{"action":"closed","number":3082,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082","id":123389677,"html_url":"https://github.com/Microsoft/ChakraCore/pull/3082","diff_url":"https://github.com/Microsoft/ChakraCore/pull/3082.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/3082.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/3082","number":3082,"state":"closed","locked":false,"title":"Check return value for GetModuleFileName","user":{"login":"xiaoyinl","id":16713498,"avatar_url":"https://avatars0.githubusercontent.com/u/16713498?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyinl","html_url":"https://github.com/xiaoyinl","followers_url":"https://api.github.com/users/xiaoyinl/followers","following_url":"https://api.github.com/users/xiaoyinl/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyinl/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyinl/subscriptions","organizations_url":"https://api.github.com/users/xiaoyinl/orgs","repos_url":"https://api.github.com/users/xiaoyinl/repos","events_url":"https://api.github.com/users/xiaoyinl/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyinl/received_events","type":"User","site_admin":false},"body":"This is a recreated pull request of PR #2757, as I messed up the commits there.\r\n\r\nThis patch checks the return values of calls to GetModuleFileName in ConfigParser.cpp. I am not so sure about how to test this. I saw most test cases in the `test` folder are js files, but this change is not related with JavaScript functionality.","created_at":"2017-05-31T23:17:34Z","updated_at":"2017-06-19T18:14:47Z","closed_at":"2017-06-19T18:14:47Z","merged_at":null,"merge_commit_sha":"dd8655ce81ef39005c83e158c1ca04c2ec2c3bdf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"boingoing","id":1569843,"avatar_url":"https://avatars0.githubusercontent.com/u/1569843?v=3","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},{"login":"suwc","id":9597888,"avatar_url":"https://avatars0.githubusercontent.com/u/9597888?v=3","gravatar_id":"","url":"https://api.github.com/users/suwc","html_url":"https://github.com/suwc","followers_url":"https://api.github.com/users/suwc/followers","following_url":"https://api.github.com/users/suwc/following{/other_user}","gists_url":"https://api.github.com/users/suwc/gists{/gist_id}","starred_url":"https://api.github.com/users/suwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suwc/subscriptions","organizations_url":"https://api.github.com/users/suwc/orgs","repos_url":"https://api.github.com/users/suwc/repos","events_url":"https://api.github.com/users/suwc/events{/privacy}","received_events_url":"https://api.github.com/users/suwc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/3082/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/6add6882aaa06be39e15d81ef7a9c1f171a169ce","head":{"label":"xiaoyinl:modulefilename","ref":"modulefilename","sha":"6add6882aaa06be39e15d81ef7a9c1f171a169ce","user":{"login":"xiaoyinl","id":16713498,"avatar_url":"https://avatars0.githubusercontent.com/u/16713498?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyinl","html_url":"https://github.com/xiaoyinl","followers_url":"https://api.github.com/users/xiaoyinl/followers","following_url":"https://api.github.com/users/xiaoyinl/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyinl/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyinl/subscriptions","organizations_url":"https://api.github.com/users/xiaoyinl/orgs","repos_url":"https://api.github.com/users/xiaoyinl/repos","events_url":"https://api.github.com/users/xiaoyinl/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyinl/received_events","type":"User","site_admin":false},"repo":{"id":67168704,"name":"ChakraCore","full_name":"xiaoyinl/ChakraCore","owner":{"login":"xiaoyinl","id":16713498,"avatar_url":"https://avatars0.githubusercontent.com/u/16713498?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyinl","html_url":"https://github.com/xiaoyinl","followers_url":"https://api.github.com/users/xiaoyinl/followers","following_url":"https://api.github.com/users/xiaoyinl/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyinl/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyinl/subscriptions","organizations_url":"https://api.github.com/users/xiaoyinl/orgs","repos_url":"https://api.github.com/users/xiaoyinl/repos","events_url":"https://api.github.com/users/xiaoyinl/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyinl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiaoyinl/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/xiaoyinl/ChakraCore","forks_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/forks","keys_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/teams","hooks_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/events","assignees_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/tags","blobs_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/subscription","commits_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/merges","archive_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/downloads","issues_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/xiaoyinl/ChakraCore/deployments","created_at":"2016-09-01T21:48:12Z","updated_at":"2016-09-01T21:48:33Z","pushed_at":"2017-06-19T02:35:08Z","git_url":"git://github.com/xiaoyinl/ChakraCore.git","ssh_url":"git@github.com:xiaoyinl/ChakraCore.git","clone_url":"https://github.com/xiaoyinl/ChakraCore.git","svn_url":"https://github.com/xiaoyinl/ChakraCore","homepage":null,"size":67947,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4bf0562cebc444bd77d7d798755649247c1cfe00","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2017-06-19T15:22:39Z","pushed_at":"2017-06-19T17:56:57Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":70686,"stargazers_count":6252,"watchers_count":6252,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":294,"forks":744,"open_issues":294,"watchers":6252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/3082"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/3082"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/3082/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/3082/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/6add6882aaa06be39e15d81ef7a9c1f171a169ce"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":9,"review_comments":4,"maintainer_can_modify":false,"commits":5,"additions":30,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"obastemur"}}