{"action":"closed","number":3113,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113","id":106966642,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3113","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3113.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3113.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3113","number":3113,"state":"closed","locked":false,"title":"Update template to make all deployment happen in template not in azure CLI","user":{"login":"ostclilideng","id":24581811,"avatar_url":"https://avatars2.githubusercontent.com/u/24581811?v=3","gravatar_id":"","url":"https://api.github.com/users/ostclilideng","html_url":"https://github.com/ostclilideng","followers_url":"https://api.github.com/users/ostclilideng/followers","following_url":"https://api.github.com/users/ostclilideng/following{/other_user}","gists_url":"https://api.github.com/users/ostclilideng/gists{/gist_id}","starred_url":"https://api.github.com/users/ostclilideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostclilideng/subscriptions","organizations_url":"https://api.github.com/users/ostclilideng/orgs","repos_url":"https://api.github.com/users/ostclilideng/repos","events_url":"https://api.github.com/users/ostclilideng/events{/privacy}","received_events_url":"https://api.github.com/users/ostclilideng/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n* Not use azure CLI in script\r\n* Deploy backend vms and route table in template\r\n* All deployment time cost 5 mins instead of 30 mins which use previous solution\r\n\r\n","created_at":"2017-02-20T09:24:40Z","updated_at":"2017-03-09T23:58:03Z","closed_at":"2017-03-09T23:58:03Z","merged_at":"2017-03-09T23:58:03Z","merge_commit_sha":"a1ef2a1f100053014739f6c522417c3dbef52b1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3113/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/fb0abb4cff408979180e40de1345eb09c32b2a25","head":{"label":"ostclilideng:master","ref":"master","sha":"fb0abb4cff408979180e40de1345eb09c32b2a25","user":{"login":"ostclilideng","id":24581811,"avatar_url":"https://avatars2.githubusercontent.com/u/24581811?v=3","gravatar_id":"","url":"https://api.github.com/users/ostclilideng","html_url":"https://github.com/ostclilideng","followers_url":"https://api.github.com/users/ostclilideng/followers","following_url":"https://api.github.com/users/ostclilideng/following{/other_user}","gists_url":"https://api.github.com/users/ostclilideng/gists{/gist_id}","starred_url":"https://api.github.com/users/ostclilideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostclilideng/subscriptions","organizations_url":"https://api.github.com/users/ostclilideng/orgs","repos_url":"https://api.github.com/users/ostclilideng/repos","events_url":"https://api.github.com/users/ostclilideng/events{/privacy}","received_events_url":"https://api.github.com/users/ostclilideng/received_events","type":"User","site_admin":false},"repo":{"id":82253741,"name":"azure-quickstart-templates","full_name":"ostclilideng/azure-quickstart-templates","owner":{"login":"ostclilideng","id":24581811,"avatar_url":"https://avatars2.githubusercontent.com/u/24581811?v=3","gravatar_id":"","url":"https://api.github.com/users/ostclilideng","html_url":"https://github.com/ostclilideng","followers_url":"https://api.github.com/users/ostclilideng/followers","following_url":"https://api.github.com/users/ostclilideng/following{/other_user}","gists_url":"https://api.github.com/users/ostclilideng/gists{/gist_id}","starred_url":"https://api.github.com/users/ostclilideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostclilideng/subscriptions","organizations_url":"https://api.github.com/users/ostclilideng/orgs","repos_url":"https://api.github.com/users/ostclilideng/repos","events_url":"https://api.github.com/users/ostclilideng/events{/privacy}","received_events_url":"https://api.github.com/users/ostclilideng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ostclilideng/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates","forks_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/ostclilideng/azure-quickstart-templates/deployments","created_at":"2017-02-17T03:36:30Z","updated_at":"2017-02-17T03:36:38Z","pushed_at":"2017-02-20T09:20:31Z","git_url":"git://github.com/ostclilideng/azure-quickstart-templates.git","ssh_url":"git@github.com:ostclilideng/azure-quickstart-templates.git","clone_url":"https://github.com/ostclilideng/azure-quickstart-templates.git","svn_url":"https://github.com/ostclilideng/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":180585,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fcfa0da961bf3c4730010e195f341c644f054f93","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-03-09T19:37:11Z","pushed_at":"2017-03-09T23:58:03Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":189393,"stargazers_count":2014,"watchers_count":2014,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2859,"mirror_url":null,"open_issues_count":274,"forks":2859,"open_issues":274,"watchers":2014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3113"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3113"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3113/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3113/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/fb0abb4cff408979180e40de1345eb09c32b2a25"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gatneil","id":1448593,"avatar_url":"https://avatars0.githubusercontent.com/u/1448593?v=3","gravatar_id":"","url":"https://api.github.com/users/gatneil","html_url":"https://github.com/gatneil","followers_url":"https://api.github.com/users/gatneil/followers","following_url":"https://api.github.com/users/gatneil/following{/other_user}","gists_url":"https://api.github.com/users/gatneil/gists{/gist_id}","starred_url":"https://api.github.com/users/gatneil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatneil/subscriptions","organizations_url":"https://api.github.com/users/gatneil/orgs","repos_url":"https://api.github.com/users/gatneil/repos","events_url":"https://api.github.com/users/gatneil/events{/privacy}","received_events_url":"https://api.github.com/users/gatneil/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":332,"deletions":246,"changed_files":8}}
{"actor":{"display_login":"gatneil"}}