{"action":"closed","number":305,"pull_request":{"url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305","id":136300015,"html_url":"https://github.com/rebase-helper/rebase-helper/pull/305","diff_url":"https://github.com/rebase-helper/rebase-helper/pull/305.diff","patch_url":"https://github.com/rebase-helper/rebase-helper/pull/305.patch","issue_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/305","number":305,"state":"closed","locked":false,"title":"Using rebase-helper Dockerfile.","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars2.githubusercontent.com/u/121989?v=4","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"body":"I want to improve current `Makefile.docker` test task with creating `rebase-helper`'s Dockerfile.\r\nThe current code looks a little bit hard to manage.\r\n\r\n```\r\n      git archive HEAD | $(DOCKER) run \\\r\n              --cap-add=SYS_ADMIN --rm -i -v /build -w /build -e PY_COLORS=1 \\\r\n              -e TOXENV=\"$(TOXENV)\" -e PYTEST_ADDOPTS=\"$(PYTEST_ADDOPTS)\" $(IMAGE) \\\r\n              /bin/sh -c 'dnf -y install tar && tar -x && dnf -y upgrade openssl-libs && dnf -y install yum && dnf -y install $$(cat test-deps-fedora.txt) && tox'\r\n```\r\n\r\nThe merits are \r\n\r\n- We can manage the logic such as `dnf install something ..` in the `Dockerfile`.\r\n  We may be able to manage `test-deps-fedora.txt`'s content in the `Dockerfile` removing the `test-deps-fedora.txt` file.\r\n- Users can test on their local by using `rebase-helper`'s docker image.\r\n- We can manage simple `Makefile.docker`.\r\n\r\nThis PR is inspired by https://github.com/rpm-software-management/rpm/blob/master/ci/Dockerfile .\r\nOther configurations in the file may inspires us.\r\n","created_at":"2017-08-17T16:29:20Z","updated_at":"2017-08-23T07:05:37Z","closed_at":"2017-08-23T07:05:37Z","merged_at":"2017-08-23T07:05:36Z","merge_commit_sha":"a9a094baf3b308790ad4d9d61fb9b709baa9e906","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305/commits","review_comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305/comments","review_comment_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/305/comments","statuses_url":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/7e59a0a7e0c550b633009dd2a8132c14400914f0","head":{"label":"junaruga:feature/add-dockerfile","ref":"feature/add-dockerfile","sha":"7e59a0a7e0c550b633009dd2a8132c14400914f0","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars2.githubusercontent.com/u/121989?v=4","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"repo":{"id":95892759,"name":"rebase-helper","full_name":"junaruga/rebase-helper","owner":{"login":"junaruga","id":121989,"avatar_url":"https://avatars2.githubusercontent.com/u/121989?v=4","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junaruga/rebase-helper","description":"This tool helps you to rebase your package to the latest version","fork":true,"url":"https://api.github.com/repos/junaruga/rebase-helper","forks_url":"https://api.github.com/repos/junaruga/rebase-helper/forks","keys_url":"https://api.github.com/repos/junaruga/rebase-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junaruga/rebase-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junaruga/rebase-helper/teams","hooks_url":"https://api.github.com/repos/junaruga/rebase-helper/hooks","issue_events_url":"https://api.github.com/repos/junaruga/rebase-helper/issues/events{/number}","events_url":"https://api.github.com/repos/junaruga/rebase-helper/events","assignees_url":"https://api.github.com/repos/junaruga/rebase-helper/assignees{/user}","branches_url":"https://api.github.com/repos/junaruga/rebase-helper/branches{/branch}","tags_url":"https://api.github.com/repos/junaruga/rebase-helper/tags","blobs_url":"https://api.github.com/repos/junaruga/rebase-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junaruga/rebase-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junaruga/rebase-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/junaruga/rebase-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junaruga/rebase-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/junaruga/rebase-helper/languages","stargazers_url":"https://api.github.com/repos/junaruga/rebase-helper/stargazers","contributors_url":"https://api.github.com/repos/junaruga/rebase-helper/contributors","subscribers_url":"https://api.github.com/repos/junaruga/rebase-helper/subscribers","subscription_url":"https://api.github.com/repos/junaruga/rebase-helper/subscription","commits_url":"https://api.github.com/repos/junaruga/rebase-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/junaruga/rebase-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/junaruga/rebase-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/junaruga/rebase-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/junaruga/rebase-helper/contents/{+path}","compare_url":"https://api.github.com/repos/junaruga/rebase-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junaruga/rebase-helper/merges","archive_url":"https://api.github.com/repos/junaruga/rebase-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junaruga/rebase-helper/downloads","issues_url":"https://api.github.com/repos/junaruga/rebase-helper/issues{/number}","pulls_url":"https://api.github.com/repos/junaruga/rebase-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/junaruga/rebase-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/junaruga/rebase-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junaruga/rebase-helper/labels{/name}","releases_url":"https://api.github.com/repos/junaruga/rebase-helper/releases{/id}","deployments_url":"https://api.github.com/repos/junaruga/rebase-helper/deployments","created_at":"2017-06-30T13:50:46Z","updated_at":"2017-06-30T13:50:48Z","pushed_at":"2017-08-22T14:16:15Z","git_url":"git://github.com/junaruga/rebase-helper.git","ssh_url":"git@github.com:junaruga/rebase-helper.git","clone_url":"https://github.com/junaruga/rebase-helper.git","svn_url":"https://github.com/junaruga/rebase-helper","homepage":"https://rebase-helper.readthedocs.io/","size":1606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rebase-helper:master","ref":"master","sha":"a6d74b6764fdd4394ce941b2c83613773ee39813","user":{"login":"rebase-helper","id":20593189,"avatar_url":"https://avatars3.githubusercontent.com/u/20593189?v=4","gravatar_id":"","url":"https://api.github.com/users/rebase-helper","html_url":"https://github.com/rebase-helper","followers_url":"https://api.github.com/users/rebase-helper/followers","following_url":"https://api.github.com/users/rebase-helper/following{/other_user}","gists_url":"https://api.github.com/users/rebase-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/rebase-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebase-helper/subscriptions","organizations_url":"https://api.github.com/users/rebase-helper/orgs","repos_url":"https://api.github.com/users/rebase-helper/repos","events_url":"https://api.github.com/users/rebase-helper/events{/privacy}","received_events_url":"https://api.github.com/users/rebase-helper/received_events","type":"Organization","site_admin":false},"repo":{"id":12696975,"name":"rebase-helper","full_name":"rebase-helper/rebase-helper","owner":{"login":"rebase-helper","id":20593189,"avatar_url":"https://avatars3.githubusercontent.com/u/20593189?v=4","gravatar_id":"","url":"https://api.github.com/users/rebase-helper","html_url":"https://github.com/rebase-helper","followers_url":"https://api.github.com/users/rebase-helper/followers","following_url":"https://api.github.com/users/rebase-helper/following{/other_user}","gists_url":"https://api.github.com/users/rebase-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/rebase-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebase-helper/subscriptions","organizations_url":"https://api.github.com/users/rebase-helper/orgs","repos_url":"https://api.github.com/users/rebase-helper/repos","events_url":"https://api.github.com/users/rebase-helper/events{/privacy}","received_events_url":"https://api.github.com/users/rebase-helper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rebase-helper/rebase-helper","description":"This tool helps you to rebase your package to the latest version","fork":false,"url":"https://api.github.com/repos/rebase-helper/rebase-helper","forks_url":"https://api.github.com/repos/rebase-helper/rebase-helper/forks","keys_url":"https://api.github.com/repos/rebase-helper/rebase-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebase-helper/rebase-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebase-helper/rebase-helper/teams","hooks_url":"https://api.github.com/repos/rebase-helper/rebase-helper/hooks","issue_events_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/events{/number}","events_url":"https://api.github.com/repos/rebase-helper/rebase-helper/events","assignees_url":"https://api.github.com/repos/rebase-helper/rebase-helper/assignees{/user}","branches_url":"https://api.github.com/repos/rebase-helper/rebase-helper/branches{/branch}","tags_url":"https://api.github.com/repos/rebase-helper/rebase-helper/tags","blobs_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/rebase-helper/rebase-helper/languages","stargazers_url":"https://api.github.com/repos/rebase-helper/rebase-helper/stargazers","contributors_url":"https://api.github.com/repos/rebase-helper/rebase-helper/contributors","subscribers_url":"https://api.github.com/repos/rebase-helper/rebase-helper/subscribers","subscription_url":"https://api.github.com/repos/rebase-helper/rebase-helper/subscription","commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/rebase-helper/rebase-helper/contents/{+path}","compare_url":"https://api.github.com/repos/rebase-helper/rebase-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebase-helper/rebase-helper/merges","archive_url":"https://api.github.com/repos/rebase-helper/rebase-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebase-helper/rebase-helper/downloads","issues_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues{/number}","pulls_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/rebase-helper/rebase-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/rebase-helper/rebase-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebase-helper/rebase-helper/labels{/name}","releases_url":"https://api.github.com/repos/rebase-helper/rebase-helper/releases{/id}","deployments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/deployments","created_at":"2013-09-09T08:48:30Z","updated_at":"2017-08-01T06:31:54Z","pushed_at":"2017-08-23T07:05:36Z","git_url":"git://github.com/rebase-helper/rebase-helper.git","ssh_url":"git@github.com:rebase-helper/rebase-helper.git","clone_url":"https://github.com/rebase-helper/rebase-helper.git","svn_url":"https://github.com/rebase-helper/rebase-helper","homepage":"https://rebase-helper.readthedocs.io/","size":1616,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":35,"forks":13,"open_issues":35,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305"},"html":{"href":"https://github.com/rebase-helper/rebase-helper/pull/305"},"issue":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/305"},"comments":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/7e59a0a7e0c550b633009dd2a8132c14400914f0"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nforro","id":14923067,"avatar_url":"https://avatars3.githubusercontent.com/u/14923067?v=4","gravatar_id":"","url":"https://api.github.com/users/nforro","html_url":"https://github.com/nforro","followers_url":"https://api.github.com/users/nforro/followers","following_url":"https://api.github.com/users/nforro/following{/other_user}","gists_url":"https://api.github.com/users/nforro/gists{/gist_id}","starred_url":"https://api.github.com/users/nforro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nforro/subscriptions","organizations_url":"https://api.github.com/users/nforro/orgs","repos_url":"https://api.github.com/users/nforro/repos","events_url":"https://api.github.com/users/nforro/events{/privacy}","received_events_url":"https://api.github.com/users/nforro/received_events","type":"User","site_admin":false},"comments":35,"review_comments":23,"maintainer_can_modify":false,"commits":3,"additions":63,"deletions":31,"changed_files":4}}
{"actor":{"display_login":"nforro"}}