{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/121281083","pull_request_review_id":43318972,"id":121281083,"diff_hunk":"@@ -0,0 +1,47 @@\n+using System;\n+using System.Threading;\n+using System.Threading.Tasks;\n+\n+namespace NHibernate.Util\n+{\n+\tpublic class AsyncLock\n+\t{\n+\t\tprivate readonly AsyncSemaphore semaphore;\n+\t\tprivate readonly Task<Releaser> releaser;","path":"src/NHibernate/Util/AsyncLock.cs","position":10,"original_position":10,"commit_id":"b07c53594eb82546dc1945cf904b6b30cdff5232","original_commit_id":"b07c53594eb82546dc1945cf904b6b30cdff5232","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars1.githubusercontent.com/u/12201973?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"New code should follow the \"underscore camelCase\" convention. (NHibernate has lot of \"camelCase only\" private members due to ports from Java having forgotten to rename them, but we should avoid adding more.)\r\n`_semaphore`, `_releaser`. ","created_at":"2017-06-11T13:02:31Z","updated_at":"2017-06-11T13:53:38Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/588#discussion_r121281083","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/121281083"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/588#discussion_r121281083"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588","id":113571299,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/588","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/588.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/588.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/588","number":588,"state":"open","locked":false,"title":"[WIP] Async generator","user":{"login":"hazzik","id":144791,"avatar_url":"https://avatars2.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"body":"Some things left on the NHibernate side:\r\n\r\n- [x] We need to define how the cancellation token parameter will be generated ([current proposal](https://github.com/maca88/AsyncGenerator/pull/11))\r\n- [x] Some warnings are produced because of the `<include />` tag ([example](https://github.com/nhibernate/nhibernate-core/blob/7ba52d2a6a4e2ea702c329470a27444bcbdb2466/src/NHibernate/Type/IType.cs#L16)), why not use `<inheritdoc />` tag instead?\r\n- [ ] Create a tool for generating the code (what options should the tool have?)\r\n- [x] Add missing `ConfigureAwait(false)` for the manually written code\r\n- [ ] Replace `[ThreadStatic]` with `AsyncLocal<>` on the `SessionIdLoggingContext`\r\n- [ ] Add missing `CancellationToken` parameters to manually written async methods (linq extensions and future)\r\n- [ ] Fix broken tests for Firebird\r\n- [ ] Fix broken tests for Oracle\r\n- [ ] Fix broken tests for PostgreSQL (There is a weird way to make a test for a known bug)\r\n- [ ] Fix broken tests for SqlServer 2012 ([NH-4022](https://nhibernate.jira.com/browse/NH-4022))\r\n- [ ] Fix broken tests for MySQL","created_at":"2017-03-31T04:09:54Z","updated_at":"2017-06-11T13:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c63c960ec6683319d651f849110270a574e84da","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/588/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/b07c53594eb82546dc1945cf904b6b30cdff5232","head":{"label":"hazzik:AsyncGenerator","ref":"AsyncGenerator","sha":"b07c53594eb82546dc1945cf904b6b30cdff5232","user":{"login":"hazzik","id":144791,"avatar_url":"https://avatars2.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"repo":{"id":3009271,"name":"nhibernate-core","full_name":"hazzik/nhibernate-core","owner":{"login":"hazzik","id":144791,"avatar_url":"https://avatars2.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hazzik/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/hazzik/nhibernate-core","forks_url":"https://api.github.com/repos/hazzik/nhibernate-core/forks","keys_url":"https://api.github.com/repos/hazzik/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazzik/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazzik/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/hazzik/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/hazzik/nhibernate-core/events","assignees_url":"https://api.github.com/repos/hazzik/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/hazzik/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazzik/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hazzik/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/hazzik/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/hazzik/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazzik/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazzik/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/hazzik/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazzik/nhibernate-core/merges","archive_url":"https://api.github.com/repos/hazzik/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazzik/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/hazzik/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hazzik/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hazzik/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazzik/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/hazzik/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/hazzik/nhibernate-core/deployments","created_at":"2011-12-19T02:04:00Z","updated_at":"2017-05-16T06:34:30Z","pushed_at":"2017-06-11T11:40:08Z","git_url":"git://github.com/hazzik/nhibernate-core.git","ssh_url":"git@github.com:hazzik/nhibernate-core.git","clone_url":"https://github.com/hazzik/nhibernate-core.git","svn_url":"https://github.com/hazzik/nhibernate-core","homepage":"http://nhforge.org/","size":80626,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"ad4c2ef101cbf8ba798220973f4f78dd795e0896","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars0.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars0.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2017-06-11T12:14:05Z","pushed_at":"2017-06-11T11:40:11Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":77528,"stargazers_count":1129,"watchers_count":1129,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":690,"mirror_url":null,"open_issues_count":70,"forks":690,"open_issues":70,"watchers":1129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/588"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/588"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/b07c53594eb82546dc1945cf904b6b30cdff5232"}}}}
{"actor":{"display_login":"fredericDelaporte"}}