{"action":"created","comment":{"url":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments/136767478","pull_request_review_id":60346277,"id":136767478,"diff_hunk":"@@ -237,7 +237,29 @@ public function assignRemoteToLocalCategoryAction()\n         }\n \n         try {\n-            $this->getImportService()->importRemoteCategory($localCategoryId, $remoteCategoryKey, $remoteCategoryLabel);\n+            $categories = $this->getImportService()->createCategoriesFromRemoteCategoires($localCategoryId, $remoteCategoryKey, $remoteCategoryLabel);","path":"Controllers/Backend/Import.php","position":5,"original_position":5,"commit_id":"de5561fb510e75a246ba69e9a5d3a544a77ba163","original_commit_id":"de5561fb510e75a246ba69e9a5d3a544a77ba163","user":{"login":"sbofirov","id":1742744,"avatar_url":"https://avatars3.githubusercontent.com/u/1742744?v=4","gravatar_id":"","url":"https://api.github.com/users/sbofirov","html_url":"https://github.com/sbofirov","followers_url":"https://api.github.com/users/sbofirov/followers","following_url":"https://api.github.com/users/sbofirov/following{/other_user}","gists_url":"https://api.github.com/users/sbofirov/gists{/gist_id}","starred_url":"https://api.github.com/users/sbofirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbofirov/subscriptions","organizations_url":"https://api.github.com/users/sbofirov/orgs","repos_url":"https://api.github.com/users/sbofirov/repos","events_url":"https://api.github.com/users/sbofirov/events{/privacy}","received_events_url":"https://api.github.com/users/sbofirov/received_events","type":"User","site_admin":false},"body":"In the past ```$this->getImportService()->importRemoteCategory($localCategoryId, $remoteCategoryKey, $remoteCategoryLabel);``` was called to create necessary entities and store them into DB.\r\n\r\nNow ```createCategoriesFromRemoteCategoires``` will generate categoryTree and extract category keys  ```return $this->autoCategoryResolver->convertTreeToKeys($remoteCategoryNodes, $localCategory);```. Then this action returns response success true, but categories are not imported.","created_at":"2017-09-04T08:25:20Z","updated_at":"2017-09-04T08:38:22Z","html_url":"https://github.com/shopware/SwagConnect/pull/371#discussion_r136767478","pull_request_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/371","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments/136767478"},"html":{"href":"https://github.com/shopware/SwagConnect/pull/371#discussion_r136767478"},"pull_request":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/shopware/SwagConnect/pulls/371","id":138664418,"html_url":"https://github.com/shopware/SwagConnect/pull/371","diff_url":"https://github.com/shopware/SwagConnect/pull/371.diff","patch_url":"https://github.com/shopware/SwagConnect/pull/371.patch","issue_url":"https://api.github.com/repos/shopware/SwagConnect/issues/371","number":371,"state":"open","locked":false,"title":"[CON-4815] Replace Doctrine with more performant services","user":{"login":"svenfinke","id":564499,"avatar_url":"https://avatars1.githubusercontent.com/u/564499?v=4","gravatar_id":"","url":"https://api.github.com/users/svenfinke","html_url":"https://github.com/svenfinke","followers_url":"https://api.github.com/users/svenfinke/followers","following_url":"https://api.github.com/users/svenfinke/following{/other_user}","gists_url":"https://api.github.com/users/svenfinke/gists{/gist_id}","starred_url":"https://api.github.com/users/svenfinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenfinke/subscriptions","organizations_url":"https://api.github.com/users/svenfinke/orgs","repos_url":"https://api.github.com/users/svenfinke/repos","events_url":"https://api.github.com/users/svenfinke/events{/privacy}","received_events_url":"https://api.github.com/users/svenfinke/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-31T13:18:03Z","updated_at":"2017-09-04T08:38:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a729dab6a12f4b9ab72eb8096d7169cce330ca3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dbeier","id":10957292,"avatar_url":"https://avatars2.githubusercontent.com/u/10957292?v=4","gravatar_id":"","url":"https://api.github.com/users/dbeier","html_url":"https://github.com/dbeier","followers_url":"https://api.github.com/users/dbeier/followers","following_url":"https://api.github.com/users/dbeier/following{/other_user}","gists_url":"https://api.github.com/users/dbeier/gists{/gist_id}","starred_url":"https://api.github.com/users/dbeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbeier/subscriptions","organizations_url":"https://api.github.com/users/dbeier/orgs","repos_url":"https://api.github.com/users/dbeier/repos","events_url":"https://api.github.com/users/dbeier/events{/privacy}","received_events_url":"https://api.github.com/users/dbeier/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/371/commits","review_comments_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/371/comments","review_comment_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/issues/371/comments","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/de5561fb510e75a246ba69e9a5d3a544a77ba163","head":{"label":"shopware:CON-4815","ref":"CON-4815","sha":"de5561fb510e75a246ba69e9a5d3a544a77ba163","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":26867190,"name":"SwagConnect","full_name":"shopware/SwagConnect","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/SwagConnect","description":null,"fork":false,"url":"https://api.github.com/repos/shopware/SwagConnect","forks_url":"https://api.github.com/repos/shopware/SwagConnect/forks","keys_url":"https://api.github.com/repos/shopware/SwagConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/SwagConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/SwagConnect/teams","hooks_url":"https://api.github.com/repos/shopware/SwagConnect/hooks","issue_events_url":"https://api.github.com/repos/shopware/SwagConnect/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/SwagConnect/events","assignees_url":"https://api.github.com/repos/shopware/SwagConnect/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/SwagConnect/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/SwagConnect/tags","blobs_url":"https://api.github.com/repos/shopware/SwagConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/SwagConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/SwagConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/SwagConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/SwagConnect/languages","stargazers_url":"https://api.github.com/repos/shopware/SwagConnect/stargazers","contributors_url":"https://api.github.com/repos/shopware/SwagConnect/contributors","subscribers_url":"https://api.github.com/repos/shopware/SwagConnect/subscribers","subscription_url":"https://api.github.com/repos/shopware/SwagConnect/subscription","commits_url":"https://api.github.com/repos/shopware/SwagConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/SwagConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/SwagConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/SwagConnect/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/SwagConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/SwagConnect/merges","archive_url":"https://api.github.com/repos/shopware/SwagConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/SwagConnect/downloads","issues_url":"https://api.github.com/repos/shopware/SwagConnect/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/SwagConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/SwagConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/SwagConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/SwagConnect/labels{/name}","releases_url":"https://api.github.com/repos/shopware/SwagConnect/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/SwagConnect/deployments","created_at":"2014-11-19T15:19:16Z","updated_at":"2017-06-12T08:52:34Z","pushed_at":"2017-09-04T08:22:36Z","git_url":"git://github.com/shopware/SwagConnect.git","ssh_url":"git@github.com:shopware/SwagConnect.git","clone_url":"https://github.com/shopware/SwagConnect.git","svn_url":"https://github.com/shopware/SwagConnect","homepage":"","size":6446,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":6,"default_branch":"master"}},"base":{"label":"shopware:master","ref":"master","sha":"d140fd4c287f3e3e84c621eb2b45d986cd69c24d","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":26867190,"name":"SwagConnect","full_name":"shopware/SwagConnect","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/SwagConnect","description":null,"fork":false,"url":"https://api.github.com/repos/shopware/SwagConnect","forks_url":"https://api.github.com/repos/shopware/SwagConnect/forks","keys_url":"https://api.github.com/repos/shopware/SwagConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/SwagConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/SwagConnect/teams","hooks_url":"https://api.github.com/repos/shopware/SwagConnect/hooks","issue_events_url":"https://api.github.com/repos/shopware/SwagConnect/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/SwagConnect/events","assignees_url":"https://api.github.com/repos/shopware/SwagConnect/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/SwagConnect/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/SwagConnect/tags","blobs_url":"https://api.github.com/repos/shopware/SwagConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/SwagConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/SwagConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/SwagConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/SwagConnect/languages","stargazers_url":"https://api.github.com/repos/shopware/SwagConnect/stargazers","contributors_url":"https://api.github.com/repos/shopware/SwagConnect/contributors","subscribers_url":"https://api.github.com/repos/shopware/SwagConnect/subscribers","subscription_url":"https://api.github.com/repos/shopware/SwagConnect/subscription","commits_url":"https://api.github.com/repos/shopware/SwagConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/SwagConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/SwagConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/SwagConnect/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/SwagConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/SwagConnect/merges","archive_url":"https://api.github.com/repos/shopware/SwagConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/SwagConnect/downloads","issues_url":"https://api.github.com/repos/shopware/SwagConnect/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/SwagConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/SwagConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/SwagConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/SwagConnect/labels{/name}","releases_url":"https://api.github.com/repos/shopware/SwagConnect/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/SwagConnect/deployments","created_at":"2014-11-19T15:19:16Z","updated_at":"2017-06-12T08:52:34Z","pushed_at":"2017-09-04T08:22:36Z","git_url":"git://github.com/shopware/SwagConnect.git","ssh_url":"git@github.com:shopware/SwagConnect.git","clone_url":"https://github.com/shopware/SwagConnect.git","svn_url":"https://github.com/shopware/SwagConnect","homepage":"","size":6446,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/371"},"html":{"href":"https://github.com/shopware/SwagConnect/pull/371"},"issue":{"href":"https://api.github.com/repos/shopware/SwagConnect/issues/371"},"comments":{"href":"https://api.github.com/repos/shopware/SwagConnect/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/SwagConnect/statuses/de5561fb510e75a246ba69e9a5d3a544a77ba163"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbofirov"}}