{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/17215","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17215/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17215/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17215/events","html_url":"https://github.com/joomla/joomla-cms/pull/17215","id":244928336,"number":17215,"title":"Implementing Multilang custom admin menus","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-07-23T18:46:50Z","updated_at":"2017-07-24T14:48:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17215","html_url":"https://github.com/joomla/joomla-cms/pull/17215","diff_url":"https://github.com/joomla/joomla-cms/pull/17215.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/17215.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/17155\r\n\r\n### Summary of Changes\r\nAllow administrator menu modules to be tagged and displayed per available administrator languages.\r\nAdded Warning when no menu modules are tagged to All languages and **some administrator menu modules are missing for an administrator language** in order to not suddenly lose all admin menu modules when switching backend language. \r\nThis warning will only display when the new Menus parameter option is set to yes.\r\nAdded a new adminfilter file for modules.\r\n\r\n### Testing Instructions\r\nPatch staging.\r\nSet the new parameter in Menus Options.\r\n\r\n![screen shot 2017-07-21 at 15 05 30](https://user-images.githubusercontent.com/869724/28464561-1928a5b4-6e26-11e7-95fd-de44fd864126.png)\r\n\r\nI have created 3 custom admin menus. French, English and one for ALL\r\n\r\n![screen shot 2017-07-21 at 15 07 12](https://user-images.githubusercontent.com/869724/28464620-54641ed8-6e26-11e7-83e0-270c60ffdf14.png)\r\n\r\nI have assigned each of these menus to an admin menu module and tagged that module to an administrator language.\r\n\r\n![screen shot 2017-07-23 at 20 20 44](https://user-images.githubusercontent.com/869724/28501823-77b54ad2-6fe4-11e7-9599-1d1767ddcb55.png)\r\n\r\nTagging to a language is only possible for admin menu modules.\r\n![screen shot 2017-07-23 at 20 22 44](https://user-images.githubusercontent.com/869724/28501834-b91dacd0-6fe4-11e7-84a6-331b18a57858.png)\r\n\r\n![screen shot 2017-07-23 at 20 24 21](https://user-images.githubusercontent.com/869724/28501841-f4142a8a-6fe4-11e7-8f54-96740521f152.png)\r\n\r\nIf there are no Published menu module tagged to ALL languages and some menu modules tagged to an administrator language are missing, we get a warning. \r\nOn my site I have 6 administrator languages and only 2 have a custom admin menu (French and English).\r\n\r\nIn the modules manager page\r\n![screen shot 2017-07-23 at 20 26 45](https://user-images.githubusercontent.com/869724/28501855-50184e10-6fe5-11e7-9d68-678c79308384.png)\r\n\r\nand also in the menus/menu items manager pages\r\n![screen shot 2017-07-23 at 20 28 12](https://user-images.githubusercontent.com/869724/28501868-7e9b3770-6fe5-11e7-9314-95c4fe93b463.png)\r\n\r\nAs formerly, if any of the custom admin menus has a compulsory item missing , we get the Warning.\r\nBoth Warnings  may be combined.\r\n![screen shot 2017-07-23 at 20 30 33](https://user-images.githubusercontent.com/869724/28501887-cebf7ea0-6fe5-11e7-86f8-d99aa554c4fa.png)\r\n\r\nIf the Menus Options Filtering parameter is set to No, the language field and columns are not displayed in the modules manager.\r\n\r\n### Notes\r\nTo be sure I get the Warning, I added the code to both menus and modules controller `display()` method. A better solution is welcome.\r\n\r\nThe purpose of this patch is  to deal ONLY with administrator menu modules.\r\nIt can easily be upgraded to deal with all admin modules by modifying the conditional which is now set as a parameter in com_menus.\r\nIf set as a Global parameter, or Modules parameter, or system plugin in the future (or right now) the method  `JLanguageMultilang::isAdminEnabled()` will just have to be modified.\r\n\r\n\r\n\r\n### Documentation Changes Required\r\nComplete custom admin menus docs.\r\n\r\n\r\n@izharaazmi \r\n@RCheesley \r\nAll improvements welcome.\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/317446831","html_url":"https://github.com/joomla/joomla-cms/pull/17215#issuecomment-317446831","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17215","id":317446831,"user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"created_at":"2017-07-24T14:48:23Z","updated_at":"2017-07-24T14:48:23Z","body":"Just wondering if we even need an option. Would I r not be enough to check if the admin menu exists for the selected admin language"}}
{"actor":{"display_login":"brianteeman"}}