{"action":"created","comment":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/149384931","pull_request_review_id":74768485,"id":149384931,"diff_hunk":"@@ -77,9 +77,23 @@ namespace :bonnie do\n       measure.user_id = bonnie_user_id\n       measure_name = measure.cms_id + \".json\"\n       measure_file = File.join(fixtures_path, 'cql_measures', args[:path], measure_name)\n-      create_fixture_file(measure_file, JSON.pretty_generate(JSON.parse(measure.to_json)))\n+      # fix the measure's id so it will be imported as a BSON::ObjectId.\n+      measure_hash = JSON.parse(measure.to_json)","path":"lib/tasks/generate_cql_fixtures.rake","position":6,"original_position":6,"commit_id":"174ad20be122a604584a33c640255a26a05a4069","original_commit_id":"174ad20be122a604584a33c640255a26a05a4069","user":{"login":"jbradl11","id":1568999,"avatar_url":"https://avatars2.githubusercontent.com/u/1568999?v=4","gravatar_id":"","url":"https://api.github.com/users/jbradl11","html_url":"https://github.com/jbradl11","followers_url":"https://api.github.com/users/jbradl11/followers","following_url":"https://api.github.com/users/jbradl11/following{/other_user}","gists_url":"https://api.github.com/users/jbradl11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbradl11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbradl11/subscriptions","organizations_url":"https://api.github.com/users/jbradl11/orgs","repos_url":"https://api.github.com/users/jbradl11/repos","events_url":"https://api.github.com/users/jbradl11/events{/privacy}","received_events_url":"https://api.github.com/users/jbradl11/received_events","type":"User","site_admin":false},"body":"Do we need to include ` :max_nesting=>1000` in the JSON.parse?","created_at":"2017-11-07T14:39:13Z","updated_at":"2017-11-07T14:39:13Z","html_url":"https://github.com/projecttacoma/bonnie/pull/882#discussion_r149384931","pull_request_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/149384931"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/882#discussion_r149384931"},"pull_request":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882"}}},"pull_request":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882","id":148985163,"html_url":"https://github.com/projecttacoma/bonnie/pull/882","diff_url":"https://github.com/projecttacoma/bonnie/pull/882.diff","patch_url":"https://github.com/projecttacoma/bonnie/pull/882.patch","issue_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/882","number":882,"state":"open","locked":false,"title":"CQL Package inclusion in fixture export and loading.","user":{"login":"hossenlopp","id":11613067,"avatar_url":"https://avatars1.githubusercontent.com/u/11613067?v=4","gravatar_id":"","url":"https://api.github.com/users/hossenlopp","html_url":"https://github.com/hossenlopp","followers_url":"https://api.github.com/users/hossenlopp/followers","following_url":"https://api.github.com/users/hossenlopp/following{/other_user}","gists_url":"https://api.github.com/users/hossenlopp/gists{/gist_id}","starred_url":"https://api.github.com/users/hossenlopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hossenlopp/subscriptions","organizations_url":"https://api.github.com/users/hossenlopp/orgs","repos_url":"https://api.github.com/users/hossenlopp/repos","events_url":"https://api.github.com/users/hossenlopp/events{/privacy}","received_events_url":"https://api.github.com/users/hossenlopp/received_events","type":"User","site_admin":false},"body":"Updated CQL fixture export to better store IDs and include measure package\r\n - Now stores measure id's in the `{ $oid: '4322342' }` structure so the fixture loader loads them as ObjectIds\r\n - Stores the measure package if one exists on the measure.\r\n - Fixture loader now properly handles loading binary fields\r\n - Added CMS160v6 fixture which has a package for it with JSON ELM\r\n - Updated existing CQL fixtures to have valid ObjectIds\r\n - Updates gemfiles\r\n\r\n\r\nPull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (\"N/A\") and :white_check_mark:.\r\n\r\n**Submitter:**\r\n- [x] This pull request describes why these changes were made.\r\n- [x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1157\r\n- [x] JIRA ticket links to this PR\r\n- [ ] Code diff has been done and been reviewed (it **does not** contain: additional white space, not applicable code changes, debug statements, etc.)\r\n- [x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced. N/A\r\n- [ ] Tests are included and test edge cases: N/A (but I have tests made in another branch that use this work and very effectively test these fixtures. Code with unit tests that use the CMS160 fixture in this PR can be found in `cql4bonnie_download_package`)\r\n- [x] Tests have been run locally and pass (remember to update Gemfile when applicable)\r\n- [x] Code coverage has not gone down and all code touched or added is covered. \r\n     * See [front-end testing instructions](https://github.com/projecttacoma/bonnie/wiki/Testing#frontend-testing) for getting coverage for front-end tests\r\n     * In rare situations, this may not be possible or applicable to a PR. In those situations:\r\n         1. Note why this could not be done or is not applicable here: \r\n         2. Add TODOs in the code noting that it requires a test\r\n         3. Add a JIRA task to add the test and link it here: \r\n- [ ] Automated regression test(s) pass\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [x] JIRA test links: N/A\r\n- [x] Justification for using JIRA tests: N/A\r\n- [x] JIRA tests have been added to sprint N/A\r\n\r\n\r\n**Reviewer 1:**\r\n\r\nName: @jbradl11 \r\n- [x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [x] The tests appropriately test the new code, including edge cases\r\n- [x] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [x] JIRA tests have been run and pass - N/A\r\n- [x] You agree with the justification for use of JIRA tests or have provided input on why you disagree - N/A\r\n\r\n\r\n**Reviewer 2:**\r\n\r\nName: @c-monkey\r\n- [x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [X] The tests appropriately test the new code, including edge cases\r\n  *Note:* tested manually since this code is fixture creation code.\r\n  Inspected using mongo. The `fix_binary_data` function and changes to `generate_backend_cql_fixtures` look good.\r\n- [x] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [x] JIRA tests have been run and pass - N/A\r\n- [x] You agree with the justification for use of JIRA tests or have provided input on why you disagree - N/A\r\n","created_at":"2017-10-26T16:32:26Z","updated_at":"2017-11-07T14:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bcb9952ee2f553b59d0f7770bc03858919fe759","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882/commits","review_comments_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882/comments","review_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/882/comments","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/174ad20be122a604584a33c640255a26a05a4069","head":{"label":"projecttacoma:cql4bonnie_package_fixtures","ref":"cql4bonnie_package_fixtures","sha":"174ad20be122a604584a33c640255a26a05a4069","user":{"login":"projecttacoma","id":5497023,"avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2017-09-27T14:13:42Z","pushed_at":"2017-11-07T14:33:26Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"git@github.com:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":91279,"stargazers_count":20,"watchers_count":20,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":18,"open_issues":12,"watchers":20,"default_branch":"master"}},"base":{"label":"projecttacoma:cql4bonnie","ref":"cql4bonnie","sha":"0ed1f13f04694e66845a692bebd5b6795fb6a8ad","user":{"login":"projecttacoma","id":5497023,"avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2017-09-27T14:13:42Z","pushed_at":"2017-11-07T14:33:26Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"git@github.com:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":91279,"stargazers_count":20,"watchers_count":20,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":18,"open_issues":12,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/882"},"issue":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/882"},"comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/882/comments"},"review_comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882/comments"},"review_comment":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/882/commits"},"statuses":{"href":"https://api.github.com/repos/projecttacoma/bonnie/statuses/174ad20be122a604584a33c640255a26a05a4069"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbradl11"}}