{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments/146880715","pull_request_review_id":71888757,"id":146880715,"diff_hunk":"@@ -530,3 +531,12 @@ def process_incomplete_job(job_id):\n             process_row(row_number, recipient, personalisation, template, job, job.service)\n \n     job_complete(job, job.service, template, resumed=True)\n+\n+\n+@notify_celery.task(bind=True, name=\"process-ses-result\", max_retries=12, default_retry_delay=300000)","path":"app/celery/tasks.py","position":14,"original_position":14,"commit_id":"524f688bdd31f5a18ef3ac0324c47915c1af6558","original_commit_id":"524f688bdd31f5a18ef3ac0324c47915c1af6558","user":{"login":"richardc0","id":31849076,"avatar_url":"https://avatars3.githubusercontent.com/u/31849076?v=4","gravatar_id":"","url":"https://api.github.com/users/richardc0","html_url":"https://github.com/richardc0","followers_url":"https://api.github.com/users/richardc0/followers","following_url":"https://api.github.com/users/richardc0/following{/other_user}","gists_url":"https://api.github.com/users/richardc0/gists{/gist_id}","starred_url":"https://api.github.com/users/richardc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardc0/subscriptions","organizations_url":"https://api.github.com/users/richardc0/orgs","repos_url":"https://api.github.com/users/richardc0/repos","events_url":"https://api.github.com/users/richardc0/events{/privacy}","received_events_url":"https://api.github.com/users/richardc0/received_events","type":"User","site_admin":false},"body":"Ahh I thought it was milliseconds for some reason so I'll update 30000 to 300.\r\nSo the other is 25 mins total time which felt like it would survive a blip but not an outage, 12 is an hour which seemed like a reasonable time to get everything back up. If its longer than 60 mins we have bigger issues that delivery receipts. If we are happy with 25 mins I'll make it consistent.","created_at":"2017-10-25T14:45:22Z","updated_at":"2017-10-25T14:45:22Z","html_url":"https://github.com/alphagov/notifications-api/pull/1340#discussion_r146880715","pull_request_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments/146880715"},"html":{"href":"https://github.com/alphagov/notifications-api/pull/1340#discussion_r146880715"},"pull_request":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340"}},"in_reply_to_id":146843675},"pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340","id":148596172,"html_url":"https://github.com/alphagov/notifications-api/pull/1340","diff_url":"https://github.com/alphagov/notifications-api/pull/1340.diff","patch_url":"https://github.com/alphagov/notifications-api/pull/1340.patch","issue_url":"https://api.github.com/repos/alphagov/notifications-api/issues/1340","number":1340,"state":"open","locked":false,"title":"Add task for ses results queue","user":{"login":"richardc0","id":31849076,"avatar_url":"https://avatars3.githubusercontent.com/u/31849076?v=4","gravatar_id":"","url":"https://api.github.com/users/richardc0","html_url":"https://github.com/richardc0","followers_url":"https://api.github.com/users/richardc0/followers","following_url":"https://api.github.com/users/richardc0/following{/other_user}","gists_url":"https://api.github.com/users/richardc0/gists{/gist_id}","starred_url":"https://api.github.com/users/richardc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardc0/subscriptions","organizations_url":"https://api.github.com/users/richardc0/orgs","repos_url":"https://api.github.com/users/richardc0/repos","events_url":"https://api.github.com/users/richardc0/events{/privacy}","received_events_url":"https://api.github.com/users/richardc0/received_events","type":"User","site_admin":false},"body":"Carrying on from Sakis's PR from August https://github.com/alphagov/notifications-api/pull/1156\r\n\r\nIn preparation for moving the SNS notification to an SES queue remove the HTTP errors codes and arguments as the method will now be run by a celery task. Also made the callback http method return more generic codes as this will be removed once the SNS has been moved to use a queue. Also added a retry if process_ses_results task fails retry every 5 mins for an hour.\r\n\r\n- Updated the process_ses_results task to retry\r\n- Added tests to check for retry\r\n- Removed errors and arguments returned from process_ses_response\r\n- Updated tests","created_at":"2017-10-25T08:04:40Z","updated_at":"2017-10-25T14:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e0bc903fa8a7b7613ff9d9a15db3d3bfe3c29b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340/commits","review_comments_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340/comments","review_comment_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/issues/1340/comments","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/524f688bdd31f5a18ef3ac0324c47915c1af6558","head":{"label":"alphagov:add-task-for-ses-results-queue","ref":"add-task-for-ses-results-queue","sha":"524f688bdd31f5a18ef3ac0324c47915c1af6558","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46422101,"name":"notifications-api","full_name":"alphagov/notifications-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-api","description":"Notifications api","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-api","forks_url":"https://api.github.com/repos/alphagov/notifications-api/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-api/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-api/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-api/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-api/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-api/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-api/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-api/deployments","created_at":"2015-11-18T13:57:17Z","updated_at":"2017-05-24T16:00:23Z","pushed_at":"2017-10-25T14:41:39Z","git_url":"git://github.com/alphagov/notifications-api.git","ssh_url":"git@github.com:alphagov/notifications-api.git","clone_url":"https://github.com/alphagov/notifications-api.git","svn_url":"https://github.com/alphagov/notifications-api","homepage":null,"size":14679,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"adfc3b0801c259494d2348e89ca59783f5bd8058","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46422101,"name":"notifications-api","full_name":"alphagov/notifications-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-api","description":"Notifications api","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-api","forks_url":"https://api.github.com/repos/alphagov/notifications-api/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-api/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-api/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-api/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-api/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-api/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-api/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-api/deployments","created_at":"2015-11-18T13:57:17Z","updated_at":"2017-05-24T16:00:23Z","pushed_at":"2017-10-25T14:41:39Z","git_url":"git://github.com/alphagov/notifications-api.git","ssh_url":"git@github.com:alphagov/notifications-api.git","clone_url":"https://github.com/alphagov/notifications-api.git","svn_url":"https://github.com/alphagov/notifications-api","homepage":null,"size":14679,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340"},"html":{"href":"https://github.com/alphagov/notifications-api/pull/1340"},"issue":{"href":"https://api.github.com/repos/alphagov/notifications-api/issues/1340"},"comments":{"href":"https://api.github.com/repos/alphagov/notifications-api/issues/1340/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1340/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/notifications-api/statuses/524f688bdd31f5a18ef3ac0324c47915c1af6558"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"richardc0"}}