{"action":"created","issue":{"url":"https://api.github.com/repos/doriordan/skuber/issues/51","repository_url":"https://api.github.com/repos/doriordan/skuber","labels_url":"https://api.github.com/repos/doriordan/skuber/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/doriordan/skuber/issues/51/comments","events_url":"https://api.github.com/repos/doriordan/skuber/issues/51/events","html_url":"https://github.com/doriordan/skuber/pull/51","id":226401111,"number":51,"title":"expose methods to pass in own client","user":{"login":"from-nibly","id":3860803,"avatar_url":"https://avatars0.githubusercontent.com/u/3860803?v=3","gravatar_id":"","url":"https://api.github.com/users/from-nibly","html_url":"https://github.com/from-nibly","followers_url":"https://api.github.com/users/from-nibly/followers","following_url":"https://api.github.com/users/from-nibly/following{/other_user}","gists_url":"https://api.github.com/users/from-nibly/gists{/gist_id}","starred_url":"https://api.github.com/users/from-nibly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/from-nibly/subscriptions","organizations_url":"https://api.github.com/users/from-nibly/orgs","repos_url":"https://api.github.com/users/from-nibly/repos","events_url":"https://api.github.com/users/from-nibly/events{/privacy}","received_events_url":"https://api.github.com/users/from-nibly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-04T20:36:53Z","updated_at":"2017-05-10T17:43:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/doriordan/skuber/pulls/51","html_url":"https://github.com/doriordan/skuber/pull/51","diff_url":"https://github.com/doriordan/skuber/pull/51.diff","patch_url":"https://github.com/doriordan/skuber/pull/51.patch"},"body":"Currently while using skuber we have a massive thread leak that results from us having 100s of namespaces. Currently skuber creates a new http client for each namespaced client that is created. We would like to intern our clients and only create one per cluster we are pointing to. Then just pass in that same client every time we create a new skuber client.\r\n\r\n@doriordan What are your thoughts on this?"},"comment":{"url":"https://api.github.com/repos/doriordan/skuber/issues/comments/300559687","html_url":"https://github.com/doriordan/skuber/pull/51#issuecomment-300559687","issue_url":"https://api.github.com/repos/doriordan/skuber/issues/51","id":300559687,"user":{"login":"doriordan","id":1973455,"avatar_url":"https://avatars0.githubusercontent.com/u/1973455?v=3","gravatar_id":"","url":"https://api.github.com/users/doriordan","html_url":"https://github.com/doriordan","followers_url":"https://api.github.com/users/doriordan/followers","following_url":"https://api.github.com/users/doriordan/following{/other_user}","gists_url":"https://api.github.com/users/doriordan/gists{/gist_id}","starred_url":"https://api.github.com/users/doriordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doriordan/subscriptions","organizations_url":"https://api.github.com/users/doriordan/orgs","repos_url":"https://api.github.com/users/doriordan/repos","events_url":"https://api.github.com/users/doriordan/events{/privacy}","received_events_url":"https://api.github.com/users/doriordan/received_events","type":"User","site_admin":false},"created_at":"2017-05-10T17:43:33Z","updated_at":"2017-05-10T17:43:33Z","body":"I agree the current API is limiting and should support operations on different namespaces without necessairly needing a new http client for each one. Its something I have considered addressing before but was never a high priority but I'd like to .\r\nRe. the proposed changes - I'd prefer an approach that didn't expose the underlying Ning client in the public API as that feels like a leaky abstraction, and if skuber moves to future versions of PlayN that Ning client might not be supported as it is essentially a Play WS implementation detail.\r\nI did consider in the past some lightweight means of dynamically switching namespaces on a context as a possible solution to this - how does that sound?"}}
{"actor":{"display_login":"doriordan"}}