{"action":"closed","number":1476,"pull_request":{"url":"https://api.github.com/repos/rancher/ui/pulls/1476","id":157152409,"html_url":"https://github.com/rancher/ui/pull/1476","diff_url":"https://github.com/rancher/ui/pull/1476.diff","patch_url":"https://github.com/rancher/ui/pull/1476.patch","issue_url":"https://api.github.com/repos/rancher/ui/issues/1476","number":1476,"state":"closed","locked":false,"title":"Fix issues https://github.com/rancher/rancher/issues/10492","user":{"login":"biblesyme","id":9334435,"avatar_url":"https://avatars3.githubusercontent.com/u/9334435?v=4","gravatar_id":"","url":"https://api.github.com/users/biblesyme","html_url":"https://github.com/biblesyme","followers_url":"https://api.github.com/users/biblesyme/followers","following_url":"https://api.github.com/users/biblesyme/following{/other_user}","gists_url":"https://api.github.com/users/biblesyme/gists{/gist_id}","starred_url":"https://api.github.com/users/biblesyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biblesyme/subscriptions","organizations_url":"https://api.github.com/users/biblesyme/orgs","repos_url":"https://api.github.com/users/biblesyme/repos","events_url":"https://api.github.com/users/biblesyme/events{/privacy}","received_events_url":"https://api.github.com/users/biblesyme/received_events","type":"User","site_admin":false},"body":"It's caused by `undefined` of 'launchConfig.labels' in Service Alias. I added the valid check here.","created_at":"2017-12-08T02:47:43Z","updated_at":"2017-12-08T18:02:43Z","closed_at":"2017-12-08T18:02:43Z","merged_at":"2017-12-08T18:02:43Z","merge_commit_sha":"5b44e18e87a2346ec3f6ee38acf0c80dfc2c8b6f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/ui/pulls/1476/commits","review_comments_url":"https://api.github.com/repos/rancher/ui/pulls/1476/comments","review_comment_url":"https://api.github.com/repos/rancher/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/ui/issues/1476/comments","statuses_url":"https://api.github.com/repos/rancher/ui/statuses/cbdd4950fd8b126e3ea5b312eb69d9dbcda3f75b","head":{"label":"biblesyme:1.6-dev-serviceUI-fix","ref":"1.6-dev-serviceUI-fix","sha":"cbdd4950fd8b126e3ea5b312eb69d9dbcda3f75b","user":{"login":"biblesyme","id":9334435,"avatar_url":"https://avatars3.githubusercontent.com/u/9334435?v=4","gravatar_id":"","url":"https://api.github.com/users/biblesyme","html_url":"https://github.com/biblesyme","followers_url":"https://api.github.com/users/biblesyme/followers","following_url":"https://api.github.com/users/biblesyme/following{/other_user}","gists_url":"https://api.github.com/users/biblesyme/gists{/gist_id}","starred_url":"https://api.github.com/users/biblesyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biblesyme/subscriptions","organizations_url":"https://api.github.com/users/biblesyme/orgs","repos_url":"https://api.github.com/users/biblesyme/repos","events_url":"https://api.github.com/users/biblesyme/events{/privacy}","received_events_url":"https://api.github.com/users/biblesyme/received_events","type":"User","site_admin":false},"repo":{"id":84430126,"name":"ui","full_name":"biblesyme/ui","owner":{"login":"biblesyme","id":9334435,"avatar_url":"https://avatars3.githubusercontent.com/u/9334435?v=4","gravatar_id":"","url":"https://api.github.com/users/biblesyme","html_url":"https://github.com/biblesyme","followers_url":"https://api.github.com/users/biblesyme/followers","following_url":"https://api.github.com/users/biblesyme/following{/other_user}","gists_url":"https://api.github.com/users/biblesyme/gists{/gist_id}","starred_url":"https://api.github.com/users/biblesyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biblesyme/subscriptions","organizations_url":"https://api.github.com/users/biblesyme/orgs","repos_url":"https://api.github.com/users/biblesyme/repos","events_url":"https://api.github.com/users/biblesyme/events{/privacy}","received_events_url":"https://api.github.com/users/biblesyme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biblesyme/ui","description":"Rancher UI","fork":true,"url":"https://api.github.com/repos/biblesyme/ui","forks_url":"https://api.github.com/repos/biblesyme/ui/forks","keys_url":"https://api.github.com/repos/biblesyme/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biblesyme/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biblesyme/ui/teams","hooks_url":"https://api.github.com/repos/biblesyme/ui/hooks","issue_events_url":"https://api.github.com/repos/biblesyme/ui/issues/events{/number}","events_url":"https://api.github.com/repos/biblesyme/ui/events","assignees_url":"https://api.github.com/repos/biblesyme/ui/assignees{/user}","branches_url":"https://api.github.com/repos/biblesyme/ui/branches{/branch}","tags_url":"https://api.github.com/repos/biblesyme/ui/tags","blobs_url":"https://api.github.com/repos/biblesyme/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biblesyme/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biblesyme/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/biblesyme/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biblesyme/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/biblesyme/ui/languages","stargazers_url":"https://api.github.com/repos/biblesyme/ui/stargazers","contributors_url":"https://api.github.com/repos/biblesyme/ui/contributors","subscribers_url":"https://api.github.com/repos/biblesyme/ui/subscribers","subscription_url":"https://api.github.com/repos/biblesyme/ui/subscription","commits_url":"https://api.github.com/repos/biblesyme/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/biblesyme/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/biblesyme/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/biblesyme/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/biblesyme/ui/contents/{+path}","compare_url":"https://api.github.com/repos/biblesyme/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biblesyme/ui/merges","archive_url":"https://api.github.com/repos/biblesyme/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biblesyme/ui/downloads","issues_url":"https://api.github.com/repos/biblesyme/ui/issues{/number}","pulls_url":"https://api.github.com/repos/biblesyme/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/biblesyme/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/biblesyme/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biblesyme/ui/labels{/name}","releases_url":"https://api.github.com/repos/biblesyme/ui/releases{/id}","deployments_url":"https://api.github.com/repos/biblesyme/ui/deployments","created_at":"2017-03-09T10:37:22Z","updated_at":"2017-03-09T10:37:25Z","pushed_at":"2017-12-08T11:10:35Z","git_url":"git://github.com/biblesyme/ui.git","ssh_url":"git@github.com:biblesyme/ui.git","clone_url":"https://github.com/biblesyme/ui.git","svn_url":"https://github.com/biblesyme/ui","homepage":"http://rancher.com","size":27024,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:1.6-dev","ref":"1.6-dev","sha":"3c130cd6a490741e16c8e6bfc3671521a33656be","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":28155823,"name":"ui","full_name":"rancher/ui","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/ui","description":"Rancher UI","fork":false,"url":"https://api.github.com/repos/rancher/ui","forks_url":"https://api.github.com/repos/rancher/ui/forks","keys_url":"https://api.github.com/repos/rancher/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/ui/teams","hooks_url":"https://api.github.com/repos/rancher/ui/hooks","issue_events_url":"https://api.github.com/repos/rancher/ui/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/ui/events","assignees_url":"https://api.github.com/repos/rancher/ui/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/ui/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/ui/tags","blobs_url":"https://api.github.com/repos/rancher/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/ui/languages","stargazers_url":"https://api.github.com/repos/rancher/ui/stargazers","contributors_url":"https://api.github.com/repos/rancher/ui/contributors","subscribers_url":"https://api.github.com/repos/rancher/ui/subscribers","subscription_url":"https://api.github.com/repos/rancher/ui/subscription","commits_url":"https://api.github.com/repos/rancher/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/ui/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/ui/merges","archive_url":"https://api.github.com/repos/rancher/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/ui/downloads","issues_url":"https://api.github.com/repos/rancher/ui/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/ui/labels{/name}","releases_url":"https://api.github.com/repos/rancher/ui/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/ui/deployments","created_at":"2014-12-17T21:13:03Z","updated_at":"2017-12-08T02:08:27Z","pushed_at":"2017-12-08T18:02:43Z","git_url":"git://github.com/rancher/ui.git","ssh_url":"git@github.com:rancher/ui.git","clone_url":"https://github.com/rancher/ui.git","svn_url":"https://github.com/rancher/ui","homepage":"http://rancher.com","size":32661,"stargazers_count":185,"watchers_count":185,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":154,"open_issues":3,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/ui/pulls/1476"},"html":{"href":"https://github.com/rancher/ui/pull/1476"},"issue":{"href":"https://api.github.com/repos/rancher/ui/issues/1476"},"comments":{"href":"https://api.github.com/repos/rancher/ui/issues/1476/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/ui/pulls/1476/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/ui/pulls/1476/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/ui/statuses/cbdd4950fd8b126e3ea5b312eb69d9dbcda3f75b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vincent99","id":753917,"avatar_url":"https://avatars0.githubusercontent.com/u/753917?v=4","gravatar_id":"","url":"https://api.github.com/users/vincent99","html_url":"https://github.com/vincent99","followers_url":"https://api.github.com/users/vincent99/followers","following_url":"https://api.github.com/users/vincent99/following{/other_user}","gists_url":"https://api.github.com/users/vincent99/gists{/gist_id}","starred_url":"https://api.github.com/users/vincent99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincent99/subscriptions","organizations_url":"https://api.github.com/users/vincent99/orgs","repos_url":"https://api.github.com/users/vincent99/repos","events_url":"https://api.github.com/users/vincent99/events{/privacy}","received_events_url":"https://api.github.com/users/vincent99/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"vincent99"}}