{"action":"created","issue":{"url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/16","repository_url":"https://api.github.com/repos/cloudhead/neovim-fuzzy","labels_url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/16/comments","events_url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/16/events","html_url":"https://github.com/cloudhead/neovim-fuzzy/pull/16","id":219426987,"number":16,"title":"Pipe lines directly to `fzy`","user":{"login":"idanarye","id":1149255,"avatar_url":"https://avatars3.githubusercontent.com/u/1149255?v=3","gravatar_id":"","url":"https://api.github.com/users/idanarye","html_url":"https://github.com/idanarye","followers_url":"https://api.github.com/users/idanarye/followers","following_url":"https://api.github.com/users/idanarye/following{/other_user}","gists_url":"https://api.github.com/users/idanarye/gists{/gist_id}","starred_url":"https://api.github.com/users/idanarye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanarye/subscriptions","organizations_url":"https://api.github.com/users/idanarye/orgs","repos_url":"https://api.github.com/users/idanarye/repos","events_url":"https://api.github.com/users/idanarye/events{/privacy}","received_events_url":"https://api.github.com/users/idanarye/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-04-05T00:26:19Z","updated_at":"2017-05-01T10:58:01Z","closed_at":"2017-04-19T13:14:19Z","pull_request":{"url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/pulls/16","html_url":"https://github.com/cloudhead/neovim-fuzzy/pull/16","diff_url":"https://github.com/cloudhead/neovim-fuzzy/pull/16.diff","patch_url":"https://github.com/cloudhead/neovim-fuzzy/pull/16.patch"},"body":"Old behavior was loading all the commands into a Vim list, write it into\r\na file, and pipe that file into `fzy`.\r\n\r\nThis is a inefficient, because both `ag`/`rg` and `fzy` are blazing fast\r\nand can handle large quantities of data, but Vimscript, with it's\r\ndynamic typing and garbage-collected memory - which aren't even\r\nstate-of-the-art! - is not only slowing the entire process down but also\r\nbreaks it when doing a big `:FuzzyGrep` in a large codebases.\r\n\r\nThis PR aims to fix it:\r\n\r\n* With `:FuzzyGrep` it pipes the `ag`/`rg` command directly to `fzy`.\r\n* With `:FuzzyOpen` it creates a temporary file, writes the list of\r\n  buffers to it with `writefile()` and then uses `ag`/`rg` to pipe the\r\n  list of files into that temporary file without passing them through\r\n  Vim.\r\n\r\nThis ensures that aside from the list of buffers(that for obvious\r\nreasons must come from Vim) all the match choices are piped by the\r\noperation system and Vim does not need to load them into it's memory."},"comment":{"url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/comments/298318706","html_url":"https://github.com/cloudhead/neovim-fuzzy/pull/16#issuecomment-298318706","issue_url":"https://api.github.com/repos/cloudhead/neovim-fuzzy/issues/16","id":298318706,"user":{"login":"cloudhead","id":40774,"avatar_url":"https://avatars3.githubusercontent.com/u/40774?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudhead","html_url":"https://github.com/cloudhead","followers_url":"https://api.github.com/users/cloudhead/followers","following_url":"https://api.github.com/users/cloudhead/following{/other_user}","gists_url":"https://api.github.com/users/cloudhead/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudhead/subscriptions","organizations_url":"https://api.github.com/users/cloudhead/orgs","repos_url":"https://api.github.com/users/cloudhead/repos","events_url":"https://api.github.com/users/cloudhead/events{/privacy}","received_events_url":"https://api.github.com/users/cloudhead/received_events","type":"User","site_admin":false},"created_at":"2017-05-01T10:58:01Z","updated_at":"2017-05-01T10:58:01Z","body":"Update: the problem is due I think to the `lcd` commands not affecting rg anymore, I'm guessing because it's run differently. Not sure how to fix yet."}}
{"actor":{"display_login":"cloudhead"}}