{"action":"created","comment":{"url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments/125060068","pull_request_review_id":47414718,"id":125060068,"diff_hunk":"@@ -1,5 +1,6 @@\n-# This can not be installed from pip, on Fedora you need to install rpm-python{,3}\n-#rpm-python\n+# This can not be installed from pip, on Fedora you need to install python3-rpm.\n+# https://github.com/rpm-software-management/rpm/tree/master/python/rpm\n+#python3-rpm","path":"requirements.txt","position":5,"original_position":5,"commit_id":"a8e2bde5253e0ffee13a4290a33fa268f3de35f0","original_commit_id":"a8e2bde5253e0ffee13a4290a33fa268f3de35f0","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"body":"OK I will wait until F24 EOL. maybe we need to wait for 1 month.\r\n\r\n> https://fedoraproject.org/wiki/Fedora_Release_Life_Cycle\r\n> Fedora 24 will be maintained until 1 month after the release of Fedora 26. \r\n\r\nBy the way I could not find `rpm3-python` pip package on my F25.\r\n\r\n```\r\n$ rpm -q python2-rpm\r\npython2-rpm-4.13.0.1-1.fc25.x86_64\r\n\r\n$ rpm -q python3-rpm\r\npython3-rpm-4.13.0.1-1.fc25.x86_64\r\n\r\n$ /usr/bin/pip list | grep rpm\r\nrpm-python (4.13.0.1)\r\n\r\n$ /usr/bin/pip3 list | grep rpm\r\nrpm-python (4.13.0.1)\r\n```\r\n","created_at":"2017-06-30T14:59:33Z","updated_at":"2017-06-30T14:59:33Z","html_url":"https://github.com/rebase-helper/rebase-helper/pull/286#discussion_r125060068","pull_request_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286","_links":{"self":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments/125060068"},"html":{"href":"https://github.com/rebase-helper/rebase-helper/pull/286#discussion_r125060068"},"pull_request":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286","id":128375509,"html_url":"https://github.com/rebase-helper/rebase-helper/pull/286","diff_url":"https://github.com/rebase-helper/rebase-helper/pull/286.diff","patch_url":"https://github.com/rebase-helper/rebase-helper/pull/286.patch","issue_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/286","number":286,"state":"open","locked":false,"title":"Update a comment for old package rpm-python in requirements.txt","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"body":"This PR is to update `requirements.txt` correctly, and from below conversation.\r\n\r\n> https://github.com/rebase-helper/rebase-helper/issues/285#issuecomment-312264180\r\n> it used to be called rpm-python3, we should probably update the comment in requirements.txt\r\n","created_at":"2017-06-30T13:55:42Z","updated_at":"2017-06-30T14:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbedc029bcecd338761622a9e4406cfb4712303e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286/commits","review_comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286/comments","review_comment_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/286/comments","statuses_url":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/a8e2bde5253e0ffee13a4290a33fa268f3de35f0","head":{"label":"junaruga:hotfix/requirements-txt-comment","ref":"hotfix/requirements-txt-comment","sha":"a8e2bde5253e0ffee13a4290a33fa268f3de35f0","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"repo":{"id":95892759,"name":"rebase-helper","full_name":"junaruga/rebase-helper","owner":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junaruga/rebase-helper","description":"This tool helps you to rebase your package to the latest version","fork":true,"url":"https://api.github.com/repos/junaruga/rebase-helper","forks_url":"https://api.github.com/repos/junaruga/rebase-helper/forks","keys_url":"https://api.github.com/repos/junaruga/rebase-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junaruga/rebase-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junaruga/rebase-helper/teams","hooks_url":"https://api.github.com/repos/junaruga/rebase-helper/hooks","issue_events_url":"https://api.github.com/repos/junaruga/rebase-helper/issues/events{/number}","events_url":"https://api.github.com/repos/junaruga/rebase-helper/events","assignees_url":"https://api.github.com/repos/junaruga/rebase-helper/assignees{/user}","branches_url":"https://api.github.com/repos/junaruga/rebase-helper/branches{/branch}","tags_url":"https://api.github.com/repos/junaruga/rebase-helper/tags","blobs_url":"https://api.github.com/repos/junaruga/rebase-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junaruga/rebase-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junaruga/rebase-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/junaruga/rebase-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junaruga/rebase-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/junaruga/rebase-helper/languages","stargazers_url":"https://api.github.com/repos/junaruga/rebase-helper/stargazers","contributors_url":"https://api.github.com/repos/junaruga/rebase-helper/contributors","subscribers_url":"https://api.github.com/repos/junaruga/rebase-helper/subscribers","subscription_url":"https://api.github.com/repos/junaruga/rebase-helper/subscription","commits_url":"https://api.github.com/repos/junaruga/rebase-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/junaruga/rebase-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/junaruga/rebase-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/junaruga/rebase-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/junaruga/rebase-helper/contents/{+path}","compare_url":"https://api.github.com/repos/junaruga/rebase-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junaruga/rebase-helper/merges","archive_url":"https://api.github.com/repos/junaruga/rebase-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junaruga/rebase-helper/downloads","issues_url":"https://api.github.com/repos/junaruga/rebase-helper/issues{/number}","pulls_url":"https://api.github.com/repos/junaruga/rebase-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/junaruga/rebase-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/junaruga/rebase-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junaruga/rebase-helper/labels{/name}","releases_url":"https://api.github.com/repos/junaruga/rebase-helper/releases{/id}","deployments_url":"https://api.github.com/repos/junaruga/rebase-helper/deployments","created_at":"2017-06-30T13:50:46Z","updated_at":"2017-06-30T13:50:48Z","pushed_at":"2017-06-30T13:51:13Z","git_url":"git://github.com/junaruga/rebase-helper.git","ssh_url":"git@github.com:junaruga/rebase-helper.git","clone_url":"https://github.com/junaruga/rebase-helper.git","svn_url":"https://github.com/junaruga/rebase-helper","homepage":"https://rebase-helper.readthedocs.io/","size":1569,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rebase-helper:master","ref":"master","sha":"6441331063d0d89d8221e6adbcc5c713d53a0341","user":{"login":"rebase-helper","id":20593189,"avatar_url":"https://avatars0.githubusercontent.com/u/20593189?v=3","gravatar_id":"","url":"https://api.github.com/users/rebase-helper","html_url":"https://github.com/rebase-helper","followers_url":"https://api.github.com/users/rebase-helper/followers","following_url":"https://api.github.com/users/rebase-helper/following{/other_user}","gists_url":"https://api.github.com/users/rebase-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/rebase-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebase-helper/subscriptions","organizations_url":"https://api.github.com/users/rebase-helper/orgs","repos_url":"https://api.github.com/users/rebase-helper/repos","events_url":"https://api.github.com/users/rebase-helper/events{/privacy}","received_events_url":"https://api.github.com/users/rebase-helper/received_events","type":"Organization","site_admin":false},"repo":{"id":12696975,"name":"rebase-helper","full_name":"rebase-helper/rebase-helper","owner":{"login":"rebase-helper","id":20593189,"avatar_url":"https://avatars0.githubusercontent.com/u/20593189?v=3","gravatar_id":"","url":"https://api.github.com/users/rebase-helper","html_url":"https://github.com/rebase-helper","followers_url":"https://api.github.com/users/rebase-helper/followers","following_url":"https://api.github.com/users/rebase-helper/following{/other_user}","gists_url":"https://api.github.com/users/rebase-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/rebase-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebase-helper/subscriptions","organizations_url":"https://api.github.com/users/rebase-helper/orgs","repos_url":"https://api.github.com/users/rebase-helper/repos","events_url":"https://api.github.com/users/rebase-helper/events{/privacy}","received_events_url":"https://api.github.com/users/rebase-helper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rebase-helper/rebase-helper","description":"This tool helps you to rebase your package to the latest version","fork":false,"url":"https://api.github.com/repos/rebase-helper/rebase-helper","forks_url":"https://api.github.com/repos/rebase-helper/rebase-helper/forks","keys_url":"https://api.github.com/repos/rebase-helper/rebase-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebase-helper/rebase-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebase-helper/rebase-helper/teams","hooks_url":"https://api.github.com/repos/rebase-helper/rebase-helper/hooks","issue_events_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/events{/number}","events_url":"https://api.github.com/repos/rebase-helper/rebase-helper/events","assignees_url":"https://api.github.com/repos/rebase-helper/rebase-helper/assignees{/user}","branches_url":"https://api.github.com/repos/rebase-helper/rebase-helper/branches{/branch}","tags_url":"https://api.github.com/repos/rebase-helper/rebase-helper/tags","blobs_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/rebase-helper/rebase-helper/languages","stargazers_url":"https://api.github.com/repos/rebase-helper/rebase-helper/stargazers","contributors_url":"https://api.github.com/repos/rebase-helper/rebase-helper/contributors","subscribers_url":"https://api.github.com/repos/rebase-helper/rebase-helper/subscribers","subscription_url":"https://api.github.com/repos/rebase-helper/rebase-helper/subscription","commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebase-helper/rebase-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/rebase-helper/rebase-helper/contents/{+path}","compare_url":"https://api.github.com/repos/rebase-helper/rebase-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebase-helper/rebase-helper/merges","archive_url":"https://api.github.com/repos/rebase-helper/rebase-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebase-helper/rebase-helper/downloads","issues_url":"https://api.github.com/repos/rebase-helper/rebase-helper/issues{/number}","pulls_url":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/rebase-helper/rebase-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/rebase-helper/rebase-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebase-helper/rebase-helper/labels{/name}","releases_url":"https://api.github.com/repos/rebase-helper/rebase-helper/releases{/id}","deployments_url":"https://api.github.com/repos/rebase-helper/rebase-helper/deployments","created_at":"2013-09-09T08:48:30Z","updated_at":"2017-05-30T11:02:29Z","pushed_at":"2017-06-30T13:55:43Z","git_url":"git://github.com/rebase-helper/rebase-helper.git","ssh_url":"git@github.com:rebase-helper/rebase-helper.git","clone_url":"https://github.com/rebase-helper/rebase-helper.git","svn_url":"https://github.com/rebase-helper/rebase-helper","homepage":"https://rebase-helper.readthedocs.io/","size":1568,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":34,"forks":13,"open_issues":34,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286"},"html":{"href":"https://github.com/rebase-helper/rebase-helper/pull/286"},"issue":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/286"},"comments":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/rebase-helper/rebase-helper/statuses/a8e2bde5253e0ffee13a4290a33fa268f3de35f0"}}}}
{"actor":{"display_login":"junaruga"}}