{"action":"created","comment":{"url":"https://api.github.com/repos/google/syzkaller/pulls/comments/115768224","pull_request_review_id":37335459,"id":115768224,"diff_hunk":"@@ -54,8 +64,9 @@ func (p *Prog) SerializeForExec(buffer []byte, pid int) error {\n \t\tforeachArg(c, func(arg, _ *Arg, _ *[]*Arg) {\n \t\t\tif arg.Kind == ArgPointer && arg.Res != nil {\n \t\t\t\tforeachSubargOffset(arg.Res, func(arg1 *Arg, offset uintptr) {\n-\t\t\t\t\tif len(arg1.Uses) != 0 {\n-\t\t\t\t\t\tw.args[arg1] = argInfo{Offset: offset}\n+\t\t\t\t\tw.args[arg1] = argInfo{Addr: physicalAddr(arg) + offset}\n+\t\t\t\t\tif arg1.Kind == ArgGroup || arg1.Kind == ArgUnion {","path":"prog/encodingexec.go","position":null,"original_position":24,"commit_id":"97eba8ac0faa912204dd419928d73abb8cd92a0e","original_commit_id":"ba076a6524e947baa020817c8b28d1fab78c528e","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars1.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"body":"I've added it since I changed foreachSubargOffset to iterate over structs and unions. It is probably mutually exclusive, however it's not obvious. I think it makes sense to leave this check for clarity.","created_at":"2017-05-10T15:11:03Z","updated_at":"2017-05-10T15:11:03Z","html_url":"https://github.com/google/syzkaller/pull/169#discussion_r115768224","pull_request_url":"https://api.github.com/repos/google/syzkaller/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments/115768224"},"html":{"href":"https://github.com/google/syzkaller/pull/169#discussion_r115768224"},"pull_request":{"href":"https://api.github.com/repos/google/syzkaller/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/google/syzkaller/pulls/169","id":117973511,"html_url":"https://github.com/google/syzkaller/pull/169","diff_url":"https://github.com/google/syzkaller/pull/169.diff","patch_url":"https://github.com/google/syzkaller/pull/169.patch","issue_url":"https://api.github.com/repos/google/syzkaller/issues/169","number":169,"state":"open","locked":false,"title":"prog, executor: move checksum computation to executor","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars1.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"body":"This commit moves checksum computation to executor. This will allow to embed dynamically generated values (like TCP sequence numbers) into packets.","created_at":"2017-04-27T15:58:53Z","updated_at":"2017-05-10T15:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"875b9dfb5dc20310f37e0703569567e88fb2e0b4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/syzkaller/pulls/169/commits","review_comments_url":"https://api.github.com/repos/google/syzkaller/pulls/169/comments","review_comment_url":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/syzkaller/issues/169/comments","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/97eba8ac0faa912204dd419928d73abb8cd92a0e","head":{"label":"xairy:executor-csum","ref":"executor-csum","sha":"97eba8ac0faa912204dd419928d73abb8cd92a0e","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars1.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"repo":{"id":68212846,"name":"syzkaller","full_name":"xairy/syzkaller","owner":{"login":"xairy","id":4965052,"avatar_url":"https://avatars1.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xairy/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":true,"url":"https://api.github.com/repos/xairy/syzkaller","forks_url":"https://api.github.com/repos/xairy/syzkaller/forks","keys_url":"https://api.github.com/repos/xairy/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xairy/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xairy/syzkaller/teams","hooks_url":"https://api.github.com/repos/xairy/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/xairy/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/xairy/syzkaller/events","assignees_url":"https://api.github.com/repos/xairy/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/xairy/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/xairy/syzkaller/tags","blobs_url":"https://api.github.com/repos/xairy/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xairy/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xairy/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/xairy/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xairy/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/xairy/syzkaller/languages","stargazers_url":"https://api.github.com/repos/xairy/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/xairy/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/xairy/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/xairy/syzkaller/subscription","commits_url":"https://api.github.com/repos/xairy/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/xairy/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/xairy/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/xairy/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/xairy/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/xairy/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xairy/syzkaller/merges","archive_url":"https://api.github.com/repos/xairy/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xairy/syzkaller/downloads","issues_url":"https://api.github.com/repos/xairy/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/xairy/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/xairy/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/xairy/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xairy/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/xairy/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/xairy/syzkaller/deployments","created_at":"2016-09-14T14:22:30Z","updated_at":"2016-09-14T14:22:32Z","pushed_at":"2017-05-10T15:06:43Z","git_url":"git://github.com/xairy/syzkaller.git","ssh_url":"git@github.com:xairy/syzkaller.git","clone_url":"https://github.com/xairy/syzkaller.git","svn_url":"https://github.com/xairy/syzkaller","homepage":"","size":3024,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e9de07e8ee4b655f0f1796c1ff937b59de618361","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":44087204,"name":"syzkaller","full_name":"google/syzkaller","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/syzkaller","description":"syzkaller is an unsupervised, coverage-guided Linux system call fuzzer","fork":false,"url":"https://api.github.com/repos/google/syzkaller","forks_url":"https://api.github.com/repos/google/syzkaller/forks","keys_url":"https://api.github.com/repos/google/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/syzkaller/teams","hooks_url":"https://api.github.com/repos/google/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/google/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/google/syzkaller/events","assignees_url":"https://api.github.com/repos/google/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/google/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/google/syzkaller/tags","blobs_url":"https://api.github.com/repos/google/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/google/syzkaller/languages","stargazers_url":"https://api.github.com/repos/google/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/google/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/google/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/google/syzkaller/subscription","commits_url":"https://api.github.com/repos/google/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/google/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/syzkaller/merges","archive_url":"https://api.github.com/repos/google/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/syzkaller/downloads","issues_url":"https://api.github.com/repos/google/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/google/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/google/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/google/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/google/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/google/syzkaller/deployments","created_at":"2015-10-12T06:05:05Z","updated_at":"2017-05-08T08:25:59Z","pushed_at":"2017-05-10T15:06:45Z","git_url":"git://github.com/google/syzkaller.git","ssh_url":"git@github.com:google/syzkaller.git","clone_url":"https://github.com/google/syzkaller.git","svn_url":"https://github.com/google/syzkaller","homepage":"","size":3073,"stargazers_count":868,"watchers_count":868,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":19,"forks":153,"open_issues":19,"watchers":868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/169"},"html":{"href":"https://github.com/google/syzkaller/pull/169"},"issue":{"href":"https://api.github.com/repos/google/syzkaller/issues/169"},"comments":{"href":"https://api.github.com/repos/google/syzkaller/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/google/syzkaller/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/syzkaller/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/google/syzkaller/statuses/97eba8ac0faa912204dd419928d73abb8cd92a0e"}}}}
{"actor":{"display_login":"xairy"}}