{"action":"created","issue":{"url":"https://api.github.com/repos/csierra/liferay-portal/issues/276","repository_url":"https://api.github.com/repos/csierra/liferay-portal","labels_url":"https://api.github.com/repos/csierra/liferay-portal/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/csierra/liferay-portal/issues/276/comments","events_url":"https://api.github.com/repos/csierra/liferay-portal/issues/276/events","html_url":"https://github.com/csierra/liferay-portal/pull/276","id":272322029,"number":276,"title":"LPS-75781 Remove export packages from portal-configuration-extender","user":{"login":"tinatian","id":860623,"avatar_url":"https://avatars0.githubusercontent.com/u/860623?v=4","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-08T19:35:53Z","updated_at":"2017-11-08T19:36:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/csierra/liferay-portal/pulls/276","html_url":"https://github.com/csierra/liferay-portal/pull/276","diff_url":"https://github.com/csierra/liferay-portal/pull/276.diff","patch_url":"https://github.com/csierra/liferay-portal/pull/276.patch"},"body":"Hi Carlos,\r\n\r\nOur team is trying to decouple modules by removing export packages, and I am working on \"portal-configuration-extender\" which you added in LPS-59342.\r\n\r\nAfter searching on our code base, I found on other usages of the classes in export packages except in this module, so I moved them into internal packages, also I did some refactoring to make code clean. Could you please review my change?\r\n\r\nI know the reason those classes were in public package instead of internal package might be we would like to add other different implementation, but since we have no other implementation now, I think it's better to make it internal, we can move them out when we needed. \r\n\r\nAny question about my changes, please feel free to let me know.\r\n\r\ncc @shuyangzhou\r\n\r\nThanks.\r\nTina."},"comment":{"url":"https://api.github.com/repos/csierra/liferay-portal/issues/comments/342934246","html_url":"https://github.com/csierra/liferay-portal/pull/276#issuecomment-342934246","issue_url":"https://api.github.com/repos/csierra/liferay-portal/issues/276","id":342934246,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars2.githubusercontent.com/u/4502793?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T19:36:33Z","updated_at":"2017-11-08T19:36:33Z","author_association":"COLLABORATOR","body":"<h1>Build started.</h1><p>Jenkins is currently running tests.</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a></p><h4>Job Summary:</h4><p>Job Link: <a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest(master)/2714/\">test-portal-acceptance-pullrequest(master)</a></p><p><b>For more details click <a href=\"https://test-1-2.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/2714/jenkins-report.html\">here</a>.</b></p>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}