{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/comments/125173541","pull_request_review_id":47541242,"id":125173541,"diff_hunk":"@@ -0,0 +1,143 @@\n+var utils = require('./utils')\n+\n+var maxTries = 1000000","path":"branchandbound.js","position":3,"original_position":3,"commit_id":"8b2b964e40f2be01be523c259b5b95df7d1e9728","original_commit_id":"8b2b964e40f2be01be523c259b5b95df7d1e9728","user":{"login":"Xekyo","id":4060799,"avatar_url":"https://avatars3.githubusercontent.com/u/4060799?v=3","gravatar_id":"","url":"https://api.github.com/users/Xekyo","html_url":"https://github.com/Xekyo","followers_url":"https://api.github.com/users/Xekyo/followers","following_url":"https://api.github.com/users/Xekyo/following{/other_user}","gists_url":"https://api.github.com/users/Xekyo/gists{/gist_id}","starred_url":"https://api.github.com/users/Xekyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xekyo/subscriptions","organizations_url":"https://api.github.com/users/Xekyo/orgs","repos_url":"https://api.github.com/users/Xekyo/repos","events_url":"https://api.github.com/users/Xekyo/events{/privacy}","received_events_url":"https://api.github.com/users/Xekyo/received_events","type":"User","site_admin":false},"body":"My gut feeling was 100k, you have 1M here. That might be very long on a huge wallet in an unfortunate UTXO pool and target combination. Might want to check what amount of time that allows.","created_at":"2017-07-02T04:51:30Z","updated_at":"2017-07-02T04:52:24Z","html_url":"https://github.com/bitcoinjs/coinselect/pull/13#discussion_r125173541","pull_request_url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/comments/125173541"},"html":{"href":"https://github.com/bitcoinjs/coinselect/pull/13#discussion_r125173541"},"pull_request":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13","id":128507184,"html_url":"https://github.com/bitcoinjs/coinselect/pull/13","diff_url":"https://github.com/bitcoinjs/coinselect/pull/13.diff","patch_url":"https://github.com/bitcoinjs/coinselect/pull/13.patch","issue_url":"https://api.github.com/repos/bitcoinjs/coinselect/issues/13","number":13,"state":"open","locked":false,"title":"Adding Branch and Bound algorithm","user":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars1.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"body":"https://github.com/bitcoinjs/coinselect/issues/10\r\n\r\nIn the end, I used the C++ code from core PR as a reference ( https://github.com/bitcoin/bitcoin/pull/10637 ), not the scala code.\r\n\r\nIt seems to be working, and performing rather well! Although it matches only in <10% of cases in the simulation, the reduction of the fees is significant.\r\n\r\nThe only question is what to take as a fallback. In the original paper and in the scala code that goes with it, random shuffle + accumulative is being used. In this module simulation, min+accumulative has the best results. (Even with the total costs from https://github.com/bitcoinjs/coinselect/pull/11 )\r\n\r\n*However*, when I tried to implement the \"minimal\" fallback into the scala code, the utxo set in the big example exploded, which caused larger total cost, *plus* the BnB search was significantly slower.\r\n\r\nAs I wrote in the linked pull request, I will try to port the big example into this code, what will happen.","created_at":"2017-07-02T02:37:27Z","updated_at":"2017-07-02T04:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f9acb219f3825db192375460aa7f73ff5ee4ff1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dcousens","id":413395,"avatar_url":"https://avatars3.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13/commits","review_comments_url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13/comments","review_comment_url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinjs/coinselect/issues/13/comments","statuses_url":"https://api.github.com/repos/bitcoinjs/coinselect/statuses/8b2b964e40f2be01be523c259b5b95df7d1e9728","head":{"label":"runn1ng:bnb","ref":"bnb","sha":"8b2b964e40f2be01be523c259b5b95df7d1e9728","user":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars1.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"repo":{"id":95784146,"name":"coinselect","full_name":"runn1ng/coinselect","owner":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars1.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runn1ng/coinselect","description":"An unspent transaction output (UTXO) selection module for bitcoin.","fork":true,"url":"https://api.github.com/repos/runn1ng/coinselect","forks_url":"https://api.github.com/repos/runn1ng/coinselect/forks","keys_url":"https://api.github.com/repos/runn1ng/coinselect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runn1ng/coinselect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runn1ng/coinselect/teams","hooks_url":"https://api.github.com/repos/runn1ng/coinselect/hooks","issue_events_url":"https://api.github.com/repos/runn1ng/coinselect/issues/events{/number}","events_url":"https://api.github.com/repos/runn1ng/coinselect/events","assignees_url":"https://api.github.com/repos/runn1ng/coinselect/assignees{/user}","branches_url":"https://api.github.com/repos/runn1ng/coinselect/branches{/branch}","tags_url":"https://api.github.com/repos/runn1ng/coinselect/tags","blobs_url":"https://api.github.com/repos/runn1ng/coinselect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runn1ng/coinselect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runn1ng/coinselect/git/refs{/sha}","trees_url":"https://api.github.com/repos/runn1ng/coinselect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runn1ng/coinselect/statuses/{sha}","languages_url":"https://api.github.com/repos/runn1ng/coinselect/languages","stargazers_url":"https://api.github.com/repos/runn1ng/coinselect/stargazers","contributors_url":"https://api.github.com/repos/runn1ng/coinselect/contributors","subscribers_url":"https://api.github.com/repos/runn1ng/coinselect/subscribers","subscription_url":"https://api.github.com/repos/runn1ng/coinselect/subscription","commits_url":"https://api.github.com/repos/runn1ng/coinselect/commits{/sha}","git_commits_url":"https://api.github.com/repos/runn1ng/coinselect/git/commits{/sha}","comments_url":"https://api.github.com/repos/runn1ng/coinselect/comments{/number}","issue_comment_url":"https://api.github.com/repos/runn1ng/coinselect/issues/comments{/number}","contents_url":"https://api.github.com/repos/runn1ng/coinselect/contents/{+path}","compare_url":"https://api.github.com/repos/runn1ng/coinselect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runn1ng/coinselect/merges","archive_url":"https://api.github.com/repos/runn1ng/coinselect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runn1ng/coinselect/downloads","issues_url":"https://api.github.com/repos/runn1ng/coinselect/issues{/number}","pulls_url":"https://api.github.com/repos/runn1ng/coinselect/pulls{/number}","milestones_url":"https://api.github.com/repos/runn1ng/coinselect/milestones{/number}","notifications_url":"https://api.github.com/repos/runn1ng/coinselect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runn1ng/coinselect/labels{/name}","releases_url":"https://api.github.com/repos/runn1ng/coinselect/releases{/id}","deployments_url":"https://api.github.com/repos/runn1ng/coinselect/deployments","created_at":"2017-06-29T14:06:34Z","updated_at":"2017-06-29T14:06:35Z","pushed_at":"2017-07-02T02:43:47Z","git_url":"git://github.com/runn1ng/coinselect.git","ssh_url":"git@github.com:runn1ng/coinselect.git","clone_url":"https://github.com/runn1ng/coinselect.git","svn_url":"https://github.com/runn1ng/coinselect","homepage":"","size":106,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinjs:master","ref":"master","sha":"182a018517a45f1be7c1d04c1529616b152ca562","user":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars3.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":42842035,"name":"coinselect","full_name":"bitcoinjs/coinselect","owner":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars3.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinjs/coinselect","description":"An unspent transaction output (UTXO) selection module for bitcoin.","fork":false,"url":"https://api.github.com/repos/bitcoinjs/coinselect","forks_url":"https://api.github.com/repos/bitcoinjs/coinselect/forks","keys_url":"https://api.github.com/repos/bitcoinjs/coinselect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/coinselect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/coinselect/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/coinselect/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/coinselect/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/coinselect/events","assignees_url":"https://api.github.com/repos/bitcoinjs/coinselect/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/coinselect/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/coinselect/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/coinselect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/coinselect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/coinselect/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/coinselect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/coinselect/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/coinselect/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/coinselect/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/coinselect/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/coinselect/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/coinselect/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/coinselect/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/coinselect/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/coinselect/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/coinselect/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/coinselect/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/coinselect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/coinselect/merges","archive_url":"https://api.github.com/repos/bitcoinjs/coinselect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/coinselect/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/coinselect/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/coinselect/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/coinselect/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/coinselect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/coinselect/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/coinselect/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinjs/coinselect/deployments","created_at":"2015-09-21T03:35:19Z","updated_at":"2017-06-30T17:30:58Z","pushed_at":"2017-07-02T02:43:49Z","git_url":"git://github.com/bitcoinjs/coinselect.git","ssh_url":"git@github.com:bitcoinjs/coinselect.git","clone_url":"https://github.com/bitcoinjs/coinselect.git","svn_url":"https://github.com/bitcoinjs/coinselect","homepage":"","size":100,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13"},"html":{"href":"https://github.com/bitcoinjs/coinselect/pull/13"},"issue":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/issues/13"},"comments":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinjs/coinselect/statuses/8b2b964e40f2be01be523c259b5b95df7d1e9728"}}}}
{"actor":{"display_login":"Xekyo"}}