{"action":"closed","number":16391,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391","id":131458809,"html_url":"https://github.com/Automattic/wp-calypso/pull/16391","diff_url":"https://github.com/Automattic/wp-calypso/pull/16391.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/16391.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16391","number":16391,"state":"closed","locked":false,"title":"Sign Up: Polish form spacing","user":{"login":"danhauk","id":448298,"avatar_url":"https://avatars0.githubusercontent.com/u/448298?v=4","gravatar_id":"","url":"https://api.github.com/users/danhauk","html_url":"https://github.com/danhauk","followers_url":"https://api.github.com/users/danhauk/followers","following_url":"https://api.github.com/users/danhauk/following{/other_user}","gists_url":"https://api.github.com/users/danhauk/gists{/gist_id}","starred_url":"https://api.github.com/users/danhauk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhauk/subscriptions","organizations_url":"https://api.github.com/users/danhauk/orgs","repos_url":"https://api.github.com/users/danhauk/repos","events_url":"https://api.github.com/users/danhauk/events{/privacy}","received_events_url":"https://api.github.com/users/danhauk/received_events","type":"User","site_admin":false},"body":"This PR addresses some concerns with the signup screen with social buttons included. Feedback from @ranh:\r\n\r\n> I think it's mostly that there's no balance between the \"old\" and new parts. The form is very spacious with tons of whitespace, the social options are packed together very tightly\r\n\r\nThe main reason it was so spacious was because we had the form validation always in the markup with a `min-height`. While this did help with the UI jumping a bit with validation errors, it's not essential. Especially because the UI still jumped with languages other than English where the error was longer. Also, the form fields felt more disconnected with so much whitespace between them.\r\n\r\n**Before**\r\n![image](https://user-images.githubusercontent.com/448298/28397879-53aae788-6cd2-11e7-9f53-b0747addfd09.png)\r\n\r\n**After**\r\n![image](https://user-images.githubusercontent.com/448298/28432720-fa4c0e08-6d56-11e7-9191-d7edbd0b9ef0.png)\r\n\r\n#### Testing\r\n\r\n1. Run `git checkout update/sign-up-screen-polish` and start your server, or open a [live branch](https://calypso.live/?branch=update/sign-up-screen-polish).\r\n2. Visit the social signup screen at [`/start/social/user-social`](http://calypso.localhost:3000/start/social/user-social).\r\n3. Assert the screen looks like the screenshot above.\r\n4. Try signing up, try to break it.\r\n5. Visit the regular signup flow at [`/start`](http://calypso.localhost:3000/start).\r\n6. Assert it looks and works in the same way.\r\n\r\n#### Review\r\n\r\n- [x] Code\r\n- [x] Product","created_at":"2017-07-20T02:41:16Z","updated_at":"2017-07-21T15:54:40Z","closed_at":"2017-07-21T15:54:40Z","merged_at":"2017-07-21T15:54:40Z","merge_commit_sha":"f3c1a25421d667aee5e6ba8548cbc1869f877c2c","assignee":{"login":"danhauk","id":448298,"avatar_url":"https://avatars0.githubusercontent.com/u/448298?v=4","gravatar_id":"","url":"https://api.github.com/users/danhauk","html_url":"https://github.com/danhauk","followers_url":"https://api.github.com/users/danhauk/followers","following_url":"https://api.github.com/users/danhauk/following{/other_user}","gists_url":"https://api.github.com/users/danhauk/gists{/gist_id}","starred_url":"https://api.github.com/users/danhauk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhauk/subscriptions","organizations_url":"https://api.github.com/users/danhauk/orgs","repos_url":"https://api.github.com/users/danhauk/repos","events_url":"https://api.github.com/users/danhauk/events{/privacy}","received_events_url":"https://api.github.com/users/danhauk/received_events","type":"User","site_admin":false},"assignees":[{"login":"danhauk","id":448298,"avatar_url":"https://avatars0.githubusercontent.com/u/448298?v=4","gravatar_id":"","url":"https://api.github.com/users/danhauk","html_url":"https://github.com/danhauk","followers_url":"https://api.github.com/users/danhauk/followers","following_url":"https://api.github.com/users/danhauk/following{/other_user}","gists_url":"https://api.github.com/users/danhauk/gists{/gist_id}","starred_url":"https://api.github.com/users/danhauk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhauk/subscriptions","organizations_url":"https://api.github.com/users/danhauk/orgs","repos_url":"https://api.github.com/users/danhauk/repos","events_url":"https://api.github.com/users/danhauk/events{/privacy}","received_events_url":"https://api.github.com/users/danhauk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16391/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/0440ecd9020e064c35ef11886cd4e605b81c8a73","head":{"label":"Automattic:update/sign-up-screen-polish","ref":"update/sign-up-screen-polish","sha":"0440ecd9020e064c35ef11886cd4e605b81c8a73","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-21T15:06:58Z","pushed_at":"2017-07-21T15:54:40Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69275,"stargazers_count":8953,"watchers_count":8953,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1188,"mirror_url":null,"open_issues_count":2147,"forks":1188,"open_issues":2147,"watchers":8953,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"d850a8061a37232dbe5ae1db5b0d364200af8a60","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-21T15:06:58Z","pushed_at":"2017-07-21T15:54:40Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69275,"stargazers_count":8953,"watchers_count":8953,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1188,"mirror_url":null,"open_issues_count":2147,"forks":1188,"open_issues":2147,"watchers":8953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/16391"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/16391"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/16391/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16391/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/0440ecd9020e064c35ef11886cd4e605b81c8a73"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danhauk","id":448298,"avatar_url":"https://avatars0.githubusercontent.com/u/448298?v=4","gravatar_id":"","url":"https://api.github.com/users/danhauk","html_url":"https://github.com/danhauk","followers_url":"https://api.github.com/users/danhauk/followers","following_url":"https://api.github.com/users/danhauk/following{/other_user}","gists_url":"https://api.github.com/users/danhauk/gists{/gist_id}","starred_url":"https://api.github.com/users/danhauk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhauk/subscriptions","organizations_url":"https://api.github.com/users/danhauk/orgs","repos_url":"https://api.github.com/users/danhauk/repos","events_url":"https://api.github.com/users/danhauk/events{/privacy}","received_events_url":"https://api.github.com/users/danhauk/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":136,"deletions":103,"changed_files":7}}
{"actor":{"display_login":"danhauk"}}