{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/26404","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/26404/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/26404/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/26404/events","html_url":"https://github.com/ansible/ansible/pull/26404","id":240460793,"number":26404,"title":"win_xml module for manipulating XML files on Windows","user":{"login":"richardcs","id":5703233,"avatar_url":"https://avatars0.githubusercontent.com/u/5703233?v=4","gravatar_id":"","url":"https://api.github.com/users/richardcs","html_url":"https://github.com/richardcs","followers_url":"https://api.github.com/users/richardcs/followers","following_url":"https://api.github.com/users/richardcs/following{/other_user}","gists_url":"https://api.github.com/users/richardcs/gists{/gist_id}","starred_url":"https://api.github.com/users/richardcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardcs/subscriptions","organizations_url":"https://api.github.com/users/richardcs/orgs","repos_url":"https://api.github.com/users/richardcs/repos","events_url":"https://api.github.com/users/richardcs/events{/privacy}","received_events_url":"https://api.github.com/users/richardcs/received_events","type":"User","site_admin":false},"labels":[{"id":562292166,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.4","name":"affects_2.4","color":"ededed","default":false},{"id":48464763,"url":"https://api.github.com/repos/ansible/ansible/labels/docs_pull_request","name":"docs_pull_request","color":"0052cc","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":473225334,"url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"ededed","default":false},{"id":153577825,"url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":108461331,"url":"https://api.github.com/repos/ansible/ansible/labels/windows","name":"windows","color":"777777","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2017-07-04T16:11:14Z","updated_at":"2017-08-12T12:27:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/26404","html_url":"https://github.com/ansible/ansible/pull/26404","diff_url":"https://github.com/ansible/ansible/pull/26404.diff","patch_url":"https://github.com/ansible/ansible/pull/26404.patch"},"body":"##### SUMMARY\r\nNew module to handle XML files on windows\r\n\r\n##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\nwin_xml\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible --version\r\nansible 2.4.0 (devel 0a6dcf4169) last updated 2017/07/03 20:14:36 (GMT -700)\r\n  config file = None\r\n  configured module search path = [u'/home/richardl/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /home/richardl/ansible/lib/ansible\r\n  executable location = /home/richardl/ansible/bin/ansible\r\n  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nwin_lineinfile is adequate for properties types of files but XML is harder to deal with. Since Powershell has native XML handling, this module just uses that for manipulating XML.\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/321978054","html_url":"https://github.com/ansible/ansible/pull/26404#issuecomment-321978054","issue_url":"https://api.github.com/repos/ansible/ansible/issues/26404","id":321978054,"user":{"login":"trondhindenes","id":1747120,"avatar_url":"https://avatars0.githubusercontent.com/u/1747120?v=4","gravatar_id":"","url":"https://api.github.com/users/trondhindenes","html_url":"https://github.com/trondhindenes","followers_url":"https://api.github.com/users/trondhindenes/followers","following_url":"https://api.github.com/users/trondhindenes/following{/other_user}","gists_url":"https://api.github.com/users/trondhindenes/gists{/gist_id}","starred_url":"https://api.github.com/users/trondhindenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondhindenes/subscriptions","organizations_url":"https://api.github.com/users/trondhindenes/orgs","repos_url":"https://api.github.com/users/trondhindenes/repos","events_url":"https://api.github.com/users/trondhindenes/events{/privacy}","received_events_url":"https://api.github.com/users/trondhindenes/received_events","type":"User","site_admin":false},"created_at":"2017-08-12T12:27:54Z","updated_at":"2017-08-12T12:27:54Z","body":"@richardcs an example that's bitten me is the \"Advanced Logging Module in IIS, the order of items here control the order in which items are written to the IIS log. So, changing the order of these fields will have an effect:\r\n```xml\r\n<logDefinition rollLogFileOnConfigChanges=\"true\" writeLogDataToDisk=\"true\" baseFileName=\"rikstv-advancedlogging\" logRaiseTraceEvents=\"false\" enabled=\"true\" logRollOption=\"Schedule\" maxDurationSeconds=\"86400\" maxFileSizeKB=\"1024\" schedule=\"Daily\" publishLogEvent=\"false\">\r\n    <selectedFields>\r\n        <logField id=\"Date-UTC\" logHeaderName=\"date\" required=\"false\" defaultValue=\"\" />\r\n        <logField id=\"Time-UTC\" logHeaderName=\"time\" required=\"false\" defaultValue=\"\" />\r\n        <logField id=\"Server Name\" logHeaderName=\"s-computername\" required=\"false\" defaultValue=\"\" />\r\n        <logField id=\"Server-IP\" logHeaderName=\"s-ip\" required=\"false\" defaultValue=\"\" />\r\n        <logField id=\"Method\" logHeaderName=\"cs-method\" required=\"false\" defaultValue=\"\" />\r\n```\r\n\r\nHow to do this right is not something we have solved in-house yet, so it's just an ask more than a requirement. Don't let this stop you guys from merging."}}
{"actor":{"display_login":"trondhindenes"}}