{"action":"opened","number":566,"pull_request":{"url":"https://api.github.com/repos/nimble-dev/nimble/pulls/566","id":138731247,"html_url":"https://github.com/nimble-dev/nimble/pull/566","diff_url":"https://github.com/nimble-dev/nimble/pull/566.diff","patch_url":"https://github.com/nimble-dev/nimble/pull/566.patch","issue_url":"https://api.github.com/repos/nimble-dev/nimble/issues/566","number":566,"state":"open","locked":false,"title":"Fix #538","user":{"login":"perrydv","id":8012337,"avatar_url":"https://avatars3.githubusercontent.com/u/8012337?v=4","gravatar_id":"","url":"https://api.github.com/users/perrydv","html_url":"https://github.com/perrydv","followers_url":"https://api.github.com/users/perrydv/followers","following_url":"https://api.github.com/users/perrydv/following{/other_user}","gists_url":"https://api.github.com/users/perrydv/gists{/gist_id}","starred_url":"https://api.github.com/users/perrydv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrydv/subscriptions","organizations_url":"https://api.github.com/users/perrydv/orgs","repos_url":"https://api.github.com/users/perrydv/repos","events_url":"https://api.github.com/users/perrydv/events{/privacy}","received_events_url":"https://api.github.com/users/perrydv/received_events","type":"User","site_admin":false},"body":"The problem with Issue #538 was in size processing of `step` and other unary functions that can handle scalar or non-scalar input (and operate component-wise on non-scalar input).  \r\n\r\nFor background, in a case like `step(foo(x))`, where `foo(x)` *cannot* be turned into eigen code, we put the result of `foo(x)` into an intermediate and then proceed to generate eigen code for `step(<Intermediate>)`.  That works fine.  \r\n\r\nThe missing case was somewhat opposite: `step( inprod(a, b))`, where `inprod(a, b)` can and should be turned into eigen code but then the scalar version of `step`, not its `eigen` version, should be used.  This was not being identified in `sizeUnaryCwise`, resulting in failure to eigenize `inprod(a, b)`.  \r\n\r\nThis bug impacted all unary functions. E.g., `exp(inprod(a, b))` also did not work.\r\n\r\nIn this pull request, logic has been added to `sizeUnaryCwise` to create an intermediate if the argument to the unary is marked for eigenization but returns a scalar.\r\n\r\nA regression test has been added to `test-coreR.R`.\r\n","created_at":"2017-08-31T18:06:58Z","updated_at":"2017-08-31T18:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nimble-dev/nimble/pulls/566/commits","review_comments_url":"https://api.github.com/repos/nimble-dev/nimble/pulls/566/comments","review_comment_url":"https://api.github.com/repos/nimble-dev/nimble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nimble-dev/nimble/issues/566/comments","statuses_url":"https://api.github.com/repos/nimble-dev/nimble/statuses/a8021c7095df1cce9ed1ed0b0e64aed9a94d4c25","head":{"label":"nimble-dev:fixIssue538","ref":"fixIssue538","sha":"a8021c7095df1cce9ed1ed0b0e64aed9a94d4c25","user":{"login":"nimble-dev","id":7871767,"avatar_url":"https://avatars0.githubusercontent.com/u/7871767?v=4","gravatar_id":"","url":"https://api.github.com/users/nimble-dev","html_url":"https://github.com/nimble-dev","followers_url":"https://api.github.com/users/nimble-dev/followers","following_url":"https://api.github.com/users/nimble-dev/following{/other_user}","gists_url":"https://api.github.com/users/nimble-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nimble-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimble-dev/subscriptions","organizations_url":"https://api.github.com/users/nimble-dev/orgs","repos_url":"https://api.github.com/users/nimble-dev/repos","events_url":"https://api.github.com/users/nimble-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nimble-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":20771527,"name":"nimble","full_name":"nimble-dev/nimble","owner":{"login":"nimble-dev","id":7871767,"avatar_url":"https://avatars0.githubusercontent.com/u/7871767?v=4","gravatar_id":"","url":"https://api.github.com/users/nimble-dev","html_url":"https://github.com/nimble-dev","followers_url":"https://api.github.com/users/nimble-dev/followers","following_url":"https://api.github.com/users/nimble-dev/following{/other_user}","gists_url":"https://api.github.com/users/nimble-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nimble-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimble-dev/subscriptions","organizations_url":"https://api.github.com/users/nimble-dev/orgs","repos_url":"https://api.github.com/users/nimble-dev/repos","events_url":"https://api.github.com/users/nimble-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nimble-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nimble-dev/nimble","description":"The base NIMBLE package for R","fork":false,"url":"https://api.github.com/repos/nimble-dev/nimble","forks_url":"https://api.github.com/repos/nimble-dev/nimble/forks","keys_url":"https://api.github.com/repos/nimble-dev/nimble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimble-dev/nimble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimble-dev/nimble/teams","hooks_url":"https://api.github.com/repos/nimble-dev/nimble/hooks","issue_events_url":"https://api.github.com/repos/nimble-dev/nimble/issues/events{/number}","events_url":"https://api.github.com/repos/nimble-dev/nimble/events","assignees_url":"https://api.github.com/repos/nimble-dev/nimble/assignees{/user}","branches_url":"https://api.github.com/repos/nimble-dev/nimble/branches{/branch}","tags_url":"https://api.github.com/repos/nimble-dev/nimble/tags","blobs_url":"https://api.github.com/repos/nimble-dev/nimble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimble-dev/nimble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimble-dev/nimble/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimble-dev/nimble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimble-dev/nimble/statuses/{sha}","languages_url":"https://api.github.com/repos/nimble-dev/nimble/languages","stargazers_url":"https://api.github.com/repos/nimble-dev/nimble/stargazers","contributors_url":"https://api.github.com/repos/nimble-dev/nimble/contributors","subscribers_url":"https://api.github.com/repos/nimble-dev/nimble/subscribers","subscription_url":"https://api.github.com/repos/nimble-dev/nimble/subscription","commits_url":"https://api.github.com/repos/nimble-dev/nimble/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimble-dev/nimble/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimble-dev/nimble/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimble-dev/nimble/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimble-dev/nimble/contents/{+path}","compare_url":"https://api.github.com/repos/nimble-dev/nimble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimble-dev/nimble/merges","archive_url":"https://api.github.com/repos/nimble-dev/nimble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimble-dev/nimble/downloads","issues_url":"https://api.github.com/repos/nimble-dev/nimble/issues{/number}","pulls_url":"https://api.github.com/repos/nimble-dev/nimble/pulls{/number}","milestones_url":"https://api.github.com/repos/nimble-dev/nimble/milestones{/number}","notifications_url":"https://api.github.com/repos/nimble-dev/nimble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimble-dev/nimble/labels{/name}","releases_url":"https://api.github.com/repos/nimble-dev/nimble/releases{/id}","deployments_url":"https://api.github.com/repos/nimble-dev/nimble/deployments","created_at":"2014-06-12T14:58:42Z","updated_at":"2017-08-02T17:06:47Z","pushed_at":"2017-08-31T17:58:33Z","git_url":"git://github.com/nimble-dev/nimble.git","ssh_url":"git@github.com:nimble-dev/nimble.git","clone_url":"https://github.com/nimble-dev/nimble.git","svn_url":"https://github.com/nimble-dev/nimble","homepage":"http://R-nimble.org","size":18424,"stargazers_count":42,"watchers_count":42,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":70,"forks":9,"open_issues":70,"watchers":42,"default_branch":"devel"}},"base":{"label":"nimble-dev:devel","ref":"devel","sha":"4c26d4bf5a1a2c84e0017e6d7bd161f8f8a3c1ea","user":{"login":"nimble-dev","id":7871767,"avatar_url":"https://avatars0.githubusercontent.com/u/7871767?v=4","gravatar_id":"","url":"https://api.github.com/users/nimble-dev","html_url":"https://github.com/nimble-dev","followers_url":"https://api.github.com/users/nimble-dev/followers","following_url":"https://api.github.com/users/nimble-dev/following{/other_user}","gists_url":"https://api.github.com/users/nimble-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nimble-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimble-dev/subscriptions","organizations_url":"https://api.github.com/users/nimble-dev/orgs","repos_url":"https://api.github.com/users/nimble-dev/repos","events_url":"https://api.github.com/users/nimble-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nimble-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":20771527,"name":"nimble","full_name":"nimble-dev/nimble","owner":{"login":"nimble-dev","id":7871767,"avatar_url":"https://avatars0.githubusercontent.com/u/7871767?v=4","gravatar_id":"","url":"https://api.github.com/users/nimble-dev","html_url":"https://github.com/nimble-dev","followers_url":"https://api.github.com/users/nimble-dev/followers","following_url":"https://api.github.com/users/nimble-dev/following{/other_user}","gists_url":"https://api.github.com/users/nimble-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nimble-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimble-dev/subscriptions","organizations_url":"https://api.github.com/users/nimble-dev/orgs","repos_url":"https://api.github.com/users/nimble-dev/repos","events_url":"https://api.github.com/users/nimble-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nimble-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nimble-dev/nimble","description":"The base NIMBLE package for R","fork":false,"url":"https://api.github.com/repos/nimble-dev/nimble","forks_url":"https://api.github.com/repos/nimble-dev/nimble/forks","keys_url":"https://api.github.com/repos/nimble-dev/nimble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimble-dev/nimble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimble-dev/nimble/teams","hooks_url":"https://api.github.com/repos/nimble-dev/nimble/hooks","issue_events_url":"https://api.github.com/repos/nimble-dev/nimble/issues/events{/number}","events_url":"https://api.github.com/repos/nimble-dev/nimble/events","assignees_url":"https://api.github.com/repos/nimble-dev/nimble/assignees{/user}","branches_url":"https://api.github.com/repos/nimble-dev/nimble/branches{/branch}","tags_url":"https://api.github.com/repos/nimble-dev/nimble/tags","blobs_url":"https://api.github.com/repos/nimble-dev/nimble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimble-dev/nimble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimble-dev/nimble/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimble-dev/nimble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimble-dev/nimble/statuses/{sha}","languages_url":"https://api.github.com/repos/nimble-dev/nimble/languages","stargazers_url":"https://api.github.com/repos/nimble-dev/nimble/stargazers","contributors_url":"https://api.github.com/repos/nimble-dev/nimble/contributors","subscribers_url":"https://api.github.com/repos/nimble-dev/nimble/subscribers","subscription_url":"https://api.github.com/repos/nimble-dev/nimble/subscription","commits_url":"https://api.github.com/repos/nimble-dev/nimble/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimble-dev/nimble/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimble-dev/nimble/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimble-dev/nimble/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimble-dev/nimble/contents/{+path}","compare_url":"https://api.github.com/repos/nimble-dev/nimble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimble-dev/nimble/merges","archive_url":"https://api.github.com/repos/nimble-dev/nimble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimble-dev/nimble/downloads","issues_url":"https://api.github.com/repos/nimble-dev/nimble/issues{/number}","pulls_url":"https://api.github.com/repos/nimble-dev/nimble/pulls{/number}","milestones_url":"https://api.github.com/repos/nimble-dev/nimble/milestones{/number}","notifications_url":"https://api.github.com/repos/nimble-dev/nimble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimble-dev/nimble/labels{/name}","releases_url":"https://api.github.com/repos/nimble-dev/nimble/releases{/id}","deployments_url":"https://api.github.com/repos/nimble-dev/nimble/deployments","created_at":"2014-06-12T14:58:42Z","updated_at":"2017-08-02T17:06:47Z","pushed_at":"2017-08-31T17:58:33Z","git_url":"git://github.com/nimble-dev/nimble.git","ssh_url":"git@github.com:nimble-dev/nimble.git","clone_url":"https://github.com/nimble-dev/nimble.git","svn_url":"https://github.com/nimble-dev/nimble","homepage":"http://R-nimble.org","size":18424,"stargazers_count":42,"watchers_count":42,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":70,"forks":9,"open_issues":70,"watchers":42,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nimble-dev/nimble/pulls/566"},"html":{"href":"https://github.com/nimble-dev/nimble/pull/566"},"issue":{"href":"https://api.github.com/repos/nimble-dev/nimble/issues/566"},"comments":{"href":"https://api.github.com/repos/nimble-dev/nimble/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/nimble-dev/nimble/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/nimble-dev/nimble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nimble-dev/nimble/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/nimble-dev/nimble/statuses/a8021c7095df1cce9ed1ed0b0e64aed9a94d4c25"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":41,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"perrydv"}}