{"action":"created","comment":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments/96296418","pull_request_review_id":16874010,"id":96296418,"diff_hunk":"@@ -1071,6 +1071,21 @@ code {\n       background-color: #666;\n     }\n   }\n+  .hamburger-dropdown {\n+    .dropdown .dropdown-menu,\n+    .open #nav-Community-dropdown {","path":"client/less/main.less","position":6,"original_position":6,"commit_id":"970f00e141a424865d7514af7cd762f9fd6b7a26","original_commit_id":"970f00e141a424865d7514af7cd762f9fd6b7a26","user":{"login":"systimotic","id":7262039,"avatar_url":"https://avatars.githubusercontent.com/u/7262039?v=3","gravatar_id":"","url":"https://api.github.com/users/systimotic","html_url":"https://github.com/systimotic","followers_url":"https://api.github.com/users/systimotic/followers","following_url":"https://api.github.com/users/systimotic/following{/other_user}","gists_url":"https://api.github.com/users/systimotic/gists{/gist_id}","starred_url":"https://api.github.com/users/systimotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systimotic/subscriptions","organizations_url":"https://api.github.com/users/systimotic/orgs","repos_url":"https://api.github.com/users/systimotic/repos","events_url":"https://api.github.com/users/systimotic/events{/privacy}","received_events_url":"https://api.github.com/users/systimotic/received_events","type":"User","site_admin":false},"body":"I think the selectors could be condensed a bit. The selector for the `a` inside of this would be \r\n```css\r\n.night .hamburger-dropdown .dropdown .dropdown-menu a\r\n```\r\nEverything seemed to work the same without `.dropdown`.\r\n`.hamburger-dropdown` was only required for the link hovering section.\r\n\r\nThat makes the selector for the same `a`\r\n```css\r\n.night .dropdown-menu a\r\n```\r\nWhile keeping the same amount of lines of code.","created_at":"2017-01-16T19:56:28Z","updated_at":"2017-01-16T20:01:25Z","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556#discussion_r96296418","pull_request_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556","_links":{"self":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments/96296418"},"html":{"href":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556#discussion_r96296418"},"pull_request":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556"}}},"pull_request":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556","id":101743510,"html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556","diff_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556.diff","patch_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556.patch","issue_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/12556","number":12556,"state":"open","locked":false,"title":"added nightmode styling to community dropdown menu, fixed dfn padding","user":{"login":"no-stack-dub-sack","id":18563015,"avatar_url":"https://avatars.githubusercontent.com/u/18563015?v=3","gravatar_id":"","url":"https://api.github.com/users/no-stack-dub-sack","html_url":"https://github.com/no-stack-dub-sack","followers_url":"https://api.github.com/users/no-stack-dub-sack/followers","following_url":"https://api.github.com/users/no-stack-dub-sack/following{/other_user}","gists_url":"https://api.github.com/users/no-stack-dub-sack/gists{/gist_id}","starred_url":"https://api.github.com/users/no-stack-dub-sack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-stack-dub-sack/subscriptions","organizations_url":"https://api.github.com/users/no-stack-dub-sack/orgs","repos_url":"https://api.github.com/users/no-stack-dub-sack/repos","events_url":"https://api.github.com/users/no-stack-dub-sack/events{/privacy}","received_events_url":"https://api.github.com/users/no-stack-dub-sack/received_events","type":"User","site_admin":false},"body":"…ding\r\n\r\n<!-- freeCodeCamp Pull Request Template -->\r\n\r\n<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->\r\n<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->\r\n<!-- Make sure that your PR is not a duplicate -->\r\n\r\n#### Pre-Submission Checklist\r\n<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->\r\n<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->\r\n<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] Your pull request targets the `staging` branch of freeCodeCamp.\r\n- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)\r\n- [x] You have only one commit (if not, [squash](http://forum.freecodecamp.com/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).\r\n- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.\r\n\r\n#### Type of Change\r\n<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->\r\n- [x] Small bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds new functionality)\r\n- [ ] Breaking change (fix or feature that would change existing functionality)\r\n- [ ] Add new translation (feature adding new translations)\r\n\r\n#### Checklist:\r\n<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->\r\n<!-- If you're unsure about any of these, don't hesitate to ask in the Help Contributors room linked above. We're here to help! -->\r\n- [x] Tested changes locally.\r\n- [x] Closes currently open issue (replace XXXX with an issue no): Closes #12538\r\n\r\n#### Description\r\n<!-- Describe your changes in detail -->\r\n- Added styling to Community dropdown menu per #12538\r\n- Also added styling to all nav bar items for `:active` and `:focus` states, as before they were still day mode colors\r\n- Used existing nightmode and brand colors only (`@gray`, `@night-text-color`, `#666` & `@link-hover-color`)\r\n- Also, while I was at it, fixed the padding on `<dfn>` tags within `.challenge-instructions` to match the padding on `<code>` tags, as this has been nagging at me for a bit, previously there was no padding and it looked a little funny.\r\n- Examples of both below.\r\n![image](https://cloud.githubusercontent.com/assets/18563015/21995125/2fa9ab5c-dbf1-11e6-9009-1c2098f4f551.png)\r\n![image](https://cloud.githubusercontent.com/assets/18563015/21995823/f996d946-dbf4-11e6-8a3d-8b8fbe22017a.png)\r\n","created_at":"2017-01-16T19:06:45Z","updated_at":"2017-01-16T20:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f152df050a22488e71117ee194d7bb08677b81ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556/commits","review_comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556/comments","review_comment_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/12556/comments","statuses_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/970f00e141a424865d7514af7cd762f9fd6b7a26","head":{"label":"no-stack-dub-sack:fix/nightmode-community-dropdown","ref":"fix/nightmode-community-dropdown","sha":"970f00e141a424865d7514af7cd762f9fd6b7a26","user":{"login":"no-stack-dub-sack","id":18563015,"avatar_url":"https://avatars.githubusercontent.com/u/18563015?v=3","gravatar_id":"","url":"https://api.github.com/users/no-stack-dub-sack","html_url":"https://github.com/no-stack-dub-sack","followers_url":"https://api.github.com/users/no-stack-dub-sack/followers","following_url":"https://api.github.com/users/no-stack-dub-sack/following{/other_user}","gists_url":"https://api.github.com/users/no-stack-dub-sack/gists{/gist_id}","starred_url":"https://api.github.com/users/no-stack-dub-sack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-stack-dub-sack/subscriptions","organizations_url":"https://api.github.com/users/no-stack-dub-sack/orgs","repos_url":"https://api.github.com/users/no-stack-dub-sack/repos","events_url":"https://api.github.com/users/no-stack-dub-sack/events{/privacy}","received_events_url":"https://api.github.com/users/no-stack-dub-sack/received_events","type":"User","site_admin":false},"repo":{"id":78902301,"name":"freeCodeCamp","full_name":"no-stack-dub-sack/freeCodeCamp","owner":{"login":"no-stack-dub-sack","id":18563015,"avatar_url":"https://avatars.githubusercontent.com/u/18563015?v=3","gravatar_id":"","url":"https://api.github.com/users/no-stack-dub-sack","html_url":"https://github.com/no-stack-dub-sack","followers_url":"https://api.github.com/users/no-stack-dub-sack/followers","following_url":"https://api.github.com/users/no-stack-dub-sack/following{/other_user}","gists_url":"https://api.github.com/users/no-stack-dub-sack/gists{/gist_id}","starred_url":"https://api.github.com/users/no-stack-dub-sack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-stack-dub-sack/subscriptions","organizations_url":"https://api.github.com/users/no-stack-dub-sack/orgs","repos_url":"https://api.github.com/users/no-stack-dub-sack/repos","events_url":"https://api.github.com/users/no-stack-dub-sack/events{/privacy}","received_events_url":"https://api.github.com/users/no-stack-dub-sack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/no-stack-dub-sack/freeCodeCamp","description":"The https://freeCodeCamp.com open source codebase and curriculum. Learn to code and help nonprofits.","fork":true,"url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp","forks_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/forks","keys_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/teams","hooks_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/hooks","issue_events_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/issues/events{/number}","events_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/events","assignees_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/assignees{/user}","branches_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/branches{/branch}","tags_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/tags","blobs_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/git/refs{/sha}","trees_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/statuses/{sha}","languages_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/languages","stargazers_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/stargazers","contributors_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/contributors","subscribers_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/subscribers","subscription_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/subscription","commits_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/commits{/sha}","git_commits_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/git/commits{/sha}","comments_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/comments{/number}","issue_comment_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/issues/comments{/number}","contents_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/contents/{+path}","compare_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/merges","archive_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/downloads","issues_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/issues{/number}","pulls_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/pulls{/number}","milestones_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/milestones{/number}","notifications_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/labels{/name}","releases_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/releases{/id}","deployments_url":"https://api.github.com/repos/no-stack-dub-sack/freeCodeCamp/deployments","created_at":"2017-01-14T01:42:42Z","updated_at":"2017-01-14T01:42:46Z","pushed_at":"2017-01-16T18:57:03Z","git_url":"git://github.com/no-stack-dub-sack/freeCodeCamp.git","ssh_url":"git@github.com:no-stack-dub-sack/freeCodeCamp.git","clone_url":"https://github.com/no-stack-dub-sack/freeCodeCamp.git","svn_url":"https://github.com/no-stack-dub-sack/freeCodeCamp","homepage":"","size":27651,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"freeCodeCamp:staging","ref":"staging","sha":"9d438d2d7c26e8ee121b9010e86937dca0f3a42f","user":{"login":"freeCodeCamp","id":9892522,"avatar_url":"https://avatars.githubusercontent.com/u/9892522?v=3","gravatar_id":"","url":"https://api.github.com/users/freeCodeCamp","html_url":"https://github.com/freeCodeCamp","followers_url":"https://api.github.com/users/freeCodeCamp/followers","following_url":"https://api.github.com/users/freeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/freeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/freeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/freeCodeCamp/orgs","repos_url":"https://api.github.com/users/freeCodeCamp/repos","events_url":"https://api.github.com/users/freeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/freeCodeCamp/received_events","type":"Organization","site_admin":false},"repo":{"id":28457823,"name":"freeCodeCamp","full_name":"freeCodeCamp/freeCodeCamp","owner":{"login":"freeCodeCamp","id":9892522,"avatar_url":"https://avatars.githubusercontent.com/u/9892522?v=3","gravatar_id":"","url":"https://api.github.com/users/freeCodeCamp","html_url":"https://github.com/freeCodeCamp","followers_url":"https://api.github.com/users/freeCodeCamp/followers","following_url":"https://api.github.com/users/freeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/freeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/freeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/freeCodeCamp/orgs","repos_url":"https://api.github.com/users/freeCodeCamp/repos","events_url":"https://api.github.com/users/freeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/freeCodeCamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeCodeCamp/freeCodeCamp","description":"The https://freeCodeCamp.com open source codebase and curriculum. Learn to code and help nonprofits.","fork":false,"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp","forks_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/forks","keys_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/teams","hooks_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/hooks","issue_events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/events{/number}","events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/events","assignees_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/assignees{/user}","branches_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/branches{/branch}","tags_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/tags","blobs_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/{sha}","languages_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/languages","stargazers_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/stargazers","contributors_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/contributors","subscribers_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/subscribers","subscription_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/subscription","commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/contents/{+path}","compare_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/merges","archive_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/downloads","issues_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues{/number}","pulls_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls{/number}","milestones_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/milestones{/number}","notifications_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/labels{/name}","releases_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/releases{/id}","deployments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/deployments","created_at":"2014-12-24T17:49:19Z","updated_at":"2017-01-16T19:57:05Z","pushed_at":"2017-01-16T19:33:24Z","git_url":"git://github.com/freeCodeCamp/freeCodeCamp.git","ssh_url":"git@github.com:freeCodeCamp/freeCodeCamp.git","clone_url":"https://github.com/freeCodeCamp/freeCodeCamp.git","svn_url":"https://github.com/freeCodeCamp/freeCodeCamp","homepage":"","size":27645,"stargazers_count":221599,"watchers_count":221599,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8870,"mirror_url":null,"open_issues_count":162,"forks":8870,"open_issues":162,"watchers":221599,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556"},"html":{"href":"https://github.com/freeCodeCamp/freeCodeCamp/pull/12556"},"issue":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/12556"},"comments":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/12556/comments"},"review_comments":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556/comments"},"review_comment":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/12556/commits"},"statuses":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/970f00e141a424865d7514af7cd762f9fd6b7a26"}}}}
{"actor":{"display_login":"systimotic"}}