{"action":"created","comment":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments/150203117","pull_request_review_id":75719186,"id":150203117,"diff_hunk":"@@ -287,6 +287,9 @@ def _apply_xheaders(self, headers):\n         proto_header = headers.get(\n             \"X-Scheme\", headers.get(\"X-Forwarded-Proto\",\n                                     self.protocol))\n+        if proto_header:\n+            # use the outermost proto entry if there is more than one","path":"tornado/httpserver.py","position":5,"original_position":5,"commit_id":"8d96557923ddcb8801fe12e506fac67342f43d6f","original_commit_id":"8d96557923ddcb8801fe12e506fac67342f43d6f","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"@psyvision in your specific case, I think you'll be okay because both hops happen to be https.\r\n\r\nI'll follow @bdarnell's recommendation and investigate a more direct way for JupyterHub to identify whether the browser views the request as coming over https in the future, since what we really care about in that particular case is the Browser's opinion, not any of the proxy hops.","created_at":"2017-11-10T10:38:59Z","updated_at":"2017-11-10T10:38:59Z","html_url":"https://github.com/tornadoweb/tornado/pull/2162#discussion_r150203117","pull_request_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments/150203117"},"html":{"href":"https://github.com/tornadoweb/tornado/pull/2162#discussion_r150203117"},"pull_request":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162"}},"in_reply_to_id":146111128},"pull_request":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162","id":146413030,"html_url":"https://github.com/tornadoweb/tornado/pull/2162","diff_url":"https://github.com/tornadoweb/tornado/pull/2162.diff","patch_url":"https://github.com/tornadoweb/tornado/pull/2162.patch","issue_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2162","number":2162,"state":"open","locked":false,"title":"handle multiple values in X-Forwarded-Proto","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"use the first entry, which should be the outermost value\n\ncloses #2161","created_at":"2017-10-13T09:39:28Z","updated_at":"2017-11-10T10:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af670c318b068a8678b53aa0534db0fe06147e69","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162/commits","review_comments_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162/comments","review_comment_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2162/comments","statuses_url":"https://api.github.com/repos/tornadoweb/tornado/statuses/8d96557923ddcb8801fe12e506fac67342f43d6f","head":{"label":"minrk:forwarded-proto-list","ref":"forwarded-proto-list","sha":"8d96557923ddcb8801fe12e506fac67342f43d6f","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":2506578,"name":"tornado","full_name":"minrk/tornado","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/tornado","description":"Tornado is an open source version of the scalable, non-blocking web server and tools that power FriendFeed.","fork":true,"url":"https://api.github.com/repos/minrk/tornado","forks_url":"https://api.github.com/repos/minrk/tornado/forks","keys_url":"https://api.github.com/repos/minrk/tornado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/tornado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/tornado/teams","hooks_url":"https://api.github.com/repos/minrk/tornado/hooks","issue_events_url":"https://api.github.com/repos/minrk/tornado/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/tornado/events","assignees_url":"https://api.github.com/repos/minrk/tornado/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/tornado/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/tornado/tags","blobs_url":"https://api.github.com/repos/minrk/tornado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/tornado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/tornado/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/tornado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/tornado/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/tornado/languages","stargazers_url":"https://api.github.com/repos/minrk/tornado/stargazers","contributors_url":"https://api.github.com/repos/minrk/tornado/contributors","subscribers_url":"https://api.github.com/repos/minrk/tornado/subscribers","subscription_url":"https://api.github.com/repos/minrk/tornado/subscription","commits_url":"https://api.github.com/repos/minrk/tornado/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/tornado/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/tornado/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/tornado/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/tornado/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/tornado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/tornado/merges","archive_url":"https://api.github.com/repos/minrk/tornado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/tornado/downloads","issues_url":"https://api.github.com/repos/minrk/tornado/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/tornado/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/tornado/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/tornado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/tornado/labels{/name}","releases_url":"https://api.github.com/repos/minrk/tornado/releases{/id}","deployments_url":"https://api.github.com/repos/minrk/tornado/deployments","created_at":"2011-10-03T18:20:51Z","updated_at":"2017-02-27T08:25:07Z","pushed_at":"2017-10-13T09:39:14Z","git_url":"git://github.com/minrk/tornado.git","ssh_url":"git@github.com:minrk/tornado.git","clone_url":"https://github.com/minrk/tornado.git","svn_url":"https://github.com/minrk/tornado","homepage":"http://www.tornadoweb.org/","size":7271,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tornadoweb:master","ref":"master","sha":"37081d792896a44d27c3423b73001937d972c806","user":{"login":"tornadoweb","id":7468980,"avatar_url":"https://avatars3.githubusercontent.com/u/7468980?v=4","gravatar_id":"","url":"https://api.github.com/users/tornadoweb","html_url":"https://github.com/tornadoweb","followers_url":"https://api.github.com/users/tornadoweb/followers","following_url":"https://api.github.com/users/tornadoweb/following{/other_user}","gists_url":"https://api.github.com/users/tornadoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/tornadoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornadoweb/subscriptions","organizations_url":"https://api.github.com/users/tornadoweb/orgs","repos_url":"https://api.github.com/users/tornadoweb/repos","events_url":"https://api.github.com/users/tornadoweb/events{/privacy}","received_events_url":"https://api.github.com/users/tornadoweb/received_events","type":"Organization","site_admin":false},"repo":{"id":301742,"name":"tornado","full_name":"tornadoweb/tornado","owner":{"login":"tornadoweb","id":7468980,"avatar_url":"https://avatars3.githubusercontent.com/u/7468980?v=4","gravatar_id":"","url":"https://api.github.com/users/tornadoweb","html_url":"https://github.com/tornadoweb","followers_url":"https://api.github.com/users/tornadoweb/followers","following_url":"https://api.github.com/users/tornadoweb/following{/other_user}","gists_url":"https://api.github.com/users/tornadoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/tornadoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornadoweb/subscriptions","organizations_url":"https://api.github.com/users/tornadoweb/orgs","repos_url":"https://api.github.com/users/tornadoweb/repos","events_url":"https://api.github.com/users/tornadoweb/events{/privacy}","received_events_url":"https://api.github.com/users/tornadoweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tornadoweb/tornado","description":"Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed.","fork":false,"url":"https://api.github.com/repos/tornadoweb/tornado","forks_url":"https://api.github.com/repos/tornadoweb/tornado/forks","keys_url":"https://api.github.com/repos/tornadoweb/tornado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tornadoweb/tornado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tornadoweb/tornado/teams","hooks_url":"https://api.github.com/repos/tornadoweb/tornado/hooks","issue_events_url":"https://api.github.com/repos/tornadoweb/tornado/issues/events{/number}","events_url":"https://api.github.com/repos/tornadoweb/tornado/events","assignees_url":"https://api.github.com/repos/tornadoweb/tornado/assignees{/user}","branches_url":"https://api.github.com/repos/tornadoweb/tornado/branches{/branch}","tags_url":"https://api.github.com/repos/tornadoweb/tornado/tags","blobs_url":"https://api.github.com/repos/tornadoweb/tornado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tornadoweb/tornado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tornadoweb/tornado/git/refs{/sha}","trees_url":"https://api.github.com/repos/tornadoweb/tornado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tornadoweb/tornado/statuses/{sha}","languages_url":"https://api.github.com/repos/tornadoweb/tornado/languages","stargazers_url":"https://api.github.com/repos/tornadoweb/tornado/stargazers","contributors_url":"https://api.github.com/repos/tornadoweb/tornado/contributors","subscribers_url":"https://api.github.com/repos/tornadoweb/tornado/subscribers","subscription_url":"https://api.github.com/repos/tornadoweb/tornado/subscription","commits_url":"https://api.github.com/repos/tornadoweb/tornado/commits{/sha}","git_commits_url":"https://api.github.com/repos/tornadoweb/tornado/git/commits{/sha}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/comments{/number}","issue_comment_url":"https://api.github.com/repos/tornadoweb/tornado/issues/comments{/number}","contents_url":"https://api.github.com/repos/tornadoweb/tornado/contents/{+path}","compare_url":"https://api.github.com/repos/tornadoweb/tornado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tornadoweb/tornado/merges","archive_url":"https://api.github.com/repos/tornadoweb/tornado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tornadoweb/tornado/downloads","issues_url":"https://api.github.com/repos/tornadoweb/tornado/issues{/number}","pulls_url":"https://api.github.com/repos/tornadoweb/tornado/pulls{/number}","milestones_url":"https://api.github.com/repos/tornadoweb/tornado/milestones{/number}","notifications_url":"https://api.github.com/repos/tornadoweb/tornado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tornadoweb/tornado/labels{/name}","releases_url":"https://api.github.com/repos/tornadoweb/tornado/releases{/id}","deployments_url":"https://api.github.com/repos/tornadoweb/tornado/deployments","created_at":"2009-09-09T04:55:16Z","updated_at":"2017-11-10T07:46:16Z","pushed_at":"2017-11-10T05:37:49Z","git_url":"git://github.com/tornadoweb/tornado.git","ssh_url":"git@github.com:tornadoweb/tornado.git","clone_url":"https://github.com/tornadoweb/tornado.git","svn_url":"https://github.com/tornadoweb/tornado","homepage":"http://www.tornadoweb.org/","size":7404,"stargazers_count":14563,"watchers_count":14563,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4302,"mirror_url":null,"archived":false,"open_issues_count":215,"forks":4302,"open_issues":215,"watchers":14563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162"},"html":{"href":"https://github.com/tornadoweb/tornado/pull/2162"},"issue":{"href":"https://api.github.com/repos/tornadoweb/tornado/issues/2162"},"comments":{"href":"https://api.github.com/repos/tornadoweb/tornado/issues/2162/comments"},"review_comments":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162/comments"},"review_comment":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2162/commits"},"statuses":{"href":"https://api.github.com/repos/tornadoweb/tornado/statuses/8d96557923ddcb8801fe12e506fac67342f43d6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"minrk"}}