{"action":"created","comment":{"url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/comments/101769905","pull_request_review_id":22509672,"id":101769905,"diff_hunk":"@@ -0,0 +1,53 @@\n+<?php\n+/* Copyright (c) 2017 Nils Haagen <nils.haagen@concepts-and-training.de> Extended GPL, see ./LICENSE */\n+\n+require_once(__DIR__ .'/../vendor/autoload.php');\n+require_once(__DIR__ .'/TestingEnvironment.php');\n+\n+use CaT\\Plugins\\Jill\\Environment;\n+use CaT\\Plugins\\Jill\\RPC;\n+\n+class ProceduresTestTest extends \\PHPUnit_Framework_TestCase {\n+\tuse TestingUtils; //trait in TestingEnvironment.php\n+\n+\tprotected $backupGlobals = FALSE; //otherwise, ilias won't work\n+\n+\tpublic function setUp() {\n+\t\t$this->environment = new TestEnvironment($this);\n+\t}\n+\n+\tpublic function test_GetTestURL() {\n+\t\trequire_once(__DIR__ .'/../classes/RPC/Procedures/Test/GetTestURL.php');\n+\t\t$proc = new GetTestURL($this->environment);\n+\t\t$this->assertEquals(\n+\t\t\t$this->invokeMethod($proc, 'isSecurityRelevant'),\n+\t\t\tfalse\n+\t\t);\n+\n+\t\t$expected = '?cmd=start&cmdClass=ilsurveyexecutiongui&cmdNode=kj:tx&baseClass=ilobjsurveygui&ref_id=';\n+\t\t$results = $proc->run(10); //ref_id\n+\n+\t\t$this->assertEquals(\n+\t\t\t$expected,\n+\t\t\t$results\n+\t\t);\n+\t}\n+\n+\tpublic function test_GetTestProgress() {\n+\t\trequire_once(__DIR__ .'/../classes/RPC/Procedures/Test/GetTestProgress.php');\n+\t\t$proc = new GetTestProgress($this->environment);\n+\t\t$this->assertEquals(\n+\t\t\t$this->invokeMethod($proc, 'isSecurityRelevant'),","path":"tests/ProceduresTestTest.php","position":40,"original_position":40,"commit_id":"ca47de1564d6a2fe893916569defe59403308813","original_commit_id":"ca47de1564d6a2fe893916569defe59403308813","user":{"login":"nlzh","id":3328364,"avatar_url":"https://avatars.githubusercontent.com/u/3328364?v=3","gravatar_id":"","url":"https://api.github.com/users/nlzh","html_url":"https://github.com/nlzh","followers_url":"https://api.github.com/users/nlzh/followers","following_url":"https://api.github.com/users/nlzh/following{/other_user}","gists_url":"https://api.github.com/users/nlzh/gists{/gist_id}","starred_url":"https://api.github.com/users/nlzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlzh/subscriptions","organizations_url":"https://api.github.com/users/nlzh/orgs","repos_url":"https://api.github.com/users/nlzh/repos","events_url":"https://api.github.com/users/nlzh/events{/privacy}","received_events_url":"https://api.github.com/users/nlzh/received_events","type":"User","site_admin":false},"body":" * https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/\r\n\r\n * Call protected/private method of a class.","created_at":"2017-02-17T14:44:30Z","updated_at":"2017-02-17T14:44:30Z","html_url":"https://github.com/conceptsandtraining/Jill/pull/33#discussion_r101769905","pull_request_url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/comments/101769905"},"html":{"href":"https://github.com/conceptsandtraining/Jill/pull/33#discussion_r101769905"},"pull_request":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33","id":106558043,"html_url":"https://github.com/conceptsandtraining/Jill/pull/33","diff_url":"https://github.com/conceptsandtraining/Jill/pull/33.diff","patch_url":"https://github.com/conceptsandtraining/Jill/pull/33.patch","issue_url":"https://api.github.com/repos/conceptsandtraining/Jill/issues/33","number":33,"state":"open","locked":false,"title":"V0.2.0","user":{"login":"nlzh","id":3328364,"avatar_url":"https://avatars.githubusercontent.com/u/3328364?v=3","gravatar_id":"","url":"https://api.github.com/users/nlzh","html_url":"https://github.com/nlzh","followers_url":"https://api.github.com/users/nlzh/followers","following_url":"https://api.github.com/users/nlzh/following{/other_user}","gists_url":"https://api.github.com/users/nlzh/gists{/gist_id}","starred_url":"https://api.github.com/users/nlzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlzh/subscriptions","organizations_url":"https://api.github.com/users/nlzh/orgs","repos_url":"https://api.github.com/users/nlzh/repos","events_url":"https://api.github.com/users/nlzh/events{/privacy}","received_events_url":"https://api.github.com/users/nlzh/received_events","type":"User","site_admin":false},"body":"refactored JILL. quite a bit.","created_at":"2017-02-16T16:09:08Z","updated_at":"2017-02-17T14:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"klees","id":10611082,"avatar_url":"https://avatars.githubusercontent.com/u/10611082?v=3","gravatar_id":"","url":"https://api.github.com/users/klees","html_url":"https://github.com/klees","followers_url":"https://api.github.com/users/klees/followers","following_url":"https://api.github.com/users/klees/following{/other_user}","gists_url":"https://api.github.com/users/klees/gists{/gist_id}","starred_url":"https://api.github.com/users/klees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klees/subscriptions","organizations_url":"https://api.github.com/users/klees/orgs","repos_url":"https://api.github.com/users/klees/repos","events_url":"https://api.github.com/users/klees/events{/privacy}","received_events_url":"https://api.github.com/users/klees/received_events","type":"User","site_admin":false},"assignees":[{"login":"klees","id":10611082,"avatar_url":"https://avatars.githubusercontent.com/u/10611082?v=3","gravatar_id":"","url":"https://api.github.com/users/klees","html_url":"https://github.com/klees","followers_url":"https://api.github.com/users/klees/followers","following_url":"https://api.github.com/users/klees/following{/other_user}","gists_url":"https://api.github.com/users/klees/gists{/gist_id}","starred_url":"https://api.github.com/users/klees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klees/subscriptions","organizations_url":"https://api.github.com/users/klees/orgs","repos_url":"https://api.github.com/users/klees/repos","events_url":"https://api.github.com/users/klees/events{/privacy}","received_events_url":"https://api.github.com/users/klees/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33/commits","review_comments_url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33/comments","review_comment_url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conceptsandtraining/Jill/issues/33/comments","statuses_url":"https://api.github.com/repos/conceptsandtraining/Jill/statuses/ca47de1564d6a2fe893916569defe59403308813","head":{"label":"nlzh:v0.2.0","ref":"v0.2.0","sha":"ca47de1564d6a2fe893916569defe59403308813","user":{"login":"nlzh","id":3328364,"avatar_url":"https://avatars.githubusercontent.com/u/3328364?v=3","gravatar_id":"","url":"https://api.github.com/users/nlzh","html_url":"https://github.com/nlzh","followers_url":"https://api.github.com/users/nlzh/followers","following_url":"https://api.github.com/users/nlzh/following{/other_user}","gists_url":"https://api.github.com/users/nlzh/gists{/gist_id}","starred_url":"https://api.github.com/users/nlzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlzh/subscriptions","organizations_url":"https://api.github.com/users/nlzh/orgs","repos_url":"https://api.github.com/users/nlzh/repos","events_url":"https://api.github.com/users/nlzh/events{/privacy}","received_events_url":"https://api.github.com/users/nlzh/received_events","type":"User","site_admin":false},"repo":{"id":67122801,"name":"Jill","full_name":"nlzh/Jill","owner":{"login":"nlzh","id":3328364,"avatar_url":"https://avatars.githubusercontent.com/u/3328364?v=3","gravatar_id":"","url":"https://api.github.com/users/nlzh","html_url":"https://github.com/nlzh","followers_url":"https://api.github.com/users/nlzh/followers","following_url":"https://api.github.com/users/nlzh/following{/other_user}","gists_url":"https://api.github.com/users/nlzh/gists{/gist_id}","starred_url":"https://api.github.com/users/nlzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlzh/subscriptions","organizations_url":"https://api.github.com/users/nlzh/orgs","repos_url":"https://api.github.com/users/nlzh/repos","events_url":"https://api.github.com/users/nlzh/events{/privacy}","received_events_url":"https://api.github.com/users/nlzh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlzh/Jill","description":"Jill3, UILayer for ILIAS","fork":false,"url":"https://api.github.com/repos/nlzh/Jill","forks_url":"https://api.github.com/repos/nlzh/Jill/forks","keys_url":"https://api.github.com/repos/nlzh/Jill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlzh/Jill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlzh/Jill/teams","hooks_url":"https://api.github.com/repos/nlzh/Jill/hooks","issue_events_url":"https://api.github.com/repos/nlzh/Jill/issues/events{/number}","events_url":"https://api.github.com/repos/nlzh/Jill/events","assignees_url":"https://api.github.com/repos/nlzh/Jill/assignees{/user}","branches_url":"https://api.github.com/repos/nlzh/Jill/branches{/branch}","tags_url":"https://api.github.com/repos/nlzh/Jill/tags","blobs_url":"https://api.github.com/repos/nlzh/Jill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlzh/Jill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlzh/Jill/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlzh/Jill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlzh/Jill/statuses/{sha}","languages_url":"https://api.github.com/repos/nlzh/Jill/languages","stargazers_url":"https://api.github.com/repos/nlzh/Jill/stargazers","contributors_url":"https://api.github.com/repos/nlzh/Jill/contributors","subscribers_url":"https://api.github.com/repos/nlzh/Jill/subscribers","subscription_url":"https://api.github.com/repos/nlzh/Jill/subscription","commits_url":"https://api.github.com/repos/nlzh/Jill/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlzh/Jill/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlzh/Jill/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlzh/Jill/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlzh/Jill/contents/{+path}","compare_url":"https://api.github.com/repos/nlzh/Jill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlzh/Jill/merges","archive_url":"https://api.github.com/repos/nlzh/Jill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlzh/Jill/downloads","issues_url":"https://api.github.com/repos/nlzh/Jill/issues{/number}","pulls_url":"https://api.github.com/repos/nlzh/Jill/pulls{/number}","milestones_url":"https://api.github.com/repos/nlzh/Jill/milestones{/number}","notifications_url":"https://api.github.com/repos/nlzh/Jill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlzh/Jill/labels{/name}","releases_url":"https://api.github.com/repos/nlzh/Jill/releases{/id}","deployments_url":"https://api.github.com/repos/nlzh/Jill/deployments","created_at":"2016-09-01T10:44:34Z","updated_at":"2016-09-01T16:24:57Z","pushed_at":"2017-02-17T14:20:46Z","git_url":"git://github.com/nlzh/Jill.git","ssh_url":"git@github.com:nlzh/Jill.git","clone_url":"https://github.com/nlzh/Jill.git","svn_url":"https://github.com/nlzh/Jill","homepage":null,"size":781,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conceptsandtraining:master","ref":"master","sha":"56ad332bb76ae0e88adac989ba7b05cceec55ab3","user":{"login":"conceptsandtraining","id":7535875,"avatar_url":"https://avatars.githubusercontent.com/u/7535875?v=3","gravatar_id":"","url":"https://api.github.com/users/conceptsandtraining","html_url":"https://github.com/conceptsandtraining","followers_url":"https://api.github.com/users/conceptsandtraining/followers","following_url":"https://api.github.com/users/conceptsandtraining/following{/other_user}","gists_url":"https://api.github.com/users/conceptsandtraining/gists{/gist_id}","starred_url":"https://api.github.com/users/conceptsandtraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conceptsandtraining/subscriptions","organizations_url":"https://api.github.com/users/conceptsandtraining/orgs","repos_url":"https://api.github.com/users/conceptsandtraining/repos","events_url":"https://api.github.com/users/conceptsandtraining/events{/privacy}","received_events_url":"https://api.github.com/users/conceptsandtraining/received_events","type":"Organization","site_admin":false},"repo":{"id":68082660,"name":"Jill","full_name":"conceptsandtraining/Jill","owner":{"login":"conceptsandtraining","id":7535875,"avatar_url":"https://avatars.githubusercontent.com/u/7535875?v=3","gravatar_id":"","url":"https://api.github.com/users/conceptsandtraining","html_url":"https://github.com/conceptsandtraining","followers_url":"https://api.github.com/users/conceptsandtraining/followers","following_url":"https://api.github.com/users/conceptsandtraining/following{/other_user}","gists_url":"https://api.github.com/users/conceptsandtraining/gists{/gist_id}","starred_url":"https://api.github.com/users/conceptsandtraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conceptsandtraining/subscriptions","organizations_url":"https://api.github.com/users/conceptsandtraining/orgs","repos_url":"https://api.github.com/users/conceptsandtraining/repos","events_url":"https://api.github.com/users/conceptsandtraining/events{/privacy}","received_events_url":"https://api.github.com/users/conceptsandtraining/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conceptsandtraining/Jill","description":"Jill3, UILayer for ILIAS","fork":true,"url":"https://api.github.com/repos/conceptsandtraining/Jill","forks_url":"https://api.github.com/repos/conceptsandtraining/Jill/forks","keys_url":"https://api.github.com/repos/conceptsandtraining/Jill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conceptsandtraining/Jill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conceptsandtraining/Jill/teams","hooks_url":"https://api.github.com/repos/conceptsandtraining/Jill/hooks","issue_events_url":"https://api.github.com/repos/conceptsandtraining/Jill/issues/events{/number}","events_url":"https://api.github.com/repos/conceptsandtraining/Jill/events","assignees_url":"https://api.github.com/repos/conceptsandtraining/Jill/assignees{/user}","branches_url":"https://api.github.com/repos/conceptsandtraining/Jill/branches{/branch}","tags_url":"https://api.github.com/repos/conceptsandtraining/Jill/tags","blobs_url":"https://api.github.com/repos/conceptsandtraining/Jill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conceptsandtraining/Jill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conceptsandtraining/Jill/git/refs{/sha}","trees_url":"https://api.github.com/repos/conceptsandtraining/Jill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conceptsandtraining/Jill/statuses/{sha}","languages_url":"https://api.github.com/repos/conceptsandtraining/Jill/languages","stargazers_url":"https://api.github.com/repos/conceptsandtraining/Jill/stargazers","contributors_url":"https://api.github.com/repos/conceptsandtraining/Jill/contributors","subscribers_url":"https://api.github.com/repos/conceptsandtraining/Jill/subscribers","subscription_url":"https://api.github.com/repos/conceptsandtraining/Jill/subscription","commits_url":"https://api.github.com/repos/conceptsandtraining/Jill/commits{/sha}","git_commits_url":"https://api.github.com/repos/conceptsandtraining/Jill/git/commits{/sha}","comments_url":"https://api.github.com/repos/conceptsandtraining/Jill/comments{/number}","issue_comment_url":"https://api.github.com/repos/conceptsandtraining/Jill/issues/comments{/number}","contents_url":"https://api.github.com/repos/conceptsandtraining/Jill/contents/{+path}","compare_url":"https://api.github.com/repos/conceptsandtraining/Jill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conceptsandtraining/Jill/merges","archive_url":"https://api.github.com/repos/conceptsandtraining/Jill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conceptsandtraining/Jill/downloads","issues_url":"https://api.github.com/repos/conceptsandtraining/Jill/issues{/number}","pulls_url":"https://api.github.com/repos/conceptsandtraining/Jill/pulls{/number}","milestones_url":"https://api.github.com/repos/conceptsandtraining/Jill/milestones{/number}","notifications_url":"https://api.github.com/repos/conceptsandtraining/Jill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conceptsandtraining/Jill/labels{/name}","releases_url":"https://api.github.com/repos/conceptsandtraining/Jill/releases{/id}","deployments_url":"https://api.github.com/repos/conceptsandtraining/Jill/deployments","created_at":"2016-09-13T06:51:52Z","updated_at":"2016-09-13T06:51:53Z","pushed_at":"2017-02-17T14:20:47Z","git_url":"git://github.com/conceptsandtraining/Jill.git","ssh_url":"git@github.com:conceptsandtraining/Jill.git","clone_url":"https://github.com/conceptsandtraining/Jill.git","svn_url":"https://github.com/conceptsandtraining/Jill","homepage":null,"size":664,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33"},"html":{"href":"https://github.com/conceptsandtraining/Jill/pull/33"},"issue":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/issues/33"},"comments":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/conceptsandtraining/Jill/statuses/ca47de1564d6a2fe893916569defe59403308813"}}}}
{"actor":{"display_login":"nlzh"}}