{"push_id":1550619719,"size":10,"distinct_size":10,"ref":"refs/heads/ps-5.7-MYR-Merge-January2017","head":"6bbbe1c7690e94f01106c108e80b283a106c3be6","before":"d37b6be91d6332c51be27f25989a24931d1c4b25","commits":[{"sha":"fb52f385e6817be3ba4701229e457aed34947dc5","author":{"name":"Reid Horuff","email":"c3ce2c280bbf2e29a8e771b3f80d6523548fc9df@fb.com"},"message":"add missing test for persistent cache support\n\nUpstream commit ID: f5c01893766b48c40cae225e24c11d28f63ffbdf\n\nSummary:\nThis diff adds tests so that sys_vars tests no longer fail. The persistent_cache test is still failing on sandcastle and is disabled.\nCloses https://github.com/facebook/mysql-5.6/pull/509\n\nReviewed By: lth\n\nDifferential Revision: D4407437\n\nPulled By: reidHoruff\n\nfbshipit-source-id: 8e03122\n\nGOL merge to Percona Server 5.7 myrocks:\n- Added --source include/have_myisam.inc to tests.","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/fb52f385e6817be3ba4701229e457aed34947dc5"},{"sha":"63e8bba852474b00dbed6145fc884ba97c650f70","author":{"name":"Gunnar Kudrjavets","email":"4b9115f38ec7f041c6bd4a85e4b309dca6bf33ca@fb.com"},"message":"Improve error handling by using named constants\n\nUpstream commit ID: 14859d1a579d0b56779b722bbbb2c0537284ac83\n\nSummary:\nTo increase the comprehension and readability of MyRocks codebase we'll\nuse constants similar to ones from C standard (`EXIT_SUCCESS` and\n`EXIT_FAILURE`) to make sure that both failure and success paths are\nclearly identifiable. The definitions of FALSE and TRUE come from\n`<my_global.h`>.\n\nError handling pattern used across MySQL abides by the following rules:\n\"All functions that can report an error (usually an allocation error),\nshould return `0/FALSE/false` on success, `1/TRUE/true` on failure.\"\n\nhttps://dev.mysql.com/doc/internals/en/additional-suggestions.html has\nmore details.\nCloses https://github.com/facebook/mysql-5.6/pull/506\n\nReviewed By: lth\n\nDifferential Revision: D4402917\n\nPulled By: gunnarku\n\nfbshipit-source-id: c32a6f6","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/63e8bba852474b00dbed6145fc884ba97c650f70"},{"sha":"4606b9a49d10dd334aea64c2aa0797c389d18e8f","author":{"name":"Gunnar Kudrjavets","email":"4b9115f38ec7f041c6bd4a85e4b309dca6bf33ca@fb.com"},"message":"Name MyRocks threads correctly to enhance debugging\n\nUpstream commit ID:  8fd209ebd4b11140ffe13bcfdce6348d82cbf2e4\n\nSummary:\nCurrently in `gdb` the MyRocks threads show up as \"my-func\". That's\nbecause how setting thread names is implemented in MySQL (using the\nsubstring of a callback function name).\n\nGiven how `Rdb_thread` class creates threads, the names all end up the\nsame. Therefore we need to reset them ourselves.\nCloses https://github.com/facebook/mysql-5.6/pull/510\n\nReviewed By: alxyang\n\nDifferential Revision: D4408652\n\nPulled By: gunnarku\n\nfbshipit-source-id: e3e3a32","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/4606b9a49d10dd334aea64c2aa0797c389d18e8f"},{"sha":"beb4e08952f6674ddefada3fc68479c1e47b0539","author":{"name":"Alex Yang","email":"2baff167e888c9d2f955ebd8225f161dae3ae6b9@fb.com"},"message":"Support for fast secondary index creation with unique secondary keys\n\nUpstream commit ID: b12ea973cfe7844472b1d5787bfd1a18e6a9e30c\n\nSummary:\nThis adds support for fast secondary index creation with unique secondary\nkeys. It validates that duplicate entries aren't being inserted during the\nmerge phase of the external sort by comparing only the memcomparable formats of\nthe secondary key - extended primary key tail.\n\nIt fails gracefully in cases where a duplicate entry is found by reporting\nerror, and rolling back any partially created indexes.\n\nReviewed By: hermanlee\n\nDifferential Revision: D4225237\n\nfbshipit-source-id: 5ff0575","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/beb4e08952f6674ddefada3fc68479c1e47b0539"},{"sha":"d2c0c114ac9b38fea77eaf8ad50ab2f9ae27702e","author":{"name":"Tian Xia","email":"5a990d9998e10c9ce0b2e41ad3bd421152f32cf6@fb.com"},"message":"Making rocksdb_max_background_compactions dynamic\n\nUpstream commit ID:  d2d7654993bf6c8e5494618730df4b1796489354\n\nSummary:\n`max_background_compactions` is a mutable option in RocksDB. Making it dynamic\nin MyRocks as well.\nCloses https://github.com/facebook/mysql-5.6/pull/507\n\nDifferential Revision: D4405189\n\nPulled By: tianx\n\nfbshipit-source-id: 7441772\n\nGOL merge to Percona Server 5.7 myrocks:\n- added --source include/have_myisam.inc to test.","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/d2c0c114ac9b38fea77eaf8ad50ab2f9ae27702e"},{"sha":"7e90d8b465f05bcd6c0822938434d22e5afcc5c3","author":{"name":"Reid Horuff","email":"c3ce2c280bbf2e29a8e771b3f80d6523548fc9df@fb.com"},"message":"rename rocksdb_disable_2pc to rocksdb_enable_2pc, default true\n\nUpstream commit ID: 8dcea967fd948cf7d5baf6343bc4a15ffccecb0c\n\nSummary:\nThis diff renames the flag rocksdb_disable_2pc to rocksdb_enable_2pc. The default for this value remains true, enabling 2pc by default.\nCloses https://github.com/facebook/mysql-5.6/pull/471\n\nReviewed By: gunnarku\n\nDifferential Revision: D4321849\n\nPulled By: reidHoruff\n\nfbshipit-source-id: 1b32ede","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/7e90d8b465f05bcd6c0822938434d22e5afcc5c3"},{"sha":"a209a99b804316c1b55733486e3220962e0a59be","author":{"name":"Anirban Rahut","email":"d590514c8ffc8787fe90dac2906ba1c9bb8f76dd@fb.com"},"message":"Updating the RocksDB submodule\n\nUpstream commit ID: 922933bf0a0e1b24a1bdf652a9ff55dc931d392d\n\nSummary:\nUpdated to the commit before 5.1.fb branch\nbc5d7b70299b763127f3714055a63ebe7e04ad47\n\nReviewed By: yoshinorim\n\nDifferential Revision: D4442962\n\nfbshipit-source-id: 7df16cd","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/a209a99b804316c1b55733486e3220962e0a59be"},{"sha":"781706694071242a23c1f58ee8c686db358d7b8f","author":{"name":"Gunnar Kudrjavets","email":"4b9115f38ec7f041c6bd4a85e4b309dca6bf33ca@fb.com"},"message":"Apply clang-format to everything to unify MyRocks code\n\nUpstream commit ID: a1badf05b5252ba9ba6b4808ec73cdc8cf9fbeef\n\nSummary:\n- Apply `clang-format` on entire MyRocks code base.\n- Use it as the one unified style in future. Makes it easy to lint,\n  verify, unify, give coding guidance.\n\nThis will:\n\n- Give us better readability.\n- Make a clean break between us and MySQL coding style.\n\nReviewed By: lth\n\nDifferential Revision: D4430944\n\nfbshipit-source-id: c3c0698\n\nConflicts:\n\tstorage/rocksdb/ha_rocksdb.cc","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/781706694071242a23c1f58ee8c686db358d7b8f"},{"sha":"ef975bad3fd09c3b4ed5de63efa2e895be209480","author":{"name":"Reid Horuff","email":"c3ce2c280bbf2e29a8e771b3f80d6523548fc9df@fb.com"},"message":"rename all rocksdb_disable_2pc to rocksdb_enable_2pc\n\nUpstream commit ID: 54e915f43370bd048bc230cb30f6be0cd2e71d2f\n\nSummary:\nI missed the vars in 2pc_group_commit test. This renames rocksdb_disable_2pc to rocksdb_enable_2pc.\n\nSquash with: D4321849\n\nReviewed By: anirbanr-fb\n\nDifferential Revision: D4432114\n\nfbshipit-source-id: 6403c12","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/ef975bad3fd09c3b4ed5de63efa2e895be209480"},{"sha":"6bbbe1c7690e94f01106c108e80b283a106c3be6","author":{"name":"Gunnar Kudrjavets","email":"4b9115f38ec7f041c6bd4a85e4b309dca6bf33ca@fb.com"},"message":"Fix the build break caused by deprecated declarations from latest version of RocksDB\n\nUpstream commit ID: 25b3da3637155f7ee882846e631ca81cde8ba8d2\n\nSummary:\nCurrently the `{ latest MyRocks + latest RocksDB }` builds fails because `GetApproximateSizes` is marked as `ROCKSDB_DEPRECATED_FUNC`. This causes build errors like:\n\n```\nerror: ‘virtual void rocksdb::DB::GetApproximateSizes(rocksdb::ColumnFamilyHandle*,\nconst rocksdb::Range*, int, uint64_t*, bool)’ is deprecated (declared at\n.../rocksdb/include/rocksdb/db.h:629) [-Werror=deprecated-declarations]\n     &sz, true);\n```\n\nThis is a quick fix to unblock the integration testing.\n\nReviewed By: lth, VitaliyLi\n\nDifferential Revision: D4458637\n\nfbshipit-source-id: 1b52d0c","distinct":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits/6bbbe1c7690e94f01106c108e80b283a106c3be6"}]}
{"actor":{"display_login":"georgelorchpercona"}}