{"action":"created","issue":{"url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/4","repository_url":"https://api.github.com/repos/MartijnCuppens/rfs","labels_url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/4/comments","events_url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/4/events","html_url":"https://github.com/MartijnCuppens/rfs/issues/4","id":270392814,"number":4,"title":"Not mobile-first","user":{"login":"garrettw","id":84885,"avatar_url":"https://avatars2.githubusercontent.com/u/84885?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettw","html_url":"https://github.com/garrettw","followers_url":"https://api.github.com/users/garrettw/followers","following_url":"https://api.github.com/users/garrettw/following{/other_user}","gists_url":"https://api.github.com/users/garrettw/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettw/subscriptions","organizations_url":"https://api.github.com/users/garrettw/orgs","repos_url":"https://api.github.com/users/garrettw/repos","events_url":"https://api.github.com/users/garrettw/events{/privacy}","received_events_url":"https://api.github.com/users/garrettw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-01T17:48:39Z","updated_at":"2017-11-02T09:19:59Z","closed_at":null,"author_association":"NONE","body":"What are your thoughts on changing the algorithm to be mobile-first (i.e. take font size on mobile as the argument and use min-width in the output)?\r\nUltimately the effect could be the same, but readability could be better for those accustomed to writing for mobile-first (of which there are many).\r\n\r\nOr another option might be to just add a mixin for mobile-first sizing.\r\n\r\nSee: _[Precise control over responsive typography](https://madebymike.com.au/writing/precise-control-responsive-typography/)_"},"comment":{"url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/comments/341362027","html_url":"https://github.com/MartijnCuppens/rfs/issues/4#issuecomment-341362027","issue_url":"https://api.github.com/repos/MartijnCuppens/rfs/issues/4","id":341362027,"user":{"login":"MartijnCuppens","id":11559216,"avatar_url":"https://avatars3.githubusercontent.com/u/11559216?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnCuppens","html_url":"https://github.com/MartijnCuppens","followers_url":"https://api.github.com/users/MartijnCuppens/followers","following_url":"https://api.github.com/users/MartijnCuppens/following{/other_user}","gists_url":"https://api.github.com/users/MartijnCuppens/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnCuppens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnCuppens/subscriptions","organizations_url":"https://api.github.com/users/MartijnCuppens/orgs","repos_url":"https://api.github.com/users/MartijnCuppens/repos","events_url":"https://api.github.com/users/MartijnCuppens/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnCuppens/received_events","type":"User","site_admin":false},"created_at":"2017-11-02T09:19:59Z","updated_at":"2017-11-02T09:19:59Z","author_association":"OWNER","body":"Hi @garrettw,\r\n\r\nThe main reason it wasn't designed mobile first is that browsers without `vw`-unit support will correctly render there font-size.\r\n\r\nIf we use the mobile-first approach, we get this:\r\nSCSS:\r\n```scss\r\n.title {\r\n  @include rfs(62);\r\n}\r\n```\r\n\r\nCSS:\r\n```css\r\n.title {\r\n  font-size: calc(23.6px + 3.2vw);\r\n}\r\n\r\n@media (min-width: 1200px) {\r\n  .title {\r\n    font-size: 62px;\r\n  }\r\n}\r\n```\r\nFor older browsers with a screen-width smaller as `1200px` the font-size will not be set.\r\n\r\nHowever it might be interesting to add an option like `$rfs-mobile-first` (default value: false) which switches to mobile first rendering?\r\n"}}
{"actor":{"display_login":"MartijnCuppens"}}