{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/138830381","pull_request_review_id":62675466,"id":138830381,"diff_hunk":"@@ -1,45 +0,0 @@\n-/*\n- * Copyright (c) 2002-2017 \"Neo Technology,\"\n- * Network Engine for Objects in Lund AB [http://neotechnology.com]\n- *\n- * This file is part of Neo4j.\n- *\n- * Neo4j is free software: you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation, either version 3 of the License, or\n- * (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n- */\n-package org.neo4j.cypher.internal.compatibility.v3_3.runtime.planDescription\n-\n-import org.neo4j.cypher.internal.compiler.v3_3.planner.logical.plans.{LogicalPlan, TreeBuilder}\n-import org.neo4j.cypher.internal.frontend.v3_3.IdentityMap\n-\n-/*\n-The map of logical plan and ids is used to allow profiling to connect to the right part in the logical plan\n-to report db hits and rows passed through.\n- */\n-object LogicalPlanIdentificationBuilder extends (LogicalPlan => Map[LogicalPlan, Id]) {\n-  def apply(plan: LogicalPlan): Map[LogicalPlan, Id] = {\n-\n-    val builder = new IdAssigner\n-    builder.mapIds(plan)\n-  }\n-\n-  private class IdAssigner extends TreeBuilder[Map[LogicalPlan, Id]] {\n-    def mapIds(plan: LogicalPlan): Map[LogicalPlan, Id] = create(plan)\n-\n-    override protected def build(plan: LogicalPlan): Map[LogicalPlan, Id] = IdentityMap(plan -> new Id)\n-\n-    override protected def build(plan: LogicalPlan, source: Map[LogicalPlan, Id]): Map[LogicalPlan, Id] = source + (plan -> new Id)\n-\n-    override protected def build(plan: LogicalPlan, lhs: Map[LogicalPlan, Id], rhs: Map[LogicalPlan, Id]): Map[LogicalPlan, Id] = lhs ++ rhs + (plan -> new Id)\n-  }\n-}","path":"community/cypher/cypher/src/main/scala/org/neo4j/cypher/internal/compatibility/v3_3/runtime/planDescription/LogicalPlanIdentificationBuilder.scala","position":45,"original_position":45,"commit_id":"c2d92b01143741b58a35475d80cb17197bf0b685","original_commit_id":"c2d92b01143741b58a35475d80cb17197bf0b685","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"body":"WIN!","created_at":"2017-09-14T08:39:50Z","updated_at":"2017-09-14T08:55:40Z","html_url":"https://github.com/neo4j/neo4j/pull/10043#discussion_r138830381","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10043","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/138830381"},"html":{"href":"https://github.com/neo4j/neo4j/pull/10043#discussion_r138830381"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10043"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/10043","id":140521421,"html_url":"https://github.com/neo4j/neo4j/pull/10043","diff_url":"https://github.com/neo4j/neo4j/pull/10043.diff","patch_url":"https://github.com/neo4j/neo4j/pull/10043.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/10043","number":10043,"state":"open","locked":false,"title":"Refactoring around logical plan identification","user":{"login":"systay","id":402248,"avatar_url":"https://avatars2.githubusercontent.com/u/402248?v=4","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"body":"Use LogicalPlanId instead of PlanDescription.Id everywhere","created_at":"2017-09-12T08:49:48Z","updated_at":"2017-09-14T08:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21a46c7783557bf2f7fa14894b1a0e6187148fe8","assignee":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"assignees":[{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10043/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10043/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/10043/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/c2d92b01143741b58a35475d80cb17197bf0b685","head":{"label":"systay:3.3-no-more-id","ref":"3.3-no-more-id","sha":"c2d92b01143741b58a35475d80cb17197bf0b685","user":{"login":"systay","id":402248,"avatar_url":"https://avatars2.githubusercontent.com/u/402248?v=4","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"repo":{"id":6667347,"name":"neo4j","full_name":"systay/neo4j","owner":{"login":"systay","id":402248,"avatar_url":"https://avatars2.githubusercontent.com/u/402248?v=4","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/systay/neo4j","description":null,"fork":true,"url":"https://api.github.com/repos/systay/neo4j","forks_url":"https://api.github.com/repos/systay/neo4j/forks","keys_url":"https://api.github.com/repos/systay/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systay/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systay/neo4j/teams","hooks_url":"https://api.github.com/repos/systay/neo4j/hooks","issue_events_url":"https://api.github.com/repos/systay/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/systay/neo4j/events","assignees_url":"https://api.github.com/repos/systay/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/systay/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/systay/neo4j/tags","blobs_url":"https://api.github.com/repos/systay/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systay/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systay/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/systay/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systay/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/systay/neo4j/languages","stargazers_url":"https://api.github.com/repos/systay/neo4j/stargazers","contributors_url":"https://api.github.com/repos/systay/neo4j/contributors","subscribers_url":"https://api.github.com/repos/systay/neo4j/subscribers","subscription_url":"https://api.github.com/repos/systay/neo4j/subscription","commits_url":"https://api.github.com/repos/systay/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/systay/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/systay/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/systay/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/systay/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/systay/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systay/neo4j/merges","archive_url":"https://api.github.com/repos/systay/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systay/neo4j/downloads","issues_url":"https://api.github.com/repos/systay/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/systay/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/systay/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/systay/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systay/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/systay/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/systay/neo4j/deployments","created_at":"2012-11-13T08:05:14Z","updated_at":"2016-01-19T19:00:58Z","pushed_at":"2017-09-14T07:43:31Z","git_url":"git://github.com/systay/neo4j.git","ssh_url":"git@github.com:systay/neo4j.git","clone_url":"https://github.com/systay/neo4j.git","svn_url":"https://github.com/systay/neo4j","homepage":null,"size":354791,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"loadcsv"}},"base":{"label":"neo4j:3.3","ref":"3.3","sha":"a641685a9d09cceffb21c3b0eb91f9385ad6f23a","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2017-09-14T07:50:16Z","pushed_at":"2017-09-14T08:54:44Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":353841,"stargazers_count":4170,"watchers_count":4170,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1177,"mirror_url":null,"open_issues_count":441,"forks":1177,"open_issues":441,"watchers":4170,"default_branch":"3.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10043"},"html":{"href":"https://github.com/neo4j/neo4j/pull/10043"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/10043"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/10043/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10043/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10043/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/c2d92b01143741b58a35475d80cb17197bf0b685"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fickludd"}}