{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/149154904","pull_request_review_id":74505175,"id":149154904,"diff_hunk":"@@ -141,6 +141,40 @@ void SubscriptionId::present(const std::string& indent)\n \n /* ****************************************************************************\n *\n+* SubscriptionId::toJson -\n+*/\n+std::string SubscriptionId::toJson(RequestType container, bool comma)\n+{\n+  std::string xString = string;","path":"src/lib/ngsi/SubscriptionId.cpp","position":8,"original_position":8,"commit_id":"70855cb96335bd616c0166aa178ae0453a37a04e","original_commit_id":"70855cb96335bd616c0166aa178ae0453a37a04e","user":{"login":"kzangeli","id":5338380,"avatar_url":"https://avatars2.githubusercontent.com/u/5338380?v=4","gravatar_id":"","url":"https://api.github.com/users/kzangeli","html_url":"https://github.com/kzangeli","followers_url":"https://api.github.com/users/kzangeli/followers","following_url":"https://api.github.com/users/kzangeli/following{/other_user}","gists_url":"https://api.github.com/users/kzangeli/gists{/gist_id}","starred_url":"https://api.github.com/users/kzangeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzangeli/subscriptions","organizations_url":"https://api.github.com/users/kzangeli/orgs","repos_url":"https://api.github.com/users/kzangeli/repos","events_url":"https://api.github.com/users/kzangeli/events{/privacy}","received_events_url":"https://api.github.com/users/kzangeli/received_events","type":"User","site_admin":false},"body":"This was probably me, smells KZ ... :-)\r\nI don't find it that bad though :-D\r\n\r\nNTC","created_at":"2017-11-06T17:58:59Z","updated_at":"2017-11-06T17:59:00Z","html_url":"https://github.com/telefonicaid/fiware-orion/pull/3034#discussion_r149154904","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/149154904"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/3034#discussion_r149154904"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034"}},"in_reply_to_id":149134255},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034","id":150897848,"html_url":"https://github.com/telefonicaid/fiware-orion/pull/3034","diff_url":"https://github.com/telefonicaid/fiware-orion/pull/3034.diff","patch_url":"https://github.com/telefonicaid/fiware-orion/pull/3034.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3034","number":3034,"state":"open","locked":false,"title":"Bug/2948 wrong max one service path response","user":{"login":"arigliano","id":11073619,"avatar_url":"https://avatars3.githubusercontent.com/u/11073619?v=4","gravatar_id":"","url":"https://api.github.com/users/arigliano","html_url":"https://github.com/arigliano","followers_url":"https://api.github.com/users/arigliano/followers","following_url":"https://api.github.com/users/arigliano/following{/other_user}","gists_url":"https://api.github.com/users/arigliano/gists{/gist_id}","starred_url":"https://api.github.com/users/arigliano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigliano/subscriptions","organizations_url":"https://api.github.com/users/arigliano/orgs","repos_url":"https://api.github.com/users/arigliano/repos","events_url":"https://api.github.com/users/arigliano/events{/privacy}","received_events_url":"https://api.github.com/users/arigliano/received_events","type":"User","site_admin":false},"body":"This PR fixes #2948 Issue\r\n\r\n- It was implemented a new **toJson()** method in SubscriberError, in order to correctly print out the error response, depending on which serviceRoutine version calls either render() or toJson() method.\r\n- Fixed 400 httpStatusCode in both serviceRoutines ","created_at":"2017-11-06T16:30:26Z","updated_at":"2017-11-06T17:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7031b34d2e9cde9013475e167f01d1b47398f0e9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3034/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/70855cb96335bd616c0166aa178ae0453a37a04e","head":{"label":"arigliano:bug/2948_wrong_max_one_service_path_response","ref":"bug/2948_wrong_max_one_service_path_response","sha":"70855cb96335bd616c0166aa178ae0453a37a04e","user":{"login":"arigliano","id":11073619,"avatar_url":"https://avatars3.githubusercontent.com/u/11073619?v=4","gravatar_id":"","url":"https://api.github.com/users/arigliano","html_url":"https://github.com/arigliano","followers_url":"https://api.github.com/users/arigliano/followers","following_url":"https://api.github.com/users/arigliano/following{/other_user}","gists_url":"https://api.github.com/users/arigliano/gists{/gist_id}","starred_url":"https://api.github.com/users/arigliano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigliano/subscriptions","organizations_url":"https://api.github.com/users/arigliano/orgs","repos_url":"https://api.github.com/users/arigliano/repos","events_url":"https://api.github.com/users/arigliano/events{/privacy}","received_events_url":"https://api.github.com/users/arigliano/received_events","type":"User","site_admin":false},"repo":{"id":103119845,"name":"fiware-orion","full_name":"arigliano/fiware-orion","owner":{"login":"arigliano","id":11073619,"avatar_url":"https://avatars3.githubusercontent.com/u/11073619?v=4","gravatar_id":"","url":"https://api.github.com/users/arigliano","html_url":"https://github.com/arigliano","followers_url":"https://api.github.com/users/arigliano/followers","following_url":"https://api.github.com/users/arigliano/following{/other_user}","gists_url":"https://api.github.com/users/arigliano/gists{/gist_id}","starred_url":"https://api.github.com/users/arigliano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigliano/subscriptions","organizations_url":"https://api.github.com/users/arigliano/orgs","repos_url":"https://api.github.com/users/arigliano/repos","events_url":"https://api.github.com/users/arigliano/events{/privacy}","received_events_url":"https://api.github.com/users/arigliano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arigliano/fiware-orion","description":"FIWARE Orion Context Broker","fork":true,"url":"https://api.github.com/repos/arigliano/fiware-orion","forks_url":"https://api.github.com/repos/arigliano/fiware-orion/forks","keys_url":"https://api.github.com/repos/arigliano/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arigliano/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arigliano/fiware-orion/teams","hooks_url":"https://api.github.com/repos/arigliano/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/arigliano/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/arigliano/fiware-orion/events","assignees_url":"https://api.github.com/repos/arigliano/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/arigliano/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/arigliano/fiware-orion/tags","blobs_url":"https://api.github.com/repos/arigliano/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arigliano/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arigliano/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/arigliano/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arigliano/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/arigliano/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/arigliano/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/arigliano/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/arigliano/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/arigliano/fiware-orion/subscription","commits_url":"https://api.github.com/repos/arigliano/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/arigliano/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/arigliano/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/arigliano/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/arigliano/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/arigliano/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arigliano/fiware-orion/merges","archive_url":"https://api.github.com/repos/arigliano/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arigliano/fiware-orion/downloads","issues_url":"https://api.github.com/repos/arigliano/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/arigliano/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/arigliano/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/arigliano/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arigliano/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/arigliano/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/arigliano/fiware-orion/deployments","created_at":"2017-09-11T10:00:40Z","updated_at":"2017-09-28T08:01:38Z","pushed_at":"2017-11-06T16:22:08Z","git_url":"git://github.com/arigliano/fiware-orion.git","ssh_url":"git@github.com:arigliano/fiware-orion.git","clone_url":"https://github.com/arigliano/fiware-orion.git","svn_url":"https://github.com/arigliano/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":32822,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telefonicaid:master","ref":"master","sha":"5e515c230ff59d5dc950c84c2fa21c587ef3b47f","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":12808420,"name":"fiware-orion","full_name":"telefonicaid/fiware-orion","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion","description":"FIWARE Orion Context Broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/deployments","created_at":"2013-09-13T11:55:25Z","updated_at":"2017-11-01T01:30:32Z","pushed_at":"2017-11-06T16:30:27Z","git_url":"git://github.com/telefonicaid/fiware-orion.git","ssh_url":"git@github.com:telefonicaid/fiware-orion.git","clone_url":"https://github.com/telefonicaid/fiware-orion.git","svn_url":"https://github.com/telefonicaid/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":32842,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":371,"forks":95,"open_issues":371,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/3034"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3034"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3034/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3034/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/70855cb96335bd616c0166aa178ae0453a37a04e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kzangeli"}}