{"action":"created","issue":{"url":"https://api.github.com/repos/decidim/decidim/issues/2217","repository_url":"https://api.github.com/repos/decidim/decidim","labels_url":"https://api.github.com/repos/decidim/decidim/issues/2217/labels{/name}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/2217/comments","events_url":"https://api.github.com/repos/decidim/decidim/issues/2217/events","html_url":"https://github.com/decidim/decidim/pull/2217","id":274510164,"number":2217,"title":"Clarify generator specs","user":{"login":"deivid-rodriguez","id":2887858,"avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-16T13:09:40Z","updated_at":"2017-11-16T13:09:42Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/2217","html_url":"https://github.com/decidim/decidim/pull/2217","diff_url":"https://github.com/decidim/decidim/pull/2217.diff","patch_url":"https://github.com/decidim/decidim/pull/2217.patch"},"body":"#### :tophat: What? Why?\r\n\r\nThese specs are very obscure and complicated since they test real usage of the generators, which is not easy. They ended up being like this because we fixed bug after bug in generators and added regression specs for them.\r\n\r\nIn this PR I try to improve them a bit and explain what they do and why they do it. \r\n\r\nAlso added some changes in general in specs that \"shell out\" to try to make debugging them easier, while keeping them \"non verbose\".\r\n\r\n#### :pushpin: Related Issues\r\n- Related to #2212 \r\n\r\n#### :clipboard: Subtasks\r\n_None_.\r\n\r\n### :camera: Screenshots (optional)\r\n_None_.\r\n\r\n#### :ghost: GIF\r\n![giphy](https://user-images.githubusercontent.com/2887858/32892780-19351c1c-cab6-11e7-9b44-85bd5f1327f6.gif)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/decidim/decidim/issues/comments/344917803","html_url":"https://github.com/decidim/decidim/pull/2217#issuecomment-344917803","issue_url":"https://api.github.com/repos/decidim/decidim/issues/2217","id":344917803,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-11-16T13:09:42Z","updated_at":"2017-11-16T13:09:42Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/decidim/decidim/pull/2217?src=pr&el=h1) Report\n> Merging [#2217](https://codecov.io/gh/decidim/decidim/pull/2217?src=pr&el=desc) into [master](https://codecov.io/gh/decidim/decidim/commit/247f04ddf971a15c0c25511058cc7da16e73975e?src=pr&el=desc) will **decrease** coverage by `0.6%`.\n> The diff coverage is `n/a`.\n\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2217      +/-   ##\n==========================================\n- Coverage   98.59%   97.98%   -0.61%     \n==========================================\n  Files        1189     1019     -170     \n  Lines       27425    23298    -4127     \n==========================================\n- Hits        27039    22828    -4211     \n- Misses        386      470      +84\n```\n"}}
{"actor":{"display_login":"codecov"}}