{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/136309631","pull_request_review_id":59828247,"id":136309631,"diff_hunk":"@@ -488,7 +488,8 @@ private void renderHitContents(Hit hit) throws IOException {\n         if (id != null)\n             generator.writeStringField(ID, id);\n \n-        generator.writeNumberField(RELEVANCE, hit.getRelevance().getScore());\n+        generator.writeFieldName(RELEVANCE);\n+        generator.writeNumber(hit.getRelevance().toString());","path":"container-search/src/main/java/com/yahoo/search/rendering/JsonRenderer.java","position":6,"original_position":6,"commit_id":"ae01edaf6692d30e6206b2e6eae213f0c52a1ded","original_commit_id":"ae01edaf6692d30e6206b2e6eae213f0c52a1ded","user":{"login":"havardpe","id":3535158,"avatar_url":"https://avatars1.githubusercontent.com/u/3535158?v=4","gravatar_id":"","url":"https://api.github.com/users/havardpe","html_url":"https://github.com/havardpe","followers_url":"https://api.github.com/users/havardpe/followers","following_url":"https://api.github.com/users/havardpe/following{/other_user}","gists_url":"https://api.github.com/users/havardpe/gists{/gist_id}","starred_url":"https://api.github.com/users/havardpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/havardpe/subscriptions","organizations_url":"https://api.github.com/users/havardpe/orgs","repos_url":"https://api.github.com/users/havardpe/repos","events_url":"https://api.github.com/users/havardpe/events{/privacy}","received_events_url":"https://api.github.com/users/havardpe/received_events","type":"User","site_admin":false},"body":"(as in maybe we also need to change the XML renderer to unbreak the system tests)","created_at":"2017-08-31T11:25:21Z","updated_at":"2017-08-31T11:25:21Z","html_url":"https://github.com/vespa-engine/vespa/pull/3285#discussion_r136309631","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/136309631"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/3285#discussion_r136309631"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285"}},"in_reply_to_id":136309022},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285","id":138629189,"html_url":"https://github.com/vespa-engine/vespa/pull/3285","diff_url":"https://github.com/vespa-engine/vespa/pull/3285.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/3285.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/3285","number":3285,"state":"open","locked":false,"title":"render infinite or NaN relevance as \"0.0\"","user":{"login":"arnej27959","id":19730911,"avatar_url":"https://avatars0.githubusercontent.com/u/19730911?v=4","gravatar_id":"","url":"https://api.github.com/users/arnej27959","html_url":"https://github.com/arnej27959","followers_url":"https://api.github.com/users/arnej27959/followers","following_url":"https://api.github.com/users/arnej27959/following{/other_user}","gists_url":"https://api.github.com/users/arnej27959/gists{/gist_id}","starred_url":"https://api.github.com/users/arnej27959/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnej27959/subscriptions","organizations_url":"https://api.github.com/users/arnej27959/orgs","repos_url":"https://api.github.com/users/arnej27959/repos","events_url":"https://api.github.com/users/arnej27959/events{/privacy}","received_events_url":"https://api.github.com/users/arnej27959/received_events","type":"User","site_admin":false},"body":"@havardpe please take a look","created_at":"2017-08-31T10:12:11Z","updated_at":"2017-08-31T11:25:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3439c3c49d7f2dd5eeb26bc59144d362ed5441ee","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/3285/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/ae01edaf6692d30e6206b2e6eae213f0c52a1ded","head":{"label":"vespa-engine:arnej/render-inf-relevance-as-0","ref":"arnej/render-inf-relevance-as-0","sha":"ae01edaf6692d30e6206b2e6eae213f0c52a1ded","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2017-08-29T15:30:02Z","pushed_at":"2017-08-31T11:06:54Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"","size":50126,"stargazers_count":54,"watchers_count":54,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":54,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"21219b0c636f219e239567e7f4bd7b536dbb9cbc","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2017-08-29T15:30:02Z","pushed_at":"2017-08-31T11:06:54Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"","size":50126,"stargazers_count":54,"watchers_count":54,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/3285"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/3285"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/3285/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/3285/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/ae01edaf6692d30e6206b2e6eae213f0c52a1ded"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"havardpe"}}