{"action":"closed","number":238,"pull_request":{"url":"https://api.github.com/repos/jwiegley/use-package/pulls/238","id":41406823,"html_url":"https://github.com/jwiegley/use-package/pull/238","diff_url":"https://github.com/jwiegley/use-package/pull/238.diff","patch_url":"https://github.com/jwiegley/use-package/pull/238.patch","issue_url":"https://api.github.com/repos/jwiegley/use-package/issues/238","number":238,"state":"closed","locked":false,"title":"Make :pin work reliably.","user":{"login":"nickalcock","id":6503005,"avatar_url":"https://avatars.githubusercontent.com/u/6503005?v=3","gravatar_id":"","url":"https://api.github.com/users/nickalcock","html_url":"https://github.com/nickalcock","followers_url":"https://api.github.com/users/nickalcock/followers","following_url":"https://api.github.com/users/nickalcock/following{/other_user}","gists_url":"https://api.github.com/users/nickalcock/gists{/gist_id}","starred_url":"https://api.github.com/users/nickalcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickalcock/subscriptions","organizations_url":"https://api.github.com/users/nickalcock/orgs","repos_url":"https://api.github.com/users/nickalcock/repos","events_url":"https://api.github.com/users/nickalcock/events{/privacy}","received_events_url":"https://api.github.com/users/nickalcock/received_events","type":"User","site_admin":false},"body":"Currently, :pin's handler works much the same way as all the others:\nit expands the remaining keywords, then pins (if there is anything\nthere to pin) and expands the body appropriately.\n\nUnfortunately, the purpose of :pin is to influence the behaviour of :ensure, and\nbecause use-package has to pull in packages from ELPA at macro-expansion time\n(so it can rely on package.el picking up necessary autoloads and the like from\nthe package definition). This means that if :ensure appears in the wrong place\nin the handlers, by the time the :pin handler calls use-package-pin-package\n(which ultimately adds the package to package-pinned-packages), the package has\nalready been loaded.\n\nThe solution is to call use-package-pin-package immediately, before doing the\nexpansion. This works in all situations: if :ensure's handler is called first,\nit will call use-package-process-keywords before installing the package, so\n:pin's handler will get called: if it is called second, :pin's handler will\nstill get a chance to get in first and pin the package before :ensure's handler\ncan run.\n","created_at":"2015-08-01T19:41:21Z","updated_at":"2017-02-13T21:44:55Z","closed_at":"2017-02-13T21:44:55Z","merged_at":null,"merge_commit_sha":"33b75060d4d38008a4d956e17c8e246e9e59771a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jwiegley/use-package/pulls/238/commits","review_comments_url":"https://api.github.com/repos/jwiegley/use-package/pulls/238/comments","review_comment_url":"https://api.github.com/repos/jwiegley/use-package/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwiegley/use-package/issues/238/comments","statuses_url":"https://api.github.com/repos/jwiegley/use-package/statuses/b5f331780e3a7504ec17c33b8a97242d28566574","head":{"label":"nickalcock:master","ref":"master","sha":"b5f331780e3a7504ec17c33b8a97242d28566574","user":{"login":"nickalcock","id":6503005,"avatar_url":"https://avatars.githubusercontent.com/u/6503005?v=3","gravatar_id":"","url":"https://api.github.com/users/nickalcock","html_url":"https://github.com/nickalcock","followers_url":"https://api.github.com/users/nickalcock/followers","following_url":"https://api.github.com/users/nickalcock/following{/other_user}","gists_url":"https://api.github.com/users/nickalcock/gists{/gist_id}","starred_url":"https://api.github.com/users/nickalcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickalcock/subscriptions","organizations_url":"https://api.github.com/users/nickalcock/orgs","repos_url":"https://api.github.com/users/nickalcock/repos","events_url":"https://api.github.com/users/nickalcock/events{/privacy}","received_events_url":"https://api.github.com/users/nickalcock/received_events","type":"User","site_admin":false},"repo":{"id":39975191,"name":"use-package","full_name":"nickalcock/use-package","owner":{"login":"nickalcock","id":6503005,"avatar_url":"https://avatars.githubusercontent.com/u/6503005?v=3","gravatar_id":"","url":"https://api.github.com/users/nickalcock","html_url":"https://github.com/nickalcock","followers_url":"https://api.github.com/users/nickalcock/followers","following_url":"https://api.github.com/users/nickalcock/following{/other_user}","gists_url":"https://api.github.com/users/nickalcock/gists{/gist_id}","starred_url":"https://api.github.com/users/nickalcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickalcock/subscriptions","organizations_url":"https://api.github.com/users/nickalcock/orgs","repos_url":"https://api.github.com/users/nickalcock/repos","events_url":"https://api.github.com/users/nickalcock/events{/privacy}","received_events_url":"https://api.github.com/users/nickalcock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickalcock/use-package","description":"A use-package declaration for simplifying your .emacs","fork":true,"url":"https://api.github.com/repos/nickalcock/use-package","forks_url":"https://api.github.com/repos/nickalcock/use-package/forks","keys_url":"https://api.github.com/repos/nickalcock/use-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickalcock/use-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickalcock/use-package/teams","hooks_url":"https://api.github.com/repos/nickalcock/use-package/hooks","issue_events_url":"https://api.github.com/repos/nickalcock/use-package/issues/events{/number}","events_url":"https://api.github.com/repos/nickalcock/use-package/events","assignees_url":"https://api.github.com/repos/nickalcock/use-package/assignees{/user}","branches_url":"https://api.github.com/repos/nickalcock/use-package/branches{/branch}","tags_url":"https://api.github.com/repos/nickalcock/use-package/tags","blobs_url":"https://api.github.com/repos/nickalcock/use-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickalcock/use-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickalcock/use-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickalcock/use-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickalcock/use-package/statuses/{sha}","languages_url":"https://api.github.com/repos/nickalcock/use-package/languages","stargazers_url":"https://api.github.com/repos/nickalcock/use-package/stargazers","contributors_url":"https://api.github.com/repos/nickalcock/use-package/contributors","subscribers_url":"https://api.github.com/repos/nickalcock/use-package/subscribers","subscription_url":"https://api.github.com/repos/nickalcock/use-package/subscription","commits_url":"https://api.github.com/repos/nickalcock/use-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickalcock/use-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickalcock/use-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickalcock/use-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickalcock/use-package/contents/{+path}","compare_url":"https://api.github.com/repos/nickalcock/use-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickalcock/use-package/merges","archive_url":"https://api.github.com/repos/nickalcock/use-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickalcock/use-package/downloads","issues_url":"https://api.github.com/repos/nickalcock/use-package/issues{/number}","pulls_url":"https://api.github.com/repos/nickalcock/use-package/pulls{/number}","milestones_url":"https://api.github.com/repos/nickalcock/use-package/milestones{/number}","notifications_url":"https://api.github.com/repos/nickalcock/use-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickalcock/use-package/labels{/name}","releases_url":"https://api.github.com/repos/nickalcock/use-package/releases{/id}","deployments_url":"https://api.github.com/repos/nickalcock/use-package/deployments","created_at":"2015-07-30T22:29:55Z","updated_at":"2015-07-30T22:29:56Z","pushed_at":"2015-08-01T19:40:21Z","git_url":"git://github.com/nickalcock/use-package.git","ssh_url":"git@github.com:nickalcock/use-package.git","clone_url":"https://github.com/nickalcock/use-package.git","svn_url":"https://github.com/nickalcock/use-package","homepage":null,"size":349,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jwiegley:master","ref":"master","sha":"ab947b0fecec9c4ee81e90121c3926b340292642","user":{"login":"jwiegley","id":8460,"avatar_url":"https://avatars.githubusercontent.com/u/8460?v=3","gravatar_id":"","url":"https://api.github.com/users/jwiegley","html_url":"https://github.com/jwiegley","followers_url":"https://api.github.com/users/jwiegley/followers","following_url":"https://api.github.com/users/jwiegley/following{/other_user}","gists_url":"https://api.github.com/users/jwiegley/gists{/gist_id}","starred_url":"https://api.github.com/users/jwiegley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwiegley/subscriptions","organizations_url":"https://api.github.com/users/jwiegley/orgs","repos_url":"https://api.github.com/users/jwiegley/repos","events_url":"https://api.github.com/users/jwiegley/events{/privacy}","received_events_url":"https://api.github.com/users/jwiegley/received_events","type":"User","site_admin":false},"repo":{"id":4690846,"name":"use-package","full_name":"jwiegley/use-package","owner":{"login":"jwiegley","id":8460,"avatar_url":"https://avatars.githubusercontent.com/u/8460?v=3","gravatar_id":"","url":"https://api.github.com/users/jwiegley","html_url":"https://github.com/jwiegley","followers_url":"https://api.github.com/users/jwiegley/followers","following_url":"https://api.github.com/users/jwiegley/following{/other_user}","gists_url":"https://api.github.com/users/jwiegley/gists{/gist_id}","starred_url":"https://api.github.com/users/jwiegley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwiegley/subscriptions","organizations_url":"https://api.github.com/users/jwiegley/orgs","repos_url":"https://api.github.com/users/jwiegley/repos","events_url":"https://api.github.com/users/jwiegley/events{/privacy}","received_events_url":"https://api.github.com/users/jwiegley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwiegley/use-package","description":"A use-package declaration for simplifying your .emacs","fork":false,"url":"https://api.github.com/repos/jwiegley/use-package","forks_url":"https://api.github.com/repos/jwiegley/use-package/forks","keys_url":"https://api.github.com/repos/jwiegley/use-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwiegley/use-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwiegley/use-package/teams","hooks_url":"https://api.github.com/repos/jwiegley/use-package/hooks","issue_events_url":"https://api.github.com/repos/jwiegley/use-package/issues/events{/number}","events_url":"https://api.github.com/repos/jwiegley/use-package/events","assignees_url":"https://api.github.com/repos/jwiegley/use-package/assignees{/user}","branches_url":"https://api.github.com/repos/jwiegley/use-package/branches{/branch}","tags_url":"https://api.github.com/repos/jwiegley/use-package/tags","blobs_url":"https://api.github.com/repos/jwiegley/use-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwiegley/use-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwiegley/use-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwiegley/use-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwiegley/use-package/statuses/{sha}","languages_url":"https://api.github.com/repos/jwiegley/use-package/languages","stargazers_url":"https://api.github.com/repos/jwiegley/use-package/stargazers","contributors_url":"https://api.github.com/repos/jwiegley/use-package/contributors","subscribers_url":"https://api.github.com/repos/jwiegley/use-package/subscribers","subscription_url":"https://api.github.com/repos/jwiegley/use-package/subscription","commits_url":"https://api.github.com/repos/jwiegley/use-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwiegley/use-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwiegley/use-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwiegley/use-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwiegley/use-package/contents/{+path}","compare_url":"https://api.github.com/repos/jwiegley/use-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwiegley/use-package/merges","archive_url":"https://api.github.com/repos/jwiegley/use-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwiegley/use-package/downloads","issues_url":"https://api.github.com/repos/jwiegley/use-package/issues{/number}","pulls_url":"https://api.github.com/repos/jwiegley/use-package/pulls{/number}","milestones_url":"https://api.github.com/repos/jwiegley/use-package/milestones{/number}","notifications_url":"https://api.github.com/repos/jwiegley/use-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwiegley/use-package/labels{/name}","releases_url":"https://api.github.com/repos/jwiegley/use-package/releases{/id}","deployments_url":"https://api.github.com/repos/jwiegley/use-package/deployments","created_at":"2012-06-17T09:40:51Z","updated_at":"2017-02-13T15:05:13Z","pushed_at":"2017-02-13T21:44:05Z","git_url":"git://github.com/jwiegley/use-package.git","ssh_url":"git@github.com:jwiegley/use-package.git","clone_url":"https://github.com/jwiegley/use-package.git","svn_url":"https://github.com/jwiegley/use-package","homepage":null,"size":384,"stargazers_count":1379,"watchers_count":1379,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":57,"forks":120,"open_issues":57,"watchers":1379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwiegley/use-package/pulls/238"},"html":{"href":"https://github.com/jwiegley/use-package/pull/238"},"issue":{"href":"https://api.github.com/repos/jwiegley/use-package/issues/238"},"comments":{"href":"https://api.github.com/repos/jwiegley/use-package/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/jwiegley/use-package/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/jwiegley/use-package/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwiegley/use-package/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/jwiegley/use-package/statuses/b5f331780e3a7504ec17c33b8a97242d28566574"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jwiegley"}}