{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/154618139","pull_request_review_id":80804795,"id":154618139,"diff_hunk":"@@ -34,9 +34,13 @@\n from iris.coords import CellMethod, DimCoord\n from iris.cube import Cube, CubeList\n from iris.exceptions import CoordinateNotFoundError\n+from iris.util import new_axis","path":"lib/improver/utilities/spatial.py","position":4,"original_position":4,"commit_id":"55e8a55bc7c699f251a4c4f63a089af0ce360c5e","original_commit_id":"55e8a55bc7c699f251a4c4f63a089af0ce360c5e","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Unused new_axis imported from iris.util](https://www.codacy.com/app/metoppv_tech/improver/pullRequest?prid=1128351)","created_at":"2017-12-04T11:06:59Z","updated_at":"2017-12-04T11:06:59Z","html_url":"https://github.com/metoppv/improver/pull/357#discussion_r154618139","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/357","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/154618139"},"html":{"href":"https://github.com/metoppv/improver/pull/357#discussion_r154618139"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/357","id":156166910,"html_url":"https://github.com/metoppv/improver/pull/357","diff_url":"https://github.com/metoppv/improver/pull/357.diff","patch_url":"https://github.com/metoppv/improver/pull/357.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/357","number":357,"state":"open","locked":false,"title":"nbhood: preserve dimensionality and units where possible","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"body":"This change avoids introducing extra realization or time dimensions during the neighbourhood processing process.\r\n\r\nThis happens particularly for the lead time varying radii change since it has to slice over time. For a single cube with scalar time, an additional time dimension would have been added. This is different behaviour from the fixed radius path.\r\n\r\nAn exception is the occurrence within vicinity, since that explicitly collapses realization.\r\n\r\nThis change also fixes an accidental permanent conversion of the forecast_period coordinate into hours during the lead time calculation.\r\n\r\nUpdated existing unit tests - result cubes should always match input cube dimensionality now (except for occurrence within vicinity realization collapse).","created_at":"2017-12-04T11:02:24Z","updated_at":"2017-12-04T11:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4af37d279d7ad961aeb0694145d90e8db857901","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/357/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/357/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/357/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/55e8a55bc7c699f251a4c4f63a089af0ce360c5e","head":{"label":"benfitzpatrick:nbhood_lead_times_metadata","ref":"nbhood_lead_times_metadata","sha":"55e8a55bc7c699f251a4c4f63a089af0ce360c5e","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"repo":{"id":85334941,"name":"improver","full_name":"benfitzpatrick/improver","owner":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfitzpatrick/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/benfitzpatrick/improver","forks_url":"https://api.github.com/repos/benfitzpatrick/improver/forks","keys_url":"https://api.github.com/repos/benfitzpatrick/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfitzpatrick/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfitzpatrick/improver/teams","hooks_url":"https://api.github.com/repos/benfitzpatrick/improver/hooks","issue_events_url":"https://api.github.com/repos/benfitzpatrick/improver/issues/events{/number}","events_url":"https://api.github.com/repos/benfitzpatrick/improver/events","assignees_url":"https://api.github.com/repos/benfitzpatrick/improver/assignees{/user}","branches_url":"https://api.github.com/repos/benfitzpatrick/improver/branches{/branch}","tags_url":"https://api.github.com/repos/benfitzpatrick/improver/tags","blobs_url":"https://api.github.com/repos/benfitzpatrick/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfitzpatrick/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfitzpatrick/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfitzpatrick/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfitzpatrick/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/benfitzpatrick/improver/languages","stargazers_url":"https://api.github.com/repos/benfitzpatrick/improver/stargazers","contributors_url":"https://api.github.com/repos/benfitzpatrick/improver/contributors","subscribers_url":"https://api.github.com/repos/benfitzpatrick/improver/subscribers","subscription_url":"https://api.github.com/repos/benfitzpatrick/improver/subscription","commits_url":"https://api.github.com/repos/benfitzpatrick/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfitzpatrick/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfitzpatrick/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfitzpatrick/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfitzpatrick/improver/contents/{+path}","compare_url":"https://api.github.com/repos/benfitzpatrick/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfitzpatrick/improver/merges","archive_url":"https://api.github.com/repos/benfitzpatrick/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfitzpatrick/improver/downloads","issues_url":"https://api.github.com/repos/benfitzpatrick/improver/issues{/number}","pulls_url":"https://api.github.com/repos/benfitzpatrick/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/benfitzpatrick/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/benfitzpatrick/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfitzpatrick/improver/labels{/name}","releases_url":"https://api.github.com/repos/benfitzpatrick/improver/releases{/id}","deployments_url":"https://api.github.com/repos/benfitzpatrick/improver/deployments","created_at":"2017-03-17T16:53:45Z","updated_at":"2017-06-06T08:28:29Z","pushed_at":"2017-12-04T11:03:42Z","git_url":"git://github.com/benfitzpatrick/improver.git","ssh_url":"git@github.com:benfitzpatrick/improver.git","clone_url":"https://github.com/benfitzpatrick/improver.git","svn_url":"https://github.com/benfitzpatrick/improver","homepage":null,"size":2204,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"676080caee358cdd97f64a2c91fd31d3006127d9","user":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2017-11-28T10:19:19Z","pushed_at":"2017-12-04T11:02:25Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"","size":2247,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":20,"open_issues":103,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/357"},"html":{"href":"https://github.com/metoppv/improver/pull/357"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/357"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/55e8a55bc7c699f251a4c4f63a089af0ce360c5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}