{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/19211","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/19211/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/19211/comments","events_url":"https://api.github.com/repos/apache/spark/issues/19211/events","html_url":"https://github.com/apache/spark/pull/19211","id":257190450,"number":19211,"title":"[SPARK-18838][core] Add separate listener queues to LiveListenerBus.","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-12T21:31:50Z","updated_at":"2017-09-13T20:28:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/19211","html_url":"https://github.com/apache/spark/pull/19211","diff_url":"https://github.com/apache/spark/pull/19211.diff","patch_url":"https://github.com/apache/spark/pull/19211.patch"},"body":"This change modifies the live listener bus so that all listeners are\r\nadded to queues; each queue has its own thread to dispatch events,\r\nmaking it possible to separate slow listeners from other more\r\nperformance-sensitive ones.\r\n\r\nThe public API has not changed - all listeners added with the existing\r\n\"addListener\" method, which after this change mostly means all\r\nuser-defined listeners, end up in a default queue. Internally, there's\r\nan API allowing listeners to be added to specific queues, and that API\r\nis used to separate the internal Spark listeners into 3 categories:\r\napplication status listeners (e.g. UI), executor management (e.g. dynamic\r\nallocation), and the event log.\r\n\r\nThe queueing logic, while abstracted away in a separate class, is kept\r\nas much as possible hidden away from consumers. Aside from choosing their\r\nqueue, there's no code change needed to take advantage of queues.\r\n\r\nTest coverage relies on existing tests; a few tests had to be tweaked\r\nbecause they relied on `LiveListenerBus.postToAll` being synchronous,\r\nand the change makes that method asynchronous. Other tests were simplified\r\nnot to use the asynchronous LiveListenerBus.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/329287230","html_url":"https://github.com/apache/spark/pull/19211#issuecomment-329287230","issue_url":"https://api.github.com/repos/apache/spark/issues/19211","id":329287230,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T20:28:06Z","updated_at":"2017-09-13T20:28:06Z","author_association":"NONE","body":"**[Test build #81728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81728/testReport)** for PR 19211 at commit [`ad6ff49`](https://github.com/apache/spark/commit/ad6ff49de17c204e8d4feb775185a05d7fa9f53b).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}