{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/3590","repository_url":"https://api.github.com/repos/Azure/azure-sdk-for-net","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/3590/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/3590/comments","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/3590/events","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/3590","id":250416779,"number":3590,"title":"Fixes for AzureEnvironment.cs","user":{"login":"aimankhan","id":13143035,"avatar_url":"https://avatars1.githubusercontent.com/u/13143035?v=4","gravatar_id":"","url":"https://api.github.com/users/aimankhan","html_url":"https://github.com/aimankhan","followers_url":"https://api.github.com/users/aimankhan/followers","following_url":"https://api.github.com/users/aimankhan/following{/other_user}","gists_url":"https://api.github.com/users/aimankhan/gists{/gist_id}","starred_url":"https://api.github.com/users/aimankhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimankhan/subscriptions","organizations_url":"https://api.github.com/users/aimankhan/orgs","repos_url":"https://api.github.com/users/aimankhan/repos","events_url":"https://api.github.com/users/aimankhan/events{/privacy}","received_events_url":"https://api.github.com/users/aimankhan/received_events","type":"User","site_admin":false},"labels":[{"id":128410461,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-15T19:43:47Z","updated_at":"2017-08-15T19:48:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/3590","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/3590","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/3590.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/3590.patch"},"body":"The Management and ResourceManager endpoints for Fairfax are incorrect. The authentication endpoint is deprecated and Azure documentation suggests using the newer endpoint at https://docs.microsoft.com/en-us/azure/azure-government/documentation-government-developer-guide\r\n\r\n<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n<!--\r\nPlease add an informative description that covers that changes made by the pull request.\r\n\r\nIf you are regenerating your SDK based off of a new swagger spec, please add the link to the corresponding swagger spec pull request that has been merged in the azure-rest-api-specs repository\r\n-->\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md).**\r\n- [x] **The pull request does not introduce [breaking changes](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md).**\r\n\r\n### [General Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#general-guidelines)\r\n- [x] Title of the pull request is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n\r\n### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#testing-guidelines)\r\n- [x] Pull request includes test coverage for the included changes.\r\n\r\n### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#sdk-generation-guidelines)\r\n- [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.\r\n- [x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.\r\n- [x] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK.\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments/322569338","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/3590#issuecomment-322569338","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/3590","id":322569338,"user":{"login":"msftclas","id":9287708,"avatar_url":"https://avatars1.githubusercontent.com/u/9287708?v=4","gravatar_id":"","url":"https://api.github.com/users/msftclas","html_url":"https://github.com/msftclas","followers_url":"https://api.github.com/users/msftclas/followers","following_url":"https://api.github.com/users/msftclas/following{/other_user}","gists_url":"https://api.github.com/users/msftclas/gists{/gist_id}","starred_url":"https://api.github.com/users/msftclas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftclas/subscriptions","organizations_url":"https://api.github.com/users/msftclas/orgs","repos_url":"https://api.github.com/users/msftclas/repos","events_url":"https://api.github.com/users/msftclas/events{/privacy}","received_events_url":"https://api.github.com/users/msftclas/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T19:48:25Z","updated_at":"2017-08-15T19:48:25Z","body":"\r\n@aimankhan,\nThanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.\n_Thanks,\nMicrosoft Pull Request Bot_"}}
{"actor":{"display_login":"msftclas"}}