{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/115240361","pull_request_review_id":36762904,"id":115240361,"diff_hunk":"@@ -467,30 +467,36 @@ func (r *Runtime) StopContainer(c *Container) error {\n func (r *Runtime) DeleteContainer(c *Container) error {\n \tc.opLock.Lock()\n \tdefer c.opLock.Unlock()\n-\treturn utils.ExecCmdWithStdStreams(os.Stdin, os.Stdout, os.Stderr, r.Path(c), \"delete\", c.name)\n+\treturn utils.ExecCmdWithStdStreams(os.Stdin, os.Stdout, os.Stderr, r.Path(c), \"delete\", c.Name)\n }\n \n // UpdateStatus refreshes the status of the container.\n func (r *Runtime) UpdateStatus(c *Container) error {\n \tc.opLock.Lock()\n \tdefer c.opLock.Unlock()\n-\tout, err := exec.Command(r.Path(c), \"state\", c.name).CombinedOutput()\n+\t// TODO: provide a default state like createdAt and such!\n+\t// idally, this state should be stored on disk for restore after reboot","path":"oci/oci.go","position":121,"original_position":121,"commit_id":"30b6b81748ca728e1d428e61d6b811ec497a5733","original_commit_id":"30b6b81748ca728e1d428e61d6b811ec497a5733","user":{"login":"TomSweeneyRedHat","id":25613829,"avatar_url":"https://avatars0.githubusercontent.com/u/25613829?v=3","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"body":"nit \"idally,\" to \"Ideally\"","created_at":"2017-05-08T12:55:05Z","updated_at":"2017-05-08T12:55:06Z","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/499#discussion_r115240361","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/115240361"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/499#discussion_r115240361"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499","id":119318707,"html_url":"https://github.com/kubernetes-incubator/cri-o/pull/499","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/499.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/499.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/499","number":499,"state":"open","locked":false,"title":"[WIP] Fix restore","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars1.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/kubernetes-incubator/cri-o/issues/497\r\n\r\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","created_at":"2017-05-06T22:37:57Z","updated_at":"2017-05-08T12:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6fed50ed5fef23a3b3f5ab943b5bd20e7bf2ed2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/499/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/30b6b81748ca728e1d428e61d6b811ec497a5733","head":{"label":"runcom:adjust-restore","ref":"adjust-restore","sha":"30b6b81748ca728e1d428e61d6b811ec497a5733","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars1.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"repo":{"id":67835263,"name":"ocid-1","full_name":"runcom/ocid-1","owner":{"login":"runcom","id":849915,"avatar_url":"https://avatars1.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runcom/ocid-1","description":"Open Container Image Format integration to Kubernetes","fork":true,"url":"https://api.github.com/repos/runcom/ocid-1","forks_url":"https://api.github.com/repos/runcom/ocid-1/forks","keys_url":"https://api.github.com/repos/runcom/ocid-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runcom/ocid-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runcom/ocid-1/teams","hooks_url":"https://api.github.com/repos/runcom/ocid-1/hooks","issue_events_url":"https://api.github.com/repos/runcom/ocid-1/issues/events{/number}","events_url":"https://api.github.com/repos/runcom/ocid-1/events","assignees_url":"https://api.github.com/repos/runcom/ocid-1/assignees{/user}","branches_url":"https://api.github.com/repos/runcom/ocid-1/branches{/branch}","tags_url":"https://api.github.com/repos/runcom/ocid-1/tags","blobs_url":"https://api.github.com/repos/runcom/ocid-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runcom/ocid-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runcom/ocid-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/runcom/ocid-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runcom/ocid-1/statuses/{sha}","languages_url":"https://api.github.com/repos/runcom/ocid-1/languages","stargazers_url":"https://api.github.com/repos/runcom/ocid-1/stargazers","contributors_url":"https://api.github.com/repos/runcom/ocid-1/contributors","subscribers_url":"https://api.github.com/repos/runcom/ocid-1/subscribers","subscription_url":"https://api.github.com/repos/runcom/ocid-1/subscription","commits_url":"https://api.github.com/repos/runcom/ocid-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/runcom/ocid-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/runcom/ocid-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/runcom/ocid-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/runcom/ocid-1/contents/{+path}","compare_url":"https://api.github.com/repos/runcom/ocid-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runcom/ocid-1/merges","archive_url":"https://api.github.com/repos/runcom/ocid-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runcom/ocid-1/downloads","issues_url":"https://api.github.com/repos/runcom/ocid-1/issues{/number}","pulls_url":"https://api.github.com/repos/runcom/ocid-1/pulls{/number}","milestones_url":"https://api.github.com/repos/runcom/ocid-1/milestones{/number}","notifications_url":"https://api.github.com/repos/runcom/ocid-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runcom/ocid-1/labels{/name}","releases_url":"https://api.github.com/repos/runcom/ocid-1/releases{/id}","deployments_url":"https://api.github.com/repos/runcom/ocid-1/deployments","created_at":"2016-09-09T21:56:48Z","updated_at":"2016-09-29T20:40:06Z","pushed_at":"2017-05-08T12:47:59Z","git_url":"git://github.com/runcom/ocid-1.git","ssh_url":"git@github.com:runcom/ocid-1.git","clone_url":"https://github.com/runcom/ocid-1.git","svn_url":"https://github.com/runcom/ocid-1","homepage":null,"size":33614,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"88b8a9efe19038fbbcc1876ee9c1e5c3bf065515","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":67828134,"name":"cri-o","full_name":"kubernetes-incubator/cri-o","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/deployments","created_at":"2016-09-09T19:56:31Z","updated_at":"2017-05-07T08:50:57Z","pushed_at":"2017-05-08T12:48:01Z","git_url":"git://github.com/kubernetes-incubator/cri-o.git","ssh_url":"git@github.com:kubernetes-incubator/cri-o.git","clone_url":"https://github.com/kubernetes-incubator/cri-o.git","svn_url":"https://github.com/kubernetes-incubator/cri-o","homepage":"","size":37464,"stargazers_count":433,"watchers_count":433,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":79,"forks":77,"open_issues":79,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/499"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/499"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/30b6b81748ca728e1d428e61d6b811ec497a5733"}}}}
{"actor":{"display_login":"TomSweeneyRedHat"}}