{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/comments/135308439","pull_request_review_id":58711237,"id":135308439,"diff_hunk":"@@ -830,18 +839,46 @@ <h4 id=\"algorithm-create\" algorithm>Create a `Credential`</h4>\n             types in order to support a \"sign-up\" use case. For the moment, though, we're punting\n             on that by restricting the dictionary to a single entry.\n \n-    5.  Let |p| be [=a new promise=].\n+    6.  Let |p| be [=a new promise=].\n \n-    6.  Run the following steps [=in parallel=]:\n+    7.  Let |origin| be the [=current settings object=]'s [=environment settings object/origin=].\n \n-        1.  Let |r| be the result of executing |interfaces|[0] {{Credential/[[Create]](options)}}\n-            internal method on |options|.\n+    8.  Run the following substeps [=in parallel=]:\n \n-        2.  If |r| is an [=exception=], [=reject=] |p| with |r|.\n+        1.  Let |r| be the result of executing |interfaces|[0]'s {{Credential/[[Create]](origin, options)}}\n+            internal method given |origin| and |options|.\n \n-            Otherwise, [=resolve=] |p| with |r|.\n+        2.  If |r| is an [=exception=], [=reject=] |p| with |r|, and terminate these substeps.\n \n-    7.  Return |p|.\n+        3.  If |r| is a {{Credential}}, [=resolve=] |p| with |r|, and terminate these substeps.\n+\n+        4.  Otherwise, |r| must be a [=struct=] whose [=items=] are:","path":"index.src.html","position":118,"original_position":118,"commit_id":"672d8de3f5c4fba632b7491ae75a03f0894d1336","original_commit_id":"672d8de3f5c4fba632b7491ae75a03f0894d1336","user":{"login":"equalsJeffH","id":226571,"avatar_url":"https://avatars0.githubusercontent.com/u/226571?v=4","gravatar_id":"","url":"https://api.github.com/users/equalsJeffH","html_url":"https://github.com/equalsJeffH","followers_url":"https://api.github.com/users/equalsJeffH/followers","following_url":"https://api.github.com/users/equalsJeffH/following{/other_user}","gists_url":"https://api.github.com/users/equalsJeffH/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsJeffH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsJeffH/subscriptions","organizations_url":"https://api.github.com/users/equalsJeffH/orgs","repos_url":"https://api.github.com/users/equalsJeffH/repos","events_url":"https://api.github.com/users/equalsJeffH/events{/privacy}","received_events_url":"https://api.github.com/users/equalsJeffH/received_events","type":"User","site_admin":false},"body":"Ok, I suspected y'all would suggest those. \r\n\r\nwrt using `Assert:` -- my understanding is that it is more a spec-level thing (https://infra.spec.whatwg.org/#assertions) and not a RFC2119 conformance requirement to implementors.  the latter is what is intended there.  I was unsure about capitalizing the \"must\" (see issue #101).\r\n\r\nwrt \"moving this description up\" -- I agree.  will take a stab at that. ","created_at":"2017-08-25T17:12:44Z","updated_at":"2017-08-25T17:12:44Z","html_url":"https://github.com/w3c/webappsec-credential-management/pull/100#discussion_r135308439","pull_request_url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/comments/135308439"},"html":{"href":"https://github.com/w3c/webappsec-credential-management/pull/100#discussion_r135308439"},"pull_request":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100"}},"in_reply_to_id":135290986},"pull_request":{"url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100","id":137597236,"html_url":"https://github.com/w3c/webappsec-credential-management/pull/100","diff_url":"https://github.com/w3c/webappsec-credential-management/pull/100.diff","patch_url":"https://github.com/w3c/webappsec-credential-management/pull/100.patch","issue_url":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/100","number":100,"state":"open","locked":false,"title":"issue 92 accessing settings object: add passing global and queue task invoke callback","user":{"login":"equalsJeffH","id":226571,"avatar_url":"https://avatars0.githubusercontent.com/u/226571?v=4","gravatar_id":"","url":"https://api.github.com/users/equalsJeffH","html_url":"https://github.com/equalsJeffH","followers_url":"https://api.github.com/users/equalsJeffH/followers","following_url":"https://api.github.com/users/equalsJeffH/following{/other_user}","gists_url":"https://api.github.com/users/equalsJeffH/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsJeffH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsJeffH/subscriptions","organizations_url":"https://api.github.com/users/equalsJeffH/orgs","repos_url":"https://api.github.com/users/equalsJeffH/repos","events_url":"https://api.github.com/users/equalsJeffH/events{/privacy}","received_events_url":"https://api.github.com/users/equalsJeffH/received_events","type":"User","site_admin":false},"body":"this drafty draft implements @domenic's suggestions (https://github.com/w3c/webappsec-credential-management/pull/93#issuecomment-324192540) in credman (only for [credential creation](https://w3c.github.io/webappsec-credential-management/#algorithm-create), not yet for \"request a credential\" aka (in webauthn) as \"get assertion\"). \n\nFor the webauthn side of this, see the current state of https://github.com/w3c/webauthn/pull/498 (rendered diff here: https://s3.amazonaws.com/pr-preview/w3c/webauthn/cca20d3...6a011d2.html)\n\nIt would be great to _please_ get feedback before proceeding and applying this approach to the \"request a credential\" alg.\n\nPlease also note that this PR is for the \"issue-92-accessing-settings-object\" branch (rather than master) and it fixes a few things I'd noted [in my review of PR #93](https://github.com/w3c/webappsec-credential-management/pull/93#pullrequestreview-58115822).\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n[Preview](https://s3.amazonaws.com/pr-preview/equalsJeffH/webappsec-credential-management/jeffh-issue-92-accessing-settings-object.html) | [Diff](https://s3.amazonaws.com/pr-preview/w3c/webappsec-credential-management/b34d4c8...equalsJeffH:672d8de.html)","created_at":"2017-08-25T04:10:22Z","updated_at":"2017-08-25T17:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21a4f647173c89bd2ba1de609a5593dd5d5a0735","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100/commits","review_comments_url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100/comments","review_comment_url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/100/comments","statuses_url":"https://api.github.com/repos/w3c/webappsec-credential-management/statuses/672d8de3f5c4fba632b7491ae75a03f0894d1336","head":{"label":"equalsJeffH:jeffh-issue-92-accessing-settings-object","ref":"jeffh-issue-92-accessing-settings-object","sha":"672d8de3f5c4fba632b7491ae75a03f0894d1336","user":{"login":"equalsJeffH","id":226571,"avatar_url":"https://avatars0.githubusercontent.com/u/226571?v=4","gravatar_id":"","url":"https://api.github.com/users/equalsJeffH","html_url":"https://github.com/equalsJeffH","followers_url":"https://api.github.com/users/equalsJeffH/followers","following_url":"https://api.github.com/users/equalsJeffH/following{/other_user}","gists_url":"https://api.github.com/users/equalsJeffH/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsJeffH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsJeffH/subscriptions","organizations_url":"https://api.github.com/users/equalsJeffH/orgs","repos_url":"https://api.github.com/users/equalsJeffH/repos","events_url":"https://api.github.com/users/equalsJeffH/events{/privacy}","received_events_url":"https://api.github.com/users/equalsJeffH/received_events","type":"User","site_admin":false},"repo":{"id":101096507,"name":"webappsec-credential-management","full_name":"equalsJeffH/webappsec-credential-management","owner":{"login":"equalsJeffH","id":226571,"avatar_url":"https://avatars0.githubusercontent.com/u/226571?v=4","gravatar_id":"","url":"https://api.github.com/users/equalsJeffH","html_url":"https://github.com/equalsJeffH","followers_url":"https://api.github.com/users/equalsJeffH/followers","following_url":"https://api.github.com/users/equalsJeffH/following{/other_user}","gists_url":"https://api.github.com/users/equalsJeffH/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsJeffH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsJeffH/subscriptions","organizations_url":"https://api.github.com/users/equalsJeffH/orgs","repos_url":"https://api.github.com/users/equalsJeffH/repos","events_url":"https://api.github.com/users/equalsJeffH/events{/privacy}","received_events_url":"https://api.github.com/users/equalsJeffH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/equalsJeffH/webappsec-credential-management","description":"WebAppSec Credential Management","fork":true,"url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management","forks_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/forks","keys_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/teams","hooks_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/hooks","issue_events_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/issues/events{/number}","events_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/events","assignees_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/assignees{/user}","branches_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/branches{/branch}","tags_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/tags","blobs_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/statuses/{sha}","languages_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/languages","stargazers_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/stargazers","contributors_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/contributors","subscribers_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/subscribers","subscription_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/subscription","commits_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/contents/{+path}","compare_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/merges","archive_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/downloads","issues_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/issues{/number}","pulls_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/pulls{/number}","milestones_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/milestones{/number}","notifications_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/labels{/name}","releases_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/releases{/id}","deployments_url":"https://api.github.com/repos/equalsJeffH/webappsec-credential-management/deployments","created_at":"2017-08-22T18:47:16Z","updated_at":"2017-08-22T18:47:18Z","pushed_at":"2017-08-25T01:50:24Z","git_url":"git://github.com/equalsJeffH/webappsec-credential-management.git","ssh_url":"git@github.com:equalsJeffH/webappsec-credential-management.git","clone_url":"https://github.com/equalsJeffH/webappsec-credential-management.git","svn_url":"https://github.com/equalsJeffH/webappsec-credential-management","homepage":"https://w3c.github.io/webappsec-credential-management/","size":1853,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:issue-92-accessing-settings-object","ref":"issue-92-accessing-settings-object","sha":"b34d4c85bc34aebda7d9d26732a87ae4b8b02b06","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":43490797,"name":"webappsec-credential-management","full_name":"w3c/webappsec-credential-management","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webappsec-credential-management","description":"WebAppSec Credential Management","fork":false,"url":"https://api.github.com/repos/w3c/webappsec-credential-management","forks_url":"https://api.github.com/repos/w3c/webappsec-credential-management/forks","keys_url":"https://api.github.com/repos/w3c/webappsec-credential-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webappsec-credential-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webappsec-credential-management/teams","hooks_url":"https://api.github.com/repos/w3c/webappsec-credential-management/hooks","issue_events_url":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webappsec-credential-management/events","assignees_url":"https://api.github.com/repos/w3c/webappsec-credential-management/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webappsec-credential-management/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webappsec-credential-management/tags","blobs_url":"https://api.github.com/repos/w3c/webappsec-credential-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webappsec-credential-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webappsec-credential-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webappsec-credential-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webappsec-credential-management/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webappsec-credential-management/languages","stargazers_url":"https://api.github.com/repos/w3c/webappsec-credential-management/stargazers","contributors_url":"https://api.github.com/repos/w3c/webappsec-credential-management/contributors","subscribers_url":"https://api.github.com/repos/w3c/webappsec-credential-management/subscribers","subscription_url":"https://api.github.com/repos/w3c/webappsec-credential-management/subscription","commits_url":"https://api.github.com/repos/w3c/webappsec-credential-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webappsec-credential-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webappsec-credential-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webappsec-credential-management/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webappsec-credential-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webappsec-credential-management/merges","archive_url":"https://api.github.com/repos/w3c/webappsec-credential-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webappsec-credential-management/downloads","issues_url":"https://api.github.com/repos/w3c/webappsec-credential-management/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webappsec-credential-management/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webappsec-credential-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webappsec-credential-management/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webappsec-credential-management/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webappsec-credential-management/deployments","created_at":"2015-10-01T10:33:02Z","updated_at":"2017-08-24T10:44:47Z","pushed_at":"2017-08-25T04:10:22Z","git_url":"git://github.com/w3c/webappsec-credential-management.git","ssh_url":"git@github.com:w3c/webappsec-credential-management.git","clone_url":"https://github.com/w3c/webappsec-credential-management.git","svn_url":"https://github.com/w3c/webappsec-credential-management","homepage":"https://w3c.github.io/webappsec-credential-management/","size":1474,"stargazers_count":14,"watchers_count":14,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":48,"forks":12,"open_issues":48,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100"},"html":{"href":"https://github.com/w3c/webappsec-credential-management/pull/100"},"issue":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/100"},"comments":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webappsec-credential-management/statuses/672d8de3f5c4fba632b7491ae75a03f0894d1336"}}}}
{"actor":{"display_login":"equalsJeffH"}}