{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/comments/146483403","pull_request_review_id":71429834,"id":146483403,"diff_hunk":"@@ -139,7 +139,7 @@ resource \"aws_nat_gateway\" \"this\" {\n   allocation_id = \"${element(aws_eip.nat.*.id, (var.single_nat_gateway ? 0 : count.index))}\"\n   subnet_id     = \"${element(aws_subnet.public.*.id, (var.single_nat_gateway ? 0 : count.index))}\"\n \n-  tags = \"${merge(var.tags, map(\"Name\", format(\"%s\", var.name)))}\"\n+  tags = \"${merge(var.tags, map(\"Name\", format(\"%s-%s\", var.name, element(var.azs, count.index))))}\"","path":"main.tf","position":5,"original_position":5,"commit_id":"e4fad19e8472630575f4fb536f7fce0b801f2bcd","original_commit_id":"e4fad19e8472630575f4fb536f7fce0b801f2bcd","user":{"login":"antonbabenko","id":393243,"avatar_url":"https://avatars3.githubusercontent.com/u/393243?v=4","gravatar_id":"","url":"https://api.github.com/users/antonbabenko","html_url":"https://github.com/antonbabenko","followers_url":"https://api.github.com/users/antonbabenko/followers","following_url":"https://api.github.com/users/antonbabenko/following{/other_user}","gists_url":"https://api.github.com/users/antonbabenko/gists{/gist_id}","starred_url":"https://api.github.com/users/antonbabenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonbabenko/subscriptions","organizations_url":"https://api.github.com/users/antonbabenko/orgs","repos_url":"https://api.github.com/users/antonbabenko/repos","events_url":"https://api.github.com/users/antonbabenko/events{/privacy}","received_events_url":"https://api.github.com/users/antonbabenko/received_events","type":"User","site_admin":false},"body":"This will probably give the wrong result when AZs are listed not alphabetically and `single_nat_gateway = true`. Correct me if I am wrong.","created_at":"2017-10-24T08:19:01Z","updated_at":"2017-10-24T08:19:02Z","html_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13#discussion_r146483403","pull_request_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/comments/146483403"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13#discussion_r146483403"},"pull_request":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13","id":148321743,"html_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13.patch","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/13","number":13,"state":"open","locked":false,"title":"Add AZ to nat gateway name","user":{"login":"felixb","id":192135,"avatar_url":"https://avatars1.githubusercontent.com/u/192135?v=4","gravatar_id":"","url":"https://api.github.com/users/felixb","html_url":"https://github.com/felixb","followers_url":"https://api.github.com/users/felixb/followers","following_url":"https://api.github.com/users/felixb/following{/other_user}","gists_url":"https://api.github.com/users/felixb/gists{/gist_id}","starred_url":"https://api.github.com/users/felixb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixb/subscriptions","organizations_url":"https://api.github.com/users/felixb/orgs","repos_url":"https://api.github.com/users/felixb/repos","events_url":"https://api.github.com/users/felixb/events{/privacy}","received_events_url":"https://api.github.com/users/felixb/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-24T07:53:50Z","updated_at":"2017-10-24T08:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da519cf356902534100b50b64da4d09e216a313","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13/commits","review_comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13/comments","review_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/13/comments","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/statuses/e4fad19e8472630575f4fb536f7fce0b801f2bcd","head":{"label":"felixb:nat-gateway-tags","ref":"nat-gateway-tags","sha":"e4fad19e8472630575f4fb536f7fce0b801f2bcd","user":{"login":"felixb","id":192135,"avatar_url":"https://avatars1.githubusercontent.com/u/192135?v=4","gravatar_id":"","url":"https://api.github.com/users/felixb","html_url":"https://github.com/felixb","followers_url":"https://api.github.com/users/felixb/followers","following_url":"https://api.github.com/users/felixb/following{/other_user}","gists_url":"https://api.github.com/users/felixb/gists{/gist_id}","starred_url":"https://api.github.com/users/felixb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixb/subscriptions","organizations_url":"https://api.github.com/users/felixb/orgs","repos_url":"https://api.github.com/users/felixb/repos","events_url":"https://api.github.com/users/felixb/events{/privacy}","received_events_url":"https://api.github.com/users/felixb/received_events","type":"User","site_admin":false},"repo":{"id":108089878,"name":"terraform-aws-vpc","full_name":"felixb/terraform-aws-vpc","owner":{"login":"felixb","id":192135,"avatar_url":"https://avatars1.githubusercontent.com/u/192135?v=4","gravatar_id":"","url":"https://api.github.com/users/felixb","html_url":"https://github.com/felixb","followers_url":"https://api.github.com/users/felixb/followers","following_url":"https://api.github.com/users/felixb/following{/other_user}","gists_url":"https://api.github.com/users/felixb/gists{/gist_id}","starred_url":"https://api.github.com/users/felixb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixb/subscriptions","organizations_url":"https://api.github.com/users/felixb/orgs","repos_url":"https://api.github.com/users/felixb/repos","events_url":"https://api.github.com/users/felixb/events{/privacy}","received_events_url":"https://api.github.com/users/felixb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixb/terraform-aws-vpc","description":"Terraform module which creates VPC resources on AWS","fork":true,"url":"https://api.github.com/repos/felixb/terraform-aws-vpc","forks_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/forks","keys_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/teams","hooks_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/hooks","issue_events_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/issues/events{/number}","events_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/events","assignees_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/assignees{/user}","branches_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/branches{/branch}","tags_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/tags","blobs_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/statuses/{sha}","languages_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/languages","stargazers_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/stargazers","contributors_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/contributors","subscribers_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/subscribers","subscription_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/subscription","commits_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/contents/{+path}","compare_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/merges","archive_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/downloads","issues_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/issues{/number}","pulls_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/pulls{/number}","milestones_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/milestones{/number}","notifications_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/labels{/name}","releases_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/releases{/id}","deployments_url":"https://api.github.com/repos/felixb/terraform-aws-vpc/deployments","created_at":"2017-10-24T07:07:29Z","updated_at":"2017-10-24T07:07:31Z","pushed_at":"2017-10-24T07:53:34Z","git_url":"git://github.com/felixb/terraform-aws-vpc.git","ssh_url":"git@github.com:felixb/terraform-aws-vpc.git","clone_url":"https://github.com/felixb/terraform-aws-vpc.git","svn_url":"https://github.com/felixb/terraform-aws-vpc","homepage":"https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws","size":14,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-aws-modules:master","ref":"master","sha":"c5c41556d7d85b3f1b05bfb5fe8e5dfd4b2bb361","user":{"login":"terraform-aws-modules","id":31414033,"avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":101660954,"name":"terraform-aws-vpc","full_name":"terraform-aws-modules/terraform-aws-vpc","owner":{"login":"terraform-aws-modules","id":31414033,"avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc","description":"Terraform module which creates VPC resources on AWS","fork":false,"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc","forks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/forks","keys_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/teams","hooks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/hooks","issue_events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/events","assignees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/tags","blobs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/languages","stargazers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/stargazers","contributors_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/contributors","subscribers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/subscribers","subscription_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/subscription","commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/merges","archive_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/downloads","issues_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/labels{/name}","releases_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/deployments","created_at":"2017-08-28T16:00:21Z","updated_at":"2017-10-22T15:56:08Z","pushed_at":"2017-10-24T07:53:50Z","git_url":"git://github.com/terraform-aws-modules/terraform-aws-vpc.git","ssh_url":"git@github.com:terraform-aws-modules/terraform-aws-vpc.git","clone_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc.git","svn_url":"https://github.com/terraform-aws-modules/terraform-aws-vpc","homepage":"https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws","size":14,"stargazers_count":28,"watchers_count":28,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":24,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/13"},"issue":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/13"},"comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-vpc/statuses/e4fad19e8472630575f4fb536f7fce0b801f2bcd"}},"author_association":"NONE"}}
{"actor":{"display_login":"antonbabenko"}}