{"action":"created","issue":{"url":"https://api.github.com/repos/docker/cli/issues/730","repository_url":"https://api.github.com/repos/docker/cli","labels_url":"https://api.github.com/repos/docker/cli/issues/730/labels{/name}","comments_url":"https://api.github.com/repos/docker/cli/issues/730/comments","events_url":"https://api.github.com/repos/docker/cli/issues/730/events","html_url":"https://github.com/docker/cli/pull/730","id":279259970,"number":730,"title":"Fixing zsh column finding in nodes and stacks.","user":{"login":"BretFisher","id":792287,"avatar_url":"https://avatars0.githubusercontent.com/u/792287?v=4","gravatar_id":"","url":"https://api.github.com/users/BretFisher","html_url":"https://github.com/BretFisher","followers_url":"https://api.github.com/users/BretFisher/followers","following_url":"https://api.github.com/users/BretFisher/following{/other_user}","gists_url":"https://api.github.com/users/BretFisher/gists{/gist_id}","starred_url":"https://api.github.com/users/BretFisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BretFisher/subscriptions","organizations_url":"https://api.github.com/users/BretFisher/orgs","repos_url":"https://api.github.com/users/BretFisher/repos","events_url":"https://api.github.com/users/BretFisher/events{/privacy}","received_events_url":"https://api.github.com/users/BretFisher/received_events","type":"User","site_admin":false},"labels":[{"id":585916069,"url":"https://api.github.com/repos/docker/cli/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-05T06:22:47Z","updated_at":"2017-12-05T06:25:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/730","html_url":"https://github.com/docker/cli/pull/730","diff_url":"https://github.com/docker/cli/pull/730.diff","patch_url":"https://github.com/docker/cli/pull/730.patch"},"body":"fixes #729 \r\n\r\n**- What I did**\r\nChanged Zsh completion script to find the proper column titles for `docker node` and `docker stack` commands.\r\n\r\n**Note** the Zsh selector for node names still has an issue selecting a node with an asterisk next to it (denoting the manager you're currently talking to). I wasn't savvy enough in Zsh functions nor regex to filter out the ` *` when tabbing to select node name, but I'm happy to update this PR if someone can point me to a solution.  This fix still works if you choose the ID, and it's better then before where you wouldn't get a list.\r\n\r\nThis is what that bug looks like:\r\n![screen capture on 2017-12-05 at 01-20-44](https://user-images.githubusercontent.com/792287/33592810-a4be2276-d95a-11e7-88a4-43ab1b09702a.gif)\r\n\r\n**- How I did it**\r\nEdited three lines with my bare hands :)\r\n\r\n**- How to verify it**\r\nUpdate your Zsh docker completion file with this one, run `compinit` to update completions, and type `docker node rm` and `docker stack rm` (assuming you have one of each in their lists) and hit tab. You should get back a list or an auto-filled CLI rather than error about \"empty string\"\r\n\r\n**- Description for the changelog**\r\nFixed Zsh completion for node and stack commands.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\nMy dog Leelu\r\n![leeludocker - 1](https://user-images.githubusercontent.com/792287/33592505-597a6ae6-d959-11e7-9c7e-3d6dc0d6da00.jpg)\r\n\r\n\r\n\r\nSigned-off-by: Bret Fisher <bret@bretfisher.com>"},"comment":{"url":"https://api.github.com/repos/docker/cli/issues/comments/349208417","html_url":"https://github.com/docker/cli/pull/730#issuecomment-349208417","issue_url":"https://api.github.com/repos/docker/cli/issues/730","id":349208417,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-12-05T06:25:59Z","updated_at":"2017-12-05T06:25:59Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/docker/cli/pull/730?src=pr&el=h1) Report\n> Merging [#730](https://codecov.io/gh/docker/cli/pull/730?src=pr&el=desc) into [master](https://codecov.io/gh/docker/cli/commit/83cdc0f1bddfa90cccc4253b8f85100a1a10704c?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n\n\n```diff\n@@           Coverage Diff           @@\n##           master     #730   +/-   ##\n=======================================\n  Coverage   53.52%   53.52%           \n=======================================\n  Files         218      218           \n  Lines       14565    14565           \n=======================================\n  Hits         7796     7796           \n  Misses       6288     6288           \n  Partials      481      481\n```\n\n"}}
{"actor":{"display_login":"codecov-io"}}