{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/150379470","pull_request_review_id":75927491,"id":150379470,"diff_hunk":"@@ -10535,6 +10535,8 @@ public final Subscription subscribe(Subscriber<? super T> subscriber) {\n     /**\n      * Returns an Observable that emits those items emitted by source Observable before a specified time runs\n      * out.\n+     * If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler},","path":"src/main/java/rx/Observable.java","position":4,"original_position":4,"commit_id":"281d411ff0de2234e2ae86f0b75cf755b4ea190b","original_commit_id":"281d411ff0de2234e2ae86f0b75cf755b4ea190b","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"A `<p>` would cleanly separate the first sentence and the rest of the Javadoc. Also the wording could use some refinement:\r\n\r\n```\r\n<p>\r\nIf time runs out before the {@code Observable} completes normally, the {@code onComplete} \r\nevent will be signaled on the default {@code computation} {@link Scheduler}.\r\n```","created_at":"2017-11-11T09:07:04Z","updated_at":"2017-11-11T09:07:54Z","html_url":"https://github.com/ReactiveX/RxJava/pull/5719#discussion_r150379470","pull_request_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/150379470"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/5719#discussion_r150379470"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719","id":152042579,"html_url":"https://github.com/ReactiveX/RxJava/pull/5719","diff_url":"https://github.com/ReactiveX/RxJava/pull/5719.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/5719.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/5719","number":5719,"state":"open","locked":false,"title":"Add a sentence to documentation of take() operator","user":{"login":"sadegh","id":657684,"avatar_url":"https://avatars1.githubusercontent.com/u/657684?v=4","gravatar_id":"","url":"https://api.github.com/users/sadegh","html_url":"https://github.com/sadegh","followers_url":"https://api.github.com/users/sadegh/followers","following_url":"https://api.github.com/users/sadegh/following{/other_user}","gists_url":"https://api.github.com/users/sadegh/gists{/gist_id}","starred_url":"https://api.github.com/users/sadegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadegh/subscriptions","organizations_url":"https://api.github.com/users/sadegh/orgs","repos_url":"https://api.github.com/users/sadegh/repos","events_url":"https://api.github.com/users/sadegh/events{/privacy}","received_events_url":"https://api.github.com/users/sadegh/received_events","type":"User","site_admin":false},"body":"#5716 ","created_at":"2017-11-11T05:11:34Z","updated_at":"2017-11-11T09:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b07d1007a94ee3adade06004a928aca3e5a1723","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/5719/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/281d411ff0de2234e2ae86f0b75cf755b4ea190b","head":{"label":"sadegh:sk/doc_for_take_op_1.x","ref":"sk/doc_for_take_op_1.x","sha":"281d411ff0de2234e2ae86f0b75cf755b4ea190b","user":{"login":"sadegh","id":657684,"avatar_url":"https://avatars1.githubusercontent.com/u/657684?v=4","gravatar_id":"","url":"https://api.github.com/users/sadegh","html_url":"https://github.com/sadegh","followers_url":"https://api.github.com/users/sadegh/followers","following_url":"https://api.github.com/users/sadegh/following{/other_user}","gists_url":"https://api.github.com/users/sadegh/gists{/gist_id}","starred_url":"https://api.github.com/users/sadegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadegh/subscriptions","organizations_url":"https://api.github.com/users/sadegh/orgs","repos_url":"https://api.github.com/users/sadegh/repos","events_url":"https://api.github.com/users/sadegh/events{/privacy}","received_events_url":"https://api.github.com/users/sadegh/received_events","type":"User","site_admin":false},"repo":{"id":110248991,"name":"RxJava","full_name":"sadegh/RxJava","owner":{"login":"sadegh","id":657684,"avatar_url":"https://avatars1.githubusercontent.com/u/657684?v=4","gravatar_id":"","url":"https://api.github.com/users/sadegh","html_url":"https://github.com/sadegh","followers_url":"https://api.github.com/users/sadegh/followers","following_url":"https://api.github.com/users/sadegh/following{/other_user}","gists_url":"https://api.github.com/users/sadegh/gists{/gist_id}","starred_url":"https://api.github.com/users/sadegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadegh/subscriptions","organizations_url":"https://api.github.com/users/sadegh/orgs","repos_url":"https://api.github.com/users/sadegh/repos","events_url":"https://api.github.com/users/sadegh/events{/privacy}","received_events_url":"https://api.github.com/users/sadegh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sadegh/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/sadegh/RxJava","forks_url":"https://api.github.com/repos/sadegh/RxJava/forks","keys_url":"https://api.github.com/repos/sadegh/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sadegh/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sadegh/RxJava/teams","hooks_url":"https://api.github.com/repos/sadegh/RxJava/hooks","issue_events_url":"https://api.github.com/repos/sadegh/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/sadegh/RxJava/events","assignees_url":"https://api.github.com/repos/sadegh/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/sadegh/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/sadegh/RxJava/tags","blobs_url":"https://api.github.com/repos/sadegh/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sadegh/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sadegh/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/sadegh/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sadegh/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/sadegh/RxJava/languages","stargazers_url":"https://api.github.com/repos/sadegh/RxJava/stargazers","contributors_url":"https://api.github.com/repos/sadegh/RxJava/contributors","subscribers_url":"https://api.github.com/repos/sadegh/RxJava/subscribers","subscription_url":"https://api.github.com/repos/sadegh/RxJava/subscription","commits_url":"https://api.github.com/repos/sadegh/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/sadegh/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/sadegh/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/sadegh/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/sadegh/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/sadegh/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sadegh/RxJava/merges","archive_url":"https://api.github.com/repos/sadegh/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sadegh/RxJava/downloads","issues_url":"https://api.github.com/repos/sadegh/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/sadegh/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/sadegh/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/sadegh/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sadegh/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/sadegh/RxJava/releases{/id}","deployments_url":"https://api.github.com/repos/sadegh/RxJava/deployments","created_at":"2017-11-10T13:18:47Z","updated_at":"2017-11-10T13:18:59Z","pushed_at":"2017-11-11T05:09:50Z","git_url":"git://github.com/sadegh/RxJava.git","ssh_url":"git@github.com:sadegh/RxJava.git","clone_url":"https://github.com/sadegh/RxJava.git","svn_url":"https://github.com/sadegh/RxJava","homepage":"","size":45292,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.x"}},"base":{"label":"ReactiveX:1.x","ref":"1.x","sha":"5b2394c9ee91f298661fff5e043744c84b425808","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"ReactiveX/RxJava","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJava","forks_url":"https://api.github.com/repos/ReactiveX/RxJava/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJava/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJava/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJava/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJava/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJava/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJava/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJava/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJava/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJava/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJava/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJava/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJava/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/RxJava/deployments","created_at":"2013-01-08T20:11:48Z","updated_at":"2017-11-11T08:25:21Z","pushed_at":"2017-11-11T05:11:35Z","git_url":"git://github.com/ReactiveX/RxJava.git","ssh_url":"git@github.com:ReactiveX/RxJava.git","clone_url":"https://github.com/ReactiveX/RxJava.git","svn_url":"https://github.com/ReactiveX/RxJava","homepage":"","size":45326,"stargazers_count":28593,"watchers_count":28593,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5034,"mirror_url":null,"archived":false,"open_issues_count":37,"forks":5034,"open_issues":37,"watchers":28593,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/5719"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/5719"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/5719/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/5719/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJava/statuses/281d411ff0de2234e2ae86f0b75cf755b4ea190b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akarnokd"}}