{"action":"created","comment":{"url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/comments/121623160","pull_request_review_id":43655401,"id":121623160,"diff_hunk":"@@ -0,0 +1,207 @@\n+within AixLib.ThermalZones.ReducedOrder.Windows;\n+model Window \"Calculation of solar energy transmitted through windows\"\n+  parameter Modelica.SIunits.Angle lat \"Latitude\";\n+  parameter Integer n(min = 1) \"Number of windows\"\n+    annotation(dialog(group=\"window\"));\n+  parameter Modelica.SIunits.CoefficientOfHeatTransfer UWin\n+    \"Thermal transmission coefficient of whole window\"\n+    annotation(dialog(group=\"window\"));\n+   parameter Modelica.SIunits.TransmissionCoefficient g[n]\n+    \"Total energy transmittance of windows\"\n+    annotation(Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.TransmissionCoefficient g_TotDir[n]\n+    \"Total energy transmittance of windows with closed sunscreen for direct\n+     radiation\"\n+    annotation(Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.TransmissionCoefficient g_TotDif[n]\n+    \"Total energy transmittance of windows with closed sunscreen for diffuse\n+     radiation\"\n+    annotation(Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.TransmissionCoefficient tau_vis[n]\n+    \"Degree of light transmission for direct irradiation\"\n+    annotation (Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.TransmissionCoefficient tau_visTotDir[n]\n+    \"Degree of light transmission for direct irradiation, with sunscreen\"\n+    annotation (Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.TransmissionCoefficient tau_visTotDif[n]\n+    \"Degree of light transmission for diffuse irradiation, with sunscreen\"\n+    annotation (Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.RadiantEnergyFluenceRate lim\n+    \"Limit for the sunscreen to become active\"\n+    annotation(dialog(group=\"sunscreen\"));\n+  parameter Modelica.SIunits.Angle xi(displayUnit=\"degree\")= 0\n+    \"Elevation angle\";\n+  parameter Modelica.SIunits.Angle til[n](displayUnit=\"deg\")\n+    \"Surface tilt. til=90 degree for walls; til=0 for ceilings; til=180 for\n+    roof\"\n+    annotation (Dialog(group=\"window\"));\n+  parameter Modelica.SIunits.Angle azi[n] \"Surface azimuth\"\n+    annotation (Dialog(group=\"window\"));\n+  extends Modelica.Blocks.Icons.Block;\n+  Modelica.Blocks.Interfaces.RealOutput HVis[n](\n+    final quantity=\"RadiantEnergyFluenceRate\",\n+    final unit=\"W/m2\") \"Solar energy entering the room in the visible area\"\n+    annotation (Placement(transformation(extent={{100,30},{120,50}}),\n+        iconTransformation(extent={{100,30},{120,50}})));\n+\n+  Modelica.Blocks.Interfaces.RealOutput HWin[n](\n+    final quantity=\"RadiantEnergyFluenceRate\",\n+    final unit=\"W/m2\")\n+    \"Solar radiation transmitted through aggregated window\"\n+    annotation (Placement(transformation(extent={{100,-50},{120,-30}}),\n+        iconTransformation(extent={{100,-50},{120,-30}})));\n+\n+  AixLib.ThermalZones.ReducedOrder.Windows.BaseClasses.Window window(\n+    final n=n,\n+    final UWin=UWin,\n+    final g=g,\n+    final g_TotDir=g_TotDir,\n+    final g_TotDif=g_TotDif,\n+    final tau_vis=tau_vis,\n+    final tau_visTotDir=tau_visTotDir,\n+    final tau_visTotDif=tau_visTotDif,\n+    final lim=lim,\n+    final til=til) annotation (\n+    Placement(transformation(extent={{20,-32},{86,30}})));","path":"AixLib/ThermalZones/ReducedOrder/Windows/Window.mo","position":65,"original_position":65,"commit_id":"7af06bb12ebc8c2cac19d4486eb6ff17a05a28d4","original_commit_id":"7af06bb12ebc8c2cac19d4486eb6ff17a05a28d4","user":{"login":"mlauster","id":6892690,"avatar_url":"https://avatars3.githubusercontent.com/u/6892690?v=3","gravatar_id":"","url":"https://api.github.com/users/mlauster","html_url":"https://github.com/mlauster","followers_url":"https://api.github.com/users/mlauster/followers","following_url":"https://api.github.com/users/mlauster/following{/other_user}","gists_url":"https://api.github.com/users/mlauster/gists{/gist_id}","starred_url":"https://api.github.com/users/mlauster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlauster/subscriptions","organizations_url":"https://api.github.com/users/mlauster/orgs","repos_url":"https://api.github.com/users/mlauster/repos","events_url":"https://api.github.com/users/mlauster/events{/privacy}","received_events_url":"https://api.github.com/users/mlauster/received_events","type":"User","site_admin":false},"body":"Comment missing","created_at":"2017-06-13T09:10:10Z","updated_at":"2017-06-13T09:11:42Z","html_url":"https://github.com/RWTH-EBC/AixLib/pull/405#discussion_r121623160","pull_request_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405","_links":{"self":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/comments/121623160"},"html":{"href":"https://github.com/RWTH-EBC/AixLib/pull/405#discussion_r121623160"},"pull_request":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405"}}},"pull_request":{"url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405","id":123071887,"html_url":"https://github.com/RWTH-EBC/AixLib/pull/405","diff_url":"https://github.com/RWTH-EBC/AixLib/pull/405.diff","patch_url":"https://github.com/RWTH-EBC/AixLib/pull/405.patch","issue_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/405","number":405,"state":"open","locked":false,"title":"Issue397 window models 1","user":{"login":"mla-srs","id":18395625,"avatar_url":"https://avatars0.githubusercontent.com/u/18395625?v=3","gravatar_id":"","url":"https://api.github.com/users/mla-srs","html_url":"https://github.com/mla-srs","followers_url":"https://api.github.com/users/mla-srs/followers","following_url":"https://api.github.com/users/mla-srs/following{/other_user}","gists_url":"https://api.github.com/users/mla-srs/gists{/gist_id}","starred_url":"https://api.github.com/users/mla-srs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mla-srs/subscriptions","organizations_url":"https://api.github.com/users/mla-srs/orgs","repos_url":"https://api.github.com/users/mla-srs/repos","events_url":"https://api.github.com/users/mla-srs/events{/privacy}","received_events_url":"https://api.github.com/users/mla-srs/received_events","type":"User","site_admin":false},"body":"Integrated the window models based on VDI 6007 into the AixLib. Due to git problems opened this new PR with the new Branch issue397_windowModels_1\r\n","created_at":"2017-05-30T15:01:36Z","updated_at":"2017-06-13T09:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b0b8154867d4b749c8cdb16b670ff5d9623ef6c","assignee":{"login":"mla-srs","id":18395625,"avatar_url":"https://avatars0.githubusercontent.com/u/18395625?v=3","gravatar_id":"","url":"https://api.github.com/users/mla-srs","html_url":"https://github.com/mla-srs","followers_url":"https://api.github.com/users/mla-srs/followers","following_url":"https://api.github.com/users/mla-srs/following{/other_user}","gists_url":"https://api.github.com/users/mla-srs/gists{/gist_id}","starred_url":"https://api.github.com/users/mla-srs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mla-srs/subscriptions","organizations_url":"https://api.github.com/users/mla-srs/orgs","repos_url":"https://api.github.com/users/mla-srs/repos","events_url":"https://api.github.com/users/mla-srs/events{/privacy}","received_events_url":"https://api.github.com/users/mla-srs/received_events","type":"User","site_admin":false},"assignees":[{"login":"mla-srs","id":18395625,"avatar_url":"https://avatars0.githubusercontent.com/u/18395625?v=3","gravatar_id":"","url":"https://api.github.com/users/mla-srs","html_url":"https://github.com/mla-srs","followers_url":"https://api.github.com/users/mla-srs/followers","following_url":"https://api.github.com/users/mla-srs/following{/other_user}","gists_url":"https://api.github.com/users/mla-srs/gists{/gist_id}","starred_url":"https://api.github.com/users/mla-srs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mla-srs/subscriptions","organizations_url":"https://api.github.com/users/mla-srs/orgs","repos_url":"https://api.github.com/users/mla-srs/repos","events_url":"https://api.github.com/users/mla-srs/events{/privacy}","received_events_url":"https://api.github.com/users/mla-srs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405/commits","review_comments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405/comments","review_comment_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/405/comments","statuses_url":"https://api.github.com/repos/RWTH-EBC/AixLib/statuses/7af06bb12ebc8c2cac19d4486eb6ff17a05a28d4","head":{"label":"RWTH-EBC:issue397_windowModels_1","ref":"issue397_windowModels_1","sha":"7af06bb12ebc8c2cac19d4486eb6ff17a05a28d4","user":{"login":"RWTH-EBC","id":8121773,"avatar_url":"https://avatars1.githubusercontent.com/u/8121773?v=3","gravatar_id":"","url":"https://api.github.com/users/RWTH-EBC","html_url":"https://github.com/RWTH-EBC","followers_url":"https://api.github.com/users/RWTH-EBC/followers","following_url":"https://api.github.com/users/RWTH-EBC/following{/other_user}","gists_url":"https://api.github.com/users/RWTH-EBC/gists{/gist_id}","starred_url":"https://api.github.com/users/RWTH-EBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWTH-EBC/subscriptions","organizations_url":"https://api.github.com/users/RWTH-EBC/orgs","repos_url":"https://api.github.com/users/RWTH-EBC/repos","events_url":"https://api.github.com/users/RWTH-EBC/events{/privacy}","received_events_url":"https://api.github.com/users/RWTH-EBC/received_events","type":"Organization","site_admin":false},"repo":{"id":21685541,"name":"AixLib","full_name":"RWTH-EBC/AixLib","owner":{"login":"RWTH-EBC","id":8121773,"avatar_url":"https://avatars1.githubusercontent.com/u/8121773?v=3","gravatar_id":"","url":"https://api.github.com/users/RWTH-EBC","html_url":"https://github.com/RWTH-EBC","followers_url":"https://api.github.com/users/RWTH-EBC/followers","following_url":"https://api.github.com/users/RWTH-EBC/following{/other_user}","gists_url":"https://api.github.com/users/RWTH-EBC/gists{/gist_id}","starred_url":"https://api.github.com/users/RWTH-EBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWTH-EBC/subscriptions","organizations_url":"https://api.github.com/users/RWTH-EBC/orgs","repos_url":"https://api.github.com/users/RWTH-EBC/repos","events_url":"https://api.github.com/users/RWTH-EBC/events{/privacy}","received_events_url":"https://api.github.com/users/RWTH-EBC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RWTH-EBC/AixLib","description":"A Modelica model library for building performance simulations","fork":false,"url":"https://api.github.com/repos/RWTH-EBC/AixLib","forks_url":"https://api.github.com/repos/RWTH-EBC/AixLib/forks","keys_url":"https://api.github.com/repos/RWTH-EBC/AixLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RWTH-EBC/AixLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RWTH-EBC/AixLib/teams","hooks_url":"https://api.github.com/repos/RWTH-EBC/AixLib/hooks","issue_events_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/events{/number}","events_url":"https://api.github.com/repos/RWTH-EBC/AixLib/events","assignees_url":"https://api.github.com/repos/RWTH-EBC/AixLib/assignees{/user}","branches_url":"https://api.github.com/repos/RWTH-EBC/AixLib/branches{/branch}","tags_url":"https://api.github.com/repos/RWTH-EBC/AixLib/tags","blobs_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RWTH-EBC/AixLib/statuses/{sha}","languages_url":"https://api.github.com/repos/RWTH-EBC/AixLib/languages","stargazers_url":"https://api.github.com/repos/RWTH-EBC/AixLib/stargazers","contributors_url":"https://api.github.com/repos/RWTH-EBC/AixLib/contributors","subscribers_url":"https://api.github.com/repos/RWTH-EBC/AixLib/subscribers","subscription_url":"https://api.github.com/repos/RWTH-EBC/AixLib/subscription","commits_url":"https://api.github.com/repos/RWTH-EBC/AixLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/RWTH-EBC/AixLib/contents/{+path}","compare_url":"https://api.github.com/repos/RWTH-EBC/AixLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RWTH-EBC/AixLib/merges","archive_url":"https://api.github.com/repos/RWTH-EBC/AixLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RWTH-EBC/AixLib/downloads","issues_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues{/number}","pulls_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls{/number}","milestones_url":"https://api.github.com/repos/RWTH-EBC/AixLib/milestones{/number}","notifications_url":"https://api.github.com/repos/RWTH-EBC/AixLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RWTH-EBC/AixLib/labels{/name}","releases_url":"https://api.github.com/repos/RWTH-EBC/AixLib/releases{/id}","deployments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/deployments","created_at":"2014-07-10T08:04:06Z","updated_at":"2017-05-13T17:45:25Z","pushed_at":"2017-06-12T14:04:49Z","git_url":"git://github.com/RWTH-EBC/AixLib.git","ssh_url":"git@github.com:RWTH-EBC/AixLib.git","clone_url":"https://github.com/RWTH-EBC/AixLib.git","svn_url":"https://github.com/RWTH-EBC/AixLib","homepage":null,"size":89608,"stargazers_count":32,"watchers_count":32,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":51,"forks":24,"open_issues":51,"watchers":32,"default_branch":"master"}},"base":{"label":"RWTH-EBC:development","ref":"development","sha":"f89dccd11b4de0e271dac938b44192115351ea3b","user":{"login":"RWTH-EBC","id":8121773,"avatar_url":"https://avatars1.githubusercontent.com/u/8121773?v=3","gravatar_id":"","url":"https://api.github.com/users/RWTH-EBC","html_url":"https://github.com/RWTH-EBC","followers_url":"https://api.github.com/users/RWTH-EBC/followers","following_url":"https://api.github.com/users/RWTH-EBC/following{/other_user}","gists_url":"https://api.github.com/users/RWTH-EBC/gists{/gist_id}","starred_url":"https://api.github.com/users/RWTH-EBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWTH-EBC/subscriptions","organizations_url":"https://api.github.com/users/RWTH-EBC/orgs","repos_url":"https://api.github.com/users/RWTH-EBC/repos","events_url":"https://api.github.com/users/RWTH-EBC/events{/privacy}","received_events_url":"https://api.github.com/users/RWTH-EBC/received_events","type":"Organization","site_admin":false},"repo":{"id":21685541,"name":"AixLib","full_name":"RWTH-EBC/AixLib","owner":{"login":"RWTH-EBC","id":8121773,"avatar_url":"https://avatars1.githubusercontent.com/u/8121773?v=3","gravatar_id":"","url":"https://api.github.com/users/RWTH-EBC","html_url":"https://github.com/RWTH-EBC","followers_url":"https://api.github.com/users/RWTH-EBC/followers","following_url":"https://api.github.com/users/RWTH-EBC/following{/other_user}","gists_url":"https://api.github.com/users/RWTH-EBC/gists{/gist_id}","starred_url":"https://api.github.com/users/RWTH-EBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWTH-EBC/subscriptions","organizations_url":"https://api.github.com/users/RWTH-EBC/orgs","repos_url":"https://api.github.com/users/RWTH-EBC/repos","events_url":"https://api.github.com/users/RWTH-EBC/events{/privacy}","received_events_url":"https://api.github.com/users/RWTH-EBC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RWTH-EBC/AixLib","description":"A Modelica model library for building performance simulations","fork":false,"url":"https://api.github.com/repos/RWTH-EBC/AixLib","forks_url":"https://api.github.com/repos/RWTH-EBC/AixLib/forks","keys_url":"https://api.github.com/repos/RWTH-EBC/AixLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RWTH-EBC/AixLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RWTH-EBC/AixLib/teams","hooks_url":"https://api.github.com/repos/RWTH-EBC/AixLib/hooks","issue_events_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/events{/number}","events_url":"https://api.github.com/repos/RWTH-EBC/AixLib/events","assignees_url":"https://api.github.com/repos/RWTH-EBC/AixLib/assignees{/user}","branches_url":"https://api.github.com/repos/RWTH-EBC/AixLib/branches{/branch}","tags_url":"https://api.github.com/repos/RWTH-EBC/AixLib/tags","blobs_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RWTH-EBC/AixLib/statuses/{sha}","languages_url":"https://api.github.com/repos/RWTH-EBC/AixLib/languages","stargazers_url":"https://api.github.com/repos/RWTH-EBC/AixLib/stargazers","contributors_url":"https://api.github.com/repos/RWTH-EBC/AixLib/contributors","subscribers_url":"https://api.github.com/repos/RWTH-EBC/AixLib/subscribers","subscription_url":"https://api.github.com/repos/RWTH-EBC/AixLib/subscription","commits_url":"https://api.github.com/repos/RWTH-EBC/AixLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/RWTH-EBC/AixLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/RWTH-EBC/AixLib/contents/{+path}","compare_url":"https://api.github.com/repos/RWTH-EBC/AixLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RWTH-EBC/AixLib/merges","archive_url":"https://api.github.com/repos/RWTH-EBC/AixLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RWTH-EBC/AixLib/downloads","issues_url":"https://api.github.com/repos/RWTH-EBC/AixLib/issues{/number}","pulls_url":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls{/number}","milestones_url":"https://api.github.com/repos/RWTH-EBC/AixLib/milestones{/number}","notifications_url":"https://api.github.com/repos/RWTH-EBC/AixLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RWTH-EBC/AixLib/labels{/name}","releases_url":"https://api.github.com/repos/RWTH-EBC/AixLib/releases{/id}","deployments_url":"https://api.github.com/repos/RWTH-EBC/AixLib/deployments","created_at":"2014-07-10T08:04:06Z","updated_at":"2017-05-13T17:45:25Z","pushed_at":"2017-06-12T14:04:49Z","git_url":"git://github.com/RWTH-EBC/AixLib.git","ssh_url":"git@github.com:RWTH-EBC/AixLib.git","clone_url":"https://github.com/RWTH-EBC/AixLib.git","svn_url":"https://github.com/RWTH-EBC/AixLib","homepage":null,"size":89608,"stargazers_count":32,"watchers_count":32,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":51,"forks":24,"open_issues":51,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405"},"html":{"href":"https://github.com/RWTH-EBC/AixLib/pull/405"},"issue":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/405"},"comments":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/RWTH-EBC/AixLib/statuses/7af06bb12ebc8c2cac19d4486eb6ff17a05a28d4"}}}}
{"actor":{"display_login":"mlauster"}}