{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/147545169","pull_request_review_id":72662279,"id":147545169,"diff_hunk":"@@ -72,21 +72,19 @@ def check_common(self, name_cube, grib_cube):\n     def test_name2_field(self):\n         filepath = tests.get_data_path(('NAME', 'NAMEII_field.txt'))\n         name_cubes = iris.load(filepath)\n-        # Check gribapi version, because we currently have a known load/save\n-        # problem with gribapi 1v14 (at least).\n-        gribapi_ver = gribapi.grib_get_api_version()\n-        gribapi_fully_supported_version = \\\n-            (StrictVersion(gribapi.grib_get_api_version()) <\n-             StrictVersion('1.13'))\n+\n+        # There is a known load/save problem with numerous\n+        # gribapi/eccodes versions and\n+        # zero only data, where min == max.\n+        # This may be a problem with data scaling.\n         for i, name_cube in enumerate(name_cubes):\n-            if not gribapi_fully_supported_version:\n-                data = name_cube.data\n-                if np.min(data) == np.max(data):\n-                    msg = ('NAMEII cube #{}, \"{}\" has empty data : '\n-                           'SKIPPING test for this cube, as save/load will '\n-                           'not currently work with gribabi > 1v12.')\n-                    warnings.warn(msg.format(i, name_cube.name()))\n-                    continue\n+            data = name_cube.data\n+            if np.min(data) == np.max(data):\n+                msg = ('NAMEII cube #{}, \"{}\" has empty data : '\n+                       'SKIPPING test for this cube, as save/load will '\n+                       'not currently work.')\n+                warnings.warn(msg.format(i, name_cube.name()))\n+                continue","path":"lib/iris/tests/integration/format_interop/test_name_grib.py","position":30,"original_position":30,"commit_id":"56f1849d3a85d981b0d4b23fe481fea0cbc0a5c4","original_commit_id":"56f1849d3a85d981b0d4b23fe481fea0cbc0a5c4","user":{"login":"pelson","id":810663,"avatar_url":"https://avatars3.githubusercontent.com/u/810663?v=4","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"body":"(I know it 's not your change but... ) We have more sophisticated means for skipping tests...","created_at":"2017-10-28T04:27:51Z","updated_at":"2017-10-28T04:29:51Z","html_url":"https://github.com/SciTools/iris/pull/2887#discussion_r147545169","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/2887","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/147545169"},"html":{"href":"https://github.com/SciTools/iris/pull/2887#discussion_r147545169"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2887"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/2887","id":149256038,"html_url":"https://github.com/SciTools/iris/pull/2887","diff_url":"https://github.com/SciTools/iris/pull/2887.diff","patch_url":"https://github.com/SciTools/iris/pull/2887.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/2887","number":2887,"state":"open","locked":false,"title":"Get working with iris-grib-with-eccodes; Python 3 included.","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars1.githubusercontent.com/u/2089069?v=4","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"body":"This won't work until a new iris-grib>=0.12 is available on conda-forge\r\nI'm assuming that will have masked dask support AND eccodes\r\n\r\nThere are changes here specific to the eccodes transition, ported across from #2607","created_at":"2017-10-27T18:28:07Z","updated_at":"2017-10-28T04:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3b6c738f5ee6d8b1f0ac1074c5588f815b3c244","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/2887/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/2887/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/2887/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/56f1849d3a85d981b0d4b23fe481fea0cbc0a5c4","head":{"label":"pp-mo:post_iris2_grib_fixes","ref":"post_iris2_grib_fixes","sha":"56f1849d3a85d981b0d4b23fe481fea0cbc0a5c4","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars1.githubusercontent.com/u/2089069?v=4","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"repo":{"id":5701421,"name":"iris","full_name":"pp-mo/iris","owner":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars1.githubusercontent.com/u/2089069?v=4","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pp-mo/iris","description":null,"fork":true,"url":"https://api.github.com/repos/pp-mo/iris","forks_url":"https://api.github.com/repos/pp-mo/iris/forks","keys_url":"https://api.github.com/repos/pp-mo/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pp-mo/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pp-mo/iris/teams","hooks_url":"https://api.github.com/repos/pp-mo/iris/hooks","issue_events_url":"https://api.github.com/repos/pp-mo/iris/issues/events{/number}","events_url":"https://api.github.com/repos/pp-mo/iris/events","assignees_url":"https://api.github.com/repos/pp-mo/iris/assignees{/user}","branches_url":"https://api.github.com/repos/pp-mo/iris/branches{/branch}","tags_url":"https://api.github.com/repos/pp-mo/iris/tags","blobs_url":"https://api.github.com/repos/pp-mo/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pp-mo/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pp-mo/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/pp-mo/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pp-mo/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/pp-mo/iris/languages","stargazers_url":"https://api.github.com/repos/pp-mo/iris/stargazers","contributors_url":"https://api.github.com/repos/pp-mo/iris/contributors","subscribers_url":"https://api.github.com/repos/pp-mo/iris/subscribers","subscription_url":"https://api.github.com/repos/pp-mo/iris/subscription","commits_url":"https://api.github.com/repos/pp-mo/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/pp-mo/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/pp-mo/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/pp-mo/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/pp-mo/iris/contents/{+path}","compare_url":"https://api.github.com/repos/pp-mo/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pp-mo/iris/merges","archive_url":"https://api.github.com/repos/pp-mo/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pp-mo/iris/downloads","issues_url":"https://api.github.com/repos/pp-mo/iris/issues{/number}","pulls_url":"https://api.github.com/repos/pp-mo/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/pp-mo/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/pp-mo/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pp-mo/iris/labels{/name}","releases_url":"https://api.github.com/repos/pp-mo/iris/releases{/id}","deployments_url":"https://api.github.com/repos/pp-mo/iris/deployments","created_at":"2012-09-06T11:45:58Z","updated_at":"2015-04-25T22:15:43Z","pushed_at":"2017-10-27T18:27:01Z","git_url":"git://github.com/pp-mo/iris.git","ssh_url":"git@github.com:pp-mo/iris.git","clone_url":"https://github.com/pp-mo/iris.git","svn_url":"https://github.com/pp-mo/iris","homepage":"http://scitools.github.com/iris","size":105992,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"07b627b4e5292935ef975e3a5417663bd760a65c","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2017-10-19T12:32:50Z","pushed_at":"2017-10-27T18:28:08Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":104257,"stargazers_count":184,"watchers_count":184,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":240,"forks":131,"open_issues":240,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2887"},"html":{"href":"https://github.com/SciTools/iris/pull/2887"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/2887"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/2887/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2887/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2887/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/56f1849d3a85d981b0d4b23fe481fea0cbc0a5c4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pelson"}}