{"action":"created","comment":{"url":"https://api.github.com/repos/luckyframework/web/pulls/comments/147434420","pull_request_review_id":72533359,"id":147434420,"diff_hunk":"@@ -39,4 +39,16 @@ module LuckyWeb::Page\n \n     generate_initializer\n   end\n+\n+  macro p(_arg, **args)\n+    def p(_arg, **args)","path":"src/lucky_web/page.cr","position":6,"original_position":6,"commit_id":"81b91c5c0180f338d43e9bd773b258e7e921f74a","original_commit_id":"81b91c5c0180f338d43e9bd773b258e7e921f74a","user":{"login":"5minpause","id":84148,"avatar_url":"https://avatars3.githubusercontent.com/u/84148?v=4","gravatar_id":"","url":"https://api.github.com/users/5minpause","html_url":"https://github.com/5minpause","followers_url":"https://api.github.com/users/5minpause/followers","following_url":"https://api.github.com/users/5minpause/following{/other_user}","gists_url":"https://api.github.com/users/5minpause/gists{/gist_id}","starred_url":"https://api.github.com/users/5minpause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5minpause/subscriptions","organizations_url":"https://api.github.com/users/5minpause/orgs","repos_url":"https://api.github.com/users/5minpause/repos","events_url":"https://api.github.com/users/5minpause/events{/privacy}","received_events_url":"https://api.github.com/users/5minpause/received_events","type":"User","site_admin":false},"body":"Sure!","created_at":"2017-10-27T15:00:00Z","updated_at":"2017-10-27T15:00:00Z","html_url":"https://github.com/luckyframework/web/pull/157#discussion_r147434420","pull_request_url":"https://api.github.com/repos/luckyframework/web/pulls/157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/luckyframework/web/pulls/comments/147434420"},"html":{"href":"https://github.com/luckyframework/web/pull/157#discussion_r147434420"},"pull_request":{"href":"https://api.github.com/repos/luckyframework/web/pulls/157"}},"in_reply_to_id":147433399},"pull_request":{"url":"https://api.github.com/repos/luckyframework/web/pulls/157","id":149205815,"html_url":"https://github.com/luckyframework/web/pull/157","diff_url":"https://github.com/luckyframework/web/pull/157.diff","patch_url":"https://github.com/luckyframework/web/pull/157.patch","issue_url":"https://api.github.com/repos/luckyframework/web/issues/157","number":157,"state":"open","locked":false,"title":"Show helpful error message when using `p`","user":{"login":"5minpause","id":84148,"avatar_url":"https://avatars3.githubusercontent.com/u/84148?v=4","gravatar_id":"","url":"https://api.github.com/users/5minpause","html_url":"https://github.com/5minpause","followers_url":"https://api.github.com/users/5minpause/followers","following_url":"https://api.github.com/users/5minpause/following{/other_user}","gists_url":"https://api.github.com/users/5minpause/gists{/gist_id}","starred_url":"https://api.github.com/users/5minpause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5minpause/subscriptions","organizations_url":"https://api.github.com/users/5minpause/orgs","repos_url":"https://api.github.com/users/5minpause/repos","events_url":"https://api.github.com/users/5minpause/events{/privacy}","received_events_url":"https://api.github.com/users/5minpause/received_events","type":"User","site_admin":false},"body":"There isn't a good reason to use `p` in a web page other than to debug something. So we should add a p macro to `LuckyWeb::Page` that accepts any number of arguments and let's the user know they should use para if they want a paragraph tag and pp if they want to debug. pp is better anyway because it also outputs the code that it's printing to standard out. It's super handy!\r\n\r\nFixes #143\r\n\r\n<img width=\"1274\" alt=\"screen shot 2017-10-27 at 16 33 29\" src=\"https://user-images.githubusercontent.com/84148/32109301-9c73d668-bb34-11e7-9ac6-ce69f18dc781.png\">\r\n\r\n(I used the `BasePage` to verify locally that it works, like this:\r\n```\r\n  def render\r\n    p \"test\"\r\n  end\r\n```\r\nsince I yet don't know how to build my own routes/controllers/view things. and excuse the Rails vocabular… that's what I am coming from…)","created_at":"2017-10-27T14:35:39Z","updated_at":"2017-10-27T15:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"666e7b86124bc255ffd65b48f2debf7f8b8d50b2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/luckyframework/web/pulls/157/commits","review_comments_url":"https://api.github.com/repos/luckyframework/web/pulls/157/comments","review_comment_url":"https://api.github.com/repos/luckyframework/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luckyframework/web/issues/157/comments","statuses_url":"https://api.github.com/repos/luckyframework/web/statuses/81b91c5c0180f338d43e9bd773b258e7e921f74a","head":{"label":"5minpause:add-p-error-message","ref":"add-p-error-message","sha":"81b91c5c0180f338d43e9bd773b258e7e921f74a","user":{"login":"5minpause","id":84148,"avatar_url":"https://avatars3.githubusercontent.com/u/84148?v=4","gravatar_id":"","url":"https://api.github.com/users/5minpause","html_url":"https://github.com/5minpause","followers_url":"https://api.github.com/users/5minpause/followers","following_url":"https://api.github.com/users/5minpause/following{/other_user}","gists_url":"https://api.github.com/users/5minpause/gists{/gist_id}","starred_url":"https://api.github.com/users/5minpause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5minpause/subscriptions","organizations_url":"https://api.github.com/users/5minpause/orgs","repos_url":"https://api.github.com/users/5minpause/repos","events_url":"https://api.github.com/users/5minpause/events{/privacy}","received_events_url":"https://api.github.com/users/5minpause/received_events","type":"User","site_admin":false},"repo":{"id":108544192,"name":"web","full_name":"5minpause/web","owner":{"login":"5minpause","id":84148,"avatar_url":"https://avatars3.githubusercontent.com/u/84148?v=4","gravatar_id":"","url":"https://api.github.com/users/5minpause","html_url":"https://github.com/5minpause","followers_url":"https://api.github.com/users/5minpause/followers","following_url":"https://api.github.com/users/5minpause/following{/other_user}","gists_url":"https://api.github.com/users/5minpause/gists{/gist_id}","starred_url":"https://api.github.com/users/5minpause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5minpause/subscriptions","organizations_url":"https://api.github.com/users/5minpause/orgs","repos_url":"https://api.github.com/users/5minpause/repos","events_url":"https://api.github.com/users/5minpause/events{/privacy}","received_events_url":"https://api.github.com/users/5minpause/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/5minpause/web","description":"Catch bugs early, forget about most performance issues, and spend more time on code instead of debugging and writing tests.","fork":true,"url":"https://api.github.com/repos/5minpause/web","forks_url":"https://api.github.com/repos/5minpause/web/forks","keys_url":"https://api.github.com/repos/5minpause/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/5minpause/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/5minpause/web/teams","hooks_url":"https://api.github.com/repos/5minpause/web/hooks","issue_events_url":"https://api.github.com/repos/5minpause/web/issues/events{/number}","events_url":"https://api.github.com/repos/5minpause/web/events","assignees_url":"https://api.github.com/repos/5minpause/web/assignees{/user}","branches_url":"https://api.github.com/repos/5minpause/web/branches{/branch}","tags_url":"https://api.github.com/repos/5minpause/web/tags","blobs_url":"https://api.github.com/repos/5minpause/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/5minpause/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/5minpause/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/5minpause/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/5minpause/web/statuses/{sha}","languages_url":"https://api.github.com/repos/5minpause/web/languages","stargazers_url":"https://api.github.com/repos/5minpause/web/stargazers","contributors_url":"https://api.github.com/repos/5minpause/web/contributors","subscribers_url":"https://api.github.com/repos/5minpause/web/subscribers","subscription_url":"https://api.github.com/repos/5minpause/web/subscription","commits_url":"https://api.github.com/repos/5minpause/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/5minpause/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/5minpause/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/5minpause/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/5minpause/web/contents/{+path}","compare_url":"https://api.github.com/repos/5minpause/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/5minpause/web/merges","archive_url":"https://api.github.com/repos/5minpause/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/5minpause/web/downloads","issues_url":"https://api.github.com/repos/5minpause/web/issues{/number}","pulls_url":"https://api.github.com/repos/5minpause/web/pulls{/number}","milestones_url":"https://api.github.com/repos/5minpause/web/milestones{/number}","notifications_url":"https://api.github.com/repos/5minpause/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/5minpause/web/labels{/name}","releases_url":"https://api.github.com/repos/5minpause/web/releases{/id}","deployments_url":"https://api.github.com/repos/5minpause/web/deployments","created_at":"2017-10-27T12:37:04Z","updated_at":"2017-10-27T12:37:06Z","pushed_at":"2017-10-27T14:33:09Z","git_url":"git://github.com/5minpause/web.git","ssh_url":"git@github.com:5minpause/web.git","clone_url":"https://github.com/5minpause/web.git","svn_url":"https://github.com/5minpause/web","homepage":"https://luckyframework.org","size":168,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luckyframework:master","ref":"master","sha":"745823ca4a1b257e4f660a6c52e80ebfb008cce3","user":{"login":"luckyframework","id":24882045,"avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"repo":{"id":78238350,"name":"web","full_name":"luckyframework/web","owner":{"login":"luckyframework","id":24882045,"avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luckyframework/web","description":"Catch bugs early, forget about most performance issues, and spend more time on code instead of debugging and writing tests.","fork":false,"url":"https://api.github.com/repos/luckyframework/web","forks_url":"https://api.github.com/repos/luckyframework/web/forks","keys_url":"https://api.github.com/repos/luckyframework/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckyframework/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckyframework/web/teams","hooks_url":"https://api.github.com/repos/luckyframework/web/hooks","issue_events_url":"https://api.github.com/repos/luckyframework/web/issues/events{/number}","events_url":"https://api.github.com/repos/luckyframework/web/events","assignees_url":"https://api.github.com/repos/luckyframework/web/assignees{/user}","branches_url":"https://api.github.com/repos/luckyframework/web/branches{/branch}","tags_url":"https://api.github.com/repos/luckyframework/web/tags","blobs_url":"https://api.github.com/repos/luckyframework/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckyframework/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckyframework/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckyframework/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckyframework/web/statuses/{sha}","languages_url":"https://api.github.com/repos/luckyframework/web/languages","stargazers_url":"https://api.github.com/repos/luckyframework/web/stargazers","contributors_url":"https://api.github.com/repos/luckyframework/web/contributors","subscribers_url":"https://api.github.com/repos/luckyframework/web/subscribers","subscription_url":"https://api.github.com/repos/luckyframework/web/subscription","commits_url":"https://api.github.com/repos/luckyframework/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckyframework/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckyframework/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckyframework/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckyframework/web/contents/{+path}","compare_url":"https://api.github.com/repos/luckyframework/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckyframework/web/merges","archive_url":"https://api.github.com/repos/luckyframework/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckyframework/web/downloads","issues_url":"https://api.github.com/repos/luckyframework/web/issues{/number}","pulls_url":"https://api.github.com/repos/luckyframework/web/pulls{/number}","milestones_url":"https://api.github.com/repos/luckyframework/web/milestones{/number}","notifications_url":"https://api.github.com/repos/luckyframework/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckyframework/web/labels{/name}","releases_url":"https://api.github.com/repos/luckyframework/web/releases{/id}","deployments_url":"https://api.github.com/repos/luckyframework/web/deployments","created_at":"2017-01-06T20:58:57Z","updated_at":"2017-10-27T14:54:10Z","pushed_at":"2017-10-27T14:35:40Z","git_url":"git://github.com/luckyframework/web.git","ssh_url":"git@github.com:luckyframework/web.git","clone_url":"https://github.com/luckyframework/web.git","svn_url":"https://github.com/luckyframework/web","homepage":"https://luckyframework.org","size":166,"stargazers_count":97,"watchers_count":97,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":42,"forks":4,"open_issues":42,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luckyframework/web/pulls/157"},"html":{"href":"https://github.com/luckyframework/web/pull/157"},"issue":{"href":"https://api.github.com/repos/luckyframework/web/issues/157"},"comments":{"href":"https://api.github.com/repos/luckyframework/web/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/luckyframework/web/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/luckyframework/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luckyframework/web/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/luckyframework/web/statuses/81b91c5c0180f338d43e9bd773b258e7e921f74a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"5minpause"}}