{"action":"created","comment":{"url":"https://api.github.com/repos/pulibrary/figgy/pulls/comments/142824341","pull_request_review_id":67242924,"id":142824341,"diff_hunk":"@@ -0,0 +1,21 @@\n+# frozen_string_literal: true\n+class LinkedResourceBuilder","path":"app/services/linked_resource_builder.rb","position":2,"original_position":2,"commit_id":"30e27f8fbe055093cbe54dc3dc3f050ac8e055f7","original_commit_id":"30e27f8fbe055093cbe54dc3dc3f050ac8e055f7","user":{"login":"tpendragon","id":2806645,"avatar_url":"https://avatars1.githubusercontent.com/u/2806645?v=4","gravatar_id":"","url":"https://api.github.com/users/tpendragon","html_url":"https://github.com/tpendragon","followers_url":"https://api.github.com/users/tpendragon/followers","following_url":"https://api.github.com/users/tpendragon/following{/other_user}","gists_url":"https://api.github.com/users/tpendragon/gists{/gist_id}","starred_url":"https://api.github.com/users/tpendragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpendragon/subscriptions","organizations_url":"https://api.github.com/users/tpendragon/orgs","repos_url":"https://api.github.com/users/tpendragon/repos","events_url":"https://api.github.com/users/tpendragon/events{/privacy}","received_events_url":"https://api.github.com/users/tpendragon/received_events","type":"User","site_admin":false},"body":"What's the purpose of this abstraction? Wouldn't it be less code to just `LinkedResourceFactory.new(resource: resource).to_json, rather than `LinkedResourceBuilder.new(resource: resource).build`?","created_at":"2017-10-05T00:14:04Z","updated_at":"2017-10-05T00:15:00Z","html_url":"https://github.com/pulibrary/figgy/pull/310#discussion_r142824341","pull_request_url":"https://api.github.com/repos/pulibrary/figgy/pulls/310","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/comments/142824341"},"html":{"href":"https://github.com/pulibrary/figgy/pull/310#discussion_r142824341"},"pull_request":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/pulibrary/figgy/pulls/310","id":144234097,"html_url":"https://github.com/pulibrary/figgy/pull/310","diff_url":"https://github.com/pulibrary/figgy/pull/310.diff","patch_url":"https://github.com/pulibrary/figgy/pull/310.patch","issue_url":"https://api.github.com/repos/pulibrary/figgy/issues/310","number":310,"state":"open","locked":false,"title":"Vocab URI's for EphemeraFolders","user":{"login":"jrgriffiniii","id":1443986,"avatar_url":"https://avatars0.githubusercontent.com/u/1443986?v=4","gravatar_id":"","url":"https://api.github.com/users/jrgriffiniii","html_url":"https://github.com/jrgriffiniii","followers_url":"https://api.github.com/users/jrgriffiniii/followers","following_url":"https://api.github.com/users/jrgriffiniii/following{/other_user}","gists_url":"https://api.github.com/users/jrgriffiniii/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgriffiniii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgriffiniii/subscriptions","organizations_url":"https://api.github.com/users/jrgriffiniii/orgs","repos_url":"https://api.github.com/users/jrgriffiniii/repos","events_url":"https://api.github.com/users/jrgriffiniii/events{/privacy}","received_events_url":"https://api.github.com/users/jrgriffiniii/received_events","type":"User","site_admin":false},"body":"Resolves #243, #257, and #226 ","created_at":"2017-10-02T17:04:50Z","updated_at":"2017-10-05T00:15:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"434e532ea9349ffa081bdde89c83c08bbba3588f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulibrary/figgy/pulls/310/commits","review_comments_url":"https://api.github.com/repos/pulibrary/figgy/pulls/310/comments","review_comment_url":"https://api.github.com/repos/pulibrary/figgy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulibrary/figgy/issues/310/comments","statuses_url":"https://api.github.com/repos/pulibrary/figgy/statuses/30e27f8fbe055093cbe54dc3dc3f050ac8e055f7","head":{"label":"pulibrary:issues-243-ephemera-folders-vocab-uris","ref":"issues-243-ephemera-folders-vocab-uris","sha":"30e27f8fbe055093cbe54dc3dc3f050ac8e055f7","user":{"login":"pulibrary","id":1827800,"avatar_url":"https://avatars3.githubusercontent.com/u/1827800?v=4","gravatar_id":"","url":"https://api.github.com/users/pulibrary","html_url":"https://github.com/pulibrary","followers_url":"https://api.github.com/users/pulibrary/followers","following_url":"https://api.github.com/users/pulibrary/following{/other_user}","gists_url":"https://api.github.com/users/pulibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/pulibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulibrary/subscriptions","organizations_url":"https://api.github.com/users/pulibrary/orgs","repos_url":"https://api.github.com/users/pulibrary/repos","events_url":"https://api.github.com/users/pulibrary/events{/privacy}","received_events_url":"https://api.github.com/users/pulibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":98223070,"name":"figgy","full_name":"pulibrary/figgy","owner":{"login":"pulibrary","id":1827800,"avatar_url":"https://avatars3.githubusercontent.com/u/1827800?v=4","gravatar_id":"","url":"https://api.github.com/users/pulibrary","html_url":"https://github.com/pulibrary","followers_url":"https://api.github.com/users/pulibrary/followers","following_url":"https://api.github.com/users/pulibrary/following{/other_user}","gists_url":"https://api.github.com/users/pulibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/pulibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulibrary/subscriptions","organizations_url":"https://api.github.com/users/pulibrary/orgs","repos_url":"https://api.github.com/users/pulibrary/repos","events_url":"https://api.github.com/users/pulibrary/events{/privacy}","received_events_url":"https://api.github.com/users/pulibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulibrary/figgy","description":"Valkyrie-based digital repository backend.","fork":false,"url":"https://api.github.com/repos/pulibrary/figgy","forks_url":"https://api.github.com/repos/pulibrary/figgy/forks","keys_url":"https://api.github.com/repos/pulibrary/figgy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulibrary/figgy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulibrary/figgy/teams","hooks_url":"https://api.github.com/repos/pulibrary/figgy/hooks","issue_events_url":"https://api.github.com/repos/pulibrary/figgy/issues/events{/number}","events_url":"https://api.github.com/repos/pulibrary/figgy/events","assignees_url":"https://api.github.com/repos/pulibrary/figgy/assignees{/user}","branches_url":"https://api.github.com/repos/pulibrary/figgy/branches{/branch}","tags_url":"https://api.github.com/repos/pulibrary/figgy/tags","blobs_url":"https://api.github.com/repos/pulibrary/figgy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulibrary/figgy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulibrary/figgy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulibrary/figgy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulibrary/figgy/statuses/{sha}","languages_url":"https://api.github.com/repos/pulibrary/figgy/languages","stargazers_url":"https://api.github.com/repos/pulibrary/figgy/stargazers","contributors_url":"https://api.github.com/repos/pulibrary/figgy/contributors","subscribers_url":"https://api.github.com/repos/pulibrary/figgy/subscribers","subscription_url":"https://api.github.com/repos/pulibrary/figgy/subscription","commits_url":"https://api.github.com/repos/pulibrary/figgy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulibrary/figgy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulibrary/figgy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulibrary/figgy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulibrary/figgy/contents/{+path}","compare_url":"https://api.github.com/repos/pulibrary/figgy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulibrary/figgy/merges","archive_url":"https://api.github.com/repos/pulibrary/figgy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulibrary/figgy/downloads","issues_url":"https://api.github.com/repos/pulibrary/figgy/issues{/number}","pulls_url":"https://api.github.com/repos/pulibrary/figgy/pulls{/number}","milestones_url":"https://api.github.com/repos/pulibrary/figgy/milestones{/number}","notifications_url":"https://api.github.com/repos/pulibrary/figgy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulibrary/figgy/labels{/name}","releases_url":"https://api.github.com/repos/pulibrary/figgy/releases{/id}","deployments_url":"https://api.github.com/repos/pulibrary/figgy/deployments","created_at":"2017-07-24T18:39:22Z","updated_at":"2017-08-29T20:33:20Z","pushed_at":"2017-10-04T20:09:08Z","git_url":"git://github.com/pulibrary/figgy.git","ssh_url":"git@github.com:pulibrary/figgy.git","clone_url":"https://github.com/pulibrary/figgy.git","svn_url":"https://github.com/pulibrary/figgy","homepage":null,"size":26394,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":72,"forks":1,"open_issues":72,"watchers":1,"default_branch":"master"}},"base":{"label":"pulibrary:master","ref":"master","sha":"c49d53539f00eeb28b17d2eb9de80b7321131f33","user":{"login":"pulibrary","id":1827800,"avatar_url":"https://avatars3.githubusercontent.com/u/1827800?v=4","gravatar_id":"","url":"https://api.github.com/users/pulibrary","html_url":"https://github.com/pulibrary","followers_url":"https://api.github.com/users/pulibrary/followers","following_url":"https://api.github.com/users/pulibrary/following{/other_user}","gists_url":"https://api.github.com/users/pulibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/pulibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulibrary/subscriptions","organizations_url":"https://api.github.com/users/pulibrary/orgs","repos_url":"https://api.github.com/users/pulibrary/repos","events_url":"https://api.github.com/users/pulibrary/events{/privacy}","received_events_url":"https://api.github.com/users/pulibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":98223070,"name":"figgy","full_name":"pulibrary/figgy","owner":{"login":"pulibrary","id":1827800,"avatar_url":"https://avatars3.githubusercontent.com/u/1827800?v=4","gravatar_id":"","url":"https://api.github.com/users/pulibrary","html_url":"https://github.com/pulibrary","followers_url":"https://api.github.com/users/pulibrary/followers","following_url":"https://api.github.com/users/pulibrary/following{/other_user}","gists_url":"https://api.github.com/users/pulibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/pulibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulibrary/subscriptions","organizations_url":"https://api.github.com/users/pulibrary/orgs","repos_url":"https://api.github.com/users/pulibrary/repos","events_url":"https://api.github.com/users/pulibrary/events{/privacy}","received_events_url":"https://api.github.com/users/pulibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulibrary/figgy","description":"Valkyrie-based digital repository backend.","fork":false,"url":"https://api.github.com/repos/pulibrary/figgy","forks_url":"https://api.github.com/repos/pulibrary/figgy/forks","keys_url":"https://api.github.com/repos/pulibrary/figgy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulibrary/figgy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulibrary/figgy/teams","hooks_url":"https://api.github.com/repos/pulibrary/figgy/hooks","issue_events_url":"https://api.github.com/repos/pulibrary/figgy/issues/events{/number}","events_url":"https://api.github.com/repos/pulibrary/figgy/events","assignees_url":"https://api.github.com/repos/pulibrary/figgy/assignees{/user}","branches_url":"https://api.github.com/repos/pulibrary/figgy/branches{/branch}","tags_url":"https://api.github.com/repos/pulibrary/figgy/tags","blobs_url":"https://api.github.com/repos/pulibrary/figgy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulibrary/figgy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulibrary/figgy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulibrary/figgy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulibrary/figgy/statuses/{sha}","languages_url":"https://api.github.com/repos/pulibrary/figgy/languages","stargazers_url":"https://api.github.com/repos/pulibrary/figgy/stargazers","contributors_url":"https://api.github.com/repos/pulibrary/figgy/contributors","subscribers_url":"https://api.github.com/repos/pulibrary/figgy/subscribers","subscription_url":"https://api.github.com/repos/pulibrary/figgy/subscription","commits_url":"https://api.github.com/repos/pulibrary/figgy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulibrary/figgy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulibrary/figgy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulibrary/figgy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulibrary/figgy/contents/{+path}","compare_url":"https://api.github.com/repos/pulibrary/figgy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulibrary/figgy/merges","archive_url":"https://api.github.com/repos/pulibrary/figgy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulibrary/figgy/downloads","issues_url":"https://api.github.com/repos/pulibrary/figgy/issues{/number}","pulls_url":"https://api.github.com/repos/pulibrary/figgy/pulls{/number}","milestones_url":"https://api.github.com/repos/pulibrary/figgy/milestones{/number}","notifications_url":"https://api.github.com/repos/pulibrary/figgy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulibrary/figgy/labels{/name}","releases_url":"https://api.github.com/repos/pulibrary/figgy/releases{/id}","deployments_url":"https://api.github.com/repos/pulibrary/figgy/deployments","created_at":"2017-07-24T18:39:22Z","updated_at":"2017-08-29T20:33:20Z","pushed_at":"2017-10-04T20:09:08Z","git_url":"git://github.com/pulibrary/figgy.git","ssh_url":"git@github.com:pulibrary/figgy.git","clone_url":"https://github.com/pulibrary/figgy.git","svn_url":"https://github.com/pulibrary/figgy","homepage":null,"size":26394,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":72,"forks":1,"open_issues":72,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/310"},"html":{"href":"https://github.com/pulibrary/figgy/pull/310"},"issue":{"href":"https://api.github.com/repos/pulibrary/figgy/issues/310"},"comments":{"href":"https://api.github.com/repos/pulibrary/figgy/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulibrary/figgy/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/pulibrary/figgy/statuses/30e27f8fbe055093cbe54dc3dc3f050ac8e055f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tpendragon"}}