{"action":"closed","number":3085,"pull_request":{"url":"https://api.github.com/repos/prettier/prettier/pulls/3085","id":148018159,"html_url":"https://github.com/prettier/prettier/pull/3085","diff_url":"https://github.com/prettier/prettier/pull/3085.diff","patch_url":"https://github.com/prettier/prettier/pull/3085.patch","issue_url":"https://api.github.com/repos/prettier/prettier/issues/3085","number":3085,"state":"closed","locked":false,"title":"Fixing playground report issue button and options parsing","user":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars0.githubusercontent.com/u/1042131?v=4","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"body":"Unfortunately with PR https://github.com/prettier/prettier/pull/3063 I introduced a few bugs to the playground\r\n\r\n1. The previous playground could parse config directly from the URL without having to wait any dependency to be available, due to the inclusion of lz-string as a dependencie for URL parsing we should have moved the logic of extracting config to go inside `window.onload`\r\n\r\n2. I Naively thought that I could have simply update all encodeUriComponent to the lz-string variant, but that was not the behaviour that we needed for `report-bug` button, that particular one should have kept the old behaviour of encodeUriComponent.\r\n\r\nApologies for leading to a broken PR being merged into `prettier`. Tested this PR and it seems to fix all the above issues.","created_at":"2017-10-22T22:59:22Z","updated_at":"2017-10-23T00:13:12Z","closed_at":"2017-10-23T00:13:12Z","merged_at":"2017-10-23T00:13:12Z","merge_commit_sha":"693d1fe01b625b9483917882b194e54cb46767f2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prettier/prettier/pulls/3085/commits","review_comments_url":"https://api.github.com/repos/prettier/prettier/pulls/3085/comments","review_comment_url":"https://api.github.com/repos/prettier/prettier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prettier/prettier/issues/3085/comments","statuses_url":"https://api.github.com/repos/prettier/prettier/statuses/ea2842c2f6d8fdc08e9c7c9064325b24c7f80334","head":{"label":"mitermayer:fixing-playground-dep-loading","ref":"fixing-playground-dep-loading","sha":"ea2842c2f6d8fdc08e9c7c9064325b24c7f80334","user":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars0.githubusercontent.com/u/1042131?v=4","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"repo":{"id":92885519,"name":"prettier","full_name":"mitermayer/prettier","owner":{"login":"mitermayer","id":1042131,"avatar_url":"https://avatars0.githubusercontent.com/u/1042131?v=4","gravatar_id":"","url":"https://api.github.com/users/mitermayer","html_url":"https://github.com/mitermayer","followers_url":"https://api.github.com/users/mitermayer/followers","following_url":"https://api.github.com/users/mitermayer/following{/other_user}","gists_url":"https://api.github.com/users/mitermayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mitermayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitermayer/subscriptions","organizations_url":"https://api.github.com/users/mitermayer/orgs","repos_url":"https://api.github.com/users/mitermayer/repos","events_url":"https://api.github.com/users/mitermayer/events{/privacy}","received_events_url":"https://api.github.com/users/mitermayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitermayer/prettier","description":"Prettier is an opinionated JavaScript formatter.","fork":true,"url":"https://api.github.com/repos/mitermayer/prettier","forks_url":"https://api.github.com/repos/mitermayer/prettier/forks","keys_url":"https://api.github.com/repos/mitermayer/prettier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitermayer/prettier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitermayer/prettier/teams","hooks_url":"https://api.github.com/repos/mitermayer/prettier/hooks","issue_events_url":"https://api.github.com/repos/mitermayer/prettier/issues/events{/number}","events_url":"https://api.github.com/repos/mitermayer/prettier/events","assignees_url":"https://api.github.com/repos/mitermayer/prettier/assignees{/user}","branches_url":"https://api.github.com/repos/mitermayer/prettier/branches{/branch}","tags_url":"https://api.github.com/repos/mitermayer/prettier/tags","blobs_url":"https://api.github.com/repos/mitermayer/prettier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitermayer/prettier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitermayer/prettier/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitermayer/prettier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitermayer/prettier/statuses/{sha}","languages_url":"https://api.github.com/repos/mitermayer/prettier/languages","stargazers_url":"https://api.github.com/repos/mitermayer/prettier/stargazers","contributors_url":"https://api.github.com/repos/mitermayer/prettier/contributors","subscribers_url":"https://api.github.com/repos/mitermayer/prettier/subscribers","subscription_url":"https://api.github.com/repos/mitermayer/prettier/subscription","commits_url":"https://api.github.com/repos/mitermayer/prettier/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitermayer/prettier/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitermayer/prettier/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitermayer/prettier/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitermayer/prettier/contents/{+path}","compare_url":"https://api.github.com/repos/mitermayer/prettier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitermayer/prettier/merges","archive_url":"https://api.github.com/repos/mitermayer/prettier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitermayer/prettier/downloads","issues_url":"https://api.github.com/repos/mitermayer/prettier/issues{/number}","pulls_url":"https://api.github.com/repos/mitermayer/prettier/pulls{/number}","milestones_url":"https://api.github.com/repos/mitermayer/prettier/milestones{/number}","notifications_url":"https://api.github.com/repos/mitermayer/prettier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitermayer/prettier/labels{/name}","releases_url":"https://api.github.com/repos/mitermayer/prettier/releases{/id}","deployments_url":"https://api.github.com/repos/mitermayer/prettier/deployments","created_at":"2017-05-30T23:41:12Z","updated_at":"2017-05-30T23:41:16Z","pushed_at":"2017-10-22T23:20:21Z","git_url":"git://github.com/mitermayer/prettier.git","ssh_url":"git@github.com:mitermayer/prettier.git","clone_url":"https://github.com/mitermayer/prettier.git","svn_url":"https://github.com/mitermayer/prettier","homepage":"https://prettier.github.io/prettier/","size":17200,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prettier:master","ref":"master","sha":"2169357c17fb6e8552af2ca69e80d8fc385aa664","user":{"login":"prettier","id":25822731,"avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"repo":{"id":75104123,"name":"prettier","full_name":"prettier/prettier","owner":{"login":"prettier","id":25822731,"avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prettier/prettier","description":"Prettier is an opinionated code formatter.","fork":false,"url":"https://api.github.com/repos/prettier/prettier","forks_url":"https://api.github.com/repos/prettier/prettier/forks","keys_url":"https://api.github.com/repos/prettier/prettier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prettier/prettier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prettier/prettier/teams","hooks_url":"https://api.github.com/repos/prettier/prettier/hooks","issue_events_url":"https://api.github.com/repos/prettier/prettier/issues/events{/number}","events_url":"https://api.github.com/repos/prettier/prettier/events","assignees_url":"https://api.github.com/repos/prettier/prettier/assignees{/user}","branches_url":"https://api.github.com/repos/prettier/prettier/branches{/branch}","tags_url":"https://api.github.com/repos/prettier/prettier/tags","blobs_url":"https://api.github.com/repos/prettier/prettier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prettier/prettier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prettier/prettier/git/refs{/sha}","trees_url":"https://api.github.com/repos/prettier/prettier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prettier/prettier/statuses/{sha}","languages_url":"https://api.github.com/repos/prettier/prettier/languages","stargazers_url":"https://api.github.com/repos/prettier/prettier/stargazers","contributors_url":"https://api.github.com/repos/prettier/prettier/contributors","subscribers_url":"https://api.github.com/repos/prettier/prettier/subscribers","subscription_url":"https://api.github.com/repos/prettier/prettier/subscription","commits_url":"https://api.github.com/repos/prettier/prettier/commits{/sha}","git_commits_url":"https://api.github.com/repos/prettier/prettier/git/commits{/sha}","comments_url":"https://api.github.com/repos/prettier/prettier/comments{/number}","issue_comment_url":"https://api.github.com/repos/prettier/prettier/issues/comments{/number}","contents_url":"https://api.github.com/repos/prettier/prettier/contents/{+path}","compare_url":"https://api.github.com/repos/prettier/prettier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prettier/prettier/merges","archive_url":"https://api.github.com/repos/prettier/prettier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prettier/prettier/downloads","issues_url":"https://api.github.com/repos/prettier/prettier/issues{/number}","pulls_url":"https://api.github.com/repos/prettier/prettier/pulls{/number}","milestones_url":"https://api.github.com/repos/prettier/prettier/milestones{/number}","notifications_url":"https://api.github.com/repos/prettier/prettier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prettier/prettier/labels{/name}","releases_url":"https://api.github.com/repos/prettier/prettier/releases{/id}","deployments_url":"https://api.github.com/repos/prettier/prettier/deployments","created_at":"2016-11-29T17:13:37Z","updated_at":"2017-10-22T22:50:54Z","pushed_at":"2017-10-23T00:13:12Z","git_url":"git://github.com/prettier/prettier.git","ssh_url":"git@github.com:prettier/prettier.git","clone_url":"https://github.com/prettier/prettier.git","svn_url":"https://github.com/prettier/prettier","homepage":"https://prettier.io/playground/","size":17495,"stargazers_count":16029,"watchers_count":16029,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":625,"mirror_url":null,"archived":false,"open_issues_count":165,"forks":625,"open_issues":165,"watchers":16029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prettier/prettier/pulls/3085"},"html":{"href":"https://github.com/prettier/prettier/pull/3085"},"issue":{"href":"https://api.github.com/repos/prettier/prettier/issues/3085"},"comments":{"href":"https://api.github.com/repos/prettier/prettier/issues/3085/comments"},"review_comments":{"href":"https://api.github.com/repos/prettier/prettier/pulls/3085/comments"},"review_comment":{"href":"https://api.github.com/repos/prettier/prettier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prettier/prettier/pulls/3085/commits"},"statuses":{"href":"https://api.github.com/repos/prettier/prettier/statuses/ea2842c2f6d8fdc08e9c7c9064325b24c7f80334"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"suchipi","id":1341513,"avatar_url":"https://avatars0.githubusercontent.com/u/1341513?v=4","gravatar_id":"","url":"https://api.github.com/users/suchipi","html_url":"https://github.com/suchipi","followers_url":"https://api.github.com/users/suchipi/followers","following_url":"https://api.github.com/users/suchipi/following{/other_user}","gists_url":"https://api.github.com/users/suchipi/gists{/gist_id}","starred_url":"https://api.github.com/users/suchipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suchipi/subscriptions","organizations_url":"https://api.github.com/users/suchipi/orgs","repos_url":"https://api.github.com/users/suchipi/repos","events_url":"https://api.github.com/users/suchipi/events{/privacy}","received_events_url":"https://api.github.com/users/suchipi/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":69,"deletions":66,"changed_files":1}}
{"actor":{"display_login":"suchipi"}}