{"action":"created","issue":{"url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/304","repository_url":"https://api.github.com/repos/getsentry/react-native-sentry","labels_url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/304/comments","events_url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/304/events","html_url":"https://github.com/getsentry/react-native-sentry/issues/304","id":276984017,"number":304,"title":"Upload gradle job fails on Windows, possibly missing backslash escape","user":{"login":"sam-vdp","id":24190534,"avatar_url":"https://avatars1.githubusercontent.com/u/24190534?v=4","gravatar_id":"","url":"https://api.github.com/users/sam-vdp","html_url":"https://github.com/sam-vdp","followers_url":"https://api.github.com/users/sam-vdp/followers","following_url":"https://api.github.com/users/sam-vdp/following{/other_user}","gists_url":"https://api.github.com/users/sam-vdp/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-vdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-vdp/subscriptions","organizations_url":"https://api.github.com/users/sam-vdp/orgs","repos_url":"https://api.github.com/users/sam-vdp/repos","events_url":"https://api.github.com/users/sam-vdp/events{/privacy}","received_events_url":"https://api.github.com/users/sam-vdp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-27T11:21:50Z","updated_at":"2017-11-27T11:33:43Z","closed_at":null,"author_association":"NONE","body":"OS:\r\n- [x]  Windows\r\n- [ ]  MacOS\r\n- [ ]  Linux\r\n\r\n_Platform:_\r\n- [ ]  iOS\r\n- [x]  Android\r\n\r\nOutput of `node -v && npm -v && npm ls --prod --depth=0`\r\n\r\n```\r\nv8.4.0\r\n5.5.1\r\n[...]\r\n+-- react-native-sentry@0.30.2\r\n```\r\n\r\nConfig:\r\nNot relevant\r\n\r\n---\r\nI have following issue:\r\n\r\ngradle task :app:bundleReleaseJsAndAssetsreleaseSentryUpload fails with error `'node_modulessentry-cli-binarybinsentry-cli' is not recognized as an internal or external command, operable program or batch file.`\r\n\r\nNote the missing slashes in the command string. The android/sentry.properties contains the following line:\r\n`cli.executable=node_modules\\sentry-cli-binary\\bin\\sentry-cli`\r\nIf I replace the singles backslashes in this string with double backslashes, the task runs successfully. However, this will probably break when building on MacOS.\r\n\r\n**Steps to reproduce:**\r\nnpm install react-native-sentry\r\nreact-native link (enter configuration)\r\ncd android\r\ngradlew assembleRelease\r\n\r\n**Actual result:**\r\napp:bundleReleaseJsAndAssetsreleaseSentryUpload fails\r\n\r\n**Expected result:**\r\napp:bundleReleaseJsAndAssetsreleaseSentryUpload  succeeds"},"comment":{"url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/comments/347156073","html_url":"https://github.com/getsentry/react-native-sentry/issues/304#issuecomment-347156073","issue_url":"https://api.github.com/repos/getsentry/react-native-sentry/issues/304","id":347156073,"user":{"login":"sam-vdp","id":24190534,"avatar_url":"https://avatars1.githubusercontent.com/u/24190534?v=4","gravatar_id":"","url":"https://api.github.com/users/sam-vdp","html_url":"https://github.com/sam-vdp","followers_url":"https://api.github.com/users/sam-vdp/followers","following_url":"https://api.github.com/users/sam-vdp/following{/other_user}","gists_url":"https://api.github.com/users/sam-vdp/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-vdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-vdp/subscriptions","organizations_url":"https://api.github.com/users/sam-vdp/orgs","repos_url":"https://api.github.com/users/sam-vdp/repos","events_url":"https://api.github.com/users/sam-vdp/events{/privacy}","received_events_url":"https://api.github.com/users/sam-vdp/received_events","type":"User","site_admin":false},"created_at":"2017-11-27T11:33:43Z","updated_at":"2017-11-27T11:33:43Z","author_association":"NONE","body":"Some more detail:\r\nsentry.gradle loads the .properties file like this:\r\n```\r\n            Properties sentryProps = new Properties();\r\n            try {\r\n                sentryProps.load(new FileInputStream(propertiesFile));\r\n            } catch (FileNotFoundException e) {\r\n                println \"File not found: $propertiesFile\"\r\n            }\r\n            def cliExecutable = sentryProps.get(\"cli.executable\", \"$reactRoot/node_modules/sentry-cli-binary/bin/sentry-cli\");\r\n```\r\nAs noted for the .properties file format\r\n> The backwards slash is used to escape a character\r\n(https://en.wikipedia.org/wiki/.properties)\r\n\r\nThe issue can fixed by simply removing the cli.executable property from the .properties file entirely, the default value then works."}}
{"actor":{"display_login":"sam-vdp"}}