{"action":"created","comment":{"url":"https://api.github.com/repos/gparmer/composite/pulls/comments/124676217","pull_request_review_id":46989432,"id":124676217,"diff_hunk":"@@ -5,7 +5,7 @@\n  * Public License v2.\n  */\n \n-#include \"include/shared/cos_types.h\"\n+#include \"include/user/cos_types.h\"","path":"src/kernel/capinv.c","position":5,"original_position":5,"commit_id":"a50af849dbe4e30384acac62bcfdf9907c064ad3","original_commit_id":"a50af849dbe4e30384acac62bcfdf9907c064ad3","user":{"login":"hungry-foolish","id":5815029,"avatar_url":"https://avatars3.githubusercontent.com/u/5815029?v=3","gravatar_id":"","url":"https://api.github.com/users/hungry-foolish","html_url":"https://github.com/hungry-foolish","followers_url":"https://api.github.com/users/hungry-foolish/followers","following_url":"https://api.github.com/users/hungry-foolish/following{/other_user}","gists_url":"https://api.github.com/users/hungry-foolish/gists{/gist_id}","starred_url":"https://api.github.com/users/hungry-foolish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungry-foolish/subscriptions","organizations_url":"https://api.github.com/users/hungry-foolish/orgs","repos_url":"https://api.github.com/users/hungry-foolish/repos","events_url":"https://api.github.com/users/hungry-foolish/events{/privacy}","received_events_url":"https://api.github.com/users/hungry-foolish/received_events","type":"User","site_admin":false},"body":"Now this is fixed.","created_at":"2017-06-28T22:50:22Z","updated_at":"2017-06-28T22:50:23Z","html_url":"https://github.com/gparmer/composite/pull/245#discussion_r124676217","pull_request_url":"https://api.github.com/repos/gparmer/composite/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/gparmer/composite/pulls/comments/124676217"},"html":{"href":"https://github.com/gparmer/composite/pull/245#discussion_r124676217"},"pull_request":{"href":"https://api.github.com/repos/gparmer/composite/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/gparmer/composite/pulls/245","id":126660131,"html_url":"https://github.com/gparmer/composite/pull/245","diff_url":"https://github.com/gparmer/composite/pull/245.diff","patch_url":"https://github.com/gparmer/composite/pull/245.patch","issue_url":"https://api.github.com/repos/gparmer/composite/issues/245","number":245,"state":"closed","locked":false,"title":"the kernel modifications, including the page table implementation","user":{"login":"hungry-foolish","id":5815029,"avatar_url":"https://avatars3.githubusercontent.com/u/5815029?v=3","gravatar_id":"","url":"https://api.github.com/users/hungry-foolish","html_url":"https://github.com/hungry-foolish","followers_url":"https://api.github.com/users/hungry-foolish/followers","following_url":"https://api.github.com/users/hungry-foolish/following{/other_user}","gists_url":"https://api.github.com/users/hungry-foolish/gists{/gist_id}","starred_url":"https://api.github.com/users/hungry-foolish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungry-foolish/subscriptions","organizations_url":"https://api.github.com/users/hungry-foolish/orgs","repos_url":"https://api.github.com/users/hungry-foolish/repos","events_url":"https://api.github.com/users/hungry-foolish/events{/privacy}","received_events_url":"https://api.github.com/users/hungry-foolish/received_events","type":"User","site_admin":false},"body":"### Summary of this PR\r\n\r\nThe kernel modifications, including the page table implementation.\r\nAlso includes some block-commented original code for functionality/logic comparison and validation.\r\n\r\n### Code Quality\r\n\r\nAs part of this pull request, I've considered the following:\r\n\r\nStyle:\r\n\r\n- [x] Comments adhere to the Style Guide (SG)\r\n- [x] Spacing adhere's to the SG \r\n- [x] Naming adhere's to the SG\r\n- [x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request\r\n\r\nCode Craftsmanship:\r\n\r\n- [x] I've made an attempt to remove all redundant code\r\n- [x] I've considered ways in which my changes might impact existing code, and cleaned it up\r\n- [x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)\r\n- [x] I've commented appropriately where code is tricky\r\n- [x] I agree that there is no \"throw-away\" code, and that code in this PR is of high quality\r\n","created_at":"2017-06-21T01:00:19Z","updated_at":"2017-06-28T22:50:23Z","closed_at":"2017-06-27T18:42:54Z","merged_at":null,"merge_commit_sha":"8c4e7cd49bc07828f3477ec58e5bfa3be9db95b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gparmer/composite/pulls/245/commits","review_comments_url":"https://api.github.com/repos/gparmer/composite/pulls/245/comments","review_comment_url":"https://api.github.com/repos/gparmer/composite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gparmer/composite/issues/245/comments","statuses_url":"https://api.github.com/repos/gparmer/composite/statuses/a50af849dbe4e30384acac62bcfdf9907c064ad3","head":{"label":"hungry-foolish:ppos_kernel","ref":"ppos_kernel","sha":"a50af849dbe4e30384acac62bcfdf9907c064ad3","user":{"login":"hungry-foolish","id":5815029,"avatar_url":"https://avatars3.githubusercontent.com/u/5815029?v=3","gravatar_id":"","url":"https://api.github.com/users/hungry-foolish","html_url":"https://github.com/hungry-foolish","followers_url":"https://api.github.com/users/hungry-foolish/followers","following_url":"https://api.github.com/users/hungry-foolish/following{/other_user}","gists_url":"https://api.github.com/users/hungry-foolish/gists{/gist_id}","starred_url":"https://api.github.com/users/hungry-foolish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungry-foolish/subscriptions","organizations_url":"https://api.github.com/users/hungry-foolish/orgs","repos_url":"https://api.github.com/users/hungry-foolish/repos","events_url":"https://api.github.com/users/hungry-foolish/events{/privacy}","received_events_url":"https://api.github.com/users/hungry-foolish/received_events","type":"User","site_admin":false},"repo":{"id":94947516,"name":"composite","full_name":"hungry-foolish/composite","owner":{"login":"hungry-foolish","id":5815029,"avatar_url":"https://avatars3.githubusercontent.com/u/5815029?v=3","gravatar_id":"","url":"https://api.github.com/users/hungry-foolish","html_url":"https://github.com/hungry-foolish","followers_url":"https://api.github.com/users/hungry-foolish/followers","following_url":"https://api.github.com/users/hungry-foolish/following{/other_user}","gists_url":"https://api.github.com/users/hungry-foolish/gists{/gist_id}","starred_url":"https://api.github.com/users/hungry-foolish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungry-foolish/subscriptions","organizations_url":"https://api.github.com/users/hungry-foolish/orgs","repos_url":"https://api.github.com/users/hungry-foolish/repos","events_url":"https://api.github.com/users/hungry-foolish/events{/privacy}","received_events_url":"https://api.github.com/users/hungry-foolish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hungry-foolish/composite","description":"A component-based OS","fork":true,"url":"https://api.github.com/repos/hungry-foolish/composite","forks_url":"https://api.github.com/repos/hungry-foolish/composite/forks","keys_url":"https://api.github.com/repos/hungry-foolish/composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hungry-foolish/composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hungry-foolish/composite/teams","hooks_url":"https://api.github.com/repos/hungry-foolish/composite/hooks","issue_events_url":"https://api.github.com/repos/hungry-foolish/composite/issues/events{/number}","events_url":"https://api.github.com/repos/hungry-foolish/composite/events","assignees_url":"https://api.github.com/repos/hungry-foolish/composite/assignees{/user}","branches_url":"https://api.github.com/repos/hungry-foolish/composite/branches{/branch}","tags_url":"https://api.github.com/repos/hungry-foolish/composite/tags","blobs_url":"https://api.github.com/repos/hungry-foolish/composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hungry-foolish/composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hungry-foolish/composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/hungry-foolish/composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hungry-foolish/composite/statuses/{sha}","languages_url":"https://api.github.com/repos/hungry-foolish/composite/languages","stargazers_url":"https://api.github.com/repos/hungry-foolish/composite/stargazers","contributors_url":"https://api.github.com/repos/hungry-foolish/composite/contributors","subscribers_url":"https://api.github.com/repos/hungry-foolish/composite/subscribers","subscription_url":"https://api.github.com/repos/hungry-foolish/composite/subscription","commits_url":"https://api.github.com/repos/hungry-foolish/composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/hungry-foolish/composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/hungry-foolish/composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/hungry-foolish/composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/hungry-foolish/composite/contents/{+path}","compare_url":"https://api.github.com/repos/hungry-foolish/composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hungry-foolish/composite/merges","archive_url":"https://api.github.com/repos/hungry-foolish/composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hungry-foolish/composite/downloads","issues_url":"https://api.github.com/repos/hungry-foolish/composite/issues{/number}","pulls_url":"https://api.github.com/repos/hungry-foolish/composite/pulls{/number}","milestones_url":"https://api.github.com/repos/hungry-foolish/composite/milestones{/number}","notifications_url":"https://api.github.com/repos/hungry-foolish/composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hungry-foolish/composite/labels{/name}","releases_url":"https://api.github.com/repos/hungry-foolish/composite/releases{/id}","deployments_url":"https://api.github.com/repos/hungry-foolish/composite/deployments","created_at":"2017-06-21T00:47:18Z","updated_at":"2017-06-21T00:47:25Z","pushed_at":"2017-06-21T01:16:18Z","git_url":"git://github.com/hungry-foolish/composite.git","ssh_url":"git@github.com:hungry-foolish/composite.git","clone_url":"https://github.com/hungry-foolish/composite.git","svn_url":"https://github.com/hungry-foolish/composite","homepage":"composite.seas.gwu.edu","size":21223,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ppos"}},"base":{"label":"gparmer:ppos","ref":"ppos","sha":"348746dcd03b40751d245ecca11dd63e67e2675c","user":{"login":"gparmer","id":454733,"avatar_url":"https://avatars3.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"repo":{"id":3140667,"name":"composite","full_name":"gparmer/composite","owner":{"login":"gparmer","id":454733,"avatar_url":"https://avatars3.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gparmer/composite","description":"A component-based OS","fork":false,"url":"https://api.github.com/repos/gparmer/composite","forks_url":"https://api.github.com/repos/gparmer/composite/forks","keys_url":"https://api.github.com/repos/gparmer/composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gparmer/composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gparmer/composite/teams","hooks_url":"https://api.github.com/repos/gparmer/composite/hooks","issue_events_url":"https://api.github.com/repos/gparmer/composite/issues/events{/number}","events_url":"https://api.github.com/repos/gparmer/composite/events","assignees_url":"https://api.github.com/repos/gparmer/composite/assignees{/user}","branches_url":"https://api.github.com/repos/gparmer/composite/branches{/branch}","tags_url":"https://api.github.com/repos/gparmer/composite/tags","blobs_url":"https://api.github.com/repos/gparmer/composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gparmer/composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gparmer/composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gparmer/composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gparmer/composite/statuses/{sha}","languages_url":"https://api.github.com/repos/gparmer/composite/languages","stargazers_url":"https://api.github.com/repos/gparmer/composite/stargazers","contributors_url":"https://api.github.com/repos/gparmer/composite/contributors","subscribers_url":"https://api.github.com/repos/gparmer/composite/subscribers","subscription_url":"https://api.github.com/repos/gparmer/composite/subscription","commits_url":"https://api.github.com/repos/gparmer/composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gparmer/composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gparmer/composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gparmer/composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gparmer/composite/contents/{+path}","compare_url":"https://api.github.com/repos/gparmer/composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gparmer/composite/merges","archive_url":"https://api.github.com/repos/gparmer/composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gparmer/composite/downloads","issues_url":"https://api.github.com/repos/gparmer/composite/issues{/number}","pulls_url":"https://api.github.com/repos/gparmer/composite/pulls{/number}","milestones_url":"https://api.github.com/repos/gparmer/composite/milestones{/number}","notifications_url":"https://api.github.com/repos/gparmer/composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gparmer/composite/labels{/name}","releases_url":"https://api.github.com/repos/gparmer/composite/releases{/id}","deployments_url":"https://api.github.com/repos/gparmer/composite/deployments","created_at":"2012-01-09T22:20:27Z","updated_at":"2017-06-05T01:31:03Z","pushed_at":"2017-06-28T21:35:41Z","git_url":"git://github.com/gparmer/composite.git","ssh_url":"git@github.com:gparmer/composite.git","clone_url":"https://github.com/gparmer/composite.git","svn_url":"https://github.com/gparmer/composite","homepage":"composite.seas.gwu.edu","size":18046,"stargazers_count":51,"watchers_count":51,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":60,"forks":36,"open_issues":60,"watchers":51,"default_branch":"ppos"}},"_links":{"self":{"href":"https://api.github.com/repos/gparmer/composite/pulls/245"},"html":{"href":"https://github.com/gparmer/composite/pull/245"},"issue":{"href":"https://api.github.com/repos/gparmer/composite/issues/245"},"comments":{"href":"https://api.github.com/repos/gparmer/composite/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/gparmer/composite/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/gparmer/composite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gparmer/composite/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/gparmer/composite/statuses/a50af849dbe4e30384acac62bcfdf9907c064ad3"}}}}
{"actor":{"display_login":"hungry-foolish"}}