{"action":"created","issue":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/2821","repository_url":"https://api.github.com/repos/scala-js/scala-js","labels_url":"https://api.github.com/repos/scala-js/scala-js/issues/2821/labels{/name}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/2821/comments","events_url":"https://api.github.com/repos/scala-js/scala-js/issues/2821/events","html_url":"https://github.com/scala-js/scala-js/issues/2821","id":215674208,"number":2821,"title":"Source Maps bug - wrong column in the generated file","user":{"login":"Gralfim","id":25323229,"avatar_url":"https://avatars3.githubusercontent.com/u/25323229?v=3","gravatar_id":"","url":"https://api.github.com/users/Gralfim","html_url":"https://github.com/Gralfim","followers_url":"https://api.github.com/users/Gralfim/followers","following_url":"https://api.github.com/users/Gralfim/following{/other_user}","gists_url":"https://api.github.com/users/Gralfim/gists{/gist_id}","starred_url":"https://api.github.com/users/Gralfim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gralfim/subscriptions","organizations_url":"https://api.github.com/users/Gralfim/orgs","repos_url":"https://api.github.com/users/Gralfim/repos","events_url":"https://api.github.com/users/Gralfim/events{/privacy}","received_events_url":"https://api.github.com/users/Gralfim/received_events","type":"User","site_admin":false},"labels":[{"id":28856109,"url":"https://api.github.com/repos/scala-js/scala-js/labels/bug","name":"bug","color":"fc2929","default":true},{"id":133973858,"url":"https://api.github.com/repos/scala-js/scala-js/labels/has-pr","name":"has-pr","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scala-js/scala-js/milestones/44","html_url":"https://github.com/scala-js/scala-js/milestone/44","labels_url":"https://api.github.com/repos/scala-js/scala-js/milestones/44/labels","id":2395385,"number":44,"title":"v0.6.16","description":"","creator":{"login":"sjrd","id":535934,"avatar_url":"https://avatars0.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":13,"state":"open","created_at":"2017-03-18T16:39:12Z","updated_at":"2017-04-26T20:44:16Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-03-21T09:24:48Z","updated_at":"2017-04-26T20:44:16Z","closed_at":"2017-04-26T20:44:16Z","body":"There seems to be a bug in the class `JSTreePrinterWithSourceMap` causing that the source maps does not exactly match the generated file.\r\nThe class has two purposes:\r\n1. it generates the output javascript code using its base class `JSTreePrinter`\r\n2. it maintains the position in the javascript (in `private var column`) and uses it to generate source map (using `sourceMap: SourceMapWriter`)\r\nTo serve well for both these functions, there is necessary to keep `var column` synchronized with the position in `out` stream (see `override protected def print(s: String): Unit`). However, in the function `override protected def print(ident: Ident): Unit` (and one similar place) there is some writing to `out` without change of `var column`.\r\n"},"comment":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/comments/297535549","html_url":"https://github.com/scala-js/scala-js/issues/2821#issuecomment-297535549","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/2821","id":297535549,"user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars0.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"created_at":"2017-04-26T20:44:16Z","updated_at":"2017-04-26T20:44:16Z","body":"Fixed in #2819."}}
{"actor":{"display_login":"sjrd"}}