{"action":"created","comment":{"url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/comments/105569155","pull_request_review_id":26455266,"id":105569155,"diff_hunk":"@@ -0,0 +1,46 @@\n+//\n+//  GADQuery.h\n+//  DB\n+//\n+//  Created by Liam li on 3/5/17.\n+//  Copyright © 2017 AppDev. All rights reserved.\n+//\n+\n+#import <Foundation/Foundation.h>\n+#import \"GADPerson.h\"\n+\n+@interface GADQuery : NSObject\n+\n+@property (nullable,nonatomic, strong) NSString *lastName;\n+@property (nullable,nonatomic, strong) NSString *firstName;\n+@property (nullable,nonatomic, strong) NSString *campusAddressOrPOBox;\n+@property (nullable,nonatomic, strong) NSString *FacStaffDeptOffice;\n+@property (nullable,nonatomic, strong) NSString *studentMajor;\n+@property (nullable,nonatomic, strong) NSString *hiatus;\n+@property (nullable,nonatomic, strong) NSString *computerUsername;\n+@property (nullable,nonatomic, strong) NSString *campusPhone;\n+@property (nullable,nonatomic, strong) NSString *homeAddress;\n+@property (nullable,nonatomic, strong) NSString *SGA;\n+@property (nullable,nonatomic, strong) NSString *concentration;\n+@property (nullable,nonatomic, strong) NSString *studentClass;\n+\n+-(void)setlastName: (nonnull NSString*) lastName;\n+-(void)setfirstName: (nonnull NSString*) firstName;\n+-(void)setcampusAddressOrPOBox: (nonnull NSString*) campusAddressOrPOBox;\n+-(void)setFacStaffDeptOffice: (nonnull NSString*) FacStaffDeptOffice;\n+-(void)setstudentMajor: (nonnull NSString*) studentMajor;\n+-(void)sethiatus: (nonnull NSString*) hiatus;\n+-(void)setcomputerUsername: (nonnull NSString*)computerUsername;\n+-(void)setcampusPhone: (nonnull NSString*)campusPhone;\n+-(void)sethomeAddress: (nonnull NSString*)homeAddress;\n+-(void)setSGA: (nonnull NSString*) SGA;\n+-(void)setconcentration: (nonnull NSString*)concentration;\n+-(void)setstudentClass: (nonnull NSString*) studentClass;\n+\n+-(nonnull NSDictionary*) convertQueryObejectToDict;\n+\n+-(void) fetchPersonInfoWithUsername:(nonnull NSString*)username","path":"GADDirectory/GADQuery.h","position":42,"original_position":42,"commit_id":"ee0efecbd0fdab7a9f33d0ee3f976c94a7a62642","original_commit_id":"ee0efecbd0fdab7a9f33d0ee3f976c94a7a62642","user":{"login":"alexthemitchell","id":5687158,"avatar_url":"https://avatars2.githubusercontent.com/u/5687158?v=3","gravatar_id":"","url":"https://api.github.com/users/alexthemitchell","html_url":"https://github.com/alexthemitchell","followers_url":"https://api.github.com/users/alexthemitchell/followers","following_url":"https://api.github.com/users/alexthemitchell/following{/other_user}","gists_url":"https://api.github.com/users/alexthemitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/alexthemitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexthemitchell/subscriptions","organizations_url":"https://api.github.com/users/alexthemitchell/orgs","repos_url":"https://api.github.com/users/alexthemitchell/repos","events_url":"https://api.github.com/users/alexthemitchell/events{/privacy}","received_events_url":"https://api.github.com/users/alexthemitchell/received_events","type":"User","site_admin":false},"body":"How about something like `executeWithUsername:Password:completionHandler` or `searchWith...` etc. Definitely should not include \"PersonInfo\", but we want to make clear that this function is the actual heart of the search.","created_at":"2017-03-12T21:14:52Z","updated_at":"2017-03-12T21:15:12Z","html_url":"https://github.com/GrinnellAppDev/DB-iOS/pull/11#discussion_r105569155","pull_request_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/comments/105569155"},"html":{"href":"https://github.com/GrinnellAppDev/DB-iOS/pull/11#discussion_r105569155"},"pull_request":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11","id":110312262,"html_url":"https://github.com/GrinnellAppDev/DB-iOS/pull/11","diff_url":"https://github.com/GrinnellAppDev/DB-iOS/pull/11.diff","patch_url":"https://github.com/GrinnellAppDev/DB-iOS/pull/11.patch","issue_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/11","number":11,"state":"open","locked":false,"title":"Add query class","user":{"login":"Liamlhy","id":22759052,"avatar_url":"https://avatars3.githubusercontent.com/u/22759052?v=3","gravatar_id":"","url":"https://api.github.com/users/Liamlhy","html_url":"https://github.com/Liamlhy","followers_url":"https://api.github.com/users/Liamlhy/followers","following_url":"https://api.github.com/users/Liamlhy/following{/other_user}","gists_url":"https://api.github.com/users/Liamlhy/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamlhy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamlhy/subscriptions","organizations_url":"https://api.github.com/users/Liamlhy/orgs","repos_url":"https://api.github.com/users/Liamlhy/repos","events_url":"https://api.github.com/users/Liamlhy/events{/privacy}","received_events_url":"https://api.github.com/users/Liamlhy/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-12T19:51:27Z","updated_at":"2017-03-12T21:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41aa85e5b1d1ef5f47ba11e4cb9848c827398431","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11/commits","review_comments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11/comments","review_comment_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/11/comments","statuses_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/statuses/ee0efecbd0fdab7a9f33d0ee3f976c94a7a62642","head":{"label":"GrinnellAppDev:query","ref":"query","sha":"ee0efecbd0fdab7a9f33d0ee3f976c94a7a62642","user":{"login":"GrinnellAppDev","id":590360,"avatar_url":"https://avatars3.githubusercontent.com/u/590360?v=3","gravatar_id":"","url":"https://api.github.com/users/GrinnellAppDev","html_url":"https://github.com/GrinnellAppDev","followers_url":"https://api.github.com/users/GrinnellAppDev/followers","following_url":"https://api.github.com/users/GrinnellAppDev/following{/other_user}","gists_url":"https://api.github.com/users/GrinnellAppDev/gists{/gist_id}","starred_url":"https://api.github.com/users/GrinnellAppDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrinnellAppDev/subscriptions","organizations_url":"https://api.github.com/users/GrinnellAppDev/orgs","repos_url":"https://api.github.com/users/GrinnellAppDev/repos","events_url":"https://api.github.com/users/GrinnellAppDev/events{/privacy}","received_events_url":"https://api.github.com/users/GrinnellAppDev/received_events","type":"Organization","site_admin":false},"repo":{"id":80388282,"name":"DB-iOS","full_name":"GrinnellAppDev/DB-iOS","owner":{"login":"GrinnellAppDev","id":590360,"avatar_url":"https://avatars3.githubusercontent.com/u/590360?v=3","gravatar_id":"","url":"https://api.github.com/users/GrinnellAppDev","html_url":"https://github.com/GrinnellAppDev","followers_url":"https://api.github.com/users/GrinnellAppDev/followers","following_url":"https://api.github.com/users/GrinnellAppDev/following{/other_user}","gists_url":"https://api.github.com/users/GrinnellAppDev/gists{/gist_id}","starred_url":"https://api.github.com/users/GrinnellAppDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrinnellAppDev/subscriptions","organizations_url":"https://api.github.com/users/GrinnellAppDev/orgs","repos_url":"https://api.github.com/users/GrinnellAppDev/repos","events_url":"https://api.github.com/users/GrinnellAppDev/events{/privacy}","received_events_url":"https://api.github.com/users/GrinnellAppDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GrinnellAppDev/DB-iOS","description":"The New DB iOS","fork":false,"url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS","forks_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/forks","keys_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/teams","hooks_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/hooks","issue_events_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/events","assignees_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/tags","blobs_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/languages","stargazers_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/stargazers","contributors_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/contributors","subscribers_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/subscribers","subscription_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/subscription","commits_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/merges","archive_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/downloads","issues_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/labels{/name}","releases_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/deployments","created_at":"2017-01-30T02:28:23Z","updated_at":"2017-01-30T02:29:00Z","pushed_at":"2017-03-12T19:56:02Z","git_url":"git://github.com/GrinnellAppDev/DB-iOS.git","ssh_url":"git@github.com:GrinnellAppDev/DB-iOS.git","clone_url":"https://github.com/GrinnellAppDev/DB-iOS.git","svn_url":"https://github.com/GrinnellAppDev/DB-iOS","homepage":null,"size":377,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"GrinnellAppDev:master","ref":"master","sha":"9a05bc63af7381ea3bb5ac0890e9a9004d8d0d46","user":{"login":"GrinnellAppDev","id":590360,"avatar_url":"https://avatars3.githubusercontent.com/u/590360?v=3","gravatar_id":"","url":"https://api.github.com/users/GrinnellAppDev","html_url":"https://github.com/GrinnellAppDev","followers_url":"https://api.github.com/users/GrinnellAppDev/followers","following_url":"https://api.github.com/users/GrinnellAppDev/following{/other_user}","gists_url":"https://api.github.com/users/GrinnellAppDev/gists{/gist_id}","starred_url":"https://api.github.com/users/GrinnellAppDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrinnellAppDev/subscriptions","organizations_url":"https://api.github.com/users/GrinnellAppDev/orgs","repos_url":"https://api.github.com/users/GrinnellAppDev/repos","events_url":"https://api.github.com/users/GrinnellAppDev/events{/privacy}","received_events_url":"https://api.github.com/users/GrinnellAppDev/received_events","type":"Organization","site_admin":false},"repo":{"id":80388282,"name":"DB-iOS","full_name":"GrinnellAppDev/DB-iOS","owner":{"login":"GrinnellAppDev","id":590360,"avatar_url":"https://avatars3.githubusercontent.com/u/590360?v=3","gravatar_id":"","url":"https://api.github.com/users/GrinnellAppDev","html_url":"https://github.com/GrinnellAppDev","followers_url":"https://api.github.com/users/GrinnellAppDev/followers","following_url":"https://api.github.com/users/GrinnellAppDev/following{/other_user}","gists_url":"https://api.github.com/users/GrinnellAppDev/gists{/gist_id}","starred_url":"https://api.github.com/users/GrinnellAppDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrinnellAppDev/subscriptions","organizations_url":"https://api.github.com/users/GrinnellAppDev/orgs","repos_url":"https://api.github.com/users/GrinnellAppDev/repos","events_url":"https://api.github.com/users/GrinnellAppDev/events{/privacy}","received_events_url":"https://api.github.com/users/GrinnellAppDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GrinnellAppDev/DB-iOS","description":"The New DB iOS","fork":false,"url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS","forks_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/forks","keys_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/teams","hooks_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/hooks","issue_events_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/events","assignees_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/tags","blobs_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/languages","stargazers_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/stargazers","contributors_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/contributors","subscribers_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/subscribers","subscription_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/subscription","commits_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/merges","archive_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/downloads","issues_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/labels{/name}","releases_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/deployments","created_at":"2017-01-30T02:28:23Z","updated_at":"2017-01-30T02:29:00Z","pushed_at":"2017-03-12T19:56:02Z","git_url":"git://github.com/GrinnellAppDev/DB-iOS.git","ssh_url":"git@github.com:GrinnellAppDev/DB-iOS.git","clone_url":"https://github.com/GrinnellAppDev/DB-iOS.git","svn_url":"https://github.com/GrinnellAppDev/DB-iOS","homepage":null,"size":377,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11"},"html":{"href":"https://github.com/GrinnellAppDev/DB-iOS/pull/11"},"issue":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/11"},"comments":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/GrinnellAppDev/DB-iOS/statuses/ee0efecbd0fdab7a9f33d0ee3f976c94a7a62642"}}}}
{"actor":{"display_login":"alexthemitchell"}}