{"action":"created","issue":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/1720","repository_url":"https://api.github.com/repos/vuetifyjs/vuetify","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/1720/labels{/name}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/1720/comments","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/1720/events","html_url":"https://github.com/vuetifyjs/vuetify/pull/1720","id":257412979,"number":1720,"title":"[vue 2.4.3] fixes #1719","user":{"login":"jacekkarczmarczyk","id":15625235,"avatar_url":"https://avatars3.githubusercontent.com/u/15625235?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekkarczmarczyk","html_url":"https://github.com/jacekkarczmarczyk","followers_url":"https://api.github.com/users/jacekkarczmarczyk/followers","following_url":"https://api.github.com/users/jacekkarczmarczyk/following{/other_user}","gists_url":"https://api.github.com/users/jacekkarczmarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkarczmarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkarczmarczyk/subscriptions","organizations_url":"https://api.github.com/users/jacekkarczmarczyk/orgs","repos_url":"https://api.github.com/users/jacekkarczmarczyk/repos","events_url":"https://api.github.com/users/jacekkarczmarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkarczmarczyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-13T14:56:53Z","updated_at":"2017-09-13T15:49:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/1720","html_url":"https://github.com/vuetifyjs/vuetify/pull/1720","diff_url":"https://github.com/vuetifyjs/vuetify/pull/1720.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/1720.patch"},"body":"### disclaimer\r\n\r\nProbably it would be better to find out why `data.on` is not extensible and change it to extensible, but i'm not sure how to approach it\r\n\r\n**Edit:**\r\nChanging `on: this.$listeners` to `on: { ...this.$listeners }` could do the thing, but actually maybe it's better to create extensible object only when needed, so this PR should be enough\r\n\r\n![image](https://user-images.githubusercontent.com/15625235/30384655-3409353e-98a5-11e7-9efc-740f6e5b1154.png)\r\n"},"comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments/329211472","html_url":"https://github.com/vuetifyjs/vuetify/pull/1720#issuecomment-329211472","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/1720","id":329211472,"user":{"login":"KaelWD","id":16421948,"avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T15:49:32Z","updated_at":"2017-09-13T15:49:32Z","author_association":"CONTRIBUTOR","body":"> it would be better to find out why `data.on` is not extensible\r\n\r\nVue 2.4.3 includes [this change](https://github.com/vuejs/vue/pull/6441/files#diff-37f4deddf9f54795e5be4c5540ceb906R236). `emptyObject` is a [frozen empty object](https://github.com/vuejs/vue/blob/d6999c19c4c18d5eedfd3a7741e17b0e34e8a8df/src/core/util/lang.js#L3), I guess to help performance. "}}
{"actor":{"display_login":"KaelWD"}}