{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66","id":100489002,"html_url":"https://github.com/nst/JSONTestSuite/pull/66","diff_url":"https://github.com/nst/JSONTestSuite/pull/66.diff","patch_url":"https://github.com/nst/JSONTestSuite/pull/66.patch","issue_url":"https://api.github.com/repos/nst/JSONTestSuite/issues/66","number":66,"state":"closed","locked":false,"title":"Tweak lonely numbers parsing tests","user":{"login":"stig","id":45407,"avatar_url":"https://avatars.githubusercontent.com/u/45407?v=3","gravatar_id":"","url":"https://api.github.com/users/stig","html_url":"https://github.com/stig","followers_url":"https://api.github.com/users/stig/followers","following_url":"https://api.github.com/users/stig/following{/other_user}","gists_url":"https://api.github.com/users/stig/gists{/gist_id}","starred_url":"https://api.github.com/users/stig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stig/subscriptions","organizations_url":"https://api.github.com/users/stig/orgs","repos_url":"https://api.github.com/users/stig/repos","events_url":"https://api.github.com/users/stig/events{/privacy}","received_events_url":"https://api.github.com/users/stig/received_events","type":"User","site_admin":false},"body":"When parsing numbers at the top level there is *no way* to differentiate 42 on its own from 4200 truncated to just the first two bytes. This only affects numbers as the other JSON datatypes are either fixed length (true, false, null) or have unambigous delimiters at both ends ([], {}, \"\"). (I personally consider allowing scalars at the top level to be a mistake in RFC7159 for this reason.)\r\n\r\nThis change moves the lonely number parsing tests to become implementation defined, and adds new \"yes\" tests with newlines after the initial digits to make it obvious that the sequence of digits is over and the token can be converted into a number.","created_at":"2017-01-06T16:53:25Z","updated_at":"2017-01-18T20:22:40Z","closed_at":"2017-01-18T20:22:40Z","merged_at":null,"merge_commit_sha":"1e7bc44500ae4fb7745f22d004a5cea010ab5a2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66/commits","review_comments_url":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66/comments","review_comment_url":"https://api.github.com/repos/nst/JSONTestSuite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nst/JSONTestSuite/issues/66/comments","statuses_url":"https://api.github.com/repos/nst/JSONTestSuite/statuses/f016fd0e50b59376924e23f48c34dc0c4ec42630","head":{"label":"stig:number-tests","ref":"number-tests","sha":"f016fd0e50b59376924e23f48c34dc0c4ec42630","user":{"login":"stig","id":45407,"avatar_url":"https://avatars.githubusercontent.com/u/45407?v=3","gravatar_id":"","url":"https://api.github.com/users/stig","html_url":"https://github.com/stig","followers_url":"https://api.github.com/users/stig/followers","following_url":"https://api.github.com/users/stig/following{/other_user}","gists_url":"https://api.github.com/users/stig/gists{/gist_id}","starred_url":"https://api.github.com/users/stig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stig/subscriptions","organizations_url":"https://api.github.com/users/stig/orgs","repos_url":"https://api.github.com/users/stig/repos","events_url":"https://api.github.com/users/stig/events{/privacy}","received_events_url":"https://api.github.com/users/stig/received_events","type":"User","site_admin":false},"repo":{"id":72794003,"name":"JSONTestSuite","full_name":"stig/JSONTestSuite","owner":{"login":"stig","id":45407,"avatar_url":"https://avatars.githubusercontent.com/u/45407?v=3","gravatar_id":"","url":"https://api.github.com/users/stig","html_url":"https://github.com/stig","followers_url":"https://api.github.com/users/stig/followers","following_url":"https://api.github.com/users/stig/following{/other_user}","gists_url":"https://api.github.com/users/stig/gists{/gist_id}","starred_url":"https://api.github.com/users/stig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stig/subscriptions","organizations_url":"https://api.github.com/users/stig/orgs","repos_url":"https://api.github.com/users/stig/repos","events_url":"https://api.github.com/users/stig/events{/privacy}","received_events_url":"https://api.github.com/users/stig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stig/JSONTestSuite","description":"A comprehensive test suite for RFC 7159 compliant JSON parsers","fork":true,"url":"https://api.github.com/repos/stig/JSONTestSuite","forks_url":"https://api.github.com/repos/stig/JSONTestSuite/forks","keys_url":"https://api.github.com/repos/stig/JSONTestSuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stig/JSONTestSuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stig/JSONTestSuite/teams","hooks_url":"https://api.github.com/repos/stig/JSONTestSuite/hooks","issue_events_url":"https://api.github.com/repos/stig/JSONTestSuite/issues/events{/number}","events_url":"https://api.github.com/repos/stig/JSONTestSuite/events","assignees_url":"https://api.github.com/repos/stig/JSONTestSuite/assignees{/user}","branches_url":"https://api.github.com/repos/stig/JSONTestSuite/branches{/branch}","tags_url":"https://api.github.com/repos/stig/JSONTestSuite/tags","blobs_url":"https://api.github.com/repos/stig/JSONTestSuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stig/JSONTestSuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stig/JSONTestSuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/stig/JSONTestSuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stig/JSONTestSuite/statuses/{sha}","languages_url":"https://api.github.com/repos/stig/JSONTestSuite/languages","stargazers_url":"https://api.github.com/repos/stig/JSONTestSuite/stargazers","contributors_url":"https://api.github.com/repos/stig/JSONTestSuite/contributors","subscribers_url":"https://api.github.com/repos/stig/JSONTestSuite/subscribers","subscription_url":"https://api.github.com/repos/stig/JSONTestSuite/subscription","commits_url":"https://api.github.com/repos/stig/JSONTestSuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/stig/JSONTestSuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/stig/JSONTestSuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/stig/JSONTestSuite/issues/comments{/number}","contents_url":"https://api.github.com/repos/stig/JSONTestSuite/contents/{+path}","compare_url":"https://api.github.com/repos/stig/JSONTestSuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stig/JSONTestSuite/merges","archive_url":"https://api.github.com/repos/stig/JSONTestSuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stig/JSONTestSuite/downloads","issues_url":"https://api.github.com/repos/stig/JSONTestSuite/issues{/number}","pulls_url":"https://api.github.com/repos/stig/JSONTestSuite/pulls{/number}","milestones_url":"https://api.github.com/repos/stig/JSONTestSuite/milestones{/number}","notifications_url":"https://api.github.com/repos/stig/JSONTestSuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stig/JSONTestSuite/labels{/name}","releases_url":"https://api.github.com/repos/stig/JSONTestSuite/releases{/id}","deployments_url":"https://api.github.com/repos/stig/JSONTestSuite/deployments","created_at":"2016-11-03T22:53:53Z","updated_at":"2016-11-03T22:53:56Z","pushed_at":"2017-01-06T16:56:05Z","git_url":"git://github.com/stig/JSONTestSuite.git","ssh_url":"git@github.com:stig/JSONTestSuite.git","clone_url":"https://github.com/stig/JSONTestSuite.git","svn_url":"https://github.com/stig/JSONTestSuite","homepage":null,"size":45662,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nst:master","ref":"master","sha":"6225255c9f08f63246707cffa9694a05a50fdf1d","user":{"login":"nst","id":51388,"avatar_url":"https://avatars.githubusercontent.com/u/51388?v=3","gravatar_id":"","url":"https://api.github.com/users/nst","html_url":"https://github.com/nst","followers_url":"https://api.github.com/users/nst/followers","following_url":"https://api.github.com/users/nst/following{/other_user}","gists_url":"https://api.github.com/users/nst/gists{/gist_id}","starred_url":"https://api.github.com/users/nst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nst/subscriptions","organizations_url":"https://api.github.com/users/nst/orgs","repos_url":"https://api.github.com/users/nst/repos","events_url":"https://api.github.com/users/nst/events{/privacy}","received_events_url":"https://api.github.com/users/nst/received_events","type":"User","site_admin":false},"repo":{"id":71723822,"name":"JSONTestSuite","full_name":"nst/JSONTestSuite","owner":{"login":"nst","id":51388,"avatar_url":"https://avatars.githubusercontent.com/u/51388?v=3","gravatar_id":"","url":"https://api.github.com/users/nst","html_url":"https://github.com/nst","followers_url":"https://api.github.com/users/nst/followers","following_url":"https://api.github.com/users/nst/following{/other_user}","gists_url":"https://api.github.com/users/nst/gists{/gist_id}","starred_url":"https://api.github.com/users/nst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nst/subscriptions","organizations_url":"https://api.github.com/users/nst/orgs","repos_url":"https://api.github.com/users/nst/repos","events_url":"https://api.github.com/users/nst/events{/privacy}","received_events_url":"https://api.github.com/users/nst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nst/JSONTestSuite","description":"A comprehensive test suite for RFC 7159 compliant JSON parsers","fork":false,"url":"https://api.github.com/repos/nst/JSONTestSuite","forks_url":"https://api.github.com/repos/nst/JSONTestSuite/forks","keys_url":"https://api.github.com/repos/nst/JSONTestSuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nst/JSONTestSuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nst/JSONTestSuite/teams","hooks_url":"https://api.github.com/repos/nst/JSONTestSuite/hooks","issue_events_url":"https://api.github.com/repos/nst/JSONTestSuite/issues/events{/number}","events_url":"https://api.github.com/repos/nst/JSONTestSuite/events","assignees_url":"https://api.github.com/repos/nst/JSONTestSuite/assignees{/user}","branches_url":"https://api.github.com/repos/nst/JSONTestSuite/branches{/branch}","tags_url":"https://api.github.com/repos/nst/JSONTestSuite/tags","blobs_url":"https://api.github.com/repos/nst/JSONTestSuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nst/JSONTestSuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nst/JSONTestSuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/nst/JSONTestSuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nst/JSONTestSuite/statuses/{sha}","languages_url":"https://api.github.com/repos/nst/JSONTestSuite/languages","stargazers_url":"https://api.github.com/repos/nst/JSONTestSuite/stargazers","contributors_url":"https://api.github.com/repos/nst/JSONTestSuite/contributors","subscribers_url":"https://api.github.com/repos/nst/JSONTestSuite/subscribers","subscription_url":"https://api.github.com/repos/nst/JSONTestSuite/subscription","commits_url":"https://api.github.com/repos/nst/JSONTestSuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/nst/JSONTestSuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/nst/JSONTestSuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/nst/JSONTestSuite/issues/comments{/number}","contents_url":"https://api.github.com/repos/nst/JSONTestSuite/contents/{+path}","compare_url":"https://api.github.com/repos/nst/JSONTestSuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nst/JSONTestSuite/merges","archive_url":"https://api.github.com/repos/nst/JSONTestSuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nst/JSONTestSuite/downloads","issues_url":"https://api.github.com/repos/nst/JSONTestSuite/issues{/number}","pulls_url":"https://api.github.com/repos/nst/JSONTestSuite/pulls{/number}","milestones_url":"https://api.github.com/repos/nst/JSONTestSuite/milestones{/number}","notifications_url":"https://api.github.com/repos/nst/JSONTestSuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nst/JSONTestSuite/labels{/name}","releases_url":"https://api.github.com/repos/nst/JSONTestSuite/releases{/id}","deployments_url":"https://api.github.com/repos/nst/JSONTestSuite/deployments","created_at":"2016-10-23T19:14:09Z","updated_at":"2017-01-10T19:07:46Z","pushed_at":"2017-01-18T20:15:26Z","git_url":"git://github.com/nst/JSONTestSuite.git","ssh_url":"git@github.com:nst/JSONTestSuite.git","clone_url":"https://github.com/nst/JSONTestSuite.git","svn_url":"https://github.com/nst/JSONTestSuite","homepage":null,"size":45621,"stargazers_count":207,"watchers_count":207,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":12,"forks":42,"open_issues":12,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66"},"html":{"href":"https://github.com/nst/JSONTestSuite/pull/66"},"issue":{"href":"https://api.github.com/repos/nst/JSONTestSuite/issues/66"},"comments":{"href":"https://api.github.com/repos/nst/JSONTestSuite/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/nst/JSONTestSuite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nst/JSONTestSuite/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/nst/JSONTestSuite/statuses/f016fd0e50b59376924e23f48c34dc0c4ec42630"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"nst"}}