{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16562","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16562/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16562/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16562/events","html_url":"https://github.com/nodejs/node/pull/16562","id":269201115,"number":16562,"title":"lib: setup IPC channel before console","user":{"login":"seishun","id":988441,"avatar_url":"https://avatars1.githubusercontent.com/u/988441?v=4","gravatar_id":"","url":"https://api.github.com/users/seishun","html_url":"https://github.com/seishun","followers_url":"https://api.github.com/users/seishun/followers","following_url":"https://api.github.com/users/seishun/following{/other_user}","gists_url":"https://api.github.com/users/seishun/gists{/gist_id}","starred_url":"https://api.github.com/users/seishun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seishun/subscriptions","organizations_url":"https://api.github.com/users/seishun/orgs","repos_url":"https://api.github.com/users/seishun/repos","events_url":"https://api.github.com/users/seishun/events{/privacy}","received_events_url":"https://api.github.com/users/seishun/received_events","type":"User","site_admin":false},"labels":[{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-27T18:49:01Z","updated_at":"2017-10-29T14:28:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16562","html_url":"https://github.com/nodejs/node/pull/16562","diff_url":"https://github.com/nodejs/node/pull/16562.diff","patch_url":"https://github.com/nodejs/node/pull/16562.patch"},"body":"Initializing IOCP on the same fd twice can fail on Windows.\r\nConsequently, if the IPC channel uses fd 1 or 2 and the console is setup\r\nfirst, writing to the IPC channel will fail.\r\n\r\nFixes: https://github.com/nodejs/node/issues/16141\r\n\r\nWill add a test if there are no objections to this approach.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nlib"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/340266373","html_url":"https://github.com/nodejs/node/pull/16562#issuecomment-340266373","issue_url":"https://api.github.com/repos/nodejs/node/issues/16562","id":340266373,"user":{"login":"seishun","id":988441,"avatar_url":"https://avatars1.githubusercontent.com/u/988441?v=4","gravatar_id":"","url":"https://api.github.com/users/seishun","html_url":"https://github.com/seishun","followers_url":"https://api.github.com/users/seishun/followers","following_url":"https://api.github.com/users/seishun/following{/other_user}","gists_url":"https://api.github.com/users/seishun/gists{/gist_id}","starred_url":"https://api.github.com/users/seishun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seishun/subscriptions","organizations_url":"https://api.github.com/users/seishun/orgs","repos_url":"https://api.github.com/users/seishun/repos","events_url":"https://api.github.com/users/seishun/events{/privacy}","received_events_url":"https://api.github.com/users/seishun/received_events","type":"User","site_admin":false},"created_at":"2017-10-29T14:28:55Z","updated_at":"2017-10-29T14:28:55Z","author_association":"MEMBER","body":"The failure seems unrelated."}}
{"actor":{"display_login":"seishun"}}