{"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/104709166","pull_request_review_id":25557306,"id":104709166,"diff_hunk":"@@ -163,6 +163,11 @@ public void execute(TransactionElement element, TransactionRequest request,\n             String[] names = new String[properties.size()];\n             Object[] values = new Object[properties.size()];\n \n+            //If no properties are defined for an update, there's nothing to do\n+            if (properties.isEmpty()) {\n+                return;","path":"src/wfs/src/main/java/org/geoserver/wfs/UpdateElementHandler.java","position":15,"original_position":15,"commit_id":"fa818cf2705b1efc6e62cdf99f34f5e03d9b9d73","original_commit_id":"fa818cf2705b1efc6e62cdf99f34f5e03d9b9d73","user":{"login":"jodygarnett","id":629681,"avatar_url":"https://avatars1.githubusercontent.com/u/629681?v=3","gravatar_id":"","url":"https://api.github.com/users/jodygarnett","html_url":"https://github.com/jodygarnett","followers_url":"https://api.github.com/users/jodygarnett/followers","following_url":"https://api.github.com/users/jodygarnett/following{/other_user}","gists_url":"https://api.github.com/users/jodygarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/jodygarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodygarnett/subscriptions","organizations_url":"https://api.github.com/users/jodygarnett/orgs","repos_url":"https://api.github.com/users/jodygarnett/repos","events_url":"https://api.github.com/users/jodygarnett/events{/privacy}","received_events_url":"https://api.github.com/users/jodygarnett/received_events","type":"User","site_admin":false},"body":"that seems fair","created_at":"2017-03-07T16:20:11Z","updated_at":"2017-03-07T16:20:11Z","html_url":"https://github.com/geoserver/geoserver/pull/2143#discussion_r104709166","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2143","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/104709166"},"html":{"href":"https://github.com/geoserver/geoserver/pull/2143#discussion_r104709166"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2143"}}},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/2143","id":109387614,"html_url":"https://github.com/geoserver/geoserver/pull/2143","diff_url":"https://github.com/geoserver/geoserver/pull/2143.diff","patch_url":"https://github.com/geoserver/geoserver/pull/2143.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/2143","number":2143,"state":"open","locked":false,"title":"GEOS-7883 Return empty transaction result when no properties are given","user":{"login":"dvntucker","id":15052952,"avatar_url":"https://avatars0.githubusercontent.com/u/15052952?v=3","gravatar_id":"","url":"https://api.github.com/users/dvntucker","html_url":"https://github.com/dvntucker","followers_url":"https://api.github.com/users/dvntucker/followers","following_url":"https://api.github.com/users/dvntucker/following{/other_user}","gists_url":"https://api.github.com/users/dvntucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dvntucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvntucker/subscriptions","organizations_url":"https://api.github.com/users/dvntucker/orgs","repos_url":"https://api.github.com/users/dvntucker/repos","events_url":"https://api.github.com/users/dvntucker/events{/privacy}","received_events_url":"https://api.github.com/users/dvntucker/received_events","type":"User","site_admin":false},"body":"When there's no properties given to update in the transaction there's nothing to do, so update should just return immediately.","created_at":"2017-03-07T01:28:16Z","updated_at":"2017-03-07T16:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfbc2f7af50040919e65fa8f685c3ae3d0de5b2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2143/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/2143/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/2143/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/fa818cf2705b1efc6e62cdf99f34f5e03d9b9d73","head":{"label":"dvntucker:geos_7883","ref":"geos_7883","sha":"fa818cf2705b1efc6e62cdf99f34f5e03d9b9d73","user":{"login":"dvntucker","id":15052952,"avatar_url":"https://avatars0.githubusercontent.com/u/15052952?v=3","gravatar_id":"","url":"https://api.github.com/users/dvntucker","html_url":"https://github.com/dvntucker","followers_url":"https://api.github.com/users/dvntucker/followers","following_url":"https://api.github.com/users/dvntucker/following{/other_user}","gists_url":"https://api.github.com/users/dvntucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dvntucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvntucker/subscriptions","organizations_url":"https://api.github.com/users/dvntucker/orgs","repos_url":"https://api.github.com/users/dvntucker/repos","events_url":"https://api.github.com/users/dvntucker/events{/privacy}","received_events_url":"https://api.github.com/users/dvntucker/received_events","type":"User","site_admin":false},"repo":{"id":44196373,"name":"geoserver","full_name":"dvntucker/geoserver","owner":{"login":"dvntucker","id":15052952,"avatar_url":"https://avatars0.githubusercontent.com/u/15052952?v=3","gravatar_id":"","url":"https://api.github.com/users/dvntucker","html_url":"https://github.com/dvntucker","followers_url":"https://api.github.com/users/dvntucker/followers","following_url":"https://api.github.com/users/dvntucker/following{/other_user}","gists_url":"https://api.github.com/users/dvntucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dvntucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvntucker/subscriptions","organizations_url":"https://api.github.com/users/dvntucker/orgs","repos_url":"https://api.github.com/users/dvntucker/repos","events_url":"https://api.github.com/users/dvntucker/events{/privacy}","received_events_url":"https://api.github.com/users/dvntucker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvntucker/geoserver","description":"Official GeoServer repository","fork":true,"url":"https://api.github.com/repos/dvntucker/geoserver","forks_url":"https://api.github.com/repos/dvntucker/geoserver/forks","keys_url":"https://api.github.com/repos/dvntucker/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvntucker/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvntucker/geoserver/teams","hooks_url":"https://api.github.com/repos/dvntucker/geoserver/hooks","issue_events_url":"https://api.github.com/repos/dvntucker/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/dvntucker/geoserver/events","assignees_url":"https://api.github.com/repos/dvntucker/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/dvntucker/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/dvntucker/geoserver/tags","blobs_url":"https://api.github.com/repos/dvntucker/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvntucker/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvntucker/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvntucker/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvntucker/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/dvntucker/geoserver/languages","stargazers_url":"https://api.github.com/repos/dvntucker/geoserver/stargazers","contributors_url":"https://api.github.com/repos/dvntucker/geoserver/contributors","subscribers_url":"https://api.github.com/repos/dvntucker/geoserver/subscribers","subscription_url":"https://api.github.com/repos/dvntucker/geoserver/subscription","commits_url":"https://api.github.com/repos/dvntucker/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvntucker/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvntucker/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvntucker/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvntucker/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/dvntucker/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvntucker/geoserver/merges","archive_url":"https://api.github.com/repos/dvntucker/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvntucker/geoserver/downloads","issues_url":"https://api.github.com/repos/dvntucker/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/dvntucker/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/dvntucker/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/dvntucker/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvntucker/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/dvntucker/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/dvntucker/geoserver/deployments","created_at":"2015-10-13T18:27:56Z","updated_at":"2016-01-13T19:21:30Z","pushed_at":"2017-03-07T01:21:43Z","git_url":"git://github.com/dvntucker/geoserver.git","ssh_url":"git@github.com:dvntucker/geoserver.git","clone_url":"https://github.com/dvntucker/geoserver.git","svn_url":"https://github.com/dvntucker/geoserver","homepage":"http://geoserver.org","size":163223,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoserver:master","ref":"master","sha":"f28e8463b1014581f3e496dd6e9f5eaeab8e824f","user":{"login":"geoserver","id":186522,"avatar_url":"https://avatars1.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"name":"geoserver","full_name":"geoserver/geoserver","owner":{"login":"geoserver","id":186522,"avatar_url":"https://avatars1.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/geoserver/geoserver/deployments","created_at":"2011-11-10T19:56:06Z","updated_at":"2017-03-07T11:44:37Z","pushed_at":"2017-03-07T15:23:15Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":165951,"stargazers_count":747,"watchers_count":747,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"open_issues_count":24,"forks":823,"open_issues":24,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2143"},"html":{"href":"https://github.com/geoserver/geoserver/pull/2143"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/2143"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/2143/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2143/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/2143/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/fa818cf2705b1efc6e62cdf99f34f5e03d9b9d73"}}}}
{"actor":{"display_login":"jodygarnett"}}