{"action":"opened","issue":{"url":"https://api.github.com/repos/pymc-devs/pymc3/issues/1787","repository_url":"https://api.github.com/repos/pymc-devs/pymc3","labels_url":"https://api.github.com/repos/pymc-devs/pymc3/issues/1787/labels{/name}","comments_url":"https://api.github.com/repos/pymc-devs/pymc3/issues/1787/comments","events_url":"https://api.github.com/repos/pymc-devs/pymc3/issues/1787/events","html_url":"https://github.com/pymc-devs/pymc3/issues/1787","id":207594767,"number":1787,"title":"Termination criterion for nuts","user":{"login":"aseyboldt","id":1882397,"avatar_url":"https://avatars.githubusercontent.com/u/1882397?v=3","gravatar_id":"","url":"https://api.github.com/users/aseyboldt","html_url":"https://github.com/aseyboldt","followers_url":"https://api.github.com/users/aseyboldt/followers","following_url":"https://api.github.com/users/aseyboldt/following{/other_user}","gists_url":"https://api.github.com/users/aseyboldt/gists{/gist_id}","starred_url":"https://api.github.com/users/aseyboldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseyboldt/subscriptions","organizations_url":"https://api.github.com/users/aseyboldt/orgs","repos_url":"https://api.github.com/users/aseyboldt/repos","events_url":"https://api.github.com/users/aseyboldt/events{/privacy}","received_events_url":"https://api.github.com/users/aseyboldt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-14T18:17:13Z","updated_at":"2017-02-14T18:17:13Z","closed_at":null,"body":"While reading through the stan code to double check the new implementation of multinomial sampling, I noticed that the termination criterion in stan is different to the one in pymc3. There have been recent changes in stan (https://github.com/stan-dev/stan/pull/1854), but even in the older code (\"classic nuts\") it is different. pymc3 fails to take into account the metric and always assumes a unit mass matrix. This is probably because the original paper on nuts used the standard euclidean space."}}
{"actor":{"display_login":"aseyboldt"}}