{"action":"created","issue":{"url":"https://api.github.com/repos/mweibel/facebook.ex/issues/50","repository_url":"https://api.github.com/repos/mweibel/facebook.ex","labels_url":"https://api.github.com/repos/mweibel/facebook.ex/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/mweibel/facebook.ex/issues/50/comments","events_url":"https://api.github.com/repos/mweibel/facebook.ex/issues/50/events","html_url":"https://github.com/mweibel/facebook.ex/pull/50","id":270199179,"number":50,"title":"Add credo and fix up credo recommendations","user":{"login":"paulruescher","id":911914,"avatar_url":"https://avatars2.githubusercontent.com/u/911914?v=4","gravatar_id":"","url":"https://api.github.com/users/paulruescher","html_url":"https://github.com/paulruescher","followers_url":"https://api.github.com/users/paulruescher/followers","following_url":"https://api.github.com/users/paulruescher/following{/other_user}","gists_url":"https://api.github.com/users/paulruescher/gists{/gist_id}","starred_url":"https://api.github.com/users/paulruescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulruescher/subscriptions","organizations_url":"https://api.github.com/users/paulruescher/orgs","repos_url":"https://api.github.com/users/paulruescher/repos","events_url":"https://api.github.com/users/paulruescher/events{/privacy}","received_events_url":"https://api.github.com/users/paulruescher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-01T05:35:09Z","updated_at":"2017-11-01T13:03:44Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mweibel/facebook.ex/pulls/50","html_url":"https://github.com/mweibel/facebook.ex/pull/50","diff_url":"https://github.com/mweibel/facebook.ex/pull/50.diff","patch_url":"https://github.com/mweibel/facebook.ex/pull/50.patch"},"body":"# Status\r\n**READY**\r\n\r\n# Description\r\nAdding credo to the project. \r\n\r\nSome of the changes are a bit weird. For example, credo expects that a raw value starts a pipe, so you'll see scenarios like https://github.com/mweibel/facebook.ex/compare/master...paulruescher:add-credo?expand=1#diff-9944d4d916ca0f3be718c57f915ae4d6R298\r\n\r\nOtherwise, things seem a bit more clear already.\r\n\r\nTake a look at https://github.com/rrrene/credo#configuration if you're interested in seeing the configs we could setup. I'm generally OK with the defaults for now.\r\n\r\n# Considerations\r\nCan we get `MIX_ENV=test mix quality` run in travis now? Usually I'd just add to the `.travis.yml` file, but I'm not sure how you have things setup at the moment."},"comment":{"url":"https://api.github.com/repos/mweibel/facebook.ex/issues/comments/341100224","html_url":"https://github.com/mweibel/facebook.ex/pull/50#issuecomment-341100224","issue_url":"https://api.github.com/repos/mweibel/facebook.ex/issues/50","id":341100224,"user":{"login":"paulruescher","id":911914,"avatar_url":"https://avatars2.githubusercontent.com/u/911914?v=4","gravatar_id":"","url":"https://api.github.com/users/paulruescher","html_url":"https://github.com/paulruescher","followers_url":"https://api.github.com/users/paulruescher/followers","following_url":"https://api.github.com/users/paulruescher/following{/other_user}","gists_url":"https://api.github.com/users/paulruescher/gists{/gist_id}","starred_url":"https://api.github.com/users/paulruescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulruescher/subscriptions","organizations_url":"https://api.github.com/users/paulruescher/orgs","repos_url":"https://api.github.com/users/paulruescher/repos","events_url":"https://api.github.com/users/paulruescher/events{/privacy}","received_events_url":"https://api.github.com/users/paulruescher/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T13:03:44Z","updated_at":"2017-11-01T13:03:44Z","author_association":"COLLABORATOR","body":"yeah, I agree that they looked a little off heh. I'll look into changing up the `@types` or maybe some other alternative"}}
{"actor":{"display_login":"paulruescher"}}