{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/13315","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/13315/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/13315/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/13315/events","html_url":"https://github.com/openshift/origin/pull/13315","id":212865208,"number":13315,"title":"BZ 1388319 handle -1 in maxScheduledImageImportsPerMinute","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars1.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-08T21:41:16Z","updated_at":"2017-03-15T15:21:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/13315","html_url":"https://github.com/openshift/origin/pull/13315","diff_url":"https://github.com/openshift/origin/pull/13315.diff","patch_url":"https://github.com/openshift/origin/pull/13315.patch"},"body":"master panics when setting -1 in maxScheduledImageImportsPerMinute though it should be handled.  It is specific, validated value and [was documented as unlimited](https://github.com/openshift/openshift-docs/pull/3638/files).\r\n\r\nThis checks for -1 and sets the limiter to the `NewFakeAlwaysRateLimiter`.  This name is confusing but it looks like it is the one that won't block on accept and is used in [tests to turn off limiting](https://github.com/pweil-/origin/blob/029902f5abf7e20d9bbec2dbe81affaef060fa27/vendor/k8s.io/kubernetes/test/e2e/service_latency.go#L71-L71)\r\n\r\n@mfojtik @smarterclayton WDYT?  The other option, I suppose, is to remove the validation and just have users set this to a very high value themselves."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/286775704","html_url":"https://github.com/openshift/origin/pull/13315#issuecomment-286775704","issue_url":"https://api.github.com/repos/openshift/origin/issues/13315","id":286775704,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2017-03-15T15:21:00Z","updated_at":"2017-03-15T15:21:00Z","body":"LGTM [merge]"}}
{"actor":{"display_login":"smarterclayton"}}