{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/3874","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/3874/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/3874/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/3874/events","html_url":"https://github.com/serverless/serverless/issues/3874","id":239381917,"number":3874,"title":"Fix dev dependency exclusion bug when too many node modules are used","user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars0.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"labels":[{"id":417327117,"url":"https://api.github.com/repos/serverless/serverless/labels/kind/bug","name":"kind/bug","color":"FF8C94","default":false},{"id":511594798,"url":"https://api.github.com/repos/serverless/serverless/labels/status/help-wanted","name":"status/help-wanted","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/serverless/serverless/milestones/33","html_url":"https://github.com/serverless/serverless/milestone/33","labels_url":"https://api.github.com/repos/serverless/serverless/milestones/33/labels","id":2595305,"number":33,"title":"1.18","description":"","creator":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars0.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2017-06-21T07:25:08Z","updated_at":"2017-06-29T09:40:44Z","due_on":"2017-07-19T07:00:00Z","closed_at":null},"comments":2,"created_at":"2017-06-29T06:52:03Z","updated_at":"2017-06-30T12:00:44Z","closed_at":null,"body":"# This is a Bug Report\r\n\r\n## Description\r\n\r\nRight now we do a glob exclude of the whole `node_modules` directory and include only prod dependencies by using `npm ls` to identify them and a glob to re-include them.\r\n\r\nHowever there's a bug with the maximum number of characters the buffer can hold.\r\n\r\nFurthermore we should switch the behavior. We should list the dev dependencies and exclude them (while still including the whole `node_modules` directory) to ensure that the whole `node_modules` directory is still in included. Even if the command fails.\r\n\r\n---\r\n\r\n**Quick fix / other addition**\r\n\r\nAdd a config parameter which allows people to opt out of this feature.\r\n\r\n---\r\n\r\nRelated #3827 "},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/312249292","html_url":"https://github.com/serverless/serverless/issues/3874#issuecomment-312249292","issue_url":"https://api.github.com/repos/serverless/serverless/issues/3874","id":312249292,"user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars0.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"created_at":"2017-06-30T12:00:44Z","updated_at":"2017-06-30T12:00:44Z","body":"Just cross-referencing @arabold comment from the PR here: https://github.com/serverless/serverless/pull/3737#issuecomment-312124143\r\n\r\nThanks for looking into it 👍 "}}
{"actor":{"display_login":"pmuens"}}