{"push_id":1880214294,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"8034b9d819eb941c7df08bdade6baa0551ccc177","before":"69a7d57c3fdaeecd3b7ec8f98ba4a02b5438b8c3","commits":[{"sha":"8034b9d819eb941c7df08bdade6baa0551ccc177","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Don't require a device be registered in Almanac to do cluster init/resync steps\n\nSummary:\nFixes T12893. See also PHI15. This is complicated but:\n\n  - In the documentation, we say \"register your web devices with Almanac\". We do this ourselves on `secure` and in the production Phacility cluster.\n  - We don't actually require you to do this, don't detect that you didn't, and there's no actual reason you need to.\n  - If you don't register your \"web\" devices, the only bad thing that really happens is that creating repositories skips version initialization, creating the bug in T12893. This process does not actually require the devices be registered, but the code currently just kind of fails silently if they aren't.\n\nInstead, just move forward on these init/resync phases even if the device isn't registered. These steps are safe to run from unregistered hosts since they just wipe the whole table and don't affect specific devices.\n\nIf this sticks, I'll probably update the docs to not tell you to register `web` devices, or at least add \"Optionally, ...\". I don't think there's any future reason we'd need them to be registered.\n\nTest Plan:\nThis is a bit tough to test without multiple hosts, but I added this piece of code to `AlmanacKeys` so we'd pretend to be a nameless \"web\" device when creating a repository:\n\n```\nif ($_REQUEST['__path__'] == '/diffusion/edit/form/default/') {\n  return null;\n}\n```\n\nThen I created some Git repositories. Before the patch, they came up with `-` versions (no version information). After the patch, they came up with `0` versions (correctly initialized).\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T12893\n\nDifferential Revision: https://secure.phabricator.com/D18273","distinct":true,"url":"https://api.github.com/repos/phacility/phabricator/commits/8034b9d819eb941c7df08bdade6baa0551ccc177"}]}
{"actor":{"display_login":"epriestley"}}