{"action":"created","issue":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/1748","repository_url":"https://api.github.com/repos/awesomeWM/awesome","labels_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1748/labels{/name}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1748/comments","events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1748/events","html_url":"https://github.com/awesomeWM/awesome/pull/1748","id":223622724,"number":1748,"title":"Fix maximize again","user":{"login":"Elv13","id":340384,"avatar_url":"https://avatars3.githubusercontent.com/u/340384?v=3","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1","html_url":"https://github.com/awesomeWM/awesome/milestone/1","labels_url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1/labels","id":1069592,"number":1,"title":"next: pull requests to be merged soon","description":"Pending pull requests to be merged soon.","creator":{"login":"blueyed","id":9766,"avatar_url":"https://avatars2.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":569,"state":"open","created_at":"2015-04-15T22:58:10Z","updated_at":"2017-05-25T13:15:38Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2017-04-23T09:04:17Z","updated_at":"2017-05-25T13:30:46Z","closed_at":"2017-05-23T21:56:30Z","pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/1748","html_url":"https://github.com/awesomeWM/awesome/pull/1748","diff_url":"https://github.com/awesomeWM/awesome/pull/1748.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/1748.patch"},"body":"Fix 2 bugs, introduce a lesser one.\r\n\r\nPrevent `max_h` and `max_v` to be set by the atoms and bypass the safeguards. <s>Also starts to ignore requests *from the clients* after `manage` has been called.</s> There is some `request::geometry` signals if the user want to honor them, but it's their problem, not mine."},"comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments/304010490","html_url":"https://github.com/awesomeWM/awesome/pull/1748#issuecomment-304010490","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1748","id":304010490,"user":{"login":"psychon","id":89482,"avatar_url":"https://avatars0.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"created_at":"2017-05-25T13:30:45Z","updated_at":"2017-05-25T13:30:45Z","body":"> Should we move this to a new issue?\r\n\r\nI think I figured it out. Let's start piece-wise:\r\n\r\n> why are dialogs floating by default?\r\n\r\n\"Old\" awesome version: https://github.com/awesomeWM/awesome/blob/088584c8120ba3c93a40bfe8017bfcfc27b6fb82/lib/awful/client.lua#L670\r\n\"Current\" awesome version: Well, it doesn't have the above so this is why something breaks. To be more specific: If https://github.com/awesomeWM/awesome/blob/c1bcad5f5e1d8911653cd3c84ba56aa16d74034d/lib/awful/client.lua#L678-L694 never runs, then we do not initialize the implicitly floating state correctly.\r\n\r\nProposed patch: Also connect to the \"manage\" signal here: https://github.com/awesomeWM/awesome/blob/c1bcad5f5e1d8911653cd3c84ba56aa16d74034d/lib/awful/client.lua#L696-L701\r\n\r\nNo idea why you can only sometimes reproduce this with zenity. Does it change its window type or size hints sometimes a short while after becoming visible / before becoming visible? (=Is there a race between awesome and zenity?)\r\n\r\nLet's come back to the original question:\r\n\r\n> Should we move this to a new issue?\r\n\r\nFeel free. But you can also feel free to test the above patch idea and submit it as a pull request if it works."}}
{"actor":{"display_login":"psychon"}}