{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/158592767","pull_request_review_id":85433057,"id":158592767,"diff_hunk":"@@ -1161,6 +1165,11 @@ extern (C++) abstract class Type : RootObject\n         return true;\n     }\n \n+    bool isAmbiguous()","path":"src/dmd/mtype.d","position":31,"original_position":31,"commit_id":"60f246179c3b8f8707d2cf7103bdba01d7be6b8c","original_commit_id":"60f246179c3b8f8707d2cf7103bdba01d7be6b8c","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"body":"Please add a DDoc header like that done for `isAssignable()`","created_at":"2017-12-24T03:05:19Z","updated_at":"2017-12-24T03:07:19Z","html_url":"https://github.com/dlang/dmd/pull/7503#discussion_r158592767","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/7503","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/158592767"},"html":{"href":"https://github.com/dlang/dmd/pull/7503#discussion_r158592767"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7503"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7503","id":159983388,"html_url":"https://github.com/dlang/dmd/pull/7503","diff_url":"https://github.com/dlang/dmd/pull/7503.diff","patch_url":"https://github.com/dlang/dmd/pull/7503.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7503","number":7503,"state":"open","locked":false,"title":"Add Type.tambig and make ready to use.","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"body":"First commit of #2130.  I've checked the PR, and fixing all mentioned issues (1983, 7322, 7549, 8868, 9027) depends on this first if we are to take on the original patch.\r\n\r\nI've replaced the handling of `isAmbiguous` in dmangle and hdrgen with asserts, as I do not know whether they are reachable.  See that the type is only used for generating errors, I would suspect not.","created_at":"2017-12-23T23:46:26Z","updated_at":"2017-12-24T03:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b95c6414888f38aabeaf0f7b0603a2e0044a08d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/7503/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/7503/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7503/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/60f246179c3b8f8707d2cf7103bdba01d7be6b8c","head":{"label":"ibuclaw:tambig","ref":"tambig","sha":"60f246179c3b8f8707d2cf7103bdba01d7be6b8c","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"repo":{"id":1653829,"name":"dmd","full_name":"ibuclaw/dmd","owner":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibuclaw/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/ibuclaw/dmd","forks_url":"https://api.github.com/repos/ibuclaw/dmd/forks","keys_url":"https://api.github.com/repos/ibuclaw/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibuclaw/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibuclaw/dmd/teams","hooks_url":"https://api.github.com/repos/ibuclaw/dmd/hooks","issue_events_url":"https://api.github.com/repos/ibuclaw/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/ibuclaw/dmd/events","assignees_url":"https://api.github.com/repos/ibuclaw/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/ibuclaw/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/ibuclaw/dmd/tags","blobs_url":"https://api.github.com/repos/ibuclaw/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibuclaw/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibuclaw/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibuclaw/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibuclaw/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/ibuclaw/dmd/languages","stargazers_url":"https://api.github.com/repos/ibuclaw/dmd/stargazers","contributors_url":"https://api.github.com/repos/ibuclaw/dmd/contributors","subscribers_url":"https://api.github.com/repos/ibuclaw/dmd/subscribers","subscription_url":"https://api.github.com/repos/ibuclaw/dmd/subscription","commits_url":"https://api.github.com/repos/ibuclaw/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibuclaw/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibuclaw/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibuclaw/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibuclaw/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/ibuclaw/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibuclaw/dmd/merges","archive_url":"https://api.github.com/repos/ibuclaw/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibuclaw/dmd/downloads","issues_url":"https://api.github.com/repos/ibuclaw/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/ibuclaw/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/ibuclaw/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/ibuclaw/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibuclaw/dmd/labels{/name}","releases_url":"https://api.github.com/repos/ibuclaw/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/ibuclaw/dmd/deployments","created_at":"2011-04-23T15:21:22Z","updated_at":"2017-08-09T09:02:56Z","pushed_at":"2017-12-23T23:41:29Z","git_url":"git://github.com/ibuclaw/dmd.git","ssh_url":"git@github.com:ibuclaw/dmd.git","clone_url":"https://github.com/ibuclaw/dmd.git","svn_url":"https://github.com/ibuclaw/dmd","homepage":"d-programming-language.org","size":75755,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"b1a9fe1d398382e067cef89ca24adf5bff69a2d8","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2017-12-23T13:19:07Z","pushed_at":"2017-12-24T02:18:38Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":80652,"stargazers_count":1716,"watchers_count":1716,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":432,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":432,"open_issues":153,"watchers":1716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7503"},"html":{"href":"https://github.com/dlang/dmd/pull/7503"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/7503"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/7503/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7503/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7503/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/60f246179c3b8f8707d2cf7103bdba01d7be6b8c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JinShil"}}