{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/12210","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/12210/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/12210/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/12210/events","html_url":"https://github.com/grpc/grpc/pull/12210","id":250779807,"number":12210,"title":"Run a local DNS server in run_tests and add c-ares tests with it","user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"labels":[{"id":166332702,"url":"https://api.github.com/repos/grpc/grpc/labels/area/core","name":"area/core","color":"efdb40","default":false},{"id":170781264,"url":"https://api.github.com/repos/grpc/grpc/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":180840978,"url":"https://api.github.com/repos/grpc/grpc/labels/disposition/DO%20NOT%20MERGE","name":"disposition/DO NOT MERGE","color":"5319e7","default":false},{"id":166437084,"url":"https://api.github.com/repos/grpc/grpc/labels/infra/buildgen","name":"infra/buildgen","color":"a36cd1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":60,"created_at":"2017-08-16T22:35:54Z","updated_at":"2017-09-12T20:15:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/12210","html_url":"https://github.com/grpc/grpc/pull/12210","diff_url":"https://github.com/grpc/grpc/pull/12210.diff","patch_url":"https://github.com/grpc/grpc/pull/12210.patch"},"body":"Starts running a local DNS server (using `dnslib`) in the same process as the port server. It also adds a revised version of the c-ares test in https://github.com/grpc/grpc/pull/12010 to run against it, and  fixes a couple of memory leaks within the `grpc_cares_wrapper.c`.\r\n\r\nThis keeps `resolver_test_record_groups.yaml` as the source of truth for all test records.\r\n\r\nTo run the tests added here:\r\n`tools/run_tests/run_tests.py -l c++ -r resolver_component_test`\r\n\r\nPlanning on creating a follow-up PR that uses what's added here for running GCE DNS integration tests (as a revised version of https://github.com/grpc/grpc/pull/12010)\r\n\r\n\r\n-------------- update: ----------------\r\n\r\n\r\n* fixed a bug in that the this PR's port server's `/quitquitquit` handler would still leave the port server process running. On shared resource workers including the jenkins mac and jenkins windows workers, this bug brought up a larger issue with this PR, in that changes to the set of DNS test records must always be backwards compatible as long as tests are sharing resources (IIC while there are still mac/windows tests on jenkins)\r\n\r\n(note all workers right now are ok; non-docker workers failed to start the faulty port server in this PR because `dnslib` wasn't present)\r\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/328971572","html_url":"https://github.com/grpc/grpc/pull/12210#issuecomment-328971572","issue_url":"https://api.github.com/repos/grpc/grpc/issues/12210","id":328971572,"user":{"login":"grpc-jenkins","id":12722905,"avatar_url":"https://avatars3.githubusercontent.com/u/12722905?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc-jenkins","html_url":"https://github.com/grpc-jenkins","followers_url":"https://api.github.com/users/grpc-jenkins/followers","following_url":"https://api.github.com/users/grpc-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/grpc-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc-jenkins/subscriptions","organizations_url":"https://api.github.com/users/grpc-jenkins/orgs","repos_url":"https://api.github.com/users/grpc-jenkins/repos","events_url":"https://api.github.com/users/grpc-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/grpc-jenkins/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T20:15:47Z","updated_at":"2017-09-12T20:15:47Z","author_association":"NONE","body":"```\n[microbenchmarks] Performance differences noted:\nBenchmark                                                              nows_per_iteration    real_time\n---------------------------------------------------------------------  --------------------  -----------\nBM_PumpStreamServerToClient<SockPair>/2M                                                     +6%\nBM_StreamingPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/16M/1  -5%\n```"}}
{"actor":{"display_login":"grpc-jenkins"}}