{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/components/pulls/comments/136791626","pull_request_review_id":60378438,"id":136791626,"diff_hunk":"@@ -13,16 +14,15 @@\n \r\n \t<dependencies>\r\n \t\t<dependency>\r\n+\t\t\t<groupId>org.json</groupId>\r","path":"core/components-common-oauth/pom.xml","position":11,"original_position":11,"commit_id":"3bfa089e9fd1eaaa6cf629fd5933cf4c1b48da4c","original_commit_id":"3bfa089e9fd1eaaa6cf629fd5933cf4c1b48da4c","user":{"login":"sgandon","id":783286,"avatar_url":"https://avatars1.githubusercontent.com/u/783286?v=4","gravatar_id":"","url":"https://api.github.com/users/sgandon","html_url":"https://github.com/sgandon","followers_url":"https://api.github.com/users/sgandon/followers","following_url":"https://api.github.com/users/sgandon/following{/other_user}","gists_url":"https://api.github.com/users/sgandon/gists{/gist_id}","starred_url":"https://api.github.com/users/sgandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgandon/subscriptions","organizations_url":"https://api.github.com/users/sgandon/orgs","repos_url":"https://api.github.com/users/sgandon/repos","events_url":"https://api.github.com/users/sgandon/events{/privacy}","received_events_url":"https://api.github.com/users/sgandon/received_events","type":"User","site_admin":false},"body":"I am not very fond of using another json librairy, daikon already depends on 2 json librairies, json-io and jackson so please could you use those libs ?","created_at":"2017-09-04T10:26:34Z","updated_at":"2017-09-04T10:58:51Z","html_url":"https://github.com/Talend/components/pull/930#discussion_r136791626","pull_request_url":"https://api.github.com/repos/Talend/components/pulls/930","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/comments/136791626"},"html":{"href":"https://github.com/Talend/components/pull/930#discussion_r136791626"},"pull_request":{"href":"https://api.github.com/repos/Talend/components/pulls/930"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/components/pulls/930","id":136431470,"html_url":"https://github.com/Talend/components/pull/930","diff_url":"https://github.com/Talend/components/pull/930.diff","patch_url":"https://github.com/Talend/components/pull/930.patch","issue_url":"https://api.github.com/repos/Talend/components/issues/930","number":930,"state":"open","locked":false,"title":"feat(TDI-39278): refactor common auth","user":{"login":"akhabali","id":25590305,"avatar_url":"https://avatars3.githubusercontent.com/u/25590305?v=4","gravatar_id":"","url":"https://api.github.com/users/akhabali","html_url":"https://github.com/akhabali","followers_url":"https://api.github.com/users/akhabali/followers","following_url":"https://api.github.com/users/akhabali/following{/other_user}","gists_url":"https://api.github.com/users/akhabali/gists{/gist_id}","starred_url":"https://api.github.com/users/akhabali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhabali/subscriptions","organizations_url":"https://api.github.com/users/akhabali/orgs","repos_url":"https://api.github.com/users/akhabali/repos","events_url":"https://api.github.com/users/akhabali/events{/privacy}","received_events_url":"https://api.github.com/users/akhabali/received_events","type":"User","site_admin":false},"body":"\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nhttps://jira.talendforge.org/browse/TDI-39278\r\n\r\n\r\n**What is the new behavior?**\r\n- Add jwt with assertion flow (a flow adapted for server to server communication)\r\n- Integrate the flow for salesforce\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n- [ ] The commit message follows Talend standard\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [ ] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [ ] Bugfix\r\n- [x] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n","created_at":"2017-08-18T08:55:43Z","updated_at":"2017-09-04T10:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6931e53e9898fba6e687f3daa83902b5649b8680","assignee":{"login":"akhabali","id":25590305,"avatar_url":"https://avatars3.githubusercontent.com/u/25590305?v=4","gravatar_id":"","url":"https://api.github.com/users/akhabali","html_url":"https://github.com/akhabali","followers_url":"https://api.github.com/users/akhabali/followers","following_url":"https://api.github.com/users/akhabali/following{/other_user}","gists_url":"https://api.github.com/users/akhabali/gists{/gist_id}","starred_url":"https://api.github.com/users/akhabali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhabali/subscriptions","organizations_url":"https://api.github.com/users/akhabali/orgs","repos_url":"https://api.github.com/users/akhabali/repos","events_url":"https://api.github.com/users/akhabali/events{/privacy}","received_events_url":"https://api.github.com/users/akhabali/received_events","type":"User","site_admin":false},"assignees":[{"login":"akhabali","id":25590305,"avatar_url":"https://avatars3.githubusercontent.com/u/25590305?v=4","gravatar_id":"","url":"https://api.github.com/users/akhabali","html_url":"https://github.com/akhabali","followers_url":"https://api.github.com/users/akhabali/followers","following_url":"https://api.github.com/users/akhabali/following{/other_user}","gists_url":"https://api.github.com/users/akhabali/gists{/gist_id}","starred_url":"https://api.github.com/users/akhabali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhabali/subscriptions","organizations_url":"https://api.github.com/users/akhabali/orgs","repos_url":"https://api.github.com/users/akhabali/repos","events_url":"https://api.github.com/users/akhabali/events{/privacy}","received_events_url":"https://api.github.com/users/akhabali/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/components/pulls/930/commits","review_comments_url":"https://api.github.com/repos/Talend/components/pulls/930/comments","review_comment_url":"https://api.github.com/repos/Talend/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/components/issues/930/comments","statuses_url":"https://api.github.com/repos/Talend/components/statuses/3bfa089e9fd1eaaa6cf629fd5933cf4c1b48da4c","head":{"label":"Talend:akhabali/oauth-server-flows","ref":"akhabali/oauth-server-flows","sha":"3bfa089e9fd1eaaa6cf629fd5933cf4c1b48da4c","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2017-08-26T17:54:40Z","pushed_at":"2017-09-01T16:26:57Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":14422,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":15,"forks":34,"open_issues":15,"watchers":15,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"66322bc2a6cec3d447dfaed242e2e89c31b26af5","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2017-08-26T17:54:40Z","pushed_at":"2017-09-01T16:26:57Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":14422,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":15,"forks":34,"open_issues":15,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/930"},"html":{"href":"https://github.com/Talend/components/pull/930"},"issue":{"href":"https://api.github.com/repos/Talend/components/issues/930"},"comments":{"href":"https://api.github.com/repos/Talend/components/issues/930/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/components/pulls/930/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/components/pulls/930/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/components/statuses/3bfa089e9fd1eaaa6cf629fd5933cf4c1b48da4c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sgandon"}}