{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1389","repository_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1389/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1389/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1389/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1389","id":233454485,"number":1389,"title":"Remove dropq_utils results function and use utils results function","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars2.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"labels":[{"id":414455048,"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-04T19:33:04Z","updated_at":"2017-06-04T19:37:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1389","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1389","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1389.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1389.patch"},"body":"This pull request removes the redundant `results` function in `dropq_utils.py` and uses in the dropq logic the `results` function in `taxcalc/utils.py` instead.  The duplicate function dates from the time when dropq logic was in a separate repository.\r\n\r\nThere is no change in tax logic or results."},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/306061983","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1389#issuecomment-306061983","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1389","id":306061983,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars3.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-06-04T19:37:16Z","updated_at":"2017-06-04T19:37:16Z","body":"# [Codecov](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=h1) Report\n> Merging [#1389](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=desc) into [master](https://codecov.io/gh/open-source-economics/Tax-Calculator/commit/0a7394244ca7df87e47b1430f3d9d68160922564?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389/graphs/tree.svg?width=650&height=150&src=pr&token=KqtTvRSNjQ)](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1389      +/-   ##\n==========================================\n- Coverage   99.64%   99.64%   -0.01%     \n==========================================\n  Files          38       38              \n  Lines        2824     2819       -5     \n==========================================\n- Hits         2814     2809       -5     \n  Misses         10       10\n```\n\n\n| [Impacted Files](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [taxcalc/dropq/dropq\\_utils.py](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=tree#diff-dGF4Y2FsYy9kcm9wcS9kcm9wcV91dGlscy5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [taxcalc/dropq/dropq.py](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=tree#diff-dGF4Y2FsYy9kcm9wcS9kcm9wcS5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=footer). Last update [0a73942...9404b5b](https://codecov.io/gh/open-source-economics/Tax-Calculator/pull/1389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}