{"action":"created","comment":{"url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/comments/149592371","pull_request_review_id":75008340,"id":149592371,"diff_hunk":"@@ -117,25 +138,49 @@ function(PROTOBUF_CATKIN_GENERATE_CPP2 BASE_PATH SRCS HDRS)\n       OUTPUT \"${OUTPUT_BASE_FILE_NAME}.pb.cc\"\n              \"${OUTPUT_BASE_FILE_NAME}.pb.h\"\n              \"${PROTO_GENERATED_HEADERS_INSTALL_DIR}/${FIL_WE}.pb.h\"\n-             \"${PROTO_FILE_INSTALL_DIR}/${PROJECT_NAME}/${FIL_WE}.proto\"\n+             \"${PROTO_SHARE_FOLDER}/${FIL_WE}.proto\"\n       COMMAND  \"${CATKIN_DEVEL_PREFIX}/bin/protoc\"\n-      ARGS --cpp_out  ${OUTPUT_FOLDER_BASE} ${_protobuf_include_path} ${ABS_FIL}\n+      ARGS --cpp_out ${OUTPUT_FOLDER_BASE} ${PYTHON_PROTOC_ARG_FLAG} ${PYTHON_PROTOC_ARG_VALUE} ${_protobuf_include_path} ${ABS_FIL}\n       COMMAND ${CMAKE_COMMAND} -E copy\n               \"${OUTPUT_BASE_FILE_NAME}.pb.h\"\n               \"${PROTO_GENERATED_HEADERS_INSTALL_DIR}/${FIL_REL_DIR}/${FIL_WE}.pb.h\"\n       COMMAND ${CMAKE_COMMAND} -E copy\n               ${ABS_FIL}\n-              \"${PROTO_FILE_INSTALL_DIR}/${FIL_REL_DIR}/${FIL_WE}.proto\"\n+              \"${PROTO_SHARE_FOLDER}/${FIL_WE}.proto\"\n       DEPENDS ${ABS_FIL}\n-      COMMENT \"Running C++ protocol buffer compiler on ${FIL}\"\n-      VERBATIM )\n+      COMMENT \"Running C++${PROTOC_PYTHON_COMMENT} protocol buffer compiler on ${FIL}.\"\n+      VERBATIM)\n   endforeach()\n \n   set_source_files_properties(${${SRCS}} ${${HDRS}} PROPERTIES GENERATED TRUE)\n   set(${SRCS} ${${SRCS}} PARENT_SCOPE)\n-  set(${HDRS} ${${HDRS}} PARENT_SCOPE)\n-endfunction()\n+  set(${HDRS} ${${HDRS}} PARENT_SCOPE)  \n \n+\n+  if (${PROTOBUF_COMPILE_PYTHON})\n+    # The filepath of the Python package init file.\n+    set(PYTHON_INIT_FILEPATH \"${PYTHON_PACKAGE_PATH}/__init__.py\")\n+    # Clear the __init__.py file first.\n+    add_custom_target(clear_init ALL\n+      COMMAND ${CMAKE_COMMAND} -E remove ${PYTHON_INIT_FILEPATH}","path":"cmake/protobuf-generate-cpp.cmake.in","position":70,"original_position":70,"commit_id":"427d82fd6dc516e6f5f768f59652e837a9fdc43f","original_commit_id":"427d82fd6dc516e6f5f768f59652e837a9fdc43f","user":{"login":"eggerk","id":4958205,"avatar_url":"https://avatars0.githubusercontent.com/u/4958205?v=4","gravatar_id":"","url":"https://api.github.com/users/eggerk","html_url":"https://github.com/eggerk","followers_url":"https://api.github.com/users/eggerk/followers","following_url":"https://api.github.com/users/eggerk/following{/other_user}","gists_url":"https://api.github.com/users/eggerk/gists{/gist_id}","starred_url":"https://api.github.com/users/eggerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggerk/subscriptions","organizations_url":"https://api.github.com/users/eggerk/orgs","repos_url":"https://api.github.com/users/eggerk/repos","events_url":"https://api.github.com/users/eggerk/events{/privacy}","received_events_url":"https://api.github.com/users/eggerk/received_events","type":"User","site_admin":false},"body":"won't this break python packages?","created_at":"2017-11-08T07:35:05Z","updated_at":"2017-11-08T07:54:16Z","html_url":"https://github.com/ethz-asl/protobuf_catkin/pull/25#discussion_r149592371","pull_request_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/comments/149592371"},"html":{"href":"https://github.com/ethz-asl/protobuf_catkin/pull/25#discussion_r149592371"},"pull_request":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25","id":151179913,"html_url":"https://github.com/ethz-asl/protobuf_catkin/pull/25","diff_url":"https://github.com/ethz-asl/protobuf_catkin/pull/25.diff","patch_url":"https://github.com/ethz-asl/protobuf_catkin/pull/25.patch","issue_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/25","number":25,"state":"open","locked":false,"title":"Feature/python support","user":{"login":"mbuerki","id":4069772,"avatar_url":"https://avatars2.githubusercontent.com/u/4069772?v=4","gravatar_id":"","url":"https://api.github.com/users/mbuerki","html_url":"https://github.com/mbuerki","followers_url":"https://api.github.com/users/mbuerki/followers","following_url":"https://api.github.com/users/mbuerki/following{/other_user}","gists_url":"https://api.github.com/users/mbuerki/gists{/gist_id}","starred_url":"https://api.github.com/users/mbuerki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbuerki/subscriptions","organizations_url":"https://api.github.com/users/mbuerki/orgs","repos_url":"https://api.github.com/users/mbuerki/repos","events_url":"https://api.github.com/users/mbuerki/events{/privacy}","received_events_url":"https://api.github.com/users/mbuerki/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-07T17:35:54Z","updated_at":"2017-11-08T07:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d51915a5f8e9be8e1229445af7f2e39058a7affd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/25/comments","statuses_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/statuses/427d82fd6dc516e6f5f768f59652e837a9fdc43f","head":{"label":"ethz-asl:feature/python_support","ref":"feature/python_support","sha":"427d82fd6dc516e6f5f768f59652e837a9fdc43f","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":19398030,"name":"protobuf_catkin","full_name":"ethz-asl/protobuf_catkin","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/protobuf_catkin","description":"A catkin wrapper for Google protocol buffers","fork":false,"url":"https://api.github.com/repos/ethz-asl/protobuf_catkin","forks_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/forks","keys_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/teams","hooks_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/events","assignees_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/tags","blobs_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/subscription","commits_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/merges","archive_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/downloads","issues_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/deployments","created_at":"2014-05-03T07:30:32Z","updated_at":"2017-10-19T14:03:32Z","pushed_at":"2017-11-07T17:35:55Z","git_url":"git://github.com/ethz-asl/protobuf_catkin.git","ssh_url":"git@github.com:ethz-asl/protobuf_catkin.git","clone_url":"https://github.com/ethz-asl/protobuf_catkin.git","svn_url":"https://github.com/ethz-asl/protobuf_catkin","homepage":null,"size":30,"stargazers_count":2,"watchers_count":2,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"ae07b372a92936d6ad05b55e3b9c48e9ae9ae528","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":19398030,"name":"protobuf_catkin","full_name":"ethz-asl/protobuf_catkin","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/protobuf_catkin","description":"A catkin wrapper for Google protocol buffers","fork":false,"url":"https://api.github.com/repos/ethz-asl/protobuf_catkin","forks_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/forks","keys_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/teams","hooks_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/events","assignees_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/tags","blobs_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/subscription","commits_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/merges","archive_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/downloads","issues_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/protobuf_catkin/deployments","created_at":"2014-05-03T07:30:32Z","updated_at":"2017-10-19T14:03:32Z","pushed_at":"2017-11-07T17:35:55Z","git_url":"git://github.com/ethz-asl/protobuf_catkin.git","ssh_url":"git@github.com:ethz-asl/protobuf_catkin.git","clone_url":"https://github.com/ethz-asl/protobuf_catkin.git","svn_url":"https://github.com/ethz-asl/protobuf_catkin","homepage":null,"size":30,"stargazers_count":2,"watchers_count":2,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25"},"html":{"href":"https://github.com/ethz-asl/protobuf_catkin/pull/25"},"issue":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/25"},"comments":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/protobuf_catkin/statuses/427d82fd6dc516e6f5f768f59652e837a9fdc43f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eggerk"}}