{"action":"created","issue":{"url":"https://api.github.com/repos/lostromb/concentus/issues/17","repository_url":"https://api.github.com/repos/lostromb/concentus","labels_url":"https://api.github.com/repos/lostromb/concentus/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/lostromb/concentus/issues/17/comments","events_url":"https://api.github.com/repos/lostromb/concentus/issues/17/events","html_url":"https://github.com/lostromb/concentus/pull/17","id":276512542,"number":17,"title":"Migrate to SDK-based csproj files","user":{"login":"Thealexbarney","id":601603,"avatar_url":"https://avatars0.githubusercontent.com/u/601603?v=4","gravatar_id":"","url":"https://api.github.com/users/Thealexbarney","html_url":"https://github.com/Thealexbarney","followers_url":"https://api.github.com/users/Thealexbarney/followers","following_url":"https://api.github.com/users/Thealexbarney/following{/other_user}","gists_url":"https://api.github.com/users/Thealexbarney/gists{/gist_id}","starred_url":"https://api.github.com/users/Thealexbarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thealexbarney/subscriptions","organizations_url":"https://api.github.com/users/Thealexbarney/orgs","repos_url":"https://api.github.com/users/Thealexbarney/repos","events_url":"https://api.github.com/users/Thealexbarney/events{/privacy}","received_events_url":"https://api.github.com/users/Thealexbarney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-24T04:30:27Z","updated_at":"2017-12-02T03:32:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lostromb/concentus/pulls/17","html_url":"https://github.com/lostromb/concentus/pull/17","diff_url":"https://github.com/lostromb/concentus/pull/17.diff","patch_url":"https://github.com/lostromb/concentus/pull/17.patch"},"body":"This migrates all csproj files except ConcentusDemo to the newer csproj format.\r\n\r\n- These projects can now be build with the cross-platform dotnet CLI.\r\n- NuGet packages are automatically generated by the build system.\r\n- There are now only two library projects: `Concentus` and `Concentus.Unsafe`. Both of these projects target multiple frameworks.\r\n- I also fixed a few warnings, mostly related to XML documentation.\r\n\r\nThere are a couple things to look over. Let me know if I need to change any of these.\r\n\r\nI saw your release notes about removing the net35 build from the latest NuGet package. I'm assuming that was because .NET Framework targets would choose the net35 build over the netstandard1.0 build. I added a net45 build so that wouldn't be an issue, and readded the net35 build.\r\n\r\nI did my best to make sure all the build outputs were the same after the transition, but there's one difference with the .nuspec file. Csproj files don't have an option to set the summary in the nuspec file. (NuGet/Home#4587) I don't know if that's a problem or not.\r\n\r\n~I had to remove the PCL build. If the cross-platform MSBuild supports targeting PCLs, I'm not sure how to do it, and netstandard1.0 supports all the platforms that Profile259 does.~"},"comment":{"url":"https://api.github.com/repos/lostromb/concentus/issues/comments/348664862","html_url":"https://github.com/lostromb/concentus/pull/17#issuecomment-348664862","issue_url":"https://api.github.com/repos/lostromb/concentus/issues/17","id":348664862,"user":{"login":"lostromb","id":918053,"avatar_url":"https://avatars0.githubusercontent.com/u/918053?v=4","gravatar_id":"","url":"https://api.github.com/users/lostromb","html_url":"https://github.com/lostromb","followers_url":"https://api.github.com/users/lostromb/followers","following_url":"https://api.github.com/users/lostromb/following{/other_user}","gists_url":"https://api.github.com/users/lostromb/gists{/gist_id}","starred_url":"https://api.github.com/users/lostromb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostromb/subscriptions","organizations_url":"https://api.github.com/users/lostromb/orgs","repos_url":"https://api.github.com/users/lostromb/repos","events_url":"https://api.github.com/users/lostromb/events{/privacy}","received_events_url":"https://api.github.com/users/lostromb/received_events","type":"User","site_admin":false},"created_at":"2017-12-02T03:32:44Z","updated_at":"2017-12-02T03:32:44Z","author_association":"OWNER","body":"I'm guessing it's not possible to also maintain the old-format project files, perhaps as a separate solution? Almost all of my machines have VS2015 at the latest and I'm, uh, too lazy to upgrade all of them"}}
{"actor":{"display_login":"lostromb"}}