{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/components/pulls/comments/154306573","pull_request_review_id":80449420,"id":154306573,"diff_hunk":"@@ -72,7 +72,7 @@ public void build(BeamJobContext ctx) {\n \t\t\t\thasFlow = !StringUtils.isEmpty(flowLink);\n \t\t\t\thasReject = !StringUtils.isEmpty(rejectLink);\n \n-\t\t\t\tPCollectionTuple outputTuples = expand(mainPCollection);\n+\t\t\t\tPCollectionTuple outputTuples = mainPCollection.apply(ctx.getPTransformName(), this);","path":"components/components-processing/processing-runtime/src/main/java/org/talend/components/processing/runtime/filterrow/FilterRowRuntime.java","position":5,"original_position":5,"commit_id":"54834a229ffa4ce752d65f1b07562618c862b280","original_commit_id":"54834a229ffa4ce752d65f1b07562618c862b280","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars1.githubusercontent.com/u/7734020?v=4","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"Yes @lbourgeois good point, I will have a PR after, to add a proper name for all the PTransform.apply on all component runtime, \r\nas PTransform is hierarchy invoke, this PR with the other two PRs solve the problem about transfer user defined name to backend.\r\nbut the child PTransform like TypeConverterRuntime(which has a well defined name already) is not controlled by user.\r\nI will modify others like KafkaInputPTransformRuntime soon. (just want to other relate PRs be reviewd ASAP)","created_at":"2017-12-01T09:55:21Z","updated_at":"2017-12-01T09:55:21Z","html_url":"https://github.com/Talend/components/pull/1058#discussion_r154306573","pull_request_url":"https://api.github.com/repos/Talend/components/pulls/1058","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/comments/154306573"},"html":{"href":"https://github.com/Talend/components/pull/1058#discussion_r154306573"},"pull_request":{"href":"https://api.github.com/repos/Talend/components/pulls/1058"}},"in_reply_to_id":154303222},"pull_request":{"url":"https://api.github.com/repos/Talend/components/pulls/1058","id":155814071,"html_url":"https://github.com/Talend/components/pull/1058","diff_url":"https://github.com/Talend/components/pull/1058.diff","patch_url":"https://github.com/Talend/components/pull/1058.patch","issue_url":"https://api.github.com/repos/Talend/components/issues/1058","number":1058,"state":"open","locked":false,"title":"feat(TFD-2146): add ability to pass through PTransform name","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars1.githubusercontent.com/u/7734020?v=4","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"**What is the current behavior?** (You can also link to an open issue here)\r\n\r\n\r\n\r\n**What is the new behavior?**\r\nadd ability to pass through PTransform name\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n- [ ] The commit message follows Talend standard\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [ ] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n","created_at":"2017-12-01T09:10:45Z","updated_at":"2017-12-01T09:55:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a6ddbf64aef8d66edb67afc7d73ef97bb98b79f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/components/pulls/1058/commits","review_comments_url":"https://api.github.com/repos/Talend/components/pulls/1058/comments","review_comment_url":"https://api.github.com/repos/Talend/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/components/issues/1058/comments","statuses_url":"https://api.github.com/repos/Talend/components/statuses/54834a229ffa4ce752d65f1b07562618c862b280","head":{"label":"Talend:bchen/TFD-2146-PTransform-name","ref":"bchen/TFD-2146-PTransform-name","sha":"54834a229ffa4ce752d65f1b07562618c862b280","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2017-11-01T20:09:32Z","pushed_at":"2017-12-01T09:33:31Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":15888,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":17,"watchers":19,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"9db1e3a55d39a3ab455ccb904c7bfaf7c5400d21","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2017-11-01T20:09:32Z","pushed_at":"2017-12-01T09:33:31Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":15888,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":17,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/1058"},"html":{"href":"https://github.com/Talend/components/pull/1058"},"issue":{"href":"https://api.github.com/repos/Talend/components/issues/1058"},"comments":{"href":"https://api.github.com/repos/Talend/components/issues/1058/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/components/pulls/1058/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/components/pulls/1058/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/components/statuses/54834a229ffa4ce752d65f1b07562618c862b280"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bchen-talend"}}