{"action":"opened","number":30843,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/30843","id":105302728,"html_url":"https://github.com/docker/docker/pull/30843","diff_url":"https://github.com/docker/docker/pull/30843.diff","patch_url":"https://github.com/docker/docker/pull/30843.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/30843","number":30843,"state":"open","locked":false,"title":"Few daemon duplication refactor","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Few small refactoring to limit duplication where I thought I could. For some part this is more a try to get opinion than a definite refactoring. It is separate in separate commit to ease the review and also to remove if the refactoring doesn't make sense.\r\n\r\nThe refactor happens mainly in `cluster` package and at some part of the `daemon` one.\r\n\r\n/cc @aaronlehmann @tonistiigi @AkihiroSuda @yongtang @cpuguy83 \r\n\r\nHopefully this does not break anything 👼\r\n\r\n🐸","created_at":"2017-02-08T20:54:04Z","updated_at":"2017-02-08T20:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/30843/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/30843/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/30843/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/f932b77d8951ca076e07e41c684c1fca369aac14","head":{"label":"vdemeester:daemon-duplication-refactor","ref":"daemon-duplication-refactor","sha":"f932b77d8951ca076e07e41c684c1fca369aac14","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":32953007,"name":"docker","full_name":"vdemeester/docker","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/docker","description":"🐳 Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vdemeester/docker","forks_url":"https://api.github.com/repos/vdemeester/docker/forks","keys_url":"https://api.github.com/repos/vdemeester/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/docker/teams","hooks_url":"https://api.github.com/repos/vdemeester/docker/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/docker/events","assignees_url":"https://api.github.com/repos/vdemeester/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/docker/tags","blobs_url":"https://api.github.com/repos/vdemeester/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/docker/languages","stargazers_url":"https://api.github.com/repos/vdemeester/docker/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/docker/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/docker/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/docker/subscription","commits_url":"https://api.github.com/repos/vdemeester/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/docker/merges","archive_url":"https://api.github.com/repos/vdemeester/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/docker/downloads","issues_url":"https://api.github.com/repos/vdemeester/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/docker/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/docker/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/docker/deployments","created_at":"2015-03-26T21:32:15Z","updated_at":"2016-12-25T10:28:16Z","pushed_at":"2017-02-08T20:31:33Z","git_url":"git://github.com/vdemeester/docker.git","ssh_url":"git@github.com:vdemeester/docker.git","clone_url":"https://github.com/vdemeester/docker.git","svn_url":"https://github.com/vdemeester/docker","homepage":"http://www.docker.com","size":119553,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"d4be5a2f677ddfee92c794503c7119d0a2de7a89","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2017-02-08T20:24:46Z","pushed_at":"2017-02-08T20:18:09Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":123118,"stargazers_count":39490,"watchers_count":39490,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11847,"mirror_url":null,"open_issues_count":2219,"forks":11847,"open_issues":2219,"watchers":39490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/30843"},"html":{"href":"https://github.com/docker/docker/pull/30843"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/30843"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/30843/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/30843/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/30843/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/f932b77d8951ca076e07e41c684c1fca369aac14"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":8,"additions":290,"deletions":380,"changed_files":11}}
{"actor":{"display_login":"vdemeester"}}