{"action":"created","comment":{"url":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments/108024716","pull_request_review_id":29036656,"id":108024716,"diff_hunk":"@@ -432,6 +434,43 @@ def read(serial_conn):\n \n   return HibikeMessage(messageID, payload)\n \n+# Sends this message\n+# Computes the checksum\n+# Then sends each byte of the message, and finally sends the checksum byte\n+def hid_send(hid, message):","path":"hibike/hibike_message.py","position":56,"original_position":56,"commit_id":"97b405728526dcf64d1b49efa4ad0becf01a573f","original_commit_id":"97b405728526dcf64d1b49efa4ad0becf01a573f","user":{"login":"dHutchings","id":2158534,"avatar_url":"https://avatars0.githubusercontent.com/u/2158534?v=3","gravatar_id":"","url":"https://api.github.com/users/dHutchings","html_url":"https://github.com/dHutchings","followers_url":"https://api.github.com/users/dHutchings/followers","following_url":"https://api.github.com/users/dHutchings/following{/other_user}","gists_url":"https://api.github.com/users/dHutchings/gists{/gist_id}","starred_url":"https://api.github.com/users/dHutchings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dHutchings/subscriptions","organizations_url":"https://api.github.com/users/dHutchings/orgs","repos_url":"https://api.github.com/users/dHutchings/repos","events_url":"https://api.github.com/users/dHutchings/events{/privacy}","received_events_url":"https://api.github.com/users/dHutchings/received_events","type":"User","site_admin":false},"body":"See my above comment.  Untill it's tested, I'm not convinced that there should be a packet limit size anymore.","created_at":"2017-03-25T01:37:52Z","updated_at":"2017-03-25T01:37:52Z","html_url":"https://github.com/pioneers/PieCentral/pull/291#discussion_r108024716","pull_request_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments/108024716"},"html":{"href":"https://github.com/pioneers/PieCentral/pull/291#discussion_r108024716"},"pull_request":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/pioneers/PieCentral/pulls/291","id":112393256,"html_url":"https://github.com/pioneers/PieCentral/pull/291","diff_url":"https://github.com/pioneers/PieCentral/pull/291.diff","patch_url":"https://github.com/pioneers/PieCentral/pull/291.patch","issue_url":"https://api.github.com/repos/pioneers/PieCentral/issues/291","number":291,"state":"open","locked":false,"title":"[HIBIKE] switch communication protocol from serial to HID","user":{"login":"karthik-shanmugam","id":7821859,"avatar_url":"https://avatars2.githubusercontent.com/u/7821859?v=3","gravatar_id":"","url":"https://api.github.com/users/karthik-shanmugam","html_url":"https://github.com/karthik-shanmugam","followers_url":"https://api.github.com/users/karthik-shanmugam/followers","following_url":"https://api.github.com/users/karthik-shanmugam/following{/other_user}","gists_url":"https://api.github.com/users/karthik-shanmugam/gists{/gist_id}","starred_url":"https://api.github.com/users/karthik-shanmugam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthik-shanmugam/subscriptions","organizations_url":"https://api.github.com/users/karthik-shanmugam/orgs","repos_url":"https://api.github.com/users/karthik-shanmugam/repos","events_url":"https://api.github.com/users/karthik-shanmugam/events{/privacy}","received_events_url":"https://api.github.com/users/karthik-shanmugam/received_events","type":"User","site_admin":false},"body":"- replace serial communication with hid in python and firmware\r\n- completely switch `hibike_process.py` to support hid only\r\n- add [this HID library](https://github.com/NicoHood/HID) to the hibike/lib folder\r\n- add a C++ preprocessor variable to switch firmware between HID and serial mode at compile time\r\n  - hard-code it to HID mode for now\r\n- add a test script to enumerate all devices using HID\r\n  - does not use `hibike_process`\r\n- minor changes/fixes\r\n  - `hibike_process`'s `write_thread` now flushes its queue when it gets too large\r\n    - it will never flush a `disable` request though\r\n  - example devices no longer continually increment two of their params\r\n    - these are now for testing writing\r\n  - `hibike_process` now keeps count of packets read/second and average time spent parsing packets","created_at":"2017-03-24T06:04:14Z","updated_at":"2017-03-25T01:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"nikitakit","id":252225,"avatar_url":"https://avatars1.githubusercontent.com/u/252225?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitakit","html_url":"https://github.com/nikitakit","followers_url":"https://api.github.com/users/nikitakit/followers","following_url":"https://api.github.com/users/nikitakit/following{/other_user}","gists_url":"https://api.github.com/users/nikitakit/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitakit/subscriptions","organizations_url":"https://api.github.com/users/nikitakit/orgs","repos_url":"https://api.github.com/users/nikitakit/repos","events_url":"https://api.github.com/users/nikitakit/events{/privacy}","received_events_url":"https://api.github.com/users/nikitakit/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikitakit","id":252225,"avatar_url":"https://avatars1.githubusercontent.com/u/252225?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitakit","html_url":"https://github.com/nikitakit","followers_url":"https://api.github.com/users/nikitakit/followers","following_url":"https://api.github.com/users/nikitakit/following{/other_user}","gists_url":"https://api.github.com/users/nikitakit/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitakit/subscriptions","organizations_url":"https://api.github.com/users/nikitakit/orgs","repos_url":"https://api.github.com/users/nikitakit/repos","events_url":"https://api.github.com/users/nikitakit/events{/privacy}","received_events_url":"https://api.github.com/users/nikitakit/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/291/commits","review_comments_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/291/comments","review_comment_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/issues/291/comments","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/97b405728526dcf64d1b49efa4ad0becf01a573f","head":{"label":"pioneers:hibike/hid","ref":"hibike/hid","sha":"97b405728526dcf64d1b49efa4ad0becf01a573f","user":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars2.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"repo":{"id":67092938,"name":"PieCentral","full_name":"pioneers/PieCentral","owner":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars2.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneers/PieCentral","description":null,"fork":false,"url":"https://api.github.com/repos/pioneers/PieCentral","forks_url":"https://api.github.com/repos/pioneers/PieCentral/forks","keys_url":"https://api.github.com/repos/pioneers/PieCentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneers/PieCentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneers/PieCentral/teams","hooks_url":"https://api.github.com/repos/pioneers/PieCentral/hooks","issue_events_url":"https://api.github.com/repos/pioneers/PieCentral/issues/events{/number}","events_url":"https://api.github.com/repos/pioneers/PieCentral/events","assignees_url":"https://api.github.com/repos/pioneers/PieCentral/assignees{/user}","branches_url":"https://api.github.com/repos/pioneers/PieCentral/branches{/branch}","tags_url":"https://api.github.com/repos/pioneers/PieCentral/tags","blobs_url":"https://api.github.com/repos/pioneers/PieCentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneers/PieCentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneers/PieCentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneers/PieCentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneers/PieCentral/languages","stargazers_url":"https://api.github.com/repos/pioneers/PieCentral/stargazers","contributors_url":"https://api.github.com/repos/pioneers/PieCentral/contributors","subscribers_url":"https://api.github.com/repos/pioneers/PieCentral/subscribers","subscription_url":"https://api.github.com/repos/pioneers/PieCentral/subscription","commits_url":"https://api.github.com/repos/pioneers/PieCentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneers/PieCentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneers/PieCentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneers/PieCentral/contents/{+path}","compare_url":"https://api.github.com/repos/pioneers/PieCentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneers/PieCentral/merges","archive_url":"https://api.github.com/repos/pioneers/PieCentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneers/PieCentral/downloads","issues_url":"https://api.github.com/repos/pioneers/PieCentral/issues{/number}","pulls_url":"https://api.github.com/repos/pioneers/PieCentral/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneers/PieCentral/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneers/PieCentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneers/PieCentral/labels{/name}","releases_url":"https://api.github.com/repos/pioneers/PieCentral/releases{/id}","deployments_url":"https://api.github.com/repos/pioneers/PieCentral/deployments","created_at":"2016-09-01T03:00:13Z","updated_at":"2017-03-03T10:04:40Z","pushed_at":"2017-03-24T07:34:45Z","git_url":"git://github.com/pioneers/PieCentral.git","ssh_url":"git@github.com:pioneers/PieCentral.git","clone_url":"https://github.com/pioneers/PieCentral.git","svn_url":"https://github.com/pioneers/PieCentral","homepage":null,"size":4803,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":4,"default_branch":"master"}},"base":{"label":"pioneers:master","ref":"master","sha":"53918ebe6c12a3935bf8c7eaece62723b8c1a312","user":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars2.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"repo":{"id":67092938,"name":"PieCentral","full_name":"pioneers/PieCentral","owner":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars2.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneers/PieCentral","description":null,"fork":false,"url":"https://api.github.com/repos/pioneers/PieCentral","forks_url":"https://api.github.com/repos/pioneers/PieCentral/forks","keys_url":"https://api.github.com/repos/pioneers/PieCentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneers/PieCentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneers/PieCentral/teams","hooks_url":"https://api.github.com/repos/pioneers/PieCentral/hooks","issue_events_url":"https://api.github.com/repos/pioneers/PieCentral/issues/events{/number}","events_url":"https://api.github.com/repos/pioneers/PieCentral/events","assignees_url":"https://api.github.com/repos/pioneers/PieCentral/assignees{/user}","branches_url":"https://api.github.com/repos/pioneers/PieCentral/branches{/branch}","tags_url":"https://api.github.com/repos/pioneers/PieCentral/tags","blobs_url":"https://api.github.com/repos/pioneers/PieCentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneers/PieCentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneers/PieCentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneers/PieCentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneers/PieCentral/languages","stargazers_url":"https://api.github.com/repos/pioneers/PieCentral/stargazers","contributors_url":"https://api.github.com/repos/pioneers/PieCentral/contributors","subscribers_url":"https://api.github.com/repos/pioneers/PieCentral/subscribers","subscription_url":"https://api.github.com/repos/pioneers/PieCentral/subscription","commits_url":"https://api.github.com/repos/pioneers/PieCentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneers/PieCentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneers/PieCentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneers/PieCentral/contents/{+path}","compare_url":"https://api.github.com/repos/pioneers/PieCentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneers/PieCentral/merges","archive_url":"https://api.github.com/repos/pioneers/PieCentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneers/PieCentral/downloads","issues_url":"https://api.github.com/repos/pioneers/PieCentral/issues{/number}","pulls_url":"https://api.github.com/repos/pioneers/PieCentral/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneers/PieCentral/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneers/PieCentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneers/PieCentral/labels{/name}","releases_url":"https://api.github.com/repos/pioneers/PieCentral/releases{/id}","deployments_url":"https://api.github.com/repos/pioneers/PieCentral/deployments","created_at":"2016-09-01T03:00:13Z","updated_at":"2017-03-03T10:04:40Z","pushed_at":"2017-03-24T07:34:45Z","git_url":"git://github.com/pioneers/PieCentral.git","ssh_url":"git@github.com:pioneers/PieCentral.git","clone_url":"https://github.com/pioneers/PieCentral.git","svn_url":"https://github.com/pioneers/PieCentral","homepage":null,"size":4803,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/291"},"html":{"href":"https://github.com/pioneers/PieCentral/pull/291"},"issue":{"href":"https://api.github.com/repos/pioneers/PieCentral/issues/291"},"comments":{"href":"https://api.github.com/repos/pioneers/PieCentral/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/pioneers/PieCentral/statuses/97b405728526dcf64d1b49efa4ad0becf01a573f"}}}}
{"actor":{"display_login":"dHutchings"}}