{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/116339463","pull_request_review_id":37960399,"id":116339463,"diff_hunk":"@@ -113,23 +143,12 @@ export const submitShipping = (formValues) => (dispatch, getState) => {\n     if (submittingWithNewAddress) {\n         const {name} = formValues\n         const names = name.split(' ')\n-        const newAddress = formValues\n \n-        address = {\n+        address = addressFormToAddressObject({\n             firstname: names.slice(0, -1).join(' '),\n             lastname: names.slice(-1).join(' '),\n-            company: newAddress.company || '',\n-            telephone: newAddress.telephone,\n-            postcode: newAddress.postcode,\n-            city: newAddress.city,\n-            street: newAddress.addressLine2\n-                ? [newAddress.addressLine1, newAddress.addressLine2]\n-                : [newAddress.addressLine1],\n-            regionId: newAddress.regionId,\n-            region: newAddress.region,\n-            countryId: newAddress.countryId,\n-            saveInAddressBook: true\n-        }\n+            ...formValues","path":"web/app/integration-manager/_merlins-connector/checkout/commands.js","position":156,"original_position":156,"commit_id":"7cac73b7c22908e928af4fe17365ec8077c0e459","original_commit_id":"28de30ae3996ebf24f8a63e1cf8cb7abe7e67748","user":{"login":"jeremywiebe","id":77138,"avatar_url":"https://avatars2.githubusercontent.com/u/77138?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremywiebe","html_url":"https://github.com/jeremywiebe","followers_url":"https://api.github.com/users/jeremywiebe/followers","following_url":"https://api.github.com/users/jeremywiebe/following{/other_user}","gists_url":"https://api.github.com/users/jeremywiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremywiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremywiebe/subscriptions","organizations_url":"https://api.github.com/users/jeremywiebe/orgs","repos_url":"https://api.github.com/users/jeremywiebe/repos","events_url":"https://api.github.com/users/jeremywiebe/events{/privacy}","received_events_url":"https://api.github.com/users/jeremywiebe/received_events","type":"User","site_admin":false},"body":"I'm a bit paranoid about using spread operators for mapping operations. If the Address object changes and no longer matches what Merlin's expects, we break.  The key names will never change unless we change what version of Magento we're using. ","created_at":"2017-05-12T23:08:11Z","updated_at":"2017-05-12T23:35:15Z","html_url":"https://github.com/mobify/platform-scaffold/pull/579#discussion_r116339463","pull_request_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579","_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/116339463"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/579#discussion_r116339463"},"pull_request":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579","id":119774692,"html_url":"https://github.com/mobify/platform-scaffold/pull/579","diff_url":"https://github.com/mobify/platform-scaffold/pull/579.diff","patch_url":"https://github.com/mobify/platform-scaffold/pull/579.patch","issue_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/579","number":579,"state":"open","locked":false,"title":"[Integration Manager] Checkout Schema Part 1","user":{"login":"DanielBrookRoberge","id":9043311,"avatar_url":"https://avatars2.githubusercontent.com/u/9043311?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielBrookRoberge","html_url":"https://github.com/DanielBrookRoberge","followers_url":"https://api.github.com/users/DanielBrookRoberge/followers","following_url":"https://api.github.com/users/DanielBrookRoberge/following{/other_user}","gists_url":"https://api.github.com/users/DanielBrookRoberge/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielBrookRoberge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielBrookRoberge/subscriptions","organizations_url":"https://api.github.com/users/DanielBrookRoberge/orgs","repos_url":"https://api.github.com/users/DanielBrookRoberge/repos","events_url":"https://api.github.com/users/DanielBrookRoberge/events{/privacy}","received_events_url":"https://api.github.com/users/DanielBrookRoberge/received_events","type":"User","site_admin":false},"body":"This PR contains the first half of the checkout schema work. It has become large enough that it could use to be split up into smaller PRs.\r\n\r\n **JIRA**: https://mobify.atlassian.net/browse/WEBDATA-69\r\n **Linked PRs**: (links to corresponding PRs, optional)\r\n\r\n## Changes\r\n- Add types for the full checkout schema\r\n- Convert the location logic\r\n- Convert the shipping methods\r\n- Switch to the new recommended method of connecting the Redux dev tools\r\n- Clean up connector code in preparation for schematization.\r\n\r\n## How to test-drive this PR\r\n- Preview the checkout in Merlins and DW\r\n- Ensure that it is still completable as far as is implemented in the base branch.\r\n","created_at":"2017-05-09T23:24:24Z","updated_at":"2017-05-12T23:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76771bff55cda3c8d2a006a4be5ed81d6a2e3404","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jnurse","id":1301857,"avatar_url":"https://avatars1.githubusercontent.com/u/1301857?v=3","gravatar_id":"","url":"https://api.github.com/users/jnurse","html_url":"https://github.com/jnurse","followers_url":"https://api.github.com/users/jnurse/followers","following_url":"https://api.github.com/users/jnurse/following{/other_user}","gists_url":"https://api.github.com/users/jnurse/gists{/gist_id}","starred_url":"https://api.github.com/users/jnurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnurse/subscriptions","organizations_url":"https://api.github.com/users/jnurse/orgs","repos_url":"https://api.github.com/users/jnurse/repos","events_url":"https://api.github.com/users/jnurse/events{/privacy}","received_events_url":"https://api.github.com/users/jnurse/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579/commits","review_comments_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579/comments","review_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/579/comments","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/7cac73b7c22908e928af4fe17365ec8077c0e459","head":{"label":"mobify:integration-manager-checkout-schema","ref":"integration-manager-checkout-schema","sha":"7cac73b7c22908e928af4fe17365ec8077c0e459","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-05-12T23:27:01Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":40489,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":2,"default_branch":"develop"}},"base":{"label":"mobify:integration-manager","ref":"integration-manager","sha":"9668ebbad00ee7667290f218f3f6c873f0b9eaaf","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-05-12T23:27:01Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":40489,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/579"},"issue":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/579"},"comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/platform-scaffold/statuses/7cac73b7c22908e928af4fe17365ec8077c0e459"}}}}
{"actor":{"display_login":"jeremywiebe"}}