{"action":"closed","number":895,"pull_request":{"url":"https://api.github.com/repos/nens/lizard-client/pulls/895","id":135766184,"html_url":"https://github.com/nens/lizard-client/pull/895","diff_url":"https://github.com/nens/lizard-client/pull/895.diff","patch_url":"https://github.com/nens/lizard-client/pull/895.patch","issue_url":"https://api.github.com/repos/nens/lizard-client/issues/895","number":895,"state":"closed","locked":false,"title":"[DONE] Searchbar fixes","user":{"login":"d-weeteling","id":7764718,"avatar_url":"https://avatars3.githubusercontent.com/u/7764718?v=4","gravatar_id":"","url":"https://api.github.com/users/d-weeteling","html_url":"https://github.com/d-weeteling","followers_url":"https://api.github.com/users/d-weeteling/followers","following_url":"https://api.github.com/users/d-weeteling/following{/other_user}","gists_url":"https://api.github.com/users/d-weeteling/gists{/gist_id}","starred_url":"https://api.github.com/users/d-weeteling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-weeteling/subscriptions","organizations_url":"https://api.github.com/users/d-weeteling/orgs","repos_url":"https://api.github.com/users/d-weeteling/repos","events_url":"https://api.github.com/users/d-weeteling/events{/privacy}","received_events_url":"https://api.github.com/users/d-weeteling/received_events","type":"User","site_admin":false},"body":"In this PR:\r\n\r\n1) Result categories are ordered differently in omnibox (https://github.com/nens/lizard-nxt/issues/2213)\r\n2) Hitting enter when several categories are shown in results takes you to the first spatial result (e.g. _city of Amsterdam_) instead of the first of the found assets (e.g. _RWZI Amsterdam-west_).\r\n3) Close/clear search results after selecting one of the results\r\n4) After selecting a location (instead of asset) with the arrow keys, you can hit enter to finalize selecting an item from the displayed results. NB! This already worked for assets\r\n5) User can iterate through results with keyboard up-/down arrows without problems at first/last item\r\n","created_at":"2017-08-15T09:33:32Z","updated_at":"2017-08-16T12:47:50Z","closed_at":"2017-08-16T12:47:50Z","merged_at":"2017-08-16T12:47:50Z","merge_commit_sha":"9ed18aca823267f79c3c9b10cc08775ac2f68709","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nens/lizard-client/pulls/895/commits","review_comments_url":"https://api.github.com/repos/nens/lizard-client/pulls/895/comments","review_comment_url":"https://api.github.com/repos/nens/lizard-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nens/lizard-client/issues/895/comments","statuses_url":"https://api.github.com/repos/nens/lizard-client/statuses/dcf52e735672983c95009cd8c511a7916fa70838","head":{"label":"nens:dirk-fix-searchbar","ref":"dirk-fix-searchbar","sha":"dcf52e735672983c95009cd8c511a7916fa70838","user":{"login":"nens","id":826981,"avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":19860085,"name":"lizard-client","full_name":"nens/lizard-client","owner":{"login":"nens","id":826981,"avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nens/lizard-client","description":"Front end to lizard-nxt.","fork":false,"url":"https://api.github.com/repos/nens/lizard-client","forks_url":"https://api.github.com/repos/nens/lizard-client/forks","keys_url":"https://api.github.com/repos/nens/lizard-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/lizard-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/lizard-client/teams","hooks_url":"https://api.github.com/repos/nens/lizard-client/hooks","issue_events_url":"https://api.github.com/repos/nens/lizard-client/issues/events{/number}","events_url":"https://api.github.com/repos/nens/lizard-client/events","assignees_url":"https://api.github.com/repos/nens/lizard-client/assignees{/user}","branches_url":"https://api.github.com/repos/nens/lizard-client/branches{/branch}","tags_url":"https://api.github.com/repos/nens/lizard-client/tags","blobs_url":"https://api.github.com/repos/nens/lizard-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/lizard-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/lizard-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/lizard-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/lizard-client/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/lizard-client/languages","stargazers_url":"https://api.github.com/repos/nens/lizard-client/stargazers","contributors_url":"https://api.github.com/repos/nens/lizard-client/contributors","subscribers_url":"https://api.github.com/repos/nens/lizard-client/subscribers","subscription_url":"https://api.github.com/repos/nens/lizard-client/subscription","commits_url":"https://api.github.com/repos/nens/lizard-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/lizard-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/lizard-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/lizard-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/lizard-client/contents/{+path}","compare_url":"https://api.github.com/repos/nens/lizard-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/lizard-client/merges","archive_url":"https://api.github.com/repos/nens/lizard-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/lizard-client/downloads","issues_url":"https://api.github.com/repos/nens/lizard-client/issues{/number}","pulls_url":"https://api.github.com/repos/nens/lizard-client/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/lizard-client/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/lizard-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/lizard-client/labels{/name}","releases_url":"https://api.github.com/repos/nens/lizard-client/releases{/id}","deployments_url":"https://api.github.com/repos/nens/lizard-client/deployments","created_at":"2014-05-16T14:50:33Z","updated_at":"2017-01-09T08:52:26Z","pushed_at":"2017-08-16T12:47:50Z","git_url":"git://github.com/nens/lizard-client.git","ssh_url":"git@github.com:nens/lizard-client.git","clone_url":"https://github.com/nens/lizard-client.git","svn_url":"https://github.com/nens/lizard-client","homepage":"https://lizard.net","size":19840,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":3,"default_branch":"master"}},"base":{"label":"nens:master","ref":"master","sha":"cc9c6eb3998c6c354dc417025513700717757e6b","user":{"login":"nens","id":826981,"avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":19860085,"name":"lizard-client","full_name":"nens/lizard-client","owner":{"login":"nens","id":826981,"avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nens/lizard-client","description":"Front end to lizard-nxt.","fork":false,"url":"https://api.github.com/repos/nens/lizard-client","forks_url":"https://api.github.com/repos/nens/lizard-client/forks","keys_url":"https://api.github.com/repos/nens/lizard-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/lizard-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/lizard-client/teams","hooks_url":"https://api.github.com/repos/nens/lizard-client/hooks","issue_events_url":"https://api.github.com/repos/nens/lizard-client/issues/events{/number}","events_url":"https://api.github.com/repos/nens/lizard-client/events","assignees_url":"https://api.github.com/repos/nens/lizard-client/assignees{/user}","branches_url":"https://api.github.com/repos/nens/lizard-client/branches{/branch}","tags_url":"https://api.github.com/repos/nens/lizard-client/tags","blobs_url":"https://api.github.com/repos/nens/lizard-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/lizard-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/lizard-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/lizard-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/lizard-client/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/lizard-client/languages","stargazers_url":"https://api.github.com/repos/nens/lizard-client/stargazers","contributors_url":"https://api.github.com/repos/nens/lizard-client/contributors","subscribers_url":"https://api.github.com/repos/nens/lizard-client/subscribers","subscription_url":"https://api.github.com/repos/nens/lizard-client/subscription","commits_url":"https://api.github.com/repos/nens/lizard-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/lizard-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/lizard-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/lizard-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/lizard-client/contents/{+path}","compare_url":"https://api.github.com/repos/nens/lizard-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/lizard-client/merges","archive_url":"https://api.github.com/repos/nens/lizard-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/lizard-client/downloads","issues_url":"https://api.github.com/repos/nens/lizard-client/issues{/number}","pulls_url":"https://api.github.com/repos/nens/lizard-client/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/lizard-client/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/lizard-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/lizard-client/labels{/name}","releases_url":"https://api.github.com/repos/nens/lizard-client/releases{/id}","deployments_url":"https://api.github.com/repos/nens/lizard-client/deployments","created_at":"2014-05-16T14:50:33Z","updated_at":"2017-01-09T08:52:26Z","pushed_at":"2017-08-16T12:47:50Z","git_url":"git://github.com/nens/lizard-client.git","ssh_url":"git@github.com:nens/lizard-client.git","clone_url":"https://github.com/nens/lizard-client.git","svn_url":"https://github.com/nens/lizard-client","homepage":"https://lizard.net","size":19840,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nens/lizard-client/pulls/895"},"html":{"href":"https://github.com/nens/lizard-client/pull/895"},"issue":{"href":"https://api.github.com/repos/nens/lizard-client/issues/895"},"comments":{"href":"https://api.github.com/repos/nens/lizard-client/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/nens/lizard-client/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/nens/lizard-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nens/lizard-client/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/nens/lizard-client/statuses/dcf52e735672983c95009cd8c511a7916fa70838"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gijs","id":7193,"avatar_url":"https://avatars0.githubusercontent.com/u/7193?v=4","gravatar_id":"","url":"https://api.github.com/users/gijs","html_url":"https://github.com/gijs","followers_url":"https://api.github.com/users/gijs/followers","following_url":"https://api.github.com/users/gijs/following{/other_user}","gists_url":"https://api.github.com/users/gijs/gists{/gist_id}","starred_url":"https://api.github.com/users/gijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijs/subscriptions","organizations_url":"https://api.github.com/users/gijs/orgs","repos_url":"https://api.github.com/users/gijs/repos","events_url":"https://api.github.com/users/gijs/events{/privacy}","received_events_url":"https://api.github.com/users/gijs/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":5,"additions":79,"deletions":67,"changed_files":3}}
{"actor":{"display_login":"gijs"}}