{"action":"closed","number":251,"pull_request":{"url":"https://api.github.com/repos/Firebottle/Firebot/pulls/251","id":128653413,"html_url":"https://github.com/Firebottle/Firebot/pull/251","diff_url":"https://github.com/Firebottle/Firebot/pull/251.diff","patch_url":"https://github.com/Firebottle/Firebot/pull/251.patch","issue_url":"https://api.github.com/repos/Firebottle/Firebot/issues/251","number":251,"state":"closed","locked":false,"title":"Cleaning up some overlay code. Adding notification.","user":{"login":"Firebottle","id":17416635,"avatar_url":"https://avatars1.githubusercontent.com/u/17416635?v=3","gravatar_id":"","url":"https://api.github.com/users/Firebottle","html_url":"https://github.com/Firebottle","followers_url":"https://api.github.com/users/Firebottle/followers","following_url":"https://api.github.com/users/Firebottle/following{/other_user}","gists_url":"https://api.github.com/users/Firebottle/gists{/gist_id}","starred_url":"https://api.github.com/users/Firebottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firebottle/subscriptions","organizations_url":"https://api.github.com/users/Firebottle/orgs","repos_url":"https://api.github.com/users/Firebottle/repos","events_url":"https://api.github.com/users/Firebottle/events{/privacy}","received_events_url":"https://api.github.com/users/Firebottle/received_events","type":"User","site_admin":false},"body":"Cleaning up overlay code a bit, converting it to scss, and adding notification to help troubleshoot connection issues.\r\n\r\n- Converted overlay over to scss.\r\n- Simplified positioning styles so that images, videos, and other effects can use them without duplicating css.\r\n- Added in notification popup that will show when trying to connect to Firebot. Should help troubleshoot connection problems and warn streamers of issues.\r\n- Separated out effect code into different js files.\r\n\r\nNotification just shows in the top left of the overlay until Firebot connects. The 8080 is the port it's trying to connect to so we can troubleshoot that easier.\r\n![image](https://user-images.githubusercontent.com/17416635/27801421-917abb52-5fe3-11e7-86af-d706b6f5d86b.png)\r\n","created_at":"2017-07-03T15:33:27Z","updated_at":"2017-07-03T17:21:18Z","closed_at":"2017-07-03T17:21:18Z","merged_at":"2017-07-03T17:21:18Z","merge_commit_sha":"20db439c9e35578438b204b540182ce0be546e3f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebiggz","id":3515161,"avatar_url":"https://avatars3.githubusercontent.com/u/3515161?v=3","gravatar_id":"","url":"https://api.github.com/users/ebiggz","html_url":"https://github.com/ebiggz","followers_url":"https://api.github.com/users/ebiggz/followers","following_url":"https://api.github.com/users/ebiggz/following{/other_user}","gists_url":"https://api.github.com/users/ebiggz/gists{/gist_id}","starred_url":"https://api.github.com/users/ebiggz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebiggz/subscriptions","organizations_url":"https://api.github.com/users/ebiggz/orgs","repos_url":"https://api.github.com/users/ebiggz/repos","events_url":"https://api.github.com/users/ebiggz/events{/privacy}","received_events_url":"https://api.github.com/users/ebiggz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Firebottle/Firebot/pulls/251/commits","review_comments_url":"https://api.github.com/repos/Firebottle/Firebot/pulls/251/comments","review_comment_url":"https://api.github.com/repos/Firebottle/Firebot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Firebottle/Firebot/issues/251/comments","statuses_url":"https://api.github.com/repos/Firebottle/Firebot/statuses/5bd706a43893d740eb0dd6e86870f3364b78fc7d","head":{"label":"Firebottle:4.0-w/fb-overlay-fixes","ref":"4.0-w/fb-overlay-fixes","sha":"5bd706a43893d740eb0dd6e86870f3364b78fc7d","user":{"login":"Firebottle","id":17416635,"avatar_url":"https://avatars1.githubusercontent.com/u/17416635?v=3","gravatar_id":"","url":"https://api.github.com/users/Firebottle","html_url":"https://github.com/Firebottle","followers_url":"https://api.github.com/users/Firebottle/followers","following_url":"https://api.github.com/users/Firebottle/following{/other_user}","gists_url":"https://api.github.com/users/Firebottle/gists{/gist_id}","starred_url":"https://api.github.com/users/Firebottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firebottle/subscriptions","organizations_url":"https://api.github.com/users/Firebottle/orgs","repos_url":"https://api.github.com/users/Firebottle/repos","events_url":"https://api.github.com/users/Firebottle/events{/privacy}","received_events_url":"https://api.github.com/users/Firebottle/received_events","type":"User","site_admin":false},"repo":{"id":66841979,"name":"Firebot","full_name":"Firebottle/Firebot","owner":{"login":"Firebottle","id":17416635,"avatar_url":"https://avatars1.githubusercontent.com/u/17416635?v=3","gravatar_id":"","url":"https://api.github.com/users/Firebottle","html_url":"https://github.com/Firebottle","followers_url":"https://api.github.com/users/Firebottle/followers","following_url":"https://api.github.com/users/Firebottle/following{/other_user}","gists_url":"https://api.github.com/users/Firebottle/gists{/gist_id}","starred_url":"https://api.github.com/users/Firebottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firebottle/subscriptions","organizations_url":"https://api.github.com/users/Firebottle/orgs","repos_url":"https://api.github.com/users/Firebottle/repos","events_url":"https://api.github.com/users/Firebottle/events{/privacy}","received_events_url":"https://api.github.com/users/Firebottle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Firebottle/Firebot","description":"An interactive tool for streamers on Mixer.com","fork":false,"url":"https://api.github.com/repos/Firebottle/Firebot","forks_url":"https://api.github.com/repos/Firebottle/Firebot/forks","keys_url":"https://api.github.com/repos/Firebottle/Firebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Firebottle/Firebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Firebottle/Firebot/teams","hooks_url":"https://api.github.com/repos/Firebottle/Firebot/hooks","issue_events_url":"https://api.github.com/repos/Firebottle/Firebot/issues/events{/number}","events_url":"https://api.github.com/repos/Firebottle/Firebot/events","assignees_url":"https://api.github.com/repos/Firebottle/Firebot/assignees{/user}","branches_url":"https://api.github.com/repos/Firebottle/Firebot/branches{/branch}","tags_url":"https://api.github.com/repos/Firebottle/Firebot/tags","blobs_url":"https://api.github.com/repos/Firebottle/Firebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Firebottle/Firebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Firebottle/Firebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Firebottle/Firebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Firebottle/Firebot/statuses/{sha}","languages_url":"https://api.github.com/repos/Firebottle/Firebot/languages","stargazers_url":"https://api.github.com/repos/Firebottle/Firebot/stargazers","contributors_url":"https://api.github.com/repos/Firebottle/Firebot/contributors","subscribers_url":"https://api.github.com/repos/Firebottle/Firebot/subscribers","subscription_url":"https://api.github.com/repos/Firebottle/Firebot/subscription","commits_url":"https://api.github.com/repos/Firebottle/Firebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Firebottle/Firebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Firebottle/Firebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Firebottle/Firebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Firebottle/Firebot/contents/{+path}","compare_url":"https://api.github.com/repos/Firebottle/Firebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Firebottle/Firebot/merges","archive_url":"https://api.github.com/repos/Firebottle/Firebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Firebottle/Firebot/downloads","issues_url":"https://api.github.com/repos/Firebottle/Firebot/issues{/number}","pulls_url":"https://api.github.com/repos/Firebottle/Firebot/pulls{/number}","milestones_url":"https://api.github.com/repos/Firebottle/Firebot/milestones{/number}","notifications_url":"https://api.github.com/repos/Firebottle/Firebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Firebottle/Firebot/labels{/name}","releases_url":"https://api.github.com/repos/Firebottle/Firebot/releases{/id}","deployments_url":"https://api.github.com/repos/Firebottle/Firebot/deployments","created_at":"2016-08-29T12:33:17Z","updated_at":"2017-06-29T01:02:14Z","pushed_at":"2017-07-03T17:21:18Z","git_url":"git://github.com/Firebottle/Firebot.git","ssh_url":"git@github.com:Firebottle/Firebot.git","clone_url":"https://github.com/Firebottle/Firebot.git","svn_url":"https://github.com/Firebottle/Firebot","homepage":"https://firebottle.tv","size":129635,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":33,"forks":12,"open_issues":33,"watchers":31,"default_branch":"master"}},"base":{"label":"Firebottle:4.0-w/Angular","ref":"4.0-w/Angular","sha":"de69cab05e225eb888067af45aefa688588ff8ef","user":{"login":"Firebottle","id":17416635,"avatar_url":"https://avatars1.githubusercontent.com/u/17416635?v=3","gravatar_id":"","url":"https://api.github.com/users/Firebottle","html_url":"https://github.com/Firebottle","followers_url":"https://api.github.com/users/Firebottle/followers","following_url":"https://api.github.com/users/Firebottle/following{/other_user}","gists_url":"https://api.github.com/users/Firebottle/gists{/gist_id}","starred_url":"https://api.github.com/users/Firebottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firebottle/subscriptions","organizations_url":"https://api.github.com/users/Firebottle/orgs","repos_url":"https://api.github.com/users/Firebottle/repos","events_url":"https://api.github.com/users/Firebottle/events{/privacy}","received_events_url":"https://api.github.com/users/Firebottle/received_events","type":"User","site_admin":false},"repo":{"id":66841979,"name":"Firebot","full_name":"Firebottle/Firebot","owner":{"login":"Firebottle","id":17416635,"avatar_url":"https://avatars1.githubusercontent.com/u/17416635?v=3","gravatar_id":"","url":"https://api.github.com/users/Firebottle","html_url":"https://github.com/Firebottle","followers_url":"https://api.github.com/users/Firebottle/followers","following_url":"https://api.github.com/users/Firebottle/following{/other_user}","gists_url":"https://api.github.com/users/Firebottle/gists{/gist_id}","starred_url":"https://api.github.com/users/Firebottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firebottle/subscriptions","organizations_url":"https://api.github.com/users/Firebottle/orgs","repos_url":"https://api.github.com/users/Firebottle/repos","events_url":"https://api.github.com/users/Firebottle/events{/privacy}","received_events_url":"https://api.github.com/users/Firebottle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Firebottle/Firebot","description":"An interactive tool for streamers on Mixer.com","fork":false,"url":"https://api.github.com/repos/Firebottle/Firebot","forks_url":"https://api.github.com/repos/Firebottle/Firebot/forks","keys_url":"https://api.github.com/repos/Firebottle/Firebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Firebottle/Firebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Firebottle/Firebot/teams","hooks_url":"https://api.github.com/repos/Firebottle/Firebot/hooks","issue_events_url":"https://api.github.com/repos/Firebottle/Firebot/issues/events{/number}","events_url":"https://api.github.com/repos/Firebottle/Firebot/events","assignees_url":"https://api.github.com/repos/Firebottle/Firebot/assignees{/user}","branches_url":"https://api.github.com/repos/Firebottle/Firebot/branches{/branch}","tags_url":"https://api.github.com/repos/Firebottle/Firebot/tags","blobs_url":"https://api.github.com/repos/Firebottle/Firebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Firebottle/Firebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Firebottle/Firebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Firebottle/Firebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Firebottle/Firebot/statuses/{sha}","languages_url":"https://api.github.com/repos/Firebottle/Firebot/languages","stargazers_url":"https://api.github.com/repos/Firebottle/Firebot/stargazers","contributors_url":"https://api.github.com/repos/Firebottle/Firebot/contributors","subscribers_url":"https://api.github.com/repos/Firebottle/Firebot/subscribers","subscription_url":"https://api.github.com/repos/Firebottle/Firebot/subscription","commits_url":"https://api.github.com/repos/Firebottle/Firebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Firebottle/Firebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Firebottle/Firebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Firebottle/Firebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Firebottle/Firebot/contents/{+path}","compare_url":"https://api.github.com/repos/Firebottle/Firebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Firebottle/Firebot/merges","archive_url":"https://api.github.com/repos/Firebottle/Firebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Firebottle/Firebot/downloads","issues_url":"https://api.github.com/repos/Firebottle/Firebot/issues{/number}","pulls_url":"https://api.github.com/repos/Firebottle/Firebot/pulls{/number}","milestones_url":"https://api.github.com/repos/Firebottle/Firebot/milestones{/number}","notifications_url":"https://api.github.com/repos/Firebottle/Firebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Firebottle/Firebot/labels{/name}","releases_url":"https://api.github.com/repos/Firebottle/Firebot/releases{/id}","deployments_url":"https://api.github.com/repos/Firebottle/Firebot/deployments","created_at":"2016-08-29T12:33:17Z","updated_at":"2017-06-29T01:02:14Z","pushed_at":"2017-07-03T17:21:18Z","git_url":"git://github.com/Firebottle/Firebot.git","ssh_url":"git@github.com:Firebottle/Firebot.git","clone_url":"https://github.com/Firebottle/Firebot.git","svn_url":"https://github.com/Firebottle/Firebot","homepage":"https://firebottle.tv","size":129635,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":33,"forks":12,"open_issues":33,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Firebottle/Firebot/pulls/251"},"html":{"href":"https://github.com/Firebottle/Firebot/pull/251"},"issue":{"href":"https://api.github.com/repos/Firebottle/Firebot/issues/251"},"comments":{"href":"https://api.github.com/repos/Firebottle/Firebot/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/Firebottle/Firebot/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/Firebottle/Firebot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Firebottle/Firebot/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/Firebottle/Firebot/statuses/5bd706a43893d740eb0dd6e86870f3364b78fc7d"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ebiggz","id":3515161,"avatar_url":"https://avatars3.githubusercontent.com/u/3515161?v=3","gravatar_id":"","url":"https://api.github.com/users/ebiggz","html_url":"https://github.com/ebiggz","followers_url":"https://api.github.com/users/ebiggz/followers","following_url":"https://api.github.com/users/ebiggz/following{/other_user}","gists_url":"https://api.github.com/users/ebiggz/gists{/gist_id}","starred_url":"https://api.github.com/users/ebiggz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebiggz/subscriptions","organizations_url":"https://api.github.com/users/ebiggz/orgs","repos_url":"https://api.github.com/users/ebiggz/repos","events_url":"https://api.github.com/users/ebiggz/events{/privacy}","received_events_url":"https://api.github.com/users/ebiggz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":582,"deletions":587,"changed_files":10}}
{"actor":{"display_login":"ebiggz"}}