{"action":"closed","number":17048,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17048","id":107766182,"html_url":"https://github.com/apache/spark/pull/17048","diff_url":"https://github.com/apache/spark/pull/17048.diff","patch_url":"https://github.com/apache/spark/pull/17048.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/17048","number":17048,"state":"closed","locked":false,"title":"[SPARK-14772][PYTHON][ML] Fixed Params.copy method to match Scala implementation","user":{"login":"BryanCutler","id":4534389,"avatar_url":"https://avatars.githubusercontent.com/u/4534389?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nFixed the PySpark Params.copy method to behave like the Scala implementation.  The main issue was that it did not account for the _defaultParamMap and merged it into the explicitly created param map.\r\n\r\n## How was this patch tested?\r\nAdded new unit test to verify the copy method behaves correctly for copying uid, explicitly created params, and default params.\r\n","created_at":"2017-02-24T04:33:07Z","updated_at":"2017-02-27T20:22:26Z","closed_at":"2017-02-27T20:22:26Z","merged_at":null,"merge_commit_sha":"1181c38f99a98401deaf3753f73deb1bd9dc02d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/17048/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/17048/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/17048/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/adeb5b7ea313662a6ab0803acbda1ec8b88bac9f","head":{"label":"BryanCutler:pyspark-ml-param_copy-Scala_sync-SPARK-14772-2_1","ref":"pyspark-ml-param_copy-Scala_sync-SPARK-14772-2_1","sha":"adeb5b7ea313662a6ab0803acbda1ec8b88bac9f","user":{"login":"BryanCutler","id":4534389,"avatar_url":"https://avatars.githubusercontent.com/u/4534389?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"repo":{"id":34092463,"name":"spark","full_name":"BryanCutler/spark","owner":{"login":"BryanCutler","id":4534389,"avatar_url":"https://avatars.githubusercontent.com/u/4534389?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BryanCutler/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/BryanCutler/spark","forks_url":"https://api.github.com/repos/BryanCutler/spark/forks","keys_url":"https://api.github.com/repos/BryanCutler/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BryanCutler/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BryanCutler/spark/teams","hooks_url":"https://api.github.com/repos/BryanCutler/spark/hooks","issue_events_url":"https://api.github.com/repos/BryanCutler/spark/issues/events{/number}","events_url":"https://api.github.com/repos/BryanCutler/spark/events","assignees_url":"https://api.github.com/repos/BryanCutler/spark/assignees{/user}","branches_url":"https://api.github.com/repos/BryanCutler/spark/branches{/branch}","tags_url":"https://api.github.com/repos/BryanCutler/spark/tags","blobs_url":"https://api.github.com/repos/BryanCutler/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BryanCutler/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BryanCutler/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/BryanCutler/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BryanCutler/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/BryanCutler/spark/languages","stargazers_url":"https://api.github.com/repos/BryanCutler/spark/stargazers","contributors_url":"https://api.github.com/repos/BryanCutler/spark/contributors","subscribers_url":"https://api.github.com/repos/BryanCutler/spark/subscribers","subscription_url":"https://api.github.com/repos/BryanCutler/spark/subscription","commits_url":"https://api.github.com/repos/BryanCutler/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/BryanCutler/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/BryanCutler/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/BryanCutler/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/BryanCutler/spark/contents/{+path}","compare_url":"https://api.github.com/repos/BryanCutler/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BryanCutler/spark/merges","archive_url":"https://api.github.com/repos/BryanCutler/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BryanCutler/spark/downloads","issues_url":"https://api.github.com/repos/BryanCutler/spark/issues{/number}","pulls_url":"https://api.github.com/repos/BryanCutler/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/BryanCutler/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/BryanCutler/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BryanCutler/spark/labels{/name}","releases_url":"https://api.github.com/repos/BryanCutler/spark/releases{/id}","deployments_url":"https://api.github.com/repos/BryanCutler/spark/deployments","created_at":"2015-04-17T02:35:36Z","updated_at":"2016-01-22T20:22:43Z","pushed_at":"2017-02-24T22:54:03Z","git_url":"git://github.com/BryanCutler/spark.git","ssh_url":"git@github.com:BryanCutler/spark.git","clone_url":"https://github.com/BryanCutler/spark.git","svn_url":"https://github.com/BryanCutler/spark","homepage":null,"size":248622,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"arrow-integration"}},"base":{"label":"apache:branch-2.1","ref":"branch-2.1","sha":"43084b3cc3918b720fe28053d2037fa22a71264e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-02-27T17:46:15Z","pushed_at":"2017-02-27T20:17:56Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":263930,"stargazers_count":11817,"watchers_count":11817,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11113,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":461,"forks":11113,"open_issues":461,"watchers":11817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/17048"},"html":{"href":"https://github.com/apache/spark/pull/17048"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/17048"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/17048/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/17048/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/17048/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/adeb5b7ea313662a6ab0803acbda1ec8b88bac9f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"BryanCutler"}}