{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/99472549","pull_request_review_id":20154112,"id":99472549,"diff_hunk":"@@ -0,0 +1,233 @@\n+#ifdef QT_UI","path":"rpcs3/rpcs3qt/mainwindow.cpp","position":1,"original_position":1,"commit_id":"db0da39b32b8f961abf21248a2e659e655e1faee","original_commit_id":"b9f6375dd65df9bd71c41f7f640e533906c5c10c","user":{"login":"danilaml","id":2046350,"avatar_url":"https://avatars.githubusercontent.com/u/2046350?v=3","gravatar_id":"","url":"https://api.github.com/users/danilaml","html_url":"https://github.com/danilaml","followers_url":"https://api.github.com/users/danilaml/followers","following_url":"https://api.github.com/users/danilaml/following{/other_user}","gists_url":"https://api.github.com/users/danilaml/gists{/gist_id}","starred_url":"https://api.github.com/users/danilaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilaml/subscriptions","organizations_url":"https://api.github.com/users/danilaml/orgs","repos_url":"https://api.github.com/users/danilaml/repos","events_url":"https://api.github.com/users/danilaml/events{/privacy}","received_events_url":"https://api.github.com/users/danilaml/received_events","type":"User","site_admin":false},"body":"Yeah, wrong line. But there is a handful of include guard in other files, like `#ifndef CORETAB_H`.\r\nAnyway, this whole qt part seems to follow Qt style (in naming and such), so I guess it's fine for now.","created_at":"2017-02-04T18:47:15Z","updated_at":"2017-02-04T18:47:15Z","html_url":"https://github.com/RPCS3/rpcs3/pull/2336#discussion_r99472549","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/99472549"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/2336#discussion_r99472549"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336","id":104662297,"html_url":"https://github.com/RPCS3/rpcs3/pull/2336","diff_url":"https://github.com/RPCS3/rpcs3/pull/2336.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/2336.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/2336","number":2336,"state":"open","locked":false,"title":"[WIP] Update Qt interface","user":{"login":"Yukariin","id":6450725,"avatar_url":"https://avatars.githubusercontent.com/u/6450725?v=3","gravatar_id":"","url":"https://api.github.com/users/Yukariin","html_url":"https://github.com/Yukariin","followers_url":"https://api.github.com/users/Yukariin/followers","following_url":"https://api.github.com/users/Yukariin/following{/other_user}","gists_url":"https://api.github.com/users/Yukariin/gists{/gist_id}","starred_url":"https://api.github.com/users/Yukariin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yukariin/subscriptions","organizations_url":"https://api.github.com/users/Yukariin/orgs","repos_url":"https://api.github.com/users/Yukariin/repos","events_url":"https://api.github.com/users/Yukariin/events{/privacy}","received_events_url":"https://api.github.com/users/Yukariin/received_events","type":"User","site_admin":false},"body":"I'm starting to work on porting wxWidgets GUI to Qt.\r\nThis is still in early WIP but I plan to port it step by step. Also I open this PR in cases there are anyone who plan to do same.\r\nI decide to use pure C++ variant with using Qt widgets instead of QML+CPP. QML is great for small and easy UI's but when we need a lot of QML<->C++ (in RPCS3 case) communication it become pain in ass with all those QML properties and other stuff on C++ side, imo.","created_at":"2017-02-04T14:11:27Z","updated_at":"2017-02-04T18:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a72b5967107ef3910fb0d3c11ab8d9f70e99769","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/2336/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/db0da39b32b8f961abf21248a2e659e655e1faee","head":{"label":"Yukariin:master","ref":"master","sha":"db0da39b32b8f961abf21248a2e659e655e1faee","user":{"login":"Yukariin","id":6450725,"avatar_url":"https://avatars.githubusercontent.com/u/6450725?v=3","gravatar_id":"","url":"https://api.github.com/users/Yukariin","html_url":"https://github.com/Yukariin","followers_url":"https://api.github.com/users/Yukariin/followers","following_url":"https://api.github.com/users/Yukariin/following{/other_user}","gists_url":"https://api.github.com/users/Yukariin/gists{/gist_id}","starred_url":"https://api.github.com/users/Yukariin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yukariin/subscriptions","organizations_url":"https://api.github.com/users/Yukariin/orgs","repos_url":"https://api.github.com/users/Yukariin/repos","events_url":"https://api.github.com/users/Yukariin/events{/privacy}","received_events_url":"https://api.github.com/users/Yukariin/received_events","type":"User","site_admin":false},"repo":{"id":80844625,"name":"rpcs3","full_name":"Yukariin/rpcs3","owner":{"login":"Yukariin","id":6450725,"avatar_url":"https://avatars.githubusercontent.com/u/6450725?v=3","gravatar_id":"","url":"https://api.github.com/users/Yukariin","html_url":"https://github.com/Yukariin","followers_url":"https://api.github.com/users/Yukariin/followers","following_url":"https://api.github.com/users/Yukariin/following{/other_user}","gists_url":"https://api.github.com/users/Yukariin/gists{/gist_id}","starred_url":"https://api.github.com/users/Yukariin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yukariin/subscriptions","organizations_url":"https://api.github.com/users/Yukariin/orgs","repos_url":"https://api.github.com/users/Yukariin/repos","events_url":"https://api.github.com/users/Yukariin/events{/privacy}","received_events_url":"https://api.github.com/users/Yukariin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yukariin/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/Yukariin/rpcs3","forks_url":"https://api.github.com/repos/Yukariin/rpcs3/forks","keys_url":"https://api.github.com/repos/Yukariin/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yukariin/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yukariin/rpcs3/teams","hooks_url":"https://api.github.com/repos/Yukariin/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/Yukariin/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/Yukariin/rpcs3/events","assignees_url":"https://api.github.com/repos/Yukariin/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/Yukariin/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/Yukariin/rpcs3/tags","blobs_url":"https://api.github.com/repos/Yukariin/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yukariin/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yukariin/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yukariin/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yukariin/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/Yukariin/rpcs3/languages","stargazers_url":"https://api.github.com/repos/Yukariin/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/Yukariin/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/Yukariin/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/Yukariin/rpcs3/subscription","commits_url":"https://api.github.com/repos/Yukariin/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yukariin/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yukariin/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yukariin/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yukariin/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/Yukariin/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yukariin/rpcs3/merges","archive_url":"https://api.github.com/repos/Yukariin/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yukariin/rpcs3/downloads","issues_url":"https://api.github.com/repos/Yukariin/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/Yukariin/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/Yukariin/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/Yukariin/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yukariin/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/Yukariin/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/Yukariin/rpcs3/deployments","created_at":"2017-02-03T16:02:28Z","updated_at":"2017-02-03T16:02:33Z","pushed_at":"2017-02-04T18:02:46Z","git_url":"git://github.com/Yukariin/rpcs3.git","ssh_url":"git@github.com:Yukariin/rpcs3.git","clone_url":"https://github.com/Yukariin/rpcs3.git","svn_url":"https://github.com/Yukariin/rpcs3","homepage":"https://rpcs3.net/","size":30332,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"758f1bcdee4a54cb49fa148317cf83de2d4d5653","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2017-02-04T14:54:26Z","pushed_at":"2017-02-04T18:02:48Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":30326,"stargazers_count":2477,"watchers_count":2477,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":174,"forks":503,"open_issues":174,"watchers":2477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/2336"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/2336"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/2336/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/2336/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/db0da39b32b8f961abf21248a2e659e655e1faee"}}}}
{"actor":{"display_login":"danilaml"}}