{"action":"opened","issue":{"url":"https://api.github.com/repos/connornishijima/TinySnore/issues/1","repository_url":"https://api.github.com/repos/connornishijima/TinySnore","labels_url":"https://api.github.com/repos/connornishijima/TinySnore/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/connornishijima/TinySnore/issues/1/comments","events_url":"https://api.github.com/repos/connornishijima/TinySnore/issues/1/events","html_url":"https://github.com/connornishijima/TinySnore/issues/1","id":228953502,"number":1,"title":"Minor cleanup tips","user":{"login":"Floessie","id":10133457,"avatar_url":"https://avatars0.githubusercontent.com/u/10133457?v=3","gravatar_id":"","url":"https://api.github.com/users/Floessie","html_url":"https://github.com/Floessie","followers_url":"https://api.github.com/users/Floessie/followers","following_url":"https://api.github.com/users/Floessie/following{/other_user}","gists_url":"https://api.github.com/users/Floessie/gists{/gist_id}","starred_url":"https://api.github.com/users/Floessie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Floessie/subscriptions","organizations_url":"https://api.github.com/users/Floessie/orgs","repos_url":"https://api.github.com/users/Floessie/repos","events_url":"https://api.github.com/users/Floessie/events{/privacy}","received_events_url":"https://api.github.com/users/Floessie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-16T08:30:44Z","updated_at":"2017-05-16T08:30:44Z","closed_at":null,"body":"Hi Connor,\r\n\r\nI coincidentally came by here. This is a fine and useful lib. I just wanted to mention two things you could improve:\r\n\r\n1. Move the `avr/*` includes from the header to the implementation, as they are only needed there.\r\n2. The `void ts_*();` functions are only needed by the implementation. Thus, move them to an anonymous namespace at the top of your implementation.\r\n\r\nJust my 2¢. :wink: \r\n\r\nBest\r\nFlössie\r\n\r\nPS: [The manual](http://www.nongnu.org/avr-libc/user-manual/group__avr__sleep.html) says, that \"there is a limited number of cycles after the BOD has been disabled that the device can be put into sleep mode, otherwise the BOD will not truly be disabled\". Are you sure, `ts_set_sleep()` is short enough?"}}
{"actor":{"display_login":"Floessie"}}