{"action":"created","issue":{"url":"https://api.github.com/repos/dan200/ComputerCraft/issues/243","repository_url":"https://api.github.com/repos/dan200/ComputerCraft","labels_url":"https://api.github.com/repos/dan200/ComputerCraft/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/dan200/ComputerCraft/issues/243/comments","events_url":"https://api.github.com/repos/dan200/ComputerCraft/issues/243/events","html_url":"https://github.com/dan200/ComputerCraft/pull/243","id":228551071,"number":243,"title":"Replace reflection with access transformers","user":{"login":"SquidDev","id":4346137,"avatar_url":"https://avatars0.githubusercontent.com/u/4346137?v=3","gravatar_id":"","url":"https://api.github.com/users/SquidDev","html_url":"https://github.com/SquidDev","followers_url":"https://api.github.com/users/SquidDev/followers","following_url":"https://api.github.com/users/SquidDev/following{/other_user}","gists_url":"https://api.github.com/users/SquidDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SquidDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquidDev/subscriptions","organizations_url":"https://api.github.com/users/SquidDev/orgs","repos_url":"https://api.github.com/users/SquidDev/repos","events_url":"https://api.github.com/users/SquidDev/events{/privacy}","received_events_url":"https://api.github.com/users/SquidDev/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-05-14T16:05:53Z","updated_at":"2017-05-16T19:55:24Z","closed_at":"2017-05-16T18:25:11Z","pull_request":{"url":"https://api.github.com/repos/dan200/ComputerCraft/pulls/243","html_url":"https://github.com/dan200/ComputerCraft/pull/243","diff_url":"https://github.com/dan200/ComputerCraft/pull/243.diff","patch_url":"https://github.com/dan200/ComputerCraft/pull/243.patch"},"body":"This makes the code slightly neater and allows us to catch places where the variable/function has been renamed between Minecraft versions (such as `createStackedBlock`).\r\n\r\nWorth noting that people may have to run `./setup.sh` again, as some IDEs won't pick up on the changes."},"comment":{"url":"https://api.github.com/repos/dan200/ComputerCraft/issues/comments/301896871","html_url":"https://github.com/dan200/ComputerCraft/pull/243#issuecomment-301896871","issue_url":"https://api.github.com/repos/dan200/ComputerCraft/issues/243","id":301896871,"user":{"login":"SquidDev","id":4346137,"avatar_url":"https://avatars0.githubusercontent.com/u/4346137?v=3","gravatar_id":"","url":"https://api.github.com/users/SquidDev","html_url":"https://github.com/SquidDev","followers_url":"https://api.github.com/users/SquidDev/followers","following_url":"https://api.github.com/users/SquidDev/following{/other_user}","gists_url":"https://api.github.com/users/SquidDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SquidDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquidDev/subscriptions","organizations_url":"https://api.github.com/users/SquidDev/orgs","repos_url":"https://api.github.com/users/SquidDev/repos","events_url":"https://api.github.com/users/SquidDev/events{/privacy}","received_events_url":"https://api.github.com/users/SquidDev/received_events","type":"User","site_admin":false},"created_at":"2017-05-16T19:55:24Z","updated_at":"2017-05-16T19:55:24Z","body":"Right, I'm really sorry about this. I was under the impression that ATs propagated to child classes (that is what my testing had indicated). However, after digging through the AT implementation, it appears they do not. I'd tested the compiling the jar, and running it an obfuscated and obfuscated environment but hadn't actually decompiled it, and therefore didn't notice this. I'm really, really sorry.\r\n\r\nWhilst the two patches for records may be kept, I will need to revert the changes to (`Block.createStackedBlock`, as used by `TurtleCompareCommand`). I don't know if you want me to create another PR to do that or just do it yourself. If so, it's worth noting that the function name has also changed from `func_149644_j` to `func_180643_i`."}}
{"actor":{"display_login":"SquidDev"}}