{"action":"created","comment":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/102851195","pull_request_review_id":23621523,"id":102851195,"diff_hunk":"@@ -2,6 +2,7 @@\n \n import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;\n import javax.annotation.CheckReturnValue;\n+import javax.annotation.OverridingMethodsMustInvokeSuper;","path":"java/src/jmri/implementation/AbstractNamedBean.java","position":4,"original_position":4,"commit_id":"5ecb248efac7f26ecd690370f5b36899dee25f60","original_commit_id":"5ecb248efac7f26ecd690370f5b36899dee25f60","user":{"login":"rhwood","id":297232,"avatar_url":"https://avatars.githubusercontent.com/u/297232?v=3","gravatar_id":"","url":"https://api.github.com/users/rhwood","html_url":"https://github.com/rhwood","followers_url":"https://api.github.com/users/rhwood/followers","following_url":"https://api.github.com/users/rhwood/following{/other_user}","gists_url":"https://api.github.com/users/rhwood/gists{/gist_id}","starred_url":"https://api.github.com/users/rhwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhwood/subscriptions","organizations_url":"https://api.github.com/users/rhwood/orgs","repos_url":"https://api.github.com/users/rhwood/repos","events_url":"https://api.github.com/users/rhwood/events{/privacy}","received_events_url":"https://api.github.com/users/rhwood/received_events","type":"User","site_admin":false},"body":"For a lot of the methods marked with this annotation, might it not be preferable to make those methods final?","created_at":"2017-02-24T00:04:52Z","updated_at":"2017-02-24T00:04:52Z","html_url":"https://github.com/JMRI/JMRI/pull/3130#discussion_r102851195","pull_request_url":"https://api.github.com/repos/JMRI/JMRI/pulls/3130","_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/102851195"},"html":{"href":"https://github.com/JMRI/JMRI/pull/3130#discussion_r102851195"},"pull_request":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/3130"}}},"pull_request":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/3130","id":107731563,"html_url":"https://github.com/JMRI/JMRI/pull/3130","diff_url":"https://github.com/JMRI/JMRI/pull/3130.diff","patch_url":"https://github.com/JMRI/JMRI/pull/3130.patch","issue_url":"https://api.github.com/repos/JMRI/JMRI/issues/3130","number":3130,"state":"open","locked":false,"title":"Infrastructure for normalizing usernames","user":{"login":"bobjacobsen","id":2774117,"avatar_url":"https://avatars.githubusercontent.com/u/2774117?v=3","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false},"body":"Adds infrastructure and associated corrections for normalizing (in whatever form decided) the format of user names on all NamedBeans.\r\n\r\n- The normalization is currently turned off.  To e.g. add a `trim(..)` operation, add it in the `normalizeUserNames(..)` method at the bottom of `jmri.NamedBean`\r\n\r\n- When normalization is finally turned on, it'll be enforced when a bean is created or has it's user name changed, including when loading from a Panel XML file.  If the normalization operation changes the name, a message like the falling is logged. Note removal of trailing spaces.\r\n```\r\nWARN  - Requested user name \"Biff  \" for system name \"LS3\" was normalized to \"Biff\"\r\n```\r\n\r\n- If a duplicate user name appears while loading (either due to normalization or for any other reason), a message will be logged:\r\n```\r\nWARN  - User name \"Biff\" already exists as system name \"LS1\"\r\n```\r\n\r\nNote: No significant user cueing has been added to GUI elements.  That's for another day, when hopefully we'll create a small number of standard input widgets to handle this.","created_at":"2017-02-23T22:53:54Z","updated_at":"2017-02-24T00:04:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77d7b6ae8ae5a0c609b6268e690e5e0819b9238e","assignee":{"login":"bobjacobsen","id":2774117,"avatar_url":"https://avatars.githubusercontent.com/u/2774117?v=3","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false},"assignees":[{"login":"bobjacobsen","id":2774117,"avatar_url":"https://avatars.githubusercontent.com/u/2774117?v=3","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JMRI/JMRI/pulls/3130/commits","review_comments_url":"https://api.github.com/repos/JMRI/JMRI/pulls/3130/comments","review_comment_url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JMRI/JMRI/issues/3130/comments","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/5ecb248efac7f26ecd690370f5b36899dee25f60","head":{"label":"bobjacobsen:normalize-usernames","ref":"normalize-usernames","sha":"5ecb248efac7f26ecd690370f5b36899dee25f60","user":{"login":"bobjacobsen","id":2774117,"avatar_url":"https://avatars.githubusercontent.com/u/2774117?v=3","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false},"repo":{"id":42793291,"name":"JMRI","full_name":"bobjacobsen/JMRI","owner":{"login":"bobjacobsen","id":2774117,"avatar_url":"https://avatars.githubusercontent.com/u/2774117?v=3","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobjacobsen/JMRI","description":null,"fork":true,"url":"https://api.github.com/repos/bobjacobsen/JMRI","forks_url":"https://api.github.com/repos/bobjacobsen/JMRI/forks","keys_url":"https://api.github.com/repos/bobjacobsen/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobjacobsen/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobjacobsen/JMRI/teams","hooks_url":"https://api.github.com/repos/bobjacobsen/JMRI/hooks","issue_events_url":"https://api.github.com/repos/bobjacobsen/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/bobjacobsen/JMRI/events","assignees_url":"https://api.github.com/repos/bobjacobsen/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/bobjacobsen/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/bobjacobsen/JMRI/tags","blobs_url":"https://api.github.com/repos/bobjacobsen/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobjacobsen/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobjacobsen/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobjacobsen/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobjacobsen/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/bobjacobsen/JMRI/languages","stargazers_url":"https://api.github.com/repos/bobjacobsen/JMRI/stargazers","contributors_url":"https://api.github.com/repos/bobjacobsen/JMRI/contributors","subscribers_url":"https://api.github.com/repos/bobjacobsen/JMRI/subscribers","subscription_url":"https://api.github.com/repos/bobjacobsen/JMRI/subscription","commits_url":"https://api.github.com/repos/bobjacobsen/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobjacobsen/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobjacobsen/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobjacobsen/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobjacobsen/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/bobjacobsen/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobjacobsen/JMRI/merges","archive_url":"https://api.github.com/repos/bobjacobsen/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobjacobsen/JMRI/downloads","issues_url":"https://api.github.com/repos/bobjacobsen/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/bobjacobsen/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/bobjacobsen/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/bobjacobsen/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobjacobsen/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/bobjacobsen/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/bobjacobsen/JMRI/deployments","created_at":"2015-09-19T23:27:53Z","updated_at":"2016-01-11T03:15:25Z","pushed_at":"2017-02-23T23:14:46Z","git_url":"git://github.com/bobjacobsen/JMRI.git","ssh_url":"git@github.com:bobjacobsen/JMRI.git","clone_url":"https://github.com/bobjacobsen/JMRI.git","svn_url":"https://github.com/bobjacobsen/JMRI","homepage":"http://jmri.org","size":1449145,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JMRI:master","ref":"master","sha":"530265012ee8364509a1afc0158efc8a9b23bd54","user":{"login":"JMRI","id":13712710,"avatar_url":"https://avatars.githubusercontent.com/u/13712710?v=3","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"repo":{"id":42789514,"name":"JMRI","full_name":"JMRI/JMRI","owner":{"login":"JMRI","id":13712710,"avatar_url":"https://avatars.githubusercontent.com/u/13712710?v=3","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JMRI/JMRI","description":"JMRI model railroad digital command & control software","fork":false,"url":"https://api.github.com/repos/JMRI/JMRI","forks_url":"https://api.github.com/repos/JMRI/JMRI/forks","keys_url":"https://api.github.com/repos/JMRI/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JMRI/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JMRI/JMRI/teams","hooks_url":"https://api.github.com/repos/JMRI/JMRI/hooks","issue_events_url":"https://api.github.com/repos/JMRI/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/JMRI/JMRI/events","assignees_url":"https://api.github.com/repos/JMRI/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/JMRI/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/JMRI/JMRI/tags","blobs_url":"https://api.github.com/repos/JMRI/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JMRI/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JMRI/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/JMRI/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/JMRI/JMRI/languages","stargazers_url":"https://api.github.com/repos/JMRI/JMRI/stargazers","contributors_url":"https://api.github.com/repos/JMRI/JMRI/contributors","subscribers_url":"https://api.github.com/repos/JMRI/JMRI/subscribers","subscription_url":"https://api.github.com/repos/JMRI/JMRI/subscription","commits_url":"https://api.github.com/repos/JMRI/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/JMRI/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/JMRI/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/JMRI/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/JMRI/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/JMRI/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JMRI/JMRI/merges","archive_url":"https://api.github.com/repos/JMRI/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JMRI/JMRI/downloads","issues_url":"https://api.github.com/repos/JMRI/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/JMRI/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/JMRI/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/JMRI/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JMRI/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/JMRI/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/JMRI/JMRI/deployments","created_at":"2015-09-19T21:01:07Z","updated_at":"2017-02-22T17:45:12Z","pushed_at":"2017-02-23T23:14:47Z","git_url":"git://github.com/JMRI/JMRI.git","ssh_url":"git@github.com:JMRI/JMRI.git","clone_url":"https://github.com/JMRI/JMRI.git","svn_url":"https://github.com/JMRI/JMRI","homepage":"http://jmri.org","size":1436607,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":129,"forks":83,"open_issues":129,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/3130"},"html":{"href":"https://github.com/JMRI/JMRI/pull/3130"},"issue":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/3130"},"comments":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/3130/comments"},"review_comments":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/3130/comments"},"review_comment":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/3130/commits"},"statuses":{"href":"https://api.github.com/repos/JMRI/JMRI/statuses/5ecb248efac7f26ecd690370f5b36899dee25f60"}}}}
{"actor":{"display_login":"rhwood"}}