{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/chronos/pulls/comments/109365306","pull_request_review_id":30461318,"id":109365306,"diff_hunk":"@@ -0,0 +1,76 @@\n+<?php\n+/**\n+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)\n+ *\n+ * Licensed under The MIT License\n+ * Redistributions of files must retain the above copyright notice.\n+ *\n+ * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)\n+ * @copyright     Copyright (c) Brian Nesbitt <brian@nesbot.com>\n+ * @link          http://cakephp.org CakePHP(tm) Project\n+ * @license       http://www.opensource.org/licenses/mit-license.php MIT License\n+ */\n+\n+namespace Cake\\Chronos\\Test\\DateTime;\n+\n+use TestCase;\n+\n+class DstHandlingTest extends TestCase\n+{\n+    /**\n+     * Tests that daylight saving hours counts in the right way to different modify arguments\n+     *\n+     * @param string $dateString date string wich should be modified\n+     * @param string $timezone   timezone string in wich $dateString is\n+     * @param string $modify     modify argument\n+     * @param string $expected   date, that shoud be maked after modifying $dateString in the format: 'Y-m-d H:i:s P'\n+     *\n+     * @dataProvider modifyOnDstChangeProvider\n+     * @return void\n+     */\n+    public function testModifyOnDstChange($className, $dateString, $timezone, $modify, $expected)\n+    {\n+        $date = new $className($dateString, $timezone);\n+        $date = $date->modify($modify);\n+        $this->assertSame($expected, $date->format('Y-m-d H:i:s P'));\n+    }\n+    \n+    /**\n+     * Provider for testModifyOnDstChange\n+     *\n+     * DayLight saving hours should be counted only if date is modifying by hours or smaller units.\n+     */\n+    public function getModifyOnDstChangeTests($className)\n+    {\n+        return array(\n+            array($className, '2014-03-30 00:00:00', 'UTC'          , '+86400 sec'   , '2014-03-31 00:00:00 +00:00'),","path":"tests/DateTime/DstHandlingTest.php","position":46,"original_position":46,"commit_id":"f3d987aefe5455f1a0f983fdaa8eca7668d3e675","original_commit_id":"f3d987aefe5455f1a0f983fdaa8eca7668d3e675","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars0.githubusercontent.com/u/16011037?v=3","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"Short array syntax must be used to define arrays\nDouble space found\nSpace before comma, expected none, though","created_at":"2017-04-03T08:45:41Z","updated_at":"2017-04-03T08:45:41Z","html_url":"https://github.com/cakephp/chronos/pull/138#discussion_r109365306","pull_request_url":"https://api.github.com/repos/cakephp/chronos/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/comments/109365306"},"html":{"href":"https://github.com/cakephp/chronos/pull/138#discussion_r109365306"},"pull_request":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/chronos/pulls/138","id":113882318,"html_url":"https://github.com/cakephp/chronos/pull/138","diff_url":"https://github.com/cakephp/chronos/pull/138.diff","patch_url":"https://github.com/cakephp/chronos/pull/138.patch","issue_url":"https://api.github.com/repos/cakephp/chronos/issues/138","number":138,"state":"open","locked":false,"title":"Implementation of issue #135 DST handling while date modifying","user":{"login":"Ovsyanka","id":1226722,"avatar_url":"https://avatars1.githubusercontent.com/u/1226722?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovsyanka","html_url":"https://github.com/Ovsyanka","followers_url":"https://api.github.com/users/Ovsyanka/followers","following_url":"https://api.github.com/users/Ovsyanka/following{/other_user}","gists_url":"https://api.github.com/users/Ovsyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovsyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovsyanka/subscriptions","organizations_url":"https://api.github.com/users/Ovsyanka/orgs","repos_url":"https://api.github.com/users/Ovsyanka/repos","events_url":"https://api.github.com/users/Ovsyanka/events{/privacy}","received_events_url":"https://api.github.com/users/Ovsyanka/received_events","type":"User","site_admin":false},"body":"While writing this code i realised that i dont like this \"Traits\" approach. And i think it will be better to implement two different overloades of modify method for both mutable and immutable objects. But i am not sure, so i asking yfor your suggestions and corrections. Thank you!","created_at":"2017-04-03T08:45:26Z","updated_at":"2017-04-03T08:45:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c669a06b0ccca146acb8ebd98a77c614369c9c83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/chronos/pulls/138/commits","review_comments_url":"https://api.github.com/repos/cakephp/chronos/pulls/138/comments","review_comment_url":"https://api.github.com/repos/cakephp/chronos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/chronos/issues/138/comments","statuses_url":"https://api.github.com/repos/cakephp/chronos/statuses/f3d987aefe5455f1a0f983fdaa8eca7668d3e675","head":{"label":"Ovsyanka:dstChangeHandlingInModify","ref":"dstChangeHandlingInModify","sha":"f3d987aefe5455f1a0f983fdaa8eca7668d3e675","user":{"login":"Ovsyanka","id":1226722,"avatar_url":"https://avatars1.githubusercontent.com/u/1226722?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovsyanka","html_url":"https://github.com/Ovsyanka","followers_url":"https://api.github.com/users/Ovsyanka/followers","following_url":"https://api.github.com/users/Ovsyanka/following{/other_user}","gists_url":"https://api.github.com/users/Ovsyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovsyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovsyanka/subscriptions","organizations_url":"https://api.github.com/users/Ovsyanka/orgs","repos_url":"https://api.github.com/users/Ovsyanka/repos","events_url":"https://api.github.com/users/Ovsyanka/events{/privacy}","received_events_url":"https://api.github.com/users/Ovsyanka/received_events","type":"User","site_admin":false},"repo":{"id":86918311,"name":"chronos","full_name":"Ovsyanka/chronos","owner":{"login":"Ovsyanka","id":1226722,"avatar_url":"https://avatars1.githubusercontent.com/u/1226722?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovsyanka","html_url":"https://github.com/Ovsyanka","followers_url":"https://api.github.com/users/Ovsyanka/followers","following_url":"https://api.github.com/users/Ovsyanka/following{/other_user}","gists_url":"https://api.github.com/users/Ovsyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovsyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovsyanka/subscriptions","organizations_url":"https://api.github.com/users/Ovsyanka/orgs","repos_url":"https://api.github.com/users/Ovsyanka/repos","events_url":"https://api.github.com/users/Ovsyanka/events{/privacy}","received_events_url":"https://api.github.com/users/Ovsyanka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ovsyanka/chronos","description":"A standalone DateTime library originally based off of Carbon","fork":true,"url":"https://api.github.com/repos/Ovsyanka/chronos","forks_url":"https://api.github.com/repos/Ovsyanka/chronos/forks","keys_url":"https://api.github.com/repos/Ovsyanka/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ovsyanka/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ovsyanka/chronos/teams","hooks_url":"https://api.github.com/repos/Ovsyanka/chronos/hooks","issue_events_url":"https://api.github.com/repos/Ovsyanka/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/Ovsyanka/chronos/events","assignees_url":"https://api.github.com/repos/Ovsyanka/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/Ovsyanka/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/Ovsyanka/chronos/tags","blobs_url":"https://api.github.com/repos/Ovsyanka/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ovsyanka/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ovsyanka/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ovsyanka/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ovsyanka/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/Ovsyanka/chronos/languages","stargazers_url":"https://api.github.com/repos/Ovsyanka/chronos/stargazers","contributors_url":"https://api.github.com/repos/Ovsyanka/chronos/contributors","subscribers_url":"https://api.github.com/repos/Ovsyanka/chronos/subscribers","subscription_url":"https://api.github.com/repos/Ovsyanka/chronos/subscription","commits_url":"https://api.github.com/repos/Ovsyanka/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ovsyanka/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ovsyanka/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ovsyanka/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ovsyanka/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/Ovsyanka/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ovsyanka/chronos/merges","archive_url":"https://api.github.com/repos/Ovsyanka/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ovsyanka/chronos/downloads","issues_url":"https://api.github.com/repos/Ovsyanka/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/Ovsyanka/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/Ovsyanka/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/Ovsyanka/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ovsyanka/chronos/labels{/name}","releases_url":"https://api.github.com/repos/Ovsyanka/chronos/releases{/id}","deployments_url":"https://api.github.com/repos/Ovsyanka/chronos/deployments","created_at":"2017-04-01T14:19:43Z","updated_at":"2017-04-01T14:19:45Z","pushed_at":"2017-04-03T08:41:21Z","git_url":"git://github.com/Ovsyanka/chronos.git","ssh_url":"git@github.com:Ovsyanka/chronos.git","clone_url":"https://github.com/Ovsyanka/chronos.git","svn_url":"https://github.com/Ovsyanka/chronos","homepage":"http://book.cakephp.org/3.0/en/chronos.html","size":377,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"26385a9a2966350f7c5df34a6a54e641a538131e","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars3.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":42588972,"name":"chronos","full_name":"cakephp/chronos","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars3.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/chronos","description":"A standalone DateTime library originally based off of Carbon","fork":false,"url":"https://api.github.com/repos/cakephp/chronos","forks_url":"https://api.github.com/repos/cakephp/chronos/forks","keys_url":"https://api.github.com/repos/cakephp/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/chronos/teams","hooks_url":"https://api.github.com/repos/cakephp/chronos/hooks","issue_events_url":"https://api.github.com/repos/cakephp/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/chronos/events","assignees_url":"https://api.github.com/repos/cakephp/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/chronos/tags","blobs_url":"https://api.github.com/repos/cakephp/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/chronos/languages","stargazers_url":"https://api.github.com/repos/cakephp/chronos/stargazers","contributors_url":"https://api.github.com/repos/cakephp/chronos/contributors","subscribers_url":"https://api.github.com/repos/cakephp/chronos/subscribers","subscription_url":"https://api.github.com/repos/cakephp/chronos/subscription","commits_url":"https://api.github.com/repos/cakephp/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/chronos/merges","archive_url":"https://api.github.com/repos/cakephp/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/chronos/downloads","issues_url":"https://api.github.com/repos/cakephp/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/chronos/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/chronos/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/chronos/deployments","created_at":"2015-09-16T13:30:45Z","updated_at":"2017-04-02T05:03:35Z","pushed_at":"2017-04-03T08:45:26Z","git_url":"git://github.com/cakephp/chronos.git","ssh_url":"git@github.com:cakephp/chronos.git","clone_url":"https://github.com/cakephp/chronos.git","svn_url":"https://github.com/cakephp/chronos","homepage":"http://book.cakephp.org/3.0/en/chronos.html","size":378,"stargazers_count":302,"watchers_count":302,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":11,"forks":26,"open_issues":11,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/138"},"html":{"href":"https://github.com/cakephp/chronos/pull/138"},"issue":{"href":"https://api.github.com/repos/cakephp/chronos/issues/138"},"comments":{"href":"https://api.github.com/repos/cakephp/chronos/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/chronos/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/chronos/statuses/f3d987aefe5455f1a0f983fdaa8eca7668d3e675"}}}}
{"actor":{"display_login":"stickler-ci"}}