{"action":"created","issue":{"url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/488","repository_url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage","labels_url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/488/comments","events_url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/488/events","html_url":"https://github.com/sebastianbergmann/php-code-coverage/issues/488","id":192243130,"number":488,"title":"Executable code not shown as executed/executable","user":{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"labels":[{"id":19358,"url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/labels/bug","name":"bug","color":"ff0000","default":true},{"id":240862429,"url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/labels/xdebug","name":"xdebug","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebastianbergmann","id":25218,"avatar_url":"https://avatars.githubusercontent.com/u/25218?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2016-11-29T10:27:08Z","updated_at":"2017-01-08T13:59:51Z","closed_at":null,"body":"Moved here from #411 (where more than one issue was discussed).\r\n\r\n## Environment\r\n* Linux\r\n* PHP 7.1.0RC6\r\n* Xdebug 2.5.0RC1\r\n* PHPUnit 5.6.7\r\n* php-code-coverage 4.0.3\r\n\r\n## Steps to reproduce\r\n```\r\ngit clone https://github.com/ramsey/uuid-doctrine.git\r\ncd uuid-doctrine\r\ngit checkout abbcbe56b023319dea7a72177333089cf47f5a69\r\ncomposer install\r\n./vendor/bin/phpunit\r\n```\r\n\r\n## Actual result\r\n![e9f95398-d168-11e5-901a-a8b81661e3a2](https://cloud.githubusercontent.com/assets/25218/20706236/9494ee8c-b626-11e6-992d-8001da70cf06.png)\r\n\r\n## Expected result\r\nLines 50-52 of the `uuid-doctrine/src/UuidBinaryType.php` files should not be white."},"comment":{"url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/comments/271152897","html_url":"https://github.com/sebastianbergmann/php-code-coverage/issues/488#issuecomment-271152897","issue_url":"https://api.github.com/repos/sebastianbergmann/php-code-coverage/issues/488","id":271152897,"user":{"login":"lordelph","id":444004,"avatar_url":"https://avatars.githubusercontent.com/u/444004?v=3","gravatar_id":"","url":"https://api.github.com/users/lordelph","html_url":"https://github.com/lordelph","followers_url":"https://api.github.com/users/lordelph/followers","following_url":"https://api.github.com/users/lordelph/following{/other_user}","gists_url":"https://api.github.com/users/lordelph/gists{/gist_id}","starred_url":"https://api.github.com/users/lordelph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordelph/subscriptions","organizations_url":"https://api.github.com/users/lordelph/orgs","repos_url":"https://api.github.com/users/lordelph/repos","events_url":"https://api.github.com/users/lordelph/events{/privacy}","received_events_url":"https://api.github.com/users/lordelph/received_events","type":"User","site_admin":false},"created_at":"2017-01-08T13:59:51Z","updated_at":"2017-01-08T13:59:51Z","body":"That's some good work JoepRoebroek :)\r\n\r\nCould a reasonable fix (at least for 7.0/7.1) simply be for xdebug to pick a different bit for `ZEND_XDEBUG_VISITED`? PHP internals aren't my thing, but I've done a bit of legwork here which might help...\r\n\r\nIt appears xdebug defines this as `#define ZEND_XDEBUG_VISITED 0x1000000` [(source)](https://github.com/xdebug/xdebug/blob/d50f2732a288ad84ed425931c5e80b63e18006f6/xdebug_private.h#L132)\r\n\r\nThis is the same value as  `#define ZEND_ACC_USE_GUARDS\t 0x1000000`[(source)](https://github.com/php/php-src/blob/c8aa6f3a9a3d2c114d0c5e0c9fdd0a465dbb54a5/Zend/zend_compile.h#L279), so it looks like JoepRoebroek hypothesis is correct.\r\n\r\nI did [a search through php-src](https://github.com/php/php-src/search?utf8=%E2%9C%93&q=ce_flags) to find what other bits might be used by `ce_flags`, I came up with this list of constants which are actually referenced (there's a few times where some magic numbers are used instead of constants, but I caught those too).\r\n\r\n```\r\nZEND_ACC_ABSTRACT                       0x02\r\nZEND_ACC_FINAL                          0x04\r\nZEND_ACC_IMPLICIT_ABSTRACT_CLASS        0x10\r\nZEND_ACC_EXPLICIT_ABSTRACT_CLASS        0x20\r\nZEND_ACC_INTERFACE                      0x40\r\nZEND_ACC_TRAIT                          0x80\r\nZEND_ACC_ANON_CLASS                    0x100\r\nZEND_ACC_ANON_BOUND                    0x200\r\nZEND_ACC_IMPLEMENT_INTERFACES        0x80000\r\nZEND_ACC_CONSTANTS_UPDATED          0x100000\r\nZEND_ACC_IMPLEMENT_TRAITS           0x400000\r\nZEND_HAS_STATIC_IN_METHODS          0x800000\r\nZEND_ACC_USE_GUARDS                0x1000000\r\n\r\n#so I humbly suggest\r\nZEND_XDEBUG_VISITED               0x10000000\r\n```\r\nSo, I'd suggest a value of `0x10000000`. That bit does not appear to currently referenced in `ce_flags`. This is the same value as `ZEND_ACC_HAS_TYPE_HINTS` but that flag is used in `fn_flags`, and not `ce_flags`. \r\n\r\nHope that helps!\r\n"}}
{"actor":{"display_login":"lordelph"}}