{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/106654057","pull_request_review_id":27588678,"id":106654057,"diff_hunk":"@@ -282,6 +282,32 @@ public function testAccessDeniedForListingChannels()\n         $this->assertSame($expectedResponse, json_decode($response->getContent(), true));\n     }\n \n+    public function testAccessGrantedForListingLocales()\n+    {\n+        $client = $this->createAuthenticatedClient();\n+\n+        $client->request('GET', '/api/rest/v1/locales');\n+\n+        $response = $client->getResponse();\n+        $this->assertSame(Response::HTTP_OK, $response->getStatusCode());\n+    }\n+\n+    public function testAccessDeniedForListingLocales()\n+    {\n+        $client = $this->createAuthenticatedClient([], [], null, null, 'julia', 'julia');\n+\n+        $client->request('GET', '/api/rest/v1/locales');\n+\n+        $expectedResponse = [\n+            'code'    => 403,\n+            'message' => 'Access forbidden. You are not allowed to list locales.',\n+        ];\n+\n+        $response = $client->getResponse();\n+        $this->assertSame(Response::HTTP_FORBIDDEN, $response->getStatusCode());\n+        $this->assertSame($expectedResponse, json_decode($response->getContent(), true));","path":"src/Pim/Bundle/ApiBundle/tests/integration/Security/AuthorizationIntegration.php","position":27,"original_position":27,"commit_id":"89843ae2df395725ec3db569c54c222a0fe015ed","original_commit_id":"89843ae2df395725ec3db569c54c222a0fe015ed","user":{"login":"skeleton","id":1131230,"avatar_url":"https://avatars2.githubusercontent.com/u/1131230?v=3","gravatar_id":"","url":"https://api.github.com/users/skeleton","html_url":"https://github.com/skeleton","followers_url":"https://api.github.com/users/skeleton/followers","following_url":"https://api.github.com/users/skeleton/following{/other_user}","gists_url":"https://api.github.com/users/skeleton/gists{/gist_id}","starred_url":"https://api.github.com/users/skeleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeleton/subscriptions","organizations_url":"https://api.github.com/users/skeleton/orgs","repos_url":"https://api.github.com/users/skeleton/repos","events_url":"https://api.github.com/users/skeleton/events{/privacy}","received_events_url":"https://api.github.com/users/skeleton/received_events","type":"User","site_admin":false},"body":"use assertJsonStringEqualsJsonString and compare the expected response with the response without decode it please","created_at":"2017-03-17T13:55:04Z","updated_at":"2017-03-17T13:58:39Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/5943#discussion_r106654057","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/106654057"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5943#discussion_r106654057"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943","id":111283635,"html_url":"https://github.com/akeneo/pim-community-dev/pull/5943","diff_url":"https://github.com/akeneo/pim-community-dev/pull/5943.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/5943.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5943","number":5943,"state":"open","locked":false,"title":"Pim 6253 : add missing permissions on entities of the API","user":{"login":"ahocquard","id":1942439,"avatar_url":"https://avatars3.githubusercontent.com/u/1942439?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocquard","html_url":"https://github.com/ahocquard","followers_url":"https://api.github.com/users/ahocquard/followers","following_url":"https://api.github.com/users/ahocquard/following{/other_user}","gists_url":"https://api.github.com/users/ahocquard/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocquard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocquard/subscriptions","organizations_url":"https://api.github.com/users/ahocquard/orgs","repos_url":"https://api.github.com/users/ahocquard/repos","events_url":"https://api.github.com/users/ahocquard/events{/privacy}","received_events_url":"https://api.github.com/users/ahocquard/received_events","type":"User","site_admin":false},"body":"[//]: <> (<3 Thanks for taking the time to contribute! You're awesome! <3)\r\n\r\n[//]: <> (If you've never contributed to this repository before, please read https://github.com/akeneo/pim-community-dev/blob/master/.github/CONTRIBUTING.md)\r\n\r\n**Description (for Contributor and Core Developer)**\r\n\r\nSome permissions were missing :( \r\n\r\n[//]: <> (What does this Pull Request do? reference the related issue?)\r\n\r\n**Definition Of Done (for Core Developer only)**\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | -\r\n| Added Behats                      | -\r\n| Added integration tests           | Ok\r\n| Changelog updated                 | Ok\r\n| Review and 2 GTM                  | Todo\r\n| Micro Demo to the PO (Story only) | Todo\r\n| Migration script                  | -\r\n| Tech Doc                          | -\r\n\r\n`Todo`: Pending / Work in progress\r\n`OK`: Done / Validated\r\n`-`: Not needed\r\n","created_at":"2017-03-17T13:44:49Z","updated_at":"2017-03-17T13:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ed4a75e52b75178011eb7ed370b681636365649","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5943/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/89843ae2df395725ec3db569c54c222a0fe015ed","head":{"label":"akeneo:PIM-6253","ref":"PIM-6253","sha":"89843ae2df395725ec3db569c54c222a0fe015ed","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars3.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars3.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-03-13T13:43:17Z","pushed_at":"2017-03-17T13:52:40Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":99407,"stargazers_count":375,"watchers_count":375,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":140,"forks":208,"open_issues":140,"watchers":375,"default_branch":"master"}},"base":{"label":"akeneo:1.7","ref":"1.7","sha":"364129c281987c7dc897d7051fe5571a174f93c4","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars3.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars3.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-03-13T13:43:17Z","pushed_at":"2017-03-17T13:52:40Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":99407,"stargazers_count":375,"watchers_count":375,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":140,"forks":208,"open_issues":140,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5943"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5943"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5943/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5943/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/89843ae2df395725ec3db569c54c222a0fe015ed"}}}}
{"actor":{"display_login":"skeleton"}}