{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16479","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16479/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16479/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16479/events","html_url":"https://github.com/apache/spark/pull/16479","id":198990602,"number":16479,"title":"[SPARK-19085][SQL] cleanup OutputWriterFactory and OutputWriter","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-01-05T16:01:47Z","updated_at":"2017-01-06T03:24:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16479","html_url":"https://github.com/apache/spark/pull/16479","diff_url":"https://github.com/apache/spark/pull/16479.diff","patch_url":"https://github.com/apache/spark/pull/16479.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\n`OutputWriterFactory`/`OutputWriter` are internal interfaces and we can remove some unnecessary APIs:\r\n1. `OutputWriterFactory.newWriter(path: String)`: no one calls it and no one implements it.\r\n2. `OutputWriter.write(row: Row)`: during execution we only call `writeInternal`, which is weird as `OutputWriter` is already an internal interface. We should rename `writeInternal` to `write` and remove `def write(row: Row)` and it's related converter code. All implementations should just implement `def write(row: InternalRow)`\r\n\r\n## How was this patch tested?\r\n\r\nexisting tests."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/270822615","html_url":"https://github.com/apache/spark/pull/16479#issuecomment-270822615","issue_url":"https://api.github.com/repos/apache/spark/issues/16479","id":270822615,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2017-01-06T03:24:38Z","updated_at":"2017-01-06T03:24:38Z","body":"Merged build finished. Test PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}