{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/115134096","pull_request_review_id":36656881,"id":115134096,"diff_hunk":"@@ -56,23 +57,34 @@ class Gcc(AutotoolsPackage):\n     version('4.6.4', 'b407a3d1480c11667f293bfb1f17d1a4')\n     version('4.5.4', '27e459c2566b8209ab064570e1b378f7')\n \n+    # Builds all default languages by default.\n+    # Ada, Go, Jit, and Objective-C++ are not default languages.\n+    # In that respect, the name 'all' is rather misleading.\n+    variant('languages',\n+            default='all',","path":"var/spack/repos/builtin/packages/gcc/package.py","position":40,"original_position":28,"commit_id":"47dc45e61cc9a22981c074515fb909763ad0db94","original_commit_id":"f63a4125441f6d28a087a2ba2c5e3dc3b3451c4a","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars1.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"> Oh, wait. So before GCC 4.8, c wasn't a valid language. I'm sure it was still built, but languages=c will fail.\r\n\r\nmaybe one just filters it out from the configure options in such case? It is still installed, obviously. So from Spack's perspective `c` is a valid options for `@:4.8`. Otherwise you would have someone who installs `gcc@4.7 language=c` and it won't build.","created_at":"2017-05-07T04:53:43Z","updated_at":"2017-05-07T04:53:43Z","html_url":"https://github.com/LLNL/spack/pull/4144#discussion_r115134096","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/4144","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/115134096"},"html":{"href":"https://github.com/LLNL/spack/pull/4144#discussion_r115134096"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4144"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/4144","id":119247197,"html_url":"https://github.com/LLNL/spack/pull/4144","diff_url":"https://github.com/LLNL/spack/pull/4144.diff","patch_url":"https://github.com/LLNL/spack/pull/4144.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/4144","number":4144,"state":"open","locked":false,"title":"[WIP] Add GCC 7","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars1.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"GCC 7 is out!\r\n\r\nThe biggest change I've noticed so far is that the Java compiler is gone. I haven't actually tried installing it yet to make sure all of our flags/hacks still work, so marking this WIP for now.\r\n\r\nFixes #1501. Now, Spack adds a `zip` dependency only when building `gcc languages=java`.","created_at":"2017-05-05T19:55:28Z","updated_at":"2017-05-07T04:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d61436447c9363f5f651158782532fb0dcf5a33d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/4144/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/4144/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/4144/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/47dc45e61cc9a22981c074515fb909763ad0db94","head":{"label":"adamjstewart:features/gcc","ref":"features/gcc","sha":"47dc45e61cc9a22981c074515fb909763ad0db94","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars1.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"repo":{"id":49444175,"name":"spack","full_name":"adamjstewart/spack","owner":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars1.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamjstewart/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/adamjstewart/spack","forks_url":"https://api.github.com/repos/adamjstewart/spack/forks","keys_url":"https://api.github.com/repos/adamjstewart/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamjstewart/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamjstewart/spack/teams","hooks_url":"https://api.github.com/repos/adamjstewart/spack/hooks","issue_events_url":"https://api.github.com/repos/adamjstewart/spack/issues/events{/number}","events_url":"https://api.github.com/repos/adamjstewart/spack/events","assignees_url":"https://api.github.com/repos/adamjstewart/spack/assignees{/user}","branches_url":"https://api.github.com/repos/adamjstewart/spack/branches{/branch}","tags_url":"https://api.github.com/repos/adamjstewart/spack/tags","blobs_url":"https://api.github.com/repos/adamjstewart/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamjstewart/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamjstewart/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamjstewart/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamjstewart/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/adamjstewart/spack/languages","stargazers_url":"https://api.github.com/repos/adamjstewart/spack/stargazers","contributors_url":"https://api.github.com/repos/adamjstewart/spack/contributors","subscribers_url":"https://api.github.com/repos/adamjstewart/spack/subscribers","subscription_url":"https://api.github.com/repos/adamjstewart/spack/subscription","commits_url":"https://api.github.com/repos/adamjstewart/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamjstewart/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamjstewart/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamjstewart/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamjstewart/spack/contents/{+path}","compare_url":"https://api.github.com/repos/adamjstewart/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamjstewart/spack/merges","archive_url":"https://api.github.com/repos/adamjstewart/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamjstewart/spack/downloads","issues_url":"https://api.github.com/repos/adamjstewart/spack/issues{/number}","pulls_url":"https://api.github.com/repos/adamjstewart/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/adamjstewart/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/adamjstewart/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamjstewart/spack/labels{/name}","releases_url":"https://api.github.com/repos/adamjstewart/spack/releases{/id}","deployments_url":"https://api.github.com/repos/adamjstewart/spack/deployments","created_at":"2016-01-11T18:04:18Z","updated_at":"2016-01-11T18:04:19Z","pushed_at":"2017-05-07T04:26:27Z","git_url":"git://github.com/adamjstewart/spack.git","ssh_url":"git@github.com:adamjstewart/spack.git","clone_url":"https://github.com/adamjstewart/spack.git","svn_url":"https://github.com/adamjstewart/spack","homepage":"http://llnl.github.io/spack","size":23289,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"12633b06e420bfec0fb3ebae09d212c41b47f1d3","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars3.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars3.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-05-06T13:07:40Z","pushed_at":"2017-05-07T04:26:29Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"https://spack.io","size":24029,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":219,"mirror_url":null,"open_issues_count":606,"forks":219,"open_issues":606,"watchers":267,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4144"},"html":{"href":"https://github.com/LLNL/spack/pull/4144"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/4144"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/4144/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4144/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4144/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/47dc45e61cc9a22981c074515fb909763ad0db94"}}}}
{"actor":{"display_login":"davydden"}}