{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/145976266","pull_request_review_id":70857802,"id":145976266,"diff_hunk":"@@ -95,5 +95,5 @@ REGRESSION_TEST(Ptr_bool)(RegressionTest *t, int /* atype ATS_UNUSED */, int *ps\n   Ptr<PtrObject> some = make_ptr(new PtrObject(&alive));","path":"lib/ts/test_Ptr.cc","position":1,"original_position":1,"commit_id":"fa9747670e66ea0bf15547fa46ca1f7883cabf31","original_commit_id":"fa9747670e66ea0bf15547fa46ca1f7883cabf31","user":{"login":"dragon512","id":7471568,"avatar_url":"https://avatars2.githubusercontent.com/u/7471568?v=4","gravatar_id":"","url":"https://api.github.com/users/dragon512","html_url":"https://github.com/dragon512","followers_url":"https://api.github.com/users/dragon512/followers","following_url":"https://api.github.com/users/dragon512/following{/other_user}","gists_url":"https://api.github.com/users/dragon512/gists{/gist_id}","starred_url":"https://api.github.com/users/dragon512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragon512/subscriptions","organizations_url":"https://api.github.com/users/dragon512/orgs","repos_url":"https://api.github.com/users/dragon512/repos","events_url":"https://api.github.com/users/dragon512/events{/privacy}","received_events_url":"https://api.github.com/users/dragon512/received_events","type":"User","site_admin":false},"body":"I would like this moved to a catch based test as part of the clean up","created_at":"2017-10-20T14:22:38Z","updated_at":"2017-10-20T14:23:22Z","html_url":"https://github.com/apache/trafficserver/pull/2672#discussion_r145976266","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/2672","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/145976266"},"html":{"href":"https://github.com/apache/trafficserver/pull/2672#discussion_r145976266"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2672"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/2672","id":146894496,"html_url":"https://github.com/apache/trafficserver/pull/2672","diff_url":"https://github.com/apache/trafficserver/pull/2672.diff","patch_url":"https://github.com/apache/trafficserver/pull/2672.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/2672","number":2672,"state":"open","locked":false,"title":"Cleanup of bool conversion in Ptr.h for C++11.","user":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-16T21:35:31Z","updated_at":"2017-10-20T14:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"355c20786ab4701382ece33803e21871a2ee22f6","assignee":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"assignees":[{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/6","html_url":"https://github.com/apache/trafficserver/milestone/6","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/6/labels","id":1763406,"number":6,"title":"8.0.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars1.githubusercontent.com/u/202131?v=4","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":619,"state":"open","created_at":"2016-05-12T22:13:34Z","updated_at":"2017-10-20T02:58:08Z","due_on":"2018-06-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/2672/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/2672/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/2672/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/fa9747670e66ea0bf15547fa46ca1f7883cabf31","head":{"label":"ywkaras:ExplicitBool","ref":"ExplicitBool","sha":"fa9747670e66ea0bf15547fa46ca1f7883cabf31","user":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"repo":{"id":93207586,"name":"trafficserver","full_name":"ywkaras/trafficserver","owner":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywkaras/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/ywkaras/trafficserver","forks_url":"https://api.github.com/repos/ywkaras/trafficserver/forks","keys_url":"https://api.github.com/repos/ywkaras/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywkaras/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywkaras/trafficserver/teams","hooks_url":"https://api.github.com/repos/ywkaras/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/ywkaras/trafficserver/events","assignees_url":"https://api.github.com/repos/ywkaras/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/ywkaras/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/ywkaras/trafficserver/tags","blobs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywkaras/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywkaras/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywkaras/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ywkaras/trafficserver/languages","stargazers_url":"https://api.github.com/repos/ywkaras/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/ywkaras/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/ywkaras/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/ywkaras/trafficserver/subscription","commits_url":"https://api.github.com/repos/ywkaras/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywkaras/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywkaras/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywkaras/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/ywkaras/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywkaras/trafficserver/merges","archive_url":"https://api.github.com/repos/ywkaras/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywkaras/trafficserver/downloads","issues_url":"https://api.github.com/repos/ywkaras/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/ywkaras/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ywkaras/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ywkaras/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywkaras/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/ywkaras/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/ywkaras/trafficserver/deployments","created_at":"2017-06-02T22:13:24Z","updated_at":"2017-06-02T22:13:33Z","pushed_at":"2017-10-18T23:34:17Z","git_url":"git://github.com/ywkaras/trafficserver.git","ssh_url":"git@github.com:ywkaras/trafficserver.git","clone_url":"https://github.com/ywkaras/trafficserver.git","svn_url":"https://github.com/ywkaras/trafficserver","homepage":null,"size":72379,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a37fb3a5ec54484752471eaa5900e9325de15e03","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2017-10-20T01:52:21Z","pushed_at":"2017-10-20T02:57:04Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":74561,"stargazers_count":609,"watchers_count":609,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":464,"mirror_url":null,"archived":false,"open_issues_count":231,"forks":464,"open_issues":231,"watchers":609,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2672"},"html":{"href":"https://github.com/apache/trafficserver/pull/2672"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/2672"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/2672/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2672/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2672/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/fa9747670e66ea0bf15547fa46ca1f7883cabf31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dragon512"}}