{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/comments/157739348","pull_request_review_id":84430504,"id":157739348,"diff_hunk":"@@ -22,3 +22,4 @@\n       :event_catcher_nuage_network:\n         :topics:\n           - topic/CNAMessages\n+        :poll: 1.seconds","path":"config/settings.yml","position":4,"original_position":4,"commit_id":"0efe0292d27c9837785814e6d011455749230640","original_commit_id":"0efe0292d27c9837785814e6d011455749230640","user":{"login":"miha-plesko","id":8102426,"avatar_url":"https://avatars1.githubusercontent.com/u/8102426?v=4","gravatar_id":"","url":"https://api.github.com/users/miha-plesko","html_url":"https://github.com/miha-plesko","followers_url":"https://api.github.com/users/miha-plesko/followers","following_url":"https://api.github.com/users/miha-plesko/following{/other_user}","gists_url":"https://api.github.com/users/miha-plesko/gists{/gist_id}","starred_url":"https://api.github.com/users/miha-plesko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miha-plesko/subscriptions","organizations_url":"https://api.github.com/users/miha-plesko/orgs","repos_url":"https://api.github.com/users/miha-plesko/repos","events_url":"https://api.github.com/users/miha-plesko/events{/privacy}","received_events_url":"https://api.github.com/users/miha-plesko/received_events","type":"User","site_admin":false},"body":"Please add empty line at the end of the file","created_at":"2017-12-19T12:24:15Z","updated_at":"2017-12-19T12:31:24Z","html_url":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52#discussion_r157739348","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/comments/157739348"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52#discussion_r157739348"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52","id":159152649,"html_url":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52","diff_url":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/52","number":52,"state":"open","locked":false,"title":"Improve the performance of event catcher","user":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"body":"Nuage event catcher relies on Qpid Proton to get the events from the\r\nAMQP queue. Due to synchronization issues, this resulted in massive\r\ndelays when processing events.\r\n\r\nThis patch tries to overcome this by adding a short sleep cycle to allow\r\nthe stream (Qpid) and event catcher to work together on the events.\r\n\r\nIt also resolves an issue with the fact the Nuage events are sometimes\r\nsent with the same timestamp for certain event types, even though the\r\nactual payload differs. As there is no ID that could be used as an EMS\r\nreference, we alter the timestamp slightly based on the current time.\r\n\r\nAddresses #47.\r\nReplaces #41 and #48. Main reason for this is that I don't want to close the connection as we are loosing events! I've also attempted to do batch processing but it's even worse. Thus, for the first improvement I would like to see this merged as it improves the performance in a way that events are published into the DB.\r\n\r\n@miq-bot add_label events, bug\r\n\r\n@miq-bot assign @juliancheal \r\n\r\n/cc @bronaghs I'd also like your comment on this one, if possible.","created_at":"2017-12-19T12:18:29Z","updated_at":"2017-12-19T12:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"468c6f180463016e37d09b668dd5d5c1e8fd817b","assignee":{"login":"juliancheal","id":63991,"avatar_url":"https://avatars0.githubusercontent.com/u/63991?v=4","gravatar_id":"","url":"https://api.github.com/users/juliancheal","html_url":"https://github.com/juliancheal","followers_url":"https://api.github.com/users/juliancheal/followers","following_url":"https://api.github.com/users/juliancheal/following{/other_user}","gists_url":"https://api.github.com/users/juliancheal/gists{/gist_id}","starred_url":"https://api.github.com/users/juliancheal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliancheal/subscriptions","organizations_url":"https://api.github.com/users/juliancheal/orgs","repos_url":"https://api.github.com/users/juliancheal/repos","events_url":"https://api.github.com/users/juliancheal/events{/privacy}","received_events_url":"https://api.github.com/users/juliancheal/received_events","type":"User","site_admin":false},"assignees":[{"login":"juliancheal","id":63991,"avatar_url":"https://avatars0.githubusercontent.com/u/63991?v=4","gravatar_id":"","url":"https://api.github.com/users/juliancheal","html_url":"https://github.com/juliancheal","followers_url":"https://api.github.com/users/juliancheal/followers","following_url":"https://api.github.com/users/juliancheal/following{/other_user}","gists_url":"https://api.github.com/users/juliancheal/gists{/gist_id}","starred_url":"https://api.github.com/users/juliancheal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliancheal/subscriptions","organizations_url":"https://api.github.com/users/juliancheal/orgs","repos_url":"https://api.github.com/users/juliancheal/repos","events_url":"https://api.github.com/users/juliancheal/events{/privacy}","received_events_url":"https://api.github.com/users/juliancheal/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/52/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/statuses/0efe0292d27c9837785814e6d011455749230640","head":{"label":"gberginc:improve_amqp_performance","ref":"improve_amqp_performance","sha":"0efe0292d27c9837785814e6d011455749230640","user":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"repo":{"id":97873264,"name":"manageiq-providers-nuage","full_name":"gberginc/manageiq-providers-nuage","owner":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gberginc/manageiq-providers-nuage","description":"ManageIQ plugin for the Nuage provider. http://manageiq.org","fork":true,"url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage","forks_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/forks","keys_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/teams","hooks_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/hooks","issue_events_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/issues/events{/number}","events_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/events","assignees_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/assignees{/user}","branches_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/branches{/branch}","tags_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/tags","blobs_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/git/refs{/sha}","trees_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/statuses/{sha}","languages_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/languages","stargazers_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/stargazers","contributors_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/contributors","subscribers_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/subscribers","subscription_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/subscription","commits_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/commits{/sha}","git_commits_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/git/commits{/sha}","comments_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/comments{/number}","issue_comment_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/issues/comments{/number}","contents_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/contents/{+path}","compare_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/merges","archive_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/downloads","issues_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/issues{/number}","pulls_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/pulls{/number}","milestones_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/milestones{/number}","notifications_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/labels{/name}","releases_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/releases{/id}","deployments_url":"https://api.github.com/repos/gberginc/manageiq-providers-nuage/deployments","created_at":"2017-07-20T19:55:53Z","updated_at":"2017-07-20T19:55:54Z","pushed_at":"2017-12-19T12:15:31Z","git_url":"git://github.com/gberginc/manageiq-providers-nuage.git","ssh_url":"git@github.com:gberginc/manageiq-providers-nuage.git","clone_url":"https://github.com/gberginc/manageiq-providers-nuage.git","svn_url":"https://github.com/gberginc/manageiq-providers-nuage","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"8ac64a6b09e73bc3a78b8c8ef621b1f70e32c72e","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":93396771,"name":"manageiq-providers-nuage","full_name":"ManageIQ/manageiq-providers-nuage","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-nuage","description":"ManageIQ plugin for the Nuage provider. http://manageiq.org","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/deployments","created_at":"2017-06-05T11:25:41Z","updated_at":"2017-11-10T02:20:44Z","pushed_at":"2017-12-19T12:18:30Z","git_url":"git://github.com/ManageIQ/manageiq-providers-nuage.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-nuage.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-nuage.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-nuage","homepage":null,"size":155,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-nuage/pull/52"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/52"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-nuage/statuses/0efe0292d27c9837785814e6d011455749230640"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"miha-plesko"}}