{"action":"created","comment":{"url":"https://api.github.com/repos/vutran/dext/pulls/comments/97357390","pull_request_review_id":17963919,"id":97357390,"diff_hunk":"@@ -0,0 +1,12 @@\n+import {\n+  COPY_ITEM,\n+} from '../actions/types';\n+\n+export default function (state, { type }) {","path":"app/renderer/src/reducers/copiedToClipboard.js","position":5,"original_position":5,"commit_id":"3e87bc9642e400a4254467ecbb52fea831de99d1","original_commit_id":"3e87bc9642e400a4254467ecbb52fea831de99d1","user":{"login":"Magellol","id":3819093,"avatar_url":"https://avatars.githubusercontent.com/u/3819093?v=3","gravatar_id":"","url":"https://api.github.com/users/Magellol","html_url":"https://github.com/Magellol","followers_url":"https://api.github.com/users/Magellol/followers","following_url":"https://api.github.com/users/Magellol/following{/other_user}","gists_url":"https://api.github.com/users/Magellol/gists{/gist_id}","starred_url":"https://api.github.com/users/Magellol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magellol/subscriptions","organizations_url":"https://api.github.com/users/Magellol/orgs","repos_url":"https://api.github.com/users/Magellol/repos","events_url":"https://api.github.com/users/Magellol/events{/privacy}","received_events_url":"https://api.github.com/users/Magellol/received_events","type":"User","site_admin":false},"body":"@vutran Actually, I thought about it and I figured that the only action that should set the flag to true is `COPY_ITEM`, so every other actions should turn it off. I think this makes sense? ","created_at":"2017-01-23T16:30:04Z","updated_at":"2017-01-23T16:30:04Z","html_url":"https://github.com/vutran/dext/pull/152#discussion_r97357390","pull_request_url":"https://api.github.com/repos/vutran/dext/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/vutran/dext/pulls/comments/97357390"},"html":{"href":"https://github.com/vutran/dext/pull/152#discussion_r97357390"},"pull_request":{"href":"https://api.github.com/repos/vutran/dext/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/vutran/dext/pulls/152","id":101983289,"html_url":"https://github.com/vutran/dext/pull/152","diff_url":"https://github.com/vutran/dext/pull/152.diff","patch_url":"https://github.com/vutran/dext/pull/152.patch","issue_url":"https://api.github.com/repos/vutran/dext/issues/152","number":152,"state":"open","locked":false,"title":"Trigger notification when user copies item to his clipboard.","user":{"login":"Magellol","id":3819093,"avatar_url":"https://avatars.githubusercontent.com/u/3819093?v=3","gravatar_id":"","url":"https://api.github.com/users/Magellol","html_url":"https://github.com/Magellol","followers_url":"https://api.github.com/users/Magellol/followers","following_url":"https://api.github.com/users/Magellol/following{/other_user}","gists_url":"https://api.github.com/users/Magellol/gists{/gist_id}","starred_url":"https://api.github.com/users/Magellol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magellol/subscriptions","organizations_url":"https://api.github.com/users/Magellol/orgs","repos_url":"https://api.github.com/users/Magellol/repos","events_url":"https://api.github.com/users/Magellol/events{/privacy}","received_events_url":"https://api.github.com/users/Magellol/received_events","type":"User","site_admin":false},"body":"Hey guys, first time around here 👋.\r\n\r\nSo I wanted to try out contributing to Dext, so I've picked up #98 since it was tagged as `up-for-grabs`. I've set up the barebones for native notifications when a user copies something into its clipboard (see how it feels), as it was suggested in the issue thread. Although, I'm not sure that's the right approach UX wise. First, user could disable them through the `DnD` mode is OSX for example, second we can't update them on the fly (I believe) so we have to trigger a new one if the user copies multiple times. Third, even if we can silence them, I feel they are very invasive.\r\n\r\nBefore going any further I wanted to see how you guys feel about building a component instead and maybe render it in `ResultListContainer` in response to some event. \r\n\r\nLast but not least, I'm wondering if we ever need a feedback from this action? Alfred doesn't say anything but instead just tells the user he _can_ do it. [See screenshot](https://cl.ly/3z2X2e3h0L3G).\r\n\r\nI'm open to any suggestion 👍 ","created_at":"2017-01-18T01:39:40Z","updated_at":"2017-01-23T16:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa6063a633b245d222857bb8c1e7d33ce180c725","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vutran/dext/pulls/152/commits","review_comments_url":"https://api.github.com/repos/vutran/dext/pulls/152/comments","review_comment_url":"https://api.github.com/repos/vutran/dext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vutran/dext/issues/152/comments","statuses_url":"https://api.github.com/repos/vutran/dext/statuses/3e87bc9642e400a4254467ecbb52fea831de99d1","head":{"label":"Magellol:feature/copy-notification","ref":"feature/copy-notification","sha":"3e87bc9642e400a4254467ecbb52fea831de99d1","user":{"login":"Magellol","id":3819093,"avatar_url":"https://avatars.githubusercontent.com/u/3819093?v=3","gravatar_id":"","url":"https://api.github.com/users/Magellol","html_url":"https://github.com/Magellol","followers_url":"https://api.github.com/users/Magellol/followers","following_url":"https://api.github.com/users/Magellol/following{/other_user}","gists_url":"https://api.github.com/users/Magellol/gists{/gist_id}","starred_url":"https://api.github.com/users/Magellol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magellol/subscriptions","organizations_url":"https://api.github.com/users/Magellol/orgs","repos_url":"https://api.github.com/users/Magellol/repos","events_url":"https://api.github.com/users/Magellol/events{/privacy}","received_events_url":"https://api.github.com/users/Magellol/received_events","type":"User","site_admin":false},"repo":{"id":79284684,"name":"dext","full_name":"Magellol/dext","owner":{"login":"Magellol","id":3819093,"avatar_url":"https://avatars.githubusercontent.com/u/3819093?v=3","gravatar_id":"","url":"https://api.github.com/users/Magellol","html_url":"https://github.com/Magellol","followers_url":"https://api.github.com/users/Magellol/followers","following_url":"https://api.github.com/users/Magellol/following{/other_user}","gists_url":"https://api.github.com/users/Magellol/gists{/gist_id}","starred_url":"https://api.github.com/users/Magellol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magellol/subscriptions","organizations_url":"https://api.github.com/users/Magellol/orgs","repos_url":"https://api.github.com/users/Magellol/repos","events_url":"https://api.github.com/users/Magellol/events{/privacy}","received_events_url":"https://api.github.com/users/Magellol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Magellol/dext","description":"🔍 A smart launcher for Mac. Powered by JavaScript.","fork":true,"url":"https://api.github.com/repos/Magellol/dext","forks_url":"https://api.github.com/repos/Magellol/dext/forks","keys_url":"https://api.github.com/repos/Magellol/dext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magellol/dext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magellol/dext/teams","hooks_url":"https://api.github.com/repos/Magellol/dext/hooks","issue_events_url":"https://api.github.com/repos/Magellol/dext/issues/events{/number}","events_url":"https://api.github.com/repos/Magellol/dext/events","assignees_url":"https://api.github.com/repos/Magellol/dext/assignees{/user}","branches_url":"https://api.github.com/repos/Magellol/dext/branches{/branch}","tags_url":"https://api.github.com/repos/Magellol/dext/tags","blobs_url":"https://api.github.com/repos/Magellol/dext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magellol/dext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magellol/dext/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magellol/dext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magellol/dext/statuses/{sha}","languages_url":"https://api.github.com/repos/Magellol/dext/languages","stargazers_url":"https://api.github.com/repos/Magellol/dext/stargazers","contributors_url":"https://api.github.com/repos/Magellol/dext/contributors","subscribers_url":"https://api.github.com/repos/Magellol/dext/subscribers","subscription_url":"https://api.github.com/repos/Magellol/dext/subscription","commits_url":"https://api.github.com/repos/Magellol/dext/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magellol/dext/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magellol/dext/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magellol/dext/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magellol/dext/contents/{+path}","compare_url":"https://api.github.com/repos/Magellol/dext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magellol/dext/merges","archive_url":"https://api.github.com/repos/Magellol/dext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magellol/dext/downloads","issues_url":"https://api.github.com/repos/Magellol/dext/issues{/number}","pulls_url":"https://api.github.com/repos/Magellol/dext/pulls{/number}","milestones_url":"https://api.github.com/repos/Magellol/dext/milestones{/number}","notifications_url":"https://api.github.com/repos/Magellol/dext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magellol/dext/labels{/name}","releases_url":"https://api.github.com/repos/Magellol/dext/releases{/id}","deployments_url":"https://api.github.com/repos/Magellol/dext/deployments","created_at":"2017-01-17T23:53:32Z","updated_at":"2017-01-17T23:53:35Z","pushed_at":"2017-01-23T16:28:51Z","git_url":"git://github.com/Magellol/dext.git","ssh_url":"git@github.com:Magellol/dext.git","clone_url":"https://github.com/Magellol/dext.git","svn_url":"https://github.com/Magellol/dext","homepage":"","size":77034,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"vutran:develop","ref":"develop","sha":"e7a0a6457de0daaf36ee3aa3b9c9787e69409a59","user":{"login":"vutran","id":1088312,"avatar_url":"https://avatars.githubusercontent.com/u/1088312?v=3","gravatar_id":"","url":"https://api.github.com/users/vutran","html_url":"https://github.com/vutran","followers_url":"https://api.github.com/users/vutran/followers","following_url":"https://api.github.com/users/vutran/following{/other_user}","gists_url":"https://api.github.com/users/vutran/gists{/gist_id}","starred_url":"https://api.github.com/users/vutran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutran/subscriptions","organizations_url":"https://api.github.com/users/vutran/orgs","repos_url":"https://api.github.com/users/vutran/repos","events_url":"https://api.github.com/users/vutran/events{/privacy}","received_events_url":"https://api.github.com/users/vutran/received_events","type":"User","site_admin":false},"repo":{"id":66712801,"name":"dext","full_name":"vutran/dext","owner":{"login":"vutran","id":1088312,"avatar_url":"https://avatars.githubusercontent.com/u/1088312?v=3","gravatar_id":"","url":"https://api.github.com/users/vutran","html_url":"https://github.com/vutran","followers_url":"https://api.github.com/users/vutran/followers","following_url":"https://api.github.com/users/vutran/following{/other_user}","gists_url":"https://api.github.com/users/vutran/gists{/gist_id}","starred_url":"https://api.github.com/users/vutran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutran/subscriptions","organizations_url":"https://api.github.com/users/vutran/orgs","repos_url":"https://api.github.com/users/vutran/repos","events_url":"https://api.github.com/users/vutran/events{/privacy}","received_events_url":"https://api.github.com/users/vutran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vutran/dext","description":"🔍 A smart launcher for Mac. Powered by JavaScript.","fork":false,"url":"https://api.github.com/repos/vutran/dext","forks_url":"https://api.github.com/repos/vutran/dext/forks","keys_url":"https://api.github.com/repos/vutran/dext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vutran/dext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vutran/dext/teams","hooks_url":"https://api.github.com/repos/vutran/dext/hooks","issue_events_url":"https://api.github.com/repos/vutran/dext/issues/events{/number}","events_url":"https://api.github.com/repos/vutran/dext/events","assignees_url":"https://api.github.com/repos/vutran/dext/assignees{/user}","branches_url":"https://api.github.com/repos/vutran/dext/branches{/branch}","tags_url":"https://api.github.com/repos/vutran/dext/tags","blobs_url":"https://api.github.com/repos/vutran/dext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vutran/dext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vutran/dext/git/refs{/sha}","trees_url":"https://api.github.com/repos/vutran/dext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vutran/dext/statuses/{sha}","languages_url":"https://api.github.com/repos/vutran/dext/languages","stargazers_url":"https://api.github.com/repos/vutran/dext/stargazers","contributors_url":"https://api.github.com/repos/vutran/dext/contributors","subscribers_url":"https://api.github.com/repos/vutran/dext/subscribers","subscription_url":"https://api.github.com/repos/vutran/dext/subscription","commits_url":"https://api.github.com/repos/vutran/dext/commits{/sha}","git_commits_url":"https://api.github.com/repos/vutran/dext/git/commits{/sha}","comments_url":"https://api.github.com/repos/vutran/dext/comments{/number}","issue_comment_url":"https://api.github.com/repos/vutran/dext/issues/comments{/number}","contents_url":"https://api.github.com/repos/vutran/dext/contents/{+path}","compare_url":"https://api.github.com/repos/vutran/dext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vutran/dext/merges","archive_url":"https://api.github.com/repos/vutran/dext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vutran/dext/downloads","issues_url":"https://api.github.com/repos/vutran/dext/issues{/number}","pulls_url":"https://api.github.com/repos/vutran/dext/pulls{/number}","milestones_url":"https://api.github.com/repos/vutran/dext/milestones{/number}","notifications_url":"https://api.github.com/repos/vutran/dext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vutran/dext/labels{/name}","releases_url":"https://api.github.com/repos/vutran/dext/releases{/id}","deployments_url":"https://api.github.com/repos/vutran/dext/deployments","created_at":"2016-08-27T12:11:22Z","updated_at":"2017-01-22T20:19:30Z","pushed_at":"2017-01-23T16:28:52Z","git_url":"git://github.com/vutran/dext.git","ssh_url":"git@github.com:vutran/dext.git","clone_url":"https://github.com/vutran/dext.git","svn_url":"https://github.com/vutran/dext","homepage":"","size":77029,"stargazers_count":414,"watchers_count":414,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":17,"forks":37,"open_issues":17,"watchers":414,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vutran/dext/pulls/152"},"html":{"href":"https://github.com/vutran/dext/pull/152"},"issue":{"href":"https://api.github.com/repos/vutran/dext/issues/152"},"comments":{"href":"https://api.github.com/repos/vutran/dext/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/vutran/dext/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/vutran/dext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vutran/dext/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/vutran/dext/statuses/3e87bc9642e400a4254467ecbb52fea831de99d1"}}}}
{"actor":{"display_login":"Magellol"}}