{"action":"created","issue":{"url":"https://api.github.com/repos/LiskHQ/lisk/issues/997","repository_url":"https://api.github.com/repos/LiskHQ/lisk","labels_url":"https://api.github.com/repos/LiskHQ/lisk/issues/997/labels{/name}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/997/comments","events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/997/events","html_url":"https://github.com/LiskHQ/lisk/pull/997","id":274841434,"number":997,"title":"Fix orderBy tests on functional get dapps - Closes #977","user":{"login":"diego-G","id":1387244,"avatar_url":"https://avatars2.githubusercontent.com/u/1387244?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-G","html_url":"https://github.com/diego-G","followers_url":"https://api.github.com/users/diego-G/followers","following_url":"https://api.github.com/users/diego-G/following{/other_user}","gists_url":"https://api.github.com/users/diego-G/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-G/subscriptions","organizations_url":"https://api.github.com/users/diego-G/orgs","repos_url":"https://api.github.com/users/diego-G/repos","events_url":"https://api.github.com/users/diego-G/events{/privacy}","received_events_url":"https://api.github.com/users/diego-G/received_events","type":"User","site_admin":false},"labels":[{"id":655482394,"url":"https://api.github.com/repos/LiskHQ/lisk/labels/pending%20review","name":"pending review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"karmacoma","id":8068,"avatar_url":"https://avatars0.githubusercontent.com/u/8068?v=4","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false},"assignees":[{"login":"karmacoma","id":8068,"avatar_url":"https://avatars0.githubusercontent.com/u/8068?v=4","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-11-17T11:52:52Z","updated_at":"2017-11-17T13:38:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/997","html_url":"https://github.com/LiskHQ/lisk/pull/997","diff_url":"https://github.com/LiskHQ/lisk/pull/997.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/997.patch"},"body":"Closes #977 "},"comment":{"url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments/345246010","html_url":"https://github.com/LiskHQ/lisk/pull/997#issuecomment-345246010","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/997","id":345246010,"user":{"login":"nazarhussain","id":112468,"avatar_url":"https://avatars0.githubusercontent.com/u/112468?v=4","gravatar_id":"","url":"https://api.github.com/users/nazarhussain","html_url":"https://github.com/nazarhussain","followers_url":"https://api.github.com/users/nazarhussain/followers","following_url":"https://api.github.com/users/nazarhussain/following{/other_user}","gists_url":"https://api.github.com/users/nazarhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/nazarhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazarhussain/subscriptions","organizations_url":"https://api.github.com/users/nazarhussain/orgs","repos_url":"https://api.github.com/users/nazarhussain/repos","events_url":"https://api.github.com/users/nazarhussain/events{/privacy}","received_events_url":"https://api.github.com/users/nazarhussain/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T13:38:41Z","updated_at":"2017-11-17T13:38:41Z","author_association":"CONTRIBUTOR","body":"@diego-G @karmacoma In my last PR I converted `sort` to a new method `dbSort`. So I don't think changing it back will actually solve the issue. I have the data set for which `sort` is failing as well the dataset for which `dbSort` is failing. None of the solution is perfect, but dbSort function solved the special characters issue very well. \r\n\r\nSince we change `sort` to `dbSort` all over tests, so what ever technique we need to implement we should do it inside `dbSort` and don't touch the tests. "}}
{"actor":{"display_login":"nazarhussain"}}