{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/13015","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/13015/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/13015/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/13015/events","html_url":"https://github.com/Wikia/app/pull/13015","id":232482367,"number":13015,"title":"add support for namespaces to WikiaView","user":{"login":"hakubo","id":1018759,"avatar_url":"https://avatars2.githubusercontent.com/u/1018759?v=3","gravatar_id":"","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-31T07:50:36Z","updated_at":"2017-05-31T07:53:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/13015","html_url":"https://github.com/Wikia/app/pull/13015","diff_url":"https://github.com/Wikia/app/pull/13015.diff","patch_url":"https://github.com/Wikia/app/pull/13015.patch"},"body":"This PR adds support for namespaces to WikiaView, so we can have nirvana controllers also inside namespaces. Template path should still be build based on class name but without namespace.\r\n\r\nExample:\r\n$this->renderView('PageHeader/PageHeader', 'index');\r\n\r\n\r\nAlternative idea:\r\nadd a param to renderView - $namespace, so we could generate paths correctly\r\nthis would unnecessarily increase learning curve of how to render view in nirvana\r\n\r\nCurrent approach mimics how you would use a class inside a namespace in PHP\r\nbut allows to have all templates inside ClassName/templates, folder\r\n"},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/305113899","html_url":"https://github.com/Wikia/app/pull/13015#issuecomment-305113899","issue_url":"https://api.github.com/repos/Wikia/app/issues/13015","id":305113899,"user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars0.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"created_at":"2017-05-31T07:53:26Z","updated_at":"2017-05-31T07:53:26Z","body":"SonarQube analysis reported 8 issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L161](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L161): Remove this commented out code. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS125)\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L281](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L281): Add curly braces around the nested statement(s). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS121)\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L282](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L282): Add curly braces around the nested statement(s). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS121)\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L320](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L320): Remove the code after this \"return\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1763)\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L323](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L323): Reduce this \"switch/case\" number of lines from 21 to at most 10, for example by extracting code into function. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1151)\n1. ![MAJOR][MAJOR] [WikiaView.class.php#L342](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L342): Remove the code after this \"return\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1763)\n1. ![MINOR][MINOR] [WikiaView.class.php#L281](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L281): 2 statements were found on this line. Reformat the code to have only one statement per line. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS122)\n1. ![MINOR][MINOR] [WikiaView.class.php#L282](https://github.com/Wikia/app/blob/a30164381b15bd810dafda137c72ef43a11e7aa4/includes/wikia/nirvana/WikiaView.class.php#L282): 2 statements were found on this line. Reformat the code to have only one statement per line. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS122)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"WikiaTech"}}