{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/125398110","pull_request_review_id":47782199,"id":125398110,"diff_hunk":"@@ -19,6 +19,6 @@ EmulationIssues = Use directx11 backend with efb scale set at 1x to deal with bl\n \n [Video_Settings]\n SafeTextureCacheColorSamples = 0\n-InternalResolution = 1\n+EFBScale = 2","path":"Data/Sys/GameSettings/G9S.ini","position":null,"original_position":5,"commit_id":"13d89769e7abb1b81439bbe95118972d4bab8e40","original_commit_id":"13d89769e7abb1b81439bbe95118972d4bab8e40","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"No, this is intentional.","created_at":"2017-07-04T06:38:08Z","updated_at":"2017-07-04T06:38:08Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/5744#discussion_r125398110","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/125398110"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5744#discussion_r125398110"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744","id":128642099,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5744","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5744.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5744.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5744","number":5744,"state":"open","locked":false,"title":"Remove non-integer IRs","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"Non-integer internal resolutions lead to many problems that we can't do much about – mostly graphical, but in Paper Mario TTYD's case, there are problems like [crashes](https://forums.dolphin-emu.org/Thread-paper-mario-thousand-year-door-crashing--49298) and even [save corruption](https://bugs.dolphin-emu.org/issues/10171). This PR removes non-integer internal resolutions from Dolphin entirely.\r\n\r\nOne note about the implementation of this PR: I've changed how Dolphin stores the EFB scale setting in RAM because it simplifies code significantly in several places. Now 0 means auto (integral), 1 means 1x, 2 means 2x, and so on. Do we want to apply this change to the INIs as well (so that values make more sense) or keep using the old numbering system in INIs (to be backwards compatible)? For now, I've just made it use the new numbering system with a new setting name, because I wasn't sure where in the new config code I could put code for translating between the two numbering systems.","created_at":"2017-07-03T14:34:39Z","updated_at":"2017-07-04T06:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a70823f178a3e7682867c38d2b1c90d88376e7d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5744/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/13d89769e7abb1b81439bbe95118972d4bab8e40","head":{"label":"JosJuice:remove-non-integer-irs","ref":"remove-non-integer-irs","sha":"13d89769e7abb1b81439bbe95118972d4bab8e40","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"repo":{"id":26057138,"name":"dolphin","full_name":"JosJuice/dolphin","owner":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosJuice/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/JosJuice/dolphin","forks_url":"https://api.github.com/repos/JosJuice/dolphin/forks","keys_url":"https://api.github.com/repos/JosJuice/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosJuice/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosJuice/dolphin/teams","hooks_url":"https://api.github.com/repos/JosJuice/dolphin/hooks","issue_events_url":"https://api.github.com/repos/JosJuice/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/JosJuice/dolphin/events","assignees_url":"https://api.github.com/repos/JosJuice/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/JosJuice/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/JosJuice/dolphin/tags","blobs_url":"https://api.github.com/repos/JosJuice/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosJuice/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosJuice/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosJuice/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosJuice/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/JosJuice/dolphin/languages","stargazers_url":"https://api.github.com/repos/JosJuice/dolphin/stargazers","contributors_url":"https://api.github.com/repos/JosJuice/dolphin/contributors","subscribers_url":"https://api.github.com/repos/JosJuice/dolphin/subscribers","subscription_url":"https://api.github.com/repos/JosJuice/dolphin/subscription","commits_url":"https://api.github.com/repos/JosJuice/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosJuice/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosJuice/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosJuice/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosJuice/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/JosJuice/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosJuice/dolphin/merges","archive_url":"https://api.github.com/repos/JosJuice/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosJuice/dolphin/downloads","issues_url":"https://api.github.com/repos/JosJuice/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/JosJuice/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/JosJuice/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/JosJuice/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosJuice/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/JosJuice/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/JosJuice/dolphin/deployments","created_at":"2014-11-01T17:12:40Z","updated_at":"2016-10-24T10:37:02Z","pushed_at":"2017-07-03T21:04:02Z","git_url":"git://github.com/JosJuice/dolphin.git","ssh_url":"git@github.com:JosJuice/dolphin.git","clone_url":"https://github.com/JosJuice/dolphin.git","svn_url":"https://github.com/JosJuice/dolphin","homepage":null,"size":305526,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"0f9ae6d361541a5917ae3b05dc7c667cdef81336","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-07-03T05:53:42Z","pushed_at":"2017-07-04T06:30:36Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":342643,"stargazers_count":3433,"watchers_count":3433,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":881,"mirror_url":null,"open_issues_count":150,"forks":881,"open_issues":150,"watchers":3433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5744"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5744"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5744/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5744/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/13d89769e7abb1b81439bbe95118972d4bab8e40"}}}}
{"actor":{"display_login":"JosJuice"}}