{"action":"created","comment":{"url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/comments/150686809","pull_request_review_id":76274210,"id":150686809,"diff_hunk":"@@ -24,11 +22,8 @@ import (\n )\n \n var (\n-\t// GlobalCommandArgs are command args received while invoking this command\n-\tGlobalCommandArgs map[string]interface{}\n-\tlauncher          *ProcessMon\n-\tnetnspath         string\n-\tchildExitStatus   = make(chan ExitStatus, 100)\n+\t// launcher supports only a global processMon instance\n+\tlauncher *processMon","path":"internal/processmon/processmon.go","position":17,"original_position":17,"commit_id":"e1933186a8e5edd963a267fa932655054690ed7d","original_commit_id":"423eba95d1adfd236bd45e4597303ca93d0df4c2","user":{"login":"satyamsi","id":10569193,"avatar_url":"https://avatars2.githubusercontent.com/u/10569193?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamsi","html_url":"https://github.com/satyamsi","followers_url":"https://api.github.com/users/satyamsi/followers","following_url":"https://api.github.com/users/satyamsi/following{/other_user}","gists_url":"https://api.github.com/users/satyamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamsi/subscriptions","organizations_url":"https://api.github.com/users/satyamsi/orgs","repos_url":"https://api.github.com/users/satyamsi/repos","events_url":"https://api.github.com/users/satyamsi/events{/privacy}","received_events_url":"https://api.github.com/users/satyamsi/received_events","type":"User","site_admin":false},"body":"So swap is only possible inside a test because they cant actually write to /var/run/ whatever. newProcessMon is a private function and cant be called by anyone other than init(). ","created_at":"2017-11-13T22:35:30Z","updated_at":"2017-11-13T22:35:30Z","html_url":"https://github.com/aporeto-inc/trireme/pull/392#discussion_r150686809","pull_request_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/comments/150686809"},"html":{"href":"https://github.com/aporeto-inc/trireme/pull/392#discussion_r150686809"},"pull_request":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392"}},"in_reply_to_id":150680864},"pull_request":{"url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392","id":152360209,"html_url":"https://github.com/aporeto-inc/trireme/pull/392","diff_url":"https://github.com/aporeto-inc/trireme/pull/392.diff","patch_url":"https://github.com/aporeto-inc/trireme/pull/392.patch","issue_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/392","number":392,"state":"open","locked":false,"title":"Fixed: Move processmon to internal  package","user":{"login":"satyamsi","id":10569193,"avatar_url":"https://avatars2.githubusercontent.com/u/10569193?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamsi","html_url":"https://github.com/satyamsi","followers_url":"https://api.github.com/users/satyamsi/followers","following_url":"https://api.github.com/users/satyamsi/following{/other_user}","gists_url":"https://api.github.com/users/satyamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamsi/subscriptions","organizations_url":"https://api.github.com/users/satyamsi/orgs","repos_url":"https://api.github.com/users/satyamsi/repos","events_url":"https://api.github.com/users/satyamsi/events{/privacy}","received_events_url":"https://api.github.com/users/satyamsi/received_events","type":"User","site_admin":false},"body":"This PR creates an internal package called processmon as this is not consumable outside trireme lib.","created_at":"2017-11-13T22:05:24Z","updated_at":"2017-11-13T22:35:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91fa884353a25f5fc1bf057ed92d11a4e498b2e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amitlimaye","id":8889471,"avatar_url":"https://avatars2.githubusercontent.com/u/8889471?v=4","gravatar_id":"","url":"https://api.github.com/users/amitlimaye","html_url":"https://github.com/amitlimaye","followers_url":"https://api.github.com/users/amitlimaye/followers","following_url":"https://api.github.com/users/amitlimaye/following{/other_user}","gists_url":"https://api.github.com/users/amitlimaye/gists{/gist_id}","starred_url":"https://api.github.com/users/amitlimaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitlimaye/subscriptions","organizations_url":"https://api.github.com/users/amitlimaye/orgs","repos_url":"https://api.github.com/users/amitlimaye/repos","events_url":"https://api.github.com/users/amitlimaye/events{/privacy}","received_events_url":"https://api.github.com/users/amitlimaye/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392/commits","review_comments_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392/comments","review_comment_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/392/comments","statuses_url":"https://api.github.com/repos/aporeto-inc/trireme/statuses/e1933186a8e5edd963a267fa932655054690ed7d","head":{"label":"aporeto-inc:refactor","ref":"refactor","sha":"e1933186a8e5edd963a267fa932655054690ed7d","user":{"login":"aporeto-inc","id":15617796,"avatar_url":"https://avatars2.githubusercontent.com/u/15617796?v=4","gravatar_id":"","url":"https://api.github.com/users/aporeto-inc","html_url":"https://github.com/aporeto-inc","followers_url":"https://api.github.com/users/aporeto-inc/followers","following_url":"https://api.github.com/users/aporeto-inc/following{/other_user}","gists_url":"https://api.github.com/users/aporeto-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/aporeto-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aporeto-inc/subscriptions","organizations_url":"https://api.github.com/users/aporeto-inc/orgs","repos_url":"https://api.github.com/users/aporeto-inc/repos","events_url":"https://api.github.com/users/aporeto-inc/events{/privacy}","received_events_url":"https://api.github.com/users/aporeto-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":71510166,"name":"trireme","full_name":"aporeto-inc/trireme","owner":{"login":"aporeto-inc","id":15617796,"avatar_url":"https://avatars2.githubusercontent.com/u/15617796?v=4","gravatar_id":"","url":"https://api.github.com/users/aporeto-inc","html_url":"https://github.com/aporeto-inc","followers_url":"https://api.github.com/users/aporeto-inc/followers","following_url":"https://api.github.com/users/aporeto-inc/following{/other_user}","gists_url":"https://api.github.com/users/aporeto-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/aporeto-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aporeto-inc/subscriptions","organizations_url":"https://api.github.com/users/aporeto-inc/orgs","repos_url":"https://api.github.com/users/aporeto-inc/repos","events_url":"https://api.github.com/users/aporeto-inc/events{/privacy}","received_events_url":"https://api.github.com/users/aporeto-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aporeto-inc/trireme","description":"Simple, scalable and secure application segmentation","fork":false,"url":"https://api.github.com/repos/aporeto-inc/trireme","forks_url":"https://api.github.com/repos/aporeto-inc/trireme/forks","keys_url":"https://api.github.com/repos/aporeto-inc/trireme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aporeto-inc/trireme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aporeto-inc/trireme/teams","hooks_url":"https://api.github.com/repos/aporeto-inc/trireme/hooks","issue_events_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/events{/number}","events_url":"https://api.github.com/repos/aporeto-inc/trireme/events","assignees_url":"https://api.github.com/repos/aporeto-inc/trireme/assignees{/user}","branches_url":"https://api.github.com/repos/aporeto-inc/trireme/branches{/branch}","tags_url":"https://api.github.com/repos/aporeto-inc/trireme/tags","blobs_url":"https://api.github.com/repos/aporeto-inc/trireme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aporeto-inc/trireme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aporeto-inc/trireme/git/refs{/sha}","trees_url":"https://api.github.com/repos/aporeto-inc/trireme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aporeto-inc/trireme/statuses/{sha}","languages_url":"https://api.github.com/repos/aporeto-inc/trireme/languages","stargazers_url":"https://api.github.com/repos/aporeto-inc/trireme/stargazers","contributors_url":"https://api.github.com/repos/aporeto-inc/trireme/contributors","subscribers_url":"https://api.github.com/repos/aporeto-inc/trireme/subscribers","subscription_url":"https://api.github.com/repos/aporeto-inc/trireme/subscription","commits_url":"https://api.github.com/repos/aporeto-inc/trireme/commits{/sha}","git_commits_url":"https://api.github.com/repos/aporeto-inc/trireme/git/commits{/sha}","comments_url":"https://api.github.com/repos/aporeto-inc/trireme/comments{/number}","issue_comment_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/comments{/number}","contents_url":"https://api.github.com/repos/aporeto-inc/trireme/contents/{+path}","compare_url":"https://api.github.com/repos/aporeto-inc/trireme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aporeto-inc/trireme/merges","archive_url":"https://api.github.com/repos/aporeto-inc/trireme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aporeto-inc/trireme/downloads","issues_url":"https://api.github.com/repos/aporeto-inc/trireme/issues{/number}","pulls_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls{/number}","milestones_url":"https://api.github.com/repos/aporeto-inc/trireme/milestones{/number}","notifications_url":"https://api.github.com/repos/aporeto-inc/trireme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aporeto-inc/trireme/labels{/name}","releases_url":"https://api.github.com/repos/aporeto-inc/trireme/releases{/id}","deployments_url":"https://api.github.com/repos/aporeto-inc/trireme/deployments","created_at":"2016-10-20T22:41:40Z","updated_at":"2017-11-13T19:36:17Z","pushed_at":"2017-11-13T22:32:39Z","git_url":"git://github.com/aporeto-inc/trireme.git","ssh_url":"git@github.com:aporeto-inc/trireme.git","clone_url":"https://github.com/aporeto-inc/trireme.git","svn_url":"https://github.com/aporeto-inc/trireme","homepage":"https://trireme.io","size":19338,"stargazers_count":220,"watchers_count":220,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":220,"default_branch":"master"}},"base":{"label":"aporeto-inc:master","ref":"master","sha":"b6d3b81958828d02cd29120ba34fdd0ee6ab40c2","user":{"login":"aporeto-inc","id":15617796,"avatar_url":"https://avatars2.githubusercontent.com/u/15617796?v=4","gravatar_id":"","url":"https://api.github.com/users/aporeto-inc","html_url":"https://github.com/aporeto-inc","followers_url":"https://api.github.com/users/aporeto-inc/followers","following_url":"https://api.github.com/users/aporeto-inc/following{/other_user}","gists_url":"https://api.github.com/users/aporeto-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/aporeto-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aporeto-inc/subscriptions","organizations_url":"https://api.github.com/users/aporeto-inc/orgs","repos_url":"https://api.github.com/users/aporeto-inc/repos","events_url":"https://api.github.com/users/aporeto-inc/events{/privacy}","received_events_url":"https://api.github.com/users/aporeto-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":71510166,"name":"trireme","full_name":"aporeto-inc/trireme","owner":{"login":"aporeto-inc","id":15617796,"avatar_url":"https://avatars2.githubusercontent.com/u/15617796?v=4","gravatar_id":"","url":"https://api.github.com/users/aporeto-inc","html_url":"https://github.com/aporeto-inc","followers_url":"https://api.github.com/users/aporeto-inc/followers","following_url":"https://api.github.com/users/aporeto-inc/following{/other_user}","gists_url":"https://api.github.com/users/aporeto-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/aporeto-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aporeto-inc/subscriptions","organizations_url":"https://api.github.com/users/aporeto-inc/orgs","repos_url":"https://api.github.com/users/aporeto-inc/repos","events_url":"https://api.github.com/users/aporeto-inc/events{/privacy}","received_events_url":"https://api.github.com/users/aporeto-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aporeto-inc/trireme","description":"Simple, scalable and secure application segmentation","fork":false,"url":"https://api.github.com/repos/aporeto-inc/trireme","forks_url":"https://api.github.com/repos/aporeto-inc/trireme/forks","keys_url":"https://api.github.com/repos/aporeto-inc/trireme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aporeto-inc/trireme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aporeto-inc/trireme/teams","hooks_url":"https://api.github.com/repos/aporeto-inc/trireme/hooks","issue_events_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/events{/number}","events_url":"https://api.github.com/repos/aporeto-inc/trireme/events","assignees_url":"https://api.github.com/repos/aporeto-inc/trireme/assignees{/user}","branches_url":"https://api.github.com/repos/aporeto-inc/trireme/branches{/branch}","tags_url":"https://api.github.com/repos/aporeto-inc/trireme/tags","blobs_url":"https://api.github.com/repos/aporeto-inc/trireme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aporeto-inc/trireme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aporeto-inc/trireme/git/refs{/sha}","trees_url":"https://api.github.com/repos/aporeto-inc/trireme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aporeto-inc/trireme/statuses/{sha}","languages_url":"https://api.github.com/repos/aporeto-inc/trireme/languages","stargazers_url":"https://api.github.com/repos/aporeto-inc/trireme/stargazers","contributors_url":"https://api.github.com/repos/aporeto-inc/trireme/contributors","subscribers_url":"https://api.github.com/repos/aporeto-inc/trireme/subscribers","subscription_url":"https://api.github.com/repos/aporeto-inc/trireme/subscription","commits_url":"https://api.github.com/repos/aporeto-inc/trireme/commits{/sha}","git_commits_url":"https://api.github.com/repos/aporeto-inc/trireme/git/commits{/sha}","comments_url":"https://api.github.com/repos/aporeto-inc/trireme/comments{/number}","issue_comment_url":"https://api.github.com/repos/aporeto-inc/trireme/issues/comments{/number}","contents_url":"https://api.github.com/repos/aporeto-inc/trireme/contents/{+path}","compare_url":"https://api.github.com/repos/aporeto-inc/trireme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aporeto-inc/trireme/merges","archive_url":"https://api.github.com/repos/aporeto-inc/trireme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aporeto-inc/trireme/downloads","issues_url":"https://api.github.com/repos/aporeto-inc/trireme/issues{/number}","pulls_url":"https://api.github.com/repos/aporeto-inc/trireme/pulls{/number}","milestones_url":"https://api.github.com/repos/aporeto-inc/trireme/milestones{/number}","notifications_url":"https://api.github.com/repos/aporeto-inc/trireme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aporeto-inc/trireme/labels{/name}","releases_url":"https://api.github.com/repos/aporeto-inc/trireme/releases{/id}","deployments_url":"https://api.github.com/repos/aporeto-inc/trireme/deployments","created_at":"2016-10-20T22:41:40Z","updated_at":"2017-11-13T19:36:17Z","pushed_at":"2017-11-13T22:32:39Z","git_url":"git://github.com/aporeto-inc/trireme.git","ssh_url":"git@github.com:aporeto-inc/trireme.git","clone_url":"https://github.com/aporeto-inc/trireme.git","svn_url":"https://github.com/aporeto-inc/trireme","homepage":"https://trireme.io","size":19338,"stargazers_count":220,"watchers_count":220,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392"},"html":{"href":"https://github.com/aporeto-inc/trireme/pull/392"},"issue":{"href":"https://api.github.com/repos/aporeto-inc/trireme/issues/392"},"comments":{"href":"https://api.github.com/repos/aporeto-inc/trireme/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aporeto-inc/trireme/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/aporeto-inc/trireme/statuses/e1933186a8e5edd963a267fa932655054690ed7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"satyamsi"}}