{"action":"created","issue":{"url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/28","repository_url":"https://api.github.com/repos/azavea/pwd-unitybar","labels_url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/28/comments","events_url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/28/events","html_url":"https://github.com/azavea/pwd-unitybar/pull/28","id":277203874,"number":28,"title":"Create dist bundle","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars1.githubusercontent.com/u/4165523?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"labels":[{"id":691614202,"url":"https://api.github.com/repos/azavea/pwd-unitybar/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"assignees":[{"login":"rajadain","id":1430060,"avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-11-27T23:17:44Z","updated_at":"2017-11-30T17:05:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/azavea/pwd-unitybar/pulls/28","html_url":"https://github.com/azavea/pwd-unitybar/pull/28","diff_url":"https://github.com/azavea/pwd-unitybar/pull/28.diff","patch_url":"https://github.com/azavea/pwd-unitybar/pull/28.patch"},"body":"## Overview\r\n\r\nThis PR adds infrastructure for generating distribution bundles on releases and adjusts the release instructions to note that one should generate the dist bundles and check them in on releases.\r\n\r\nConnects #25\r\n\r\n### Notes\r\n\r\n- `babel-polyfill` apparently can't be nested, so I change this back to use `transform-runtime` as Babel recommends for libraries\r\n- to reduce the size of the bundles, I made `react` and `react-dom` into externals which are then loaded from the apps which use this. This works pretty seamlessly except that the `react-onclickoutside` dependency expects ReactDOM 16.x to work correctly now. This upgrade will have to happen in the apps this gets used in, though.\r\n\r\n## Testing Instructions\r\n- run `.scripts/cibuild` and verify that it outputs two bundles in the `dist` dir: one minified, one not. Output should look similar to: https://travis-ci.org/azavea/pwd-unitybar/builds/308162185\r\n- check the testing instructions in the GARP/EPA STAR cognate PR."},"comment":{"url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/comments/348254137","html_url":"https://github.com/azavea/pwd-unitybar/pull/28#issuecomment-348254137","issue_url":"https://api.github.com/repos/azavea/pwd-unitybar/issues/28","id":348254137,"user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T17:05:54Z","updated_at":"2017-11-30T17:05:54Z","author_association":"NONE","body":"Here's the diff if interesting: [pwd.unitybar.js.diff.txt](https://github.com/azavea/pwd-unitybar/files/1518744/pwd.unitybar.js.diff.txt)\r\n"}}
{"actor":{"display_login":"rajadain"}}