{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/94560643","pull_request_review_id":15087374,"id":94560643,"diff_hunk":"@@ -66,12 +66,14 @@ public function testController()\n         ;\n         $extension = new PageExtension($cmsManager, $siteSelector, $router, $blockHelper, $HttpKernelExtension);\n         $extension->initRuntime($env);\n-        $HttpKernelExtension->expects($this->once())->method('controller')->with(\n-            'foo',\n-            array('pathInfo' => '/foo/bar/'),\n-            array()\n-        )\n-        ;\n+        if (!method_exists('Symfony\\Bridge\\Twig\\AppVariable', 'getToken')) {\n+            $HttpKernelExtension->expects($this->once())->method('controller')->with(\n+                'foo',\n+                array('pathInfo' => '/foo/bar/'),\n+                array()\n+            )\n+            ;","path":"Tests/Twig/Extension/PageExtensionTest.php","position":16,"original_position":16,"commit_id":"157ae5be8ef6662c6e58675d2e74baaf956dbf75","original_commit_id":"157ae5be8ef6662c6e58675d2e74baaf956dbf75","user":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"body":"this looks weird","created_at":"2017-01-04T10:31:34Z","updated_at":"2017-01-04T10:31:56Z","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/761#discussion_r94560643","pull_request_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/94560643"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/761#discussion_r94560643"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761","id":100008866,"html_url":"https://github.com/sonata-project/SonataPageBundle/pull/761","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/761.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/761.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/761","number":761,"state":"closed","locked":false,"title":"Stop calling static method in a non-static way","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"I am targetting this branch, because this is BC.\r\n\r\n\r\n## Subject\r\n\r\nFixes the broken test suite\r\n\r\nCloses #760\r\n\r\nSince symfony/twig-bridge#3.2, HttpKernelExtension::controller is no\r\nlonger static. This is not a problem when running the code, but it is\r\nwhen trying to mock the extension and then call the method on it. This\r\nfix calls the extension method statically and removes the mocking calls\r\nwhen appropriate.\r\n\r\nTo be merged asap 🚨 ","created_at":"2017-01-03T19:40:16Z","updated_at":"2017-01-04T10:31:56Z","closed_at":"2017-01-03T21:18:25Z","merged_at":"2017-01-03T21:18:25Z","merge_commit_sha":"1734f3c3ba52c2108407bf9eac58edce5618abab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/761/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/157ae5be8ef6662c6e58675d2e74baaf956dbf75","head":{"label":"greg0ire:fixes/broken_test_suite","ref":"fixes/broken_test_suite","sha":"157ae5be8ef6662c6e58675d2e74baaf956dbf75","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":19692849,"name":"SonataPageBundle","full_name":"greg0ire/SonataPageBundle","owner":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg0ire/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/greg0ire/SonataPageBundle","forks_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/greg0ire/SonataPageBundle/deployments","created_at":"2014-05-12T09:28:08Z","updated_at":"2014-05-28T09:33:29Z","pushed_at":"2017-01-03T21:18:29Z","git_url":"git://github.com/greg0ire/SonataPageBundle.git","ssh_url":"git@github.com:greg0ire/SonataPageBundle.git","clone_url":"https://github.com/greg0ire/SonataPageBundle.git","svn_url":"https://github.com/greg0ire/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":3589,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"7ecf74b57ad30367fd7728ceb4942a29361f9070","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/deployments","created_at":"2010-12-06T00:18:21Z","updated_at":"2016-12-18T02:39:35Z","pushed_at":"2017-01-04T01:00:16Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":3622,"stargazers_count":145,"watchers_count":145,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":66,"forks":164,"open_issues":66,"watchers":145,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/761"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/761"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/761/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/761/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/157ae5be8ef6662c6e58675d2e74baaf956dbf75"}}}}
{"actor":{"display_login":"OskarStark"}}