{"action":"opened","issue":{"url":"https://api.github.com/repos/wavelab/libwave/issues/45","repository_url":"https://api.github.com/repos/wavelab/libwave","labels_url":"https://api.github.com/repos/wavelab/libwave/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/wavelab/libwave/issues/45/comments","events_url":"https://api.github.com/repos/wavelab/libwave/issues/45/events","html_url":"https://github.com/wavelab/libwave/issues/45","id":221633430,"number":45,"title":"Properly find dependencies with CMake","user":{"login":"leokoppel","id":3952195,"avatar_url":"https://avatars1.githubusercontent.com/u/3952195?v=3","gravatar_id":"","url":"https://api.github.com/users/leokoppel","html_url":"https://github.com/leokoppel","followers_url":"https://api.github.com/users/leokoppel/followers","following_url":"https://api.github.com/users/leokoppel/following{/other_user}","gists_url":"https://api.github.com/users/leokoppel/gists{/gist_id}","starred_url":"https://api.github.com/users/leokoppel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leokoppel/subscriptions","organizations_url":"https://api.github.com/users/leokoppel/orgs","repos_url":"https://api.github.com/users/leokoppel/repos","events_url":"https://api.github.com/users/leokoppel/events{/privacy}","received_events_url":"https://api.github.com/users/leokoppel/received_events","type":"User","site_admin":false},"labels":[{"id":521863216,"url":"https://api.github.com/repos/wavelab/libwave/labels/fix","name":"fix","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-13T17:40:26Z","updated_at":"2017-04-13T17:40:26Z","closed_at":null,"body":"The purpose of CMake is to allow cross-platform builds without making assumptions about directory structure.\r\n\r\nOver time some absolute paths have crept into CMakeLists files. Conversely, some dependencies are found by virtue of being in the default path, but are never declared. These practices may cause problems for users with different directory structures, different OS, multiple versions of libraries installed, etc.\r\n\r\nThe tasks for this issue are:\r\n\r\n#### Remove hardcoded paths from CMake files\r\n   This includes lines such as\r\n   ```cmake\r\n   INCLUDE_DIRECTORIES(/usr/include/eigen3)\r\n   ```\r\n   and \r\n   ```cmake\r\n   INCLUDE_DIRECTORIES(/usr/include)\r\n   ```\r\n\r\n#### Explicitly list all dependencies\r\n   For example, Boost is not listed"}}
{"actor":{"display_login":"leokoppel"}}