{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/988","repository_url":"https://api.github.com/repos/apple/swift-corelibs-foundation","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/988/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/988/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/988/events","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/988","id":229582229,"number":988,"title":"'Fix' macOS build errors, explicit tuple members (Swift 4), TestXDG folder cleanup","user":{"login":"e78l","id":16230516,"avatar_url":"https://avatars1.githubusercontent.com/u/16230516?v=3","gravatar_id":"","url":"https://api.github.com/users/e78l","html_url":"https://github.com/e78l","followers_url":"https://api.github.com/users/e78l/followers","following_url":"https://api.github.com/users/e78l/following{/other_user}","gists_url":"https://api.github.com/users/e78l/gists{/gist_id}","starred_url":"https://api.github.com/users/e78l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e78l/subscriptions","organizations_url":"https://api.github.com/users/e78l/orgs","repos_url":"https://api.github.com/users/e78l/repos","events_url":"https://api.github.com/users/e78l/events{/privacy}","received_events_url":"https://api.github.com/users/e78l/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-18T07:43:30Z","updated_at":"2017-05-22T21:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/988","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/988","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/988.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/988.patch"},"body":"- 'Fix' macOS build errors with swift compiler option `-swift-version 3`. Xcode seems to have a SWIFT_VERSION setting, but it doesn't have the same effect! Changes should be like those in https://github.com/apple/swift-corelibs-foundation/pull/956.\r\n- Quiet some warnings with `-Wno-nullability-completeness-on-arrays` and `-Wno-format-security` for CoreFoundation - please review if `GCC_WARN_TYPECHECK_CALLS_TO_PRINTF` Xcode setting has the same effect/is better than `-Wno-format-security`\r\n- Has mangling changed on Mac? I've have had issues with comparing CF/NS strings, and not sure if it /was just/ a mangling issue, but got warning and error with macOS build, so updating __CFSwiftGetBaseClass and __CFConstantStringClassReference.\r\n@slavapestov  or @eeckstein - is there a way for a script to determine a mangled class/function name at build time?\r\nThe warning/error reported on macOS:\r\n~~~~\r\nld: warning: undefined base symbol '__TMC15SwiftFoundation19_NSCFConstantString' for alias '___CFConstantStringClassReference'\r\nUndefined symbols for architecture x86_64:\r\n  \"__T015SwiftFoundation21__CFSwiftGetBaseClassyXlXpyF\", referenced from:\r\n      ___CFInitialize in libCoreFoundation.a(CFRuntime.o)\r\nld: symbol(s) not found for architecture x86_64\r\nclang: error: linker command failed with exit code 1 (use -v to see invocation)\r\n~~~~\r\n- Refactored XDG helper, and created target in Xcode so tests pass on Mac (well 2 failures still in NSString):\r\n~~~~\r\nTestNSString.test_FromContentsOfURLUsedEncodingUTF16BE : failed - URL for NSString-UTF16-BE-data.txt is nil\r\nTestNSString.test_FromContentsOfURLUsedEncodingUTF16LE : failed - URL for NSString-UTF16-LE-data.txt is nil\r\n~~~~\r\nTarget depends on SwiftFoundation being at same level in build directory (added rpath in lieu of framework copy phase). Perhaps copy can be disabled for TestFoundation too?\r\n@mamabusi Are these changes okay with you?\r\nI am thinking, perhaps, xdgTestHelper can be renamed `testHelper` or similar and used for any other 'checks' needing another process in the future."},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments/303224665","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/988#issuecomment-303224665","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/988","id":303224665,"user":{"login":"e78l","id":16230516,"avatar_url":"https://avatars1.githubusercontent.com/u/16230516?v=3","gravatar_id":"","url":"https://api.github.com/users/e78l","html_url":"https://github.com/e78l","followers_url":"https://api.github.com/users/e78l/followers","following_url":"https://api.github.com/users/e78l/following{/other_user}","gists_url":"https://api.github.com/users/e78l/gists{/gist_id}","starred_url":"https://api.github.com/users/e78l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e78l/subscriptions","organizations_url":"https://api.github.com/users/e78l/orgs","repos_url":"https://api.github.com/users/e78l/repos","events_url":"https://api.github.com/users/e78l/events{/privacy}","received_events_url":"https://api.github.com/users/e78l/received_events","type":"User","site_admin":false},"created_at":"2017-05-22T21:26:44Z","updated_at":"2017-05-22T21:26:44Z","body":"Hello @parkera,\r\nThanks for the review - I split some changes that were easy to do into #1006 and can split further+undo warnings silence if decided (would be a bit time consuming).\r\nRemoved Swift 4 changes which I think were covered by @spevans. After those changes, may be able to forget about `-swift-version 3`; in that case, may also want to update build.py.\r\n@mamabusi Thanks also!"}}
{"actor":{"display_login":"e78l"}}