{"action":"closed","number":3344,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344","id":116304006,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3344","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3344.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3344.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3344","number":3344,"state":"closed","locked":false,"title":"Sample4-PR-201-vmss-scale-existing . - - Support for Env Var","user":{"login":"amalik99","id":15818309,"avatar_url":"https://avatars0.githubusercontent.com/u/15818309?v=3","gravatar_id":"","url":"https://api.github.com/users/amalik99","html_url":"https://github.com/amalik99","followers_url":"https://api.github.com/users/amalik99/followers","following_url":"https://api.github.com/users/amalik99/following{/other_user}","gists_url":"https://api.github.com/users/amalik99/gists{/gist_id}","starred_url":"https://api.github.com/users/amalik99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalik99/subscriptions","organizations_url":"https://api.github.com/users/amalik99/orgs","repos_url":"https://api.github.com/users/amalik99/repos","events_url":"https://api.github.com/users/amalik99/events{/privacy}","received_events_url":"https://api.github.com/users/amalik99/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n","created_at":"2017-04-18T11:13:18Z","updated_at":"2017-06-12T10:12:57Z","closed_at":"2017-06-12T10:12:57Z","merged_at":null,"merge_commit_sha":"17896ab94a8e4d17793f432f5560a134d1594396","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3344/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/123bbad64f01344bd5dd30dba5b605b8b7811b89","head":{"label":"SpektraSystems:Sample4-PR-201-vmss-scale-existing","ref":"Sample4-PR-201-vmss-scale-existing","sha":"123bbad64f01344bd5dd30dba5b605b8b7811b89","user":{"login":"SpektraSystems","id":22569568,"avatar_url":"https://avatars3.githubusercontent.com/u/22569568?v=3","gravatar_id":"","url":"https://api.github.com/users/SpektraSystems","html_url":"https://github.com/SpektraSystems","followers_url":"https://api.github.com/users/SpektraSystems/followers","following_url":"https://api.github.com/users/SpektraSystems/following{/other_user}","gists_url":"https://api.github.com/users/SpektraSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/SpektraSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpektraSystems/subscriptions","organizations_url":"https://api.github.com/users/SpektraSystems/orgs","repos_url":"https://api.github.com/users/SpektraSystems/repos","events_url":"https://api.github.com/users/SpektraSystems/events{/privacy}","received_events_url":"https://api.github.com/users/SpektraSystems/received_events","type":"Organization","site_admin":false},"repo":null},"base":{"label":"Azure:master","ref":"master","sha":"5aaa36908cb2362e50906babf95b6b73b34d6460","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-06-12T07:48:27Z","pushed_at":"2017-06-11T16:09:40Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":199051,"stargazers_count":2395,"watchers_count":2395,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3407,"mirror_url":null,"open_issues_count":354,"forks":3407,"open_issues":354,"watchers":2395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3344"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3344"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3344/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3344/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/123bbad64f01344bd5dd30dba5b605b8b7811b89"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"amalik99"}}