{"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/157488877","pull_request_review_id":84137742,"id":157488877,"diff_hunk":"@@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final CreateNodeWithGroupEncod\n       final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions()\n             .as(DimensionDataCloudControlTemplateOptions.class);\n \n-      String networkDomainName = firstNonNull(templateOptions.getNetworkDomainName(), DEFAULT_NETWORK_DOMAIN_NAME);\n-      String vlanName = firstNonNull(templateOptions.getVlanName(), DEFAULT_VLAN_NAME);\n+      final Set<String> networks = templateOptions.getNetworks();\n+\n+      String networkDomainName = firstNonNull(!networks.isEmpty() ? networks.iterator().next() : null,\n+            DimensionDataCloudControlTemplateOptions.DEFAULT_NETWORK_DOMAIN_NAME);","path":"dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/compute/strategy/GetOrCreateNetworkDomainThenCreateNodes.java","position":null,"original_position":21,"commit_id":"07e8d0d3fa5d86d815180d7c471895dae8c6d120","original_commit_id":"07e8d0d3fa5d86d815180d7c471895dae8c6d120","user":{"login":"trevorflanagan","id":16255147,"avatar_url":"https://avatars0.githubusercontent.com/u/16255147?v=4","gravatar_id":"","url":"https://api.github.com/users/trevorflanagan","html_url":"https://github.com/trevorflanagan","followers_url":"https://api.github.com/users/trevorflanagan/followers","following_url":"https://api.github.com/users/trevorflanagan/following{/other_user}","gists_url":"https://api.github.com/users/trevorflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorflanagan/subscriptions","organizations_url":"https://api.github.com/users/trevorflanagan/orgs","repos_url":"https://api.github.com/users/trevorflanagan/repos","events_url":"https://api.github.com/users/trevorflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/trevorflanagan/received_events","type":"User","site_admin":false},"body":">Sounds good. Use the DD options to configure the domain name, and read the VLAN names from the templateOptions.networks option.\r\n\r\nCool @nacx this is the approach I am going to take. \r\n\r\n>> OR we could use a Server to retrieve this information and therefore reduce the set of Vlans we store in templateOptions.network. Just not sure what you think is the best approach?\r\n\r\n> I'm not sure I get what you mean with this. The templateOptions.networks options are used to tell jclouds where to attach the servers it is about to create... Could you please clarify what do you mean?\r\n\r\nI took a look a bit further at the core jclouds code and that option does not make any sense, since we are actually creating nodes here.\r\n","created_at":"2017-12-18T13:52:19Z","updated_at":"2017-12-18T13:52:19Z","html_url":"https://github.com/jclouds/jclouds-labs/pull/426#discussion_r157488877","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/157488877"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/426#discussion_r157488877"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426"}},"in_reply_to_id":157140848},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426","id":157275817,"html_url":"https://github.com/jclouds/jclouds-labs/pull/426","diff_url":"https://github.com/jclouds/jclouds-labs/pull/426.diff","patch_url":"https://github.com/jclouds/jclouds-labs/pull/426.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/426","number":426,"state":"open","locked":false,"title":"Implement GetOrCreateNetworkDomainThenCreateNodes Strategy","user":{"login":"trevorflanagan","id":16255147,"avatar_url":"https://avatars0.githubusercontent.com/u/16255147?v=4","gravatar_id":"","url":"https://api.github.com/users/trevorflanagan","html_url":"https://github.com/trevorflanagan","followers_url":"https://api.github.com/users/trevorflanagan/followers","following_url":"https://api.github.com/users/trevorflanagan/following{/other_user}","gists_url":"https://api.github.com/users/trevorflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorflanagan/subscriptions","organizations_url":"https://api.github.com/users/trevorflanagan/orgs","repos_url":"https://api.github.com/users/trevorflanagan/repos","events_url":"https://api.github.com/users/trevorflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/trevorflanagan/received_events","type":"User","site_admin":false},"body":"Extending `org.jclouds.compute.strategy.impl.CreateNodesWithGroupEncodedIntoNameThenAddToSet` for jclouds abstraction strategy.","created_at":"2017-12-08T16:02:08Z","updated_at":"2017-12-18T13:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a69f7e66bb413a47187edd587346ff98e3bc769d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/426/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/07e8d0d3fa5d86d815180d7c471895dae8c6d120","head":{"label":"DimensionDataDublin:GetOrCreateNetworkDomain_ThenCreateNodes","ref":"GetOrCreateNetworkDomain_ThenCreateNodes","sha":"07e8d0d3fa5d86d815180d7c471895dae8c6d120","user":{"login":"DimensionDataDublin","id":26415494,"avatar_url":"https://avatars2.githubusercontent.com/u/26415494?v=4","gravatar_id":"","url":"https://api.github.com/users/DimensionDataDublin","html_url":"https://github.com/DimensionDataDublin","followers_url":"https://api.github.com/users/DimensionDataDublin/followers","following_url":"https://api.github.com/users/DimensionDataDublin/following{/other_user}","gists_url":"https://api.github.com/users/DimensionDataDublin/gists{/gist_id}","starred_url":"https://api.github.com/users/DimensionDataDublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimensionDataDublin/subscriptions","organizations_url":"https://api.github.com/users/DimensionDataDublin/orgs","repos_url":"https://api.github.com/users/DimensionDataDublin/repos","events_url":"https://api.github.com/users/DimensionDataDublin/events{/privacy}","received_events_url":"https://api.github.com/users/DimensionDataDublin/received_events","type":"User","site_admin":false},"repo":{"id":84979674,"name":"jclouds-labs","full_name":"DimensionDataDublin/jclouds-labs","owner":{"login":"DimensionDataDublin","id":26415494,"avatar_url":"https://avatars2.githubusercontent.com/u/26415494?v=4","gravatar_id":"","url":"https://api.github.com/users/DimensionDataDublin","html_url":"https://github.com/DimensionDataDublin","followers_url":"https://api.github.com/users/DimensionDataDublin/followers","following_url":"https://api.github.com/users/DimensionDataDublin/following{/other_user}","gists_url":"https://api.github.com/users/DimensionDataDublin/gists{/gist_id}","starred_url":"https://api.github.com/users/DimensionDataDublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimensionDataDublin/subscriptions","organizations_url":"https://api.github.com/users/DimensionDataDublin/orgs","repos_url":"https://api.github.com/users/DimensionDataDublin/repos","events_url":"https://api.github.com/users/DimensionDataDublin/events{/privacy}","received_events_url":"https://api.github.com/users/DimensionDataDublin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DimensionDataDublin/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":true,"url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs","forks_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/forks","keys_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/events","assignees_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/merges","archive_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/DimensionDataDublin/jclouds-labs/deployments","created_at":"2017-03-14T17:45:34Z","updated_at":"2017-03-24T17:04:10Z","pushed_at":"2017-12-18T13:35:50Z","git_url":"git://github.com/DimensionDataDublin/jclouds-labs.git","ssh_url":"git@github.com:DimensionDataDublin/jclouds-labs.git","clone_url":"https://github.com/DimensionDataDublin/jclouds-labs.git","svn_url":"https://github.com/DimensionDataDublin/jclouds-labs","homepage":null,"size":22731,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"eaeea5c31ddd886c972d9b9aaee66b9be31889e8","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars2.githubusercontent.com/u/108982?v=4","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040970,"name":"jclouds-labs","full_name":"jclouds/jclouds-labs","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars2.githubusercontent.com/u/108982?v=4","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/jclouds/jclouds-labs/deployments","created_at":"2013-05-13T20:47:47Z","updated_at":"2017-11-14T23:29:12Z","pushed_at":"2017-12-18T13:31:56Z","git_url":"git://github.com/jclouds/jclouds-labs.git","ssh_url":"git@github.com:jclouds/jclouds-labs.git","clone_url":"https://github.com/jclouds/jclouds-labs.git","svn_url":"https://github.com/jclouds/jclouds-labs","homepage":null,"size":22691,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":102,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/426"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/426"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/07e8d0d3fa5d86d815180d7c471895dae8c6d120"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"trevorflanagan"}}