{"action":"created","comment":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/112118162","pull_request_review_id":33407758,"id":112118162,"diff_hunk":"@@ -1778,19 +1778,20 @@ candidate:1 1 UDP 1694498815 192.0.2.33 10000 typ host\n           \"a=rtcp-fb\" attributes, indicating its willingness to support\n           \"(UDP,TCP)/TLS/RTP/SAVPF\". In order to simplify compatibility\n           with such endpoints, JSEP implementations MUST follow the\n-          following rules when processing the media m= sections in an\n-          offer:</t>\n+          following rules when processing the media m= sections in a\n+          received offer:</t>\n \n           <t>\n             <list style=\"symbols\">\n-\n-              <t>The profile in any \"m=\" line in any answer MUST\n-              exactly match the profile provided in the offer.</t>\n-\n-              <t>Any profile matching the following patterns MUST be\n-              accepted: \"RTP/[S]AVP[F]\" and\n-              \"(UDP/TCP)/TLS/RTP/SAVP[F]\"</t>\n-\n+              <t>Any profile in the offer matching the following patterns\n+              MUST be accepted: \"RTP/[S]AVP[F]\" and \n+              \"(UDP/TCP)/TLS/RTP/SAVP[F]\".","path":"draft-ietf-rtcweb-jsep.xml","position":21,"original_position":21,"commit_id":"6e69fac16e215545b1c82ae7b92665aa064ad5d0","original_commit_id":"6e69fac16e215545b1c82ae7b92665aa064ad5d0","user":{"login":"juberti","id":1821693,"avatar_url":"https://avatars2.githubusercontent.com/u/1821693?v=3","gravatar_id":"","url":"https://api.github.com/users/juberti","html_url":"https://github.com/juberti","followers_url":"https://api.github.com/users/juberti/followers","following_url":"https://api.github.com/users/juberti/following{/other_user}","gists_url":"https://api.github.com/users/juberti/gists{/gist_id}","starred_url":"https://api.github.com/users/juberti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juberti/subscriptions","organizations_url":"https://api.github.com/users/juberti/orgs","repos_url":"https://api.github.com/users/juberti/repos","events_url":"https://api.github.com/users/juberti/events{/privacy}","received_events_url":"https://api.github.com/users/juberti/received_events","type":"User","site_admin":false},"body":"OK. Will tweak accordingly.","created_at":"2017-04-19T05:30:08Z","updated_at":"2017-04-19T05:30:08Z","html_url":"https://github.com/rtcweb-wg/jsep/pull/629#discussion_r112118162","pull_request_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629","_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/112118162"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/629#discussion_r112118162"},"pull_request":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629"}}},"pull_request":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629","id":112643090,"html_url":"https://github.com/rtcweb-wg/jsep/pull/629","diff_url":"https://github.com/rtcweb-wg/jsep/pull/629.diff","patch_url":"https://github.com/rtcweb-wg/jsep/pull/629.patch","issue_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/629","number":629,"state":"open","locked":false,"title":"Clarify that when generating an answer the proto field value","user":{"login":"gloinul","id":11295323,"avatar_url":"https://avatars0.githubusercontent.com/u/11295323?v=3","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"body":"Proposal for how to clarify that when JSEP implementation generates an answer it needs to have the proto value identical to what is in the offer. ","created_at":"2017-03-26T20:33:17Z","updated_at":"2017-04-19T05:30:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35c6f92975eca76adc1595918cbaf8d377fe5cb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629/commits","review_comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629/comments","review_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/629/comments","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/6e69fac16e215545b1c82ae7b92665aa064ad5d0","head":{"label":"gloinul:master","ref":"master","sha":"6e69fac16e215545b1c82ae7b92665aa064ad5d0","user":{"login":"gloinul","id":11295323,"avatar_url":"https://avatars0.githubusercontent.com/u/11295323?v=3","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"repo":{"id":74475878,"name":"jsep","full_name":"gloinul/jsep","owner":{"login":"gloinul","id":11295323,"avatar_url":"https://avatars0.githubusercontent.com/u/11295323?v=3","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gloinul/jsep","description":null,"fork":true,"url":"https://api.github.com/repos/gloinul/jsep","forks_url":"https://api.github.com/repos/gloinul/jsep/forks","keys_url":"https://api.github.com/repos/gloinul/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gloinul/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gloinul/jsep/teams","hooks_url":"https://api.github.com/repos/gloinul/jsep/hooks","issue_events_url":"https://api.github.com/repos/gloinul/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/gloinul/jsep/events","assignees_url":"https://api.github.com/repos/gloinul/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/gloinul/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/gloinul/jsep/tags","blobs_url":"https://api.github.com/repos/gloinul/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gloinul/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gloinul/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/gloinul/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gloinul/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/gloinul/jsep/languages","stargazers_url":"https://api.github.com/repos/gloinul/jsep/stargazers","contributors_url":"https://api.github.com/repos/gloinul/jsep/contributors","subscribers_url":"https://api.github.com/repos/gloinul/jsep/subscribers","subscription_url":"https://api.github.com/repos/gloinul/jsep/subscription","commits_url":"https://api.github.com/repos/gloinul/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/gloinul/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/gloinul/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/gloinul/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/gloinul/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/gloinul/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gloinul/jsep/merges","archive_url":"https://api.github.com/repos/gloinul/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gloinul/jsep/downloads","issues_url":"https://api.github.com/repos/gloinul/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/gloinul/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/gloinul/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/gloinul/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gloinul/jsep/labels{/name}","releases_url":"https://api.github.com/repos/gloinul/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/gloinul/jsep/deployments","created_at":"2016-11-22T13:38:10Z","updated_at":"2017-03-26T19:40:13Z","pushed_at":"2017-03-30T04:21:59Z","git_url":"git://github.com/gloinul/jsep.git","ssh_url":"git@github.com:gloinul/jsep.git","clone_url":"https://github.com/gloinul/jsep.git","svn_url":"https://github.com/gloinul/jsep","homepage":null,"size":5118,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rtcweb-wg:master","ref":"master","sha":"71797aa19b686da7691f4578628d389e9720e81d","user":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":19118011,"name":"jsep","full_name":"rtcweb-wg/jsep","owner":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtcweb-wg/jsep","description":null,"fork":false,"url":"https://api.github.com/repos/rtcweb-wg/jsep","forks_url":"https://api.github.com/repos/rtcweb-wg/jsep/forks","keys_url":"https://api.github.com/repos/rtcweb-wg/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtcweb-wg/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtcweb-wg/jsep/teams","hooks_url":"https://api.github.com/repos/rtcweb-wg/jsep/hooks","issue_events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/events","assignees_url":"https://api.github.com/repos/rtcweb-wg/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/rtcweb-wg/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/tags","blobs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/rtcweb-wg/jsep/languages","stargazers_url":"https://api.github.com/repos/rtcweb-wg/jsep/stargazers","contributors_url":"https://api.github.com/repos/rtcweb-wg/jsep/contributors","subscribers_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscribers","subscription_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscription","commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtcweb-wg/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/rtcweb-wg/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtcweb-wg/jsep/merges","archive_url":"https://api.github.com/repos/rtcweb-wg/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtcweb-wg/jsep/downloads","issues_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/rtcweb-wg/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/rtcweb-wg/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/labels{/name}","releases_url":"https://api.github.com/repos/rtcweb-wg/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/rtcweb-wg/jsep/deployments","created_at":"2014-04-24T17:46:05Z","updated_at":"2017-03-10T23:57:59Z","pushed_at":"2017-04-14T06:12:49Z","git_url":"git://github.com/rtcweb-wg/jsep.git","ssh_url":"git@github.com:rtcweb-wg/jsep.git","clone_url":"https://github.com/rtcweb-wg/jsep.git","svn_url":"https://github.com/rtcweb-wg/jsep","homepage":null,"size":6519,"stargazers_count":16,"watchers_count":16,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/629"},"issue":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/629"},"comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/629/comments"},"review_comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629/comments"},"review_comment":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/629/commits"},"statuses":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/6e69fac16e215545b1c82ae7b92665aa064ad5d0"}}}}
{"actor":{"display_login":"juberti"}}