{"action":"created","comment":{"url":"https://api.github.com/repos/gchq/Gaffer/pulls/comments/133168476","pull_request_review_id":56315684,"id":133168476,"diff_hunk":"@@ -518,6 +521,12 @@ private void expandElementDefinitions(final Schema schema) {\n                 schema.getEntities().put(entry.getKey(), entry.getValue().getExpandedDefinition());\n             }\n         }\n+\n+        private void validateGroups() {\n+            getThisSchema().getEdgeGroups().forEach(edgeGroup -> GroupUtil.validate(edgeGroup));","path":"core/store/src/main/java/uk/gov/gchq/gaffer/store/schema/Schema.java","position":23,"original_position":23,"commit_id":"d6bb218379093f8c9cea3258af4d0d127b6b83ac","original_commit_id":"d6bb218379093f8c9cea3258af4d0d127b6b83ac","user":{"login":"p013570","id":16834101,"avatar_url":"https://avatars3.githubusercontent.com/u/16834101?v=4","gravatar_id":"","url":"https://api.github.com/users/p013570","html_url":"https://github.com/p013570","followers_url":"https://api.github.com/users/p013570/followers","following_url":"https://api.github.com/users/p013570/following{/other_user}","gists_url":"https://api.github.com/users/p013570/gists{/gist_id}","starred_url":"https://api.github.com/users/p013570/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p013570/subscriptions","organizations_url":"https://api.github.com/users/p013570/orgs","repos_url":"https://api.github.com/users/p013570/repos","events_url":"https://api.github.com/users/p013570/events{/privacy}","received_events_url":"https://api.github.com/users/p013570/received_events","type":"User","site_admin":false},"body":"You can simplify these lines to:\r\n\r\n```java\r\ngetThisSchema().getGroups().forEach(GroupUtil::validate);\r\ngetThisSchema().getEntityGroups().forEach(GroupUtil::validate);\r\n```","created_at":"2017-08-15T11:29:19Z","updated_at":"2017-08-15T11:29:36Z","html_url":"https://github.com/gchq/Gaffer/pull/1196#discussion_r133168476","pull_request_url":"https://api.github.com/repos/gchq/Gaffer/pulls/1196","_links":{"self":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/comments/133168476"},"html":{"href":"https://github.com/gchq/Gaffer/pull/1196#discussion_r133168476"},"pull_request":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/gchq/Gaffer/pulls/1196","id":135776790,"html_url":"https://github.com/gchq/Gaffer/pull/1196","diff_url":"https://github.com/gchq/Gaffer/pull/1196.diff","patch_url":"https://github.com/gchq/Gaffer/pull/1196.patch","issue_url":"https://api.github.com/repos/gchq/Gaffer/issues/1196","number":1196,"state":"open","locked":false,"title":"Gh 1110 validate groups and properties","user":{"login":"m55624","id":29117199,"avatar_url":"https://avatars3.githubusercontent.com/u/29117199?v=4","gravatar_id":"","url":"https://api.github.com/users/m55624","html_url":"https://github.com/m55624","followers_url":"https://api.github.com/users/m55624/followers","following_url":"https://api.github.com/users/m55624/following{/other_user}","gists_url":"https://api.github.com/users/m55624/gists{/gist_id}","starred_url":"https://api.github.com/users/m55624/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m55624/subscriptions","organizations_url":"https://api.github.com/users/m55624/orgs","repos_url":"https://api.github.com/users/m55624/repos","events_url":"https://api.github.com/users/m55624/events{/privacy}","received_events_url":"https://api.github.com/users/m55624/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-15T10:44:51Z","updated_at":"2017-08-15T11:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91a3a9ae77cbd5306a65c9f64a8cbd0c434188d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gchq/Gaffer/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/gchq/Gaffer/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/gchq/Gaffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gchq/Gaffer/issues/1196/comments","statuses_url":"https://api.github.com/repos/gchq/Gaffer/statuses/d6bb218379093f8c9cea3258af4d0d127b6b83ac","head":{"label":"gchq:gh-1110-validate-groups-and-properties","ref":"gh-1110-validate-groups-and-properties","sha":"d6bb218379093f8c9cea3258af4d0d127b6b83ac","user":{"login":"gchq","id":15800240,"avatar_url":"https://avatars2.githubusercontent.com/u/15800240?v=4","gravatar_id":"","url":"https://api.github.com/users/gchq","html_url":"https://github.com/gchq","followers_url":"https://api.github.com/users/gchq/followers","following_url":"https://api.github.com/users/gchq/following{/other_user}","gists_url":"https://api.github.com/users/gchq/gists{/gist_id}","starred_url":"https://api.github.com/users/gchq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchq/subscriptions","organizations_url":"https://api.github.com/users/gchq/orgs","repos_url":"https://api.github.com/users/gchq/repos","events_url":"https://api.github.com/users/gchq/events{/privacy}","received_events_url":"https://api.github.com/users/gchq/received_events","type":"Organization","site_admin":false},"repo":{"id":47973088,"name":"Gaffer","full_name":"gchq/Gaffer","owner":{"login":"gchq","id":15800240,"avatar_url":"https://avatars2.githubusercontent.com/u/15800240?v=4","gravatar_id":"","url":"https://api.github.com/users/gchq","html_url":"https://github.com/gchq","followers_url":"https://api.github.com/users/gchq/followers","following_url":"https://api.github.com/users/gchq/following{/other_user}","gists_url":"https://api.github.com/users/gchq/gists{/gist_id}","starred_url":"https://api.github.com/users/gchq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchq/subscriptions","organizations_url":"https://api.github.com/users/gchq/orgs","repos_url":"https://api.github.com/users/gchq/repos","events_url":"https://api.github.com/users/gchq/events{/privacy}","received_events_url":"https://api.github.com/users/gchq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gchq/Gaffer","description":"A large-scale entity and relation database supporting aggregation of properties","fork":false,"url":"https://api.github.com/repos/gchq/Gaffer","forks_url":"https://api.github.com/repos/gchq/Gaffer/forks","keys_url":"https://api.github.com/repos/gchq/Gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gchq/Gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gchq/Gaffer/teams","hooks_url":"https://api.github.com/repos/gchq/Gaffer/hooks","issue_events_url":"https://api.github.com/repos/gchq/Gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/gchq/Gaffer/events","assignees_url":"https://api.github.com/repos/gchq/Gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/gchq/Gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/gchq/Gaffer/tags","blobs_url":"https://api.github.com/repos/gchq/Gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gchq/Gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gchq/Gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gchq/Gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gchq/Gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/gchq/Gaffer/languages","stargazers_url":"https://api.github.com/repos/gchq/Gaffer/stargazers","contributors_url":"https://api.github.com/repos/gchq/Gaffer/contributors","subscribers_url":"https://api.github.com/repos/gchq/Gaffer/subscribers","subscription_url":"https://api.github.com/repos/gchq/Gaffer/subscription","commits_url":"https://api.github.com/repos/gchq/Gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gchq/Gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gchq/Gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gchq/Gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gchq/Gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/gchq/Gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gchq/Gaffer/merges","archive_url":"https://api.github.com/repos/gchq/Gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gchq/Gaffer/downloads","issues_url":"https://api.github.com/repos/gchq/Gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/gchq/Gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/gchq/Gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/gchq/Gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gchq/Gaffer/labels{/name}","releases_url":"https://api.github.com/repos/gchq/Gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/gchq/Gaffer/deployments","created_at":"2015-12-14T12:12:39Z","updated_at":"2017-08-14T13:36:58Z","pushed_at":"2017-08-15T11:28:52Z","git_url":"git://github.com/gchq/Gaffer.git","ssh_url":"git@github.com:gchq/Gaffer.git","clone_url":"https://github.com/gchq/Gaffer.git","svn_url":"https://github.com/gchq/Gaffer","homepage":"","size":51975,"stargazers_count":1345,"watchers_count":1345,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":289,"mirror_url":null,"open_issues_count":70,"forks":289,"open_issues":70,"watchers":1345,"default_branch":"master"}},"base":{"label":"gchq:develop","ref":"develop","sha":"edf8c6d535b1968734383ff41a3ed470b01803fa","user":{"login":"gchq","id":15800240,"avatar_url":"https://avatars2.githubusercontent.com/u/15800240?v=4","gravatar_id":"","url":"https://api.github.com/users/gchq","html_url":"https://github.com/gchq","followers_url":"https://api.github.com/users/gchq/followers","following_url":"https://api.github.com/users/gchq/following{/other_user}","gists_url":"https://api.github.com/users/gchq/gists{/gist_id}","starred_url":"https://api.github.com/users/gchq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchq/subscriptions","organizations_url":"https://api.github.com/users/gchq/orgs","repos_url":"https://api.github.com/users/gchq/repos","events_url":"https://api.github.com/users/gchq/events{/privacy}","received_events_url":"https://api.github.com/users/gchq/received_events","type":"Organization","site_admin":false},"repo":{"id":47973088,"name":"Gaffer","full_name":"gchq/Gaffer","owner":{"login":"gchq","id":15800240,"avatar_url":"https://avatars2.githubusercontent.com/u/15800240?v=4","gravatar_id":"","url":"https://api.github.com/users/gchq","html_url":"https://github.com/gchq","followers_url":"https://api.github.com/users/gchq/followers","following_url":"https://api.github.com/users/gchq/following{/other_user}","gists_url":"https://api.github.com/users/gchq/gists{/gist_id}","starred_url":"https://api.github.com/users/gchq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchq/subscriptions","organizations_url":"https://api.github.com/users/gchq/orgs","repos_url":"https://api.github.com/users/gchq/repos","events_url":"https://api.github.com/users/gchq/events{/privacy}","received_events_url":"https://api.github.com/users/gchq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gchq/Gaffer","description":"A large-scale entity and relation database supporting aggregation of properties","fork":false,"url":"https://api.github.com/repos/gchq/Gaffer","forks_url":"https://api.github.com/repos/gchq/Gaffer/forks","keys_url":"https://api.github.com/repos/gchq/Gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gchq/Gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gchq/Gaffer/teams","hooks_url":"https://api.github.com/repos/gchq/Gaffer/hooks","issue_events_url":"https://api.github.com/repos/gchq/Gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/gchq/Gaffer/events","assignees_url":"https://api.github.com/repos/gchq/Gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/gchq/Gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/gchq/Gaffer/tags","blobs_url":"https://api.github.com/repos/gchq/Gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gchq/Gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gchq/Gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gchq/Gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gchq/Gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/gchq/Gaffer/languages","stargazers_url":"https://api.github.com/repos/gchq/Gaffer/stargazers","contributors_url":"https://api.github.com/repos/gchq/Gaffer/contributors","subscribers_url":"https://api.github.com/repos/gchq/Gaffer/subscribers","subscription_url":"https://api.github.com/repos/gchq/Gaffer/subscription","commits_url":"https://api.github.com/repos/gchq/Gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gchq/Gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gchq/Gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gchq/Gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gchq/Gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/gchq/Gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gchq/Gaffer/merges","archive_url":"https://api.github.com/repos/gchq/Gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gchq/Gaffer/downloads","issues_url":"https://api.github.com/repos/gchq/Gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/gchq/Gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/gchq/Gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/gchq/Gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gchq/Gaffer/labels{/name}","releases_url":"https://api.github.com/repos/gchq/Gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/gchq/Gaffer/deployments","created_at":"2015-12-14T12:12:39Z","updated_at":"2017-08-14T13:36:58Z","pushed_at":"2017-08-15T11:28:52Z","git_url":"git://github.com/gchq/Gaffer.git","ssh_url":"git@github.com:gchq/Gaffer.git","clone_url":"https://github.com/gchq/Gaffer.git","svn_url":"https://github.com/gchq/Gaffer","homepage":"","size":51975,"stargazers_count":1345,"watchers_count":1345,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":289,"mirror_url":null,"open_issues_count":70,"forks":289,"open_issues":70,"watchers":1345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/1196"},"html":{"href":"https://github.com/gchq/Gaffer/pull/1196"},"issue":{"href":"https://api.github.com/repos/gchq/Gaffer/issues/1196"},"comments":{"href":"https://api.github.com/repos/gchq/Gaffer/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gchq/Gaffer/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/gchq/Gaffer/statuses/d6bb218379093f8c9cea3258af4d0d127b6b83ac"}}}}
{"actor":{"display_login":"p013570"}}