{"action":"closed","issue":{"url":"https://api.github.com/repos/zettajs/zetta/issues/345","repository_url":"https://api.github.com/repos/zettajs/zetta","labels_url":"https://api.github.com/repos/zettajs/zetta/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/zettajs/zetta/issues/345/comments","events_url":"https://api.github.com/repos/zettajs/zetta/issues/345/events","html_url":"https://github.com/zettajs/zetta/issues/345","id":220601672,"number":345,"title":"Test failing on windows","user":{"login":"marvinroger","id":990773,"avatar_url":"https://avatars3.githubusercontent.com/u/990773?v=3","gravatar_id":"","url":"https://api.github.com/users/marvinroger","html_url":"https://github.com/marvinroger","followers_url":"https://api.github.com/users/marvinroger/followers","following_url":"https://api.github.com/users/marvinroger/following{/other_user}","gists_url":"https://api.github.com/users/marvinroger/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinroger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinroger/subscriptions","organizations_url":"https://api.github.com/users/marvinroger/orgs","repos_url":"https://api.github.com/users/marvinroger/repos","events_url":"https://api.github.com/users/marvinroger/events{/privacy}","received_events_url":"https://api.github.com/users/marvinroger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-10T10:28:51Z","updated_at":"2017-04-12T00:57:22Z","closed_at":"2017-04-12T00:57:22Z","body":"There's another issue with URLs on Windows. When launched, the output is as follows:\r\n\r\n```json\r\n{\"class\":[\"root\"],\"links\":[{\"rel\":[\"self\"],\"href\":\"http://127.0.0.1:1337\\\\\"},{\"title\":\"Test\",\"rel\":[\"http://rels.zettajs.io/server\"],\"href\":\"http://127.0.0.1:1337/servers/Test\"},{\"rel\":[\"http://rels.zettajs.io/events\"],\"href\":\"ws://127.0.0.1:1337/events\"},{\"rel\":[\"http://rels.zettajs.io/peer-management\"],\"href\":\"http://127.0.0.1:1337/peer-management\"}],\"actions\":[{\"name\":\"query-devices\",\"method\":\"GET\",\"href\":\"http://127.0.0.1:1337\\\\\",\"type\":\"application/x-www-form-urlencoded\",\"fields\":[{\"name\":\"server\",\"type\":\"text\"},{\"name\":\"ql\",\"type\":\"text\"}]}]}\r\n```\r\n\r\nNotice the `http://127.0.0.1:1337\\\\` instead of `http://127.0.0.1:1337/`.\r\n\r\nThis causes the following test to fail:\r\n\r\n```js\r\nZetta Api updates href hosts using x-forwarded-host header:\r\n     AssertionError: 'http://google.com\\\\' == 'http://google.com/'\r\n      at C:\\Users\\Marvin\\Documents\\Code\\zetta\\test\\test_api.js:99:22\r\n      at C:\\Users\\Marvin\\Documents\\Code\\zetta\\test\\test_api.js:32:5\r\n      at Test.assert (C:\\Users\\Marvin\\Documents\\Code\\zetta\\node_modules\\supertest\\lib\\test.js:213:13)\r\n      at Server.assert (C:\\Users\\Marvin\\Documents\\Code\\zetta\\node_modules\\supertest\\lib\\test.js:132:12)\r\n      at Object.onceWrapper (events.js:293:19)\r\n      at emitNone (events.js:86:13)\r\n      at Server.emit (events.js:188:7)\r\n      at emitCloseNT (net.js:1546:8)\r\n      at _combinedTickCallback (internal/process/next_tick.js:77:11)\r\n      at process._tickDomainCallback (internal/process/next_tick.js:128:9)\r\n```\r\n\r\nI haven't been able to find the place where the URL helper is defined... But a simple `.replace(/\\\\/g, '/')` would do."}}
{"actor":{"display_login":"kevinswiber"}}