{"action":"reopened","number":1425,"pull_request":{"url":"https://api.github.com/repos/loklak/loklak_server/pulls/1425","id":134949982,"html_url":"https://github.com/loklak/loklak_server/pull/1425","diff_url":"https://github.com/loklak/loklak_server/pull/1425.diff","patch_url":"https://github.com/loklak/loklak_server/pull/1425.patch","issue_url":"https://api.github.com/repos/loklak/loklak_server/issues/1425","number":1425,"state":"open","locked":false,"title":"Refactoring try-finally block to try resource block","user":{"login":"DengYiping","id":12176046,"avatar_url":"https://avatars0.githubusercontent.com/u/12176046?v=4","gravatar_id":"","url":"https://api.github.com/users/DengYiping","html_url":"https://github.com/DengYiping","followers_url":"https://api.github.com/users/DengYiping/followers","following_url":"https://api.github.com/users/DengYiping/following{/other_user}","gists_url":"https://api.github.com/users/DengYiping/gists{/gist_id}","starred_url":"https://api.github.com/users/DengYiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DengYiping/subscriptions","organizations_url":"https://api.github.com/users/DengYiping/orgs","repos_url":"https://api.github.com/users/DengYiping/repos","events_url":"https://api.github.com/users/DengYiping/events{/privacy}","received_events_url":"https://api.github.com/users/DengYiping/received_events","type":"User","site_admin":false},"body":"### Short description\r\nI have:\r\nRefactoring try-finally block to try-with-resource block.\r\n\r\n Introduced in Java 7, try-with-resource block is the recommended way to close a Closable object, leading to more manageable and defensive code.\r\n\r\nI suggest that we should find more of these try-finally block and replace it with try-with-resource. It is pretty secure way to enhance readability and manageability of the code.\r\n\r\nSee: \r\nhttps://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html\r\nhttps://stackoverflow.com/questions/17739362/java7-try-with-resources-statement-advantage\r\n\r\n\r\n### For the reviewers\r\nI have:\r\n- [ ] Reviewed this pull request by an authorized contributor.\r\n- [ ] The reviewer is assigned to the pull request.","created_at":"2017-08-09T17:41:10Z","updated_at":"2017-08-09T18:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62402fade5eb9c71bec6b55e6753d2c5913bc210","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/loklak/loklak_server/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/loklak/loklak_server/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/loklak/loklak_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loklak/loklak_server/issues/1425/comments","statuses_url":"https://api.github.com/repos/loklak/loklak_server/statuses/5c72f0f54399aa6758073abfcb982d8b34b44483","head":{"label":"DengYiping:development","ref":"development","sha":"5c72f0f54399aa6758073abfcb982d8b34b44483","user":{"login":"DengYiping","id":12176046,"avatar_url":"https://avatars0.githubusercontent.com/u/12176046?v=4","gravatar_id":"","url":"https://api.github.com/users/DengYiping","html_url":"https://github.com/DengYiping","followers_url":"https://api.github.com/users/DengYiping/followers","following_url":"https://api.github.com/users/DengYiping/following{/other_user}","gists_url":"https://api.github.com/users/DengYiping/gists{/gist_id}","starred_url":"https://api.github.com/users/DengYiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DengYiping/subscriptions","organizations_url":"https://api.github.com/users/DengYiping/orgs","repos_url":"https://api.github.com/users/DengYiping/repos","events_url":"https://api.github.com/users/DengYiping/events{/privacy}","received_events_url":"https://api.github.com/users/DengYiping/received_events","type":"User","site_admin":false},"repo":{"id":99724160,"name":"loklak_server","full_name":"DengYiping/loklak_server","owner":{"login":"DengYiping","id":12176046,"avatar_url":"https://avatars0.githubusercontent.com/u/12176046?v=4","gravatar_id":"","url":"https://api.github.com/users/DengYiping","html_url":"https://github.com/DengYiping","followers_url":"https://api.github.com/users/DengYiping/followers","following_url":"https://api.github.com/users/DengYiping/following{/other_user}","gists_url":"https://api.github.com/users/DengYiping/gists{/gist_id}","starred_url":"https://api.github.com/users/DengYiping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DengYiping/subscriptions","organizations_url":"https://api.github.com/users/DengYiping/orgs","repos_url":"https://api.github.com/users/DengYiping/repos","events_url":"https://api.github.com/users/DengYiping/events{/privacy}","received_events_url":"https://api.github.com/users/DengYiping/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DengYiping/loklak_server","description":"Distributed message search server to anonymously collect, share, dump and index social media search results http://api.loklak.org","fork":true,"url":"https://api.github.com/repos/DengYiping/loklak_server","forks_url":"https://api.github.com/repos/DengYiping/loklak_server/forks","keys_url":"https://api.github.com/repos/DengYiping/loklak_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DengYiping/loklak_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DengYiping/loklak_server/teams","hooks_url":"https://api.github.com/repos/DengYiping/loklak_server/hooks","issue_events_url":"https://api.github.com/repos/DengYiping/loklak_server/issues/events{/number}","events_url":"https://api.github.com/repos/DengYiping/loklak_server/events","assignees_url":"https://api.github.com/repos/DengYiping/loklak_server/assignees{/user}","branches_url":"https://api.github.com/repos/DengYiping/loklak_server/branches{/branch}","tags_url":"https://api.github.com/repos/DengYiping/loklak_server/tags","blobs_url":"https://api.github.com/repos/DengYiping/loklak_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DengYiping/loklak_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DengYiping/loklak_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/DengYiping/loklak_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DengYiping/loklak_server/statuses/{sha}","languages_url":"https://api.github.com/repos/DengYiping/loklak_server/languages","stargazers_url":"https://api.github.com/repos/DengYiping/loklak_server/stargazers","contributors_url":"https://api.github.com/repos/DengYiping/loklak_server/contributors","subscribers_url":"https://api.github.com/repos/DengYiping/loklak_server/subscribers","subscription_url":"https://api.github.com/repos/DengYiping/loklak_server/subscription","commits_url":"https://api.github.com/repos/DengYiping/loklak_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/DengYiping/loklak_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/DengYiping/loklak_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/DengYiping/loklak_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/DengYiping/loklak_server/contents/{+path}","compare_url":"https://api.github.com/repos/DengYiping/loklak_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DengYiping/loklak_server/merges","archive_url":"https://api.github.com/repos/DengYiping/loklak_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DengYiping/loklak_server/downloads","issues_url":"https://api.github.com/repos/DengYiping/loklak_server/issues{/number}","pulls_url":"https://api.github.com/repos/DengYiping/loklak_server/pulls{/number}","milestones_url":"https://api.github.com/repos/DengYiping/loklak_server/milestones{/number}","notifications_url":"https://api.github.com/repos/DengYiping/loklak_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DengYiping/loklak_server/labels{/name}","releases_url":"https://api.github.com/repos/DengYiping/loklak_server/releases{/id}","deployments_url":"https://api.github.com/repos/DengYiping/loklak_server/deployments","created_at":"2017-08-08T18:29:36Z","updated_at":"2017-08-08T18:29:39Z","pushed_at":"2017-08-09T17:31:24Z","git_url":"git://github.com/DengYiping/loklak_server.git","ssh_url":"git@github.com:DengYiping/loklak_server.git","clone_url":"https://github.com/DengYiping/loklak_server.git","svn_url":"https://github.com/DengYiping/loklak_server","homepage":"","size":238305,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"loklak:development","ref":"development","sha":"ff2d1edd7bf24803be7cf1f49aaf0837cdcc893c","user":{"login":"loklak","id":11370631,"avatar_url":"https://avatars1.githubusercontent.com/u/11370631?v=4","gravatar_id":"","url":"https://api.github.com/users/loklak","html_url":"https://github.com/loklak","followers_url":"https://api.github.com/users/loklak/followers","following_url":"https://api.github.com/users/loklak/following{/other_user}","gists_url":"https://api.github.com/users/loklak/gists{/gist_id}","starred_url":"https://api.github.com/users/loklak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loklak/subscriptions","organizations_url":"https://api.github.com/users/loklak/orgs","repos_url":"https://api.github.com/users/loklak/repos","events_url":"https://api.github.com/users/loklak/events{/privacy}","received_events_url":"https://api.github.com/users/loklak/received_events","type":"Organization","site_admin":false},"repo":{"id":32751172,"name":"loklak_server","full_name":"loklak/loklak_server","owner":{"login":"loklak","id":11370631,"avatar_url":"https://avatars1.githubusercontent.com/u/11370631?v=4","gravatar_id":"","url":"https://api.github.com/users/loklak","html_url":"https://github.com/loklak","followers_url":"https://api.github.com/users/loklak/followers","following_url":"https://api.github.com/users/loklak/following{/other_user}","gists_url":"https://api.github.com/users/loklak/gists{/gist_id}","starred_url":"https://api.github.com/users/loklak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loklak/subscriptions","organizations_url":"https://api.github.com/users/loklak/orgs","repos_url":"https://api.github.com/users/loklak/repos","events_url":"https://api.github.com/users/loklak/events{/privacy}","received_events_url":"https://api.github.com/users/loklak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loklak/loklak_server","description":"Distributed message search server to anonymously collect, share, dump and index social media search results http://api.loklak.org","fork":false,"url":"https://api.github.com/repos/loklak/loklak_server","forks_url":"https://api.github.com/repos/loklak/loklak_server/forks","keys_url":"https://api.github.com/repos/loklak/loklak_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loklak/loklak_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loklak/loklak_server/teams","hooks_url":"https://api.github.com/repos/loklak/loklak_server/hooks","issue_events_url":"https://api.github.com/repos/loklak/loklak_server/issues/events{/number}","events_url":"https://api.github.com/repos/loklak/loklak_server/events","assignees_url":"https://api.github.com/repos/loklak/loklak_server/assignees{/user}","branches_url":"https://api.github.com/repos/loklak/loklak_server/branches{/branch}","tags_url":"https://api.github.com/repos/loklak/loklak_server/tags","blobs_url":"https://api.github.com/repos/loklak/loklak_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loklak/loklak_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loklak/loklak_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/loklak/loklak_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loklak/loklak_server/statuses/{sha}","languages_url":"https://api.github.com/repos/loklak/loklak_server/languages","stargazers_url":"https://api.github.com/repos/loklak/loklak_server/stargazers","contributors_url":"https://api.github.com/repos/loklak/loklak_server/contributors","subscribers_url":"https://api.github.com/repos/loklak/loklak_server/subscribers","subscription_url":"https://api.github.com/repos/loklak/loklak_server/subscription","commits_url":"https://api.github.com/repos/loklak/loklak_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/loklak/loklak_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/loklak/loklak_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/loklak/loklak_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/loklak/loklak_server/contents/{+path}","compare_url":"https://api.github.com/repos/loklak/loklak_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loklak/loklak_server/merges","archive_url":"https://api.github.com/repos/loklak/loklak_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loklak/loklak_server/downloads","issues_url":"https://api.github.com/repos/loklak/loklak_server/issues{/number}","pulls_url":"https://api.github.com/repos/loklak/loklak_server/pulls{/number}","milestones_url":"https://api.github.com/repos/loklak/loklak_server/milestones{/number}","notifications_url":"https://api.github.com/repos/loklak/loklak_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loklak/loklak_server/labels{/name}","releases_url":"https://api.github.com/repos/loklak/loklak_server/releases{/id}","deployments_url":"https://api.github.com/repos/loklak/loklak_server/deployments","created_at":"2015-03-23T18:32:59Z","updated_at":"2017-08-09T17:58:42Z","pushed_at":"2017-08-09T17:41:10Z","git_url":"git://github.com/loklak/loklak_server.git","ssh_url":"git@github.com:loklak/loklak_server.git","clone_url":"https://github.com/loklak/loklak_server.git","svn_url":"https://github.com/loklak/loklak_server","homepage":"","size":238334,"stargazers_count":165,"watchers_count":165,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":83,"forks":178,"open_issues":83,"watchers":165,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/loklak/loklak_server/pulls/1425"},"html":{"href":"https://github.com/loklak/loklak_server/pull/1425"},"issue":{"href":"https://api.github.com/repos/loklak/loklak_server/issues/1425"},"comments":{"href":"https://api.github.com/repos/loklak/loklak_server/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/loklak/loklak_server/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/loklak/loklak_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loklak/loklak_server/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/loklak/loklak_server/statuses/5c72f0f54399aa6758073abfcb982d8b34b44483"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"DengYiping"}}