{"action":"opened","number":12047,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/12047","id":102837653,"html_url":"https://github.com/facebook/react-native/pull/12047","diff_url":"https://github.com/facebook/react-native/pull/12047.diff","patch_url":"https://github.com/facebook/react-native/pull/12047.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/12047","number":12047,"state":"open","locked":false,"title":"Adds video support to react-native link","user":{"login":"mosesoak","id":24345,"avatar_url":"https://avatars.githubusercontent.com/u/24345?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesoak","html_url":"https://github.com/mosesoak","followers_url":"https://api.github.com/users/mosesoak/followers","following_url":"https://api.github.com/users/mosesoak/following{/other_user}","gists_url":"https://api.github.com/users/mosesoak/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesoak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesoak/subscriptions","organizations_url":"https://api.github.com/users/mosesoak/orgs","repos_url":"https://api.github.com/users/mosesoak/repos","events_url":"https://api.github.com/users/mosesoak/events{/privacy}","received_events_url":"https://api.github.com/users/mosesoak/received_events","type":"User","site_admin":false},"body":"The React Native packager doesn't support static videos. (Could it? that would be a better solution than this if so...) This PR adds support for videos in `react-native link` for iOS when configured in the package.json like this,\r\n\r\n```\r\n  \"rnpm\": {\r\n    \"assets\": [\r\n      \"assets/fonts\",\r\n      \"assets/videos\"\r\n    ]\r\n  },\r\n```\r\n\r\nThe files are copied into the `Resources` folder in the Xcode project for iOS, similarly to fonts but without the plist step. For Android the files are copied into `Assets/videos`.\r\n\r\n**Test plan**\r\n\r\nThe file `local-cli/link/__tests__/link.spec.js` should be updated to include a mock MP4 file. I haven't done that here as it is unclear to me how the mock files are handled (e.g. https://github.com/facebook/react-native/blob/master/local-cli/link/__tests__/link.spec.js#L183-L186).\r\n\r\nI've tested manually with fonts and videos in Xcode.\r\n\r\nI have not manually tested Android.\r\n\r\nWould love some help with testing to improve this PR!\r\n\r\nCC @Kureev @grabbou ","created_at":"2017-01-24T01:41:13Z","updated_at":"2017-01-24T01:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/12047/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/12047/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/12047/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/6b7b1dd485b72debf2748caa39bf990212455b41","head":{"label":"mosesoak:react-native-link-fixes","ref":"react-native-link-fixes","sha":"6b7b1dd485b72debf2748caa39bf990212455b41","user":{"login":"mosesoak","id":24345,"avatar_url":"https://avatars.githubusercontent.com/u/24345?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesoak","html_url":"https://github.com/mosesoak","followers_url":"https://api.github.com/users/mosesoak/followers","following_url":"https://api.github.com/users/mosesoak/following{/other_user}","gists_url":"https://api.github.com/users/mosesoak/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesoak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesoak/subscriptions","organizations_url":"https://api.github.com/users/mosesoak/orgs","repos_url":"https://api.github.com/users/mosesoak/repos","events_url":"https://api.github.com/users/mosesoak/events{/privacy}","received_events_url":"https://api.github.com/users/mosesoak/received_events","type":"User","site_admin":false},"repo":{"id":43523692,"name":"react-native","full_name":"mosesoak/react-native","owner":{"login":"mosesoak","id":24345,"avatar_url":"https://avatars.githubusercontent.com/u/24345?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesoak","html_url":"https://github.com/mosesoak","followers_url":"https://api.github.com/users/mosesoak/followers","following_url":"https://api.github.com/users/mosesoak/following{/other_user}","gists_url":"https://api.github.com/users/mosesoak/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesoak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesoak/subscriptions","organizations_url":"https://api.github.com/users/mosesoak/orgs","repos_url":"https://api.github.com/users/mosesoak/repos","events_url":"https://api.github.com/users/mosesoak/events{/privacy}","received_events_url":"https://api.github.com/users/mosesoak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mosesoak/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/mosesoak/react-native","forks_url":"https://api.github.com/repos/mosesoak/react-native/forks","keys_url":"https://api.github.com/repos/mosesoak/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosesoak/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosesoak/react-native/teams","hooks_url":"https://api.github.com/repos/mosesoak/react-native/hooks","issue_events_url":"https://api.github.com/repos/mosesoak/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/mosesoak/react-native/events","assignees_url":"https://api.github.com/repos/mosesoak/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/mosesoak/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/mosesoak/react-native/tags","blobs_url":"https://api.github.com/repos/mosesoak/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosesoak/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosesoak/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosesoak/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosesoak/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mosesoak/react-native/languages","stargazers_url":"https://api.github.com/repos/mosesoak/react-native/stargazers","contributors_url":"https://api.github.com/repos/mosesoak/react-native/contributors","subscribers_url":"https://api.github.com/repos/mosesoak/react-native/subscribers","subscription_url":"https://api.github.com/repos/mosesoak/react-native/subscription","commits_url":"https://api.github.com/repos/mosesoak/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosesoak/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosesoak/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosesoak/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosesoak/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/mosesoak/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosesoak/react-native/merges","archive_url":"https://api.github.com/repos/mosesoak/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosesoak/react-native/downloads","issues_url":"https://api.github.com/repos/mosesoak/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/mosesoak/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mosesoak/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mosesoak/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosesoak/react-native/labels{/name}","releases_url":"https://api.github.com/repos/mosesoak/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/mosesoak/react-native/deployments","created_at":"2015-10-01T22:04:41Z","updated_at":"2017-01-24T00:42:57Z","pushed_at":"2017-01-24T01:31:56Z","git_url":"git://github.com/mosesoak/react-native.git","ssh_url":"git@github.com:mosesoak/react-native.git","clone_url":"https://github.com/mosesoak/react-native.git","svn_url":"https://github.com/mosesoak/react-native","homepage":"http://facebook.github.io/react-native/","size":42084,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"17c99394444aebcd178054792fcd341016d225a6","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2017-01-24T01:22:08Z","pushed_at":"2017-01-24T01:13:32Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":110566,"stargazers_count":43186,"watchers_count":43186,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9895,"mirror_url":null,"open_issues_count":1045,"forks":9895,"open_issues":1045,"watchers":43186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/12047"},"html":{"href":"https://github.com/facebook/react-native/pull/12047"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/12047"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/12047/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/12047/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/12047/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/6b7b1dd485b72debf2748caa39bf990212455b41"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":21,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"mosesoak"}}