{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46283","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46283/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46283/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46283/events","html_url":"https://github.com/kubernetes/kubernetes/pull/46283","id":230670654,"number":46283,"title":"Adding option to set the federation api server port if nodeport is set","user":{"login":"ktsakalozos","id":11489452,"avatar_url":"https://avatars2.githubusercontent.com/u/11489452?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsakalozos","html_url":"https://github.com/ktsakalozos","followers_url":"https://api.github.com/users/ktsakalozos/followers","following_url":"https://api.github.com/users/ktsakalozos/following{/other_user}","gists_url":"https://api.github.com/users/ktsakalozos/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsakalozos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsakalozos/subscriptions","organizations_url":"https://api.github.com/users/ktsakalozos/orgs","repos_url":"https://api.github.com/users/ktsakalozos/repos","events_url":"https://api.github.com/users/ktsakalozos/events{/privacy}","received_events_url":"https://api.github.com/users/ktsakalozos/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars0.githubusercontent.com/u/10183?v=4","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"assignees":[{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars0.githubusercontent.com/u/10183?v=4","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},{"login":"perotinus","id":5122391,"avatar_url":"https://avatars1.githubusercontent.com/u/5122391?v=4","gravatar_id":"","url":"https://api.github.com/users/perotinus","html_url":"https://github.com/perotinus","followers_url":"https://api.github.com/users/perotinus/followers","following_url":"https://api.github.com/users/perotinus/following{/other_user}","gists_url":"https://api.github.com/users/perotinus/gists{/gist_id}","starred_url":"https://api.github.com/users/perotinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perotinus/subscriptions","organizations_url":"https://api.github.com/users/perotinus/orgs","repos_url":"https://api.github.com/users/perotinus/repos","events_url":"https://api.github.com/users/perotinus/events{/privacy}","received_events_url":"https://api.github.com/users/perotinus/received_events","type":"User","site_admin":false},{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2017-05-23T11:10:24Z","updated_at":"2017-07-29T15:41:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46283","html_url":"https://github.com/kubernetes/kubernetes/pull/46283","diff_url":"https://github.com/kubernetes/kubernetes/pull/46283.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/46283.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**: Kubefed will deploy the respected services and then it will do a health check. Prior to this patch if the user selects the nodeport a random port is opened. In environments where firewalls are in place this random port selection will cause the health check to fail. With this patch we enable users to designate a specific port, after for example opening it on their firewall.    \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46021\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**: \r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nKubefed init allows for setting port in Nodeport configuration\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/318839041","html_url":"https://github.com/kubernetes/kubernetes/pull/46283#issuecomment-318839041","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46283","id":318839041,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-07-29T15:41:13Z","updated_at":"2017-07-29T15:41:13Z","body":"@ktsakalozos: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce-etcd3 | 8c1e0593bbc7c3ad8a401c11d0ad596507448579 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/46283/pull-kubernetes-e2e-gce-etcd3/43800/) | `/test pull-kubernetes-e2e-gce-etcd3`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/46283). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/ktsakalozos). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}