{"action":"created","issue":{"url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/46","repository_url":"https://api.github.com/repos/jstemmer/go-junit-report","labels_url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/46/comments","events_url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/46/events","html_url":"https://github.com/jstemmer/go-junit-report/issues/46","id":202349267,"number":46,"title":"Test that has a build error, does not fail the junit-report","user":{"login":"posener","id":919294,"avatar_url":"https://avatars.githubusercontent.com/u/919294?v=3","gravatar_id":"","url":"https://api.github.com/users/posener","html_url":"https://github.com/posener","followers_url":"https://api.github.com/users/posener/followers","following_url":"https://api.github.com/users/posener/following{/other_user}","gists_url":"https://api.github.com/users/posener/gists{/gist_id}","starred_url":"https://api.github.com/users/posener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/posener/subscriptions","organizations_url":"https://api.github.com/users/posener/orgs","repos_url":"https://api.github.com/users/posener/repos","events_url":"https://api.github.com/users/posener/events{/privacy}","received_events_url":"https://api.github.com/users/posener/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-22T00:20:31Z","updated_at":"2017-02-16T21:27:34Z","closed_at":null,"body":"The output of a test that failed on build might be:\r\n```\r\npackage/name/file_test.go:9: undefined: x\r\nFAIL\tpackage/name [build failed]\r\n```\r\nrunning the go-junit-report on that test with the flag `-set-exit-code` still returns exit code 0."},"comment":{"url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/comments/280466254","html_url":"https://github.com/jstemmer/go-junit-report/issues/46#issuecomment-280466254","issue_url":"https://api.github.com/repos/jstemmer/go-junit-report/issues/46","id":280466254,"user":{"login":"posener","id":919294,"avatar_url":"https://avatars.githubusercontent.com/u/919294?v=3","gravatar_id":"","url":"https://api.github.com/users/posener","html_url":"https://github.com/posener","followers_url":"https://api.github.com/users/posener/followers","following_url":"https://api.github.com/users/posener/following{/other_user}","gists_url":"https://api.github.com/users/posener/gists{/gist_id}","starred_url":"https://api.github.com/users/posener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/posener/subscriptions","organizations_url":"https://api.github.com/users/posener/orgs","repos_url":"https://api.github.com/users/posener/repos","events_url":"https://api.github.com/users/posener/events{/privacy}","received_events_url":"https://api.github.com/users/posener/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T21:27:34Z","updated_at":"2017-02-16T21:27:34Z","body":"Hey, thanks for the feedback.\r\n\r\nAs for the command line solution:\r\n1. It will take twice the time (or maybe more) to build and test the program rather than only test it.\r\n2. It also doesn't make sense to have this whole command: a combination of 2 commands, to actually understand if your program is not failing. \r\n3. If you already have this info from the test report, why not use it?\r\n\r\nBy leaving the go-junit-report as it is, it's return code might be wrong in some of the cases, and thus his behavior is not as expected.\r\n\r\nIt might be a lot of extra code (I'm not sure, it is a lot of tests code). If you have any advice how to implement it in a more simple way, I'll be glad to rewrite it.\r\n\r\nAbout the output junit,\r\nI see that the `testsuite` can have an `errors` attribute, do you think it might suite our case?\r\n\r\nCheers"}}
{"actor":{"display_login":"posener"}}