{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/15134","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/15134/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/15134/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/15134/events","html_url":"https://github.com/elastic/kibana/pull/15134","id":276237875,"number":15134,"title":"EUI: Reset CSS","user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars2.githubusercontent.com/u/1238659?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"labels":[{"id":271062529,"url":"https://api.github.com/repos/elastic/kibana/labels/:Design","name":":Design","color":"fef2c0","default":false},{"id":654061976,"url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-23T00:13:46Z","updated_at":"2017-11-30T19:32:34Z","closed_at":"2017-11-30T19:32:34Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/15134","html_url":"https://github.com/elastic/kibana/pull/15134","diff_url":"https://github.com/elastic/kibana/pull/15134.diff","patch_url":"https://github.com/elastic/kibana/pull/15134.patch"},"body":"I've extracted the commits from https://github.com/elastic/kibana/pull/14948 which load the EUI CSS (thereby using its reset), and removing the Bootstrap, UI Framework, and custom reset CSS. Depends upon https://github.com/elastic/eui/pull/153.\r\n\r\nWe'll need to complete the partial audit below and fix the regressions we find.\r\n\r\n\r\n## Partial audit\r\n\r\nHere are a few of the visual regressions incurred by the CSS reset changes.\r\n\r\n### Notifications\r\n\r\n- [x] Notifications are missing padding around their edges, causing text to appear misaligned vertically and buttons to be flush against the top and bottom edges.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804401-cbfa42a4-c93b-11e7-8b36-4c6af488a909.png)\r\n\r\n### Timepicker\r\n\r\n- [x] Timepicker buttons don't have a pointer cursor when hovered, probably because they're `a` elements with no `href` attribute.\r\n- [x] The spacing also looks like it got tighter, causing the \"collapse\" button to get uncomfortably close to the \"Absolute\" button.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804432-e1a9aa54-c93b-11e7-8a10-b7cc548a6329.png)\r\n\r\n### Query bar\r\n\r\n- [x] The \"Add filter\" button doesn't have a pointer cursor when hovered.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804486-0c1b594a-c93c-11e7-8959-db1296079f18.png)\r\n\r\n### Discover\r\n\r\n- [x] The \"Selected fields\" label is too close to the index pattern title.\r\n- [x] The \"Available fields\" element become too short, causing the gear button on the right side to overflow.\r\n- [x] The link (\"143\" in the screenshot) is missing link styles.\r\n- [ ] The vertical spacing of the values and progress bars looks too tight.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804506-2056589c-c93c-11e7-94c6-39035352526b.png)\r\n\r\n- [ ] When expanded, the labels are too close to the Available Fields inputs.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/33156404-5149a562-cfae-11e7-938a-113aa93abc1e.png)\r\n\r\n- [ ] In \"Single document\" view, the tabs lack pointer cursors when hovered, possibly because they're `a` elements without `href` attributes.\r\n\r\n- [ ] Note: this applies to the tabs in an expanded row of the doc table, too.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804670-8aa03bd2-c93c-11e7-8522-406c431594ca.png)\r\n\r\n### Visualize\r\n\r\n- [x] The title is too close to the search bar in the Visualize Wizard.\r\n- [x] The `sr-only` accessibility class has been deleted, which means all elements previously hidden by it are now visible. We can fix this by replacing this class with `euiScreenReaderOnly` instead.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/33156468-d0200aca-cfae-11e7-9371-27fb058a5606.png)\r\n\r\n- [ ] The sidebar tabs lack pointer cursors when hovered, possibly because they're `a` elements without `href` attributes.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804775-a0ca7274-c93c-11e7-8b9d-51a667180190.png)\r\n\r\n- [ ] The spacing between \"Select bucket types\" and the menu is too tight.\r\n\r\n![image](https://user-images.githubusercontent.com/1238659/32804881-b0e37c00-c93c-11e7-81d5-c62623d06ed2.png)\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/348295793","html_url":"https://github.com/elastic/kibana/pull/15134#issuecomment-348295793","issue_url":"https://api.github.com/repos/elastic/kibana/issues/15134","id":348295793,"user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars2.githubusercontent.com/u/1238659?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T19:32:33Z","updated_at":"2017-11-30T19:32:33Z","author_association":"CONTRIBUTOR","body":"Closing in favor of a branch on the original repo: https://github.com/elastic/kibana/tree/eui/reset-css\r\n\r\nAnd this issue: https://github.com/elastic/kibana/issues/15315"}}
{"actor":{"display_login":"cjcenizal"}}