{"action":"created","issue":{"url":"https://api.github.com/repos/antlr/grammars-v4/issues/738","repository_url":"https://api.github.com/repos/antlr/grammars-v4","labels_url":"https://api.github.com/repos/antlr/grammars-v4/issues/738/labels{/name}","comments_url":"https://api.github.com/repos/antlr/grammars-v4/issues/738/comments","events_url":"https://api.github.com/repos/antlr/grammars-v4/issues/738/events","html_url":"https://github.com/antlr/grammars-v4/pull/738","id":233263928,"number":738,"title":"Adding an alternative Python3 grammar which supports Python2 detection.","user":{"login":"quaeler","id":22581048,"avatar_url":"https://avatars0.githubusercontent.com/u/22581048?v=3","gravatar_id":"","url":"https://api.github.com/users/quaeler","html_url":"https://github.com/quaeler","followers_url":"https://api.github.com/users/quaeler/followers","following_url":"https://api.github.com/users/quaeler/following{/other_user}","gists_url":"https://api.github.com/users/quaeler/gists{/gist_id}","starred_url":"https://api.github.com/users/quaeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quaeler/subscriptions","organizations_url":"https://api.github.com/users/quaeler/orgs","repos_url":"https://api.github.com/users/quaeler/repos","events_url":"https://api.github.com/users/quaeler/events{/privacy}","received_events_url":"https://api.github.com/users/quaeler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-02T18:31:12Z","updated_at":"2017-06-02T22:15:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/antlr/grammars-v4/pulls/738","html_url":"https://github.com/antlr/grammars-v4/pull/738","diff_url":"https://github.com/antlr/grammars-v4/pull/738.diff","patch_url":"https://github.com/antlr/grammars-v4/pull/738.patch"},"body":"I see that someone introduced changes to Python3.g4, of course, hours after i cloned originally for a base to my alternative parser. The previous version sufficed for my needs, so i didn't attempt to re-make changes to the new version of Python3.g4\r\n"},"comment":{"url":"https://api.github.com/repos/antlr/grammars-v4/issues/comments/305921503","html_url":"https://github.com/antlr/grammars-v4/pull/738#issuecomment-305921503","issue_url":"https://api.github.com/repos/antlr/grammars-v4/issues/738","id":305921503,"user":{"login":"quaeler","id":22581048,"avatar_url":"https://avatars0.githubusercontent.com/u/22581048?v=3","gravatar_id":"","url":"https://api.github.com/users/quaeler","html_url":"https://github.com/quaeler","followers_url":"https://api.github.com/users/quaeler/followers","following_url":"https://api.github.com/users/quaeler/following{/other_user}","gists_url":"https://api.github.com/users/quaeler/gists{/gist_id}","starred_url":"https://api.github.com/users/quaeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quaeler/subscriptions","organizations_url":"https://api.github.com/users/quaeler/orgs","repos_url":"https://api.github.com/users/quaeler/repos","events_url":"https://api.github.com/users/quaeler/events{/privacy}","received_events_url":"https://api.github.com/users/quaeler/received_events","type":"User","site_admin":false},"created_at":"2017-06-02T22:15:10Z","updated_at":"2017-06-02T22:15:10Z","body":"Absolutely - sorry for previous and this curtness - on a phone presently.\n\nOn Jun 2, 2017 1:52 PM, \"Tom Everett\" <notifications@github.com> wrote:\n\n> Could you please move the commit from under /python3 to a new folder\n> /python3alt, with a pom.xml and with examples?\n>\n>\n> On Fri, Jun 2, 2017 at 2:05 PM, loki der quaeler <notifications@github.com\n> >\n> wrote:\n>\n> > Oh I see the problem - it's my code. Will fix.\n> >\n> > On Jun 2, 2017 12:41 PM, \"Tom Everett\" <notifications@github.com> wrote:\n> >\n> > > Here is the compile issue. I'm not sure what's causing it, yet.\n> > >\n> > > INFO] --- maven-compiler-plugin:3.0:compile (default-compile) @\n> python3\n> > ---\n> > > [INFO] Changes detected - recompiling the module!\n> > > [INFO] Compiling 12 source files to /home/travis/build/antlr/\n> > grammars-v4/python3/target/classes\n> > > [INFO] -------------------------------------------------------------\n> > > [ERROR] COMPILATION ERROR :\n> > > [INFO] -------------------------------------------------------------\n> > > [ERROR] /home/travis/build/antlr/grammars-v4/python3/target/\n> > generated-sources/antlr4/AltPython3Parser.java:[6102,85] cannot find\n> > symbol\n> > > symbol: variable ALREADY_THROWN_TOKEN_TYPE\n> > > location: class Python3Parser\n> > > [ERROR] /home/travis/build/antlr/grammars-v4/python3/target/\n> > generated-sources/antlr4/AltPython3Parser.java:[6110,84] cannot find\n> > symbol\n> > > symbol: variable ALREADY_THROWN_TOKEN_TYPE\n> > > location: class Python3Parser\n> > > [INFO] 2 errors\n> > >\n> > >\n> > > IN terms of the commit, the maven test build uses a single grammar\n> file,\n> > > defined in the pom.xml. Currently its:\n> > >\n> > > Python3.g4\n> > >\n> > > One way to approach the problem of more than one python3 grammar would\n> be\n> > > for you to re-issue the pull request under a new directory (python3alt)\n> > > which is a peer of python3 and python3. I would ask that you update the\n> > > pom.xml, and copy the examples into your new directory.\n> > >\n> > > —\n> > > You are receiving this because you authored the thread.\n> > > Reply to this email directly, view it on GitHub\n> > > <https://github.com/antlr/grammars-v4/pull/738#issuecomment-305890758\n> >,\n> > > or mute the thread\n> > > <https://github.com/notifications/unsubscribe-auth/\n> > AViPOIDDyvy1BIM9AlVyaw9SNr5quqHPks5sAGVNgaJpZM4NuoWH>\n> > > .\n> > >\n> >\n> > —\n> > You are receiving this because you commented.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/antlr/grammars-v4/pull/738#issuecomment-305896238>,\n> > or mute the thread\n> > <https://github.com/notifications/unsubscribe-auth/\n> ABK1Zu04OKOBBLVgvK1Kvdf8DQKv4l8iks5sAGsXgaJpZM4NuoWH>\n> > .\n> >\n>\n>\n>\n> --\n> A better world shall emerge based on faith and understanding - Douglas\n> MacArthur\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/antlr/grammars-v4/pull/738#issuecomment-305904835>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AViPOMLr_gAKydZsRHht7M8CkJ3myhSqks5sAHR-gaJpZM4NuoWH>\n> .\n>\n"}}
{"actor":{"display_login":"quaeler"}}