{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/8","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/8/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/8/events","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/issues/8","id":231153116,"number":8,"title":"Provide ACK control","user":{"login":"viniciusccarvalho","id":803893,"avatar_url":"https://avatars0.githubusercontent.com/u/803893?v=3","gravatar_id":"","url":"https://api.github.com/users/viniciusccarvalho","html_url":"https://github.com/viniciusccarvalho","followers_url":"https://api.github.com/users/viniciusccarvalho/followers","following_url":"https://api.github.com/users/viniciusccarvalho/following{/other_user}","gists_url":"https://api.github.com/users/viniciusccarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/viniciusccarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viniciusccarvalho/subscriptions","organizations_url":"https://api.github.com/users/viniciusccarvalho/orgs","repos_url":"https://api.github.com/users/viniciusccarvalho/repos","events_url":"https://api.github.com/users/viniciusccarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/viniciusccarvalho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars3.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars3.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones/1","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/milestone/1","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones/1/labels","id":2562261,"number":1,"title":"si-channel-adapters-alpha","description":"List of blocking issues for alpha release of the Spring Integration channel adapters alpha version.","creator":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars3.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2017-06-05T14:35:30Z","updated_at":"2017-06-06T19:50:06Z","due_on":"2017-06-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2017-05-24T19:55:13Z","updated_at":"2017-06-06T21:35:13Z","closed_at":null,"body":"Spring Messaging in general has the notion of a MessageListenerContainer, which allows configuration of different settings such as ACK mode, concurrent listeners.\r\n\r\nWe need to add same behavior here not only to be consistent with the Spring ecosystem, but to allow our users to control those parameters.\r\n\r\nAs usual, let's use the spring-kafka project (https://github.com/spring-projects/spring-kafka/tree/master/spring-kafka/src/main/java/org/springframework/kafka/listener) as source of inspiration, since it's a new take on a well stablished concept"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments/306624370","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/issues/8#issuecomment-306624370","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/8","id":306624370,"user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars3.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"created_at":"2017-06-06T21:35:13Z","updated_at":"2017-06-06T21:35:13Z","body":"@artembilan I looked into that Kinesis example, but couldn't find anywhere where (n)acking is done.\r\n\r\nDid you mean we can do something similar to how the checkpointing is done there?\r\n\r\nIn any case, sounds like a start would be to add a new header to specify auto/manual acking and then `PubSubInboundChannelAdapter` could either ack messages after `sendMessage()` or else send the `AckReplyConsumer` back to the user, although we would probably want to replace that with something Spring and not part of the Google Cloud Pub/Sub API."}}
{"actor":{"display_login":"joaoandremartins"}}