{"push_id":1515301746,"size":8,"distinct_size":1,"ref":"refs/heads/remove-sinatra-exception","head":"e74ccd7be1de1654cd3f953bc28edbb88567ac92","before":"e42e3d892327468102dd285d28edfc5a736223bb","commits":[{"sha":"a24c8cc869b014fdf28bbc5e26691afde77aca3d","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Update README to add an explanation of the project","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/a24c8cc869b014fdf28bbc5e26691afde77aca3d"},{"sha":"faec9d71fdd43b9818c377d5196885780bb02751","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Use hard line-wrapping throughout the README","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/faec9d71fdd43b9818c377d5196885780bb02751"},{"sha":"64123d83610c3dfe23178e857fe6894053bc5758","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Add a comment in the Gemfile to update README with ruby version","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/64123d83610c3dfe23178e857fe6894053bc5758"},{"sha":"a57ea8a7b9a9c64bd6185b9fc0ac6fc060ae8029","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Change the layout since the homepage markup is different\n\nSince the homepage layout is different to the rest of pages,\n(some of the partials are not included in the home page), the\nlayout test was changed to request a normal page instead, so\nthat the tests still pass, and the homepage will have its own\nweb tests.","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/a57ea8a7b9a9c64bd6185b9fc0ac6fc060ae8029"},{"sha":"2d00fbf1ef2768ddab0e38ccc6c4a06345a7a884","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Add a presenter page for the homepage\n\nFor now the homepage doesn't contain logic for the featured persons,\nsince the logic for that is not ready yet. In the meanwhile, the featured\npersons will be hardcoded in the homepage view.\n\nAlso, since we still don't have an event_date method in documents\nnor an evendate field defined in prose.io config file, the featured_events\nand the featured_posts work in the same way.","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/2d00fbf1ef2768ddab0e38ccc6c4a06345a7a884"},{"sha":"63c22e81c2e51900e429ed9001841a465f00c471","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Fix the title in the head partial\n\nThe meta title of a page (the one that goes inside the head tag) is\ndifferent for the homepage and the rest of pages. The Jekyll code\nthat was initially taken from the Jekyll site was updated to\nreproduce the behaviour of the homepage meta title.\n\nIn order for this fix to work, all normal pages need to have a title.\n\nThe only page without a title was the /places/ route. This route was\ndeleted since it was a placeholder. The correct route is /places\nand it is already covered by the info pages.","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/63c22e81c2e51900e429ed9001841a465f00c471"},{"sha":"63162f456b9739450a6d86b5ed651e37623790f6","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Update the homepage with the code from the Jekyll site\n\nThe homepage is mostly harcoded for now, in particular the featured\npersons. The homepage view code was taken from:\n\n*  shineyoureye/index.html\n\n    https://github.com/theyworkforyou/shineyoureye/blob/\n    8441907b3d179f5cabb828ecebd1b904cb98ad89/index.html\n\nThere are no tests for the home page view because the homepage\nas it is in the Jekyll version of the site is the whole HTML document,\ni.e. it is not generated using the layout. So some parts in the home\npage layout are different to the rest of the pages' layout (probably\nchanges were made in the generic layout that all pages use and\nthe home page got out of sync).\n\nI identified the common parts and loaded the different ones using\nthe homepage checker that was added to the layout helper. Since\nthe only differences seem to be styles and markup, I think these\ntwo different branches of the if statement can be eliminated by\nthe designers, unifying styles and markup for both versions.\n\nThe parts where there is a conditional check are:\n\n* the part where the styles are imported in the head tag (_head partial)\n\n* the styles in the footer (_footer partial)\n\n* a section in the body (layout view)\n\nIn my opinion the section in the body can stay, but the sections in\nthe head and footer could easily be simplified by the designers to\nunify the markup and the css. That would allow the conditional to\ngo away.","distinct":false,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/63162f456b9739450a6d86b5ed651e37623790f6"},{"sha":"e74ccd7be1de1654cd3f953bc28edbb88567ac92","author":{"name":"octopusinvitro","email":"c40f6590ce811566214f19ea8f7ff7746bc4473c@users.noreply.github.com"},"message":"Remove the reference to a Sinatra exception in the finder class\n\nThe lib folder should be plug and play, so no files inside that folder\nshould be referencing anything from Sinatra. A normal exception is\nraised for the case in which no files are found.","distinct":true,"url":"https://api.github.com/repos/theyworkforyou/shineyoureye-sinatra/commits/e74ccd7be1de1654cd3f953bc28edbb88567ac92"}]}
{"actor":{"display_login":"octopusinvitro"}}