{"action":"created","issue":{"url":"https://api.github.com/repos/docker/swarmkit/issues/2375","repository_url":"https://api.github.com/repos/docker/swarmkit","labels_url":"https://api.github.com/repos/docker/swarmkit/issues/2375/labels{/name}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/2375/comments","events_url":"https://api.github.com/repos/docker/swarmkit/issues/2375/events","html_url":"https://github.com/docker/swarmkit/pull/2375","id":257957295,"number":2375,"title":"Set grpc max message size to 128MB.","user":{"login":"anshulpundir","id":13551457,"avatar_url":"https://avatars3.githubusercontent.com/u/13551457?v=4","gravatar_id":"","url":"https://api.github.com/users/anshulpundir","html_url":"https://github.com/anshulpundir","followers_url":"https://api.github.com/users/anshulpundir/followers","following_url":"https://api.github.com/users/anshulpundir/following{/other_user}","gists_url":"https://api.github.com/users/anshulpundir/gists{/gist_id}","starred_url":"https://api.github.com/users/anshulpundir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshulpundir/subscriptions","organizations_url":"https://api.github.com/users/anshulpundir/orgs","repos_url":"https://api.github.com/users/anshulpundir/repos","events_url":"https://api.github.com/users/anshulpundir/events{/privacy}","received_events_url":"https://api.github.com/users/anshulpundir/received_events","type":"User","site_admin":false},"labels":[{"id":356598885,"url":"https://api.github.com/repos/docker/swarmkit/labels/area/raft","name":"area/raft","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-09-15T07:59:20Z","updated_at":"2017-09-18T21:02:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/2375","html_url":"https://github.com/docker/swarmkit/pull/2375","diff_url":"https://github.com/docker/swarmkit/pull/2375.diff","patch_url":"https://github.com/docker/swarmkit/pull/2375.patch"},"body":"Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/swarmkit/issues/comments/330355271","html_url":"https://github.com/docker/swarmkit/pull/2375#issuecomment-330355271","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/2375","id":330355271,"user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"created_at":"2017-09-18T21:02:06Z","updated_at":"2017-09-18T21:02:06Z","author_association":"CONTRIBUTOR","body":"> Logging the length of every single message before sending it might have some unforeseen performance implications.\r\n\r\nNo really what I was suggesting:\r\n\r\n```go\r\nif len(msg) > 1 << 20 {\r\n // log it.\r\n}\r\n```\r\n\r\nBetter would be to have bucketed counters (unrolled below):\r\n\r\n```go\r\nif len(msg) >= 1 << 20 {\r\n  gt1MB++\r\n}\r\n\r\nif len(msg) >= 4 << 20 {\r\n  gt4MB++\r\n}\r\n\r\nif len(msg) >= 10 << 20 {\r\n  gt10MB++\r\n}\r\n\r\nif len(msg) >= 16 << 20 {\r\n  gt16MB++\r\n}\r\n...\r\n```\r\n\r\nNotice that this is a cumulative counter setup, rather than bucketed, which allows easy aggregates.\r\n\r\n> probably go in a separate PR.\r\n\r\nSure, but let's make sure it gets backported: right now, this condition is hard to diagnose and debug."}}
{"actor":{"display_login":"stevvooe"}}