{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/111806186","pull_request_review_id":33073719,"id":111806186,"diff_hunk":"@@ -1543,6 +1543,11 @@ def revoke_auth(self, load):\n         :return: True if key was revoked, False if not\n         '''\n         load = self.__verify_load(load, ('id', 'tok'))\n+\n+        if not self.opts.get('allow_minion_key_revoke', False):\n+            log.debug('Minion {0} requested key revoke, but allow_minion_key_revoke is False'.format(load['id']))","path":"salt/master.py","position":6,"original_position":6,"commit_id":"65ea8997b79834776e64ba249b55a72171a6a9c4","original_commit_id":"65ea8997b79834776e64ba249b55a72171a6a9c4","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars0.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"I don't think that debug is the correct log level for this. Probably `warning`.","created_at":"2017-04-17T19:47:32Z","updated_at":"2017-04-17T19:47:40Z","html_url":"https://github.com/saltstack/salt/pull/40724#discussion_r111806186","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/40724","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/111806186"},"html":{"href":"https://github.com/saltstack/salt/pull/40724#discussion_r111806186"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40724"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/40724","id":116185779,"html_url":"https://github.com/saltstack/salt/pull/40724","diff_url":"https://github.com/saltstack/salt/pull/40724.diff","patch_url":"https://github.com/saltstack/salt/pull/40724.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/40724","number":40724,"state":"open","locked":false,"title":"Minion key revoke cfg","user":{"login":"cro","id":83323,"avatar_url":"https://avatars0.githubusercontent.com/u/83323?v=3","gravatar_id":"","url":"https://api.github.com/users/cro","html_url":"https://github.com/cro","followers_url":"https://api.github.com/users/cro/followers","following_url":"https://api.github.com/users/cro/following{/other_user}","gists_url":"https://api.github.com/users/cro/gists{/gist_id}","starred_url":"https://api.github.com/users/cro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cro/subscriptions","organizations_url":"https://api.github.com/users/cro/orgs","repos_url":"https://api.github.com/users/cro/repos","events_url":"https://api.github.com/users/cro/events{/privacy}","received_events_url":"https://api.github.com/users/cro/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAdds a new configuration option `allow_minion__key_revoke` that controls whether\r\na minion's request to the master to revoke its own key will be honored.\r\n","created_at":"2017-04-17T19:23:01Z","updated_at":"2017-04-17T19:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4806e3d5208dedb9f83e76ca1d621aa1482409d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/40724/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/40724/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/40724/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/65ea8997b79834776e64ba249b55a72171a6a9c4","head":{"label":"cro:minion_key_revoke_cfg","ref":"minion_key_revoke_cfg","sha":"65ea8997b79834776e64ba249b55a72171a6a9c4","user":{"login":"cro","id":83323,"avatar_url":"https://avatars0.githubusercontent.com/u/83323?v=3","gravatar_id":"","url":"https://api.github.com/users/cro","html_url":"https://github.com/cro","followers_url":"https://api.github.com/users/cro/followers","following_url":"https://api.github.com/users/cro/following{/other_user}","gists_url":"https://api.github.com/users/cro/gists{/gist_id}","starred_url":"https://api.github.com/users/cro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cro/subscriptions","organizations_url":"https://api.github.com/users/cro/orgs","repos_url":"https://api.github.com/users/cro/repos","events_url":"https://api.github.com/users/cro/events{/privacy}","received_events_url":"https://api.github.com/users/cro/received_events","type":"User","site_admin":false},"repo":{"id":13874293,"name":"salt","full_name":"cro/salt","owner":{"login":"cro","id":83323,"avatar_url":"https://avatars0.githubusercontent.com/u/83323?v=3","gravatar_id":"","url":"https://api.github.com/users/cro","html_url":"https://github.com/cro","followers_url":"https://api.github.com/users/cro/followers","following_url":"https://api.github.com/users/cro/following{/other_user}","gists_url":"https://api.github.com/users/cro/gists{/gist_id}","starred_url":"https://api.github.com/users/cro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cro/subscriptions","organizations_url":"https://api.github.com/users/cro/orgs","repos_url":"https://api.github.com/users/cro/repos","events_url":"https://api.github.com/users/cro/events{/privacy}","received_events_url":"https://api.github.com/users/cro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cro/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/cro/salt","forks_url":"https://api.github.com/repos/cro/salt/forks","keys_url":"https://api.github.com/repos/cro/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cro/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cro/salt/teams","hooks_url":"https://api.github.com/repos/cro/salt/hooks","issue_events_url":"https://api.github.com/repos/cro/salt/issues/events{/number}","events_url":"https://api.github.com/repos/cro/salt/events","assignees_url":"https://api.github.com/repos/cro/salt/assignees{/user}","branches_url":"https://api.github.com/repos/cro/salt/branches{/branch}","tags_url":"https://api.github.com/repos/cro/salt/tags","blobs_url":"https://api.github.com/repos/cro/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cro/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cro/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cro/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cro/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/cro/salt/languages","stargazers_url":"https://api.github.com/repos/cro/salt/stargazers","contributors_url":"https://api.github.com/repos/cro/salt/contributors","subscribers_url":"https://api.github.com/repos/cro/salt/subscribers","subscription_url":"https://api.github.com/repos/cro/salt/subscription","commits_url":"https://api.github.com/repos/cro/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cro/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cro/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cro/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cro/salt/contents/{+path}","compare_url":"https://api.github.com/repos/cro/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cro/salt/merges","archive_url":"https://api.github.com/repos/cro/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cro/salt/downloads","issues_url":"https://api.github.com/repos/cro/salt/issues{/number}","pulls_url":"https://api.github.com/repos/cro/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/cro/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/cro/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cro/salt/labels{/name}","releases_url":"https://api.github.com/repos/cro/salt/releases{/id}","deployments_url":"https://api.github.com/repos/cro/salt/deployments","created_at":"2013-10-25T23:16:49Z","updated_at":"2015-04-06T20:26:45Z","pushed_at":"2017-04-17T19:21:12Z","git_url":"git://github.com/cro/salt.git","ssh_url":"git@github.com:cro/salt.git","clone_url":"https://github.com/cro/salt.git","svn_url":"https://github.com/cro/salt","homepage":"saltstack.org","size":153839,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2016.3","ref":"2016.3","sha":"4145d33e46eb2284879bce4d28c2433c90f891dd","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-04-17T17:26:29Z","pushed_at":"2017-04-17T19:35:26Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":163971,"stargazers_count":7592,"watchers_count":7592,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3516,"mirror_url":null,"open_issues_count":4431,"forks":3516,"open_issues":4431,"watchers":7592,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40724"},"html":{"href":"https://github.com/saltstack/salt/pull/40724"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/40724"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/40724/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40724/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40724/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/65ea8997b79834776e64ba249b55a72171a6a9c4"}}}}
{"actor":{"display_login":"cachedout"}}