{"action":"created","comment":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/126842716","pull_request_review_id":49366709,"id":126842716,"diff_hunk":"@@ -16,6 +16,23 @@ export function getTypeData(key, val='', tip = '', labelV='', labelW) {\n     };\n }\n \n+/**\n+ * Returns only numerical column names form raw lc table\n+ * @param {Object} rawTbl\n+ * @returns {TableColumn[]} - array of table columns objects\n+ */\n+export function getOnlyNumericalCol(rawTbl) {\n+\n+    var colType = ['double', 'd', 'long', 'l', 'int', 'i', 'float', 'f'];\n+    return get(rawTbl, ['tableData', 'columns']).reduce((prev, col) => {\n+        if ((colType.includes(col.type)) &&\n+            (!has(col, 'visibility') || get(col, 'visibility') !== 'hidden')) {\n+            prev.push(col.name);\n+        }\n+        return prev;","path":"src/firefly/js/templates/lightcurve/LcUtil.jsx","position":25,"original_position":25,"commit_id":"908aef55259689254414d298378ebf0dbf694221","original_commit_id":"908aef55259689254414d298378ebf0dbf694221","user":{"login":"loitly","id":11449642,"avatar_url":"https://avatars1.githubusercontent.com/u/11449642?v=3","gravatar_id":"","url":"https://api.github.com/users/loitly","html_url":"https://github.com/loitly","followers_url":"https://api.github.com/users/loitly/followers","following_url":"https://api.github.com/users/loitly/following{/other_user}","gists_url":"https://api.github.com/users/loitly/gists{/gist_id}","starred_url":"https://api.github.com/users/loitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loitly/subscriptions","organizations_url":"https://api.github.com/users/loitly/orgs","repos_url":"https://api.github.com/users/loitly/repos","events_url":"https://api.github.com/users/loitly/events{/privacy}","received_events_url":"https://api.github.com/users/loitly/received_events","type":"User","site_admin":false},"body":"These sort of functions should be in TableUtil.js.  It would also be easier to read if written as:\r\n```\r\n        return get(rawTbl, ['tableData', 'columns'])\r\n                .filter((col) => colType.includes(col.type) && get(col, 'visibility') !== 'hidden')\r\n                .map((col) => col.name);\r\n\r\n\r\n```","created_at":"2017-07-12T00:52:56Z","updated_at":"2017-07-12T01:02:25Z","html_url":"https://github.com/Caltech-IPAC/firefly/pull/409#discussion_r126842716","pull_request_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/126842716"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/409#discussion_r126842716"},"pull_request":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409","id":130016008,"html_url":"https://github.com/Caltech-IPAC/firefly/pull/409","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/409.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/409.patch","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/409","number":409,"state":"open","locked":false,"title":"IRSA-540, IRSA-541:Add PTF case to Time Series Tool","user":{"login":"lznakano","id":11981693,"avatar_url":"https://avatars2.githubusercontent.com/u/11981693?v=3","gravatar_id":"","url":"https://api.github.com/users/lznakano","html_url":"https://github.com/lznakano","followers_url":"https://api.github.com/users/lznakano/followers","following_url":"https://api.github.com/users/lznakano/following{/other_user}","gists_url":"https://api.github.com/users/lznakano/gists{/gist_id}","starred_url":"https://api.github.com/users/lznakano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lznakano/subscriptions","organizations_url":"https://api.github.com/users/lznakano/orgs","repos_url":"https://api.github.com/users/lznakano/repos","events_url":"https://api.github.com/users/lznakano/events{/privacy}","received_events_url":"https://api.github.com/users/lznakano/received_events","type":"User","site_admin":false},"body":"  Two tickets were implemented together.  A new PTF form is created and added. Corresponding actions in the form were implemented. ","created_at":"2017-07-11T22:04:21Z","updated_at":"2017-07-12T01:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85df9c37cfdbf4c81f08253cf1cf19672a99cc1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ejoliet","id":770124,"avatar_url":"https://avatars3.githubusercontent.com/u/770124?v=3","gravatar_id":"","url":"https://api.github.com/users/ejoliet","html_url":"https://github.com/ejoliet","followers_url":"https://api.github.com/users/ejoliet/followers","following_url":"https://api.github.com/users/ejoliet/following{/other_user}","gists_url":"https://api.github.com/users/ejoliet/gists{/gist_id}","starred_url":"https://api.github.com/users/ejoliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejoliet/subscriptions","organizations_url":"https://api.github.com/users/ejoliet/orgs","repos_url":"https://api.github.com/users/ejoliet/repos","events_url":"https://api.github.com/users/ejoliet/events{/privacy}","received_events_url":"https://api.github.com/users/ejoliet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409/commits","review_comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409/comments","review_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/409/comments","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/908aef55259689254414d298378ebf0dbf694221","head":{"label":"Caltech-IPAC:IRSA-540-IRSA-541-PTF","ref":"IRSA-540-IRSA-541-PTF","sha":"908aef55259689254414d298378ebf0dbf694221","user":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars1.githubusercontent.com/u/9708378?v=3","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars1.githubusercontent.com/u/9708378?v=3","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2017-07-10T21:26:50Z","pushed_at":"2017-07-11T23:49:12Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":156252,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":7,"default_branch":"dev"}},"base":{"label":"Caltech-IPAC:dev","ref":"dev","sha":"45b1a9a7007edacd1d8c87c3e3832cb22bf788bc","user":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars1.githubusercontent.com/u/9708378?v=3","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars1.githubusercontent.com/u/9708378?v=3","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2017-07-10T21:26:50Z","pushed_at":"2017-07-11T23:49:12Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":156252,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/409"},"issue":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/409"},"comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/908aef55259689254414d298378ebf0dbf694221"}}}}
{"actor":{"display_login":"loitly"}}