{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments/111687321","pull_request_review_id":32947259,"id":111687321,"diff_hunk":"@@ -61,7 +63,12 @@\n             max = DoubleSummaryStatistics.class.getDeclaredField(\"max\");\n             max.setAccessible(true);\n         }\n-        catch (SecurityException | NoSuchFieldException ignored)\n+        catch (RuntimeException e)","path":"eclipse-collections/src/main/java/org/eclipse/collections/impl/collector/SerializableDoubleSummaryStatistics.java","position":15,"original_position":15,"commit_id":"9cd46174c8c952dce351e72f71a729d8d53abe09","original_commit_id":"9cd46174c8c952dce351e72f71a729d8d53abe09","user":{"login":"motlin","id":244258,"avatar_url":"https://avatars0.githubusercontent.com/u/244258?v=3","gravatar_id":"","url":"https://api.github.com/users/motlin","html_url":"https://github.com/motlin","followers_url":"https://api.github.com/users/motlin/followers","following_url":"https://api.github.com/users/motlin/following{/other_user}","gists_url":"https://api.github.com/users/motlin/gists{/gist_id}","starred_url":"https://api.github.com/users/motlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motlin/subscriptions","organizations_url":"https://api.github.com/users/motlin/orgs","repos_url":"https://api.github.com/users/motlin/repos","events_url":"https://api.github.com/users/motlin/events{/privacy}","received_events_url":"https://api.github.com/users/motlin/received_events","type":"User","site_admin":false},"body":"I believe catching RuntimeException is actually a regression. We should have a test that fails due to this code, perhaps using a SecurityManager. We can delete this block entirely and just catch Exception. It's one of those rare situations where catching Exception feels right, because it executes in a static block.","created_at":"2017-04-16T16:40:58Z","updated_at":"2017-04-16T16:45:08Z","html_url":"https://github.com/eclipse/eclipse-collections/pull/253#discussion_r111687321","pull_request_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments/111687321"},"html":{"href":"https://github.com/eclipse/eclipse-collections/pull/253#discussion_r111687321"},"pull_request":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253","id":113821376,"html_url":"https://github.com/eclipse/eclipse-collections/pull/253","diff_url":"https://github.com/eclipse/eclipse-collections/pull/253.diff","patch_url":"https://github.com/eclipse/eclipse-collections/pull/253.patch","issue_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/253","number":253,"state":"open","locked":false,"title":"Implement fixes such that library is compatible with Java 8 and Java 9-EA-163.","user":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars3.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-02T14:59:36Z","updated_at":"2017-04-16T16:45:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8971f5e7d871d4d5d70635c2e967f45b8711d6c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253/commits","review_comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253/comments","review_comment_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/253/comments","statuses_url":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/9cd46174c8c952dce351e72f71a729d8d53abe09","head":{"label":"nikhilnanivadekar:FixesForJava9","ref":"FixesForJava9","sha":"9cd46174c8c952dce351e72f71a729d8d53abe09","user":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars3.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"repo":{"id":50205219,"name":"eclipse-collections","full_name":"nikhilnanivadekar/eclipse-collections","owner":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars3.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhilnanivadekar/eclipse-collections","description":"The Eclipse Collections Project","fork":true,"url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections","forks_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/forks","keys_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/teams","hooks_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/hooks","issue_events_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/issues/events{/number}","events_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/events","assignees_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/assignees{/user}","branches_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/branches{/branch}","tags_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/tags","blobs_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/languages","stargazers_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/stargazers","contributors_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/contributors","subscribers_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/subscribers","subscription_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/subscription","commits_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/contents/{+path}","compare_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/merges","archive_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/downloads","issues_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/issues{/number}","pulls_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/labels{/name}","releases_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/releases{/id}","deployments_url":"https://api.github.com/repos/nikhilnanivadekar/eclipse-collections/deployments","created_at":"2016-01-22T20:16:50Z","updated_at":"2016-11-18T23:43:55Z","pushed_at":"2017-04-12T05:09:09Z","git_url":"git://github.com/nikhilnanivadekar/eclipse-collections.git","ssh_url":"git@github.com:nikhilnanivadekar/eclipse-collections.git","clone_url":"https://github.com/nikhilnanivadekar/eclipse-collections.git","svn_url":"https://github.com/nikhilnanivadekar/eclipse-collections","homepage":"http://www.eclipse.org/collections","size":7582,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"e2228ee7ff06ebff9ec1ca54f07433c162e78e0a","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":46803767,"name":"eclipse-collections","full_name":"eclipse/eclipse-collections","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/eclipse-collections","description":"The Eclipse Collections Project","fork":false,"url":"https://api.github.com/repos/eclipse/eclipse-collections","forks_url":"https://api.github.com/repos/eclipse/eclipse-collections/forks","keys_url":"https://api.github.com/repos/eclipse/eclipse-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/eclipse-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/eclipse-collections/teams","hooks_url":"https://api.github.com/repos/eclipse/eclipse-collections/hooks","issue_events_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/eclipse-collections/events","assignees_url":"https://api.github.com/repos/eclipse/eclipse-collections/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/eclipse-collections/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/eclipse-collections/tags","blobs_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/eclipse-collections/languages","stargazers_url":"https://api.github.com/repos/eclipse/eclipse-collections/stargazers","contributors_url":"https://api.github.com/repos/eclipse/eclipse-collections/contributors","subscribers_url":"https://api.github.com/repos/eclipse/eclipse-collections/subscribers","subscription_url":"https://api.github.com/repos/eclipse/eclipse-collections/subscription","commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/eclipse-collections/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/eclipse-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/eclipse-collections/merges","archive_url":"https://api.github.com/repos/eclipse/eclipse-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/eclipse-collections/downloads","issues_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/eclipse-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/eclipse-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/eclipse-collections/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/eclipse-collections/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/eclipse-collections/deployments","created_at":"2015-11-24T16:22:48Z","updated_at":"2017-04-16T13:21:03Z","pushed_at":"2017-04-14T14:05:50Z","git_url":"git://github.com/eclipse/eclipse-collections.git","ssh_url":"git@github.com:eclipse/eclipse-collections.git","clone_url":"https://github.com/eclipse/eclipse-collections.git","svn_url":"https://github.com/eclipse/eclipse-collections","homepage":"http://www.eclipse.org/collections","size":7582,"stargazers_count":283,"watchers_count":283,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":32,"forks":70,"open_issues":32,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253"},"html":{"href":"https://github.com/eclipse/eclipse-collections/pull/253"},"issue":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/issues/253"},"comments":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/9cd46174c8c952dce351e72f71a729d8d53abe09"}}}}
{"actor":{"display_login":"motlin"}}