{"action":"opened","issue":{"url":"https://api.github.com/repos/Thwaitesy/MSTestHacks/issues/25","repository_url":"https://api.github.com/repos/Thwaitesy/MSTestHacks","labels_url":"https://api.github.com/repos/Thwaitesy/MSTestHacks/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/Thwaitesy/MSTestHacks/issues/25/comments","events_url":"https://api.github.com/repos/Thwaitesy/MSTestHacks/issues/25/events","html_url":"https://github.com/Thwaitesy/MSTestHacks/issues/25","id":238938927,"number":25,"title":"No strong name","user":{"login":"hilari0n","id":26122570,"avatar_url":"https://avatars1.githubusercontent.com/u/26122570?v=3","gravatar_id":"","url":"https://api.github.com/users/hilari0n","html_url":"https://github.com/hilari0n","followers_url":"https://api.github.com/users/hilari0n/followers","following_url":"https://api.github.com/users/hilari0n/following{/other_user}","gists_url":"https://api.github.com/users/hilari0n/gists{/gist_id}","starred_url":"https://api.github.com/users/hilari0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hilari0n/subscriptions","organizations_url":"https://api.github.com/users/hilari0n/orgs","repos_url":"https://api.github.com/users/hilari0n/repos","events_url":"https://api.github.com/users/hilari0n/events{/privacy}","received_events_url":"https://api.github.com/users/hilari0n/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-27T18:19:38Z","updated_at":"2017-06-27T18:19:38Z","closed_at":null,"body":"The MSTestHacks library is not strongly-named. This may not be relevant in most cases (as MSTestHacks is used almost solely in testing code, not in \"production\" code), but in some is a pain.\r\nThe problem is only when you need your testing assembly to be strongly named. In that case you can't use MSTestHacks as it's not strongly named.\r\nWhy would I need my testing assembly to be strongly named? In a rare case, when I need to give it access to internal classes of a strongly named assembly (e.g. one under tests).\r\nWhy wouldn't I add the strong name signature to the library on my own? For two reasons:\r\n\r\n1. I would either have to **not** use the NuGet package of MSTestHacks, so my signed version is not overwritten when the package is refreshed from repo., or have some kind of additional automated step which ensures that the MSTestHacks library is strongly named.\r\n2. The strong name signing operation should be done during compilation (or rather linking), so to perform it on a compiled library I get from NuGet, I'd have to decompile it first, and then recompile with a signature. This may actually alter the library, depending on the (original) compilation options.\r\n\r\nAre there any drawbacks of having the MSTestHacks library strongly named? Yes. The main one is that the private key used to sign the assembly should be protected from unauthorized access, otherwise anyone could produce a library of their own, which would be signed just as the original one, circumventing all the security measures that the strong name brings. The secondary one is that the MSTestHacks will not be able to rely on other libraries, that are not strongly named. It's not the case now, but could turn out to be a problem in the future.\r\nWill I have to also sign my assemblies with a strong name, when using a strongly named version of the MSTestHacks library? No. A strongly named assembly can be freely used by both signed and not signed assemblies."}}
{"actor":{"display_login":"hilari0n"}}