{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/1582","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1582/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1582/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1582/events","html_url":"https://github.com/openzipkin/zipkin/pull/1582","id":225975754,"number":1582,"title":"Enables search by binary annotation aka tag key","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars1.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-03T12:53:03Z","updated_at":"2017-05-04T01:46:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1582","html_url":"https://github.com/openzipkin/zipkin/pull/1582","diff_url":"https://github.com/openzipkin/zipkin/pull/1582.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1582.patch"},"body":"I believe we once were able to search by presence of a tag key. Ex\r\n\"http.method\" would return any traces that included any http request.\r\nSomewhere along the way this stopped working. This resurrects the\r\nfeature along with tests. Here's the impact:\r\n\r\n* Cassandra will index a bit more: once per unique service/tag key\r\n* Elasticsearch now does two nested queries when looking for a key\r\n* MySQL now considers all annotation rows when looking for a key\r\n\r\nI think the value is greater than the impact as this is intuitive and\r\nanswers a functionality many expect to \"just work\"."},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/299080305","html_url":"https://github.com/openzipkin/zipkin/pull/1582#issuecomment-299080305","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1582","id":299080305,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars1.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2017-05-04T01:46:08Z","updated_at":"2017-05-04T01:46:08Z","body":"merging based on thumbs present!"}}
{"actor":{"display_login":"adriancole"}}