{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/prkumar/uplink/pulls/29","id":154296412,"html_url":"https://github.com/prkumar/uplink/pull/29","diff_url":"https://github.com/prkumar/uplink/pull/29.diff","patch_url":"https://github.com/prkumar/uplink/pull/29.patch","issue_url":"https://api.github.com/repos/prkumar/uplink/issues/29","number":29,"state":"closed","locked":false,"title":"Instantiate client adapter if a class is passed.","user":{"login":"kadrach","id":206176,"avatar_url":"https://avatars1.githubusercontent.com/u/206176?v=4","gravatar_id":"","url":"https://api.github.com/users/kadrach","html_url":"https://github.com/kadrach","followers_url":"https://api.github.com/users/kadrach/followers","following_url":"https://api.github.com/users/kadrach/following{/other_user}","gists_url":"https://api.github.com/users/kadrach/gists{/gist_id}","starred_url":"https://api.github.com/users/kadrach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadrach/subscriptions","organizations_url":"https://api.github.com/users/kadrach/orgs","repos_url":"https://api.github.com/users/kadrach/repos","events_url":"https://api.github.com/users/kadrach/events{/privacy}","received_events_url":"https://api.github.com/users/kadrach/received_events","type":"User","site_admin":false},"body":"Fixes #26.\r\n\r\nSimple change to allow the use case outlined in the issue, although now it will blindly try to instantiate any classes passed in, whether it implements the interface or not.\r\n\r\nI couldn't figure out how to have pytest use a fixture within a fixture, along the lines of\r\n\r\n```\r\n@pytest.fixture(params=[None, http_client_mock, http_client_mock()])\r\n```\r\n\r\nso I went with the current workaround.\r\n\r\nAttention: @prkumar","created_at":"2017-11-23T04:09:14Z","updated_at":"2017-11-23T05:54:34Z","closed_at":"2017-11-23T05:54:34Z","merged_at":"2017-11-23T05:54:34Z","merge_commit_sha":"f7717f34dcc05a956a1dbe4faebb8cb930e4e389","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prkumar/uplink/pulls/29/commits","review_comments_url":"https://api.github.com/repos/prkumar/uplink/pulls/29/comments","review_comment_url":"https://api.github.com/repos/prkumar/uplink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prkumar/uplink/issues/29/comments","statuses_url":"https://api.github.com/repos/prkumar/uplink/statuses/ff6ee96a29c890538f208f5d48dd0b103e4bf41d","head":{"label":"kadrach:stable","ref":"stable","sha":"ff6ee96a29c890538f208f5d48dd0b103e4bf41d","user":{"login":"kadrach","id":206176,"avatar_url":"https://avatars1.githubusercontent.com/u/206176?v=4","gravatar_id":"","url":"https://api.github.com/users/kadrach","html_url":"https://github.com/kadrach","followers_url":"https://api.github.com/users/kadrach/followers","following_url":"https://api.github.com/users/kadrach/following{/other_user}","gists_url":"https://api.github.com/users/kadrach/gists{/gist_id}","starred_url":"https://api.github.com/users/kadrach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadrach/subscriptions","organizations_url":"https://api.github.com/users/kadrach/orgs","repos_url":"https://api.github.com/users/kadrach/repos","events_url":"https://api.github.com/users/kadrach/events{/privacy}","received_events_url":"https://api.github.com/users/kadrach/received_events","type":"User","site_admin":false},"repo":{"id":111760415,"name":"uplink","full_name":"kadrach/uplink","owner":{"login":"kadrach","id":206176,"avatar_url":"https://avatars1.githubusercontent.com/u/206176?v=4","gravatar_id":"","url":"https://api.github.com/users/kadrach","html_url":"https://github.com/kadrach","followers_url":"https://api.github.com/users/kadrach/followers","following_url":"https://api.github.com/users/kadrach/following{/other_user}","gists_url":"https://api.github.com/users/kadrach/gists{/gist_id}","starred_url":"https://api.github.com/users/kadrach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadrach/subscriptions","organizations_url":"https://api.github.com/users/kadrach/orgs","repos_url":"https://api.github.com/users/kadrach/repos","events_url":"https://api.github.com/users/kadrach/events{/privacy}","received_events_url":"https://api.github.com/users/kadrach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kadrach/uplink","description":"A Declarative HTTP Client for Python","fork":true,"url":"https://api.github.com/repos/kadrach/uplink","forks_url":"https://api.github.com/repos/kadrach/uplink/forks","keys_url":"https://api.github.com/repos/kadrach/uplink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadrach/uplink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadrach/uplink/teams","hooks_url":"https://api.github.com/repos/kadrach/uplink/hooks","issue_events_url":"https://api.github.com/repos/kadrach/uplink/issues/events{/number}","events_url":"https://api.github.com/repos/kadrach/uplink/events","assignees_url":"https://api.github.com/repos/kadrach/uplink/assignees{/user}","branches_url":"https://api.github.com/repos/kadrach/uplink/branches{/branch}","tags_url":"https://api.github.com/repos/kadrach/uplink/tags","blobs_url":"https://api.github.com/repos/kadrach/uplink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadrach/uplink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadrach/uplink/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadrach/uplink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadrach/uplink/statuses/{sha}","languages_url":"https://api.github.com/repos/kadrach/uplink/languages","stargazers_url":"https://api.github.com/repos/kadrach/uplink/stargazers","contributors_url":"https://api.github.com/repos/kadrach/uplink/contributors","subscribers_url":"https://api.github.com/repos/kadrach/uplink/subscribers","subscription_url":"https://api.github.com/repos/kadrach/uplink/subscription","commits_url":"https://api.github.com/repos/kadrach/uplink/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadrach/uplink/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadrach/uplink/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadrach/uplink/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadrach/uplink/contents/{+path}","compare_url":"https://api.github.com/repos/kadrach/uplink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadrach/uplink/merges","archive_url":"https://api.github.com/repos/kadrach/uplink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadrach/uplink/downloads","issues_url":"https://api.github.com/repos/kadrach/uplink/issues{/number}","pulls_url":"https://api.github.com/repos/kadrach/uplink/pulls{/number}","milestones_url":"https://api.github.com/repos/kadrach/uplink/milestones{/number}","notifications_url":"https://api.github.com/repos/kadrach/uplink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadrach/uplink/labels{/name}","releases_url":"https://api.github.com/repos/kadrach/uplink/releases{/id}","deployments_url":"https://api.github.com/repos/kadrach/uplink/deployments","created_at":"2017-11-23T03:48:10Z","updated_at":"2017-11-23T03:48:12Z","pushed_at":"2017-11-23T04:03:16Z","git_url":"git://github.com/kadrach/uplink.git","ssh_url":"git@github.com:kadrach/uplink.git","clone_url":"https://github.com/kadrach/uplink.git","svn_url":"https://github.com/kadrach/uplink","homepage":"https://uplink.readthedocs.io/","size":172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prkumar:stable","ref":"stable","sha":"25f94063f549cd33c76ed5a8aca4617fa52373e2","user":{"login":"prkumar","id":10181244,"avatar_url":"https://avatars0.githubusercontent.com/u/10181244?v=4","gravatar_id":"","url":"https://api.github.com/users/prkumar","html_url":"https://github.com/prkumar","followers_url":"https://api.github.com/users/prkumar/followers","following_url":"https://api.github.com/users/prkumar/following{/other_user}","gists_url":"https://api.github.com/users/prkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/prkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prkumar/subscriptions","organizations_url":"https://api.github.com/users/prkumar/orgs","repos_url":"https://api.github.com/users/prkumar/repos","events_url":"https://api.github.com/users/prkumar/events{/privacy}","received_events_url":"https://api.github.com/users/prkumar/received_events","type":"User","site_admin":false},"repo":{"id":104703235,"name":"uplink","full_name":"prkumar/uplink","owner":{"login":"prkumar","id":10181244,"avatar_url":"https://avatars0.githubusercontent.com/u/10181244?v=4","gravatar_id":"","url":"https://api.github.com/users/prkumar","html_url":"https://github.com/prkumar","followers_url":"https://api.github.com/users/prkumar/followers","following_url":"https://api.github.com/users/prkumar/following{/other_user}","gists_url":"https://api.github.com/users/prkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/prkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prkumar/subscriptions","organizations_url":"https://api.github.com/users/prkumar/orgs","repos_url":"https://api.github.com/users/prkumar/repos","events_url":"https://api.github.com/users/prkumar/events{/privacy}","received_events_url":"https://api.github.com/users/prkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prkumar/uplink","description":"A Declarative HTTP Client for Python","fork":false,"url":"https://api.github.com/repos/prkumar/uplink","forks_url":"https://api.github.com/repos/prkumar/uplink/forks","keys_url":"https://api.github.com/repos/prkumar/uplink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prkumar/uplink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prkumar/uplink/teams","hooks_url":"https://api.github.com/repos/prkumar/uplink/hooks","issue_events_url":"https://api.github.com/repos/prkumar/uplink/issues/events{/number}","events_url":"https://api.github.com/repos/prkumar/uplink/events","assignees_url":"https://api.github.com/repos/prkumar/uplink/assignees{/user}","branches_url":"https://api.github.com/repos/prkumar/uplink/branches{/branch}","tags_url":"https://api.github.com/repos/prkumar/uplink/tags","blobs_url":"https://api.github.com/repos/prkumar/uplink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prkumar/uplink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prkumar/uplink/git/refs{/sha}","trees_url":"https://api.github.com/repos/prkumar/uplink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prkumar/uplink/statuses/{sha}","languages_url":"https://api.github.com/repos/prkumar/uplink/languages","stargazers_url":"https://api.github.com/repos/prkumar/uplink/stargazers","contributors_url":"https://api.github.com/repos/prkumar/uplink/contributors","subscribers_url":"https://api.github.com/repos/prkumar/uplink/subscribers","subscription_url":"https://api.github.com/repos/prkumar/uplink/subscription","commits_url":"https://api.github.com/repos/prkumar/uplink/commits{/sha}","git_commits_url":"https://api.github.com/repos/prkumar/uplink/git/commits{/sha}","comments_url":"https://api.github.com/repos/prkumar/uplink/comments{/number}","issue_comment_url":"https://api.github.com/repos/prkumar/uplink/issues/comments{/number}","contents_url":"https://api.github.com/repos/prkumar/uplink/contents/{+path}","compare_url":"https://api.github.com/repos/prkumar/uplink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prkumar/uplink/merges","archive_url":"https://api.github.com/repos/prkumar/uplink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prkumar/uplink/downloads","issues_url":"https://api.github.com/repos/prkumar/uplink/issues{/number}","pulls_url":"https://api.github.com/repos/prkumar/uplink/pulls{/number}","milestones_url":"https://api.github.com/repos/prkumar/uplink/milestones{/number}","notifications_url":"https://api.github.com/repos/prkumar/uplink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prkumar/uplink/labels{/name}","releases_url":"https://api.github.com/repos/prkumar/uplink/releases{/id}","deployments_url":"https://api.github.com/repos/prkumar/uplink/deployments","created_at":"2017-09-25T04:27:45Z","updated_at":"2017-11-22T17:23:26Z","pushed_at":"2017-11-23T05:54:34Z","git_url":"git://github.com/prkumar/uplink.git","ssh_url":"git@github.com:prkumar/uplink.git","clone_url":"https://github.com/prkumar/uplink.git","svn_url":"https://github.com/prkumar/uplink","homepage":"https://uplink.readthedocs.io/","size":168,"stargazers_count":251,"watchers_count":251,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prkumar/uplink/pulls/29"},"html":{"href":"https://github.com/prkumar/uplink/pull/29"},"issue":{"href":"https://api.github.com/repos/prkumar/uplink/issues/29"},"comments":{"href":"https://api.github.com/repos/prkumar/uplink/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/prkumar/uplink/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/prkumar/uplink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prkumar/uplink/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/prkumar/uplink/statuses/ff6ee96a29c890538f208f5d48dd0b103e4bf41d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"prkumar","id":10181244,"avatar_url":"https://avatars0.githubusercontent.com/u/10181244?v=4","gravatar_id":"","url":"https://api.github.com/users/prkumar","html_url":"https://github.com/prkumar","followers_url":"https://api.github.com/users/prkumar/followers","following_url":"https://api.github.com/users/prkumar/following{/other_user}","gists_url":"https://api.github.com/users/prkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/prkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prkumar/subscriptions","organizations_url":"https://api.github.com/users/prkumar/orgs","repos_url":"https://api.github.com/users/prkumar/repos","events_url":"https://api.github.com/users/prkumar/events{/privacy}","received_events_url":"https://api.github.com/users/prkumar/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"prkumar"}}