{"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/comments/117795575","pull_request_review_id":39532245,"id":117795575,"diff_hunk":"@@ -85,7 +83,9 @@ module.exports = {\n      * @property update\n      * @type {Joi}\n      */\n-    update: Joi.object(mutate(MODEL, [], [\n+    update: Joi.object(mutate(MODEL, [\n+        'id'\n+    ], [","path":"models/token.js","position":32,"original_position":32,"commit_id":"b4de3bde1e7b6f42e0c822454d7b2f9d626b0747","original_commit_id":"b4de3bde1e7b6f42e0c822454d7b2f9d626b0747","user":{"login":"minz1027","id":20427140,"avatar_url":"https://avatars3.githubusercontent.com/u/20427140?v=3","gravatar_id":"","url":"https://api.github.com/users/minz1027","html_url":"https://github.com/minz1027","followers_url":"https://api.github.com/users/minz1027/followers","following_url":"https://api.github.com/users/minz1027/following{/other_user}","gists_url":"https://api.github.com/users/minz1027/gists{/gist_id}","starred_url":"https://api.github.com/users/minz1027/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minz1027/subscriptions","organizations_url":"https://api.github.com/users/minz1027/orgs","repos_url":"https://api.github.com/users/minz1027/repos","events_url":"https://api.github.com/users/minz1027/events{/privacy}","received_events_url":"https://api.github.com/users/minz1027/received_events","type":"User","site_admin":false},"body":"This is intended to be used to validate the payload of the POST tokens/{id} right?\r\nIf you look at this: https://github.com/screwdriver-cd/screwdriver/blob/master/plugins/jobs/update.js\r\n`/{id}` is validated by validate param and the update schema is used to validate the payload. Do you want `id` inside the payload instead of part of the endpoint? ","created_at":"2017-05-22T16:58:54Z","updated_at":"2017-05-22T16:59:00Z","html_url":"https://github.com/screwdriver-cd/data-schema/pull/133#discussion_r117795575","pull_request_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/comments/117795575"},"html":{"href":"https://github.com/screwdriver-cd/data-schema/pull/133#discussion_r117795575"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133","id":121599820,"html_url":"https://github.com/screwdriver-cd/data-schema/pull/133","diff_url":"https://github.com/screwdriver-cd/data-schema/pull/133.diff","patch_url":"https://github.com/screwdriver-cd/data-schema/pull/133.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/133","number":133,"state":"open","locked":false,"title":"fix: update fields in token schema","user":{"login":"ian-fox","id":7689953,"avatar_url":"https://avatars3.githubusercontent.com/u/7689953?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-fox","html_url":"https://github.com/ian-fox","followers_url":"https://api.github.com/users/ian-fox/followers","following_url":"https://api.github.com/users/ian-fox/following{/other_user}","gists_url":"https://api.github.com/users/ian-fox/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-fox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-fox/subscriptions","organizations_url":"https://api.github.com/users/ian-fox/orgs","repos_url":"https://api.github.com/users/ian-fox/repos","events_url":"https://api.github.com/users/ian-fox/events{/privacy}","received_events_url":"https://api.github.com/users/ian-fox/received_events","type":"User","site_admin":false},"body":"* Get should not be an array, it will be turned into an array in the tokens.list endpoint\r\n* Don't need a userID when creating a token, can pull that from the request authorization\r\n* Do need a token ID to tell which token is being updated when calling token.update","created_at":"2017-05-19T23:41:01Z","updated_at":"2017-05-22T16:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a41d8bddce5d54e7964ec5d832136d6b8b4c62a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/133/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/data-schema/statuses/b4de3bde1e7b6f42e0c822454d7b2f9d626b0747","head":{"label":"screwdriver-cd:user-tokens","ref":"user-tokens","sha":"b4de3bde1e7b6f42e0c822454d7b2f9d626b0747","user":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars3.githubusercontent.com/u/19417863?v=3","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":62757101,"name":"data-schema","full_name":"screwdriver-cd/data-schema","owner":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars3.githubusercontent.com/u/19417863?v=3","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/data-schema","description":" Screwdriver internal data schema","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/data-schema","forks_url":"https://api.github.com/repos/screwdriver-cd/data-schema/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/data-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/data-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/data-schema/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/data-schema/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/data-schema/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/data-schema/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/data-schema/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/data-schema/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/data-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/data-schema/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/data-schema/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/data-schema/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/data-schema/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/data-schema/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/data-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/data-schema/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/data-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/data-schema/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/data-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/data-schema/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/data-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/data-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/data-schema/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/data-schema/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/deployments","created_at":"2016-07-06T22:20:53Z","updated_at":"2017-03-01T00:10:32Z","pushed_at":"2017-05-22T16:32:28Z","git_url":"git://github.com/screwdriver-cd/data-schema.git","ssh_url":"git@github.com:screwdriver-cd/data-schema.git","clone_url":"https://github.com/screwdriver-cd/data-schema.git","svn_url":"https://github.com/screwdriver-cd/data-schema","homepage":"https://www.npmjs.com/package/screwdriver-data-schema","size":213,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"3dfadec9cad57b2e4109f4cb3e1d1000203ea32c","user":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars3.githubusercontent.com/u/19417863?v=3","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":62757101,"name":"data-schema","full_name":"screwdriver-cd/data-schema","owner":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars3.githubusercontent.com/u/19417863?v=3","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/data-schema","description":" Screwdriver internal data schema","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/data-schema","forks_url":"https://api.github.com/repos/screwdriver-cd/data-schema/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/data-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/data-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/data-schema/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/data-schema/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/data-schema/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/data-schema/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/data-schema/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/data-schema/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/data-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/data-schema/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/data-schema/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/data-schema/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/data-schema/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/data-schema/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/data-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/data-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/data-schema/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/data-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/data-schema/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/data-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/data-schema/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/data-schema/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/data-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/data-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/data-schema/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/data-schema/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/data-schema/deployments","created_at":"2016-07-06T22:20:53Z","updated_at":"2017-03-01T00:10:32Z","pushed_at":"2017-05-22T16:32:28Z","git_url":"git://github.com/screwdriver-cd/data-schema.git","ssh_url":"git@github.com:screwdriver-cd/data-schema.git","clone_url":"https://github.com/screwdriver-cd/data-schema.git","svn_url":"https://github.com/screwdriver-cd/data-schema","homepage":"https://www.npmjs.com/package/screwdriver-data-schema","size":213,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133"},"html":{"href":"https://github.com/screwdriver-cd/data-schema/pull/133"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/133"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/data-schema/statuses/b4de3bde1e7b6f42e0c822454d7b2f9d626b0747"}}}}
{"actor":{"display_login":"minz1027"}}