{"action":"created","comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/104151655","pull_request_review_id":24968786,"id":104151655,"diff_hunk":"@@ -0,0 +1,68 @@\n+---\n+- name: create Graphite user group\n+  group: name=graphite\n+         state=present\n+\n+- name: create service account for Graphite\n+  user: name=graphite\n+        system=yes\n+        home={{ graphite_root }}\n+        shell=/bin/false\n+        group=graphite\n+        state=present\n+\n+- name: create service account for Carbon\n+  user: name=carbon\n+        system=yes\n+        home={{ graphite_root }}\n+        shell=/bin/false\n+        group=graphite\n+        state=present\n+\n+- name: create common Graphite directories","path":"playbooks/roles/graphite/tasks/main.yml","position":22,"original_position":22,"commit_id":"b5960d58f9d5718c2364b6e8505b2f0cb4c097b7","original_commit_id":"b5960d58f9d5718c2364b6e8505b2f0cb4c097b7","user":{"login":"e0d","id":1270274,"avatar_url":"https://avatars1.githubusercontent.com/u/1270274?v=3","gravatar_id":"","url":"https://api.github.com/users/e0d","html_url":"https://github.com/e0d","followers_url":"https://api.github.com/users/e0d/followers","following_url":"https://api.github.com/users/e0d/following{/other_user}","gists_url":"https://api.github.com/users/e0d/gists{/gist_id}","starred_url":"https://api.github.com/users/e0d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e0d/subscriptions","organizations_url":"https://api.github.com/users/e0d/orgs","repos_url":"https://api.github.com/users/e0d/repos","events_url":"https://api.github.com/users/e0d/events{/privacy}","received_events_url":"https://api.github.com/users/e0d/received_events","type":"User","site_admin":false},"body":"I like doing this using with_items and data:\r\n\r\nhttps://github.com/edx/configuration/blob/master/playbooks/roles/vhost/defaults/main.yml#L18","created_at":"2017-03-03T13:25:16Z","updated_at":"2017-03-03T13:46:52Z","html_url":"https://github.com/edx/configuration/pull/3723#discussion_r104151655","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/3723","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/104151655"},"html":{"href":"https://github.com/edx/configuration/pull/3723#discussion_r104151655"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/3723"}}},"pull_request":{"url":"https://api.github.com/repos/edx/configuration/pulls/3723","id":108616645,"html_url":"https://github.com/edx/configuration/pull/3723","diff_url":"https://github.com/edx/configuration/pull/3723.diff","patch_url":"https://github.com/edx/configuration/pull/3723.patch","issue_url":"https://api.github.com/repos/edx/configuration/issues/3723","number":3723,"state":"open","locked":false,"title":"Add a playbook for installing and configuring Graphite.","user":{"login":"tobz","id":222615,"avatar_url":"https://avatars1.githubusercontent.com/u/222615?v=3","gravatar_id":"","url":"https://api.github.com/users/tobz","html_url":"https://github.com/tobz","followers_url":"https://api.github.com/users/tobz/followers","following_url":"https://api.github.com/users/tobz/following{/other_user}","gists_url":"https://api.github.com/users/tobz/gists{/gist_id}","starred_url":"https://api.github.com/users/tobz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobz/subscriptions","organizations_url":"https://api.github.com/users/tobz/orgs","repos_url":"https://api.github.com/users/tobz/repos","events_url":"https://api.github.com/users/tobz/events{/privacy}","received_events_url":"https://api.github.com/users/tobz/received_events","type":"User","site_admin":false},"body":"This playbook will install `carbon-cache` and `graphite-api` to provide a minimalistic starting point for metrics collection.  A server would be ready to accept metrics (from anything that could speak the Graphite line protocol, such as `statsd`) and be a target for a Grafana installation after running this playbook on its own.\r\n\r\nIt currently installs all components from their upstream source (albeit with defaults that point to tags, and not master/development branches).  It uses systemd, and so is tailored specifically to Ubuntu 16.04.\r\n\r\nIt currently does not support any of the advanced configuration such as multiple `carbon-cache` process + `carbon-relay`.  It is also lacking many variables to fully tweak the various configuration files, although there's support for fully configuring the storage schemas.\r\n\r\nThere is a small \"master\" playbook -- `edx-monitoring` -- for running the role, and in the future, supporting the culmination of other playbooks to build out an all-in-one monitoring server: Graphite, Grafana, etc.\r\n\r\nConfiguration Pull Request\r\n---\r\n\r\nMake sure that the following steps are done before merging\r\n\r\n  - [ ] A devops team member has commented with :+1:\r\n  - [ ] are you adding any new default values that need to be overridden when this goes live?\r\n    - [ ] Open a ticket (DEVOPS) to make sure that they have been added to secure vars.\r\n    - [ ] Add an entry to the CHANGELOG.\r\n","created_at":"2017-03-01T20:00:39Z","updated_at":"2017-03-03T13:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0cf576bad6b49927782b108d09db92bdb10e9cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/configuration/pulls/3723/commits","review_comments_url":"https://api.github.com/repos/edx/configuration/pulls/3723/comments","review_comment_url":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/configuration/issues/3723/comments","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/b5960d58f9d5718c2364b6e8505b2f0cb4c097b7","head":{"label":"edx:tobz/add-graphite-role","ref":"tobz/add-graphite-role","sha":"b5960d58f9d5718c2364b6e8505b2f0cb4c097b7","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/edx/configuration/deployments","created_at":"2013-04-16T17:23:42Z","updated_at":"2017-02-27T20:40:14Z","pushed_at":"2017-03-02T16:34:32Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":11679,"stargazers_count":573,"watchers_count":573,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":594,"mirror_url":null,"open_issues_count":92,"forks":594,"open_issues":92,"watchers":573,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"9a0161423d3ec0021a9acda22f05e0d15623db34","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/edx/configuration/deployments","created_at":"2013-04-16T17:23:42Z","updated_at":"2017-02-27T20:40:14Z","pushed_at":"2017-03-02T16:34:32Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":11679,"stargazers_count":573,"watchers_count":573,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":594,"mirror_url":null,"open_issues_count":92,"forks":594,"open_issues":92,"watchers":573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/3723"},"html":{"href":"https://github.com/edx/configuration/pull/3723"},"issue":{"href":"https://api.github.com/repos/edx/configuration/issues/3723"},"comments":{"href":"https://api.github.com/repos/edx/configuration/issues/3723/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/configuration/pulls/3723/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/configuration/pulls/3723/commits"},"statuses":{"href":"https://api.github.com/repos/edx/configuration/statuses/b5960d58f9d5718c2364b6e8505b2f0cb4c097b7"}}}}
{"actor":{"display_login":"e0d"}}