{"comment":{"url":"https://api.github.com/repos/MariaDB/server/comments/25858755","html_url":"https://github.com/MariaDB/server/commit/378c54fef16f02c5622644bb63e4d99dffea27b6#commitcomment-25858755","id":25858755,"user":{"login":"vuvova","id":2737648,"avatar_url":"https://avatars2.githubusercontent.com/u/2737648?v=4","gravatar_id":"","url":"https://api.github.com/users/vuvova","html_url":"https://github.com/vuvova","followers_url":"https://api.github.com/users/vuvova/followers","following_url":"https://api.github.com/users/vuvova/following{/other_user}","gists_url":"https://api.github.com/users/vuvova/gists{/gist_id}","starred_url":"https://api.github.com/users/vuvova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuvova/subscriptions","organizations_url":"https://api.github.com/users/vuvova/orgs","repos_url":"https://api.github.com/users/vuvova/repos","events_url":"https://api.github.com/users/vuvova/events{/privacy}","received_events_url":"https://api.github.com/users/vuvova/received_events","type":"User","site_admin":false},"position":30,"line":98,"path":"sql/sql_plugin.cc","commit_id":"378c54fef16f02c5622644bb63e4d99dffea27b6","created_at":"2017-11-26T21:06:08Z","updated_at":"2017-11-26T21:06:08Z","author_association":"OWNER","body":"I'd rather extend `Sys_var_enum` class by adding new constructor that takes a string as def_value. In the constructor it would do\r\n```\r\n    global_var(ulong)= find_type(def_val, &typelib, FIND_TYPE_NO_PREFIX)  - 1;\r\n```\r\nAfter that you can use `STRINGIFY_ARG(SERVER_MATURITY_LEVEL)` directly as a default value for `Sys_plugin_maturity`.\r\n\r\nEven simpler would be to do something like\r\n```\r\n#define alpha 1\r\n#define beta 2\r\n```\r\netc, and then use `SERVER_MATURITY_LEVEL` directly as a default value."}}
{"actor":{"display_login":"vuvova"}}