{"action":"closed","number":623,"pull_request":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/623","id":111869264,"html_url":"https://github.com/mozilla/normandy/pull/623","diff_url":"https://github.com/mozilla/normandy/pull/623.diff","patch_url":"https://github.com/mozilla/normandy/pull/623.patch","issue_url":"https://api.github.com/repos/mozilla/normandy/issues/623","number":623,"state":"closed","locked":false,"title":"Preference experiment driver API","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars2.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"This is based off #603, and must wait for that to merge. The last 4 commits are the ones that matter, and IMO are review-able now, even if this is blocked by the previous PR.\r\n\r\nThis adds `PreferenceExperiments.jsm` to the add-on, which implements the API for starting and stopping preference experiments, persists experiment state to the profile, modifies preferences, and starts watchers to end the experiment if the user changes the preference. This also includes a new `SandboxManager.wrapAsync` method for wrapping privileged async methods for use in the sandbox.\r\n\r\nIt also updates the action code to use the API and to assign the user to a feature branch correctly according to the branch ratios.\r\n\r\nThis is (intentionally, for now) missing:\r\n- Checking for preference changes on a new session startup\r\n- Starting preference watchers on a new session startup\r\n- Removing expired preference experiments\r\n\r\n(Including @chartjes on this for test coverage review of non-addon bits)\r\n","created_at":"2017-03-21T20:16:07Z","updated_at":"2017-03-21T20:28:28Z","closed_at":"2017-03-21T20:28:28Z","merged_at":null,"merge_commit_sha":"ca2f66473017150470bf1f821a808d31967dc650","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/normandy/pulls/623/commits","review_comments_url":"https://api.github.com/repos/mozilla/normandy/pulls/623/comments","review_comment_url":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/normandy/issues/623/comments","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/f4732714cbf1fbdf2bcd59fc95e1894330d44425","head":{"label":"Osmose:preference-experiment-driver","ref":"preference-experiment-driver","sha":"f4732714cbf1fbdf2bcd59fc95e1894330d44425","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars2.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"repo":{"id":48456654,"name":"normandy","full_name":"Osmose/normandy","owner":{"login":"Osmose","id":193106,"avatar_url":"https://avatars2.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Osmose/normandy","description":"Self-Repair 2","fork":true,"url":"https://api.github.com/repos/Osmose/normandy","forks_url":"https://api.github.com/repos/Osmose/normandy/forks","keys_url":"https://api.github.com/repos/Osmose/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Osmose/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Osmose/normandy/teams","hooks_url":"https://api.github.com/repos/Osmose/normandy/hooks","issue_events_url":"https://api.github.com/repos/Osmose/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/Osmose/normandy/events","assignees_url":"https://api.github.com/repos/Osmose/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/Osmose/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/Osmose/normandy/tags","blobs_url":"https://api.github.com/repos/Osmose/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Osmose/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Osmose/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Osmose/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Osmose/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/Osmose/normandy/languages","stargazers_url":"https://api.github.com/repos/Osmose/normandy/stargazers","contributors_url":"https://api.github.com/repos/Osmose/normandy/contributors","subscribers_url":"https://api.github.com/repos/Osmose/normandy/subscribers","subscription_url":"https://api.github.com/repos/Osmose/normandy/subscription","commits_url":"https://api.github.com/repos/Osmose/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Osmose/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Osmose/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Osmose/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Osmose/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/Osmose/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Osmose/normandy/merges","archive_url":"https://api.github.com/repos/Osmose/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Osmose/normandy/downloads","issues_url":"https://api.github.com/repos/Osmose/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/Osmose/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/Osmose/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/Osmose/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Osmose/normandy/labels{/name}","releases_url":"https://api.github.com/repos/Osmose/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/Osmose/normandy/deployments","created_at":"2015-12-22T22:18:41Z","updated_at":"2017-01-07T01:53:48Z","pushed_at":"2017-03-21T20:27:17Z","git_url":"git://github.com/Osmose/normandy.git","ssh_url":"git@github.com:Osmose/normandy.git","clone_url":"https://github.com/Osmose/normandy.git","svn_url":"https://github.com/Osmose/normandy","homepage":null,"size":3196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:preference-experiment","ref":"preference-experiment","sha":"551a40aa61689e89d358c879513ccf2c84669352","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":48456638,"name":"normandy","full_name":"mozilla/normandy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/normandy","description":"Firefox recipe server","fork":false,"url":"https://api.github.com/repos/mozilla/normandy","forks_url":"https://api.github.com/repos/mozilla/normandy/forks","keys_url":"https://api.github.com/repos/mozilla/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/normandy/teams","hooks_url":"https://api.github.com/repos/mozilla/normandy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/normandy/events","assignees_url":"https://api.github.com/repos/mozilla/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/normandy/tags","blobs_url":"https://api.github.com/repos/mozilla/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/normandy/languages","stargazers_url":"https://api.github.com/repos/mozilla/normandy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/normandy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/normandy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/normandy/subscription","commits_url":"https://api.github.com/repos/mozilla/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/normandy/merges","archive_url":"https://api.github.com/repos/mozilla/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/normandy/downloads","issues_url":"https://api.github.com/repos/mozilla/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/normandy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/normandy/deployments","created_at":"2015-12-22T22:18:19Z","updated_at":"2017-03-15T11:54:32Z","pushed_at":"2017-03-21T20:27:29Z","git_url":"git://github.com/mozilla/normandy.git","ssh_url":"git@github.com:mozilla/normandy.git","clone_url":"https://github.com/mozilla/normandy.git","svn_url":"https://github.com/mozilla/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":3360,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":74,"forks":16,"open_issues":74,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/623"},"html":{"href":"https://github.com/mozilla/normandy/pull/623"},"issue":{"href":"https://api.github.com/repos/mozilla/normandy/issues/623"},"comments":{"href":"https://api.github.com/repos/mozilla/normandy/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/normandy/statuses/f4732714cbf1fbdf2bcd59fc95e1894330d44425"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":31,"additions":1762,"deletions":189,"changed_files":47}}
{"actor":{"display_login":"Osmose"}}