{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/99994010","pull_request_review_id":20685221,"id":99994010,"diff_hunk":"@@ -30,8 +30,7 @@\n \n def get_version():\n   global_names = {}\n-  execfile(os.path.normpath('./apache_beam/version.py'),\n-           global_names)\n+  exec(open(os.path.normpath('./apache_beam/version.py')).read(), global_names)","path":"sdks/python/setup.py","position":6,"original_position":6,"commit_id":"5253bcb1ff46b93c0d27ada81e40f556bcc627c1","original_commit_id":"5253bcb1ff46b93c0d27ada81e40f556bcc627c1","user":{"login":"wikier","id":812223,"avatar_url":"https://avatars.githubusercontent.com/u/812223?v=3","gravatar_id":"","url":"https://api.github.com/users/wikier","html_url":"https://github.com/wikier","followers_url":"https://api.github.com/users/wikier/followers","following_url":"https://api.github.com/users/wikier/following{/other_user}","gists_url":"https://api.github.com/users/wikier/gists{/gist_id}","starred_url":"https://api.github.com/users/wikier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikier/subscriptions","organizations_url":"https://api.github.com/users/wikier/orgs","repos_url":"https://api.github.com/users/wikier/repos","events_url":"https://api.github.com/users/wikier/events{/privacy}","received_events_url":"https://api.github.com/users/wikier/received_events","type":"User","site_admin":false},"body":"Not sure... the purpose of `apache_beam.version` is to have access to the version at runtime. The trick this PR patched was already there for the purpose I commented before. It's typical chicken-and-egg problem of setuptools.","created_at":"2017-02-08T05:26:05Z","updated_at":"2017-02-08T05:26:05Z","html_url":"https://github.com/apache/beam/pull/1887#discussion_r99994010","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/1887","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/99994010"},"html":{"href":"https://github.com/apache/beam/pull/1887#discussion_r99994010"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/1887"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/1887","id":104092216,"html_url":"https://github.com/apache/beam/pull/1887","diff_url":"https://github.com/apache/beam/pull/1887.diff","patch_url":"https://github.com/apache/beam/pull/1887.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/1887","number":1887,"state":"open","locked":false,"title":"[BEAM-1368] fixed Python SDK setup in Python 3.x","user":{"login":"wikier","id":812223,"avatar_url":"https://avatars.githubusercontent.com/u/812223?v=3","gravatar_id":"","url":"https://api.github.com/users/wikier","html_url":"https://github.com/wikier","followers_url":"https://api.github.com/users/wikier/followers","following_url":"https://api.github.com/users/wikier/following{/other_user}","gists_url":"https://api.github.com/users/wikier/gists{/gist_id}","starred_url":"https://api.github.com/users/wikier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikier/subscriptions","organizations_url":"https://api.github.com/users/wikier/orgs","repos_url":"https://api.github.com/users/wikier/repos","events_url":"https://api.github.com/users/wikier/events{/privacy}","received_events_url":"https://api.github.com/users/wikier/received_events","type":"User","site_admin":false},"body":"By replacing the usage of `execfile()` by `exec()`, which is the official recommendation for portability.\r\n\r\nFurther details described at [BEAM-1368](https://issues.apache.org/jira/browse/BEAM-1368).\r\n\r\n---\r\n\r\nBe sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [X] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [X] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [X] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n\r\n","created_at":"2017-02-01T08:25:06Z","updated_at":"2017-02-08T05:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"483a4e32466fae03cb5f93e16419e14d9af551ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/1887/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/1887/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/1887/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/5253bcb1ff46b93c0d27ada81e40f556bcc627c1","head":{"label":"wikier:BEAM-1368_setup_python3","ref":"BEAM-1368_setup_python3","sha":"5253bcb1ff46b93c0d27ada81e40f556bcc627c1","user":{"login":"wikier","id":812223,"avatar_url":"https://avatars.githubusercontent.com/u/812223?v=3","gravatar_id":"","url":"https://api.github.com/users/wikier","html_url":"https://github.com/wikier","followers_url":"https://api.github.com/users/wikier/followers","following_url":"https://api.github.com/users/wikier/following{/other_user}","gists_url":"https://api.github.com/users/wikier/gists{/gist_id}","starred_url":"https://api.github.com/users/wikier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikier/subscriptions","organizations_url":"https://api.github.com/users/wikier/orgs","repos_url":"https://api.github.com/users/wikier/repos","events_url":"https://api.github.com/users/wikier/events{/privacy}","received_events_url":"https://api.github.com/users/wikier/received_events","type":"User","site_admin":false},"repo":{"id":80518232,"name":"beam","full_name":"wikier/beam","owner":{"login":"wikier","id":812223,"avatar_url":"https://avatars.githubusercontent.com/u/812223?v=3","gravatar_id":"","url":"https://api.github.com/users/wikier","html_url":"https://github.com/wikier","followers_url":"https://api.github.com/users/wikier/followers","following_url":"https://api.github.com/users/wikier/following{/other_user}","gists_url":"https://api.github.com/users/wikier/gists{/gist_id}","starred_url":"https://api.github.com/users/wikier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikier/subscriptions","organizations_url":"https://api.github.com/users/wikier/orgs","repos_url":"https://api.github.com/users/wikier/repos","events_url":"https://api.github.com/users/wikier/events{/privacy}","received_events_url":"https://api.github.com/users/wikier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wikier/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/wikier/beam","forks_url":"https://api.github.com/repos/wikier/beam/forks","keys_url":"https://api.github.com/repos/wikier/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikier/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikier/beam/teams","hooks_url":"https://api.github.com/repos/wikier/beam/hooks","issue_events_url":"https://api.github.com/repos/wikier/beam/issues/events{/number}","events_url":"https://api.github.com/repos/wikier/beam/events","assignees_url":"https://api.github.com/repos/wikier/beam/assignees{/user}","branches_url":"https://api.github.com/repos/wikier/beam/branches{/branch}","tags_url":"https://api.github.com/repos/wikier/beam/tags","blobs_url":"https://api.github.com/repos/wikier/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikier/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikier/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikier/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikier/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/wikier/beam/languages","stargazers_url":"https://api.github.com/repos/wikier/beam/stargazers","contributors_url":"https://api.github.com/repos/wikier/beam/contributors","subscribers_url":"https://api.github.com/repos/wikier/beam/subscribers","subscription_url":"https://api.github.com/repos/wikier/beam/subscription","commits_url":"https://api.github.com/repos/wikier/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikier/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikier/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikier/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikier/beam/contents/{+path}","compare_url":"https://api.github.com/repos/wikier/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikier/beam/merges","archive_url":"https://api.github.com/repos/wikier/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikier/beam/downloads","issues_url":"https://api.github.com/repos/wikier/beam/issues{/number}","pulls_url":"https://api.github.com/repos/wikier/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/wikier/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/wikier/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikier/beam/labels{/name}","releases_url":"https://api.github.com/repos/wikier/beam/releases{/id}","deployments_url":"https://api.github.com/repos/wikier/beam/deployments","created_at":"2017-01-31T12:25:54Z","updated_at":"2017-01-31T12:26:02Z","pushed_at":"2017-02-01T08:20:57Z","git_url":"git://github.com/wikier/beam.git","ssh_url":"git@github.com:wikier/beam.git","clone_url":"https://github.com/wikier/beam.git","svn_url":"https://github.com/wikier/beam","homepage":"","size":27528,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"92021c5dc6c5a80b7ee64fb06b629207aef132c6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-02-08T04:24:10Z","pushed_at":"2017-02-08T05:00:44Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":27324,"stargazers_count":830,"watchers_count":830,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":439,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":56,"forks":439,"open_issues":56,"watchers":830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/1887"},"html":{"href":"https://github.com/apache/beam/pull/1887"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/1887"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/1887/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/1887/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/1887/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/5253bcb1ff46b93c0d27ada81e40f556bcc627c1"}}}}
{"actor":{"display_login":"wikier"}}