{"action":"created","comment":{"url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/comments/125287333","pull_request_review_id":47662269,"id":125287333,"diff_hunk":"@@ -47,11 +47,11 @@ def fetch_and_extract(self, filename):\n class AWSPersistor(Persistor):\n     \"\"\"Store models on S3 and fetch them when needed instead of storing them on the local disk.\"\"\"\n \n-    def __init__(self, data_dir, aws_region, bucket_name):\n+    def __init__(self, data_dir, aws_region, bucket_name, endpoint_url):\n         # type: (Text, Text, Text) -> None\n         Persistor.__init__(self)\n         self.data_dir = data_dir\n-        self.s3 = boto3.resource('s3', region_name=aws_region)\n+        self.s3 = boto3.resource('s3', region_name=aws_region, endpoint_url=endpoint_url)","path":"rasa_nlu/persistor.py","position":19,"original_position":19,"commit_id":"e7672a0f7fa795f01f21206226393872e6f7d6eb","original_commit_id":"e7672a0f7fa795f01f21206226393872e6f7d6eb","user":{"login":"tmbo","id":1098412,"avatar_url":"https://avatars0.githubusercontent.com/u/1098412?v=3","gravatar_id":"","url":"https://api.github.com/users/tmbo","html_url":"https://github.com/tmbo","followers_url":"https://api.github.com/users/tmbo/followers","following_url":"https://api.github.com/users/tmbo/following{/other_user}","gists_url":"https://api.github.com/users/tmbo/gists{/gist_id}","starred_url":"https://api.github.com/users/tmbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmbo/subscriptions","organizations_url":"https://api.github.com/users/tmbo/orgs","repos_url":"https://api.github.com/users/tmbo/repos","events_url":"https://api.github.com/users/tmbo/events{/privacy}","received_events_url":"https://api.github.com/users/tmbo/received_events","type":"User","site_admin":false},"body":"yes looks good :+1:","created_at":"2017-07-03T13:18:37Z","updated_at":"2017-07-03T13:18:37Z","html_url":"https://github.com/RasaHQ/rasa_nlu/pull/448#discussion_r125287333","pull_request_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448","_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/comments/125287333"},"html":{"href":"https://github.com/RasaHQ/rasa_nlu/pull/448#discussion_r125287333"},"pull_request":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448"}}},"pull_request":{"url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448","id":127727179,"html_url":"https://github.com/RasaHQ/rasa_nlu/pull/448","diff_url":"https://github.com/RasaHQ/rasa_nlu/pull/448.diff","patch_url":"https://github.com/RasaHQ/rasa_nlu/pull/448.patch","issue_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/448","number":448,"state":"open","locked":false,"title":"Added functionality to allow custom S3 endpoints","user":{"login":"jinhong-","id":3448324,"avatar_url":"https://avatars0.githubusercontent.com/u/3448324?v=3","gravatar_id":"","url":"https://api.github.com/users/jinhong-","html_url":"https://github.com/jinhong-","followers_url":"https://api.github.com/users/jinhong-/followers","following_url":"https://api.github.com/users/jinhong-/following{/other_user}","gists_url":"https://api.github.com/users/jinhong-/gists{/gist_id}","starred_url":"https://api.github.com/users/jinhong-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinhong-/subscriptions","organizations_url":"https://api.github.com/users/jinhong-/orgs","repos_url":"https://api.github.com/users/jinhong-/repos","events_url":"https://api.github.com/users/jinhong-/events{/privacy}","received_events_url":"https://api.github.com/users/jinhong-/received_events","type":"User","site_admin":false},"body":"**Proposed changes**:\r\n- #444   \r\n\r\n**Status**:\r\n- [x] ready for code review\r\n- [ ] there are tests for the functionality\r\n- [x] documentation updated\r\n- [ ] changelog updated\r\n","created_at":"2017-06-27T15:41:06Z","updated_at":"2017-07-03T13:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a666fb90b17ef9f2151072c2d9abe6eb767f3cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448/commits","review_comments_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448/comments","review_comment_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/448/comments","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/statuses/e7672a0f7fa795f01f21206226393872e6f7d6eb","head":{"label":"jinhong-:master","ref":"master","sha":"e7672a0f7fa795f01f21206226393872e6f7d6eb","user":{"login":"jinhong-","id":3448324,"avatar_url":"https://avatars0.githubusercontent.com/u/3448324?v=3","gravatar_id":"","url":"https://api.github.com/users/jinhong-","html_url":"https://github.com/jinhong-","followers_url":"https://api.github.com/users/jinhong-/followers","following_url":"https://api.github.com/users/jinhong-/following{/other_user}","gists_url":"https://api.github.com/users/jinhong-/gists{/gist_id}","starred_url":"https://api.github.com/users/jinhong-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinhong-/subscriptions","organizations_url":"https://api.github.com/users/jinhong-/orgs","repos_url":"https://api.github.com/users/jinhong-/repos","events_url":"https://api.github.com/users/jinhong-/events{/privacy}","received_events_url":"https://api.github.com/users/jinhong-/received_events","type":"User","site_admin":false},"repo":{"id":95564768,"name":"rasa_nlu","full_name":"jinhong-/rasa_nlu","owner":{"login":"jinhong-","id":3448324,"avatar_url":"https://avatars0.githubusercontent.com/u/3448324?v=3","gravatar_id":"","url":"https://api.github.com/users/jinhong-","html_url":"https://github.com/jinhong-","followers_url":"https://api.github.com/users/jinhong-/followers","following_url":"https://api.github.com/users/jinhong-/following{/other_user}","gists_url":"https://api.github.com/users/jinhong-/gists{/gist_id}","starred_url":"https://api.github.com/users/jinhong-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinhong-/subscriptions","organizations_url":"https://api.github.com/users/jinhong-/orgs","repos_url":"https://api.github.com/users/jinhong-/repos","events_url":"https://api.github.com/users/jinhong-/events{/privacy}","received_events_url":"https://api.github.com/users/jinhong-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jinhong-/rasa_nlu","description":"turn natural language into structured data","fork":true,"url":"https://api.github.com/repos/jinhong-/rasa_nlu","forks_url":"https://api.github.com/repos/jinhong-/rasa_nlu/forks","keys_url":"https://api.github.com/repos/jinhong-/rasa_nlu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jinhong-/rasa_nlu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jinhong-/rasa_nlu/teams","hooks_url":"https://api.github.com/repos/jinhong-/rasa_nlu/hooks","issue_events_url":"https://api.github.com/repos/jinhong-/rasa_nlu/issues/events{/number}","events_url":"https://api.github.com/repos/jinhong-/rasa_nlu/events","assignees_url":"https://api.github.com/repos/jinhong-/rasa_nlu/assignees{/user}","branches_url":"https://api.github.com/repos/jinhong-/rasa_nlu/branches{/branch}","tags_url":"https://api.github.com/repos/jinhong-/rasa_nlu/tags","blobs_url":"https://api.github.com/repos/jinhong-/rasa_nlu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jinhong-/rasa_nlu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jinhong-/rasa_nlu/git/refs{/sha}","trees_url":"https://api.github.com/repos/jinhong-/rasa_nlu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jinhong-/rasa_nlu/statuses/{sha}","languages_url":"https://api.github.com/repos/jinhong-/rasa_nlu/languages","stargazers_url":"https://api.github.com/repos/jinhong-/rasa_nlu/stargazers","contributors_url":"https://api.github.com/repos/jinhong-/rasa_nlu/contributors","subscribers_url":"https://api.github.com/repos/jinhong-/rasa_nlu/subscribers","subscription_url":"https://api.github.com/repos/jinhong-/rasa_nlu/subscription","commits_url":"https://api.github.com/repos/jinhong-/rasa_nlu/commits{/sha}","git_commits_url":"https://api.github.com/repos/jinhong-/rasa_nlu/git/commits{/sha}","comments_url":"https://api.github.com/repos/jinhong-/rasa_nlu/comments{/number}","issue_comment_url":"https://api.github.com/repos/jinhong-/rasa_nlu/issues/comments{/number}","contents_url":"https://api.github.com/repos/jinhong-/rasa_nlu/contents/{+path}","compare_url":"https://api.github.com/repos/jinhong-/rasa_nlu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jinhong-/rasa_nlu/merges","archive_url":"https://api.github.com/repos/jinhong-/rasa_nlu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jinhong-/rasa_nlu/downloads","issues_url":"https://api.github.com/repos/jinhong-/rasa_nlu/issues{/number}","pulls_url":"https://api.github.com/repos/jinhong-/rasa_nlu/pulls{/number}","milestones_url":"https://api.github.com/repos/jinhong-/rasa_nlu/milestones{/number}","notifications_url":"https://api.github.com/repos/jinhong-/rasa_nlu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jinhong-/rasa_nlu/labels{/name}","releases_url":"https://api.github.com/repos/jinhong-/rasa_nlu/releases{/id}","deployments_url":"https://api.github.com/repos/jinhong-/rasa_nlu/deployments","created_at":"2017-06-27T14:04:04Z","updated_at":"2017-06-27T14:04:05Z","pushed_at":"2017-06-27T15:37:27Z","git_url":"git://github.com/jinhong-/rasa_nlu.git","ssh_url":"git@github.com:jinhong-/rasa_nlu.git","clone_url":"https://github.com/jinhong-/rasa_nlu.git","svn_url":"https://github.com/jinhong-/rasa_nlu","homepage":"https://rasa.ai","size":2950,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RasaHQ:master","ref":"master","sha":"7f40694a24cd1b0579660e7f68db39ca78f898a2","user":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars3.githubusercontent.com/u/21214473?v=3","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":70908208,"name":"rasa_nlu","full_name":"RasaHQ/rasa_nlu","owner":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars3.githubusercontent.com/u/21214473?v=3","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RasaHQ/rasa_nlu","description":"turn natural language into structured data","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa_nlu","forks_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa_nlu/deployments","created_at":"2016-10-14T12:27:49Z","updated_at":"2017-07-03T11:27:33Z","pushed_at":"2017-07-03T12:58:32Z","git_url":"git://github.com/RasaHQ/rasa_nlu.git","ssh_url":"git@github.com:RasaHQ/rasa_nlu.git","clone_url":"https://github.com/RasaHQ/rasa_nlu.git","svn_url":"https://github.com/RasaHQ/rasa_nlu","homepage":"https://rasa.ai","size":2965,"stargazers_count":1581,"watchers_count":1581,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":61,"forks":314,"open_issues":61,"watchers":1581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448"},"html":{"href":"https://github.com/RasaHQ/rasa_nlu/pull/448"},"issue":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/448"},"comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/RasaHQ/rasa_nlu/statuses/e7672a0f7fa795f01f21206226393872e6f7d6eb"}}}}
{"actor":{"display_login":"tmbo"}}