{"action":"closed","number":14853,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/14853","id":150617177,"html_url":"https://github.com/dotnet/coreclr/pull/14853","diff_url":"https://github.com/dotnet/coreclr/pull/14853.diff","patch_url":"https://github.com/dotnet/coreclr/pull/14853.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/14853","number":14853,"state":"closed","locked":false,"title":"[Arm64] SIMD applyCalleeSaveHeuristics","user":{"login":"sdmaclea","id":25674984,"avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false},"body":"`getRegisterType()` was incorrectly being called here.  Per the `getRegisterType()` function comment this should only be called when the register is about to be consumed.  In this case the register is not necessarily being consumed.  In the case of incoming arguments it is being produced.\r\n\r\nFor ARM64 with SIMD, this caused an assert because the assign register was a Integer register due to ABI constraints (SIMD args are passed in integer registers, while the SIMD reg uses float during computation.\r\n\r\nThis seems to me like the correct fix.\r\n\r\n@dotnet/jit-contrib @dotnet/arm64-contrib ","created_at":"2017-11-03T20:03:10Z","updated_at":"2017-11-07T21:13:31Z","closed_at":"2017-11-07T21:13:31Z","merged_at":"2017-11-07T21:13:31Z","merge_commit_sha":"1ae7e5c63e1cbd6f08f3a4c9c7b2beb5c863bbba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14853/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14853/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/14853/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/755d2667ac03716f88d5207760a493572bc56848","head":{"label":"sdmaclea:PR-ARM64-SIMD-applyCalleeSaveHeuristics","ref":"PR-ARM64-SIMD-applyCalleeSaveHeuristics","sha":"755d2667ac03716f88d5207760a493572bc56848","user":{"login":"sdmaclea","id":25674984,"avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false},"repo":{"id":81508412,"name":"coreclr","full_name":"sdmaclea/coreclr","owner":{"login":"sdmaclea","id":25674984,"avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdmaclea/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/sdmaclea/coreclr","forks_url":"https://api.github.com/repos/sdmaclea/coreclr/forks","keys_url":"https://api.github.com/repos/sdmaclea/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdmaclea/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdmaclea/coreclr/teams","hooks_url":"https://api.github.com/repos/sdmaclea/coreclr/hooks","issue_events_url":"https://api.github.com/repos/sdmaclea/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/sdmaclea/coreclr/events","assignees_url":"https://api.github.com/repos/sdmaclea/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/sdmaclea/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/sdmaclea/coreclr/tags","blobs_url":"https://api.github.com/repos/sdmaclea/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdmaclea/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdmaclea/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdmaclea/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdmaclea/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/sdmaclea/coreclr/languages","stargazers_url":"https://api.github.com/repos/sdmaclea/coreclr/stargazers","contributors_url":"https://api.github.com/repos/sdmaclea/coreclr/contributors","subscribers_url":"https://api.github.com/repos/sdmaclea/coreclr/subscribers","subscription_url":"https://api.github.com/repos/sdmaclea/coreclr/subscription","commits_url":"https://api.github.com/repos/sdmaclea/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdmaclea/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdmaclea/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdmaclea/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdmaclea/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/sdmaclea/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdmaclea/coreclr/merges","archive_url":"https://api.github.com/repos/sdmaclea/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdmaclea/coreclr/downloads","issues_url":"https://api.github.com/repos/sdmaclea/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/sdmaclea/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/sdmaclea/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/sdmaclea/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdmaclea/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/sdmaclea/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/sdmaclea/coreclr/deployments","created_at":"2017-02-10T00:20:20Z","updated_at":"2017-09-07T23:20:39Z","pushed_at":"2017-11-07T20:52:50Z","git_url":"git://github.com/sdmaclea/coreclr.git","ssh_url":"git@github.com:sdmaclea/coreclr.git","clone_url":"https://github.com/sdmaclea/coreclr.git","svn_url":"https://github.com/sdmaclea/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":190209,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7182f42a66fd30544c1a967ddd7e2297e33bbaae","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-11-07T16:57:03Z","pushed_at":"2017-11-07T21:13:31Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":192222,"stargazers_count":8572,"watchers_count":8572,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2147,"mirror_url":null,"archived":false,"open_issues_count":1473,"forks":2147,"open_issues":1473,"watchers":8572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14853"},"html":{"href":"https://github.com/dotnet/coreclr/pull/14853"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14853"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14853/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14853/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14853/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/755d2667ac03716f88d5207760a493572bc56848"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars1.githubusercontent.com/u/2973870?v=4","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"CarolEidt"}}