{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/comments/107011382","pull_request_review_id":27960802,"id":107011382,"diff_hunk":"@@ -333,56 +351,62 @@ private synchronized void syncAcl() {\n \t\t\twriteACL(esClient, roles, rolesMapping);\n \t\t} catch (Exception e) {\n \t\t\tlogger.error(\"Exception while syncing ACL with cache\", e);\n-\t\t}\n+        }finally {\n+            lock.unlock();\n+        }\n \t}\n \n \tprivate SearchGuardRoles readRolesACL(Client esClient) throws IOException {\n \t\tGetRequest getRequest = esClient.prepareGet(searchGuardIndex, SEARCHGUARD_ROLE_TYPE, SEARCHGUARD_CONFIG_ID)\n \t\t\t\t.setRefresh(true).request();\n \t\tGetResponse response = esClient.get(getRequest).actionGet(); // need to worry about timeout?\n+\t\tif(logger.isDebugEnabled()) {\n+\t\t    logger.debug(\"Read in roles {}\", XContentHelper.convertToJson(response.getSourceAsBytesRef(), true, true));\n+\t\t}\n \n-\t\tSearchGuardRoles roles = new SearchGuardRoles().load(response.getSource());\n-\t\tlogger.debug(\"Read in roles '{}'\", roles);\n-\t\treturn roles;\n+\t\treturn new SearchGuardRoles().load(response.getSource());\n \t}\n \n \tprivate SearchGuardRolesMapping readRolesMappingACL(Client esClient) throws IOException {\n \t\tGetRequest getRequest = esClient.prepareGet(searchGuardIndex, SEARCHGUARD_MAPPING_TYPE, SEARCHGUARD_CONFIG_ID)\n \t\t\t\t.setRefresh(true).request();\n \t\tGetResponse response = esClient.get(getRequest).actionGet(); // need to worry about timeout?\n+        if(logger.isDebugEnabled()) {","path":"src/main/java/io/fabric8/elasticsearch/plugin/acl/DynamicACLFilter.java","position":155,"original_position":157,"commit_id":"82a56ddafea79c5987eb29934519c1bf46a28b37","original_commit_id":"43cabf414538753a2a529a346e953d8b966104df","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars1.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"spaces for tabs. need lint job and formatting rules","created_at":"2017-03-20T20:44:05Z","updated_at":"2017-03-20T20:44:05Z","html_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68#discussion_r107011382","pull_request_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/comments/107011382"},"html":{"href":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68#discussion_r107011382"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68","id":111595489,"html_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68","diff_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68.diff","patch_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68.patch","issue_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/68","number":68,"state":"open","locked":false,"title":"bug 1431551. Node does not survive upgrade","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars1.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"This PR fixes:\r\n\r\n* Concurrency issues while seeding initial ACL\r\n* Deletes SG index on start up if exists\r\n* Adds state to seeding ACLs\r\n* Forces SG to load all ACL docs on write update\r\n* Updates debug logs to pretty print doc info","created_at":"2017-03-20T16:37:17Z","updated_at":"2017-03-20T20:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a5ac8647107ae0ae2fdb111f6f275b0dc220164","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68/commits","review_comments_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68/comments","review_comment_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/68/comments","statuses_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/statuses/82a56ddafea79c5987eb29934519c1bf46a28b37","head":{"label":"jcantrill:bz_1431551_node_not_survive_upgrade","ref":"bz_1431551_node_not_survive_upgrade","sha":"82a56ddafea79c5987eb29934519c1bf46a28b37","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars1.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"repo":{"id":41877967,"name":"openshift-elasticsearch-plugin","full_name":"jcantrill/openshift-elasticsearch-plugin","owner":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars1.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcantrill/openshift-elasticsearch-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin","forks_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/forks","keys_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/teams","hooks_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/hooks","issue_events_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/events","assignees_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/tags","blobs_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/languages","stargazers_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/stargazers","contributors_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/contributors","subscribers_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/subscribers","subscription_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/subscription","commits_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/merges","archive_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/downloads","issues_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jcantrill/openshift-elasticsearch-plugin/deployments","created_at":"2015-09-03T18:55:59Z","updated_at":"2017-02-24T17:03:32Z","pushed_at":"2017-03-20T20:12:57Z","git_url":"git://github.com/jcantrill/openshift-elasticsearch-plugin.git","ssh_url":"git@github.com:jcantrill/openshift-elasticsearch-plugin.git","clone_url":"https://github.com/jcantrill/openshift-elasticsearch-plugin.git","svn_url":"https://github.com/jcantrill/openshift-elasticsearch-plugin","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:2.4.1.x","ref":"2.4.1.x","sha":"8f9adfb95ae0fd52dc60c90ec557cfafad9b8adb","user":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars2.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":41058701,"name":"openshift-elasticsearch-plugin","full_name":"fabric8io/openshift-elasticsearch-plugin","owner":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars2.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin","forks_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/forks","keys_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/teams","hooks_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/events","assignees_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/tags","blobs_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/languages","stargazers_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/subscription","commits_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/merges","archive_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/downloads","issues_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/deployments","created_at":"2015-08-19T20:37:42Z","updated_at":"2017-02-03T22:32:40Z","pushed_at":"2017-03-20T20:12:58Z","git_url":"git://github.com/fabric8io/openshift-elasticsearch-plugin.git","ssh_url":"git@github.com:fabric8io/openshift-elasticsearch-plugin.git","clone_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin.git","svn_url":"https://github.com/fabric8io/openshift-elasticsearch-plugin","homepage":null,"size":507,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68"},"html":{"href":"https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/68"},"issue":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/68"},"comments":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/openshift-elasticsearch-plugin/statuses/82a56ddafea79c5987eb29934519c1bf46a28b37"}}}}
{"actor":{"display_login":"jcantrill"}}