{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/mayu/pulls/comments/153477455","pull_request_review_id":79487036,"id":153477455,"diff_hunk":"@@ -35,6 +35,7 @@ const (\n \tDefaultIgnitionTemplateSnippets string = \"./template_snippets/ignition\"\n \tDefaultDNSMasq                  string = \"/usr/sbin/dnsmasq\"\n \tDefaultImagesCacheDir           string = \"./images\"\n+\tDefaultFilesDir                 string = \"./files\"","path":"main.go","position":4,"original_position":4,"commit_id":"08046c001810ad32ca16a8d98d7e1dbe9a616946","original_commit_id":"71e462470a0dfc9f6e9463f7fa491188f4f562bb","user":{"login":"teemow","id":32488,"avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false},"body":"what about the old templates then? can you also remove `DefaultFirstStageScript` and `DefaultLastStageCloudconfig`?","created_at":"2017-11-28T12:29:30Z","updated_at":"2017-11-28T12:29:31Z","html_url":"https://github.com/giantswarm/mayu/pull/116#discussion_r153477455","pull_request_url":"https://api.github.com/repos/giantswarm/mayu/pulls/116","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/comments/153477455"},"html":{"href":"https://github.com/giantswarm/mayu/pull/116#discussion_r153477455"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/116"}},"in_reply_to_id":153291800},"pull_request":{"url":"https://api.github.com/repos/giantswarm/mayu/pulls/116","id":151909120,"html_url":"https://github.com/giantswarm/mayu/pull/116","diff_url":"https://github.com/giantswarm/mayu/pull/116.diff","patch_url":"https://github.com/giantswarm/mayu/pull/116.patch","issue_url":"https://api.github.com/repos/giantswarm/mayu/issues/116","number":116,"state":"open","locked":false,"title":"ignition-fire-up","user":{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"body":"Migrate mayu to ignition\r\ntowards: https://github.com/giantswarm/giantswarm/issues/2121\r\n\r\n\r\nchanges:\r\n* migrated cloudconfig to ignition\r\n* added filesManager (ignition does not support files in the ignition itself so we put them in separate files in dir `./files` and then load them via fileManager,  render the template values and encode with base64 into ignition)\r\n* ignition templates are in yaml but result ignition is json (yaml is easier to read)\r\n* removed 2 phase installation\r\n* removed dependency on `mayu-infopusher`, serial is fetched via ipxe script\r\n* tweaking hostname from random hash to machine ip (we can the use for better identification in k8s)\r\nthere are also few changes to g8s in hive configs - https://github.com/giantswarm/hive/pull/193\r\n\r\n I wanted to separate this changes with cleaning mayu from cloudconfig so its not too big PR.\r\nNext, follow up will remove all unused code and cloudconfig support.\r\n\r\n\r\nI need to update the docs for sure as there are few new things. But this make sense  when the cloudconfig stuff is removed.\r\n\r\n","created_at":"2017-11-10T13:36:47Z","updated_at":"2017-11-28T12:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a719f7152f1614841db5c2532ec1f0470f5270be","assignee":{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvix","id":7136358,"avatar_url":"https://avatars3.githubusercontent.com/u/7136358?v=4","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"teemow","id":32488,"avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false},{"login":"JosephSalisbury","id":297653,"avatar_url":"https://avatars1.githubusercontent.com/u/297653?v=4","gravatar_id":"","url":"https://api.github.com/users/JosephSalisbury","html_url":"https://github.com/JosephSalisbury","followers_url":"https://api.github.com/users/JosephSalisbury/followers","following_url":"https://api.github.com/users/JosephSalisbury/following{/other_user}","gists_url":"https://api.github.com/users/JosephSalisbury/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSalisbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSalisbury/subscriptions","organizations_url":"https://api.github.com/users/JosephSalisbury/orgs","repos_url":"https://api.github.com/users/JosephSalisbury/repos","events_url":"https://api.github.com/users/JosephSalisbury/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSalisbury/received_events","type":"User","site_admin":false},{"login":"corest","id":1071648,"avatar_url":"https://avatars1.githubusercontent.com/u/1071648?v=4","gravatar_id":"","url":"https://api.github.com/users/corest","html_url":"https://github.com/corest","followers_url":"https://api.github.com/users/corest/followers","following_url":"https://api.github.com/users/corest/following{/other_user}","gists_url":"https://api.github.com/users/corest/gists{/gist_id}","starred_url":"https://api.github.com/users/corest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corest/subscriptions","organizations_url":"https://api.github.com/users/corest/orgs","repos_url":"https://api.github.com/users/corest/repos","events_url":"https://api.github.com/users/corest/events{/privacy}","received_events_url":"https://api.github.com/users/corest/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/mayu/pulls/116/commits","review_comments_url":"https://api.github.com/repos/giantswarm/mayu/pulls/116/comments","review_comment_url":"https://api.github.com/repos/giantswarm/mayu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/mayu/issues/116/comments","statuses_url":"https://api.github.com/repos/giantswarm/mayu/statuses/08046c001810ad32ca16a8d98d7e1dbe9a616946","head":{"label":"giantswarm:ignition-fire-up","ref":"ignition-fire-up","sha":"08046c001810ad32ca16a8d98d7e1dbe9a616946","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":50949948,"name":"mayu","full_name":"giantswarm/mayu","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/mayu","description":"Mayu helps you to provision a cluster of bare metal machines with CoreOS Container Linux","fork":false,"url":"https://api.github.com/repos/giantswarm/mayu","forks_url":"https://api.github.com/repos/giantswarm/mayu/forks","keys_url":"https://api.github.com/repos/giantswarm/mayu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/mayu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/mayu/teams","hooks_url":"https://api.github.com/repos/giantswarm/mayu/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/mayu/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/mayu/events","assignees_url":"https://api.github.com/repos/giantswarm/mayu/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/mayu/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/mayu/tags","blobs_url":"https://api.github.com/repos/giantswarm/mayu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/mayu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/mayu/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/mayu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/mayu/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/mayu/languages","stargazers_url":"https://api.github.com/repos/giantswarm/mayu/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/mayu/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/mayu/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/mayu/subscription","commits_url":"https://api.github.com/repos/giantswarm/mayu/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/mayu/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/mayu/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/mayu/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/mayu/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/mayu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/mayu/merges","archive_url":"https://api.github.com/repos/giantswarm/mayu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/mayu/downloads","issues_url":"https://api.github.com/repos/giantswarm/mayu/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/mayu/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/mayu/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/mayu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/mayu/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/mayu/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/mayu/deployments","created_at":"2016-02-02T20:34:37Z","updated_at":"2017-10-17T22:06:54Z","pushed_at":"2017-11-28T11:35:11Z","git_url":"git://github.com/giantswarm/mayu.git","ssh_url":"git@github.com:giantswarm/mayu.git","clone_url":"https://github.com/giantswarm/mayu.git","svn_url":"https://github.com/giantswarm/mayu","homepage":"","size":11124,"stargazers_count":89,"watchers_count":89,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":89,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"7213053ca253553c8cae83941e66ee8af28ef629","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":50949948,"name":"mayu","full_name":"giantswarm/mayu","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/mayu","description":"Mayu helps you to provision a cluster of bare metal machines with CoreOS Container Linux","fork":false,"url":"https://api.github.com/repos/giantswarm/mayu","forks_url":"https://api.github.com/repos/giantswarm/mayu/forks","keys_url":"https://api.github.com/repos/giantswarm/mayu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/mayu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/mayu/teams","hooks_url":"https://api.github.com/repos/giantswarm/mayu/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/mayu/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/mayu/events","assignees_url":"https://api.github.com/repos/giantswarm/mayu/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/mayu/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/mayu/tags","blobs_url":"https://api.github.com/repos/giantswarm/mayu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/mayu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/mayu/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/mayu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/mayu/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/mayu/languages","stargazers_url":"https://api.github.com/repos/giantswarm/mayu/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/mayu/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/mayu/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/mayu/subscription","commits_url":"https://api.github.com/repos/giantswarm/mayu/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/mayu/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/mayu/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/mayu/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/mayu/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/mayu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/mayu/merges","archive_url":"https://api.github.com/repos/giantswarm/mayu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/mayu/downloads","issues_url":"https://api.github.com/repos/giantswarm/mayu/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/mayu/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/mayu/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/mayu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/mayu/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/mayu/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/mayu/deployments","created_at":"2016-02-02T20:34:37Z","updated_at":"2017-10-17T22:06:54Z","pushed_at":"2017-11-28T11:35:11Z","git_url":"git://github.com/giantswarm/mayu.git","ssh_url":"git@github.com:giantswarm/mayu.git","clone_url":"https://github.com/giantswarm/mayu.git","svn_url":"https://github.com/giantswarm/mayu","homepage":"","size":11124,"stargazers_count":89,"watchers_count":89,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/116"},"html":{"href":"https://github.com/giantswarm/mayu/pull/116"},"issue":{"href":"https://api.github.com/repos/giantswarm/mayu/issues/116"},"comments":{"href":"https://api.github.com/repos/giantswarm/mayu/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/mayu/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/mayu/statuses/08046c001810ad32ca16a8d98d7e1dbe9a616946"}},"author_association":"OWNER"}}
{"actor":{"display_login":"teemow"}}