{"action":"created","comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/100300591","pull_request_review_id":21002638,"id":100300591,"diff_hunk":"@@ -0,0 +1,314 @@\n+// #sakai-rubrics-manager","path":"rubrics/services/src/main/webapp/sass/sakai-rubrics.scss","position":1,"original_position":1,"commit_id":"6d7e98f20cc8a9f3ca428b065e6c33a5d97a3351","original_commit_id":"6d7e98f20cc8a9f3ca428b065e6c33a5d97a3351","user":{"login":"bradszabo","id":231619,"avatar_url":"https://avatars.githubusercontent.com/u/231619?v=3","gravatar_id":"","url":"https://api.github.com/users/bradszabo","html_url":"https://github.com/bradszabo","followers_url":"https://api.github.com/users/bradszabo/followers","following_url":"https://api.github.com/users/bradszabo/following{/other_user}","gists_url":"https://api.github.com/users/bradszabo/gists{/gist_id}","starred_url":"https://api.github.com/users/bradszabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradszabo/subscriptions","organizations_url":"https://api.github.com/users/bradszabo/orgs","repos_url":"https://api.github.com/users/bradszabo/repos","events_url":"https://api.github.com/users/bradszabo/events{/privacy}","received_events_url":"https://api.github.com/users/bradszabo/received_events","type":"User","site_admin":false},"body":"Hi, Earl. We will have to discuss this as these styles are part of the [Web Components](https://www.webcomponents.org/), which are [intended to be encapsulated (HTML, CSS and JavaScript as a reusable unit)](https://developers.google.com/web/fundamentals/getting-started/primers/shadowdom). With [Shadow DOM](https://www.w3.org/TR/shadow-dom/) or [Shady DOM](https://www.polymer-project.org/1.0/blog/shadydom) the [components inherit some core theme styles from the container](https://www.webcomponents.org/specs#styling) but are meant provide component specific styles, and to not leak component specific styles to anything else on the page.\r\n\r\nThere may be parts of the styling that make sense to move into Morpheus, but in general, use of Shadow/Shady DOM with web components is a new paradigm that should slightly change the way styling is handled in Sakai. Central theme aspects will stay in Morpheus, but there should be a place for component specific styles to stay directly with the components, especially given that these components can and should be able to be used and rendered completely outside of Sakai. The Rubrics services as designed can actually integrate and work with any LMS platform that wants to add rubrics functionality. There are a few clean-up items, particularly in the view layer to make this a reality which were deferred given that this is targeted for Sakai, but it is not far off. Diego is scheduling a meeting and I am available tomorrow so we can discuss more at that point.","created_at":"2017-02-09T13:05:43Z","updated_at":"2017-02-09T13:05:43Z","html_url":"https://github.com/sakaiproject/sakai/pull/3883#discussion_r100300591","pull_request_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883","_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/100300591"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3883#discussion_r100300591"},"pull_request":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883"}}},"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883","id":105287386,"html_url":"https://github.com/sakaiproject/sakai/pull/3883","diff_url":"https://github.com/sakaiproject/sakai/pull/3883.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/3883.patch","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3883","number":3883,"state":"open","locked":false,"title":"SAK-32151 Sakai Rubrics initial support","user":{"login":"ddelblanco","id":5720144,"avatar_url":"https://avatars.githubusercontent.com/u/5720144?v=3","gravatar_id":"","url":"https://api.github.com/users/ddelblanco","html_url":"https://github.com/ddelblanco","followers_url":"https://api.github.com/users/ddelblanco/followers","following_url":"https://api.github.com/users/ddelblanco/following{/other_user}","gists_url":"https://api.github.com/users/ddelblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ddelblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddelblanco/subscriptions","organizations_url":"https://api.github.com/users/ddelblanco/orgs","repos_url":"https://api.github.com/users/ddelblanco/repos","events_url":"https://api.github.com/users/ddelblanco/events{/privacy}","received_events_url":"https://api.github.com/users/ddelblanco/received_events","type":"User","site_admin":false},"body":"Rubrics service, without the integration with assignments (see SAK 32152)\r\n\r\nRead the readme about information about architecture how to compile and configure.\r\n","created_at":"2017-02-08T19:31:03Z","updated_at":"2017-02-09T13:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ea8db89bab0382ffca85f6a0a0844c40d5687d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883/commits","review_comments_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883/comments","review_comment_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3883/comments","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/6d7e98f20cc8a9f3ca428b065e6c33a5d97a3351","head":{"label":"ddelblanco:SAK-32151","ref":"SAK-32151","sha":"6d7e98f20cc8a9f3ca428b065e6c33a5d97a3351","user":{"login":"ddelblanco","id":5720144,"avatar_url":"https://avatars.githubusercontent.com/u/5720144?v=3","gravatar_id":"","url":"https://api.github.com/users/ddelblanco","html_url":"https://github.com/ddelblanco","followers_url":"https://api.github.com/users/ddelblanco/followers","following_url":"https://api.github.com/users/ddelblanco/following{/other_user}","gists_url":"https://api.github.com/users/ddelblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ddelblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddelblanco/subscriptions","organizations_url":"https://api.github.com/users/ddelblanco/orgs","repos_url":"https://api.github.com/users/ddelblanco/repos","events_url":"https://api.github.com/users/ddelblanco/events{/privacy}","received_events_url":"https://api.github.com/users/ddelblanco/received_events","type":"User","site_admin":false},"repo":{"id":40727809,"name":"sakai","full_name":"ddelblanco/sakai","owner":{"login":"ddelblanco","id":5720144,"avatar_url":"https://avatars.githubusercontent.com/u/5720144?v=3","gravatar_id":"","url":"https://api.github.com/users/ddelblanco","html_url":"https://github.com/ddelblanco","followers_url":"https://api.github.com/users/ddelblanco/followers","following_url":"https://api.github.com/users/ddelblanco/following{/other_user}","gists_url":"https://api.github.com/users/ddelblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/ddelblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddelblanco/subscriptions","organizations_url":"https://api.github.com/users/ddelblanco/orgs","repos_url":"https://api.github.com/users/ddelblanco/repos","events_url":"https://api.github.com/users/ddelblanco/events{/privacy}","received_events_url":"https://api.github.com/users/ddelblanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddelblanco/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":true,"url":"https://api.github.com/repos/ddelblanco/sakai","forks_url":"https://api.github.com/repos/ddelblanco/sakai/forks","keys_url":"https://api.github.com/repos/ddelblanco/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddelblanco/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddelblanco/sakai/teams","hooks_url":"https://api.github.com/repos/ddelblanco/sakai/hooks","issue_events_url":"https://api.github.com/repos/ddelblanco/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/ddelblanco/sakai/events","assignees_url":"https://api.github.com/repos/ddelblanco/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/ddelblanco/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/ddelblanco/sakai/tags","blobs_url":"https://api.github.com/repos/ddelblanco/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddelblanco/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddelblanco/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddelblanco/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddelblanco/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/ddelblanco/sakai/languages","stargazers_url":"https://api.github.com/repos/ddelblanco/sakai/stargazers","contributors_url":"https://api.github.com/repos/ddelblanco/sakai/contributors","subscribers_url":"https://api.github.com/repos/ddelblanco/sakai/subscribers","subscription_url":"https://api.github.com/repos/ddelblanco/sakai/subscription","commits_url":"https://api.github.com/repos/ddelblanco/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddelblanco/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddelblanco/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddelblanco/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddelblanco/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/ddelblanco/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddelblanco/sakai/merges","archive_url":"https://api.github.com/repos/ddelblanco/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddelblanco/sakai/downloads","issues_url":"https://api.github.com/repos/ddelblanco/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/ddelblanco/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/ddelblanco/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/ddelblanco/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddelblanco/sakai/labels{/name}","releases_url":"https://api.github.com/repos/ddelblanco/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/ddelblanco/sakai/deployments","created_at":"2015-08-14T17:34:58Z","updated_at":"2016-01-11T16:38:14Z","pushed_at":"2017-02-08T19:12:55Z","git_url":"git://github.com/ddelblanco/sakai.git","ssh_url":"git@github.com:ddelblanco/sakai.git","clone_url":"https://github.com/ddelblanco/sakai.git","svn_url":"https://github.com/ddelblanco/sakai","homepage":"https://www.sakaiproject.org","size":314621,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sakaiproject:master","ref":"master","sha":"25cfae214e6d8ce746431e4d9491ea41e1ba2281","user":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"repo":{"id":28589709,"name":"sakai","full_name":"sakaiproject/sakai","owner":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sakaiproject/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":false,"url":"https://api.github.com/repos/sakaiproject/sakai","forks_url":"https://api.github.com/repos/sakaiproject/sakai/forks","keys_url":"https://api.github.com/repos/sakaiproject/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakaiproject/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakaiproject/sakai/teams","hooks_url":"https://api.github.com/repos/sakaiproject/sakai/hooks","issue_events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/sakaiproject/sakai/events","assignees_url":"https://api.github.com/repos/sakaiproject/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/sakaiproject/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/sakaiproject/sakai/tags","blobs_url":"https://api.github.com/repos/sakaiproject/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakaiproject/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakaiproject/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakaiproject/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/sakaiproject/sakai/languages","stargazers_url":"https://api.github.com/repos/sakaiproject/sakai/stargazers","contributors_url":"https://api.github.com/repos/sakaiproject/sakai/contributors","subscribers_url":"https://api.github.com/repos/sakaiproject/sakai/subscribers","subscription_url":"https://api.github.com/repos/sakaiproject/sakai/subscription","commits_url":"https://api.github.com/repos/sakaiproject/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakaiproject/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakaiproject/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/sakaiproject/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakaiproject/sakai/merges","archive_url":"https://api.github.com/repos/sakaiproject/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakaiproject/sakai/downloads","issues_url":"https://api.github.com/repos/sakaiproject/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/sakaiproject/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/sakaiproject/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/sakaiproject/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakaiproject/sakai/labels{/name}","releases_url":"https://api.github.com/repos/sakaiproject/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/sakaiproject/sakai/deployments","created_at":"2014-12-29T11:14:17Z","updated_at":"2017-02-09T04:43:09Z","pushed_at":"2017-02-09T11:49:08Z","git_url":"git://github.com/sakaiproject/sakai.git","ssh_url":"git@github.com:sakaiproject/sakai.git","clone_url":"https://github.com/sakaiproject/sakai.git","svn_url":"https://github.com/sakaiproject/sakai","homepage":"https://www.sakaiproject.org","size":320311,"stargazers_count":212,"watchers_count":212,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":353,"mirror_url":null,"open_issues_count":78,"forks":353,"open_issues":78,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3883"},"issue":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3883"},"comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3883/comments"},"review_comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883/comments"},"review_comment":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3883/commits"},"statuses":{"href":"https://api.github.com/repos/sakaiproject/sakai/statuses/6d7e98f20cc8a9f3ca428b065e6c33a5d97a3351"}}}}
{"actor":{"display_login":"bradszabo"}}