{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/1718","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/1718/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/1718/comments","events_url":"https://api.github.com/repos/istio/istio/issues/1718/events","html_url":"https://github.com/istio/istio/pull/1718","id":273920875,"number":1718,"title":"Increase security code coverage","user":{"login":"mangchiandjjoe","id":1411263,"avatar_url":"https://avatars0.githubusercontent.com/u/1411263?v=4","gravatar_id":"","url":"https://api.github.com/users/mangchiandjjoe","html_url":"https://github.com/mangchiandjjoe","followers_url":"https://api.github.com/users/mangchiandjjoe/followers","following_url":"https://api.github.com/users/mangchiandjjoe/following{/other_user}","gists_url":"https://api.github.com/users/mangchiandjjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mangchiandjjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangchiandjjoe/subscriptions","organizations_url":"https://api.github.com/users/mangchiandjjoe/orgs","repos_url":"https://api.github.com/users/mangchiandjjoe/repos","events_url":"https://api.github.com/users/mangchiandjjoe/events{/privacy}","received_events_url":"https://api.github.com/users/mangchiandjjoe/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":660558399,"url":"https://api.github.com/repos/istio/istio/labels/release-note-none","name":"release-note-none","color":"ededed","default":false},{"id":744786716,"url":"https://api.github.com/repos/istio/istio/labels/security","name":"security","color":"1a85a5","default":false}],"state":"open","locked":false,"assignee":{"login":"myidpt","id":102881,"avatar_url":"https://avatars2.githubusercontent.com/u/102881?v=4","gravatar_id":"","url":"https://api.github.com/users/myidpt","html_url":"https://github.com/myidpt","followers_url":"https://api.github.com/users/myidpt/followers","following_url":"https://api.github.com/users/myidpt/following{/other_user}","gists_url":"https://api.github.com/users/myidpt/gists{/gist_id}","starred_url":"https://api.github.com/users/myidpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myidpt/subscriptions","organizations_url":"https://api.github.com/users/myidpt/orgs","repos_url":"https://api.github.com/users/myidpt/repos","events_url":"https://api.github.com/users/myidpt/events{/privacy}","received_events_url":"https://api.github.com/users/myidpt/received_events","type":"User","site_admin":false},"assignees":[{"login":"myidpt","id":102881,"avatar_url":"https://avatars2.githubusercontent.com/u/102881?v=4","gravatar_id":"","url":"https://api.github.com/users/myidpt","html_url":"https://github.com/myidpt","followers_url":"https://api.github.com/users/myidpt/followers","following_url":"https://api.github.com/users/myidpt/following{/other_user}","gists_url":"https://api.github.com/users/myidpt/gists{/gist_id}","starred_url":"https://api.github.com/users/myidpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myidpt/subscriptions","organizations_url":"https://api.github.com/users/myidpt/orgs","repos_url":"https://api.github.com/users/myidpt/repos","events_url":"https://api.github.com/users/myidpt/events{/privacy}","received_events_url":"https://api.github.com/users/myidpt/received_events","type":"User","site_admin":false},{"login":"wattli","id":24381542,"avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-11-14T19:51:58Z","updated_at":"2017-11-15T00:29:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1718","html_url":"https://github.com/istio/istio/pull/1718","diff_url":"https://github.com/istio/istio/pull/1718.diff","patch_url":"https://github.com/istio/istio/pull/1718.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/344446447","html_url":"https://github.com/istio/istio/pull/1718#issuecomment-344446447","issue_url":"https://api.github.com/repos/istio/istio/issues/1718","id":344446447,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T00:29:48Z","updated_at":"2017-11-15T00:29:48Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=h1) Report\n> Merging [#1718](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=desc) into [master](https://codecov.io/gh/istio/istio/commit/58a96fc2bc1e2d2fa0dac2423aa461b25ac3ed10?src=pr&el=desc) will **increase** coverage by `0.63%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/1718/graphs/tree.svg?width=650&token=nYtepj7fDQ&height=150&src=pr)](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1718      +/-   ##\n==========================================\n+ Coverage   79.83%   80.46%   +0.63%     \n==========================================\n  Files         208      208              \n  Lines       21072    21072              \n==========================================\n+ Hits        16822    16955     +133     \n+ Misses       3758     3617     -141     \n- Partials      492      500       +8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [security/pkg/pki/ca/generate\\_cert.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3BraS9jYS9nZW5lcmF0ZV9jZXJ0Lmdv) | `88.97% <100%> (+13.23%)` | :arrow_up: |\n| [pilot/platform/eureka/controller.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-cGlsb3QvcGxhdGZvcm0vZXVyZWthL2NvbnRyb2xsZXIuZ28=) | `85% <0%> (-7.5%)` | :arrow_down: |\n| [security/pkg/server/grpc/authenticator.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3NlcnZlci9ncnBjL2F1dGhlbnRpY2F0b3IuZ28=) | `58.92% <0%> (+7.14%)` | :arrow_up: |\n| [security/pkg/platform/onprem.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3BsYXRmb3JtL29ucHJlbS5nbw==) | `84.74% <0%> (+10.16%)` | :arrow_up: |\n| [security/pkg/platform/aws.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3BsYXRmb3JtL2F3cy5nbw==) | `58% <0%> (+40%)` | :arrow_up: |\n| [security/pkg/server/grpc/server.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3NlcnZlci9ncnBjL3NlcnZlci5nbw==) | `76.42% <0%> (+44.71%)` | :arrow_up: |\n| [security/pkg/platform/gcp.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3BsYXRmb3JtL2djcC5nbw==) | `94.59% <0%> (+62.16%)` | :arrow_up: |\n| [security/pkg/platform/client.go](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=tree#diff-c2VjdXJpdHkvcGtnL3BsYXRmb3JtL2NsaWVudC5nbw==) | `100% <0%> (+100%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=footer). Last update [58a96fc...f926324](https://codecov.io/gh/istio/istio/pull/1718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}