{"action":"closed","number":46163,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163","id":121616507,"html_url":"https://github.com/kubernetes/kubernetes/pull/46163","diff_url":"https://github.com/kubernetes/kubernetes/pull/46163.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/46163.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46163","number":46163,"state":"closed","locked":false,"title":"Display <none> for kubectl describe secret when type is empty.","user":{"login":"zhangxiaoyu-zidif","id":5154334,"avatar_url":"https://avatars2.githubusercontent.com/u/5154334?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangxiaoyu-zidif","html_url":"https://github.com/zhangxiaoyu-zidif","followers_url":"https://api.github.com/users/zhangxiaoyu-zidif/followers","following_url":"https://api.github.com/users/zhangxiaoyu-zidif/following{/other_user}","gists_url":"https://api.github.com/users/zhangxiaoyu-zidif/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxiaoyu-zidif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxiaoyu-zidif/subscriptions","organizations_url":"https://api.github.com/users/zhangxiaoyu-zidif/orgs","repos_url":"https://api.github.com/users/zhangxiaoyu-zidif/repos","events_url":"https://api.github.com/users/zhangxiaoyu-zidif/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxiaoyu-zidif/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nwhen describe secret, if its type is null, it is better to show <none>\r\n\r\n**Special notes for your reviewer**:\r\nRefer to #45788\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-05-20T08:54:51Z","updated_at":"2017-05-31T21:46:27Z","closed_at":"2017-05-31T21:46:27Z","merged_at":null,"merge_commit_sha":"54cb0fab79b2c7b28040f9bf527b3d81f530ca0c","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars3.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars3.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46163/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/729d43052b3ffc31008b38a0de808e50d4e12b1c","head":{"label":"zhangxiaoyu-zidif:modify-describe-secret","ref":"modify-describe-secret","sha":"729d43052b3ffc31008b38a0de808e50d4e12b1c","user":{"login":"zhangxiaoyu-zidif","id":5154334,"avatar_url":"https://avatars2.githubusercontent.com/u/5154334?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangxiaoyu-zidif","html_url":"https://github.com/zhangxiaoyu-zidif","followers_url":"https://api.github.com/users/zhangxiaoyu-zidif/followers","following_url":"https://api.github.com/users/zhangxiaoyu-zidif/following{/other_user}","gists_url":"https://api.github.com/users/zhangxiaoyu-zidif/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxiaoyu-zidif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxiaoyu-zidif/subscriptions","organizations_url":"https://api.github.com/users/zhangxiaoyu-zidif/orgs","repos_url":"https://api.github.com/users/zhangxiaoyu-zidif/repos","events_url":"https://api.github.com/users/zhangxiaoyu-zidif/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxiaoyu-zidif/received_events","type":"User","site_admin":false},"repo":{"id":86646032,"name":"kubernetes","full_name":"zhangxiaoyu-zidif/kubernetes","owner":{"login":"zhangxiaoyu-zidif","id":5154334,"avatar_url":"https://avatars2.githubusercontent.com/u/5154334?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangxiaoyu-zidif","html_url":"https://github.com/zhangxiaoyu-zidif","followers_url":"https://api.github.com/users/zhangxiaoyu-zidif/followers","following_url":"https://api.github.com/users/zhangxiaoyu-zidif/following{/other_user}","gists_url":"https://api.github.com/users/zhangxiaoyu-zidif/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxiaoyu-zidif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxiaoyu-zidif/subscriptions","organizations_url":"https://api.github.com/users/zhangxiaoyu-zidif/orgs","repos_url":"https://api.github.com/users/zhangxiaoyu-zidif/repos","events_url":"https://api.github.com/users/zhangxiaoyu-zidif/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxiaoyu-zidif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhangxiaoyu-zidif/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes","forks_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/forks","keys_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/teams","hooks_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/events","assignees_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/tags","blobs_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/languages","stargazers_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/subscription","commits_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/merges","archive_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/downloads","issues_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/zhangxiaoyu-zidif/kubernetes/deployments","created_at":"2017-03-30T01:37:19Z","updated_at":"2017-03-30T01:37:52Z","pushed_at":"2017-05-31T07:52:36Z","git_url":"git://github.com/zhangxiaoyu-zidif/kubernetes.git","ssh_url":"git@github.com:zhangxiaoyu-zidif/kubernetes.git","clone_url":"https://github.com/zhangxiaoyu-zidif/kubernetes.git","svn_url":"https://github.com/zhangxiaoyu-zidif/kubernetes","homepage":"http://kubernetes.io","size":437330,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"03495f12c305c8016e00090adf55ea3c38979e87","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-05-31T21:13:33Z","pushed_at":"2017-05-31T21:46:06Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":654521,"stargazers_count":23609,"watchers_count":23609,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8351,"mirror_url":null,"open_issues_count":5476,"forks":8351,"open_issues":5476,"watchers":23609,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46163"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46163"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46163/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46163/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/729d43052b3ffc31008b38a0de808e50d4e12b1c"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":10,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zhangxiaoyu-zidif"}}