{"action":"created","comment":{"url":"https://api.github.com/repos/google/keytransparency/pulls/comments/157197374","pull_request_review_id":83804214,"id":157197374,"diff_hunk":"@@ -173,15 +178,21 @@ func TestLowestSequenceNumber(t *testing.T) {\n \t\t{\"4\", 0, 4, true},\n \t\t{\"4\", 1, 4, true},\n \t\t{\"some_token\", 0, 0, false},\n-\t\t{\"\", 1, 6, true},\n+\t\t{\"\", 2, 6, true},","path":"core/keyserver/epochs_test.go","position":81,"original_position":81,"commit_id":"1c7b90e5ef7eba4beecaa30cfecc1d937af36147","original_commit_id":"dc5f075b4a6a529d5b1693587a9c2e88ba88b8fe","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"I'm not sure what the previous code was doing, but 2 seems like the correct number for the following reasons: \r\n- The test setup prepares two epochs:\r\n   - Epoch 1 with a highest sequenced value of 6\r\n   - Epoch 2 with a highest sequenced value of 10\r\n- When asking for the mutations associated with epoch 2, and no `page_token`, we should start with 6 and go to 10.  ","created_at":"2017-12-15T13:13:35Z","updated_at":"2017-12-15T13:13:36Z","html_url":"https://github.com/google/keytransparency/pull/882#discussion_r157197374","pull_request_url":"https://api.github.com/repos/google/keytransparency/pulls/882","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments/157197374"},"html":{"href":"https://github.com/google/keytransparency/pull/882#discussion_r157197374"},"pull_request":{"href":"https://api.github.com/repos/google/keytransparency/pulls/882"}},"in_reply_to_id":157190980},"pull_request":{"url":"https://api.github.com/repos/google/keytransparency/pulls/882","id":157722595,"html_url":"https://github.com/google/keytransparency/pull/882","diff_url":"https://github.com/google/keytransparency/pull/882.diff","patch_url":"https://github.com/google/keytransparency/pull/882.patch","issue_url":"https://api.github.com/repos/google/keytransparency/issues/882","number":882,"state":"open","locked":false,"title":"Split GetMutations API into GetEpoch and ListMutations ","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"Merge #887 and #888 First \r\n\r\nThis PR splits the `GetMutations` endpoint into `GetEpoch` and `ListMutations`. \r\n\r\nThe previous design combined epoch objects, and their various proofs, with mutations and their proofs, making it difficult to determine sane pagination points, and reusable code blocks. \r\n\r\nThis PR separates the two entities into separate API end points, per API style. \r\n- `GetEpoch` can now be cleanly iterated over\r\n   - It also has a small streaming RPC for faster notification of new epochs.\r\n   - It could also make a natural gossip reply endpoint in the future.\r\n- `ListMutations` can now be cleanly iterated over without duplicating epoch information\r\n   - It can now handle very large diffs between epochs.  \r\n   - And it gets it's own streaming RPC too. \r\n\r\nAs a result of these changes, the monitoring code processing diffs between epochs can be broken up and simplified into:\r\n1. Waiting for new epochs to arrive\r\n2. Grouping new epochs into pairs\r\n3. Fetching mutations\r\n4. Verifying the difference between each epoch pair. \r\n","created_at":"2017-12-12T02:33:37Z","updated_at":"2017-12-15T13:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"987f0e3569b192ba4aa7f8c12af191878857e803","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cesarghali","id":1832622,"avatar_url":"https://avatars2.githubusercontent.com/u/1832622?v=4","gravatar_id":"","url":"https://api.github.com/users/cesarghali","html_url":"https://github.com/cesarghali","followers_url":"https://api.github.com/users/cesarghali/followers","following_url":"https://api.github.com/users/cesarghali/following{/other_user}","gists_url":"https://api.github.com/users/cesarghali/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarghali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarghali/subscriptions","organizations_url":"https://api.github.com/users/cesarghali/orgs","repos_url":"https://api.github.com/users/cesarghali/repos","events_url":"https://api.github.com/users/cesarghali/events{/privacy}","received_events_url":"https://api.github.com/users/cesarghali/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/keytransparency/pulls/882/commits","review_comments_url":"https://api.github.com/repos/google/keytransparency/pulls/882/comments","review_comment_url":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/keytransparency/issues/882/comments","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/1c7b90e5ef7eba4beecaa30cfecc1d937af36147","head":{"label":"gdbelvin:api/sequencer","ref":"api/sequencer","sha":"1c7b90e5ef7eba4beecaa30cfecc1d937af36147","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79116210,"name":"keytransparency","full_name":"gdbelvin/keytransparency","owner":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/keytransparency","description":"A transparent and secure way to look up public keys.","fork":true,"url":"https://api.github.com/repos/gdbelvin/keytransparency","forks_url":"https://api.github.com/repos/gdbelvin/keytransparency/forks","keys_url":"https://api.github.com/repos/gdbelvin/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/keytransparency/teams","hooks_url":"https://api.github.com/repos/gdbelvin/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/keytransparency/events","assignees_url":"https://api.github.com/repos/gdbelvin/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/tags","blobs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/keytransparency/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscription","commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/keytransparency/merges","archive_url":"https://api.github.com/repos/gdbelvin/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/keytransparency/downloads","issues_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/keytransparency/deployments","created_at":"2017-01-16T12:28:44Z","updated_at":"2017-01-18T13:41:50Z","pushed_at":"2017-12-15T12:45:52Z","git_url":"git://github.com/gdbelvin/keytransparency.git","ssh_url":"git@github.com:gdbelvin/keytransparency.git","clone_url":"https://github.com/gdbelvin/keytransparency.git","svn_url":"https://github.com/gdbelvin/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":24494,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"cdda5222a3cc807edee48cd9fab73df9b2e1a238","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37165115,"name":"keytransparency","full_name":"google/keytransparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/keytransparency","description":"A transparent and secure way to look up public keys.","fork":false,"url":"https://api.github.com/repos/google/keytransparency","forks_url":"https://api.github.com/repos/google/keytransparency/forks","keys_url":"https://api.github.com/repos/google/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/keytransparency/teams","hooks_url":"https://api.github.com/repos/google/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/google/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/keytransparency/events","assignees_url":"https://api.github.com/repos/google/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/keytransparency/tags","blobs_url":"https://api.github.com/repos/google/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/keytransparency/languages","stargazers_url":"https://api.github.com/repos/google/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/google/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/google/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/google/keytransparency/subscription","commits_url":"https://api.github.com/repos/google/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/keytransparency/merges","archive_url":"https://api.github.com/repos/google/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/keytransparency/downloads","issues_url":"https://api.github.com/repos/google/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/google/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/keytransparency/deployments","created_at":"2015-06-09T23:55:20Z","updated_at":"2017-12-14T04:36:24Z","pushed_at":"2017-12-15T12:45:53Z","git_url":"git://github.com/google/keytransparency.git","ssh_url":"git@github.com:google/keytransparency.git","clone_url":"https://github.com/google/keytransparency.git","svn_url":"https://github.com/google/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":22957,"stargazers_count":1197,"watchers_count":1197,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":85,"open_issues":59,"watchers":1197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/882"},"html":{"href":"https://github.com/google/keytransparency/pull/882"},"issue":{"href":"https://api.github.com/repos/google/keytransparency/issues/882"},"comments":{"href":"https://api.github.com/repos/google/keytransparency/issues/882/comments"},"review_comments":{"href":"https://api.github.com/repos/google/keytransparency/pulls/882/comments"},"review_comment":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/keytransparency/pulls/882/commits"},"statuses":{"href":"https://api.github.com/repos/google/keytransparency/statuses/1c7b90e5ef7eba4beecaa30cfecc1d937af36147"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gdbelvin"}}