{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/15366","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/15366/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/15366/comments","events_url":"https://api.github.com/repos/servo/servo/issues/15366/events","html_url":"https://github.com/servo/servo/pull/15366","id":205119650,"number":15366,"title":"Remove the 29 byte limitation, when requesting bluetooth devices","user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars.githubusercontent.com/u/11725775?v=3","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"labels":[{"id":152310014,"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"assignees":[{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-02-03T10:21:13Z","updated_at":"2017-02-03T11:54:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/15366","html_url":"https://github.com/servo/servo/pull/15366","diff_url":"https://github.com/servo/servo/pull/15366.diff","patch_url":"https://github.com/servo/servo/pull/15366.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nRemove the 29 byte limit when calling `requestDevice` using a `name` or `namePrefix`. The following discussion is about this by the specification writers: https://bugs.chromium.org/p/chromium/issues/detail?id=653718.\r\nRelated tests also got removed.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] There are tests for these changes\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/15366)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/277230284","html_url":"https://github.com/servo/servo/pull/15366#issuecomment-277230284","issue_url":"https://api.github.com/repos/servo/servo/issues/15366","id":277230284,"user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars.githubusercontent.com/u/11725775?v=3","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"created_at":"2017-02-03T11:54:31Z","updated_at":"2017-02-03T11:54:31Z","body":"The 248 limit is also in the current implementation [here](https://github.com/servo/servo/pull/15366/files#diff-c46adaa4a07505ce292afa8642267f23L42) and used as you quoted. The 29 byte limit was not a part of the specification, but when we ported chrome tests, we discovered they use it and we put this check in our code too. We fired an [issue](https://github.com/WebBluetoothCG/web-bluetooth/issues/296), to move this limit in the specification. Meanwhile it turned out we don't need this anymore, this is what the linked conversation about. "}}
{"actor":{"display_login":"zakorgy"}}