{"action":"created","issue":{"url":"https://api.github.com/repos/zero-os/0-Disk/issues/240","repository_url":"https://api.github.com/repos/zero-os/0-Disk","labels_url":"https://api.github.com/repos/zero-os/0-Disk/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/zero-os/0-Disk/issues/240/comments","events_url":"https://api.github.com/repos/zero-os/0-Disk/issues/240/events","html_url":"https://github.com/zero-os/0-Disk/pull/240","id":233499959,"number":240,"title":"nbdserver tlogStorage : `go test -race` fixes","user":{"login":"iwanbk","id":977552,"avatar_url":"https://avatars2.githubusercontent.com/u/977552?v=3","gravatar_id":"","url":"https://api.github.com/users/iwanbk","html_url":"https://github.com/iwanbk","followers_url":"https://api.github.com/users/iwanbk/followers","following_url":"https://api.github.com/users/iwanbk/following{/other_user}","gists_url":"https://api.github.com/users/iwanbk/gists{/gist_id}","starred_url":"https://api.github.com/users/iwanbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwanbk/subscriptions","organizations_url":"https://api.github.com/users/iwanbk/orgs","repos_url":"https://api.github.com/users/iwanbk/repos","events_url":"https://api.github.com/users/iwanbk/events{/privacy}","received_events_url":"https://api.github.com/users/iwanbk/received_events","type":"User","site_admin":false},"labels":[{"id":540951216,"url":"https://api.github.com/repos/zero-os/0-Disk/labels/state_inprogress","name":"state_inprogress","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"GlenDC","id":3900482,"avatar_url":"https://avatars1.githubusercontent.com/u/3900482?v=3","gravatar_id":"","url":"https://api.github.com/users/GlenDC","html_url":"https://github.com/GlenDC","followers_url":"https://api.github.com/users/GlenDC/followers","following_url":"https://api.github.com/users/GlenDC/following{/other_user}","gists_url":"https://api.github.com/users/GlenDC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenDC/subscriptions","organizations_url":"https://api.github.com/users/GlenDC/orgs","repos_url":"https://api.github.com/users/GlenDC/repos","events_url":"https://api.github.com/users/GlenDC/events{/privacy}","received_events_url":"https://api.github.com/users/GlenDC/received_events","type":"User","site_admin":false},"assignees":[{"login":"GlenDC","id":3900482,"avatar_url":"https://avatars1.githubusercontent.com/u/3900482?v=3","gravatar_id":"","url":"https://api.github.com/users/GlenDC","html_url":"https://github.com/GlenDC","followers_url":"https://api.github.com/users/GlenDC/followers","following_url":"https://api.github.com/users/GlenDC/following{/other_user}","gists_url":"https://api.github.com/users/GlenDC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenDC/subscriptions","organizations_url":"https://api.github.com/users/GlenDC/orgs","repos_url":"https://api.github.com/users/GlenDC/repos","events_url":"https://api.github.com/users/GlenDC/events{/privacy}","received_events_url":"https://api.github.com/users/GlenDC/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-06-05T05:49:29Z","updated_at":"2017-06-05T18:04:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zero-os/0-Disk/pulls/240","html_url":"https://github.com/zero-os/0-Disk/pull/240","diff_url":"https://github.com/zero-os/0-Disk/pull/240.diff","patch_url":"https://github.com/zero-os/0-Disk/pull/240.patch"},"body":"part of #239 "},"comment":{"url":"https://api.github.com/repos/zero-os/0-Disk/issues/comments/306260035","html_url":"https://github.com/zero-os/0-Disk/pull/240#issuecomment-306260035","issue_url":"https://api.github.com/repos/zero-os/0-Disk/issues/240","id":306260035,"user":{"login":"GlenDC","id":3900482,"avatar_url":"https://avatars1.githubusercontent.com/u/3900482?v=3","gravatar_id":"","url":"https://api.github.com/users/GlenDC","html_url":"https://github.com/GlenDC","followers_url":"https://api.github.com/users/GlenDC/followers","following_url":"https://api.github.com/users/GlenDC/following{/other_user}","gists_url":"https://api.github.com/users/GlenDC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenDC/subscriptions","organizations_url":"https://api.github.com/users/GlenDC/orgs","repos_url":"https://api.github.com/users/GlenDC/repos","events_url":"https://api.github.com/users/GlenDC/events{/privacy}","received_events_url":"https://api.github.com/users/GlenDC/received_events","type":"User","site_admin":false},"created_at":"2017-06-05T18:04:44Z","updated_at":"2017-06-05T18:04:44Z","body":"Seems that this is only ever an issue when running `testEndToEndReplay`, which somehow gets killed due to: `signal: killed`, ONLY when you run that test with the `-race` flag.\r\n\r\n> see: https://travis-ci.org/zero-os/0-Disk/builds/239664773\r\n\r\nSo I don't think this is an issue on our side, and more to do with limitations on the travis machine, as doing a `-race` test on an EndToEnd test is probably very heavy.\r\n\r\nTherefore I added the `-race` tests now as a seperate Make target, called `testrace`, which only runs on the `gonbdserver`, `nbdserver`, and `tlog` modules, using pure go. This should be good enough for now. It's certainly better then before, which wasn't running at all."}}
{"actor":{"display_login":"GlenDC"}}