{"action":"created","comment":{"url":"https://api.github.com/repos/dunst-project/dunst/pulls/comments/148924080","pull_request_review_id":74248093,"id":148924080,"diff_hunk":"@@ -183,30 +183,29 @@ int queues_notification_close_id(int id, int reason)\n {\n         notification *target = NULL;\n \n-        for (GList *iter = g_queue_peek_head_link(displayed); iter;\n+        for (GList *iter = g_queue_peek_head_link(displayed);\n+             iter && !target;","path":"src/queues.c","position":6,"original_position":6,"commit_id":"705a1a0fd4eb208d59e01e8cf74b57534aaf4f90","original_commit_id":"705a1a0fd4eb208d59e01e8cf74b57534aaf4f90","user":{"login":"tsipinakis","id":18189112,"avatar_url":"https://avatars2.githubusercontent.com/u/18189112?v=4","gravatar_id":"","url":"https://api.github.com/users/tsipinakis","html_url":"https://github.com/tsipinakis","followers_url":"https://api.github.com/users/tsipinakis/followers","following_url":"https://api.github.com/users/tsipinakis/following{/other_user}","gists_url":"https://api.github.com/users/tsipinakis/gists{/gist_id}","starred_url":"https://api.github.com/users/tsipinakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsipinakis/subscriptions","organizations_url":"https://api.github.com/users/tsipinakis/orgs","repos_url":"https://api.github.com/users/tsipinakis/repos","events_url":"https://api.github.com/users/tsipinakis/events{/privacy}","received_events_url":"https://api.github.com/users/tsipinakis/received_events","type":"User","site_admin":false},"body":"What's the point of this change? All it's doing it adding a bit of overhead because now we have to check `target` on each iteration and hurts readability.","created_at":"2017-11-04T06:13:45Z","updated_at":"2017-11-04T06:16:07Z","html_url":"https://github.com/dunst-project/dunst/pull/425#discussion_r148924080","pull_request_url":"https://api.github.com/repos/dunst-project/dunst/pulls/425","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/comments/148924080"},"html":{"href":"https://github.com/dunst-project/dunst/pull/425#discussion_r148924080"},"pull_request":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/dunst-project/dunst/pulls/425","id":149766487,"html_url":"https://github.com/dunst-project/dunst/pull/425","diff_url":"https://github.com/dunst-project/dunst/pull/425.diff","patch_url":"https://github.com/dunst-project/dunst/pull/425.patch","issue_url":"https://api.github.com/repos/dunst-project/dunst/issues/425","number":425,"state":"open","locked":false,"title":"Free notifications ignored in history","user":{"login":"bebehei","id":2073458,"avatar_url":"https://avatars1.githubusercontent.com/u/2073458?v=4","gravatar_id":"","url":"https://api.github.com/users/bebehei","html_url":"https://github.com/bebehei","followers_url":"https://api.github.com/users/bebehei/followers","following_url":"https://api.github.com/users/bebehei/following{/other_user}","gists_url":"https://api.github.com/users/bebehei/gists{/gist_id}","starred_url":"https://api.github.com/users/bebehei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebehei/subscriptions","organizations_url":"https://api.github.com/users/bebehei/orgs","repos_url":"https://api.github.com/users/bebehei/repos","events_url":"https://api.github.com/users/bebehei/events{/privacy}","received_events_url":"https://api.github.com/users/bebehei/received_events","type":"User","site_admin":false},"body":"Notifications marked with `history_ignore = 1` (and therefore transient ones too) are currently never freed.","created_at":"2017-10-31T12:03:05Z","updated_at":"2017-11-04T06:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31bc330267e7adb2a399fdb2596e43a93d720c3f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dunst-project/dunst/pulls/425/commits","review_comments_url":"https://api.github.com/repos/dunst-project/dunst/pulls/425/comments","review_comment_url":"https://api.github.com/repos/dunst-project/dunst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dunst-project/dunst/issues/425/comments","statuses_url":"https://api.github.com/repos/dunst-project/dunst/statuses/705a1a0fd4eb208d59e01e8cf74b57534aaf4f90","head":{"label":"bebehei:memory-leak_history-ignore","ref":"memory-leak_history-ignore","sha":"705a1a0fd4eb208d59e01e8cf74b57534aaf4f90","user":{"login":"bebehei","id":2073458,"avatar_url":"https://avatars1.githubusercontent.com/u/2073458?v=4","gravatar_id":"","url":"https://api.github.com/users/bebehei","html_url":"https://github.com/bebehei","followers_url":"https://api.github.com/users/bebehei/followers","following_url":"https://api.github.com/users/bebehei/following{/other_user}","gists_url":"https://api.github.com/users/bebehei/gists{/gist_id}","starred_url":"https://api.github.com/users/bebehei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebehei/subscriptions","organizations_url":"https://api.github.com/users/bebehei/orgs","repos_url":"https://api.github.com/users/bebehei/repos","events_url":"https://api.github.com/users/bebehei/events{/privacy}","received_events_url":"https://api.github.com/users/bebehei/received_events","type":"User","site_admin":false},"repo":{"id":96532167,"name":"dunst","full_name":"bebehei/dunst","owner":{"login":"bebehei","id":2073458,"avatar_url":"https://avatars1.githubusercontent.com/u/2073458?v=4","gravatar_id":"","url":"https://api.github.com/users/bebehei","html_url":"https://github.com/bebehei","followers_url":"https://api.github.com/users/bebehei/followers","following_url":"https://api.github.com/users/bebehei/following{/other_user}","gists_url":"https://api.github.com/users/bebehei/gists{/gist_id}","starred_url":"https://api.github.com/users/bebehei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebehei/subscriptions","organizations_url":"https://api.github.com/users/bebehei/orgs","repos_url":"https://api.github.com/users/bebehei/repos","events_url":"https://api.github.com/users/bebehei/events{/privacy}","received_events_url":"https://api.github.com/users/bebehei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bebehei/dunst","description":"lightweight and customizable notification daemon","fork":true,"url":"https://api.github.com/repos/bebehei/dunst","forks_url":"https://api.github.com/repos/bebehei/dunst/forks","keys_url":"https://api.github.com/repos/bebehei/dunst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bebehei/dunst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bebehei/dunst/teams","hooks_url":"https://api.github.com/repos/bebehei/dunst/hooks","issue_events_url":"https://api.github.com/repos/bebehei/dunst/issues/events{/number}","events_url":"https://api.github.com/repos/bebehei/dunst/events","assignees_url":"https://api.github.com/repos/bebehei/dunst/assignees{/user}","branches_url":"https://api.github.com/repos/bebehei/dunst/branches{/branch}","tags_url":"https://api.github.com/repos/bebehei/dunst/tags","blobs_url":"https://api.github.com/repos/bebehei/dunst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bebehei/dunst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bebehei/dunst/git/refs{/sha}","trees_url":"https://api.github.com/repos/bebehei/dunst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bebehei/dunst/statuses/{sha}","languages_url":"https://api.github.com/repos/bebehei/dunst/languages","stargazers_url":"https://api.github.com/repos/bebehei/dunst/stargazers","contributors_url":"https://api.github.com/repos/bebehei/dunst/contributors","subscribers_url":"https://api.github.com/repos/bebehei/dunst/subscribers","subscription_url":"https://api.github.com/repos/bebehei/dunst/subscription","commits_url":"https://api.github.com/repos/bebehei/dunst/commits{/sha}","git_commits_url":"https://api.github.com/repos/bebehei/dunst/git/commits{/sha}","comments_url":"https://api.github.com/repos/bebehei/dunst/comments{/number}","issue_comment_url":"https://api.github.com/repos/bebehei/dunst/issues/comments{/number}","contents_url":"https://api.github.com/repos/bebehei/dunst/contents/{+path}","compare_url":"https://api.github.com/repos/bebehei/dunst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bebehei/dunst/merges","archive_url":"https://api.github.com/repos/bebehei/dunst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bebehei/dunst/downloads","issues_url":"https://api.github.com/repos/bebehei/dunst/issues{/number}","pulls_url":"https://api.github.com/repos/bebehei/dunst/pulls{/number}","milestones_url":"https://api.github.com/repos/bebehei/dunst/milestones{/number}","notifications_url":"https://api.github.com/repos/bebehei/dunst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bebehei/dunst/labels{/name}","releases_url":"https://api.github.com/repos/bebehei/dunst/releases{/id}","deployments_url":"https://api.github.com/repos/bebehei/dunst/deployments","created_at":"2017-07-07T11:26:58Z","updated_at":"2017-07-07T11:27:00Z","pushed_at":"2017-11-03T10:15:15Z","git_url":"git://github.com/bebehei/dunst.git","ssh_url":"git@github.com:bebehei/dunst.git","clone_url":"https://github.com/bebehei/dunst.git","svn_url":"https://github.com/bebehei/dunst","homepage":"https://dunst-project.org","size":1277,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dunst-project:master","ref":"master","sha":"e111f5393e22a93f5b603d1ee5bfdd9c8d2de0ee","user":{"login":"dunst-project","id":25010042,"avatar_url":"https://avatars0.githubusercontent.com/u/25010042?v=4","gravatar_id":"","url":"https://api.github.com/users/dunst-project","html_url":"https://github.com/dunst-project","followers_url":"https://api.github.com/users/dunst-project/followers","following_url":"https://api.github.com/users/dunst-project/following{/other_user}","gists_url":"https://api.github.com/users/dunst-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dunst-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunst-project/subscriptions","organizations_url":"https://api.github.com/users/dunst-project/orgs","repos_url":"https://api.github.com/users/dunst-project/repos","events_url":"https://api.github.com/users/dunst-project/events{/privacy}","received_events_url":"https://api.github.com/users/dunst-project/received_events","type":"Organization","site_admin":false},"repo":{"id":2341146,"name":"dunst","full_name":"dunst-project/dunst","owner":{"login":"dunst-project","id":25010042,"avatar_url":"https://avatars0.githubusercontent.com/u/25010042?v=4","gravatar_id":"","url":"https://api.github.com/users/dunst-project","html_url":"https://github.com/dunst-project","followers_url":"https://api.github.com/users/dunst-project/followers","following_url":"https://api.github.com/users/dunst-project/following{/other_user}","gists_url":"https://api.github.com/users/dunst-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dunst-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunst-project/subscriptions","organizations_url":"https://api.github.com/users/dunst-project/orgs","repos_url":"https://api.github.com/users/dunst-project/repos","events_url":"https://api.github.com/users/dunst-project/events{/privacy}","received_events_url":"https://api.github.com/users/dunst-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dunst-project/dunst","description":"Lightweight and customizable notification daemon","fork":false,"url":"https://api.github.com/repos/dunst-project/dunst","forks_url":"https://api.github.com/repos/dunst-project/dunst/forks","keys_url":"https://api.github.com/repos/dunst-project/dunst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dunst-project/dunst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dunst-project/dunst/teams","hooks_url":"https://api.github.com/repos/dunst-project/dunst/hooks","issue_events_url":"https://api.github.com/repos/dunst-project/dunst/issues/events{/number}","events_url":"https://api.github.com/repos/dunst-project/dunst/events","assignees_url":"https://api.github.com/repos/dunst-project/dunst/assignees{/user}","branches_url":"https://api.github.com/repos/dunst-project/dunst/branches{/branch}","tags_url":"https://api.github.com/repos/dunst-project/dunst/tags","blobs_url":"https://api.github.com/repos/dunst-project/dunst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dunst-project/dunst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dunst-project/dunst/git/refs{/sha}","trees_url":"https://api.github.com/repos/dunst-project/dunst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dunst-project/dunst/statuses/{sha}","languages_url":"https://api.github.com/repos/dunst-project/dunst/languages","stargazers_url":"https://api.github.com/repos/dunst-project/dunst/stargazers","contributors_url":"https://api.github.com/repos/dunst-project/dunst/contributors","subscribers_url":"https://api.github.com/repos/dunst-project/dunst/subscribers","subscription_url":"https://api.github.com/repos/dunst-project/dunst/subscription","commits_url":"https://api.github.com/repos/dunst-project/dunst/commits{/sha}","git_commits_url":"https://api.github.com/repos/dunst-project/dunst/git/commits{/sha}","comments_url":"https://api.github.com/repos/dunst-project/dunst/comments{/number}","issue_comment_url":"https://api.github.com/repos/dunst-project/dunst/issues/comments{/number}","contents_url":"https://api.github.com/repos/dunst-project/dunst/contents/{+path}","compare_url":"https://api.github.com/repos/dunst-project/dunst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dunst-project/dunst/merges","archive_url":"https://api.github.com/repos/dunst-project/dunst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dunst-project/dunst/downloads","issues_url":"https://api.github.com/repos/dunst-project/dunst/issues{/number}","pulls_url":"https://api.github.com/repos/dunst-project/dunst/pulls{/number}","milestones_url":"https://api.github.com/repos/dunst-project/dunst/milestones{/number}","notifications_url":"https://api.github.com/repos/dunst-project/dunst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dunst-project/dunst/labels{/name}","releases_url":"https://api.github.com/repos/dunst-project/dunst/releases{/id}","deployments_url":"https://api.github.com/repos/dunst-project/dunst/deployments","created_at":"2011-09-07T11:36:06Z","updated_at":"2017-11-04T04:32:58Z","pushed_at":"2017-11-03T10:15:16Z","git_url":"git://github.com/dunst-project/dunst.git","ssh_url":"git@github.com:dunst-project/dunst.git","clone_url":"https://github.com/dunst-project/dunst.git","svn_url":"https://github.com/dunst-project/dunst","homepage":"https://dunst-project.org","size":1251,"stargazers_count":964,"watchers_count":964,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":65,"forks":115,"open_issues":65,"watchers":964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/425"},"html":{"href":"https://github.com/dunst-project/dunst/pull/425"},"issue":{"href":"https://api.github.com/repos/dunst-project/dunst/issues/425"},"comments":{"href":"https://api.github.com/repos/dunst-project/dunst/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dunst-project/dunst/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/dunst-project/dunst/statuses/705a1a0fd4eb208d59e01e8cf74b57534aaf4f90"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tsipinakis"}}