{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/12632","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/12632/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12632/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/12632/events","html_url":"https://github.com/nodejs/node/pull/12632","id":223970102,"number":12632,"title":"gyp: get ninja generator compatible with VS2017","user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":237979054,"url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"assignees":[{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2017-04-24T22:31:10Z","updated_at":"2017-04-30T23:58:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12632","html_url":"https://github.com/nodejs/node/pull/12632","diff_url":"https://github.com/nodejs/node/pull/12632.diff","patch_url":"https://github.com/nodejs/node/pull/12632.patch"},"body":"backport of gyp commits from upstream GYP to up\r\nhttps://chromium.googlesource.com/external/gyp/+/a478c1ab51ea3e04e79791ac3d1dad01b3f57434\r\nThis was done instead of a full rebase\r\n\r\nRef: https://github.com/nodejs/node/issues/12281\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ntools, gyp, build\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/298265690","html_url":"https://github.com/nodejs/node/pull/12632#issuecomment-298265690","issue_url":"https://api.github.com/repos/nodejs/node/issues/12632","id":298265690,"user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2017-04-30T23:58:24Z","updated_at":"2017-04-30T23:58:24Z","body":"Double bummer.\r\n\r\nBut in good news, our diff from upstream is:\r\n* 2loc in `xcode_emulation.py`\r\n* one whole new file `compile_commands_json.py`\r\n* and 1 line in `make.py1 I'm not so sure should have landed anyway...\r\n\r\nSo actualy you can compare with https://chromium.googlesource.com/external/gyp/+/a478c1ab51ea3e04e79791ac3d1dad01b3f57434"}}
{"actor":{"display_login":"refack"}}