{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/125982924","pull_request_review_id":48402320,"id":125982924,"diff_hunk":"@@ -7093,6 +7093,15 @@ InitializationSequence::Perform(Sema &S,\n       CurInit = CurInitExprRes;\n \n       bool Complained;\n+\n+      // FIXME : This code is inserted only as a hotfix for type variable","path":"lib/Sema/SemaInit.cpp","position":5,"original_position":5,"commit_id":"8890a80b88bcb2ceb78edd9910039b7f1dd724cc","original_commit_id":"8890a80b88bcb2ceb78edd9910039b7f1dd724cc","user":{"login":"dtarditi","id":11841034,"avatar_url":"https://avatars0.githubusercontent.com/u/11841034?v=3","gravatar_id":"","url":"https://api.github.com/users/dtarditi","html_url":"https://github.com/dtarditi","followers_url":"https://api.github.com/users/dtarditi/followers","following_url":"https://api.github.com/users/dtarditi/following{/other_user}","gists_url":"https://api.github.com/users/dtarditi/gists{/gist_id}","starred_url":"https://api.github.com/users/dtarditi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtarditi/subscriptions","organizations_url":"https://api.github.com/users/dtarditi/orgs","repos_url":"https://api.github.com/users/dtarditi/repos","events_url":"https://api.github.com/users/dtarditi/events{/privacy}","received_events_url":"https://api.github.com/users/dtarditi/received_events","type":"User","site_admin":false},"body":"I think the comment should be different.    This is a workaround because generic type instantiation has not been implemented.  That leaves type variables in unexpected places.    You've actually implemented compatibility for type variables in the current change.  Also, could you use the word TODO instead of FIXME.   FIXME implies that this is a bug, whereas TODO means unimplemented functionality.\r\n","created_at":"2017-07-06T18:42:53Z","updated_at":"2017-07-06T18:55:19Z","html_url":"https://github.com/Microsoft/checkedc-clang/pull/340#discussion_r125982924","pull_request_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/125982924"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/340#discussion_r125982924"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340","id":129084942,"html_url":"https://github.com/Microsoft/checkedc-clang/pull/340","diff_url":"https://github.com/Microsoft/checkedc-clang/pull/340.diff","patch_url":"https://github.com/Microsoft/checkedc-clang/pull/340.patch","issue_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/340","number":340,"state":"open","locked":false,"title":"Type variable type.","user":{"login":"jp1729","id":8700707,"avatar_url":"https://avatars2.githubusercontent.com/u/8700707?v=3","gravatar_id":"","url":"https://api.github.com/users/jp1729","html_url":"https://github.com/jp1729","followers_url":"https://api.github.com/users/jp1729/followers","following_url":"https://api.github.com/users/jp1729/following{/other_user}","gists_url":"https://api.github.com/users/jp1729/gists{/gist_id}","starred_url":"https://api.github.com/users/jp1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp1729/subscriptions","organizations_url":"https://api.github.com/users/jp1729/orgs","repos_url":"https://api.github.com/users/jp1729/repos","events_url":"https://api.github.com/users/jp1729/events{/privacy}","received_events_url":"https://api.github.com/users/jp1729/received_events","type":"User","site_admin":false},"body":"This pull request has TypeVariableType implementation.\r\nWhen a generic function is declared, each type variable is assigned a TypeVariableType, and is stored in Typedef. At the same time, each Typedef is stored inside of FunctionDecl to keep track of the name (identifier) and the type (deBruijn indexes).\r\nFunction Type is also updated to keep track of the number of type variables.\r\nWhen invoking -ast-dump, the type variable information is shown as well.\r\n* The Typedef that stores TypeVariableType is shown first.\r\n* Then, the Function declaration is shown with the new function type. The new function type shows the number of type variables declared in the function.\r\n* Next, each TypeVariable will be shown.\r\n* Then the list continues like it was before, starting with the list of parameters.","created_at":"2017-07-06T01:08:27Z","updated_at":"2017-07-06T18:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8a97288c03a7f1c016568d9295508ad40ec88c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340/commits","review_comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340/comments","review_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/340/comments","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/8890a80b88bcb2ceb78edd9910039b7f1dd724cc","head":{"label":"jp1729:typevartype","ref":"typevartype","sha":"8890a80b88bcb2ceb78edd9910039b7f1dd724cc","user":{"login":"jp1729","id":8700707,"avatar_url":"https://avatars2.githubusercontent.com/u/8700707?v=3","gravatar_id":"","url":"https://api.github.com/users/jp1729","html_url":"https://github.com/jp1729","followers_url":"https://api.github.com/users/jp1729/followers","following_url":"https://api.github.com/users/jp1729/following{/other_user}","gists_url":"https://api.github.com/users/jp1729/gists{/gist_id}","starred_url":"https://api.github.com/users/jp1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp1729/subscriptions","organizations_url":"https://api.github.com/users/jp1729/orgs","repos_url":"https://api.github.com/users/jp1729/repos","events_url":"https://api.github.com/users/jp1729/events{/privacy}","received_events_url":"https://api.github.com/users/jp1729/received_events","type":"User","site_admin":false},"repo":{"id":93419065,"name":"checkedc-clang","full_name":"jp1729/checkedc-clang","owner":{"login":"jp1729","id":8700707,"avatar_url":"https://avatars2.githubusercontent.com/u/8700707?v=3","gravatar_id":"","url":"https://api.github.com/users/jp1729","html_url":"https://github.com/jp1729","followers_url":"https://api.github.com/users/jp1729/followers","following_url":"https://api.github.com/users/jp1729/following{/other_user}","gists_url":"https://api.github.com/users/jp1729/gists{/gist_id}","starred_url":"https://api.github.com/users/jp1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp1729/subscriptions","organizations_url":"https://api.github.com/users/jp1729/orgs","repos_url":"https://api.github.com/users/jp1729/repos","events_url":"https://api.github.com/users/jp1729/events{/privacy}","received_events_url":"https://api.github.com/users/jp1729/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jp1729/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C.   Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":true,"url":"https://api.github.com/repos/jp1729/checkedc-clang","forks_url":"https://api.github.com/repos/jp1729/checkedc-clang/forks","keys_url":"https://api.github.com/repos/jp1729/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jp1729/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jp1729/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/jp1729/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/jp1729/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/jp1729/checkedc-clang/events","assignees_url":"https://api.github.com/repos/jp1729/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/jp1729/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/jp1729/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/jp1729/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jp1729/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jp1729/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/jp1729/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jp1729/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/jp1729/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/jp1729/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/jp1729/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/jp1729/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/jp1729/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/jp1729/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/jp1729/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/jp1729/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/jp1729/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/jp1729/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/jp1729/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jp1729/checkedc-clang/merges","archive_url":"https://api.github.com/repos/jp1729/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jp1729/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/jp1729/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/jp1729/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/jp1729/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/jp1729/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jp1729/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/jp1729/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/jp1729/checkedc-clang/deployments","created_at":"2017-06-05T15:33:33Z","updated_at":"2017-06-05T15:33:59Z","pushed_at":"2017-07-06T00:46:41Z","git_url":"git://github.com/jp1729/checkedc-clang.git","ssh_url":"git@github.com:jp1729/checkedc-clang.git","clone_url":"https://github.com/jp1729/checkedc-clang.git","svn_url":"https://github.com/jp1729/checkedc-clang","homepage":"","size":281503,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b8e92e209fc1ff2fb87a92e0666e1942f7e01d9f","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60645050,"name":"checkedc-clang","full_name":"Microsoft/checkedc-clang","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C.   Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":false,"url":"https://api.github.com/repos/Microsoft/checkedc-clang","forks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/forks","keys_url":"https://api.github.com/repos/Microsoft/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/events","assignees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/checkedc-clang/merges","archive_url":"https://api.github.com/repos/Microsoft/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/deployments","created_at":"2016-06-07T20:43:32Z","updated_at":"2017-06-27T12:32:18Z","pushed_at":"2017-07-06T18:07:28Z","git_url":"git://github.com/Microsoft/checkedc-clang.git","ssh_url":"git@github.com:Microsoft/checkedc-clang.git","clone_url":"https://github.com/Microsoft/checkedc-clang.git","svn_url":"https://github.com/Microsoft/checkedc-clang","homepage":"","size":280955,"stargazers_count":123,"watchers_count":123,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":71,"forks":18,"open_issues":71,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/340"},"issue":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/340"},"comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/8890a80b88bcb2ceb78edd9910039b7f1dd724cc"}}}}
{"actor":{"display_login":"dtarditi"}}