{"action":"closed","number":30789,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/30789","id":144356858,"html_url":"https://github.com/rails/rails/pull/30789","diff_url":"https://github.com/rails/rails/pull/30789.diff","patch_url":"https://github.com/rails/rails/pull/30789.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/30789","number":30789,"state":"closed","locked":false,"title":"Fixes ActiveSupport::Cache::FileStore#cleanup bug which prevented it from removing expired entries","user":{"login":"erichmachado","id":613422,"avatar_url":"https://avatars0.githubusercontent.com/u/613422?v=4","gravatar_id":"","url":"https://api.github.com/users/erichmachado","html_url":"https://github.com/erichmachado","followers_url":"https://api.github.com/users/erichmachado/followers","following_url":"https://api.github.com/users/erichmachado/following{/other_user}","gists_url":"https://api.github.com/users/erichmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/erichmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichmachado/subscriptions","organizations_url":"https://api.github.com/users/erichmachado/orgs","repos_url":"https://api.github.com/users/erichmachado/repos","events_url":"https://api.github.com/users/erichmachado/events{/privacy}","received_events_url":"https://api.github.com/users/erichmachado/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\n`ActiveSupport::Cache::FileStore#cleanup` implementation was silently failing to remove expired entries from the cache storage directory. This was due to the implementation itself failing to read the entry properly during the `cleanup` call:\r\n\r\n```ruby\r\ndef cleanup(options = nil)\r\n  options = merged_options(options)\r\n  search_dir(cache_path) do |fname|\r\n    key = file_path_key(fname)\r\n    entry = read_entry(key, options)\r\n    delete_entry(key, options) if entry && entry.expired?\r\n  end\r\nend\r\n```\r\n\r\nThe `read_entry` method here should receive the actual `fname` instead of `key` to retrieve this entry, otherwise it will just return `nil` and never calls `delete_entry`.\r\n\r\nThis was already reported [here](https://github.com/rails/rails/issues/30788).\r\n","created_at":"2017-10-03T07:50:30Z","updated_at":"2017-10-08T21:40:40Z","closed_at":"2017-10-08T21:40:40Z","merged_at":"2017-10-08T21:40:40Z","merge_commit_sha":"1f0e4ebad22e597459613a82858569b66f7f0cf8","assignee":{"login":"georgeclaghorn","id":94129,"avatar_url":"https://avatars1.githubusercontent.com/u/94129?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeclaghorn","html_url":"https://github.com/georgeclaghorn","followers_url":"https://api.github.com/users/georgeclaghorn/followers","following_url":"https://api.github.com/users/georgeclaghorn/following{/other_user}","gists_url":"https://api.github.com/users/georgeclaghorn/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeclaghorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeclaghorn/subscriptions","organizations_url":"https://api.github.com/users/georgeclaghorn/orgs","repos_url":"https://api.github.com/users/georgeclaghorn/repos","events_url":"https://api.github.com/users/georgeclaghorn/events{/privacy}","received_events_url":"https://api.github.com/users/georgeclaghorn/received_events","type":"User","site_admin":false},"assignees":[{"login":"georgeclaghorn","id":94129,"avatar_url":"https://avatars1.githubusercontent.com/u/94129?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeclaghorn","html_url":"https://github.com/georgeclaghorn","followers_url":"https://api.github.com/users/georgeclaghorn/followers","following_url":"https://api.github.com/users/georgeclaghorn/following{/other_user}","gists_url":"https://api.github.com/users/georgeclaghorn/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeclaghorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeclaghorn/subscriptions","organizations_url":"https://api.github.com/users/georgeclaghorn/orgs","repos_url":"https://api.github.com/users/georgeclaghorn/repos","events_url":"https://api.github.com/users/georgeclaghorn/events{/privacy}","received_events_url":"https://api.github.com/users/georgeclaghorn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/30789/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/30789/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/30789/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e2dbfe5adac3438e3f8bbd2e2dce2ad39c91221b","head":{"label":"erichmachado:file-store-cache-cleanup-fix","ref":"file-store-cache-cleanup-fix","sha":"e2dbfe5adac3438e3f8bbd2e2dce2ad39c91221b","user":{"login":"erichmachado","id":613422,"avatar_url":"https://avatars0.githubusercontent.com/u/613422?v=4","gravatar_id":"","url":"https://api.github.com/users/erichmachado","html_url":"https://github.com/erichmachado","followers_url":"https://api.github.com/users/erichmachado/followers","following_url":"https://api.github.com/users/erichmachado/following{/other_user}","gists_url":"https://api.github.com/users/erichmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/erichmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichmachado/subscriptions","organizations_url":"https://api.github.com/users/erichmachado/orgs","repos_url":"https://api.github.com/users/erichmachado/repos","events_url":"https://api.github.com/users/erichmachado/events{/privacy}","received_events_url":"https://api.github.com/users/erichmachado/received_events","type":"User","site_admin":false},"repo":{"id":105593409,"name":"rails","full_name":"erichmachado/rails","owner":{"login":"erichmachado","id":613422,"avatar_url":"https://avatars0.githubusercontent.com/u/613422?v=4","gravatar_id":"","url":"https://api.github.com/users/erichmachado","html_url":"https://github.com/erichmachado","followers_url":"https://api.github.com/users/erichmachado/followers","following_url":"https://api.github.com/users/erichmachado/following{/other_user}","gists_url":"https://api.github.com/users/erichmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/erichmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichmachado/subscriptions","organizations_url":"https://api.github.com/users/erichmachado/orgs","repos_url":"https://api.github.com/users/erichmachado/repos","events_url":"https://api.github.com/users/erichmachado/events{/privacy}","received_events_url":"https://api.github.com/users/erichmachado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erichmachado/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/erichmachado/rails","forks_url":"https://api.github.com/repos/erichmachado/rails/forks","keys_url":"https://api.github.com/repos/erichmachado/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erichmachado/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erichmachado/rails/teams","hooks_url":"https://api.github.com/repos/erichmachado/rails/hooks","issue_events_url":"https://api.github.com/repos/erichmachado/rails/issues/events{/number}","events_url":"https://api.github.com/repos/erichmachado/rails/events","assignees_url":"https://api.github.com/repos/erichmachado/rails/assignees{/user}","branches_url":"https://api.github.com/repos/erichmachado/rails/branches{/branch}","tags_url":"https://api.github.com/repos/erichmachado/rails/tags","blobs_url":"https://api.github.com/repos/erichmachado/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erichmachado/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erichmachado/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/erichmachado/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erichmachado/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/erichmachado/rails/languages","stargazers_url":"https://api.github.com/repos/erichmachado/rails/stargazers","contributors_url":"https://api.github.com/repos/erichmachado/rails/contributors","subscribers_url":"https://api.github.com/repos/erichmachado/rails/subscribers","subscription_url":"https://api.github.com/repos/erichmachado/rails/subscription","commits_url":"https://api.github.com/repos/erichmachado/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/erichmachado/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/erichmachado/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/erichmachado/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/erichmachado/rails/contents/{+path}","compare_url":"https://api.github.com/repos/erichmachado/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erichmachado/rails/merges","archive_url":"https://api.github.com/repos/erichmachado/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erichmachado/rails/downloads","issues_url":"https://api.github.com/repos/erichmachado/rails/issues{/number}","pulls_url":"https://api.github.com/repos/erichmachado/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/erichmachado/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/erichmachado/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erichmachado/rails/labels{/name}","releases_url":"https://api.github.com/repos/erichmachado/rails/releases{/id}","deployments_url":"https://api.github.com/repos/erichmachado/rails/deployments","created_at":"2017-10-02T22:55:37Z","updated_at":"2017-10-02T22:56:19Z","pushed_at":"2017-10-03T07:51:48Z","git_url":"git://github.com/erichmachado/rails.git","ssh_url":"git@github.com:erichmachado/rails.git","clone_url":"https://github.com/erichmachado/rails.git","svn_url":"https://github.com/erichmachado/rails","homepage":"http://rubyonrails.org","size":155845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"e0d2207ab321145c117c6d615ce209c6f873605d","user":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2017-10-08T20:27:05Z","pushed_at":"2017-10-08T21:40:40Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":156002,"stargazers_count":37170,"watchers_count":37170,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15223,"mirror_url":null,"open_issues_count":1189,"forks":15223,"open_issues":1189,"watchers":37170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/30789"},"html":{"href":"https://github.com/rails/rails/pull/30789"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/30789"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/30789/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/30789/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/30789/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e2dbfe5adac3438e3f8bbd2e2dce2ad39c91221b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"georgeclaghorn","id":94129,"avatar_url":"https://avatars1.githubusercontent.com/u/94129?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeclaghorn","html_url":"https://github.com/georgeclaghorn","followers_url":"https://api.github.com/users/georgeclaghorn/followers","following_url":"https://api.github.com/users/georgeclaghorn/following{/other_user}","gists_url":"https://api.github.com/users/georgeclaghorn/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeclaghorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeclaghorn/subscriptions","organizations_url":"https://api.github.com/users/georgeclaghorn/orgs","repos_url":"https://api.github.com/users/georgeclaghorn/repos","events_url":"https://api.github.com/users/georgeclaghorn/events{/privacy}","received_events_url":"https://api.github.com/users/georgeclaghorn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"georgeclaghorn"}}