{"action":"created","issue":{"url":"https://api.github.com/repos/osuosl/formsender/issues/74","repository_url":"https://api.github.com/repos/osuosl/formsender","labels_url":"https://api.github.com/repos/osuosl/formsender/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/osuosl/formsender/issues/74/comments","events_url":"https://api.github.com/repos/osuosl/formsender/issues/74/events","html_url":"https://github.com/osuosl/formsender/pull/74","id":220720439,"number":74,"title":"check_mx will perform unreliable DNS and network queries","user":{"login":"jldugger","id":152055,"avatar_url":"https://avatars3.githubusercontent.com/u/152055?v=3","gravatar_id":"","url":"https://api.github.com/users/jldugger","html_url":"https://github.com/jldugger","followers_url":"https://api.github.com/users/jldugger/followers","following_url":"https://api.github.com/users/jldugger/following{/other_user}","gists_url":"https://api.github.com/users/jldugger/gists{/gist_id}","starred_url":"https://api.github.com/users/jldugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jldugger/subscriptions","organizations_url":"https://api.github.com/users/jldugger/orgs","repos_url":"https://api.github.com/users/jldugger/repos","events_url":"https://api.github.com/users/jldugger/events{/privacy}","received_events_url":"https://api.github.com/users/jldugger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-10T17:49:52Z","updated_at":"2017-04-11T00:45:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/osuosl/formsender/pulls/74","html_url":"https://github.com/osuosl/formsender/pull/74","diff_url":"https://github.com/osuosl/formsender/pull/74.diff","patch_url":"https://github.com/osuosl/formsender/pull/74.patch"},"body":"We have a number of [cases](https://sentry.io/osuosl/formsender-prod/issues/248142549/\r\n) where DNS lookup has failed, at which point Formsender does not catch the exception thrown and the POST data is discarded. There's a [number](https://pypi.python.org/pypi/retrying) of [ways](https://www.darkcoding.net/software/choosing-a-message-queue-for-python-on-ubuntu-on-a-vps/) to improve this code, but disabling the check is the fastest way of not dropping customer requests.\r\n\r\nReviewing the [validate_email function](https://github.com/syrusakbary/validate_email/blob/master/validate_email.py#L129), it does two optional things:\r\n\r\n- look for an MX record in DNS\r\n- send a RCPT request to the result of the MX lookup for the email address in question\r\n\r\nThis PR disables network validation of email addresses."},"comment":{"url":"https://api.github.com/repos/osuosl/formsender/issues/comments/293118068","html_url":"https://github.com/osuosl/formsender/pull/74#issuecomment-293118068","issue_url":"https://api.github.com/repos/osuosl/formsender/issues/74","id":293118068,"user":{"login":"jldugger","id":152055,"avatar_url":"https://avatars3.githubusercontent.com/u/152055?v=3","gravatar_id":"","url":"https://api.github.com/users/jldugger","html_url":"https://github.com/jldugger","followers_url":"https://api.github.com/users/jldugger/followers","following_url":"https://api.github.com/users/jldugger/following{/other_user}","gists_url":"https://api.github.com/users/jldugger/gists{/gist_id}","starred_url":"https://api.github.com/users/jldugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jldugger/subscriptions","organizations_url":"https://api.github.com/users/jldugger/orgs","repos_url":"https://api.github.com/users/jldugger/repos","events_url":"https://api.github.com/users/jldugger/events{/privacy}","received_events_url":"https://api.github.com/users/jldugger/received_events","type":"User","site_admin":false},"created_at":"2017-04-11T00:45:51Z","updated_at":"2017-04-11T00:45:51Z","body":"@ramereth fixed, and fixed a preexisting syntax error that was breaking CI."}}
{"actor":{"display_login":"jldugger"}}