{"action":"closed","number":372,"pull_request":{"url":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372","id":132166924,"html_url":"https://github.com/01org/tpm2.0-tools/pull/372","diff_url":"https://github.com/01org/tpm2.0-tools/pull/372.diff","patch_url":"https://github.com/01org/tpm2.0-tools/pull/372.patch","issue_url":"https://api.github.com/repos/01org/tpm2.0-tools/issues/372","number":372,"state":"closed","locked":false,"title":"tpm2_create: check if keyed-hash algorithm was used when sealing data","user":{"login":"martinezjavier","id":498974,"avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"body":"The TCG specification is clear that only the TPM_ALG_KEYEDHASH algorithm\r\ncan be used when the user provides part of the the sensitive data.\r\n\r\nThe tpm2_create tool behaves according to the specification, but it may\r\nnot be clear to the users why it fails, unless are already familiar with\r\nthe specs. Make the tool gracefully fail and also add a note to man page.\r\n\r\nFixes: #369\r\n\r\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>","created_at":"2017-07-24T23:30:11Z","updated_at":"2017-07-25T23:48:23Z","closed_at":"2017-07-25T23:48:23Z","merged_at":"2017-07-25T23:48:23Z","merge_commit_sha":"1ae94ffaaccf28ec4622eeaa2da64ba538e35a4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372/commits","review_comments_url":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372/comments","review_comment_url":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/tpm2.0-tools/issues/372/comments","statuses_url":"https://api.github.com/repos/01org/tpm2.0-tools/statuses/e5766b38930bec3d2a5c930d60ad1aea91ba793e","head":{"label":"martinezjavier:tpm2-create-sanity-check","ref":"tpm2-create-sanity-check","sha":"e5766b38930bec3d2a5c930d60ad1aea91ba793e","user":{"login":"martinezjavier","id":498974,"avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"repo":{"id":95092669,"name":"tpm2.0-tools","full_name":"martinezjavier/tpm2.0-tools","owner":{"login":"martinezjavier","id":498974,"avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinezjavier/tpm2.0-tools","description":"The source repository for the TPM (Trusted Platform Module) 2.0 tools","fork":true,"url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools","forks_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/forks","keys_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/teams","hooks_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/hooks","issue_events_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/issues/events{/number}","events_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/events","assignees_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/assignees{/user}","branches_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/branches{/branch}","tags_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/tags","blobs_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/languages","stargazers_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/stargazers","contributors_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/contributors","subscribers_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/subscribers","subscription_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/subscription","commits_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/contents/{+path}","compare_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/merges","archive_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/downloads","issues_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/issues{/number}","pulls_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/labels{/name}","releases_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/releases{/id}","deployments_url":"https://api.github.com/repos/martinezjavier/tpm2.0-tools/deployments","created_at":"2017-06-22T08:27:52Z","updated_at":"2017-07-25T01:05:17Z","pushed_at":"2017-07-25T22:42:58Z","git_url":"git://github.com/martinezjavier/tpm2.0-tools.git","ssh_url":"git@github.com:martinezjavier/tpm2.0-tools.git","clone_url":"https://github.com/martinezjavier/tpm2.0-tools.git","svn_url":"https://github.com/martinezjavier/tpm2.0-tools","homepage":"","size":1146,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"325168080e8946596ab4a063ca5942dbf377ca0e","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":41126332,"name":"tpm2.0-tools","full_name":"01org/tpm2.0-tools","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/tpm2.0-tools","description":"The source repository for the TPM (Trusted Platform Module) 2.0 tools","fork":false,"url":"https://api.github.com/repos/01org/tpm2.0-tools","forks_url":"https://api.github.com/repos/01org/tpm2.0-tools/forks","keys_url":"https://api.github.com/repos/01org/tpm2.0-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/tpm2.0-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/tpm2.0-tools/teams","hooks_url":"https://api.github.com/repos/01org/tpm2.0-tools/hooks","issue_events_url":"https://api.github.com/repos/01org/tpm2.0-tools/issues/events{/number}","events_url":"https://api.github.com/repos/01org/tpm2.0-tools/events","assignees_url":"https://api.github.com/repos/01org/tpm2.0-tools/assignees{/user}","branches_url":"https://api.github.com/repos/01org/tpm2.0-tools/branches{/branch}","tags_url":"https://api.github.com/repos/01org/tpm2.0-tools/tags","blobs_url":"https://api.github.com/repos/01org/tpm2.0-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/tpm2.0-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/tpm2.0-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/tpm2.0-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/tpm2.0-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/tpm2.0-tools/languages","stargazers_url":"https://api.github.com/repos/01org/tpm2.0-tools/stargazers","contributors_url":"https://api.github.com/repos/01org/tpm2.0-tools/contributors","subscribers_url":"https://api.github.com/repos/01org/tpm2.0-tools/subscribers","subscription_url":"https://api.github.com/repos/01org/tpm2.0-tools/subscription","commits_url":"https://api.github.com/repos/01org/tpm2.0-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/tpm2.0-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/tpm2.0-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/tpm2.0-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/tpm2.0-tools/contents/{+path}","compare_url":"https://api.github.com/repos/01org/tpm2.0-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/tpm2.0-tools/merges","archive_url":"https://api.github.com/repos/01org/tpm2.0-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/tpm2.0-tools/downloads","issues_url":"https://api.github.com/repos/01org/tpm2.0-tools/issues{/number}","pulls_url":"https://api.github.com/repos/01org/tpm2.0-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/tpm2.0-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/tpm2.0-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/tpm2.0-tools/labels{/name}","releases_url":"https://api.github.com/repos/01org/tpm2.0-tools/releases{/id}","deployments_url":"https://api.github.com/repos/01org/tpm2.0-tools/deployments","created_at":"2015-08-21T01:07:28Z","updated_at":"2017-07-19T07:51:32Z","pushed_at":"2017-07-25T23:48:23Z","git_url":"git://github.com/01org/tpm2.0-tools.git","ssh_url":"git@github.com:01org/tpm2.0-tools.git","clone_url":"https://github.com/01org/tpm2.0-tools.git","svn_url":"https://github.com/01org/tpm2.0-tools","homepage":"","size":1144,"stargazers_count":58,"watchers_count":58,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":22,"forks":45,"open_issues":22,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372"},"html":{"href":"https://github.com/01org/tpm2.0-tools/pull/372"},"issue":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/issues/372"},"comments":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/01org/tpm2.0-tools/statuses/e5766b38930bec3d2a5c930d60ad1aea91ba793e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"williamcroberts","id":17750791,"avatar_url":"https://avatars0.githubusercontent.com/u/17750791?v=4","gravatar_id":"","url":"https://api.github.com/users/williamcroberts","html_url":"https://github.com/williamcroberts","followers_url":"https://api.github.com/users/williamcroberts/followers","following_url":"https://api.github.com/users/williamcroberts/following{/other_user}","gists_url":"https://api.github.com/users/williamcroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/williamcroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamcroberts/subscriptions","organizations_url":"https://api.github.com/users/williamcroberts/orgs","repos_url":"https://api.github.com/users/williamcroberts/repos","events_url":"https://api.github.com/users/williamcroberts/events{/privacy}","received_events_url":"https://api.github.com/users/williamcroberts/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"williamcroberts"}}