{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/pinot/issues/1621","repository_url":"https://api.github.com/repos/linkedin/pinot","labels_url":"https://api.github.com/repos/linkedin/pinot/issues/1621/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/1621/comments","events_url":"https://api.github.com/repos/linkedin/pinot/issues/1621/events","html_url":"https://github.com/linkedin/pinot/pull/1621","id":239023098,"number":1621,"title":"[PINOT-4926] Introduce a memory manager so that we can switch between Mmap and direct allocation","user":{"login":"mcvsubbu","id":2279037,"avatar_url":"https://avatars0.githubusercontent.com/u/2279037?v=3","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-28T00:52:27Z","updated_at":"2017-06-28T03:09:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/1621","html_url":"https://github.com/linkedin/pinot/pull/1621","diff_url":"https://github.com/linkedin/pinot/pull/1621.diff","patch_url":"https://github.com/linkedin/pinot/pull/1621.patch"},"body":"Introduced the abstract class OffHeapMemoryManager, and the two concrete sub-classes DirectMemoryManager\nand MmapMemoryManager.\n\nRe-factored all the classes allocating memory for real-time segments to use the OffHeapMemoryManager abstract\nclass to allocate memory."},"comment":{"url":"https://api.github.com/repos/linkedin/pinot/issues/comments/311544661","html_url":"https://github.com/linkedin/pinot/pull/1621#issuecomment-311544661","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/1621","id":311544661,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars3.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T03:09:51Z","updated_at":"2017-06-28T03:09:51Z","body":"# [Codecov](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=h1) Report\n> Merging [#1621](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=desc) into [master](https://codecov.io/gh/linkedin/pinot/commit/3b0409289bb97de2e2a19dd2985cd31926736f8a?src=pr&el=desc) will **increase** coverage by `0.11%`.\n> The diff coverage is `90.1%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/linkedin/pinot/pull/1621/graphs/tree.svg?height=150&width=650&token=4ibza2ugkz&src=pr)](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1621      +/-   ##\n==========================================\n+ Coverage   67.96%   68.07%   +0.11%     \n==========================================\n  Files         822      825       +3     \n  Lines       39944    40012      +68     \n  Branches     5262     5263       +1     \n==========================================\n+ Hits        27148    27239      +91     \n+ Misses      11020    11000      -20     \n+ Partials     1776     1773       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `37.73% <100%> (ø)` | :arrow_up: |\n| [...not/core/io/readerwriter/OffHeapMemoryManager.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3JlYWRlcndyaXRlci9PZmZIZWFwTWVtb3J5TWFuYWdlci5qYXZh) | `100% <100%> (ø)` | |\n| [...mpl/dictionary/StringOffHeapMutableDictionary.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9TdHJpbmdPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `50% <100%> (ø)` | :arrow_up: |\n| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `37.73% <100%> (ø)` | :arrow_up: |\n| [.../pinot/core/io/writer/impl/OffHeapStringStore.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3dyaXRlci9pbXBsL09mZkhlYXBTdHJpbmdTdG9yZS5qYXZh) | `76.47% <100%> (+0.56%)` | :arrow_up: |\n| [...l/FixedByteSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3JlYWRlcndyaXRlci9pbXBsL0ZpeGVkQnl0ZVNpbmdsZUNvbHVtbk11bHRpVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `77.36% <100%> (+0.11%)` | :arrow_up: |\n| [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `37.73% <100%> (ø)` | :arrow_up: |\n| [.../FixedByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3JlYWRlcndyaXRlci9pbXBsL0ZpeGVkQnl0ZVNpbmdsZUNvbHVtblNpbmdsZVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `95.12% <100%> (+0.03%)` | :arrow_up: |\n| [.../pinot/core/realtime/impl/RealtimeSegmentImpl.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvUmVhbHRpbWVTZWdtZW50SW1wbC5qYXZh) | `66.11% <100%> (-3.81%)` | :arrow_down: |\n| [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3dyaXRlci9pbXBsL011dGFibGVPZmZIZWFwQnl0ZUFycmF5U3RvcmUuamF2YQ==) | `92.94% <100%> (+0.17%)` | :arrow_up: |\n| ... and [26 more](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=footer). Last update [3b04092...8020db4](https://codecov.io/gh/linkedin/pinot/pull/1621?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}