{"action":"created","issue":{"url":"https://api.github.com/repos/acassen/keepalived/issues/525","repository_url":"https://api.github.com/repos/acassen/keepalived","labels_url":"https://api.github.com/repos/acassen/keepalived/issues/525/labels{/name}","comments_url":"https://api.github.com/repos/acassen/keepalived/issues/525/comments","events_url":"https://api.github.com/repos/acassen/keepalived/issues/525/events","html_url":"https://github.com/acassen/keepalived/issues/525","id":208156840,"number":525,"title":"1.3.3 \"make install\" installs upstart file; probably shouldn't do this","user":{"login":"otheus","id":6928226,"avatar_url":"https://avatars.githubusercontent.com/u/6928226?v=3","gravatar_id":"","url":"https://api.github.com/users/otheus","html_url":"https://github.com/otheus","followers_url":"https://api.github.com/users/otheus/followers","following_url":"https://api.github.com/users/otheus/following{/other_user}","gists_url":"https://api.github.com/users/otheus/gists{/gist_id}","starred_url":"https://api.github.com/users/otheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otheus/subscriptions","organizations_url":"https://api.github.com/users/otheus/orgs","repos_url":"https://api.github.com/users/otheus/repos","events_url":"https://api.github.com/users/otheus/events{/privacy}","received_events_url":"https://api.github.com/users/otheus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-02-16T15:38:05Z","updated_at":"2017-02-16T16:06:01Z","closed_at":null,"body":"I'm working on preparing a spec file for the EPEL team (or at least, internal use). The current build output shows that it's trying to install the upstart service:\r\n\r\n```\r\nmake[3]: Entering directory `/home/c102/c10267/rpmbuild/BUILD/keepalived-1.3.3/keepalived'\r\n...\r\n /bin/mkdir -p '/home/c102/c10267/rpmbuild/BUILDROOT/keepalived-1.3.3-3.el6_UIBK_ZID.x86_64/etc/init'\r\n /usr/bin/install -c -m 644 etc/init/keepalived.conf '/home/c102/c10267/rpmbuild/BUILDROOT/keepalived-1.3.3-3.el6_UIBK_ZID.x86_64/etc/init'\r\n```\r\n\r\nWhile I do want to use upstart here, the fact is, installing the script directly from Make presents a problem  for non-upstart systems, especially w.r.t packaging. Note: other packaging systems might depend on this \"Feature\".\r\n"},"comment":{"url":"https://api.github.com/repos/acassen/keepalived/issues/comments/280374070","html_url":"https://github.com/acassen/keepalived/issues/525#issuecomment-280374070","issue_url":"https://api.github.com/repos/acassen/keepalived/issues/525","id":280374070,"user":{"login":"otheus","id":6928226,"avatar_url":"https://avatars.githubusercontent.com/u/6928226?v=3","gravatar_id":"","url":"https://api.github.com/users/otheus","html_url":"https://github.com/otheus","followers_url":"https://api.github.com/users/otheus/followers","following_url":"https://api.github.com/users/otheus/following{/other_user}","gists_url":"https://api.github.com/users/otheus/gists{/gist_id}","starred_url":"https://api.github.com/users/otheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otheus/subscriptions","organizations_url":"https://api.github.com/users/otheus/orgs","repos_url":"https://api.github.com/users/otheus/repos","events_url":"https://api.github.com/users/otheus/events{/privacy}","received_events_url":"https://api.github.com/users/otheus/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T16:06:01Z","updated_at":"2017-02-16T16:06:01Z","body":"Given the limitations of upstart and exsiting sysconfig file,  a more sensible upstart service file would be as follows:\r\n\r\n```\r\ndescription \"load-balancing and high-availability service\"\r\n\r\nstart on runlevel [2345]\r\nstop on runlevel [!2345]\r\n\r\nrespawn\r\n\r\nscript\r\n        . /etc/sysconfig/keepalived\r\n        exec keepalived --dont-fork ${KEEPALIVED_OPTIONS}\r\nend script\r\n```\r\n\r\nThere's no reason to set the path here, as that is the responsibility of either the admin or the packager to make sure the PATH is appropriately set. In this case, the PATH can be set in /etc/sysconfig/keepalived if needed. However, I duly must note, this might be a redhat-specific implementation."}}
{"actor":{"display_login":"otheus"}}