{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/147242146","pull_request_review_id":72311788,"id":147242146,"diff_hunk":"@@ -103,7 +103,16 @@ public JoinOperatorInfo mergeWith(JoinOperatorInfo other)\n             logHistogramProbes[i] = this.logHistogramProbes[i] + other.logHistogramProbes[i];\n             logHistogramOutput[i] = this.logHistogramOutput[i] + other.logHistogramOutput[i];\n         }\n-        return new JoinOperatorInfo(this.joinType, logHistogramProbes, logHistogramOutput, this.lookupSourcePositions + other.lookupSourcePositions);\n+\n+        long mergedSourcePositions = this.lookupSourcePositions;\n+        if (mergedSourcePositions >= 0 && other.lookupSourcePositions >= 0) {\n+            mergedSourcePositions += other.lookupSourcePositions;\n+        }\n+        else {\n+            mergedSourcePositions = other.lookupSourcePositions;","path":"presto-main/src/main/java/com/facebook/presto/operator/JoinOperatorInfo.java","position":11,"original_position":11,"commit_id":"5e2962cfad5018fa288ed51031ca9d449b50bb8c","original_commit_id":"5e2962cfad5018fa288ed51031ca9d449b50bb8c","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars3.githubusercontent.com/u/715788?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"Yes, you're right. Fixing.","created_at":"2017-10-26T19:23:49Z","updated_at":"2017-10-26T19:23:49Z","html_url":"https://github.com/prestodb/presto/pull/9178#discussion_r147242146","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/9178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/147242146"},"html":{"href":"https://github.com/prestodb/presto/pull/9178#discussion_r147242146"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/9178"}},"in_reply_to_id":145890238},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/9178","id":147592447,"html_url":"https://github.com/prestodb/presto/pull/9178","diff_url":"https://github.com/prestodb/presto/pull/9178.diff","patch_url":"https://github.com/prestodb/presto/pull/9178.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/9178","number":9178,"state":"open","locked":false,"title":"Fix merging for JoinOperatorInfo","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars3.githubusercontent.com/u/715788?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-19T15:40:25Z","updated_at":"2017-10-26T19:23:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbc7abb7f46da8be0cf151de448f64082f4d8bc6","assignee":{"login":"dain","id":58298,"avatar_url":"https://avatars0.githubusercontent.com/u/58298?v=4","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"assignees":[{"login":"dain","id":58298,"avatar_url":"https://avatars0.githubusercontent.com/u/58298?v=4","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dain","id":58298,"avatar_url":"https://avatars0.githubusercontent.com/u/58298?v=4","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/9178/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/9178/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/9178/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/5e2962cfad5018fa288ed51031ca9d449b50bb8c","head":{"label":"raghavsethi:lookupSourcePositions","ref":"lookupSourcePositions","sha":"5e2962cfad5018fa288ed51031ca9d449b50bb8c","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars3.githubusercontent.com/u/715788?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"repo":{"id":42330619,"name":"presto","full_name":"raghavsethi/presto","owner":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars3.githubusercontent.com/u/715788?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavsethi/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/raghavsethi/presto","forks_url":"https://api.github.com/repos/raghavsethi/presto/forks","keys_url":"https://api.github.com/repos/raghavsethi/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavsethi/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavsethi/presto/teams","hooks_url":"https://api.github.com/repos/raghavsethi/presto/hooks","issue_events_url":"https://api.github.com/repos/raghavsethi/presto/issues/events{/number}","events_url":"https://api.github.com/repos/raghavsethi/presto/events","assignees_url":"https://api.github.com/repos/raghavsethi/presto/assignees{/user}","branches_url":"https://api.github.com/repos/raghavsethi/presto/branches{/branch}","tags_url":"https://api.github.com/repos/raghavsethi/presto/tags","blobs_url":"https://api.github.com/repos/raghavsethi/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavsethi/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavsethi/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavsethi/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavsethi/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavsethi/presto/languages","stargazers_url":"https://api.github.com/repos/raghavsethi/presto/stargazers","contributors_url":"https://api.github.com/repos/raghavsethi/presto/contributors","subscribers_url":"https://api.github.com/repos/raghavsethi/presto/subscribers","subscription_url":"https://api.github.com/repos/raghavsethi/presto/subscription","commits_url":"https://api.github.com/repos/raghavsethi/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavsethi/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavsethi/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavsethi/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavsethi/presto/contents/{+path}","compare_url":"https://api.github.com/repos/raghavsethi/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavsethi/presto/merges","archive_url":"https://api.github.com/repos/raghavsethi/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavsethi/presto/downloads","issues_url":"https://api.github.com/repos/raghavsethi/presto/issues{/number}","pulls_url":"https://api.github.com/repos/raghavsethi/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavsethi/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavsethi/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavsethi/presto/labels{/name}","releases_url":"https://api.github.com/repos/raghavsethi/presto/releases{/id}","deployments_url":"https://api.github.com/repos/raghavsethi/presto/deployments","created_at":"2015-09-11T20:28:31Z","updated_at":"2016-01-12T19:42:33Z","pushed_at":"2017-10-26T15:40:12Z","git_url":"git://github.com/raghavsethi/presto.git","ssh_url":"git@github.com:raghavsethi/presto.git","clone_url":"https://github.com/raghavsethi/presto.git","svn_url":"https://github.com/raghavsethi/presto","homepage":"https://prestodb.io","size":86621,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"479420d00274a5464def11e0ffd860bde66ee9eb","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-10-26T17:46:31Z","pushed_at":"2017-10-26T18:19:29Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":81444,"stargazers_count":6633,"watchers_count":6633,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2208,"mirror_url":null,"archived":false,"open_issues_count":1128,"forks":2208,"open_issues":1128,"watchers":6633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/9178"},"html":{"href":"https://github.com/prestodb/presto/pull/9178"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/9178"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/9178/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/9178/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/9178/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/5e2962cfad5018fa288ed51031ca9d449b50bb8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"raghavsethi"}}