{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/comments/98738093","pull_request_review_id":19389106,"id":98738093,"diff_hunk":"@@ -72,19 +112,25 @@ const Video = (props: {\n     onLoad?: () => void,\n     onClick?: () => void,\n }) => {\n-    const src = new URI(props.src);\n-    const domain = src.domain();\n+    const url = document.createElement('a');\n+    url.href = props.src;\n+\n+    const queryObject = queryStringToObject(url.search);\n+    const pathSegments = url.pathname.substr(1).split('/');","path":"src/Attachment.tsx","position":130,"original_position":130,"commit_id":"83bef6f3684c70c02017025346fecd978c93b72d","original_commit_id":"83bef6f3684c70c02017025346fecd978c93b72d","user":{"login":"danmarshall","id":11507384,"avatar_url":"https://avatars.githubusercontent.com/u/11507384?v=3","gravatar_id":"","url":"https://api.github.com/users/danmarshall","html_url":"https://github.com/danmarshall","followers_url":"https://api.github.com/users/danmarshall/followers","following_url":"https://api.github.com/users/danmarshall/following{/other_user}","gists_url":"https://api.github.com/users/danmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/danmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmarshall/subscriptions","organizations_url":"https://api.github.com/users/danmarshall/orgs","repos_url":"https://api.github.com/users/danmarshall/repos","events_url":"https://api.github.com/users/danmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/danmarshall/received_events","type":"User","site_admin":false},"body":"I believe it removes the leading slash character, so that the array from .split does not have an empty first element.","created_at":"2017-01-31T18:34:25Z","updated_at":"2017-01-31T18:34:25Z","html_url":"https://github.com/Microsoft/BotFramework-WebChat/pull/316#discussion_r98738093","pull_request_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/comments/98738093"},"html":{"href":"https://github.com/Microsoft/BotFramework-WebChat/pull/316#discussion_r98738093"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316","id":103860482,"html_url":"https://github.com/Microsoft/BotFramework-WebChat/pull/316","diff_url":"https://github.com/Microsoft/BotFramework-WebChat/pull/316.diff","patch_url":"https://github.com/Microsoft/BotFramework-WebChat/pull/316.patch","issue_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/316","number":316,"state":"open","locked":false,"title":"Removing URI.js","user":{"login":"bnookala","id":87996,"avatar_url":"https://avatars.githubusercontent.com/u/87996?v=3","gravatar_id":"","url":"https://api.github.com/users/bnookala","html_url":"https://github.com/bnookala","followers_url":"https://api.github.com/users/bnookala/followers","following_url":"https://api.github.com/users/bnookala/following{/other_user}","gists_url":"https://api.github.com/users/bnookala/gists{/gist_id}","starred_url":"https://api.github.com/users/bnookala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnookala/subscriptions","organizations_url":"https://api.github.com/users/bnookala/orgs","repos_url":"https://api.github.com/users/bnookala/repos","events_url":"https://api.github.com/users/bnookala/events{/privacy}","received_events_url":"https://api.github.com/users/bnookala/received_events","type":"User","site_admin":false},"body":"Removing the URI.js dependency, which was a bit heavier weight than necessary.","created_at":"2017-01-31T02:11:53Z","updated_at":"2017-01-31T18:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"515857230c67576e6b9348cc476ba2f50004a023","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316/commits","review_comments_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316/comments","review_comment_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/316/comments","statuses_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/statuses/83bef6f3684c70c02017025346fecd978c93b72d","head":{"label":"bnookala:removing-uri-js","ref":"removing-uri-js","sha":"83bef6f3684c70c02017025346fecd978c93b72d","user":{"login":"bnookala","id":87996,"avatar_url":"https://avatars.githubusercontent.com/u/87996?v=3","gravatar_id":"","url":"https://api.github.com/users/bnookala","html_url":"https://github.com/bnookala","followers_url":"https://api.github.com/users/bnookala/followers","following_url":"https://api.github.com/users/bnookala/following{/other_user}","gists_url":"https://api.github.com/users/bnookala/gists{/gist_id}","starred_url":"https://api.github.com/users/bnookala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnookala/subscriptions","organizations_url":"https://api.github.com/users/bnookala/orgs","repos_url":"https://api.github.com/users/bnookala/repos","events_url":"https://api.github.com/users/bnookala/events{/privacy}","received_events_url":"https://api.github.com/users/bnookala/received_events","type":"User","site_admin":false},"repo":{"id":77966179,"name":"BotFramework-WebChat","full_name":"bnookala/BotFramework-WebChat","owner":{"login":"bnookala","id":87996,"avatar_url":"https://avatars.githubusercontent.com/u/87996?v=3","gravatar_id":"","url":"https://api.github.com/users/bnookala","html_url":"https://github.com/bnookala","followers_url":"https://api.github.com/users/bnookala/followers","following_url":"https://api.github.com/users/bnookala/following{/other_user}","gists_url":"https://api.github.com/users/bnookala/gists{/gist_id}","starred_url":"https://api.github.com/users/bnookala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnookala/subscriptions","organizations_url":"https://api.github.com/users/bnookala/orgs","repos_url":"https://api.github.com/users/bnookala/repos","events_url":"https://api.github.com/users/bnookala/events{/privacy}","received_events_url":"https://api.github.com/users/bnookala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnookala/BotFramework-WebChat","description":"Embeddable web chat control for the Microsoft Bot Framework","fork":true,"url":"https://api.github.com/repos/bnookala/BotFramework-WebChat","forks_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/forks","keys_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/teams","hooks_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/hooks","issue_events_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/issues/events{/number}","events_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/events","assignees_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/assignees{/user}","branches_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/branches{/branch}","tags_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/tags","blobs_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/statuses/{sha}","languages_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/languages","stargazers_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/stargazers","contributors_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/contributors","subscribers_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/subscribers","subscription_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/subscription","commits_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/contents/{+path}","compare_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/merges","archive_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/downloads","issues_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/issues{/number}","pulls_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/pulls{/number}","milestones_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/milestones{/number}","notifications_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/labels{/name}","releases_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/releases{/id}","deployments_url":"https://api.github.com/repos/bnookala/BotFramework-WebChat/deployments","created_at":"2017-01-04T00:51:23Z","updated_at":"2017-01-04T00:51:26Z","pushed_at":"2017-01-31T02:11:09Z","git_url":"git://github.com/bnookala/BotFramework-WebChat.git","ssh_url":"git@github.com:bnookala/BotFramework-WebChat.git","clone_url":"https://github.com/bnookala/BotFramework-WebChat.git","svn_url":"https://github.com/bnookala/BotFramework-WebChat","homepage":"","size":7355,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"09cc8bc4b0e38c03822b880b6349849379894798","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":62843932,"name":"BotFramework-WebChat","full_name":"Microsoft/BotFramework-WebChat","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/BotFramework-WebChat","description":"Embeddable web chat control for the Microsoft Bot Framework","fork":false,"url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat","forks_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/forks","keys_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/teams","hooks_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/events","assignees_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/tags","blobs_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/languages","stargazers_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/subscription","commits_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/merges","archive_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/downloads","issues_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/deployments","created_at":"2016-07-07T23:16:57Z","updated_at":"2017-01-30T23:46:20Z","pushed_at":"2017-01-31T18:07:05Z","git_url":"git://github.com/Microsoft/BotFramework-WebChat.git","ssh_url":"git@github.com:Microsoft/BotFramework-WebChat.git","clone_url":"https://github.com/Microsoft/BotFramework-WebChat.git","svn_url":"https://github.com/Microsoft/BotFramework-WebChat","homepage":"","size":7361,"stargazers_count":84,"watchers_count":84,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":39,"forks":56,"open_issues":39,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316"},"html":{"href":"https://github.com/Microsoft/BotFramework-WebChat/pull/316"},"issue":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/316"},"comments":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/BotFramework-WebChat/statuses/83bef6f3684c70c02017025346fecd978c93b72d"}}}}
{"actor":{"display_login":"danmarshall"}}