{"action":"created","comment":{"url":"https://api.github.com/repos/istio/manager/pulls/comments/114212081","pull_request_review_id":35660391,"id":114212081,"diff_hunk":"@@ -1,3 +1,15 @@\n-load(\"@io_bazel_rules_go//go:def.bzl\", \"go_prefix\")\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_prefix\")\n \n go_prefix(\"istio.io/manager\")\n+\n+go_library(\n+    name = \"go_default_library\",\n+    srcs = [\"config.pb.go\"],","path":"BUILD","position":8,"original_position":8,"commit_id":"5d3e56efe8e718cadc626b4414689fb5e3a3f0a5","original_commit_id":"5d3e56efe8e718cadc626b4414689fb5e3a3f0a5","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars1.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"this seems unnecessary? there is no config.pb.go file around","created_at":"2017-05-01T22:04:45Z","updated_at":"2017-05-01T22:04:48Z","html_url":"https://github.com/istio/manager/pull/632#discussion_r114212081","pull_request_url":"https://api.github.com/repos/istio/manager/pulls/632","_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/comments/114212081"},"html":{"href":"https://github.com/istio/manager/pull/632#discussion_r114212081"},"pull_request":{"href":"https://api.github.com/repos/istio/manager/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/istio/manager/pulls/632","id":118445127,"html_url":"https://github.com/istio/manager/pull/632","diff_url":"https://github.com/istio/manager/pull/632.diff","patch_url":"https://github.com/istio/manager/pull/632.patch","issue_url":"https://api.github.com/repos/istio/manager/issues/632","number":632,"state":"open","locked":false,"title":"New ?codes= option to simulate HTTP errors from echo server","user":{"login":"esnible","id":3237651,"avatar_url":"https://avatars1.githubusercontent.com/u/3237651?v=3","gravatar_id":"","url":"https://api.github.com/users/esnible","html_url":"https://github.com/esnible","followers_url":"https://api.github.com/users/esnible/followers","following_url":"https://api.github.com/users/esnible/following{/other_user}","gists_url":"https://api.github.com/users/esnible/gists{/gist_id}","starred_url":"https://api.github.com/users/esnible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esnible/subscriptions","organizations_url":"https://api.github.com/users/esnible/orgs","repos_url":"https://api.github.com/users/esnible/repos","events_url":"https://api.github.com/users/esnible/events{/privacy}","received_events_url":"https://api.github.com/users/esnible/received_events","type":"User","site_admin":false},"body":"This is a re-write of the ?codes= injection feature from last week.\r\n\r\nThe echo server output includes its hostname\r\nIf a request to the echo server HTTP includes ?codes=code[:chances],... the server might send a response other than HTTP 200.  This is for testing code that retries, but where we don't need to track the exact number of retries.\r\n\r\nFor example, ?codes=500:90,200:10 returns 500 90% of times and 200 10% of times\r\nFor example, ?codes=500:1,200:1 returns 500 50% of times and 200 50% of times\r\nFor example, ?codes=501:999,401:1 returns 500 99.9% of times and 401 0.1% of times.\r\nFor example, ?codes=500,200 returns 500 50% of times and 200 50% of times","created_at":"2017-05-01T21:29:29Z","updated_at":"2017-05-01T22:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec03be14e07402b6638576828b7ff8bc7bec4487","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/manager/pulls/632/commits","review_comments_url":"https://api.github.com/repos/istio/manager/pulls/632/comments","review_comment_url":"https://api.github.com/repos/istio/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/manager/issues/632/comments","statuses_url":"https://api.github.com/repos/istio/manager/statuses/5d3e56efe8e718cadc626b4414689fb5e3a3f0a5","head":{"label":"istio:probablistic_echo","ref":"probablistic_echo","sha":"5d3e56efe8e718cadc626b4414689fb5e3a3f0a5","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"manager","full_name":"istio/manager","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/manager","description":"The Istio manager implementation","fork":false,"url":"https://api.github.com/repos/istio/manager","forks_url":"https://api.github.com/repos/istio/manager/forks","keys_url":"https://api.github.com/repos/istio/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/manager/teams","hooks_url":"https://api.github.com/repos/istio/manager/hooks","issue_events_url":"https://api.github.com/repos/istio/manager/issues/events{/number}","events_url":"https://api.github.com/repos/istio/manager/events","assignees_url":"https://api.github.com/repos/istio/manager/assignees{/user}","branches_url":"https://api.github.com/repos/istio/manager/branches{/branch}","tags_url":"https://api.github.com/repos/istio/manager/tags","blobs_url":"https://api.github.com/repos/istio/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/manager/languages","stargazers_url":"https://api.github.com/repos/istio/manager/stargazers","contributors_url":"https://api.github.com/repos/istio/manager/contributors","subscribers_url":"https://api.github.com/repos/istio/manager/subscribers","subscription_url":"https://api.github.com/repos/istio/manager/subscription","commits_url":"https://api.github.com/repos/istio/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/manager/contents/{+path}","compare_url":"https://api.github.com/repos/istio/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/manager/merges","archive_url":"https://api.github.com/repos/istio/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/manager/downloads","issues_url":"https://api.github.com/repos/istio/manager/issues{/number}","pulls_url":"https://api.github.com/repos/istio/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/manager/labels{/name}","releases_url":"https://api.github.com/repos/istio/manager/releases{/id}","deployments_url":"https://api.github.com/repos/istio/manager/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-04-27T03:37:31Z","pushed_at":"2017-05-01T22:00:13Z","git_url":"git://github.com/istio/manager.git","ssh_url":"git@github.com:istio/manager.git","clone_url":"https://github.com/istio/manager.git","svn_url":"https://github.com/istio/manager","homepage":"","size":1348,"stargazers_count":29,"watchers_count":29,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":55,"forks":26,"open_issues":55,"watchers":29,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"ff8a20d97ef1a3d1aa95271fb2201f803a6bb87d","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"manager","full_name":"istio/manager","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/manager","description":"The Istio manager implementation","fork":false,"url":"https://api.github.com/repos/istio/manager","forks_url":"https://api.github.com/repos/istio/manager/forks","keys_url":"https://api.github.com/repos/istio/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/manager/teams","hooks_url":"https://api.github.com/repos/istio/manager/hooks","issue_events_url":"https://api.github.com/repos/istio/manager/issues/events{/number}","events_url":"https://api.github.com/repos/istio/manager/events","assignees_url":"https://api.github.com/repos/istio/manager/assignees{/user}","branches_url":"https://api.github.com/repos/istio/manager/branches{/branch}","tags_url":"https://api.github.com/repos/istio/manager/tags","blobs_url":"https://api.github.com/repos/istio/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/manager/languages","stargazers_url":"https://api.github.com/repos/istio/manager/stargazers","contributors_url":"https://api.github.com/repos/istio/manager/contributors","subscribers_url":"https://api.github.com/repos/istio/manager/subscribers","subscription_url":"https://api.github.com/repos/istio/manager/subscription","commits_url":"https://api.github.com/repos/istio/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/manager/contents/{+path}","compare_url":"https://api.github.com/repos/istio/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/manager/merges","archive_url":"https://api.github.com/repos/istio/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/manager/downloads","issues_url":"https://api.github.com/repos/istio/manager/issues{/number}","pulls_url":"https://api.github.com/repos/istio/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/manager/labels{/name}","releases_url":"https://api.github.com/repos/istio/manager/releases{/id}","deployments_url":"https://api.github.com/repos/istio/manager/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-04-27T03:37:31Z","pushed_at":"2017-05-01T22:00:13Z","git_url":"git://github.com/istio/manager.git","ssh_url":"git@github.com:istio/manager.git","clone_url":"https://github.com/istio/manager.git","svn_url":"https://github.com/istio/manager","homepage":"","size":1348,"stargazers_count":29,"watchers_count":29,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":55,"forks":26,"open_issues":55,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/632"},"html":{"href":"https://github.com/istio/manager/pull/632"},"issue":{"href":"https://api.github.com/repos/istio/manager/issues/632"},"comments":{"href":"https://api.github.com/repos/istio/manager/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/manager/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/manager/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/istio/manager/statuses/5d3e56efe8e718cadc626b4414689fb5e3a3f0a5"}}}}
{"actor":{"display_login":"kyessenov"}}