{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/KDAB/unicode_view/pulls/2","id":159670361,"html_url":"https://github.com/KDAB/unicode_view/pull/2","diff_url":"https://github.com/KDAB/unicode_view/pull/2.diff","patch_url":"https://github.com/KDAB/unicode_view/pull/2.patch","issue_url":"https://api.github.com/repos/KDAB/unicode_view/issues/2","number":2,"state":"closed","locked":false,"title":"Simplify: rely on overloading instead of template specializations","user":{"login":"milianw","id":57207,"avatar_url":"https://avatars1.githubusercontent.com/u/57207?v=4","gravatar_id":"","url":"https://api.github.com/users/milianw","html_url":"https://github.com/milianw","followers_url":"https://api.github.com/users/milianw/followers","following_url":"https://api.github.com/users/milianw/following{/other_user}","gists_url":"https://api.github.com/users/milianw/gists{/gist_id}","starred_url":"https://api.github.com/users/milianw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milianw/subscriptions","organizations_url":"https://api.github.com/users/milianw/orgs","repos_url":"https://api.github.com/users/milianw/repos","events_url":"https://api.github.com/users/milianw/events{/privacy}","received_events_url":"https://api.github.com/users/milianw/received_events","type":"User","site_admin":false},"body":"I don't see a need for template specializations here. There are\r\nonly the three options available, so use overloading to make this\r\nclear.","created_at":"2017-12-21T14:29:44Z","updated_at":"2017-12-21T14:39:15Z","closed_at":"2017-12-21T14:39:15Z","merged_at":"2017-12-21T14:39:15Z","merge_commit_sha":"1a93f29f63f105a2613abe16f19937dbfaadf191","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KDAB/unicode_view/pulls/2/commits","review_comments_url":"https://api.github.com/repos/KDAB/unicode_view/pulls/2/comments","review_comment_url":"https://api.github.com/repos/KDAB/unicode_view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KDAB/unicode_view/issues/2/comments","statuses_url":"https://api.github.com/repos/KDAB/unicode_view/statuses/ad06071e908950a0b24ea4da5400fe3e06ad10c4","head":{"label":"milianw:overload-instead-of-specialize","ref":"overload-instead-of-specialize","sha":"ad06071e908950a0b24ea4da5400fe3e06ad10c4","user":{"login":"milianw","id":57207,"avatar_url":"https://avatars1.githubusercontent.com/u/57207?v=4","gravatar_id":"","url":"https://api.github.com/users/milianw","html_url":"https://github.com/milianw","followers_url":"https://api.github.com/users/milianw/followers","following_url":"https://api.github.com/users/milianw/following{/other_user}","gists_url":"https://api.github.com/users/milianw/gists{/gist_id}","starred_url":"https://api.github.com/users/milianw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milianw/subscriptions","organizations_url":"https://api.github.com/users/milianw/orgs","repos_url":"https://api.github.com/users/milianw/repos","events_url":"https://api.github.com/users/milianw/events{/privacy}","received_events_url":"https://api.github.com/users/milianw/received_events","type":"User","site_admin":false},"repo":{"id":115014405,"name":"unicode_view","full_name":"milianw/unicode_view","owner":{"login":"milianw","id":57207,"avatar_url":"https://avatars1.githubusercontent.com/u/57207?v=4","gravatar_id":"","url":"https://api.github.com/users/milianw","html_url":"https://github.com/milianw","followers_url":"https://api.github.com/users/milianw/followers","following_url":"https://api.github.com/users/milianw/following{/other_user}","gists_url":"https://api.github.com/users/milianw/gists{/gist_id}","starred_url":"https://api.github.com/users/milianw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milianw/subscriptions","organizations_url":"https://api.github.com/users/milianw/orgs","repos_url":"https://api.github.com/users/milianw/repos","events_url":"https://api.github.com/users/milianw/events{/privacy}","received_events_url":"https://api.github.com/users/milianw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milianw/unicode_view","description":"Playground repo for unicode view","fork":true,"url":"https://api.github.com/repos/milianw/unicode_view","forks_url":"https://api.github.com/repos/milianw/unicode_view/forks","keys_url":"https://api.github.com/repos/milianw/unicode_view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milianw/unicode_view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milianw/unicode_view/teams","hooks_url":"https://api.github.com/repos/milianw/unicode_view/hooks","issue_events_url":"https://api.github.com/repos/milianw/unicode_view/issues/events{/number}","events_url":"https://api.github.com/repos/milianw/unicode_view/events","assignees_url":"https://api.github.com/repos/milianw/unicode_view/assignees{/user}","branches_url":"https://api.github.com/repos/milianw/unicode_view/branches{/branch}","tags_url":"https://api.github.com/repos/milianw/unicode_view/tags","blobs_url":"https://api.github.com/repos/milianw/unicode_view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milianw/unicode_view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milianw/unicode_view/git/refs{/sha}","trees_url":"https://api.github.com/repos/milianw/unicode_view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milianw/unicode_view/statuses/{sha}","languages_url":"https://api.github.com/repos/milianw/unicode_view/languages","stargazers_url":"https://api.github.com/repos/milianw/unicode_view/stargazers","contributors_url":"https://api.github.com/repos/milianw/unicode_view/contributors","subscribers_url":"https://api.github.com/repos/milianw/unicode_view/subscribers","subscription_url":"https://api.github.com/repos/milianw/unicode_view/subscription","commits_url":"https://api.github.com/repos/milianw/unicode_view/commits{/sha}","git_commits_url":"https://api.github.com/repos/milianw/unicode_view/git/commits{/sha}","comments_url":"https://api.github.com/repos/milianw/unicode_view/comments{/number}","issue_comment_url":"https://api.github.com/repos/milianw/unicode_view/issues/comments{/number}","contents_url":"https://api.github.com/repos/milianw/unicode_view/contents/{+path}","compare_url":"https://api.github.com/repos/milianw/unicode_view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milianw/unicode_view/merges","archive_url":"https://api.github.com/repos/milianw/unicode_view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milianw/unicode_view/downloads","issues_url":"https://api.github.com/repos/milianw/unicode_view/issues{/number}","pulls_url":"https://api.github.com/repos/milianw/unicode_view/pulls{/number}","milestones_url":"https://api.github.com/repos/milianw/unicode_view/milestones{/number}","notifications_url":"https://api.github.com/repos/milianw/unicode_view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milianw/unicode_view/labels{/name}","releases_url":"https://api.github.com/repos/milianw/unicode_view/releases{/id}","deployments_url":"https://api.github.com/repos/milianw/unicode_view/deployments","created_at":"2017-12-21T14:28:48Z","updated_at":"2017-12-21T14:28:51Z","pushed_at":"2017-12-21T14:29:40Z","git_url":"git://github.com/milianw/unicode_view.git","ssh_url":"git@github.com:milianw/unicode_view.git","clone_url":"https://github.com/milianw/unicode_view.git","svn_url":"https://github.com/milianw/unicode_view","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KDAB:master","ref":"master","sha":"d36675959f4a0a34e5b0e6576380b0a1265903c9","user":{"login":"KDAB","id":402842,"avatar_url":"https://avatars1.githubusercontent.com/u/402842?v=4","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"repo":{"id":114983367,"name":"unicode_view","full_name":"KDAB/unicode_view","owner":{"login":"KDAB","id":402842,"avatar_url":"https://avatars1.githubusercontent.com/u/402842?v=4","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KDAB/unicode_view","description":"Playground repo for unicode view","fork":false,"url":"https://api.github.com/repos/KDAB/unicode_view","forks_url":"https://api.github.com/repos/KDAB/unicode_view/forks","keys_url":"https://api.github.com/repos/KDAB/unicode_view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KDAB/unicode_view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KDAB/unicode_view/teams","hooks_url":"https://api.github.com/repos/KDAB/unicode_view/hooks","issue_events_url":"https://api.github.com/repos/KDAB/unicode_view/issues/events{/number}","events_url":"https://api.github.com/repos/KDAB/unicode_view/events","assignees_url":"https://api.github.com/repos/KDAB/unicode_view/assignees{/user}","branches_url":"https://api.github.com/repos/KDAB/unicode_view/branches{/branch}","tags_url":"https://api.github.com/repos/KDAB/unicode_view/tags","blobs_url":"https://api.github.com/repos/KDAB/unicode_view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KDAB/unicode_view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KDAB/unicode_view/git/refs{/sha}","trees_url":"https://api.github.com/repos/KDAB/unicode_view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KDAB/unicode_view/statuses/{sha}","languages_url":"https://api.github.com/repos/KDAB/unicode_view/languages","stargazers_url":"https://api.github.com/repos/KDAB/unicode_view/stargazers","contributors_url":"https://api.github.com/repos/KDAB/unicode_view/contributors","subscribers_url":"https://api.github.com/repos/KDAB/unicode_view/subscribers","subscription_url":"https://api.github.com/repos/KDAB/unicode_view/subscription","commits_url":"https://api.github.com/repos/KDAB/unicode_view/commits{/sha}","git_commits_url":"https://api.github.com/repos/KDAB/unicode_view/git/commits{/sha}","comments_url":"https://api.github.com/repos/KDAB/unicode_view/comments{/number}","issue_comment_url":"https://api.github.com/repos/KDAB/unicode_view/issues/comments{/number}","contents_url":"https://api.github.com/repos/KDAB/unicode_view/contents/{+path}","compare_url":"https://api.github.com/repos/KDAB/unicode_view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KDAB/unicode_view/merges","archive_url":"https://api.github.com/repos/KDAB/unicode_view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KDAB/unicode_view/downloads","issues_url":"https://api.github.com/repos/KDAB/unicode_view/issues{/number}","pulls_url":"https://api.github.com/repos/KDAB/unicode_view/pulls{/number}","milestones_url":"https://api.github.com/repos/KDAB/unicode_view/milestones{/number}","notifications_url":"https://api.github.com/repos/KDAB/unicode_view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KDAB/unicode_view/labels{/name}","releases_url":"https://api.github.com/repos/KDAB/unicode_view/releases{/id}","deployments_url":"https://api.github.com/repos/KDAB/unicode_view/deployments","created_at":"2017-12-21T08:44:07Z","updated_at":"2017-12-21T08:48:19Z","pushed_at":"2017-12-21T14:39:15Z","git_url":"git://github.com/KDAB/unicode_view.git","ssh_url":"git@github.com:KDAB/unicode_view.git","clone_url":"https://github.com/KDAB/unicode_view.git","svn_url":"https://github.com/KDAB/unicode_view","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KDAB/unicode_view/pulls/2"},"html":{"href":"https://github.com/KDAB/unicode_view/pull/2"},"issue":{"href":"https://api.github.com/repos/KDAB/unicode_view/issues/2"},"comments":{"href":"https://api.github.com/repos/KDAB/unicode_view/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/KDAB/unicode_view/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/KDAB/unicode_view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KDAB/unicode_view/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/KDAB/unicode_view/statuses/ad06071e908950a0b24ea4da5400fe3e06ad10c4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bog-dan-ro","id":2239316,"avatar_url":"https://avatars1.githubusercontent.com/u/2239316?v=4","gravatar_id":"","url":"https://api.github.com/users/bog-dan-ro","html_url":"https://github.com/bog-dan-ro","followers_url":"https://api.github.com/users/bog-dan-ro/followers","following_url":"https://api.github.com/users/bog-dan-ro/following{/other_user}","gists_url":"https://api.github.com/users/bog-dan-ro/gists{/gist_id}","starred_url":"https://api.github.com/users/bog-dan-ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bog-dan-ro/subscriptions","organizations_url":"https://api.github.com/users/bog-dan-ro/orgs","repos_url":"https://api.github.com/users/bog-dan-ro/repos","events_url":"https://api.github.com/users/bog-dan-ro/events{/privacy}","received_events_url":"https://api.github.com/users/bog-dan-ro/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"bog-dan-ro"}}