{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23","id":119496313,"html_url":"https://github.com/pipermerriam/py-solc/pull/23","diff_url":"https://github.com/pipermerriam/py-solc/pull/23.diff","patch_url":"https://github.com/pipermerriam/py-solc/pull/23.patch","issue_url":"https://api.github.com/repos/pipermerriam/py-solc/issues/23","number":23,"state":"closed","locked":false,"title":"Switched to semantic_version for versioning","user":{"login":"cag","id":298447,"avatar_url":"https://avatars2.githubusercontent.com/u/298447?v=3","gravatar_id":"","url":"https://api.github.com/users/cag","html_url":"https://github.com/cag","followers_url":"https://api.github.com/users/cag/followers","following_url":"https://api.github.com/users/cag/following{/other_user}","gists_url":"https://api.github.com/users/cag/gists{/gist_id}","starred_url":"https://api.github.com/users/cag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cag/subscriptions","organizations_url":"https://api.github.com/users/cag/orgs","repos_url":"https://api.github.com/users/cag/repos","events_url":"https://api.github.com/users/cag/events{/privacy}","received_events_url":"https://api.github.com/users/cag/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\n\r\nWhen I ran the tests, the tests would fail because the version check is too specific. Also, some information about the solc version was not captured.\r\n\r\n### How was it fixed?\r\n\r\nI switched it to use `semantic_version`. I had to replace `++` with `pp` from the version string because that library doesn't like having more than one `+` in the string. I may address that soon, but for now, this is fine. Also, having a `solc` that is not an official release also passes the tests. I feel this is fine since the tests are mainly for developers anyway.\r\n\r\n#### Cute Animal Picture\r\n\r\n> ![They will scratch your face off](https://media.giphy.com/media/Hrr0GblXsiE7u/giphy.gif)","created_at":"2017-05-08T17:33:10Z","updated_at":"2017-05-10T16:49:41Z","closed_at":"2017-05-10T16:49:41Z","merged_at":"2017-05-10T16:49:41Z","merge_commit_sha":"bd4bbaadf80c9a4e605ab6efb2a46d0767033291","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23/commits","review_comments_url":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23/comments","review_comment_url":"https://api.github.com/repos/pipermerriam/py-solc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pipermerriam/py-solc/issues/23/comments","statuses_url":"https://api.github.com/repos/pipermerriam/py-solc/statuses/96ae94287e4be170df602f682f4bffa2c5324cdc","head":{"label":"cag:compiler-versioning","ref":"compiler-versioning","sha":"96ae94287e4be170df602f682f4bffa2c5324cdc","user":{"login":"cag","id":298447,"avatar_url":"https://avatars2.githubusercontent.com/u/298447?v=3","gravatar_id":"","url":"https://api.github.com/users/cag","html_url":"https://github.com/cag","followers_url":"https://api.github.com/users/cag/followers","following_url":"https://api.github.com/users/cag/following{/other_user}","gists_url":"https://api.github.com/users/cag/gists{/gist_id}","starred_url":"https://api.github.com/users/cag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cag/subscriptions","organizations_url":"https://api.github.com/users/cag/orgs","repos_url":"https://api.github.com/users/cag/repos","events_url":"https://api.github.com/users/cag/events{/privacy}","received_events_url":"https://api.github.com/users/cag/received_events","type":"User","site_admin":false},"repo":{"id":90305504,"name":"py-solc","full_name":"cag/py-solc","owner":{"login":"cag","id":298447,"avatar_url":"https://avatars2.githubusercontent.com/u/298447?v=3","gravatar_id":"","url":"https://api.github.com/users/cag","html_url":"https://github.com/cag","followers_url":"https://api.github.com/users/cag/followers","following_url":"https://api.github.com/users/cag/following{/other_user}","gists_url":"https://api.github.com/users/cag/gists{/gist_id}","starred_url":"https://api.github.com/users/cag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cag/subscriptions","organizations_url":"https://api.github.com/users/cag/orgs","repos_url":"https://api.github.com/users/cag/repos","events_url":"https://api.github.com/users/cag/events{/privacy}","received_events_url":"https://api.github.com/users/cag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cag/py-solc","description":"Python wrapper around the solc Solidity compiler.","fork":true,"url":"https://api.github.com/repos/cag/py-solc","forks_url":"https://api.github.com/repos/cag/py-solc/forks","keys_url":"https://api.github.com/repos/cag/py-solc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cag/py-solc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cag/py-solc/teams","hooks_url":"https://api.github.com/repos/cag/py-solc/hooks","issue_events_url":"https://api.github.com/repos/cag/py-solc/issues/events{/number}","events_url":"https://api.github.com/repos/cag/py-solc/events","assignees_url":"https://api.github.com/repos/cag/py-solc/assignees{/user}","branches_url":"https://api.github.com/repos/cag/py-solc/branches{/branch}","tags_url":"https://api.github.com/repos/cag/py-solc/tags","blobs_url":"https://api.github.com/repos/cag/py-solc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cag/py-solc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cag/py-solc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cag/py-solc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cag/py-solc/statuses/{sha}","languages_url":"https://api.github.com/repos/cag/py-solc/languages","stargazers_url":"https://api.github.com/repos/cag/py-solc/stargazers","contributors_url":"https://api.github.com/repos/cag/py-solc/contributors","subscribers_url":"https://api.github.com/repos/cag/py-solc/subscribers","subscription_url":"https://api.github.com/repos/cag/py-solc/subscription","commits_url":"https://api.github.com/repos/cag/py-solc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cag/py-solc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cag/py-solc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cag/py-solc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cag/py-solc/contents/{+path}","compare_url":"https://api.github.com/repos/cag/py-solc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cag/py-solc/merges","archive_url":"https://api.github.com/repos/cag/py-solc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cag/py-solc/downloads","issues_url":"https://api.github.com/repos/cag/py-solc/issues{/number}","pulls_url":"https://api.github.com/repos/cag/py-solc/pulls{/number}","milestones_url":"https://api.github.com/repos/cag/py-solc/milestones{/number}","notifications_url":"https://api.github.com/repos/cag/py-solc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cag/py-solc/labels{/name}","releases_url":"https://api.github.com/repos/cag/py-solc/releases{/id}","deployments_url":"https://api.github.com/repos/cag/py-solc/deployments","created_at":"2017-05-04T20:14:07Z","updated_at":"2017-05-04T20:14:09Z","pushed_at":"2017-05-09T22:07:28Z","git_url":"git://github.com/cag/py-solc.git","ssh_url":"git@github.com:cag/py-solc.git","clone_url":"https://github.com/cag/py-solc.git","svn_url":"https://github.com/cag/py-solc","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pipermerriam:master","ref":"master","sha":"1ecaa53441bc351abe42e64b22b5cbba6a105498","user":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars0.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"repo":{"id":63730598,"name":"py-solc","full_name":"pipermerriam/py-solc","owner":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars0.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pipermerriam/py-solc","description":"Python wrapper around the solc Solidity compiler.","fork":false,"url":"https://api.github.com/repos/pipermerriam/py-solc","forks_url":"https://api.github.com/repos/pipermerriam/py-solc/forks","keys_url":"https://api.github.com/repos/pipermerriam/py-solc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipermerriam/py-solc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipermerriam/py-solc/teams","hooks_url":"https://api.github.com/repos/pipermerriam/py-solc/hooks","issue_events_url":"https://api.github.com/repos/pipermerriam/py-solc/issues/events{/number}","events_url":"https://api.github.com/repos/pipermerriam/py-solc/events","assignees_url":"https://api.github.com/repos/pipermerriam/py-solc/assignees{/user}","branches_url":"https://api.github.com/repos/pipermerriam/py-solc/branches{/branch}","tags_url":"https://api.github.com/repos/pipermerriam/py-solc/tags","blobs_url":"https://api.github.com/repos/pipermerriam/py-solc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipermerriam/py-solc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipermerriam/py-solc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipermerriam/py-solc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipermerriam/py-solc/statuses/{sha}","languages_url":"https://api.github.com/repos/pipermerriam/py-solc/languages","stargazers_url":"https://api.github.com/repos/pipermerriam/py-solc/stargazers","contributors_url":"https://api.github.com/repos/pipermerriam/py-solc/contributors","subscribers_url":"https://api.github.com/repos/pipermerriam/py-solc/subscribers","subscription_url":"https://api.github.com/repos/pipermerriam/py-solc/subscription","commits_url":"https://api.github.com/repos/pipermerriam/py-solc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipermerriam/py-solc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipermerriam/py-solc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipermerriam/py-solc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipermerriam/py-solc/contents/{+path}","compare_url":"https://api.github.com/repos/pipermerriam/py-solc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipermerriam/py-solc/merges","archive_url":"https://api.github.com/repos/pipermerriam/py-solc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipermerriam/py-solc/downloads","issues_url":"https://api.github.com/repos/pipermerriam/py-solc/issues{/number}","pulls_url":"https://api.github.com/repos/pipermerriam/py-solc/pulls{/number}","milestones_url":"https://api.github.com/repos/pipermerriam/py-solc/milestones{/number}","notifications_url":"https://api.github.com/repos/pipermerriam/py-solc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipermerriam/py-solc/labels{/name}","releases_url":"https://api.github.com/repos/pipermerriam/py-solc/releases{/id}","deployments_url":"https://api.github.com/repos/pipermerriam/py-solc/deployments","created_at":"2016-07-19T21:55:56Z","updated_at":"2017-05-05T00:27:51Z","pushed_at":"2017-05-10T16:49:41Z","git_url":"git://github.com/pipermerriam/py-solc.git","ssh_url":"git@github.com:pipermerriam/py-solc.git","clone_url":"https://github.com/pipermerriam/py-solc.git","svn_url":"https://github.com/pipermerriam/py-solc","homepage":null,"size":70,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23"},"html":{"href":"https://github.com/pipermerriam/py-solc/pull/23"},"issue":{"href":"https://api.github.com/repos/pipermerriam/py-solc/issues/23"},"comments":{"href":"https://api.github.com/repos/pipermerriam/py-solc/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/pipermerriam/py-solc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pipermerriam/py-solc/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/pipermerriam/py-solc/statuses/96ae94287e4be170df602f682f4bffa2c5324cdc"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars0.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":27,"deletions":34,"changed_files":8}}
{"actor":{"display_login":"pipermerriam"}}