{"action":"created","issue":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/1883","repository_url":"https://api.github.com/repos/StoDevX/AAO-React-Native","labels_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/1883/labels{/name}","comments_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/1883/comments","events_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/1883/events","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/1883","id":273263353,"number":1883,"title":"Misc fixes in preparation for Flow 56","user":{"login":"hawkrives","id":464441,"avatar_url":"https://avatars0.githubusercontent.com/u/464441?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkrives","html_url":"https://github.com/hawkrives","followers_url":"https://api.github.com/users/hawkrives/followers","following_url":"https://api.github.com/users/hawkrives/following{/other_user}","gists_url":"https://api.github.com/users/hawkrives/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkrives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkrives/subscriptions","organizations_url":"https://api.github.com/users/hawkrives/orgs","repos_url":"https://api.github.com/users/hawkrives/repos","events_url":"https://api.github.com/users/hawkrives/events{/privacy}","received_events_url":"https://api.github.com/users/hawkrives/received_events","type":"User","site_admin":false},"labels":[{"id":436398708,"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/labels/pr/ready%20for%20review","name":"pr/ready for review","color":"bfd4f2","default":false},{"id":513566516,"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/labels/type/refactoring","name":"type/refactoring","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-12T20:43:20Z","updated_at":"2017-11-13T00:49:32Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/pulls/1883","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/1883","diff_url":"https://github.com/StoDevX/AAO-React-Native/pull/1883.diff","patch_url":"https://github.com/StoDevX/AAO-React-Native/pull/1883.patch"},"body":"This PR is all of the miscellaneous changes I made while in the depths of the React-Native v0.49 / v0.50 upgrade.\r\n\r\n- 9fe7e6e Like https://github.com/StoDevX/AAO-React-Native/pull/1881 for CodeClimate, this configures `danger` to not worry about `@flow` annotations in `flow-typed/`\r\n- 3367beb There was a property missing in the `OtherModesType` flow type. I added it. (Flow 56 noticed this.)\r\n- `several` Some of these commits are pulling the state/props types out of components and into external types – Flow 56 changes how you specify Props and State.\r\n- 23fd5d9 / 28e65fd Removal of `_.head` from AlphabetListViews. Turns out that `_.head` expects an array, not a string, so I just switched to accessing `str[0]` instead.\r\n- bff938a Hopefully the last time I need to correct an import of `react-native-communications`\r\n- 3199761 I missed this in https://github.com/StoDevX/AAO-React-Native/pull/1859; this removes the \"Open Storybook\" button from Settings in dev mode\r\n- e4f2241 / 93294f8267e1763300f3f52172344e8e5e1c57df Optimize the openUrl listeners on iOS, I guess\r\n- 34c6d6a It makes more sense to check if something is an array than to check if it's an object – arrays are objects, but the inverse is not true\r\n- c64fc4d rework the datepicker to pick the platform component at compile time (flow 56 doesn't like the original code)\r\n- bd5f752 reduce promises in event-detail adding to calendar logic or something\r\n- 4f2bd32 fix timezone bug in a parse-hours test (I think it's a bug)\r\n\r\nThat's more-or-less everything."},"comment":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/comments/343783059","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/1883#issuecomment-343783059","issue_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/1883","id":343783059,"user":{"login":"rye","id":1566689,"avatar_url":"https://avatars0.githubusercontent.com/u/1566689?v=4","gravatar_id":"","url":"https://api.github.com/users/rye","html_url":"https://github.com/rye","followers_url":"https://api.github.com/users/rye/followers","following_url":"https://api.github.com/users/rye/following{/other_user}","gists_url":"https://api.github.com/users/rye/gists{/gist_id}","starred_url":"https://api.github.com/users/rye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rye/subscriptions","organizations_url":"https://api.github.com/users/rye/orgs","repos_url":"https://api.github.com/users/rye/repos","events_url":"https://api.github.com/users/rye/events{/privacy}","received_events_url":"https://api.github.com/users/rye/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T00:49:32Z","updated_at":"2017-11-13T00:49:32Z","author_association":"CONTRIBUTOR","body":"I don't have much grumbling to do because this is all mostly just flow stuff. Builds and runs fine on iOS and Android.\r\n\r\nOne point of note: when I switch quickly between components on iOS, I get a warning:\r\n<img width=\"392\" alt=\"screen shot 2017-11-12 at 6 39 14 pm\" src=\"https://user-images.githubusercontent.com/1566689/32705453-28efe904-c7da-11e7-9725-415235c4eda2.png\">\r\n"}}
{"actor":{"display_login":"rye"}}