{"action":"created","comment":{"url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments/118692063","pull_request_review_id":40509894,"id":118692063,"diff_hunk":"@@ -128,10 +143,19 @@\n             \"ranger.jpa.jdbc.driver\": \"org.postgresql.Driver\",\n             \"ranger.jpa.jdbc.url\": \"jdbc:postgresql://{{ RANGER_DB_HOST }}/{{ RANGER_DB_NAME }}\",\n             \"ranger.audit.source.type\": \"solr\",\n-            \"ranger.authentication.method\": \"ACTIVE_DIRECTORY\",\n-            \"ranger.ldap.ad.domain\": \"{{ LDAP_DOMAIN }}\",\n-            \"ranger.ldap.ad.base.dn\": \"{{ LDAP_SYNC_SEARCH_BASE }}\",\n-            \"ranger.ldap.ad.user.searchfilter\": \"({{ LDAP_NAME_ATTRIBUTE }}={0})\"\n+            \"ranger.authentication.method\": \"{{ LDAP_METHOD }}\",\n+            \"ranger.ldap.ad.url\": \"{{ LDAP_URL }}\",\n+            \"ranger.ldap.ad.base.dn\": \"{{ LDAP_USER_SEARCH_BASE }}\",\n+            \"ranger.ldap.ad.user.searchfilter\": \"{{ LDAP_USER_SEARCH_FILTER }}\",","path":"core/src/main/resources/defaults/blueprints/hdp26-shared-services.bp","position":68,"original_position":68,"commit_id":"fa0b7804faef53c47dcc4eb917cd4fefcaade0cb","original_commit_id":"fa0b7804faef53c47dcc4eb917cd4fefcaade0cb","user":{"login":"akanto","id":2838000,"avatar_url":"https://avatars1.githubusercontent.com/u/2838000?v=3","gravatar_id":"","url":"https://api.github.com/users/akanto","html_url":"https://github.com/akanto","followers_url":"https://api.github.com/users/akanto/followers","following_url":"https://api.github.com/users/akanto/following{/other_user}","gists_url":"https://api.github.com/users/akanto/gists{/gist_id}","starred_url":"https://api.github.com/users/akanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akanto/subscriptions","organizations_url":"https://api.github.com/users/akanto/orgs","repos_url":"https://api.github.com/users/akanto/repos","events_url":"https://api.github.com/users/akanto/events{/privacy}","received_events_url":"https://api.github.com/users/akanto/received_events","type":"User","site_admin":false},"body":"We don't need search filter, we can use:  \"ranger.ldap.ad.user.searchfilter\": \"({{ LDAP_NAME_ATTRIBUTE }}={0})\"","created_at":"2017-05-26T12:33:26Z","updated_at":"2017-05-26T12:33:26Z","html_url":"https://github.com/sequenceiq/cloudbreak/pull/2508#discussion_r118692063","pull_request_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508","_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments/118692063"},"html":{"href":"https://github.com/sequenceiq/cloudbreak/pull/2508#discussion_r118692063"},"pull_request":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508"}}},"pull_request":{"url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508","id":122632019,"html_url":"https://github.com/sequenceiq/cloudbreak/pull/2508","diff_url":"https://github.com/sequenceiq/cloudbreak/pull/2508.diff","patch_url":"https://github.com/sequenceiq/cloudbreak/pull/2508.patch","issue_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/2508","number":2508,"state":"open","locked":false,"title":"CLOUD-81127 Simplify LDAP Setup (Ranger, Knox, Zeppelin, Hive)","user":{"login":"shwethags","id":1281757,"avatar_url":"https://avatars2.githubusercontent.com/u/1281757?v=3","gravatar_id":"","url":"https://api.github.com/users/shwethags","html_url":"https://github.com/shwethags","followers_url":"https://api.github.com/users/shwethags/followers","following_url":"https://api.github.com/users/shwethags/following{/other_user}","gists_url":"https://api.github.com/users/shwethags/gists{/gist_id}","starred_url":"https://api.github.com/users/shwethags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shwethags/subscriptions","organizations_url":"https://api.github.com/users/shwethags/orgs","repos_url":"https://api.github.com/users/shwethags/repos","events_url":"https://api.github.com/users/shwethags/events{/privacy}","received_events_url":"https://api.github.com/users/shwethags/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-26T12:21:39Z","updated_at":"2017-05-26T12:33:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b74f7dddeecd00604fd5d82e6c702d9191ede93c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"doktoric","id":1117088,"avatar_url":"https://avatars0.githubusercontent.com/u/1117088?v=3","gravatar_id":"","url":"https://api.github.com/users/doktoric","html_url":"https://github.com/doktoric","followers_url":"https://api.github.com/users/doktoric/followers","following_url":"https://api.github.com/users/doktoric/following{/other_user}","gists_url":"https://api.github.com/users/doktoric/gists{/gist_id}","starred_url":"https://api.github.com/users/doktoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktoric/subscriptions","organizations_url":"https://api.github.com/users/doktoric/orgs","repos_url":"https://api.github.com/users/doktoric/repos","events_url":"https://api.github.com/users/doktoric/events{/privacy}","received_events_url":"https://api.github.com/users/doktoric/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508/commits","review_comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508/comments","review_comment_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/2508/comments","statuses_url":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/fa0b7804faef53c47dcc4eb917cd4fefcaade0cb","head":{"label":"shwethags:BUG-81127","ref":"BUG-81127","sha":"fa0b7804faef53c47dcc4eb917cd4fefcaade0cb","user":{"login":"shwethags","id":1281757,"avatar_url":"https://avatars2.githubusercontent.com/u/1281757?v=3","gravatar_id":"","url":"https://api.github.com/users/shwethags","html_url":"https://github.com/shwethags","followers_url":"https://api.github.com/users/shwethags/followers","following_url":"https://api.github.com/users/shwethags/following{/other_user}","gists_url":"https://api.github.com/users/shwethags/gists{/gist_id}","starred_url":"https://api.github.com/users/shwethags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shwethags/subscriptions","organizations_url":"https://api.github.com/users/shwethags/orgs","repos_url":"https://api.github.com/users/shwethags/repos","events_url":"https://api.github.com/users/shwethags/events{/privacy}","received_events_url":"https://api.github.com/users/shwethags/received_events","type":"User","site_admin":false},"repo":{"id":80606892,"name":"cloudbreak","full_name":"shwethags/cloudbreak","owner":{"login":"shwethags","id":1281757,"avatar_url":"https://avatars2.githubusercontent.com/u/1281757?v=3","gravatar_id":"","url":"https://api.github.com/users/shwethags","html_url":"https://github.com/shwethags","followers_url":"https://api.github.com/users/shwethags/followers","following_url":"https://api.github.com/users/shwethags/following{/other_user}","gists_url":"https://api.github.com/users/shwethags/gists{/gist_id}","starred_url":"https://api.github.com/users/shwethags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shwethags/subscriptions","organizations_url":"https://api.github.com/users/shwethags/orgs","repos_url":"https://api.github.com/users/shwethags/repos","events_url":"https://api.github.com/users/shwethags/events{/privacy}","received_events_url":"https://api.github.com/users/shwethags/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shwethags/cloudbreak","description":"Cloudbreak is a cloud agnostic Hadoop as a Service API.","fork":true,"url":"https://api.github.com/repos/shwethags/cloudbreak","forks_url":"https://api.github.com/repos/shwethags/cloudbreak/forks","keys_url":"https://api.github.com/repos/shwethags/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shwethags/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shwethags/cloudbreak/teams","hooks_url":"https://api.github.com/repos/shwethags/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/shwethags/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/shwethags/cloudbreak/events","assignees_url":"https://api.github.com/repos/shwethags/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/shwethags/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/shwethags/cloudbreak/tags","blobs_url":"https://api.github.com/repos/shwethags/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shwethags/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shwethags/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/shwethags/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shwethags/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/shwethags/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/shwethags/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/shwethags/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/shwethags/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/shwethags/cloudbreak/subscription","commits_url":"https://api.github.com/repos/shwethags/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/shwethags/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/shwethags/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/shwethags/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/shwethags/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/shwethags/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shwethags/cloudbreak/merges","archive_url":"https://api.github.com/repos/shwethags/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shwethags/cloudbreak/downloads","issues_url":"https://api.github.com/repos/shwethags/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/shwethags/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/shwethags/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/shwethags/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shwethags/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/shwethags/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/shwethags/cloudbreak/deployments","created_at":"2017-02-01T09:47:26Z","updated_at":"2017-02-01T09:47:39Z","pushed_at":"2017-05-26T12:20:57Z","git_url":"git://github.com/shwethags/cloudbreak.git","ssh_url":"git@github.com:shwethags/cloudbreak.git","clone_url":"https://github.com/shwethags/cloudbreak.git","svn_url":"https://github.com/shwethags/cloudbreak","homepage":"http://sequenceiq.com/cloudbreak-docs","size":46223,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequenceiq:rc-1.15","ref":"rc-1.15","sha":"6b632269f7d4c94f0f45bc9d634f624da75abf37","user":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars2.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"name":"cloudbreak","full_name":"sequenceiq/cloudbreak","owner":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars2.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequenceiq/cloudbreak","description":"Cloudbreak is a cloud agnostic Hadoop as a Service API.","fork":false,"url":"https://api.github.com/repos/sequenceiq/cloudbreak","forks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/forks","keys_url":"https://api.github.com/repos/sequenceiq/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequenceiq/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequenceiq/cloudbreak/teams","hooks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/events","assignees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/sequenceiq/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/tags","blobs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/sequenceiq/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscription","commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/sequenceiq/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequenceiq/cloudbreak/merges","archive_url":"https://api.github.com/repos/sequenceiq/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequenceiq/cloudbreak/downloads","issues_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/sequenceiq/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/sequenceiq/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequenceiq/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/sequenceiq/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/deployments","created_at":"2014-05-10T10:03:07Z","updated_at":"2017-05-24T06:56:56Z","pushed_at":"2017-05-26T12:21:56Z","git_url":"git://github.com/sequenceiq/cloudbreak.git","ssh_url":"git@github.com:sequenceiq/cloudbreak.git","clone_url":"https://github.com/sequenceiq/cloudbreak.git","svn_url":"https://github.com/sequenceiq/cloudbreak","homepage":"http://sequenceiq.com/cloudbreak-docs","size":45050,"stargazers_count":174,"watchers_count":174,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":60,"mirror_url":null,"open_issues_count":16,"forks":60,"open_issues":16,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508"},"html":{"href":"https://github.com/sequenceiq/cloudbreak/pull/2508"},"issue":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/2508"},"comments":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/2508/comments"},"review_comments":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508/comments"},"review_comment":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/2508/commits"},"statuses":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/fa0b7804faef53c47dcc4eb917cd4fefcaade0cb"}}}}
{"actor":{"display_login":"akanto"}}