{"action":"created","issue":{"url":"https://api.github.com/repos/minishift/minishift/issues/558","repository_url":"https://api.github.com/repos/minishift/minishift","labels_url":"https://api.github.com/repos/minishift/minishift/issues/558/labels{/name}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/558/comments","events_url":"https://api.github.com/repos/minishift/minishift/issues/558/events","html_url":"https://github.com/minishift/minishift/pull/558","id":214669105,"number":558,"title":"[WIP] Issue #342 Fix service command","user":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars2.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-16T11:07:30Z","updated_at":"2017-03-17T09:07:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/558","html_url":"https://github.com/minishift/minishift/pull/558","diff_url":"https://github.com/minishift/minishift/pull/558.diff","patch_url":"https://github.com/minishift/minishift/pull/558.patch"},"body":"- Use oc binary to fetch route and open it in browser\r\n- Remove k8s dependency in service and service list files\r\n\r\n#### Tests are being worked on\r\n\r\n### Execution log\r\n```\r\n$ minishift openshift service nationalparks-katacoda\r\nOpening the service /nationalparks-katacoda in the default browser...\r\n\r\n$ minishift openshift service nationalparks-katacoda -n myproject\r\nOpening the service myproject/nationalparks-katacoda in the default browser...\r\n\r\n$ minishift openshift service nationalparks-katacoda -n foo      \r\nNamespace foo doesn't exits\r\n```\r\n\r\nEarly feedback/review appreciated.\r\n\r\ncc @hferentschik @LalatenduMohanty "},"comment":{"url":"https://api.github.com/repos/minishift/minishift/issues/comments/287302547","html_url":"https://github.com/minishift/minishift/pull/558#issuecomment-287302547","issue_url":"https://api.github.com/repos/minishift/minishift/issues/558","id":287302547,"user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"created_at":"2017-03-17T09:07:11Z","updated_at":"2017-03-17T09:07:11Z","body":"> I am assuming, for integration testing, I need to deploy application application first, need to wait for some time (bit tricky here), expose route and verify the service command behaviour.\r\n\r\n-1 for waiting. As we discussed, this is never a good strategy. If you want to wait until the build completes the easiest is to tail the build (`oc logs -f bc/nodejs-ex`). This command will return once the build is complete at which time you know the app is ready. \r\n\r\nThere is a little gotcha here (which is a feature request in Origin as well). When you tail the build config, directly after you triggered the build and the s2i image is not there, the command will return directly. Really, one would like the command to wait, from the moment the build gets created. Anyways, so there might be a wait needed (for now), but it should not be a wait for the overall app to be available and hopefully this would also be only temporary.\r\n\r\nThat said, if you are just after checking that the service url is correct, there is not need to wait for the build to complete. You can expose the service directly after you issues the app creation command. You don't have to wait for the build to complete. Also, for getting the service url, the service does not need to be deployed yet. Different, if you want to also hit the app to make sure it works. Then you need to wait for the app to be deployed."}}
{"actor":{"display_login":"hferentschik"}}