{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/5506","repository_url":"https://api.github.com/repos/kripken/emscripten","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/5506/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/5506/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/5506/events","html_url":"https://github.com/kripken/emscripten/pull/5506","id":252031292,"number":5506,"title":"Fix js lib exports","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-22T17:25:02Z","updated_at":"2017-08-23T04:48:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/5506","html_url":"https://github.com/kripken/emscripten/pull/5506","diff_url":"https://github.com/kripken/emscripten/pull/5506.diff","patch_url":"https://github.com/kripken/emscripten/pull/5506.patch"},"body":"After reading the code more carefully, I think #5471 was a step in the right direction but still not quite right. Basically, jsifier is in charge of exporting js library functions, and emscripten.py of exporting asm module (compiled code) functions. So we can't only do EXPORT_ALL in jsifier, it would miss exporting of library functions. It's true that probably no one ever used this ;) aside from dynamic linking, which uses EXPORT_ALL anyhow. Still, it's better to not break that, so this PR does that, and adds tests.\r\n\r\nSecond, the real issue is actually not on the line with EXPORT_ALL. The actual bug was that we added all asm library functions to EXPORTED_FUNCTIONS. That's not necessary, and this PR makes us only add asm library funcs if they are needed from outside the asm module. That makes us export even fewer things than after that first improvement.\r\n\r\nStill running tests, but looks good so far. @nazar-pc, maybe you can take a look at this, and also confirm that doesn't do anything worse than after your PR?"},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/324220142","html_url":"https://github.com/kripken/emscripten/pull/5506#issuecomment-324220142","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/5506","id":324220142,"user":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars0.githubusercontent.com/u/928965?v=4","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T04:48:56Z","updated_at":"2017-08-23T04:48:56Z","body":"Yes, now it works as expected, thanks!"}}
{"actor":{"display_login":"nazar-pc"}}