{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/12","repository_url":"https://api.github.com/repos/BloomBooks/BloomReader","labels_url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/12/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/12/events","html_url":"https://github.com/BloomBooks/BloomReader/pull/12","id":247508736,"number":12,"title":"Sort book list alphabetically (BL-4833)","user":{"login":"andrew-polk","id":5847219,"avatar_url":"https://avatars1.githubusercontent.com/u/5847219?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-polk","html_url":"https://github.com/andrew-polk","followers_url":"https://api.github.com/users/andrew-polk/followers","following_url":"https://api.github.com/users/andrew-polk/following{/other_user}","gists_url":"https://api.github.com/users/andrew-polk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-polk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-polk/subscriptions","organizations_url":"https://api.github.com/users/andrew-polk/orgs","repos_url":"https://api.github.com/users/andrew-polk/repos","events_url":"https://api.github.com/users/andrew-polk/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-polk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-02T20:15:55Z","updated_at":"2017-08-03T17:21:14Z","closed_at":"2017-08-03T14:13:00Z","pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomReader/pulls/12","html_url":"https://github.com/BloomBooks/BloomReader/pull/12","diff_url":"https://github.com/BloomBooks/BloomReader/pull/12.diff","patch_url":"https://github.com/BloomBooks/BloomReader/pull/12.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomreader/12)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/comments/320034790","html_url":"https://github.com/BloomBooks/BloomReader/pull/12#issuecomment-320034790","issue_url":"https://api.github.com/repos/BloomBooks/BloomReader/issues/12","id":320034790,"user":{"login":"andrew-polk","id":5847219,"avatar_url":"https://avatars1.githubusercontent.com/u/5847219?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-polk","html_url":"https://github.com/andrew-polk","followers_url":"https://api.github.com/users/andrew-polk/followers","following_url":"https://api.github.com/users/andrew-polk/following{/other_user}","gists_url":"https://api.github.com/users/andrew-polk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-polk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-polk/subscriptions","organizations_url":"https://api.github.com/users/andrew-polk/orgs","repos_url":"https://api.github.com/users/andrew-polk/repos","events_url":"https://api.github.com/users/andrew-polk/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-polk/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T17:21:14Z","updated_at":"2017-08-03T17:21:14Z","body":"\n\n\n\n\n\n\n\n*[app/src/main/java/org/sil/bloom/reader/models/BookCollection.java, line 43 at r1](https://reviewable.io:443/reviews/bloombooks/bloomreader/12#-KqZuLEil0fczTXrzhj2:-Kqd68qIy-LYAzE6AqMU:br6lm8k) ([raw file](https://github.com/bloombooks/bloomreader/blob/3de53e04249a1f4f08c4a0f4c946d8aa38499f88/app/src/main/java/org/sil/bloom/reader/models/BookCollection.java#L43)):*\n<details><summary><i>Previously, JohnThomson (John Thomson) wrote…</i></summary><blockquote>\n\nGood question. Premature optimization is certainly a danger. I tend to think it's worth a little thought especially if something more efficient does NOT add to complexity. For example, in C# I would make it a sorted collection..I believe Java has java.util.PriorityQueue. That lets you add n items in n log n time and might actually be simpler, whereas the current code is going to be n-squared log n, which grows pretty fast...400k or so string comparisons for 200 items.\n\nIt can stand for MVP. Won't be hard to fix if we need to. The main thing was to be sure it DOES get sorted initially.\n</blockquote></details>\n\nYes, a sorted collection should have worked. I tried that initially, but was having trouble with it. I don't remember why. I didn't actually find the PriorityQueue, though, so maybe I was just using the wrong data structure. I'll look at it. Thanks.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/bloombooks/bloomreader/12)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"andrew-polk"}}