{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/1470","repository_url":"https://api.github.com/repos/OpenMW/openmw","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/events","html_url":"https://github.com/OpenMW/openmw/pull/1470","id":259241928,"number":1470,"title":"ESS-Importer: Convert magic projectiles","user":{"login":"MiroslavR","id":7346770,"avatar_url":"https://avatars2.githubusercontent.com/u/7346770?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroslavR","html_url":"https://github.com/MiroslavR","followers_url":"https://api.github.com/users/MiroslavR/followers","following_url":"https://api.github.com/users/MiroslavR/following{/other_user}","gists_url":"https://api.github.com/users/MiroslavR/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroslavR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroslavR/subscriptions","organizations_url":"https://api.github.com/users/MiroslavR/orgs","repos_url":"https://api.github.com/users/MiroslavR/repos","events_url":"https://api.github.com/users/MiroslavR/events{/privacy}","received_events_url":"https://api.github.com/users/MiroslavR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-20T17:28:28Z","updated_at":"2017-09-22T16:41:26Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1470","html_url":"https://github.com/OpenMW/openmw/pull/1470","diff_url":"https://github.com/OpenMW/openmw/pull/1470.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1470.patch"},"body":"Implements: https://bugs.openmw.org/issues/2320\r\n\r\nThis PR imports and converts magic projectiles, and partially imports active spells (SPLM record). To make this conversion possible, OpenMW save format was slightly changed. Particularly, these redundant MPRJ fields were removed:\r\n* sourceName (can be determined from spellId)\r\n* effects (can be determined from spellId)\r\n* stack (was always false)\r\n* sound (was unused)\r\n\r\nThe interface for launching magic projectiles was also refactored to remove redundancy.\r\n\r\nStrange things noticed during development:\r\n* `ESMStore::find(const std::string &id)` does not seem to work for spell records,\r\n* Magic projectile speed stored by vanilla is 1000 times greater than OpenMW, e.g. `1250` vs `1.25` for spell \"fireball\" (content file defines `1.25` speed for \"Fire Damage\" effect). I'm not sure where that factor comes from.\r\n"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/331498463","html_url":"https://github.com/OpenMW/openmw/pull/1470#issuecomment-331498463","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470","id":331498463,"user":{"login":"MiroslavR","id":7346770,"avatar_url":"https://avatars2.githubusercontent.com/u/7346770?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroslavR","html_url":"https://github.com/MiroslavR","followers_url":"https://api.github.com/users/MiroslavR/followers","following_url":"https://api.github.com/users/MiroslavR/following{/other_user}","gists_url":"https://api.github.com/users/MiroslavR/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroslavR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroslavR/subscriptions","organizations_url":"https://api.github.com/users/MiroslavR/orgs","repos_url":"https://api.github.com/users/MiroslavR/repos","events_url":"https://api.github.com/users/MiroslavR/events{/privacy}","received_events_url":"https://api.github.com/users/MiroslavR/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T16:41:26Z","updated_at":"2017-09-22T16:41:26Z","author_association":"COLLABORATOR","body":"I'm worried about this new policy blocking progress towards 1.0. It's very possible we will run into problems where breaking forward compatibility is inevitable.\r\n\r\nAs far as rogue projectiles go, they seem quite unlikely to occur. All projectiles are cleared when sleeping/waiting and upon changing the worldspace. Ballistic projectiles should also hit the water plane at some point after surpassing the active cells (unless the worldspace has no water). Same can't be said about magic projectiles as their trajectory is linear - I guess rogue projectiles only become a problem when you fire magic bolts at the sky?\r\n\r\nWhen do you think would be the appropriate time to clear them - during the loading phase or periodically during simulation?"}}
{"actor":{"display_login":"MiroslavR"}}