{"action":"closed","number":2472,"pull_request":{"url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472","id":141489326,"html_url":"https://github.com/SparkDevNetwork/Rock/pull/2472","diff_url":"https://github.com/SparkDevNetwork/Rock/pull/2472.diff","patch_url":"https://github.com/SparkDevNetwork/Rock/pull/2472.patch","issue_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2472","number":2472,"state":"closed","locked":false,"title":"Fixes #2308 Save Person attributes when adding a new family member","user":{"login":"shivambareria","id":10127187,"avatar_url":"https://avatars3.githubusercontent.com/u/10127187?v=4","gravatar_id":"","url":"https://api.github.com/users/shivambareria","html_url":"https://github.com/shivambareria","followers_url":"https://api.github.com/users/shivambareria/followers","following_url":"https://api.github.com/users/shivambareria/following{/other_user}","gists_url":"https://api.github.com/users/shivambareria/gists{/gist_id}","starred_url":"https://api.github.com/users/shivambareria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivambareria/subscriptions","organizations_url":"https://api.github.com/users/shivambareria/orgs","repos_url":"https://api.github.com/users/shivambareria/repos","events_url":"https://api.github.com/users/shivambareria/events{/privacy}","received_events_url":"https://api.github.com/users/shivambareria/received_events","type":"User","site_admin":false},"body":"## Contributor Agreement\r\nHave you filled out and sent your [Spark Contributor Agreement](http://www.rockrms.com/Content/RockExternal/Misc/Contributor%20Agreement.pdf) to secretary [at] sparkdevnetwork.org?\r\nYes\r\n\r\n## Context\r\nWhat is the problem you encountered that lead to you creating this pull request?\r\n#2308 Person attributes not saving when adding a new family member on the external website\r\n\r\n## Strategy\r\nHow have you implemented your solution?\r\nWhile adding New family member, DisplayEditAttributes method was not called on Load.\r\n\r\n\r\n## Tests\r\nIf your code is a new method or function (that doesn't need a mock database or SqlServerTypes library) and can be Xunit tested [see example](https://github.com/SparkDevNetwork/Rock/blob/develop/Rock.Tests/Rock/Lava/RockFiltersTests.cs) be sure your pull request includes the corresponding unit tests in the Rock.Tests project. In all cases *you* MUST test your code before submitting a pull request.\r\nN/A\r\n\r\n## Possible Implications\r\n_What could this change potentially impact? Are there any security considerations? Where could this potentially affect backwards compatibility?_\r\n\r\n## Screenshots\r\n_Provide us some screenshots if your pull request either alters existing UI or provides new UI. Arrows and labels are helpful._\r\n\r\n## Documentation\r\n_If your change effects the UI or needs to be documented in one of the existing [user guides](http://www.rockrms.com/Learn/Documentation), please provide the brief write-up here:_\r\n\r\n## Migrations\r\nShould your pull request require a migration, please exclude the migration from the Rock.Migration project, but submit it in your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.\r\n","created_at":"2017-09-17T14:54:50Z","updated_at":"2017-09-24T14:35:53Z","closed_at":"2017-09-24T14:35:53Z","merged_at":"2017-09-24T14:35:53Z","merge_commit_sha":"0f65412650cbe8d03ea17463b49fa0b0bc87dec0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472/commits","review_comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472/comments","review_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2472/comments","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/5dd11d8ccebfbe6332480184356ab00866b97dc8","head":{"label":"shivambareria:fix-sk-2308","ref":"fix-sk-2308","sha":"5dd11d8ccebfbe6332480184356ab00866b97dc8","user":{"login":"shivambareria","id":10127187,"avatar_url":"https://avatars3.githubusercontent.com/u/10127187?v=4","gravatar_id":"","url":"https://api.github.com/users/shivambareria","html_url":"https://github.com/shivambareria","followers_url":"https://api.github.com/users/shivambareria/followers","following_url":"https://api.github.com/users/shivambareria/following{/other_user}","gists_url":"https://api.github.com/users/shivambareria/gists{/gist_id}","starred_url":"https://api.github.com/users/shivambareria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivambareria/subscriptions","organizations_url":"https://api.github.com/users/shivambareria/orgs","repos_url":"https://api.github.com/users/shivambareria/repos","events_url":"https://api.github.com/users/shivambareria/events{/privacy}","received_events_url":"https://api.github.com/users/shivambareria/received_events","type":"User","site_admin":false},"repo":{"id":97449720,"name":"Rock","full_name":"shivambareria/Rock","owner":{"login":"shivambareria","id":10127187,"avatar_url":"https://avatars3.githubusercontent.com/u/10127187?v=4","gravatar_id":"","url":"https://api.github.com/users/shivambareria","html_url":"https://github.com/shivambareria","followers_url":"https://api.github.com/users/shivambareria/followers","following_url":"https://api.github.com/users/shivambareria/following{/other_user}","gists_url":"https://api.github.com/users/shivambareria/gists{/gist_id}","starred_url":"https://api.github.com/users/shivambareria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivambareria/subscriptions","organizations_url":"https://api.github.com/users/shivambareria/orgs","repos_url":"https://api.github.com/users/shivambareria/repos","events_url":"https://api.github.com/users/shivambareria/events{/privacy}","received_events_url":"https://api.github.com/users/shivambareria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivambareria/Rock","description":"An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.","fork":true,"url":"https://api.github.com/repos/shivambareria/Rock","forks_url":"https://api.github.com/repos/shivambareria/Rock/forks","keys_url":"https://api.github.com/repos/shivambareria/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivambareria/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivambareria/Rock/teams","hooks_url":"https://api.github.com/repos/shivambareria/Rock/hooks","issue_events_url":"https://api.github.com/repos/shivambareria/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/shivambareria/Rock/events","assignees_url":"https://api.github.com/repos/shivambareria/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/shivambareria/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/shivambareria/Rock/tags","blobs_url":"https://api.github.com/repos/shivambareria/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivambareria/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivambareria/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivambareria/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivambareria/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/shivambareria/Rock/languages","stargazers_url":"https://api.github.com/repos/shivambareria/Rock/stargazers","contributors_url":"https://api.github.com/repos/shivambareria/Rock/contributors","subscribers_url":"https://api.github.com/repos/shivambareria/Rock/subscribers","subscription_url":"https://api.github.com/repos/shivambareria/Rock/subscription","commits_url":"https://api.github.com/repos/shivambareria/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivambareria/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivambareria/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivambareria/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivambareria/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/shivambareria/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivambareria/Rock/merges","archive_url":"https://api.github.com/repos/shivambareria/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivambareria/Rock/downloads","issues_url":"https://api.github.com/repos/shivambareria/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/shivambareria/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/shivambareria/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/shivambareria/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivambareria/Rock/labels{/name}","releases_url":"https://api.github.com/repos/shivambareria/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/shivambareria/Rock/deployments","created_at":"2017-07-17T07:52:28Z","updated_at":"2017-07-17T07:52:55Z","pushed_at":"2017-09-23T16:51:35Z","git_url":"git://github.com/shivambareria/Rock.git","ssh_url":"git@github.com:shivambareria/Rock.git","clone_url":"https://github.com/shivambareria/Rock.git","svn_url":"https://github.com/shivambareria/Rock","homepage":"http://www.rockrms.com","size":1187216,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"SparkDevNetwork:develop","ref":"develop","sha":"7529cd5b7fa9ef612df5eca555bd9ade9458d30b","user":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars2.githubusercontent.com/u/548191?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":1614137,"name":"Rock","full_name":"SparkDevNetwork/Rock","owner":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars2.githubusercontent.com/u/548191?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SparkDevNetwork/Rock","description":"An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.","fork":false,"url":"https://api.github.com/repos/SparkDevNetwork/Rock","forks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/forks","keys_url":"https://api.github.com/repos/SparkDevNetwork/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparkDevNetwork/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparkDevNetwork/Rock/teams","hooks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/hooks","issue_events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/events","assignees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/SparkDevNetwork/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/tags","blobs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/SparkDevNetwork/Rock/languages","stargazers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/stargazers","contributors_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contributors","subscribers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscribers","subscription_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscription","commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/SparkDevNetwork/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparkDevNetwork/Rock/merges","archive_url":"https://api.github.com/repos/SparkDevNetwork/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparkDevNetwork/Rock/downloads","issues_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/SparkDevNetwork/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/SparkDevNetwork/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparkDevNetwork/Rock/labels{/name}","releases_url":"https://api.github.com/repos/SparkDevNetwork/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/deployments","created_at":"2011-04-14T13:11:46Z","updated_at":"2017-09-22T14:58:56Z","pushed_at":"2017-09-24T14:35:53Z","git_url":"git://github.com/SparkDevNetwork/Rock.git","ssh_url":"git@github.com:SparkDevNetwork/Rock.git","clone_url":"https://github.com/SparkDevNetwork/Rock.git","svn_url":"https://github.com/SparkDevNetwork/Rock","homepage":"http://www.rockrms.com","size":1185190,"stargazers_count":221,"watchers_count":221,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":152,"mirror_url":null,"open_issues_count":242,"forks":152,"open_issues":242,"watchers":221,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472"},"html":{"href":"https://github.com/SparkDevNetwork/Rock/pull/2472"},"issue":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2472"},"comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2472/comments"},"review_comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472/comments"},"review_comment":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2472/commits"},"statuses":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/5dd11d8ccebfbe6332480184356ab00866b97dc8"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"azturner","id":548180,"avatar_url":"https://avatars3.githubusercontent.com/u/548180?v=4","gravatar_id":"","url":"https://api.github.com/users/azturner","html_url":"https://github.com/azturner","followers_url":"https://api.github.com/users/azturner/followers","following_url":"https://api.github.com/users/azturner/following{/other_user}","gists_url":"https://api.github.com/users/azturner/gists{/gist_id}","starred_url":"https://api.github.com/users/azturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azturner/subscriptions","organizations_url":"https://api.github.com/users/azturner/orgs","repos_url":"https://api.github.com/users/azturner/repos","events_url":"https://api.github.com/users/azturner/events{/privacy}","received_events_url":"https://api.github.com/users/azturner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":60,"deletions":30,"changed_files":1}}
{"actor":{"display_login":"azturner"}}