{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/10510","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/10510/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/10510/comments","events_url":"https://api.github.com/repos/electron/electron/issues/10510/events","html_url":"https://github.com/electron/electron/pull/10510","id":257519663,"number":10510,"title":"OSR fixes - devtools, dialogs","user":{"login":"brenca","id":1690458,"avatar_url":"https://avatars2.githubusercontent.com/u/1690458?v=4","gravatar_id":"","url":"https://api.github.com/users/brenca","html_url":"https://github.com/brenca","followers_url":"https://api.github.com/users/brenca/followers","following_url":"https://api.github.com/users/brenca/following{/other_user}","gists_url":"https://api.github.com/users/brenca/gists{/gist_id}","starred_url":"https://api.github.com/users/brenca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenca/subscriptions","organizations_url":"https://api.github.com/users/brenca/orgs","repos_url":"https://api.github.com/users/brenca/repos","events_url":"https://api.github.com/users/brenca/events{/privacy}","received_events_url":"https://api.github.com/users/brenca/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-09-13T21:00:18Z","updated_at":"2017-12-07T22:28:08Z","closed_at":"2017-11-13T09:04:35Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/10510","html_url":"https://github.com/electron/electron/pull/10510","diff_url":"https://github.com/electron/electron/pull/10510.diff","patch_url":"https://github.com/electron/electron/pull/10510.patch"},"body":"This PR aims to fix the following bugs:\r\n - devtools on Windows would crash when the user typed anything in the console (in detached state). This was related to the datalist element support that I added a while back. The normal window with the devtools  of an offscreen one, trying to show suggestions (this is where the datalist comes into play) confused the system enough to crash.\r\n - devtools for an offscreen window wouldn't render properly on MacOS\r\n - any dialogs (alert, confirm, download) would show the hidden dummy window on MacOS because these were modal dialogs. I fixed this by forcing the dialogs to be detached from any window in case the parent is offscreen.\r\n - datalist elements on windows wouldn't properly set the input's value when a suggestion was accepted. ( #9860 )\r\n- datalist elements didn't render at the proper position ( #11035 )"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/350114047","html_url":"https://github.com/electron/electron/pull/10510#issuecomment-350114047","issue_url":"https://api.github.com/repos/electron/electron/issues/10510","id":350114047,"user":{"login":"brenca","id":1690458,"avatar_url":"https://avatars2.githubusercontent.com/u/1690458?v=4","gravatar_id":"","url":"https://api.github.com/users/brenca","html_url":"https://github.com/brenca","followers_url":"https://api.github.com/users/brenca/followers","following_url":"https://api.github.com/users/brenca/following{/other_user}","gists_url":"https://api.github.com/users/brenca/gists{/gist_id}","starred_url":"https://api.github.com/users/brenca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenca/subscriptions","organizations_url":"https://api.github.com/users/brenca/orgs","repos_url":"https://api.github.com/users/brenca/repos","events_url":"https://api.github.com/users/brenca/events{/privacy}","received_events_url":"https://api.github.com/users/brenca/received_events","type":"User","site_admin":false},"created_at":"2017-12-07T22:28:08Z","updated_at":"2017-12-07T22:28:08Z","author_association":"MEMBER","body":"It's a bit hard to find, so actually I'm sorry. In the meantime, someone else posted an issue about this #11375."}}
{"actor":{"display_login":"brenca"}}