{"action":"opened","issue":{"url":"https://api.github.com/repos/NCAR/ParallelIO/issues/921","repository_url":"https://api.github.com/repos/NCAR/ParallelIO","labels_url":"https://api.github.com/repos/NCAR/ParallelIO/issues/921/labels{/name}","comments_url":"https://api.github.com/repos/NCAR/ParallelIO/issues/921/comments","events_url":"https://api.github.com/repos/NCAR/ParallelIO/issues/921/events","html_url":"https://github.com/NCAR/ParallelIO/issues/921","id":215253506,"number":921,"title":"compute_counts() only used with box rearranger","user":{"login":"edhartnett","id":4533212,"avatar_url":"https://avatars0.githubusercontent.com/u/4533212?v=3","gravatar_id":"","url":"https://api.github.com/users/edhartnett","html_url":"https://github.com/edhartnett","followers_url":"https://api.github.com/users/edhartnett/followers","following_url":"https://api.github.com/users/edhartnett/following{/other_user}","gists_url":"https://api.github.com/users/edhartnett/gists{/gist_id}","starred_url":"https://api.github.com/users/edhartnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhartnett/subscriptions","organizations_url":"https://api.github.com/users/edhartnett/orgs","repos_url":"https://api.github.com/users/edhartnett/repos","events_url":"https://api.github.com/users/edhartnett/events{/privacy}","received_events_url":"https://api.github.com/users/edhartnett/received_events","type":"User","site_admin":false},"labels":[{"id":191573877,"url":"https://api.github.com/repos/NCAR/ParallelIO/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"edhartnett","id":4533212,"avatar_url":"https://avatars0.githubusercontent.com/u/4533212?v=3","gravatar_id":"","url":"https://api.github.com/users/edhartnett","html_url":"https://github.com/edhartnett","followers_url":"https://api.github.com/users/edhartnett/followers","following_url":"https://api.github.com/users/edhartnett/following{/other_user}","gists_url":"https://api.github.com/users/edhartnett/gists{/gist_id}","starred_url":"https://api.github.com/users/edhartnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhartnett/subscriptions","organizations_url":"https://api.github.com/users/edhartnett/orgs","repos_url":"https://api.github.com/users/edhartnett/repos","events_url":"https://api.github.com/users/edhartnett/events{/privacy}","received_events_url":"https://api.github.com/users/edhartnett/received_events","type":"User","site_admin":false},"assignees":[{"login":"edhartnett","id":4533212,"avatar_url":"https://avatars0.githubusercontent.com/u/4533212?v=3","gravatar_id":"","url":"https://api.github.com/users/edhartnett","html_url":"https://github.com/edhartnett","followers_url":"https://api.github.com/users/edhartnett/followers","following_url":"https://api.github.com/users/edhartnett/following{/other_user}","gists_url":"https://api.github.com/users/edhartnett/gists{/gist_id}","starred_url":"https://api.github.com/users/edhartnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhartnett/subscriptions","organizations_url":"https://api.github.com/users/edhartnett/orgs","repos_url":"https://api.github.com/users/edhartnett/repos","events_url":"https://api.github.com/users/edhartnett/events{/privacy}","received_events_url":"https://api.github.com/users/edhartnett/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-19T10:01:15Z","updated_at":"2017-03-19T10:01:15Z","closed_at":null,"body":"The compute_counts() function contains code like this:\r\n\r\n```\r\n    /* Subset rearranger always gets 1 IO task. */\r\n    if (iodesc->rearranger == PIO_REARR_BOX)\r\n        numiotasks = ios->num_iotasks;\r\n    else\r\n        numiotasks = 1;\r\n\r\n```\r\n\r\nThe rearranger is checked at various points in the function. \r\n\r\nHowever, compute_counts() is only ever used for the box rearranger. It is not used by the subset rearranger.\r\n\r\nI put the following assert at the beginning of compute_counts():\r\n\r\n```\r\n    pioassert(ios && iodesc && maplen >= 0 && dest_ioproc && dest_ioindex &&\r\n              iodesc->rearranger == PIO_REARR_BOX, \"invalid input\", __FILE__, __LINE__);\r\n\r\n```\r\n\r\nWhich confirms that this function is never used for the subset rearranger. So all the subset rearranger code in compute_counts() can be removed."}}
{"actor":{"display_login":"edhartnett"}}