{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/137505714","pull_request_review_id":61180749,"id":137505714,"diff_hunk":"@@ -7,14 +7,16 @@\n     \"preload\": \"none\",\n     \"autoplay\": false,\n     \"muted\": false,\n-    \"options\": {\n+    \"tweaks\": {","path":"src/player-config.json","position":5,"original_position":5,"commit_id":"9ff6db92cddc217e4892e7026977517cc8581126","original_commit_id":"6df1742fe54f7d722dee68933f1d577e77889c1d","user":{"login":"dan-ziv","id":21081590,"avatar_url":"https://avatars2.githubusercontent.com/u/21081590?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-ziv","html_url":"https://github.com/dan-ziv","followers_url":"https://api.github.com/users/dan-ziv/followers","following_url":"https://api.github.com/users/dan-ziv/following{/other_user}","gists_url":"https://api.github.com/users/dan-ziv/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-ziv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-ziv/subscriptions","organizations_url":"https://api.github.com/users/dan-ziv/orgs","repos_url":"https://api.github.com/users/dan-ziv/repos","events_url":"https://api.github.com/users/dan-ziv/events{/privacy}","received_events_url":"https://api.github.com/users/dan-ziv/received_events","type":"User","site_admin":false},"body":"@OrenMe  if we're changing this key we should change also the reference in dash & hls adapters","created_at":"2017-09-07T10:44:49Z","updated_at":"2017-09-07T10:44:49Z","html_url":"https://github.com/kaltura/playkit-js/pull/106#discussion_r137505714","pull_request_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/137505714"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/106#discussion_r137505714"},"pull_request":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/106","id":139755867,"html_url":"https://github.com/kaltura/playkit-js/pull/106","diff_url":"https://github.com/kaltura/playkit-js/pull/106.diff","patch_url":"https://github.com/kaltura/playkit-js/pull/106.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-js/issues/106","number":106,"state":"open","locked":false,"title":"feat: allow setting native hls and dash playback","user":{"login":"OrenMe","id":5461862,"avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false},"body":"### Description of the Changes\r\n\r\nBy default we use HLS and Dash adapters for playback of HLS and Dash streams.\r\nThis feature will allow setting the required adapter to be native or not, so we can use native HLS playback on Safari for example.\r\n\r\n```json\r\n{\r\n  \"playback\": {\r\n    \"preferNative\": {\r\n      \"hls\": false,\r\n      \"dash\": false\r\n    }\r\n  }\r\n}\r\n```\r\n\r\n\r\n### CheckLists\r\n\r\n- [x] changes have been done against master branch, and PR does not conflict\r\n- [x] new unit / functional tests have been added (whenever applicable)\r\n- [x] test are passing in local environment \r\n- [x] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] Docs have been updated\r\n","created_at":"2017-09-07T09:23:09Z","updated_at":"2017-09-07T10:44:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d706e75db5b6fc2d89f38c986548a85896b28f4","assignee":{"login":"OrenMe","id":5461862,"avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false},"assignees":[{"login":"OrenMe","id":5461862,"avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yairans","id":17685520,"avatar_url":"https://avatars3.githubusercontent.com/u/17685520?v=4","gravatar_id":"","url":"https://api.github.com/users/yairans","html_url":"https://github.com/yairans","followers_url":"https://api.github.com/users/yairans/followers","following_url":"https://api.github.com/users/yairans/following{/other_user}","gists_url":"https://api.github.com/users/yairans/gists{/gist_id}","starred_url":"https://api.github.com/users/yairans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairans/subscriptions","organizations_url":"https://api.github.com/users/yairans/orgs","repos_url":"https://api.github.com/users/yairans/repos","events_url":"https://api.github.com/users/yairans/events{/privacy}","received_events_url":"https://api.github.com/users/yairans/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/106/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/106/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/issues/106/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/9ff6db92cddc217e4892e7026977517cc8581126","head":{"label":"kaltura:preferNative","ref":"preferNative","sha":"9ff6db92cddc217e4892e7026977517cc8581126","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"name":"playkit-js","full_name":"kaltura/playkit-js","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js","description":null,"fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2017-08-24T13:18:56Z","pushed_at":"2017-09-07T10:43:27Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":null,"size":43755,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"a8baf1d9fdcf0af7bad3ad9cb3dcf82da253779f","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"name":"playkit-js","full_name":"kaltura/playkit-js","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js","description":null,"fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2017-08-24T13:18:56Z","pushed_at":"2017-09-07T10:43:27Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":null,"size":43755,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/106"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/106"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/106"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-js/statuses/9ff6db92cddc217e4892e7026977517cc8581126"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dan-ziv"}}