{"action":"created","issue":{"url":"https://api.github.com/repos/CosmicMind/Material/issues/938","repository_url":"https://api.github.com/repos/CosmicMind/Material","labels_url":"https://api.github.com/repos/CosmicMind/Material/issues/938/labels{/name}","comments_url":"https://api.github.com/repos/CosmicMind/Material/issues/938/comments","events_url":"https://api.github.com/repos/CosmicMind/Material/issues/938/events","html_url":"https://github.com/CosmicMind/Material/pull/938","id":268231080,"number":938,"title":"TabsController - Missing logic","user":{"login":"markst","id":274318,"avatar_url":"https://avatars0.githubusercontent.com/u/274318?v=4","gravatar_id":"","url":"https://api.github.com/users/markst","html_url":"https://github.com/markst","followers_url":"https://api.github.com/users/markst/followers","following_url":"https://api.github.com/users/markst/following{/other_user}","gists_url":"https://api.github.com/users/markst/gists{/gist_id}","starred_url":"https://api.github.com/users/markst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markst/subscriptions","organizations_url":"https://api.github.com/users/markst/orgs","repos_url":"https://api.github.com/users/markst/repos","events_url":"https://api.github.com/users/markst/events{/privacy}","received_events_url":"https://api.github.com/users/markst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-25T00:39:19Z","updated_at":"2017-10-25T01:02:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CosmicMind/Material/pulls/938","html_url":"https://github.com/CosmicMind/Material/pull/938","diff_url":"https://github.com/CosmicMind/Material/pull/938.diff","patch_url":"https://github.com/CosmicMind/Material/pull/938.patch"},"body":"As outlined in #935 and provided fix in #936.\r\n\r\nHere is a PR again which provides the appropriate logic for adding the destination view controller to the child view controller stack & calls the appropriate appearance transitions in the correct order. \r\n"},"comment":{"url":"https://api.github.com/repos/CosmicMind/Material/issues/comments/339181232","html_url":"https://github.com/CosmicMind/Material/pull/938#issuecomment-339181232","issue_url":"https://api.github.com/repos/CosmicMind/Material/issues/938","id":339181232,"user":{"login":"markst","id":274318,"avatar_url":"https://avatars0.githubusercontent.com/u/274318?v=4","gravatar_id":"","url":"https://api.github.com/users/markst","html_url":"https://github.com/markst","followers_url":"https://api.github.com/users/markst/followers","following_url":"https://api.github.com/users/markst/following{/other_user}","gists_url":"https://api.github.com/users/markst/gists{/gist_id}","starred_url":"https://api.github.com/users/markst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markst/subscriptions","organizations_url":"https://api.github.com/users/markst/orgs","repos_url":"https://api.github.com/users/markst/repos","events_url":"https://api.github.com/users/markst/events{/privacy}","received_events_url":"https://api.github.com/users/markst/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T01:02:20Z","updated_at":"2017-10-25T01:02:20Z","author_association":"CONTRIBUTOR","body":"without this PR notice how the view lifecycle calls are performed way too many times. \r\n\r\n```\r\n<TabsController.GreenViewController: 0x7fb30760b260> viewWillAppear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.GreenViewController: 0x7fb30760b260> viewDidAppear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.GreenViewController: 0x7fb30760b260> viewWillDisappear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.CyanViewController: 0x7fb30760aa00> viewWillDisappear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.GreenViewController: 0x7fb30760b260> viewWillAppear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.GreenViewController: 0x7fb30760b260> viewDidAppear - Parent: Optional(<TabsController.AppTabsController: 0x7fb30760d5e0>)\r\n<TabsController.CyanViewController: 0x7fb30760aa00> viewDidDisappear - Parent: nil\r\n```\r\n\r\nvs. with this PR:\r\n\r\n```\r\n<TabsController.CyanViewController: 0x7f91eac04dd0> viewWillDisappear - Parent: Optional(<TabsController.AppTabsController: 0x7f91eac079b0>)\r\n<TabsController.GreenViewController: 0x7f91eac05630> viewWillAppear - Parent: nil\r\n<TabsController.CyanViewController: 0x7f91eac04dd0> viewDidDisappear - Parent: nil\r\n<TabsController.GreenViewController: 0x7f91eac05630> viewDidAppear - Parent: Optional(<TabsController.AppTabsController: 0x7f91eac079b0>)\r\n\r\n```\r\n"}}
{"actor":{"display_login":"markst"}}