{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/117813054","pull_request_review_id":39551266,"id":117813054,"diff_hunk":"@@ -376,13 +378,39 @@ func (b *glusterfsMounter) setUpAtInternal(dir string) error {\n \t\t}\n \n \t}\n-\n \toptions = append(options, \"backup-volfile-servers=\"+dstrings.Join(addrlist[:], \":\"))\n \n+\t//fetch client version.\n+\tmountBinaryVerStr := \"\"\n+\n+\tcmdOut, err := b.exe.Command(linuxGlusterMountBinary, \"-V\").CombinedOutput()\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"Failed to get binary %s version\", linuxGlusterMountBinary)\n+\t}\n+\t//parseStr will be filled with version line for eg# glusterfs 3.10.1","path":"pkg/volume/glusterfs/glusterfs.go","position":null,"original_position":66,"commit_id":"04bf95a5d1b2251eba5df159a6b222fd99333c7a","original_commit_id":"3f4db207277ad959f98a5427a1f02165e712dfaf","user":{"login":"humblec","id":5001742,"avatar_url":"https://avatars0.githubusercontent.com/u/5001742?v=3","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"body":"Added.","created_at":"2017-05-22T18:24:00Z","updated_at":"2017-05-22T18:24:00Z","html_url":"https://github.com/kubernetes/kubernetes/pull/45995#discussion_r117813054","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/117813054"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/45995#discussion_r117813054"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995","id":121149557,"html_url":"https://github.com/kubernetes/kubernetes/pull/45995","diff_url":"https://github.com/kubernetes/kubernetes/pull/45995.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45995.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45995","number":45995,"state":"open","locked":false,"title":"Add `auto_unmount` mount option for glusterfs fuse mount.","user":{"login":"humblec","id":5001742,"avatar_url":"https://avatars0.githubusercontent.com/u/5001742?v=3","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"body":"libfuse has an auto_unmount option which, if enabled, ensures that\r\nthe file system is unmounted at FUSE server termination by running a\r\nseparate monitor process that performs the unmount when that occurs.\r\n(This feature would probably better be called \"robust auto-unmount\",\r\nas FUSE servers usually do try to unmount their file systems upon\r\ntermination, it's just this mechanism is not crash resilient.)\r\nThis change implements that option and behavior for glusterfs.\r\n\r\nThis option will be only supported for clients with version >3.11.\r\n\r\nSigned-off-by: Humble Chirammal <hchiramm@redhat.com>\r\n\r\n","created_at":"2017-05-17T20:51:07Z","updated_at":"2017-05-22T18:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec7f1142dc4a1a7c2de7e3c0e6f70181dcf20f98","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars1.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars1.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars1.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"rootfs","id":7062400,"avatar_url":"https://avatars3.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45995/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/04bf95a5d1b2251eba5df159a6b222fd99333c7a","head":{"label":"humblec:glusterfs-mount-3","ref":"glusterfs-mount-3","sha":"04bf95a5d1b2251eba5df159a6b222fd99333c7a","user":{"login":"humblec","id":5001742,"avatar_url":"https://avatars0.githubusercontent.com/u/5001742?v=3","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"repo":{"id":22284752,"name":"kubernetes","full_name":"humblec/kubernetes","owner":{"login":"humblec","id":5001742,"avatar_url":"https://avatars0.githubusercontent.com/u/5001742?v=3","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/humblec/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/humblec/kubernetes","forks_url":"https://api.github.com/repos/humblec/kubernetes/forks","keys_url":"https://api.github.com/repos/humblec/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humblec/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humblec/kubernetes/teams","hooks_url":"https://api.github.com/repos/humblec/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/humblec/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/humblec/kubernetes/events","assignees_url":"https://api.github.com/repos/humblec/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/humblec/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/humblec/kubernetes/tags","blobs_url":"https://api.github.com/repos/humblec/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humblec/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humblec/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/humblec/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humblec/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/humblec/kubernetes/languages","stargazers_url":"https://api.github.com/repos/humblec/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/humblec/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/humblec/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/humblec/kubernetes/subscription","commits_url":"https://api.github.com/repos/humblec/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/humblec/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/humblec/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/humblec/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/humblec/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/humblec/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humblec/kubernetes/merges","archive_url":"https://api.github.com/repos/humblec/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humblec/kubernetes/downloads","issues_url":"https://api.github.com/repos/humblec/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/humblec/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/humblec/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/humblec/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humblec/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/humblec/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/humblec/kubernetes/deployments","created_at":"2014-07-26T10:58:59Z","updated_at":"2016-03-02T06:50:22Z","pushed_at":"2017-05-22T18:21:21Z","git_url":"git://github.com/humblec/kubernetes.git","ssh_url":"git@github.com:humblec/kubernetes.git","clone_url":"https://github.com/humblec/kubernetes.git","svn_url":"https://github.com/humblec/kubernetes","homepage":null,"size":422368,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"027c31e7dc9fcbb4eb3fd781a5966e81f00558c4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-05-22T18:22:21Z","pushed_at":"2017-05-22T18:21:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":649593,"stargazers_count":23376,"watchers_count":23376,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8228,"mirror_url":null,"open_issues_count":5573,"forks":8228,"open_issues":5573,"watchers":23376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/45995"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/45995"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/45995/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45995/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/04bf95a5d1b2251eba5df159a6b222fd99333c7a"}}}}
{"actor":{"display_login":"humblec"}}