{"action":"created","issue":{"url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/40","repository_url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react","labels_url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/40/comments","events_url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/40/events","html_url":"https://github.com/FreemapSlovakia/freemap-v3-react/pull/40","id":213615530,"number":40,"title":"#30: smarter map refocus on search results","user":{"login":"petervojtek","id":225506,"avatar_url":"https://avatars0.githubusercontent.com/u/225506?v=3","gravatar_id":"","url":"https://api.github.com/users/petervojtek","html_url":"https://github.com/petervojtek","followers_url":"https://api.github.com/users/petervojtek/followers","following_url":"https://api.github.com/users/petervojtek/following{/other_user}","gists_url":"https://api.github.com/users/petervojtek/gists{/gist_id}","starred_url":"https://api.github.com/users/petervojtek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petervojtek/subscriptions","organizations_url":"https://api.github.com/users/petervojtek/orgs","repos_url":"https://api.github.com/users/petervojtek/repos","events_url":"https://api.github.com/users/petervojtek/events{/privacy}","received_events_url":"https://api.github.com/users/petervojtek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-12T16:28:12Z","updated_at":"2017-03-21T06:27:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/pulls/40","html_url":"https://github.com/FreemapSlovakia/freemap-v3-react/pull/40","diff_url":"https://github.com/FreemapSlovakia/freemap-v3-react/pull/40.diff","patch_url":"https://github.com/FreemapSlovakia/freemap-v3-react/pull/40.patch"},"body":"Martin, ak si najdes cas, daj vediet ci sa ti pozdava takyto refocus mapy pre vysledky vyhladavania:\r\n* pre Points to funguje ako doteraz (zoom level 13)\r\n* pre polygons/polylines to prisposobuje zoom level aby bolo dobre vidiet aj vysledok, aj okolie.\r\n\r\nnepouzil som leaflet map.fitBounds, lebo to by som musel trochu viac prerabat react stavovy stroj a mal som obavy ako by to cele dopadlo. ten moj algoritmus fit-to-zoom som sa snazil nechat co najjednoduchsi, aby pokryl vacsinu pripadov (a neriesim polygony o velkosti SR)."},"comment":{"url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/comments/287988506","html_url":"https://github.com/FreemapSlovakia/freemap-v3-react/pull/40#issuecomment-287988506","issue_url":"https://api.github.com/repos/FreemapSlovakia/freemap-v3-react/issues/40","id":287988506,"user":{"login":"petervojtek","id":225506,"avatar_url":"https://avatars0.githubusercontent.com/u/225506?v=3","gravatar_id":"","url":"https://api.github.com/users/petervojtek","html_url":"https://github.com/petervojtek","followers_url":"https://api.github.com/users/petervojtek/followers","following_url":"https://api.github.com/users/petervojtek/following{/other_user}","gists_url":"https://api.github.com/users/petervojtek/gists{/gist_id}","starred_url":"https://api.github.com/users/petervojtek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petervojtek/subscriptions","organizations_url":"https://api.github.com/users/petervojtek/orgs","repos_url":"https://api.github.com/users/petervojtek/repos","events_url":"https://api.github.com/users/petervojtek/events{/privacy}","received_events_url":"https://api.github.com/users/petervojtek/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T06:27:51Z","updated_at":"2017-03-21T06:27:51Z","body":"ok, tento kod zahadzujem a vyrobil som pre ten ucel `mapAimedEventEmitter` - nazov ma naznacovat ze sluzi pre eventy ktore smeruju \"do mapy\".  7fd517c10ef047b\r\n\r\ntiez som oba emitteri presunut do spolocneho adresara a opravil som tvoj preklep (`mapEventEmmiter` -> `mapEventEmitter`) bacade020d233c3e\r\n\r\nale napriek tomu ze events robia kod jednoduchsim, je to cele take - zdvojene.\r\nlebo react actions su events a redux-logic je sposob ako sa na ne subscribnut a dispatch je emit. cize asi sme nezvolili najlepsie nastroje (dispatch, action, redux-logic), ked aj tak musime pouzivat este dalsi u kniznicu ktora robi to iste trochu inak. ale to je len teoreticky postreh, prakticke vyhody toho co nam sucasny stav umoznuje prevazuju :)"}}
{"actor":{"display_login":"petervojtek"}}