{"action":"created","issue":{"url":"https://api.github.com/repos/codaco/Network-Canvas/issues/257","repository_url":"https://api.github.com/repos/codaco/Network-Canvas","labels_url":"https://api.github.com/repos/codaco/Network-Canvas/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/codaco/Network-Canvas/issues/257/comments","events_url":"https://api.github.com/repos/codaco/Network-Canvas/issues/257/events","html_url":"https://github.com/codaco/Network-Canvas/pull/257","id":270122990,"number":257,"title":"Feature/ordinal bin interface","user":{"login":"SunjayDK","id":20175029,"avatar_url":"https://avatars2.githubusercontent.com/u/20175029?v=4","gravatar_id":"","url":"https://api.github.com/users/SunjayDK","html_url":"https://github.com/SunjayDK","followers_url":"https://api.github.com/users/SunjayDK/followers","following_url":"https://api.github.com/users/SunjayDK/following{/other_user}","gists_url":"https://api.github.com/users/SunjayDK/gists{/gist_id}","starred_url":"https://api.github.com/users/SunjayDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunjayDK/subscriptions","organizations_url":"https://api.github.com/users/SunjayDK/orgs","repos_url":"https://api.github.com/users/SunjayDK/repos","events_url":"https://api.github.com/users/SunjayDK/events{/privacy}","received_events_url":"https://api.github.com/users/SunjayDK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-31T21:20:51Z","updated_at":"2017-11-01T16:48:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codaco/Network-Canvas/pulls/257","html_url":"https://github.com/codaco/Network-Canvas/pull/257","diff_url":"https://github.com/codaco/Network-Canvas/pull/257.diff","patch_url":"https://github.com/codaco/Network-Canvas/pull/257.patch"},"body":"This adds the ordinal bin interface!\r\n\r\nI refactored the NodeBucket component slightly to allow it to be used in this context. Specifically, the onDropNode/handleDropNode function was moved from the NodeBucket out into the interface.\r\n\r\nThis does not include the tests yet; unfortunately I didn't have the chance to write them yet. It seems to function correctly currently though so they could be pretty easily built out from this."},"comment":{"url":"https://api.github.com/repos/codaco/Network-Canvas/issues/comments/341165587","html_url":"https://github.com/codaco/Network-Canvas/pull/257#issuecomment-341165587","issue_url":"https://api.github.com/repos/codaco/Network-Canvas/issues/257","id":341165587,"user":{"login":"rebeccamadsen","id":16093053,"avatar_url":"https://avatars3.githubusercontent.com/u/16093053?v=4","gravatar_id":"","url":"https://api.github.com/users/rebeccamadsen","html_url":"https://github.com/rebeccamadsen","followers_url":"https://api.github.com/users/rebeccamadsen/followers","following_url":"https://api.github.com/users/rebeccamadsen/following{/other_user}","gists_url":"https://api.github.com/users/rebeccamadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccamadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccamadsen/subscriptions","organizations_url":"https://api.github.com/users/rebeccamadsen/orgs","repos_url":"https://api.github.com/users/rebeccamadsen/repos","events_url":"https://api.github.com/users/rebeccamadsen/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccamadsen/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T16:48:37Z","updated_at":"2017-11-01T16:48:37Z","author_association":"CONTRIBUTOR","body":"I did not try altering the protocol yet or look closely at the code itself, just focused in this first look at the functionality.\r\n* general layout needs to scale better\r\n* opacity of the last column seems really dark? is this what specs call for?\r\n* size of the drop area should fill the column\r\n* if you change prompts, the placements of nodes are the same on every prompt. I imagine different prompts ought to allow different node placements.\r\n* there is a hover effect on bins? Is this right? If so, should there be a hover effect on the farthest left column too?\r\n* similarly the color of the drop area for the farthest left doesn't really show\r\n* the mouse changes to a hand when you hover over nodes, even if you cannot select the node (do we have an \"inactive\" class or something?)\r\n* menu item text probably needs a space between Ordinal and Bin, and the icon is just the default right now; I think the specs have a different icon\r\n* bins should be scrollable. if you fill a bin up the overflow is funky\r\n* download data shows labels like \"ORDINALBIN-3\" instead of the user friendly text"}}
{"actor":{"display_login":"rebeccamadsen"}}