{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/9800","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/9800/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/9800/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/9800/events","html_url":"https://github.com/fastlane/fastlane/pull/9800","id":243887626,"number":9800,"title":"fix: Encoded the url before passing to faraday","user":{"login":"rpranata","id":354678,"avatar_url":"https://avatars2.githubusercontent.com/u/354678?v=4","gravatar_id":"","url":"https://api.github.com/users/rpranata","html_url":"https://github.com/rpranata","followers_url":"https://api.github.com/users/rpranata/followers","following_url":"https://api.github.com/users/rpranata/following{/other_user}","gists_url":"https://api.github.com/users/rpranata/gists{/gist_id}","starred_url":"https://api.github.com/users/rpranata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpranata/subscriptions","organizations_url":"https://api.github.com/users/rpranata/orgs","repos_url":"https://api.github.com/users/rpranata/repos","events_url":"https://api.github.com/users/rpranata/events{/privacy}","received_events_url":"https://api.github.com/users/rpranata/received_events","type":"User","site_admin":false},"labels":[{"id":560541068,"url":"https://api.github.com/repos/fastlane/fastlane/labels/cla:%20no","name":"cla: no","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-19T00:14:40Z","updated_at":"2017-07-19T00:14:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/9800","html_url":"https://github.com/fastlane/fastlane/pull/9800","diff_url":"https://github.com/fastlane/fastlane/pull/9800.diff","patch_url":"https://github.com/fastlane/fastlane/pull/9800.patch"},"body":"This is to avoid failure when the url is valid but not encoded\r\n\r\n### Checklist\r\n🔑\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\nThe url metada in iTunes Connect can contain a non encoded url, like in our case, [https://moneytree.jp/個人情報保護方針/](https://moneytree.jp/個人情報保護方針/) that is a valid url. But running `bundle exec fastlane precheck` returns a failure.\r\n\r\nissue: https://github.com/fastlane/fastlane/issues/9798\r\n\r\n### Description\r\n\r\nIn `unreachable_url_rule.rb`, passing a non encoded url when initializing Faraday throws an exception. This exception is caught and a failure with unreachable url is returned.\r\n\r\n```\r\nirb(main):013:0> url = 'https://moneytree.jp/個人情報保護方針/'.to_s.strip\r\n=> \"https://moneytree.jp/個人情報保護方針/\"\r\nirb(main):014:0> request = Faraday.new(url)\r\nURI::InvalidURIError: bad URI(is not URI?): https://moneytree.jp/個人情報保護方針/\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/2.0.0/uri/common.rb:176:in `split'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/2.0.0/uri/common.rb:211:in `parse'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/2.0.0/uri/common.rb:747:in `parse'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/2.0.0/uri/common.rb:996:in `URI'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday/utils.rb:266:in `call'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday/utils.rb:266:in `URI'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday/connection.rb:318:in `url_prefix='\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday/connection.rb:77:in `initialize'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday.rb:67:in `new'\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/lib/ruby/gems/2.0.0/gems/faraday-0.12.1/lib/faraday.rb:67:in `new'\r\n\tfrom (irb):14\r\n\tfrom /Users/RenD/.rbenv/versions/2.0.0-p576/bin/irb:12:in `<main>'\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/316235224","html_url":"https://github.com/fastlane/fastlane/pull/9800#issuecomment-316235224","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/9800","id":316235224,"user":{"login":"googlebot","id":5384588,"avatar_url":"https://avatars3.githubusercontent.com/u/5384588?v=4","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2017-07-19T00:14:43Z","updated_at":"2017-07-19T00:14:43Z","body":"Thanks for your pull request.  It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please visit <https://cla.developers.google.com/> to sign.**\n\nOnce you've signed, please reply here (e.g. `I signed it!`) and we'll verify.  Thanks.\n\n---\n\n- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.\n- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.\n\n<!-- need_sender_cla -->"}}
{"actor":{"display_login":"googlebot"}}