{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/130186303","pull_request_review_id":53039236,"id":130186303,"diff_hunk":"@@ -380,6 +381,17 @@ this.ripple_ = new MDCRippleFoundation({\n });\n ```\n \n+## Caveat: Edge\n+\n+> TL;DR ripples are disabled in Edge because of issues with its support of CSS variables in pseudo elements.\n+\n+Edge introduced CSS variables in version 15.  Unfortunately, there are\n+[issues](https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11495448/)\n+involving its implementation for `::before` and `::after` pseudo-element selectors which cause ripples to\n+behave incorrectly.  We feature-detect one of these bugs and do not upgrade ripples if the bug is observed.","path":"packages/mdc-ripple/README.md","position":39,"original_position":39,"commit_id":"ea805ec0a3a1e2a0d0792ab1b7827e72f6a1ba2f","original_commit_id":"ea805ec0a3a1e2a0d0792ab1b7827e72f6a1ba2f","user":{"login":"lynnjepsen","id":4703432,"avatar_url":"https://avatars2.githubusercontent.com/u/4703432?v=4","gravatar_id":"","url":"https://api.github.com/users/lynnjepsen","html_url":"https://github.com/lynnjepsen","followers_url":"https://api.github.com/users/lynnjepsen/followers","following_url":"https://api.github.com/users/lynnjepsen/following{/other_user}","gists_url":"https://api.github.com/users/lynnjepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lynnjepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynnjepsen/subscriptions","organizations_url":"https://api.github.com/users/lynnjepsen/orgs","repos_url":"https://api.github.com/users/lynnjepsen/repos","events_url":"https://api.github.com/users/lynnjepsen/events{/privacy}","received_events_url":"https://api.github.com/users/lynnjepsen/received_events","type":"User","site_admin":false},"body":"\"one of these bugs\"....which one? Or is there only one \"issue\", in which case update the \"issues\" word in the second sentence.","created_at":"2017-07-28T21:06:17Z","updated_at":"2017-07-28T21:12:03Z","html_url":"https://github.com/material-components/material-components-web/pull/1041#discussion_r130186303","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1041","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/130186303"},"html":{"href":"https://github.com/material-components/material-components-web/pull/1041#discussion_r130186303"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1041"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/1041","id":133034515,"html_url":"https://github.com/material-components/material-components-web/pull/1041","diff_url":"https://github.com/material-components/material-components-web/pull/1041.diff","patch_url":"https://github.com/material-components/material-components-web/pull/1041.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/1041","number":1041,"state":"open","locked":false,"title":"fix(ripple): Feature-detect buggy Edge behavior for custom properties","user":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars2.githubusercontent.com/u/398379?v=4","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"This adds feature detection for buggy var() behavior in Edge WRT pseudo selectors, and will not upgrade ripples if the buggy behavior is found.\r\n\r\nBecause this adds quite a bit of logic (including DOM operations) to the function, this PR also changes the function to cache its result once a true or false result is obtained, much like we do for various other util functions.  This requires adding an optional force parameter to the function for tests to use.\r\n\r\nThis PR also updates tests and adds one to test the new case, and adds a section to the README.\r\n\r\nFixes #663.","created_at":"2017-07-28T19:16:13Z","updated_at":"2017-07-28T21:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb656fbc54b92787a9e2a55e084e3c60dae307a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1041/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1041/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/1041/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/ea805ec0a3a1e2a0d0792ab1b7827e72f6a1ba2f","head":{"label":"material-components:fix/edge-var-detect","ref":"fix/edge-var-detect","sha":"ea805ec0a3a1e2a0d0792ab1b7827e72f6a1ba2f","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-07-28T20:56:25Z","pushed_at":"2017-07-28T20:44:54Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":52689,"stargazers_count":5406,"watchers_count":5406,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":542,"mirror_url":null,"open_issues_count":193,"forks":542,"open_issues":193,"watchers":5406,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"38327daabad855158e8bc89d0ed3ba504fb12876","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-07-28T20:56:25Z","pushed_at":"2017-07-28T20:44:54Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":52689,"stargazers_count":5406,"watchers_count":5406,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":542,"mirror_url":null,"open_issues_count":193,"forks":542,"open_issues":193,"watchers":5406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1041"},"html":{"href":"https://github.com/material-components/material-components-web/pull/1041"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/1041"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/1041/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1041/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1041/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/ea805ec0a3a1e2a0d0792ab1b7827e72f6a1ba2f"}}}}
{"actor":{"display_login":"lynnjepsen"}}