{"action":"created","issue":{"url":"https://api.github.com/repos/dpopp07/bartop/issues/45","repository_url":"https://api.github.com/repos/dpopp07/bartop","labels_url":"https://api.github.com/repos/dpopp07/bartop/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/dpopp07/bartop/issues/45/comments","events_url":"https://api.github.com/repos/dpopp07/bartop/issues/45/events","html_url":"https://github.com/dpopp07/bartop/pull/45","id":274028840,"number":45,"title":"Add Styled Components","user":{"login":"jamesvclements","id":20052710,"avatar_url":"https://avatars2.githubusercontent.com/u/20052710?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesvclements","html_url":"https://github.com/jamesvclements","followers_url":"https://api.github.com/users/jamesvclements/followers","following_url":"https://api.github.com/users/jamesvclements/following{/other_user}","gists_url":"https://api.github.com/users/jamesvclements/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvclements/subscriptions","organizations_url":"https://api.github.com/users/jamesvclements/orgs","repos_url":"https://api.github.com/users/jamesvclements/repos","events_url":"https://api.github.com/users/jamesvclements/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvclements/received_events","type":"User","site_admin":false},"labels":[{"id":750807938,"url":"https://api.github.com/repos/dpopp07/bartop/labels/in%20progress","name":"in progress","color":"4be5ed","default":false},{"id":731293660,"url":"https://api.github.com/repos/dpopp07/bartop/labels/setup","name":"setup","color":"e99695","default":false},{"id":730145984,"url":"https://api.github.com/repos/dpopp07/bartop/labels/ui","name":"ui","color":"0253e0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-15T04:10:09Z","updated_at":"2017-11-16T06:04:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dpopp07/bartop/pulls/45","html_url":"https://github.com/dpopp07/bartop/pull/45","diff_url":"https://github.com/dpopp07/bartop/pull/45.diff","patch_url":"https://github.com/dpopp07/bartop/pull/45.patch"},"body":"- [x] Adds Styled Components\r\n- [x] Port CRA to Styled Components\r\n- [x] Follow the README to enable syntax highlighting (Babel & Theme)\r\n- [x] Enable Stylelinting for commits\r\n- [x] Enable Stylelinting in editor\r\n- [x] Add minification / class names for builds\r\n"},"comment":{"url":"https://api.github.com/repos/dpopp07/bartop/issues/comments/344825043","html_url":"https://github.com/dpopp07/bartop/pull/45#issuecomment-344825043","issue_url":"https://api.github.com/repos/dpopp07/bartop/issues/45","id":344825043,"user":{"login":"jamesvclements","id":20052710,"avatar_url":"https://avatars2.githubusercontent.com/u/20052710?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesvclements","html_url":"https://github.com/jamesvclements","followers_url":"https://api.github.com/users/jamesvclements/followers","following_url":"https://api.github.com/users/jamesvclements/following{/other_user}","gists_url":"https://api.github.com/users/jamesvclements/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvclements/subscriptions","organizations_url":"https://api.github.com/users/jamesvclements/orgs","repos_url":"https://api.github.com/users/jamesvclements/repos","events_url":"https://api.github.com/users/jamesvclements/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvclements/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T06:04:06Z","updated_at":"2017-11-16T06:04:06Z","author_association":"COLLABORATOR","body":"Okay so two steps on developers end:\r\n1. Enable Styled Components syntax highlighting in editor https://github.com/styled-components/styled-components#syntax-highlighting\r\n2. Enable StyleLint lint output editor integration\r\n\r\nFor VSCode, I had to do this:\r\n1. Install the VSCode Stylelint plugin (https://marketplace.visualstudio.com/items?itemName=shinnn.stylelint)\r\n2. Add these settings to my VSCode user settings:\r\n```\r\n// to match BarTop .stylelintrc and run on JS files\r\n    \"stylelint.enable\": true,\r\n    \"css.validate\": false,\r\n    \"scss.validate\": false,\r\n    \"stylelint.additionalDocumentSelectors\": [\"javascriptreact\"]\r\n```\r\n\r\nUnfortunately the VSCode plugin doesn't let you specify the absolute path to the StyleLint config file, so the editor highlighting only works if `client` is the root directory of the workspace. Shouldn't be too big of a deal, but I opened [an issue](https://github.com/shinnn/vscode-stylelint/issues/114) to see if it could be added.\r\n"}}
{"actor":{"display_login":"jamesvclements"}}