{"action":"created","issue":{"url":"https://api.github.com/repos/gradle/gradle/issues/2062","repository_url":"https://api.github.com/repos/gradle/gradle","labels_url":"https://api.github.com/repos/gradle/gradle/issues/2062/labels{/name}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/2062/comments","events_url":"https://api.github.com/repos/gradle/gradle/issues/2062/events","html_url":"https://github.com/gradle/gradle/pull/2062","id":229235967,"number":2062,"title":"Decouple Play and Twirl versions","user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars3.githubusercontent.com/u/322311?v=4","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"labels":[{"id":460356753,"url":"https://api.github.com/repos/gradle/gradle/labels/a:feature","name":"a:feature","color":"0e8a16","default":false},{"id":478384995,"url":"https://api.github.com/repos/gradle/gradle/labels/from:contributor","name":"from:contributor","color":"0052cc","default":false},{"id":281288606,"url":"https://api.github.com/repos/gradle/gradle/labels/in:play","name":"in:play","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"big-guy","id":5387972,"avatar_url":"https://avatars0.githubusercontent.com/u/5387972?v=4","gravatar_id":"","url":"https://api.github.com/users/big-guy","html_url":"https://github.com/big-guy","followers_url":"https://api.github.com/users/big-guy/followers","following_url":"https://api.github.com/users/big-guy/following{/other_user}","gists_url":"https://api.github.com/users/big-guy/gists{/gist_id}","starred_url":"https://api.github.com/users/big-guy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-guy/subscriptions","organizations_url":"https://api.github.com/users/big-guy/orgs","repos_url":"https://api.github.com/users/big-guy/repos","events_url":"https://api.github.com/users/big-guy/events{/privacy}","received_events_url":"https://api.github.com/users/big-guy/received_events","type":"User","site_admin":false},"assignees":[{"login":"big-guy","id":5387972,"avatar_url":"https://avatars0.githubusercontent.com/u/5387972?v=4","gravatar_id":"","url":"https://api.github.com/users/big-guy","html_url":"https://github.com/big-guy","followers_url":"https://api.github.com/users/big-guy/followers","following_url":"https://api.github.com/users/big-guy/following{/other_user}","gists_url":"https://api.github.com/users/big-guy/gists{/gist_id}","starred_url":"https://api.github.com/users/big-guy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-guy/subscriptions","organizations_url":"https://api.github.com/users/big-guy/orgs","repos_url":"https://api.github.com/users/big-guy/repos","events_url":"https://api.github.com/users/big-guy/events{/privacy}","received_events_url":"https://api.github.com/users/big-guy/received_events","type":"User","site_admin":false},{"login":"blindpirate","id":12689835,"avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2017-05-17T04:41:56Z","updated_at":"2017-11-23T04:01:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/2062","html_url":"https://github.com/gradle/gradle/pull/2062","diff_url":"https://github.com/gradle/gradle/pull/2062.diff","patch_url":"https://github.com/gradle/gradle/pull/2062.patch"},"body":"### Context\r\n\r\nThe imports should not be hardcoded in the TwirlCompilerAdapters so that we can mix and match versions of TwirlCompilerAdapters and versions of Play. This change will allow me to create a TwirlCompilerAdapterV13X for Twirl 1.3.x to be used with Play 2.6 while reusing the existing PlayTwirlAdapterV23X which is used for Play 2.3 - 2.5. This also theoretically makes it so that you can use varying versions of Twirl with a given version of Play, which is something that makes upgrades between Play versions easier, allows for pulling in bug fixes for Twirl separately, and is something supported by the SBT plugin.\r\n\r\nThis changes the imports to a List from which the concatenated string version is then constructed. This change is necessary because Twirl 1.3 expects a List. (Well maybe not strictly necessary as I could explode the concatenated string version into a List, but that wouldn't be as clean)\r\n\r\n### Contributor Checklist\r\n- [X] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/.github/CONTRIBUTING.md)\r\n- [X] [Sign Gradle CLA](http://gradle.org/contributor-license-agreement/)\r\n- [N/A] [Link to Design Spec](https://github.com/gradle/gradle/tree/master/design-docs) for changes that affect more than 1 public API (that is, not in an `internal` package) or updates to > 20 files\r\n- [X] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective\r\n- [X] Provide unit tests (under `<subproject>/src/test`) to verify logic\r\n- [N/A] Update User Guide, DSL Reference, and Javadoc for public-facing changes\r\n- [X] Ensure that tests pass locally: `./gradlew quickCheck :platformPlay:check`\r\n\r\n### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation including proper use of `@since` and `@Incubating` annotations for all public APIs\r\n- [ ] Recognize contributor in release notes\r\n"},"comment":{"url":"https://api.github.com/repos/gradle/gradle/issues/comments/346527845","html_url":"https://github.com/gradle/gradle/pull/2062#issuecomment-346527845","issue_url":"https://api.github.com/repos/gradle/gradle/issues/2062","id":346527845,"user":{"login":"blindpirate","id":12689835,"avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T04:01:48Z","updated_at":"2017-11-23T04:01:48Z","author_association":"CONTRIBUTOR","body":"Sure."}}
{"actor":{"display_login":"blindpirate"}}