{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/138871067","pull_request_review_id":62723862,"id":138871067,"diff_hunk":"@@ -1762,8 +1745,6 @@ void wallet2::refresh(uint64_t start_height, uint64_t & blocks_fetched, bool& re\n     catch (const std::exception&)\n     {\n       blocks_fetched += added_blocks;\n-      if (pull_thread.joinable())\n-        pull_thread.join();","path":"src/wallet/wallet2.cpp","position":140,"original_position":140,"commit_id":"e4b8c2434009c71330785be9bf579ea268af098e","original_commit_id":"b57fdba8ca0fabfe792914a5fde7e6f9bccfb0a4","user":{"login":"hyc","id":306354,"avatar_url":"https://avatars1.githubusercontent.com/u/306354?v=4","gravatar_id":"","url":"https://api.github.com/users/hyc","html_url":"https://github.com/hyc","followers_url":"https://api.github.com/users/hyc/followers","following_url":"https://api.github.com/users/hyc/following{/other_user}","gists_url":"https://api.github.com/users/hyc/gists{/gist_id}","starred_url":"https://api.github.com/users/hyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyc/subscriptions","organizations_url":"https://api.github.com/users/hyc/orgs","repos_url":"https://api.github.com/users/hyc/repos","events_url":"https://api.github.com/users/hyc/events{/privacy}","received_events_url":"https://api.github.com/users/hyc/received_events","type":"User","site_admin":false},"body":"Since it's using the pool there's nothing to cleanup here.","created_at":"2017-09-14T11:54:38Z","updated_at":"2017-09-14T11:54:38Z","html_url":"https://github.com/monero-project/monero/pull/2446#discussion_r138871067","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/2446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/138871067"},"html":{"href":"https://github.com/monero-project/monero/pull/2446#discussion_r138871067"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/2446"}},"in_reply_to_id":138868308},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/2446","id":140979251,"html_url":"https://github.com/monero-project/monero/pull/2446","diff_url":"https://github.com/monero-project/monero/pull/2446.diff","patch_url":"https://github.com/monero-project/monero/pull/2446.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/2446","number":2446,"state":"open","locked":false,"title":"Use a threadpool","user":{"login":"hyc","id":306354,"avatar_url":"https://avatars1.githubusercontent.com/u/306354?v=4","gravatar_id":"","url":"https://api.github.com/users/hyc","html_url":"https://github.com/hyc","followers_url":"https://api.github.com/users/hyc/followers","following_url":"https://api.github.com/users/hyc/following{/other_user}","gists_url":"https://api.github.com/users/hyc/gists{/gist_id}","starred_url":"https://api.github.com/users/hyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyc/subscriptions","organizations_url":"https://api.github.com/users/hyc/orgs","repos_url":"https://api.github.com/users/hyc/repos","events_url":"https://api.github.com/users/hyc/events{/privacy}","received_events_url":"https://api.github.com/users/hyc/received_events","type":"User","site_admin":false},"body":"Instead of constantly creating and destroying threads. Makes gdb sessions more tolerable too.\r\n","created_at":"2017-09-14T04:11:35Z","updated_at":"2017-09-14T11:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5493c5dde3d3ec8a4541b6b958208e92211c64d1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/2446/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/2446/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/2446/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/e4b8c2434009c71330785be9bf579ea268af098e","head":{"label":"LMDB:threadpool","ref":"threadpool","sha":"e4b8c2434009c71330785be9bf579ea268af098e","user":{"login":"LMDB","id":12072501,"avatar_url":"https://avatars1.githubusercontent.com/u/12072501?v=4","gravatar_id":"","url":"https://api.github.com/users/LMDB","html_url":"https://github.com/LMDB","followers_url":"https://api.github.com/users/LMDB/followers","following_url":"https://api.github.com/users/LMDB/following{/other_user}","gists_url":"https://api.github.com/users/LMDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMDB/subscriptions","organizations_url":"https://api.github.com/users/LMDB/orgs","repos_url":"https://api.github.com/users/LMDB/repos","events_url":"https://api.github.com/users/LMDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMDB/received_events","type":"Organization","site_admin":false},"repo":{"id":47730413,"name":"bitmonero","full_name":"LMDB/bitmonero","owner":{"login":"LMDB","id":12072501,"avatar_url":"https://avatars1.githubusercontent.com/u/12072501?v=4","gravatar_id":"","url":"https://api.github.com/users/LMDB","html_url":"https://github.com/LMDB","followers_url":"https://api.github.com/users/LMDB/followers","following_url":"https://api.github.com/users/LMDB/following{/other_user}","gists_url":"https://api.github.com/users/LMDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMDB/subscriptions","organizations_url":"https://api.github.com/users/LMDB/orgs","repos_url":"https://api.github.com/users/LMDB/repos","events_url":"https://api.github.com/users/LMDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMDB/bitmonero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/LMDB/bitmonero","forks_url":"https://api.github.com/repos/LMDB/bitmonero/forks","keys_url":"https://api.github.com/repos/LMDB/bitmonero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMDB/bitmonero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMDB/bitmonero/teams","hooks_url":"https://api.github.com/repos/LMDB/bitmonero/hooks","issue_events_url":"https://api.github.com/repos/LMDB/bitmonero/issues/events{/number}","events_url":"https://api.github.com/repos/LMDB/bitmonero/events","assignees_url":"https://api.github.com/repos/LMDB/bitmonero/assignees{/user}","branches_url":"https://api.github.com/repos/LMDB/bitmonero/branches{/branch}","tags_url":"https://api.github.com/repos/LMDB/bitmonero/tags","blobs_url":"https://api.github.com/repos/LMDB/bitmonero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMDB/bitmonero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMDB/bitmonero/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMDB/bitmonero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMDB/bitmonero/statuses/{sha}","languages_url":"https://api.github.com/repos/LMDB/bitmonero/languages","stargazers_url":"https://api.github.com/repos/LMDB/bitmonero/stargazers","contributors_url":"https://api.github.com/repos/LMDB/bitmonero/contributors","subscribers_url":"https://api.github.com/repos/LMDB/bitmonero/subscribers","subscription_url":"https://api.github.com/repos/LMDB/bitmonero/subscription","commits_url":"https://api.github.com/repos/LMDB/bitmonero/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMDB/bitmonero/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMDB/bitmonero/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMDB/bitmonero/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMDB/bitmonero/contents/{+path}","compare_url":"https://api.github.com/repos/LMDB/bitmonero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMDB/bitmonero/merges","archive_url":"https://api.github.com/repos/LMDB/bitmonero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMDB/bitmonero/downloads","issues_url":"https://api.github.com/repos/LMDB/bitmonero/issues{/number}","pulls_url":"https://api.github.com/repos/LMDB/bitmonero/pulls{/number}","milestones_url":"https://api.github.com/repos/LMDB/bitmonero/milestones{/number}","notifications_url":"https://api.github.com/repos/LMDB/bitmonero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMDB/bitmonero/labels{/name}","releases_url":"https://api.github.com/repos/LMDB/bitmonero/releases{/id}","deployments_url":"https://api.github.com/repos/LMDB/bitmonero/deployments","created_at":"2015-12-10T01:41:00Z","updated_at":"2017-04-14T07:32:22Z","pushed_at":"2017-09-14T11:26:27Z","git_url":"git://github.com/LMDB/bitmonero.git","ssh_url":"git@github.com:LMDB/bitmonero.git","clone_url":"https://github.com/LMDB/bitmonero.git","svn_url":"https://github.com/LMDB/bitmonero","homepage":"https://getmonero.org","size":131841,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"02e5dcd2fab07c46b4943028cfabecbba4745b58","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"name":"monero","full_name":"monero-project/monero","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2017-09-14T11:38:08Z","pushed_at":"2017-09-14T11:26:29Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":131008,"stargazers_count":1012,"watchers_count":1012,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":464,"mirror_url":null,"open_issues_count":230,"forks":464,"open_issues":230,"watchers":1012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/2446"},"html":{"href":"https://github.com/monero-project/monero/pull/2446"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/2446"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/2446/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/2446/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/2446/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/e4b8c2434009c71330785be9bf579ea268af098e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hyc"}}