{"action":"created","issue":{"url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/22","repository_url":"https://api.github.com/repos/lunarok/jeedom_MQTT","labels_url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/22/comments","events_url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/22/events","html_url":"https://github.com/lunarok/jeedom_MQTT/issues/22","id":276528144,"number":22,"title":"Nettoyage du code","user":{"login":"Steph3147","id":26516939,"avatar_url":"https://avatars0.githubusercontent.com/u/26516939?v=4","gravatar_id":"","url":"https://api.github.com/users/Steph3147","html_url":"https://github.com/Steph3147","followers_url":"https://api.github.com/users/Steph3147/followers","following_url":"https://api.github.com/users/Steph3147/following{/other_user}","gists_url":"https://api.github.com/users/Steph3147/gists{/gist_id}","starred_url":"https://api.github.com/users/Steph3147/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steph3147/subscriptions","organizations_url":"https://api.github.com/users/Steph3147/orgs","repos_url":"https://api.github.com/users/Steph3147/repos","events_url":"https://api.github.com/users/Steph3147/events{/privacy}","received_events_url":"https://api.github.com/users/Steph3147/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-24T06:50:04Z","updated_at":"2017-11-25T07:28:52Z","closed_at":"2017-11-25T07:28:52Z","author_association":"NONE","body":"Bonjour Lunarok,\r\n\r\nJ'ai vu que tu as effectué un profond nettoyage du code comme annoncé :smile:.\r\nEst-ce que le fonctionnement est compatible ascendant? Autrement dit, peut-on procéder à l'update sans précautions particulières (autre que sauvegarde au cas où bien sûr)?\r\n\r\nEn regardant la fonction publishMosquitto je me demande pourquoi tu ouvres un client spécifique pour publier, ce qui oblige à faire une boucle d'attente peu élégante avant fermeture?... Il serait plus propre, et plus dans l'esprit MQTT (un seul client par objet pour recevoir et publier), d'utiliser le client ouvert dans la fonction daemon (mais peut-être que Jeedom ne le permet pas - je débute...).\r\n\r\nEncore merci pour ta contribution immense.\r\nStéphane (StephC sur le forum)\r\n"},"comment":{"url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/comments/346924297","html_url":"https://github.com/lunarok/jeedom_MQTT/issues/22#issuecomment-346924297","issue_url":"https://api.github.com/repos/lunarok/jeedom_MQTT/issues/22","id":346924297,"user":{"login":"lunarok","id":1303626,"avatar_url":"https://avatars2.githubusercontent.com/u/1303626?v=4","gravatar_id":"","url":"https://api.github.com/users/lunarok","html_url":"https://github.com/lunarok","followers_url":"https://api.github.com/users/lunarok/followers","following_url":"https://api.github.com/users/lunarok/following{/other_user}","gists_url":"https://api.github.com/users/lunarok/gists{/gist_id}","starred_url":"https://api.github.com/users/lunarok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunarok/subscriptions","organizations_url":"https://api.github.com/users/lunarok/orgs","repos_url":"https://api.github.com/users/lunarok/repos","events_url":"https://api.github.com/users/lunarok/events{/privacy}","received_events_url":"https://api.github.com/users/lunarok/received_events","type":"User","site_admin":false},"created_at":"2017-11-25T07:28:52Z","updated_at":"2017-11-25T07:28:52Z","author_association":"OWNER","body":"Normalement ca doit passer, au pire il va trouver de nouvelles commandes vu qu'il est repassé en mode \"simple\" (mais c'est vraiment volontaire, je n'aime pas faire des usines à gaz en options et pour l'utilisateur final c'est démoralisant si pour commencer il faut connaitre ca par coeur)"}}
{"actor":{"display_login":"lunarok"}}