{"action":"created","issue":{"url":"https://api.github.com/repos/OpenNews/opennews-source/issues/54","repository_url":"https://api.github.com/repos/OpenNews/opennews-source","labels_url":"https://api.github.com/repos/OpenNews/opennews-source/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/OpenNews/opennews-source/issues/54/comments","events_url":"https://api.github.com/repos/OpenNews/opennews-source/issues/54/events","html_url":"https://github.com/OpenNews/opennews-source/issues/54","id":204147514,"number":54,"title":"JavaScript issue on staging?","user":{"login":"beep","id":124493,"avatar_url":"https://avatars.githubusercontent.com/u/124493?v=3","gravatar_id":"","url":"https://api.github.com/users/beep","html_url":"https://github.com/beep","followers_url":"https://api.github.com/users/beep/followers","following_url":"https://api.github.com/users/beep/following{/other_user}","gists_url":"https://api.github.com/users/beep/gists{/gist_id}","starred_url":"https://api.github.com/users/beep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beep/subscriptions","organizations_url":"https://api.github.com/users/beep/orgs","repos_url":"https://api.github.com/users/beep/repos","events_url":"https://api.github.com/users/beep/events{/privacy}","received_events_url":"https://api.github.com/users/beep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ryanpitts","id":56477,"avatar_url":"https://avatars.githubusercontent.com/u/56477?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpitts","html_url":"https://github.com/ryanpitts","followers_url":"https://api.github.com/users/ryanpitts/followers","following_url":"https://api.github.com/users/ryanpitts/following{/other_user}","gists_url":"https://api.github.com/users/ryanpitts/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpitts/subscriptions","organizations_url":"https://api.github.com/users/ryanpitts/orgs","repos_url":"https://api.github.com/users/ryanpitts/repos","events_url":"https://api.github.com/users/ryanpitts/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpitts/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryanpitts","id":56477,"avatar_url":"https://avatars.githubusercontent.com/u/56477?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpitts","html_url":"https://github.com/ryanpitts","followers_url":"https://api.github.com/users/ryanpitts/followers","following_url":"https://api.github.com/users/ryanpitts/following{/other_user}","gists_url":"https://api.github.com/users/ryanpitts/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpitts/subscriptions","organizations_url":"https://api.github.com/users/ryanpitts/orgs","repos_url":"https://api.github.com/users/ryanpitts/repos","events_url":"https://api.github.com/users/ryanpitts/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpitts/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-01-30T22:20:15Z","updated_at":"2017-01-31T17:52:55Z","closed_at":null,"body":"Seeing a really weird bug on most staging server URLs:\r\n\r\n```\r\n17:16:07.741 jQuery.Deferred exception: Argument 1 of Window.getComputedStyle is not an object. _isNonInteractive@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:26799\r\n_checkInteractivity@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:27046\r\n_bindEvents@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:27383\r\ninit@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:26157\r\nr@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:25620\r\ne.fn[a]/<@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:28283\r\neach@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:14861\r\neach@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:13031\r\ne.fn[a]@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:28245\r\n@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:28344\r\ndispatch@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:18828\r\nadd/A.handle@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:16882\r\ntrigger@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:8099\r\ntrigger/<@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:8613\r\neach@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:14861\r\neach@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:13031\r\ntrigger@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:3:8592\r\n@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:4:27511\r\nu@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:9226\r\na/</f<@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:9543\r\nsetTimeout handler*a/<@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:9754\r\nd@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:7464\r\nfireWith@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:8240\r\nfire@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:8274\r\nd@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:7464\r\nfireWith@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:8240\r\nready@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:11245\r\nsetTimeout handler*@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:2:11379\r\n@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:220\r\n@https://opennews-source-staging.herokuapp.com/static/base/_v2/dist/js/main.js:1:2\r\n undefined 1 main.js:2:10821\r\n```\r\n\r\nNever seen anything quite like this. It seems to be preventing the JS from fully executing, which is causing some JS/errors. And I can’t replicate that locally! (On the static templates, anyway.)\r\n\r\n(Noticed on #43, ping)"},"comment":{"url":"https://api.github.com/repos/OpenNews/opennews-source/issues/comments/276439026","html_url":"https://github.com/OpenNews/opennews-source/issues/54#issuecomment-276439026","issue_url":"https://api.github.com/repos/OpenNews/opennews-source/issues/54","id":276439026,"user":{"login":"ryanpitts","id":56477,"avatar_url":"https://avatars.githubusercontent.com/u/56477?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpitts","html_url":"https://github.com/ryanpitts","followers_url":"https://api.github.com/users/ryanpitts/followers","following_url":"https://api.github.com/users/ryanpitts/following{/other_user}","gists_url":"https://api.github.com/users/ryanpitts/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpitts/subscriptions","organizations_url":"https://api.github.com/users/ryanpitts/orgs","repos_url":"https://api.github.com/users/ryanpitts/repos","events_url":"https://api.github.com/users/ryanpitts/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpitts/received_events","type":"User","site_admin":false},"created_at":"2017-01-31T17:52:55Z","updated_at":"2017-01-31T17:52:55Z","body":"oh nice! Sorry about the Pacific Time lag here, but that's awesome. Re: the two questions you posted:\r\n\r\n1. If you're marginally comfortable with Python, we could totally do that. The biggest issue would be setting up the test database, which currently involves a fun time with postgresql. I could look into making a sqlite test db if this feels like a useful thing though.\r\n2. Django's template `include` for inlining objects works a bit differently than PHP's `include` from what I can tell -- the most important difference being that Django verifies that you're including a template-like object, and straight javascript files don't seem to work. (I'd never tried doing this before, but I banged around on it last week, and at least at that point this was the conclusion I reached.) It would still be possible to inline `initial.js` by making an `initial.js.html` template for Django purposes, though. Or I might be able to find another solution. I set that aside in favor of just linking via `script` tag to get things moving, and planned to ask how important inlining might be here."}}
{"actor":{"display_login":"ryanpitts"}}