{"action":"opened","number":13238,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238","id":158598464,"html_url":"https://github.com/CartoDB/cartodb/pull/13238","diff_url":"https://github.com/CartoDB/cartodb/pull/13238.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13238.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13238","number":13238,"state":"open","locked":false,"title":"Updates app_config.yml.sample for unit tests","user":{"login":"bb-acarrera","id":27735868,"avatar_url":"https://avatars3.githubusercontent.com/u/27735868?v=4","gravatar_id":"","url":"https://api.github.com/users/bb-acarrera","html_url":"https://github.com/bb-acarrera","followers_url":"https://api.github.com/users/bb-acarrera/followers","following_url":"https://api.github.com/users/bb-acarrera/following{/other_user}","gists_url":"https://api.github.com/users/bb-acarrera/gists{/gist_id}","starred_url":"https://api.github.com/users/bb-acarrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb-acarrera/subscriptions","organizations_url":"https://api.github.com/users/bb-acarrera/orgs","repos_url":"https://api.github.com/users/bb-acarrera/repos","events_url":"https://api.github.com/users/bb-acarrera/events{/privacy}","received_events_url":"https://api.github.com/users/bb-acarrera/received_events","type":"User","site_admin":false},"body":"The unit tests expect session_domain to be '.localhost.lan' and subdomainless_urls to be false.  Therefore by setting these values in the \"test\" section of app_config.yml.sample it'll reduce the chances that users who overwrite this in other environments will have failures running the unit tests.\r\n\r\nThis address Issue #13218 ","created_at":"2017-12-15T13:03:14Z","updated_at":"2017-12-15T13:03:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13238/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/7d2d50834280626e3643b55f1a6c7bd474409bff","head":{"label":"bb-acarrera:13218-domain_params_in_test_env","ref":"13218-domain_params_in_test_env","sha":"7d2d50834280626e3643b55f1a6c7bd474409bff","user":{"login":"bb-acarrera","id":27735868,"avatar_url":"https://avatars3.githubusercontent.com/u/27735868?v=4","gravatar_id":"","url":"https://api.github.com/users/bb-acarrera","html_url":"https://github.com/bb-acarrera","followers_url":"https://api.github.com/users/bb-acarrera/followers","following_url":"https://api.github.com/users/bb-acarrera/following{/other_user}","gists_url":"https://api.github.com/users/bb-acarrera/gists{/gist_id}","starred_url":"https://api.github.com/users/bb-acarrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb-acarrera/subscriptions","organizations_url":"https://api.github.com/users/bb-acarrera/orgs","repos_url":"https://api.github.com/users/bb-acarrera/repos","events_url":"https://api.github.com/users/bb-acarrera/events{/privacy}","received_events_url":"https://api.github.com/users/bb-acarrera/received_events","type":"User","site_admin":false},"repo":{"id":99846450,"name":"cartodb","full_name":"bb-acarrera/cartodb","owner":{"login":"bb-acarrera","id":27735868,"avatar_url":"https://avatars3.githubusercontent.com/u/27735868?v=4","gravatar_id":"","url":"https://api.github.com/users/bb-acarrera","html_url":"https://github.com/bb-acarrera","followers_url":"https://api.github.com/users/bb-acarrera/followers","following_url":"https://api.github.com/users/bb-acarrera/following{/other_user}","gists_url":"https://api.github.com/users/bb-acarrera/gists{/gist_id}","starred_url":"https://api.github.com/users/bb-acarrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb-acarrera/subscriptions","organizations_url":"https://api.github.com/users/bb-acarrera/orgs","repos_url":"https://api.github.com/users/bb-acarrera/repos","events_url":"https://api.github.com/users/bb-acarrera/events{/privacy}","received_events_url":"https://api.github.com/users/bb-acarrera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bb-acarrera/cartodb","description":"Location Intelligence & Data Visualization tool","fork":true,"url":"https://api.github.com/repos/bb-acarrera/cartodb","forks_url":"https://api.github.com/repos/bb-acarrera/cartodb/forks","keys_url":"https://api.github.com/repos/bb-acarrera/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bb-acarrera/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bb-acarrera/cartodb/teams","hooks_url":"https://api.github.com/repos/bb-acarrera/cartodb/hooks","issue_events_url":"https://api.github.com/repos/bb-acarrera/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/bb-acarrera/cartodb/events","assignees_url":"https://api.github.com/repos/bb-acarrera/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/bb-acarrera/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/bb-acarrera/cartodb/tags","blobs_url":"https://api.github.com/repos/bb-acarrera/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bb-acarrera/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bb-acarrera/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bb-acarrera/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bb-acarrera/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/bb-acarrera/cartodb/languages","stargazers_url":"https://api.github.com/repos/bb-acarrera/cartodb/stargazers","contributors_url":"https://api.github.com/repos/bb-acarrera/cartodb/contributors","subscribers_url":"https://api.github.com/repos/bb-acarrera/cartodb/subscribers","subscription_url":"https://api.github.com/repos/bb-acarrera/cartodb/subscription","commits_url":"https://api.github.com/repos/bb-acarrera/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bb-acarrera/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bb-acarrera/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bb-acarrera/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bb-acarrera/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/bb-acarrera/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bb-acarrera/cartodb/merges","archive_url":"https://api.github.com/repos/bb-acarrera/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bb-acarrera/cartodb/downloads","issues_url":"https://api.github.com/repos/bb-acarrera/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/bb-acarrera/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/bb-acarrera/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/bb-acarrera/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bb-acarrera/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/bb-acarrera/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/bb-acarrera/cartodb/deployments","created_at":"2017-08-09T19:40:41Z","updated_at":"2017-08-09T19:41:00Z","pushed_at":"2017-12-15T13:01:24Z","git_url":"git://github.com/bb-acarrera/cartodb.git","ssh_url":"git@github.com:bb-acarrera/cartodb.git","clone_url":"https://github.com/bb-acarrera/cartodb.git","svn_url":"https://github.com/bb-acarrera/cartodb","homepage":"http://carto.com","size":360291,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"1c77b5d59845ca739201af48f1260d4a3ae8969b","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2017-12-15T08:20:05Z","pushed_at":"2017-12-15T12:44:31Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":366810,"stargazers_count":1672,"watchers_count":1672,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":779,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":473,"open_issues":779,"watchers":1672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13238"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13238"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13238/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13238/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/7d2d50834280626e3643b55f1a6c7bd474409bff"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bb-acarrera"}}