{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/123120448","pull_request_review_id":45293652,"id":123120448,"diff_hunk":"@@ -13,13 +13,21 @@\n                xmlns=\"urn:activemq\"\n                xsi:schemaLocation=\"urn:activemq /schema/artemis-configuration.xsd\">\n \n-    <jms xmlns=\"urn:activemq:jms\">\n-        <queue name=\"DLQ\"/>\n-        <queue name=\"ExpiryQueue\"/>\n-    </jms>\n-\n     <core xmlns=\"urn:activemq:core\">\n \n+        <addresses>\n+            <address name=\"DLQ\">\n+                <anycast>","path":"distribution/ddf-common/src/main/resources/etc/artemis-backup.xml","position":13,"original_position":13,"commit_id":"144d37abb7c12afafe39a1b24718ba7af937afc5","original_commit_id":"144d37abb7c12afafe39a1b24718ba7af937afc5","user":{"login":"harrison-tarr","id":14062223,"avatar_url":"https://avatars3.githubusercontent.com/u/14062223?v=3","gravatar_id":"","url":"https://api.github.com/users/harrison-tarr","html_url":"https://github.com/harrison-tarr","followers_url":"https://api.github.com/users/harrison-tarr/followers","following_url":"https://api.github.com/users/harrison-tarr/following{/other_user}","gists_url":"https://api.github.com/users/harrison-tarr/gists{/gist_id}","starred_url":"https://api.github.com/users/harrison-tarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrison-tarr/subscriptions","organizations_url":"https://api.github.com/users/harrison-tarr/orgs","repos_url":"https://api.github.com/users/harrison-tarr/repos","events_url":"https://api.github.com/users/harrison-tarr/events{/privacy}","received_events_url":"https://api.github.com/users/harrison-tarr/received_events","type":"User","site_admin":false},"body":"What does this anycast mean?","created_at":"2017-06-20T23:19:13Z","updated_at":"2017-06-20T23:21:35Z","html_url":"https://github.com/codice/ddf/pull/2075#discussion_r123120448","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/2075","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/123120448"},"html":{"href":"https://github.com/codice/ddf/pull/2075#discussion_r123120448"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/2075"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/2075","id":126406801,"html_url":"https://github.com/codice/ddf/pull/2075","diff_url":"https://github.com/codice/ddf/pull/2075.diff","patch_url":"https://github.com/codice/ddf/pull/2075.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/2075","number":2075,"state":"open","locked":false,"title":"DDF-3029 Upgrade Artemis to 2.1.0","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars2.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nUpgrades Artemis to 2.1.0. \r\n\r\n-Artemis fixed a glitch that required appending JMS prefixes: \"jms.queue\" or \"jms.topic\" to queue/topic names when brokering messages via AMQP, now it's not necessary to append the JMS prefixes. Removed the JMS prefixes for the DLQ and Expiry queues defined in the artemis.xml.\r\n-Uncommented the password-codec and mask-password elements in the artemis.xml to allow password encryption within the file. (There was a bug in the previous version of artemis that prevented us from doing this)\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?\r\n@harrison-tarr \r\n@ryeats \r\n@jrnorth \r\n@derekwilhelm \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@jaymcnallie\r\n@kcwire\r\n@pklinef\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nRun a full build. Make sure itests pass. Start DDF, and install all artemis features to verify they can start up.\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-3029](https://codice.atlassian.net/browse/)\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [X] Documentation Updated\r\n- [ ] Change Log Updated\r\n- [X] Update / Add Unit Tests\r\n- [X] Update / Add Integration Tests\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2017-06-19T21:57:58Z","updated_at":"2017-06-20T23:21:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c374d1419eebab64a515ced04f675ffa4864df1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/2075/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/2075/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/2075/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/144d37abb7c12afafe39a1b24718ba7af937afc5","head":{"label":"roelens8:DDF-3029","ref":"DDF-3029","sha":"144d37abb7c12afafe39a1b24718ba7af937afc5","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars2.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"repo":{"id":37481426,"name":"ddf","full_name":"roelens8/ddf","owner":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars2.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roelens8/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/roelens8/ddf","forks_url":"https://api.github.com/repos/roelens8/ddf/forks","keys_url":"https://api.github.com/repos/roelens8/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roelens8/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roelens8/ddf/teams","hooks_url":"https://api.github.com/repos/roelens8/ddf/hooks","issue_events_url":"https://api.github.com/repos/roelens8/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/roelens8/ddf/events","assignees_url":"https://api.github.com/repos/roelens8/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/roelens8/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/roelens8/ddf/tags","blobs_url":"https://api.github.com/repos/roelens8/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roelens8/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roelens8/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roelens8/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roelens8/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/roelens8/ddf/languages","stargazers_url":"https://api.github.com/repos/roelens8/ddf/stargazers","contributors_url":"https://api.github.com/repos/roelens8/ddf/contributors","subscribers_url":"https://api.github.com/repos/roelens8/ddf/subscribers","subscription_url":"https://api.github.com/repos/roelens8/ddf/subscription","commits_url":"https://api.github.com/repos/roelens8/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roelens8/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roelens8/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roelens8/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roelens8/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/roelens8/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roelens8/ddf/merges","archive_url":"https://api.github.com/repos/roelens8/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roelens8/ddf/downloads","issues_url":"https://api.github.com/repos/roelens8/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/roelens8/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/roelens8/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/roelens8/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roelens8/ddf/labels{/name}","releases_url":"https://api.github.com/repos/roelens8/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/roelens8/ddf/deployments","created_at":"2015-06-15T17:55:32Z","updated_at":"2015-06-15T17:55:33Z","pushed_at":"2017-06-20T20:42:25Z","git_url":"git://github.com/roelens8/ddf.git","ssh_url":"git@github.com:roelens8/ddf.git","clone_url":"https://github.com/roelens8/ddf.git","svn_url":"https://github.com/roelens8/ddf","homepage":"","size":166602,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"53d880c44d2a8170bf33556d91a64d2cb680e13a","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2017-04-12T02:00:28Z","pushed_at":"2017-06-20T22:32:29Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":322247,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":30,"forks":112,"open_issues":30,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/2075"},"html":{"href":"https://github.com/codice/ddf/pull/2075"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/2075"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/2075/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/2075/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/2075/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/144d37abb7c12afafe39a1b24718ba7af937afc5"}}}}
{"actor":{"display_login":"harrison-tarr"}}