{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/comments/132809763","pull_request_review_id":55935862,"id":132809763,"diff_hunk":"@@ -0,0 +1,84 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+'use strict';\n+\n+const ModelUtils = require('../modelutil');\n+\n+/**\n+ * All the identifying properties of a resource.\n+ * @private\n+ * @class\n+ * @memberof module:composer-common\n+ * @property {String} protocol\n+ * @property {String} namespace\n+ * @property {String} type\n+ * @property {String} id\n+ */\n+class Identifier {\n+    /**\n+     * <strong>Note: only for use by internal framework code.</strong>\n+     * @param {String} protocol - Protocol.\n+     * @param {String} namespace - Namespace containing the type.\n+     * @param {String} type - Short type name.\n+     * @param {String} id - Instance identifier.\n+     * @private\n+     */\n+    constructor(protocol, namespace, type, id) {\n+        this.protocol = protocol;\n+        this.namespace = namespace;\n+        this.type = type;\n+        this.id = id;\n+    }\n+\n+    /**\n+     * Parse a URI into an identifier.\n+     * @param {String} uri - Resource URI.\n+     * @param {String} [defaultNamespace] - Namespace to use if the URI does not specify one.\n+     * @param {String} [defaultType] - Type to use if the URI does not specify one.\n+     * @return {Identifier} - An identifier.\n+     */\n+    static fromUri(uri, defaultNamespace, defaultType) {","path":"packages/composer-common/lib/model/identifier.js","position":52,"original_position":52,"commit_id":"493e8a046efd93e84d1555629a41047151057a13","original_commit_id":"493e8a046efd93e84d1555629a41047151057a13","user":{"login":"sstone1","id":7118158,"avatar_url":"https://avatars2.githubusercontent.com/u/7118158?v=4","gravatar_id":"","url":"https://api.github.com/users/sstone1","html_url":"https://github.com/sstone1","followers_url":"https://api.github.com/users/sstone1/followers","following_url":"https://api.github.com/users/sstone1/following{/other_user}","gists_url":"https://api.github.com/users/sstone1/gists{/gist_id}","starred_url":"https://api.github.com/users/sstone1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstone1/subscriptions","organizations_url":"https://api.github.com/users/sstone1/orgs","repos_url":"https://api.github.com/users/sstone1/repos","events_url":"https://api.github.com/users/sstone1/events{/privacy}","received_events_url":"https://api.github.com/users/sstone1/received_events","type":"User","site_admin":false},"body":"Why is this `fromUri` and not `fromURI` as per the existing code?","created_at":"2017-08-12T04:50:41Z","updated_at":"2017-08-12T04:50:41Z","html_url":"https://github.com/hyperledger/composer/pull/1849#discussion_r132809763","pull_request_url":"https://api.github.com/repos/hyperledger/composer/pulls/1849","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments/132809763"},"html":{"href":"https://github.com/hyperledger/composer/pull/1849#discussion_r132809763"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1849"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/1849","id":135348496,"html_url":"https://github.com/hyperledger/composer/pull/1849","diff_url":"https://github.com/hyperledger/composer/pull/1849.diff","patch_url":"https://github.com/hyperledger/composer/pull/1849.patch","issue_url":"https://api.github.com/repos/hyperledger/composer/issues/1849","number":1849,"state":"open","locked":false,"title":"Handle colon (:) in ID portion of resource URIs","user":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars3.githubusercontent.com/u/4856862?v=4","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"body":"Composer identity issue fails for participant ids containing colons #1805\r\n\r\nSigned-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>","created_at":"2017-08-11T14:30:44Z","updated_at":"2017-08-12T04:50:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14de859e63888cd7d05b761849a8167fb560b143","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/composer/pulls/1849/commits","review_comments_url":"https://api.github.com/repos/hyperledger/composer/pulls/1849/comments","review_comment_url":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/composer/issues/1849/comments","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/493e8a046efd93e84d1555629a41047151057a13","head":{"label":"bestbeforetoday:1805","ref":"1805","sha":"493e8a046efd93e84d1555629a41047151057a13","user":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars3.githubusercontent.com/u/4856862?v=4","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"repo":{"id":94881424,"name":"composer","full_name":"bestbeforetoday/composer","owner":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars3.githubusercontent.com/u/4856862?v=4","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bestbeforetoday/composer","description":"Composer is a framework for building Blockchain business networks","fork":true,"url":"https://api.github.com/repos/bestbeforetoday/composer","forks_url":"https://api.github.com/repos/bestbeforetoday/composer/forks","keys_url":"https://api.github.com/repos/bestbeforetoday/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bestbeforetoday/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bestbeforetoday/composer/teams","hooks_url":"https://api.github.com/repos/bestbeforetoday/composer/hooks","issue_events_url":"https://api.github.com/repos/bestbeforetoday/composer/issues/events{/number}","events_url":"https://api.github.com/repos/bestbeforetoday/composer/events","assignees_url":"https://api.github.com/repos/bestbeforetoday/composer/assignees{/user}","branches_url":"https://api.github.com/repos/bestbeforetoday/composer/branches{/branch}","tags_url":"https://api.github.com/repos/bestbeforetoday/composer/tags","blobs_url":"https://api.github.com/repos/bestbeforetoday/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bestbeforetoday/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bestbeforetoday/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/bestbeforetoday/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bestbeforetoday/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/bestbeforetoday/composer/languages","stargazers_url":"https://api.github.com/repos/bestbeforetoday/composer/stargazers","contributors_url":"https://api.github.com/repos/bestbeforetoday/composer/contributors","subscribers_url":"https://api.github.com/repos/bestbeforetoday/composer/subscribers","subscription_url":"https://api.github.com/repos/bestbeforetoday/composer/subscription","commits_url":"https://api.github.com/repos/bestbeforetoday/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/bestbeforetoday/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/bestbeforetoday/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/bestbeforetoday/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/bestbeforetoday/composer/contents/{+path}","compare_url":"https://api.github.com/repos/bestbeforetoday/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bestbeforetoday/composer/merges","archive_url":"https://api.github.com/repos/bestbeforetoday/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bestbeforetoday/composer/downloads","issues_url":"https://api.github.com/repos/bestbeforetoday/composer/issues{/number}","pulls_url":"https://api.github.com/repos/bestbeforetoday/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/bestbeforetoday/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/bestbeforetoday/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bestbeforetoday/composer/labels{/name}","releases_url":"https://api.github.com/repos/bestbeforetoday/composer/releases{/id}","deployments_url":"https://api.github.com/repos/bestbeforetoday/composer/deployments","created_at":"2017-06-20T10:55:35Z","updated_at":"2017-06-20T10:55:40Z","pushed_at":"2017-08-11T14:59:55Z","git_url":"git://github.com/bestbeforetoday/composer.git","ssh_url":"git@github.com:bestbeforetoday/composer.git","clone_url":"https://github.com/bestbeforetoday/composer.git","svn_url":"https://github.com/bestbeforetoday/composer","homepage":"https://hyperledger.github.io/composer","size":78541,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"701c5e152b3ee595dd5c20cecc1ae54d987d7b12","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":80234065,"name":"composer","full_name":"hyperledger/composer","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/composer","description":"Composer is a framework for building Blockchain business networks","fork":false,"url":"https://api.github.com/repos/hyperledger/composer","forks_url":"https://api.github.com/repos/hyperledger/composer/forks","keys_url":"https://api.github.com/repos/hyperledger/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/composer/teams","hooks_url":"https://api.github.com/repos/hyperledger/composer/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/composer/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/composer/events","assignees_url":"https://api.github.com/repos/hyperledger/composer/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/composer/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/composer/tags","blobs_url":"https://api.github.com/repos/hyperledger/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/composer/languages","stargazers_url":"https://api.github.com/repos/hyperledger/composer/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/composer/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/composer/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/composer/subscription","commits_url":"https://api.github.com/repos/hyperledger/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/composer/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/composer/merges","archive_url":"https://api.github.com/repos/hyperledger/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/composer/downloads","issues_url":"https://api.github.com/repos/hyperledger/composer/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/composer/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/composer/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/composer/deployments","created_at":"2017-01-27T18:27:47Z","updated_at":"2017-08-11T22:20:25Z","pushed_at":"2017-08-12T01:36:26Z","git_url":"git://github.com/hyperledger/composer.git","ssh_url":"git@github.com:hyperledger/composer.git","clone_url":"https://github.com/hyperledger/composer.git","svn_url":"https://github.com/hyperledger/composer","homepage":"https://hyperledger.github.io/composer","size":101944,"stargazers_count":224,"watchers_count":224,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":272,"forks":153,"open_issues":272,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1849"},"html":{"href":"https://github.com/hyperledger/composer/pull/1849"},"issue":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1849"},"comments":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1849/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1849/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1849/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/composer/statuses/493e8a046efd93e84d1555629a41047151057a13"}}}}
{"actor":{"display_login":"sstone1"}}