{"action":"created","issue":{"url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/64","repository_url":"https://api.github.com/repos/JohannesBuchner/imagehash","labels_url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/64/comments","events_url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/64/events","html_url":"https://github.com/JohannesBuchner/imagehash/pull/64","id":270825039,"number":64,"title":"Fix  binary array to hex","user":{"login":"djunzu","id":8784122,"avatar_url":"https://avatars2.githubusercontent.com/u/8784122?v=4","gravatar_id":"","url":"https://api.github.com/users/djunzu","html_url":"https://github.com/djunzu","followers_url":"https://api.github.com/users/djunzu/followers","following_url":"https://api.github.com/users/djunzu/following{/other_user}","gists_url":"https://api.github.com/users/djunzu/gists{/gist_id}","starred_url":"https://api.github.com/users/djunzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djunzu/subscriptions","organizations_url":"https://api.github.com/users/djunzu/orgs","repos_url":"https://api.github.com/users/djunzu/repos","events_url":"https://api.github.com/users/djunzu/events{/privacy}","received_events_url":"https://api.github.com/users/djunzu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-11-02T22:15:05Z","updated_at":"2017-12-07T22:08:30Z","closed_at":"2017-12-06T23:12:11Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JohannesBuchner/imagehash/pulls/64","html_url":"https://github.com/JohannesBuchner/imagehash/pull/64","diff_url":"https://github.com/JohannesBuchner/imagehash/pull/64.diff","patch_url":"https://github.com/JohannesBuchner/imagehash/pull/64.patch"},"body":"Fix _binary_array_to_hex as discussed in #51\r\n\r\nFixing _binary_array_to_hex demands hex_to_hash to be changed as well. That makes hex_to_hash incompatible with hex values generate with previous versions of ImageHash. For that reason, the old implementation is available as old_hex_to_hash in order to allow users convert old hex values back to hashes.\r\n\r\nBecause of that, I think that this PR should be followed by a major release and the README should point out how to upgrade.\r\n\r\nRegarding the new version of hex_to_hash:\r\n- It assumes all hashes are bidimensional arrays with dimensions hash_size * hash_size. This is the current behavior of all hashes.\r\n- The implementation does not work for hash_size < 2. (But hash_size = 1 does not make sense anyway.\r\n\r\nThis PR also fix some tests.\r\nThis PR closes #51."},"comment":{"url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/comments/350109585","html_url":"https://github.com/JohannesBuchner/imagehash/pull/64#issuecomment-350109585","issue_url":"https://api.github.com/repos/JohannesBuchner/imagehash/issues/64","id":350109585,"user":{"login":"djunzu","id":8784122,"avatar_url":"https://avatars2.githubusercontent.com/u/8784122?v=4","gravatar_id":"","url":"https://api.github.com/users/djunzu","html_url":"https://github.com/djunzu","followers_url":"https://api.github.com/users/djunzu/followers","following_url":"https://api.github.com/users/djunzu/following{/other_user}","gists_url":"https://api.github.com/users/djunzu/gists{/gist_id}","starred_url":"https://api.github.com/users/djunzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djunzu/subscriptions","organizations_url":"https://api.github.com/users/djunzu/orgs","repos_url":"https://api.github.com/users/djunzu/repos","events_url":"https://api.github.com/users/djunzu/events{/privacy}","received_events_url":"https://api.github.com/users/djunzu/received_events","type":"User","site_admin":false},"created_at":"2017-12-07T22:08:30Z","updated_at":"2017-12-07T22:08:30Z","author_association":"NONE","body":"Working!\r\n🎉 "}}
{"actor":{"display_login":"djunzu"}}