{"action":"opened","number":198,"pull_request":{"url":"https://api.github.com/repos/JacORB/JacORB/pulls/198","id":127906876,"html_url":"https://github.com/JacORB/JacORB/pull/198","diff_url":"https://github.com/JacORB/JacORB/pull/198.diff","patch_url":"https://github.com/JacORB/JacORB/pull/198.patch","issue_url":"https://api.github.com/repos/JacORB/JacORB/issues/198","number":198,"state":"open","locked":false,"title":"Fixed a bug in NotificationService which caused ConcurrentModificationExceptions","user":{"login":"JohannesPulla","id":29745388,"avatar_url":"https://avatars1.githubusercontent.com/u/29745388?v=3","gravatar_id":"","url":"https://api.github.com/users/JohannesPulla","html_url":"https://github.com/JohannesPulla","followers_url":"https://api.github.com/users/JohannesPulla/followers","following_url":"https://api.github.com/users/JohannesPulla/following{/other_user}","gists_url":"https://api.github.com/users/JohannesPulla/gists{/gist_id}","starred_url":"https://api.github.com/users/JohannesPulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohannesPulla/subscriptions","organizations_url":"https://api.github.com/users/JohannesPulla/orgs","repos_url":"https://api.github.com/users/JohannesPulla/repos","events_url":"https://api.github.com/users/JohannesPulla/events{/privacy}","received_events_url":"https://api.github.com/users/JohannesPulla/received_events","type":"User","site_admin":false},"body":"I fixed a bug where adding a new message filter or filter matching in NotificationService caused ConcurrentModificationException while iterating filters. \r\n\r\nFollowing warning was logged when iterating filters failed:\r\n\r\nWARN StructuredEventMessage:565 - unexpected error during match. match result defaults to false\r\njava.util.ConcurrentModificationException\r\n    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[?:1.8.0_51]\r\n    at java.util.ArrayList$Itr.next(ArrayList.java:851) ~[?:1.8.0_51]\r\n    at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1042) ~[?:1.8.0_51]\r\n    at org.jacorb.notification.AbstractMessage.match(AbstractMessage.java:551) [?:3.7]\r\n    at org.jacorb.notification.AbstractMessage$MessageHandle.match(AbstractMessage.java:241) [?:3.7]\r\n    at org.jacorb.notification.engine.FilterProxySupplierTask.filter(FilterProxySupplierTask.java:221) [?:3.7]\r\n    at org.jacorb.notification.engine.FilterProxySupplierTask.doFilter(FilterProxySupplierTask.java:117) [?:3.7]\r\n    at org.jacorb.notification.engine.AbstractFilterTask.doWork(AbstractFilterTask.java:76) [?:3.7]\r\n    at org.jacorb.notification.engine.AbstractTask.run(AbstractTask.java:63) [?:3.7]\r\n    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_51]\r\n    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_51]\r\n    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]\r\n\r\n\r\nAnother problem was that sorting filters while adding new filter threw ConcurrentModificationException:\r\n\r\nERROR FilterConsumerAdminTask:148 - Error while Filtering in Task:FilterConsumerAdminTask#3483\r\njava.util.ConcurrentModificationException\r\n    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[?:1.8.0_51]\r\n    at java.util.ArrayList$Itr.next(ArrayList.java:851) ~[?:1.8.0_51]\r\n    at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1042) ~[?:1.8.0_51]\r\n    at org.jacorb.notification.engine.AbstractFilterTask.addFilterStage(AbstractFilterTask.java:105) ~[?:3.7]\r\n    at org.jacorb.notification.engine.FilterConsumerAdminTask.filter(FilterConsumerAdminTask.java:137) ~[?:3.7]\r\n    at org.jacorb.notification.engine.FilterConsumerAdminTask.doFilter(FilterConsumerAdminTask.java:82) ~[?:3.7]\r\n    at org.jacorb.notification.engine.AbstractFilterTask.doWork(AbstractFilterTask.java:76) [?:3.7]\r\n    at org.jacorb.notification.engine.AbstractTask.run(AbstractTask.java:63) [?:3.7]\r\n    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_51]\r\n    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_51]\r\n    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]\r\n\r\nI wrote also a test for FilterManager but it is more like a system test with requirements for concurrency. It is not included to source control.\r\n\r\n[FilterManagerTest.zip](https://github.com/JacORB/JacORB/files/1108609/FilterManagerTest.zip)\r\n\r\n","created_at":"2017-06-28T12:07:16Z","updated_at":"2017-06-28T12:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JacORB/JacORB/pulls/198/commits","review_comments_url":"https://api.github.com/repos/JacORB/JacORB/pulls/198/comments","review_comment_url":"https://api.github.com/repos/JacORB/JacORB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JacORB/JacORB/issues/198/comments","statuses_url":"https://api.github.com/repos/JacORB/JacORB/statuses/1edc6b4bf87dc5548fa57a82d20aa371df193e1b","head":{"label":"JohannesPulla:master","ref":"master","sha":"1edc6b4bf87dc5548fa57a82d20aa371df193e1b","user":{"login":"JohannesPulla","id":29745388,"avatar_url":"https://avatars1.githubusercontent.com/u/29745388?v=3","gravatar_id":"","url":"https://api.github.com/users/JohannesPulla","html_url":"https://github.com/JohannesPulla","followers_url":"https://api.github.com/users/JohannesPulla/followers","following_url":"https://api.github.com/users/JohannesPulla/following{/other_user}","gists_url":"https://api.github.com/users/JohannesPulla/gists{/gist_id}","starred_url":"https://api.github.com/users/JohannesPulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohannesPulla/subscriptions","organizations_url":"https://api.github.com/users/JohannesPulla/orgs","repos_url":"https://api.github.com/users/JohannesPulla/repos","events_url":"https://api.github.com/users/JohannesPulla/events{/privacy}","received_events_url":"https://api.github.com/users/JohannesPulla/received_events","type":"User","site_admin":false},"repo":{"id":95641426,"name":"JacORB","full_name":"JohannesPulla/JacORB","owner":{"login":"JohannesPulla","id":29745388,"avatar_url":"https://avatars1.githubusercontent.com/u/29745388?v=3","gravatar_id":"","url":"https://api.github.com/users/JohannesPulla","html_url":"https://github.com/JohannesPulla","followers_url":"https://api.github.com/users/JohannesPulla/followers","following_url":"https://api.github.com/users/JohannesPulla/following{/other_user}","gists_url":"https://api.github.com/users/JohannesPulla/gists{/gist_id}","starred_url":"https://api.github.com/users/JohannesPulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohannesPulla/subscriptions","organizations_url":"https://api.github.com/users/JohannesPulla/orgs","repos_url":"https://api.github.com/users/JohannesPulla/repos","events_url":"https://api.github.com/users/JohannesPulla/events{/privacy}","received_events_url":"https://api.github.com/users/JohannesPulla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohannesPulla/JacORB","description":"JacORB ORB","fork":true,"url":"https://api.github.com/repos/JohannesPulla/JacORB","forks_url":"https://api.github.com/repos/JohannesPulla/JacORB/forks","keys_url":"https://api.github.com/repos/JohannesPulla/JacORB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohannesPulla/JacORB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohannesPulla/JacORB/teams","hooks_url":"https://api.github.com/repos/JohannesPulla/JacORB/hooks","issue_events_url":"https://api.github.com/repos/JohannesPulla/JacORB/issues/events{/number}","events_url":"https://api.github.com/repos/JohannesPulla/JacORB/events","assignees_url":"https://api.github.com/repos/JohannesPulla/JacORB/assignees{/user}","branches_url":"https://api.github.com/repos/JohannesPulla/JacORB/branches{/branch}","tags_url":"https://api.github.com/repos/JohannesPulla/JacORB/tags","blobs_url":"https://api.github.com/repos/JohannesPulla/JacORB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohannesPulla/JacORB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohannesPulla/JacORB/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohannesPulla/JacORB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohannesPulla/JacORB/statuses/{sha}","languages_url":"https://api.github.com/repos/JohannesPulla/JacORB/languages","stargazers_url":"https://api.github.com/repos/JohannesPulla/JacORB/stargazers","contributors_url":"https://api.github.com/repos/JohannesPulla/JacORB/contributors","subscribers_url":"https://api.github.com/repos/JohannesPulla/JacORB/subscribers","subscription_url":"https://api.github.com/repos/JohannesPulla/JacORB/subscription","commits_url":"https://api.github.com/repos/JohannesPulla/JacORB/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohannesPulla/JacORB/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohannesPulla/JacORB/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohannesPulla/JacORB/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohannesPulla/JacORB/contents/{+path}","compare_url":"https://api.github.com/repos/JohannesPulla/JacORB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohannesPulla/JacORB/merges","archive_url":"https://api.github.com/repos/JohannesPulla/JacORB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohannesPulla/JacORB/downloads","issues_url":"https://api.github.com/repos/JohannesPulla/JacORB/issues{/number}","pulls_url":"https://api.github.com/repos/JohannesPulla/JacORB/pulls{/number}","milestones_url":"https://api.github.com/repos/JohannesPulla/JacORB/milestones{/number}","notifications_url":"https://api.github.com/repos/JohannesPulla/JacORB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohannesPulla/JacORB/labels{/name}","releases_url":"https://api.github.com/repos/JohannesPulla/JacORB/releases{/id}","deployments_url":"https://api.github.com/repos/JohannesPulla/JacORB/deployments","created_at":"2017-06-28T07:26:38Z","updated_at":"2017-06-28T07:26:45Z","pushed_at":"2017-06-28T11:08:11Z","git_url":"git://github.com/JohannesPulla/JacORB.git","ssh_url":"git@github.com:JohannesPulla/JacORB.git","clone_url":"https://github.com/JohannesPulla/JacORB.git","svn_url":"https://github.com/JohannesPulla/JacORB","homepage":null,"size":56511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JacORB:master","ref":"master","sha":"beaf5e3a5ec6c79047be7663ef91c93b327304cd","user":{"login":"JacORB","id":1194095,"avatar_url":"https://avatars3.githubusercontent.com/u/1194095?v=3","gravatar_id":"","url":"https://api.github.com/users/JacORB","html_url":"https://github.com/JacORB","followers_url":"https://api.github.com/users/JacORB/followers","following_url":"https://api.github.com/users/JacORB/following{/other_user}","gists_url":"https://api.github.com/users/JacORB/gists{/gist_id}","starred_url":"https://api.github.com/users/JacORB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacORB/subscriptions","organizations_url":"https://api.github.com/users/JacORB/orgs","repos_url":"https://api.github.com/users/JacORB/repos","events_url":"https://api.github.com/users/JacORB/events{/privacy}","received_events_url":"https://api.github.com/users/JacORB/received_events","type":"Organization","site_admin":false},"repo":{"id":4738719,"name":"JacORB","full_name":"JacORB/JacORB","owner":{"login":"JacORB","id":1194095,"avatar_url":"https://avatars3.githubusercontent.com/u/1194095?v=3","gravatar_id":"","url":"https://api.github.com/users/JacORB","html_url":"https://github.com/JacORB","followers_url":"https://api.github.com/users/JacORB/followers","following_url":"https://api.github.com/users/JacORB/following{/other_user}","gists_url":"https://api.github.com/users/JacORB/gists{/gist_id}","starred_url":"https://api.github.com/users/JacORB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacORB/subscriptions","organizations_url":"https://api.github.com/users/JacORB/orgs","repos_url":"https://api.github.com/users/JacORB/repos","events_url":"https://api.github.com/users/JacORB/events{/privacy}","received_events_url":"https://api.github.com/users/JacORB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JacORB/JacORB","description":"JacORB ORB","fork":false,"url":"https://api.github.com/repos/JacORB/JacORB","forks_url":"https://api.github.com/repos/JacORB/JacORB/forks","keys_url":"https://api.github.com/repos/JacORB/JacORB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacORB/JacORB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacORB/JacORB/teams","hooks_url":"https://api.github.com/repos/JacORB/JacORB/hooks","issue_events_url":"https://api.github.com/repos/JacORB/JacORB/issues/events{/number}","events_url":"https://api.github.com/repos/JacORB/JacORB/events","assignees_url":"https://api.github.com/repos/JacORB/JacORB/assignees{/user}","branches_url":"https://api.github.com/repos/JacORB/JacORB/branches{/branch}","tags_url":"https://api.github.com/repos/JacORB/JacORB/tags","blobs_url":"https://api.github.com/repos/JacORB/JacORB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacORB/JacORB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacORB/JacORB/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacORB/JacORB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacORB/JacORB/statuses/{sha}","languages_url":"https://api.github.com/repos/JacORB/JacORB/languages","stargazers_url":"https://api.github.com/repos/JacORB/JacORB/stargazers","contributors_url":"https://api.github.com/repos/JacORB/JacORB/contributors","subscribers_url":"https://api.github.com/repos/JacORB/JacORB/subscribers","subscription_url":"https://api.github.com/repos/JacORB/JacORB/subscription","commits_url":"https://api.github.com/repos/JacORB/JacORB/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacORB/JacORB/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacORB/JacORB/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacORB/JacORB/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacORB/JacORB/contents/{+path}","compare_url":"https://api.github.com/repos/JacORB/JacORB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacORB/JacORB/merges","archive_url":"https://api.github.com/repos/JacORB/JacORB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacORB/JacORB/downloads","issues_url":"https://api.github.com/repos/JacORB/JacORB/issues{/number}","pulls_url":"https://api.github.com/repos/JacORB/JacORB/pulls{/number}","milestones_url":"https://api.github.com/repos/JacORB/JacORB/milestones{/number}","notifications_url":"https://api.github.com/repos/JacORB/JacORB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacORB/JacORB/labels{/name}","releases_url":"https://api.github.com/repos/JacORB/JacORB/releases{/id}","deployments_url":"https://api.github.com/repos/JacORB/JacORB/deployments","created_at":"2012-06-21T12:18:10Z","updated_at":"2017-06-28T07:26:35Z","pushed_at":"2017-04-26T15:48:50Z","git_url":"git://github.com/JacORB/JacORB.git","ssh_url":"git@github.com:JacORB/JacORB.git","clone_url":"https://github.com/JacORB/JacORB.git","svn_url":"https://github.com/JacORB/JacORB","homepage":null,"size":56511,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":2,"forks":53,"open_issues":2,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JacORB/JacORB/pulls/198"},"html":{"href":"https://github.com/JacORB/JacORB/pull/198"},"issue":{"href":"https://api.github.com/repos/JacORB/JacORB/issues/198"},"comments":{"href":"https://api.github.com/repos/JacORB/JacORB/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/JacORB/JacORB/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/JacORB/JacORB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JacORB/JacORB/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/JacORB/JacORB/statuses/1edc6b4bf87dc5548fa57a82d20aa371df193e1b"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":147,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"JohannesPulla"}}