{"action":"created","issue":{"url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/410","repository_url":"https://api.github.com/repos/nickel-org/nickel.rs","labels_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/410/labels{/name}","comments_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/410/comments","events_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/410/events","html_url":"https://github.com/nickel-org/nickel.rs/pull/410","id":273182356,"number":410,"title":"chore(*): Move to hyper 0.11.x","user":{"login":"jolhoeft","id":504452,"avatar_url":"https://avatars1.githubusercontent.com/u/504452?v=4","gravatar_id":"","url":"https://api.github.com/users/jolhoeft","html_url":"https://github.com/jolhoeft","followers_url":"https://api.github.com/users/jolhoeft/followers","following_url":"https://api.github.com/users/jolhoeft/following{/other_user}","gists_url":"https://api.github.com/users/jolhoeft/gists{/gist_id}","starred_url":"https://api.github.com/users/jolhoeft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolhoeft/subscriptions","organizations_url":"https://api.github.com/users/jolhoeft/orgs","repos_url":"https://api.github.com/users/jolhoeft/repos","events_url":"https://api.github.com/users/jolhoeft/events{/privacy}","received_events_url":"https://api.github.com/users/jolhoeft/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-11T22:50:36Z","updated_at":"2017-11-13T23:36:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/410","html_url":"https://github.com/nickel-org/nickel.rs/pull/410","diff_url":"https://github.com/nickel-org/nickel.rs/pull/410.diff","patch_url":"https://github.com/nickel-org/nickel.rs/pull/410.patch"},"body":"This is very rough, I've only tested the hello_world example so far. I have probably introduced some unnecessary copying to cope with lifetimes. I think I have avoided synchronizing hyper-0.11's async code, but a review from someone familiar with hyper and futures would be helpful.\r\n\r\nA number of things have been commented out to get it to build, but need to be fixed. This includes template rendering, sending files, and mounting. Searching for \"Todo: migration cleanup\" will find many of them, but I may have forgotten to flag a few. 'panic!(\"Migration not implemented!\");' will also be useful to search for.\r\n\r\nSince this is going to be a long development process, I think we are going to need to run the 0.10 branch in parallel. I am pondering two branch approaches.\r\n\r\n 1) Create an async branch and commit this to that, and maintain 0.10.x on master.\r\n 1) Create a 0.10 branch from the tip of master, and maintain 0.10.x on that branch, and commit this to master and continue asynch development there.\r\n\r\nI'm leaning towards the second option, but welcome input."},"comment":{"url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/comments/344095598","html_url":"https://github.com/nickel-org/nickel.rs/pull/410#issuecomment-344095598","issue_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/410","id":344095598,"user":{"login":"GitCop","id":7943652,"avatar_url":"https://avatars0.githubusercontent.com/u/7943652?v=4","gravatar_id":"","url":"https://api.github.com/users/GitCop","html_url":"https://github.com/GitCop","followers_url":"https://api.github.com/users/GitCop/followers","following_url":"https://api.github.com/users/GitCop/following{/other_user}","gists_url":"https://api.github.com/users/GitCop/gists{/gist_id}","starred_url":"https://api.github.com/users/GitCop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitCop/subscriptions","organizations_url":"https://api.github.com/users/GitCop/orgs","repos_url":"https://api.github.com/users/GitCop/repos","events_url":"https://api.github.com/users/GitCop/events{/privacy}","received_events_url":"https://api.github.com/users/GitCop/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T23:36:17Z","updated_at":"2017-11-13T23:36:17Z","author_association":"NONE","body":"Thanks for contributing! Unfortunately, I'm here to tell you there were style issues with your Pull Request:\n\n * Commit: d19604db4357f23f9a42b2f4078b3d2f6c4eb49d\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: b628c87386392643d551808b87837189ae4129b4\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: a4c15a943c5d13b1acfefc277b3c9a9e1ffe7287\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 8c630447bdc2e4e768306ff5cb966ac1c6517f08\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: cbfd5a33f0f4d1abe8bc9ea05ad209c5d975bd6c\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: a49f68c6afe966d7563237131a675760f61626a9\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 6bfcd402314218d99c8a93303c82cdb21d2da9c5\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 5a88365ed6a56412aacc436da76bf3d1d6f70fb5\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 37d70344873307611c1feb6057b1e6c63826e313\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 5eb3d09462b8ede42c33af5af20c8c5131c87060\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: b0c252379ecedc004cdf7e35194ec76ecd92b362\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 4553740b837cfa22442f01392dac52bd296bd14f\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 42f0c097792038a2186b411720e1bd8e62ee7dcb\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 51c1ce3710241dd7ca7c30b790937383ee4e9d4f\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 0cfee7409f0a0b389dceef51360c7d8eb47b9949\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: bc1d812196124bc9b357507755e9febd6a0457c9\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: e5c57484c5f3f9bc18e8109a7f874ca5d550db39\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 743b50a1deb7b40772b67a16a961d35b399affa9\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 5a6c4ca442b55d373c546f1619653965ac1c7314\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 0982ed5f906c09e8d98bd4eccb103305728b7473\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: d0ccf03e57a9d37307e15f5947d6cc69b32a9031\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: e3f5ff0823b2f7d755466d6f194659a137ab0ed5\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: b07cad4674d7a1c4c0351cb8d58508d1813c4b5f\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 7e479ff6d429935ff45576bd5f36b154a39fde9d\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 2b23a284946d3d1119d25a9cdc4654d6544bb6af\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: e3aa0b4915fe0972eef496ec9a29b6ae2353a26e\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: cfb5bfcf8187e888a2180f021fe9a9551196133d\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 70e78ff698db64839c825c237793008c3a92336a\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 4dbc91a6c0da99ac4bd60d18235f007ef6b67232\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\n * Commit: 705549eaecbc68b88f6988cfa07c4d3642a0d584\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\nGuidelines are available at https://github.com/nickel-org/nickel.rs/blob/master/contributing.md\n\n---\nThis message was auto-generated by https://gitcop.com\n"}}
{"actor":{"display_login":"GitCop"}}