{"action":"closed","number":1116,"pull_request":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116","id":160010068,"html_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/1116","diff_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/1116.diff","patch_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/1116.patch","issue_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/1116","number":1116,"state":"closed","locked":false,"title":"Update tool interfaces to be compatible with 21.2.13","user":{"login":"kkrizka","id":177068,"avatar_url":"https://avatars1.githubusercontent.com/u/177068?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrizka","html_url":"https://github.com/kkrizka","followers_url":"https://api.github.com/users/kkrizka/followers","following_url":"https://api.github.com/users/kkrizka/following{/other_user}","gists_url":"https://api.github.com/users/kkrizka/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrizka/subscriptions","organizations_url":"https://api.github.com/users/kkrizka/orgs","repos_url":"https://api.github.com/users/kkrizka/repos","events_url":"https://api.github.com/users/kkrizka/events{/privacy}","received_events_url":"https://api.github.com/users/kkrizka/received_events","type":"User","site_admin":false},"body":"Updates to the tool interfaces to make them compatible with the latest AnalysisBase release:\r\n* `ElectronSelection` tool only wants pointers to electrons, not references.\r\n* Trig::MatchingTool has a new non-default option to [allow rerun decision](https://gitlab.cern.ch/atlas/athena/merge_requests/6515). This does have a default value if you use `Trig::IMatchingTool` and `asg::AnaToolHandle`. This updates `TrigMatcher` to use the `asg::AnaToolHandle` interface.\r\n\r\nI am marking this as a WIP, because 21.2.13 does not like the way that we name our tools in BasicEventSelection: `<ToolType>/<ToolType>_<AlgorithmName>::<AlgorithmAddress>`. More speficially, the GRL tool hangs on retrieve if `::<AlgorithmAddress>` is included in the name. I reported it here:\r\nhttps://groups.cern.ch/group/hn-atlas-PATHelp/Lists/Archive/Flat.aspx?RootFolder=%2fgroup%2fhn-atlas-PATHelp%2fLists%2fArchive%2fAnaToolHandleIGoodRunsListSelectionToolretrieve%20hangs%20in%2021%2e2%2e13&FolderCTID=0x0120020084D7E80CB0C3394A8D54EF07C309B044","created_at":"2017-12-24T20:36:20Z","updated_at":"2017-12-25T18:36:46Z","closed_at":"2017-12-25T18:36:46Z","merged_at":"2017-12-25T18:36:46Z","merge_commit_sha":"dfae9a38088a3faaee854b50ac0fcf40ef4ddaff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/1116/comments","statuses_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/statuses/c2e91ed7dc63703220337fe67724a08078446f25","head":{"label":"UCATLAS:toolinterfaceupdate","ref":"toolinterfaceupdate","sha":"c2e91ed7dc63703220337fe67724a08078446f25","user":{"login":"UCATLAS","id":12347248,"avatar_url":"https://avatars2.githubusercontent.com/u/12347248?v=4","gravatar_id":"","url":"https://api.github.com/users/UCATLAS","html_url":"https://github.com/UCATLAS","followers_url":"https://api.github.com/users/UCATLAS/followers","following_url":"https://api.github.com/users/UCATLAS/following{/other_user}","gists_url":"https://api.github.com/users/UCATLAS/gists{/gist_id}","starred_url":"https://api.github.com/users/UCATLAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCATLAS/subscriptions","organizations_url":"https://api.github.com/users/UCATLAS/orgs","repos_url":"https://api.github.com/users/UCATLAS/repos","events_url":"https://api.github.com/users/UCATLAS/events{/privacy}","received_events_url":"https://api.github.com/users/UCATLAS/received_events","type":"Organization","site_admin":false},"repo":{"id":35496971,"name":"xAODAnaHelpers","full_name":"UCATLAS/xAODAnaHelpers","owner":{"login":"UCATLAS","id":12347248,"avatar_url":"https://avatars2.githubusercontent.com/u/12347248?v=4","gravatar_id":"","url":"https://api.github.com/users/UCATLAS","html_url":"https://github.com/UCATLAS","followers_url":"https://api.github.com/users/UCATLAS/followers","following_url":"https://api.github.com/users/UCATLAS/following{/other_user}","gists_url":"https://api.github.com/users/UCATLAS/gists{/gist_id}","starred_url":"https://api.github.com/users/UCATLAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCATLAS/subscriptions","organizations_url":"https://api.github.com/users/UCATLAS/orgs","repos_url":"https://api.github.com/users/UCATLAS/repos","events_url":"https://api.github.com/users/UCATLAS/events{/privacy}","received_events_url":"https://api.github.com/users/UCATLAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCATLAS/xAODAnaHelpers","description":null,"fork":false,"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers","forks_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/forks","keys_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/teams","hooks_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/hooks","issue_events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/events{/number}","events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/events","assignees_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/assignees{/user}","branches_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/branches{/branch}","tags_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/tags","blobs_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/statuses/{sha}","languages_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/languages","stargazers_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/stargazers","contributors_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/contributors","subscribers_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/subscribers","subscription_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/subscription","commits_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/contents/{+path}","compare_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/merges","archive_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/downloads","issues_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues{/number}","pulls_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls{/number}","milestones_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/milestones{/number}","notifications_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/labels{/name}","releases_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/releases{/id}","deployments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/deployments","created_at":"2015-05-12T15:38:14Z","updated_at":"2017-12-07T14:42:52Z","pushed_at":"2017-12-25T18:36:46Z","git_url":"git://github.com/UCATLAS/xAODAnaHelpers.git","ssh_url":"git@github.com:UCATLAS/xAODAnaHelpers.git","clone_url":"https://github.com/UCATLAS/xAODAnaHelpers.git","svn_url":"https://github.com/UCATLAS/xAODAnaHelpers","homepage":"https://ucatlas.github.io/xAODAnaHelpers/","size":31101,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":41,"open_issues":66,"watchers":18,"default_branch":"master"}},"base":{"label":"UCATLAS:master","ref":"master","sha":"c758a269b193a2a1264273317bc79b3a92eed240","user":{"login":"UCATLAS","id":12347248,"avatar_url":"https://avatars2.githubusercontent.com/u/12347248?v=4","gravatar_id":"","url":"https://api.github.com/users/UCATLAS","html_url":"https://github.com/UCATLAS","followers_url":"https://api.github.com/users/UCATLAS/followers","following_url":"https://api.github.com/users/UCATLAS/following{/other_user}","gists_url":"https://api.github.com/users/UCATLAS/gists{/gist_id}","starred_url":"https://api.github.com/users/UCATLAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCATLAS/subscriptions","organizations_url":"https://api.github.com/users/UCATLAS/orgs","repos_url":"https://api.github.com/users/UCATLAS/repos","events_url":"https://api.github.com/users/UCATLAS/events{/privacy}","received_events_url":"https://api.github.com/users/UCATLAS/received_events","type":"Organization","site_admin":false},"repo":{"id":35496971,"name":"xAODAnaHelpers","full_name":"UCATLAS/xAODAnaHelpers","owner":{"login":"UCATLAS","id":12347248,"avatar_url":"https://avatars2.githubusercontent.com/u/12347248?v=4","gravatar_id":"","url":"https://api.github.com/users/UCATLAS","html_url":"https://github.com/UCATLAS","followers_url":"https://api.github.com/users/UCATLAS/followers","following_url":"https://api.github.com/users/UCATLAS/following{/other_user}","gists_url":"https://api.github.com/users/UCATLAS/gists{/gist_id}","starred_url":"https://api.github.com/users/UCATLAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCATLAS/subscriptions","organizations_url":"https://api.github.com/users/UCATLAS/orgs","repos_url":"https://api.github.com/users/UCATLAS/repos","events_url":"https://api.github.com/users/UCATLAS/events{/privacy}","received_events_url":"https://api.github.com/users/UCATLAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCATLAS/xAODAnaHelpers","description":null,"fork":false,"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers","forks_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/forks","keys_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/teams","hooks_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/hooks","issue_events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/events{/number}","events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/events","assignees_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/assignees{/user}","branches_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/branches{/branch}","tags_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/tags","blobs_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/statuses/{sha}","languages_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/languages","stargazers_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/stargazers","contributors_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/contributors","subscribers_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/subscribers","subscription_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/subscription","commits_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/contents/{+path}","compare_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/merges","archive_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/downloads","issues_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues{/number}","pulls_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls{/number}","milestones_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/milestones{/number}","notifications_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/labels{/name}","releases_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/releases{/id}","deployments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/deployments","created_at":"2015-05-12T15:38:14Z","updated_at":"2017-12-07T14:42:52Z","pushed_at":"2017-12-25T18:36:46Z","git_url":"git://github.com/UCATLAS/xAODAnaHelpers.git","ssh_url":"git@github.com:UCATLAS/xAODAnaHelpers.git","clone_url":"https://github.com/UCATLAS/xAODAnaHelpers.git","svn_url":"https://github.com/UCATLAS/xAODAnaHelpers","homepage":"https://ucatlas.github.io/xAODAnaHelpers/","size":31101,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":41,"open_issues":66,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116"},"html":{"href":"https://github.com/UCATLAS/xAODAnaHelpers/pull/1116"},"issue":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/1116"},"comments":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/statuses/c2e91ed7dc63703220337fe67724a08078446f25"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kkrizka","id":177068,"avatar_url":"https://avatars1.githubusercontent.com/u/177068?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrizka","html_url":"https://github.com/kkrizka","followers_url":"https://api.github.com/users/kkrizka/followers","following_url":"https://api.github.com/users/kkrizka/following{/other_user}","gists_url":"https://api.github.com/users/kkrizka/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrizka/subscriptions","organizations_url":"https://api.github.com/users/kkrizka/orgs","repos_url":"https://api.github.com/users/kkrizka/repos","events_url":"https://api.github.com/users/kkrizka/events{/privacy}","received_events_url":"https://api.github.com/users/kkrizka/received_events","type":"User","site_admin":false},"comments":15,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":9,"deletions":16,"changed_files":4}}
{"actor":{"display_login":"kkrizka"}}