{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/99841497","pull_request_review_id":20528279,"id":99841497,"diff_hunk":"@@ -172,8 +172,8 @@ func RunValidateCluster(f *util.Factory, cmd *cobra.Command, args []string, out\n \t\t// do we need to print which instance group is not ready?\n \t\t// nodes are going to be a pain\n \t\tfmt.Fprint(out, \"\\nValidation Failed\\n\")\n-\t\tfmt.Fprintf(out, \"Master(s) Not Ready %d out of %d.\\n\", len(validationCluster.MastersNotReadyArray), validationCluster.MastersCount)\n-\t\tfmt.Fprintf(out, \"Node(s) Not Ready   %d out of %d.\\n\", len(validationCluster.NodesNotReadyArray), validationCluster.NodesCount)\n+\t\tfmt.Fprintf(out, \"Ready Master(s) %d out of %d.\\n\", len(validationCluster.MastersNotReadyArray), validationCluster.MastersCount)","path":"cmd/kops/validate_cluster.go","position":6,"original_position":6,"commit_id":"eb3a639911cf33afb8c3f74d3b20a712962c0b03","original_commit_id":"eb3a639911cf33afb8c3f74d3b20a712962c0b03","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"I like this message.  Is this the wrong way round though?  If one master is not ready, and 4 are ready, it looks like this prints:\r\n\r\n\"Ready Masters 1 out of 5\"","created_at":"2017-02-07T15:05:03Z","updated_at":"2017-02-07T15:05:04Z","html_url":"https://github.com/kubernetes/kops/pull/1701#discussion_r99841497","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/1701","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/99841497"},"html":{"href":"https://github.com/kubernetes/kops/pull/1701#discussion_r99841497"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1701"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/1701","id":103679900,"html_url":"https://github.com/kubernetes/kops/pull/1701","diff_url":"https://github.com/kubernetes/kops/pull/1701.diff","patch_url":"https://github.com/kubernetes/kops/pull/1701.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/1701","number":1701,"state":"open","locked":false,"title":"Improve cluster validate output","user":{"login":"kamilhristov","id":7661748,"avatar_url":"https://avatars.githubusercontent.com/u/7661748?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilhristov","html_url":"https://github.com/kamilhristov","followers_url":"https://api.github.com/users/kamilhristov/followers","following_url":"https://api.github.com/users/kamilhristov/following{/other_user}","gists_url":"https://api.github.com/users/kamilhristov/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilhristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilhristov/subscriptions","organizations_url":"https://api.github.com/users/kamilhristov/orgs","repos_url":"https://api.github.com/users/kamilhristov/repos","events_url":"https://api.github.com/users/kamilhristov/events{/privacy}","received_events_url":"https://api.github.com/users/kamilhristov/received_events","type":"User","site_admin":false},"body":"Fixes #1674 \r\n\r\nI have also decreased the connection timeout.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/1701)\n<!-- Reviewable:end -->\n","created_at":"2017-01-30T05:07:55Z","updated_at":"2017-02-07T15:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59d69721e7bae16e58cba91d1d5e1ff945ab83d5","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/6","html_url":"https://github.com/kubernetes/kops/milestone/6","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/6/labels","id":2218273,"number":6,"title":"1.5.1","description":null,"creator":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":265,"closed_issues":16,"state":"open","created_at":"2016-12-28T02:16:03Z","updated_at":"2017-02-07T15:02:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/1701/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/1701/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/1701/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/eb3a639911cf33afb8c3f74d3b20a712962c0b03","head":{"label":"kamilhristov:cmd/validate_cluster","ref":"cmd/validate_cluster","sha":"eb3a639911cf33afb8c3f74d3b20a712962c0b03","user":{"login":"kamilhristov","id":7661748,"avatar_url":"https://avatars.githubusercontent.com/u/7661748?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilhristov","html_url":"https://github.com/kamilhristov","followers_url":"https://api.github.com/users/kamilhristov/followers","following_url":"https://api.github.com/users/kamilhristov/following{/other_user}","gists_url":"https://api.github.com/users/kamilhristov/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilhristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilhristov/subscriptions","organizations_url":"https://api.github.com/users/kamilhristov/orgs","repos_url":"https://api.github.com/users/kamilhristov/repos","events_url":"https://api.github.com/users/kamilhristov/events{/privacy}","received_events_url":"https://api.github.com/users/kamilhristov/received_events","type":"User","site_admin":false},"repo":{"id":80151505,"name":"kops","full_name":"kamilhristov/kops","owner":{"login":"kamilhristov","id":7661748,"avatar_url":"https://avatars.githubusercontent.com/u/7661748?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilhristov","html_url":"https://github.com/kamilhristov","followers_url":"https://api.github.com/users/kamilhristov/followers","following_url":"https://api.github.com/users/kamilhristov/following{/other_user}","gists_url":"https://api.github.com/users/kamilhristov/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilhristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilhristov/subscriptions","organizations_url":"https://api.github.com/users/kamilhristov/orgs","repos_url":"https://api.github.com/users/kamilhristov/repos","events_url":"https://api.github.com/users/kamilhristov/events{/privacy}","received_events_url":"https://api.github.com/users/kamilhristov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamilhristov/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/kamilhristov/kops","forks_url":"https://api.github.com/repos/kamilhristov/kops/forks","keys_url":"https://api.github.com/repos/kamilhristov/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamilhristov/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamilhristov/kops/teams","hooks_url":"https://api.github.com/repos/kamilhristov/kops/hooks","issue_events_url":"https://api.github.com/repos/kamilhristov/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kamilhristov/kops/events","assignees_url":"https://api.github.com/repos/kamilhristov/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kamilhristov/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kamilhristov/kops/tags","blobs_url":"https://api.github.com/repos/kamilhristov/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamilhristov/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamilhristov/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamilhristov/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamilhristov/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kamilhristov/kops/languages","stargazers_url":"https://api.github.com/repos/kamilhristov/kops/stargazers","contributors_url":"https://api.github.com/repos/kamilhristov/kops/contributors","subscribers_url":"https://api.github.com/repos/kamilhristov/kops/subscribers","subscription_url":"https://api.github.com/repos/kamilhristov/kops/subscription","commits_url":"https://api.github.com/repos/kamilhristov/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamilhristov/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamilhristov/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamilhristov/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamilhristov/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kamilhristov/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamilhristov/kops/merges","archive_url":"https://api.github.com/repos/kamilhristov/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamilhristov/kops/downloads","issues_url":"https://api.github.com/repos/kamilhristov/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kamilhristov/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kamilhristov/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kamilhristov/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamilhristov/kops/labels{/name}","releases_url":"https://api.github.com/repos/kamilhristov/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kamilhristov/kops/deployments","created_at":"2017-01-26T20:19:04Z","updated_at":"2017-01-26T20:19:08Z","pushed_at":"2017-02-02T21:33:32Z","git_url":"git://github.com/kamilhristov/kops.git","ssh_url":"git@github.com:kamilhristov/kops.git","clone_url":"https://github.com/kamilhristov/kops.git","svn_url":"https://github.com/kamilhristov/kops","homepage":"","size":109333,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b5f6ba34881a6894e3e699b8df3f4c64885da9a4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-02-07T12:14:50Z","pushed_at":"2017-02-07T14:36:34Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":109934,"stargazers_count":1040,"watchers_count":1040,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":484,"forks":223,"open_issues":484,"watchers":1040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1701"},"html":{"href":"https://github.com/kubernetes/kops/pull/1701"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1701"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1701/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1701/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1701/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/eb3a639911cf33afb8c3f74d3b20a712962c0b03"}}}}
{"actor":{"display_login":"justinsb"}}