{"push_id":1746360922,"size":358,"distinct_size":0,"ref":"refs/heads/project_generator_expands_location_macros","head":"d27cc24db54a883c7a56bcab8d47d72be347d4aa","before":"edf1588249354b9846f439c617bef073ed712778","commits":[{"sha":"0d9925424fa37fb9a10c2dfc16dd9cf5810579eb","author":{"name":"Jon Shemitz","email":"821f9e480644b8b94c0d5cc0a74169d00924573e@fb.com"},"message":"Get APK_PATH from TargetGraph\n\nSummary: Get `APK_PATH` correctly; sets `GEN_FOLDER_RELATIVE_PATH_APT` to `buck-out/gen` and `GEN_FOLDER_RELATIVE_PATH_AIDL` to `buck-out/gen/aidl`\n\nTest Plan: buck project --view  ~/view_directory target_that_produces_an_apk\n\nReviewed By: styurin\n\nfbshipit-source-id: 6264ab1","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/0d9925424fa37fb9a10c2dfc16dd9cf5810579eb"},{"sha":"89713ae482b335ba7949612668fbf872591bff6e","author":{"name":"Bert Maher","email":"69649bc45fe86d148064365a527227a5779d135c@fb.com"},"message":"Clean output directories if metadata_storage is inconsistent\n\nSummary:\nWhen a user changes the build.metadata_storage format, we need to ensure that\nstale metadata is not left behind, or future builds could use incorrect\nmetadata, leading to broken builds.  Unfortunately, using the filesystem to\nstore metadata makes it hard to reliably find metadata for all targets, so the\nsafest thing to do is remove the entire output directory.\n\nTest Plan:\n- Updated integration test\n- Manual testing switching from filesystem -> rocksdb -> filesystem -> rocksdb\n\nReviewed By: asp2insp\n\nfbshipit-source-id: fda8822","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/89713ae482b335ba7949612668fbf872591bff6e"},{"sha":"578da5a8077cd7dbbcb11abee59390c99f27db9a","author":{"name":"Jon Shemitz","email":"821f9e480644b8b94c0d5cc0a74169d00924573e@fb.com"},"message":"More Java 8\n\nSummary: Just some refactoring that eliminates some intermediate results.\n\nTest Plan: buck project --view ~/view_directory target_that_produces_an_apk\n\nReviewed By: styurin\n\nfbshipit-source-id: 044e281","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/578da5a8077cd7dbbcb11abee59390c99f27db9a"},{"sha":"c4722458e7c0251d2dab8f67afae16320349c980","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"engine: downgrade rule key checks to warnings\n\nSummary:\nWe're seeing missing rule keys in artifacts triggering this failure.  As this\ndoesn't indicate corruption, downgrade checks to warnings until we can diagnose.\n\nTest Plan: CI\n\nfbshipit-source-id: 1432f0c","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/c4722458e7c0251d2dab8f67afae16320349c980"},{"sha":"b32a4d873cfc4473698332b4d6d16aac36431dc2","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Get rid of Predicate interface for BuildTargetPattern, and rename match method\n\nSummary:\nThis interface helps nobody. Java 8 recommends creating predicates using method\nreferences anyways. Also conveniently gets rid of these pointless null checks.\n\nTest Plan: CI\n\nReviewed By: plamenko\n\nfbshipit-source-id: d949093","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/b32a4d873cfc4473698332b4d6d16aac36431dc2"},{"sha":"d7c26eebd922c3bd729865ace32a8107f123d62f","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Convert BuildTargetPattern implementations to Immutables\n\nSummary:\nThis lets me get rid of a bunch of pointless tests of equals and\nhashcode, and boilerplate implementations.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 6f6801e","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/d7c26eebd922c3bd729865ace32a8107f123d62f"},{"sha":"d07bdce087f4868f4dc7694e55c051b1630a6d82","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Only check cell paths for visibility pattern.\n\nSummary:\nPreviously, singleton build target pattern will implicitly check that cell name\nof incoming cell paths are empty, this is strictly wrong now that canonical\ncell names are always used.\n\nHere I change it to skip checking cell name, and only check cell path, and\nadded some test to verify correct behavior.\n\nTest Plan: CI\n\nReviewed By: mzlee\n\nfbshipit-source-id: 3036790","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/d07bdce087f4868f4dc7694e55c051b1630a6d82"},{"sha":"384882f0f2bf4d4be8d18ae38b8229d60c6a4400","author":{"name":"Adam Ernst","email":"b8be19731925137ab4edb6fde6758e9bd67899f0@fb.com"},"message":"Revert \"remove overflow threshold for Watchman\"\n\nSummary:\nThe key assumption of the removal was the following:\n\n> The reasoning behind the removal is that it's not possible re-parsing the whole repository is faster than re-parsing only the edited files.\n\nUnfortuantely this is not true. It is definitely possible that reparsing the entire repository is faster.\n\nTest Plan: Unit test.\n\nReviewed By: mzlee\n\nfbshipit-source-id: bcdc3ac","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/384882f0f2bf4d4be8d18ae38b8229d60c6a4400"},{"sha":"3ab187e801679e0a5edb6bc5b192077717b3a329","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Follow symlinks when resolving paths for Xcode\n\nSummary: When resolving paths, we should resolve to the final symlink. This is because occasionally the Xcode directories are symlinked into place.\n\nTest Plan:\nA unit test for AppleConfigTest because it's extra_{toolchain,developer}_paths that's messing with things.\n\nAnd a test in BuckConfigTest\n\nReviewed By: illicitonion\n\nfbshipit-source-id: 3f194af","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/3ab187e801679e0a5edb6bc5b192077717b3a329"},{"sha":"1f985f2b3730af0a2e01b7b37ea2895dc07b072c","author":{"name":"Jon Shemitz","email":"821f9e480644b8b94c0d5cc0a74169d00924573e@fb.com"},"message":"Get misc.xml ProjectRootManager values from .buckconfig\n\nTest Plan: `buck project --view ~/view_directory target_that_produces_an_apk`\n\nReviewed By: styurin\n\nfbshipit-source-id: 9106922","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/1f985f2b3730af0a2e01b7b37ea2895dc07b072c"},{"sha":"f4753f27cbee808a28607316fd7c197e87c03d67","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Use labels to detect IntelliJ plugins\n\nSummary: We use dependencies as a marker to detect if a `java_binary` needs to be represented as an Intellij plugin module. Instead, we can use a label to do that.\n\nTest Plan: Unit tests\n\nReviewed By: asp2insp\n\nfbshipit-source-id: e2e7030","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/f4753f27cbee808a28607316fd7c197e87c03d67"},{"sha":"9b47c0a5b6e097e4dce1cc2baaf30fb18af68876","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"(IjProject) Use type parameters in BaseIjModuleRule\n\nSummary: `BaseIjModuleRule` uses generic type parameter, but it's actually not that generic and I need to get access to labels in the following change so reducing the type parameter to inherit from `AbstractDescriptionArg`.\n\nTest Plan: Unit tests\n\nReviewed By: asp2insp\n\nfbshipit-source-id: 5feb086","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/9b47c0a5b6e097e4dce1cc2baaf30fb18af68876"},{"sha":"94ae280de8238d15bf339b85f11bb33df7185dbb","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"(IjProject) Use labels to add path with generated sources\n\nSummary:\nWe use dependencies as a marker to detect if generated source paths needs to be added to the project. Instead, we can use labels to do that same. This should be more efficient because the number of labels is usually much lower than the number of dependencies.\n\nAlso, keeping the old logic in place to make transitioning easier. It will be removed after we migrate our repo to the new model.\n\nTest Plan: Unit tests\n\nReviewed By: asp2insp\n\nfbshipit-source-id: d187738","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/94ae280de8238d15bf339b85f11bb33df7185dbb"},{"sha":"3977b1d9bca2d05e28beda77d825d4262263fea4","author":{"name":"Daniel Wagner-Hall","email":"a66f99cb67733caeee340612e9fef663e6dc880e@fb.com"},"message":"Inline trivial uses of Description#createUnpopulatedConstructorArg\n\nSummary: I'm about to delete it.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 7cc7dba","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/3977b1d9bca2d05e28beda77d825d4262263fea4"},{"sha":"b184569a488a9472d70ad2a63c32dc8f14eb21fe","author":{"name":"Daniel Wagner-Hall","email":"a66f99cb67733caeee340612e9fef663e6dc880e@fb.com"},"message":"Parameterize testutil on Arg not Description\n\nSummary: Descriptions are about to lose createUnpopulatedConstructorArg()\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 7163dd2","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/b184569a488a9472d70ad2a63c32dc8f14eb21fe"},{"sha":"0320c2b0808422351a4b461921c2e5d03fa6ea31","author":{"name":"Daniel Wagner-Hall","email":"a66f99cb67733caeee340612e9fef663e6dc880e@fb.com"},"message":"BuckPythonProgram uses a Class not an instance thereof\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 9a2ab36","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/0320c2b0808422351a4b461921c2e5d03fa6ea31"},{"sha":"d3653bb003db0a3f053b0f286ee3c9b2de483990","author":{"name":"Daniel Wagner-Hall","email":"a66f99cb67733caeee340612e9fef663e6dc880e@fb.com"},"message":"TargetNodeFactory uses Class not instance thereof\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 8eb5a4c","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/d3653bb003db0a3f053b0f286ee3c9b2de483990"},{"sha":"a859be28ced86989019a1ac17557a6360232776c","author":{"name":"Daniel Wagner-Hall","email":"a66f99cb67733caeee340612e9fef663e6dc880e@fb.com"},"message":"Tighten generic bound\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 5735959","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/a859be28ced86989019a1ac17557a6360232776c"},{"sha":"e16e23a2fdb14d6a06982479bb8ceba850a3ebed","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"log successful uploads to machine-log\n\nSummary: log the number of successful and failed cache uploads to the machine-readable log\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 4957dff","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/e16e23a2fdb14d6a06982479bb8ceba850a3ebed"},{"sha":"7f9742d5c08268516e4d4e4ae2b966159cf41a06","author":{"name":"Riccardo Vitale","email":"12f9de39a74d338a75c68abd54dbdf03aa04d0f6@fb.com"},"message":"Fixed logging for file hash cache experiment.\n\nTest Plan: CI and scuba\n\nReviewed By: aiked\n\nfbshipit-source-id: 6d9bffe","distinct":false,"url":"https://api.github.com/repos/ProfessaA/buck/commits/7f9742d5c08268516e4d4e4ae2b966159cf41a06"}]}
{"actor":{"display_login":"ProfessaA"}}