{"action":"created","issue":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3430","repository_url":"https://api.github.com/repos/statsmodels/statsmodels","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3430/labels{/name}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3430/comments","events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3430/events","html_url":"https://github.com/statsmodels/statsmodels/pull/3430","id":205398692,"number":3430,"title":"BUG: _get_predict_end did not accept datetime (0.8 shim)","user":{"login":"ChadFulton","id":280864,"avatar_url":"https://avatars.githubusercontent.com/u/280864?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadFulton","html_url":"https://github.com/ChadFulton","followers_url":"https://api.github.com/users/ChadFulton/followers","following_url":"https://api.github.com/users/ChadFulton/following{/other_user}","gists_url":"https://api.github.com/users/ChadFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadFulton/subscriptions","organizations_url":"https://api.github.com/users/ChadFulton/orgs","repos_url":"https://api.github.com/users/ChadFulton/repos","events_url":"https://api.github.com/users/ChadFulton/events{/privacy}","received_events_url":"https://api.github.com/users/ChadFulton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-05T03:58:01Z","updated_at":"2017-02-05T17:37:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/3430","html_url":"https://github.com/statsmodels/statsmodels/pull/3430","diff_url":"https://github.com/statsmodels/statsmodels/pull/3430.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/3430.patch"},"body":"Closes #2553\r\n\r\nShim in 0.8 for accepting `datetime.datetime` objects in `TimeSeriesModel._get_predict_end`. The strategy is the same as in `_get_predict_start` (i.e. convert to string, then use `_str_to_date`).\r\n\r\nIt \\*appears\\* to fix the issue (in the sense that I can use datetime objects in start and end of `predict` calls), and it seems very straightforward, but I don't know whether or not to merge it because:\r\n\r\n1. it's pretty late in the process now, and\r\n2. since I've already refactored the dates for 0.9 I don't want to spend a lot of time making sure it doesn't break corner cases or something\r\n\r\n@josef-pkt what are your thoughts?"},"comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/277535037","html_url":"https://github.com/statsmodels/statsmodels/pull/3430#issuecomment-277535037","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3430","id":277535037,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-02-05T17:37:25Z","updated_at":"2017-02-05T17:37:25Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10003084/badge)](https://coveralls.io/builds/10003084)\n\nCoverage increased (+0.002%) to 89.506% when pulling **49d49d5e02b9151359c230d33ee97885332fe053 on ChadFulton:08-datetime-shim** into **957561cb72d4e5bde28bd319a861ca68157235ff on statsmodels:maintenance/0.8.x**.\n"}}
{"actor":{"display_login":"coveralls"}}