{"action":"created","comment":{"url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/comments/146789728","pull_request_review_id":71780743,"id":146789728,"diff_hunk":"@@ -69,12 +69,11 @@ defmodule Phoenix.Channels.GenSocketClientTest do\n     assert {:ok, 5} == TestSocket.push(conn.socket, \"channel:2\", \"channel_2_event\")\n     assert {:ok, 6} == TestSocket.push(conn.socket, \"channel:1\", \"yet_another_event\")\n \n-    # leave and rejoin the channel, and verify that counter has been reset\n+    # leave and rejoin the channel","path":"test/socket_client_test.exs","position":null,"original_position":5,"commit_id":"bad598e842c8787bbe6a73ce210b3c78f0153040","original_commit_id":"bad598e842c8787bbe6a73ce210b3c78f0153040","user":{"login":"sebastian","id":1089,"avatar_url":"https://avatars3.githubusercontent.com/u/1089?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian","html_url":"https://github.com/sebastian","followers_url":"https://api.github.com/users/sebastian/followers","following_url":"https://api.github.com/users/sebastian/following{/other_user}","gists_url":"https://api.github.com/users/sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian/subscriptions","organizations_url":"https://api.github.com/users/sebastian/orgs","repos_url":"https://api.github.com/users/sebastian/repos","events_url":"https://api.github.com/users/sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian/received_events","type":"User","site_admin":false},"body":"This comment is somewhat pointless at this point. Maybe describe _why_ you are leaving and rejoining?","created_at":"2017-10-25T08:45:34Z","updated_at":"2017-10-25T08:45:48Z","html_url":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23#discussion_r146789728","pull_request_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/comments/146789728"},"html":{"href":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23#discussion_r146789728"},"pull_request":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23","id":148581173,"html_url":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23","diff_url":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23.diff","patch_url":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23.patch","issue_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/23","number":23,"state":"open","locked":false,"title":"Sasa/support phoenix1.3","user":{"login":"sasa1977","id":202498,"avatar_url":"https://avatars1.githubusercontent.com/u/202498?v=4","gravatar_id":"","url":"https://api.github.com/users/sasa1977","html_url":"https://github.com/sasa1977","followers_url":"https://api.github.com/users/sasa1977/followers","following_url":"https://api.github.com/users/sasa1977/following{/other_user}","gists_url":"https://api.github.com/users/sasa1977/gists{/gist_id}","starred_url":"https://api.github.com/users/sasa1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasa1977/subscriptions","organizations_url":"https://api.github.com/users/sasa1977/orgs","repos_url":"https://api.github.com/users/sasa1977/repos","events_url":"https://api.github.com/users/sasa1977/events{/privacy}","received_events_url":"https://api.github.com/users/sasa1977/received_events","type":"User","site_admin":false},"body":"This PR upgrades the library to the Phoenix channels protocol 2.0. This is a backwards incompatible change, so I bumped the library version to 2.0.","created_at":"2017-10-25T06:35:39Z","updated_at":"2017-10-25T08:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f911ab21439e83bfcc2d117941ff38237ef7388a","assignee":{"login":"sebastian","id":1089,"avatar_url":"https://avatars3.githubusercontent.com/u/1089?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian","html_url":"https://github.com/sebastian","followers_url":"https://api.github.com/users/sebastian/followers","following_url":"https://api.github.com/users/sebastian/following{/other_user}","gists_url":"https://api.github.com/users/sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian/subscriptions","organizations_url":"https://api.github.com/users/sebastian/orgs","repos_url":"https://api.github.com/users/sebastian/repos","events_url":"https://api.github.com/users/sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebastian","id":1089,"avatar_url":"https://avatars3.githubusercontent.com/u/1089?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian","html_url":"https://github.com/sebastian","followers_url":"https://api.github.com/users/sebastian/followers","following_url":"https://api.github.com/users/sebastian/following{/other_user}","gists_url":"https://api.github.com/users/sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian/subscriptions","organizations_url":"https://api.github.com/users/sebastian/orgs","repos_url":"https://api.github.com/users/sebastian/repos","events_url":"https://api.github.com/users/sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/23/comments","statuses_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/statuses/bad598e842c8787bbe6a73ce210b3c78f0153040","head":{"label":"Aircloak:sasa/support-phoenix1.3","ref":"sasa/support-phoenix1.3","sha":"bad598e842c8787bbe6a73ce210b3c78f0153040","user":{"login":"Aircloak","id":2162258,"avatar_url":"https://avatars0.githubusercontent.com/u/2162258?v=4","gravatar_id":"","url":"https://api.github.com/users/Aircloak","html_url":"https://github.com/Aircloak","followers_url":"https://api.github.com/users/Aircloak/followers","following_url":"https://api.github.com/users/Aircloak/following{/other_user}","gists_url":"https://api.github.com/users/Aircloak/gists{/gist_id}","starred_url":"https://api.github.com/users/Aircloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aircloak/subscriptions","organizations_url":"https://api.github.com/users/Aircloak/orgs","repos_url":"https://api.github.com/users/Aircloak/repos","events_url":"https://api.github.com/users/Aircloak/events{/privacy}","received_events_url":"https://api.github.com/users/Aircloak/received_events","type":"Organization","site_admin":false},"repo":{"id":55591921,"name":"phoenix_gen_socket_client","full_name":"Aircloak/phoenix_gen_socket_client","owner":{"login":"Aircloak","id":2162258,"avatar_url":"https://avatars0.githubusercontent.com/u/2162258?v=4","gravatar_id":"","url":"https://api.github.com/users/Aircloak","html_url":"https://github.com/Aircloak","followers_url":"https://api.github.com/users/Aircloak/followers","following_url":"https://api.github.com/users/Aircloak/following{/other_user}","gists_url":"https://api.github.com/users/Aircloak/gists{/gist_id}","starred_url":"https://api.github.com/users/Aircloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aircloak/subscriptions","organizations_url":"https://api.github.com/users/Aircloak/orgs","repos_url":"https://api.github.com/users/Aircloak/repos","events_url":"https://api.github.com/users/Aircloak/events{/privacy}","received_events_url":"https://api.github.com/users/Aircloak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aircloak/phoenix_gen_socket_client","description":"Socket client behaviour for phoenix channels","fork":false,"url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client","forks_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/forks","keys_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/teams","hooks_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/hooks","issue_events_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/events{/number}","events_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/events","assignees_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/assignees{/user}","branches_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/branches{/branch}","tags_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/tags","blobs_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/statuses/{sha}","languages_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/languages","stargazers_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/stargazers","contributors_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/contributors","subscribers_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/subscribers","subscription_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/subscription","commits_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/contents/{+path}","compare_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/merges","archive_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/downloads","issues_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues{/number}","pulls_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls{/number}","milestones_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/milestones{/number}","notifications_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/labels{/name}","releases_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/releases{/id}","deployments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/deployments","created_at":"2016-04-06T09:12:18Z","updated_at":"2017-10-11T09:08:18Z","pushed_at":"2017-10-25T08:36:32Z","git_url":"git://github.com/Aircloak/phoenix_gen_socket_client.git","ssh_url":"git@github.com:Aircloak/phoenix_gen_socket_client.git","clone_url":"https://github.com/Aircloak/phoenix_gen_socket_client.git","svn_url":"https://github.com/Aircloak/phoenix_gen_socket_client","homepage":null,"size":143,"stargazers_count":71,"watchers_count":71,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":71,"default_branch":"master"}},"base":{"label":"Aircloak:master","ref":"master","sha":"35ad882900efb7f4690f5c6c1435ec75dfaa313a","user":{"login":"Aircloak","id":2162258,"avatar_url":"https://avatars0.githubusercontent.com/u/2162258?v=4","gravatar_id":"","url":"https://api.github.com/users/Aircloak","html_url":"https://github.com/Aircloak","followers_url":"https://api.github.com/users/Aircloak/followers","following_url":"https://api.github.com/users/Aircloak/following{/other_user}","gists_url":"https://api.github.com/users/Aircloak/gists{/gist_id}","starred_url":"https://api.github.com/users/Aircloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aircloak/subscriptions","organizations_url":"https://api.github.com/users/Aircloak/orgs","repos_url":"https://api.github.com/users/Aircloak/repos","events_url":"https://api.github.com/users/Aircloak/events{/privacy}","received_events_url":"https://api.github.com/users/Aircloak/received_events","type":"Organization","site_admin":false},"repo":{"id":55591921,"name":"phoenix_gen_socket_client","full_name":"Aircloak/phoenix_gen_socket_client","owner":{"login":"Aircloak","id":2162258,"avatar_url":"https://avatars0.githubusercontent.com/u/2162258?v=4","gravatar_id":"","url":"https://api.github.com/users/Aircloak","html_url":"https://github.com/Aircloak","followers_url":"https://api.github.com/users/Aircloak/followers","following_url":"https://api.github.com/users/Aircloak/following{/other_user}","gists_url":"https://api.github.com/users/Aircloak/gists{/gist_id}","starred_url":"https://api.github.com/users/Aircloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aircloak/subscriptions","organizations_url":"https://api.github.com/users/Aircloak/orgs","repos_url":"https://api.github.com/users/Aircloak/repos","events_url":"https://api.github.com/users/Aircloak/events{/privacy}","received_events_url":"https://api.github.com/users/Aircloak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aircloak/phoenix_gen_socket_client","description":"Socket client behaviour for phoenix channels","fork":false,"url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client","forks_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/forks","keys_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/teams","hooks_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/hooks","issue_events_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/events{/number}","events_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/events","assignees_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/assignees{/user}","branches_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/branches{/branch}","tags_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/tags","blobs_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/statuses/{sha}","languages_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/languages","stargazers_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/stargazers","contributors_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/contributors","subscribers_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/subscribers","subscription_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/subscription","commits_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/contents/{+path}","compare_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/merges","archive_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/downloads","issues_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues{/number}","pulls_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls{/number}","milestones_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/milestones{/number}","notifications_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/labels{/name}","releases_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/releases{/id}","deployments_url":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/deployments","created_at":"2016-04-06T09:12:18Z","updated_at":"2017-10-11T09:08:18Z","pushed_at":"2017-10-25T08:36:32Z","git_url":"git://github.com/Aircloak/phoenix_gen_socket_client.git","ssh_url":"git@github.com:Aircloak/phoenix_gen_socket_client.git","clone_url":"https://github.com/Aircloak/phoenix_gen_socket_client.git","svn_url":"https://github.com/Aircloak/phoenix_gen_socket_client","homepage":null,"size":143,"stargazers_count":71,"watchers_count":71,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23"},"html":{"href":"https://github.com/Aircloak/phoenix_gen_socket_client/pull/23"},"issue":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/23"},"comments":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Aircloak/phoenix_gen_socket_client/statuses/bad598e842c8787bbe6a73ce210b3c78f0153040"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sebastian"}}