{"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/116857739","pull_request_review_id":38512572,"id":116857739,"diff_hunk":"@@ -1336,4 +1336,18 @@ object messages {\n           |out the parameter list when extending it.\n           |\"\"\"\n   }\n+\n+  case class VarValParametersMayNotBeCallByName(name: Names.TermName, mutable: Boolean)(implicit ctx: Context)\n+    extends Message(VarValParametersMayNotBeCallByNameID) {\n+    val msg = s\"${if (mutable) \"`var'\" else \"`val'\"} parameters may not be call-by-name\"\n+    val kind = \"Syntax\"\n+    val explanation =\n+      hl\"\"\"Parameters of classes and traits may no be call-by-name. In case you\n+          |want the parameter to be evaluated on demand, consider using a function\n+          |and a lazy value in the class such as\n+          |  ${s\"class MyClass(${name}Tick: () => String) {\"}\n+          |  ${s\"  lazy val $name = ${name}Tick\"}","path":"compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala","position":14,"original_position":14,"commit_id":"e4b8e3422633d2c68a76ed9f1c3a2ff9e91002f2","original_commit_id":"e4b8e3422633d2c68a76ed9f1c3a2ff9e91002f2","user":{"login":"smarter","id":63430,"avatar_url":"https://avatars1.githubusercontent.com/u/63430?v=3","gravatar_id":"","url":"https://api.github.com/users/smarter","html_url":"https://github.com/smarter","followers_url":"https://api.github.com/users/smarter/followers","following_url":"https://api.github.com/users/smarter/following{/other_user}","gists_url":"https://api.github.com/users/smarter/gists{/gist_id}","starred_url":"https://api.github.com/users/smarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarter/subscriptions","organizations_url":"https://api.github.com/users/smarter/orgs","repos_url":"https://api.github.com/users/smarter/repos","events_url":"https://api.github.com/users/smarter/events{/privacy}","received_events_url":"https://api.github.com/users/smarter/received_events","type":"User","site_admin":false},"body":"Or even:\r\n```scala\r\nclass MyClass(myFoo: => Int) {\r\n  def foo() = myFoo\r\n}\r\n```","created_at":"2017-05-16T21:05:53Z","updated_at":"2017-05-16T21:05:53Z","html_url":"https://github.com/lampepfl/dotty/pull/2447#discussion_r116857739","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/2447","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/116857739"},"html":{"href":"https://github.com/lampepfl/dotty/pull/2447#discussion_r116857739"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/2447"}}},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/2447","id":120924035,"html_url":"https://github.com/lampepfl/dotty/pull/2447","diff_url":"https://github.com/lampepfl/dotty/pull/2447.diff","patch_url":"https://github.com/lampepfl/dotty/pull/2447.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/2447","number":2447,"state":"open","locked":false,"title":"Move 'var/val parameter may not be call-by-name' to error case class","user":{"login":"ennru","id":458526,"avatar_url":"https://avatars0.githubusercontent.com/u/458526?v=3","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"body":"@felixmulder One more and I call it a day.","created_at":"2017-05-16T20:57:50Z","updated_at":"2017-05-16T21:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520ee74da92642c7dfed0ec7790b86c94e28cf36","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/2447/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/2447/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/2447/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/e4b8e3422633d2c68a76ed9f1c3a2ff9e91002f2","head":{"label":"ennru:ennru_VarValParametersMayNotBeCallByName","ref":"ennru_VarValParametersMayNotBeCallByName","sha":"e4b8e3422633d2c68a76ed9f1c3a2ff9e91002f2","user":{"login":"ennru","id":458526,"avatar_url":"https://avatars0.githubusercontent.com/u/458526?v=3","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"repo":{"id":81984544,"name":"dotty","full_name":"ennru/dotty","owner":{"login":"ennru","id":458526,"avatar_url":"https://avatars0.githubusercontent.com/u/458526?v=3","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ennru/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":true,"url":"https://api.github.com/repos/ennru/dotty","forks_url":"https://api.github.com/repos/ennru/dotty/forks","keys_url":"https://api.github.com/repos/ennru/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ennru/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ennru/dotty/teams","hooks_url":"https://api.github.com/repos/ennru/dotty/hooks","issue_events_url":"https://api.github.com/repos/ennru/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/ennru/dotty/events","assignees_url":"https://api.github.com/repos/ennru/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/ennru/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/ennru/dotty/tags","blobs_url":"https://api.github.com/repos/ennru/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ennru/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ennru/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/ennru/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ennru/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/ennru/dotty/languages","stargazers_url":"https://api.github.com/repos/ennru/dotty/stargazers","contributors_url":"https://api.github.com/repos/ennru/dotty/contributors","subscribers_url":"https://api.github.com/repos/ennru/dotty/subscribers","subscription_url":"https://api.github.com/repos/ennru/dotty/subscription","commits_url":"https://api.github.com/repos/ennru/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/ennru/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/ennru/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/ennru/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/ennru/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/ennru/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ennru/dotty/merges","archive_url":"https://api.github.com/repos/ennru/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ennru/dotty/downloads","issues_url":"https://api.github.com/repos/ennru/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/ennru/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/ennru/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/ennru/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ennru/dotty/labels{/name}","releases_url":"https://api.github.com/repos/ennru/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/ennru/dotty/deployments","created_at":"2017-02-14T20:10:52Z","updated_at":"2017-02-14T20:11:01Z","pushed_at":"2017-05-16T20:55:02Z","git_url":"git://github.com/ennru/dotty.git","ssh_url":"git@github.com:ennru/dotty.git","clone_url":"https://github.com/ennru/dotty.git","svn_url":"https://github.com/ennru/dotty","homepage":"http://dotty.epfl.ch","size":32485,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lampepfl:master","ref":"master","sha":"8fbe0879f02adce6cf6685c831717a0e371cf556","user":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars2.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"name":"dotty","full_name":"lampepfl/dotty","owner":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars2.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lampepfl/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2017-05-16T19:13:25Z","pushed_at":"2017-05-16T20:57:50Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"git@github.com:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"http://dotty.epfl.ch","size":54220,"stargazers_count":1590,"watchers_count":1590,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":319,"forks":234,"open_issues":319,"watchers":1590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/2447"},"html":{"href":"https://github.com/lampepfl/dotty/pull/2447"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/2447"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/2447/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/2447/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/2447/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/e4b8e3422633d2c68a76ed9f1c3a2ff9e91002f2"}}}}
{"actor":{"display_login":"smarter"}}