{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/142855968","pull_request_review_id":67277860,"id":142855968,"diff_hunk":"@@ -719,26 +720,32 @@ double rk_wald(rk_state *state, double mean, double scale)\n \n long rk_zipf(rk_state *state, double a)\n {\n-    double T, U, V;\n-    long X;\n+    double T, U, V, X;","path":"numpy/random/mtrand/distributions.c","position":14,"original_position":14,"commit_id":"9950b82bb541ae0d160d2b53714bc2260214a7d5","original_commit_id":"9950b82bb541ae0d160d2b53714bc2260214a7d5","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"Can you move these declarations inside the loop now?","created_at":"2017-10-05T06:28:46Z","updated_at":"2017-10-05T06:28:46Z","html_url":"https://github.com/numpy/numpy/pull/9824#discussion_r142855968","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/9824","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/142855968"},"html":{"href":"https://github.com/numpy/numpy/pull/9824#discussion_r142855968"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9824"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/9824","id":144744005,"html_url":"https://github.com/numpy/numpy/pull/9824","diff_url":"https://github.com/numpy/numpy/pull/9824.diff","patch_url":"https://github.com/numpy/numpy/pull/9824.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/9824","number":9824,"state":"open","locked":false,"title":"BUG: Fix possibly undefined cast of double -> long.","user":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"Cleanup of #9680 \r\n\r\nCurrent double to long casting in the zipf function depends on non-standardized behavior when the double is too big to fit in a long. This is potentially dangerous and makes the code fail with tools such as AddressSanitizer.\r\n    \r\nChecks are added here to prevent overflow during casting and make sure we get the desired behavior.\r\n","created_at":"2017-10-04T18:36:40Z","updated_at":"2017-10-05T06:28:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad6137b158347b12a47726d58ddf4821ead5c431","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/9824/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/9824/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/9824/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/9950b82bb541ae0d160d2b53714bc2260214a7d5","head":{"label":"charris:gh-9680","ref":"gh-9680","sha":"9950b82bb541ae0d160d2b53714bc2260214a7d5","user":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"repo":{"id":908701,"name":"numpy","full_name":"charris/numpy","owner":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charris/numpy","description":"Fork of numpy/numpy","fork":true,"url":"https://api.github.com/repos/charris/numpy","forks_url":"https://api.github.com/repos/charris/numpy/forks","keys_url":"https://api.github.com/repos/charris/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charris/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charris/numpy/teams","hooks_url":"https://api.github.com/repos/charris/numpy/hooks","issue_events_url":"https://api.github.com/repos/charris/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/charris/numpy/events","assignees_url":"https://api.github.com/repos/charris/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/charris/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/charris/numpy/tags","blobs_url":"https://api.github.com/repos/charris/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charris/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charris/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/charris/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charris/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/charris/numpy/languages","stargazers_url":"https://api.github.com/repos/charris/numpy/stargazers","contributors_url":"https://api.github.com/repos/charris/numpy/contributors","subscribers_url":"https://api.github.com/repos/charris/numpy/subscribers","subscription_url":"https://api.github.com/repos/charris/numpy/subscription","commits_url":"https://api.github.com/repos/charris/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/charris/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/charris/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/charris/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/charris/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/charris/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charris/numpy/merges","archive_url":"https://api.github.com/repos/charris/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charris/numpy/downloads","issues_url":"https://api.github.com/repos/charris/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/charris/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/charris/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/charris/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charris/numpy/labels{/name}","releases_url":"https://api.github.com/repos/charris/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/charris/numpy/deployments","created_at":"2010-09-13T23:57:46Z","updated_at":"2015-05-02T19:17:10Z","pushed_at":"2017-10-04T18:33:51Z","git_url":"git://github.com/charris/numpy.git","ssh_url":"git@github.com:charris/numpy.git","clone_url":"https://github.com/charris/numpy.git","svn_url":"https://github.com/charris/numpy","homepage":"","size":51810,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"729df78cfff15adb1a78377f18050e91f919a724","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2017-10-05T05:22:25Z","pushed_at":"2017-10-04T23:21:52Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":53017,"stargazers_count":5185,"watchers_count":5185,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2275,"mirror_url":null,"open_issues_count":1690,"forks":2275,"open_issues":1690,"watchers":5185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9824"},"html":{"href":"https://github.com/numpy/numpy/pull/9824"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/9824"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/9824/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9824/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9824/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/9950b82bb541ae0d160d2b53714bc2260214a7d5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"eric-wieser"}}