{"action":"created","comment":{"url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/comments/158492072","pull_request_review_id":85314251,"id":158492072,"diff_hunk":"@@ -229,11 +229,12 @@ def _validate(self, array_type, test_shape, dtype,\n \n         np_input_array = numpy.asarray(input_array)\n \n-        if np_input_array.dtype == 'clongdouble':\n-            np_input_array = numpy.complex128(input_array)\n+        # TODO why are long double inputs copied to double precision?","path":"test/test_pyfftw_numpy_interface.py","position":35,"original_position":15,"commit_id":"41554a7dec90dbb153bfafab4998dc102f0d1a25","original_commit_id":"41554a7dec90dbb153bfafab4998dc102f0d1a25","user":{"login":"hgomersall","id":701883,"avatar_url":"https://avatars2.githubusercontent.com/u/701883?v=4","gravatar_id":"","url":"https://api.github.com/users/hgomersall","html_url":"https://github.com/hgomersall","followers_url":"https://api.github.com/users/hgomersall/followers","following_url":"https://api.github.com/users/hgomersall/following{/other_user}","gists_url":"https://api.github.com/users/hgomersall/gists{/gist_id}","starred_url":"https://api.github.com/users/hgomersall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgomersall/subscriptions","organizations_url":"https://api.github.com/users/hgomersall/orgs","repos_url":"https://api.github.com/users/hgomersall/repos","events_url":"https://api.github.com/users/hgomersall/events{/privacy}","received_events_url":"https://api.github.com/users/hgomersall/received_events","type":"User","site_admin":false},"body":"I can't remember the precise reason for this. There are all sorts of annoyances around `clongdouble`, particularly on windows. I suspect this sidesteps one of those issues. It might be your work supersedes this approach.","created_at":"2017-12-22T13:30:31Z","updated_at":"2017-12-22T13:30:31Z","html_url":"https://github.com/pyFFTW/pyFFTW/pull/189#discussion_r158492072","pull_request_url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/comments/158492072"},"html":{"href":"https://github.com/pyFFTW/pyFFTW/pull/189#discussion_r158492072"},"pull_request":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189","id":138300076,"html_url":"https://github.com/pyFFTW/pyFFTW/pull/189","diff_url":"https://github.com/pyFFTW/pyFFTW/pull/189.diff","patch_url":"https://github.com/pyFFTW/pyFFTW/pull/189.patch","issue_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/189","number":189,"state":"open","locked":false,"title":"[setup, pyx] Build only the parts for which FFTW libraries were found","user":{"login":"fredRos","id":1833693,"avatar_url":"https://avatars3.githubusercontent.com/u/1833693?v=4","gravatar_id":"","url":"https://api.github.com/users/fredRos","html_url":"https://github.com/fredRos","followers_url":"https://api.github.com/users/fredRos/followers","following_url":"https://api.github.com/users/fredRos/following{/other_user}","gists_url":"https://api.github.com/users/fredRos/gists{/gist_id}","starred_url":"https://api.github.com/users/fredRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredRos/subscriptions","organizations_url":"https://api.github.com/users/fredRos/orgs","repos_url":"https://api.github.com/users/fredRos/repos","events_url":"https://api.github.com/users/fredRos/events{/privacy}","received_events_url":"https://api.github.com/users/fredRos/received_events","type":"User","site_admin":false},"body":"After #177 and #185 have been merged, it remains to use available information on available libs during build time and during run time to run only available tests. \r\n\r\nThis is work in progress and should not be merged yet but I want to open the PR so you can have a look at what's coming.\r\n\r\nThe essential steps\r\n\r\n- [x] build with cython compile time `IF HAVE_DOUBLE`. Fixes long-standing issues #27 and #70\r\n- [x] skip tests for unavailable FFTW libs. Fixes #127","created_at":"2017-08-29T22:38:26Z","updated_at":"2017-12-22T13:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f455c587fecf24126ef29e2957bc6a70e91b8714","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189/commits","review_comments_url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189/comments","review_comment_url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/189/comments","statuses_url":"https://api.github.com/repos/pyFFTW/pyFFTW/statuses/41554a7dec90dbb153bfafab4998dc102f0d1a25","head":{"label":"fredRos:cond-tests","ref":"cond-tests","sha":"41554a7dec90dbb153bfafab4998dc102f0d1a25","user":{"login":"fredRos","id":1833693,"avatar_url":"https://avatars3.githubusercontent.com/u/1833693?v=4","gravatar_id":"","url":"https://api.github.com/users/fredRos","html_url":"https://github.com/fredRos","followers_url":"https://api.github.com/users/fredRos/followers","following_url":"https://api.github.com/users/fredRos/following{/other_user}","gists_url":"https://api.github.com/users/fredRos/gists{/gist_id}","starred_url":"https://api.github.com/users/fredRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredRos/subscriptions","organizations_url":"https://api.github.com/users/fredRos/orgs","repos_url":"https://api.github.com/users/fredRos/repos","events_url":"https://api.github.com/users/fredRos/events{/privacy}","received_events_url":"https://api.github.com/users/fredRos/received_events","type":"User","site_admin":false},"repo":{"id":17025872,"name":"pyFFTW","full_name":"fredRos/pyFFTW","owner":{"login":"fredRos","id":1833693,"avatar_url":"https://avatars3.githubusercontent.com/u/1833693?v=4","gravatar_id":"","url":"https://api.github.com/users/fredRos","html_url":"https://github.com/fredRos","followers_url":"https://api.github.com/users/fredRos/followers","following_url":"https://api.github.com/users/fredRos/following{/other_user}","gists_url":"https://api.github.com/users/fredRos/gists{/gist_id}","starred_url":"https://api.github.com/users/fredRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredRos/subscriptions","organizations_url":"https://api.github.com/users/fredRos/orgs","repos_url":"https://api.github.com/users/fredRos/repos","events_url":"https://api.github.com/users/fredRos/events{/privacy}","received_events_url":"https://api.github.com/users/fredRos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fredRos/pyFFTW","description":"A pythonic python wrapper around FFTW","fork":true,"url":"https://api.github.com/repos/fredRos/pyFFTW","forks_url":"https://api.github.com/repos/fredRos/pyFFTW/forks","keys_url":"https://api.github.com/repos/fredRos/pyFFTW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fredRos/pyFFTW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fredRos/pyFFTW/teams","hooks_url":"https://api.github.com/repos/fredRos/pyFFTW/hooks","issue_events_url":"https://api.github.com/repos/fredRos/pyFFTW/issues/events{/number}","events_url":"https://api.github.com/repos/fredRos/pyFFTW/events","assignees_url":"https://api.github.com/repos/fredRos/pyFFTW/assignees{/user}","branches_url":"https://api.github.com/repos/fredRos/pyFFTW/branches{/branch}","tags_url":"https://api.github.com/repos/fredRos/pyFFTW/tags","blobs_url":"https://api.github.com/repos/fredRos/pyFFTW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fredRos/pyFFTW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fredRos/pyFFTW/git/refs{/sha}","trees_url":"https://api.github.com/repos/fredRos/pyFFTW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fredRos/pyFFTW/statuses/{sha}","languages_url":"https://api.github.com/repos/fredRos/pyFFTW/languages","stargazers_url":"https://api.github.com/repos/fredRos/pyFFTW/stargazers","contributors_url":"https://api.github.com/repos/fredRos/pyFFTW/contributors","subscribers_url":"https://api.github.com/repos/fredRos/pyFFTW/subscribers","subscription_url":"https://api.github.com/repos/fredRos/pyFFTW/subscription","commits_url":"https://api.github.com/repos/fredRos/pyFFTW/commits{/sha}","git_commits_url":"https://api.github.com/repos/fredRos/pyFFTW/git/commits{/sha}","comments_url":"https://api.github.com/repos/fredRos/pyFFTW/comments{/number}","issue_comment_url":"https://api.github.com/repos/fredRos/pyFFTW/issues/comments{/number}","contents_url":"https://api.github.com/repos/fredRos/pyFFTW/contents/{+path}","compare_url":"https://api.github.com/repos/fredRos/pyFFTW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fredRos/pyFFTW/merges","archive_url":"https://api.github.com/repos/fredRos/pyFFTW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fredRos/pyFFTW/downloads","issues_url":"https://api.github.com/repos/fredRos/pyFFTW/issues{/number}","pulls_url":"https://api.github.com/repos/fredRos/pyFFTW/pulls{/number}","milestones_url":"https://api.github.com/repos/fredRos/pyFFTW/milestones{/number}","notifications_url":"https://api.github.com/repos/fredRos/pyFFTW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fredRos/pyFFTW/labels{/name}","releases_url":"https://api.github.com/repos/fredRos/pyFFTW/releases{/id}","deployments_url":"https://api.github.com/repos/fredRos/pyFFTW/deployments","created_at":"2014-02-20T15:55:23Z","updated_at":"2016-01-29T21:36:43Z","pushed_at":"2017-12-22T13:12:53Z","git_url":"git://github.com/fredRos/pyFFTW.git","ssh_url":"git@github.com:fredRos/pyFFTW.git","clone_url":"https://github.com/fredRos/pyFFTW.git","svn_url":"https://github.com/fredRos/pyFFTW","homepage":"http://hgomersall.github.com/pyFFTW/","size":1439,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"pyFFTW:master","ref":"master","sha":"c81c3fb2eac071f8eabfb02ed61550ae7af9f547","user":{"login":"pyFFTW","id":16965121,"avatar_url":"https://avatars3.githubusercontent.com/u/16965121?v=4","gravatar_id":"","url":"https://api.github.com/users/pyFFTW","html_url":"https://github.com/pyFFTW","followers_url":"https://api.github.com/users/pyFFTW/followers","following_url":"https://api.github.com/users/pyFFTW/following{/other_user}","gists_url":"https://api.github.com/users/pyFFTW/gists{/gist_id}","starred_url":"https://api.github.com/users/pyFFTW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyFFTW/subscriptions","organizations_url":"https://api.github.com/users/pyFFTW/orgs","repos_url":"https://api.github.com/users/pyFFTW/repos","events_url":"https://api.github.com/users/pyFFTW/events{/privacy}","received_events_url":"https://api.github.com/users/pyFFTW/received_events","type":"Organization","site_admin":false},"repo":{"id":3277149,"name":"pyFFTW","full_name":"pyFFTW/pyFFTW","owner":{"login":"pyFFTW","id":16965121,"avatar_url":"https://avatars3.githubusercontent.com/u/16965121?v=4","gravatar_id":"","url":"https://api.github.com/users/pyFFTW","html_url":"https://github.com/pyFFTW","followers_url":"https://api.github.com/users/pyFFTW/followers","following_url":"https://api.github.com/users/pyFFTW/following{/other_user}","gists_url":"https://api.github.com/users/pyFFTW/gists{/gist_id}","starred_url":"https://api.github.com/users/pyFFTW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyFFTW/subscriptions","organizations_url":"https://api.github.com/users/pyFFTW/orgs","repos_url":"https://api.github.com/users/pyFFTW/repos","events_url":"https://api.github.com/users/pyFFTW/events{/privacy}","received_events_url":"https://api.github.com/users/pyFFTW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyFFTW/pyFFTW","description":"A pythonic python wrapper around FFTW","fork":false,"url":"https://api.github.com/repos/pyFFTW/pyFFTW","forks_url":"https://api.github.com/repos/pyFFTW/pyFFTW/forks","keys_url":"https://api.github.com/repos/pyFFTW/pyFFTW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyFFTW/pyFFTW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyFFTW/pyFFTW/teams","hooks_url":"https://api.github.com/repos/pyFFTW/pyFFTW/hooks","issue_events_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/events{/number}","events_url":"https://api.github.com/repos/pyFFTW/pyFFTW/events","assignees_url":"https://api.github.com/repos/pyFFTW/pyFFTW/assignees{/user}","branches_url":"https://api.github.com/repos/pyFFTW/pyFFTW/branches{/branch}","tags_url":"https://api.github.com/repos/pyFFTW/pyFFTW/tags","blobs_url":"https://api.github.com/repos/pyFFTW/pyFFTW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyFFTW/pyFFTW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyFFTW/pyFFTW/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyFFTW/pyFFTW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyFFTW/pyFFTW/statuses/{sha}","languages_url":"https://api.github.com/repos/pyFFTW/pyFFTW/languages","stargazers_url":"https://api.github.com/repos/pyFFTW/pyFFTW/stargazers","contributors_url":"https://api.github.com/repos/pyFFTW/pyFFTW/contributors","subscribers_url":"https://api.github.com/repos/pyFFTW/pyFFTW/subscribers","subscription_url":"https://api.github.com/repos/pyFFTW/pyFFTW/subscription","commits_url":"https://api.github.com/repos/pyFFTW/pyFFTW/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyFFTW/pyFFTW/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyFFTW/pyFFTW/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyFFTW/pyFFTW/contents/{+path}","compare_url":"https://api.github.com/repos/pyFFTW/pyFFTW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyFFTW/pyFFTW/merges","archive_url":"https://api.github.com/repos/pyFFTW/pyFFTW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyFFTW/pyFFTW/downloads","issues_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues{/number}","pulls_url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls{/number}","milestones_url":"https://api.github.com/repos/pyFFTW/pyFFTW/milestones{/number}","notifications_url":"https://api.github.com/repos/pyFFTW/pyFFTW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyFFTW/pyFFTW/labels{/name}","releases_url":"https://api.github.com/repos/pyFFTW/pyFFTW/releases{/id}","deployments_url":"https://api.github.com/repos/pyFFTW/pyFFTW/deployments","created_at":"2012-01-26T20:27:19Z","updated_at":"2017-12-21T19:11:56Z","pushed_at":"2017-12-22T13:19:32Z","git_url":"git://github.com/pyFFTW/pyFFTW.git","ssh_url":"git@github.com:pyFFTW/pyFFTW.git","clone_url":"https://github.com/pyFFTW/pyFFTW.git","svn_url":"https://github.com/pyFFTW/pyFFTW","homepage":"http://pyfftw.readthedocs.io/en/latest/","size":1260,"stargazers_count":113,"watchers_count":113,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":53,"open_issues":36,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189"},"html":{"href":"https://github.com/pyFFTW/pyFFTW/pull/189"},"issue":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/189"},"comments":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/pyFFTW/pyFFTW/statuses/41554a7dec90dbb153bfafab4998dc102f0d1a25"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hgomersall"}}