{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7498","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7498/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7498/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7498/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/7498","id":249886513,"number":7498,"title":"Bugfix 1.1.x","user":{"login":"cdedwards","id":2271505,"avatar_url":"https://avatars3.githubusercontent.com/u/2271505?v=4","gravatar_id":"","url":"https://api.github.com/users/cdedwards","html_url":"https://github.com/cdedwards","followers_url":"https://api.github.com/users/cdedwards/followers","following_url":"https://api.github.com/users/cdedwards/following{/other_user}","gists_url":"https://api.github.com/users/cdedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/cdedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdedwards/subscriptions","organizations_url":"https://api.github.com/users/cdedwards/orgs","repos_url":"https://api.github.com/users/cdedwards/repos","events_url":"https://api.github.com/users/cdedwards/events{/privacy}","received_events_url":"https://api.github.com/users/cdedwards/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-13T17:23:41Z","updated_at":"2017-08-15T02:23:16Z","closed_at":"2017-08-14T00:03:16Z","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7498","html_url":"https://github.com/MarlinFirmware/Marlin/pull/7498","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/7498.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/7498.patch"},"body":"when doing a G26 the heater stats when warming the bed keep getting longer and longer due to a misused macro.\r\n\r\nThere should only be one line printed every 5000ms through the loop instead of the current printing a million.\r\n\r\nG26 will reproduce this from a the start..\r\n\r\nin file G26_MESH_VALIDATION_TOOL\r\nthe PENDING() should be changed to ELAPSED(). This exposes another feature, in print_heaterstates(). a missing SERIAL_EOL() at the bottom of the function in Marlin_main.cpp causes the \"busy processing\" to be printed on the same line as the heater states.\r\n\r\nSENT: M105\r\nREAD: T:26.28 /0.00 B:45.26 /60.00 @:0 B@:127\r\nREAD: echo:busy: processing\r\nbusy: processing\r\nSENT: M105\r\nREAD: echo:busy: processing\r\nThe above is how the display should be.. instead of the current mess.\r\n\r\nI'm still trying to figure out how to use github desktop. and as such, can not make a diff for these small changes.\r\n\r\nbool unified_bed_leveling::turn_on_heaters() {\r\nmillis_t next = millis() + 5000UL;\r\n#if HAS_TEMP_BED\r\n#if ENABLED(ULTRA_LCD)\r\nif (g26_bed_temp > 25) {\r\nlcd_setstatusPGM(PSTR(\"G26 Heating Bed.\"), 99);\r\nlcd_quick_feedback();\r\n#endif\r\nhas_control_of_lcd_panel = true;\r\nthermalManager.setTargetBed(g26_bed_temp);\r\nwhile (abs(thermalManager.degBed() - g26_bed_temp) > 3) {\r\n\r\n        #if ENABLED(NEWPANEL)\r\n          if (ubl_lcd_clicked()) return exit_from_g26();\r\n        #endif\r\n\r\n        if (ELAPSED(millis(), next)) {\r\n          next = millis() + 5000UL;\r\n          print_heaterstates();\r\n        }\r\n        idle();\r\n      }\r\n  #if ENABLED(ULTRA_LCD)\r\n    }\r\n    lcd_setstatusPGM(PSTR(\"G26 Heating Nozzle.\"), 99);\r\n    lcd_quick_feedback();\r\n  #endif\r\n#endif\r\n\r\n// Start heating the nozzle and wait for it to reach temperature.\r\nthermalManager.setTargetHotend(g26_hotend_temp, 0);\r\nwhile (abs(thermalManager.degHotend(0) - g26_hotend_temp) > 3) {\r\n\r\n  #if ENABLED(NEWPANEL)\r\n    if (ubl_lcd_clicked()) return exit_from_g26();\r\n  #endif\r\n\r\n  if (ELAPSED(millis(), next)) {\r\n    next = millis() + 5000UL;\r\n    print_heaterstates();\r\n  }\r\n  idle();\r\n}\r\nprint_heaterstates() in Marlin_main.cpp\r\n\r\n    SERIAL_PROTOCOL(thermalManager.getHeaterPower(e));\r\n  }\r\n#endif\r\nSERIAL_EOL();\r\n}\r\n#endif\r\n\r\nlooks like this is the wrong way of doing this."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/322359816","html_url":"https://github.com/MarlinFirmware/Marlin/pull/7498#issuecomment-322359816","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7498","id":322359816,"user":{"login":"cdedwards","id":2271505,"avatar_url":"https://avatars3.githubusercontent.com/u/2271505?v=4","gravatar_id":"","url":"https://api.github.com/users/cdedwards","html_url":"https://github.com/cdedwards","followers_url":"https://api.github.com/users/cdedwards/followers","following_url":"https://api.github.com/users/cdedwards/following{/other_user}","gists_url":"https://api.github.com/users/cdedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/cdedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdedwards/subscriptions","organizations_url":"https://api.github.com/users/cdedwards/orgs","repos_url":"https://api.github.com/users/cdedwards/repos","events_url":"https://api.github.com/users/cdedwards/events{/privacy}","received_events_url":"https://api.github.com/users/cdedwards/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T02:23:16Z","updated_at":"2017-08-15T02:23:16Z","body":"thanks for the help.. lotsa steps for three little changes :)"}}
{"actor":{"display_login":"cdedwards"}}