{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/107898767","pull_request_review_id":28898908,"id":107898767,"diff_hunk":"@@ -0,0 +1,120 @@\n+#\n+# Copyright 2017 Fujitsu LIMITED\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitation.\n+\n+package \"ansible\"\n+package \"monasca-installer\"\n+\n+cookbook_file \"/etc/ansible/ansible.cfg\" do\n+  source \"ansible.cfg\"\n+  owner \"root\"\n+  group \"root\"\n+  mode \"0644\"\n+end\n+\n+keystone_settings = KeystoneHelper.keystone_settings(node, @cookbook_name)\n+monasca_hosts = MonascaHelper.monasca_hosts(search(:node, \"roles:monasca-server\"))\n+\n+raise \"no nodes with monasca-server role found\" if monasca_hosts.nil? or monasca_hosts.empty?","path":"chef/cookbooks/monasca/recipes/master.rb","position":29,"original_position":29,"commit_id":"a569f3e44b9254d90404f13fac3a02567c139729","original_commit_id":"a569f3e44b9254d90404f13fac3a02567c139729","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/AndOr: Use || instead of or. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or)","created_at":"2017-03-24T13:13:43Z","updated_at":"2017-03-24T13:13:43Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/879#discussion_r107898767","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/107898767"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/879#discussion_r107898767"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879","id":112402707,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/879","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/879.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/879.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/879","number":879,"state":"open","locked":false,"title":"Add monasca barclamp","user":{"login":"samirjorina","id":14940860,"avatar_url":"https://avatars2.githubusercontent.com/u/14940860?v=3","gravatar_id":"","url":"https://api.github.com/users/samirjorina","html_url":"https://github.com/samirjorina","followers_url":"https://api.github.com/users/samirjorina/followers","following_url":"https://api.github.com/users/samirjorina/following{/other_user}","gists_url":"https://api.github.com/users/samirjorina/gists{/gist_id}","starred_url":"https://api.github.com/users/samirjorina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samirjorina/subscriptions","organizations_url":"https://api.github.com/users/samirjorina/orgs","repos_url":"https://api.github.com/users/samirjorina/repos","events_url":"https://api.github.com/users/samirjorina/events{/privacy}","received_events_url":"https://api.github.com/users/samirjorina/received_events","type":"User","site_admin":false},"body":"**Highlights:**\r\n- all backend services are managed by Ansible-based monasca-installer (https://gitlab.com/monasca-installer).\r\n- currently only single-node deployment is supported (clustered deployment is work in progress)\r\n- monasca backend services should use dedicated 'monitoring' network\r\n\r\n**Deployment:**\r\n- monasca-master role should be deployed on the admin (AKA crowbar) node - Ansible uses SSH keys, which are available there\r\n- monasa-server should be deployed on a dedicated, clean node\r\n- monasca-metric-agent and monasca-log-agent can be deployed to any node(s)\r\n","created_at":"2017-03-24T07:44:42Z","updated_at":"2017-03-24T13:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2359e274c6060d2cff4e69c8cf19e9efb098caf1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/879/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a569f3e44b9254d90404f13fac3a02567c139729","head":{"label":"FujitsuEnablingSoftwareTechnologyGmbH:monasca","ref":"monasca","sha":"a569f3e44b9254d90404f13fac3a02567c139729","user":{"login":"FujitsuEnablingSoftwareTechnologyGmbH","id":12654358,"avatar_url":"https://avatars0.githubusercontent.com/u/12654358?v=3","gravatar_id":"","url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH","html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH","followers_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/followers","following_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/following{/other_user}","gists_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/subscriptions","organizations_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/orgs","repos_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/repos","events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":78113367,"name":"crowbar-openstack","full_name":"FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack","owner":{"login":"FujitsuEnablingSoftwareTechnologyGmbH","id":12654358,"avatar_url":"https://avatars0.githubusercontent.com/u/12654358?v=3","gravatar_id":"","url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH","html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH","followers_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/followers","following_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/following{/other_user}","gists_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/subscriptions","organizations_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/orgs","repos_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/repos","events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack","forks_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack/deployments","created_at":"2017-01-05T13:02:32Z","updated_at":"2017-01-05T13:02:36Z","pushed_at":"2017-03-24T13:13:22Z","git_url":"git://github.com/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack.git","ssh_url":"git@github.com:FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack.git","clone_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack.git","svn_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/crowbar-openstack","homepage":null,"size":18306,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"monasca"}},"base":{"label":"crowbar:master","ref":"master","sha":"a3b1335e65f015db3220e2b7243c7736f504d7ee","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2017-03-24T11:40:40Z","pushed_at":"2017-03-24T13:13:23Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18498,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":59,"forks":54,"open_issues":59,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/879"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/879"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a569f3e44b9254d90404f13fac3a02567c139729"}}}}
{"actor":{"display_login":"houndci-bot"}}