{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/108555230","pull_request_review_id":29594054,"id":108555230,"diff_hunk":"@@ -114,7 +114,7 @@ def get_learner_data_record(self, enterprise_enrollment, completed_date=None, gr\n         course_completed = False\n         if completed_date is not None:\n             completed_timestamp = parse_datetime_to_epoch(completed_date)\n-            course_completed = True\n+            course_completed = True if is_passing else False","path":"integrated_channels/sap_success_factors/models.py","position":14,"original_position":14,"commit_id":"028fae8c01969d3549a8a5f2ebfa3d82267d22c9","original_commit_id":"028fae8c01969d3549a8a5f2ebfa3d82267d22c9","user":{"login":"pomegranited","id":7556571,"avatar_url":"https://avatars0.githubusercontent.com/u/7556571?v=3","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"Could simply be `course_completed = is_passing`","created_at":"2017-03-28T22:44:06Z","updated_at":"2017-03-28T22:52:46Z","html_url":"https://github.com/edx/edx-enterprise/pull/77#discussion_r108555230","pull_request_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/108555230"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/77#discussion_r108555230"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/77","id":113026597,"html_url":"https://github.com/edx/edx-enterprise/pull/77","diff_url":"https://github.com/edx/edx-enterprise/pull/77.diff","patch_url":"https://github.com/edx/edx-enterprise/pull/77.patch","issue_url":"https://api.github.com/repos/edx/edx-enterprise/issues/77","number":77,"state":"open","locked":false,"title":"ENT-286 Adjustment to grade and courseCompleted values","user":{"login":"brittneyexline","id":524809,"avatar_url":"https://avatars2.githubusercontent.com/u/524809?v=3","gravatar_id":"","url":"https://api.github.com/users/brittneyexline","html_url":"https://github.com/brittneyexline","followers_url":"https://api.github.com/users/brittneyexline/followers","following_url":"https://api.github.com/users/brittneyexline/following{/other_user}","gists_url":"https://api.github.com/users/brittneyexline/gists{/gist_id}","starred_url":"https://api.github.com/users/brittneyexline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittneyexline/subscriptions","organizations_url":"https://api.github.com/users/brittneyexline/orgs","repos_url":"https://api.github.com/users/brittneyexline/repos","events_url":"https://api.github.com/users/brittneyexline/events{/privacy}","received_events_url":"https://api.github.com/users/brittneyexline/received_events","type":"User","site_admin":false},"body":"**Description:** We were informed that courseCompleted should be false if the learner received a failing grade. Additionally, I updated the instructor paced grades to be sent as Pass/Fail like the self paced grades were.\r\n\r\n**JIRA:** https://openedx.atlassian.net/browse/ENT-286\r\n\r\n**Dependencies:** n/a\r\n\r\n**Merge deadline:** 3/31/2017\r\n\r\n**Installation instructions:** n/a\r\n\r\n**Testing instructions:**\r\n\r\nI'm not sure if any additional verification is necessary beyond the unit tests.\r\n\r\n**Merge checklist:**\r\n\r\n- [ ] Regenerate requirements with `make upgrade && make requirements` (and make sure to fix any errors).\r\n  **DO NOT** just add dependencies to `requirements/*.txt` files.\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Version bumped\r\n- [ ] Changelog record added\r\n- [ ] Documentation updated (not only docstrings)\r\n- [ ] Commits are (reasonably) squashed\r\n- [ ] Translations are updated\r\n- [ ] PR author is listed in AUTHORS\r\n\r\n**Post merge:**\r\n- [ ] Create a tag\r\n- [ ] Check new version is pushed to PyPi after tag-triggered build is finished.\r\n- [ ] Delete working branch (if not needed anymore)\r\n\r\n**Author concerns:** \r\n","created_at":"2017-03-28T17:39:52Z","updated_at":"2017-03-28T22:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9f9cd7dcba9f42488bc0755565040c79150ce01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/77/commits","review_comments_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/77/comments","review_comment_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/issues/77/comments","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/028fae8c01969d3549a8a5f2ebfa3d82267d22c9","head":{"label":"edx:bexline/sap_completion_status","ref":"bexline/sap_completion_status","sha":"028fae8c01969d3549a8a5f2ebfa3d82267d22c9","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-03-16T11:02:23Z","pushed_at":"2017-03-28T17:57:45Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":1059,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"528cb8dcd20556d157cfcb06b40b054d6bcbce0d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-03-16T11:02:23Z","pushed_at":"2017-03-28T17:57:45Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":1059,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/77"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/77"},"issue":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/77"},"comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-enterprise/statuses/028fae8c01969d3549a8a5f2ebfa3d82267d22c9"}}}}
{"actor":{"display_login":"pomegranited"}}