{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/155069156","pull_request_review_id":81327719,"id":155069156,"diff_hunk":"@@ -11,6 +11,6 @@ Create a default fully qualified app name.\n We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).\n */}}\n {{- define \"gcloud-sqlproxy.fullname\" -}}\n-{{- $name := default .Chart.Name .Values.nameOverride -}}\n-{{- printf \"%s-%s\" .Release.Name $name | trunc 63 | trimSuffix \"-\" -}}\n+{{- $name := .Values.nameOverride | default (printf \"%s-%s\" .Release.Name .Release.Name) -}}","path":"stable/gcloud-sqlproxy/templates/_helpers.tpl","position":6,"original_position":6,"commit_id":"cdd002f07ab7c04792c754d5c76863ca6a8a5c7f","original_commit_id":"cdd002f07ab7c04792c754d5c76863ca6a8a5c7f","user":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"body":"`nameOverride` is meant for the `name` template. Either add a `fullnameOverride` or do something like this: https://github.com/kubernetes/charts/blob/master/incubator/oauth-proxy/templates/_helpers.tpl#L14-L18","created_at":"2017-12-05T20:38:33Z","updated_at":"2017-12-05T20:39:02Z","html_url":"https://github.com/kubernetes/charts/pull/2773#discussion_r155069156","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/2773","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/155069156"},"html":{"href":"https://github.com/kubernetes/charts/pull/2773#discussion_r155069156"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/2773"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/2773","id":153289202,"html_url":"https://github.com/kubernetes/charts/pull/2773","diff_url":"https://github.com/kubernetes/charts/pull/2773.diff","patch_url":"https://github.com/kubernetes/charts/pull/2773.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/2773","number":2773,"state":"open","locked":false,"title":"Make value nameOverride overide name completely","user":{"login":"Tim-Smyth","id":33017641,"avatar_url":"https://avatars3.githubusercontent.com/u/33017641?v=4","gravatar_id":"","url":"https://api.github.com/users/Tim-Smyth","html_url":"https://github.com/Tim-Smyth","followers_url":"https://api.github.com/users/Tim-Smyth/followers","following_url":"https://api.github.com/users/Tim-Smyth/following{/other_user}","gists_url":"https://api.github.com/users/Tim-Smyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Tim-Smyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tim-Smyth/subscriptions","organizations_url":"https://api.github.com/users/Tim-Smyth/orgs","repos_url":"https://api.github.com/users/Tim-Smyth/repos","events_url":"https://api.github.com/users/Tim-Smyth/events{/privacy}","received_events_url":"https://api.github.com/users/Tim-Smyth/received_events","type":"User","site_admin":false},"body":"The value \"nameOverride\" should set the complete name of the deployment/service, not just a part of it.\r\n#2772 ","created_at":"2017-11-17T12:43:46Z","updated_at":"2017-12-05T20:39:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f626a4c6b5226b4fd635faf574fb342d90ad1e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/2773/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/2773/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/2773/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/cdd002f07ab7c04792c754d5c76863ca6a8a5c7f","head":{"label":"Tim-Smyth:gsqlNameOverride","ref":"gsqlNameOverride","sha":"cdd002f07ab7c04792c754d5c76863ca6a8a5c7f","user":{"login":"Tim-Smyth","id":33017641,"avatar_url":"https://avatars3.githubusercontent.com/u/33017641?v=4","gravatar_id":"","url":"https://api.github.com/users/Tim-Smyth","html_url":"https://github.com/Tim-Smyth","followers_url":"https://api.github.com/users/Tim-Smyth/followers","following_url":"https://api.github.com/users/Tim-Smyth/following{/other_user}","gists_url":"https://api.github.com/users/Tim-Smyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Tim-Smyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tim-Smyth/subscriptions","organizations_url":"https://api.github.com/users/Tim-Smyth/orgs","repos_url":"https://api.github.com/users/Tim-Smyth/repos","events_url":"https://api.github.com/users/Tim-Smyth/events{/privacy}","received_events_url":"https://api.github.com/users/Tim-Smyth/received_events","type":"User","site_admin":false},"repo":{"id":111098425,"name":"charts","full_name":"Tim-Smyth/charts","owner":{"login":"Tim-Smyth","id":33017641,"avatar_url":"https://avatars3.githubusercontent.com/u/33017641?v=4","gravatar_id":"","url":"https://api.github.com/users/Tim-Smyth","html_url":"https://github.com/Tim-Smyth","followers_url":"https://api.github.com/users/Tim-Smyth/followers","following_url":"https://api.github.com/users/Tim-Smyth/following{/other_user}","gists_url":"https://api.github.com/users/Tim-Smyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Tim-Smyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tim-Smyth/subscriptions","organizations_url":"https://api.github.com/users/Tim-Smyth/orgs","repos_url":"https://api.github.com/users/Tim-Smyth/repos","events_url":"https://api.github.com/users/Tim-Smyth/events{/privacy}","received_events_url":"https://api.github.com/users/Tim-Smyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tim-Smyth/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/Tim-Smyth/charts","forks_url":"https://api.github.com/repos/Tim-Smyth/charts/forks","keys_url":"https://api.github.com/repos/Tim-Smyth/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tim-Smyth/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tim-Smyth/charts/teams","hooks_url":"https://api.github.com/repos/Tim-Smyth/charts/hooks","issue_events_url":"https://api.github.com/repos/Tim-Smyth/charts/issues/events{/number}","events_url":"https://api.github.com/repos/Tim-Smyth/charts/events","assignees_url":"https://api.github.com/repos/Tim-Smyth/charts/assignees{/user}","branches_url":"https://api.github.com/repos/Tim-Smyth/charts/branches{/branch}","tags_url":"https://api.github.com/repos/Tim-Smyth/charts/tags","blobs_url":"https://api.github.com/repos/Tim-Smyth/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tim-Smyth/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tim-Smyth/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tim-Smyth/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tim-Smyth/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Tim-Smyth/charts/languages","stargazers_url":"https://api.github.com/repos/Tim-Smyth/charts/stargazers","contributors_url":"https://api.github.com/repos/Tim-Smyth/charts/contributors","subscribers_url":"https://api.github.com/repos/Tim-Smyth/charts/subscribers","subscription_url":"https://api.github.com/repos/Tim-Smyth/charts/subscription","commits_url":"https://api.github.com/repos/Tim-Smyth/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tim-Smyth/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tim-Smyth/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tim-Smyth/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tim-Smyth/charts/contents/{+path}","compare_url":"https://api.github.com/repos/Tim-Smyth/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tim-Smyth/charts/merges","archive_url":"https://api.github.com/repos/Tim-Smyth/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tim-Smyth/charts/downloads","issues_url":"https://api.github.com/repos/Tim-Smyth/charts/issues{/number}","pulls_url":"https://api.github.com/repos/Tim-Smyth/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Tim-Smyth/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Tim-Smyth/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tim-Smyth/charts/labels{/name}","releases_url":"https://api.github.com/repos/Tim-Smyth/charts/releases{/id}","deployments_url":"https://api.github.com/repos/Tim-Smyth/charts/deployments","created_at":"2017-11-17T11:57:39Z","updated_at":"2017-11-17T11:57:43Z","pushed_at":"2017-11-17T12:56:06Z","git_url":"git://github.com/Tim-Smyth/charts.git","ssh_url":"git@github.com:Tim-Smyth/charts.git","clone_url":"https://github.com/Tim-Smyth/charts.git","svn_url":"https://github.com/Tim-Smyth/charts","homepage":"","size":2915,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2202dcb07806f675790478493bc287e31089775b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2017-12-05T18:05:18Z","pushed_at":"2017-12-05T20:31:29Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":3149,"stargazers_count":1605,"watchers_count":1605,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1320,"mirror_url":null,"archived":false,"open_issues_count":459,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1320,"open_issues":459,"watchers":1605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/2773"},"html":{"href":"https://github.com/kubernetes/charts/pull/2773"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/2773"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/2773/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/2773/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/2773/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/cdd002f07ab7c04792c754d5c76863ca6a8a5c7f"}},"author_association":"NONE"}}
{"actor":{"display_login":"unguiculus"}}