{"action":"created","issue":{"url":"https://api.github.com/repos/vuejs/vue/issues/5993","repository_url":"https://api.github.com/repos/vuejs/vue","labels_url":"https://api.github.com/repos/vuejs/vue/issues/5993/labels{/name}","comments_url":"https://api.github.com/repos/vuejs/vue/issues/5993/comments","events_url":"https://api.github.com/repos/vuejs/vue/issues/5993/events","html_url":"https://github.com/vuejs/vue/pull/5993","id":239214806,"number":5993,"title":"added Object key sort prior to JSON.stringify comparison (fix #5908)","user":{"login":"drewsmith","id":595469,"avatar_url":"https://avatars0.githubusercontent.com/u/595469?v=3","gravatar_id":"","url":"https://api.github.com/users/drewsmith","html_url":"https://github.com/drewsmith","followers_url":"https://api.github.com/users/drewsmith/followers","following_url":"https://api.github.com/users/drewsmith/following{/other_user}","gists_url":"https://api.github.com/users/drewsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/drewsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewsmith/subscriptions","organizations_url":"https://api.github.com/users/drewsmith/orgs","repos_url":"https://api.github.com/users/drewsmith/repos","events_url":"https://api.github.com/users/drewsmith/events{/privacy}","received_events_url":"https://api.github.com/users/drewsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-28T16:02:59Z","updated_at":"2017-06-28T17:42:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vuejs/vue/pulls/5993","html_url":"https://github.com/vuejs/vue/pull/5993","diff_url":"https://github.com/vuejs/vue/pull/5993.diff","patch_url":"https://github.com/vuejs/vue/pull/5993.patch"},"body":"#5908\r\n\r\n<!--\r\nPlease make sure to read the Pull Request Guidelines:\r\nhttps://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines\r\n-->\r\n\r\n<!-- PULL REQUEST TEMPLATE -->\r\n<!-- (Update \"[ ]\" to \"[x]\" to check a box) -->\r\n\r\n**What kind of change does this PR introduce?** (check at least one)\r\n\r\n- [ ] Bugfix\r\n- [X] Feature\r\n- [ ] Code style update\r\n- [ ] Refactor\r\n- [ ] Build-related changes\r\n- [ ] Other, please describe: Improvement\r\n\r\n**Does this PR introduce a breaking change?** (check one)\r\n\r\n- [ ] Yes\r\n- [X] No\r\n\r\nIf yes, please describe the impact and migration path for existing applications:\r\n\r\n**The PR fulfills these requirements:**\r\n\r\n- [X] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch\r\n- [X] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where \"xxx\" is the issue number)\r\n- [X] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup\r\n- [X] New/updated tests are included\r\n\r\nIf adding a **new feature**, the PR's description includes:\r\n- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)\r\n\r\n**Other information:**\r\n"},"comment":{"url":"https://api.github.com/repos/vuejs/vue/issues/comments/311734487","html_url":"https://github.com/vuejs/vue/pull/5993#issuecomment-311734487","issue_url":"https://api.github.com/repos/vuejs/vue/issues/5993","id":311734487,"user":{"login":"znck","id":2596484,"avatar_url":"https://avatars3.githubusercontent.com/u/2596484?v=3","gravatar_id":"","url":"https://api.github.com/users/znck","html_url":"https://github.com/znck","followers_url":"https://api.github.com/users/znck/followers","following_url":"https://api.github.com/users/znck/following{/other_user}","gists_url":"https://api.github.com/users/znck/gists{/gist_id}","starred_url":"https://api.github.com/users/znck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/znck/subscriptions","organizations_url":"https://api.github.com/users/znck/orgs","repos_url":"https://api.github.com/users/znck/repos","events_url":"https://api.github.com/users/znck/events{/privacy}","received_events_url":"https://api.github.com/users/znck/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T17:42:16Z","updated_at":"2017-06-28T17:42:16Z","body":"I want to say, sorting the keys beats the purpose of `looseEqual`.\r\n\r\nAlso, `looseEqual` is used only in [model.js](https://github.com/vuejs/vue/blob/master/src/platforms/web/runtime/directives/model.js) for select options, I guess `stringify` serves the purpose there. @yyx990803 would know this better."}}
{"actor":{"display_login":"znck"}}