{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/145091047","pull_request_review_id":69837862,"id":145091047,"diff_hunk":"@@ -0,0 +1,16 @@\n+import ReactDOM from 'react-dom';\n+import Navbar from './scenes/Nav';\n+\n+let attempts = 0;\n+\n+function mountReact() {","path":"webpack/index.js","position":6,"original_position":6,"commit_id":"6f1f558bf65972a3f155f625427b12f4cebefc33","original_commit_id":"6f1f558bf65972a3f155f625427b12f4cebefc33","user":{"login":"ohadlevy","id":20167,"avatar_url":"https://avatars1.githubusercontent.com/u/20167?v=4","gravatar_id":"","url":"https://api.github.com/users/ohadlevy","html_url":"https://github.com/ohadlevy","followers_url":"https://api.github.com/users/ohadlevy/followers","following_url":"https://api.github.com/users/ohadlevy/following{/other_user}","gists_url":"https://api.github.com/users/ohadlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/ohadlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohadlevy/subscriptions","organizations_url":"https://api.github.com/users/ohadlevy/orgs","repos_url":"https://api.github.com/users/ohadlevy/repos","events_url":"https://api.github.com/users/ohadlevy/events{/privacy}","received_events_url":"https://api.github.com/users/ohadlevy/received_events","type":"User","site_admin":false},"body":"can you please just use the react mounter that exists in core instead ? :)","created_at":"2017-10-17T10:38:59Z","updated_at":"2017-10-17T10:38:59Z","html_url":"https://github.com/Katello/katello/pull/6992#discussion_r145091047","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/6992","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/145091047"},"html":{"href":"https://github.com/Katello/katello/pull/6992#discussion_r145091047"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/6992"}},"in_reply_to_id":145090784},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/6992","id":145196180,"html_url":"https://github.com/Katello/katello/pull/6992","diff_url":"https://github.com/Katello/katello/pull/6992.diff","patch_url":"https://github.com/Katello/katello/pull/6992.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/6992","number":6992,"state":"open","locked":false,"title":"Fixes #21009: React scaffolding for Katello","user":{"login":"danseethaler","id":11202705,"avatar_url":"https://avatars1.githubusercontent.com/u/11202705?v=4","gravatar_id":"","url":"https://api.github.com/users/danseethaler","html_url":"https://github.com/danseethaler","followers_url":"https://api.github.com/users/danseethaler/followers","following_url":"https://api.github.com/users/danseethaler/following{/other_user}","gists_url":"https://api.github.com/users/danseethaler/gists{/gist_id}","starred_url":"https://api.github.com/users/danseethaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danseethaler/subscriptions","organizations_url":"https://api.github.com/users/danseethaler/orgs","repos_url":"https://api.github.com/users/danseethaler/repos","events_url":"https://api.github.com/users/danseethaler/events{/privacy}","received_events_url":"https://api.github.com/users/danseethaler/received_events","type":"User","site_admin":false},"body":"The idea here is to leverage the placeholder div from [4894](https://github.com/theforeman/foreman/pull/4894) and mount the React navigation. This mounted component would be in charge of routing and also rendering the matching component to the DOM.\r\n\r\nhttp://projects.theforeman.org/issues/21009","created_at":"2017-10-06T16:35:41Z","updated_at":"2017-10-17T10:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a9ed121ad3dbd8c66895b5d271346341622a0a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/6992/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/6992/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/6992/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/6f1f558bf65972a3f155f625427b12f4cebefc33","head":{"label":"danseethaler:21009","ref":"21009","sha":"6f1f558bf65972a3f155f625427b12f4cebefc33","user":{"login":"danseethaler","id":11202705,"avatar_url":"https://avatars1.githubusercontent.com/u/11202705?v=4","gravatar_id":"","url":"https://api.github.com/users/danseethaler","html_url":"https://github.com/danseethaler","followers_url":"https://api.github.com/users/danseethaler/followers","following_url":"https://api.github.com/users/danseethaler/following{/other_user}","gists_url":"https://api.github.com/users/danseethaler/gists{/gist_id}","starred_url":"https://api.github.com/users/danseethaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danseethaler/subscriptions","organizations_url":"https://api.github.com/users/danseethaler/orgs","repos_url":"https://api.github.com/users/danseethaler/repos","events_url":"https://api.github.com/users/danseethaler/events{/privacy}","received_events_url":"https://api.github.com/users/danseethaler/received_events","type":"User","site_admin":false},"repo":{"id":100964877,"name":"katello","full_name":"danseethaler/katello","owner":{"login":"danseethaler","id":11202705,"avatar_url":"https://avatars1.githubusercontent.com/u/11202705?v=4","gravatar_id":"","url":"https://api.github.com/users/danseethaler","html_url":"https://github.com/danseethaler","followers_url":"https://api.github.com/users/danseethaler/followers","following_url":"https://api.github.com/users/danseethaler/following{/other_user}","gists_url":"https://api.github.com/users/danseethaler/gists{/gist_id}","starred_url":"https://api.github.com/users/danseethaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danseethaler/subscriptions","organizations_url":"https://api.github.com/users/danseethaler/orgs","repos_url":"https://api.github.com/users/danseethaler/repos","events_url":"https://api.github.com/users/danseethaler/events{/privacy}","received_events_url":"https://api.github.com/users/danseethaler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danseethaler/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/danseethaler/katello","forks_url":"https://api.github.com/repos/danseethaler/katello/forks","keys_url":"https://api.github.com/repos/danseethaler/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danseethaler/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danseethaler/katello/teams","hooks_url":"https://api.github.com/repos/danseethaler/katello/hooks","issue_events_url":"https://api.github.com/repos/danseethaler/katello/issues/events{/number}","events_url":"https://api.github.com/repos/danseethaler/katello/events","assignees_url":"https://api.github.com/repos/danseethaler/katello/assignees{/user}","branches_url":"https://api.github.com/repos/danseethaler/katello/branches{/branch}","tags_url":"https://api.github.com/repos/danseethaler/katello/tags","blobs_url":"https://api.github.com/repos/danseethaler/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danseethaler/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danseethaler/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/danseethaler/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danseethaler/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/danseethaler/katello/languages","stargazers_url":"https://api.github.com/repos/danseethaler/katello/stargazers","contributors_url":"https://api.github.com/repos/danseethaler/katello/contributors","subscribers_url":"https://api.github.com/repos/danseethaler/katello/subscribers","subscription_url":"https://api.github.com/repos/danseethaler/katello/subscription","commits_url":"https://api.github.com/repos/danseethaler/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/danseethaler/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/danseethaler/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/danseethaler/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/danseethaler/katello/contents/{+path}","compare_url":"https://api.github.com/repos/danseethaler/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danseethaler/katello/merges","archive_url":"https://api.github.com/repos/danseethaler/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danseethaler/katello/downloads","issues_url":"https://api.github.com/repos/danseethaler/katello/issues{/number}","pulls_url":"https://api.github.com/repos/danseethaler/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/danseethaler/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/danseethaler/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danseethaler/katello/labels{/name}","releases_url":"https://api.github.com/repos/danseethaler/katello/releases{/id}","deployments_url":"https://api.github.com/repos/danseethaler/katello/deployments","created_at":"2017-08-21T15:12:45Z","updated_at":"2017-08-21T15:12:57Z","pushed_at":"2017-10-12T15:04:42Z","git_url":"git://github.com/danseethaler/katello.git","ssh_url":"git@github.com:danseethaler/katello.git","clone_url":"https://github.com/danseethaler/katello.git","svn_url":"https://github.com/danseethaler/katello","homepage":"katello.org","size":90581,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"57cfe796fdef58da8531bc5ab62dc1381a752f3d","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2017-10-10T20:49:57Z","pushed_at":"2017-10-16T19:44:46Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":90654,"stargazers_count":219,"watchers_count":219,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":109,"forks":160,"open_issues":109,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/6992"},"html":{"href":"https://github.com/Katello/katello/pull/6992"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/6992"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/6992/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/6992/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/6992/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/6f1f558bf65972a3f155f625427b12f4cebefc33"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ohadlevy"}}