{"action":"closed","number":698,"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698","id":135814356,"html_url":"https://github.com/SonarSource/sonar-csharp/pull/698","diff_url":"https://github.com/SonarSource/sonar-csharp/pull/698.diff","patch_url":"https://github.com/SonarSource/sonar-csharp/pull/698.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/698","number":698,"state":"closed","locked":false,"title":"Rule S2699: Tests should include assertions","user":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"body":"Fix #665 \r\n\r\nCurrently we have quite a lot of FP related to private methods/classes used as helper (wrapping the call to the assertion).","created_at":"2017-08-15T14:36:28Z","updated_at":"2017-08-16T15:33:57Z","closed_at":"2017-08-16T15:33:57Z","merged_at":"2017-08-16T15:33:57Z","merge_commit_sha":"9b0772a593b320ad88d872302224c8ad0fb0c2f6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"valhristov","id":23195959,"avatar_url":"https://avatars2.githubusercontent.com/u/23195959?v=4","gravatar_id":"","url":"https://api.github.com/users/valhristov","html_url":"https://github.com/valhristov","followers_url":"https://api.github.com/users/valhristov/followers","following_url":"https://api.github.com/users/valhristov/following{/other_user}","gists_url":"https://api.github.com/users/valhristov/gists{/gist_id}","starred_url":"https://api.github.com/users/valhristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhristov/subscriptions","organizations_url":"https://api.github.com/users/valhristov/orgs","repos_url":"https://api.github.com/users/valhristov/repos","events_url":"https://api.github.com/users/valhristov/events{/privacy}","received_events_url":"https://api.github.com/users/valhristov/received_events","type":"User","site_admin":false},{"login":"michalb-sonar","id":28255392,"avatar_url":"https://avatars1.githubusercontent.com/u/28255392?v=4","gravatar_id":"","url":"https://api.github.com/users/michalb-sonar","html_url":"https://github.com/michalb-sonar","followers_url":"https://api.github.com/users/michalb-sonar/followers","following_url":"https://api.github.com/users/michalb-sonar/following{/other_user}","gists_url":"https://api.github.com/users/michalb-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/michalb-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalb-sonar/subscriptions","organizations_url":"https://api.github.com/users/michalb-sonar/orgs","repos_url":"https://api.github.com/users/michalb-sonar/repos","events_url":"https://api.github.com/users/michalb-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/michalb-sonar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/698/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/2df0d6a3fc60bab3b92875fa645427520fa31987","head":{"label":"SonarSource:rule-S2699","ref":"rule-S2699","sha":"2df0d6a3fc60bab3b92875fa645427520fa31987","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5582516,"name":"sonar-csharp","full_name":"SonarSource/sonar-csharp","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-csharp","description":"Code analyzer for C# projects","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-csharp","forks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-csharp/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-csharp/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-csharp/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-csharp/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-csharp/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/deployments","created_at":"2012-08-28T07:37:28Z","updated_at":"2017-08-10T14:02:12Z","pushed_at":"2017-08-16T15:33:57Z","git_url":"git://github.com/SonarSource/sonar-csharp.git","ssh_url":"git@github.com:SonarSource/sonar-csharp.git","clone_url":"https://github.com/SonarSource/sonar-csharp.git","svn_url":"https://github.com/SonarSource/sonar-csharp","homepage":"https://redirect.sonarsource.com/plugins/csharp.html","size":54875,"stargazers_count":96,"watchers_count":96,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":70,"forks":79,"open_issues":70,"watchers":96,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"26007d3e1c73175aa0784b6a3fbffdb330659a88","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5582516,"name":"sonar-csharp","full_name":"SonarSource/sonar-csharp","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-csharp","description":"Code analyzer for C# projects","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-csharp","forks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-csharp/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-csharp/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-csharp/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-csharp/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-csharp/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/deployments","created_at":"2012-08-28T07:37:28Z","updated_at":"2017-08-10T14:02:12Z","pushed_at":"2017-08-16T15:33:57Z","git_url":"git://github.com/SonarSource/sonar-csharp.git","ssh_url":"git@github.com:SonarSource/sonar-csharp.git","clone_url":"https://github.com/SonarSource/sonar-csharp.git","svn_url":"https://github.com/SonarSource/sonar-csharp","homepage":"https://redirect.sonarsource.com/plugins/csharp.html","size":54875,"stargazers_count":96,"watchers_count":96,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":70,"forks":79,"open_issues":70,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698"},"html":{"href":"https://github.com/SonarSource/sonar-csharp/pull/698"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/698"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/2df0d6a3fc60bab3b92875fa645427520fa31987"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":746,"deletions":5,"changed_files":15}}
{"actor":{"display_login":"Evangelink"}}