{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/125591767","pull_request_review_id":47993157,"id":125591767,"diff_hunk":"@@ -2,11 +2,39 @@ import Wreck from 'wreck';\n import Progress from '../progress';\n import { fromNode as fn } from 'bluebird';\n import { createWriteStream } from 'fs';\n+import HttpProxyAgent from 'http-proxy-agent';\n+import URL from 'url';\n+\n+function getProxyAgent(sourceUrl) {\n+  const httpProxy = process.env.HTTP_PROXY;","path":"src/cli_plugin/install/downloaders/http.js","position":8,"original_position":8,"commit_id":"a4990338ac20e9531eddd8a5f394d8be44a4e0d6","original_commit_id":"a4990338ac20e9531eddd8a5f394d8be44a4e0d6","user":{"login":"timroes","id":877229,"avatar_url":"https://avatars3.githubusercontent.com/u/877229?v=3","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"body":"Unfortunately the case of the env variable is not really specified. On Linux most programs use the lower case variant `http_proxy` (and same for `no_proxy`). Most programs support either lower or upper case and I think we should also try to use lower-case (preferred) and fallback to upper-case.","created_at":"2017-07-05T09:10:24Z","updated_at":"2017-07-05T09:12:23Z","html_url":"https://github.com/elastic/kibana/pull/10946#discussion_r125591767","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/10946","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/125591767"},"html":{"href":"https://github.com/elastic/kibana/pull/10946#discussion_r125591767"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10946"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10946","id":113311330,"html_url":"https://github.com/elastic/kibana/pull/10946","diff_url":"https://github.com/elastic/kibana/pull/10946.diff","patch_url":"https://github.com/elastic/kibana/pull/10946.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10946","number":10946,"state":"open","locked":false,"title":"Plugin installer proxy support","user":{"login":"thomasv314","id":584675,"avatar_url":"https://avatars0.githubusercontent.com/u/584675?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasv314","html_url":"https://github.com/thomasv314","followers_url":"https://api.github.com/users/thomasv314/followers","following_url":"https://api.github.com/users/thomasv314/following{/other_user}","gists_url":"https://api.github.com/users/thomasv314/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasv314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasv314/subscriptions","organizations_url":"https://api.github.com/users/thomasv314/orgs","repos_url":"https://api.github.com/users/thomasv314/repos","events_url":"https://api.github.com/users/thomasv314/events{/privacy}","received_events_url":"https://api.github.com/users/thomasv314/received_events","type":"User","site_admin":false},"body":"This commit fixes #5211  #5196 #5902 and possibly a few others.\r\n\r\nInstead of removing the Wreck dependency and changing the plugin CLI API like in PR #7967, it depends on `HTTP_PROXY` and `NO_PROXY` envvars.\r\n\r\nI did not include any tests for this only because I could not find them in the kibana repo. If you can point me to the right place I'd be more than happy to write a unit or feature test.","created_at":"2017-03-29T22:45:50Z","updated_at":"2017-07-05T09:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e63b8113c066bd267b3da95050dfca49f2d4aba0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/10946/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/10946/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10946/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/a4990338ac20e9531eddd8a5f394d8be44a4e0d6","head":{"label":"thomasv314:bugfix/5211-proxy-support-for-plugin-installation","ref":"bugfix/5211-proxy-support-for-plugin-installation","sha":"a4990338ac20e9531eddd8a5f394d8be44a4e0d6","user":{"login":"thomasv314","id":584675,"avatar_url":"https://avatars0.githubusercontent.com/u/584675?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasv314","html_url":"https://github.com/thomasv314","followers_url":"https://api.github.com/users/thomasv314/followers","following_url":"https://api.github.com/users/thomasv314/following{/other_user}","gists_url":"https://api.github.com/users/thomasv314/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasv314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasv314/subscriptions","organizations_url":"https://api.github.com/users/thomasv314/orgs","repos_url":"https://api.github.com/users/thomasv314/repos","events_url":"https://api.github.com/users/thomasv314/events{/privacy}","received_events_url":"https://api.github.com/users/thomasv314/received_events","type":"User","site_admin":false},"repo":{"id":86633429,"name":"kibana","full_name":"thomasv314/kibana","owner":{"login":"thomasv314","id":584675,"avatar_url":"https://avatars0.githubusercontent.com/u/584675?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasv314","html_url":"https://github.com/thomasv314","followers_url":"https://api.github.com/users/thomasv314/followers","following_url":"https://api.github.com/users/thomasv314/following{/other_user}","gists_url":"https://api.github.com/users/thomasv314/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasv314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasv314/subscriptions","organizations_url":"https://api.github.com/users/thomasv314/orgs","repos_url":"https://api.github.com/users/thomasv314/repos","events_url":"https://api.github.com/users/thomasv314/events{/privacy}","received_events_url":"https://api.github.com/users/thomasv314/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasv314/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/thomasv314/kibana","forks_url":"https://api.github.com/repos/thomasv314/kibana/forks","keys_url":"https://api.github.com/repos/thomasv314/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasv314/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasv314/kibana/teams","hooks_url":"https://api.github.com/repos/thomasv314/kibana/hooks","issue_events_url":"https://api.github.com/repos/thomasv314/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/thomasv314/kibana/events","assignees_url":"https://api.github.com/repos/thomasv314/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/thomasv314/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/thomasv314/kibana/tags","blobs_url":"https://api.github.com/repos/thomasv314/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasv314/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasv314/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasv314/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasv314/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasv314/kibana/languages","stargazers_url":"https://api.github.com/repos/thomasv314/kibana/stargazers","contributors_url":"https://api.github.com/repos/thomasv314/kibana/contributors","subscribers_url":"https://api.github.com/repos/thomasv314/kibana/subscribers","subscription_url":"https://api.github.com/repos/thomasv314/kibana/subscription","commits_url":"https://api.github.com/repos/thomasv314/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasv314/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasv314/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasv314/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasv314/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/thomasv314/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasv314/kibana/merges","archive_url":"https://api.github.com/repos/thomasv314/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasv314/kibana/downloads","issues_url":"https://api.github.com/repos/thomasv314/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/thomasv314/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasv314/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasv314/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasv314/kibana/labels{/name}","releases_url":"https://api.github.com/repos/thomasv314/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/thomasv314/kibana/deployments","created_at":"2017-03-29T22:02:08Z","updated_at":"2017-03-29T22:02:16Z","pushed_at":"2017-06-27T15:38:07Z","git_url":"git://github.com/thomasv314/kibana.git","ssh_url":"git@github.com:thomasv314/kibana.git","clone_url":"https://github.com/thomasv314/kibana.git","svn_url":"https://github.com/thomasv314/kibana","homepage":"https://www.elastic.co/products/kibana","size":235911,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"2cc836880e42821b890efb44e5bf3ecc0a50b4ec","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-07-05T08:40:22Z","pushed_at":"2017-07-05T08:15:15Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":260134,"stargazers_count":7575,"watchers_count":7575,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2919,"mirror_url":null,"open_issues_count":1832,"forks":2919,"open_issues":1832,"watchers":7575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10946"},"html":{"href":"https://github.com/elastic/kibana/pull/10946"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/10946"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/10946/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10946/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10946/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/a4990338ac20e9531eddd8a5f394d8be44a4e0d6"}}}}
{"actor":{"display_login":"timroes"}}