{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18996","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18996/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18996/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18996/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18996","id":250436038,"number":18996,"title":"storybook__react: Remove dependency on @types/node","user":{"login":"apexskier","id":329222,"avatar_url":"https://avatars3.githubusercontent.com/u/329222?v=4","gravatar_id":"","url":"https://api.github.com/users/apexskier","html_url":"https://github.com/apexskier","followers_url":"https://api.github.com/users/apexskier/followers","following_url":"https://api.github.com/users/apexskier/following{/other_user}","gists_url":"https://api.github.com/users/apexskier/gists{/gist_id}","starred_url":"https://api.github.com/users/apexskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apexskier/subscriptions","organizations_url":"https://api.github.com/users/apexskier/orgs","repos_url":"https://api.github.com/users/apexskier/repos","events_url":"https://api.github.com/users/apexskier/events{/privacy}","received_events_url":"https://api.github.com/users/apexskier/received_events","type":"User","site_admin":false},"labels":[{"id":395679059,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false},{"id":57534397,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-08-15T20:54:38Z","updated_at":"2017-08-15T22:41:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18996","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18996","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18996.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18996.patch"},"body":"Including `@types/node` is problematic because the storybook react api runs in a browser context. `@types/node` defines several globals that are incompatible with common browser contexts (such as `require` and `global`\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- ~Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>~\r\n- !Increase the version number in the header if appropriate.~\r\n- ~If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.~\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/322609227","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18996#issuecomment-322609227","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18996","id":322609227,"user":{"login":"joscha","id":188038,"avatar_url":"https://avatars3.githubusercontent.com/u/188038?v=4","gravatar_id":"","url":"https://api.github.com/users/joscha","html_url":"https://github.com/joscha","followers_url":"https://api.github.com/users/joscha/followers","following_url":"https://api.github.com/users/joscha/following{/other_user}","gists_url":"https://api.github.com/users/joscha/gists{/gist_id}","starred_url":"https://api.github.com/users/joscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscha/subscriptions","organizations_url":"https://api.github.com/users/joscha/orgs","repos_url":"https://api.github.com/users/joscha/repos","events_url":"https://api.github.com/users/joscha/events{/privacy}","received_events_url":"https://api.github.com/users/joscha/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T22:41:17Z","updated_at":"2017-08-15T22:41:17Z","body":"webpack-env 💯 As this is what storybook actually expects and uses the `.hot` member of."}}
{"actor":{"display_login":"joscha"}}