{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/134113583","pull_request_review_id":57370400,"id":134113583,"diff_hunk":"@@ -49,13 +55,21 @@ oppia.factory('explorationData', [\n     // Put exploration variables here.\n     var explorationData = {\n       explorationId: explorationId,\n+      // Note that the changeList is the full changeList since the last\n+      // commited version.","path":"core/templates/dev/head/pages/exploration_editor/EditorServices.js","position":null,"original_position":35,"commit_id":"daee7027ec45fcba9cba38700056161f79d2b029","original_commit_id":"a2ed15282a65eca3a4eaaae05463d136a0c8e467","user":{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-08-20T11:56:25Z","updated_at":"2017-08-20T11:56:25Z","html_url":"https://github.com/oppia/oppia/pull/3584#discussion_r134113583","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3584","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/134113583"},"html":{"href":"https://github.com/oppia/oppia/pull/3584#discussion_r134113583"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3584"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3584","id":127910852,"html_url":"https://github.com/oppia/oppia/pull/3584","diff_url":"https://github.com/oppia/oppia/pull/3584.diff","patch_url":"https://github.com/oppia/oppia/pull/3584.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3584","number":3584,"state":"open","locked":false,"title":"Fix #3295 Save draft change list to local storage.","user":{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false},"body":"Implements Milestone 3 of the task to extend the changeLists autosave functionality to local saves. \r\n\r\nA couple of preemptive questions about this PR:\r\n  - Testing: I wasn't entirely sure how to go about unit testing (or if unit testing is applicable). I thought pushing might help to clarify why but the changes are around the functionality in exploration data which is not tested directly (it is replicated using mock objects in tests). I think that an end to end test is more suitable to test the changes which won't be applicable until completion of the next milestone (I did manually test this PR to make sure it is behaving as expected).\r\n - If local storage doesn't exist: as discussed in the design doc if local storage doesn't exist then on the error callback a message should be displayed to the user (in the case of an internet connection issue) with the changes they may lose as opposed the current system in which no warning is currently displayed (in fact it seems it no longer warns the user they are offline and to refresh). To implement this I was thinking using a modal and checking if local storage doesn't exist in which case if this isn't a validation error then we display the modal. However as we are offline the modal template url won't be retrievable so it would have to be pre-loaded for this to work. This seems like a relatively large change so I thought perhaps if we wish to display the message it may be worth making another milestone in the design doc and committing this as the next PR. What do you think?","created_at":"2017-06-28T12:29:30Z","updated_at":"2017-08-20T11:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924ab1bc6d1a1470cf225681c81b7b95e4ce74ce","assignee":{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false},"assignees":[{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3584/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3584/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3584/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/daee7027ec45fcba9cba38700056161f79d2b029","head":{"label":"Anthony-Alridge:autosave-local","ref":"autosave-local","sha":"daee7027ec45fcba9cba38700056161f79d2b029","user":{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false},"repo":{"id":79559781,"name":"oppia","full_name":"Anthony-Alridge/oppia","owner":{"login":"Anthony-Alridge","id":16727074,"avatar_url":"https://avatars2.githubusercontent.com/u/16727074?v=4","gravatar_id":"","url":"https://api.github.com/users/Anthony-Alridge","html_url":"https://github.com/Anthony-Alridge","followers_url":"https://api.github.com/users/Anthony-Alridge/followers","following_url":"https://api.github.com/users/Anthony-Alridge/following{/other_user}","gists_url":"https://api.github.com/users/Anthony-Alridge/gists{/gist_id}","starred_url":"https://api.github.com/users/Anthony-Alridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anthony-Alridge/subscriptions","organizations_url":"https://api.github.com/users/Anthony-Alridge/orgs","repos_url":"https://api.github.com/users/Anthony-Alridge/repos","events_url":"https://api.github.com/users/Anthony-Alridge/events{/privacy}","received_events_url":"https://api.github.com/users/Anthony-Alridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Anthony-Alridge/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/Anthony-Alridge/oppia","forks_url":"https://api.github.com/repos/Anthony-Alridge/oppia/forks","keys_url":"https://api.github.com/repos/Anthony-Alridge/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anthony-Alridge/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anthony-Alridge/oppia/teams","hooks_url":"https://api.github.com/repos/Anthony-Alridge/oppia/hooks","issue_events_url":"https://api.github.com/repos/Anthony-Alridge/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/Anthony-Alridge/oppia/events","assignees_url":"https://api.github.com/repos/Anthony-Alridge/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/Anthony-Alridge/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/Anthony-Alridge/oppia/tags","blobs_url":"https://api.github.com/repos/Anthony-Alridge/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anthony-Alridge/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anthony-Alridge/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anthony-Alridge/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anthony-Alridge/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/Anthony-Alridge/oppia/languages","stargazers_url":"https://api.github.com/repos/Anthony-Alridge/oppia/stargazers","contributors_url":"https://api.github.com/repos/Anthony-Alridge/oppia/contributors","subscribers_url":"https://api.github.com/repos/Anthony-Alridge/oppia/subscribers","subscription_url":"https://api.github.com/repos/Anthony-Alridge/oppia/subscription","commits_url":"https://api.github.com/repos/Anthony-Alridge/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anthony-Alridge/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anthony-Alridge/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anthony-Alridge/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anthony-Alridge/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/Anthony-Alridge/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anthony-Alridge/oppia/merges","archive_url":"https://api.github.com/repos/Anthony-Alridge/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anthony-Alridge/oppia/downloads","issues_url":"https://api.github.com/repos/Anthony-Alridge/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/Anthony-Alridge/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/Anthony-Alridge/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/Anthony-Alridge/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anthony-Alridge/oppia/labels{/name}","releases_url":"https://api.github.com/repos/Anthony-Alridge/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/Anthony-Alridge/oppia/deployments","created_at":"2017-01-20T13:06:26Z","updated_at":"2017-01-20T13:06:32Z","pushed_at":"2017-08-20T11:36:47Z","git_url":"git://github.com/Anthony-Alridge/oppia.git","ssh_url":"git@github.com:Anthony-Alridge/oppia.git","clone_url":"https://github.com/Anthony-Alridge/oppia.git","svn_url":"https://github.com/Anthony-Alridge/oppia","homepage":"https://www.oppia.org","size":66524,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"80043168817baf2f37daea4c71c8493f39b2a011","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-08-15T17:54:59Z","pushed_at":"2017-08-20T11:36:50Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":68249,"stargazers_count":343,"watchers_count":343,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":453,"mirror_url":null,"open_issues_count":331,"forks":453,"open_issues":331,"watchers":343,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3584"},"html":{"href":"https://github.com/oppia/oppia/pull/3584"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3584"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3584/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3584/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3584/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/daee7027ec45fcba9cba38700056161f79d2b029"}}}}
{"actor":{"display_login":"Anthony-Alridge"}}