{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7","id":119656490,"html_url":"https://github.com/VruiVTK/VolumeViewer/pull/7","diff_url":"https://github.com/VruiVTK/VolumeViewer/pull/7.diff","patch_url":"https://github.com/VruiVTK/VolumeViewer/pull/7.patch","issue_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/7","number":7,"state":"closed","locked":false,"title":"Fixes for Vrui-4 enabling HTC Vive","user":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"body":"- Fixed menus\r\n- Fixed Vive rendering\r\n\r\nRelated: https://github.com/VruiVTK/vtkVRUI-superbuild/pull/2\r\n\r\nIn principal the VolumeViewer works but volume rendering looks a little bit odd:\r\n\r\nIt looks like the view direction is not passed to the volume rendering shader. So seen from the top it looks good but when diving in to the dataset one can see that the rendering happens on a surface which is always pointing upwards and not adapting to the viewing direction. It is hard to describe.. Also the volume rendering disappears completely when viewing from specific angles..","created_at":"2017-05-09T13:12:23Z","updated_at":"2017-05-12T13:15:17Z","closed_at":"2017-05-12T13:15:16Z","merged_at":"2017-05-12T13:15:16Z","merge_commit_sha":"b062e1c5249a760b1034d22f670d13ca8af38fae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7/commits","review_comments_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7/comments","review_comment_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/7/comments","statuses_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/statuses/86dc934a235e949ac427878a01dfed3a6577c173","head":{"label":"bilke:vrui-4","ref":"vrui-4","sha":"86dc934a235e949ac427878a01dfed3a6577c173","user":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"repo":{"id":90745840,"name":"VolumeViewer","full_name":"bilke/VolumeViewer","owner":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bilke/VolumeViewer","description":"Example application that can read VTK files","fork":true,"url":"https://api.github.com/repos/bilke/VolumeViewer","forks_url":"https://api.github.com/repos/bilke/VolumeViewer/forks","keys_url":"https://api.github.com/repos/bilke/VolumeViewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bilke/VolumeViewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bilke/VolumeViewer/teams","hooks_url":"https://api.github.com/repos/bilke/VolumeViewer/hooks","issue_events_url":"https://api.github.com/repos/bilke/VolumeViewer/issues/events{/number}","events_url":"https://api.github.com/repos/bilke/VolumeViewer/events","assignees_url":"https://api.github.com/repos/bilke/VolumeViewer/assignees{/user}","branches_url":"https://api.github.com/repos/bilke/VolumeViewer/branches{/branch}","tags_url":"https://api.github.com/repos/bilke/VolumeViewer/tags","blobs_url":"https://api.github.com/repos/bilke/VolumeViewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bilke/VolumeViewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bilke/VolumeViewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/bilke/VolumeViewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bilke/VolumeViewer/statuses/{sha}","languages_url":"https://api.github.com/repos/bilke/VolumeViewer/languages","stargazers_url":"https://api.github.com/repos/bilke/VolumeViewer/stargazers","contributors_url":"https://api.github.com/repos/bilke/VolumeViewer/contributors","subscribers_url":"https://api.github.com/repos/bilke/VolumeViewer/subscribers","subscription_url":"https://api.github.com/repos/bilke/VolumeViewer/subscription","commits_url":"https://api.github.com/repos/bilke/VolumeViewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/bilke/VolumeViewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/bilke/VolumeViewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/bilke/VolumeViewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/bilke/VolumeViewer/contents/{+path}","compare_url":"https://api.github.com/repos/bilke/VolumeViewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bilke/VolumeViewer/merges","archive_url":"https://api.github.com/repos/bilke/VolumeViewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bilke/VolumeViewer/downloads","issues_url":"https://api.github.com/repos/bilke/VolumeViewer/issues{/number}","pulls_url":"https://api.github.com/repos/bilke/VolumeViewer/pulls{/number}","milestones_url":"https://api.github.com/repos/bilke/VolumeViewer/milestones{/number}","notifications_url":"https://api.github.com/repos/bilke/VolumeViewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bilke/VolumeViewer/labels{/name}","releases_url":"https://api.github.com/repos/bilke/VolumeViewer/releases{/id}","deployments_url":"https://api.github.com/repos/bilke/VolumeViewer/deployments","created_at":"2017-05-09T12:57:32Z","updated_at":"2017-05-09T12:57:34Z","pushed_at":"2017-05-10T12:52:06Z","git_url":"git://github.com/bilke/VolumeViewer.git","ssh_url":"git@github.com:bilke/VolumeViewer.git","clone_url":"https://github.com/bilke/VolumeViewer.git","svn_url":"https://github.com/bilke/VolumeViewer","homepage":null,"size":16030,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VruiVTK:master","ref":"master","sha":"d3e327891721aaacc3521a910380ea086b427324","user":{"login":"VruiVTK","id":7798082,"avatar_url":"https://avatars1.githubusercontent.com/u/7798082?v=3","gravatar_id":"","url":"https://api.github.com/users/VruiVTK","html_url":"https://github.com/VruiVTK","followers_url":"https://api.github.com/users/VruiVTK/followers","following_url":"https://api.github.com/users/VruiVTK/following{/other_user}","gists_url":"https://api.github.com/users/VruiVTK/gists{/gist_id}","starred_url":"https://api.github.com/users/VruiVTK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VruiVTK/subscriptions","organizations_url":"https://api.github.com/users/VruiVTK/orgs","repos_url":"https://api.github.com/users/VruiVTK/repos","events_url":"https://api.github.com/users/VruiVTK/events{/privacy}","received_events_url":"https://api.github.com/users/VruiVTK/received_events","type":"Organization","site_admin":false},"repo":{"id":21441490,"name":"VolumeViewer","full_name":"VruiVTK/VolumeViewer","owner":{"login":"VruiVTK","id":7798082,"avatar_url":"https://avatars1.githubusercontent.com/u/7798082?v=3","gravatar_id":"","url":"https://api.github.com/users/VruiVTK","html_url":"https://github.com/VruiVTK","followers_url":"https://api.github.com/users/VruiVTK/followers","following_url":"https://api.github.com/users/VruiVTK/following{/other_user}","gists_url":"https://api.github.com/users/VruiVTK/gists{/gist_id}","starred_url":"https://api.github.com/users/VruiVTK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VruiVTK/subscriptions","organizations_url":"https://api.github.com/users/VruiVTK/orgs","repos_url":"https://api.github.com/users/VruiVTK/repos","events_url":"https://api.github.com/users/VruiVTK/events{/privacy}","received_events_url":"https://api.github.com/users/VruiVTK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VruiVTK/VolumeViewer","description":"Example application that can read VTK files","fork":false,"url":"https://api.github.com/repos/VruiVTK/VolumeViewer","forks_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/forks","keys_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/teams","hooks_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/hooks","issue_events_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/events{/number}","events_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/events","assignees_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/assignees{/user}","branches_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/branches{/branch}","tags_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/tags","blobs_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/statuses/{sha}","languages_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/languages","stargazers_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/stargazers","contributors_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/contributors","subscribers_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/subscribers","subscription_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/subscription","commits_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/contents/{+path}","compare_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/merges","archive_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/downloads","issues_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues{/number}","pulls_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls{/number}","milestones_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/milestones{/number}","notifications_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/labels{/name}","releases_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/releases{/id}","deployments_url":"https://api.github.com/repos/VruiVTK/VolumeViewer/deployments","created_at":"2014-07-02T21:48:37Z","updated_at":"2016-06-21T20:08:03Z","pushed_at":"2017-05-12T13:15:16Z","git_url":"git://github.com/VruiVTK/VolumeViewer.git","ssh_url":"git@github.com:VruiVTK/VolumeViewer.git","clone_url":"https://github.com/VruiVTK/VolumeViewer.git","svn_url":"https://github.com/VruiVTK/VolumeViewer","homepage":null,"size":16026,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7"},"html":{"href":"https://github.com/VruiVTK/VolumeViewer/pull/7"},"issue":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/7"},"comments":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/VruiVTK/VolumeViewer/statuses/86dc934a235e949ac427878a01dfed3a6577c173"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sankhesh","id":936354,"avatar_url":"https://avatars2.githubusercontent.com/u/936354?v=3","gravatar_id":"","url":"https://api.github.com/users/sankhesh","html_url":"https://github.com/sankhesh","followers_url":"https://api.github.com/users/sankhesh/followers","following_url":"https://api.github.com/users/sankhesh/following{/other_user}","gists_url":"https://api.github.com/users/sankhesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sankhesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sankhesh/subscriptions","organizations_url":"https://api.github.com/users/sankhesh/orgs","repos_url":"https://api.github.com/users/sankhesh/repos","events_url":"https://api.github.com/users/sankhesh/events{/privacy}","received_events_url":"https://api.github.com/users/sankhesh/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":45,"deletions":51,"changed_files":7}}
{"actor":{"display_login":"sankhesh"}}