{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17725","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17725/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17725/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17725/events","html_url":"https://github.com/Automattic/wp-calypso/pull/17725","id":254783400,"number":17725,"title":"Add Geolocation checks for the Masterbar pride styling","user":{"login":"pento","id":352291,"avatar_url":"https://avatars3.githubusercontent.com/u/352291?v=4","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"labels":[{"id":285010026,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Navigation","name":"Navigation","color":"006b75","default":false},{"id":542869111,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Size]%20S","name":"[Size] S","color":"aa71a7","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285009976,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"pento","id":352291,"avatar_url":"https://avatars3.githubusercontent.com/u/352291?v=4","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"assignees":[{"login":"pento","id":352291,"avatar_url":"https://avatars3.githubusercontent.com/u/352291?v=4","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-09-02T02:21:16Z","updated_at":"2017-09-04T08:07:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/17725","html_url":"https://github.com/Automattic/wp-calypso/pull/17725","diff_url":"https://github.com/Automattic/wp-calypso/pull/17725.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/17725.patch"},"body":"This pull request makes the pride styling check look at the new `X-GeoIP-Country-Code` header, which may contain accurate information.\r\n\r\n#### Testing instructions\r\n\r\n1. Run `git checkout add/pride-masterbar-geolocation`, and start your server\r\n2. Grep with no header sent: `curl http://calypso.localhost:3000/ | grep pride`\r\n3. Grep with the wrong header sent: `curl http://calypso.localhost:3000/ -H \"X-GeoIP-Country-Code: US\" | grep '\"pride\"'`\r\n3. Grep with the right header sent: `curl http://calypso.localhost:3000/ -H \"X-GeoIP-Country-Code: AU\" | grep '\"pride\"'`\r\n\r\nNote: The header isn't set automatically on calypso.live, but you can fake it. ie:\r\n\r\n`curl https://calypso.live/?branch=add/pride-masterbar-geolocation -H \"X-GeoIP-Country-Code: AU\" | ack '\"pride\"'`\r\n\r\nOnly the correct header should show any grep results.\r\n\r\n#### Reviews\r\n\r\n- [ ] Code\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/326894304","html_url":"https://github.com/Automattic/wp-calypso/pull/17725#issuecomment-326894304","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17725","id":326894304,"user":{"login":"yurynix","id":326402,"avatar_url":"https://avatars2.githubusercontent.com/u/326402?v=4","gravatar_id":"","url":"https://api.github.com/users/yurynix","html_url":"https://github.com/yurynix","followers_url":"https://api.github.com/users/yurynix/followers","following_url":"https://api.github.com/users/yurynix/following{/other_user}","gists_url":"https://api.github.com/users/yurynix/gists{/gist_id}","starred_url":"https://api.github.com/users/yurynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurynix/subscriptions","organizations_url":"https://api.github.com/users/yurynix/orgs","repos_url":"https://api.github.com/users/yurynix/repos","events_url":"https://api.github.com/users/yurynix/events{/privacy}","received_events_url":"https://api.github.com/users/yurynix/received_events","type":"User","site_admin":false},"created_at":"2017-09-04T08:07:14Z","updated_at":"2017-09-04T08:07:14Z","author_association":"CONTRIBUTOR","body":"IMO code looks fine, we can merge it and iterate later.\r\nThough, I think @Tug had some opinion regards that, related to SSR..."}}
{"actor":{"display_login":"yurynix"}}