{"action":"created","comment":{"url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/comments/141814883","pull_request_review_id":66087653,"id":141814883,"diff_hunk":"@@ -2,9 +2,9 @@\n \n class MsgProcessor(object):\n \n-    def __init__(self, handlers_list, encoding=None):\n+    def __init__(self, handlers_list, encoding=None, *args, **kwargs):\n         self._handlers = []\n-        self.processor_handlers = MsgProcessorHandlers(encoding=encoding)\n+        self.processor_handlers = MsgProcessorHandlers(encoding=encoding, *args, **kwargs)","path":"kafka_scanner/msg_processor.py","position":8,"original_position":8,"commit_id":"9013b69e392aa2f4153d01d8147e8e981763ad3d","original_commit_id":"3b8120745eb69f8e42e9f354c728170c40cb1ecc","user":{"login":"manugarri","id":3670355,"avatar_url":"https://avatars2.githubusercontent.com/u/3670355?v=4","gravatar_id":"","url":"https://api.github.com/users/manugarri","html_url":"https://github.com/manugarri","followers_url":"https://api.github.com/users/manugarri/followers","following_url":"https://api.github.com/users/manugarri/following{/other_user}","gists_url":"https://api.github.com/users/manugarri/gists{/gist_id}","starred_url":"https://api.github.com/users/manugarri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugarri/subscriptions","organizations_url":"https://api.github.com/users/manugarri/orgs","repos_url":"https://api.github.com/users/manugarri/repos","events_url":"https://api.github.com/users/manugarri/events{/privacy}","received_events_url":"https://api.github.com/users/manugarri/received_events","type":"User","site_admin":false},"body":"no, afaik this is perfectly valid. If it goes against SH style guide let me know and I can make it an unnamed argument (i always prefer using names for the shake of documenting but I see your point).","created_at":"2017-09-29T08:28:48Z","updated_at":"2017-09-29T08:28:48Z","html_url":"https://github.com/scrapinghub/kafka-scanner/pull/8#discussion_r141814883","pull_request_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/comments/141814883"},"html":{"href":"https://github.com/scrapinghub/kafka-scanner/pull/8#discussion_r141814883"},"pull_request":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8"}},"in_reply_to_id":141606733},"pull_request":{"url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8","id":143379405,"html_url":"https://github.com/scrapinghub/kafka-scanner/pull/8","diff_url":"https://github.com/scrapinghub/kafka-scanner/pull/8.diff","patch_url":"https://github.com/scrapinghub/kafka-scanner/pull/8.patch","issue_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/8","number":8,"state":"open","locked":false,"title":"Add support for json messages and no compression","user":{"login":"manugarri","id":3670355,"avatar_url":"https://avatars2.githubusercontent.com/u/3670355?v=4","gravatar_id":"","url":"https://api.github.com/users/manugarri","html_url":"https://github.com/manugarri","followers_url":"https://api.github.com/users/manugarri/followers","following_url":"https://api.github.com/users/manugarri/following{/other_user}","gists_url":"https://api.github.com/users/manugarri/gists{/gist_id}","starred_url":"https://api.github.com/users/manugarri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugarri/subscriptions","organizations_url":"https://api.github.com/users/manugarri/orgs","repos_url":"https://api.github.com/users/manugarri/repos","events_url":"https://api.github.com/users/manugarri/events{/privacy}","received_events_url":"https://api.github.com/users/manugarri/received_events","type":"User","site_admin":false},"body":"This PR implements the following changes:\r\n\r\n- Supports json encoded messages\r\n- Supports uncompressed messages\r\n- P3 compatible\r\n- Minor fixes (remove commented code and unused imports)\r\n\r\nI set all the default encoding to `msgpack` and the decompress to `True`. That should make it compatible with current use cases.\r\n","created_at":"2017-09-27T12:33:08Z","updated_at":"2017-09-29T08:28:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bd35d8e6a600e8b537b3a4a5e1efbe8a422fe54","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/8/comments","statuses_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/statuses/9013b69e392aa2f4153d01d8147e8e981763ad3d","head":{"label":"manugarri:addParams","ref":"addParams","sha":"9013b69e392aa2f4153d01d8147e8e981763ad3d","user":{"login":"manugarri","id":3670355,"avatar_url":"https://avatars2.githubusercontent.com/u/3670355?v=4","gravatar_id":"","url":"https://api.github.com/users/manugarri","html_url":"https://github.com/manugarri","followers_url":"https://api.github.com/users/manugarri/followers","following_url":"https://api.github.com/users/manugarri/following{/other_user}","gists_url":"https://api.github.com/users/manugarri/gists{/gist_id}","starred_url":"https://api.github.com/users/manugarri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugarri/subscriptions","organizations_url":"https://api.github.com/users/manugarri/orgs","repos_url":"https://api.github.com/users/manugarri/repos","events_url":"https://api.github.com/users/manugarri/events{/privacy}","received_events_url":"https://api.github.com/users/manugarri/received_events","type":"User","site_admin":false},"repo":{"id":104996969,"name":"kafka-scanner","full_name":"manugarri/kafka-scanner","owner":{"login":"manugarri","id":3670355,"avatar_url":"https://avatars2.githubusercontent.com/u/3670355?v=4","gravatar_id":"","url":"https://api.github.com/users/manugarri","html_url":"https://github.com/manugarri","followers_url":"https://api.github.com/users/manugarri/followers","following_url":"https://api.github.com/users/manugarri/following{/other_user}","gists_url":"https://api.github.com/users/manugarri/gists{/gist_id}","starred_url":"https://api.github.com/users/manugarri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugarri/subscriptions","organizations_url":"https://api.github.com/users/manugarri/orgs","repos_url":"https://api.github.com/users/manugarri/repos","events_url":"https://api.github.com/users/manugarri/events{/privacy}","received_events_url":"https://api.github.com/users/manugarri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manugarri/kafka-scanner","description":"High Level Kafka Scanner","fork":true,"url":"https://api.github.com/repos/manugarri/kafka-scanner","forks_url":"https://api.github.com/repos/manugarri/kafka-scanner/forks","keys_url":"https://api.github.com/repos/manugarri/kafka-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manugarri/kafka-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manugarri/kafka-scanner/teams","hooks_url":"https://api.github.com/repos/manugarri/kafka-scanner/hooks","issue_events_url":"https://api.github.com/repos/manugarri/kafka-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/manugarri/kafka-scanner/events","assignees_url":"https://api.github.com/repos/manugarri/kafka-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/manugarri/kafka-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/manugarri/kafka-scanner/tags","blobs_url":"https://api.github.com/repos/manugarri/kafka-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manugarri/kafka-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manugarri/kafka-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/manugarri/kafka-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manugarri/kafka-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/manugarri/kafka-scanner/languages","stargazers_url":"https://api.github.com/repos/manugarri/kafka-scanner/stargazers","contributors_url":"https://api.github.com/repos/manugarri/kafka-scanner/contributors","subscribers_url":"https://api.github.com/repos/manugarri/kafka-scanner/subscribers","subscription_url":"https://api.github.com/repos/manugarri/kafka-scanner/subscription","commits_url":"https://api.github.com/repos/manugarri/kafka-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/manugarri/kafka-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/manugarri/kafka-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/manugarri/kafka-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/manugarri/kafka-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/manugarri/kafka-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manugarri/kafka-scanner/merges","archive_url":"https://api.github.com/repos/manugarri/kafka-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manugarri/kafka-scanner/downloads","issues_url":"https://api.github.com/repos/manugarri/kafka-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/manugarri/kafka-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/manugarri/kafka-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/manugarri/kafka-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manugarri/kafka-scanner/labels{/name}","releases_url":"https://api.github.com/repos/manugarri/kafka-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/manugarri/kafka-scanner/deployments","created_at":"2017-09-27T09:07:05Z","updated_at":"2017-09-27T09:07:07Z","pushed_at":"2017-09-29T08:26:28Z","git_url":"git://github.com/manugarri/kafka-scanner.git","ssh_url":"git@github.com:manugarri/kafka-scanner.git","clone_url":"https://github.com/manugarri/kafka-scanner.git","svn_url":"https://github.com/manugarri/kafka-scanner","homepage":"","size":202,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"38779601d5b3514b907caf129a39e8f6ed3266ae","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars3.githubusercontent.com/u/699596?v=4","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":40253012,"name":"kafka-scanner","full_name":"scrapinghub/kafka-scanner","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars3.githubusercontent.com/u/699596?v=4","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/kafka-scanner","description":"High Level Kafka Scanner","fork":false,"url":"https://api.github.com/repos/scrapinghub/kafka-scanner","forks_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/forks","keys_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/teams","hooks_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/events","assignees_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/tags","blobs_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/subscription","commits_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/merges","archive_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/downloads","issues_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/kafka-scanner/deployments","created_at":"2015-08-05T15:22:44Z","updated_at":"2017-08-25T00:20:34Z","pushed_at":"2017-09-29T08:26:29Z","git_url":"git://github.com/scrapinghub/kafka-scanner.git","ssh_url":"git@github.com:scrapinghub/kafka-scanner.git","clone_url":"https://github.com/scrapinghub/kafka-scanner.git","svn_url":"https://github.com/scrapinghub/kafka-scanner","homepage":"","size":200,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8"},"html":{"href":"https://github.com/scrapinghub/kafka-scanner/pull/8"},"issue":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/8"},"comments":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/kafka-scanner/statuses/9013b69e392aa2f4153d01d8147e8e981763ad3d"}},"author_association":"NONE"}}
{"actor":{"display_login":"manugarri"}}