{"action":"created","comment":{"url":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments/123793610","pull_request_review_id":46033527,"id":123793610,"diff_hunk":"@@ -83,6 +82,62 @@ After running `aws-mfa`, your credentials file would read:\n     aws_secret_access_key = <POPULATED_BY_AWS-MFA>\n     aws_security_token = <POPULATED_BY_AWS-MFA>\n \n+The default naming convention for the credential section can be overriden by using the ``--long-term-suffix`` and\n+``--short-term-suffix`` command line arguments. For example, in a multi account scenario you can have one AWS account","path":"README.rst","position":40,"original_position":40,"commit_id":"6422757de1c4551e090f21f16a3159ca8082e1cb","original_commit_id":"6422757de1c4551e090f21f16a3159ca8082e1cb","user":{"login":"broamski","id":5578240,"avatar_url":"https://avatars1.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"body":"I'm not sure I follow. If you are in a multi-account scenario, your `long-term` credentials are going to be different for each account. So, you shouldn't be able to re-use one pair of `long-term` credentials on multiple accounts.\r\n\r\nI sort of understand the need to customize the prefix. But below, you've just replaced the value `default` with `myorganization`, so there is no functional difference. Try taking a look at: http://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html for more details on named profiles.","created_at":"2017-06-23T16:41:27Z","updated_at":"2017-06-23T16:41:47Z","html_url":"https://github.com/broamski/aws-mfa/pull/16#discussion_r123793610","pull_request_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments/123793610"},"html":{"href":"https://github.com/broamski/aws-mfa/pull/16#discussion_r123793610"},"pull_request":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/broamski/aws-mfa/pulls/16","id":127175804,"html_url":"https://github.com/broamski/aws-mfa/pull/16","diff_url":"https://github.com/broamski/aws-mfa/pull/16.diff","patch_url":"https://github.com/broamski/aws-mfa/pull/16.patch","issue_url":"https://api.github.com/repos/broamski/aws-mfa/issues/16","number":16,"state":"open","locked":false,"title":"[ADD] override naming convention with command line arguments","user":{"login":"rehos","id":454303,"avatar_url":"https://avatars2.githubusercontent.com/u/454303?v=3","gravatar_id":"","url":"https://api.github.com/users/rehos","html_url":"https://github.com/rehos","followers_url":"https://api.github.com/users/rehos/followers","following_url":"https://api.github.com/users/rehos/following{/other_user}","gists_url":"https://api.github.com/users/rehos/gists{/gist_id}","starred_url":"https://api.github.com/users/rehos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehos/subscriptions","organizations_url":"https://api.github.com/users/rehos/orgs","repos_url":"https://api.github.com/users/rehos/repos","events_url":"https://api.github.com/users/rehos/events{/privacy}","received_events_url":"https://api.github.com/users/rehos/received_events","type":"User","site_admin":false},"body":"I have added two new command line arguments ```--long-term-suffix``` and ```--short-term-suffix``` to be able to override the default naming convention for the credential sections.","created_at":"2017-06-23T10:12:31Z","updated_at":"2017-06-23T16:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"498933238746a9a26064d29da0699dd9260c13a0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/16/commits","review_comments_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/16/comments","review_comment_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broamski/aws-mfa/issues/16/comments","statuses_url":"https://api.github.com/repos/broamski/aws-mfa/statuses/6422757de1c4551e090f21f16a3159ca8082e1cb","head":{"label":"rehos:feature/override-naming-convention","ref":"feature/override-naming-convention","sha":"6422757de1c4551e090f21f16a3159ca8082e1cb","user":{"login":"rehos","id":454303,"avatar_url":"https://avatars2.githubusercontent.com/u/454303?v=3","gravatar_id":"","url":"https://api.github.com/users/rehos","html_url":"https://github.com/rehos","followers_url":"https://api.github.com/users/rehos/followers","following_url":"https://api.github.com/users/rehos/following{/other_user}","gists_url":"https://api.github.com/users/rehos/gists{/gist_id}","starred_url":"https://api.github.com/users/rehos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehos/subscriptions","organizations_url":"https://api.github.com/users/rehos/orgs","repos_url":"https://api.github.com/users/rehos/repos","events_url":"https://api.github.com/users/rehos/events{/privacy}","received_events_url":"https://api.github.com/users/rehos/received_events","type":"User","site_admin":false},"repo":{"id":95207995,"name":"aws-mfa","full_name":"rehos/aws-mfa","owner":{"login":"rehos","id":454303,"avatar_url":"https://avatars2.githubusercontent.com/u/454303?v=3","gravatar_id":"","url":"https://api.github.com/users/rehos","html_url":"https://github.com/rehos","followers_url":"https://api.github.com/users/rehos/followers","following_url":"https://api.github.com/users/rehos/following{/other_user}","gists_url":"https://api.github.com/users/rehos/gists{/gist_id}","starred_url":"https://api.github.com/users/rehos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehos/subscriptions","organizations_url":"https://api.github.com/users/rehos/orgs","repos_url":"https://api.github.com/users/rehos/repos","events_url":"https://api.github.com/users/rehos/events{/privacy}","received_events_url":"https://api.github.com/users/rehos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rehos/aws-mfa","description":"Manage AWS MFA Security Credentials","fork":true,"url":"https://api.github.com/repos/rehos/aws-mfa","forks_url":"https://api.github.com/repos/rehos/aws-mfa/forks","keys_url":"https://api.github.com/repos/rehos/aws-mfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rehos/aws-mfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rehos/aws-mfa/teams","hooks_url":"https://api.github.com/repos/rehos/aws-mfa/hooks","issue_events_url":"https://api.github.com/repos/rehos/aws-mfa/issues/events{/number}","events_url":"https://api.github.com/repos/rehos/aws-mfa/events","assignees_url":"https://api.github.com/repos/rehos/aws-mfa/assignees{/user}","branches_url":"https://api.github.com/repos/rehos/aws-mfa/branches{/branch}","tags_url":"https://api.github.com/repos/rehos/aws-mfa/tags","blobs_url":"https://api.github.com/repos/rehos/aws-mfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rehos/aws-mfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rehos/aws-mfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/rehos/aws-mfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rehos/aws-mfa/statuses/{sha}","languages_url":"https://api.github.com/repos/rehos/aws-mfa/languages","stargazers_url":"https://api.github.com/repos/rehos/aws-mfa/stargazers","contributors_url":"https://api.github.com/repos/rehos/aws-mfa/contributors","subscribers_url":"https://api.github.com/repos/rehos/aws-mfa/subscribers","subscription_url":"https://api.github.com/repos/rehos/aws-mfa/subscription","commits_url":"https://api.github.com/repos/rehos/aws-mfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/rehos/aws-mfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/rehos/aws-mfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/rehos/aws-mfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/rehos/aws-mfa/contents/{+path}","compare_url":"https://api.github.com/repos/rehos/aws-mfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rehos/aws-mfa/merges","archive_url":"https://api.github.com/repos/rehos/aws-mfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rehos/aws-mfa/downloads","issues_url":"https://api.github.com/repos/rehos/aws-mfa/issues{/number}","pulls_url":"https://api.github.com/repos/rehos/aws-mfa/pulls{/number}","milestones_url":"https://api.github.com/repos/rehos/aws-mfa/milestones{/number}","notifications_url":"https://api.github.com/repos/rehos/aws-mfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rehos/aws-mfa/labels{/name}","releases_url":"https://api.github.com/repos/rehos/aws-mfa/releases{/id}","deployments_url":"https://api.github.com/repos/rehos/aws-mfa/deployments","created_at":"2017-06-23T09:58:21Z","updated_at":"2017-06-23T09:58:23Z","pushed_at":"2017-06-23T10:26:41Z","git_url":"git://github.com/rehos/aws-mfa.git","ssh_url":"git@github.com:rehos/aws-mfa.git","clone_url":"https://github.com/rehos/aws-mfa.git","svn_url":"https://github.com/rehos/aws-mfa","homepage":"","size":37,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"broamski:master","ref":"master","sha":"c3e4e4cd1f980f84fa075f16263e2b68bba32d9c","user":{"login":"broamski","id":5578240,"avatar_url":"https://avatars1.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"repo":{"id":48399035,"name":"aws-mfa","full_name":"broamski/aws-mfa","owner":{"login":"broamski","id":5578240,"avatar_url":"https://avatars1.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/broamski/aws-mfa","description":"Manage AWS MFA Security Credentials","fork":false,"url":"https://api.github.com/repos/broamski/aws-mfa","forks_url":"https://api.github.com/repos/broamski/aws-mfa/forks","keys_url":"https://api.github.com/repos/broamski/aws-mfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broamski/aws-mfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broamski/aws-mfa/teams","hooks_url":"https://api.github.com/repos/broamski/aws-mfa/hooks","issue_events_url":"https://api.github.com/repos/broamski/aws-mfa/issues/events{/number}","events_url":"https://api.github.com/repos/broamski/aws-mfa/events","assignees_url":"https://api.github.com/repos/broamski/aws-mfa/assignees{/user}","branches_url":"https://api.github.com/repos/broamski/aws-mfa/branches{/branch}","tags_url":"https://api.github.com/repos/broamski/aws-mfa/tags","blobs_url":"https://api.github.com/repos/broamski/aws-mfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broamski/aws-mfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broamski/aws-mfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/broamski/aws-mfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broamski/aws-mfa/statuses/{sha}","languages_url":"https://api.github.com/repos/broamski/aws-mfa/languages","stargazers_url":"https://api.github.com/repos/broamski/aws-mfa/stargazers","contributors_url":"https://api.github.com/repos/broamski/aws-mfa/contributors","subscribers_url":"https://api.github.com/repos/broamski/aws-mfa/subscribers","subscription_url":"https://api.github.com/repos/broamski/aws-mfa/subscription","commits_url":"https://api.github.com/repos/broamski/aws-mfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/broamski/aws-mfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/broamski/aws-mfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/broamski/aws-mfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/broamski/aws-mfa/contents/{+path}","compare_url":"https://api.github.com/repos/broamski/aws-mfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broamski/aws-mfa/merges","archive_url":"https://api.github.com/repos/broamski/aws-mfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broamski/aws-mfa/downloads","issues_url":"https://api.github.com/repos/broamski/aws-mfa/issues{/number}","pulls_url":"https://api.github.com/repos/broamski/aws-mfa/pulls{/number}","milestones_url":"https://api.github.com/repos/broamski/aws-mfa/milestones{/number}","notifications_url":"https://api.github.com/repos/broamski/aws-mfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broamski/aws-mfa/labels{/name}","releases_url":"https://api.github.com/repos/broamski/aws-mfa/releases{/id}","deployments_url":"https://api.github.com/repos/broamski/aws-mfa/deployments","created_at":"2015-12-21T23:11:38Z","updated_at":"2017-06-18T22:45:47Z","pushed_at":"2017-06-23T10:26:42Z","git_url":"git://github.com/broamski/aws-mfa.git","ssh_url":"git@github.com:broamski/aws-mfa.git","clone_url":"https://github.com/broamski/aws-mfa.git","svn_url":"https://github.com/broamski/aws-mfa","homepage":"","size":40,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/16"},"html":{"href":"https://github.com/broamski/aws-mfa/pull/16"},"issue":{"href":"https://api.github.com/repos/broamski/aws-mfa/issues/16"},"comments":{"href":"https://api.github.com/repos/broamski/aws-mfa/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/broamski/aws-mfa/statuses/6422757de1c4551e090f21f16a3159ca8082e1cb"}}}}
{"actor":{"display_login":"broamski"}}