{"action":"created","comment":{"url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/comments/155926142","pull_request_review_id":82328899,"id":155926142,"diff_hunk":"@@ -0,0 +1,233 @@\n+/*\n+* Colors used in this theme from light to dark:\n+* - #EDFAFD (Glass)\n+* - #AED9DA (Chill)\n+* - #3DDAD7 (Californian Coral)\n+* - #2A93D5 (Bondi Blue)\n+* - #135589 (Marina)\n+*\n+*/\n+\n+body {\n+\tbackground: #AED9DA; /* Chill */\n+}\n+\n+::-webkit-scrollbar {\n+    width: 10px;\n+}\n+\n+::-webkit-scrollbar-track {\n+    background: #AED9DA; /* Chill */\n+    background-clip: content-box;\n+}\n+\n+::-webkit-scrollbar-thumb {\n+    background: #135589; /* Marina */\n+    border-radius: 2px;\n+}\n+\n+ng-datatable thead {\n+    width: calc(100% - 10px) !important;\n+}\n+\n+.appbar, .drawer {\n+\tcolor: #EDFAFD; /* Glass */\n+\tbackground: #135589; /* Marina */","path":"src/css/themes/2018_hydrodynamics.css","position":35,"original_position":35,"commit_id":"d614de0222daa67f79f75fe1aded05e354bcf2b9","original_commit_id":"d614de0222daa67f79f75fe1aded05e354bcf2b9","user":{"login":"idanstark42","id":19326938,"avatar_url":"https://avatars0.githubusercontent.com/u/19326938?v=4","gravatar_id":"","url":"https://api.github.com/users/idanstark42","html_url":"https://github.com/idanstark42","followers_url":"https://api.github.com/users/idanstark42/followers","following_url":"https://api.github.com/users/idanstark42/following{/other_user}","gists_url":"https://api.github.com/users/idanstark42/gists{/gist_id}","starred_url":"https://api.github.com/users/idanstark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanstark42/subscriptions","organizations_url":"https://api.github.com/users/idanstark42/orgs","repos_url":"https://api.github.com/users/idanstark42/repos","events_url":"https://api.github.com/users/idanstark42/events{/privacy}","received_events_url":"https://api.github.com/users/idanstark42/received_events","type":"User","site_admin":false},"body":"Will fix that","created_at":"2017-12-09T16:14:43Z","updated_at":"2017-12-09T16:14:43Z","html_url":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128#discussion_r155926142","pull_request_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/comments/155926142"},"html":{"href":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128#discussion_r155926142"},"pull_request":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128"}},"in_reply_to_id":155918626},"pull_request":{"url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128","id":157228977,"html_url":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128","diff_url":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128.diff","patch_url":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128.patch","issue_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/128","number":128,"state":"open","locked":false,"title":"Ux","user":{"login":"idanstark42","id":19326938,"avatar_url":"https://avatars0.githubusercontent.com/u/19326938?v=4","gravatar_id":"","url":"https://api.github.com/users/idanstark42","html_url":"https://github.com/idanstark42","followers_url":"https://api.github.com/users/idanstark42/followers","following_url":"https://api.github.com/users/idanstark42/following{/other_user}","gists_url":"https://api.github.com/users/idanstark42/gists{/gist_id}","starred_url":"https://api.github.com/users/idanstark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanstark42/subscriptions","organizations_url":"https://api.github.com/users/idanstark42/orgs","repos_url":"https://api.github.com/users/idanstark42/repos","events_url":"https://api.github.com/users/idanstark42/events{/privacy}","received_events_url":"https://api.github.com/users/idanstark42/received_events","type":"User","site_admin":false},"body":"So... what did I do here?\r\n1. Restructured the HTML pages, and added adequate, responsive CSS instead of the old UI. Now there are 4 pages: \r\n - Scoresheet\r\n - Scores - which includes the rankings as well\r\n - Tournament - which includes all tournament settings\r\n - Settings, which include more advanced options\r\nRemoved all confusion options, and split the scoresheet into 4 steps:\r\n - intro - only once, setting the ref and table, \r\n - team selection\r\n - missions form\r\n - checkout\r\nAfter the checkout the user is referenced back to teams selection. The \"edit\" button in the scores page references the user to the \"missions form\" step here.\r\n2. Created and used across the system the `ng-datatable` directive, which displays data in an easy to review, sortable, searchable way, with infinite scrolling for heavier data.\r\n3. Split the CSS into generic CSS, used in every season, and CSS per challenge, giving it a theme.\r\n4. Added the \"stay on the same page\" functionality: When you enter a page, it's saved in the `path` part of the URL, so that if you refresh it will go to the same page.\r\n5. Performance improvments: removed various instances of `$watch`, changed `ng-show` to `ng-if` everywhere that it should be (pages for instance), Added the `dialogs` service, which makes the usage of handshakes redundent.\r\n\r\nThat's it all in all, I hope you like it. There's a lot left to improve here.","created_at":"2017-12-08T12:10:31Z","updated_at":"2017-12-09T16:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5b5339c006b4252f4cf803022ed89b196b27541","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128/commits","review_comments_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128/comments","review_comment_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/128/comments","statuses_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/statuses/d614de0222daa67f79f75fe1aded05e354bcf2b9","head":{"label":"idanstark42:ux","ref":"ux","sha":"d614de0222daa67f79f75fe1aded05e354bcf2b9","user":{"login":"idanstark42","id":19326938,"avatar_url":"https://avatars0.githubusercontent.com/u/19326938?v=4","gravatar_id":"","url":"https://api.github.com/users/idanstark42","html_url":"https://github.com/idanstark42","followers_url":"https://api.github.com/users/idanstark42/followers","following_url":"https://api.github.com/users/idanstark42/following{/other_user}","gists_url":"https://api.github.com/users/idanstark42/gists{/gist_id}","starred_url":"https://api.github.com/users/idanstark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanstark42/subscriptions","organizations_url":"https://api.github.com/users/idanstark42/orgs","repos_url":"https://api.github.com/users/idanstark42/repos","events_url":"https://api.github.com/users/idanstark42/events{/privacy}","received_events_url":"https://api.github.com/users/idanstark42/received_events","type":"User","site_admin":false},"repo":{"id":94251197,"name":"fllscoring","full_name":"idanstark42/fllscoring","owner":{"login":"idanstark42","id":19326938,"avatar_url":"https://avatars0.githubusercontent.com/u/19326938?v=4","gravatar_id":"","url":"https://api.github.com/users/idanstark42","html_url":"https://github.com/idanstark42","followers_url":"https://api.github.com/users/idanstark42/followers","following_url":"https://api.github.com/users/idanstark42/following{/other_user}","gists_url":"https://api.github.com/users/idanstark42/gists{/gist_id}","starred_url":"https://api.github.com/users/idanstark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanstark42/subscriptions","organizations_url":"https://api.github.com/users/idanstark42/orgs","repos_url":"https://api.github.com/users/idanstark42/repos","events_url":"https://api.github.com/users/idanstark42/events{/privacy}","received_events_url":"https://api.github.com/users/idanstark42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/idanstark42/fllscoring","description":"FLL Scoring app. See Demo:","fork":true,"url":"https://api.github.com/repos/idanstark42/fllscoring","forks_url":"https://api.github.com/repos/idanstark42/fllscoring/forks","keys_url":"https://api.github.com/repos/idanstark42/fllscoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idanstark42/fllscoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idanstark42/fllscoring/teams","hooks_url":"https://api.github.com/repos/idanstark42/fllscoring/hooks","issue_events_url":"https://api.github.com/repos/idanstark42/fllscoring/issues/events{/number}","events_url":"https://api.github.com/repos/idanstark42/fllscoring/events","assignees_url":"https://api.github.com/repos/idanstark42/fllscoring/assignees{/user}","branches_url":"https://api.github.com/repos/idanstark42/fllscoring/branches{/branch}","tags_url":"https://api.github.com/repos/idanstark42/fllscoring/tags","blobs_url":"https://api.github.com/repos/idanstark42/fllscoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idanstark42/fllscoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idanstark42/fllscoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/idanstark42/fllscoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idanstark42/fllscoring/statuses/{sha}","languages_url":"https://api.github.com/repos/idanstark42/fllscoring/languages","stargazers_url":"https://api.github.com/repos/idanstark42/fllscoring/stargazers","contributors_url":"https://api.github.com/repos/idanstark42/fllscoring/contributors","subscribers_url":"https://api.github.com/repos/idanstark42/fllscoring/subscribers","subscription_url":"https://api.github.com/repos/idanstark42/fllscoring/subscription","commits_url":"https://api.github.com/repos/idanstark42/fllscoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/idanstark42/fllscoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/idanstark42/fllscoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/idanstark42/fllscoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/idanstark42/fllscoring/contents/{+path}","compare_url":"https://api.github.com/repos/idanstark42/fllscoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idanstark42/fllscoring/merges","archive_url":"https://api.github.com/repos/idanstark42/fllscoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idanstark42/fllscoring/downloads","issues_url":"https://api.github.com/repos/idanstark42/fllscoring/issues{/number}","pulls_url":"https://api.github.com/repos/idanstark42/fllscoring/pulls{/number}","milestones_url":"https://api.github.com/repos/idanstark42/fllscoring/milestones{/number}","notifications_url":"https://api.github.com/repos/idanstark42/fllscoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idanstark42/fllscoring/labels{/name}","releases_url":"https://api.github.com/repos/idanstark42/fllscoring/releases{/id}","deployments_url":"https://api.github.com/repos/idanstark42/fllscoring/deployments","created_at":"2017-06-13T19:45:53Z","updated_at":"2017-06-13T19:45:55Z","pushed_at":"2017-12-08T12:16:51Z","git_url":"git://github.com/idanstark42/fllscoring.git","ssh_url":"git@github.com:idanstark42/fllscoring.git","clone_url":"https://github.com/idanstark42/fllscoring.git","svn_url":"https://github.com/idanstark42/fllscoring","homepage":"http://firstlegoleague.github.io/fllscoring/","size":39515,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FirstLegoLeagueIL:master","ref":"master","sha":"fd2ac2da34a9b38717474196b1551cade91d677a","user":{"login":"FirstLegoLeagueIL","id":31323804,"avatar_url":"https://avatars1.githubusercontent.com/u/31323804?v=4","gravatar_id":"","url":"https://api.github.com/users/FirstLegoLeagueIL","html_url":"https://github.com/FirstLegoLeagueIL","followers_url":"https://api.github.com/users/FirstLegoLeagueIL/followers","following_url":"https://api.github.com/users/FirstLegoLeagueIL/following{/other_user}","gists_url":"https://api.github.com/users/FirstLegoLeagueIL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirstLegoLeagueIL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirstLegoLeagueIL/subscriptions","organizations_url":"https://api.github.com/users/FirstLegoLeagueIL/orgs","repos_url":"https://api.github.com/users/FirstLegoLeagueIL/repos","events_url":"https://api.github.com/users/FirstLegoLeagueIL/events{/privacy}","received_events_url":"https://api.github.com/users/FirstLegoLeagueIL/received_events","type":"Organization","site_admin":false},"repo":{"id":101333084,"name":"fllscoring","full_name":"FirstLegoLeagueIL/fllscoring","owner":{"login":"FirstLegoLeagueIL","id":31323804,"avatar_url":"https://avatars1.githubusercontent.com/u/31323804?v=4","gravatar_id":"","url":"https://api.github.com/users/FirstLegoLeagueIL","html_url":"https://github.com/FirstLegoLeagueIL","followers_url":"https://api.github.com/users/FirstLegoLeagueIL/followers","following_url":"https://api.github.com/users/FirstLegoLeagueIL/following{/other_user}","gists_url":"https://api.github.com/users/FirstLegoLeagueIL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirstLegoLeagueIL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirstLegoLeagueIL/subscriptions","organizations_url":"https://api.github.com/users/FirstLegoLeagueIL/orgs","repos_url":"https://api.github.com/users/FirstLegoLeagueIL/repos","events_url":"https://api.github.com/users/FirstLegoLeagueIL/events{/privacy}","received_events_url":"https://api.github.com/users/FirstLegoLeagueIL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirstLegoLeagueIL/fllscoring","description":"FLL Scoring app. See Demo:","fork":true,"url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring","forks_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/forks","keys_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/teams","hooks_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/hooks","issue_events_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/events{/number}","events_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/events","assignees_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/assignees{/user}","branches_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/branches{/branch}","tags_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/tags","blobs_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/statuses/{sha}","languages_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/languages","stargazers_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/stargazers","contributors_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/contributors","subscribers_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/subscribers","subscription_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/subscription","commits_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/contents/{+path}","compare_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/merges","archive_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/downloads","issues_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues{/number}","pulls_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls{/number}","milestones_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/milestones{/number}","notifications_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/labels{/name}","releases_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/releases{/id}","deployments_url":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/deployments","created_at":"2017-08-24T20:00:26Z","updated_at":"2017-09-15T10:13:34Z","pushed_at":"2017-12-08T12:16:52Z","git_url":"git://github.com/FirstLegoLeagueIL/fllscoring.git","ssh_url":"git@github.com:FirstLegoLeagueIL/fllscoring.git","clone_url":"https://github.com/FirstLegoLeagueIL/fllscoring.git","svn_url":"https://github.com/FirstLegoLeagueIL/fllscoring","homepage":"http://firstlegoleague.github.io/fllscoring/","size":38527,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128"},"html":{"href":"https://github.com/FirstLegoLeagueIL/fllscoring/pull/128"},"issue":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/128"},"comments":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/FirstLegoLeagueIL/fllscoring/statuses/d614de0222daa67f79f75fe1aded05e354bcf2b9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"idanstark42"}}