{"action":"closed","number":1530,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1530","id":111882055,"html_url":"https://github.com/puppetlabs/facter/pull/1530","diff_url":"https://github.com/puppetlabs/facter/pull/1530.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1530.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1530","number":1530,"state":"closed","locked":false,"title":"Task/lts 1.7/fact 1587/update custom and external facts command line tests","user":{"login":"ericldelaney","id":25037515,"avatar_url":"https://avatars0.githubusercontent.com/u/25037515?v=3","gravatar_id":"","url":"https://api.github.com/users/ericldelaney","html_url":"https://github.com/ericldelaney","followers_url":"https://api.github.com/users/ericldelaney/followers","following_url":"https://api.github.com/users/ericldelaney/following{/other_user}","gists_url":"https://api.github.com/users/ericldelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/ericldelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericldelaney/subscriptions","organizations_url":"https://api.github.com/users/ericldelaney/orgs","repos_url":"https://api.github.com/users/ericldelaney/repos","events_url":"https://api.github.com/users/ericldelaney/events{/privacy}","received_events_url":"https://api.github.com/users/ericldelaney/received_events","type":"User","site_admin":false},"body":"Split the existing tests for testing --custom-dir --no-custom-facts --external-dir and --no-external-facts into multiple test files, and add missing tests on the --no-custom-facts cases and options conflict errors.\r\n\r\nI also added TestRail numbers to the test names and added risk level tags\r\n\r\nAll tests pass on VMpooler boxes, and I've only excluded the cisco_nexus on the 2 tests where it has to be excluded. So we have better coverage now that the tests are split into different files.","created_at":"2017-03-21T21:19:28Z","updated_at":"2017-03-22T21:55:32Z","closed_at":"2017-03-22T21:55:32Z","merged_at":null,"merge_commit_sha":"c270490818511f19198078e558350776f0b3641f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1530/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1530/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1530/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/2d7ef413d6932d55c4fec7de1c34e94ae6cbb3f2","head":{"label":"ericldelaney:task/LTS-1.7/FACT-1587/update_custom_and_external_facts_command_line_tests","ref":"task/LTS-1.7/FACT-1587/update_custom_and_external_facts_command_line_tests","sha":"2d7ef413d6932d55c4fec7de1c34e94ae6cbb3f2","user":{"login":"ericldelaney","id":25037515,"avatar_url":"https://avatars0.githubusercontent.com/u/25037515?v=3","gravatar_id":"","url":"https://api.github.com/users/ericldelaney","html_url":"https://github.com/ericldelaney","followers_url":"https://api.github.com/users/ericldelaney/followers","following_url":"https://api.github.com/users/ericldelaney/following{/other_user}","gists_url":"https://api.github.com/users/ericldelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/ericldelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericldelaney/subscriptions","organizations_url":"https://api.github.com/users/ericldelaney/orgs","repos_url":"https://api.github.com/users/ericldelaney/repos","events_url":"https://api.github.com/users/ericldelaney/events{/privacy}","received_events_url":"https://api.github.com/users/ericldelaney/received_events","type":"User","site_admin":false},"repo":{"id":80039419,"name":"facter","full_name":"ericldelaney/facter","owner":{"login":"ericldelaney","id":25037515,"avatar_url":"https://avatars0.githubusercontent.com/u/25037515?v=3","gravatar_id":"","url":"https://api.github.com/users/ericldelaney","html_url":"https://github.com/ericldelaney","followers_url":"https://api.github.com/users/ericldelaney/followers","following_url":"https://api.github.com/users/ericldelaney/following{/other_user}","gists_url":"https://api.github.com/users/ericldelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/ericldelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericldelaney/subscriptions","organizations_url":"https://api.github.com/users/ericldelaney/orgs","repos_url":"https://api.github.com/users/ericldelaney/repos","events_url":"https://api.github.com/users/ericldelaney/events{/privacy}","received_events_url":"https://api.github.com/users/ericldelaney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericldelaney/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/ericldelaney/facter","forks_url":"https://api.github.com/repos/ericldelaney/facter/forks","keys_url":"https://api.github.com/repos/ericldelaney/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericldelaney/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericldelaney/facter/teams","hooks_url":"https://api.github.com/repos/ericldelaney/facter/hooks","issue_events_url":"https://api.github.com/repos/ericldelaney/facter/issues/events{/number}","events_url":"https://api.github.com/repos/ericldelaney/facter/events","assignees_url":"https://api.github.com/repos/ericldelaney/facter/assignees{/user}","branches_url":"https://api.github.com/repos/ericldelaney/facter/branches{/branch}","tags_url":"https://api.github.com/repos/ericldelaney/facter/tags","blobs_url":"https://api.github.com/repos/ericldelaney/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericldelaney/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericldelaney/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericldelaney/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericldelaney/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/ericldelaney/facter/languages","stargazers_url":"https://api.github.com/repos/ericldelaney/facter/stargazers","contributors_url":"https://api.github.com/repos/ericldelaney/facter/contributors","subscribers_url":"https://api.github.com/repos/ericldelaney/facter/subscribers","subscription_url":"https://api.github.com/repos/ericldelaney/facter/subscription","commits_url":"https://api.github.com/repos/ericldelaney/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericldelaney/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericldelaney/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericldelaney/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericldelaney/facter/contents/{+path}","compare_url":"https://api.github.com/repos/ericldelaney/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericldelaney/facter/merges","archive_url":"https://api.github.com/repos/ericldelaney/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericldelaney/facter/downloads","issues_url":"https://api.github.com/repos/ericldelaney/facter/issues{/number}","pulls_url":"https://api.github.com/repos/ericldelaney/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/ericldelaney/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/ericldelaney/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericldelaney/facter/labels{/name}","releases_url":"https://api.github.com/repos/ericldelaney/facter/releases{/id}","deployments_url":"https://api.github.com/repos/ericldelaney/facter/deployments","created_at":"2017-01-25T17:41:04Z","updated_at":"2017-01-25T17:41:08Z","pushed_at":"2017-03-22T21:51:46Z","git_url":"git://github.com/ericldelaney/facter.git","ssh_url":"git@github.com:ericldelaney/facter.git","clone_url":"https://github.com/ericldelaney/facter.git","svn_url":"https://github.com/ericldelaney/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13452,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:LTS-1.7","ref":"LTS-1.7","sha":"eff843e37d37457e3453df92c6feedc1a26d2ac4","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2017-03-17T14:17:36Z","pushed_at":"2017-03-22T21:54:13Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13476,"stargazers_count":471,"watchers_count":471,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":407,"mirror_url":null,"open_issues_count":4,"forks":407,"open_issues":4,"watchers":471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1530"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1530"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1530"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1530/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1530/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1530/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/2d7ef413d6932d55c4fec7de1c34e94ae6cbb3f2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":12,"maintainer_can_modify":false,"commits":3,"additions":386,"deletions":108,"changed_files":13}}
{"actor":{"display_login":"ericldelaney"}}