{"action":"created","issue":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/959","repository_url":"https://api.github.com/repos/StoDevX/AAO-React-Native","labels_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/959/labels{/name}","comments_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/959/comments","events_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/959/events","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/959","id":222033373,"number":959,"title":"Searchable dictionary and orgs","user":{"login":"drewvolz","id":5240843,"avatar_url":"https://avatars2.githubusercontent.com/u/5240843?v=3","gravatar_id":"","url":"https://api.github.com/users/drewvolz","html_url":"https://github.com/drewvolz","followers_url":"https://api.github.com/users/drewvolz/followers","following_url":"https://api.github.com/users/drewvolz/following{/other_user}","gists_url":"https://api.github.com/users/drewvolz/gists{/gist_id}","starred_url":"https://api.github.com/users/drewvolz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewvolz/subscriptions","organizations_url":"https://api.github.com/users/drewvolz/orgs","repos_url":"https://api.github.com/users/drewvolz/repos","events_url":"https://api.github.com/users/drewvolz/events{/privacy}","received_events_url":"https://api.github.com/users/drewvolz/received_events","type":"User","site_admin":false},"labels":[{"id":302558847,"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/labels/enhancement","name":"enhancement","color":"c5def5","default":true},{"id":426748172,"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/labels/pr/don't%20merge","name":"pr/don't merge","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-16T21:08:12Z","updated_at":"2017-04-20T01:50:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/pulls/959","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/959","diff_url":"https://github.com/StoDevX/AAO-React-Native/pull/959.diff","patch_url":"https://github.com/StoDevX/AAO-React-Native/pull/959.patch"},"body":"This introduces a searchbar for iOS and Android in the AlphabetListViews for Student Orgs and the Dictionary.\r\n\r\n**Todo**\r\n- [x] I would like feedback on my flow types... I know they're not all correct\r\n- [ ] Search will not filter by word at the moment. Finds any substring.\r\n- [ ] Android alphabet list slider extends underneath the searchbar? This was correct before and I broke it here. [see screenshot]\r\n- [ ] `findNodeHandle` error when searching/deleting quickly [see screenshot]. We might be able to solve this by buffering the search by adding a delay. Instant search might be the cause.\r\n- [ ] Searching for `pda` in the dictionary on iOS reveals a strange layout bug  [see screenshot]\r\n- [ ] Grouping issues:\r\n  - [ ] Need to find a way to re-highlight the *new* orgs in student orgs. This was correct before and I broke it here.\r\n  - [ ] Need to reduce duplicates by going back to the way we took the first capitalized letter of all the words... currently have \"B and b\" because of \"bloom\". This was correct before and I broke it here.\r\n\r\n**Student Orgs Screenshots**\r\n\r\nx | iOS | Android\r\n---|---|---\r\nmain | <img width=\"487\" alt=\"screen shot 2017-04-16 at 4 35 14 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074251/e9cda46a-22c4-11e7-9c1e-843cfbc04e27.png\"> | <img width=\"502\" alt=\"screen shot 2017-04-16 at 4 35 10 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074250/e9c0e892-22c4-11e7-868a-5013c9ebdc7c.png\">\r\nsearch | <img width=\"487\" alt=\"screen shot 2017-04-16 at 4 35 43 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074267/4c09b77c-22c5-11e7-880c-6bcdb4e88fc9.png\"> | <img width=\"502\" alt=\"screen shot 2017-04-16 at 4 33 30 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074287/afcdb196-22c5-11e7-83aa-6e997a60ffa0.png\">\r\nsingle | <img width=\"487\" alt=\"screen shot 2017-04-16 at 4 35 28 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074274/7697086e-22c5-11e7-947d-2186ce2c9127.png\"> | <img width=\"502\" alt=\"screen shot 2017-04-16 at 4 34 10 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074318/1cd61d8c-22c6-11e7-8f47-efc1cead728e.png\">\r\n\r\n**Dictionary Screenshots**\r\n\r\nx | iOS | Android\r\n---|---|---\r\nmain | <img width=\"487\" alt=\"screen shot 2017-04-16 at 5 10 48 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074411/12330884-22c8-11e7-980b-4f33d2a591a0.png\"> | <img width=\"502\" alt=\"screen shot 2017-04-16 at 5 12 21 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074410/12320344-22c8-11e7-88ae-b6c594f32985.png\">\r\nsearch | <img width=\"487\" alt=\"screen shot 2017-04-16 at 5 11 00 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074412/123424c6-22c8-11e7-91db-e56c47483927.png\"> | <img width=\"502\" alt=\"screen shot 2017-04-16 at 5 12 32 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074409/11ef81ea-22c8-11e7-9013-bfa525801c27.png\">\r\n\r\n\r\n**Issues**\r\n\r\niOS visual issue | X-platform state issue\r\n---|---\r\n<img width=\"487\" alt=\"screen shot 2017-04-16 at 4 44 55 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074335/741da3bc-22c6-11e7-8161-7201babb7167.png\"> | <img width=\"487\" alt=\"screen shot 2017-04-16 at 4 30 01 pm\" src=\"https://cloud.githubusercontent.com/assets/5240843/25074336/7f4aac26-22c6-11e7-9ee7-1c965debb4c8.png\">"},"comment":{"url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/comments/295539034","html_url":"https://github.com/StoDevX/AAO-React-Native/pull/959#issuecomment-295539034","issue_url":"https://api.github.com/repos/StoDevX/AAO-React-Native/issues/959","id":295539034,"user":{"login":"stodevx-bot","id":23485544,"avatar_url":"https://avatars2.githubusercontent.com/u/23485544?v=3","gravatar_id":"","url":"https://api.github.com/users/stodevx-bot","html_url":"https://github.com/stodevx-bot","followers_url":"https://api.github.com/users/stodevx-bot/followers","following_url":"https://api.github.com/users/stodevx-bot/following{/other_user}","gists_url":"https://api.github.com/users/stodevx-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/stodevx-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stodevx-bot/subscriptions","organizations_url":"https://api.github.com/users/stodevx-bot/orgs","repos_url":"https://api.github.com/users/stodevx-bot/repos","events_url":"https://api.github.com/users/stodevx-bot/events{/privacy}","received_events_url":"https://api.github.com/users/stodevx-bot/received_events","type":"User","site_admin":false},"created_at":"2017-04-20T01:50:58Z","updated_at":"2017-04-20T01:50:58Z","body":"\n<!--\n  0 failure: \n  0 warning: \n  1 messages\n  \n-->\n\n\n\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\">Messages</th>\n    </tr>\n  </thead>\n  <tbody><tr>\n      <td>:book:</td>\n      <td><details>\n  <summary>Flow would like to interject about types…</summary>\n\n```\nnode_modules/react-native-vector-icons/lib/generate-icon-set-from-css.js:0\ngenerateIconSetFromCss. Duplicate module provider\ncurrent provider. See: node_modules/react-native-searchbar/node_modules/react-native-vector-icons/lib/generate-icon-set-from-css.js:0\n\n\nFound 1 error\n```\n\n</details></td>\n    </tr>\n  </tbody>\n</table>\n\n\n<p align=\"right\">\n  Generated by :no_entry_sign: <a href=\"http://github.com/danger/danger-js/\">dangerJS</a>\n</p>\n"}}
{"actor":{"display_login":"stodevx-bot"}}