{"action":"closed","number":14845,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14845","id":135903642,"html_url":"https://github.com/nodejs/node/pull/14845","diff_url":"https://github.com/nodejs/node/pull/14845.diff","patch_url":"https://github.com/nodejs/node/pull/14845.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14845","number":14845,"state":"closed","locked":false,"title":"test: pass env through to child processes","user":{"login":"gibfahn","id":15943089,"avatar_url":"https://avatars0.githubusercontent.com/u/15943089?v=4","gravatar_id":"","url":"https://api.github.com/users/gibfahn","html_url":"https://github.com/gibfahn","followers_url":"https://api.github.com/users/gibfahn/followers","following_url":"https://api.github.com/users/gibfahn/following{/other_user}","gists_url":"https://api.github.com/users/gibfahn/gists{/gist_id}","starred_url":"https://api.github.com/users/gibfahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibfahn/subscriptions","organizations_url":"https://api.github.com/users/gibfahn/orgs","repos_url":"https://api.github.com/users/gibfahn/repos","events_url":"https://api.github.com/users/gibfahn/events{/privacy}","received_events_url":"https://api.github.com/users/gibfahn/received_events","type":"User","site_admin":false},"body":"Add a helper function to provide an easy way to modify the\r\nenvironment passed to child processes.\r\n\r\nFixes: #14823\r\nRefs: https://github.com/nodejs/node/pull/14822\r\n\r\nThe function itself is trivial, the main benefit to having it is that it gives an easy way to pass modified environments to child processes. There are a bunch of tests that don't pass the environment through to child processes, and the tests that do use a variety of methods. So ideally by having a `common` function we can standardise on this way of doing things.\r\n\r\nAn alternative would be to just replace all of these with `Object.assign({}, process.env, additionalEnv)`.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest","created_at":"2017-08-15T22:13:34Z","updated_at":"2017-09-03T20:29:26Z","closed_at":"2017-09-03T20:29:25Z","merged_at":null,"merge_commit_sha":"5eb956f4032bcd560118c1b35ca7628b6b8cfad3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14845/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14845/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14845/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/a7469da4e780869fb8d76b8af15deff174a4c5a0","head":{"label":"gibfahn:envPlus","ref":"envPlus","sha":"a7469da4e780869fb8d76b8af15deff174a4c5a0","user":{"login":"gibfahn","id":15943089,"avatar_url":"https://avatars0.githubusercontent.com/u/15943089?v=4","gravatar_id":"","url":"https://api.github.com/users/gibfahn","html_url":"https://github.com/gibfahn","followers_url":"https://api.github.com/users/gibfahn/followers","following_url":"https://api.github.com/users/gibfahn/following{/other_user}","gists_url":"https://api.github.com/users/gibfahn/gists{/gist_id}","starred_url":"https://api.github.com/users/gibfahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibfahn/subscriptions","organizations_url":"https://api.github.com/users/gibfahn/orgs","repos_url":"https://api.github.com/users/gibfahn/repos","events_url":"https://api.github.com/users/gibfahn/events{/privacy}","received_events_url":"https://api.github.com/users/gibfahn/received_events","type":"User","site_admin":false},"repo":{"id":46805827,"name":"node","full_name":"gibfahn/node","owner":{"login":"gibfahn","id":15943089,"avatar_url":"https://avatars0.githubusercontent.com/u/15943089?v=4","gravatar_id":"","url":"https://api.github.com/users/gibfahn","html_url":"https://github.com/gibfahn","followers_url":"https://api.github.com/users/gibfahn/followers","following_url":"https://api.github.com/users/gibfahn/following{/other_user}","gists_url":"https://api.github.com/users/gibfahn/gists{/gist_id}","starred_url":"https://api.github.com/users/gibfahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibfahn/subscriptions","organizations_url":"https://api.github.com/users/gibfahn/orgs","repos_url":"https://api.github.com/users/gibfahn/repos","events_url":"https://api.github.com/users/gibfahn/events{/privacy}","received_events_url":"https://api.github.com/users/gibfahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gibfahn/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/gibfahn/node","forks_url":"https://api.github.com/repos/gibfahn/node/forks","keys_url":"https://api.github.com/repos/gibfahn/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibfahn/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibfahn/node/teams","hooks_url":"https://api.github.com/repos/gibfahn/node/hooks","issue_events_url":"https://api.github.com/repos/gibfahn/node/issues/events{/number}","events_url":"https://api.github.com/repos/gibfahn/node/events","assignees_url":"https://api.github.com/repos/gibfahn/node/assignees{/user}","branches_url":"https://api.github.com/repos/gibfahn/node/branches{/branch}","tags_url":"https://api.github.com/repos/gibfahn/node/tags","blobs_url":"https://api.github.com/repos/gibfahn/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibfahn/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibfahn/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibfahn/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibfahn/node/statuses/{sha}","languages_url":"https://api.github.com/repos/gibfahn/node/languages","stargazers_url":"https://api.github.com/repos/gibfahn/node/stargazers","contributors_url":"https://api.github.com/repos/gibfahn/node/contributors","subscribers_url":"https://api.github.com/repos/gibfahn/node/subscribers","subscription_url":"https://api.github.com/repos/gibfahn/node/subscription","commits_url":"https://api.github.com/repos/gibfahn/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibfahn/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibfahn/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibfahn/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibfahn/node/contents/{+path}","compare_url":"https://api.github.com/repos/gibfahn/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibfahn/node/merges","archive_url":"https://api.github.com/repos/gibfahn/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibfahn/node/downloads","issues_url":"https://api.github.com/repos/gibfahn/node/issues{/number}","pulls_url":"https://api.github.com/repos/gibfahn/node/pulls{/number}","milestones_url":"https://api.github.com/repos/gibfahn/node/milestones{/number}","notifications_url":"https://api.github.com/repos/gibfahn/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibfahn/node/labels{/name}","releases_url":"https://api.github.com/repos/gibfahn/node/releases{/id}","deployments_url":"https://api.github.com/repos/gibfahn/node/deployments","created_at":"2015-11-24T16:59:18Z","updated_at":"2017-06-15T12:23:23Z","pushed_at":"2017-08-28T08:32:14Z","git_url":"git://github.com/gibfahn/node.git","ssh_url":"git@github.com:gibfahn/node.git","clone_url":"https://github.com/gibfahn/node.git","svn_url":"https://github.com/gibfahn/node","homepage":"https://nodejs.org","size":279412,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"oldmaster"}},"base":{"label":"nodejs:master","ref":"master","sha":"219932a9f77f8a013d50067e931e6c877f9024d3","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-09-03T20:09:51Z","pushed_at":"2017-09-03T20:29:23Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":309660,"stargazers_count":38843,"watchers_count":38843,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7768,"mirror_url":null,"open_issues_count":802,"forks":7768,"open_issues":802,"watchers":38843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14845"},"html":{"href":"https://github.com/nodejs/node/pull/14845"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14845"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14845/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14845/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14845/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/a7469da4e780869fb8d76b8af15deff174a4c5a0"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":23,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":37,"deletions":39,"changed_files":15}}
{"actor":{"display_login":"BridgeAR"}}