{"action":"created","issue":{"url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/1","repository_url":"https://api.github.com/repos/tatut/clj-chrome-devtools","labels_url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/1/comments","events_url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/1/events","html_url":"https://github.com/tatut/clj-chrome-devtools/issues/1","id":252588143,"number":1,"title":"Throw Exception instead of asserting if connection was successful","user":{"login":"the-kenny","id":31167,"avatar_url":"https://avatars0.githubusercontent.com/u/31167?v=4","gravatar_id":"","url":"https://api.github.com/users/the-kenny","html_url":"https://github.com/the-kenny","followers_url":"https://api.github.com/users/the-kenny/followers","following_url":"https://api.github.com/users/the-kenny/following{/other_user}","gists_url":"https://api.github.com/users/the-kenny/gists{/gist_id}","starred_url":"https://api.github.com/users/the-kenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-kenny/subscriptions","organizations_url":"https://api.github.com/users/the-kenny/orgs","repos_url":"https://api.github.com/users/the-kenny/repos","events_url":"https://api.github.com/users/the-kenny/events{/privacy}","received_events_url":"https://api.github.com/users/the-kenny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-24T12:39:21Z","updated_at":"2017-08-24T13:21:18Z","closed_at":null,"body":"https://github.com/tatut/clj-chrome-devtools/blob/704e1e611fa524e2692cc0e857109514fa3a19dc/src/clj_chrome_devtools/impl/connection.clj#L57-L58\r\n\r\nIf you spawn a headless chrome and connect right away it isn't ready and the quoted code above will run. This will throw an `AssertionError` where a normal `RuntimeException` or some subclass would be much more appropriate. "},"comment":{"url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/comments/324632895","html_url":"https://github.com/tatut/clj-chrome-devtools/issues/1#issuecomment-324632895","issue_url":"https://api.github.com/repos/tatut/clj-chrome-devtools/issues/1","id":324632895,"user":{"login":"the-kenny","id":31167,"avatar_url":"https://avatars0.githubusercontent.com/u/31167?v=4","gravatar_id":"","url":"https://api.github.com/users/the-kenny","html_url":"https://github.com/the-kenny","followers_url":"https://api.github.com/users/the-kenny/followers","following_url":"https://api.github.com/users/the-kenny/following{/other_user}","gists_url":"https://api.github.com/users/the-kenny/gists{/gist_id}","starred_url":"https://api.github.com/users/the-kenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-kenny/subscriptions","organizations_url":"https://api.github.com/users/the-kenny/orgs","repos_url":"https://api.github.com/users/the-kenny/repos","events_url":"https://api.github.com/users/the-kenny/events{/privacy}","received_events_url":"https://api.github.com/users/the-kenny/received_events","type":"User","site_admin":false},"created_at":"2017-08-24T13:21:17Z","updated_at":"2017-08-24T13:21:17Z","body":"Sounds reasonable, but I think it's best to make this automatic retry\nbehavior optional.\n\nAm 24.08.2017 14:58 schrieb \"Tatu Tarvainen\" <notifications@github.com>:\n\n> That's a good point. I actually have code to wait for the spawned Chrome\n> to be ready in the clojure.test fixture.\n>\n> Perhaps that functionality should be in connect itself.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tatut/clj-chrome-devtools/issues/1#issuecomment-324627175>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAB5v-tBTwbvsDdgUmjwI7f6L7ciQH6nks5sbXNZgaJpZM4PBUi2>\n> .\n>\n"}}
{"actor":{"display_login":"the-kenny"}}