{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/117678227","pull_request_review_id":39402210,"id":117678227,"diff_hunk":"@@ -92,7 +92,7 @@ const frameReducer = (state, action, immutableAction) => {\n         }\n       }\n \n-      const title = immutableAction.getIn(['changeInfo', 'title'])\n+      const title = immutableAction.getIn(['tabValue', 'title'])","path":"app/renderer/reducers/frameReducer.js","position":5,"original_position":5,"commit_id":"7f2f9fb073bbd1b604b808478cdc3f85ad8c6a29","original_commit_id":"7f2f9fb073bbd1b604b808478cdc3f85ad8c6a29","user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"body":"Currently the only problem with the title not updating is when you use navigation buttons, so when tab state changes. What should I wrote in todo? `TODO fix race condition with appState`","created_at":"2017-05-22T07:26:20Z","updated_at":"2017-05-22T07:26:20Z","html_url":"https://github.com/brave/browser-laptop/pull/8992#discussion_r117678227","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/8992","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/117678227"},"html":{"href":"https://github.com/brave/browser-laptop/pull/8992#discussion_r117678227"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/8992"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/8992","id":121674630,"html_url":"https://github.com/brave/browser-laptop/pull/8992","diff_url":"https://github.com/brave/browser-laptop/pull/8992.diff","patch_url":"https://github.com/brave/browser-laptop/pull/8992.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/8992","number":8992,"state":"open","locked":false,"title":"Fixes tab title on tab update","user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"body":"Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nResolves #8908\r\n\r\nAuditors: @bsclifton @bridiver\r\n\r\nTest Plan:\r\n- go to site clifton.io\r\n- create a history\r\n- click on back/forward buttons\r\n- check that title is always correct\r\n\r\n\r\nReviewer Checklist:\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2017-05-21T20:25:31Z","updated_at":"2017-05-22T07:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9409a257c74fea63800b549e02e7e03db707ede8","assignee":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"assignees":[{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars0.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/64","html_url":"https://github.com/brave/browser-laptop/milestone/64","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/64/labels","id":2385508,"number":64,"title":"0.15.300","description":"Was 0.15.1 and then 0.15.2, but bumped up since 0.15.1 and 0.15.2 are hotfix releases","creator":{"login":"alexwykoff","id":1434040,"avatar_url":"https://avatars3.githubusercontent.com/u/1434040?v=3","gravatar_id":"","url":"https://api.github.com/users/alexwykoff","html_url":"https://github.com/alexwykoff","followers_url":"https://api.github.com/users/alexwykoff/followers","following_url":"https://api.github.com/users/alexwykoff/following{/other_user}","gists_url":"https://api.github.com/users/alexwykoff/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwykoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwykoff/subscriptions","organizations_url":"https://api.github.com/users/alexwykoff/orgs","repos_url":"https://api.github.com/users/alexwykoff/repos","events_url":"https://api.github.com/users/alexwykoff/events{/privacy}","received_events_url":"https://api.github.com/users/alexwykoff/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":306,"state":"open","created_at":"2017-03-14T16:22:52Z","updated_at":"2017-05-22T02:01:39Z","due_on":"2017-05-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/8992/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/8992/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/8992/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/7f2f9fb073bbd1b604b808478cdc3f85ad8c6a29","head":{"label":"NejcZdovc:hotfix/#8908-title","ref":"hotfix/#8908-title","sha":"7f2f9fb073bbd1b604b808478cdc3f85ad8c6a29","user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"repo":{"id":75922517,"name":"browser-laptop","full_name":"NejcZdovc/browser-laptop","owner":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars2.githubusercontent.com/u/9574457?v=3","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NejcZdovc/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/NejcZdovc/browser-laptop","forks_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/forks","keys_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/teams","hooks_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/events","assignees_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/tags","blobs_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/subscription","commits_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/merges","archive_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/downloads","issues_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/NejcZdovc/browser-laptop/deployments","created_at":"2016-12-08T09:19:56Z","updated_at":"2016-12-08T09:19:59Z","pushed_at":"2017-05-21T20:22:29Z","git_url":"git://github.com/NejcZdovc/browser-laptop.git","ssh_url":"git@github.com:NejcZdovc/browser-laptop.git","clone_url":"https://github.com/NejcZdovc/browser-laptop.git","svn_url":"https://github.com/NejcZdovc/browser-laptop","homepage":"https://www.brave.com","size":49809,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"31a6714c8a587d82414f63b501fe5c4b9de3b0a4","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars2.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars2.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2017-05-22T06:59:20Z","pushed_at":"2017-05-22T01:57:49Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":48310,"stargazers_count":4871,"watchers_count":4871,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":583,"mirror_url":null,"open_issues_count":2150,"forks":583,"open_issues":2150,"watchers":4871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/8992"},"html":{"href":"https://github.com/brave/browser-laptop/pull/8992"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/8992"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/8992/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/8992/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/8992/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/7f2f9fb073bbd1b604b808478cdc3f85ad8c6a29"}}}}
{"actor":{"display_login":"NejcZdovc"}}