{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/18976","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18976/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18976/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18976/events","html_url":"https://github.com/joomla/joomla-cms/pull/18976","id":279033054,"number":18976,"title":"Reinstate electric calendar functionality in date picker (fixes BC break)","user":{"login":"GeraintEdwards","id":839810,"avatar_url":"https://avatars3.githubusercontent.com/u/839810?v=4","gravatar_id":"","url":"https://api.github.com/users/GeraintEdwards","html_url":"https://github.com/GeraintEdwards","followers_url":"https://api.github.com/users/GeraintEdwards/followers","following_url":"https://api.github.com/users/GeraintEdwards/following{/other_user}","gists_url":"https://api.github.com/users/GeraintEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/GeraintEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeraintEdwards/subscriptions","organizations_url":"https://api.github.com/users/GeraintEdwards/orgs","repos_url":"https://api.github.com/users/GeraintEdwards/repos","events_url":"https://api.github.com/users/GeraintEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/GeraintEdwards/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2017-12-04T15:20:22Z","updated_at":"2017-12-15T10:49:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/18976","html_url":"https://github.com/joomla/joomla-cms/pull/18976","diff_url":"https://github.com/joomla/joomla-cms/pull/18976.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/18976.patch"},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\n\r\nThe old Dynarch DHTML date picker had a setup option 'electric' which stopped the date input field from updating until a specific date was picked.  This was not implement in the new joomla.calendar.  This PR reinstates this functionality and adds support for it into JFormFieldCalendar\r\n\r\nThe reason its important is that calendar/event components will have javascript events triggered off changes in date fields - if these are changed spuriously as the date picker is navigated it can lead to unforseen/unplanned for outcomes such as date validation errors or incorrect data entry.\r\n\r\n### Testing Instructions\r\n\r\n1. Edit/create and article, go to the publishing tab and click the date picker button for the start date.  Navigate the months and years and notice that the date picker field changes value.  This is the 'electric; behaviour in action.\r\n\r\n2. Edit the file administrator/components/com_content/models/forms/article.xml and add \r\n\r\n`                        electric=\"false\"`\r\n\r\nto the publish_up field at line c. 166 and repeat step 1.\r\n\r\n3. Edit the file administrator/components/com_content/models/forms/article.xml and add \r\n\r\n`                        electric=\"true\"`\r\n\r\nto the publish_up field at line c. 166 and repeat step 1.\r\n\r\n### Expected result\r\n\r\n1. Date input field changes value as you navigate.\r\n\r\n2. Date input field does NOT change value as you navigate.\r\n\r\n3. Date input field changes value as you navigate.\r\n\r\n### Actual result\r\n\r\n1. Date input field changes value as you navigate.\r\n\r\n2. Date input field changes value as you navigate.\r\n\r\n3. Date input field changes value as you navigate.\r\n\r\nIn fact the joomla.calendar javascript has the 'electric' behaviour hard coded in.\r\n\r\n### Documentation Changes Required\r\n\r\nNot sure if 'electric' is the best parameter name/description - its just that is what the old calendar used.\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/351975328","html_url":"https://github.com/joomla/joomla-cms/pull/18976#issuecomment-351975328","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18976","id":351975328,"user":{"login":"GeraintEdwards","id":839810,"avatar_url":"https://avatars3.githubusercontent.com/u/839810?v=4","gravatar_id":"","url":"https://api.github.com/users/GeraintEdwards","html_url":"https://github.com/GeraintEdwards","followers_url":"https://api.github.com/users/GeraintEdwards/followers","following_url":"https://api.github.com/users/GeraintEdwards/following{/other_user}","gists_url":"https://api.github.com/users/GeraintEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/GeraintEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeraintEdwards/subscriptions","organizations_url":"https://api.github.com/users/GeraintEdwards/orgs","repos_url":"https://api.github.com/users/GeraintEdwards/repos","events_url":"https://api.github.com/users/GeraintEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/GeraintEdwards/received_events","type":"User","site_admin":false},"created_at":"2017-12-15T10:49:00Z","updated_at":"2017-12-15T10:49:00Z","author_association":"CONTRIBUTOR","body":"What about \"auto-update\" instead of electric?\r\n\r\nI agree wholeheartedly that \"electric\" is a rubbish descriptor and since it hasn't been used in the xml file before now its the right time to choose the better name."}}
{"actor":{"display_login":"GeraintEdwards"}}