{"action":"closed","number":1167,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1167","id":30870396,"html_url":"https://github.com/php/php-src/pull/1167","diff_url":"https://github.com/php/php-src/pull/1167.diff","patch_url":"https://github.com/php/php-src/pull/1167.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1167","number":1167,"state":"closed","locked":false,"title":"Bug #68669\tDateTime::createFromFormat() does not allow NULL $timezone","user":{"login":"Neeke","id":1913308,"avatar_url":"https://avatars.githubusercontent.com/u/1913308?v=3","gravatar_id":"","url":"https://api.github.com/users/Neeke","html_url":"https://github.com/Neeke","followers_url":"https://api.github.com/users/Neeke/followers","following_url":"https://api.github.com/users/Neeke/following{/other_user}","gists_url":"https://api.github.com/users/Neeke/gists{/gist_id}","starred_url":"https://api.github.com/users/Neeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neeke/subscriptions","organizations_url":"https://api.github.com/users/Neeke/orgs","repos_url":"https://api.github.com/users/Neeke/repos","events_url":"https://api.github.com/users/Neeke/events{/privacy}","received_events_url":"https://api.github.com/users/Neeke/received_events","type":"User","site_admin":false},"body":"`DateTime::createFromFormat($format, $time, DateTimeZone $timezone = null)` has a default value for its third parameter `$timezone`, but it doesn't accept `null` as a value.\n\nRunning the following script will raise a warning:\n\nDateTime::createFromFormat('Y/m/d', '2015/1/1', null);\n\n// Warning: DateTime::createFromFormat() expects parameter 3 to be DateTimeZone, null given\n\nWhile the documentation states that the default timezone is going to be used when no parameter is given, also the case where a `null` `$timezone` is given should be handled correctly.\n\nThis would align the API to the language semantics about default values.\n","created_at":"2015-03-10T16:59:59Z","updated_at":"2017-01-04T10:29:10Z","closed_at":"2017-01-04T10:29:10Z","merged_at":null,"merge_commit_sha":"4a1de31d283af46e9de1e96f740c4719d5949116","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1167/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1167/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1167/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/e884158c6e5b00c3cfa9ceef995863830761b02c","head":{"label":"Neeke:PHP-5.5","ref":"PHP-5.5","sha":"e884158c6e5b00c3cfa9ceef995863830761b02c","user":{"login":"Neeke","id":1913308,"avatar_url":"https://avatars.githubusercontent.com/u/1913308?v=3","gravatar_id":"","url":"https://api.github.com/users/Neeke","html_url":"https://github.com/Neeke","followers_url":"https://api.github.com/users/Neeke/followers","following_url":"https://api.github.com/users/Neeke/following{/other_user}","gists_url":"https://api.github.com/users/Neeke/gists{/gist_id}","starred_url":"https://api.github.com/users/Neeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neeke/subscriptions","organizations_url":"https://api.github.com/users/Neeke/orgs","repos_url":"https://api.github.com/users/Neeke/repos","events_url":"https://api.github.com/users/Neeke/events{/privacy}","received_events_url":"https://api.github.com/users/Neeke/received_events","type":"User","site_admin":false},"repo":{"id":31807978,"name":"php-src","full_name":"Neeke/php-src","owner":{"login":"Neeke","id":1913308,"avatar_url":"https://avatars.githubusercontent.com/u/1913308?v=3","gravatar_id":"","url":"https://api.github.com/users/Neeke","html_url":"https://github.com/Neeke","followers_url":"https://api.github.com/users/Neeke/followers","following_url":"https://api.github.com/users/Neeke/following{/other_user}","gists_url":"https://api.github.com/users/Neeke/gists{/gist_id}","starred_url":"https://api.github.com/users/Neeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neeke/subscriptions","organizations_url":"https://api.github.com/users/Neeke/orgs","repos_url":"https://api.github.com/users/Neeke/repos","events_url":"https://api.github.com/users/Neeke/events{/privacy}","received_events_url":"https://api.github.com/users/Neeke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neeke/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/Neeke/php-src","forks_url":"https://api.github.com/repos/Neeke/php-src/forks","keys_url":"https://api.github.com/repos/Neeke/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neeke/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neeke/php-src/teams","hooks_url":"https://api.github.com/repos/Neeke/php-src/hooks","issue_events_url":"https://api.github.com/repos/Neeke/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/Neeke/php-src/events","assignees_url":"https://api.github.com/repos/Neeke/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/Neeke/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/Neeke/php-src/tags","blobs_url":"https://api.github.com/repos/Neeke/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neeke/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neeke/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neeke/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neeke/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/Neeke/php-src/languages","stargazers_url":"https://api.github.com/repos/Neeke/php-src/stargazers","contributors_url":"https://api.github.com/repos/Neeke/php-src/contributors","subscribers_url":"https://api.github.com/repos/Neeke/php-src/subscribers","subscription_url":"https://api.github.com/repos/Neeke/php-src/subscription","commits_url":"https://api.github.com/repos/Neeke/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neeke/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neeke/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neeke/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neeke/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/Neeke/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neeke/php-src/merges","archive_url":"https://api.github.com/repos/Neeke/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neeke/php-src/downloads","issues_url":"https://api.github.com/repos/Neeke/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/Neeke/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/Neeke/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/Neeke/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neeke/php-src/labels{/name}","releases_url":"https://api.github.com/repos/Neeke/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/Neeke/php-src/deployments","created_at":"2015-03-07T09:57:50Z","updated_at":"2015-03-11T03:25:42Z","pushed_at":"2015-03-11T03:25:41Z","git_url":"git://github.com/Neeke/php-src.git","ssh_url":"git@github.com:Neeke/php-src.git","clone_url":"https://github.com/Neeke/php-src.git","svn_url":"https://github.com/Neeke/php-src","homepage":"http://www.php.net","size":216186,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:PHP-5.5","ref":"PHP-5.5","sha":"675606f1a673e285cd0eb5720484376a5fc90eba","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2017-01-04T10:26:21Z","pushed_at":"2017-01-04T10:01:23Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":277366,"stargazers_count":10839,"watchers_count":10839,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3741,"mirror_url":null,"open_issues_count":208,"forks":3741,"open_issues":208,"watchers":10839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1167"},"html":{"href":"https://github.com/php/php-src/pull/1167"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1167"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1167/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1167/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1167/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/e884158c6e5b00c3cfa9ceef995863830761b02c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"krakjoe"}}