{"action":"created","issue":{"url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/598","repository_url":"https://api.github.com/repos/PrismarineJS/mineflayer","labels_url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/598/labels{/name}","comments_url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/598/comments","events_url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/598/events","html_url":"https://github.com/PrismarineJS/mineflayer/issues/598","id":263091904,"number":598,"title":"Compilation of errors and problems I've had (current problems and problems not affecting me anymore but still present)","user":{"login":"johnpyp","id":20625636,"avatar_url":"https://avatars2.githubusercontent.com/u/20625636?v=4","gravatar_id":"","url":"https://api.github.com/users/johnpyp","html_url":"https://github.com/johnpyp","followers_url":"https://api.github.com/users/johnpyp/followers","following_url":"https://api.github.com/users/johnpyp/following{/other_user}","gists_url":"https://api.github.com/users/johnpyp/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpyp/subscriptions","organizations_url":"https://api.github.com/users/johnpyp/orgs","repos_url":"https://api.github.com/users/johnpyp/repos","events_url":"https://api.github.com/users/johnpyp/events{/privacy}","received_events_url":"https://api.github.com/users/johnpyp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-05T11:34:21Z","updated_at":"2017-10-09T14:41:18Z","closed_at":null,"author_association":"NONE","body":"**Current Fatal Issues**:\r\n\r\nGetting a new error after about 20minutes of grinding blazes on pvp.desteria.com with !atkmob command in my bot https://github.com/johnpyp/mineflayer-bot/blob/master/server/commands.js#L5:\r\n\r\n``` \r\n { TypeError: Serialization error for play.toServer.window_click.action : Write error for params.window_click.action : \"value\" argument is out of bounds\r\n    at checkInt (buffer.js:1178:11)\r\n    at Buffer.writeInt16BE (buffer.js:1357:5)\r\n    at ProtoDef.writer (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\datatypes\\numeric.js:76:25)\r\n    at ProtoDef.write (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\protodef.js:135:29)\r\n    at tryDoc (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\datatypes\\structures.js:64:23)\r\n    at tryCatch (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\utils.js:63:16)\r\n    at tryDoc (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\utils.js:67:10)\r\n    at typeArgs.reduce (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\datatypes\\structures.js:64:5)\r\n    at Array.reduce (<anonymous>)\r\n    at ProtoDef.writeContainer (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\protodef\\src\\datatypes\\structures.js:63:19) field: 'play.toServer.window_click.action' }\r\n```\r\nI have tampered with the mineflayer code twice to fix other issues:\r\n\r\n* I changed `return cb(err)` to `return cb()` in compression.js in NMP to fix unexpected end of file error. (https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/transforms/compression.js#L64) \r\nThis is the relevant issue I referenced to quick-fix this problem: https://github.com/PrismarineJS/mineflayer/issues/431\r\n\r\n* I also removed the if statement here https://github.com/PrismarineJS/prismarine-chunk/blob/master/src/pc/1.8/chunk.js#L192  to quick-fix this unknown error: \r\n```\r\nD:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modulesprismarine-chunk\\src\\pc\\1.8\\chunk.js:192                                                                                                                         \r\n      throw(new Error(`Data buffer not correct size \\(was ${data.length}, expected ${BUFFER_SIZE}\\)`));                   \r\n      ^                                                                                                                   \r\n                                                                                                                          \r\nError: Data buffer not correct size (was 12288, expected 196864)                                                          \r\n    at Chunk.load (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\prismarine-chunk\\src\\pc\\1.8\\chunk.js:192:13)                                                                                                  \r\n    at addColumn (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\mineflayer\\lib\\plugins\\blocks.js:46:12)                                                                                                        \r\n    at Client.bot._client.on (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\mineflayer\\lib\\plugins\\blocks.js:166:5)                                                                                            \r\n    at emitTwo (events.js:125:13)                                                                                         \r\n    at Client.emit (events.js:213:7)                                                                                      \r\n    at Parser.deserializer.on (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\minecraft-protocol\\src\\client.js:102:12)                                                                                          \r\n    at emitOne (events.js:115:13)                                                                                         \r\n    at Parser.emit (events.js:210:7)                                                                                      \r\n    at addChunk (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\readable-stream\\lib\\_stream_readable.js:284:12)                                                                                                 \r\n    at readableAddChunk (D:\\epcmuser\\Desktop\\Coding\\HTML & Web Development\\Node\\mineflayer-bot\\node_modules\\readable-stream\\lib\\_stream_readable.js:271:11)                                                                                         `\r\n```\r\n\r\nI have a feeling tampering with the code is causing more errors, but the bot won't work on my server I play on without the first fix and the chunk.js error I have no idea what it is.\r\n\r\n\r\n **Other more minor issues:** \r\n* 1.9 has multiple physics problems:\r\n1) Player doesn't pick up items or exp.\r\n2) Player's head doesn't turn with lookAt.\r\n3) Item switch doesn't change item sprite always.\r\n4) Player sticks into walls if spawned next to a wall.\r\n5) When teleported into mid-air, player floats in air and falls while dying then teleports backup and keeps falling. Almost like a weird fall lag.\r\n6) Players do not experience hunger damage.\r\n7) Players do not move in flowing water.\r\n8) Players do not experience drowning damage.\r\n\r\n(Almost all of these issues fixed themselves when changing to 1.8.9)\r\n\r\n*Note: These problems were created using version: \"1.9\" and using the quick-fixes found above on pvp.desteria.com . Moving players to different places was all done via /tpa, no actual movement.*\r\n*Note: Problems 7 & 8 have not been recreated in 1.8.9 to confirm they are operating as expected.*\r\n\r\n\r\n\r\n* Socks5-client example found here: https://github.com/PrismarineJS/mineflayer/issues/461#issuecomment-267124920 returns an error and crashes (Will reproduce later and post)\r\n\r\n\r\n\r\n* Looking to keep one of the \"bugs\" from 1.9 and convert it to 1.8.9 -- not collecting exp. Is it possible to turn some of these properties on and off?\r\n\r\n**When not using quick fixes:**\r\n\r\n*To undo fixes I deleted node_modules and did npm install*\r\n\r\nUnexpected end of file error appears on most servers I go to and it crashes. That said, on one of the servers that I didn't get that error (mc.hypixel.net), the bot seems to run perfectly indefinitely with no errors like the chunk.js error or the serialization error.\r\n\r\n--------------------------------------------------------------------------------------------------\r\nThe repository for my bot can be found here: https://github.com/johnpyp/mineflayer-bot\r\n"},"comment":{"url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/comments/335178928","html_url":"https://github.com/PrismarineJS/mineflayer/issues/598#issuecomment-335178928","issue_url":"https://api.github.com/repos/PrismarineJS/mineflayer/issues/598","id":335178928,"user":{"login":"roblabla","id":1069318,"avatar_url":"https://avatars3.githubusercontent.com/u/1069318?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla","html_url":"https://github.com/roblabla","followers_url":"https://api.github.com/users/roblabla/followers","following_url":"https://api.github.com/users/roblabla/following{/other_user}","gists_url":"https://api.github.com/users/roblabla/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla/subscriptions","organizations_url":"https://api.github.com/users/roblabla/orgs","repos_url":"https://api.github.com/users/roblabla/repos","events_url":"https://api.github.com/users/roblabla/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla/received_events","type":"User","site_admin":false},"created_at":"2017-10-09T14:41:18Z","updated_at":"2017-10-09T14:41:18Z","author_association":"OWNER","body":"For the proxies : Are you using public proxies ? If so, I can't really help you much. Try to set up your own proxy servers and check if those work. If they don't, tell me what proxy software and version you tried using so I can figure out what's wrong.\r\n\r\nFor the chunk errors : we probably have a mistake in the way we handle chunks. We'll need a TCP dump.\r\n\r\n@rom1504 just had a silly thought : when we get a parse error in NMP, we should output a file on the disk with the raw buffer that failed to parse (after splitting phase) and ask users to upload that in the stacktrace message ^^."}}
{"actor":{"display_login":"roblabla"}}