{"action":"created","issue":{"url":"https://api.github.com/repos/rpush/rpush/issues/382","repository_url":"https://api.github.com/repos/rpush/rpush","labels_url":"https://api.github.com/repos/rpush/rpush/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/rpush/rpush/issues/382/comments","events_url":"https://api.github.com/repos/rpush/rpush/issues/382/events","html_url":"https://github.com/rpush/rpush/issues/382","id":263662239,"number":382,"title":"make booleans true or false ... not nil","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-07T18:30:13Z","updated_at":"2017-10-17T15:13:52Z","closed_at":null,"author_association":"NONE","body":"mutable_content, content_available and alert_is_json can be nil/true/false which seems dangerous ...\r\nwould you accept a PR that changes them via `change_column_null false` ?\r\n\r\nFYI found via:\r\n\r\n```Ruby\r\n  it \"does not have 3-state booleans (nil/false/true)\" do\r\n    bad = File.read(\"db/schema.rb\").scan(/\\st\\.boolean.*/).reject { |l| l .include?(\" null: false\") }\r\n    assert bad.empty?, \"Boolean columns missing a default or null: false\\n#{bad.join(\"\\n\")}\"\r\n  end\r\n```"},"comment":{"url":"https://api.github.com/repos/rpush/rpush/issues/comments/337265249","html_url":"https://github.com/rpush/rpush/issues/382#issuecomment-337265249","issue_url":"https://api.github.com/repos/rpush/rpush/issues/382","id":337265249,"user":{"login":"aried3r","id":1301152,"avatar_url":"https://avatars1.githubusercontent.com/u/1301152?v=4","gravatar_id":"","url":"https://api.github.com/users/aried3r","html_url":"https://github.com/aried3r","followers_url":"https://api.github.com/users/aried3r/followers","following_url":"https://api.github.com/users/aried3r/following{/other_user}","gists_url":"https://api.github.com/users/aried3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aried3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aried3r/subscriptions","organizations_url":"https://api.github.com/users/aried3r/orgs","repos_url":"https://api.github.com/users/aried3r/repos","events_url":"https://api.github.com/users/aried3r/events{/privacy}","received_events_url":"https://api.github.com/users/aried3r/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T15:13:52Z","updated_at":"2017-10-17T15:13:52Z","author_association":"COLLABORATOR","body":"Sure, I don't see why not. Would you change the migration templates or add a `3_0_1_updates` migration? Asking because I'm not sure if this should be seen as a backwards incompatible breaking change which would demand a 4.0 according to semver. I don't know if people rely on it being `nil` at any point.\r\n\r\nIn theory it should be an implementation detail which should not break stuff.\r\n\r\nPS: That's a neat test, got some more of those sanity checks online?"}}
{"actor":{"display_login":"aried3r"}}