{"action":"closed","number":267,"pull_request":{"url":"https://api.github.com/repos/cnjinhao/nana/pulls/267","id":147695151,"html_url":"https://github.com/cnjinhao/nana/pull/267","diff_url":"https://github.com/cnjinhao/nana/pull/267.diff","patch_url":"https://github.com/cnjinhao/nana/pull/267.patch","issue_url":"https://api.github.com/repos/cnjinhao/nana/issues/267","number":267,"state":"closed","locked":false,"title":"improve the readability of the place div-string by using width and height instead of weight","user":{"login":"qPCR4vir","id":1911982,"avatar_url":"https://avatars2.githubusercontent.com/u/1911982?v=4","gravatar_id":"","url":"https://api.github.com/users/qPCR4vir","html_url":"https://github.com/qPCR4vir","followers_url":"https://api.github.com/users/qPCR4vir/followers","following_url":"https://api.github.com/users/qPCR4vir/following{/other_user}","gists_url":"https://api.github.com/users/qPCR4vir/gists{/gist_id}","starred_url":"https://api.github.com/users/qPCR4vir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qPCR4vir/subscriptions","organizations_url":"https://api.github.com/users/qPCR4vir/orgs","repos_url":"https://api.github.com/users/qPCR4vir/repos","events_url":"https://api.github.com/users/qPCR4vir/events{/privacy}","received_events_url":"https://api.github.com/users/qPCR4vir/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI was thinking in an easy way to improve the readability of the place div-string and I think that if we use `width `and `height `instead of `weight` it will be much more easy to see where we are, in what direction.\r\nCompare:\r\n```\r\nvertical   gap=2                                    \r\n\t<height=25>                             \r\n\t<height=25  OpenSave>                   \r\n\t<textBox>                               \r\n\t<height=25 <width=15>                  \r\n\t           <re width=50 gap=2>         \r\n\t           <panic width=50>            \r\n\t           < >                          \r\n\t           <def  gap=2 width=120>      \r\n\t           < >                          \r\n\t           <hide width=50>             \r\n\t           <width=15> >                \r\n\t<height=5>       \r\n```                \r\nand \r\n```\r\nvertical   gap=2                                    \r\n\t<weight=25>                             \r\n\t<weight=25  OpenSave>                   \r\n\t<textBox>                               \r\n\t<weight=25 <weight=15>                  \r\n\t           <re weight=50 gap=2>         \r\n\t           <panic weight=50>            \r\n\t           < >                          \r\n\t           <def  gap=2 weight=120>      \r\n\t           < >                          \r\n\t           <hide weight=50>             \r\n\t           <weight=15> >                \r\n\t<weight=5>     \r\n```                         \r\n\r\nadditionaly, it will detect if there are an imposible combination. \r\nAnd if someone prefer can continue to use `weight`, no problem.\r\nAnother addition could be to have comments.\r\n\r\n\r\n","created_at":"2017-10-20T00:24:37Z","updated_at":"2017-10-28T18:05:27Z","closed_at":"2017-10-28T18:05:27Z","merged_at":"2017-10-28T18:05:27Z","merge_commit_sha":"708152ed7880c61c122f551c89f1ad82b1df2299","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cnjinhao/nana/pulls/267/commits","review_comments_url":"https://api.github.com/repos/cnjinhao/nana/pulls/267/comments","review_comment_url":"https://api.github.com/repos/cnjinhao/nana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cnjinhao/nana/issues/267/comments","statuses_url":"https://api.github.com/repos/cnjinhao/nana/statuses/708152ed7880c61c122f551c89f1ad82b1df2299","head":{"label":"qPCR4vir:dev","ref":"dev","sha":"708152ed7880c61c122f551c89f1ad82b1df2299","user":{"login":"qPCR4vir","id":1911982,"avatar_url":"https://avatars2.githubusercontent.com/u/1911982?v=4","gravatar_id":"","url":"https://api.github.com/users/qPCR4vir","html_url":"https://github.com/qPCR4vir","followers_url":"https://api.github.com/users/qPCR4vir/followers","following_url":"https://api.github.com/users/qPCR4vir/following{/other_user}","gists_url":"https://api.github.com/users/qPCR4vir/gists{/gist_id}","starred_url":"https://api.github.com/users/qPCR4vir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qPCR4vir/subscriptions","organizations_url":"https://api.github.com/users/qPCR4vir/orgs","repos_url":"https://api.github.com/users/qPCR4vir/repos","events_url":"https://api.github.com/users/qPCR4vir/events{/privacy}","received_events_url":"https://api.github.com/users/qPCR4vir/received_events","type":"User","site_admin":false},"repo":{"id":27860980,"name":"nana","full_name":"qPCR4vir/nana","owner":{"login":"qPCR4vir","id":1911982,"avatar_url":"https://avatars2.githubusercontent.com/u/1911982?v=4","gravatar_id":"","url":"https://api.github.com/users/qPCR4vir","html_url":"https://github.com/qPCR4vir","followers_url":"https://api.github.com/users/qPCR4vir/followers","following_url":"https://api.github.com/users/qPCR4vir/following{/other_user}","gists_url":"https://api.github.com/users/qPCR4vir/gists{/gist_id}","starred_url":"https://api.github.com/users/qPCR4vir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qPCR4vir/subscriptions","organizations_url":"https://api.github.com/users/qPCR4vir/orgs","repos_url":"https://api.github.com/users/qPCR4vir/repos","events_url":"https://api.github.com/users/qPCR4vir/events{/privacy}","received_events_url":"https://api.github.com/users/qPCR4vir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qPCR4vir/nana","description":"a modern C++ GUI library","fork":true,"url":"https://api.github.com/repos/qPCR4vir/nana","forks_url":"https://api.github.com/repos/qPCR4vir/nana/forks","keys_url":"https://api.github.com/repos/qPCR4vir/nana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qPCR4vir/nana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qPCR4vir/nana/teams","hooks_url":"https://api.github.com/repos/qPCR4vir/nana/hooks","issue_events_url":"https://api.github.com/repos/qPCR4vir/nana/issues/events{/number}","events_url":"https://api.github.com/repos/qPCR4vir/nana/events","assignees_url":"https://api.github.com/repos/qPCR4vir/nana/assignees{/user}","branches_url":"https://api.github.com/repos/qPCR4vir/nana/branches{/branch}","tags_url":"https://api.github.com/repos/qPCR4vir/nana/tags","blobs_url":"https://api.github.com/repos/qPCR4vir/nana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qPCR4vir/nana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qPCR4vir/nana/git/refs{/sha}","trees_url":"https://api.github.com/repos/qPCR4vir/nana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qPCR4vir/nana/statuses/{sha}","languages_url":"https://api.github.com/repos/qPCR4vir/nana/languages","stargazers_url":"https://api.github.com/repos/qPCR4vir/nana/stargazers","contributors_url":"https://api.github.com/repos/qPCR4vir/nana/contributors","subscribers_url":"https://api.github.com/repos/qPCR4vir/nana/subscribers","subscription_url":"https://api.github.com/repos/qPCR4vir/nana/subscription","commits_url":"https://api.github.com/repos/qPCR4vir/nana/commits{/sha}","git_commits_url":"https://api.github.com/repos/qPCR4vir/nana/git/commits{/sha}","comments_url":"https://api.github.com/repos/qPCR4vir/nana/comments{/number}","issue_comment_url":"https://api.github.com/repos/qPCR4vir/nana/issues/comments{/number}","contents_url":"https://api.github.com/repos/qPCR4vir/nana/contents/{+path}","compare_url":"https://api.github.com/repos/qPCR4vir/nana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qPCR4vir/nana/merges","archive_url":"https://api.github.com/repos/qPCR4vir/nana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qPCR4vir/nana/downloads","issues_url":"https://api.github.com/repos/qPCR4vir/nana/issues{/number}","pulls_url":"https://api.github.com/repos/qPCR4vir/nana/pulls{/number}","milestones_url":"https://api.github.com/repos/qPCR4vir/nana/milestones{/number}","notifications_url":"https://api.github.com/repos/qPCR4vir/nana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qPCR4vir/nana/labels{/name}","releases_url":"https://api.github.com/repos/qPCR4vir/nana/releases{/id}","deployments_url":"https://api.github.com/repos/qPCR4vir/nana/deployments","created_at":"2014-12-11T08:15:24Z","updated_at":"2017-01-13T14:43:35Z","pushed_at":"2017-10-20T00:13:07Z","git_url":"git://github.com/qPCR4vir/nana.git","ssh_url":"git@github.com:qPCR4vir/nana.git","clone_url":"https://github.com/qPCR4vir/nana.git","svn_url":"https://github.com/qPCR4vir/nana","homepage":"http://nanapro.org","size":14513,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":21,"forks":2,"open_issues":21,"watchers":12,"default_branch":"master"}},"base":{"label":"cnjinhao:develop","ref":"develop","sha":"3ce374f0103313bda791537d97d2e9b9d7cdf59c","user":{"login":"cnjinhao","id":1246418,"avatar_url":"https://avatars2.githubusercontent.com/u/1246418?v=4","gravatar_id":"","url":"https://api.github.com/users/cnjinhao","html_url":"https://github.com/cnjinhao","followers_url":"https://api.github.com/users/cnjinhao/followers","following_url":"https://api.github.com/users/cnjinhao/following{/other_user}","gists_url":"https://api.github.com/users/cnjinhao/gists{/gist_id}","starred_url":"https://api.github.com/users/cnjinhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnjinhao/subscriptions","organizations_url":"https://api.github.com/users/cnjinhao/orgs","repos_url":"https://api.github.com/users/cnjinhao/repos","events_url":"https://api.github.com/users/cnjinhao/events{/privacy}","received_events_url":"https://api.github.com/users/cnjinhao/received_events","type":"User","site_admin":false},"repo":{"id":2930881,"name":"nana","full_name":"cnjinhao/nana","owner":{"login":"cnjinhao","id":1246418,"avatar_url":"https://avatars2.githubusercontent.com/u/1246418?v=4","gravatar_id":"","url":"https://api.github.com/users/cnjinhao","html_url":"https://github.com/cnjinhao","followers_url":"https://api.github.com/users/cnjinhao/followers","following_url":"https://api.github.com/users/cnjinhao/following{/other_user}","gists_url":"https://api.github.com/users/cnjinhao/gists{/gist_id}","starred_url":"https://api.github.com/users/cnjinhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnjinhao/subscriptions","organizations_url":"https://api.github.com/users/cnjinhao/orgs","repos_url":"https://api.github.com/users/cnjinhao/repos","events_url":"https://api.github.com/users/cnjinhao/events{/privacy}","received_events_url":"https://api.github.com/users/cnjinhao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnjinhao/nana","description":"a modern C++ GUI library","fork":false,"url":"https://api.github.com/repos/cnjinhao/nana","forks_url":"https://api.github.com/repos/cnjinhao/nana/forks","keys_url":"https://api.github.com/repos/cnjinhao/nana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnjinhao/nana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnjinhao/nana/teams","hooks_url":"https://api.github.com/repos/cnjinhao/nana/hooks","issue_events_url":"https://api.github.com/repos/cnjinhao/nana/issues/events{/number}","events_url":"https://api.github.com/repos/cnjinhao/nana/events","assignees_url":"https://api.github.com/repos/cnjinhao/nana/assignees{/user}","branches_url":"https://api.github.com/repos/cnjinhao/nana/branches{/branch}","tags_url":"https://api.github.com/repos/cnjinhao/nana/tags","blobs_url":"https://api.github.com/repos/cnjinhao/nana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnjinhao/nana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnjinhao/nana/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnjinhao/nana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnjinhao/nana/statuses/{sha}","languages_url":"https://api.github.com/repos/cnjinhao/nana/languages","stargazers_url":"https://api.github.com/repos/cnjinhao/nana/stargazers","contributors_url":"https://api.github.com/repos/cnjinhao/nana/contributors","subscribers_url":"https://api.github.com/repos/cnjinhao/nana/subscribers","subscription_url":"https://api.github.com/repos/cnjinhao/nana/subscription","commits_url":"https://api.github.com/repos/cnjinhao/nana/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnjinhao/nana/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnjinhao/nana/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnjinhao/nana/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnjinhao/nana/contents/{+path}","compare_url":"https://api.github.com/repos/cnjinhao/nana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnjinhao/nana/merges","archive_url":"https://api.github.com/repos/cnjinhao/nana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnjinhao/nana/downloads","issues_url":"https://api.github.com/repos/cnjinhao/nana/issues{/number}","pulls_url":"https://api.github.com/repos/cnjinhao/nana/pulls{/number}","milestones_url":"https://api.github.com/repos/cnjinhao/nana/milestones{/number}","notifications_url":"https://api.github.com/repos/cnjinhao/nana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnjinhao/nana/labels{/name}","releases_url":"https://api.github.com/repos/cnjinhao/nana/releases{/id}","deployments_url":"https://api.github.com/repos/cnjinhao/nana/deployments","created_at":"2011-12-07T07:12:03Z","updated_at":"2017-10-27T15:55:51Z","pushed_at":"2017-10-28T18:05:26Z","git_url":"git://github.com/cnjinhao/nana.git","ssh_url":"git@github.com:cnjinhao/nana.git","clone_url":"https://github.com/cnjinhao/nana.git","svn_url":"https://github.com/cnjinhao/nana","homepage":"http://nanapro.org","size":4748,"stargazers_count":610,"watchers_count":610,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":24,"forks":131,"open_issues":24,"watchers":610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cnjinhao/nana/pulls/267"},"html":{"href":"https://github.com/cnjinhao/nana/pull/267"},"issue":{"href":"https://api.github.com/repos/cnjinhao/nana/issues/267"},"comments":{"href":"https://api.github.com/repos/cnjinhao/nana/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/cnjinhao/nana/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/cnjinhao/nana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cnjinhao/nana/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/cnjinhao/nana/statuses/708152ed7880c61c122f551c89f1ad82b1df2299"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cnjinhao","id":1246418,"avatar_url":"https://avatars2.githubusercontent.com/u/1246418?v=4","gravatar_id":"","url":"https://api.github.com/users/cnjinhao","html_url":"https://github.com/cnjinhao","followers_url":"https://api.github.com/users/cnjinhao/followers","following_url":"https://api.github.com/users/cnjinhao/following{/other_user}","gists_url":"https://api.github.com/users/cnjinhao/gists{/gist_id}","starred_url":"https://api.github.com/users/cnjinhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnjinhao/subscriptions","organizations_url":"https://api.github.com/users/cnjinhao/orgs","repos_url":"https://api.github.com/users/cnjinhao/repos","events_url":"https://api.github.com/users/cnjinhao/events{/privacy}","received_events_url":"https://api.github.com/users/cnjinhao/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":299,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"cnjinhao"}}