{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/138296055","pull_request_review_id":62069930,"id":138296055,"diff_hunk":"@@ -117,6 +118,7 @@ public function build(ContainerBuilder $container)\n         $container->addCompilerPass(new CachePoolPrunerPass(), PassConfig::TYPE_AFTER_REMOVING);\n         $this->addCompilerPassIfExists($container, FormPass::class);\n         $container->addCompilerPass(new WorkflowGuardListenerPass());\n+        $container->addCompilerPass(new ResettableServicePass('kernel.reset'), PassConfig::TYPE_AFTER_REMOVING);","path":"src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php","position":12,"original_position":12,"commit_id":"9d2d4e89ddcda54561e87f57582a84cb572b1167","original_commit_id":"ac7b2c6b4557e6c16f94fa7e2378ba4e1f607460","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"'kernel.reset' should be the default value of the constructor arg instead (as done in other passes)","created_at":"2017-09-12T09:26:46Z","updated_at":"2017-09-12T09:31:30Z","html_url":"https://github.com/symfony/symfony/pull/24155#discussion_r138296055","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/24155","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/138296055"},"html":{"href":"https://github.com/symfony/symfony/pull/24155#discussion_r138296055"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24155"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/24155","id":140352134,"html_url":"https://github.com/symfony/symfony/pull/24155","diff_url":"https://github.com/symfony/symfony/pull/24155.diff","patch_url":"https://github.com/symfony/symfony/pull/24155.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/24155","number":24155,"state":"open","locked":false,"title":"[FrameworkBundle] Add DI tag for resettable services","user":{"login":"derrabus","id":1506493,"avatar_url":"https://avatars3.githubusercontent.com/u/1506493?v=4","gravatar_id":"","url":"https://api.github.com/users/derrabus","html_url":"https://github.com/derrabus","followers_url":"https://api.github.com/users/derrabus/followers","following_url":"https://api.github.com/users/derrabus/following{/other_user}","gists_url":"https://api.github.com/users/derrabus/gists{/gist_id}","starred_url":"https://api.github.com/users/derrabus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derrabus/subscriptions","organizations_url":"https://api.github.com/users/derrabus/orgs","repos_url":"https://api.github.com/users/derrabus/repos","events_url":"https://api.github.com/users/derrabus/events{/privacy}","received_events_url":"https://api.github.com/users/derrabus/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.4\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #23984\r\n| License       | MIT\r\n| Doc PR        | TODO\r\n\r\nThis PR uses #24033 to introduce a DI tag for resettable services.\r\n\r\nTODO:\r\n* [ ] Add an interface, make the \"method\" attribute optional and enable autoconfiguration.\r\n* [ ] Add a config option to enable/disable this feature.\r\n* [ ] Configure leaking services of the core bundles as resettable.","created_at":"2017-09-11T14:40:21Z","updated_at":"2017-09-12T09:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b8afc38fae906d6963a4bfd90944a284cf788f0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":142,"closed_issues":270,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2017-09-12T08:08:11Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/24155/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/24155/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/24155/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/9d2d4e89ddcda54561e87f57582a84cb572b1167","head":{"label":"derrabus:3.4-resettable-services","ref":"3.4-resettable-services","sha":"9d2d4e89ddcda54561e87f57582a84cb572b1167","user":{"login":"derrabus","id":1506493,"avatar_url":"https://avatars3.githubusercontent.com/u/1506493?v=4","gravatar_id":"","url":"https://api.github.com/users/derrabus","html_url":"https://github.com/derrabus","followers_url":"https://api.github.com/users/derrabus/followers","following_url":"https://api.github.com/users/derrabus/following{/other_user}","gists_url":"https://api.github.com/users/derrabus/gists{/gist_id}","starred_url":"https://api.github.com/users/derrabus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derrabus/subscriptions","organizations_url":"https://api.github.com/users/derrabus/orgs","repos_url":"https://api.github.com/users/derrabus/repos","events_url":"https://api.github.com/users/derrabus/events{/privacy}","received_events_url":"https://api.github.com/users/derrabus/received_events","type":"User","site_admin":false},"repo":{"id":16010475,"name":"symfony","full_name":"derrabus/symfony","owner":{"login":"derrabus","id":1506493,"avatar_url":"https://avatars3.githubusercontent.com/u/1506493?v=4","gravatar_id":"","url":"https://api.github.com/users/derrabus","html_url":"https://github.com/derrabus","followers_url":"https://api.github.com/users/derrabus/followers","following_url":"https://api.github.com/users/derrabus/following{/other_user}","gists_url":"https://api.github.com/users/derrabus/gists{/gist_id}","starred_url":"https://api.github.com/users/derrabus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derrabus/subscriptions","organizations_url":"https://api.github.com/users/derrabus/orgs","repos_url":"https://api.github.com/users/derrabus/repos","events_url":"https://api.github.com/users/derrabus/events{/privacy}","received_events_url":"https://api.github.com/users/derrabus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derrabus/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/derrabus/symfony","forks_url":"https://api.github.com/repos/derrabus/symfony/forks","keys_url":"https://api.github.com/repos/derrabus/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derrabus/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derrabus/symfony/teams","hooks_url":"https://api.github.com/repos/derrabus/symfony/hooks","issue_events_url":"https://api.github.com/repos/derrabus/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/derrabus/symfony/events","assignees_url":"https://api.github.com/repos/derrabus/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/derrabus/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/derrabus/symfony/tags","blobs_url":"https://api.github.com/repos/derrabus/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derrabus/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derrabus/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/derrabus/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derrabus/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/derrabus/symfony/languages","stargazers_url":"https://api.github.com/repos/derrabus/symfony/stargazers","contributors_url":"https://api.github.com/repos/derrabus/symfony/contributors","subscribers_url":"https://api.github.com/repos/derrabus/symfony/subscribers","subscription_url":"https://api.github.com/repos/derrabus/symfony/subscription","commits_url":"https://api.github.com/repos/derrabus/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/derrabus/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/derrabus/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/derrabus/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/derrabus/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/derrabus/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derrabus/symfony/merges","archive_url":"https://api.github.com/repos/derrabus/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derrabus/symfony/downloads","issues_url":"https://api.github.com/repos/derrabus/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/derrabus/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/derrabus/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/derrabus/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derrabus/symfony/labels{/name}","releases_url":"https://api.github.com/repos/derrabus/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/derrabus/symfony/deployments","created_at":"2014-01-17T20:10:54Z","updated_at":"2015-01-02T10:13:49Z","pushed_at":"2017-09-12T09:30:38Z","git_url":"git://github.com/derrabus/symfony.git","ssh_url":"git@github.com:derrabus/symfony.git","clone_url":"https://github.com/derrabus/symfony.git","svn_url":"https://github.com/derrabus/symfony","homepage":"symfony.com","size":97696,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:3.4","ref":"3.4","sha":"7ab8efb74ecd422ed627753971637bd7d8dc92ca","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-09-12T03:27:51Z","pushed_at":"2017-09-12T09:30:41Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":101940,"stargazers_count":15116,"watchers_count":15116,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5690,"mirror_url":null,"open_issues_count":842,"forks":5690,"open_issues":842,"watchers":15116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24155"},"html":{"href":"https://github.com/symfony/symfony/pull/24155"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/24155"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/24155/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24155/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24155/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/9d2d4e89ddcda54561e87f57582a84cb572b1167"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicolas-grekas"}}