{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/148712174","pull_request_review_id":73998580,"id":148712174,"diff_hunk":"@@ -374,6 +374,8 @@ public ChildProcess(RSCConf conf, Promise<?> promise, final Process childProc, F\n         @Override\n         public void run() {\n           try {\n+            RSCClientFactory.childProcesses().incrementAndGet();\n+            System.out.println(\"processes:\" + RSCClientFactory.childProcesses().get());","path":"rsc/src/main/java/org/apache/livy/rsc/ContextLauncher.java","position":null,"original_position":5,"commit_id":"408cc00014432a6aee2b19fb013cb43d836e371d","original_commit_id":"ca05bba44b4d4ac24384eac035b8e686242dde38","user":{"login":"shenh062326","id":9527867,"avatar_url":"https://avatars3.githubusercontent.com/u/9527867?v=4","gravatar_id":"","url":"https://api.github.com/users/shenh062326","html_url":"https://github.com/shenh062326","followers_url":"https://api.github.com/users/shenh062326/followers","following_url":"https://api.github.com/users/shenh062326/following{/other_user}","gists_url":"https://api.github.com/users/shenh062326/gists{/gist_id}","starred_url":"https://api.github.com/users/shenh062326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenh062326/subscriptions","organizations_url":"https://api.github.com/users/shenh062326/orgs","repos_url":"https://api.github.com/users/shenh062326/repos","events_url":"https://api.github.com/users/shenh062326/events{/privacy}","received_events_url":"https://api.github.com/users/shenh062326/received_events","type":"User","site_admin":false},"body":"Yes, I have remove debug log.","created_at":"2017-11-03T05:29:29Z","updated_at":"2017-11-03T05:29:29Z","html_url":"https://github.com/apache/incubator-livy/pull/58#discussion_r148712174","pull_request_url":"https://api.github.com/repos/apache/incubator-livy/pulls/58","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/148712174"},"html":{"href":"https://github.com/apache/incubator-livy/pull/58#discussion_r148712174"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/58"}},"in_reply_to_id":148712137},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/58","id":148032299,"html_url":"https://github.com/apache/incubator-livy/pull/58","diff_url":"https://github.com/apache/incubator-livy/pull/58.diff","patch_url":"https://github.com/apache/incubator-livy/pull/58.patch","issue_url":"https://api.github.com/repos/apache/incubator-livy/issues/58","number":58,"state":"open","locked":false,"title":"[LIVY-412][Server] Reject create session request if too more sessions are creating.","user":{"login":"shenh062326","id":9527867,"avatar_url":"https://avatars3.githubusercontent.com/u/9527867?v=4","gravatar_id":"","url":"https://api.github.com/users/shenh062326","html_url":"https://github.com/shenh062326","followers_url":"https://api.github.com/users/shenh062326/followers","following_url":"https://api.github.com/users/shenh062326/following{/other_user}","gists_url":"https://api.github.com/users/shenh062326/gists{/gist_id}","starred_url":"https://api.github.com/users/shenh062326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenh062326/subscriptions","organizations_url":"https://api.github.com/users/shenh062326/orgs","repos_url":"https://api.github.com/users/shenh062326/repos","events_url":"https://api.github.com/users/shenh062326/events{/privacy}","received_events_url":"https://api.github.com/users/shenh062326/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nIn our cluster, livy server run with spark yarn cluster mode, when createSession request is too frequently, livyServer will start too more spark-submit child process, it will cause the machine oom. \r\n\r\nReject the create session request when there are too many spark-submit child process. \r\n\r\n## How was this patch tested?\r\n\r\nAdd two testcase, test create interactive and batch session when reach the max creating sessions, the request should failed.\r\n\r\nPlease review https://livy.incubator.apache.org/community/ before opening a pull request.\r\n","created_at":"2017-10-23T03:15:08Z","updated_at":"2017-11-03T05:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b64dc983b169a9166992a40ebda5ebd382fcecc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-livy/pulls/58/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-livy/pulls/58/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-livy/issues/58/comments","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/408cc00014432a6aee2b19fb013cb43d836e371d","head":{"label":"shenh062326:livy-412","ref":"livy-412","sha":"408cc00014432a6aee2b19fb013cb43d836e371d","user":{"login":"shenh062326","id":9527867,"avatar_url":"https://avatars3.githubusercontent.com/u/9527867?v=4","gravatar_id":"","url":"https://api.github.com/users/shenh062326","html_url":"https://github.com/shenh062326","followers_url":"https://api.github.com/users/shenh062326/followers","following_url":"https://api.github.com/users/shenh062326/following{/other_user}","gists_url":"https://api.github.com/users/shenh062326/gists{/gist_id}","starred_url":"https://api.github.com/users/shenh062326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenh062326/subscriptions","organizations_url":"https://api.github.com/users/shenh062326/orgs","repos_url":"https://api.github.com/users/shenh062326/repos","events_url":"https://api.github.com/users/shenh062326/events{/privacy}","received_events_url":"https://api.github.com/users/shenh062326/received_events","type":"User","site_admin":false},"repo":{"id":98493063,"name":"incubator-livy","full_name":"shenh062326/incubator-livy","owner":{"login":"shenh062326","id":9527867,"avatar_url":"https://avatars3.githubusercontent.com/u/9527867?v=4","gravatar_id":"","url":"https://api.github.com/users/shenh062326","html_url":"https://github.com/shenh062326","followers_url":"https://api.github.com/users/shenh062326/followers","following_url":"https://api.github.com/users/shenh062326/following{/other_user}","gists_url":"https://api.github.com/users/shenh062326/gists{/gist_id}","starred_url":"https://api.github.com/users/shenh062326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenh062326/subscriptions","organizations_url":"https://api.github.com/users/shenh062326/orgs","repos_url":"https://api.github.com/users/shenh062326/repos","events_url":"https://api.github.com/users/shenh062326/events{/privacy}","received_events_url":"https://api.github.com/users/shenh062326/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shenh062326/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":true,"url":"https://api.github.com/repos/shenh062326/incubator-livy","forks_url":"https://api.github.com/repos/shenh062326/incubator-livy/forks","keys_url":"https://api.github.com/repos/shenh062326/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shenh062326/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shenh062326/incubator-livy/teams","hooks_url":"https://api.github.com/repos/shenh062326/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/shenh062326/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/shenh062326/incubator-livy/events","assignees_url":"https://api.github.com/repos/shenh062326/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/shenh062326/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/shenh062326/incubator-livy/tags","blobs_url":"https://api.github.com/repos/shenh062326/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shenh062326/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shenh062326/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/shenh062326/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shenh062326/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/shenh062326/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/shenh062326/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/shenh062326/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/shenh062326/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/shenh062326/incubator-livy/subscription","commits_url":"https://api.github.com/repos/shenh062326/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/shenh062326/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/shenh062326/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/shenh062326/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/shenh062326/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/shenh062326/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shenh062326/incubator-livy/merges","archive_url":"https://api.github.com/repos/shenh062326/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shenh062326/incubator-livy/downloads","issues_url":"https://api.github.com/repos/shenh062326/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/shenh062326/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/shenh062326/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/shenh062326/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shenh062326/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/shenh062326/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/shenh062326/incubator-livy/deployments","created_at":"2017-07-27T04:14:50Z","updated_at":"2017-07-27T04:14:52Z","pushed_at":"2017-11-03T05:28:05Z","git_url":"git://github.com/shenh062326/incubator-livy.git","ssh_url":"git@github.com:shenh062326/incubator-livy.git","clone_url":"https://github.com/shenh062326/incubator-livy.git","svn_url":"https://github.com/shenh062326/incubator-livy","homepage":null,"size":2949,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bef5b4f6d8ac931613027cf50cbc44be3be2e107","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":95343930,"name":"incubator-livy","full_name":"apache/incubator-livy","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-livy","forks_url":"https://api.github.com/repos/apache/incubator-livy/forks","keys_url":"https://api.github.com/repos/apache/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-livy/teams","hooks_url":"https://api.github.com/repos/apache/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-livy/events","assignees_url":"https://api.github.com/repos/apache/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-livy/tags","blobs_url":"https://api.github.com/repos/apache/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-livy/subscription","commits_url":"https://api.github.com/repos/apache/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-livy/merges","archive_url":"https://api.github.com/repos/apache/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-livy/downloads","issues_url":"https://api.github.com/repos/apache/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-livy/deployments","created_at":"2017-06-25T07:00:09Z","updated_at":"2017-10-29T07:02:35Z","pushed_at":"2017-11-03T05:28:07Z","git_url":"git://github.com/apache/incubator-livy.git","ssh_url":"git@github.com:apache/incubator-livy.git","clone_url":"https://github.com/apache/incubator-livy.git","svn_url":"https://github.com/apache/incubator-livy","homepage":null,"size":2816,"stargazers_count":36,"watchers_count":36,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":"git://git.apache.org/incubator-livy.git","archived":false,"open_issues_count":8,"forks":28,"open_issues":8,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/58"},"html":{"href":"https://github.com/apache/incubator-livy/pull/58"},"issue":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/58"},"comments":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-livy/statuses/408cc00014432a6aee2b19fb013cb43d836e371d"}},"author_association":"NONE"}}
{"actor":{"display_login":"shenh062326"}}