{"action":"created","comment":{"url":"https://api.github.com/repos/istio/api/pulls/comments/110725858","pull_request_review_id":31916804,"id":110725858,"diff_hunk":"@@ -47,21 +44,22 @@ message QuotaRequest {\n   // false, the exact requested amount is returned or 0 if not enough quota\n   // was available.\n   bool best_effort = 6;\n-}\n \n-message QuotaResponse {\n-  // Index of the request this response is associated with.\n+  // TO BE REMOVED\n   int64 request_index = 1;\n+}\n \n+message QuotaResponse {\n   // The attributes to use for this response\n-  Attributes attribute_update = 2;\n-\n-  // Indicates whether the quota request was successfully processed.\n-  google.rpc.Status result = 3 [(gogoproto.nullable) = false];","path":"mixer/v1/quota.proto","position":27,"original_position":27,"commit_id":"1544e3fb076bbcae742edd8df658528964b0e290","original_commit_id":"1544e3fb076bbcae742edd8df658528964b0e290","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars3.githubusercontent.com/u/11790727?v=3","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"WE are not passing status?   using amount=0 to indicate failure?","created_at":"2017-04-10T18:16:16Z","updated_at":"2017-04-10T18:25:22Z","html_url":"https://github.com/istio/api/pull/72#discussion_r110725858","pull_request_url":"https://api.github.com/repos/istio/api/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/comments/110725858"},"html":{"href":"https://github.com/istio/api/pull/72#discussion_r110725858"},"pull_request":{"href":"https://api.github.com/repos/istio/api/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/istio/api/pulls/72","id":114997457,"html_url":"https://github.com/istio/api/pull/72","diff_url":"https://github.com/istio/api/pull/72.diff","patch_url":"https://github.com/istio/api/pull/72.patch","issue_url":"https://api.github.com/repos/istio/api/issues/72","number":72,"state":"open","locked":false,"title":"Introduce unary mixer APIs.","user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars0.githubusercontent.com/u/22780957?v=3","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"body":"For now, all unary methods have a 2\r\nsuffix to allow implementation work to proceed side-by-side with\r\nthe existing API. Once work is complete in the mixer and mixer\r\nclient, then we can get rid of the streaming API definitions and\r\ndrop the 2 suffix on the unary definitions.\r\n\r\nThis API updates the attribute protocol to use both a global connection-level dictionary and a\r\nper-message dictionary, add supports for using the dictionary for attribute values in addition to\r\nusing it for attribute names. Finally, the new protocol doesn't provide delta\r\nsemantics, it's always all-or-nothing.","created_at":"2017-04-09T19:02:42Z","updated_at":"2017-04-10T18:25:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8e754200cc20f7df685ab3d7217af64385d5408","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/api/pulls/72/commits","review_comments_url":"https://api.github.com/repos/istio/api/pulls/72/comments","review_comment_url":"https://api.github.com/repos/istio/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/api/issues/72/comments","statuses_url":"https://api.github.com/repos/istio/api/statuses/1544e3fb076bbcae742edd8df658528964b0e290","head":{"label":"geeknoid:master","ref":"master","sha":"1544e3fb076bbcae742edd8df658528964b0e290","user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars0.githubusercontent.com/u/22780957?v=3","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"repo":{"id":76677121,"name":"api","full_name":"geeknoid/api","owner":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars0.githubusercontent.com/u/22780957?v=3","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geeknoid/api","description":"API, Config Definitions and Standard Vocabulary definitions for the istio project","fork":true,"url":"https://api.github.com/repos/geeknoid/api","forks_url":"https://api.github.com/repos/geeknoid/api/forks","keys_url":"https://api.github.com/repos/geeknoid/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geeknoid/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geeknoid/api/teams","hooks_url":"https://api.github.com/repos/geeknoid/api/hooks","issue_events_url":"https://api.github.com/repos/geeknoid/api/issues/events{/number}","events_url":"https://api.github.com/repos/geeknoid/api/events","assignees_url":"https://api.github.com/repos/geeknoid/api/assignees{/user}","branches_url":"https://api.github.com/repos/geeknoid/api/branches{/branch}","tags_url":"https://api.github.com/repos/geeknoid/api/tags","blobs_url":"https://api.github.com/repos/geeknoid/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geeknoid/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geeknoid/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/geeknoid/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geeknoid/api/statuses/{sha}","languages_url":"https://api.github.com/repos/geeknoid/api/languages","stargazers_url":"https://api.github.com/repos/geeknoid/api/stargazers","contributors_url":"https://api.github.com/repos/geeknoid/api/contributors","subscribers_url":"https://api.github.com/repos/geeknoid/api/subscribers","subscription_url":"https://api.github.com/repos/geeknoid/api/subscription","commits_url":"https://api.github.com/repos/geeknoid/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/geeknoid/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/geeknoid/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/geeknoid/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/geeknoid/api/contents/{+path}","compare_url":"https://api.github.com/repos/geeknoid/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geeknoid/api/merges","archive_url":"https://api.github.com/repos/geeknoid/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geeknoid/api/downloads","issues_url":"https://api.github.com/repos/geeknoid/api/issues{/number}","pulls_url":"https://api.github.com/repos/geeknoid/api/pulls{/number}","milestones_url":"https://api.github.com/repos/geeknoid/api/milestones{/number}","notifications_url":"https://api.github.com/repos/geeknoid/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geeknoid/api/labels{/name}","releases_url":"https://api.github.com/repos/geeknoid/api/releases{/id}","deployments_url":"https://api.github.com/repos/geeknoid/api/deployments","created_at":"2016-12-16T18:43:28Z","updated_at":"2016-12-16T19:20:24Z","pushed_at":"2017-04-10T17:15:17Z","git_url":"git://github.com/geeknoid/api.git","ssh_url":"git@github.com:geeknoid/api.git","clone_url":"https://github.com/geeknoid/api.git","svn_url":"https://github.com/geeknoid/api","homepage":null,"size":90,"stargazers_count":0,"watchers_count":0,"language":"Protocol Buffer","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"e28817b9d7ec1d61410638154a842f28a306c3a4","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config definitions and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2017-03-01T19:23:56Z","pushed_at":"2017-04-10T17:15:19Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":88,"stargazers_count":6,"watchers_count":6,"language":"Protocol Buffer","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":13,"forks":18,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/72"},"html":{"href":"https://github.com/istio/api/pull/72"},"issue":{"href":"https://api.github.com/repos/istio/api/issues/72"},"comments":{"href":"https://api.github.com/repos/istio/api/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/api/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/api/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/istio/api/statuses/1544e3fb076bbcae742edd8df658528964b0e290"}}}}
{"actor":{"display_login":"qiwzhang"}}