{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9632","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9632/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9632/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9632/events","html_url":"https://github.com/home-assistant/home-assistant/pull/9632","id":261873615,"number":9632,"title":"Google Actions for Assistant","user":{"login":"philk","id":29562,"avatar_url":"https://avatars1.githubusercontent.com/u/29562?v=4","gravatar_id":"","url":"https://api.github.com/users/philk","html_url":"https://github.com/philk","followers_url":"https://api.github.com/users/philk/followers","following_url":"https://api.github.com/users/philk/following{/other_user}","gists_url":"https://api.github.com/users/philk/gists{/gist_id}","starred_url":"https://api.github.com/users/philk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philk/subscriptions","organizations_url":"https://api.github.com/users/philk/orgs","repos_url":"https://api.github.com/users/philk/repos","events_url":"https://api.github.com/users/philk/events{/privacy}","received_events_url":"https://api.github.com/users/philk/received_events","type":"User","site_admin":false},"labels":[{"id":528349273,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-error","name":"cla-error","color":"ff0000","default":false},{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":514133558,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component","name":"component","color":"d4c5f9","default":false},{"id":707468894,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20googleactions","name":"component: googleactions","color":"ededed","default":false},{"id":546863056,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20http","name":"component: http","color":"ededed","default":false},{"id":451931292,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":526146744,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2017-09-30T21:29:59Z","updated_at":"2017-10-17T01:33:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9632","html_url":"https://github.com/home-assistant/home-assistant/pull/9632","diff_url":"https://github.com/home-assistant/home-assistant/pull/9632.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/9632.patch"},"body":"## Description:\r\n\r\nI'm looking for some feedback on this both as a component and as a specific implementation.\r\n\r\nThe current `emulated_hue` implementation can only work with either the Echo or Google Home, but not both at the same time so I took some of the ideas from the Alexa component.\r\n\r\nGoogle provides a [Smart Home API](https://developers.google.com/actions/smarthome/create-app) for interacting with Google Assistant. It's a relatively straightforward API that just requires some mapping of Home-Assistant objects to a [couple of schemas](https://developers.google.com/actions/smarthome/light-schema). I think that part all makes sense and is a reasonable component for hass. I will acknowledge there was a lot of copy paste from the hue and Alexa components to figure out how aiohttp works. Happy to take feedback on the /right/ way to do things for sure 😅\r\n\r\nWhere I'm most looking for feedback though is really UX, basically the Google Actions deploy and setup process.  You have to [set up OAuth](https://developers.google.com/actions/smarthome/create-app#set_up_an_oauth_20_server) for your action to authenticate against and the way I did it is...hacky to say the least. I'm really curious what the path forward for the [Cloud Auth](https://github.com/home-assistant/home-assistant/tree/dev/homeassistant/components/cloud) stuff is but right now it looks pretty AWS specific and more for handling login to hass rather than being an OAuth provider.\r\n\r\nI'm also not super happy with having to ask people to go through the [setup steps](https://developers.google.com/actions/smarthome/testing-deploying) for creating an app in GCP. We could probably break it down to:\r\n\r\n1. Download Google's gactions tool\r\n2. Copy a json file and fill in some fields\r\n3. Run the `gactions test` command with the json file\r\n\r\nWhich isn't /too/ bad but doesn't feel as user friendly as hass has gotten lately (OMG, not having to deal with Zwave compilation and install, life saving).\r\n\r\n\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) (TODO)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/337091062","html_url":"https://github.com/home-assistant/home-assistant/pull/9632#issuecomment-337091062","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9632","id":337091062,"user":{"login":"cnrd","id":5996053,"avatar_url":"https://avatars0.githubusercontent.com/u/5996053?v=4","gravatar_id":"","url":"https://api.github.com/users/cnrd","html_url":"https://github.com/cnrd","followers_url":"https://api.github.com/users/cnrd/followers","following_url":"https://api.github.com/users/cnrd/following{/other_user}","gists_url":"https://api.github.com/users/cnrd/gists{/gist_id}","starred_url":"https://api.github.com/users/cnrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnrd/subscriptions","organizations_url":"https://api.github.com/users/cnrd/orgs","repos_url":"https://api.github.com/users/cnrd/repos","events_url":"https://api.github.com/users/cnrd/events{/privacy}","received_events_url":"https://api.github.com/users/cnrd/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T01:33:22Z","updated_at":"2017-10-17T01:33:22Z","author_association":"CONTRIBUTOR","body":"@philk thanks for WIP guide, now it goes through the auth process, but unfortunately it just kicks me back to the \"Home Control\" screen without the \"app\" setup.\r\n\r\nI have sent you a couple of screenshots and a video of the behavior in a PM on Discord, I really hope that you have a minute to look at those and see if there is anything wrong with my setup :-)\r\n\r\nPeople want it really badly now, as emulated_hue has stopped working for the Google Home, so this is currently the only thing that looks like it could get the Google Home to control stuff again ;-)"}}
{"actor":{"display_login":"cnrd"}}