{"action":"created","issue":{"url":"https://api.github.com/repos/opentable/design-tokens/issues/52","repository_url":"https://api.github.com/repos/opentable/design-tokens","labels_url":"https://api.github.com/repos/opentable/design-tokens/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/opentable/design-tokens/issues/52/comments","events_url":"https://api.github.com/repos/opentable/design-tokens/issues/52/events","html_url":"https://github.com/opentable/design-tokens/issues/52","id":264341757,"number":52,"title":"Color Naming","user":{"login":"cbeley","id":4041776,"avatar_url":"https://avatars1.githubusercontent.com/u/4041776?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeley","html_url":"https://github.com/cbeley","followers_url":"https://api.github.com/users/cbeley/followers","following_url":"https://api.github.com/users/cbeley/following{/other_user}","gists_url":"https://api.github.com/users/cbeley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeley/subscriptions","organizations_url":"https://api.github.com/users/cbeley/orgs","repos_url":"https://api.github.com/users/cbeley/repos","events_url":"https://api.github.com/users/cbeley/events{/privacy}","received_events_url":"https://api.github.com/users/cbeley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-10-10T19:07:13Z","updated_at":"2017-10-27T17:46:52Z","closed_at":null,"author_association":"NONE","body":"The current names of our colors seem a bit awkward and not consistent.  We use color-primary, which seems to imply how it is used, without being generically usable.  But then we have a set of gray's which breaks that convention.\r\n\r\nInstead of going into full details here, I'd recommend reading https://davidwalsh.name/sass-color-variables-dont-suck .  For mobile-web-frontend, we adopted a similar approach, though ended up using color numbers (https://github.com/opentable/mobile-web-frontend/blob/develop/statics/scss/_colors.scss ...though, there shouldn't be so many greens and blues..that was not design approved).\r\n\r\nTLDR:  I'm a fan of David Walsh's approach to the problem (though, I'm not inherently opposed to the pattern mobile web took).  We have tools to replace all colors of a certain type if need be and it's not very obvious when reading code what $colorPrimary is."},"comment":{"url":"https://api.github.com/repos/opentable/design-tokens/issues/comments/340039009","html_url":"https://github.com/opentable/design-tokens/issues/52#issuecomment-340039009","issue_url":"https://api.github.com/repos/opentable/design-tokens/issues/52","id":340039009,"user":{"login":"mannionaco","id":28025024,"avatar_url":"https://avatars3.githubusercontent.com/u/28025024?v=4","gravatar_id":"","url":"https://api.github.com/users/mannionaco","html_url":"https://github.com/mannionaco","followers_url":"https://api.github.com/users/mannionaco/followers","following_url":"https://api.github.com/users/mannionaco/following{/other_user}","gists_url":"https://api.github.com/users/mannionaco/gists{/gist_id}","starred_url":"https://api.github.com/users/mannionaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mannionaco/subscriptions","organizations_url":"https://api.github.com/users/mannionaco/orgs","repos_url":"https://api.github.com/users/mannionaco/repos","events_url":"https://api.github.com/users/mannionaco/events{/privacy}","received_events_url":"https://api.github.com/users/mannionaco/received_events","type":"User","site_admin":false},"created_at":"2017-10-27T17:46:52Z","updated_at":"2017-10-27T17:46:52Z","author_association":"COLLABORATOR","body":"Logically the suggested proposal makes a lot of sense. Looking at the Salesforce's design token list, the items are granular and design wants to make sure that our naming of components and instances is in alignment to maintain a common language within our teams. I can foresee naming getting a bit out of hand, though I don't think it'll be a major problem, at the expense of having common naming for color where there is a control.\r\n\r\n@francesyun and I are in alignment with this proposal and are wondering if @morewry @cbeley want to see an example list with naming to make sure we are all on the same page. Sound good?"}}
{"actor":{"display_login":"mannionaco"}}