{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/133220235","pull_request_review_id":56375436,"id":133220235,"diff_hunk":"@@ -13,36 +13,31 @@\n  * See the License for the specific language governing permissions and\n  * limitations under the License.\n  */\n-\n package org.gradle.internal.time;\n \n-public class Clock implements Timer {\n-    private long startTime;\n-    private long startInstant;\n-    private TimeProvider timeProvider;\n+import java.util.concurrent.TimeUnit;\n \n+public class DefaultTimer implements Timer {","path":"subprojects/base-services/src/main/java/org/gradle/internal/time/DefaultTimer.java","position":20,"original_position":20,"commit_id":"2dc7b80cb192d1d099422be549c04a000478eaa3","original_commit_id":"433cb84e11f018bc4f6ed1784a66ca42c680c462","user":{"login":"bigdaz","id":179734,"avatar_url":"https://avatars3.githubusercontent.com/u/179734?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdaz","html_url":"https://github.com/bigdaz","followers_url":"https://api.github.com/users/bigdaz/followers","following_url":"https://api.github.com/users/bigdaz/following{/other_user}","gists_url":"https://api.github.com/users/bigdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdaz/subscriptions","organizations_url":"https://api.github.com/users/bigdaz/orgs","repos_url":"https://api.github.com/users/bigdaz/repos","events_url":"https://api.github.com/users/bigdaz/events{/privacy}","received_events_url":"https://api.github.com/users/bigdaz/received_events","type":"User","site_admin":false},"body":"Done: https://github.com/gradle/gradle/pull/2698/commits/2dc7b80cb192d1d099422be549c04a000478eaa3","created_at":"2017-08-15T15:27:45Z","updated_at":"2017-08-15T15:27:45Z","html_url":"https://github.com/gradle/gradle/pull/2698#discussion_r133220235","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/2698","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/133220235"},"html":{"href":"https://github.com/gradle/gradle/pull/2698#discussion_r133220235"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2698"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/2698","id":135175993,"html_url":"https://github.com/gradle/gradle/pull/2698","diff_url":"https://github.com/gradle/gradle/pull/2698.diff","patch_url":"https://github.com/gradle/gradle/pull/2698.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/2698","number":2698,"state":"open","locked":false,"title":"Use a shared, nanoTime-backed `TimeProvider` where possible","user":{"login":"bigdaz","id":179734,"avatar_url":"https://avatars3.githubusercontent.com/u/179734?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdaz","html_url":"https://github.com/bigdaz","followers_url":"https://api.github.com/users/bigdaz/followers","following_url":"https://api.github.com/users/bigdaz/following{/other_user}","gists_url":"https://api.github.com/users/bigdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdaz/subscriptions","organizations_url":"https://api.github.com/users/bigdaz/orgs","repos_url":"https://api.github.com/users/bigdaz/repos","events_url":"https://api.github.com/users/bigdaz/events{/privacy}","received_events_url":"https://api.github.com/users/bigdaz/received_events","type":"User","site_admin":false},"body":"Many services in Gradle require access to wall-clock time, and the `TimeProvider` interface is used for this purpose. However, the primary implementation (`TrueTimeProvider`) relied on `System.currentTimeMillis()`, which suffers both from low precision and accuracy.\r\n\r\nTo address this, and number of changes were made:\r\n- Add a new `ReliableTimeProvider` which produces ms timestamps based on a ms start time and the elapsed time from `System.nanoTime()`.\r\n- Since `ReliableTimeProvider` being 'reliable' depends on a single instance with a common start time, use a global instance in each started process.\r\n- Move `TrueTimeProvider` to test fixtures: it should not be used in production code.","created_at":"2017-08-10T17:07:07Z","updated_at":"2017-08-15T15:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1e5288f96619a697b7f2eeb2bd3c9172db2b6b8","assignee":{"login":"bigdaz","id":179734,"avatar_url":"https://avatars3.githubusercontent.com/u/179734?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdaz","html_url":"https://github.com/bigdaz","followers_url":"https://api.github.com/users/bigdaz/followers","following_url":"https://api.github.com/users/bigdaz/following{/other_user}","gists_url":"https://api.github.com/users/bigdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdaz/subscriptions","organizations_url":"https://api.github.com/users/bigdaz/orgs","repos_url":"https://api.github.com/users/bigdaz/repos","events_url":"https://api.github.com/users/bigdaz/events{/privacy}","received_events_url":"https://api.github.com/users/bigdaz/received_events","type":"User","site_admin":false},"assignees":[{"login":"bigdaz","id":179734,"avatar_url":"https://avatars3.githubusercontent.com/u/179734?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdaz","html_url":"https://github.com/bigdaz","followers_url":"https://api.github.com/users/bigdaz/followers","following_url":"https://api.github.com/users/bigdaz/following{/other_user}","gists_url":"https://api.github.com/users/bigdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdaz/subscriptions","organizations_url":"https://api.github.com/users/bigdaz/orgs","repos_url":"https://api.github.com/users/bigdaz/repos","events_url":"https://api.github.com/users/bigdaz/events{/privacy}","received_events_url":"https://api.github.com/users/bigdaz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/2698/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/2698/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/2698/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/2dc7b80cb192d1d099422be549c04a000478eaa3","head":{"label":"gradle:dd/buildscans/time","ref":"dd/buildscans/time","sha":"2dc7b80cb192d1d099422be549c04a000478eaa3","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-08-15T09:36:20Z","pushed_at":"2017-08-15T15:27:07Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":175062,"stargazers_count":5291,"watchers_count":5291,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1842,"mirror_url":null,"open_issues_count":746,"forks":1842,"open_issues":746,"watchers":5291,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"c82429b342acf5c4ae14e336cf376f41452d8ce8","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-08-15T09:36:20Z","pushed_at":"2017-08-15T15:27:07Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":175062,"stargazers_count":5291,"watchers_count":5291,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1842,"mirror_url":null,"open_issues_count":746,"forks":1842,"open_issues":746,"watchers":5291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2698"},"html":{"href":"https://github.com/gradle/gradle/pull/2698"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/2698"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/2698/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2698/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2698/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/2dc7b80cb192d1d099422be549c04a000478eaa3"}}}}
{"actor":{"display_login":"bigdaz"}}