{"action":"created","issue":{"url":"https://api.github.com/repos/nathancahill/Split.js/issues/73","repository_url":"https://api.github.com/repos/nathancahill/Split.js","labels_url":"https://api.github.com/repos/nathancahill/Split.js/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/nathancahill/Split.js/issues/73/comments","events_url":"https://api.github.com/repos/nathancahill/Split.js/issues/73/events","html_url":"https://github.com/nathancahill/Split.js/issues/73","id":206423839,"number":73,"title":"Panel sometimes gets pushed underneath gutter","user":{"login":"weltschmerz1","id":2866749,"avatar_url":"https://avatars1.githubusercontent.com/u/2866749?v=3","gravatar_id":"","url":"https://api.github.com/users/weltschmerz1","html_url":"https://github.com/weltschmerz1","followers_url":"https://api.github.com/users/weltschmerz1/followers","following_url":"https://api.github.com/users/weltschmerz1/following{/other_user}","gists_url":"https://api.github.com/users/weltschmerz1/gists{/gist_id}","starred_url":"https://api.github.com/users/weltschmerz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltschmerz1/subscriptions","organizations_url":"https://api.github.com/users/weltschmerz1/orgs","repos_url":"https://api.github.com/users/weltschmerz1/repos","events_url":"https://api.github.com/users/weltschmerz1/events{/privacy}","received_events_url":"https://api.github.com/users/weltschmerz1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-09T07:13:37Z","updated_at":"2017-04-12T16:39:23Z","closed_at":null,"body":"I haven't tested this much, but it seems that depending on the gutter width and the window width, sometimes the panel width plus gutter width adds up to more than 100%, which ends up pushing the panel underneath the gutter.\r\n\r\nConsider a case with two panels that are split next to each other. For me, this has happened only when collapsing the left panel all the way to 0. Curiously, collapsing the right pane completely did not reproduce the issue.\r\n\r\nInitial state:\r\n\r\n```\r\n                     ↓ gutter\r\nxxxxxxxxxxxxxxxxxx   |   xxxxxxxxxxxxxxxxxx\r\nx                    |                    x\r\nx    left panel      |      right panel   x\r\nx                    |                    x\r\nxxxxxxxxxxxxxxxxxx   |   xxxxxxxxxxxxxxxxxx\r\n```\r\n\r\nThen I drag the gutter all the way to the left, which hides the left panel.\r\n\r\nDesired result:\r\n\r\n```\r\n↓ gutter (left panel hidden)\r\n| xxxxxxxxxxxxxxxxxx\r\n|                  x\r\n|  right panel     x\r\n|                  x\r\n| xxxxxxxxxxxxxxxxxx\r\n```\r\n\r\nActual result:\r\n\r\n```\r\n↓ gutter (left panel hidden)\r\n|\r\n|\r\n|\r\n|\r\n|\r\nxxxxxxxxxxxxxxxxxx\r\n                 x\r\n   right panel   x         (right panel pushed underneath gutter)\r\n                 x\r\nxxxxxxxxxxxxxxxxxx\r\n```\r\n\r\nThe thing about the gutter and the right panel adding up to more than 100% width is just my initial intuition and it could obviously be something else altogether.\r\n\r\nFor now, my temporary solution was to set the gutter width to one pixel smaller using css:\r\n\r\n```css\r\n.gutter.gutter-horizontal {\r\n  width: 9px !important;\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/nathancahill/Split.js/issues/comments/293637167","html_url":"https://github.com/nathancahill/Split.js/issues/73#issuecomment-293637167","issue_url":"https://api.github.com/repos/nathancahill/Split.js/issues/73","id":293637167,"user":{"login":"sanleong","id":1580031,"avatar_url":"https://avatars2.githubusercontent.com/u/1580031?v=3","gravatar_id":"","url":"https://api.github.com/users/sanleong","html_url":"https://github.com/sanleong","followers_url":"https://api.github.com/users/sanleong/followers","following_url":"https://api.github.com/users/sanleong/following{/other_user}","gists_url":"https://api.github.com/users/sanleong/gists{/gist_id}","starred_url":"https://api.github.com/users/sanleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanleong/subscriptions","organizations_url":"https://api.github.com/users/sanleong/orgs","repos_url":"https://api.github.com/users/sanleong/repos","events_url":"https://api.github.com/users/sanleong/events{/privacy}","received_events_url":"https://api.github.com/users/sanleong/received_events","type":"User","site_admin":false},"created_at":"2017-04-12T16:39:22Z","updated_at":"2017-04-12T16:39:22Z","body":"Thanks for the feedback.\r\nReally appreciated.\r\n\r\nRegards,\r\nGilberto Leon\r\n\r\nOn Apr 12, 2017, at 12:44 AM, Nathan Cahill <notifications@github.com<mailto:notifications@github.com>> wrote:\r\n\r\n\r\nHaven't been able to find a clean solution to this. It tricky because of the floating-point math when dividing by 3 and summing up to 100%. Will keep working on it.\r\n\r\n—\r\nYou are receiving this because you commented.\r\nReply to this email directly, view it on GitHub<https://github.com/nathancahill/Split.js/issues/73#issuecomment-293472646>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABgb__cCkkFObuwL8tKBpqEyJPst94Kyks5rvFaRgaJpZM4L7yQn>.\r\n"}}
{"actor":{"display_login":"sanleong"}}