{"action":"created","issue":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/120","repository_url":"https://api.github.com/repos/nanoframework/nf-interpreter","labels_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/120/comments","events_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/120/events","html_url":"https://github.com/nanoframework/nf-interpreter/pull/120","id":207865995,"number":120,"title":"Fix definitions for VERSION and OEM strings","user":{"login":"josesimoes","id":1881520,"avatar_url":"https://avatars.githubusercontent.com/u/1881520?v=3","gravatar_id":"","url":"https://api.github.com/users/josesimoes","html_url":"https://github.com/josesimoes","followers_url":"https://api.github.com/users/josesimoes/followers","following_url":"https://api.github.com/users/josesimoes/following{/other_user}","gists_url":"https://api.github.com/users/josesimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/josesimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josesimoes/subscriptions","organizations_url":"https://api.github.com/users/josesimoes/orgs","repos_url":"https://api.github.com/users/josesimoes/repos","events_url":"https://api.github.com/users/josesimoes/events{/privacy}","received_events_url":"https://api.github.com/users/josesimoes/received_events","type":"User","site_admin":false},"labels":[{"id":507617446,"url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels/area-Config-and-Build","name":"area-Config-and-Build","color":"d4c5f9","default":false},{"id":539183251,"url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels/DCO-check-valid","name":"DCO-check-valid","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-15T17:06:27Z","updated_at":"2017-02-16T13:48:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/120","html_url":"https://github.com/nanoframework/nf-interpreter/pull/120","diff_url":"https://github.com/nanoframework/nf-interpreter/pull/120.diff","patch_url":"https://github.com/nanoframework/nf-interpreter/pull/120.patch"},"body":"- these preprocessor definitions are now defined in project properties\r\n(because for native compilation these are set at target/board level)\r\n\r\nSigned-off-by: José Simões <jose.simoes@eclo.solutions>"},"comment":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/comments/280334558","html_url":"https://github.com/nanoframework/nf-interpreter/pull/120#issuecomment-280334558","issue_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/120","id":280334558,"user":{"login":"josesimoes","id":1881520,"avatar_url":"https://avatars.githubusercontent.com/u/1881520?v=3","gravatar_id":"","url":"https://api.github.com/users/josesimoes","html_url":"https://github.com/josesimoes","followers_url":"https://api.github.com/users/josesimoes/followers","following_url":"https://api.github.com/users/josesimoes/following{/other_user}","gists_url":"https://api.github.com/users/josesimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/josesimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josesimoes/subscriptions","organizations_url":"https://api.github.com/users/josesimoes/orgs","repos_url":"https://api.github.com/users/josesimoes/repos","events_url":"https://api.github.com/users/josesimoes/events{/privacy}","received_events_url":"https://api.github.com/users/josesimoes/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T13:48:54Z","updated_at":"2017-02-16T13:48:54Z","body":"The fact that those should be set at platform or board level.\r\nYou had to add those there in order to build the debugger project, I guess that's why there is a note there mentioning that those come from platfom_selector.h\r\nThose version numbers are already available in the build, so they should be used from there I guess.\r\nBtw, this is the way the the problem is solved in NETMF equivalent project."}}
{"actor":{"display_login":"josesimoes"}}