{"action":"closed","number":24824,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/24824","id":150723606,"html_url":"https://github.com/symfony/symfony/pull/24824","diff_url":"https://github.com/symfony/symfony/pull/24824.diff","patch_url":"https://github.com/symfony/symfony/pull/24824.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/24824","number":24824,"state":"closed","locked":false,"title":"[FrameworkBundle][Config] fix: do not add resource checkers for no-debug","user":{"login":"dmaicher","id":921145,"avatar_url":"https://avatars3.githubusercontent.com/u/921145?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaicher","html_url":"https://github.com/dmaicher","followers_url":"https://api.github.com/users/dmaicher/followers","following_url":"https://api.github.com/users/dmaicher/following{/other_user}","gists_url":"https://api.github.com/users/dmaicher/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaicher/subscriptions","organizations_url":"https://api.github.com/users/dmaicher/orgs","repos_url":"https://api.github.com/users/dmaicher/repos","events_url":"https://api.github.com/users/dmaicher/events{/privacy}","received_events_url":"https://api.github.com/users/dmaicher/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.4\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #24808\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nAs mentioned within #24808 replacing the `ConfigCachePass` here https://github.com/symfony/symfony/compare/537c496dfee1d04aab832f8441f8b6cfe7dc2af5...a442e378e18d399e942bcffe0c2e960fcdc0b53f#diff-687bdbb38a4dc672ca2a79f23e764892L127 with a tagged iterator argument resulted in resource checkers being added even if debug=false.\r\n\r\nThis resulted in a performance drop as on every request all the checkers have been checked.\r\n\r\nThis restores the previous behavior and does not add any checkers if debug=false.","created_at":"2017-11-05T14:00:30Z","updated_at":"2017-11-05T15:34:33Z","closed_at":"2017-11-05T15:34:33Z","merged_at":"2017-11-05T15:34:32Z","merge_commit_sha":"645f7121901841699bee1dcdd9dda8aa48bbac97","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":456,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2017-11-05T15:34:33Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/24824/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/24824/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/24824/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/645f7121901841699bee1dcdd9dda8aa48bbac97","head":{"label":"dmaicher:fix-24808","ref":"fix-24808","sha":"645f7121901841699bee1dcdd9dda8aa48bbac97","user":{"login":"dmaicher","id":921145,"avatar_url":"https://avatars3.githubusercontent.com/u/921145?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaicher","html_url":"https://github.com/dmaicher","followers_url":"https://api.github.com/users/dmaicher/followers","following_url":"https://api.github.com/users/dmaicher/following{/other_user}","gists_url":"https://api.github.com/users/dmaicher/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaicher/subscriptions","organizations_url":"https://api.github.com/users/dmaicher/orgs","repos_url":"https://api.github.com/users/dmaicher/repos","events_url":"https://api.github.com/users/dmaicher/events{/privacy}","received_events_url":"https://api.github.com/users/dmaicher/received_events","type":"User","site_admin":false},"repo":{"id":49979116,"name":"symfony","full_name":"dmaicher/symfony","owner":{"login":"dmaicher","id":921145,"avatar_url":"https://avatars3.githubusercontent.com/u/921145?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaicher","html_url":"https://github.com/dmaicher","followers_url":"https://api.github.com/users/dmaicher/followers","following_url":"https://api.github.com/users/dmaicher/following{/other_user}","gists_url":"https://api.github.com/users/dmaicher/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaicher/subscriptions","organizations_url":"https://api.github.com/users/dmaicher/orgs","repos_url":"https://api.github.com/users/dmaicher/repos","events_url":"https://api.github.com/users/dmaicher/events{/privacy}","received_events_url":"https://api.github.com/users/dmaicher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmaicher/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/dmaicher/symfony","forks_url":"https://api.github.com/repos/dmaicher/symfony/forks","keys_url":"https://api.github.com/repos/dmaicher/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmaicher/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmaicher/symfony/teams","hooks_url":"https://api.github.com/repos/dmaicher/symfony/hooks","issue_events_url":"https://api.github.com/repos/dmaicher/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/dmaicher/symfony/events","assignees_url":"https://api.github.com/repos/dmaicher/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/dmaicher/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/dmaicher/symfony/tags","blobs_url":"https://api.github.com/repos/dmaicher/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmaicher/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmaicher/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmaicher/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmaicher/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/dmaicher/symfony/languages","stargazers_url":"https://api.github.com/repos/dmaicher/symfony/stargazers","contributors_url":"https://api.github.com/repos/dmaicher/symfony/contributors","subscribers_url":"https://api.github.com/repos/dmaicher/symfony/subscribers","subscription_url":"https://api.github.com/repos/dmaicher/symfony/subscription","commits_url":"https://api.github.com/repos/dmaicher/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmaicher/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmaicher/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmaicher/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmaicher/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/dmaicher/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmaicher/symfony/merges","archive_url":"https://api.github.com/repos/dmaicher/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmaicher/symfony/downloads","issues_url":"https://api.github.com/repos/dmaicher/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/dmaicher/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/dmaicher/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/dmaicher/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmaicher/symfony/labels{/name}","releases_url":"https://api.github.com/repos/dmaicher/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/dmaicher/symfony/deployments","created_at":"2016-01-19T19:57:37Z","updated_at":"2016-01-19T19:57:51Z","pushed_at":"2017-11-05T13:56:33Z","git_url":"git://github.com/dmaicher/symfony.git","ssh_url":"git@github.com:dmaicher/symfony.git","clone_url":"https://github.com/dmaicher/symfony.git","svn_url":"https://github.com/dmaicher/symfony","homepage":"symfony.com","size":101451,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:3.4","ref":"3.4","sha":"e973c247c8acd032a5ee72418452c3a255d5e321","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-11-05T14:34:32Z","pushed_at":"2017-11-05T15:34:22Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":105758,"stargazers_count":15495,"watchers_count":15495,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5787,"mirror_url":null,"archived":false,"open_issues_count":822,"forks":5787,"open_issues":822,"watchers":15495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24824"},"html":{"href":"https://github.com/symfony/symfony/pull/24824"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/24824"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/24824/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24824/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24824/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/645f7121901841699bee1dcdd9dda8aa48bbac97"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fabpot","id":47313,"avatar_url":"https://avatars3.githubusercontent.com/u/47313?v=4","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"fabpot"}}