{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/154288147","pull_request_review_id":80428404,"id":154288147,"diff_hunk":"@@ -60,6 +59,7 @@ struct ObjectProperties\n \tstd::string wield_item;\n \tbool static_save = true;\n \tfloat eye_height = 1.625f;\n+\tfloat zoom_fov = 15.0f;","path":"src/object_properties.h","position":12,"original_position":12,"commit_id":"14a33db863cfa30338162eb9cf2a75232ef57525","original_commit_id":"14a33db863cfa30338162eb9cf2a75232ef57525","user":{"login":"SmallJoker","id":1497498,"avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"This means the server will force a zoom fov of 15 as soon the ObjectProperties are sent to the server. The client has no control about the limits.","created_at":"2017-12-01T08:20:21Z","updated_at":"2017-12-01T08:20:21Z","html_url":"https://github.com/minetest/minetest/pull/6650#discussion_r154288147","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/6650","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/154288147"},"html":{"href":"https://github.com/minetest/minetest/pull/6650#discussion_r154288147"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6650"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/6650","id":153530888,"html_url":"https://github.com/minetest/minetest/pull/6650","diff_url":"https://github.com/minetest/minetest/pull/6650.diff","patch_url":"https://github.com/minetest/minetest/pull/6650.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/6650","number":6650,"state":"open","locked":false,"title":"Zoom: Set zoom FOV per-player using a player object property","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"Change the player object property 'can zoom' to 'zoom fov'.\r\nOnly allow the client's settings to choose a limited range of zoom FOV,\r\na more powerful zoom can only be set by server mods.\r\n\r\nNeeded due to zoom now loading in distant world according to zoom FOV.\r\n///////////////\r\n\r\nMerge https://github.com/minetest/minetest_game/pull/1956 soon after this.\r\n\r\nTogether with lhofhansl's recent work this will allow a game to provide an item which enables a particular zoom FOV, which in turn allows a certain distance of world to be loaded in when using zoom.\r\nFor example a powerful telescope item that allows a zoom FOV of 1 degree, which is capable of loading (and/or generating) world 2000 nodes away.\r\n\r\nA server mod can still disable zooming for a player by setting zoom FOV to 0. So the functionality of the previous 'can zoom' property is kept.\r\n\r\n@lhofhansl ","created_at":"2017-11-20T02:08:37Z","updated_at":"2017-12-01T08:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f399a79ed1a6afb693676eb0f1603adddcb528da","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/6650/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/6650/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/6650/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/14a33db863cfa30338162eb9cf2a75232ef57525","head":{"label":"paramat:zoomfovpop","ref":"zoomfovpop","sha":"14a33db863cfa30338162eb9cf2a75232ef57525","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"repo":{"id":25287736,"name":"minetest","full_name":"paramat/minetest","owner":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paramat/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/paramat/minetest","forks_url":"https://api.github.com/repos/paramat/minetest/forks","keys_url":"https://api.github.com/repos/paramat/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paramat/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paramat/minetest/teams","hooks_url":"https://api.github.com/repos/paramat/minetest/hooks","issue_events_url":"https://api.github.com/repos/paramat/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/paramat/minetest/events","assignees_url":"https://api.github.com/repos/paramat/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/paramat/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/paramat/minetest/tags","blobs_url":"https://api.github.com/repos/paramat/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paramat/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paramat/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/paramat/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paramat/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/paramat/minetest/languages","stargazers_url":"https://api.github.com/repos/paramat/minetest/stargazers","contributors_url":"https://api.github.com/repos/paramat/minetest/contributors","subscribers_url":"https://api.github.com/repos/paramat/minetest/subscribers","subscription_url":"https://api.github.com/repos/paramat/minetest/subscription","commits_url":"https://api.github.com/repos/paramat/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/paramat/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/paramat/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/paramat/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/paramat/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/paramat/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paramat/minetest/merges","archive_url":"https://api.github.com/repos/paramat/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paramat/minetest/downloads","issues_url":"https://api.github.com/repos/paramat/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/paramat/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/paramat/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/paramat/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paramat/minetest/labels{/name}","releases_url":"https://api.github.com/repos/paramat/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/paramat/minetest/deployments","created_at":"2014-10-16T05:25:29Z","updated_at":"2016-10-24T04:29:17Z","pushed_at":"2017-12-01T00:47:46Z","git_url":"git://github.com/paramat/minetest.git","ssh_url":"git@github.com:paramat/minetest.git","clone_url":"https://github.com/paramat/minetest.git","svn_url":"https://github.com/paramat/minetest","homepage":"http://minetest.net/","size":53659,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"ea1ae07beb4c65b29a356c64971e49249f7c5118","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine and game with survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2017-12-01T04:21:44Z","pushed_at":"2017-12-01T06:26:08Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":53997,"stargazers_count":2948,"watchers_count":2948,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":855,"mirror_url":null,"archived":false,"open_issues_count":896,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":855,"open_issues":896,"watchers":2948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6650"},"html":{"href":"https://github.com/minetest/minetest/pull/6650"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/6650"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/6650/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6650/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6650/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/14a33db863cfa30338162eb9cf2a75232ef57525"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SmallJoker"}}