{"action":"created","issue":{"url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/50","repository_url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson","labels_url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/50/comments","events_url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/50/events","html_url":"https://github.com/whitequark/ppx_deriving_yojson/pull/50","id":221006509,"number":50,"title":"Support record variants","user":{"login":"gerdstolpmann","id":1489498,"avatar_url":"https://avatars3.githubusercontent.com/u/1489498?v=3","gravatar_id":"","url":"https://api.github.com/users/gerdstolpmann","html_url":"https://github.com/gerdstolpmann","followers_url":"https://api.github.com/users/gerdstolpmann/followers","following_url":"https://api.github.com/users/gerdstolpmann/following{/other_user}","gists_url":"https://api.github.com/users/gerdstolpmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gerdstolpmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerdstolpmann/subscriptions","organizations_url":"https://api.github.com/users/gerdstolpmann/orgs","repos_url":"https://api.github.com/users/gerdstolpmann/repos","events_url":"https://api.github.com/users/gerdstolpmann/events{/privacy}","received_events_url":"https://api.github.com/users/gerdstolpmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-11T16:20:12Z","updated_at":"2017-04-11T16:51:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/pulls/50","html_url":"https://github.com/whitequark/ppx_deriving_yojson/pull/50","diff_url":"https://github.com/whitequark/ppx_deriving_yojson/pull/50.diff","patch_url":"https://github.com/whitequark/ppx_deriving_yojson/pull/50.patch"},"body":"For example,  `type t = X of { field : typ }`\r\n\r\nNo support, though, if these variants are used in extensible types\r\n(`type t = ..;; type t += X of { field : typ }`)\r\n\r\nChanges in the serializer: I factored out the code generating the code for records (into `ser_str_of_record`).  The name of the variable - formerly always \"x\" - is now an argument.\r\n\r\nChanges in the deserializer: Similarly, there is now also `desu_str_of_record`. The code allows it to wrap the record, because for record variants the name of the variant needs to be inserted somehow (we generate `X { field = ... }` instead of just `{ field = ... }` in the record variant case)."},"comment":{"url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/comments/293325795","html_url":"https://github.com/whitequark/ppx_deriving_yojson/pull/50#issuecomment-293325795","issue_url":"https://api.github.com/repos/whitequark/ppx_deriving_yojson/issues/50","id":293325795,"user":{"login":"gerdstolpmann","id":1489498,"avatar_url":"https://avatars3.githubusercontent.com/u/1489498?v=3","gravatar_id":"","url":"https://api.github.com/users/gerdstolpmann","html_url":"https://github.com/gerdstolpmann","followers_url":"https://api.github.com/users/gerdstolpmann/followers","following_url":"https://api.github.com/users/gerdstolpmann/following{/other_user}","gists_url":"https://api.github.com/users/gerdstolpmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gerdstolpmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerdstolpmann/subscriptions","organizations_url":"https://api.github.com/users/gerdstolpmann/orgs","repos_url":"https://api.github.com/users/gerdstolpmann/repos","events_url":"https://api.github.com/users/gerdstolpmann/events{/privacy}","received_events_url":"https://api.github.com/users/gerdstolpmann/received_events","type":"User","site_admin":false},"created_at":"2017-04-11T16:51:25Z","updated_at":"2017-04-11T16:51:25Z","body":"Tried to address the requested changes. Hope it is good now."}}
{"actor":{"display_login":"gerdstolpmann"}}