{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments/124586107","pull_request_review_id":46889672,"id":124586107,"diff_hunk":"@@ -99,7 +99,7 @@ func (cfg *Config) ParseFlags(args []string) error {\n \t// Flags related to providers\n \tapp.Flag(\"provider\", \"The DNS provider where the DNS records will be created (required, options: aws, google, azure, cloudflare, digitalocean, inmemory)\").Required().PlaceHolder(\"provider\").EnumVar(&cfg.Provider, \"aws\", \"google\", \"azure\", \"cloudflare\", \"digitalocean\", \"inmemory\")\n \tapp.Flag(\"google-project\", \"When using the Google provider, specify the Google project (required when --provider=google)\").Default(defaultConfig.GoogleProject).StringVar(&cfg.GoogleProject)\n-\tapp.Flag(\"domain-filter\", \"Limit possible target zones by a domain suffix (optional)\").Default(defaultConfig.DomainFilter).StringVar(&cfg.DomainFilter)\n+\tapp.Flag(\"domain-filter\", \"Limit possible target zones by a comma separeted list of domain suffixes (optional)\").Default(defaultConfig.DomainFilter).StringVar(&cfg.DomainFilter)","path":"pkg/apis/externaldns/types.go","position":5,"original_position":5,"commit_id":"7f31af34c6a0197b01ec542923ae2ae121e0c635","original_commit_id":"7f31af34c6a0197b01ec542923ae2ae121e0c635","user":{"login":"linki","id":36162,"avatar_url":"https://avatars2.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"body":"I would like to change this to use `StringVars`, note the traling `s`. This already supports processing multiple strings into a single string slice. This avoids `strings.Split(\",\")` in your code.\r\n\r\nFurthermore, it changes the usage to provide the flag `--domain-filter` multiple times. Your example would become:\r\n\r\n```\r\nexternal-dns \\\r\n  --domain-filter=example.com \\\r\n  --domain-filter=company.org \\\r\n  --domain-filter=staging-company.org\r\n```\r\n\r\nThis approach is also used by `helm` and `kubernetes`.","created_at":"2017-06-28T16:12:50Z","updated_at":"2017-06-28T16:12:50Z","html_url":"https://github.com/kubernetes-incubator/external-dns/pull/252#discussion_r124586107","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments/124586107"},"html":{"href":"https://github.com/kubernetes-incubator/external-dns/pull/252#discussion_r124586107"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252","id":127751263,"html_url":"https://github.com/kubernetes-incubator/external-dns/pull/252","diff_url":"https://github.com/kubernetes-incubator/external-dns/pull/252.diff","patch_url":"https://github.com/kubernetes-incubator/external-dns/pull/252.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/252","number":252,"state":"open","locked":false,"title":"Support for multiple domains within --domain-filter","user":{"login":"totallyunknown","id":1724494,"avatar_url":"https://avatars2.githubusercontent.com/u/1724494?v=3","gravatar_id":"","url":"https://api.github.com/users/totallyunknown","html_url":"https://github.com/totallyunknown","followers_url":"https://api.github.com/users/totallyunknown/followers","following_url":"https://api.github.com/users/totallyunknown/following{/other_user}","gists_url":"https://api.github.com/users/totallyunknown/gists{/gist_id}","starred_url":"https://api.github.com/users/totallyunknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totallyunknown/subscriptions","organizations_url":"https://api.github.com/users/totallyunknown/orgs","repos_url":"https://api.github.com/users/totallyunknown/repos","events_url":"https://api.github.com/users/totallyunknown/events{/privacy}","received_events_url":"https://api.github.com/users/totallyunknown/received_events","type":"User","site_admin":false},"body":"The parameter accepts a comma separated list of domains with or without trailing dot. Example: `--domain-filter=\"example.org, company.test.,staging.com\"`. Closes #247 and #229","created_at":"2017-06-27T17:35:30Z","updated_at":"2017-06-28T16:12:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3aa0d75f2fc885fcb014be4a2abeb659319012c2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/252/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/7f31af34c6a0197b01ec542923ae2ae121e0c635","head":{"label":"totallyunknown:master","ref":"master","sha":"7f31af34c6a0197b01ec542923ae2ae121e0c635","user":{"login":"totallyunknown","id":1724494,"avatar_url":"https://avatars2.githubusercontent.com/u/1724494?v=3","gravatar_id":"","url":"https://api.github.com/users/totallyunknown","html_url":"https://github.com/totallyunknown","followers_url":"https://api.github.com/users/totallyunknown/followers","following_url":"https://api.github.com/users/totallyunknown/following{/other_user}","gists_url":"https://api.github.com/users/totallyunknown/gists{/gist_id}","starred_url":"https://api.github.com/users/totallyunknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totallyunknown/subscriptions","organizations_url":"https://api.github.com/users/totallyunknown/orgs","repos_url":"https://api.github.com/users/totallyunknown/repos","events_url":"https://api.github.com/users/totallyunknown/events{/privacy}","received_events_url":"https://api.github.com/users/totallyunknown/received_events","type":"User","site_admin":false},"repo":{"id":95562233,"name":"external-dns","full_name":"totallyunknown/external-dns","owner":{"login":"totallyunknown","id":1724494,"avatar_url":"https://avatars2.githubusercontent.com/u/1724494?v=3","gravatar_id":"","url":"https://api.github.com/users/totallyunknown","html_url":"https://github.com/totallyunknown","followers_url":"https://api.github.com/users/totallyunknown/followers","following_url":"https://api.github.com/users/totallyunknown/following{/other_user}","gists_url":"https://api.github.com/users/totallyunknown/gists{/gist_id}","starred_url":"https://api.github.com/users/totallyunknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totallyunknown/subscriptions","organizations_url":"https://api.github.com/users/totallyunknown/orgs","repos_url":"https://api.github.com/users/totallyunknown/repos","events_url":"https://api.github.com/users/totallyunknown/events{/privacy}","received_events_url":"https://api.github.com/users/totallyunknown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/totallyunknown/external-dns","description":"Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services","fork":true,"url":"https://api.github.com/repos/totallyunknown/external-dns","forks_url":"https://api.github.com/repos/totallyunknown/external-dns/forks","keys_url":"https://api.github.com/repos/totallyunknown/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/totallyunknown/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/totallyunknown/external-dns/teams","hooks_url":"https://api.github.com/repos/totallyunknown/external-dns/hooks","issue_events_url":"https://api.github.com/repos/totallyunknown/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/totallyunknown/external-dns/events","assignees_url":"https://api.github.com/repos/totallyunknown/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/totallyunknown/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/totallyunknown/external-dns/tags","blobs_url":"https://api.github.com/repos/totallyunknown/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/totallyunknown/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/totallyunknown/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/totallyunknown/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/totallyunknown/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/totallyunknown/external-dns/languages","stargazers_url":"https://api.github.com/repos/totallyunknown/external-dns/stargazers","contributors_url":"https://api.github.com/repos/totallyunknown/external-dns/contributors","subscribers_url":"https://api.github.com/repos/totallyunknown/external-dns/subscribers","subscription_url":"https://api.github.com/repos/totallyunknown/external-dns/subscription","commits_url":"https://api.github.com/repos/totallyunknown/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/totallyunknown/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/totallyunknown/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/totallyunknown/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/totallyunknown/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/totallyunknown/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/totallyunknown/external-dns/merges","archive_url":"https://api.github.com/repos/totallyunknown/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/totallyunknown/external-dns/downloads","issues_url":"https://api.github.com/repos/totallyunknown/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/totallyunknown/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/totallyunknown/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/totallyunknown/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/totallyunknown/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/totallyunknown/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/totallyunknown/external-dns/deployments","created_at":"2017-06-27T13:39:04Z","updated_at":"2017-06-27T13:39:06Z","pushed_at":"2017-06-27T17:53:08Z","git_url":"git://github.com/totallyunknown/external-dns.git","ssh_url":"git@github.com:totallyunknown/external-dns.git","clone_url":"https://github.com/totallyunknown/external-dns.git","svn_url":"https://github.com/totallyunknown/external-dns","homepage":"","size":34784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"1592ef0afaf9f3382a4065d5681e80373bb6ca95","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":81497153,"name":"external-dns","full_name":"kubernetes-incubator/external-dns","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/external-dns","description":"Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/external-dns","forks_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/deployments","created_at":"2017-02-09T21:34:27Z","updated_at":"2017-06-28T05:22:04Z","pushed_at":"2017-06-27T19:22:47Z","git_url":"git://github.com/kubernetes-incubator/external-dns.git","ssh_url":"git@github.com:kubernetes-incubator/external-dns.git","clone_url":"https://github.com/kubernetes-incubator/external-dns.git","svn_url":"https://github.com/kubernetes-incubator/external-dns","homepage":"","size":34787,"stargazers_count":230,"watchers_count":230,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":62,"forks":33,"open_issues":62,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252"},"html":{"href":"https://github.com/kubernetes-incubator/external-dns/pull/252"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/252"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/7f31af34c6a0197b01ec542923ae2ae121e0c635"}}}}
{"actor":{"display_login":"linki"}}