{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/comments/122207201","pull_request_review_id":44299864,"id":122207201,"diff_hunk":"@@ -48,8 +57,7 @@\n         the right format                                  %>\n     <% url = 'https://www.gov.uk/api/search.json?q=' %>\n     <% term = params[\"search_term\"] %>\n-    <% url += term.split.join(\"+\") %>\n-\n+    <%  url += term.split.join(\"+\") %>","path":"app/views/result/index.html.erb","position":54,"original_position":54,"commit_id":"2b7ba37cbc8fb45bb02e93992ad754d48fdfb405","original_commit_id":"2b7ba37cbc8fb45bb02e93992ad754d48fdfb405","user":{"login":"dwhenry","id":63736,"avatar_url":"https://avatars0.githubusercontent.com/u/63736?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhenry","html_url":"https://github.com/dwhenry","followers_url":"https://api.github.com/users/dwhenry/followers","following_url":"https://api.github.com/users/dwhenry/following{/other_user}","gists_url":"https://api.github.com/users/dwhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhenry/subscriptions","organizations_url":"https://api.github.com/users/dwhenry/orgs","repos_url":"https://api.github.com/users/dwhenry/repos","events_url":"https://api.github.com/users/dwhenry/events{/privacy}","received_events_url":"https://api.github.com/users/dwhenry/received_events","type":"User","site_admin":false},"body":"While I would recommend not declaring variables in views if you are going to do it you can just do the following:\r\n```\r\n<% url = 'https://www.gov.uk/api/search.json?q=' \r\n   term = params[\"search_term\"] \r\n   url += term.split.join(\"+\") %>","created_at":"2017-06-15T13:50:13Z","updated_at":"2017-06-15T13:54:13Z","html_url":"https://github.com/alphagov/search-performance-explorer/pull/4#discussion_r122207201","pull_request_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/comments/122207201"},"html":{"href":"https://github.com/alphagov/search-performance-explorer/pull/4#discussion_r122207201"},"pull_request":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4","id":125812377,"html_url":"https://github.com/alphagov/search-performance-explorer/pull/4","diff_url":"https://github.com/alphagov/search-performance-explorer/pull/4.diff","patch_url":"https://github.com/alphagov/search-performance-explorer/pull/4.patch","issue_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/4","number":4,"state":"open","locked":false,"title":"Changed the format of the results page","user":{"login":"JonathanHallam","id":24547207,"avatar_url":"https://avatars2.githubusercontent.com/u/24547207?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanHallam","html_url":"https://github.com/JonathanHallam","followers_url":"https://api.github.com/users/JonathanHallam/followers","following_url":"https://api.github.com/users/JonathanHallam/following{/other_user}","gists_url":"https://api.github.com/users/JonathanHallam/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanHallam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanHallam/subscriptions","organizations_url":"https://api.github.com/users/JonathanHallam/orgs","repos_url":"https://api.github.com/users/JonathanHallam/repos","events_url":"https://api.github.com/users/JonathanHallam/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanHallam/received_events","type":"User","site_admin":false},"body":"Also changed the tests to compensate for the format change and fixed a couple of bugs","created_at":"2017-06-15T12:41:30Z","updated_at":"2017-06-15T13:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c67256df2152efe38d396f08e14b711296cc43b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4/commits","review_comments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4/comments","review_comment_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/4/comments","statuses_url":"https://api.github.com/repos/alphagov/search-performance-explorer/statuses/2b7ba37cbc8fb45bb02e93992ad754d48fdfb405","head":{"label":"alphagov:result_formating","ref":"result_formating","sha":"2b7ba37cbc8fb45bb02e93992ad754d48fdfb405","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":93414534,"name":"search-performance-explorer","full_name":"alphagov/search-performance-explorer","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/search-performance-explorer","description":"Shows changes in search results for running A/B tests","fork":false,"url":"https://api.github.com/repos/alphagov/search-performance-explorer","forks_url":"https://api.github.com/repos/alphagov/search-performance-explorer/forks","keys_url":"https://api.github.com/repos/alphagov/search-performance-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/search-performance-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/search-performance-explorer/teams","hooks_url":"https://api.github.com/repos/alphagov/search-performance-explorer/hooks","issue_events_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/search-performance-explorer/events","assignees_url":"https://api.github.com/repos/alphagov/search-performance-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/search-performance-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/search-performance-explorer/tags","blobs_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/search-performance-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/search-performance-explorer/languages","stargazers_url":"https://api.github.com/repos/alphagov/search-performance-explorer/stargazers","contributors_url":"https://api.github.com/repos/alphagov/search-performance-explorer/contributors","subscribers_url":"https://api.github.com/repos/alphagov/search-performance-explorer/subscribers","subscription_url":"https://api.github.com/repos/alphagov/search-performance-explorer/subscription","commits_url":"https://api.github.com/repos/alphagov/search-performance-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/search-performance-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/search-performance-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/search-performance-explorer/merges","archive_url":"https://api.github.com/repos/alphagov/search-performance-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/search-performance-explorer/downloads","issues_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/search-performance-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/search-performance-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/search-performance-explorer/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/search-performance-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/deployments","created_at":"2017-06-05T14:48:33Z","updated_at":"2017-06-05T15:07:25Z","pushed_at":"2017-06-15T12:49:55Z","git_url":"git://github.com/alphagov/search-performance-explorer.git","ssh_url":"git@github.com:alphagov/search-performance-explorer.git","clone_url":"https://github.com/alphagov/search-performance-explorer.git","svn_url":"https://github.com/alphagov/search-performance-explorer","homepage":null,"size":570,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"65e7a541cd72cdc446d0be6263cb2d2d8828c72a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":93414534,"name":"search-performance-explorer","full_name":"alphagov/search-performance-explorer","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/search-performance-explorer","description":"Shows changes in search results for running A/B tests","fork":false,"url":"https://api.github.com/repos/alphagov/search-performance-explorer","forks_url":"https://api.github.com/repos/alphagov/search-performance-explorer/forks","keys_url":"https://api.github.com/repos/alphagov/search-performance-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/search-performance-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/search-performance-explorer/teams","hooks_url":"https://api.github.com/repos/alphagov/search-performance-explorer/hooks","issue_events_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/search-performance-explorer/events","assignees_url":"https://api.github.com/repos/alphagov/search-performance-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/search-performance-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/search-performance-explorer/tags","blobs_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/search-performance-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/search-performance-explorer/languages","stargazers_url":"https://api.github.com/repos/alphagov/search-performance-explorer/stargazers","contributors_url":"https://api.github.com/repos/alphagov/search-performance-explorer/contributors","subscribers_url":"https://api.github.com/repos/alphagov/search-performance-explorer/subscribers","subscription_url":"https://api.github.com/repos/alphagov/search-performance-explorer/subscription","commits_url":"https://api.github.com/repos/alphagov/search-performance-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/search-performance-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/search-performance-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/search-performance-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/search-performance-explorer/merges","archive_url":"https://api.github.com/repos/alphagov/search-performance-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/search-performance-explorer/downloads","issues_url":"https://api.github.com/repos/alphagov/search-performance-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/search-performance-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/search-performance-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/search-performance-explorer/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/search-performance-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/search-performance-explorer/deployments","created_at":"2017-06-05T14:48:33Z","updated_at":"2017-06-05T15:07:25Z","pushed_at":"2017-06-15T12:49:55Z","git_url":"git://github.com/alphagov/search-performance-explorer.git","ssh_url":"git@github.com:alphagov/search-performance-explorer.git","clone_url":"https://github.com/alphagov/search-performance-explorer.git","svn_url":"https://github.com/alphagov/search-performance-explorer","homepage":null,"size":570,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4"},"html":{"href":"https://github.com/alphagov/search-performance-explorer/pull/4"},"issue":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/4"},"comments":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/search-performance-explorer/statuses/2b7ba37cbc8fb45bb02e93992ad754d48fdfb405"}}}}
{"actor":{"display_login":"dwhenry"}}