{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/95008360","pull_request_review_id":15554362,"id":95008360,"diff_hunk":"@@ -2968,6 +2975,23 @@ defmodule Kernel do\n \n       when x >= 1 and x <= 3\n \n+  ### Special AST Considerations\n+\n+  `not in` is rewritten in the Elixir compiler, so `:left not in :right` appears","path":"lib/elixir/lib/kernel.ex","position":28,"original_position":28,"commit_id":"788016828de795c0bfb75065016930babee879d5","original_commit_id":"788016828de795c0bfb75065016930babee879d5","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"And it would be clearer to say \"`not in` is parsed by the compiler into the `{:not, [], [{:in, _, [left, right]}]}`\". There is no such thing as being rewritten, it is just how it is parsed. :)","created_at":"2017-01-06T19:50:46Z","updated_at":"2017-01-06T19:50:46Z","html_url":"https://github.com/elixir-lang/elixir/pull/5620#discussion_r95008360","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/95008360"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5620#discussion_r95008360"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620","id":100395001,"html_url":"https://github.com/elixir-lang/elixir/pull/5620","diff_url":"https://github.com/elixir-lang/elixir/pull/5620.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/5620.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5620","number":5620,"state":"open","locked":false,"title":"`left not in right`","user":{"login":"antipax","id":56482,"avatar_url":"https://avatars.githubusercontent.com/u/56482?v=3","gravatar_id":"","url":"https://api.github.com/users/antipax","html_url":"https://github.com/antipax","followers_url":"https://api.github.com/users/antipax/followers","following_url":"https://api.github.com/users/antipax/following{/other_user}","gists_url":"https://api.github.com/users/antipax/gists{/gist_id}","starred_url":"https://api.github.com/users/antipax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antipax/subscriptions","organizations_url":"https://api.github.com/users/antipax/orgs","repos_url":"https://api.github.com/users/antipax/repos","events_url":"https://api.github.com/users/antipax/events{/privacy}","received_events_url":"https://api.github.com/users/antipax/received_events","type":"User","site_admin":false},"body":"As discussed in #5544.\r\n\r\n* Adds `left not in right`, which is translated into `not(left in right)` in the tokenizer/parser.\r\n* Updates all existing uses of `not left in right` into the new form, since we plan to deprecate the former.\r\n* `Macro.to_string/2` now translates `not(left in right)` to `left not in right`.\r\n* Adds documentation for `left not in right`.","created_at":"2017-01-06T01:18:15Z","updated_at":"2017-01-06T19:50:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"257f1015d20c8d29a136bec96a40bb6bf832076f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5620/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/788016828de795c0bfb75065016930babee879d5","head":{"label":"antipax:not-in","ref":"not-in","sha":"788016828de795c0bfb75065016930babee879d5","user":{"login":"antipax","id":56482,"avatar_url":"https://avatars.githubusercontent.com/u/56482?v=3","gravatar_id":"","url":"https://api.github.com/users/antipax","html_url":"https://github.com/antipax","followers_url":"https://api.github.com/users/antipax/followers","following_url":"https://api.github.com/users/antipax/following{/other_user}","gists_url":"https://api.github.com/users/antipax/gists{/gist_id}","starred_url":"https://api.github.com/users/antipax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antipax/subscriptions","organizations_url":"https://api.github.com/users/antipax/orgs","repos_url":"https://api.github.com/users/antipax/repos","events_url":"https://api.github.com/users/antipax/events{/privacy}","received_events_url":"https://api.github.com/users/antipax/received_events","type":"User","site_admin":false},"repo":{"id":33321987,"name":"elixir","full_name":"antipax/elixir","owner":{"login":"antipax","id":56482,"avatar_url":"https://avatars.githubusercontent.com/u/56482?v=3","gravatar_id":"","url":"https://api.github.com/users/antipax","html_url":"https://github.com/antipax","followers_url":"https://api.github.com/users/antipax/followers","following_url":"https://api.github.com/users/antipax/following{/other_user}","gists_url":"https://api.github.com/users/antipax/gists{/gist_id}","starred_url":"https://api.github.com/users/antipax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antipax/subscriptions","organizations_url":"https://api.github.com/users/antipax/orgs","repos_url":"https://api.github.com/users/antipax/repos","events_url":"https://api.github.com/users/antipax/events{/privacy}","received_events_url":"https://api.github.com/users/antipax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antipax/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/antipax/elixir","forks_url":"https://api.github.com/repos/antipax/elixir/forks","keys_url":"https://api.github.com/repos/antipax/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antipax/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antipax/elixir/teams","hooks_url":"https://api.github.com/repos/antipax/elixir/hooks","issue_events_url":"https://api.github.com/repos/antipax/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/antipax/elixir/events","assignees_url":"https://api.github.com/repos/antipax/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/antipax/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/antipax/elixir/tags","blobs_url":"https://api.github.com/repos/antipax/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antipax/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antipax/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/antipax/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antipax/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/antipax/elixir/languages","stargazers_url":"https://api.github.com/repos/antipax/elixir/stargazers","contributors_url":"https://api.github.com/repos/antipax/elixir/contributors","subscribers_url":"https://api.github.com/repos/antipax/elixir/subscribers","subscription_url":"https://api.github.com/repos/antipax/elixir/subscription","commits_url":"https://api.github.com/repos/antipax/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/antipax/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/antipax/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/antipax/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/antipax/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/antipax/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antipax/elixir/merges","archive_url":"https://api.github.com/repos/antipax/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antipax/elixir/downloads","issues_url":"https://api.github.com/repos/antipax/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/antipax/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/antipax/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/antipax/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antipax/elixir/labels{/name}","releases_url":"https://api.github.com/repos/antipax/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/antipax/elixir/deployments","created_at":"2015-04-02T17:23:06Z","updated_at":"2015-04-02T17:23:08Z","pushed_at":"2017-01-06T18:07:43Z","git_url":"git://github.com/antipax/elixir.git","ssh_url":"git@github.com:antipax/elixir.git","clone_url":"https://github.com/antipax/elixir.git","svn_url":"https://github.com/antipax/elixir","homepage":"http://elixir-lang.org/","size":29674,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"d94b9b7b0aaf252d640113c016cfea8c5e4c44bd","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2017-01-06T17:32:46Z","pushed_at":"2017-01-06T18:07:45Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":30091,"stargazers_count":8982,"watchers_count":8982,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1224,"mirror_url":null,"open_issues_count":21,"forks":1224,"open_issues":21,"watchers":8982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5620"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5620"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5620/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5620/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/788016828de795c0bfb75065016930babee879d5"}}}}
{"actor":{"display_login":"josevalim"}}