{"action":"closed","number":12412,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/12412","id":146343705,"html_url":"https://github.com/apple/swift/pull/12412","diff_url":"https://github.com/apple/swift/pull/12412.diff","patch_url":"https://github.com/apple/swift/pull/12412.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/12412","number":12412,"state":"closed","locked":false,"title":"Merge pull request #12411 from shajrawi/silcombine_bugfix","user":{"login":"shajrawi","id":17753158,"avatar_url":"https://avatars3.githubusercontent.com/u/17753158?v=4","gravatar_id":"","url":"https://api.github.com/users/shajrawi","html_url":"https://github.com/shajrawi","followers_url":"https://api.github.com/users/shajrawi/followers","following_url":"https://api.github.com/users/shajrawi/following{/other_user}","gists_url":"https://api.github.com/users/shajrawi/gists{/gist_id}","starred_url":"https://api.github.com/users/shajrawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajrawi/subscriptions","organizations_url":"https://api.github.com/users/shajrawi/orgs","repos_url":"https://api.github.com/users/shajrawi/repos","events_url":"https://api.github.com/users/shajrawi/events{/privacy}","received_events_url":"https://api.github.com/users/shajrawi/received_events","type":"User","site_admin":false},"body":"radar rdar://problem/34966696\r\n\r\n• Explanation: Fixes an infinite loop. The infinite loop was there for over a year but it got exposed by the following bug fix: rdar://problem/34753633\r\n\r\n• Scope of Issue: Fixes an infinite loop in SILCombiner: we should not create a new witness method instruction if it exactly the same as the old one: doing so might cause the transformation to go into an infinite loop: The new method instruction will be added to the Builder’s tracker list. SILCombine, in turn, uses the tracker list to populate the worklist. As such, if we don’t remove the witness method later on in the pass, we are stuck: We will re-create the same instruction and re-populate the worklist with it. This SILCombiner bug was always there, we just never hit it before because we always removed the witness method instruction later on in the transformation (creating the new apply / making the witness instruction dead). Since we now bail on creating new apply instructions, which is the right thing to do as seen in rdar://problem/34753633, it got exposed.\r\n\r\n• Origination: This was discovered while debugging <rdar://problem/34966696> Swift CI: 2. Swift Source Compatibility Suite (master)\r\n\r\n• Risk: Low - The bug fix is a very simple if statement: if we are trying to replace a witness method instruction with itself (exact same conformance and lookup type) bail. Don’t do so. There’s no point in creating the exact same instruction, replacing all uses with the new one, and deleting the old one. The old one should do the job. That way we are not adding a new instruction to the builder’s tracker list.\r\n\r\n• Reviewed By: @eeckstein ","created_at":"2017-10-13T00:07:51Z","updated_at":"2017-10-13T03:10:32Z","closed_at":"2017-10-13T03:10:32Z","merged_at":"2017-10-13T03:10:32Z","merge_commit_sha":"e37175d8bab4fd99d25a532d7981707bd37e1e51","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/12412/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/12412/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/12412/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/71266fa1eb9a08be11e38ccef486bff97da0ce10","head":{"label":"apple:cherrypick_silcombine_infinite_loop_fix","ref":"cherrypick_silcombine_infinite_loop_fix","sha":"71266fa1eb9a08be11e38ccef486bff97da0ce10","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-10-13T02:54:05Z","pushed_at":"2017-10-13T03:10:32Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":232324,"stargazers_count":41030,"watchers_count":41030,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6353,"mirror_url":null,"open_issues_count":173,"forks":6353,"open_issues":173,"watchers":41030,"default_branch":"master"}},"base":{"label":"apple:swift-4.0-branch","ref":"swift-4.0-branch","sha":"12f71668428369744ba48296628488cf0d4882d0","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-10-13T02:54:05Z","pushed_at":"2017-10-13T03:10:32Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":232324,"stargazers_count":41030,"watchers_count":41030,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6353,"mirror_url":null,"open_issues_count":173,"forks":6353,"open_issues":173,"watchers":41030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/12412"},"html":{"href":"https://github.com/apple/swift/pull/12412"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/12412"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/12412/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/12412/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/12412/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/71266fa1eb9a08be11e38ccef486bff97da0ce10"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shajrawi","id":17753158,"avatar_url":"https://avatars3.githubusercontent.com/u/17753158?v=4","gravatar_id":"","url":"https://api.github.com/users/shajrawi","html_url":"https://github.com/shajrawi","followers_url":"https://api.github.com/users/shajrawi/followers","following_url":"https://api.github.com/users/shajrawi/following{/other_user}","gists_url":"https://api.github.com/users/shajrawi/gists{/gist_id}","starred_url":"https://api.github.com/users/shajrawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajrawi/subscriptions","organizations_url":"https://api.github.com/users/shajrawi/orgs","repos_url":"https://api.github.com/users/shajrawi/repos","events_url":"https://api.github.com/users/shajrawi/events{/privacy}","received_events_url":"https://api.github.com/users/shajrawi/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"shajrawi"}}