{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/137713915","pull_request_review_id":61417280,"id":137713915,"diff_hunk":"@@ -3189,6 +3190,16 @@ struct config_bool ConfigureNamesBool_gp[] =\n \t},\n \n \t{\n+\t\t{\"optimizer_use_gpdb_allocators\", PGC_POSTMASTER, RESOURCES_MEM,","path":"src/backend/utils/misc/guc_gp.c","position":12,"original_position":12,"commit_id":"7a54d97462ff8cdc0f738ebc9a5fd863b1bea3ed","original_commit_id":"7a54d97462ff8cdc0f738ebc9a5fd863b1bea3ed","user":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars1.githubusercontent.com/u/12649877?v=4","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"body":"well we wanted to test it with and without. I think we should get rid of this once we are confident of the impact","created_at":"2017-09-08T05:54:53Z","updated_at":"2017-09-08T05:54:53Z","html_url":"https://github.com/greenplum-db/gpdb/pull/3202#discussion_r137713915","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/137713915"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/3202#discussion_r137713915"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202"}},"in_reply_to_id":137709845},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202","id":139915215,"html_url":"https://github.com/greenplum-db/gpdb/pull/3202","diff_url":"https://github.com/greenplum-db/gpdb/pull/3202.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/3202.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3202","number":3202,"state":"open","locked":false,"title":"Gpos memory accounting","user":{"login":"kavinderd","id":449917,"avatar_url":"https://avatars0.githubusercontent.com/u/449917?v=4","gravatar_id":"","url":"https://api.github.com/users/kavinderd","html_url":"https://github.com/kavinderd","followers_url":"https://api.github.com/users/kavinderd/followers","following_url":"https://api.github.com/users/kavinderd/following{/other_user}","gists_url":"https://api.github.com/users/kavinderd/gists{/gist_id}","starred_url":"https://api.github.com/users/kavinderd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kavinderd/subscriptions","organizations_url":"https://api.github.com/users/kavinderd/orgs","repos_url":"https://api.github.com/users/kavinderd/repos","events_url":"https://api.github.com/users/kavinderd/events{/privacy}","received_events_url":"https://api.github.com/users/kavinderd/received_events","type":"User","site_admin":false},"body":"Before this commit all memory allocations made by ORCA/GPOS were a\r\nblackbox to GPDB. However the ground work had been in place to allow\r\nGPDB's Memory Accounting Framework to track memory consumption by ORCA.\r\nThis commit introduces two new functions\r\nMemoryAccounting_ExternalAllocate & MemoryAccounting_ExternalFree which\r\npass through their parameters to malloc and free and do some bookeeping\r\nagainst the Optimizer Memory Account. This introduces very little\r\noverhead to the GPOS memory management framework.","created_at":"2017-09-07T22:03:34Z","updated_at":"2017-09-08T05:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49c5b80d97c13a4a0d61bc8bfd9a1f3f8c717c7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"d","id":440892,"avatar_url":"https://avatars2.githubusercontent.com/u/440892?v=4","gravatar_id":"","url":"https://api.github.com/users/d","html_url":"https://github.com/d","followers_url":"https://api.github.com/users/d/followers","following_url":"https://api.github.com/users/d/following{/other_user}","gists_url":"https://api.github.com/users/d/gists{/gist_id}","starred_url":"https://api.github.com/users/d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d/subscriptions","organizations_url":"https://api.github.com/users/d/orgs","repos_url":"https://api.github.com/users/d/repos","events_url":"https://api.github.com/users/d/events{/privacy}","received_events_url":"https://api.github.com/users/d/received_events","type":"User","site_admin":false},{"login":"hsyuan","id":15352793,"avatar_url":"https://avatars2.githubusercontent.com/u/15352793?v=4","gravatar_id":"","url":"https://api.github.com/users/hsyuan","html_url":"https://github.com/hsyuan","followers_url":"https://api.github.com/users/hsyuan/followers","following_url":"https://api.github.com/users/hsyuan/following{/other_user}","gists_url":"https://api.github.com/users/hsyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsyuan/subscriptions","organizations_url":"https://api.github.com/users/hsyuan/orgs","repos_url":"https://api.github.com/users/hsyuan/repos","events_url":"https://api.github.com/users/hsyuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsyuan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3202/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/7a54d97462ff8cdc0f738ebc9a5fd863b1bea3ed","head":{"label":"kavinderd:gpos_memory_accounting","ref":"gpos_memory_accounting","sha":"7a54d97462ff8cdc0f738ebc9a5fd863b1bea3ed","user":{"login":"kavinderd","id":449917,"avatar_url":"https://avatars0.githubusercontent.com/u/449917?v=4","gravatar_id":"","url":"https://api.github.com/users/kavinderd","html_url":"https://github.com/kavinderd","followers_url":"https://api.github.com/users/kavinderd/followers","following_url":"https://api.github.com/users/kavinderd/following{/other_user}","gists_url":"https://api.github.com/users/kavinderd/gists{/gist_id}","starred_url":"https://api.github.com/users/kavinderd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kavinderd/subscriptions","organizations_url":"https://api.github.com/users/kavinderd/orgs","repos_url":"https://api.github.com/users/kavinderd/repos","events_url":"https://api.github.com/users/kavinderd/events{/privacy}","received_events_url":"https://api.github.com/users/kavinderd/received_events","type":"User","site_admin":false},"repo":{"id":90416368,"name":"gpdb","full_name":"kavinderd/gpdb","owner":{"login":"kavinderd","id":449917,"avatar_url":"https://avatars0.githubusercontent.com/u/449917?v=4","gravatar_id":"","url":"https://api.github.com/users/kavinderd","html_url":"https://github.com/kavinderd","followers_url":"https://api.github.com/users/kavinderd/followers","following_url":"https://api.github.com/users/kavinderd/following{/other_user}","gists_url":"https://api.github.com/users/kavinderd/gists{/gist_id}","starred_url":"https://api.github.com/users/kavinderd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kavinderd/subscriptions","organizations_url":"https://api.github.com/users/kavinderd/orgs","repos_url":"https://api.github.com/users/kavinderd/repos","events_url":"https://api.github.com/users/kavinderd/events{/privacy}","received_events_url":"https://api.github.com/users/kavinderd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kavinderd/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/kavinderd/gpdb","forks_url":"https://api.github.com/repos/kavinderd/gpdb/forks","keys_url":"https://api.github.com/repos/kavinderd/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kavinderd/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kavinderd/gpdb/teams","hooks_url":"https://api.github.com/repos/kavinderd/gpdb/hooks","issue_events_url":"https://api.github.com/repos/kavinderd/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/kavinderd/gpdb/events","assignees_url":"https://api.github.com/repos/kavinderd/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/kavinderd/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/kavinderd/gpdb/tags","blobs_url":"https://api.github.com/repos/kavinderd/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kavinderd/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kavinderd/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kavinderd/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kavinderd/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/kavinderd/gpdb/languages","stargazers_url":"https://api.github.com/repos/kavinderd/gpdb/stargazers","contributors_url":"https://api.github.com/repos/kavinderd/gpdb/contributors","subscribers_url":"https://api.github.com/repos/kavinderd/gpdb/subscribers","subscription_url":"https://api.github.com/repos/kavinderd/gpdb/subscription","commits_url":"https://api.github.com/repos/kavinderd/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kavinderd/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kavinderd/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kavinderd/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kavinderd/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/kavinderd/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kavinderd/gpdb/merges","archive_url":"https://api.github.com/repos/kavinderd/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kavinderd/gpdb/downloads","issues_url":"https://api.github.com/repos/kavinderd/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/kavinderd/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/kavinderd/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/kavinderd/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kavinderd/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/kavinderd/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/kavinderd/gpdb/deployments","created_at":"2017-05-05T21:07:36Z","updated_at":"2017-05-05T21:08:23Z","pushed_at":"2017-09-07T23:33:06Z","git_url":"git://github.com/kavinderd/gpdb.git","ssh_url":"git@github.com:kavinderd/gpdb.git","clone_url":"https://github.com/kavinderd/gpdb.git","svn_url":"https://github.com/kavinderd/gpdb","homepage":"http://greenplum.org","size":218491,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"bafd3d805ebed55d83e07963de30c98a3a791104","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-09-08T02:48:06Z","pushed_at":"2017-09-08T05:16:14Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":218809,"stargazers_count":2056,"watchers_count":2056,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":638,"mirror_url":null,"open_issues_count":146,"forks":638,"open_issues":146,"watchers":2056,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/3202"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/3202"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/3202/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3202/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/7a54d97462ff8cdc0f738ebc9a5fd863b1bea3ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vraghavan78"}}