{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/sdk/issues/1442","repository_url":"https://api.github.com/repos/dotnet/sdk","labels_url":"https://api.github.com/repos/dotnet/sdk/issues/1442/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/sdk/issues/1442/comments","events_url":"https://api.github.com/repos/dotnet/sdk/issues/1442/events","html_url":"https://github.com/dotnet/sdk/pull/1442","id":244821201,"number":1442,"title":"Fix #1435 - calculation of ResolvedPath for project references","user":{"login":"BrunoJuchli","id":2090172,"avatar_url":"https://avatars1.githubusercontent.com/u/2090172?v=4","gravatar_id":"","url":"https://api.github.com/users/BrunoJuchli","html_url":"https://github.com/BrunoJuchli","followers_url":"https://api.github.com/users/BrunoJuchli/followers","following_url":"https://api.github.com/users/BrunoJuchli/following{/other_user}","gists_url":"https://api.github.com/users/BrunoJuchli/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoJuchli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoJuchli/subscriptions","organizations_url":"https://api.github.com/users/BrunoJuchli/orgs","repos_url":"https://api.github.com/users/BrunoJuchli/repos","events_url":"https://api.github.com/users/BrunoJuchli/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoJuchli/received_events","type":"User","site_admin":false},"labels":[{"id":465746480,"url":"https://api.github.com/repos/dotnet/sdk/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-07-22T03:41:24Z","updated_at":"2017-07-24T22:36:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/1442","html_url":"https://github.com/dotnet/sdk/pull/1442","diff_url":"https://github.com/dotnet/sdk/pull/1442.diff","patch_url":"https://github.com/dotnet/sdk/pull/1442.patch"},"body":"See #1435 for error description and analysis of the problem. In short:\r\n\r\nThe old implementation combined the relative `<ProjectReference Include=\"...\" />` path with the directory of the `ProjectAssetFile`.\r\nCorrected this to combine the relative project reference with the current's project path.\r\n\r\nQuestions:\r\n - Is it actually the desired outcome that ResolvedPath points to the csproj file? Or should it point to the output directory of that project?\r\n - Is ProjectPath always passed in as full path? (otherwise it needs to be enclosed by a `Path.GetFullPath`)"},"comment":{"url":"https://api.github.com/repos/dotnet/sdk/issues/comments/317574677","html_url":"https://github.com/dotnet/sdk/pull/1442#issuecomment-317574677","issue_url":"https://api.github.com/repos/dotnet/sdk/issues/1442","id":317574677,"user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars0.githubusercontent.com/u/75470?v=4","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"created_at":"2017-07-24T22:36:17Z","updated_at":"2017-07-24T22:36:17Z","body":"@natidea #1435 says the build is failing due to this.\r\n\r\n @BrunoJuchli Do you have anything custom reading this ResolvedPath ?"}}
{"actor":{"display_login":"nguerrera"}}