{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-linter/issues/1336","repository_url":"https://api.github.com/repos/mozilla/addons-linter","labels_url":"https://api.github.com/repos/mozilla/addons-linter/issues/1336/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-linter/issues/1336/comments","events_url":"https://api.github.com/repos/mozilla/addons-linter/issues/1336/events","html_url":"https://github.com/mozilla/addons-linter/pull/1336","id":234880452,"number":1336,"title":"[WIP] Validate icon files","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars1.githubusercontent.com/u/211578?v=4","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"labels":[{"id":366386465,"url":"https://api.github.com/repos/mozilla/addons-linter/labels/state:%20pull%20request%20ready","name":"state: pull request ready","color":"fac209","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-09T16:38:07Z","updated_at":"2017-07-25T17:37:11Z","closed_at":"2017-07-25T16:05:12Z","pull_request":{"url":"https://api.github.com/repos/mozilla/addons-linter/pulls/1336","html_url":"https://github.com/mozilla/addons-linter/pull/1336","diff_url":"https://github.com/mozilla/addons-linter/pull/1336.diff","patch_url":"https://github.com/mozilla/addons-linter/pull/1336.patch"},"body":"I need to fix how the async works. I hacked it in the `getMetadata()` since that worked well with `async`/`await` but then that stopped working after an npm/yarn install.\r\n\r\nI think we'll want the API for `ManifestJSONParser` to change to something like:\r\n\r\n```js\r\nconst parser = new ManifestJSONParser(\r\n  json,\r\n  this.collector,\r\n  { io: this.io, ... });\r\nawait parser.validate();\r\nparser.getMetadata();\r\n```\r\n\r\nAlternatively the icon validation could go into a separate class like `ManifestIconValidator` and that can be async. That might be easier.\r\n\r\nThe tests are scoped to the new stuff so they pass but this should break a bunch of stuff."},"comment":{"url":"https://api.github.com/repos/mozilla/addons-linter/issues/comments/317812545","html_url":"https://github.com/mozilla/addons-linter/pull/1336#issuecomment-317812545","issue_url":"https://api.github.com/repos/mozilla/addons-linter/issues/1336","id":317812545,"user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars1.githubusercontent.com/u/139033?v=4","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T17:37:11Z","updated_at":"2017-07-25T17:37:11Z","body":"Cool, thanks! Let me know if I can be of any help working on this."}}
{"actor":{"display_login":"EnTeQuAk"}}