{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-go/pulls/comments/115347989","pull_request_review_id":36879618,"id":115347989,"diff_hunk":"@@ -79,3 +82,73 @@ func Run(ctx context.Context, command string, arg []string) (*CommandExecutor, e\n \n \treturn commandExecutor, nil\n }\n+\n+// Output returns stdout, stderr and error status for a given shell command\n+func Output(ctx context.Context, command []string, timeout ...string) ([]byte, []byte, error) {","path":"exec/exec.go","position":21,"original_position":21,"commit_id":"20c7890b8c503b86233041ad7829a7bed692430f","original_commit_id":"20c7890b8c503b86233041ad7829a7bed692430f","user":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars0.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"body":"sure\r\n","created_at":"2017-05-08T20:41:27Z","updated_at":"2017-05-08T20:41:27Z","html_url":"https://github.com/dcos/dcos-go/pull/27#discussion_r115347989","pull_request_url":"https://api.github.com/repos/dcos/dcos-go/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/comments/115347989"},"html":{"href":"https://github.com/dcos/dcos-go/pull/27#discussion_r115347989"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-go/pulls/27","id":119313231,"html_url":"https://github.com/dcos/dcos-go/pull/27","diff_url":"https://github.com/dcos/dcos-go/pull/27.diff","patch_url":"https://github.com/dcos/dcos-go/pull/27.patch","issue_url":"https://api.github.com/repos/dcos/dcos-go/issues/27","number":27,"state":"open","locked":false,"title":"WIP: Adding exec output","user":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars0.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"body":"Add common shelling out function to exec.\r\n\r\nit returns stdout, stderr and error","created_at":"2017-05-06T19:32:45Z","updated_at":"2017-05-08T20:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80002717bec07fcd537872f28769684ff0c03e82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-go/pulls/27/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-go/pulls/27/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-go/issues/27/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-go/statuses/20c7890b8c503b86233041ad7829a7bed692430f","head":{"label":"amitaekbote:exec-go","ref":"exec-go","sha":"20c7890b8c503b86233041ad7829a7bed692430f","user":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars0.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"repo":{"id":90093983,"name":"dcos-go","full_name":"amitaekbote/dcos-go","owner":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars0.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitaekbote/dcos-go","description":"DC/OS golang shared libraries","fork":true,"url":"https://api.github.com/repos/amitaekbote/dcos-go","forks_url":"https://api.github.com/repos/amitaekbote/dcos-go/forks","keys_url":"https://api.github.com/repos/amitaekbote/dcos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitaekbote/dcos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitaekbote/dcos-go/teams","hooks_url":"https://api.github.com/repos/amitaekbote/dcos-go/hooks","issue_events_url":"https://api.github.com/repos/amitaekbote/dcos-go/issues/events{/number}","events_url":"https://api.github.com/repos/amitaekbote/dcos-go/events","assignees_url":"https://api.github.com/repos/amitaekbote/dcos-go/assignees{/user}","branches_url":"https://api.github.com/repos/amitaekbote/dcos-go/branches{/branch}","tags_url":"https://api.github.com/repos/amitaekbote/dcos-go/tags","blobs_url":"https://api.github.com/repos/amitaekbote/dcos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitaekbote/dcos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitaekbote/dcos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitaekbote/dcos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitaekbote/dcos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/amitaekbote/dcos-go/languages","stargazers_url":"https://api.github.com/repos/amitaekbote/dcos-go/stargazers","contributors_url":"https://api.github.com/repos/amitaekbote/dcos-go/contributors","subscribers_url":"https://api.github.com/repos/amitaekbote/dcos-go/subscribers","subscription_url":"https://api.github.com/repos/amitaekbote/dcos-go/subscription","commits_url":"https://api.github.com/repos/amitaekbote/dcos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitaekbote/dcos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitaekbote/dcos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitaekbote/dcos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitaekbote/dcos-go/contents/{+path}","compare_url":"https://api.github.com/repos/amitaekbote/dcos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitaekbote/dcos-go/merges","archive_url":"https://api.github.com/repos/amitaekbote/dcos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitaekbote/dcos-go/downloads","issues_url":"https://api.github.com/repos/amitaekbote/dcos-go/issues{/number}","pulls_url":"https://api.github.com/repos/amitaekbote/dcos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/amitaekbote/dcos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/amitaekbote/dcos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitaekbote/dcos-go/labels{/name}","releases_url":"https://api.github.com/repos/amitaekbote/dcos-go/releases{/id}","deployments_url":"https://api.github.com/repos/amitaekbote/dcos-go/deployments","created_at":"2017-05-03T01:15:34Z","updated_at":"2017-05-03T01:15:35Z","pushed_at":"2017-05-08T19:40:51Z","git_url":"git://github.com/amitaekbote/dcos-go.git","ssh_url":"git@github.com:amitaekbote/dcos-go.git","clone_url":"https://github.com/amitaekbote/dcos-go.git","svn_url":"https://github.com/amitaekbote/dcos-go","homepage":"","size":2711,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"0060d71f61c06c460887a67cc4ea274f4b2e7441","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":69291251,"name":"dcos-go","full_name":"dcos/dcos-go","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-go","description":"DC/OS golang shared libraries","fork":false,"url":"https://api.github.com/repos/dcos/dcos-go","forks_url":"https://api.github.com/repos/dcos/dcos-go/forks","keys_url":"https://api.github.com/repos/dcos/dcos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-go/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-go/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-go/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-go/events","assignees_url":"https://api.github.com/repos/dcos/dcos-go/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-go/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-go/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-go/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-go/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-go/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-go/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-go/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-go/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-go/merges","archive_url":"https://api.github.com/repos/dcos/dcos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-go/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-go/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-go/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-go/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-go/deployments","created_at":"2016-09-26T20:45:14Z","updated_at":"2017-02-03T12:22:09Z","pushed_at":"2017-05-06T21:36:15Z","git_url":"git://github.com/dcos/dcos-go.git","ssh_url":"git@github.com:dcos/dcos-go.git","clone_url":"https://github.com/dcos/dcos-go.git","svn_url":"https://github.com/dcos/dcos-go","homepage":"","size":2705,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/27"},"html":{"href":"https://github.com/dcos/dcos-go/pull/27"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-go/issues/27"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-go/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-go/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-go/statuses/20c7890b8c503b86233041ad7829a7bed692430f"}}}}
{"actor":{"display_login":"amitaekbote"}}