{"action":"created","issue":{"url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/153","repository_url":"https://api.github.com/repos/sentinelsat/sentinelsat","labels_url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/153/comments","events_url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/153/events","html_url":"https://github.com/sentinelsat/sentinelsat/issues/153","id":249396342,"number":153,"title":"--footprints parameter","user":{"login":"valgur","id":1778160,"avatar_url":"https://avatars3.githubusercontent.com/u/1778160?v=4","gravatar_id":"","url":"https://api.github.com/users/valgur","html_url":"https://github.com/valgur","followers_url":"https://api.github.com/users/valgur/followers","following_url":"https://api.github.com/users/valgur/following{/other_user}","gists_url":"https://api.github.com/users/valgur/gists{/gist_id}","starred_url":"https://api.github.com/users/valgur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valgur/subscriptions","organizations_url":"https://api.github.com/users/valgur/orgs","repos_url":"https://api.github.com/users/valgur/repos","events_url":"https://api.github.com/users/valgur/events{/privacy}","received_events_url":"https://api.github.com/users/valgur/received_events","type":"User","site_admin":false},"labels":[{"id":618181481,"url":"https://api.github.com/repos/sentinelsat/sentinelsat/labels/discussion","name":"discussion","color":"d4c5f9","default":false},{"id":214922610,"url":"https://api.github.com/repos/sentinelsat/sentinelsat/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-10T15:59:59Z","updated_at":"2017-08-14T10:20:18Z","closed_at":null,"body":"## Question\r\n**Should we change the `--footprints` parameter's behavior to also include the name of the file that will be created?**\r\n\r\nLet's make it a poll. I encourage anyone to leave a thumbs up or down to voice your opinion. Comments are welcome too, of course.\r\n\r\n## Reasoning\r\nI've been thinking that the `--footprints` flag would be more useful if it also took the name/path of the file to be created instead of always writing it to `search_footprints.geojson`.\r\n\r\nAn example use case might be:\r\n```\r\nsentinelsat -g germany_aoi.geojson --sentinel 1 --footprints s1_germany_footprints.geojson\r\n```\r\nOn the other hand, forcing the user to always provide the destination filename is a minor inconvenience as well (which we could mitigate a bit by automatically appending the `.geojson` suffix if it is missing).\r\n\r\nSince I rarely use the `--footprints` feature myself (I rely on the Python API) and the choice is not obvious, I would like to hear everyone else's take on this."},"comment":{"url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/comments/322154519","html_url":"https://github.com/sentinelsat/sentinelsat/issues/153#issuecomment-322154519","issue_url":"https://api.github.com/repos/sentinelsat/sentinelsat/issues/153","id":322154519,"user":{"login":"Fernerkundung","id":1621864,"avatar_url":"https://avatars2.githubusercontent.com/u/1621864?v=4","gravatar_id":"","url":"https://api.github.com/users/Fernerkundung","html_url":"https://github.com/Fernerkundung","followers_url":"https://api.github.com/users/Fernerkundung/followers","following_url":"https://api.github.com/users/Fernerkundung/following{/other_user}","gists_url":"https://api.github.com/users/Fernerkundung/gists{/gist_id}","starred_url":"https://api.github.com/users/Fernerkundung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fernerkundung/subscriptions","organizations_url":"https://api.github.com/users/Fernerkundung/orgs","repos_url":"https://api.github.com/users/Fernerkundung/repos","events_url":"https://api.github.com/users/Fernerkundung/events{/privacy}","received_events_url":"https://api.github.com/users/Fernerkundung/received_events","type":"User","site_admin":false},"created_at":"2017-08-14T10:20:18Z","updated_at":"2017-08-14T10:20:18Z","body":"> Can click do that at all - an option that works both as a flag (i.e. without following arguments) and as an option that takes a single argument?\r\n\r\nYou are right, implementing a flag that is also an option but only if the user provides input is indeed not supported by click (and might be hard to explain to the user).\r\n\r\n>  make `--footprints` an option that always requires a single argument, which can also be . (very quick to type) and if os.path.isdir(footprints_path) join it with the default search_footprints.geojson\r\n\r\nSo you want users to provide essentially a `--(footprint)-path`? I'd rather we use `--path` for that and use `--footprint` and require the user to provide the filename and append the suffix, like @valgur initially suggested."}}
{"actor":{"display_login":"Fernerkundung"}}