{"action":"created","issue":{"url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/2","repository_url":"https://api.github.com/repos/wealthsimple/rubocop-migration","labels_url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/2/comments","events_url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/2/events","html_url":"https://github.com/wealthsimple/rubocop-migration/issues/2","id":271598802,"number":2,"title":"Doesn't seem to obey `safety_assured` blocks","user":{"login":"ibrahima","id":47774,"avatar_url":"https://avatars1.githubusercontent.com/u/47774?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrahima","html_url":"https://github.com/ibrahima","followers_url":"https://api.github.com/users/ibrahima/followers","following_url":"https://api.github.com/users/ibrahima/following{/other_user}","gists_url":"https://api.github.com/users/ibrahima/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrahima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrahima/subscriptions","organizations_url":"https://api.github.com/users/ibrahima/orgs","repos_url":"https://api.github.com/users/ibrahima/repos","events_url":"https://api.github.com/users/ibrahima/events{/privacy}","received_events_url":"https://api.github.com/users/ibrahima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-06T19:51:26Z","updated_at":"2017-11-06T19:59:09Z","closed_at":null,"author_association":"NONE","body":"Hi! First of all, thanks for making this rubocop cop! I was about to make something similar after our 2nd or 3rd incident of brief downtime caused by an unsafe migration, but then I found this and was happy to see that it just uses strong_migrations for checking the migrations.\r\n\r\nOne thing though, it doesn't seem like the linter knows to ignore migrations that are wrapped in `safety_assured`. Is it supposed to, or is that just not implemented? I wasn't quite sure from looking at the code, but if it's just not implemented yet I might be able to find some time to work on a PR.\r\n\r\nThanks again!"},"comment":{"url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/comments/342268024","html_url":"https://github.com/wealthsimple/rubocop-migration/issues/2#issuecomment-342268024","issue_url":"https://api.github.com/repos/wealthsimple/rubocop-migration/issues/2","id":342268024,"user":{"login":"ibrahima","id":47774,"avatar_url":"https://avatars1.githubusercontent.com/u/47774?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrahima","html_url":"https://github.com/ibrahima","followers_url":"https://api.github.com/users/ibrahima/followers","following_url":"https://api.github.com/users/ibrahima/following{/other_user}","gists_url":"https://api.github.com/users/ibrahima/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrahima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrahima/subscriptions","organizations_url":"https://api.github.com/users/ibrahima/orgs","repos_url":"https://api.github.com/users/ibrahima/repos","events_url":"https://api.github.com/users/ibrahima/events{/privacy}","received_events_url":"https://api.github.com/users/ibrahima/received_events","type":"User","site_admin":false},"created_at":"2017-11-06T19:59:09Z","updated_at":"2017-11-06T19:59:09Z","author_association":"NONE","body":"The thing I'm confused about is what this commit is doing: https://github.com/wealthsimple/rubocop-migration/pull/1/commits/90ff8d2ff4c4f231bcc4220873f0dc57d7fb1161\r\n\r\nThe message makes it seem like it should ignore migrations wrapped in `safety_assured`, but the code looks like it just ignores specific migrations from a list?"}}
{"actor":{"display_login":"ibrahima"}}