{"action":"created","comment":{"url":"https://api.github.com/repos/csound/csound/pulls/comments/118004248","pull_request_review_id":39755980,"id":118004248,"diff_hunk":"@@ -169,24 +170,22 @@ else()\n endif()\r\n \r\n if(USE_PORTMIDI)\r\n-    set(pmidi_LIBS ${PORTMIDI_LIBRARY})\r\n     include_directories(${PORTMIDI_INCLUDE_PATH})\r\n+\tmake_plugin(pmidi pmidi.c)\r\n     if(LINUX)\r\n         if(NEED_PORTTIME)\r\n-           list(APPEND pmidi_LIBS ${PORTTIME_LIBRARY})\r\n-           include_directories(${PORTTIME_INCLUDE_PATH})\r\n-        endif()\r\n-    endif()\r\n-    if(WIN32)\r\n-      if(NEED_PORTTIME)\r\n-        include_directories(${PORTTIME_INCLUDE_PATH})\r\n-      endif()\r\n-        list(APPEND pmidi_LIBS ${CSOUND_WINDOWS_LIBRARIES})\r\n-    endif()\r\n-    if(LINUX AND ALSA_LIBRARY)\r\n-        list(APPEND pmidi_LIBS ${ALSA_LIBRARY})\r\n+\t\t\tinclude_directories(${PORTTIME_INCLUDE_PATH})\r","path":"InOut/CMakeLists.txt","position":31,"original_position":31,"commit_id":"54d121284ce7585d8686a93a1cd15ac154655057","original_commit_id":"54d121284ce7585d8686a93a1cd15ac154655057","user":{"login":"fsateler","id":1322013,"avatar_url":"https://avatars1.githubusercontent.com/u/1322013?v=3","gravatar_id":"","url":"https://api.github.com/users/fsateler","html_url":"https://github.com/fsateler","followers_url":"https://api.github.com/users/fsateler/followers","following_url":"https://api.github.com/users/fsateler/following{/other_user}","gists_url":"https://api.github.com/users/fsateler/gists{/gist_id}","starred_url":"https://api.github.com/users/fsateler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsateler/subscriptions","organizations_url":"https://api.github.com/users/fsateler/orgs","repos_url":"https://api.github.com/users/fsateler/repos","events_url":"https://api.github.com/users/fsateler/events{/privacy}","received_events_url":"https://api.github.com/users/fsateler/received_events","type":"User","site_admin":false},"body":"Indentation is off (using tabs instead of spaces) in some (but not all) cmake changes.","created_at":"2017-05-23T14:17:02Z","updated_at":"2017-05-23T14:21:21Z","html_url":"https://github.com/csound/csound/pull/797#discussion_r118004248","pull_request_url":"https://api.github.com/repos/csound/csound/pulls/797","_links":{"self":{"href":"https://api.github.com/repos/csound/csound/pulls/comments/118004248"},"html":{"href":"https://github.com/csound/csound/pull/797#discussion_r118004248"},"pull_request":{"href":"https://api.github.com/repos/csound/csound/pulls/797"}}},"pull_request":{"url":"https://api.github.com/repos/csound/csound/pulls/797","id":121958174,"html_url":"https://github.com/csound/csound/pull/797","diff_url":"https://github.com/csound/csound/pull/797.diff","patch_url":"https://github.com/csound/csound/pull/797.patch","issue_url":"https://api.github.com/repos/csound/csound/issues/797","number":797,"state":"open","locked":false,"title":"Numerous CMake changes for MSVC build","user":{"login":"stekyne","id":2091399,"avatar_url":"https://avatars0.githubusercontent.com/u/2091399?v=3","gravatar_id":"","url":"https://api.github.com/users/stekyne","html_url":"https://github.com/stekyne","followers_url":"https://api.github.com/users/stekyne/followers","following_url":"https://api.github.com/users/stekyne/following{/other_user}","gists_url":"https://api.github.com/users/stekyne/gists{/gist_id}","starred_url":"https://api.github.com/users/stekyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stekyne/subscriptions","organizations_url":"https://api.github.com/users/stekyne/orgs","repos_url":"https://api.github.com/users/stekyne/repos","events_url":"https://api.github.com/users/stekyne/events{/privacy}","received_events_url":"https://api.github.com/users/stekyne/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\n\r\nI've been working off this branch for a while and it's accumulated a lot of changes at this stage. I'd like to merge it back to develop now that it's building correctly on travis and appveyor.  \r\n\r\nI originally was going to do some big changes but I had to avoid that in the end and now it's just a collection of small changes. It does now build the swig interfaces, python, portmidi and liblo. I've put all the build settings into the custom-msvc.cmake file as well. There are some miscellaneous changes here and there in general. \r\n\r\nIf you guys think it looks ok, I'll merge it in.","created_at":"2017-05-23T09:59:09Z","updated_at":"2017-05-23T14:21:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c6a04429cc08339b7ebaffbc5f822277c38058a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/csound/csound/pulls/797/commits","review_comments_url":"https://api.github.com/repos/csound/csound/pulls/797/comments","review_comment_url":"https://api.github.com/repos/csound/csound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/csound/csound/issues/797/comments","statuses_url":"https://api.github.com/repos/csound/csound/statuses/54d121284ce7585d8686a93a1cd15ac154655057","head":{"label":"csound:msvc_cmake_changes_branch","ref":"msvc_cmake_changes_branch","sha":"54d121284ce7585d8686a93a1cd15ac154655057","user":{"login":"csound","id":4031607,"avatar_url":"https://avatars3.githubusercontent.com/u/4031607?v=3","gravatar_id":"","url":"https://api.github.com/users/csound","html_url":"https://github.com/csound","followers_url":"https://api.github.com/users/csound/followers","following_url":"https://api.github.com/users/csound/following{/other_user}","gists_url":"https://api.github.com/users/csound/gists{/gist_id}","starred_url":"https://api.github.com/users/csound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csound/subscriptions","organizations_url":"https://api.github.com/users/csound/orgs","repos_url":"https://api.github.com/users/csound/repos","events_url":"https://api.github.com/users/csound/events{/privacy}","received_events_url":"https://api.github.com/users/csound/received_events","type":"Organization","site_admin":false},"repo":{"id":18047592,"name":"csound","full_name":"csound/csound","owner":{"login":"csound","id":4031607,"avatar_url":"https://avatars3.githubusercontent.com/u/4031607?v=3","gravatar_id":"","url":"https://api.github.com/users/csound","html_url":"https://github.com/csound","followers_url":"https://api.github.com/users/csound/followers","following_url":"https://api.github.com/users/csound/following{/other_user}","gists_url":"https://api.github.com/users/csound/gists{/gist_id}","starred_url":"https://api.github.com/users/csound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csound/subscriptions","organizations_url":"https://api.github.com/users/csound/orgs","repos_url":"https://api.github.com/users/csound/repos","events_url":"https://api.github.com/users/csound/events{/privacy}","received_events_url":"https://api.github.com/users/csound/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/csound/csound","description":"Main repository for Csound","fork":false,"url":"https://api.github.com/repos/csound/csound","forks_url":"https://api.github.com/repos/csound/csound/forks","keys_url":"https://api.github.com/repos/csound/csound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csound/csound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csound/csound/teams","hooks_url":"https://api.github.com/repos/csound/csound/hooks","issue_events_url":"https://api.github.com/repos/csound/csound/issues/events{/number}","events_url":"https://api.github.com/repos/csound/csound/events","assignees_url":"https://api.github.com/repos/csound/csound/assignees{/user}","branches_url":"https://api.github.com/repos/csound/csound/branches{/branch}","tags_url":"https://api.github.com/repos/csound/csound/tags","blobs_url":"https://api.github.com/repos/csound/csound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csound/csound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csound/csound/git/refs{/sha}","trees_url":"https://api.github.com/repos/csound/csound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csound/csound/statuses/{sha}","languages_url":"https://api.github.com/repos/csound/csound/languages","stargazers_url":"https://api.github.com/repos/csound/csound/stargazers","contributors_url":"https://api.github.com/repos/csound/csound/contributors","subscribers_url":"https://api.github.com/repos/csound/csound/subscribers","subscription_url":"https://api.github.com/repos/csound/csound/subscription","commits_url":"https://api.github.com/repos/csound/csound/commits{/sha}","git_commits_url":"https://api.github.com/repos/csound/csound/git/commits{/sha}","comments_url":"https://api.github.com/repos/csound/csound/comments{/number}","issue_comment_url":"https://api.github.com/repos/csound/csound/issues/comments{/number}","contents_url":"https://api.github.com/repos/csound/csound/contents/{+path}","compare_url":"https://api.github.com/repos/csound/csound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csound/csound/merges","archive_url":"https://api.github.com/repos/csound/csound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csound/csound/downloads","issues_url":"https://api.github.com/repos/csound/csound/issues{/number}","pulls_url":"https://api.github.com/repos/csound/csound/pulls{/number}","milestones_url":"https://api.github.com/repos/csound/csound/milestones{/number}","notifications_url":"https://api.github.com/repos/csound/csound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csound/csound/labels{/name}","releases_url":"https://api.github.com/repos/csound/csound/releases{/id}","deployments_url":"https://api.github.com/repos/csound/csound/deployments","created_at":"2014-03-24T00:47:43Z","updated_at":"2017-05-23T10:31:25Z","pushed_at":"2017-05-23T13:59:55Z","git_url":"git://github.com/csound/csound.git","ssh_url":"git@github.com:csound/csound.git","clone_url":"https://github.com/csound/csound.git","svn_url":"https://github.com/csound/csound","homepage":null,"size":62625,"stargazers_count":385,"watchers_count":385,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":68,"forks":75,"open_issues":68,"watchers":385,"default_branch":"develop"}},"base":{"label":"csound:develop","ref":"develop","sha":"743f677ae8dda1a38ca7d7ebe8a231b5659e246e","user":{"login":"csound","id":4031607,"avatar_url":"https://avatars3.githubusercontent.com/u/4031607?v=3","gravatar_id":"","url":"https://api.github.com/users/csound","html_url":"https://github.com/csound","followers_url":"https://api.github.com/users/csound/followers","following_url":"https://api.github.com/users/csound/following{/other_user}","gists_url":"https://api.github.com/users/csound/gists{/gist_id}","starred_url":"https://api.github.com/users/csound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csound/subscriptions","organizations_url":"https://api.github.com/users/csound/orgs","repos_url":"https://api.github.com/users/csound/repos","events_url":"https://api.github.com/users/csound/events{/privacy}","received_events_url":"https://api.github.com/users/csound/received_events","type":"Organization","site_admin":false},"repo":{"id":18047592,"name":"csound","full_name":"csound/csound","owner":{"login":"csound","id":4031607,"avatar_url":"https://avatars3.githubusercontent.com/u/4031607?v=3","gravatar_id":"","url":"https://api.github.com/users/csound","html_url":"https://github.com/csound","followers_url":"https://api.github.com/users/csound/followers","following_url":"https://api.github.com/users/csound/following{/other_user}","gists_url":"https://api.github.com/users/csound/gists{/gist_id}","starred_url":"https://api.github.com/users/csound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csound/subscriptions","organizations_url":"https://api.github.com/users/csound/orgs","repos_url":"https://api.github.com/users/csound/repos","events_url":"https://api.github.com/users/csound/events{/privacy}","received_events_url":"https://api.github.com/users/csound/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/csound/csound","description":"Main repository for Csound","fork":false,"url":"https://api.github.com/repos/csound/csound","forks_url":"https://api.github.com/repos/csound/csound/forks","keys_url":"https://api.github.com/repos/csound/csound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csound/csound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csound/csound/teams","hooks_url":"https://api.github.com/repos/csound/csound/hooks","issue_events_url":"https://api.github.com/repos/csound/csound/issues/events{/number}","events_url":"https://api.github.com/repos/csound/csound/events","assignees_url":"https://api.github.com/repos/csound/csound/assignees{/user}","branches_url":"https://api.github.com/repos/csound/csound/branches{/branch}","tags_url":"https://api.github.com/repos/csound/csound/tags","blobs_url":"https://api.github.com/repos/csound/csound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csound/csound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csound/csound/git/refs{/sha}","trees_url":"https://api.github.com/repos/csound/csound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csound/csound/statuses/{sha}","languages_url":"https://api.github.com/repos/csound/csound/languages","stargazers_url":"https://api.github.com/repos/csound/csound/stargazers","contributors_url":"https://api.github.com/repos/csound/csound/contributors","subscribers_url":"https://api.github.com/repos/csound/csound/subscribers","subscription_url":"https://api.github.com/repos/csound/csound/subscription","commits_url":"https://api.github.com/repos/csound/csound/commits{/sha}","git_commits_url":"https://api.github.com/repos/csound/csound/git/commits{/sha}","comments_url":"https://api.github.com/repos/csound/csound/comments{/number}","issue_comment_url":"https://api.github.com/repos/csound/csound/issues/comments{/number}","contents_url":"https://api.github.com/repos/csound/csound/contents/{+path}","compare_url":"https://api.github.com/repos/csound/csound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csound/csound/merges","archive_url":"https://api.github.com/repos/csound/csound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csound/csound/downloads","issues_url":"https://api.github.com/repos/csound/csound/issues{/number}","pulls_url":"https://api.github.com/repos/csound/csound/pulls{/number}","milestones_url":"https://api.github.com/repos/csound/csound/milestones{/number}","notifications_url":"https://api.github.com/repos/csound/csound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csound/csound/labels{/name}","releases_url":"https://api.github.com/repos/csound/csound/releases{/id}","deployments_url":"https://api.github.com/repos/csound/csound/deployments","created_at":"2014-03-24T00:47:43Z","updated_at":"2017-05-23T10:31:25Z","pushed_at":"2017-05-23T13:59:55Z","git_url":"git://github.com/csound/csound.git","ssh_url":"git@github.com:csound/csound.git","clone_url":"https://github.com/csound/csound.git","svn_url":"https://github.com/csound/csound","homepage":null,"size":62625,"stargazers_count":385,"watchers_count":385,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":68,"forks":75,"open_issues":68,"watchers":385,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/csound/csound/pulls/797"},"html":{"href":"https://github.com/csound/csound/pull/797"},"issue":{"href":"https://api.github.com/repos/csound/csound/issues/797"},"comments":{"href":"https://api.github.com/repos/csound/csound/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/csound/csound/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/csound/csound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/csound/csound/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/csound/csound/statuses/54d121284ce7585d8686a93a1cd15ac154655057"}}}}
{"actor":{"display_login":"fsateler"}}