{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/146388979","pull_request_review_id":71324150,"id":146388979,"diff_hunk":"@@ -34,7 +35,9 @@\n       <header class=\"logo-container\">\n         <h1>\n           <a href=\"{{ LMS_ROOT_URL }}\"><img src=\"{% static 'images/logo.png' %}\" alt=\"{{ header_logo_alt_text }}\" /></a>","path":"enterprise/templates/enterprise/base.html","position":null,"original_position":18,"commit_id":"42edc2b8e72a033488282e3555993d98cf78cc3c","original_commit_id":"e64109d72f89f55ce88804a0d4930444f238bbd1","user":{"login":"BessieSteinberg","id":5060285,"avatar_url":"https://avatars3.githubusercontent.com/u/5060285?v=4","gravatar_id":"","url":"https://api.github.com/users/BessieSteinberg","html_url":"https://github.com/BessieSteinberg","followers_url":"https://api.github.com/users/BessieSteinberg/followers","following_url":"https://api.github.com/users/BessieSteinberg/following{/other_user}","gists_url":"https://api.github.com/users/BessieSteinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/BessieSteinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BessieSteinberg/subscriptions","organizations_url":"https://api.github.com/users/BessieSteinberg/orgs","repos_url":"https://api.github.com/users/BessieSteinberg/repos","events_url":"https://api.github.com/users/BessieSteinberg/events{/privacy}","received_events_url":"https://api.github.com/users/BessieSteinberg/received_events","type":"User","site_admin":false},"body":"Added this too, thank you!","created_at":"2017-10-23T20:46:46Z","updated_at":"2017-10-23T20:46:46Z","html_url":"https://github.com/edx/edx-enterprise/pull/216#discussion_r146388979","pull_request_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/216","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/146388979"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/216#discussion_r146388979"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/216"}},"in_reply_to_id":144566910},"pull_request":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/216","id":146264195,"html_url":"https://github.com/edx/edx-enterprise/pull/216","diff_url":"https://github.com/edx/edx-enterprise/pull/216.diff","patch_url":"https://github.com/edx/edx-enterprise/pull/216.patch","issue_url":"https://api.github.com/repos/edx/edx-enterprise/issues/216","number":216,"state":"open","locked":false,"title":"Improve Theming of Enterprise Pages","user":{"login":"BessieSteinberg","id":5060285,"avatar_url":"https://avatars3.githubusercontent.com/u/5060285?v=4","gravatar_id":"","url":"https://api.github.com/users/BessieSteinberg","html_url":"https://github.com/BessieSteinberg","followers_url":"https://api.github.com/users/BessieSteinberg/followers","following_url":"https://api.github.com/users/BessieSteinberg/following{/other_user}","gists_url":"https://api.github.com/users/BessieSteinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/BessieSteinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BessieSteinberg/subscriptions","organizations_url":"https://api.github.com/users/BessieSteinberg/orgs","repos_url":"https://api.github.com/users/BessieSteinberg/repos","events_url":"https://api.github.com/users/BessieSteinberg/events{/privacy}","received_events_url":"https://api.github.com/users/BessieSteinberg/received_events","type":"User","site_admin":false},"body":"1. Set height of header logo so that regardless of the size of theme's\r\n   logo, it shows up as the correct height.\r\n2. Fixed bug where sites that had not set 'ENTERPRISE_TAGLINE' in\r\n   their site configs would show '{}' as the tagline\r\n3. Made favicon in browser be site specific\r\n\r\n**Description:** Describe in a couple of sentence what this PR adds\r\n\r\n**JIRA:** Link to JIRA ticket\r\n\r\n**Dependencies:** dependencies on other outstanding PRs, issues, etc. \r\n\r\n**Merge deadline:** List merge deadline (if any)\r\n\r\n**Installation instructions:** List any non-trivial installation \r\ninstructions.\r\n\r\n**Testing instructions:**\r\n\r\n1. Open page A\r\n2. Do thing B\r\n3. Expect C to happen\r\n4. If D happend instead - check failed.\r\n\r\n**Merge checklist:**\r\n\r\n- [ ] Check that the versions of the requirements in the `platform-master.in` file match edx-platform.\r\n- [ ] New requirements are in the right place (`base.in` if only used in enterprise; in the correct `platform-****.in` files if they're hosted in edx-platform)\r\n- [ ] Regenerate requirements with `make upgrade && make requirements` (and make sure to fix any errors).\r\n  **DO NOT** just add dependencies to `requirements/*.txt` files.\r\n- [ ] Called `make static` for webpack bundling if any static content was updated.\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Version bumped\r\n- [ ] Changelog record added\r\n- [ ] Documentation updated (not only docstrings)\r\n- [ ] Commits are (reasonably) squashed\r\n- [ ] Translations are updated\r\n- [ ] PR author is listed in AUTHORS\r\n\r\n**Post merge:**\r\n- [ ] Create a tag\r\n- [ ] Check new version is pushed to PyPi after tag-triggered build is finished.\r\n- [ ] Delete working branch (if not needed anymore)\r\n- [ ] edx-platform PR (be sure to include edx-platform requirements upgrades that were present in this PR)\r\n\r\n**Author concerns:** List any concerns about this PR - inelegant \r\nsolutions, hacks, quick-and-dirty implementations, concerns about \r\nmigrations, etc.\r\n","created_at":"2017-10-12T17:06:14Z","updated_at":"2017-10-23T20:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93fca0ac987e8ec1860b16bec28b5712b24b0a9a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"douglashall","id":224634,"avatar_url":"https://avatars2.githubusercontent.com/u/224634?v=4","gravatar_id":"","url":"https://api.github.com/users/douglashall","html_url":"https://github.com/douglashall","followers_url":"https://api.github.com/users/douglashall/followers","following_url":"https://api.github.com/users/douglashall/following{/other_user}","gists_url":"https://api.github.com/users/douglashall/gists{/gist_id}","starred_url":"https://api.github.com/users/douglashall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglashall/subscriptions","organizations_url":"https://api.github.com/users/douglashall/orgs","repos_url":"https://api.github.com/users/douglashall/repos","events_url":"https://api.github.com/users/douglashall/events{/privacy}","received_events_url":"https://api.github.com/users/douglashall/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/216/commits","review_comments_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/216/comments","review_comment_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/issues/216/comments","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/42edc2b8e72a033488282e3555993d98cf78cc3c","head":{"label":"edx:bessiesteinberg/theme-data-sharing-consent-page","ref":"bessiesteinberg/theme-data-sharing-consent-page","sha":"42edc2b8e72a033488282e3555993d98cf78cc3c","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-08-20T11:15:04Z","pushed_at":"2017-10-23T20:36:07Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":2167,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"001cc891fc2841e2845fd6540b66c190399d360f","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-08-20T11:15:04Z","pushed_at":"2017-10-23T20:36:07Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":2167,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/216"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/216"},"issue":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/216"},"comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-enterprise/statuses/42edc2b8e72a033488282e3555993d98cf78cc3c"}},"author_association":"NONE"}}
{"actor":{"display_login":"BessieSteinberg"}}