{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/comments/105557273","pull_request_review_id":26444721,"id":105557273,"diff_hunk":"@@ -0,0 +1,94 @@\n+from bears.elm.ElmLintBear import ElmLintBear\n+from coalib.testing.LocalBearTestHelper import verify_local_bear\n+\n+good_file_no_unexpected_comma = \"\"\"\n+ab =\n+  \"Hello World!\"\n+\"\"\"\n+\n+bad_file_unexpected_comma = \"\"\"\n+a, b =\n+  \"Hello World!\"\n+\"\"\"\n+\n+good_file_no_unexpected_end_of_input = \"\"\"\n+foo =\n+  100\n+\"\"\"\n+\n+bad_file_unexpected_end_of_input = \"\"\"\n+foo =\n+\"\"\"\n+\n+good_file_not_empty = \"\"\"\n+add x y = x + y\n+\"\"\"\n+\n+bad_file_empty = \"\"\"\n+\"\"\"\n+\n+good_file_comment = \"\"\"\n+foo =\n+  5 * 3 - 8 / 1\n+-- A single line comment\n+\"\"\"\n+\n+bad_file_comment = \"\"\"\n+-- A single line comment\n+\"\"\"\n+\n+good_file_list = \"\"\"\n+l =\n+  [\"one\", \"two\", \"three\"]\n+\"\"\"\n+\n+bad_file_list = \"\"\"\n+l =\n+  [\"one\", \"two\", \"three\"\n+\"\"\"\n+\n+good_file_function = \"\"\"\n+import Html exposing (text)\n+four =\n+  sqrt 16\n+main =\n+  text (toString [four])\n+\"\"\"\n+\n+bad_file_function = \"\"\"\n+import Html exposing (text)\n+four =\n+  sqr 16\n+main =\n+  text (toString [four)\n+\"\"\"\n+\n+UnexpectedCommaTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_no_unexpected_comma,),\n+    invalid_files=(bad_file_unexpected_comma,))\n+\n+UnexpectedEndOfInputTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_no_unexpected_end_of_input,),\n+    invalid_files=(bad_file_unexpected_end_of_input,))\n+\n+EmptyFileTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_not_empty,),\n+    invalid_files=(bad_file_empty,))\n+\n+CommentTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_comment,),\n+    invalid_files=(bad_file_comment,))\n+\n+ListTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_list,),\n+    invalid_files=(bad_file_list,))\n+\n+FunctionTest = verify_local_bear(\n+    ElmLintBear,\n+    valid_files=(good_file_function,),\n+    invalid_files=(bad_file_function,))","path":"tests/elm/ElmLintBearTest.py","position":null,"original_position":94,"commit_id":"4423634b041ba496a3c3431d54a9b24d42720e2e","original_commit_id":"5a7f8c41a8f2456d97aeafd06c73fb4bd2a6ed56","user":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars2.githubusercontent.com/u/14862976?v=3","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"body":"I have addressed your comments @sils . Please have a look when you are free. ;)","created_at":"2017-03-12T13:15:42Z","updated_at":"2017-03-12T13:15:42Z","html_url":"https://github.com/coala/coala-bears/pull/1480#discussion_r105557273","pull_request_url":"https://api.github.com/repos/coala/coala-bears/pulls/1480","_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments/105557273"},"html":{"href":"https://github.com/coala/coala-bears/pull/1480#discussion_r105557273"},"pull_request":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1480"}}},"pull_request":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/1480","id":109108628,"html_url":"https://github.com/coala/coala-bears/pull/1480","diff_url":"https://github.com/coala/coala-bears/pull/1480.diff","patch_url":"https://github.com/coala/coala-bears/pull/1480.patch","issue_url":"https://api.github.com/repos/coala/coala-bears/issues/1480","number":1480,"state":"open","locked":false,"title":"bears/elm: Add ElmLintBear","user":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars2.githubusercontent.com/u/14862976?v=3","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/coala/coala-bears/issues/1073\r\n\r\n<!--\r\nThanks for your contribution!\r\n\r\nPlease take a quick look at those things down there. They're quite important.\r\nReally! We wrote them for you. Yes you! With utmost care. Read them.\r\n-->\r\n\r\n**For short term contributors:** we understand that getting your commits well\r\ndefined like we require is a hard task and takes some learning. If you\r\nlook to help without wanting to contribute long term there's no need\r\nfor you to learn this. Just drop us a message and we'll take care of brushing\r\nup your stuff for merge!\r\n\r\n### Checklist\r\n\r\n- [ ] I read the [commit guidelines](http://coala.io/commit) and I've followed\r\n      them.\r\n- [ ] I ran coala over my code locally. (*All commits have to pass\r\n      individually.* It is not sufficient to have \"fixup commits\" on your PR,\r\n      our bot will still report the issues for the previous commit.) You will\r\n      likely receive a lot of bot comments and build failures if coala does not\r\n      pass on every single commit!\r\n\r\nAfter you submit your pull request, **DO NOT click the 'Update Branch' button.**\r\nWhen asked for a rebase, consult [coala.io/rebase](https://coala.io/rebase)\r\ninstead.\r\n\r\nPlease consider helping us by reviewing other peoples pull requests as well:\r\n\r\n- pick up any PR at <https://coala.io/review>\r\n- review it (check <https://coala.io/reviewing> for more info)\r\n- if you are sure that it needs work, use `cobot mark wip <URL>` to get it out\r\n  of the review queue.\r\n\r\nThe more you review, the more your score will grow at coala.io and we will\r\nreview your PRs faster!\r\n","created_at":"2017-03-04T14:06:08Z","updated_at":"2017-03-12T13:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3159165fea20cb0f009fc39acf04c1f5c99dabe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala-bears/pulls/1480/commits","review_comments_url":"https://api.github.com/repos/coala/coala-bears/pulls/1480/comments","review_comment_url":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala-bears/issues/1480/comments","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/4423634b041ba496a3c3431d54a9b24d42720e2e","head":{"label":"yash-nisar:iss#1073","ref":"iss#1073","sha":"4423634b041ba496a3c3431d54a9b24d42720e2e","user":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars2.githubusercontent.com/u/14862976?v=3","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"repo":{"id":65023217,"name":"coala-bears","full_name":"yash-nisar/coala-bears","owner":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars2.githubusercontent.com/u/14862976?v=3","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yash-nisar/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/yash-nisar/coala-bears","forks_url":"https://api.github.com/repos/yash-nisar/coala-bears/forks","keys_url":"https://api.github.com/repos/yash-nisar/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yash-nisar/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yash-nisar/coala-bears/teams","hooks_url":"https://api.github.com/repos/yash-nisar/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/yash-nisar/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/yash-nisar/coala-bears/events","assignees_url":"https://api.github.com/repos/yash-nisar/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/yash-nisar/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/yash-nisar/coala-bears/tags","blobs_url":"https://api.github.com/repos/yash-nisar/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yash-nisar/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yash-nisar/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/yash-nisar/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yash-nisar/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/yash-nisar/coala-bears/languages","stargazers_url":"https://api.github.com/repos/yash-nisar/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/yash-nisar/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/yash-nisar/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/yash-nisar/coala-bears/subscription","commits_url":"https://api.github.com/repos/yash-nisar/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/yash-nisar/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/yash-nisar/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/yash-nisar/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/yash-nisar/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/yash-nisar/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yash-nisar/coala-bears/merges","archive_url":"https://api.github.com/repos/yash-nisar/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yash-nisar/coala-bears/downloads","issues_url":"https://api.github.com/repos/yash-nisar/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/yash-nisar/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/yash-nisar/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/yash-nisar/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yash-nisar/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/yash-nisar/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/yash-nisar/coala-bears/deployments","created_at":"2016-08-05T14:04:30Z","updated_at":"2016-08-05T14:04:31Z","pushed_at":"2017-03-12T13:14:20Z","git_url":"git://github.com/yash-nisar/coala-bears.git","ssh_url":"git@github.com:yash-nisar/coala-bears.git","clone_url":"https://github.com/yash-nisar/coala-bears.git","svn_url":"https://github.com/yash-nisar/coala-bears","homepage":"http://coala-analyzer.org/","size":1472,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"b64a6da3a3744557052b8ea1ae416b96c5485ae1","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars0.githubusercontent.com/u/10620750?v=3","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":51688289,"name":"coala-bears","full_name":"coala/coala-bears","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars0.githubusercontent.com/u/10620750?v=3","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala-bears","description":"Bears for coala","fork":false,"url":"https://api.github.com/repos/coala/coala-bears","forks_url":"https://api.github.com/repos/coala/coala-bears/forks","keys_url":"https://api.github.com/repos/coala/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala-bears/teams","hooks_url":"https://api.github.com/repos/coala/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/coala/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala-bears/events","assignees_url":"https://api.github.com/repos/coala/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala-bears/tags","blobs_url":"https://api.github.com/repos/coala/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala-bears/languages","stargazers_url":"https://api.github.com/repos/coala/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/coala/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/coala/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/coala/coala-bears/subscription","commits_url":"https://api.github.com/repos/coala/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala-bears/merges","archive_url":"https://api.github.com/repos/coala/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala-bears/downloads","issues_url":"https://api.github.com/repos/coala/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala-bears/deployments","created_at":"2016-02-14T09:25:11Z","updated_at":"2017-03-10T16:34:54Z","pushed_at":"2017-03-12T13:14:21Z","git_url":"git://github.com/coala/coala-bears.git","ssh_url":"git@github.com:coala/coala-bears.git","clone_url":"https://github.com/coala/coala-bears.git","svn_url":"https://github.com/coala/coala-bears","homepage":"https://coala.io/","size":1526,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":369,"forks":250,"open_issues":369,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1480"},"html":{"href":"https://github.com/coala/coala-bears/pull/1480"},"issue":{"href":"https://api.github.com/repos/coala/coala-bears/issues/1480"},"comments":{"href":"https://api.github.com/repos/coala/coala-bears/issues/1480/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1480/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1480/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala-bears/statuses/4423634b041ba496a3c3431d54a9b24d42720e2e"}}}}
{"actor":{"display_login":"yash-nisar"}}