{"action":"created","issue":{"url":"https://api.github.com/repos/nucleic/enaml/issues/234","repository_url":"https://api.github.com/repos/nucleic/enaml","labels_url":"https://api.github.com/repos/nucleic/enaml/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/nucleic/enaml/issues/234/comments","events_url":"https://api.github.com/repos/nucleic/enaml/issues/234/events","html_url":"https://github.com/nucleic/enaml/issues/234","id":274618958,"number":234,"title":"pip install enaml fails to build with python 2.7","user":{"login":"frmdstryr","id":380158,"avatar_url":"https://avatars2.githubusercontent.com/u/380158?v=4","gravatar_id":"","url":"https://api.github.com/users/frmdstryr","html_url":"https://github.com/frmdstryr","followers_url":"https://api.github.com/users/frmdstryr/followers","following_url":"https://api.github.com/users/frmdstryr/following{/other_user}","gists_url":"https://api.github.com/users/frmdstryr/gists{/gist_id}","starred_url":"https://api.github.com/users/frmdstryr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frmdstryr/subscriptions","organizations_url":"https://api.github.com/users/frmdstryr/orgs","repos_url":"https://api.github.com/users/frmdstryr/repos","events_url":"https://api.github.com/users/frmdstryr/events{/privacy}","received_events_url":"https://api.github.com/users/frmdstryr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-11-16T18:34:39Z","updated_at":"2017-11-16T20:01:00Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Sorry for spamming with issues.... It's also failing from master.\r\n\r\n```\r\n    cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++\r\n    enaml/src/alias.cpp:361:28: warning: ‘_state’ defined but not used [-Wunused-variable]\r\n     static struct module_state _state;\r\n                                ^\r\n    c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/enaml/src/alias.o -o build/lib.linux-x86_64-2.7/enaml/core/alias.so\r\n    building 'enaml.core.declarative_function' extension\r\n    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c enaml/src/declarative_function.cpp -o build/temp.linux-x86_64-2.7/enaml/src/declarative_function.o\r\n    cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++\r\n    enaml/src/declarative_function.cpp: In function ‘PyObject* DFunc_repr(DFunc*)’:\r\n    enaml/src/declarative_function.cpp:159:51: error: format not a string literal and no format arguments [-Werror=format-security]\r\n         return Py23Str_FromFormat( ostr.str().c_str() );\r\n                                                       ^\r\n    enaml/src/declarative_function.cpp: At global scope:\r\n    enaml/src/declarative_function.cpp:494:28: warning: ‘_state’ defined but not used [-Wunused-variable]\r\n     static struct module_state _state;\r\n                                ^\r\n    cc1plus: some warnings being treated as errors\r\n    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1\r\n   ```\r\n\r\n```\r\nenaml/src/declarative_function.cpp:159:51: error: format not a string literal and no format arguments [-Werror=format-security]\r\n         return Py23Str_FromFormat( ostr.str().c_str() );\r\n\r\n```\r\n\r\nInstalling `enaml==0.9.8` works .\r\n"},"comment":{"url":"https://api.github.com/repos/nucleic/enaml/issues/comments/345045428","html_url":"https://github.com/nucleic/enaml/issues/234#issuecomment-345045428","issue_url":"https://api.github.com/repos/nucleic/enaml/issues/234","id":345045428,"user":{"login":"frmdstryr","id":380158,"avatar_url":"https://avatars2.githubusercontent.com/u/380158?v=4","gravatar_id":"","url":"https://api.github.com/users/frmdstryr","html_url":"https://github.com/frmdstryr","followers_url":"https://api.github.com/users/frmdstryr/followers","following_url":"https://api.github.com/users/frmdstryr/following{/other_user}","gists_url":"https://api.github.com/users/frmdstryr/gists{/gist_id}","starred_url":"https://api.github.com/users/frmdstryr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frmdstryr/subscriptions","organizations_url":"https://api.github.com/users/frmdstryr/orgs","repos_url":"https://api.github.com/users/frmdstryr/repos","events_url":"https://api.github.com/users/frmdstryr/events{/privacy}","received_events_url":"https://api.github.com/users/frmdstryr/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T20:01:00Z","updated_at":"2017-11-16T20:01:00Z","author_association":"CONTRIBUTOR","body":"Ok, yeah it seems to make no difference. So the switch to `Py23Str_FromString` at least fixes 2.7."}}
{"actor":{"display_login":"frmdstryr"}}