{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments/156816227","pull_request_review_id":83355669,"id":156816227,"diff_hunk":"@@ -159,6 +159,47 @@ module.exports = {\n };\n ```\n \n+## Mutating `neutrino.options`\n+\n+While it is possible to mutate `neutrino.options` directly, this should be avoided.\n+Instead, it is _always recommended_ to pass an `options` object to ensure proper normalization.\n+\n+```js\n+// Bad: Using function format, overriding `neutrino.options` properites.\n+// Paths will not be relative to `neutrino.options.root` as expected.\n+module.exports = neutrino => {\n+  Object.assign(neutrino.options, {\n+    source: 'lib'\n+  });\n+\n+  neutrino.options.output = 'dist';","path":"docs/customization/README.md","position":17,"original_position":17,"commit_id":"a6eb82850fe57890ac4b15512c73bc27eb153819","original_commit_id":"a6eb82850fe57890ac4b15512c73bc27eb153819","user":{"login":"timkelty","id":18329,"avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"body":"Ah, wondered about that - I'll change it.","created_at":"2017-12-13T23:28:51Z","updated_at":"2017-12-13T23:28:52Z","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614#discussion_r156816227","pull_request_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments/156816227"},"html":{"href":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614#discussion_r156816227"},"pull_request":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614"}},"in_reply_to_id":156788118},"pull_request":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614","id":158152775,"html_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614","diff_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614.diff","patch_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614.patch","issue_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/614","number":614,"state":"open","locked":false,"title":"Warn about the evils of mutating `neutrino.options`.","user":{"login":"timkelty","id":18329,"avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-13T17:12:50Z","updated_at":"2017-12-13T23:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae9e1a799ddad2993c93189d783c78198f8ff8c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614/commits","review_comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614/comments","review_comment_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/614/comments","statuses_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/a6eb82850fe57890ac4b15512c73bc27eb153819","head":{"label":"mozilla-neutrino:docs-options-override-warning","ref":"docs-options-override-warning","sha":"a6eb82850fe57890ac4b15512c73bc27eb153819","user":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"repo":{"id":80793561,"name":"neutrino-dev","full_name":"mozilla-neutrino/neutrino-dev","owner":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-neutrino/neutrino-dev","description":"Create and build modern JavaScript applications with zero initial configuration.","fork":false,"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev","forks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/forks","keys_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/teams","hooks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/events","assignees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/tags","blobs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscription","commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/merges","archive_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/downloads","issues_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/deployments","created_at":"2017-02-03T03:27:20Z","updated_at":"2017-12-13T22:13:40Z","pushed_at":"2017-12-13T21:27:29Z","git_url":"git://github.com/mozilla-neutrino/neutrino-dev.git","ssh_url":"git@github.com:mozilla-neutrino/neutrino-dev.git","clone_url":"https://github.com/mozilla-neutrino/neutrino-dev.git","svn_url":"https://github.com/mozilla-neutrino/neutrino-dev","homepage":"https://neutrino.js.org","size":8187,"stargazers_count":2129,"watchers_count":2129,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":120,"open_issues":39,"watchers":2129,"default_branch":"master"}},"base":{"label":"mozilla-neutrino:master","ref":"master","sha":"7c41bc65f794e63c1dc1265dd08fa5193aac0b81","user":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"repo":{"id":80793561,"name":"neutrino-dev","full_name":"mozilla-neutrino/neutrino-dev","owner":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-neutrino/neutrino-dev","description":"Create and build modern JavaScript applications with zero initial configuration.","fork":false,"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev","forks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/forks","keys_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/teams","hooks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/events","assignees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/tags","blobs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscription","commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/merges","archive_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/downloads","issues_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/deployments","created_at":"2017-02-03T03:27:20Z","updated_at":"2017-12-13T22:13:40Z","pushed_at":"2017-12-13T21:27:29Z","git_url":"git://github.com/mozilla-neutrino/neutrino-dev.git","ssh_url":"git@github.com:mozilla-neutrino/neutrino-dev.git","clone_url":"https://github.com/mozilla-neutrino/neutrino-dev.git","svn_url":"https://github.com/mozilla-neutrino/neutrino-dev","homepage":"https://neutrino.js.org","size":8187,"stargazers_count":2129,"watchers_count":2129,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":120,"open_issues":39,"watchers":2129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614"},"html":{"href":"https://github.com/mozilla-neutrino/neutrino-dev/pull/614"},"issue":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/614"},"comments":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/a6eb82850fe57890ac4b15512c73bc27eb153819"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timkelty"}}