{"action":"created","comment":{"url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments/112346782","pull_request_review_id":33654714,"id":112346782,"diff_hunk":"@@ -9,3 +10,14 @@ test('can be instantiated', function(assert) {\n   let app = new Application({ rootName: 'app', resolver: new BlankResolver });\n   assert.ok(app, 'app exists');\n });\n+\n+test('accepts options for rootName, resolver and document', function(assert) {\n+  const resolver = new BlankResolver;\n+  let app = new Application({ rootName: 'app', resolver });\n+  assert.equal(app.rootName, 'app');\n+  assert.equal(app.resolver, resolver);\n+  assert.equal(app.document, window.document, 'defaults to window document if document is not provided in options');\n+  let customDocument = <Simple.Document>{};","path":"test/application-test.ts","position":18,"original_position":18,"commit_id":"8dba08de82c351a3f134d3a962ffd0c97dbc12c9","original_commit_id":"8dba08de82c351a3f134d3a962ffd0c97dbc12c9","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars3.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"I wonder if we can actually bring in `simple-dom` and test rendering here in a test?\r\n\r\nIt _seems_ like it should work, and it would be nice to confirm it does via a test (even though the tests will still be running in the browser)...","created_at":"2017-04-20T01:04:35Z","updated_at":"2017-04-20T01:04:37Z","html_url":"https://github.com/glimmerjs/glimmer-application/pull/61#discussion_r112346782","pull_request_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments/112346782"},"html":{"href":"https://github.com/glimmerjs/glimmer-application/pull/61#discussion_r112346782"},"pull_request":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61","id":116251166,"html_url":"https://github.com/glimmerjs/glimmer-application/pull/61","diff_url":"https://github.com/glimmerjs/glimmer-application/pull/61.diff","patch_url":"https://github.com/glimmerjs/glimmer-application/pull/61.patch","issue_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/61","number":61,"state":"open","locked":false,"title":"Allow Application to receive document as option","user":{"login":"josemarluedke","id":230476,"avatar_url":"https://avatars3.githubusercontent.com/u/230476?v=3","gravatar_id":"","url":"https://api.github.com/users/josemarluedke","html_url":"https://github.com/josemarluedke","followers_url":"https://api.github.com/users/josemarluedke/followers","following_url":"https://api.github.com/users/josemarluedke/following{/other_user}","gists_url":"https://api.github.com/users/josemarluedke/gists{/gist_id}","starred_url":"https://api.github.com/users/josemarluedke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemarluedke/subscriptions","organizations_url":"https://api.github.com/users/josemarluedke/orgs","repos_url":"https://api.github.com/users/josemarluedke/repos","events_url":"https://api.github.com/users/josemarluedke/events{/privacy}","received_events_url":"https://api.github.com/users/josemarluedke/received_events","type":"User","site_admin":false},"body":"This allow some experimenting with Server Side Rendering. With this change it's possible to use `simple-dom` to render the application.\r\n\r\nAlso removes all the usages of `window.document` to use the new option.","created_at":"2017-04-18T04:54:45Z","updated_at":"2017-04-20T01:04:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"613fbc2470722ee2a1a458b4a9876df7c813bd11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61/commits","review_comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61/comments","review_comment_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/61/comments","statuses_url":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/8dba08de82c351a3f134d3a962ffd0c97dbc12c9","head":{"label":"josemarluedke:add-document-to-app-options","ref":"add-document-to-app-options","sha":"8dba08de82c351a3f134d3a962ffd0c97dbc12c9","user":{"login":"josemarluedke","id":230476,"avatar_url":"https://avatars3.githubusercontent.com/u/230476?v=3","gravatar_id":"","url":"https://api.github.com/users/josemarluedke","html_url":"https://github.com/josemarluedke","followers_url":"https://api.github.com/users/josemarluedke/followers","following_url":"https://api.github.com/users/josemarluedke/following{/other_user}","gists_url":"https://api.github.com/users/josemarluedke/gists{/gist_id}","starred_url":"https://api.github.com/users/josemarluedke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemarluedke/subscriptions","organizations_url":"https://api.github.com/users/josemarluedke/orgs","repos_url":"https://api.github.com/users/josemarluedke/repos","events_url":"https://api.github.com/users/josemarluedke/events{/privacy}","received_events_url":"https://api.github.com/users/josemarluedke/received_events","type":"User","site_admin":false},"repo":{"id":86614898,"name":"glimmer-application","full_name":"josemarluedke/glimmer-application","owner":{"login":"josemarluedke","id":230476,"avatar_url":"https://avatars3.githubusercontent.com/u/230476?v=3","gravatar_id":"","url":"https://api.github.com/users/josemarluedke","html_url":"https://github.com/josemarluedke","followers_url":"https://api.github.com/users/josemarluedke/followers","following_url":"https://api.github.com/users/josemarluedke/following{/other_user}","gists_url":"https://api.github.com/users/josemarluedke/gists{/gist_id}","starred_url":"https://api.github.com/users/josemarluedke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemarluedke/subscriptions","organizations_url":"https://api.github.com/users/josemarluedke/orgs","repos_url":"https://api.github.com/users/josemarluedke/repos","events_url":"https://api.github.com/users/josemarluedke/events{/privacy}","received_events_url":"https://api.github.com/users/josemarluedke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josemarluedke/glimmer-application","description":null,"fork":true,"url":"https://api.github.com/repos/josemarluedke/glimmer-application","forks_url":"https://api.github.com/repos/josemarluedke/glimmer-application/forks","keys_url":"https://api.github.com/repos/josemarluedke/glimmer-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josemarluedke/glimmer-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josemarluedke/glimmer-application/teams","hooks_url":"https://api.github.com/repos/josemarluedke/glimmer-application/hooks","issue_events_url":"https://api.github.com/repos/josemarluedke/glimmer-application/issues/events{/number}","events_url":"https://api.github.com/repos/josemarluedke/glimmer-application/events","assignees_url":"https://api.github.com/repos/josemarluedke/glimmer-application/assignees{/user}","branches_url":"https://api.github.com/repos/josemarluedke/glimmer-application/branches{/branch}","tags_url":"https://api.github.com/repos/josemarluedke/glimmer-application/tags","blobs_url":"https://api.github.com/repos/josemarluedke/glimmer-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josemarluedke/glimmer-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josemarluedke/glimmer-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/josemarluedke/glimmer-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josemarluedke/glimmer-application/statuses/{sha}","languages_url":"https://api.github.com/repos/josemarluedke/glimmer-application/languages","stargazers_url":"https://api.github.com/repos/josemarluedke/glimmer-application/stargazers","contributors_url":"https://api.github.com/repos/josemarluedke/glimmer-application/contributors","subscribers_url":"https://api.github.com/repos/josemarluedke/glimmer-application/subscribers","subscription_url":"https://api.github.com/repos/josemarluedke/glimmer-application/subscription","commits_url":"https://api.github.com/repos/josemarluedke/glimmer-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/josemarluedke/glimmer-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/josemarluedke/glimmer-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/josemarluedke/glimmer-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/josemarluedke/glimmer-application/contents/{+path}","compare_url":"https://api.github.com/repos/josemarluedke/glimmer-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josemarluedke/glimmer-application/merges","archive_url":"https://api.github.com/repos/josemarluedke/glimmer-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josemarluedke/glimmer-application/downloads","issues_url":"https://api.github.com/repos/josemarluedke/glimmer-application/issues{/number}","pulls_url":"https://api.github.com/repos/josemarluedke/glimmer-application/pulls{/number}","milestones_url":"https://api.github.com/repos/josemarluedke/glimmer-application/milestones{/number}","notifications_url":"https://api.github.com/repos/josemarluedke/glimmer-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josemarluedke/glimmer-application/labels{/name}","releases_url":"https://api.github.com/repos/josemarluedke/glimmer-application/releases{/id}","deployments_url":"https://api.github.com/repos/josemarluedke/glimmer-application/deployments","created_at":"2017-03-29T18:16:54Z","updated_at":"2017-03-29T18:16:56Z","pushed_at":"2017-04-19T22:27:09Z","git_url":"git://github.com/josemarluedke/glimmer-application.git","ssh_url":"git@github.com:josemarluedke/glimmer-application.git","clone_url":"https://github.com/josemarluedke/glimmer-application.git","svn_url":"https://github.com/josemarluedke/glimmer-application","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"glimmerjs:master","ref":"master","sha":"c085b463c9f21f73442b8d8a58918e564aa12642","user":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":80530646,"name":"glimmer-application","full_name":"glimmerjs/glimmer-application","owner":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glimmerjs/glimmer-application","description":null,"fork":false,"url":"https://api.github.com/repos/glimmerjs/glimmer-application","forks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/forks","keys_url":"https://api.github.com/repos/glimmerjs/glimmer-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glimmerjs/glimmer-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glimmerjs/glimmer-application/teams","hooks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/hooks","issue_events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/events{/number}","events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/events","assignees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/assignees{/user}","branches_url":"https://api.github.com/repos/glimmerjs/glimmer-application/branches{/branch}","tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/tags","blobs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/{sha}","languages_url":"https://api.github.com/repos/glimmerjs/glimmer-application/languages","stargazers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/stargazers","contributors_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contributors","subscribers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscribers","subscription_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscription","commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contents/{+path}","compare_url":"https://api.github.com/repos/glimmerjs/glimmer-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glimmerjs/glimmer-application/merges","archive_url":"https://api.github.com/repos/glimmerjs/glimmer-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glimmerjs/glimmer-application/downloads","issues_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues{/number}","pulls_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls{/number}","milestones_url":"https://api.github.com/repos/glimmerjs/glimmer-application/milestones{/number}","notifications_url":"https://api.github.com/repos/glimmerjs/glimmer-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glimmerjs/glimmer-application/labels{/name}","releases_url":"https://api.github.com/repos/glimmerjs/glimmer-application/releases{/id}","deployments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/deployments","created_at":"2017-01-31T15:01:27Z","updated_at":"2017-04-15T23:22:53Z","pushed_at":"2017-04-19T22:27:10Z","git_url":"git://github.com/glimmerjs/glimmer-application.git","ssh_url":"git@github.com:glimmerjs/glimmer-application.git","clone_url":"https://github.com/glimmerjs/glimmer-application.git","svn_url":"https://github.com/glimmerjs/glimmer-application","homepage":null,"size":87,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":18,"forks":14,"open_issues":18,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61"},"html":{"href":"https://github.com/glimmerjs/glimmer-application/pull/61"},"issue":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/61"},"comments":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/8dba08de82c351a3f134d3a962ffd0c97dbc12c9"}}}}
{"actor":{"display_login":"rwjblue"}}