{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/2153","repository_url":"https://api.github.com/repos/mozilla/activity-stream","labels_url":"https://api.github.com/repos/mozilla/activity-stream/issues/2153/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/2153/comments","events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/2153/events","html_url":"https://github.com/mozilla/activity-stream/pull/2153","id":206624923,"number":2153,"title":"feat(a11y): Closes #1993 Bring '...' button to foreground","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars.githubusercontent.com/u/7219526?v=3","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"labels":[{"id":334509354,"url":"https://api.github.com/repos/mozilla/activity-stream/labels/PR%20/%20Needs%20review","name":"PR / Needs review","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"assignees":[{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-02-09T20:46:03Z","updated_at":"2017-02-09T20:58:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/2153","html_url":"https://github.com/mozilla/activity-stream/pull/2153","diff_url":"https://github.com/mozilla/activity-stream/pull/2153.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/2153.patch"},"body":"This diff is really hard to read but basically what I did was:\r\n1. Move ```.tile``` so that it's nested in ```.tile-outer```. This allowed for some of the focus stuff to work properly\r\n2. Add a new mixin for these \"inner\" elements, ```.tile``` and ```.spotlight-inner``` which keeps the border and shows the link menu button when you tab through it\r\n\r\nThe best way to test this is to just run this and start tabbing through the top sites and highlights. What happens is when you tab through it, it'll show focus in 3 ways: 1. the border shows up 2. background colour of ```.site-icon-title``` turns white and 3. the menu link button shows up. Another tab brings the menu link button into focus and if you press enter it'll open the context menu. This works for both top sites and highlights.\r\n\r\nNote: In the original ticket #1993 it was mentioned that if you press \"ESC\" then the context menu doesn't close. That behaviour is still happening here, I figured we could fix that when we make the context menu accessible in general"},"comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments/278771705","html_url":"https://github.com/mozilla/activity-stream/pull/2153#issuecomment-278771705","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/2153","id":278771705,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-02-09T20:58:44Z","updated_at":"2017-02-09T20:58:44Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10082163/badge)](https://coveralls.io/builds/10082163)\n\nCoverage remained the same at 89.209% when pulling **473ead69cd60c5953c1f7530aed4a4fd84c08a2a on sarracini:gh1993** into **3c1b35c98f013ed047b8952a70a346436f18ae3c on mozilla:master**.\n"}}
{"actor":{"display_login":"coveralls"}}