{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/comments/119286353","pull_request_review_id":41149352,"id":119286353,"diff_hunk":"@@ -971,18 +981,35 @@\n \t\t},\n \t\t//UI Handlers\n \t\tmediaClicked: function (mediaIndex) {\n-\t\t\tif (this.getConfig(\"closeOnClick\") && (this.getConfig('parent') === 'sideBarContainer')){\n-\t\t\t\tthis.getPlayer().triggerHelper(\"closeSideBarContainer\");\n-\t\t\t}\n-\t\t\t//Only apply seek in VOD or in live if DVR is supported\n-\t\t\tif ((this.getPlayer().isLive() && this.getPlayer().isDVR()) ||\n-\t\t\t\t\t!this.getPlayer().isLive()) {\n+\t\t//disable click from items out of DVR window\n+\t\tif (this.getComponent().find(\"li[data-mediaBox-index='\" + mediaIndex + \"']\").hasClass(\"out-of-dvr\")) {\n+\t\t\treturn;\n+\t\t}\n+\t\tif (this.getConfig(\"closeOnClick\") && (this.getConfig('parent') === 'sideBarContainer')){\n+\t\t\tthis.getPlayer().triggerHelper(\"closeSideBarContainer\");\n+\t\t}\n+\t\t//Only apply seek in VOD or in live if DVR is supported\n+\t\tif ((this.getPlayer().isLive() && this.getPlayer().isDVR()) ||\n+\t\t\t!this.getPlayer().isLive()) {\n \t\t\t\t//Send play request on first click for devices that don't have autoplay, e.g. mobile devices\n \t\t\t\tif (!this.getPlayer().canAutoPlay() && this.getPlayer().firstPlay){\n \t\t\t\t\tthis.getPlayer().sendNotification('doPlay');\n \t\t\t\t}\n-\t\t\t\t// see to start time and play ( +.1 to avoid highlight of prev chapter )\n-\t\t\t\tthis.getPlayer().sendNotification('doSeek', ( this.mediaList[mediaIndex].startTime ) + 0.1);\n+\t\t\t\tif (this.embedPlayer.isDVR()) {\n+\t\t\t\t\t// get current time from Id3","path":"modules/KalturaSupport/components/chapters/chapters.js","position":96,"original_position":96,"commit_id":"18e842b663bf1b4dcee46f40e9bbbf2f70319fb2","original_commit_id":"18e842b663bf1b4dcee46f40e9bbbf2f70319fb2","user":{"login":"kalturaguy","id":7511565,"avatar_url":"https://avatars0.githubusercontent.com/u/7511565?v=3","gravatar_id":"","url":"https://api.github.com/users/kalturaguy","html_url":"https://github.com/kalturaguy","followers_url":"https://api.github.com/users/kalturaguy/followers","following_url":"https://api.github.com/users/kalturaguy/following{/other_user}","gists_url":"https://api.github.com/users/kalturaguy/gists{/gist_id}","starred_url":"https://api.github.com/users/kalturaguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalturaguy/subscriptions","organizations_url":"https://api.github.com/users/kalturaguy/orgs","repos_url":"https://api.github.com/users/kalturaguy/repos","events_url":"https://api.github.com/users/kalturaguy/events{/privacy}","received_events_url":"https://api.github.com/users/kalturaguy/received_events","type":"User","site_admin":false},"body":"Also you already have liveplayertime which contains the same calculation. So you can remove the code about id3 and yse it","created_at":"2017-05-31T07:22:06Z","updated_at":"2017-05-31T07:33:55Z","html_url":"https://github.com/kaltura/mwEmbed/pull/3403#discussion_r119286353","pull_request_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403","_links":{"self":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/comments/119286353"},"html":{"href":"https://github.com/kaltura/mwEmbed/pull/3403#discussion_r119286353"},"pull_request":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403","id":123127746,"html_url":"https://github.com/kaltura/mwEmbed/pull/3403","diff_url":"https://github.com/kaltura/mwEmbed/pull/3403.diff","patch_url":"https://github.com/kaltura/mwEmbed/pull/3403.patch","issue_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/3403","number":3403,"state":"open","locked":false,"title":"2.56 dvr","user":{"login":"eitanavgil","id":1536299,"avatar_url":"https://avatars2.githubusercontent.com/u/1536299?v=3","gravatar_id":"","url":"https://api.github.com/users/eitanavgil","html_url":"https://github.com/eitanavgil","followers_url":"https://api.github.com/users/eitanavgil/followers","following_url":"https://api.github.com/users/eitanavgil/following{/other_user}","gists_url":"https://api.github.com/users/eitanavgil/gists{/gist_id}","starred_url":"https://api.github.com/users/eitanavgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eitanavgil/subscriptions","organizations_url":"https://api.github.com/users/eitanavgil/orgs","repos_url":"https://api.github.com/users/eitanavgil/repos","events_url":"https://api.github.com/users/eitanavgil/events{/privacy}","received_events_url":"https://api.github.com/users/eitanavgil/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-30T19:42:33Z","updated_at":"2017-05-31T07:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a129055cee74e6cd66fa3ec8aef022957b94f4bb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403/commits","review_comments_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403/comments","review_comment_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/3403/comments","statuses_url":"https://api.github.com/repos/kaltura/mwEmbed/statuses/18e842b663bf1b4dcee46f40e9bbbf2f70319fb2","head":{"label":"kaltura:2.56-dvr","ref":"2.56-dvr","sha":"18e842b663bf1b4dcee46f40e9bbbf2f70319fb2","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":3388498,"name":"mwEmbed","full_name":"kaltura/mwEmbed","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/mwEmbed","description":"Kaltura's Cross Platform Video Player ToolKit ","fork":false,"url":"https://api.github.com/repos/kaltura/mwEmbed","forks_url":"https://api.github.com/repos/kaltura/mwEmbed/forks","keys_url":"https://api.github.com/repos/kaltura/mwEmbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/mwEmbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/mwEmbed/teams","hooks_url":"https://api.github.com/repos/kaltura/mwEmbed/hooks","issue_events_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/mwEmbed/events","assignees_url":"https://api.github.com/repos/kaltura/mwEmbed/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/mwEmbed/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/mwEmbed/tags","blobs_url":"https://api.github.com/repos/kaltura/mwEmbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/mwEmbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/mwEmbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/mwEmbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/mwEmbed/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/mwEmbed/languages","stargazers_url":"https://api.github.com/repos/kaltura/mwEmbed/stargazers","contributors_url":"https://api.github.com/repos/kaltura/mwEmbed/contributors","subscribers_url":"https://api.github.com/repos/kaltura/mwEmbed/subscribers","subscription_url":"https://api.github.com/repos/kaltura/mwEmbed/subscription","commits_url":"https://api.github.com/repos/kaltura/mwEmbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/mwEmbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/mwEmbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/mwEmbed/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/mwEmbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/mwEmbed/merges","archive_url":"https://api.github.com/repos/kaltura/mwEmbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/mwEmbed/downloads","issues_url":"https://api.github.com/repos/kaltura/mwEmbed/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/mwEmbed/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/mwEmbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/mwEmbed/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/mwEmbed/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/mwEmbed/deployments","created_at":"2012-02-08T15:44:27Z","updated_at":"2017-05-24T19:29:50Z","pushed_at":"2017-05-30T20:32:41Z","git_url":"git://github.com/kaltura/mwEmbed.git","ssh_url":"git@github.com:kaltura/mwEmbed.git","clone_url":"https://github.com/kaltura/mwEmbed.git","svn_url":"https://github.com/kaltura/mwEmbed","homepage":"http://player.kaltura.com","size":846657,"stargazers_count":166,"watchers_count":166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":193,"forks":126,"open_issues":193,"watchers":166,"default_branch":"master"}},"base":{"label":"kaltura:2.57-18-June","ref":"2.57-18-June","sha":"7ab638c28fcaa62e4522d4c606a4b627a3e51484","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":3388498,"name":"mwEmbed","full_name":"kaltura/mwEmbed","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/mwEmbed","description":"Kaltura's Cross Platform Video Player ToolKit ","fork":false,"url":"https://api.github.com/repos/kaltura/mwEmbed","forks_url":"https://api.github.com/repos/kaltura/mwEmbed/forks","keys_url":"https://api.github.com/repos/kaltura/mwEmbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/mwEmbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/mwEmbed/teams","hooks_url":"https://api.github.com/repos/kaltura/mwEmbed/hooks","issue_events_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/mwEmbed/events","assignees_url":"https://api.github.com/repos/kaltura/mwEmbed/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/mwEmbed/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/mwEmbed/tags","blobs_url":"https://api.github.com/repos/kaltura/mwEmbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/mwEmbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/mwEmbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/mwEmbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/mwEmbed/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/mwEmbed/languages","stargazers_url":"https://api.github.com/repos/kaltura/mwEmbed/stargazers","contributors_url":"https://api.github.com/repos/kaltura/mwEmbed/contributors","subscribers_url":"https://api.github.com/repos/kaltura/mwEmbed/subscribers","subscription_url":"https://api.github.com/repos/kaltura/mwEmbed/subscription","commits_url":"https://api.github.com/repos/kaltura/mwEmbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/mwEmbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/mwEmbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/mwEmbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/mwEmbed/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/mwEmbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/mwEmbed/merges","archive_url":"https://api.github.com/repos/kaltura/mwEmbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/mwEmbed/downloads","issues_url":"https://api.github.com/repos/kaltura/mwEmbed/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/mwEmbed/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/mwEmbed/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/mwEmbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/mwEmbed/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/mwEmbed/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/mwEmbed/deployments","created_at":"2012-02-08T15:44:27Z","updated_at":"2017-05-24T19:29:50Z","pushed_at":"2017-05-30T20:32:41Z","git_url":"git://github.com/kaltura/mwEmbed.git","ssh_url":"git@github.com:kaltura/mwEmbed.git","clone_url":"https://github.com/kaltura/mwEmbed.git","svn_url":"https://github.com/kaltura/mwEmbed","homepage":"http://player.kaltura.com","size":846657,"stargazers_count":166,"watchers_count":166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":193,"forks":126,"open_issues":193,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403"},"html":{"href":"https://github.com/kaltura/mwEmbed/pull/3403"},"issue":{"href":"https://api.github.com/repos/kaltura/mwEmbed/issues/3403"},"comments":{"href":"https://api.github.com/repos/kaltura/mwEmbed/issues/3403/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/mwEmbed/pulls/3403/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/mwEmbed/statuses/18e842b663bf1b4dcee46f40e9bbbf2f70319fb2"}}}}
{"actor":{"display_login":"kalturaguy"}}