{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/17783","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/17783/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/17783/comments","events_url":"https://api.github.com/repos/servo/servo/issues/17783/events","html_url":"https://github.com/servo/servo/pull/17783","id":243970064,"number":17783,"title":"stylo: Bug 1374233 - Clamp interpolated values for properties which need to be restricted","user":{"login":"BorisChiou","id":1914903,"avatar_url":"https://avatars3.githubusercontent.com/u/1914903?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisChiou","html_url":"https://github.com/BorisChiou","followers_url":"https://api.github.com/users/BorisChiou/followers","following_url":"https://api.github.com/users/BorisChiou/following{/other_user}","gists_url":"https://api.github.com/users/BorisChiou/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisChiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisChiou/subscriptions","organizations_url":"https://api.github.com/users/BorisChiou/orgs","repos_url":"https://api.github.com/users/BorisChiou/repos","events_url":"https://api.github.com/users/BorisChiou/events{/privacy}","received_events_url":"https://api.github.com/users/BorisChiou/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false},{"id":152311003,"url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars0.githubusercontent.com/u/123095?v=4","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"assignees":[{"login":"nox","id":123095,"avatar_url":"https://avatars0.githubusercontent.com/u/123095?v=4","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-07-19T09:00:34Z","updated_at":"2017-07-26T07:26:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/17783","html_url":"https://github.com/servo/servo/pull/17783","diff_url":"https://github.com/servo/servo/pull/17783.diff","patch_url":"https://github.com/servo/servo/pull/17783.patch"},"body":"Some properties only accept non-negative values, or values greater than or equal to one. It is possible to produce an negative interpolated values while using negative timing functions, so we have to apply a restriction to these values to avoid getting invalid values.\r\n\r\nFor example, line-height must be non-negative, but the output progress of some timing functions (e,g. cubic-bezier(0.25, -2, 0.75, 1)) may be a negative value, so the interpolated result of line-height is also negative.\r\n\r\n---\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix Bug 1374233.\r\n- [X] These changes do not require tests because we have tests in Gecko side already.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/17783)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/317971766","html_url":"https://github.com/servo/servo/pull/17783#issuecomment-317971766","issue_url":"https://api.github.com/repos/servo/servo/issues/17783","id":317971766,"user":{"login":"BorisChiou","id":1914903,"avatar_url":"https://avatars3.githubusercontent.com/u/1914903?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisChiou","html_url":"https://github.com/BorisChiou","followers_url":"https://api.github.com/users/BorisChiou/followers","following_url":"https://api.github.com/users/BorisChiou/following{/other_user}","gists_url":"https://api.github.com/users/BorisChiou/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisChiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisChiou/subscriptions","organizations_url":"https://api.github.com/users/BorisChiou/orgs","repos_url":"https://api.github.com/users/BorisChiou/repos","events_url":"https://api.github.com/users/BorisChiou/events{/privacy}","received_events_url":"https://api.github.com/users/BorisChiou/received_events","type":"User","site_admin":false},"created_at":"2017-07-26T07:26:35Z","updated_at":"2017-07-26T07:26:35Z","body":"r? @nox again. Thanks.\r\nI add some types for NonNegtaive and Greater-than-Or-Equal-To-One values, and then use these types as the specified/computed values of these properties which need to be clamped."}}
{"actor":{"display_login":"BorisChiou"}}