{"action":"created","issue":{"url":"https://api.github.com/repos/spinnaker/deck/issues/3689","repository_url":"https://api.github.com/repos/spinnaker/deck","labels_url":"https://api.github.com/repos/spinnaker/deck/issues/3689/labels{/name}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/3689/comments","events_url":"https://api.github.com/repos/spinnaker/deck/issues/3689/events","html_url":"https://github.com/spinnaker/deck/pull/3689","id":229146735,"number":3689,"title":"refactor(core): move React-injected services into ReactInjector directly","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars3.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-05-16T19:40:56Z","updated_at":"2017-05-16T21:43:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/3689","html_url":"https://github.com/spinnaker/deck/pull/3689","diff_url":"https://github.com/spinnaker/deck/pull/3689.diff","patch_url":"https://github.com/spinnaker/deck/pull/3689.patch"},"body":"@jrsquared @christopherthielen PTAL\r\n\r\nThe `export let xxx = undefined;` approach is fine when importing directly from the declaring source file. However, if we attempt to re-export that field, e.g.\r\n\r\n```javascript\r\n// file: a/a.js\r\nexport let foo = undefined;\r\nmodule('', []).service('foo', foo).run($injector => foo = $injector.get('foo'));\r\n\r\n// file: a/index.js\r\nexport * from 'a.js'\r\n\r\n// file: b.js\r\nimport { foo } from 'a';\r\n\r\nfoo === undefined // true\r\n```\r\n\r\nThis becomes a problem when we try to package modules up as libraries, which we're trying to do.\r\n\r\nInstead, we'll explicitly export the `ReactInjector`, and add those fields to it explicitly. I made them getters - not because of concern someone will overwrite them, but because we don't want to actually initialize something unless a component requests it; otherwise, tests get pretty gnarly.\r\n\r\nAlso changing the casing on `loadBalancerFilterModel`. I'll do the same with the other `*FilterModel`s in a separate PR."},"comment":{"url":"https://api.github.com/repos/spinnaker/deck/issues/comments/301924613","html_url":"https://github.com/spinnaker/deck/pull/3689#issuecomment-301924613","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/3689","id":301924613,"user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars3.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"created_at":"2017-05-16T21:43:41Z","updated_at":"2017-05-16T21:43:41Z","body":"Get to work, Justin"}}
{"actor":{"display_login":"anotherchrisberry"}}