{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2132","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2132/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2132/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2132/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2132","id":241349846,"number":2132,"title":"RCS Support","user":{"login":"james-rae","id":7585245,"avatar_url":"https://avatars0.githubusercontent.com/u/7585245?v=3","gravatar_id":"","url":"https://api.github.com/users/james-rae","html_url":"https://github.com/james-rae","followers_url":"https://api.github.com/users/james-rae/followers","following_url":"https://api.github.com/users/james-rae/following{/other_user}","gists_url":"https://api.github.com/users/james-rae/gists{/gist_id}","starred_url":"https://api.github.com/users/james-rae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-rae/subscriptions","organizations_url":"https://api.github.com/users/james-rae/orgs","repos_url":"https://api.github.com/users/james-rae/repos","events_url":"https://api.github.com/users/james-rae/events{/privacy}","received_events_url":"https://api.github.com/users/james-rae/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars3.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars3.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-07-07T18:52:56Z","updated_at":"2017-07-11T18:30:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/2132","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2132","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2132.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2132.patch"},"body":"## Description\r\n<!-- Link to an issue or include a description -->\r\nCloses https://github.com/fgpv-vpgf/fgpv-vpgf/issues/1961 , https://github.com/fgpv-vpgf/fgpv-vpgf/issues/1666\r\n\r\nRe-enables RCS Layer support for the following\r\n\r\n* Keys on Site URL\r\n* Keys on Map HTML Tag\r\n* Back to Cart\r\n* Bookmark Restore\r\n* Projection Change\r\n* Language Change\r\n\r\nRe-adds `bookmark-decode.html`.\r\n\r\nUpdated the `fpg` test pages.\r\n\r\nRemoved piles of pre-refactor code.\r\n\r\nPending fix: Prevent RCS Layers that are `Removed` but still in the \"undoable\" state from getting piped onto the Back-to-Cart output.\r\n\r\n## Testing\r\n<!-- Have you added unit tests for this code?  If not explain why. -->\r\nTesting against local build, including modded tags, modded back-to-cart switcheroos, medleys of config based, tag based, and URL based layers.\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\nI have a lovely text file that somewhat explains things.\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] commits messages follow the guidelines\r\n- [ ] code passes unit tests\r\n- [x] release notes have been updated\r\n- [x] PR targets the correct release version\r\n\r\nRemember, it is no longer a *muffin offence* to open a PR with any of the above checklist items incomplete, as we have removed unit tests (a wise decision).\r\n\r\nPlease keep the original issue up to date with the final solution, expected behaviour, and any additional notes for testers\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/2132)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/314532627","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2132#issuecomment-314532627","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2132","id":314532627,"user":{"login":"james-rae","id":7585245,"avatar_url":"https://avatars0.githubusercontent.com/u/7585245?v=3","gravatar_id":"","url":"https://api.github.com/users/james-rae","html_url":"https://github.com/james-rae","followers_url":"https://api.github.com/users/james-rae/followers","following_url":"https://api.github.com/users/james-rae/following{/other_user}","gists_url":"https://api.github.com/users/james-rae/gists{/gist_id}","starred_url":"https://api.github.com/users/james-rae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-rae/subscriptions","organizations_url":"https://api.github.com/users/james-rae/orgs","repos_url":"https://api.github.com/users/james-rae/repos","events_url":"https://api.github.com/users/james-rae/events{/privacy}","received_events_url":"https://api.github.com/users/james-rae/received_events","type":"User","site_admin":false},"created_at":"2017-07-11T18:30:57Z","updated_at":"2017-07-11T18:30:57Z","body":"Yeah.  We can investigate more. It's a bit funny because the process is constantly removing and re-adding things to the config's `layers` array. \n\n---\n\n\n\n\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/2132#-:-KomuPxtVq8mCslLtRKc:bnh69np)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"james-rae"}}