{"action":"created","issue":{"url":"https://api.github.com/repos/GMOD/jbrowse/issues/844","repository_url":"https://api.github.com/repos/GMOD/jbrowse","labels_url":"https://api.github.com/repos/GMOD/jbrowse/issues/844/labels{/name}","comments_url":"https://api.github.com/repos/GMOD/jbrowse/issues/844/comments","events_url":"https://api.github.com/repos/GMOD/jbrowse/issues/844/events","html_url":"https://github.com/GMOD/jbrowse/pull/844","id":202843686,"number":844,"title":"Allow more usage of jbrowse without iframe","user":{"login":"cmdcolin","id":6511937,"avatar_url":"https://avatars3.githubusercontent.com/u/6511937?v=3","gravatar_id":"","url":"https://api.github.com/users/cmdcolin","html_url":"https://github.com/cmdcolin","followers_url":"https://api.github.com/users/cmdcolin/followers","following_url":"https://api.github.com/users/cmdcolin/following{/other_user}","gists_url":"https://api.github.com/users/cmdcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmdcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmdcolin/subscriptions","organizations_url":"https://api.github.com/users/cmdcolin/orgs","repos_url":"https://api.github.com/users/cmdcolin/repos","events_url":"https://api.github.com/users/cmdcolin/events{/privacy}","received_events_url":"https://api.github.com/users/cmdcolin/received_events","type":"User","site_admin":false},"labels":[{"id":4613283,"url":"https://api.github.com/repos/GMOD/jbrowse/labels/in%20progress","name":"in progress","color":"e10c02","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-01-24T15:03:25Z","updated_at":"2017-03-08T06:24:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GMOD/jbrowse/pulls/844","html_url":"https://github.com/GMOD/jbrowse/pull/844","diff_url":"https://github.com/GMOD/jbrowse/pull/844.diff","patch_url":"https://github.com/GMOD/jbrowse/pull/844.patch"},"body":"This PR adds more specificity to the CSS used by jbrowse to allow it to be loaded better in other pages without iframe\r\n\r\n\r\nSome notable changes\r\n\r\n* The \"jbrowse\" CSS class was prefixed to almost all css styles\r\n* The root styles from src/dojo/resources/dojo.css were removed, which added global fonts. It seems this stylesheet is not essential though, and it is called a \"baseline file for general usage\" and  that it is not the \"foundation for more complex things\", so I think it's not essential style\r\n* The font/font-family that was added via css/main.css was modified so that it only applies to a \"jbrowsecontainer\" class, which is added to the GenomeBrowser div\r\n* The width/height 100% has to be applied to \"html, body\" in css/main.css, because otherwise jbrowse comes up blank. I don't fully understand the purpose of having to set width/height 100% on \"html, body\" but it doesn't seem to have consequences for embedding (might need verification)\r\n\r\n\r\nThis PR adds a test page tests/drupal.htm to the test directory which you can view the embedded page in drupal like this\r\n\r\n\r\nExample with volvox data\r\nhttp://localhost/jbrowse/tests/drupal.htm?data=http%3A%2F%2Flocalhost%2Fjbrowse%2Fsample_data%2Fjson%2Fvolvox&loc=ctgA%3A26209..35186&tracks=DNA%2Crnasim%2CGenes%2CCDS%2CExampleFeatures%2CEST%2Cvolvox_gtf%2Cvolvox_gff3_tabix%2Cvolvox_bed_tabix&highlight=\r\n\r\nExample with the \"error page\"/Congratulations, jbrowse is on the web... message\r\nhttp://localhost/jbrowse/tests/drupal.htm\r\n\r\n\r\n\r\n\r\nRemaining issues\r\n\r\n- the dialog boxes are not styled by css properly\r\n- the scrollbar thing is still an issue, see https://github.com/GMOD/jbrowse/issues/575\r\n\r\nxref here for drupal examples https://github.com/GMOD/jbrowse/issues/777"},"comment":{"url":"https://api.github.com/repos/GMOD/jbrowse/issues/comments/284958276","html_url":"https://github.com/GMOD/jbrowse/pull/844#issuecomment-284958276","issue_url":"https://api.github.com/repos/GMOD/jbrowse/issues/844","id":284958276,"user":{"login":"nathandunn","id":751274,"avatar_url":"https://avatars1.githubusercontent.com/u/751274?v=3","gravatar_id":"","url":"https://api.github.com/users/nathandunn","html_url":"https://github.com/nathandunn","followers_url":"https://api.github.com/users/nathandunn/followers","following_url":"https://api.github.com/users/nathandunn/following{/other_user}","gists_url":"https://api.github.com/users/nathandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/nathandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathandunn/subscriptions","organizations_url":"https://api.github.com/users/nathandunn/orgs","repos_url":"https://api.github.com/users/nathandunn/repos","events_url":"https://api.github.com/users/nathandunn/events{/privacy}","received_events_url":"https://api.github.com/users/nathandunn/received_events","type":"User","site_admin":false},"created_at":"2017-03-08T06:24:36Z","updated_at":"2017-03-08T06:24:36Z","body":"@enuggetry  The only problem I'm running into right now (I almost have Apollo working with JBrowse as a div) is that I have two different versions of jQuery.   Hopefully, that is something that could be installed via bower / npm, as well.   I'd hate to have to manually install that as well.   Otherwise, this is still an improvement. "}}
{"actor":{"display_login":"nathandunn"}}