{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/100120658","pull_request_review_id":20816543,"id":100120658,"diff_hunk":"@@ -54,7 +54,7 @@ open class FxADeviceRegistration: NSObject, NSCoding {\n \n     public convenience required init(coder: NSCoder) {\n         let id = coder.decodeObject(forKey: \"id\") as! String\n-        let version = coder.decodeObject(forKey: \"version\") as! Int\n+        let version: Int = coder.decodeObject(forKey: \"version\") as! Int? ?? 0","path":"Account/FxADeviceRegistration.swift","position":5,"original_position":5,"commit_id":"0c900d98e0ee96d67d81a6e0819f10c98f4bf3c5","original_commit_id":"95bec971d1226f30cd1340657917703c824a1a16","user":{"login":"fluffyemily","id":12613048,"avatar_url":"https://avatars.githubusercontent.com/u/12613048?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyemily","html_url":"https://github.com/fluffyemily","followers_url":"https://api.github.com/users/fluffyemily/followers","following_url":"https://api.github.com/users/fluffyemily/following{/other_user}","gists_url":"https://api.github.com/users/fluffyemily/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyemily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyemily/subscriptions","organizations_url":"https://api.github.com/users/fluffyemily/orgs","repos_url":"https://api.github.com/users/fluffyemily/repos","events_url":"https://api.github.com/users/fluffyemily/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyemily/received_events","type":"User","site_admin":false},"body":"Damnit. I can no longer replicate the missing version situation so I can't go back to look at it. Do we have any startup crashes for iOS that are sync related? If so, this _could_ be it.","created_at":"2017-02-08T17:22:21Z","updated_at":"2017-02-08T17:22:21Z","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2400#discussion_r100120658","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/100120658"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2400#discussion_r100120658"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400","id":105235483,"html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2400","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2400.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2400.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2400","number":2400,"state":"open","locked":false,"title":"Bug 1337769 - sync issues swift 3","user":{"login":"fluffyemily","id":12613048,"avatar_url":"https://avatars.githubusercontent.com/u/12613048?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyemily","html_url":"https://github.com/fluffyemily","followers_url":"https://api.github.com/users/fluffyemily/followers","following_url":"https://api.github.com/users/fluffyemily/following{/other_user}","gists_url":"https://api.github.com/users/fluffyemily/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyemily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyemily/subscriptions","organizations_url":"https://api.github.com/users/fluffyemily/orgs","repos_url":"https://api.github.com/users/fluffyemily/repos","events_url":"https://api.github.com/users/fluffyemily/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyemily/received_events","type":"User","site_admin":false},"body":"I encountered a number of issues when trying to Sync using the Swift 3 branch. Here are the fixes:\r\n\r\nMissing version field for first sync on new device after sign in\r\nFetching an incorrect header for the remote timestamp field\r\nForce unwrapping a potentialy nil value when synchronizing tabs","created_at":"2017-02-08T15:09:18Z","updated_at":"2017-02-08T17:22:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"369210b58279626eda9c40ab21c2230264ecd14c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2400/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/0c900d98e0ee96d67d81a6e0819f10c98f4bf3c5","head":{"label":"mozilla-mobile:fluffyemily/bug-1337769-sync-issues-swift-3","ref":"fluffyemily/bug-1337769-sync-issues-swift-3","sha":"0c900d98e0ee96d67d81a6e0819f10c98f4bf3c5","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2017-02-08T09:40:33Z","pushed_at":"2017-02-08T17:07:03Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":432057,"stargazers_count":6803,"watchers_count":6803,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1427,"mirror_url":null,"open_issues_count":69,"forks":1427,"open_issues":69,"watchers":6803,"default_branch":"master"}},"base":{"label":"mozilla-mobile:swift-3-migration","ref":"swift-3-migration","sha":"054a03728fbb9a3b04cf9bb7b8e8f4c0ef2a7dde","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2017-02-08T09:40:33Z","pushed_at":"2017-02-08T17:07:03Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":432057,"stargazers_count":6803,"watchers_count":6803,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1427,"mirror_url":null,"open_issues_count":69,"forks":1427,"open_issues":69,"watchers":6803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2400"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2400"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2400/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2400/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/0c900d98e0ee96d67d81a6e0819f10c98f4bf3c5"}}}}
{"actor":{"display_login":"fluffyemily"}}