{"action":"created","comment":{"url":"https://api.github.com/repos/azerupi/mdBook/pulls/comments/123893502","pull_request_review_id":46140889,"id":123893502,"diff_hunk":"@@ -5,7 +5,7 @@ use super::tomlconfig::TomlConfig;\n use super::jsonconfig::JsonConfig;\n \n /// Configuration struct containing all the configuration options available in mdBook.\n-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]","path":"src/config/bookconfig.rs","position":4,"original_position":4,"commit_id":"18d53b2f8b29d252707da802c89a712aeb8ea47b","original_commit_id":"18d53b2f8b29d252707da802c89a712aeb8ea47b","user":{"login":"budziq","id":221000,"avatar_url":"https://avatars1.githubusercontent.com/u/221000?v=3","gravatar_id":"","url":"https://api.github.com/users/budziq","html_url":"https://github.com/budziq","followers_url":"https://api.github.com/users/budziq/followers","following_url":"https://api.github.com/users/budziq/following{/other_user}","gists_url":"https://api.github.com/users/budziq/gists{/gist_id}","starred_url":"https://api.github.com/users/budziq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budziq/subscriptions","organizations_url":"https://api.github.com/users/budziq/orgs","repos_url":"https://api.github.com/users/budziq/repos","events_url":"https://api.github.com/users/budziq/events{/privacy}","received_events_url":"https://api.github.com/users/budziq/received_events","type":"User","site_admin":false},"body":"> That should probably be in a different commit than this one then, just to keep commit history clean. \r\n\r\nGood point. ATM this was just an exploratory PR for further review (and honestly I've removed the derives to check if this will sill compile). I'll cleanup if the PR will ever have a chance of merging.\r\n\r\n> Course, I'm just a nobody, so take my recommendation with a grain of salt.\r\n\r\nNope. All help and another pair of eyes is always welcome. Thanks :+1: !","created_at":"2017-06-25T08:41:08Z","updated_at":"2017-06-25T08:41:08Z","html_url":"https://github.com/azerupi/mdBook/pull/362#discussion_r123893502","pull_request_url":"https://api.github.com/repos/azerupi/mdBook/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/comments/123893502"},"html":{"href":"https://github.com/azerupi/mdBook/pull/362#discussion_r123893502"},"pull_request":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/azerupi/mdBook/pulls/362","id":127344023,"html_url":"https://github.com/azerupi/mdBook/pull/362","diff_url":"https://github.com/azerupi/mdBook/pull/362.diff","patch_url":"https://github.com/azerupi/mdBook/pull/362.patch","issue_url":"https://api.github.com/repos/azerupi/mdBook/issues/362","number":362,"state":"open","locked":false,"title":"Make HtmlConfig is no longer optional","user":{"login":"budziq","id":221000,"avatar_url":"https://avatars1.githubusercontent.com/u/221000?v=3","gravatar_id":"","url":"https://api.github.com/users/budziq","html_url":"https://github.com/budziq","followers_url":"https://api.github.com/users/budziq/followers","following_url":"https://api.github.com/users/budziq/following{/other_user}","gists_url":"https://api.github.com/users/budziq/gists{/gist_id}","starred_url":"https://api.github.com/users/budziq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budziq/subscriptions","organizations_url":"https://api.github.com/users/budziq/orgs","repos_url":"https://api.github.com/users/budziq/repos","events_url":"https://api.github.com/users/budziq/events{/privacy}","received_events_url":"https://api.github.com/users/budziq/received_events","type":"User","site_admin":false},"body":"`HtmlConfig` was both guaranteed to exist within `BookConfig`\r\nand `expect`ed in few places.\r\nThis simplifies the API a little by representing the fact that\r\n`HtmlConfig` is curently mandatory for proper mdbook binary operation.\r\n\r\nPlease feel free to drop this PR if it does not match the project vision (it did not take a lot of effort anyway ;) ). ","created_at":"2017-06-24T21:23:19Z","updated_at":"2017-06-25T08:41:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44346fef427353a62508064c4cab68267412e435","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/azerupi/mdBook/pulls/362/commits","review_comments_url":"https://api.github.com/repos/azerupi/mdBook/pulls/362/comments","review_comment_url":"https://api.github.com/repos/azerupi/mdBook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azerupi/mdBook/issues/362/comments","statuses_url":"https://api.github.com/repos/azerupi/mdBook/statuses/18d53b2f8b29d252707da802c89a712aeb8ea47b","head":{"label":"budziq:nonopt_htmlconfig","ref":"nonopt_htmlconfig","sha":"18d53b2f8b29d252707da802c89a712aeb8ea47b","user":{"login":"budziq","id":221000,"avatar_url":"https://avatars1.githubusercontent.com/u/221000?v=3","gravatar_id":"","url":"https://api.github.com/users/budziq","html_url":"https://github.com/budziq","followers_url":"https://api.github.com/users/budziq/followers","following_url":"https://api.github.com/users/budziq/following{/other_user}","gists_url":"https://api.github.com/users/budziq/gists{/gist_id}","starred_url":"https://api.github.com/users/budziq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budziq/subscriptions","organizations_url":"https://api.github.com/users/budziq/orgs","repos_url":"https://api.github.com/users/budziq/repos","events_url":"https://api.github.com/users/budziq/events{/privacy}","received_events_url":"https://api.github.com/users/budziq/received_events","type":"User","site_admin":false},"repo":{"id":91616634,"name":"mdBook","full_name":"budziq/mdBook","owner":{"login":"budziq","id":221000,"avatar_url":"https://avatars1.githubusercontent.com/u/221000?v=3","gravatar_id":"","url":"https://api.github.com/users/budziq","html_url":"https://github.com/budziq","followers_url":"https://api.github.com/users/budziq/followers","following_url":"https://api.github.com/users/budziq/following{/other_user}","gists_url":"https://api.github.com/users/budziq/gists{/gist_id}","starred_url":"https://api.github.com/users/budziq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budziq/subscriptions","organizations_url":"https://api.github.com/users/budziq/orgs","repos_url":"https://api.github.com/users/budziq/repos","events_url":"https://api.github.com/users/budziq/events{/privacy}","received_events_url":"https://api.github.com/users/budziq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/budziq/mdBook","description":"Create book from markdown files. Like Gitbook but implemented in Rust","fork":true,"url":"https://api.github.com/repos/budziq/mdBook","forks_url":"https://api.github.com/repos/budziq/mdBook/forks","keys_url":"https://api.github.com/repos/budziq/mdBook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/budziq/mdBook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/budziq/mdBook/teams","hooks_url":"https://api.github.com/repos/budziq/mdBook/hooks","issue_events_url":"https://api.github.com/repos/budziq/mdBook/issues/events{/number}","events_url":"https://api.github.com/repos/budziq/mdBook/events","assignees_url":"https://api.github.com/repos/budziq/mdBook/assignees{/user}","branches_url":"https://api.github.com/repos/budziq/mdBook/branches{/branch}","tags_url":"https://api.github.com/repos/budziq/mdBook/tags","blobs_url":"https://api.github.com/repos/budziq/mdBook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/budziq/mdBook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/budziq/mdBook/git/refs{/sha}","trees_url":"https://api.github.com/repos/budziq/mdBook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/budziq/mdBook/statuses/{sha}","languages_url":"https://api.github.com/repos/budziq/mdBook/languages","stargazers_url":"https://api.github.com/repos/budziq/mdBook/stargazers","contributors_url":"https://api.github.com/repos/budziq/mdBook/contributors","subscribers_url":"https://api.github.com/repos/budziq/mdBook/subscribers","subscription_url":"https://api.github.com/repos/budziq/mdBook/subscription","commits_url":"https://api.github.com/repos/budziq/mdBook/commits{/sha}","git_commits_url":"https://api.github.com/repos/budziq/mdBook/git/commits{/sha}","comments_url":"https://api.github.com/repos/budziq/mdBook/comments{/number}","issue_comment_url":"https://api.github.com/repos/budziq/mdBook/issues/comments{/number}","contents_url":"https://api.github.com/repos/budziq/mdBook/contents/{+path}","compare_url":"https://api.github.com/repos/budziq/mdBook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/budziq/mdBook/merges","archive_url":"https://api.github.com/repos/budziq/mdBook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/budziq/mdBook/downloads","issues_url":"https://api.github.com/repos/budziq/mdBook/issues{/number}","pulls_url":"https://api.github.com/repos/budziq/mdBook/pulls{/number}","milestones_url":"https://api.github.com/repos/budziq/mdBook/milestones{/number}","notifications_url":"https://api.github.com/repos/budziq/mdBook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/budziq/mdBook/labels{/name}","releases_url":"https://api.github.com/repos/budziq/mdBook/releases{/id}","deployments_url":"https://api.github.com/repos/budziq/mdBook/deployments","created_at":"2017-05-17T20:19:27Z","updated_at":"2017-05-17T20:19:29Z","pushed_at":"2017-06-24T22:40:08Z","git_url":"git://github.com/budziq/mdBook.git","ssh_url":"git@github.com:budziq/mdBook.git","clone_url":"https://github.com/budziq/mdBook.git","svn_url":"https://github.com/budziq/mdBook","homepage":"","size":1419,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azerupi:master","ref":"master","sha":"b44106610550d6cf66697c68bb1aef6b0bce38be","user":{"login":"azerupi","id":7647338,"avatar_url":"https://avatars3.githubusercontent.com/u/7647338?v=3","gravatar_id":"","url":"https://api.github.com/users/azerupi","html_url":"https://github.com/azerupi","followers_url":"https://api.github.com/users/azerupi/followers","following_url":"https://api.github.com/users/azerupi/following{/other_user}","gists_url":"https://api.github.com/users/azerupi/gists{/gist_id}","starred_url":"https://api.github.com/users/azerupi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerupi/subscriptions","organizations_url":"https://api.github.com/users/azerupi/orgs","repos_url":"https://api.github.com/users/azerupi/repos","events_url":"https://api.github.com/users/azerupi/events{/privacy}","received_events_url":"https://api.github.com/users/azerupi/received_events","type":"User","site_admin":false},"repo":{"id":38655056,"name":"mdBook","full_name":"azerupi/mdBook","owner":{"login":"azerupi","id":7647338,"avatar_url":"https://avatars3.githubusercontent.com/u/7647338?v=3","gravatar_id":"","url":"https://api.github.com/users/azerupi","html_url":"https://github.com/azerupi","followers_url":"https://api.github.com/users/azerupi/followers","following_url":"https://api.github.com/users/azerupi/following{/other_user}","gists_url":"https://api.github.com/users/azerupi/gists{/gist_id}","starred_url":"https://api.github.com/users/azerupi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerupi/subscriptions","organizations_url":"https://api.github.com/users/azerupi/orgs","repos_url":"https://api.github.com/users/azerupi/repos","events_url":"https://api.github.com/users/azerupi/events{/privacy}","received_events_url":"https://api.github.com/users/azerupi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azerupi/mdBook","description":"Create book from markdown files. Like Gitbook but implemented in Rust","fork":false,"url":"https://api.github.com/repos/azerupi/mdBook","forks_url":"https://api.github.com/repos/azerupi/mdBook/forks","keys_url":"https://api.github.com/repos/azerupi/mdBook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerupi/mdBook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerupi/mdBook/teams","hooks_url":"https://api.github.com/repos/azerupi/mdBook/hooks","issue_events_url":"https://api.github.com/repos/azerupi/mdBook/issues/events{/number}","events_url":"https://api.github.com/repos/azerupi/mdBook/events","assignees_url":"https://api.github.com/repos/azerupi/mdBook/assignees{/user}","branches_url":"https://api.github.com/repos/azerupi/mdBook/branches{/branch}","tags_url":"https://api.github.com/repos/azerupi/mdBook/tags","blobs_url":"https://api.github.com/repos/azerupi/mdBook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerupi/mdBook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerupi/mdBook/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerupi/mdBook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerupi/mdBook/statuses/{sha}","languages_url":"https://api.github.com/repos/azerupi/mdBook/languages","stargazers_url":"https://api.github.com/repos/azerupi/mdBook/stargazers","contributors_url":"https://api.github.com/repos/azerupi/mdBook/contributors","subscribers_url":"https://api.github.com/repos/azerupi/mdBook/subscribers","subscription_url":"https://api.github.com/repos/azerupi/mdBook/subscription","commits_url":"https://api.github.com/repos/azerupi/mdBook/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerupi/mdBook/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerupi/mdBook/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerupi/mdBook/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerupi/mdBook/contents/{+path}","compare_url":"https://api.github.com/repos/azerupi/mdBook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerupi/mdBook/merges","archive_url":"https://api.github.com/repos/azerupi/mdBook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerupi/mdBook/downloads","issues_url":"https://api.github.com/repos/azerupi/mdBook/issues{/number}","pulls_url":"https://api.github.com/repos/azerupi/mdBook/pulls{/number}","milestones_url":"https://api.github.com/repos/azerupi/mdBook/milestones{/number}","notifications_url":"https://api.github.com/repos/azerupi/mdBook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerupi/mdBook/labels{/name}","releases_url":"https://api.github.com/repos/azerupi/mdBook/releases{/id}","deployments_url":"https://api.github.com/repos/azerupi/mdBook/deployments","created_at":"2015-07-07T00:57:25Z","updated_at":"2017-06-24T11:13:56Z","pushed_at":"2017-06-25T07:53:18Z","git_url":"git://github.com/azerupi/mdBook.git","ssh_url":"git@github.com:azerupi/mdBook.git","clone_url":"https://github.com/azerupi/mdBook.git","svn_url":"https://github.com/azerupi/mdBook","homepage":"","size":65814,"stargazers_count":544,"watchers_count":544,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":81,"forks":86,"open_issues":81,"watchers":544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/362"},"html":{"href":"https://github.com/azerupi/mdBook/pull/362"},"issue":{"href":"https://api.github.com/repos/azerupi/mdBook/issues/362"},"comments":{"href":"https://api.github.com/repos/azerupi/mdBook/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azerupi/mdBook/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/azerupi/mdBook/statuses/18d53b2f8b29d252707da802c89a712aeb8ea47b"}}}}
{"actor":{"display_login":"budziq"}}