{"action":"created","issue":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2115","repository_url":"https://api.github.com/repos/splitbrain/dokuwiki","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2115/labels{/name}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2115/comments","events_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2115/events","html_url":"https://github.com/splitbrain/dokuwiki/pull/2115","id":255353894,"number":2115,"title":"Fix section edit buttons for tables etc. ","user":{"login":"micgro42","id":7372507,"avatar_url":"https://avatars0.githubusercontent.com/u/7372507?v=4","gravatar_id":"","url":"https://api.github.com/users/micgro42","html_url":"https://github.com/micgro42","followers_url":"https://api.github.com/users/micgro42/followers","following_url":"https://api.github.com/users/micgro42/following{/other_user}","gists_url":"https://api.github.com/users/micgro42/gists{/gist_id}","starred_url":"https://api.github.com/users/micgro42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micgro42/subscriptions","organizations_url":"https://api.github.com/users/micgro42/orgs","repos_url":"https://api.github.com/users/micgro42/repos","events_url":"https://api.github.com/users/micgro42/events{/privacy}","received_events_url":"https://api.github.com/users/micgro42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-05T17:35:25Z","updated_at":"2017-09-11T17:45:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2115","html_url":"https://github.com/splitbrain/dokuwiki/pull/2115","diff_url":"https://github.com/splitbrain/dokuwiki/pull/2115.diff","patch_url":"https://github.com/splitbrain/dokuwiki/pull/2115.patch"},"body":"#1966 or 2571786c763e04c7abbf27c2245a5720878dc3f1 respectively broke the section edit buttons for sections that did not provide a title. This stopped the editbuttons of the edittable plugin from being generated.\r\n\r\nThe wrap plugin is likely affected by this as well, since it too uses `\\Doku_Renderer_xhtml::startSectionEdit` with only two arguments. (cc @selfthinker )\r\n\r\nFurther, the above commit broke saving a table with the edittable plugin. However I have not yet checked whether this has to be fixed in the edittable plugin or within in DokuWiki-core as well. This may also affect the data plugin.\r\n\r\nKnown Issues:\r\n* since both title and hid are optional, a hid may be misinterpreted as a title if the title is not generated."},"comment":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/comments/328604824","html_url":"https://github.com/splitbrain/dokuwiki/pull/2115#issuecomment-328604824","issue_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2115","id":328604824,"user":{"login":"micgro42","id":7372507,"avatar_url":"https://avatars0.githubusercontent.com/u/7372507?v=4","gravatar_id":"","url":"https://api.github.com/users/micgro42","html_url":"https://github.com/micgro42","followers_url":"https://api.github.com/users/micgro42/followers","following_url":"https://api.github.com/users/micgro42/following{/other_user}","gists_url":"https://api.github.com/users/micgro42/gists{/gist_id}","starred_url":"https://api.github.com/users/micgro42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micgro42/subscriptions","organizations_url":"https://api.github.com/users/micgro42/orgs","repos_url":"https://api.github.com/users/micgro42/repos","events_url":"https://api.github.com/users/micgro42/events{/privacy}","received_events_url":"https://api.github.com/users/micgro42/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T17:45:24Z","updated_at":"2017-09-11T17:45:24Z","author_association":"COLLABORATOR","body":"@Klap-in could you have a look at the last commit in this pull request (2d3b082).\r\n@splitbrain reviewed the other commits and this last one should only include additional tests. But I still would like to have another set of eyes and I'm somewhat confused by the failing AppVeyor job. (However, I cannot reproduce the failure locally)"}}
{"actor":{"display_login":"micgro42"}}