{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments/141046788","pull_request_review_id":65203437,"id":141046788,"diff_hunk":"@@ -68,14 +66,22 @@ void StreamHandler::SetProtection(const UserPolicy& policy) {\n void StreamHandler::RemoveProtection() {\n }\n \n-void StreamHandler::Commit(std::shared_ptr<IStream> outputStream, std::string& outputExtension) {\n-  mFileFormat->UpdateProperties(mProperties, {});\n-  mFileFormat->Commit(outputStream, outputExtension);\n-}\n-\n time_t StreamHandler::GetCurrentTime() {","path":"sdk/file_sdk/api_impl/stream_handler.cpp","position":82,"original_position":82,"commit_id":"e04cf603187a1b2c6aeffa86d961d0b609a4adfe","original_commit_id":"e04cf603187a1b2c6aeffa86d961d0b609a4adfe","user":{"login":"shenhavba","id":3798137,"avatar_url":"https://avatars3.githubusercontent.com/u/3798137?v=4","gravatar_id":"","url":"https://api.github.com/users/shenhavba","html_url":"https://github.com/shenhavba","followers_url":"https://api.github.com/users/shenhavba/followers","following_url":"https://api.github.com/users/shenhavba/following{/other_user}","gists_url":"https://api.github.com/users/shenhavba/gists{/gist_id}","starred_url":"https://api.github.com/users/shenhavba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenhavba/subscriptions","organizations_url":"https://api.github.com/users/shenhavba/orgs","repos_url":"https://api.github.com/users/shenhavba/repos","events_url":"https://api.github.com/users/shenhavba/events{/privacy}","received_events_url":"https://api.github.com/users/shenhavba/received_events","type":"User","site_admin":false},"body":"please change it to use the correct time format like i did, the sample should show the correct way to use the sdk...\r\nAlso, it should be UTC time","created_at":"2017-09-26T12:56:32Z","updated_at":"2017-09-26T12:56:32Z","html_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170#discussion_r141046788","pull_request_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments/141046788"},"html":{"href":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170#discussion_r141046788"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170","id":143126399,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170","diff_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170.diff","patch_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170.patch","issue_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/170","number":170,"state":"open","locked":false,"title":"Update IStreamHandler and label_sample","user":{"login":"meijin007","id":4030466,"avatar_url":"https://avatars2.githubusercontent.com/u/4030466?v=4","gravatar_id":"","url":"https://api.github.com/users/meijin007","html_url":"https://github.com/meijin007","followers_url":"https://api.github.com/users/meijin007/followers","following_url":"https://api.github.com/users/meijin007/following{/other_user}","gists_url":"https://api.github.com/users/meijin007/gists{/gist_id}","starred_url":"https://api.github.com/users/meijin007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meijin007/subscriptions","organizations_url":"https://api.github.com/users/meijin007/orgs","repos_url":"https://api.github.com/users/meijin007/repos","events_url":"https://api.github.com/users/meijin007/events{/privacy}","received_events_url":"https://api.github.com/users/meijin007/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-26T12:54:22Z","updated_at":"2017-09-26T12:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c450a43d9799d5a13389540c1beb2d7cccd3a14","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vakuras","id":22167695,"avatar_url":"https://avatars1.githubusercontent.com/u/22167695?v=4","gravatar_id":"","url":"https://api.github.com/users/vakuras","html_url":"https://github.com/vakuras","followers_url":"https://api.github.com/users/vakuras/followers","following_url":"https://api.github.com/users/vakuras/following{/other_user}","gists_url":"https://api.github.com/users/vakuras/gists{/gist_id}","starred_url":"https://api.github.com/users/vakuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakuras/subscriptions","organizations_url":"https://api.github.com/users/vakuras/orgs","repos_url":"https://api.github.com/users/vakuras/repos","events_url":"https://api.github.com/users/vakuras/events{/privacy}","received_events_url":"https://api.github.com/users/vakuras/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170/commits","review_comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170/comments","review_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/170/comments","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/e04cf603187a1b2c6aeffa86d961d0b609a4adfe","head":{"label":"AzureAD:private/assapir/istreamUpdate","ref":"private/assapir/istreamUpdate","sha":"e04cf603187a1b2c6aeffa86d961d0b609a4adfe","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":37728349,"name":"rms-sdk-for-cpp","full_name":"AzureAD/rms-sdk-for-cpp","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp","description":"RMS SDK for C++","fork":false,"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp","forks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/forks","keys_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/teams","hooks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/events","assignees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/tags","blobs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/languages","stargazers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscription","commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/merges","archive_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/downloads","issues_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/deployments","created_at":"2015-06-19T15:04:00Z","updated_at":"2017-09-19T07:08:46Z","pushed_at":"2017-09-26T12:54:23Z","git_url":"git://github.com/AzureAD/rms-sdk-for-cpp.git","ssh_url":"git@github.com:AzureAD/rms-sdk-for-cpp.git","clone_url":"https://github.com/AzureAD/rms-sdk-for-cpp.git","svn_url":"https://github.com/AzureAD/rms-sdk-for-cpp","homepage":null,"size":143596,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":19,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"fd1198d5d8b83bd8d93d94ef64f55efb33258c16","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":37728349,"name":"rms-sdk-for-cpp","full_name":"AzureAD/rms-sdk-for-cpp","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp","description":"RMS SDK for C++","fork":false,"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp","forks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/forks","keys_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/teams","hooks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/events","assignees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/tags","blobs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/languages","stargazers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscription","commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/merges","archive_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/downloads","issues_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/deployments","created_at":"2015-06-19T15:04:00Z","updated_at":"2017-09-19T07:08:46Z","pushed_at":"2017-09-26T12:54:23Z","git_url":"git://github.com/AzureAD/rms-sdk-for-cpp.git","ssh_url":"git@github.com:AzureAD/rms-sdk-for-cpp.git","clone_url":"https://github.com/AzureAD/rms-sdk-for-cpp.git","svn_url":"https://github.com/AzureAD/rms-sdk-for-cpp","homepage":null,"size":143596,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170"},"html":{"href":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/170"},"issue":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/170"},"comments":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/e04cf603187a1b2c6aeffa86d961d0b609a4adfe"}},"author_association":"NONE"}}
{"actor":{"display_login":"shenhavba"}}