{"action":"closed","number":3359,"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/3359","id":138315379,"html_url":"https://github.com/dotnet/orleans/pull/3359","diff_url":"https://github.com/dotnet/orleans/pull/3359.diff","patch_url":"https://github.com/dotnet/orleans/pull/3359.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/3359","number":3359,"state":"closed","locked":false,"title":"[Abstractions] Remove dependency from Serialization in UniqueKey","user":{"login":"benjaminpetit","id":20427417,"avatar_url":"https://avatars0.githubusercontent.com/u/20427417?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminpetit","html_url":"https://github.com/benjaminpetit","followers_url":"https://api.github.com/users/benjaminpetit/followers","following_url":"https://api.github.com/users/benjaminpetit/following{/other_user}","gists_url":"https://api.github.com/users/benjaminpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminpetit/subscriptions","organizations_url":"https://api.github.com/users/benjaminpetit/orgs","repos_url":"https://api.github.com/users/benjaminpetit/repos","events_url":"https://api.github.com/users/benjaminpetit/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminpetit/received_events","type":"User","site_admin":false},"body":"Since this is a potentially dangerous change, please review this CR carefully.\r\n\r\n~~This PR will consist of 2 commits:~~\r\n\r\n- the first will remove the dependency to serialization in `UniqueKey` by duplicating the existing logic from `BinaryTokenStreamWriter.Write(UniqueKey key)`. I added a test to check that the value returned by the new method is consistent with the previous method.\r\n- ~~the second (to come after this first commit pass the build) will remove the code duplication in `BinaryTokenStreamWriter` by calling the method added in the first commit.~~\r\n\r\n~~Basically this will \"invert\" the dependency.~~\r\n\r\nAfter thoughts, I don't think we should to the 2nd commit, since they are not supposed to share the same logic after all. But I will keep the test to show that the value used for the hash is consistent with the previous method.","created_at":"2017-08-30T00:55:05Z","updated_at":"2017-08-31T06:14:41Z","closed_at":"2017-08-31T06:14:41Z","merged_at":"2017-08-31T06:14:41Z","merge_commit_sha":"b51e10d18b6b8e6ac210087a8ee8cd9d12c5f965","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/3359/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/3359/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/3359/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/c451fa482ecc47f670058aa3874884b087b25c7a","head":{"label":"benjaminpetit:abstractions-ids","ref":"abstractions-ids","sha":"c451fa482ecc47f670058aa3874884b087b25c7a","user":{"login":"benjaminpetit","id":20427417,"avatar_url":"https://avatars0.githubusercontent.com/u/20427417?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminpetit","html_url":"https://github.com/benjaminpetit","followers_url":"https://api.github.com/users/benjaminpetit/followers","following_url":"https://api.github.com/users/benjaminpetit/following{/other_user}","gists_url":"https://api.github.com/users/benjaminpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminpetit/subscriptions","organizations_url":"https://api.github.com/users/benjaminpetit/orgs","repos_url":"https://api.github.com/users/benjaminpetit/repos","events_url":"https://api.github.com/users/benjaminpetit/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminpetit/received_events","type":"User","site_admin":false},"repo":{"id":63194422,"name":"orleans","full_name":"benjaminpetit/orleans","owner":{"login":"benjaminpetit","id":20427417,"avatar_url":"https://avatars0.githubusercontent.com/u/20427417?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminpetit","html_url":"https://github.com/benjaminpetit","followers_url":"https://api.github.com/users/benjaminpetit/followers","following_url":"https://api.github.com/users/benjaminpetit/following{/other_user}","gists_url":"https://api.github.com/users/benjaminpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminpetit/subscriptions","organizations_url":"https://api.github.com/users/benjaminpetit/orgs","repos_url":"https://api.github.com/users/benjaminpetit/repos","events_url":"https://api.github.com/users/benjaminpetit/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminpetit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminpetit/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/benjaminpetit/orleans","forks_url":"https://api.github.com/repos/benjaminpetit/orleans/forks","keys_url":"https://api.github.com/repos/benjaminpetit/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminpetit/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminpetit/orleans/teams","hooks_url":"https://api.github.com/repos/benjaminpetit/orleans/hooks","issue_events_url":"https://api.github.com/repos/benjaminpetit/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminpetit/orleans/events","assignees_url":"https://api.github.com/repos/benjaminpetit/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminpetit/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminpetit/orleans/tags","blobs_url":"https://api.github.com/repos/benjaminpetit/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminpetit/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminpetit/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminpetit/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminpetit/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminpetit/orleans/languages","stargazers_url":"https://api.github.com/repos/benjaminpetit/orleans/stargazers","contributors_url":"https://api.github.com/repos/benjaminpetit/orleans/contributors","subscribers_url":"https://api.github.com/repos/benjaminpetit/orleans/subscribers","subscription_url":"https://api.github.com/repos/benjaminpetit/orleans/subscription","commits_url":"https://api.github.com/repos/benjaminpetit/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminpetit/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminpetit/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminpetit/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminpetit/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminpetit/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminpetit/orleans/merges","archive_url":"https://api.github.com/repos/benjaminpetit/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminpetit/orleans/downloads","issues_url":"https://api.github.com/repos/benjaminpetit/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminpetit/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminpetit/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminpetit/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminpetit/orleans/labels{/name}","releases_url":"https://api.github.com/repos/benjaminpetit/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminpetit/orleans/deployments","created_at":"2016-07-12T21:45:14Z","updated_at":"2016-07-12T21:45:18Z","pushed_at":"2017-08-30T23:04:35Z","git_url":"git://github.com/benjaminpetit/orleans.git","ssh_url":"git@github.com:benjaminpetit/orleans.git","clone_url":"https://github.com/benjaminpetit/orleans.git","svn_url":"https://github.com/benjaminpetit/orleans","homepage":"http://dotnet.github.io/orleans","size":39717,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9375ff2603ca16d60527f4d8aa4273c69f8b2a3e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2017-08-31T05:16:35Z","pushed_at":"2017-08-31T06:14:40Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":40205,"stargazers_count":3049,"watchers_count":3049,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":755,"mirror_url":null,"open_issues_count":303,"forks":755,"open_issues":303,"watchers":3049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3359"},"html":{"href":"https://github.com/dotnet/orleans/pull/3359"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3359"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3359/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3359/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3359/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/c451fa482ecc47f670058aa3874884b087b25c7a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars1.githubusercontent.com/u/203839?v=4","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":62,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"ReubenBond"}}