{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38071","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38071/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38071/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38071/events","html_url":"https://github.com/kubernetes/kubernetes/pull/38071","id":193378848,"number":38071,"title":"OpenAPI generated definition names are not unique across groups","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars.githubusercontent.com/u/1613024?v=3","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars.githubusercontent.com/u/1613024?v=3","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false}],"milestone":null,"comments":45,"created_at":"2016-12-04T21:53:28Z","updated_at":"2017-01-03T21:49:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38071","html_url":"https://github.com/kubernetes/kubernetes/pull/38071","diff_url":"https://github.com/kubernetes/kubernetes/pull/38071.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38071.patch"},"body":"There can be more than one type with a given name in a given version, but in different groups. For example, `pkg/apis/batch/v1#Foo` could also be in `pkg/api/v1#Foo`, and OpenAPI would generate the same name `v1.Foo`, which causes a conflict (duplicate name).\n\nInstead, we should assign names that include group + version as a prefix. This PR uses the default algorithm in gengo for assigning package shortnames (`parentpackage_package.Type`).\n\nThis will impact any caller that generates from OpenAPI, but they were already broken.\n\nFound during #37530"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/270234714","html_url":"https://github.com/kubernetes/kubernetes/pull/38071#issuecomment-270234714","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38071","id":270234714,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-01-03T21:49:25Z","updated_at":"2017-01-03T21:49:25Z","body":"Jenkins unit/integration [**failed**](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/38071/pull-kubernetes-unit/11445/) for commit c7a75245ed26541bfd1ee1b922dfb9f1e40e2d82. [Full PR test history](http://pr-test.k8s.io/38071).\n\nThe magic incantation to run this job again is `@k8s-bot unit test this`. Please help us cut down flakes by linking to an [open flake issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open) when you hit one in your PR.\n\n<details>\n\nIf you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/prow/commands.md).\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}