{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8","id":100714799,"html_url":"https://github.com/ONSdigital/dp-frontend-models/pull/8","diff_url":"https://github.com/ONSdigital/dp-frontend-models/pull/8.diff","patch_url":"https://github.com/ONSdigital/dp-frontend-models/pull/8.patch","issue_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/8","number":8,"state":"closed","locked":false,"title":"Add configs for dataset react app to use","user":{"login":"Crispioso","id":8183179,"avatar_url":"https://avatars.githubusercontent.com/u/8183179?v=3","gravatar_id":"","url":"https://api.github.com/users/Crispioso","html_url":"https://github.com/Crispioso","followers_url":"https://api.github.com/users/Crispioso/followers","following_url":"https://api.github.com/users/Crispioso/following{/other_user}","gists_url":"https://api.github.com/users/Crispioso/gists{/gist_id}","starred_url":"https://api.github.com/users/Crispioso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crispioso/subscriptions","organizations_url":"https://api.github.com/users/Crispioso/orgs","repos_url":"https://api.github.com/users/Crispioso/repos","events_url":"https://api.github.com/users/Crispioso/events{/privacy}","received_events_url":"https://api.github.com/users/Crispioso/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\nAdd environment variables for JS application in dataset page. Some default configurations are still pointing to local, rather than production values, because other work needs to be done first to get production values for those variables.\r\n\r\n### How to review\r\n\r\nReact app still starts up and a dataset from '/dd' list of datasets works fine on your local machine.\r\n\r\n### Who can review\r\n\r\nAnyone but me.","created_at":"2017-01-09T16:25:04Z","updated_at":"2017-01-10T08:35:23Z","closed_at":"2017-01-10T08:35:23Z","merged_at":"2017-01-10T08:35:23Z","merge_commit_sha":"7d46067031c434fb9f292914631f6ad015f23e00","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/8/comments","statuses_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/statuses/c2d6504f8f2f4604ff9c3344f01fe30f6618396c","head":{"label":"ONSdigital:feature/js-configs","ref":"feature/js-configs","sha":"c2d6504f8f2f4604ff9c3344f01fe30f6618396c","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":74004585,"name":"dp-frontend-models","full_name":"ONSdigital/dp-frontend-models","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-frontend-models","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-frontend-models","forks_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/deployments","created_at":"2016-11-17T08:09:12Z","updated_at":"2016-11-17T08:59:40Z","pushed_at":"2017-01-10T08:35:23Z","git_url":"git://github.com/ONSdigital/dp-frontend-models.git","ssh_url":"git@github.com:ONSdigital/dp-frontend-models.git","clone_url":"https://github.com/ONSdigital/dp-frontend-models.git","svn_url":"https://github.com/ONSdigital/dp-frontend-models","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ONSdigital:dd-develop","ref":"dd-develop","sha":"6d96124bfc3282f164df198daa964efdd2c75174","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":74004585,"name":"dp-frontend-models","full_name":"ONSdigital/dp-frontend-models","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-frontend-models","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-frontend-models","forks_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-frontend-models/deployments","created_at":"2016-11-17T08:09:12Z","updated_at":"2016-11-17T08:59:40Z","pushed_at":"2017-01-10T08:35:23Z","git_url":"git://github.com/ONSdigital/dp-frontend-models.git","ssh_url":"git@github.com:ONSdigital/dp-frontend-models.git","clone_url":"https://github.com/ONSdigital/dp-frontend-models.git","svn_url":"https://github.com/ONSdigital/dp-frontend-models","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8"},"html":{"href":"https://github.com/ONSdigital/dp-frontend-models/pull/8"},"issue":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/8"},"comments":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/dp-frontend-models/statuses/c2d6504f8f2f4604ff9c3344f01fe30f6618396c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ian-kent","id":2300772,"avatar_url":"https://avatars.githubusercontent.com/u/2300772?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-kent","html_url":"https://github.com/ian-kent","followers_url":"https://api.github.com/users/ian-kent/followers","following_url":"https://api.github.com/users/ian-kent/following{/other_user}","gists_url":"https://api.github.com/users/ian-kent/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-kent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-kent/subscriptions","organizations_url":"https://api.github.com/users/ian-kent/orgs","repos_url":"https://api.github.com/users/ian-kent/repos","events_url":"https://api.github.com/users/ian-kent/events{/privacy}","received_events_url":"https://api.github.com/users/ian-kent/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"ian-kent"}}