{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/6381","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/6381/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/6381/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/6381/events","html_url":"https://github.com/librenms/librenms/pull/6381","id":220313867,"number":6381,"title":"feature: Added rrdtool version check to compare installed version with defined version","user":{"login":"laf","id":3941142,"avatar_url":"https://avatars3.githubusercontent.com/u/3941142?v=3","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-04-07T20:00:08Z","updated_at":"2017-04-10T02:16:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/6381","html_url":"https://github.com/librenms/librenms/pull/6381","diff_url":"https://github.com/librenms/librenms/pull/6381.diff","patch_url":"https://github.com/librenms/librenms/pull/6381.patch"},"body":"DO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [X] Have you signed the [Contributors agreement](http://docs.librenms.org/General/Contributing/) - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.\r\n- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n\r\nCame across a user this week who had blindly set `$config['rrdtool_version'] = '1.6.0';` when running 1.4.3 resulting in poor performance apparently. Easy enough to test for."},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/292833861","html_url":"https://github.com/librenms/librenms/pull/6381#issuecomment-292833861","issue_url":"https://api.github.com/repos/librenms/librenms/issues/6381","id":292833861,"user":{"login":"murrant","id":39462,"avatar_url":"https://avatars1.githubusercontent.com/u/39462?v=3","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T02:16:43Z","updated_at":"2017-04-10T02:16:43Z","body":"I think for validate we should only raise the alarm if the version is newer than the binary"}}
{"actor":{"display_login":"murrant"}}