{"action":"created","comment":{"url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments/99151330","pull_request_review_id":19818349,"id":99151330,"diff_hunk":"@@ -233,3 +233,26 @@ def set_choices(self):\n     def set_help_text(self):\n         self.route_table.help_text = self.route_table_help_text\n         self.public_ip_auto_assignment.help_text = self.public_ip_auto_assignment_help_text\n+\n+\n+class RouteTableForm(BaseSecureForm):\n+    \"\"\"Form to update an existing route table\"\"\"\n+    name_error_msg = _('Not a valid name')\n+    name = TextEscapedField(label=_('Name'))\n+\n+    def __init__(self, request, route_table=None, **kwargs):\n+        super(RouteTableForm, self).__init__(request, **kwargs)\n+        self.route_table = route_table\n+        self.name.error_msg = self.name_error_msg\n+\n+        if self.route_table:","path":"eucaconsole/forms/vpcs.py","position":16,"original_position":16,"commit_id":"65e1e4715ed80676bec1197b94f1b005dc227f46","original_commit_id":"65e1e4715ed80676bec1197b94f1b005dc227f46","user":{"login":"dkavanagh","id":367566,"avatar_url":"https://avatars.githubusercontent.com/u/367566?v=3","gravatar_id":"","url":"https://api.github.com/users/dkavanagh","html_url":"https://github.com/dkavanagh","followers_url":"https://api.github.com/users/dkavanagh/followers","following_url":"https://api.github.com/users/dkavanagh/following{/other_user}","gists_url":"https://api.github.com/users/dkavanagh/gists{/gist_id}","starred_url":"https://api.github.com/users/dkavanagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkavanagh/subscriptions","organizations_url":"https://api.github.com/users/dkavanagh/orgs","repos_url":"https://api.github.com/users/dkavanagh/repos","events_url":"https://api.github.com/users/dkavanagh/events{/privacy}","received_events_url":"https://api.github.com/users/dkavanagh/received_events","type":"User","site_admin":false},"body":"Will route table ever be None? I notice one is always passed to the form in the view.","created_at":"2017-02-02T15:56:11Z","updated_at":"2017-02-02T15:56:11Z","html_url":"https://github.com/eucalyptus/eucaconsole/pull/2165#discussion_r99151330","pull_request_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165","_links":{"self":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments/99151330"},"html":{"href":"https://github.com/eucalyptus/eucaconsole/pull/2165#discussion_r99151330"},"pull_request":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165"}}},"pull_request":{"url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165","id":104213875,"html_url":"https://github.com/eucalyptus/eucaconsole/pull/2165","diff_url":"https://github.com/eucalyptus/eucaconsole/pull/2165.diff","patch_url":"https://github.com/eucalyptus/eucaconsole/pull/2165.patch","issue_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/2165","number":2165,"state":"open","locked":false,"title":"GUI-2829: Implement route table details page","user":{"login":"kamalgill","id":133923,"avatar_url":"https://avatars.githubusercontent.com/u/133923?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalgill","html_url":"https://github.com/kamalgill","followers_url":"https://api.github.com/users/kamalgill/followers","following_url":"https://api.github.com/users/kamalgill/following{/other_user}","gists_url":"https://api.github.com/users/kamalgill/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalgill/subscriptions","organizations_url":"https://api.github.com/users/kamalgill/orgs","repos_url":"https://api.github.com/users/kamalgill/repos","events_url":"https://api.github.com/users/kamalgill/events{/privacy}","received_events_url":"https://api.github.com/users/kamalgill/received_events","type":"User","site_admin":false},"body":"Implements https://eucalyptus.atlassian.net/browse/GUI-2829\n\nNOTE: This is a work in progress -- more work is needed in GUI-2829 to incorporate NAT gateways as route targets","created_at":"2017-02-01T20:22:03Z","updated_at":"2017-02-02T15:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a47b21b1c11e606973873d3cb7f40d240e0509","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165/commits","review_comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165/comments","review_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/2165/comments","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/65e1e4715ed80676bec1197b94f1b005dc227f46","head":{"label":"eucalyptus:GUI-2829","ref":"GUI-2829","sha":"65e1e4715ed80676bec1197b94f1b005dc227f46","user":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"repo":{"id":13843551,"name":"eucaconsole","full_name":"eucalyptus/eucaconsole","owner":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eucalyptus/eucaconsole","description":"Eucalyptus Management Console","fork":false,"url":"https://api.github.com/repos/eucalyptus/eucaconsole","forks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/forks","keys_url":"https://api.github.com/repos/eucalyptus/eucaconsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eucalyptus/eucaconsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eucalyptus/eucaconsole/teams","hooks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/hooks","issue_events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/events{/number}","events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/events","assignees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/assignees{/user}","branches_url":"https://api.github.com/repos/eucalyptus/eucaconsole/branches{/branch}","tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/tags","blobs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/{sha}","languages_url":"https://api.github.com/repos/eucalyptus/eucaconsole/languages","stargazers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/stargazers","contributors_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contributors","subscribers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscribers","subscription_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscription","commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contents/{+path}","compare_url":"https://api.github.com/repos/eucalyptus/eucaconsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eucalyptus/eucaconsole/merges","archive_url":"https://api.github.com/repos/eucalyptus/eucaconsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eucalyptus/eucaconsole/downloads","issues_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues{/number}","pulls_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls{/number}","milestones_url":"https://api.github.com/repos/eucalyptus/eucaconsole/milestones{/number}","notifications_url":"https://api.github.com/repos/eucalyptus/eucaconsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eucalyptus/eucaconsole/labels{/name}","releases_url":"https://api.github.com/repos/eucalyptus/eucaconsole/releases{/id}","deployments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/deployments","created_at":"2013-10-24T20:31:49Z","updated_at":"2017-01-19T00:27:12Z","pushed_at":"2017-02-01T20:29:46Z","git_url":"git://github.com/eucalyptus/eucaconsole.git","ssh_url":"git@github.com:eucalyptus/eucaconsole.git","clone_url":"https://github.com/eucalyptus/eucaconsole.git","svn_url":"https://github.com/eucalyptus/eucaconsole","homepage":"","size":36515,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":4,"forks":23,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"eucalyptus:master","ref":"master","sha":"95327c28731b4035ac2c7562f7fe9e6125ea48e9","user":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"repo":{"id":13843551,"name":"eucaconsole","full_name":"eucalyptus/eucaconsole","owner":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eucalyptus/eucaconsole","description":"Eucalyptus Management Console","fork":false,"url":"https://api.github.com/repos/eucalyptus/eucaconsole","forks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/forks","keys_url":"https://api.github.com/repos/eucalyptus/eucaconsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eucalyptus/eucaconsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eucalyptus/eucaconsole/teams","hooks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/hooks","issue_events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/events{/number}","events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/events","assignees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/assignees{/user}","branches_url":"https://api.github.com/repos/eucalyptus/eucaconsole/branches{/branch}","tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/tags","blobs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/{sha}","languages_url":"https://api.github.com/repos/eucalyptus/eucaconsole/languages","stargazers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/stargazers","contributors_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contributors","subscribers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscribers","subscription_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscription","commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contents/{+path}","compare_url":"https://api.github.com/repos/eucalyptus/eucaconsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eucalyptus/eucaconsole/merges","archive_url":"https://api.github.com/repos/eucalyptus/eucaconsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eucalyptus/eucaconsole/downloads","issues_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues{/number}","pulls_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls{/number}","milestones_url":"https://api.github.com/repos/eucalyptus/eucaconsole/milestones{/number}","notifications_url":"https://api.github.com/repos/eucalyptus/eucaconsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eucalyptus/eucaconsole/labels{/name}","releases_url":"https://api.github.com/repos/eucalyptus/eucaconsole/releases{/id}","deployments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/deployments","created_at":"2013-10-24T20:31:49Z","updated_at":"2017-01-19T00:27:12Z","pushed_at":"2017-02-01T20:29:46Z","git_url":"git://github.com/eucalyptus/eucaconsole.git","ssh_url":"git@github.com:eucalyptus/eucaconsole.git","clone_url":"https://github.com/eucalyptus/eucaconsole.git","svn_url":"https://github.com/eucalyptus/eucaconsole","homepage":"","size":36515,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":4,"forks":23,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165"},"html":{"href":"https://github.com/eucalyptus/eucaconsole/pull/2165"},"issue":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/2165"},"comments":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/2165/comments"},"review_comments":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165/comments"},"review_comment":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/2165/commits"},"statuses":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/65e1e4715ed80676bec1197b94f1b005dc227f46"}}}}
{"actor":{"display_login":"dkavanagh"}}