{"action":"created","issue":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/416","repository_url":"https://api.github.com/repos/TextureGroup/Texture","labels_url":"https://api.github.com/repos/TextureGroup/Texture/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/416/comments","events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/416/events","html_url":"https://github.com/TextureGroup/Texture/pull/416","id":240483692,"number":416,"title":"[ASDataController] Fix a crash in table view caused by executing an empty change set during layoutSubviews","user":{"login":"nguyenhuy","id":587874,"avatar_url":"https://avatars2.githubusercontent.com/u/587874?v=3","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-04T19:01:20Z","updated_at":"2017-07-05T19:23:30Z","closed_at":"2017-07-05T17:55:45Z","pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/416","html_url":"https://github.com/TextureGroup/Texture/pull/416","diff_url":"https://github.com/TextureGroup/Texture/pull/416.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/416.patch"},"body":"- Previously, when a change set is empty, `ASDataController` forwards the change set to its delegate right away, without dispatching to its editing queue and then back to main.\r\n- This behaviour can potentially cause bad internal states in UITableView which trigger a crash reported in #83.\r\n- Fix by still reusing the existing pending map, because the data source's state has not changed, but go through the editing queue and main queue tunnel.\r\n\r\nFixes #83."},"comment":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments/313201385","html_url":"https://github.com/TextureGroup/Texture/pull/416#issuecomment-313201385","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/416","id":313201385,"user":{"login":"rewandy","id":4761768,"avatar_url":"https://avatars1.githubusercontent.com/u/4761768?v=3","gravatar_id":"","url":"https://api.github.com/users/rewandy","html_url":"https://github.com/rewandy","followers_url":"https://api.github.com/users/rewandy/followers","following_url":"https://api.github.com/users/rewandy/following{/other_user}","gists_url":"https://api.github.com/users/rewandy/gists{/gist_id}","starred_url":"https://api.github.com/users/rewandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rewandy/subscriptions","organizations_url":"https://api.github.com/users/rewandy/orgs","repos_url":"https://api.github.com/users/rewandy/repos","events_url":"https://api.github.com/users/rewandy/events{/privacy}","received_events_url":"https://api.github.com/users/rewandy/received_events","type":"User","site_admin":false},"created_at":"2017-07-05T19:23:30Z","updated_at":"2017-07-05T19:23:30Z","body":"We can confirm this addresses our issue! Thanks so much for tackling this - we can finally get with the times and update to Texture!"}}
{"actor":{"display_login":"rewandy"}}