{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/clio/pulls/comments/134303600","pull_request_review_id":57580402,"id":134303600,"diff_hunk":"@@ -0,0 +1,13 @@\n+package org.broadinstitute.clio.transfer.model","path":"clio-transfer-model/src/main/scala/org/broadinstitute/clio/transfer/model/UBamFileStatus.scala","position":null,"original_position":1,"commit_id":"cf920c325f34e7787b0b4325c52e6e5102d0ba87","original_commit_id":"3c084cf9e31b055df53b42780f1fc3081022aeea","user":{"login":"gbggrant","id":4129081,"avatar_url":"https://avatars3.githubusercontent.com/u/4129081?v=4","gravatar_id":"","url":"https://api.github.com/users/gbggrant","html_url":"https://github.com/gbggrant","followers_url":"https://api.github.com/users/gbggrant/followers","following_url":"https://api.github.com/users/gbggrant/following{/other_user}","gists_url":"https://api.github.com/users/gbggrant/gists{/gist_id}","starred_url":"https://api.github.com/users/gbggrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbggrant/subscriptions","organizations_url":"https://api.github.com/users/gbggrant/orgs","repos_url":"https://api.github.com/users/gbggrant/repos","events_url":"https://api.github.com/users/gbggrant/events{/privacy}","received_events_url":"https://api.github.com/users/gbggrant/received_events","type":"User","site_admin":false},"body":"I've named it DocumentStatus (already had that refactor in place) - we can discuss if FileStatus is a better choice.","created_at":"2017-08-21T18:54:34Z","updated_at":"2017-08-21T18:54:34Z","html_url":"https://github.com/broadinstitute/clio/pull/71#discussion_r134303600","pull_request_url":"https://api.github.com/repos/broadinstitute/clio/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/comments/134303600"},"html":{"href":"https://github.com/broadinstitute/clio/pull/71#discussion_r134303600"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/clio/pulls/71","id":135859406,"html_url":"https://github.com/broadinstitute/clio/pull/71","diff_url":"https://github.com/broadinstitute/clio/pull/71.diff","patch_url":"https://github.com/broadinstitute/clio/pull/71.patch","issue_url":"https://api.github.com/repos/broadinstitute/clio/issues/71","number":71,"state":"open","locked":false,"title":"gg_DSDEGP-1480 Added support for deleting ubam records","user":{"login":"gbggrant","id":4129081,"avatar_url":"https://avatars3.githubusercontent.com/u/4129081?v=4","gravatar_id":"","url":"https://api.github.com/users/gbggrant","html_url":"https://github.com/gbggrant","followers_url":"https://api.github.com/users/gbggrant/followers","following_url":"https://api.github.com/users/gbggrant/following{/other_user}","gists_url":"https://api.github.com/users/gbggrant/gists{/gist_id}","starred_url":"https://api.github.com/users/gbggrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbggrant/subscriptions","organizations_url":"https://api.github.com/users/gbggrant/orgs","repos_url":"https://api.github.com/users/gbggrant/repos","events_url":"https://api.github.com/users/gbggrant/events{/privacy}","received_events_url":"https://api.github.com/users/gbggrant/received_events","type":"User","site_admin":false},"body":"Added new enum flag to data model to support marking ubam as deleted 'ubam_file_status'\r\nSet to 'Normal' for upserts that don't explicitly set it.\r\nAdded queryall endpoint to return all records (deleted or not)\r\nModified query endpoint to only return non-deleted 'Normal' records\r\n\r\n### Description\r\n\r\nJira DSDEGP-1480\r\nAdded new enum flag to data model to support marking ubam as deleted 'ubam_file_status'\r\nSet to 'Normal' for upserts that don't explicitly set it.\r\nAdded queryall endpoint to return all records (deleted or not)\r\nModified query endpoint to only return non-deleted 'Normal' records\r\n\r\n\r\n----\r\n\r\n### Checklist (never delete this)\r\n\r\nNever delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.\r\n\r\n- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: Ensure that you have added or updated tests\r\n- [ ] **Submitter**: If you're adding/switching libraries or otherwise changing the design, update the [design documentation](https://broadinstitute.atlassian.net/wiki/pages/viewpage.action?pageId=114531509).\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * Add notes on what you've tested\r\n* Review cycle:\r\n  * Team may comment on PR at will\r\n  * **Reviewer assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to reviewer** for further feedback\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Move the JIRA issue to QA once this checklist is completed\r\n","created_at":"2017-08-15T18:18:26Z","updated_at":"2017-08-21T18:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"628408b83a96a320e5190adaf502396429421e0c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/clio/pulls/71/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/clio/pulls/71/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/clio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/clio/issues/71/comments","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/cf920c325f34e7787b0b4325c52e6e5102d0ba87","head":{"label":"broadinstitute:gg_DSDEGP-1480_queryAllEndpoint","ref":"gg_DSDEGP-1480_queryAllEndpoint","sha":"cf920c325f34e7787b0b4325c52e6e5102d0ba87","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":88189881,"name":"clio","full_name":"broadinstitute/clio","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/clio","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/clio","forks_url":"https://api.github.com/repos/broadinstitute/clio/forks","keys_url":"https://api.github.com/repos/broadinstitute/clio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/clio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/clio/teams","hooks_url":"https://api.github.com/repos/broadinstitute/clio/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/clio/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/clio/events","assignees_url":"https://api.github.com/repos/broadinstitute/clio/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/clio/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/clio/tags","blobs_url":"https://api.github.com/repos/broadinstitute/clio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/clio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/clio/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/clio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/clio/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/clio/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/clio/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/clio/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/clio/subscription","commits_url":"https://api.github.com/repos/broadinstitute/clio/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/clio/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/clio/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/clio/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/clio/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/clio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/clio/merges","archive_url":"https://api.github.com/repos/broadinstitute/clio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/clio/downloads","issues_url":"https://api.github.com/repos/broadinstitute/clio/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/clio/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/clio/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/clio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/clio/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/clio/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/clio/deployments","created_at":"2017-04-13T17:28:28Z","updated_at":"2017-07-06T22:50:40Z","pushed_at":"2017-08-21T18:26:52Z","git_url":"git://github.com/broadinstitute/clio.git","ssh_url":"git@github.com:broadinstitute/clio.git","clone_url":"https://github.com/broadinstitute/clio.git","svn_url":"https://github.com/broadinstitute/clio","homepage":null,"size":441,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"f1d4a6a17dd6777fa981dc7c9ba1185acb9e4de6","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":88189881,"name":"clio","full_name":"broadinstitute/clio","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/clio","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/clio","forks_url":"https://api.github.com/repos/broadinstitute/clio/forks","keys_url":"https://api.github.com/repos/broadinstitute/clio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/clio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/clio/teams","hooks_url":"https://api.github.com/repos/broadinstitute/clio/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/clio/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/clio/events","assignees_url":"https://api.github.com/repos/broadinstitute/clio/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/clio/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/clio/tags","blobs_url":"https://api.github.com/repos/broadinstitute/clio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/clio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/clio/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/clio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/clio/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/clio/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/clio/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/clio/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/clio/subscription","commits_url":"https://api.github.com/repos/broadinstitute/clio/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/clio/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/clio/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/clio/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/clio/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/clio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/clio/merges","archive_url":"https://api.github.com/repos/broadinstitute/clio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/clio/downloads","issues_url":"https://api.github.com/repos/broadinstitute/clio/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/clio/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/clio/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/clio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/clio/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/clio/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/clio/deployments","created_at":"2017-04-13T17:28:28Z","updated_at":"2017-07-06T22:50:40Z","pushed_at":"2017-08-21T18:26:52Z","git_url":"git://github.com/broadinstitute/clio.git","ssh_url":"git@github.com:broadinstitute/clio.git","clone_url":"https://github.com/broadinstitute/clio.git","svn_url":"https://github.com/broadinstitute/clio","homepage":null,"size":441,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/71"},"html":{"href":"https://github.com/broadinstitute/clio/pull/71"},"issue":{"href":"https://api.github.com/repos/broadinstitute/clio/issues/71"},"comments":{"href":"https://api.github.com/repos/broadinstitute/clio/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/clio/statuses/cf920c325f34e7787b0b4325c52e6e5102d0ba87"}}}}
{"actor":{"display_login":"gbggrant"}}