{"action":"created","comment":{"url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/comments/140570916","pull_request_review_id":64437532,"id":140570916,"diff_hunk":"@@ -527,27 +604,73 @@ def doDiffIm(processed_repo, sciencevisit, ccdnum, templatevisit, diffim_repo):\n         config.doDecorrelation = True\n \n     TODO: use coadds as templates by default, not another visit (DM-11422).\n+    Some of the comments in this function are placeholders for DM-11422 work.\n \n     RESULT:\n-    diffim_repo/deepDiff/v+sciencevisit populated with difference images\n+    diffim_repo/deepDiff/v+visit populated with difference images\n     and catalogs of detected sources (diaSrc, diffexp, and metadata files)\n     '''\n-    if os.path.exists(os.path.join(diffim_repo, 'deepDiff', 'v' + sciencevisit)):\n-        print('DiffIm has already been run for visit {0}, skipping...'.format(sciencevisit))\n+    lsst.log.configure()\n+    log = lsst.log.Log.getLogger('ap.pipe.doDiffIm')\n+    dataId_items = re.split('[ +=]', dataId)\n+    dataId_dict = dict(zip(dataId_items[::2], dataId_items[1::2]))\n+    if 'visit' not in dataId_dict.keys():\n+        raise RuntimeError('The dataId string is missing \\'visit\\'')\n+    else:  # save the visit number from the dataId\n+        visit = dataId_dict['visit']\n+    if os.path.exists(os.path.join(diffim_repo, 'deepDiff', 'v' + visit)):\n+        log.warn('DiffIm has already been run for visit {0}, skipping...'.format(visit))\n         return None\n     if not os.path.isdir(diffim_repo):\n         os.mkdir(diffim_repo)\n-    print('Running ImageDifference...')\n+    log.info('Running ImageDifference...')\n     config = ImageDifferenceConfig()\n-    config.getTemplate.retarget(GetCalexpAsTemplateTask)\n+    config.getTemplate.retarget(GetCalexpAsTemplateTask)  # visit template config\n+    # config.doSelectSources = False  # coadd template config\n     config.detection.thresholdValue = 5.0\n     config.doDecorrelation = True\n-    args = [processed_repo, '--id', 'visit=' + sciencevisit, 'ccdnum=' + ccdnum,\n-            '--templateId', 'visit=' + templatevisit, '--output', diffim_repo]\n+    dataId = dataId.split(' ')","path":"python/lsst/ap/pipe/ap_pipe.py","position":643,"original_position":643,"commit_id":"a3db926292cbc39123f2332ca2e51d9be4e2b0d9","original_commit_id":"a3db926292cbc39123f2332ca2e51d9be4e2b0d9","user":{"login":"kfindeisen","id":8508260,"avatar_url":"https://avatars3.githubusercontent.com/u/8508260?v=4","gravatar_id":"","url":"https://api.github.com/users/kfindeisen","html_url":"https://github.com/kfindeisen","followers_url":"https://api.github.com/users/kfindeisen/followers","following_url":"https://api.github.com/users/kfindeisen/following{/other_user}","gists_url":"https://api.github.com/users/kfindeisen/gists{/gist_id}","starred_url":"https://api.github.com/users/kfindeisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfindeisen/subscriptions","organizations_url":"https://api.github.com/users/kfindeisen/orgs","repos_url":"https://api.github.com/users/kfindeisen/repos","events_url":"https://api.github.com/users/kfindeisen/events{/privacy}","received_events_url":"https://api.github.com/users/kfindeisen/received_events","type":"User","site_admin":false},"body":"Why are you splitting on three characters above but only on spaces here?","created_at":"2017-09-22T18:54:56Z","updated_at":"2017-09-22T19:02:22Z","html_url":"https://github.com/lsst-dm/ap_pipe/pull/6#discussion_r140570916","pull_request_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/comments/140570916"},"html":{"href":"https://github.com/lsst-dm/ap_pipe/pull/6#discussion_r140570916"},"pull_request":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6","id":142243817,"html_url":"https://github.com/lsst-dm/ap_pipe/pull/6","diff_url":"https://github.com/lsst-dm/ap_pipe/pull/6.diff","patch_url":"https://github.com/lsst-dm/ap_pipe/pull/6.patch","issue_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/6","number":6,"state":"open","locked":false,"title":"DM-11390: Plug prototype pipeline script into verify_ap framework","user":{"login":"mrawls","id":5659077,"avatar_url":"https://avatars2.githubusercontent.com/u/5659077?v=4","gravatar_id":"","url":"https://api.github.com/users/mrawls","html_url":"https://github.com/mrawls","followers_url":"https://api.github.com/users/mrawls/followers","following_url":"https://api.github.com/users/mrawls/following{/other_user}","gists_url":"https://api.github.com/users/mrawls/gists{/gist_id}","starred_url":"https://api.github.com/users/mrawls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrawls/subscriptions","organizations_url":"https://api.github.com/users/mrawls/orgs","repos_url":"https://api.github.com/users/mrawls/repos","events_url":"https://api.github.com/users/mrawls/events{/privacy}","received_events_url":"https://api.github.com/users/mrawls/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-21T02:35:02Z","updated_at":"2017-09-22T19:02:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"542eaa82f10e4904f92907c9f135ba9383e11991","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6/commits","review_comments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6/comments","review_comment_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/6/comments","statuses_url":"https://api.github.com/repos/lsst-dm/ap_pipe/statuses/a3db926292cbc39123f2332ca2e51d9be4e2b0d9","head":{"label":"lsst-dm:tickets/DM-11390","ref":"tickets/DM-11390","sha":"a3db926292cbc39123f2332ca2e51d9be4e2b0d9","user":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":77710130,"name":"ap_pipe","full_name":"lsst-dm/ap_pipe","owner":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/ap_pipe","description":"Using lsst/obs_decam to process raw HiTS data","fork":false,"url":"https://api.github.com/repos/lsst-dm/ap_pipe","forks_url":"https://api.github.com/repos/lsst-dm/ap_pipe/forks","keys_url":"https://api.github.com/repos/lsst-dm/ap_pipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/ap_pipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/ap_pipe/teams","hooks_url":"https://api.github.com/repos/lsst-dm/ap_pipe/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/ap_pipe/events","assignees_url":"https://api.github.com/repos/lsst-dm/ap_pipe/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/ap_pipe/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/ap_pipe/tags","blobs_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/ap_pipe/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/ap_pipe/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/ap_pipe/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/ap_pipe/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/ap_pipe/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/ap_pipe/subscription","commits_url":"https://api.github.com/repos/lsst-dm/ap_pipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/ap_pipe/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/ap_pipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/ap_pipe/merges","archive_url":"https://api.github.com/repos/lsst-dm/ap_pipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/ap_pipe/downloads","issues_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/ap_pipe/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/ap_pipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/ap_pipe/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/ap_pipe/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/deployments","created_at":"2016-12-30T20:58:57Z","updated_at":"2017-08-11T20:12:01Z","pushed_at":"2017-09-22T02:08:27Z","git_url":"git://github.com/lsst-dm/ap_pipe.git","ssh_url":"git@github.com:lsst-dm/ap_pipe.git","clone_url":"https://github.com/lsst-dm/ap_pipe.git","svn_url":"https://github.com/lsst-dm/ap_pipe","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst-dm:master","ref":"master","sha":"2e9464a12c0187fa2ea27f8e4433a08c7a541947","user":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":77710130,"name":"ap_pipe","full_name":"lsst-dm/ap_pipe","owner":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/ap_pipe","description":"Using lsst/obs_decam to process raw HiTS data","fork":false,"url":"https://api.github.com/repos/lsst-dm/ap_pipe","forks_url":"https://api.github.com/repos/lsst-dm/ap_pipe/forks","keys_url":"https://api.github.com/repos/lsst-dm/ap_pipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/ap_pipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/ap_pipe/teams","hooks_url":"https://api.github.com/repos/lsst-dm/ap_pipe/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/ap_pipe/events","assignees_url":"https://api.github.com/repos/lsst-dm/ap_pipe/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/ap_pipe/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/ap_pipe/tags","blobs_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/ap_pipe/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/ap_pipe/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/ap_pipe/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/ap_pipe/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/ap_pipe/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/ap_pipe/subscription","commits_url":"https://api.github.com/repos/lsst-dm/ap_pipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/ap_pipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/ap_pipe/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/ap_pipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/ap_pipe/merges","archive_url":"https://api.github.com/repos/lsst-dm/ap_pipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/ap_pipe/downloads","issues_url":"https://api.github.com/repos/lsst-dm/ap_pipe/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/ap_pipe/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/ap_pipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/ap_pipe/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/ap_pipe/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/ap_pipe/deployments","created_at":"2016-12-30T20:58:57Z","updated_at":"2017-08-11T20:12:01Z","pushed_at":"2017-09-22T02:08:27Z","git_url":"git://github.com/lsst-dm/ap_pipe.git","ssh_url":"git@github.com:lsst-dm/ap_pipe.git","clone_url":"https://github.com/lsst-dm/ap_pipe.git","svn_url":"https://github.com/lsst-dm/ap_pipe","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6"},"html":{"href":"https://github.com/lsst-dm/ap_pipe/pull/6"},"issue":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/6"},"comments":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/lsst-dm/ap_pipe/statuses/a3db926292cbc39123f2332ca2e51d9be4e2b0d9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kfindeisen"}}