{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1930","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1930/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1930/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1930/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1930","id":233229789,"number":1930,"title":"Add dirty bit columns for English and French in the translation file","user":{"login":"barryytm","id":19259169,"avatar_url":"https://avatars0.githubusercontent.com/u/19259169?v=3","gravatar_id":"","url":"https://api.github.com/users/barryytm","html_url":"https://github.com/barryytm","followers_url":"https://api.github.com/users/barryytm/followers","following_url":"https://api.github.com/users/barryytm/following{/other_user}","gists_url":"https://api.github.com/users/barryytm/gists{/gist_id}","starred_url":"https://api.github.com/users/barryytm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryytm/subscriptions","organizations_url":"https://api.github.com/users/barryytm/orgs","repos_url":"https://api.github.com/users/barryytm/repos","events_url":"https://api.github.com/users/barryytm/events{/privacy}","received_events_url":"https://api.github.com/users/barryytm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars3.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars3.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},{"login":"james-rae","id":7585245,"avatar_url":"https://avatars0.githubusercontent.com/u/7585245?v=3","gravatar_id":"","url":"https://api.github.com/users/james-rae","html_url":"https://github.com/james-rae","followers_url":"https://api.github.com/users/james-rae/followers","following_url":"https://api.github.com/users/james-rae/following{/other_user}","gists_url":"https://api.github.com/users/james-rae/gists{/gist_id}","starred_url":"https://api.github.com/users/james-rae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-rae/subscriptions","organizations_url":"https://api.github.com/users/james-rae/orgs","repos_url":"https://api.github.com/users/james-rae/repos","events_url":"https://api.github.com/users/james-rae/events{/privacy}","received_events_url":"https://api.github.com/users/james-rae/received_events","type":"User","site_admin":false},{"login":"milesap","id":10187181,"avatar_url":"https://avatars2.githubusercontent.com/u/10187181?v=3","gravatar_id":"","url":"https://api.github.com/users/milesap","html_url":"https://github.com/milesap","followers_url":"https://api.github.com/users/milesap/followers","following_url":"https://api.github.com/users/milesap/following{/other_user}","gists_url":"https://api.github.com/users/milesap/gists{/gist_id}","starred_url":"https://api.github.com/users/milesap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesap/subscriptions","organizations_url":"https://api.github.com/users/milesap/orgs","repos_url":"https://api.github.com/users/milesap/repos","events_url":"https://api.github.com/users/milesap/events{/privacy}","received_events_url":"https://api.github.com/users/milesap/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2017-06-02T16:05:22Z","updated_at":"2017-06-05T14:12:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/1930","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1930","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1930.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1930.patch"},"body":"## Description\r\n<!-- Link to an issue or include a description -->\r\n#1921 \r\nAdd the dirty bit columns in the translation file and ignore it when converting to JSON\r\n## Testing\r\n<!-- Have you added unit tests for this code?  If not explain why. -->\r\nNo, because it was mostly editing data\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\ntranslations.csv\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] commits messages follow the guidelines\r\n- [x] code passes unit tests\r\n- [x] release notes have been updated\r\n- [x] PR targets the correct release version\r\n\r\nRemember, it is a *muffin offence* to open a PR with any of the above checklist items incomplete.\r\n\r\nPlease keep the original issue up to date with the final solution, expected behaviour, and any additional notes for testers\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/1930)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/306197590","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1930#issuecomment-306197590","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1930","id":306197590,"user":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars3.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"created_at":"2017-06-05T14:12:08Z","updated_at":"2017-06-05T14:12:08Z","body":"\n\n\n\nReview status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[scripts/translations_plugin.js, line 78 at r2](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1930#-KlsQZ2t6GzwN8IVA6JE:-KlsaFDGb3Xj8cgbzq2E:b-kbp52i) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/bc73511ac6252f36a2264cadc9f20a9fe935121f/scripts/translations_plugin.js#L78)):*\n<details><summary><i>Previously, AleksueiR (Aleksuei Riabtsev) wrote…</i></summary><blockquote>\n\nPlease, use `===` instead of `==`.\nCan you also add a comment block to this function?\n</blockquote></details>\n\n:+1:  Perfect, thanks!\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1930)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"AleksueiR"}}