{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/98550024","pull_request_review_id":19195487,"id":98550024,"diff_hunk":"@@ -250,13 +260,21 @@\n \t\t\t\t\tthis.set('_searchSemestersAction', myEnrollmentsEntity.getActionByName('add-semester-filter'));\n \t\t\t\t}\n \t\t\t},\n-\t\t\t_numFiltersChanged: function() {\n-\t\t\t\tthis.$.semesterListButton.textContent = this._numSemesterFilters > 0\n-\t\t\t\t\t? this.localize('filtering.semesterMultiple', 'num', this._numSemesterFilters)\n-\t\t\t\t\t: this.localize('filtering.semester');\n-\t\t\t\tthis.$.departmentListButton.textContent = this._numDepartmentFilters > 0\n-\t\t\t\t\t? this.localize('filtering.departmentMultiple', 'num', this._numDepartmentFilters)\n-\t\t\t\t\t: this.localize('filtering.department');\n+\t\t\t_updateDepartmentFilterLabel: function(numDepartmentFilters, departmentFilterName) {\n+\t\t\t\tvar selectArg = this.filterStandardDepartmentName === this.localize('filtering.departmentDefault') ? 'default' : departmentFilterName;","path":"d2l-filter-menu-content/d2l-filter-menu-content-tabbed.html","position":95,"original_position":95,"commit_id":"b729e7d9b3109e985917cbf4dc9b918867a75ff6","original_commit_id":"b729e7d9b3109e985917cbf4dc9b918867a75ff6","user":{"login":"trevorjonesd2l","id":8656538,"avatar_url":"https://avatars.githubusercontent.com/u/8656538?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorjonesd2l","html_url":"https://github.com/trevorjonesd2l","followers_url":"https://api.github.com/users/trevorjonesd2l/followers","following_url":"https://api.github.com/users/trevorjonesd2l/following{/other_user}","gists_url":"https://api.github.com/users/trevorjonesd2l/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorjonesd2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorjonesd2l/subscriptions","organizations_url":"https://api.github.com/users/trevorjonesd2l/orgs","repos_url":"https://api.github.com/users/trevorjonesd2l/repos","events_url":"https://api.github.com/users/trevorjonesd2l/events{/privacy}","received_events_url":"https://api.github.com/users/trevorjonesd2l/received_events","type":"User","site_admin":false},"body":"`selectArg` seems a little vague can we use something more specific here like `useDefaultName`","created_at":"2017-01-30T21:52:58Z","updated_at":"2017-01-30T21:52:58Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278#discussion_r98550024","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/98550024"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278#discussion_r98550024"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278","id":101962905,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/278","number":278,"state":"open","locked":false,"title":"US80271- Match filter names","user":{"login":"JoshuaKlassen","id":12076483,"avatar_url":"https://avatars.githubusercontent.com/u/12076483?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKlassen","html_url":"https://github.com/JoshuaKlassen","followers_url":"https://api.github.com/users/JoshuaKlassen/followers","following_url":"https://api.github.com/users/JoshuaKlassen/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKlassen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKlassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKlassen/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKlassen/orgs","repos_url":"https://api.github.com/users/JoshuaKlassen/repos","events_url":"https://api.github.com/users/JoshuaKlassen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKlassen/received_events","type":"User","site_admin":false},"body":"US80271: My Courses Semester and Department filters should match the lang terms the user has set.\r\n\r\nBasically, update the display names in the filter dropdown in the All Courses view to the Standard OU types for Semester and Department that the client has set.\r\n\r\nHave only tested Chrome so far, will test other browsers.\r\n\r\nTo test: https://git.dev.d2l/projects/CORE/repos/le/pull-requests/6530/overview","created_at":"2017-01-17T22:43:24Z","updated_at":"2017-01-30T21:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d92ec9ea4cb45f53b7d3c83f0aee012fd7d60cef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/278/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/b729e7d9b3109e985917cbf4dc9b918867a75ff6","head":{"label":"Brightspace:match-filter-names","ref":"match-filter-names","sha":"b729e7d9b3109e985917cbf4dc9b918867a75ff6","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2017-01-30T21:28:30Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":927,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"66277811ecb7498ce9c478abe080baa42bfbbd6b","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2017-01-30T21:28:30Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":927,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/278"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/278"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/b729e7d9b3109e985917cbf4dc9b918867a75ff6"}}}}
{"actor":{"display_login":"trevorjonesd2l"}}