{"action":"created","comment":{"url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/comments/111092243","pull_request_review_id":32310889,"id":111092243,"diff_hunk":"@@ -0,0 +1,204 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.Linq;\n+using System.Reflection;\n+using System.Text;\n+using ESRI.ArcGIS.ArcMapUI;\n+using ESRI.ArcGIS.Carto;\n+using MapAction;\n+using NUnit.Framework;\n+\n+namespace MapAction.tests\n+{\n+    /// <summary>\n+    /// The tests in this case are focused on the testing that code dealing with the MapAction specific MXDs work correctly\n+    /// \n+    /// At present the PageLayoutProperties class is entirely procedural and only uses static methods. The layout of these test is intened to be adaptable ","path":"arcgis10_mapping_tools/CommonTests/MATemplateTests.cs","position":null,"original_position":17,"commit_id":"d2eeef48bd99e69aceb6d92cc95572daf2d78319","original_commit_id":"efd927c385c6b76c29e751050ca43aabcf7d826e","user":{"login":"andrewphilipsmith","id":5346065,"avatar_url":"https://avatars3.githubusercontent.com/u/5346065?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewphilipsmith","html_url":"https://github.com/andrewphilipsmith","followers_url":"https://api.github.com/users/andrewphilipsmith/followers","following_url":"https://api.github.com/users/andrewphilipsmith/following{/other_user}","gists_url":"https://api.github.com/users/andrewphilipsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewphilipsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewphilipsmith/subscriptions","organizations_url":"https://api.github.com/users/andrewphilipsmith/orgs","repos_url":"https://api.github.com/users/andrewphilipsmith/repos","events_url":"https://api.github.com/users/andrewphilipsmith/events{/privacy}","received_events_url":"https://api.github.com/users/andrewphilipsmith/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2017-04-12T08:36:27Z","updated_at":"2017-04-12T08:36:27Z","html_url":"https://github.com/mapaction/mapaction-toolbox/pull/143#discussion_r111092243","pull_request_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/comments/111092243"},"html":{"href":"https://github.com/mapaction/mapaction-toolbox/pull/143#discussion_r111092243"},"pull_request":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143","id":95100958,"html_url":"https://github.com/mapaction/mapaction-toolbox/pull/143","diff_url":"https://github.com/mapaction/mapaction-toolbox/pull/143.diff","patch_url":"https://github.com/mapaction/mapaction-toolbox/pull/143.patch","issue_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/143","number":143,"state":"open","locked":false,"title":"Map Template tests","user":{"login":"andrewphilipsmith","id":5346065,"avatar_url":"https://avatars3.githubusercontent.com/u/5346065?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewphilipsmith","html_url":"https://github.com/andrewphilipsmith","followers_url":"https://api.github.com/users/andrewphilipsmith/followers","following_url":"https://api.github.com/users/andrewphilipsmith/following{/other_user}","gists_url":"https://api.github.com/users/andrewphilipsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewphilipsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewphilipsmith/subscriptions","organizations_url":"https://api.github.com/users/andrewphilipsmith/orgs","repos_url":"https://api.github.com/users/andrewphilipsmith/repos","events_url":"https://api.github.com/users/andrewphilipsmith/events{/privacy}","received_events_url":"https://api.github.com/users/andrewphilipsmith/received_events","type":"User","site_admin":false},"body":"I've had a bit of a look at https://github.com/mapaction/mapaction-toolbox/issues/142.\r\n\r\nI've creating a UnitTest which calls the `PageLayoutProperties.getLayoutTextElements` method. By running OverCoverage over it I could see that the line `while (element != null)` always indicates that the element value is null, meaning that a large chunk of the method is never called.\r\n\r\n* I've made an enum for the different map elements, so that we can move away from having so many hardcoded map element names spread arround the code. enums don't directly support strings, but where the strings don't include spaces they used as long as the user remembers to call `.ToString()` each time. eg:\r\n`MapElementNames.title` won't work, but `MapElementNames.title.ToString()` should work.\r\n* I've created a `MapActionMapTemplateException` class. The intention is that this is used to show when the MXD file doesn't fit the requirements for these tools.\r\n\r\n@kes1 This relates to some of the stuff you where working on. Do you have any suggestions? Could it be related to different .Net, VS or ArcGIS versions? Many thanks","created_at":"2016-11-24T00:40:55Z","updated_at":"2017-04-12T08:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75274a72cda9e972210450e82f309e6d8570b6b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143/commits","review_comments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143/comments","review_comment_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/143/comments","statuses_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/statuses/d2eeef48bd99e69aceb6d92cc95572daf2d78319","head":{"label":"mapaction:map-template-tests","ref":"map-template-tests","sha":"d2eeef48bd99e69aceb6d92cc95572daf2d78319","user":{"login":"mapaction","id":5138673,"avatar_url":"https://avatars2.githubusercontent.com/u/5138673?v=3","gravatar_id":"","url":"https://api.github.com/users/mapaction","html_url":"https://github.com/mapaction","followers_url":"https://api.github.com/users/mapaction/followers","following_url":"https://api.github.com/users/mapaction/following{/other_user}","gists_url":"https://api.github.com/users/mapaction/gists{/gist_id}","starred_url":"https://api.github.com/users/mapaction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapaction/subscriptions","organizations_url":"https://api.github.com/users/mapaction/orgs","repos_url":"https://api.github.com/users/mapaction/repos","events_url":"https://api.github.com/users/mapaction/events{/privacy}","received_events_url":"https://api.github.com/users/mapaction/received_events","type":"Organization","site_admin":false},"repo":{"id":25876340,"name":"mapaction-toolbox","full_name":"mapaction/mapaction-toolbox","owner":{"login":"mapaction","id":5138673,"avatar_url":"https://avatars2.githubusercontent.com/u/5138673?v=3","gravatar_id":"","url":"https://api.github.com/users/mapaction","html_url":"https://github.com/mapaction","followers_url":"https://api.github.com/users/mapaction/followers","following_url":"https://api.github.com/users/mapaction/following{/other_user}","gists_url":"https://api.github.com/users/mapaction/gists{/gist_id}","starred_url":"https://api.github.com/users/mapaction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapaction/subscriptions","organizations_url":"https://api.github.com/users/mapaction/orgs","repos_url":"https://api.github.com/users/mapaction/repos","events_url":"https://api.github.com/users/mapaction/events{/privacy}","received_events_url":"https://api.github.com/users/mapaction/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapaction/mapaction-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/mapaction/mapaction-toolbox","forks_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/forks","keys_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/teams","hooks_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/hooks","issue_events_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/events","assignees_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/tags","blobs_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/languages","stargazers_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/stargazers","contributors_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/contributors","subscribers_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/subscribers","subscription_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/subscription","commits_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/merges","archive_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/downloads","issues_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/deployments","created_at":"2014-10-28T15:32:41Z","updated_at":"2017-03-16T10:25:51Z","pushed_at":"2017-04-12T08:36:25Z","git_url":"git://github.com/mapaction/mapaction-toolbox.git","ssh_url":"git@github.com:mapaction/mapaction-toolbox.git","clone_url":"https://github.com/mapaction/mapaction-toolbox.git","svn_url":"https://github.com/mapaction/mapaction-toolbox","homepage":null,"size":46645,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":42,"forks":1,"open_issues":42,"watchers":2,"default_branch":"master"}},"base":{"label":"mapaction:master","ref":"master","sha":"9ea303f087b826859dd7c3ca67b4505aeb03a0a3","user":{"login":"mapaction","id":5138673,"avatar_url":"https://avatars2.githubusercontent.com/u/5138673?v=3","gravatar_id":"","url":"https://api.github.com/users/mapaction","html_url":"https://github.com/mapaction","followers_url":"https://api.github.com/users/mapaction/followers","following_url":"https://api.github.com/users/mapaction/following{/other_user}","gists_url":"https://api.github.com/users/mapaction/gists{/gist_id}","starred_url":"https://api.github.com/users/mapaction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapaction/subscriptions","organizations_url":"https://api.github.com/users/mapaction/orgs","repos_url":"https://api.github.com/users/mapaction/repos","events_url":"https://api.github.com/users/mapaction/events{/privacy}","received_events_url":"https://api.github.com/users/mapaction/received_events","type":"Organization","site_admin":false},"repo":{"id":25876340,"name":"mapaction-toolbox","full_name":"mapaction/mapaction-toolbox","owner":{"login":"mapaction","id":5138673,"avatar_url":"https://avatars2.githubusercontent.com/u/5138673?v=3","gravatar_id":"","url":"https://api.github.com/users/mapaction","html_url":"https://github.com/mapaction","followers_url":"https://api.github.com/users/mapaction/followers","following_url":"https://api.github.com/users/mapaction/following{/other_user}","gists_url":"https://api.github.com/users/mapaction/gists{/gist_id}","starred_url":"https://api.github.com/users/mapaction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapaction/subscriptions","organizations_url":"https://api.github.com/users/mapaction/orgs","repos_url":"https://api.github.com/users/mapaction/repos","events_url":"https://api.github.com/users/mapaction/events{/privacy}","received_events_url":"https://api.github.com/users/mapaction/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapaction/mapaction-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/mapaction/mapaction-toolbox","forks_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/forks","keys_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/teams","hooks_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/hooks","issue_events_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/events","assignees_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/tags","blobs_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/languages","stargazers_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/stargazers","contributors_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/contributors","subscribers_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/subscribers","subscription_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/subscription","commits_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/merges","archive_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/downloads","issues_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/mapaction/mapaction-toolbox/deployments","created_at":"2014-10-28T15:32:41Z","updated_at":"2017-03-16T10:25:51Z","pushed_at":"2017-04-12T08:36:25Z","git_url":"git://github.com/mapaction/mapaction-toolbox.git","ssh_url":"git@github.com:mapaction/mapaction-toolbox.git","clone_url":"https://github.com/mapaction/mapaction-toolbox.git","svn_url":"https://github.com/mapaction/mapaction-toolbox","homepage":null,"size":46645,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":42,"forks":1,"open_issues":42,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143"},"html":{"href":"https://github.com/mapaction/mapaction-toolbox/pull/143"},"issue":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/143"},"comments":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/mapaction/mapaction-toolbox/statuses/d2eeef48bd99e69aceb6d92cc95572daf2d78319"}}}}
{"actor":{"display_login":"andrewphilipsmith"}}