{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity/pulls/comments/132240896","pull_request_review_id":55300763,"id":132240896,"diff_hunk":"@@ -419,7 +423,7 @@ impl<'x> OpenBlock<'x> {\n \t\tlet mut s = self;\n \n \t\tif let Err(e) = s.engine.on_close_block(&mut s.block) {\n-\t\t\twarn!(\"Encountered error on closing the block: {}\", e);\n+ \t\t\twarn!(\"Encountered error on closing the block: {}\", e);","path":"ethcore/src/block.rs","position":62,"original_position":62,"commit_id":"dd91121017e1155f13a55d06f2456db6ccd629f5","original_commit_id":"dd91121017e1155f13a55d06f2456db6ccd629f5","user":{"login":"gavofyork","id":138296,"avatar_url":"https://avatars0.githubusercontent.com/u/138296?v=4","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"body":"dodgy space added (beginning of line)","created_at":"2017-08-09T16:48:17Z","updated_at":"2017-08-09T16:48:18Z","html_url":"https://github.com/paritytech/parity/pull/6194#discussion_r132240896","pull_request_url":"https://api.github.com/repos/paritytech/parity/pulls/6194","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments/132240896"},"html":{"href":"https://github.com/paritytech/parity/pull/6194#discussion_r132240896"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6194"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity/pulls/6194","id":133214453,"html_url":"https://github.com/paritytech/parity/pull/6194","diff_url":"https://github.com/paritytech/parity/pull/6194.diff","patch_url":"https://github.com/paritytech/parity/pull/6194.patch","issue_url":"https://api.github.com/repos/paritytech/parity/issues/6194","number":6194,"state":"open","locked":false,"title":"Rewards on closing blocks","user":{"login":"grbIzl","id":5435439,"avatar_url":"https://avatars2.githubusercontent.com/u/5435439?v=4","gravatar_id":"","url":"https://api.github.com/users/grbIzl","html_url":"https://github.com/grbIzl","followers_url":"https://api.github.com/users/grbIzl/followers","following_url":"https://api.github.com/users/grbIzl/following{/other_user}","gists_url":"https://api.github.com/users/grbIzl/gists{/gist_id}","starred_url":"https://api.github.com/users/grbIzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grbIzl/subscriptions","organizations_url":"https://api.github.com/users/grbIzl/orgs","repos_url":"https://api.github.com/users/grbIzl/repos","events_url":"https://api.github.com/users/grbIzl/events{/privacy}","received_events_url":"https://api.github.com/users/grbIzl/received_events","type":"User","site_admin":false},"body":"Added tracing of rewards on closing blocks. The following major changes made:\r\n\r\n- Add new action Reward with reward type (Block or Uncle)\r\n- Extended engine's API in order to return traces on closing block.\r\n- New parameter for engine's spec params added (apply_reward). By default it's true\r\n- New engine spec null_morden_with_reward created (in order to distinguish with default null_morden without reward)\r\n- Db code of trace filtering was modified in order to reflect, that traces can be block-related not only transaction-related\r\n- Localisation trace (passed outside by rpc) modified. Transaction id and hash in trace made optional. So it can be null now. This should be expressed in release notes somehow.\r\n- Integration and unit tests added\r\n\r\nThe work was done in terms of https://github.com/paritytech/parity/issues/4858\r\n","created_at":"2017-07-31T10:39:56Z","updated_at":"2017-08-09T16:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd906ddaa2fb58ba7f893fbfd9a59935c3c85c9f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity/pulls/6194/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity/pulls/6194/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity/issues/6194/comments","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/dd91121017e1155f13a55d06f2456db6ccd629f5","head":{"label":"paritytech:Fix-4858","ref":"Fix-4858","sha":"dd91121017e1155f13a55d06f2456db6ccd629f5","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-08-09T13:41:41Z","pushed_at":"2017-08-09T15:37:16Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":101423,"stargazers_count":1770,"watchers_count":1770,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":360,"mirror_url":null,"open_issues_count":386,"forks":360,"open_issues":386,"watchers":1770,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"0c7c34e6091c2d716eddbc722c0847541f663d01","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-08-09T13:41:41Z","pushed_at":"2017-08-09T15:37:16Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":101423,"stargazers_count":1770,"watchers_count":1770,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":360,"mirror_url":null,"open_issues_count":386,"forks":360,"open_issues":386,"watchers":1770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6194"},"html":{"href":"https://github.com/paritytech/parity/pull/6194"},"issue":{"href":"https://api.github.com/repos/paritytech/parity/issues/6194"},"comments":{"href":"https://api.github.com/repos/paritytech/parity/issues/6194/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6194/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6194/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity/statuses/dd91121017e1155f13a55d06f2456db6ccd629f5"}}}}
{"actor":{"display_login":"gavofyork"}}