{"action":"created","comment":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments/110336378","pull_request_review_id":31502254,"id":110336378,"diff_hunk":"@@ -2,6 +2,9 @@\n /* Copyright (c) 2016 Richard Klees <richard.klees@concepts-and-training.de> Extended GPL, see docs/LICENSE */\n \n namespace ILIAS\\DI;\n+use ILIAS\\HTTP\\Cookies\\CookieJarFactoryImpl;\n+use ILIAS\\HTTP\\GlobalHttpState;\n+use ILIAS\\HTTP\\Response\\Sender\\DefaultResponseSenderStrategy;","path":"src/DI/Container.php","position":6,"original_position":6,"commit_id":"3d5489807b9509602cf6c29dc305ddad15bb975b","original_commit_id":"3d5489807b9509602cf6c29dc305ddad15bb975b","user":{"login":"klees","id":10611082,"avatar_url":"https://avatars3.githubusercontent.com/u/10611082?v=3","gravatar_id":"","url":"https://api.github.com/users/klees","html_url":"https://github.com/klees","followers_url":"https://api.github.com/users/klees/followers","following_url":"https://api.github.com/users/klees/following{/other_user}","gists_url":"https://api.github.com/users/klees/gists{/gist_id}","starred_url":"https://api.github.com/users/klees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klees/subscriptions","organizations_url":"https://api.github.com/users/klees/orgs","repos_url":"https://api.github.com/users/klees/repos","events_url":"https://api.github.com/users/klees/events{/privacy}","received_events_url":"https://api.github.com/users/klees/received_events","type":"User","site_admin":false},"body":"Remove these please.","created_at":"2017-04-07T08:02:29Z","updated_at":"2017-04-07T08:05:34Z","html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/466#discussion_r110336378","pull_request_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments/110336378"},"html":{"href":"https://github.com/ILIAS-eLearning/ILIAS/pull/466#discussion_r110336378"},"pull_request":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466","id":112269868,"html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/466","diff_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/466.diff","patch_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/466.patch","issue_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/466","number":466,"state":"open","locked":false,"title":"Feature/5 3/introduction of http service","user":{"login":"d3r1w","id":544458,"avatar_url":"https://avatars3.githubusercontent.com/u/544458?v=3","gravatar_id":"","url":"https://api.github.com/users/d3r1w","html_url":"https://github.com/d3r1w","followers_url":"https://api.github.com/users/d3r1w/followers","following_url":"https://api.github.com/users/d3r1w/following{/other_user}","gists_url":"https://api.github.com/users/d3r1w/gists{/gist_id}","starred_url":"https://api.github.com/users/d3r1w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3r1w/subscriptions","organizations_url":"https://api.github.com/users/d3r1w/orgs","repos_url":"https://api.github.com/users/d3r1w/repos","events_url":"https://api.github.com/users/d3r1w/events{/privacy}","received_events_url":"https://api.github.com/users/d3r1w/received_events","type":"User","site_admin":false},"body":"# HTTP Service\r\n\r\nThe http service aims to simplify and secure the handling with the http request and response. Furthermore it enables developers to test the cookie handling, which was previously close to impossible.\r\n\r\n## Features\r\n* PSR-7 compliant request and response handling.\r\n* Cookie handling\r\n\r\n## Required Libraries\r\n### guzzlehttp/psr7\r\nThe currently used PSR-7 implementation used by the http service.\r\n\r\n### ralouphie/getallheaders\r\nA polly fill for the getallheader function which is used by the guzzlehttp/psr7. This pollyfill is needed if no Apache is present in the system setup.\r\n\r\n### psr/http-message\r\nThe PSR-7 interfaces designed by the PHP-FIG.\r\n\r\n### dflydev/fig-cookies\r\nThe current implementation to handle the cookies. This library was designed to work with the http server request interface of the PSR-7.\r\n\r\n### mockery/mockery\r\nMockery provides a convenient api to create mock objects for the unit tests.\r\n\r\n\r\n","created_at":"2017-03-23T15:43:28Z","updated_at":"2017-04-07T08:05:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a0f7c0e7a2e8786fd0abc41858802922560ce9a","assignee":{"login":"chfsx","id":6661332,"avatar_url":"https://avatars3.githubusercontent.com/u/6661332?v=3","gravatar_id":"","url":"https://api.github.com/users/chfsx","html_url":"https://github.com/chfsx","followers_url":"https://api.github.com/users/chfsx/followers","following_url":"https://api.github.com/users/chfsx/following{/other_user}","gists_url":"https://api.github.com/users/chfsx/gists{/gist_id}","starred_url":"https://api.github.com/users/chfsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfsx/subscriptions","organizations_url":"https://api.github.com/users/chfsx/orgs","repos_url":"https://api.github.com/users/chfsx/repos","events_url":"https://api.github.com/users/chfsx/events{/privacy}","received_events_url":"https://api.github.com/users/chfsx/received_events","type":"User","site_admin":false},"assignees":[{"login":"chfsx","id":6661332,"avatar_url":"https://avatars3.githubusercontent.com/u/6661332?v=3","gravatar_id":"","url":"https://api.github.com/users/chfsx","html_url":"https://github.com/chfsx","followers_url":"https://api.github.com/users/chfsx/followers","following_url":"https://api.github.com/users/chfsx/following{/other_user}","gists_url":"https://api.github.com/users/chfsx/gists{/gist_id}","starred_url":"https://api.github.com/users/chfsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfsx/subscriptions","organizations_url":"https://api.github.com/users/chfsx/orgs","repos_url":"https://api.github.com/users/chfsx/repos","events_url":"https://api.github.com/users/chfsx/events{/privacy}","received_events_url":"https://api.github.com/users/chfsx/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466/commits","review_comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466/comments","review_comment_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/466/comments","statuses_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/3d5489807b9509602cf6c29dc305ddad15bb975b","head":{"label":"studer-raimann:feature/5-3/IntroductionOfHTTPService","ref":"feature/5-3/IntroductionOfHTTPService","sha":"3d5489807b9509602cf6c29dc305ddad15bb975b","user":{"login":"studer-raimann","id":7720996,"avatar_url":"https://avatars3.githubusercontent.com/u/7720996?v=3","gravatar_id":"","url":"https://api.github.com/users/studer-raimann","html_url":"https://github.com/studer-raimann","followers_url":"https://api.github.com/users/studer-raimann/followers","following_url":"https://api.github.com/users/studer-raimann/following{/other_user}","gists_url":"https://api.github.com/users/studer-raimann/gists{/gist_id}","starred_url":"https://api.github.com/users/studer-raimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studer-raimann/subscriptions","organizations_url":"https://api.github.com/users/studer-raimann/orgs","repos_url":"https://api.github.com/users/studer-raimann/repos","events_url":"https://api.github.com/users/studer-raimann/events{/privacy}","received_events_url":"https://api.github.com/users/studer-raimann/received_events","type":"Organization","site_admin":false},"repo":{"id":32461965,"name":"ILIAS","full_name":"studer-raimann/ILIAS","owner":{"login":"studer-raimann","id":7720996,"avatar_url":"https://avatars3.githubusercontent.com/u/7720996?v=3","gravatar_id":"","url":"https://api.github.com/users/studer-raimann","html_url":"https://github.com/studer-raimann","followers_url":"https://api.github.com/users/studer-raimann/followers","following_url":"https://api.github.com/users/studer-raimann/following{/other_user}","gists_url":"https://api.github.com/users/studer-raimann/gists{/gist_id}","starred_url":"https://api.github.com/users/studer-raimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studer-raimann/subscriptions","organizations_url":"https://api.github.com/users/studer-raimann/orgs","repos_url":"https://api.github.com/users/studer-raimann/repos","events_url":"https://api.github.com/users/studer-raimann/events{/privacy}","received_events_url":"https://api.github.com/users/studer-raimann/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/studer-raimann/ILIAS","description":null,"fork":true,"url":"https://api.github.com/repos/studer-raimann/ILIAS","forks_url":"https://api.github.com/repos/studer-raimann/ILIAS/forks","keys_url":"https://api.github.com/repos/studer-raimann/ILIAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studer-raimann/ILIAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studer-raimann/ILIAS/teams","hooks_url":"https://api.github.com/repos/studer-raimann/ILIAS/hooks","issue_events_url":"https://api.github.com/repos/studer-raimann/ILIAS/issues/events{/number}","events_url":"https://api.github.com/repos/studer-raimann/ILIAS/events","assignees_url":"https://api.github.com/repos/studer-raimann/ILIAS/assignees{/user}","branches_url":"https://api.github.com/repos/studer-raimann/ILIAS/branches{/branch}","tags_url":"https://api.github.com/repos/studer-raimann/ILIAS/tags","blobs_url":"https://api.github.com/repos/studer-raimann/ILIAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studer-raimann/ILIAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studer-raimann/ILIAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/studer-raimann/ILIAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studer-raimann/ILIAS/statuses/{sha}","languages_url":"https://api.github.com/repos/studer-raimann/ILIAS/languages","stargazers_url":"https://api.github.com/repos/studer-raimann/ILIAS/stargazers","contributors_url":"https://api.github.com/repos/studer-raimann/ILIAS/contributors","subscribers_url":"https://api.github.com/repos/studer-raimann/ILIAS/subscribers","subscription_url":"https://api.github.com/repos/studer-raimann/ILIAS/subscription","commits_url":"https://api.github.com/repos/studer-raimann/ILIAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/studer-raimann/ILIAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/studer-raimann/ILIAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/studer-raimann/ILIAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/studer-raimann/ILIAS/contents/{+path}","compare_url":"https://api.github.com/repos/studer-raimann/ILIAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studer-raimann/ILIAS/merges","archive_url":"https://api.github.com/repos/studer-raimann/ILIAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studer-raimann/ILIAS/downloads","issues_url":"https://api.github.com/repos/studer-raimann/ILIAS/issues{/number}","pulls_url":"https://api.github.com/repos/studer-raimann/ILIAS/pulls{/number}","milestones_url":"https://api.github.com/repos/studer-raimann/ILIAS/milestones{/number}","notifications_url":"https://api.github.com/repos/studer-raimann/ILIAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studer-raimann/ILIAS/labels{/name}","releases_url":"https://api.github.com/repos/studer-raimann/ILIAS/releases{/id}","deployments_url":"https://api.github.com/repos/studer-raimann/ILIAS/deployments","created_at":"2015-03-18T13:57:46Z","updated_at":"2016-12-23T11:42:01Z","pushed_at":"2017-04-07T07:58:19Z","git_url":"git://github.com/studer-raimann/ILIAS.git","ssh_url":"git@github.com:studer-raimann/ILIAS.git","clone_url":"https://github.com/studer-raimann/ILIAS.git","svn_url":"https://github.com/studer-raimann/ILIAS","homepage":"","size":637224,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"ILIAS-eLearning:trunk","ref":"trunk","sha":"44c058750b41dd12a0c6f5c06d14c872cf83d08e","user":{"login":"ILIAS-eLearning","id":8789134,"avatar_url":"https://avatars1.githubusercontent.com/u/8789134?v=3","gravatar_id":"","url":"https://api.github.com/users/ILIAS-eLearning","html_url":"https://github.com/ILIAS-eLearning","followers_url":"https://api.github.com/users/ILIAS-eLearning/followers","following_url":"https://api.github.com/users/ILIAS-eLearning/following{/other_user}","gists_url":"https://api.github.com/users/ILIAS-eLearning/gists{/gist_id}","starred_url":"https://api.github.com/users/ILIAS-eLearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ILIAS-eLearning/subscriptions","organizations_url":"https://api.github.com/users/ILIAS-eLearning/orgs","repos_url":"https://api.github.com/users/ILIAS-eLearning/repos","events_url":"https://api.github.com/users/ILIAS-eLearning/events{/privacy}","received_events_url":"https://api.github.com/users/ILIAS-eLearning/received_events","type":"Organization","site_admin":false},"repo":{"id":30634542,"name":"ILIAS","full_name":"ILIAS-eLearning/ILIAS","owner":{"login":"ILIAS-eLearning","id":8789134,"avatar_url":"https://avatars1.githubusercontent.com/u/8789134?v=3","gravatar_id":"","url":"https://api.github.com/users/ILIAS-eLearning","html_url":"https://github.com/ILIAS-eLearning","followers_url":"https://api.github.com/users/ILIAS-eLearning/followers","following_url":"https://api.github.com/users/ILIAS-eLearning/following{/other_user}","gists_url":"https://api.github.com/users/ILIAS-eLearning/gists{/gist_id}","starred_url":"https://api.github.com/users/ILIAS-eLearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ILIAS-eLearning/subscriptions","organizations_url":"https://api.github.com/users/ILIAS-eLearning/orgs","repos_url":"https://api.github.com/users/ILIAS-eLearning/repos","events_url":"https://api.github.com/users/ILIAS-eLearning/events{/privacy}","received_events_url":"https://api.github.com/users/ILIAS-eLearning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ILIAS-eLearning/ILIAS","description":"GitHub repository for official ILIAS release branches and development branches (trunk)","fork":false,"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS","forks_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/forks","keys_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/teams","hooks_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/hooks","issue_events_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/events{/number}","events_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/events","assignees_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/assignees{/user}","branches_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/branches{/branch}","tags_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/tags","blobs_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/{sha}","languages_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/languages","stargazers_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/stargazers","contributors_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/contributors","subscribers_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/subscribers","subscription_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/subscription","commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/contents/{+path}","compare_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/merges","archive_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/downloads","issues_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues{/number}","pulls_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls{/number}","milestones_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/milestones{/number}","notifications_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/labels{/name}","releases_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/releases{/id}","deployments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/deployments","created_at":"2015-02-11T06:44:39Z","updated_at":"2017-04-02T11:06:54Z","pushed_at":"2017-04-07T07:57:35Z","git_url":"git://github.com/ILIAS-eLearning/ILIAS.git","ssh_url":"git@github.com:ILIAS-eLearning/ILIAS.git","clone_url":"https://github.com/ILIAS-eLearning/ILIAS.git","svn_url":"https://github.com/ILIAS-eLearning/ILIAS","homepage":"http://www.ilias.de/docu/goto_docu_cat_582.html","size":636612,"stargazers_count":72,"watchers_count":72,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":37,"forks":91,"open_issues":37,"watchers":72,"default_branch":"release_5-2"}},"_links":{"self":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466"},"html":{"href":"https://github.com/ILIAS-eLearning/ILIAS/pull/466"},"issue":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/466"},"comments":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/3d5489807b9509602cf6c29dc305ddad15bb975b"}}}}
{"actor":{"display_login":"klees"}}