{"action":"created","comment":{"url":"https://api.github.com/repos/opentx/opentx/pulls/comments/136795961","pull_request_review_id":60383685,"id":136795961,"diff_hunk":"@@ -921,6 +921,23 @@ void menuModelSetup(event_t event)\n             }\n           }\n         }\n+        else if (IS_MODULE_CROSSFIRE(moduleIdx)) {\n+          lcdDrawTextAlignedLeft(y, INDENT \"Baudrate\");\n+          lcdDrawNumber(MODEL_SETUP_2ND_COLUMN, y, CROSSFIRE_BAUDRATES[g_eeGeneral.mavbaud], attr|LEFT);\n+          if (attr) {\n+            g_eeGeneral.mavbaud = DIM(CROSSFIRE_BAUDRATES) - 1 - checkIncDecModel(event, DIM(CROSSFIRE_BAUDRATES) - 1 - g_eeGeneral.mavbaud, 0, DIM(CROSSFIRE_BAUDRATES) - 1);","path":"radio/src/gui/128x64/model_setup.cpp","position":17,"original_position":17,"commit_id":"1d5fc5bcc7132169d9f655e8ea5d44e1753bf500","original_commit_id":"1d5fc5bcc7132169d9f655e8ea5d44e1753bf500","user":{"login":"schwabe","id":1038539,"avatar_url":"https://avatars3.githubusercontent.com/u/1038539?v=4","gravatar_id":"","url":"https://api.github.com/users/schwabe","html_url":"https://github.com/schwabe","followers_url":"https://api.github.com/users/schwabe/followers","following_url":"https://api.github.com/users/schwabe/following{/other_user}","gists_url":"https://api.github.com/users/schwabe/gists{/gist_id}","starred_url":"https://api.github.com/users/schwabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwabe/subscriptions","organizations_url":"https://api.github.com/users/schwabe/orgs","repos_url":"https://api.github.com/users/schwabe/repos","events_url":"https://api.github.com/users/schwabe/events{/privacy}","received_events_url":"https://api.github.com/users/schwabe/received_events","type":"User","site_admin":false},"body":"I don't think you should reuse mavbaudrate here. Module specific data should be in ModuleData. PXX and multi are already saving their extra settings there and I think crossfire should do the same.","created_at":"2017-09-04T10:53:49Z","updated_at":"2017-09-04T10:53:49Z","html_url":"https://github.com/opentx/opentx/pull/5194#discussion_r136795961","pull_request_url":"https://api.github.com/repos/opentx/opentx/pulls/5194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments/136795961"},"html":{"href":"https://github.com/opentx/opentx/pull/5194#discussion_r136795961"},"pull_request":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5194"}}},"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/5194","id":139087571,"html_url":"https://github.com/opentx/opentx/pull/5194","diff_url":"https://github.com/opentx/opentx/pull/5194.diff","patch_url":"https://github.com/opentx/opentx/pull/5194.patch","issue_url":"https://api.github.com/repos/opentx/opentx/issues/5194","number":5194,"state":"open","locked":false,"title":"Crossfire baudrate selection for X7 support ( fixes #4922 )","user":{"login":"sirPerna","id":7645907,"avatar_url":"https://avatars0.githubusercontent.com/u/7645907?v=4","gravatar_id":"","url":"https://api.github.com/users/sirPerna","html_url":"https://github.com/sirPerna","followers_url":"https://api.github.com/users/sirPerna/followers","following_url":"https://api.github.com/users/sirPerna/following{/other_user}","gists_url":"https://api.github.com/users/sirPerna/gists{/gist_id}","starred_url":"https://api.github.com/users/sirPerna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirPerna/subscriptions","organizations_url":"https://api.github.com/users/sirPerna/orgs","repos_url":"https://api.github.com/users/sirPerna/repos","events_url":"https://api.github.com/users/sirPerna/events{/privacy}","received_events_url":"https://api.github.com/users/sirPerna/received_events","type":"User","site_admin":false},"body":"Requires TBS Crossfire V2.07 or higher.","created_at":"2017-09-04T06:04:31Z","updated_at":"2017-09-04T10:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c320c80d65e8aa5f869a34a62133b84e9dcad1a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentx/opentx/pulls/5194/commits","review_comments_url":"https://api.github.com/repos/opentx/opentx/pulls/5194/comments","review_comment_url":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/5194/comments","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/1d5fc5bcc7132169d9f655e8ea5d44e1753bf500","head":{"label":"sirPerna:2.2","ref":"2.2","sha":"1d5fc5bcc7132169d9f655e8ea5d44e1753bf500","user":{"login":"sirPerna","id":7645907,"avatar_url":"https://avatars0.githubusercontent.com/u/7645907?v=4","gravatar_id":"","url":"https://api.github.com/users/sirPerna","html_url":"https://github.com/sirPerna","followers_url":"https://api.github.com/users/sirPerna/followers","following_url":"https://api.github.com/users/sirPerna/following{/other_user}","gists_url":"https://api.github.com/users/sirPerna/gists{/gist_id}","starred_url":"https://api.github.com/users/sirPerna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirPerna/subscriptions","organizations_url":"https://api.github.com/users/sirPerna/orgs","repos_url":"https://api.github.com/users/sirPerna/repos","events_url":"https://api.github.com/users/sirPerna/events{/privacy}","received_events_url":"https://api.github.com/users/sirPerna/received_events","type":"User","site_admin":false},"repo":{"id":102190642,"name":"opentx","full_name":"sirPerna/opentx","owner":{"login":"sirPerna","id":7645907,"avatar_url":"https://avatars0.githubusercontent.com/u/7645907?v=4","gravatar_id":"","url":"https://api.github.com/users/sirPerna","html_url":"https://github.com/sirPerna","followers_url":"https://api.github.com/users/sirPerna/followers","following_url":"https://api.github.com/users/sirPerna/following{/other_user}","gists_url":"https://api.github.com/users/sirPerna/gists{/gist_id}","starred_url":"https://api.github.com/users/sirPerna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirPerna/subscriptions","organizations_url":"https://api.github.com/users/sirPerna/orgs","repos_url":"https://api.github.com/users/sirPerna/repos","events_url":"https://api.github.com/users/sirPerna/events{/privacy}","received_events_url":"https://api.github.com/users/sirPerna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirPerna/opentx","description":"OpenTX custom firmware for Transmitters","fork":true,"url":"https://api.github.com/repos/sirPerna/opentx","forks_url":"https://api.github.com/repos/sirPerna/opentx/forks","keys_url":"https://api.github.com/repos/sirPerna/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirPerna/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirPerna/opentx/teams","hooks_url":"https://api.github.com/repos/sirPerna/opentx/hooks","issue_events_url":"https://api.github.com/repos/sirPerna/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/sirPerna/opentx/events","assignees_url":"https://api.github.com/repos/sirPerna/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/sirPerna/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/sirPerna/opentx/tags","blobs_url":"https://api.github.com/repos/sirPerna/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirPerna/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirPerna/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirPerna/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirPerna/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/sirPerna/opentx/languages","stargazers_url":"https://api.github.com/repos/sirPerna/opentx/stargazers","contributors_url":"https://api.github.com/repos/sirPerna/opentx/contributors","subscribers_url":"https://api.github.com/repos/sirPerna/opentx/subscribers","subscription_url":"https://api.github.com/repos/sirPerna/opentx/subscription","commits_url":"https://api.github.com/repos/sirPerna/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirPerna/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirPerna/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirPerna/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirPerna/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/sirPerna/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirPerna/opentx/merges","archive_url":"https://api.github.com/repos/sirPerna/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirPerna/opentx/downloads","issues_url":"https://api.github.com/repos/sirPerna/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/sirPerna/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/sirPerna/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/sirPerna/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirPerna/opentx/labels{/name}","releases_url":"https://api.github.com/repos/sirPerna/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/sirPerna/opentx/deployments","created_at":"2017-09-02T11:00:25Z","updated_at":"2017-09-02T11:00:32Z","pushed_at":"2017-09-02T11:13:42Z","git_url":"git://github.com/sirPerna/opentx.git","ssh_url":"git@github.com:sirPerna/opentx.git","clone_url":"https://github.com/sirPerna/opentx.git","svn_url":"https://github.com/sirPerna/opentx","homepage":"","size":148808,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.2"}},"base":{"label":"opentx:2.2","ref":"2.2","sha":"5b5c88fb4ec96ffa2dbb66fd8ae76febb895ab0a","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2017-09-04T02:55:46Z","pushed_at":"2017-09-04T10:33:35Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":149061,"stargazers_count":597,"watchers_count":597,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":325,"mirror_url":null,"open_issues_count":515,"forks":325,"open_issues":515,"watchers":597,"default_branch":"2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5194"},"html":{"href":"https://github.com/opentx/opentx/pull/5194"},"issue":{"href":"https://api.github.com/repos/opentx/opentx/issues/5194"},"comments":{"href":"https://api.github.com/repos/opentx/opentx/issues/5194/comments"},"review_comments":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5194/comments"},"review_comment":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5194/commits"},"statuses":{"href":"https://api.github.com/repos/opentx/opentx/statuses/1d5fc5bcc7132169d9f655e8ea5d44e1753bf500"}},"author_association":"NONE"}}
{"actor":{"display_login":"schwabe"}}