{"action":"created","issue":{"url":"https://api.github.com/repos/adminspotter/r9/issues/165","repository_url":"https://api.github.com/repos/adminspotter/r9","labels_url":"https://api.github.com/repos/adminspotter/r9/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/adminspotter/r9/issues/165/comments","events_url":"https://api.github.com/repos/adminspotter/r9/issues/165/events","html_url":"https://github.com/adminspotter/r9/pull/165","id":247369215,"number":165,"title":"Socket user dataflow","user":{"login":"adminspotter","id":7100928,"avatar_url":"https://avatars3.githubusercontent.com/u/7100928?v=4","gravatar_id":"","url":"https://api.github.com/users/adminspotter","html_url":"https://github.com/adminspotter","followers_url":"https://api.github.com/users/adminspotter/followers","following_url":"https://api.github.com/users/adminspotter/following{/other_user}","gists_url":"https://api.github.com/users/adminspotter/gists{/gist_id}","starred_url":"https://api.github.com/users/adminspotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adminspotter/subscriptions","organizations_url":"https://api.github.com/users/adminspotter/orgs","repos_url":"https://api.github.com/users/adminspotter/repos","events_url":"https://api.github.com/users/adminspotter/events{/privacy}","received_events_url":"https://api.github.com/users/adminspotter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-02T12:18:29Z","updated_at":"2017-08-02T12:18:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adminspotter/r9/pulls/165","html_url":"https://github.com/adminspotter/r9/pull/165","diff_url":"https://github.com/adminspotter/r9/pull/165.diff","patch_url":"https://github.com/adminspotter/r9/pull/165.patch"},"body":"The base_user/listen_socket interaction and the data flow through the listening loop was confusing.  It's less so now, but can still stand improvement in the future."},"comment":{"url":"https://api.github.com/repos/adminspotter/r9/issues/comments/319655340","html_url":"https://github.com/adminspotter/r9/pull/165#issuecomment-319655340","issue_url":"https://api.github.com/repos/adminspotter/r9/issues/165","id":319655340,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-08-02T12:18:31Z","updated_at":"2017-08-02T12:18:31Z","body":"# [Codecov](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=h1) Report\n> Merging [#165](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=desc) into [improve-test-coverage](https://codecov.io/gh/adminspotter/r9/commit/db013ee502dcb0460422f7b203cc6b884e876e49?src=pr&el=desc) will **decrease** coverage by `0.19%`.\n> The diff coverage is `47.94%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/adminspotter/r9/pull/165/graphs/tree.svg?height=150&width=650&token=nPImn2bP6I&src=pr)](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree)\n\n```diff\n@@                   Coverage Diff                    @@\n##           improve-test-coverage     #165     +/-   ##\n========================================================\n- Coverage                  81.75%   81.55%   -0.2%     \n========================================================\n  Files                         37       37             \n  Lines                       2444     2440      -4     \n========================================================\n- Hits                        1998     1990      -8     \n- Misses                       446      450      +4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [server/classes/stream.h](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvc3RyZWFtLmg=) | `0% <ø> (ø)` | :arrow_up: |\n| [server/classes/dgram.h](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvZGdyYW0uaA==) | `100% <ø> (ø)` | :arrow_up: |\n| [server/classes/defs.h](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvZGVmcy5o) | `100% <ø> (ø)` | :arrow_up: |\n| [server/classes/stream.cc](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvc3RyZWFtLmNj) | `0.49% <0%> (ø)` | :arrow_up: |\n| [server/classes/listensock.cc](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvbGlzdGVuc29jay5jYw==) | `99.4% <100%> (-0.03%)` | :arrow_down: |\n| [server/classes/update\\_pool.cc](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvdXBkYXRlX3Bvb2wuY2M=) | `100% <100%> (ø)` | :arrow_up: |\n| [server/classes/dgram.cc](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvZGdyYW0uY2M=) | `28.03% <12.82%> (-0.4%)` | :arrow_down: |\n| [server/classes/action\\_pool.cc](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=tree#diff-c2VydmVyL2NsYXNzZXMvYWN0aW9uX3Bvb2wuY2M=) | `90.19% <85.71%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=footer). Last update [db013ee...276be66](https://codecov.io/gh/adminspotter/r9/pull/165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}