{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments/107902257","pull_request_review_id":28902762,"id":107902257,"diff_hunk":"@@ -31,7 +31,7 @@ class MinimumViableTokenSpec extends FreeSpec with Matchers {\n       val (_, contract) = deployContract(\"MinimumViableToken\", creatorAddress = sender, constructorArgs = Seq(100))\n \n       val transferRes = contract.transfer(receiver, 200).call(sender = sender)\n-      transferRes.error shouldBe Some(InvalidOpCode) // TODO: change to invalid jump destination\n+      transferRes.error shouldBe Some(InvalidOpCode(0xfd.toByte))","path":"src/evmTest/scala/io/iohk/ethereum/vm/MinimumViableTokenSpec.scala","position":null,"original_position":5,"commit_id":"b28dcba8c43407bbd4bce666b7ab1c44931e671a","original_commit_id":"b28dcba8c43407bbd4bce666b7ab1c44931e671a","user":{"login":"LukasGasior1","id":5664242,"avatar_url":"https://avatars2.githubusercontent.com/u/5664242?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasGasior1","html_url":"https://github.com/LukasGasior1","followers_url":"https://api.github.com/users/LukasGasior1/followers","following_url":"https://api.github.com/users/LukasGasior1/following{/other_user}","gists_url":"https://api.github.com/users/LukasGasior1/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasGasior1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasGasior1/subscriptions","organizations_url":"https://api.github.com/users/LukasGasior1/orgs","repos_url":"https://api.github.com/users/LukasGasior1/repos","events_url":"https://api.github.com/users/LukasGasior1/events{/privacy}","received_events_url":"https://api.github.com/users/LukasGasior1/received_events","type":"User","site_admin":false},"body":"well that's what solidity generates, and seems we don't have a constant for 0xfd (revert op?)","created_at":"2017-03-24T13:32:14Z","updated_at":"2017-03-24T13:32:14Z","html_url":"https://github.com/input-output-hk/etc-client/pull/97#discussion_r107902257","pull_request_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments/107902257"},"html":{"href":"https://github.com/input-output-hk/etc-client/pull/97#discussion_r107902257"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97","id":110977455,"html_url":"https://github.com/input-output-hk/etc-client/pull/97","diff_url":"https://github.com/input-output-hk/etc-client/pull/97.diff","patch_url":"https://github.com/input-output-hk/etc-client/pull/97.patch","issue_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/97","number":97,"state":"open","locked":false,"title":"[EC-86] Add evm tests","user":{"login":"LukasGasior1","id":5664242,"avatar_url":"https://avatars2.githubusercontent.com/u/5664242?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasGasior1","html_url":"https://github.com/LukasGasior1","followers_url":"https://api.github.com/users/LukasGasior1/followers","following_url":"https://api.github.com/users/LukasGasior1/following{/other_user}","gists_url":"https://api.github.com/users/LukasGasior1/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasGasior1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasGasior1/subscriptions","organizations_url":"https://api.github.com/users/LukasGasior1/orgs","repos_url":"https://api.github.com/users/LukasGasior1/repos","events_url":"https://api.github.com/users/LukasGasior1/events{/privacy}","received_events_url":"https://api.github.com/users/LukasGasior1/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-16T01:40:46Z","updated_at":"2017-03-24T13:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e48f32f99b025a39af806bcaadd169df0d2be5a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/97/comments","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/b28dcba8c43407bbd4bce666b7ab1c44931e671a","head":{"label":"input-output-hk:feature/evm-tests","ref":"feature/evm-tests","sha":"b28dcba8c43407bbd4bce666b7ab1c44931e671a","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-03-08T20:06:41Z","pushed_at":"2017-03-24T12:13:43Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":2761,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"input-output-hk:phase/3/txExecution","ref":"phase/3/txExecution","sha":"c59c0e7d59569819ddcdb89098a24542ff82f030","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-03-08T20:06:41Z","pushed_at":"2017-03-24T12:13:43Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":2761,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97"},"html":{"href":"https://github.com/input-output-hk/etc-client/pull/97"},"issue":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/97"},"comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/etc-client/statuses/b28dcba8c43407bbd4bce666b7ab1c44931e671a"}}}}
{"actor":{"display_login":"LukasGasior1"}}