{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24362","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24362/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24362/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24362/events","html_url":"https://github.com/NixOS/nixpkgs/pull/24362","id":217081913,"number":24362,"title":"lxqt-panel: fix for `explicit` (a C++11 keyword) being used as variable","user":{"login":"romildo","id":1217934,"avatar_url":"https://avatars2.githubusercontent.com/u/1217934?v=3","gravatar_id":"","url":"https://api.github.com/users/romildo","html_url":"https://github.com/romildo","followers_url":"https://api.github.com/users/romildo/followers","following_url":"https://api.github.com/users/romildo/following{/other_user}","gists_url":"https://api.github.com/users/romildo/gists{/gist_id}","starred_url":"https://api.github.com/users/romildo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romildo/subscriptions","organizations_url":"https://api.github.com/users/romildo/orgs","repos_url":"https://api.github.com/users/romildo/repos","events_url":"https://api.github.com/users/romildo/events{/privacy}","received_events_url":"https://api.github.com/users/romildo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-26T19:24:20Z","updated_at":"2017-03-26T19:24:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24362","html_url":"https://github.com/NixOS/nixpkgs/pull/24362","diff_url":"https://github.com/NixOS/nixpkgs/pull/24362.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/24362.patch"},"body":"It is needed to override \"explicit\" as this is a C++ keyword. But it\r\nis used as variable name in xkb.h. This is causing a failure in C++\r\ncompile time.  Similar bug here:\r\nhttps://bugs.freedesktop.org/show_bug.cgi?id=74080\r\n\r\nWorkaround from\r\nhttps://github.com/lxde/lxqt-panel/commit/ec62109e0fa678875a9b10fc6f1975267432712d.\r\n\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md)."},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/289308092","html_url":"https://github.com/NixOS/nixpkgs/pull/24362#issuecomment-289308092","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24362","id":289308092,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars2.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T19:24:21Z","updated_at":"2017-03-26T19:24:21Z","body":"@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer."}}
{"actor":{"display_login":"mention-bot"}}