{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/21539","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/21539/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/21539/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/21539/events","html_url":"https://github.com/dotnet/roslyn/pull/21539","id":250470644,"number":21539,"title":"removed ImmutableArray from json.net usage. and moved to IList","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars3.githubusercontent.com/u/1333179?v=4","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"labels":[{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-08-15T23:54:23Z","updated_at":"2017-08-17T22:39:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/21539","html_url":"https://github.com/dotnet/roslyn/pull/21539","diff_url":"https://github.com/dotnet/roslyn/pull/21539.diff","patch_url":"https://github.com/dotnet/roslyn/pull/21539.patch"},"body":"this is port of https://github.com/dotnet/roslyn/pull/21395 to dev15.3.x branch.\r\n\r\n**Customer scenario**\r\n\r\nVS crashes at random point when C#/VB proects are loaded to VS.\r\n\r\n**Bugs this fixes:**\r\n\r\nhttps://devdiv.visualstudio.com/DevDiv/_workitems?id=473979&fullScreen=false&_a=edit\r\n\r\n**Workarounds, if any**\r\n\r\nMake sure VS uses newtonsoft.json shipped with VS not one in the GAC or one in some VS extensions by deleting those.\r\n\r\n**Risk**\r\n\r\nlow. There should be no behavior or noticeable perf changes. it just changes collection type we use to marshal collections between 2 processes.\r\n\r\n**Performance impact**\r\n\r\nthere could be some allocations differences due to creating different kinds of collections (List vs ImmutableArray) but not significant.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nKind of yes. in RTM, we used old version of newtonsoft.json to build, so didn't try to use ImmutableArray, after RTM, we moved all dependencies to current (what VS uses) which support ImmutableArray, so we changed all code to use ImmutableArray.\r\n\r\n**Root cause analysis:**\r\n\r\nThis is general problem for any dll that are not specific to VS but VS depends on. we just encountered it since newstonsoft.json is such a popular one. and some other software GACed the dll that happened to be same version as VS uses but target different framework.\r\n\r\n**How was the bug found?**\r\n\r\nWatson. feedbacks.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/323213437","html_url":"https://github.com/dotnet/roslyn/pull/21539#issuecomment-323213437","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/21539","id":323213437,"user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars0.githubusercontent.com/u/926281?v=4","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"created_at":"2017-08-17T22:39:58Z","updated_at":"2017-08-17T22:39:58Z","body":"Merging at the request of @Pilchie."}}
{"actor":{"display_login":"brettfo"}}