{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/1188","repository_url":"https://api.github.com/repos/material-components/material-components-ios","labels_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1188/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1188/comments","events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1188/events","html_url":"https://github.com/material-components/material-components-ios/pull/1188","id":206036439,"number":1188,"title":"[Bottom sheet] API review (do not merge)","user":{"login":"samnm","id":1251373,"avatar_url":"https://avatars.githubusercontent.com/u/1251373?v=3","gravatar_id":"","url":"https://api.github.com/users/samnm","html_url":"https://github.com/samnm","followers_url":"https://api.github.com/users/samnm/followers","following_url":"https://api.github.com/users/samnm/following{/other_user}","gists_url":"https://api.github.com/users/samnm/gists{/gist_id}","starred_url":"https://api.github.com/users/samnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samnm/subscriptions","organizations_url":"https://api.github.com/users/samnm/orgs","repos_url":"https://api.github.com/users/samnm/repos","events_url":"https://api.github.com/users/samnm/events{/privacy}","received_events_url":"https://api.github.com/users/samnm/received_events","type":"User","site_admin":false},"labels":[{"id":273191333,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"4CAF50","default":false},{"id":473892729,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/pr:Author%20will%20merge","name":"pr:Author will merge","color":"F44336","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-07T22:28:58Z","updated_at":"2017-02-08T02:00:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/1188","html_url":"https://github.com/material-components/material-components-ios/pull/1188","diff_url":"https://github.com/material-components/material-components-ios/pull/1188.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/1188.patch"},"body":"A very minimal API review.\r\n\r\nHistorically our internal implementation of `usePreferredHeight` has defaulted to NO but in this modern day and age it might be more reasonable to default to YES.\r\n\r\nExample:\r\n```\r\n- (void)didTapButton:(id)sender {\r\n  UIViewController *viewController = [[UIViewController alloc] init];\r\n  viewController.transitioningDelegate = self;\r\n  viewController.modalPresentationStyle = UIModalPresentationCustom;\r\n  [self presentViewController:viewController animated:YES completion:nil];\r\n}\r\n\r\n- (UIPresentationController *)\r\n    presentationControllerForPresentedViewController:(UIViewController *)presented\r\n                            presentingViewController:(UIViewController *)presenting\r\n                                sourceViewController:(UIViewController *)source {\r\n  return [[MDCBottomSheetPresentationController alloc] initWithPresentedViewController:presented \r\n                                                              presentingViewController:presenting];\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments/278206400","html_url":"https://github.com/material-components/material-components-ios/pull/1188#issuecomment-278206400","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1188","id":278206400,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T02:00:41Z","updated_at":"2017-02-08T02:00:41Z","body":"# [Codecov](https://codecov.io/gh/material-components/material-components-ios/pull/1188?src=pr&el=h1) Report\n> Merging [#1188](https://codecov.io/gh/material-components/material-components-ios/pull/1188?src=pr&el=desc) into [develop](https://codecov.io/gh/material-components/material-components-ios/commit/d8a2696b5fea5fbf2b5c33bca632da4a924d06a6?src=pr&el=desc) will **not impact** coverage.\n\n\n```diff\n@@           Coverage Diff            @@\n##           develop    #1188   +/-   ##\n========================================\n  Coverage    34.86%   34.86%           \n========================================\n  Files          166      166           \n  Lines        16404    16404           \n  Branches      1120     1120           \n========================================\n  Hits          5720     5720           \n  Misses       10671    10671           \n  Partials        13       13\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/material-components/material-components-ios/pull/1188?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/material-components/material-components-ios/pull/1188?src=pr&el=footer). Last update [d8a2696...be60faa](https://codecov.io/gh/material-components/material-components-ios/compare/d8a2696b5fea5fbf2b5c33bca632da4a924d06a6...be60faad785010fe2df7df9199ab4db740762108?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments)."}}
{"actor":{"display_login":"codecov-io"}}