{"action":"opened","number":16579,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/16579","id":149329482,"html_url":"https://github.com/facebook/react-native/pull/16579","diff_url":"https://github.com/facebook/react-native/pull/16579.diff","patch_url":"https://github.com/facebook/react-native/pull/16579.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/16579","number":16579,"state":"open","locked":false,"title":"[cli] Remove built-in templates","user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars3.githubusercontent.com/u/346214?v=4","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nI added a template for react-navigation directly into the React Native repo a long time ago. The feature `react-native init --template foo` supports both:\r\n- Remote templates (`react-native-template-foo` in npm as well as HTTP URLs for npm)\r\n- Local templates that ship together with react-native itself\r\n\r\nIn retrospect, adding the local template wasn't a good idea. Templates should live outside of the React Native repo and be versioned independently. This was templates can be fixed, adapted to new versions of react-navigation independently of React Native releases, and people can use new templates without having to upgrade React Native.\r\n\r\n### Future of the `navigation` template?\r\n\r\nRemoving the template from the repo is definitely a good idea. The question is whether we should move it to a separate repo.\r\n\r\nHere are a few reasons we might want to delete this template and not move it anywhere else:\r\n- It was undocumented so it's unlikely many people use this template\r\n- `react-navigation` itself contains some [examples](https://github.com/react-community/react-navigation/tree/master/examples)\r\n- Project generators like Ignite might be more a popular and maintained alternative\r\n- If we move this template to a separate repo, how to make sure it will stay maintained? If it's unmaintained, it will disappoint people when it stops working.\r\n\r\nHere are some reasons why we might want to move this code to a separate repo:\r\n- \r\n\r\n@hramos What do you think? I'm slightly leaning towards not moving this template to a new place unless we can guarantee it will stay maintained.\r\n\r\n## Test Plan\r\n\r\nCLI e2e tests pass on Cirle CI.\r\n\r\n## Release Notes\r\n\r\n [CLI] [BREAKING] [TEMPLATES] - Remove built-in project template for react-navigation. Project templates should live outside the React Native repo and be versioned separately. This used to available via `react-native init --template navigation`.\r\n","created_at":"2017-10-28T10:34:25Z","updated_at":"2017-10-28T10:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/16579/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/16579/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/16579/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/75da4361589086dbe7f08606858090d81f5bf1ee","head":{"label":"mkonicek:remove_navigation_template","ref":"remove_navigation_template","sha":"75da4361589086dbe7f08606858090d81f5bf1ee","user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars3.githubusercontent.com/u/346214?v=4","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"repo":{"id":53063875,"name":"react-native","full_name":"mkonicek/react-native","owner":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars3.githubusercontent.com/u/346214?v=4","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkonicek/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/mkonicek/react-native","forks_url":"https://api.github.com/repos/mkonicek/react-native/forks","keys_url":"https://api.github.com/repos/mkonicek/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkonicek/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkonicek/react-native/teams","hooks_url":"https://api.github.com/repos/mkonicek/react-native/hooks","issue_events_url":"https://api.github.com/repos/mkonicek/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/mkonicek/react-native/events","assignees_url":"https://api.github.com/repos/mkonicek/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/mkonicek/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/mkonicek/react-native/tags","blobs_url":"https://api.github.com/repos/mkonicek/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkonicek/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkonicek/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkonicek/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkonicek/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mkonicek/react-native/languages","stargazers_url":"https://api.github.com/repos/mkonicek/react-native/stargazers","contributors_url":"https://api.github.com/repos/mkonicek/react-native/contributors","subscribers_url":"https://api.github.com/repos/mkonicek/react-native/subscribers","subscription_url":"https://api.github.com/repos/mkonicek/react-native/subscription","commits_url":"https://api.github.com/repos/mkonicek/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkonicek/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkonicek/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkonicek/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkonicek/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/mkonicek/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkonicek/react-native/merges","archive_url":"https://api.github.com/repos/mkonicek/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkonicek/react-native/downloads","issues_url":"https://api.github.com/repos/mkonicek/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/mkonicek/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mkonicek/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mkonicek/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkonicek/react-native/labels{/name}","releases_url":"https://api.github.com/repos/mkonicek/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/mkonicek/react-native/deployments","created_at":"2016-03-03T16:03:53Z","updated_at":"2016-11-16T19:49:26Z","pushed_at":"2017-10-28T10:16:06Z","git_url":"git://github.com/mkonicek/react-native.git","ssh_url":"git@github.com:mkonicek/react-native.git","clone_url":"https://github.com/mkonicek/react-native.git","svn_url":"https://github.com/mkonicek/react-native","homepage":"http://facebook.github.io/react-native/","size":86489,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4c05ede9772ad39f00291e93501241491a8f84f5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2017-10-28T10:00:56Z","pushed_at":"2017-10-28T08:08:47Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":146852,"stargazers_count":55123,"watchers_count":55123,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12876,"mirror_url":null,"archived":false,"open_issues_count":689,"forks":12876,"open_issues":689,"watchers":55123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16579"},"html":{"href":"https://github.com/facebook/react-native/pull/16579"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/16579"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/16579/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16579/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16579/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/75da4361589086dbe7f08606858090d81f5bf1ee"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":866,"changed_files":17}}
{"actor":{"display_login":"mkonicek"}}