{"action":"created","comment":{"url":"https://api.github.com/repos/gtk-rs/gtk/pulls/comments/107586939","pull_request_review_id":28567350,"id":107586939,"diff_hunk":"@@ -1344,6 +1390,9 @@ status = \"generate\"\n     name = \"destroy-event\"\n     inhibit = true\n     [[object.signal]]\n+    name = \"drag-data-get\"\n+    ignore = true #in/out parameter","path":"Gir.toml","position":100,"original_position":100,"commit_id":"9dc885d54eb7409fcee45421f8854f31e75281e4","original_commit_id":"9dc885d54eb7409fcee45421f8854f31e75281e4","user":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars1.githubusercontent.com/u/584258?v=3","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"body":"Comment to separate line, please","created_at":"2017-03-23T04:40:24Z","updated_at":"2017-03-23T04:40:24Z","html_url":"https://github.com/gtk-rs/gtk/pull/472#discussion_r107586939","pull_request_url":"https://api.github.com/repos/gtk-rs/gtk/pulls/472","_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/comments/107586939"},"html":{"href":"https://github.com/gtk-rs/gtk/pull/472#discussion_r107586939"},"pull_request":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/472"}}},"pull_request":{"url":"https://api.github.com/repos/gtk-rs/gtk/pulls/472","id":111365443,"html_url":"https://github.com/gtk-rs/gtk/pull/472","diff_url":"https://github.com/gtk-rs/gtk/pull/472.diff","patch_url":"https://github.com/gtk-rs/gtk/pull/472.patch","issue_url":"https://api.github.com/repos/gtk-rs/gtk/issues/472","number":472,"state":"open","locked":false,"title":"RFC: Drag targets","user":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars2.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"body":"Automatically generates `TargetFlags` and `TargetList` and manually implements `TargetEntry`. This follows the same pattern as that used by `gdk::RGBA` following @EPashkin's advice.\r\n\r\nThere are a few issues I see here:\r\n\r\n  1. The in-memory layout of `gdk::RGBA` and `gdk_sys::GdkRGBA` is identical, so casting between them was trivial while I don't believe that holds true for `gtk::TargetEntry` and `gtk_sys::GtkTargetEntry`.\r\n  2. I was getting compilation errors when autogenerating functions that tool an array of `TargetEntry`s so I disabled all functions that do that, though I obviously would like to have them as it includes the functions I want to use.\r\n  3. I'm getting compilation errors for `SetValue` and `SetValueOptional` because of the datatype of `to_glib_none()`, which I didn't get with `gdk::RGBA`, but I don't know if I even need those traits implemented.\r\n \r\nCloses #442.","created_at":"2017-03-17T21:04:02Z","updated_at":"2017-03-23T04:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5215678513c549e91a757a5744a88c6ee1be6deb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gtk-rs/gtk/pulls/472/commits","review_comments_url":"https://api.github.com/repos/gtk-rs/gtk/pulls/472/comments","review_comment_url":"https://api.github.com/repos/gtk-rs/gtk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gtk-rs/gtk/issues/472/comments","statuses_url":"https://api.github.com/repos/gtk-rs/gtk/statuses/9dc885d54eb7409fcee45421f8854f31e75281e4","head":{"label":"Susurrus:drag_targets","ref":"drag_targets","sha":"9dc885d54eb7409fcee45421f8854f31e75281e4","user":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars2.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"repo":{"id":58350382,"name":"gtk","full_name":"Susurrus/gtk","owner":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars2.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Susurrus/gtk","description":"GTK+ 3.x bindings and wrappers for Rust","fork":true,"url":"https://api.github.com/repos/Susurrus/gtk","forks_url":"https://api.github.com/repos/Susurrus/gtk/forks","keys_url":"https://api.github.com/repos/Susurrus/gtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Susurrus/gtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Susurrus/gtk/teams","hooks_url":"https://api.github.com/repos/Susurrus/gtk/hooks","issue_events_url":"https://api.github.com/repos/Susurrus/gtk/issues/events{/number}","events_url":"https://api.github.com/repos/Susurrus/gtk/events","assignees_url":"https://api.github.com/repos/Susurrus/gtk/assignees{/user}","branches_url":"https://api.github.com/repos/Susurrus/gtk/branches{/branch}","tags_url":"https://api.github.com/repos/Susurrus/gtk/tags","blobs_url":"https://api.github.com/repos/Susurrus/gtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Susurrus/gtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Susurrus/gtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Susurrus/gtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Susurrus/gtk/statuses/{sha}","languages_url":"https://api.github.com/repos/Susurrus/gtk/languages","stargazers_url":"https://api.github.com/repos/Susurrus/gtk/stargazers","contributors_url":"https://api.github.com/repos/Susurrus/gtk/contributors","subscribers_url":"https://api.github.com/repos/Susurrus/gtk/subscribers","subscription_url":"https://api.github.com/repos/Susurrus/gtk/subscription","commits_url":"https://api.github.com/repos/Susurrus/gtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Susurrus/gtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Susurrus/gtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Susurrus/gtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Susurrus/gtk/contents/{+path}","compare_url":"https://api.github.com/repos/Susurrus/gtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Susurrus/gtk/merges","archive_url":"https://api.github.com/repos/Susurrus/gtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Susurrus/gtk/downloads","issues_url":"https://api.github.com/repos/Susurrus/gtk/issues{/number}","pulls_url":"https://api.github.com/repos/Susurrus/gtk/pulls{/number}","milestones_url":"https://api.github.com/repos/Susurrus/gtk/milestones{/number}","notifications_url":"https://api.github.com/repos/Susurrus/gtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Susurrus/gtk/labels{/name}","releases_url":"https://api.github.com/repos/Susurrus/gtk/releases{/id}","deployments_url":"https://api.github.com/repos/Susurrus/gtk/deployments","created_at":"2016-05-09T05:22:12Z","updated_at":"2016-05-09T05:22:14Z","pushed_at":"2017-03-23T04:25:12Z","git_url":"git://github.com/Susurrus/gtk.git","ssh_url":"git@github.com:Susurrus/gtk.git","clone_url":"https://github.com/Susurrus/gtk.git","svn_url":"https://github.com/Susurrus/gtk","homepage":"http://gtk-rs.org/","size":6190,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gtk-rs:master","ref":"master","sha":"b266e67c78b45622a3ed84051ccbe47a18e23a00","user":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars1.githubusercontent.com/u/11757045?v=3","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":33257338,"name":"gtk","full_name":"gtk-rs/gtk","owner":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars1.githubusercontent.com/u/11757045?v=3","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gtk-rs/gtk","description":"GTK+ 3.x bindings and wrappers for Rust","fork":false,"url":"https://api.github.com/repos/gtk-rs/gtk","forks_url":"https://api.github.com/repos/gtk-rs/gtk/forks","keys_url":"https://api.github.com/repos/gtk-rs/gtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtk-rs/gtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtk-rs/gtk/teams","hooks_url":"https://api.github.com/repos/gtk-rs/gtk/hooks","issue_events_url":"https://api.github.com/repos/gtk-rs/gtk/issues/events{/number}","events_url":"https://api.github.com/repos/gtk-rs/gtk/events","assignees_url":"https://api.github.com/repos/gtk-rs/gtk/assignees{/user}","branches_url":"https://api.github.com/repos/gtk-rs/gtk/branches{/branch}","tags_url":"https://api.github.com/repos/gtk-rs/gtk/tags","blobs_url":"https://api.github.com/repos/gtk-rs/gtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtk-rs/gtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtk-rs/gtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtk-rs/gtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtk-rs/gtk/statuses/{sha}","languages_url":"https://api.github.com/repos/gtk-rs/gtk/languages","stargazers_url":"https://api.github.com/repos/gtk-rs/gtk/stargazers","contributors_url":"https://api.github.com/repos/gtk-rs/gtk/contributors","subscribers_url":"https://api.github.com/repos/gtk-rs/gtk/subscribers","subscription_url":"https://api.github.com/repos/gtk-rs/gtk/subscription","commits_url":"https://api.github.com/repos/gtk-rs/gtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtk-rs/gtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtk-rs/gtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtk-rs/gtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtk-rs/gtk/contents/{+path}","compare_url":"https://api.github.com/repos/gtk-rs/gtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtk-rs/gtk/merges","archive_url":"https://api.github.com/repos/gtk-rs/gtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtk-rs/gtk/downloads","issues_url":"https://api.github.com/repos/gtk-rs/gtk/issues{/number}","pulls_url":"https://api.github.com/repos/gtk-rs/gtk/pulls{/number}","milestones_url":"https://api.github.com/repos/gtk-rs/gtk/milestones{/number}","notifications_url":"https://api.github.com/repos/gtk-rs/gtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtk-rs/gtk/labels{/name}","releases_url":"https://api.github.com/repos/gtk-rs/gtk/releases{/id}","deployments_url":"https://api.github.com/repos/gtk-rs/gtk/deployments","created_at":"2015-04-01T15:57:09Z","updated_at":"2017-03-22T21:49:14Z","pushed_at":"2017-03-23T04:25:14Z","git_url":"git://github.com/gtk-rs/gtk.git","ssh_url":"git@github.com:gtk-rs/gtk.git","clone_url":"https://github.com/gtk-rs/gtk.git","svn_url":"https://github.com/gtk-rs/gtk","homepage":"http://gtk-rs.org/","size":6306,"stargazers_count":452,"watchers_count":452,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":50,"forks":50,"open_issues":50,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/472"},"html":{"href":"https://github.com/gtk-rs/gtk/pull/472"},"issue":{"href":"https://api.github.com/repos/gtk-rs/gtk/issues/472"},"comments":{"href":"https://api.github.com/repos/gtk-rs/gtk/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gtk-rs/gtk/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/gtk-rs/gtk/statuses/9dc885d54eb7409fcee45421f8854f31e75281e4"}}}}
{"actor":{"display_login":"EPashkin"}}