{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/spark-build/pulls/comments/146836288","pull_request_review_id":71829804,"id":146836288,"diff_hunk":"@@ -318,6 +318,16 @@ def test_secrets():\n         LOGGER.warn(\"Error when deleting secret, {}\".format(r.content))\n \n \n+@pytest.mark.sanity\n+@pytest.mark.multspaces\n+def test_cli_multiple_spaces():\n+    utils.run_tests(app_url=SPARK_EXAMPLES,\n+                    app_args=\"30\",\n+                    expected_output=\"Pi is roughly 3\",\n+                    app_name=\"/spark\",\n+                    args_str=\"--conf  spark.cores.max=2  --class   org.apache.spark.examples.SparkPi\")","path":"tests/test_spark.py","position":11,"original_position":11,"commit_id":"24d1e379f76f5d8c9ed8ed0b082a63f897e6237f","original_commit_id":"24d1e379f76f5d8c9ed8ed0b082a63f897e6237f","user":{"login":"elezar","id":931393,"avatar_url":"https://avatars3.githubusercontent.com/u/931393?v=4","gravatar_id":"","url":"https://api.github.com/users/elezar","html_url":"https://github.com/elezar","followers_url":"https://api.github.com/users/elezar/followers","following_url":"https://api.github.com/users/elezar/following{/other_user}","gists_url":"https://api.github.com/users/elezar/gists{/gist_id}","starred_url":"https://api.github.com/users/elezar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elezar/subscriptions","organizations_url":"https://api.github.com/users/elezar/orgs","repos_url":"https://api.github.com/users/elezar/repos","events_url":"https://api.github.com/users/elezar/events{/privacy}","received_events_url":"https://api.github.com/users/elezar/received_events","type":"User","site_admin":false},"body":"Also, we have added an additional parameter `args_str` here just to handle this case. Would it not be better to continue to use `args` here?\r\n\r\nWe could write the parameter here as:\r\n```python\r\nargs=[\"--conf\", \" spark.cores.max=2\", \" --class \", \" org.apache.spark.examples.SparkPi\", ]\r\n```\r\n(or even have the additional spaces as **explicit** empty strings in the list)\r\n \r\nSince we use `\" \".join(s for s in args)` in the actual submit method, there is no further manipulation fo the whitespace performed.","created_at":"2017-10-25T12:14:06Z","updated_at":"2017-10-25T12:22:08Z","html_url":"https://github.com/mesosphere/spark-build/pull/197#discussion_r146836288","pull_request_url":"https://api.github.com/repos/mesosphere/spark-build/pulls/197","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/comments/146836288"},"html":{"href":"https://github.com/mesosphere/spark-build/pull/197#discussion_r146836288"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/197"}},"in_reply_to_id":146830423},"pull_request":{"url":"https://api.github.com/repos/mesosphere/spark-build/pulls/197","id":148557004,"html_url":"https://github.com/mesosphere/spark-build/pull/197","diff_url":"https://github.com/mesosphere/spark-build/pull/197.diff","patch_url":"https://github.com/mesosphere/spark-build/pull/197.patch","issue_url":"https://api.github.com/repos/mesosphere/spark-build/issues/197","number":197,"state":"open","locked":false,"title":"Added integration test for CLI multiple spaces bug","user":{"login":"susanxhuynh","id":22622418,"avatar_url":"https://avatars1.githubusercontent.com/u/22622418?v=4","gravatar_id":"","url":"https://api.github.com/users/susanxhuynh","html_url":"https://github.com/susanxhuynh","followers_url":"https://api.github.com/users/susanxhuynh/followers","following_url":"https://api.github.com/users/susanxhuynh/following{/other_user}","gists_url":"https://api.github.com/users/susanxhuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/susanxhuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susanxhuynh/subscriptions","organizations_url":"https://api.github.com/users/susanxhuynh/orgs","repos_url":"https://api.github.com/users/susanxhuynh/repos","events_url":"https://api.github.com/users/susanxhuynh/events{/privacy}","received_events_url":"https://api.github.com/users/susanxhuynh/received_events","type":"User","site_admin":false},"body":"Added an integration test for the CLI multiple spaces in submit args bug, which Stavros recently fixed (https://github.com/mesosphere/spark-build/pull/193).\r\nI have verified that the test fails without the fix and passes with it.","created_at":"2017-10-25T02:34:27Z","updated_at":"2017-10-25T12:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33a5463acb5e01c5316c255ccee0f953bc63e91b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ArtRand","id":8851152,"avatar_url":"https://avatars0.githubusercontent.com/u/8851152?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtRand","html_url":"https://github.com/ArtRand","followers_url":"https://api.github.com/users/ArtRand/followers","following_url":"https://api.github.com/users/ArtRand/following{/other_user}","gists_url":"https://api.github.com/users/ArtRand/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtRand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtRand/subscriptions","organizations_url":"https://api.github.com/users/ArtRand/orgs","repos_url":"https://api.github.com/users/ArtRand/repos","events_url":"https://api.github.com/users/ArtRand/events{/privacy}","received_events_url":"https://api.github.com/users/ArtRand/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/spark-build/pulls/197/commits","review_comments_url":"https://api.github.com/repos/mesosphere/spark-build/pulls/197/comments","review_comment_url":"https://api.github.com/repos/mesosphere/spark-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/spark-build/issues/197/comments","statuses_url":"https://api.github.com/repos/mesosphere/spark-build/statuses/24d1e379f76f5d8c9ed8ed0b082a63f897e6237f","head":{"label":"mesosphere:sh-cli-mult-spaces-test","ref":"sh-cli-mult-spaces-test","sha":"24d1e379f76f5d8c9ed8ed0b082a63f897e6237f","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":44209080,"name":"spark-build","full_name":"mesosphere/spark-build","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/spark-build","description":"Used to build the mesosphere/spark docker image and the DC/OS Spark package","fork":false,"url":"https://api.github.com/repos/mesosphere/spark-build","forks_url":"https://api.github.com/repos/mesosphere/spark-build/forks","keys_url":"https://api.github.com/repos/mesosphere/spark-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/spark-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/spark-build/teams","hooks_url":"https://api.github.com/repos/mesosphere/spark-build/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/spark-build/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/spark-build/events","assignees_url":"https://api.github.com/repos/mesosphere/spark-build/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/spark-build/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/spark-build/tags","blobs_url":"https://api.github.com/repos/mesosphere/spark-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/spark-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/spark-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/spark-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/spark-build/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/spark-build/languages","stargazers_url":"https://api.github.com/repos/mesosphere/spark-build/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/spark-build/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/spark-build/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/spark-build/subscription","commits_url":"https://api.github.com/repos/mesosphere/spark-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/spark-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/spark-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/spark-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/spark-build/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/spark-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/spark-build/merges","archive_url":"https://api.github.com/repos/mesosphere/spark-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/spark-build/downloads","issues_url":"https://api.github.com/repos/mesosphere/spark-build/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/spark-build/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/spark-build/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/spark-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/spark-build/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/spark-build/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/spark-build/deployments","created_at":"2015-10-13T22:25:38Z","updated_at":"2017-10-04T09:56:56Z","pushed_at":"2017-10-25T02:34:27Z","git_url":"git://github.com/mesosphere/spark-build.git","ssh_url":"git@github.com:mesosphere/spark-build.git","clone_url":"https://github.com/mesosphere/spark-build.git","svn_url":"https://github.com/mesosphere/spark-build","homepage":"","size":3497,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":20,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"17e248377b8c5746275a922acb67de5a5e0445eb","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":44209080,"name":"spark-build","full_name":"mesosphere/spark-build","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/spark-build","description":"Used to build the mesosphere/spark docker image and the DC/OS Spark package","fork":false,"url":"https://api.github.com/repos/mesosphere/spark-build","forks_url":"https://api.github.com/repos/mesosphere/spark-build/forks","keys_url":"https://api.github.com/repos/mesosphere/spark-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/spark-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/spark-build/teams","hooks_url":"https://api.github.com/repos/mesosphere/spark-build/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/spark-build/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/spark-build/events","assignees_url":"https://api.github.com/repos/mesosphere/spark-build/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/spark-build/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/spark-build/tags","blobs_url":"https://api.github.com/repos/mesosphere/spark-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/spark-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/spark-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/spark-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/spark-build/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/spark-build/languages","stargazers_url":"https://api.github.com/repos/mesosphere/spark-build/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/spark-build/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/spark-build/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/spark-build/subscription","commits_url":"https://api.github.com/repos/mesosphere/spark-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/spark-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/spark-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/spark-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/spark-build/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/spark-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/spark-build/merges","archive_url":"https://api.github.com/repos/mesosphere/spark-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/spark-build/downloads","issues_url":"https://api.github.com/repos/mesosphere/spark-build/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/spark-build/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/spark-build/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/spark-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/spark-build/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/spark-build/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/spark-build/deployments","created_at":"2015-10-13T22:25:38Z","updated_at":"2017-10-04T09:56:56Z","pushed_at":"2017-10-25T02:34:27Z","git_url":"git://github.com/mesosphere/spark-build.git","ssh_url":"git@github.com:mesosphere/spark-build.git","clone_url":"https://github.com/mesosphere/spark-build.git","svn_url":"https://github.com/mesosphere/spark-build","homepage":"","size":3497,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/197"},"html":{"href":"https://github.com/mesosphere/spark-build/pull/197"},"issue":{"href":"https://api.github.com/repos/mesosphere/spark-build/issues/197"},"comments":{"href":"https://api.github.com/repos/mesosphere/spark-build/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/spark-build/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/spark-build/statuses/24d1e379f76f5d8c9ed8ed0b082a63f897e6237f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elezar"}}