{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/117890772","pull_request_review_id":39633260,"id":117890772,"diff_hunk":"@@ -1566,6 +1567,22 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd\n         flags |= SCRIPT_VERIFY_NULLDUMMY;\n     }\n \n+    if (gArgs.GetBoolArg(\"-bip148\", DEFAULT_BIP148)) {\n+        // BIP148 mandatory segwit signalling.\n+        int64_t nMedianTimePast = pindex->GetMedianTimePast();\n+        if ( (nMedianTimePast >= 1501545600) &&  // Tue 01 Aug 2017 00:00:00 UTC\n+                (nMedianTimePast <= 1510704000) &&  // Wed 15 Nov 2017 00:00:00 UTC\n+                (!IsWitnessLockedIn(pindex->pprev, chainparams.GetConsensus()) &&  // Segwit is not locked in\n+                 !IsWitnessEnabled(pindex->pprev, chainparams.GetConsensus())) )   // and is not active.\n+        {\n+            bool fVersionBits = (pindex->nVersion & VERSIONBITS_TOP_MASK) == VERSIONBITS_TOP_BITS;\n+            bool fSegbit = (pindex->nVersion & VersionBitsMask(chainparams.GetConsensus(), Consensus::DEPLOYMENT_SEGWIT)) != 0;\n+            if (!(fVersionBits && fSegbit)) {\n+                return state.DoS(0, error(\"ConnectBlock(): relayed block must signal for segwit, please upgrade to Bitcoin version 0.13.1\"), REJECT_INVALID, \"bad-no-segwit\");","path":"src/validation.cpp","position":23,"original_position":23,"commit_id":"5288ddab0f3f9bb001e1a92eeaa087160d78bf6c","original_commit_id":"5288ddab0f3f9bb001e1a92eeaa087160d78bf6c","user":{"login":"webcaetano","id":2578320,"avatar_url":"https://avatars3.githubusercontent.com/u/2578320?v=3","gravatar_id":"","url":"https://api.github.com/users/webcaetano","html_url":"https://github.com/webcaetano","followers_url":"https://api.github.com/users/webcaetano/followers","following_url":"https://api.github.com/users/webcaetano/following{/other_user}","gists_url":"https://api.github.com/users/webcaetano/gists{/gist_id}","starred_url":"https://api.github.com/users/webcaetano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcaetano/subscriptions","organizations_url":"https://api.github.com/users/webcaetano/orgs","repos_url":"https://api.github.com/users/webcaetano/repos","events_url":"https://api.github.com/users/webcaetano/events{/privacy}","received_events_url":"https://api.github.com/users/webcaetano/received_events","type":"User","site_admin":false},"body":"@PRabahy Maybe `please upgrade to Bitcoin version >=0.13.1`","created_at":"2017-05-23T03:28:40Z","updated_at":"2017-05-23T03:28:41Z","html_url":"https://github.com/bitcoin/bitcoin/pull/10442#discussion_r117890772","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/117890772"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10442#discussion_r117890772"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442","id":121854691,"html_url":"https://github.com/bitcoin/bitcoin/pull/10442","diff_url":"https://github.com/bitcoin/bitcoin/pull/10442.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10442.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10442","number":10442,"state":"open","locked":false,"title":"add a -bip148 option","user":{"login":"earonesty","id":50769,"avatar_url":"https://avatars0.githubusercontent.com/u/50769?v=3","gravatar_id":"","url":"https://api.github.com/users/earonesty","html_url":"https://github.com/earonesty","followers_url":"https://api.github.com/users/earonesty/followers","following_url":"https://api.github.com/users/earonesty/following{/other_user}","gists_url":"https://api.github.com/users/earonesty/gists{/gist_id}","starred_url":"https://api.github.com/users/earonesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earonesty/subscriptions","organizations_url":"https://api.github.com/users/earonesty/orgs","repos_url":"https://api.github.com/users/earonesty/repos","events_url":"https://api.github.com/users/earonesty/events{/privacy}","received_events_url":"https://api.github.com/users/earonesty/received_events","type":"User","site_admin":false},"body":"Disabled by default, this optional parameter allows a user to choose bip148 enforcement.\r\n\r\nThis is rebased from https://github.com/bitcoin/bitcoin/pull/10428\r\n\r\nIncludes changes from code review/suggestions.","created_at":"2017-05-22T20:06:23Z","updated_at":"2017-05-23T03:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3978602182ed5a3a3861e5ccaf4fe8de652797d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10442/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5288ddab0f3f9bb001e1a92eeaa087160d78bf6c","head":{"label":"earonesty:master","ref":"master","sha":"5288ddab0f3f9bb001e1a92eeaa087160d78bf6c","user":{"login":"earonesty","id":50769,"avatar_url":"https://avatars0.githubusercontent.com/u/50769?v=3","gravatar_id":"","url":"https://api.github.com/users/earonesty","html_url":"https://github.com/earonesty","followers_url":"https://api.github.com/users/earonesty/followers","following_url":"https://api.github.com/users/earonesty/following{/other_user}","gists_url":"https://api.github.com/users/earonesty/gists{/gist_id}","starred_url":"https://api.github.com/users/earonesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earonesty/subscriptions","organizations_url":"https://api.github.com/users/earonesty/orgs","repos_url":"https://api.github.com/users/earonesty/repos","events_url":"https://api.github.com/users/earonesty/events{/privacy}","received_events_url":"https://api.github.com/users/earonesty/received_events","type":"User","site_admin":false},"repo":{"id":91742655,"name":"bitcoin","full_name":"earonesty/bitcoin","owner":{"login":"earonesty","id":50769,"avatar_url":"https://avatars0.githubusercontent.com/u/50769?v=3","gravatar_id":"","url":"https://api.github.com/users/earonesty","html_url":"https://github.com/earonesty","followers_url":"https://api.github.com/users/earonesty/followers","following_url":"https://api.github.com/users/earonesty/following{/other_user}","gists_url":"https://api.github.com/users/earonesty/gists{/gist_id}","starred_url":"https://api.github.com/users/earonesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earonesty/subscriptions","organizations_url":"https://api.github.com/users/earonesty/orgs","repos_url":"https://api.github.com/users/earonesty/repos","events_url":"https://api.github.com/users/earonesty/events{/privacy}","received_events_url":"https://api.github.com/users/earonesty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/earonesty/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/earonesty/bitcoin","forks_url":"https://api.github.com/repos/earonesty/bitcoin/forks","keys_url":"https://api.github.com/repos/earonesty/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/earonesty/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/earonesty/bitcoin/teams","hooks_url":"https://api.github.com/repos/earonesty/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/earonesty/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/earonesty/bitcoin/events","assignees_url":"https://api.github.com/repos/earonesty/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/earonesty/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/earonesty/bitcoin/tags","blobs_url":"https://api.github.com/repos/earonesty/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/earonesty/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/earonesty/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/earonesty/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/earonesty/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/earonesty/bitcoin/languages","stargazers_url":"https://api.github.com/repos/earonesty/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/earonesty/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/earonesty/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/earonesty/bitcoin/subscription","commits_url":"https://api.github.com/repos/earonesty/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/earonesty/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/earonesty/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/earonesty/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/earonesty/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/earonesty/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/earonesty/bitcoin/merges","archive_url":"https://api.github.com/repos/earonesty/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/earonesty/bitcoin/downloads","issues_url":"https://api.github.com/repos/earonesty/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/earonesty/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/earonesty/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/earonesty/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/earonesty/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/earonesty/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/earonesty/bitcoin/deployments","created_at":"2017-05-18T22:24:12Z","updated_at":"2017-05-18T22:24:28Z","pushed_at":"2017-05-23T02:17:51Z","git_url":"git://github.com/earonesty/bitcoin.git","ssh_url":"git@github.com:earonesty/bitcoin.git","clone_url":"https://github.com/earonesty/bitcoin.git","svn_url":"https://github.com/earonesty/bitcoin","homepage":"https://bitcoin.org/en/download","size":82946,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"e4775167cb4b15e6a37290d27009386efb1e5e97","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-05-23T03:06:36Z","pushed_at":"2017-05-23T02:17:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":82968,"stargazers_count":12713,"watchers_count":12713,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":8216,"mirror_url":null,"open_issues_count":671,"forks":8216,"open_issues":671,"watchers":12713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10442"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10442"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10442/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10442/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5288ddab0f3f9bb001e1a92eeaa087160d78bf6c"}}}}
{"actor":{"display_login":"webcaetano"}}