{"action":"created","issue":{"url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/1737","repository_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows","labels_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/1737/labels{/name}","comments_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/1737/comments","events_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/1737/events","html_url":"https://github.com/AdguardTeam/AdguardForWindows/issues/1737","id":227102366,"number":1737,"title":"Consider adding a TLSv1.3 flag to advanced settings","user":{"login":"ameshkov","id":5947035,"avatar_url":"https://avatars3.githubusercontent.com/u/5947035?v=3","gravatar_id":"","url":"https://api.github.com/users/ameshkov","html_url":"https://github.com/ameshkov","followers_url":"https://api.github.com/users/ameshkov/followers","following_url":"https://api.github.com/users/ameshkov/following{/other_user}","gists_url":"https://api.github.com/users/ameshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ameshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameshkov/subscriptions","organizations_url":"https://api.github.com/users/ameshkov/orgs","repos_url":"https://api.github.com/users/ameshkov/repos","events_url":"https://api.github.com/users/ameshkov/events{/privacy}","received_events_url":"https://api.github.com/users/ameshkov/received_events","type":"User","site_admin":false},"labels":[{"id":253080580,"url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/labels/Security","name":"Security","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"sfionov","id":47204,"avatar_url":"https://avatars1.githubusercontent.com/u/47204?v=3","gravatar_id":"","url":"https://api.github.com/users/sfionov","html_url":"https://github.com/sfionov","followers_url":"https://api.github.com/users/sfionov/followers","following_url":"https://api.github.com/users/sfionov/following{/other_user}","gists_url":"https://api.github.com/users/sfionov/gists{/gist_id}","starred_url":"https://api.github.com/users/sfionov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfionov/subscriptions","organizations_url":"https://api.github.com/users/sfionov/orgs","repos_url":"https://api.github.com/users/sfionov/repos","events_url":"https://api.github.com/users/sfionov/events{/privacy}","received_events_url":"https://api.github.com/users/sfionov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sfionov","id":47204,"avatar_url":"https://avatars1.githubusercontent.com/u/47204?v=3","gravatar_id":"","url":"https://api.github.com/users/sfionov","html_url":"https://github.com/sfionov","followers_url":"https://api.github.com/users/sfionov/followers","following_url":"https://api.github.com/users/sfionov/following{/other_user}","gists_url":"https://api.github.com/users/sfionov/gists{/gist_id}","starred_url":"https://api.github.com/users/sfionov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfionov/subscriptions","organizations_url":"https://api.github.com/users/sfionov/orgs","repos_url":"https://api.github.com/users/sfionov/repos","events_url":"https://api.github.com/users/sfionov/events{/privacy}","received_events_url":"https://api.github.com/users/sfionov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/milestones/6","html_url":"https://github.com/AdguardTeam/AdguardForWindows/milestone/6","labels_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/milestones/6/labels","id":1720176,"number":6,"title":"6.2","description":"New Adguard Assistant\r\nSettings import and export (prerequisite for cloud sync)\r\nNew Filtering log and Filter editor","creator":{"login":"ameshkov","id":5947035,"avatar_url":"https://avatars3.githubusercontent.com/u/5947035?v=3","gravatar_id":"","url":"https://api.github.com/users/ameshkov","html_url":"https://github.com/ameshkov","followers_url":"https://api.github.com/users/ameshkov/followers","following_url":"https://api.github.com/users/ameshkov/following{/other_user}","gists_url":"https://api.github.com/users/ameshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ameshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameshkov/subscriptions","organizations_url":"https://api.github.com/users/ameshkov/orgs","repos_url":"https://api.github.com/users/ameshkov/repos","events_url":"https://api.github.com/users/ameshkov/events{/privacy}","received_events_url":"https://api.github.com/users/ameshkov/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":94,"state":"open","created_at":"2016-04-20T09:49:18Z","updated_at":"2017-05-08T16:32:07Z","due_on":"2017-04-27T07:00:00Z","closed_at":null},"comments":1,"created_at":"2017-05-08T16:32:07Z","updated_at":"2017-05-09T11:44:15Z","closed_at":null,"body":"We had a very intense discussion about it on Wilders:\r\nhttps://www.wilderssecurity.com/threads/adguard-ad-blocker.342850/page-92\r\n\r\nSo, what should we do to add TLSv1.3 support:\r\n1. Link with a newer OpenSSL: https://www.openssl.org/blog/blog/2017/05/04/tlsv1.3/\r\n2. Use TLSv1.3 in one case only: if client app sends a TLSv1.3 hello AND if TLSv1.3 flag is enabled.\r\n\r\nAlso, it seems, that we'll need to change the way we work with SSL sessions as `SSL_get1_session` is no more reliable when 1.3 is in use."},"comment":{"url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/comments/300138780","html_url":"https://github.com/AdguardTeam/AdguardForWindows/issues/1737#issuecomment-300138780","issue_url":"https://api.github.com/repos/AdguardTeam/AdguardForWindows/issues/1737","id":300138780,"user":{"login":"BooBerry","id":5448916,"avatar_url":"https://avatars3.githubusercontent.com/u/5448916?v=3","gravatar_id":"","url":"https://api.github.com/users/BooBerry","html_url":"https://github.com/BooBerry","followers_url":"https://api.github.com/users/BooBerry/followers","following_url":"https://api.github.com/users/BooBerry/following{/other_user}","gists_url":"https://api.github.com/users/BooBerry/gists{/gist_id}","starred_url":"https://api.github.com/users/BooBerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BooBerry/subscriptions","organizations_url":"https://api.github.com/users/BooBerry/orgs","repos_url":"https://api.github.com/users/BooBerry/repos","events_url":"https://api.github.com/users/BooBerry/events{/privacy}","received_events_url":"https://api.github.com/users/BooBerry/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T11:44:15Z","updated_at":"2017-05-09T11:44:15Z","body":"Yikes, that discussion.\r\n\r\nI'll be following this one closely. It might be somewhat related to #1728 as well, as Adguard still uses an obsolete key exchange which one could see as a 'security' concern, like lack of TLS v1.3 support (albeit experimental due to the incompatibilities between drafts until either finalization and/or having it enabled causes no issues).\r\n\r\nMaybe a blog post about these things when it comes to filtering HTTPS websites is needed, along with a clear list of things you guys are going to do about it (and possibly when)?\r\n\r\nIMO, focusing on these issues in the short term might be a good idea to calm security conscious minds (in times like these we live in, good luck!)."}}
{"actor":{"display_login":"BooBerry"}}