{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/redox-os/kernel/pulls/25","id":126647981,"html_url":"https://github.com/redox-os/kernel/pull/25","diff_url":"https://github.com/redox-os/kernel/pull/25.diff","patch_url":"https://github.com/redox-os/kernel/pull/25.patch","issue_url":"https://api.github.com/repos/redox-os/kernel/issues/25","number":25,"state":"closed","locked":false,"title":"Make env: return ENOENT on non-existent; support unlink()","user":{"login":"ids1024","id":2263150,"avatar_url":"https://avatars2.githubusercontent.com/u/2263150?v=3","gravatar_id":"","url":"https://api.github.com/users/ids1024","html_url":"https://github.com/ids1024","followers_url":"https://api.github.com/users/ids1024/followers","following_url":"https://api.github.com/users/ids1024/following{/other_user}","gists_url":"https://api.github.com/users/ids1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ids1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ids1024/subscriptions","organizations_url":"https://api.github.com/users/ids1024/orgs","repos_url":"https://api.github.com/users/ids1024/repos","events_url":"https://api.github.com/users/ids1024/events{/privacy}","received_events_url":"https://api.github.com/users/ids1024/received_events","type":"User","site_admin":false},"body":"This also requires a small modification to libstd; I guess I'll submit a PR to redox-os/rust, and if it looks okay a PR can be sent upstream as well. Everything has to be rebuilt for this change, if it sets environmental variables. That seems unavoidable though.\r\n\r\nHopefully this is okay, but I don't know why that if condition was commented out, so perhaps it causes issues I'm not aware of.","created_at":"2017-06-20T23:01:24Z","updated_at":"2017-06-20T23:06:14Z","closed_at":"2017-06-20T23:06:14Z","merged_at":"2017-06-20T23:06:14Z","merge_commit_sha":"0478e5f7fb352a26edb480bb6470777a8a29e1f8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/redox-os/kernel/pulls/25/commits","review_comments_url":"https://api.github.com/repos/redox-os/kernel/pulls/25/comments","review_comment_url":"https://api.github.com/repos/redox-os/kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redox-os/kernel/issues/25/comments","statuses_url":"https://api.github.com/repos/redox-os/kernel/statuses/b9f659dadfffc9e705315139e7be5db2702b29ee","head":{"label":"ids1024:env","ref":"env","sha":"b9f659dadfffc9e705315139e7be5db2702b29ee","user":{"login":"ids1024","id":2263150,"avatar_url":"https://avatars2.githubusercontent.com/u/2263150?v=3","gravatar_id":"","url":"https://api.github.com/users/ids1024","html_url":"https://github.com/ids1024","followers_url":"https://api.github.com/users/ids1024/followers","following_url":"https://api.github.com/users/ids1024/following{/other_user}","gists_url":"https://api.github.com/users/ids1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ids1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ids1024/subscriptions","organizations_url":"https://api.github.com/users/ids1024/orgs","repos_url":"https://api.github.com/users/ids1024/repos","events_url":"https://api.github.com/users/ids1024/events{/privacy}","received_events_url":"https://api.github.com/users/ids1024/received_events","type":"User","site_admin":false},"repo":{"id":91986367,"name":"kernel","full_name":"ids1024/kernel","owner":{"login":"ids1024","id":2263150,"avatar_url":"https://avatars2.githubusercontent.com/u/2263150?v=3","gravatar_id":"","url":"https://api.github.com/users/ids1024","html_url":"https://github.com/ids1024","followers_url":"https://api.github.com/users/ids1024/followers","following_url":"https://api.github.com/users/ids1024/following{/other_user}","gists_url":"https://api.github.com/users/ids1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ids1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ids1024/subscriptions","organizations_url":"https://api.github.com/users/ids1024/orgs","repos_url":"https://api.github.com/users/ids1024/repos","events_url":"https://api.github.com/users/ids1024/events{/privacy}","received_events_url":"https://api.github.com/users/ids1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ids1024/kernel","description":"The Redox microkernel","fork":true,"url":"https://api.github.com/repos/ids1024/kernel","forks_url":"https://api.github.com/repos/ids1024/kernel/forks","keys_url":"https://api.github.com/repos/ids1024/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ids1024/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ids1024/kernel/teams","hooks_url":"https://api.github.com/repos/ids1024/kernel/hooks","issue_events_url":"https://api.github.com/repos/ids1024/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ids1024/kernel/events","assignees_url":"https://api.github.com/repos/ids1024/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ids1024/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ids1024/kernel/tags","blobs_url":"https://api.github.com/repos/ids1024/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ids1024/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ids1024/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ids1024/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ids1024/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ids1024/kernel/languages","stargazers_url":"https://api.github.com/repos/ids1024/kernel/stargazers","contributors_url":"https://api.github.com/repos/ids1024/kernel/contributors","subscribers_url":"https://api.github.com/repos/ids1024/kernel/subscribers","subscription_url":"https://api.github.com/repos/ids1024/kernel/subscription","commits_url":"https://api.github.com/repos/ids1024/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ids1024/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ids1024/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ids1024/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ids1024/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ids1024/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ids1024/kernel/merges","archive_url":"https://api.github.com/repos/ids1024/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ids1024/kernel/downloads","issues_url":"https://api.github.com/repos/ids1024/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ids1024/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ids1024/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ids1024/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ids1024/kernel/labels{/name}","releases_url":"https://api.github.com/repos/ids1024/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ids1024/kernel/deployments","created_at":"2017-05-21T20:44:30Z","updated_at":"2017-05-21T20:44:31Z","pushed_at":"2017-06-20T22:57:37Z","git_url":"git://github.com/ids1024/kernel.git","ssh_url":"git@github.com:ids1024/kernel.git","clone_url":"https://github.com/ids1024/kernel.git","svn_url":"https://github.com/ids1024/kernel","homepage":null,"size":357,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redox-os:master","ref":"master","sha":"cd67aabd5aa1a16f1468c1f97eaf776425deb60a","user":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars0.githubusercontent.com/u/14909902?v=3","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"repo":{"id":78058884,"name":"kernel","full_name":"redox-os/kernel","owner":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars0.githubusercontent.com/u/14909902?v=3","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redox-os/kernel","description":"The Redox microkernel","fork":false,"url":"https://api.github.com/repos/redox-os/kernel","forks_url":"https://api.github.com/repos/redox-os/kernel/forks","keys_url":"https://api.github.com/repos/redox-os/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redox-os/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redox-os/kernel/teams","hooks_url":"https://api.github.com/repos/redox-os/kernel/hooks","issue_events_url":"https://api.github.com/repos/redox-os/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/redox-os/kernel/events","assignees_url":"https://api.github.com/repos/redox-os/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/redox-os/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/redox-os/kernel/tags","blobs_url":"https://api.github.com/repos/redox-os/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redox-os/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redox-os/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/redox-os/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redox-os/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/redox-os/kernel/languages","stargazers_url":"https://api.github.com/repos/redox-os/kernel/stargazers","contributors_url":"https://api.github.com/repos/redox-os/kernel/contributors","subscribers_url":"https://api.github.com/repos/redox-os/kernel/subscribers","subscription_url":"https://api.github.com/repos/redox-os/kernel/subscription","commits_url":"https://api.github.com/repos/redox-os/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/redox-os/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/redox-os/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/redox-os/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/redox-os/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/redox-os/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redox-os/kernel/merges","archive_url":"https://api.github.com/repos/redox-os/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redox-os/kernel/downloads","issues_url":"https://api.github.com/repos/redox-os/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/redox-os/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/redox-os/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/redox-os/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redox-os/kernel/labels{/name}","releases_url":"https://api.github.com/repos/redox-os/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/redox-os/kernel/deployments","created_at":"2017-01-04T22:41:21Z","updated_at":"2017-06-16T14:45:24Z","pushed_at":"2017-06-20T23:06:14Z","git_url":"git://github.com/redox-os/kernel.git","ssh_url":"git@github.com:redox-os/kernel.git","clone_url":"https://github.com/redox-os/kernel.git","svn_url":"https://github.com/redox-os/kernel","homepage":null,"size":388,"stargazers_count":72,"watchers_count":72,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":5,"forks":20,"open_issues":5,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redox-os/kernel/pulls/25"},"html":{"href":"https://github.com/redox-os/kernel/pull/25"},"issue":{"href":"https://api.github.com/repos/redox-os/kernel/issues/25"},"comments":{"href":"https://api.github.com/repos/redox-os/kernel/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/redox-os/kernel/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/redox-os/kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redox-os/kernel/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/redox-os/kernel/statuses/b9f659dadfffc9e705315139e7be5db2702b29ee"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jackpot51","id":7741236,"avatar_url":"https://avatars3.githubusercontent.com/u/7741236?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpot51","html_url":"https://github.com/jackpot51","followers_url":"https://api.github.com/users/jackpot51/followers","following_url":"https://api.github.com/users/jackpot51/following{/other_user}","gists_url":"https://api.github.com/users/jackpot51/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpot51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpot51/subscriptions","organizations_url":"https://api.github.com/users/jackpot51/orgs","repos_url":"https://api.github.com/users/jackpot51/repos","events_url":"https://api.github.com/users/jackpot51/events{/privacy}","received_events_url":"https://api.github.com/users/jackpot51/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jackpot51"}}