{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/16802","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/16802/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/16802/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/16802/events","html_url":"https://github.com/Microsoft/TypeScript/issues/16802","id":239194338,"number":16802,"title":"TypeScript 2.4.1 - TS2345 - \"Property 'push' is missing in type","user":{"login":"simonua","id":8005145,"avatar_url":"https://avatars3.githubusercontent.com/u/8005145?v=3","gravatar_id":"","url":"https://api.github.com/users/simonua","html_url":"https://github.com/simonua","followers_url":"https://api.github.com/users/simonua/followers","following_url":"https://api.github.com/users/simonua/following{/other_user}","gists_url":"https://api.github.com/users/simonua/gists{/gist_id}","starred_url":"https://api.github.com/users/simonua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonua/subscriptions","organizations_url":"https://api.github.com/users/simonua/orgs","repos_url":"https://api.github.com/users/simonua/repos","events_url":"https://api.github.com/users/simonua/events{/privacy}","received_events_url":"https://api.github.com/users/simonua/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-28T15:01:18Z","updated_at":"2017-06-28T15:23:21Z","closed_at":null,"body":"<!-- BUGS: Please use this template. -->\r\n<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n**TypeScript Version:**  2.4.1\r\n\r\nI will preface this with me being unclear whether this is a bug or my misunderstanding of the error (more likely), but I hope I can get some traction on it here nevertheless, please. And, thank you!\r\n\r\n**Code**\r\n\r\nThis code used to work with 2.3.4 but fails in 2.4.1\r\n```ts\r\n// A *self-contained* demonstration of the problem follows...\r\nmodule app {\r\n    class TypeScript24Controller {\r\n        static $inject = ['$log'];\r\n\r\n        constructor(private $log: ng.ILogService) {\r\n            $log.debug('TypeScript24Controller constructor called.');\r\n        }\r\n    }\r\n\r\n    angular.module('app').controller('TypeScript24Controller', TypeScript24Controller);\r\n}\r\n```\r\n\r\nStripping `private` in my constructor eliminates the error, but I do want the private property created.\r\n```ts\r\nmodule app {\r\n    class TypeScript24Controller {\r\n        static $inject = ['$log'];\r\n\r\n        constructor($log: ng.ILogService) {\r\n            $log.debug('TypeScript24Controller constructor called.');\r\n        }\r\n    }\r\n\r\n    angular.module('app').controller('TypeScript24Controller', TypeScript24Controller);\r\n}\r\n```\r\n\r\n![image](https://user-images.githubusercontent.com/8005145/27644210-e8638e5e-5bf0-11e7-8327-bc5dcaccd1fd.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/311694353","html_url":"https://github.com/Microsoft/TypeScript/issues/16802#issuecomment-311694353","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/16802","id":311694353,"user":{"login":"andy-ms","id":19274678,"avatar_url":"https://avatars0.githubusercontent.com/u/19274678?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-ms","html_url":"https://github.com/andy-ms","followers_url":"https://api.github.com/users/andy-ms/followers","following_url":"https://api.github.com/users/andy-ms/following{/other_user}","gists_url":"https://api.github.com/users/andy-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-ms/subscriptions","organizations_url":"https://api.github.com/users/andy-ms/orgs","repos_url":"https://api.github.com/users/andy-ms/repos","events_url":"https://api.github.com/users/andy-ms/events{/privacy}","received_events_url":"https://api.github.com/users/andy-ms/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T15:23:21Z","updated_at":"2017-06-28T15:23:21Z","body":"This is due to new weak type checking (#16047).\r\nShould have been fixed by DefinitelyTyped/DefinitelyTyped#17303. Try upgrading your `@types/angular`?"}}
{"actor":{"display_login":"andy-ms"}}