{"action":"closed","number":761,"pull_request":{"url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761","id":123814983,"html_url":"https://github.com/Exygy/sf-dahlia-web/pull/761","diff_url":"https://github.com/Exygy/sf-dahlia-web/pull/761.diff","patch_url":"https://github.com/Exygy/sf-dahlia-web/pull/761.patch","issue_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/761","number":761,"state":"closed","locked":false,"title":"Features/multiple reserved types #137567887","user":{"login":"mluedke2","id":1056580,"avatar_url":"https://avatars2.githubusercontent.com/u/1056580?v=3","gravatar_id":"","url":"https://api.github.com/users/mluedke2","html_url":"https://github.com/mluedke2","followers_url":"https://api.github.com/users/mluedke2/followers","following_url":"https://api.github.com/users/mluedke2/following{/other_user}","gists_url":"https://api.github.com/users/mluedke2/gists{/gist_id}","starred_url":"https://api.github.com/users/mluedke2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluedke2/subscriptions","organizations_url":"https://api.github.com/users/mluedke2/orgs","repos_url":"https://api.github.com/users/mluedke2/repos","events_url":"https://api.github.com/users/mluedke2/events{/privacy}","received_events_url":"https://api.github.com/users/mluedke2/received_events","type":"User","site_admin":false},"body":"Copied the `icons.html` over from the `multifamily-shortform` branch of the pattern library [here](https://raw.githubusercontent.com/Exygy/sf-dahlia-pattern-library/multifamily-shortform/src/views/layouts/includes/icons.html).\r\n\r\nHas a bugfix Grant found to get `reservedDescriptor` in the `listings` object from the Salesforce API on the listings page.\r\n\r\nI'm not wild about the hardcoded 0/1/2/3, so if anyone has ideas to improve that, I'm open. But it's only in 3 spots so I didn't worry about it.\r\n\r\nI made the `or` translated, requiring that I inject the translator into `ListingController`. If I should move this into the `ListingService` instead, let me know and I'll make that change.","created_at":"2017-06-02T23:05:05Z","updated_at":"2017-06-14T18:41:24Z","closed_at":"2017-06-14T18:41:24Z","merged_at":"2017-06-14T18:41:24Z","merge_commit_sha":"c158b8ee16be80ced38f8a64eb6f35db1af707a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761/commits","review_comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761/comments","review_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/761/comments","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/062665c240f72bc9033a6fd78fe8422ec466dde2","head":{"label":"Exygy:features/multiple-reserved-types-#137567887","ref":"features/multiple-reserved-types-#137567887","sha":"062665c240f72bc9033a6fd78fe8422ec466dde2","user":{"login":"Exygy","id":689564,"avatar_url":"https://avatars2.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"repo":{"id":43323246,"name":"sf-dahlia-web","full_name":"Exygy/sf-dahlia-web","owner":{"login":"Exygy","id":689564,"avatar_url":"https://avatars2.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exygy/sf-dahlia-web","description":"DAHLIA is the affordable housing portal for the City and County of San Francisco.","fork":false,"url":"https://api.github.com/repos/Exygy/sf-dahlia-web","forks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/forks","keys_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/teams","hooks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/hooks","issue_events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/events{/number}","events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/events","assignees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/assignees{/user}","branches_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/branches{/branch}","tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/tags","blobs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/languages","stargazers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/stargazers","contributors_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contributors","subscribers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscribers","subscription_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscription","commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contents/{+path}","compare_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/merges","archive_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/downloads","issues_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues{/number}","pulls_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/labels{/name}","releases_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/releases{/id}","deployments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/deployments","created_at":"2015-09-28T19:48:45Z","updated_at":"2017-05-20T22:39:34Z","pushed_at":"2017-06-14T18:41:24Z","git_url":"git://github.com/Exygy/sf-dahlia-web.git","ssh_url":"git@github.com:Exygy/sf-dahlia-web.git","clone_url":"https://github.com/Exygy/sf-dahlia-web.git","svn_url":"https://github.com/Exygy/sf-dahlia-web","homepage":"https://housing.sfgov.org","size":31173,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":6,"default_branch":"master"}},"base":{"label":"Exygy:master","ref":"master","sha":"d2ed45b07fa73d7c35f113a57fc4b5700440768b","user":{"login":"Exygy","id":689564,"avatar_url":"https://avatars2.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"repo":{"id":43323246,"name":"sf-dahlia-web","full_name":"Exygy/sf-dahlia-web","owner":{"login":"Exygy","id":689564,"avatar_url":"https://avatars2.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exygy/sf-dahlia-web","description":"DAHLIA is the affordable housing portal for the City and County of San Francisco.","fork":false,"url":"https://api.github.com/repos/Exygy/sf-dahlia-web","forks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/forks","keys_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/teams","hooks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/hooks","issue_events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/events{/number}","events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/events","assignees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/assignees{/user}","branches_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/branches{/branch}","tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/tags","blobs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/languages","stargazers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/stargazers","contributors_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contributors","subscribers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscribers","subscription_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscription","commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contents/{+path}","compare_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/merges","archive_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/downloads","issues_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues{/number}","pulls_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/labels{/name}","releases_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/releases{/id}","deployments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/deployments","created_at":"2015-09-28T19:48:45Z","updated_at":"2017-05-20T22:39:34Z","pushed_at":"2017-06-14T18:41:24Z","git_url":"git://github.com/Exygy/sf-dahlia-web.git","ssh_url":"git@github.com:Exygy/sf-dahlia-web.git","clone_url":"https://github.com/Exygy/sf-dahlia-web.git","svn_url":"https://github.com/Exygy/sf-dahlia-web","homepage":"https://housing.sfgov.org","size":31173,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761"},"html":{"href":"https://github.com/Exygy/sf-dahlia-web/pull/761"},"issue":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/761"},"comments":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/761/comments"},"review_comments":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761/comments"},"review_comment":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/761/commits"},"statuses":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/062665c240f72bc9033a6fd78fe8422ec466dde2"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kaptron","id":318100,"avatar_url":"https://avatars1.githubusercontent.com/u/318100?v=3","gravatar_id":"","url":"https://api.github.com/users/kaptron","html_url":"https://github.com/kaptron","followers_url":"https://api.github.com/users/kaptron/followers","following_url":"https://api.github.com/users/kaptron/following{/other_user}","gists_url":"https://api.github.com/users/kaptron/gists{/gist_id}","starred_url":"https://api.github.com/users/kaptron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaptron/subscriptions","organizations_url":"https://api.github.com/users/kaptron/orgs","repos_url":"https://api.github.com/users/kaptron/repos","events_url":"https://api.github.com/users/kaptron/events{/privacy}","received_events_url":"https://api.github.com/users/kaptron/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":254,"deletions":301,"changed_files":4}}
{"actor":{"display_login":"kaptron"}}