{"action":"created","issue":{"url":"https://api.github.com/repos/limpkin/mooltipass/issues/443","repository_url":"https://api.github.com/repos/limpkin/mooltipass","labels_url":"https://api.github.com/repos/limpkin/mooltipass/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/limpkin/mooltipass/issues/443/comments","events_url":"https://api.github.com/repos/limpkin/mooltipass/issues/443/events","html_url":"https://github.com/limpkin/mooltipass/pull/443","id":240689290,"number":443,"title":"handle http auth","user":{"login":"reepush","id":8476339,"avatar_url":"https://avatars3.githubusercontent.com/u/8476339?v=3","gravatar_id":"","url":"https://api.github.com/users/reepush","html_url":"https://github.com/reepush","followers_url":"https://api.github.com/users/reepush/followers","following_url":"https://api.github.com/users/reepush/following{/other_user}","gists_url":"https://api.github.com/users/reepush/gists{/gist_id}","starred_url":"https://api.github.com/users/reepush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reepush/subscriptions","organizations_url":"https://api.github.com/users/reepush/orgs","repos_url":"https://api.github.com/users/reepush/repos","events_url":"https://api.github.com/users/reepush/events{/privacy}","received_events_url":"https://api.github.com/users/reepush/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-05T15:28:41Z","updated_at":"2017-07-06T18:15:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/limpkin/mooltipass/pulls/443","html_url":"https://github.com/limpkin/mooltipass/pull/443","diff_url":"https://github.com/limpkin/mooltipass/pull/443.diff","patch_url":"https://github.com/limpkin/mooltipass/pull/443.patch"},"body":"Finally got it working for both Chrome and Firefox!\r\n\r\n* In emulation mode callback for _mooltipass.device.retrieveCredentials_ didn't execute that's why there was no auth popup.\r\n* Stuck with a problem that it's impossible to get `Authorization` header while we intercept response. But we can create our custom popup and handle http authorization by ourself. I used window.prompt now, will add popup later.\r\n* Firefox doesn't execute callback because of the _asyncBlocking_ setting. It's not supported and I will see the differences between Chrome's _asyncBlocking_ and Firefox's _blocking_."},"comment":{"url":"https://api.github.com/repos/limpkin/mooltipass/issues/comments/313477011","html_url":"https://github.com/limpkin/mooltipass/pull/443#issuecomment-313477011","issue_url":"https://api.github.com/repos/limpkin/mooltipass/issues/443","id":313477011,"user":{"login":"reepush","id":8476339,"avatar_url":"https://avatars3.githubusercontent.com/u/8476339?v=3","gravatar_id":"","url":"https://api.github.com/users/reepush","html_url":"https://github.com/reepush","followers_url":"https://api.github.com/users/reepush/followers","following_url":"https://api.github.com/users/reepush/following{/other_user}","gists_url":"https://api.github.com/users/reepush/gists{/gist_id}","starred_url":"https://api.github.com/users/reepush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reepush/subscriptions","organizations_url":"https://api.github.com/users/reepush/orgs","repos_url":"https://api.github.com/users/reepush/repos","events_url":"https://api.github.com/users/reepush/events{/privacy}","received_events_url":"https://api.github.com/users/reepush/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T18:15:59Z","updated_at":"2017-07-06T18:15:59Z","body":"Force pushed to _http-auth_ branch. Please check the changes.\r\n\r\n<img width=\"424\" alt=\"screen shot 2017-07-06 at 20 57 56\" src=\"https://user-images.githubusercontent.com/8476339/27926136-0c88f1de-6290-11e7-8de6-b8ad97f1ec1a.png\">\r\n\r\n* Added custom overlay for http auth\r\n* Handled Firefox spec\r\n* Made changes to _credentialsFound_ as discussed previously\r\n\r\nWhat we need to handle also:\r\n* Pressing _Cancel_ in popup should stop request\r\n* Show error after submitting invalid credentials\r\n* Also remember new credentials after invalid ones were submitted\r\n* Handle proxy authorization\r\n* Handle multiple http authorization at the same time\r\n\r\nLast two issues relates to the fact that I removed a bunch of code from _background/httpauth.js_. For my test case everything works and sufficient. But I think I need to put some of the code back to solve last issues. Anyway I need to understand what's needed and what's not and now it's easier to add code step by step.\r\n"}}
{"actor":{"display_login":"reepush"}}