{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments/147329131","pull_request_review_id":72410199,"id":147329131,"diff_hunk":"@@ -11,7 +11,7 @@ all: test\n NOVENDOR = go list github.com/tendermint/tmlibs/... | grep -v /vendor/\n \n test:\n-\tgo test `glide novendor`\n+\tgo test -tags gcc `glide novendor`","path":"Makefile","position":5,"original_position":5,"commit_id":"1a763ab297c4e375417b63a945c69cd4002f40d6","original_commit_id":"d9c040b7baffcfe238ab1c7b4c6d499356473405","user":{"login":"jaekwon","id":53785,"avatar_url":"https://avatars1.githubusercontent.com/u/53785?v=4","gravatar_id":"","url":"https://api.github.com/users/jaekwon","html_url":"https://github.com/jaekwon","followers_url":"https://api.github.com/users/jaekwon/followers","following_url":"https://api.github.com/users/jaekwon/following{/other_user}","gists_url":"https://api.github.com/users/jaekwon/gists{/gist_id}","starred_url":"https://api.github.com/users/jaekwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaekwon/subscriptions","organizations_url":"https://api.github.com/users/jaekwon/orgs","repos_url":"https://api.github.com/users/jaekwon/repos","events_url":"https://api.github.com/users/jaekwon/events{/privacy}","received_events_url":"https://api.github.com/users/jaekwon/received_events","type":"User","site_admin":false},"body":"Works for me... go 1.8.1, 10.12.x ","created_at":"2017-10-27T06:09:11Z","updated_at":"2017-10-27T06:09:11Z","html_url":"https://github.com/tendermint/tmlibs/pull/67#discussion_r147329131","pull_request_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/67","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments/147329131"},"html":{"href":"https://github.com/tendermint/tmlibs/pull/67#discussion_r147329131"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/67"}},"in_reply_to_id":147037981},"pull_request":{"url":"https://api.github.com/repos/tendermint/tmlibs/pulls/67","id":148520107,"html_url":"https://github.com/tendermint/tmlibs/pull/67","diff_url":"https://github.com/tendermint/tmlibs/pull/67.diff","patch_url":"https://github.com/tendermint/tmlibs/pull/67.patch","issue_url":"https://api.github.com/repos/tendermint/tmlibs/issues/67","number":67,"state":"open","locked":false,"title":"CacheDB","user":{"login":"jaekwon","id":53785,"avatar_url":"https://avatars1.githubusercontent.com/u/53785?v=4","gravatar_id":"","url":"https://api.github.com/users/jaekwon","html_url":"https://github.com/jaekwon","followers_url":"https://api.github.com/users/jaekwon/followers","following_url":"https://api.github.com/users/jaekwon/following{/other_user}","gists_url":"https://api.github.com/users/jaekwon/gists{/gist_id}","starred_url":"https://api.github.com/users/jaekwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaekwon/subscriptions","organizations_url":"https://api.github.com/users/jaekwon/orgs","repos_url":"https://api.github.com/users/jaekwon/repos","events_url":"https://api.github.com/users/jaekwon/events{/privacy}","received_events_url":"https://api.github.com/users/jaekwon/received_events","type":"User","site_admin":false},"body":"This PR is to make the tendermint/tmlibs/db CacheWrap() compatible.\r\nWe could in the future use cosmos/cosmos-sdk/state/kvcache.go (or whatever it becomes), but it's not clear whether we want to make the Cosmos KVStore/IterKVStore interfaces (designed for Merkle stores) compatible with the Tendermint DB interface (designed for LevelDB etc).  Until we can unify them lets keep them separate like this for now.\r\n\r\nAlso fixes a bug where MemDB keys weren't being ordered before Merkle-rooting.\r\nAlso fixes c-leveldb compatibility.  You need to run `brew install leveldb` or equivalent to run the tests.\r\n\r\nNOTE: We *need* c-leveldb support so we should keep them as part of the tests, and fix our CI environment as necessary, instead of crippling our tests.","created_at":"2017-10-24T21:39:34Z","updated_at":"2017-10-27T06:09:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19278d1c6f8add486408ae19df51f591858d8302","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/67/commits","review_comments_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/67/comments","review_comment_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/issues/67/comments","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/1a763ab297c4e375417b63a945c69cd4002f40d6","head":{"label":"tendermint:cachedb","ref":"cachedb","sha":"1a763ab297c4e375417b63a945c69cd4002f40d6","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":88674011,"name":"tmlibs","full_name":"tendermint/tmlibs","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tmlibs","description":null,"fork":false,"url":"https://api.github.com/repos/tendermint/tmlibs","forks_url":"https://api.github.com/repos/tendermint/tmlibs/forks","keys_url":"https://api.github.com/repos/tendermint/tmlibs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tmlibs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tmlibs/teams","hooks_url":"https://api.github.com/repos/tendermint/tmlibs/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tmlibs/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tmlibs/events","assignees_url":"https://api.github.com/repos/tendermint/tmlibs/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tmlibs/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tmlibs/tags","blobs_url":"https://api.github.com/repos/tendermint/tmlibs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tmlibs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tmlibs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tmlibs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tmlibs/languages","stargazers_url":"https://api.github.com/repos/tendermint/tmlibs/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tmlibs/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tmlibs/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tmlibs/subscription","commits_url":"https://api.github.com/repos/tendermint/tmlibs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tmlibs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tmlibs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tmlibs/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tmlibs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tmlibs/merges","archive_url":"https://api.github.com/repos/tendermint/tmlibs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tmlibs/downloads","issues_url":"https://api.github.com/repos/tendermint/tmlibs/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tmlibs/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tmlibs/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tmlibs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tmlibs/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tmlibs/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tmlibs/deployments","created_at":"2017-04-18T21:56:36Z","updated_at":"2017-10-19T16:08:39Z","pushed_at":"2017-10-27T06:08:13Z","git_url":"git://github.com/tendermint/tmlibs.git","ssh_url":"git@github.com:tendermint/tmlibs.git","clone_url":"https://github.com/tendermint/tmlibs.git","svn_url":"https://github.com/tendermint/tmlibs","homepage":null,"size":379,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":11,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"42145a82bd953e4a666bcc01a37e2d140b9c1e8e","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":88674011,"name":"tmlibs","full_name":"tendermint/tmlibs","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tmlibs","description":null,"fork":false,"url":"https://api.github.com/repos/tendermint/tmlibs","forks_url":"https://api.github.com/repos/tendermint/tmlibs/forks","keys_url":"https://api.github.com/repos/tendermint/tmlibs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tmlibs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tmlibs/teams","hooks_url":"https://api.github.com/repos/tendermint/tmlibs/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tmlibs/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tmlibs/events","assignees_url":"https://api.github.com/repos/tendermint/tmlibs/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tmlibs/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tmlibs/tags","blobs_url":"https://api.github.com/repos/tendermint/tmlibs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tmlibs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tmlibs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tmlibs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tmlibs/languages","stargazers_url":"https://api.github.com/repos/tendermint/tmlibs/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tmlibs/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tmlibs/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tmlibs/subscription","commits_url":"https://api.github.com/repos/tendermint/tmlibs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tmlibs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tmlibs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tmlibs/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tmlibs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tmlibs/merges","archive_url":"https://api.github.com/repos/tendermint/tmlibs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tmlibs/downloads","issues_url":"https://api.github.com/repos/tendermint/tmlibs/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tmlibs/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tmlibs/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tmlibs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tmlibs/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tmlibs/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tmlibs/deployments","created_at":"2017-04-18T21:56:36Z","updated_at":"2017-10-19T16:08:39Z","pushed_at":"2017-10-27T06:08:13Z","git_url":"git://github.com/tendermint/tmlibs.git","ssh_url":"git@github.com:tendermint/tmlibs.git","clone_url":"https://github.com/tendermint/tmlibs.git","svn_url":"https://github.com/tendermint/tmlibs","homepage":null,"size":379,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/67"},"html":{"href":"https://github.com/tendermint/tmlibs/pull/67"},"issue":{"href":"https://api.github.com/repos/tendermint/tmlibs/issues/67"},"comments":{"href":"https://api.github.com/repos/tendermint/tmlibs/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tmlibs/statuses/1a763ab297c4e375417b63a945c69cd4002f40d6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaekwon"}}