{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/11865","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/11865/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11865/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/11865/events","html_url":"https://github.com/xbmc/xbmc/pull/11865","id":215187266,"number":11865,"title":"[Fix]paplayer: replaygain regression","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars1.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"labels":[{"id":300779472,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Audio","name":"Audio","color":"009800","default":false},{"id":241676408,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Backport-Done","name":"Backport-Done","color":"5319e7","default":false},{"id":1659186,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1","default":false},{"id":400751192,"url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars2.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":506,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2017-03-18T13:29:03Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"comments":6,"created_at":"2017-03-18T11:33:56Z","updated_at":"2017-03-18T18:01:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11865","html_url":"https://github.com/xbmc/xbmc/pull/11865","diff_url":"https://github.com/xbmc/xbmc/pull/11865.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11865.patch"},"body":"This has been backported as #11864 \r\n\r\nThere have been a number of user reports of replaygain not working since #10924 that fixed the issue of replay gain not being applied if peak value was missing, and also removed the avoid clipping setting. See http://forum.kodi.tv/showthread.php?tid=296751&pid=2517978#pid2517978\r\n\r\nThe regression is that using stream amplification rather than setting replaygain whenever peak is not 1.0 does not result in the required change in volume (users say there is no audible change)\r\n\r\nOn reading http://wiki.hydrogenaud.io/index.php?title=ReplayGain_1.0_specification I believe that the \"reduced gain\" approach to clipping protection, as previously implemented, should be restored along with the AvoidClipping setting that gave the users this option.\r\n\r\nThis reverts those aspects of that PR, but keeps the fix of the original user issue."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/287563364","html_url":"https://github.com/xbmc/xbmc/pull/11865#issuecomment-287563364","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11865","id":287563364,"user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars3.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"created_at":"2017-03-18T18:01:35Z","updated_at":"2017-03-18T18:01:35Z","body":"this is imo the better fix: https://github.com/FernetMenta/xbmc/commit/efbb55aee1389e1c08c9ec1d678df83d20e003ec\r\n\r\nbringing back clipping protection by a setting has imo no value for the user. the limiter of AE is the more sophisticated approach.\r\n\r\nthe actual problem here was that I forgot to consider rgain values < 1.0"}}
{"actor":{"display_login":"FernetMenta"}}