{"push_id":1832186199,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"d829ec4cf2d20296ab3c87099585fd4821101d2c","before":"af5b2ca7f5236912cca9b8484f7ce5296ad2fe56","commits":[{"sha":"d829ec4cf2d20296ab3c87099585fd4821101d2c","author":{"name":"Drew Jaynes","email":"616e881177e53541ea47e5917a60deb2554e079d@drewapicture.com"},"message":"Docs: Provide best practice guidance for achieving parity between `$menu_slug` values supplied when adding menu and submenu pages, and later trying to compare those initial values against sanitized screen IDs derived from `$menu_slug`.\n\nAt the heart of the matter, the `$menu_slug` parameter in `add_menu_page()` and `add_submenu_page()` is not sanitized with `sanitize_key()`. When the screen object is later built for the admin page, the screen ID is derived from that `$menu_slug` value, though passed through `sanitize_key()`, which can produce unexpected results in comparison check.\n\nChanging the sanitization code to provide actual parity is out of the question at this juncture, so updating the docs to describe how to avoid this edge case is the next best option.\n\nProps GregRoss.\nFixes #35305.\n\nBuilt from https://develop.svn.wordpress.org/trunk@40967\n\n\ngit-svn-id: http://core.svn.wordpress.org/trunk@40817 1a063a9b-81f0-0310-95a4-ce76da25c4cd","distinct":true,"url":"https://api.github.com/repos/WordPress/WordPress/commits/d829ec4cf2d20296ab3c87099585fd4821101d2c"}]}
{"actor":{"display_login":"markjaquith"}}