{"action":"created","comment":{"url":"https://api.github.com/repos/babel/babel/pulls/comments/118867618","pull_request_review_id":40698964,"id":118867618,"diff_hunk":"@@ -0,0 +1,87 @@\n+var _ref5 = function (j, result, i) {","path":"packages/babel-plugin-transform-es2015-block-scoping/test/fixtures/general/hoisting-2/expected.js","position":1,"original_position":1,"commit_id":"e51e84a5a5ee1437ca620f369d98606069d3cf4c","original_commit_id":"e51e84a5a5ee1437ca620f369d98606069d3cf4c","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars2.githubusercontent.com/u/73085?v=3","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"body":"Why do we generate these as expressions assigned to a `var` anyway? Is it just easier to generate the AST instead of making a function declaration?","created_at":"2017-05-29T05:26:33Z","updated_at":"2017-05-29T05:29:27Z","html_url":"https://github.com/babel/babel/pull/5773#discussion_r118867618","pull_request_url":"https://api.github.com/repos/babel/babel/pulls/5773","_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/comments/118867618"},"html":{"href":"https://github.com/babel/babel/pull/5773#discussion_r118867618"},"pull_request":{"href":"https://api.github.com/repos/babel/babel/pulls/5773"}}},"pull_request":{"url":"https://api.github.com/repos/babel/babel/pulls/5773","id":122366136,"html_url":"https://github.com/babel/babel/pull/5773","diff_url":"https://github.com/babel/babel/pull/5773.diff","patch_url":"https://github.com/babel/babel/pull/5773.patch","issue_url":"https://api.github.com/repos/babel/babel/issues/5773","number":5773,"state":"open","locked":false,"title":"Hoist block-scoped wrapping functions","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"| Q                        | A <!--(yes/no) -->\r\n| ------------------------ | ---\r\n| Patch: Bug Fix?          | No\r\n| Major: Breaking Change?  | No\r\n| Minor: New Feature?      | No\r\n| Deprecations?            | No\r\n| Spec Compliancy?         | No\r\n| Tests Added/Pass?        | Yes\r\n| Fixed Tickets            |\r\n| License                  | MIT\r\n| Doc PR                   | \r\n| Dependency Changes       | \r\n\r\nThis might be one of the biggest performance boosts we can make. Block scoping is used _everywhere_, and it's the easiest thing to screw up.\r\n\r\nWe can definitely clean up this code, but it's a start. Basically, if we pass in any constant variables, we can likely hoist these wrapped functions wayyy up, avoid recreating the function instances constantly (😉). This is one of the few times we can do it, since we control both the (only) call-site _and_ the function definition.","created_at":"2017-05-25T03:37:29Z","updated_at":"2017-05-29T05:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91c1970c8f168516367f51f01bb5b2358fe028fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/babel/pulls/5773/commits","review_comments_url":"https://api.github.com/repos/babel/babel/pulls/5773/comments","review_comment_url":"https://api.github.com/repos/babel/babel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babel/issues/5773/comments","statuses_url":"https://api.github.com/repos/babel/babel/statuses/e51e84a5a5ee1437ca620f369d98606069d3cf4c","head":{"label":"jridgewell:hoist-block-scoping","ref":"hoist-block-scoping","sha":"e51e84a5a5ee1437ca620f369d98606069d3cf4c","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":43450298,"name":"babel","full_name":"jridgewell/babel","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/babel","description":"Babel is a compiler for writing next generation JavaScript.","fork":true,"url":"https://api.github.com/repos/jridgewell/babel","forks_url":"https://api.github.com/repos/jridgewell/babel/forks","keys_url":"https://api.github.com/repos/jridgewell/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/babel/teams","hooks_url":"https://api.github.com/repos/jridgewell/babel/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/babel/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/babel/events","assignees_url":"https://api.github.com/repos/jridgewell/babel/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/babel/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/babel/tags","blobs_url":"https://api.github.com/repos/jridgewell/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/babel/languages","stargazers_url":"https://api.github.com/repos/jridgewell/babel/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/babel/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/babel/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/babel/subscription","commits_url":"https://api.github.com/repos/jridgewell/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/babel/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/babel/merges","archive_url":"https://api.github.com/repos/jridgewell/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/babel/downloads","issues_url":"https://api.github.com/repos/jridgewell/babel/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/babel/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/babel/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/babel/deployments","created_at":"2015-09-30T18:12:49Z","updated_at":"2016-06-10T01:59:24Z","pushed_at":"2017-05-25T03:27:56Z","git_url":"git://github.com/jridgewell/babel.git","ssh_url":"git@github.com:jridgewell/babel.git","clone_url":"https://github.com/jridgewell/babel.git","svn_url":"https://github.com/jridgewell/babel","homepage":"https://babeljs.io/","size":16992,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:7.0","ref":"7.0","sha":"cfe0a84e2b609cfac02a5b92093625b35a58c9e7","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars2.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":24560307,"name":"babel","full_name":"babel/babel","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars2.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babel","description":":tropical_fish: Babel is a compiler for writing next generation JavaScript.","fork":false,"url":"https://api.github.com/repos/babel/babel","forks_url":"https://api.github.com/repos/babel/babel/forks","keys_url":"https://api.github.com/repos/babel/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babel/teams","hooks_url":"https://api.github.com/repos/babel/babel/hooks","issue_events_url":"https://api.github.com/repos/babel/babel/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babel/events","assignees_url":"https://api.github.com/repos/babel/babel/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babel/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babel/tags","blobs_url":"https://api.github.com/repos/babel/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babel/languages","stargazers_url":"https://api.github.com/repos/babel/babel/stargazers","contributors_url":"https://api.github.com/repos/babel/babel/contributors","subscribers_url":"https://api.github.com/repos/babel/babel/subscribers","subscription_url":"https://api.github.com/repos/babel/babel/subscription","commits_url":"https://api.github.com/repos/babel/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babel/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babel/merges","archive_url":"https://api.github.com/repos/babel/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babel/downloads","issues_url":"https://api.github.com/repos/babel/babel/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babel/labels{/name}","releases_url":"https://api.github.com/repos/babel/babel/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babel/deployments","created_at":"2014-09-28T13:38:23Z","updated_at":"2017-05-29T04:10:10Z","pushed_at":"2017-05-29T00:34:47Z","git_url":"git://github.com/babel/babel.git","ssh_url":"git@github.com:babel/babel.git","clone_url":"https://github.com/babel/babel.git","svn_url":"https://github.com/babel/babel","homepage":"https://babeljs.io/","size":17429,"stargazers_count":21189,"watchers_count":21189,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1850,"mirror_url":null,"open_issues_count":402,"forks":1850,"open_issues":402,"watchers":21189,"default_branch":"7.0"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/5773"},"html":{"href":"https://github.com/babel/babel/pull/5773"},"issue":{"href":"https://api.github.com/repos/babel/babel/issues/5773"},"comments":{"href":"https://api.github.com/repos/babel/babel/issues/5773/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babel/pulls/5773/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babel/pulls/5773/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babel/statuses/e51e84a5a5ee1437ca620f369d98606069d3cf4c"}}}}
{"actor":{"display_login":"Kovensky"}}