{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/104247853","pull_request_review_id":25076190,"id":104247853,"diff_hunk":"@@ -63,6 +63,39 @@ Upgrade VCH with containers\n     Should Not Contain  ${output}  Rolling back upgrade\n     Should Be Equal As Integers  ${rc}  0\n \n+    # check version\n+    ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux version\n+    @{vers}=  Split String  ${output}\n+    ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux inspect --name=%{VCH-NAME} --target=%{TEST_URL} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --password=%{TEST_PASSWORD} --compute-resource=%{TEST_RESOURCE}\n+    Should Contain  ${output}  Completed successfully\n+    Should Contain  ${output}  @{vers}[2]\n+    Should Be Equal As Integers  ${rc}  0\n+    Log  ${output}\n+    Get Docker Params  ${output}  ${true}\n+\n+    Log To Console  \\nTesting rollback...\n+    ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux upgrade --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL} --user=%{TEST_USERNAME} --password=%{TEST_PASSWORD} --force=true --compute-resource=%{TEST_RESOURCE} --timeout %{TEST_TIMEOUT} --rollback\n+    Should Contain  ${output}  Completed successfully\n+    Should Be Equal As Integers  ${rc}  0\n+\n+    # check version again, but old version this time\n+    ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux version","path":"tests/test-cases/Group11-Upgrade/11-01-Upgrade.robot","position":20,"original_position":20,"commit_id":"80fc5ec3ad6db1eae579fad665a99d261e2a1865","original_commit_id":"80fc5ec3ad6db1eae579fad665a99d261e2a1865","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars0.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"it's okay to use the new version of the vic-machine-linux binary here -- same as I've been doing with my ad-hoc testing.","created_at":"2017-03-03T21:40:17Z","updated_at":"2017-03-03T21:40:17Z","html_url":"https://github.com/vmware/vic/pull/4122#discussion_r104247853","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/4122","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/104247853"},"html":{"href":"https://github.com/vmware/vic/pull/4122#discussion_r104247853"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/4122"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/4122","id":108661794,"html_url":"https://github.com/vmware/vic/pull/4122","diff_url":"https://github.com/vmware/vic/pull/4122.diff","patch_url":"https://github.com/vmware/vic/pull/4122.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/4122","number":4122,"state":"open","locked":false,"title":"[specific ci=Group11-Upgrade] vic-machine upgrade --rollback","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars0.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"Resolves #3765 \r\n \r\nStill needs tests and a little cleanup but I wanted to go ahead and post this.\r\n\r\nThis is `vic-machine upgrade --rollback` which allows you to manually go back to a saved snapshot after an upgrade if the upgrade succeeds (from the point of view of vic-machine or the product as a whole) but the user's application doesn't function properly, or for any other reason. Also this contains a couple of commits from @emlin 's open PR and a number of small typo/grammar fixes.","created_at":"2017-03-02T00:36:20Z","updated_at":"2017-03-03T21:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b47e92ddea449efb541991b5983f825a02990c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/4122/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/4122/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/4122/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/80fc5ec3ad6db1eae579fad665a99d261e2a1865","head":{"label":"gigawhitlocks:upgrade-rollback","ref":"upgrade-rollback","sha":"80fc5ec3ad6db1eae579fad665a99d261e2a1865","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars0.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"repo":{"id":55534993,"name":"vic","full_name":"gigawhitlocks/vic","owner":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars0.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigawhitlocks/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/gigawhitlocks/vic","forks_url":"https://api.github.com/repos/gigawhitlocks/vic/forks","keys_url":"https://api.github.com/repos/gigawhitlocks/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigawhitlocks/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigawhitlocks/vic/teams","hooks_url":"https://api.github.com/repos/gigawhitlocks/vic/hooks","issue_events_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/events{/number}","events_url":"https://api.github.com/repos/gigawhitlocks/vic/events","assignees_url":"https://api.github.com/repos/gigawhitlocks/vic/assignees{/user}","branches_url":"https://api.github.com/repos/gigawhitlocks/vic/branches{/branch}","tags_url":"https://api.github.com/repos/gigawhitlocks/vic/tags","blobs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigawhitlocks/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigawhitlocks/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigawhitlocks/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/gigawhitlocks/vic/languages","stargazers_url":"https://api.github.com/repos/gigawhitlocks/vic/stargazers","contributors_url":"https://api.github.com/repos/gigawhitlocks/vic/contributors","subscribers_url":"https://api.github.com/repos/gigawhitlocks/vic/subscribers","subscription_url":"https://api.github.com/repos/gigawhitlocks/vic/subscription","commits_url":"https://api.github.com/repos/gigawhitlocks/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigawhitlocks/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigawhitlocks/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigawhitlocks/vic/contents/{+path}","compare_url":"https://api.github.com/repos/gigawhitlocks/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigawhitlocks/vic/merges","archive_url":"https://api.github.com/repos/gigawhitlocks/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigawhitlocks/vic/downloads","issues_url":"https://api.github.com/repos/gigawhitlocks/vic/issues{/number}","pulls_url":"https://api.github.com/repos/gigawhitlocks/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/gigawhitlocks/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/gigawhitlocks/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigawhitlocks/vic/labels{/name}","releases_url":"https://api.github.com/repos/gigawhitlocks/vic/releases{/id}","deployments_url":"https://api.github.com/repos/gigawhitlocks/vic/deployments","created_at":"2016-04-05T18:57:06Z","updated_at":"2016-04-05T18:57:13Z","pushed_at":"2017-03-03T21:34:37Z","git_url":"git://github.com/gigawhitlocks/vic.git","ssh_url":"git@github.com:gigawhitlocks/vic.git","clone_url":"https://github.com/gigawhitlocks/vic.git","svn_url":"https://github.com/gigawhitlocks/vic","homepage":null,"size":49981,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"739bdb96c4e099473de4054c471c358bcb352879","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2017-03-02T00:04:55Z","pushed_at":"2017-03-03T21:34:39Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":52939,"stargazers_count":199,"watchers_count":199,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"open_issues_count":649,"forks":79,"open_issues":649,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/4122"},"html":{"href":"https://github.com/vmware/vic/pull/4122"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/4122"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/4122/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/4122/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/4122/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/80fc5ec3ad6db1eae579fad665a99d261e2a1865"}}}}
{"actor":{"display_login":"gigawhitlocks"}}