{"action":"opened","number":277,"pull_request":{"url":"https://api.github.com/repos/heiseonline/shariff/pulls/277","id":159999088,"html_url":"https://github.com/heiseonline/shariff/pull/277","diff_url":"https://github.com/heiseonline/shariff/pull/277.diff","patch_url":"https://github.com/heiseonline/shariff/pull/277.patch","issue_url":"https://api.github.com/repos/heiseonline/shariff/issues/277","number":277,"state":"open","locked":false,"title":"Correct errors in the demo page","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars3.githubusercontent.com/u/7413183?v=4","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"body":"This PR corrects following issues in the demo main page \"demo/index.html\":\r\n\r\n1. In the parameters listing for the \"data-services\" parameter of the 2nd example (which is the first one with parameters) one \"&amp;quot;\" is missing before \"whatsapp\". See attached screen shot of the [Shariff demo](http://heiseonline.github.io/shariff/).\r\n\r\n![shariff-demo-ampersand-error](https://user-images.githubusercontent.com/7413183/34326679-88d15458-e8b3-11e7-99bc-f5b960198541.png)\r\n\r\n\r\n2. Examples 3, 4 and 5 use the \"data-services\" parameter, but this is not listed in the parameters listings for these examples.\r\n\r\nI have made these 2 changes with 2 commits, so maintainers can decide to cherry-pick one of these 2 changes only, e.g. in case if the 2nd issue is not a mistake but by purpose.\r\n\r\n**How to test:** Run the demo as described in the README and using the index-html from this PR.\r\n\r\n**Expected results:**\r\n\r\nIssue 1: The \"data-services\" parameter in the parameters listing of the 2nd example shows the correct encoded html, and the listing shows the same value as used for the shariff element in that example.\r\nIssue 2: The \"data-services\" parameter in the parameters listing of examples 3, 4 and 5 show the same values as used for the shariff elements for the particular examples.","created_at":"2017-12-24T13:06:38Z","updated_at":"2017-12-24T13:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/heiseonline/shariff/pulls/277/commits","review_comments_url":"https://api.github.com/repos/heiseonline/shariff/pulls/277/comments","review_comment_url":"https://api.github.com/repos/heiseonline/shariff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heiseonline/shariff/issues/277/comments","statuses_url":"https://api.github.com/repos/heiseonline/shariff/statuses/5af764c04f243e4077fabce67bae65a5a906576a","head":{"label":"richard67:upstream-correct-demo","ref":"upstream-correct-demo","sha":"5af764c04f243e4077fabce67bae65a5a906576a","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars3.githubusercontent.com/u/7413183?v=4","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"repo":{"id":113662344,"name":"shariff-plus","full_name":"richard67/shariff-plus","owner":{"login":"richard67","id":7413183,"avatar_url":"https://avatars3.githubusercontent.com/u/7413183?v=4","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard67/shariff-plus","description":"Fork of the shariff project by heiseonline. Shariff enables website users to share their favorite content without compromising their privacy. Shariff-plus is Shariff extended by some enhancements, e.g. a button for Facebook \"Like\".","fork":true,"url":"https://api.github.com/repos/richard67/shariff-plus","forks_url":"https://api.github.com/repos/richard67/shariff-plus/forks","keys_url":"https://api.github.com/repos/richard67/shariff-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard67/shariff-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard67/shariff-plus/teams","hooks_url":"https://api.github.com/repos/richard67/shariff-plus/hooks","issue_events_url":"https://api.github.com/repos/richard67/shariff-plus/issues/events{/number}","events_url":"https://api.github.com/repos/richard67/shariff-plus/events","assignees_url":"https://api.github.com/repos/richard67/shariff-plus/assignees{/user}","branches_url":"https://api.github.com/repos/richard67/shariff-plus/branches{/branch}","tags_url":"https://api.github.com/repos/richard67/shariff-plus/tags","blobs_url":"https://api.github.com/repos/richard67/shariff-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard67/shariff-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard67/shariff-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard67/shariff-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard67/shariff-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/richard67/shariff-plus/languages","stargazers_url":"https://api.github.com/repos/richard67/shariff-plus/stargazers","contributors_url":"https://api.github.com/repos/richard67/shariff-plus/contributors","subscribers_url":"https://api.github.com/repos/richard67/shariff-plus/subscribers","subscription_url":"https://api.github.com/repos/richard67/shariff-plus/subscription","commits_url":"https://api.github.com/repos/richard67/shariff-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard67/shariff-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard67/shariff-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard67/shariff-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard67/shariff-plus/contents/{+path}","compare_url":"https://api.github.com/repos/richard67/shariff-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard67/shariff-plus/merges","archive_url":"https://api.github.com/repos/richard67/shariff-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard67/shariff-plus/downloads","issues_url":"https://api.github.com/repos/richard67/shariff-plus/issues{/number}","pulls_url":"https://api.github.com/repos/richard67/shariff-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/richard67/shariff-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/richard67/shariff-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard67/shariff-plus/labels{/name}","releases_url":"https://api.github.com/repos/richard67/shariff-plus/releases{/id}","deployments_url":"https://api.github.com/repos/richard67/shariff-plus/deployments","created_at":"2017-12-09T10:51:40Z","updated_at":"2017-12-21T15:00:07Z","pushed_at":"2017-12-24T12:45:09Z","git_url":"git://github.com/richard67/shariff-plus.git","ssh_url":"git@github.com:richard67/shariff-plus.git","clone_url":"https://github.com/richard67/shariff-plus.git","svn_url":"https://github.com/richard67/shariff-plus","homepage":"","size":3040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"heiseonline:develop","ref":"develop","sha":"9462f7c7f21d696d973060db1ace3540ed2611f8","user":{"login":"heiseonline","id":8555894,"avatar_url":"https://avatars2.githubusercontent.com/u/8555894?v=4","gravatar_id":"","url":"https://api.github.com/users/heiseonline","html_url":"https://github.com/heiseonline","followers_url":"https://api.github.com/users/heiseonline/followers","following_url":"https://api.github.com/users/heiseonline/following{/other_user}","gists_url":"https://api.github.com/users/heiseonline/gists{/gist_id}","starred_url":"https://api.github.com/users/heiseonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiseonline/subscriptions","organizations_url":"https://api.github.com/users/heiseonline/orgs","repos_url":"https://api.github.com/users/heiseonline/repos","events_url":"https://api.github.com/users/heiseonline/events{/privacy}","received_events_url":"https://api.github.com/users/heiseonline/received_events","type":"Organization","site_admin":false},"repo":{"id":26486322,"name":"shariff","full_name":"heiseonline/shariff","owner":{"login":"heiseonline","id":8555894,"avatar_url":"https://avatars2.githubusercontent.com/u/8555894?v=4","gravatar_id":"","url":"https://api.github.com/users/heiseonline","html_url":"https://github.com/heiseonline","followers_url":"https://api.github.com/users/heiseonline/followers","following_url":"https://api.github.com/users/heiseonline/following{/other_user}","gists_url":"https://api.github.com/users/heiseonline/gists{/gist_id}","starred_url":"https://api.github.com/users/heiseonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiseonline/subscriptions","organizations_url":"https://api.github.com/users/heiseonline/orgs","repos_url":"https://api.github.com/users/heiseonline/repos","events_url":"https://api.github.com/users/heiseonline/events{/privacy}","received_events_url":"https://api.github.com/users/heiseonline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heiseonline/shariff","description":"👮 Shariff enables website users to share their favorite content without compromising their privacy.","fork":false,"url":"https://api.github.com/repos/heiseonline/shariff","forks_url":"https://api.github.com/repos/heiseonline/shariff/forks","keys_url":"https://api.github.com/repos/heiseonline/shariff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heiseonline/shariff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heiseonline/shariff/teams","hooks_url":"https://api.github.com/repos/heiseonline/shariff/hooks","issue_events_url":"https://api.github.com/repos/heiseonline/shariff/issues/events{/number}","events_url":"https://api.github.com/repos/heiseonline/shariff/events","assignees_url":"https://api.github.com/repos/heiseonline/shariff/assignees{/user}","branches_url":"https://api.github.com/repos/heiseonline/shariff/branches{/branch}","tags_url":"https://api.github.com/repos/heiseonline/shariff/tags","blobs_url":"https://api.github.com/repos/heiseonline/shariff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heiseonline/shariff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heiseonline/shariff/git/refs{/sha}","trees_url":"https://api.github.com/repos/heiseonline/shariff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heiseonline/shariff/statuses/{sha}","languages_url":"https://api.github.com/repos/heiseonline/shariff/languages","stargazers_url":"https://api.github.com/repos/heiseonline/shariff/stargazers","contributors_url":"https://api.github.com/repos/heiseonline/shariff/contributors","subscribers_url":"https://api.github.com/repos/heiseonline/shariff/subscribers","subscription_url":"https://api.github.com/repos/heiseonline/shariff/subscription","commits_url":"https://api.github.com/repos/heiseonline/shariff/commits{/sha}","git_commits_url":"https://api.github.com/repos/heiseonline/shariff/git/commits{/sha}","comments_url":"https://api.github.com/repos/heiseonline/shariff/comments{/number}","issue_comment_url":"https://api.github.com/repos/heiseonline/shariff/issues/comments{/number}","contents_url":"https://api.github.com/repos/heiseonline/shariff/contents/{+path}","compare_url":"https://api.github.com/repos/heiseonline/shariff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heiseonline/shariff/merges","archive_url":"https://api.github.com/repos/heiseonline/shariff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heiseonline/shariff/downloads","issues_url":"https://api.github.com/repos/heiseonline/shariff/issues{/number}","pulls_url":"https://api.github.com/repos/heiseonline/shariff/pulls{/number}","milestones_url":"https://api.github.com/repos/heiseonline/shariff/milestones{/number}","notifications_url":"https://api.github.com/repos/heiseonline/shariff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heiseonline/shariff/labels{/name}","releases_url":"https://api.github.com/repos/heiseonline/shariff/releases{/id}","deployments_url":"https://api.github.com/repos/heiseonline/shariff/deployments","created_at":"2014-11-11T13:34:30Z","updated_at":"2017-12-21T18:29:26Z","pushed_at":"2017-12-22T11:41:38Z","git_url":"git://github.com/heiseonline/shariff.git","ssh_url":"git@github.com:heiseonline/shariff.git","clone_url":"https://github.com/heiseonline/shariff.git","svn_url":"https://github.com/heiseonline/shariff","homepage":"http://ct.de/-2467514","size":4212,"stargazers_count":902,"watchers_count":902,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":138,"open_issues":26,"watchers":902,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/heiseonline/shariff/pulls/277"},"html":{"href":"https://github.com/heiseonline/shariff/pull/277"},"issue":{"href":"https://api.github.com/repos/heiseonline/shariff/issues/277"},"comments":{"href":"https://api.github.com/repos/heiseonline/shariff/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/heiseonline/shariff/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/heiseonline/shariff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heiseonline/shariff/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/heiseonline/shariff/statuses/5af764c04f243e4077fabce67bae65a5a906576a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"richard67"}}