{"action":"created","issue":{"url":"https://api.github.com/repos/bcoe/c8/issues/6","repository_url":"https://api.github.com/repos/bcoe/c8","labels_url":"https://api.github.com/repos/bcoe/c8/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/bcoe/c8/issues/6/comments","events_url":"https://api.github.com/repos/bcoe/c8/issues/6/events","html_url":"https://github.com/bcoe/c8/pull/6","id":276905426,"number":6,"title":"Fix event timing","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-27T05:31:57Z","updated_at":"2017-11-29T23:08:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bcoe/c8/pulls/6","html_url":"https://github.com/bcoe/c8/pull/6","diff_url":"https://github.com/bcoe/c8/pull/6.diff","patch_url":"https://github.com/bcoe/c8/pull/6.patch"},"body":"Fixes the symptoms documented at https://github.com/nodejs/node/issues/17336. This commit contains multiple parts that are hard to separate into separate commits/PRs, but I've documented the bits that I changed below:\r\n\r\n- Use `process.execPath` instead of hardcoding `'node'`\r\n- Make sure to call `done()` in the `foreground()` callback; doing this used to segfault for unknown reasons (presumably inside V8), but will no longer do so after the timing fixes in this PR\r\n- Listen for Inspector events before enabling Profiler/Runtime/Debugger, since events will start flowing in as soon as those are enabled\r\n- Attempt to enable Profiler/Runtime/Debugger before runIfWaitingForDebugger, but do not expect them to complete before runIfWaitingForDebugger finishes\r\n- Wait for the initial pause brought about by `--inspect-brk` before doing anything further, like starting coverage tracking\r\n- Ignore `executionContextDestroyed` signals for non-main contexts (e.g. VM contexts)\r\n- Use Promises more extensively"},"comment":{"url":"https://api.github.com/repos/bcoe/c8/issues/comments/348027439","html_url":"https://github.com/bcoe/c8/pull/6#issuecomment-348027439","issue_url":"https://api.github.com/repos/bcoe/c8/issues/6","id":348027439,"user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars3.githubusercontent.com/u/194609?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"created_at":"2017-11-29T23:08:14Z","updated_at":"2017-11-29T23:08:14Z","author_association":"OWNER","body":"@TimothyGu thank you; I will test when I get home tonight."}}
{"actor":{"display_login":"bcoe"}}