{"action":"created","comment":{"url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/comments/99219158","pull_request_review_id":19888591,"id":99219158,"diff_hunk":"@@ -34,3 +40,7 @@ def local_validate(self,ega_enums):\n         if not any(cc['tag'] == str(self.sample.case_or_control_id) for cc in ega_enums.lookup(\"case_control\")):\n             self._add_local_validation_error(\"sample\",self.sample.alias,\"caseOrControl\",\"Invalid value '%s'\" % self.sample.case_or_control_id)\n \n+    def ftp_files_remote_validate(self,host,username, password):\n+        for _file in self._analysis.files:\n+            if not file_exists(host,username,password,_file.file_name):\n+                self._add_ftp_file_validation_error(\"analysis\",self.analysis.alias,\"fileName\",\"File missing on FTP ega server: %s\" % _file.file_name)","path":"egasub/submission/submittable/alignment.py","position":32,"original_position":32,"commit_id":"d29e72d874ab44f0a7c26561d2ae7d172f172921","original_commit_id":"d29e72d874ab44f0a7c26561d2ae7d172f172921","user":{"login":"junjun-zhang","id":1071695,"avatar_url":"https://avatars.githubusercontent.com/u/1071695?v=3","gravatar_id":"","url":"https://api.github.com/users/junjun-zhang","html_url":"https://github.com/junjun-zhang","followers_url":"https://api.github.com/users/junjun-zhang/followers","following_url":"https://api.github.com/users/junjun-zhang/following{/other_user}","gists_url":"https://api.github.com/users/junjun-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/junjun-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junjun-zhang/subscriptions","organizations_url":"https://api.github.com/users/junjun-zhang/orgs","repos_url":"https://api.github.com/users/junjun-zhang/repos","events_url":"https://api.github.com/users/junjun-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/junjun-zhang/received_events","type":"User","site_admin":false},"body":"only need two parameters here: `file_name`, and `error` (the text of error message)","created_at":"2017-02-02T21:03:45Z","updated_at":"2017-02-02T21:05:22Z","html_url":"https://github.com/icgc-dcc/egasub/pull/25#discussion_r99219158","pull_request_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/comments/99219158"},"html":{"href":"https://github.com/icgc-dcc/egasub/pull/25#discussion_r99219158"},"pull_request":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25","id":104416868,"html_url":"https://github.com/icgc-dcc/egasub/pull/25","diff_url":"https://github.com/icgc-dcc/egasub/pull/25.diff","patch_url":"https://github.com/icgc-dcc/egasub/pull/25.patch","issue_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/25","number":25,"state":"open","locked":false,"title":"Ftp file validation","user":{"login":"baminou","id":16019989,"avatar_url":"https://avatars.githubusercontent.com/u/16019989?v=3","gravatar_id":"","url":"https://api.github.com/users/baminou","html_url":"https://github.com/baminou","followers_url":"https://api.github.com/users/baminou/followers","following_url":"https://api.github.com/users/baminou/following{/other_user}","gists_url":"https://api.github.com/users/baminou/gists{/gist_id}","starred_url":"https://api.github.com/users/baminou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baminou/subscriptions","organizations_url":"https://api.github.com/users/baminou/orgs","repos_url":"https://api.github.com/users/baminou/repos","events_url":"https://api.github.com/users/baminou/events{/privacy}","received_events_url":"https://api.github.com/users/baminou/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-02T20:25:51Z","updated_at":"2017-02-02T21:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"362357dc82ab0da468150c75c5243380096e750a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25/commits","review_comments_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25/comments","review_comment_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/25/comments","statuses_url":"https://api.github.com/repos/icgc-dcc/egasub/statuses/d29e72d874ab44f0a7c26561d2ae7d172f172921","head":{"label":"icgc-dcc:ftp_file_validation","ref":"ftp_file_validation","sha":"d29e72d874ab44f0a7c26561d2ae7d172f172921","user":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"repo":{"id":79081773,"name":"egasub","full_name":"icgc-dcc/egasub","owner":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/icgc-dcc/egasub","description":null,"fork":false,"url":"https://api.github.com/repos/icgc-dcc/egasub","forks_url":"https://api.github.com/repos/icgc-dcc/egasub/forks","keys_url":"https://api.github.com/repos/icgc-dcc/egasub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icgc-dcc/egasub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icgc-dcc/egasub/teams","hooks_url":"https://api.github.com/repos/icgc-dcc/egasub/hooks","issue_events_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/events{/number}","events_url":"https://api.github.com/repos/icgc-dcc/egasub/events","assignees_url":"https://api.github.com/repos/icgc-dcc/egasub/assignees{/user}","branches_url":"https://api.github.com/repos/icgc-dcc/egasub/branches{/branch}","tags_url":"https://api.github.com/repos/icgc-dcc/egasub/tags","blobs_url":"https://api.github.com/repos/icgc-dcc/egasub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icgc-dcc/egasub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icgc-dcc/egasub/git/refs{/sha}","trees_url":"https://api.github.com/repos/icgc-dcc/egasub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icgc-dcc/egasub/statuses/{sha}","languages_url":"https://api.github.com/repos/icgc-dcc/egasub/languages","stargazers_url":"https://api.github.com/repos/icgc-dcc/egasub/stargazers","contributors_url":"https://api.github.com/repos/icgc-dcc/egasub/contributors","subscribers_url":"https://api.github.com/repos/icgc-dcc/egasub/subscribers","subscription_url":"https://api.github.com/repos/icgc-dcc/egasub/subscription","commits_url":"https://api.github.com/repos/icgc-dcc/egasub/commits{/sha}","git_commits_url":"https://api.github.com/repos/icgc-dcc/egasub/git/commits{/sha}","comments_url":"https://api.github.com/repos/icgc-dcc/egasub/comments{/number}","issue_comment_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/comments{/number}","contents_url":"https://api.github.com/repos/icgc-dcc/egasub/contents/{+path}","compare_url":"https://api.github.com/repos/icgc-dcc/egasub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icgc-dcc/egasub/merges","archive_url":"https://api.github.com/repos/icgc-dcc/egasub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icgc-dcc/egasub/downloads","issues_url":"https://api.github.com/repos/icgc-dcc/egasub/issues{/number}","pulls_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls{/number}","milestones_url":"https://api.github.com/repos/icgc-dcc/egasub/milestones{/number}","notifications_url":"https://api.github.com/repos/icgc-dcc/egasub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icgc-dcc/egasub/labels{/name}","releases_url":"https://api.github.com/repos/icgc-dcc/egasub/releases{/id}","deployments_url":"https://api.github.com/repos/icgc-dcc/egasub/deployments","created_at":"2017-01-16T04:06:09Z","updated_at":"2017-01-27T15:47:37Z","pushed_at":"2017-02-02T20:38:01Z","git_url":"git://github.com/icgc-dcc/egasub.git","ssh_url":"git@github.com:icgc-dcc/egasub.git","clone_url":"https://github.com/icgc-dcc/egasub.git","svn_url":"https://github.com/icgc-dcc/egasub","homepage":null,"size":130,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"icgc-dcc:master","ref":"master","sha":"092def23274995d78585176e607724b909b0c36a","user":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"repo":{"id":79081773,"name":"egasub","full_name":"icgc-dcc/egasub","owner":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/icgc-dcc/egasub","description":null,"fork":false,"url":"https://api.github.com/repos/icgc-dcc/egasub","forks_url":"https://api.github.com/repos/icgc-dcc/egasub/forks","keys_url":"https://api.github.com/repos/icgc-dcc/egasub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icgc-dcc/egasub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icgc-dcc/egasub/teams","hooks_url":"https://api.github.com/repos/icgc-dcc/egasub/hooks","issue_events_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/events{/number}","events_url":"https://api.github.com/repos/icgc-dcc/egasub/events","assignees_url":"https://api.github.com/repos/icgc-dcc/egasub/assignees{/user}","branches_url":"https://api.github.com/repos/icgc-dcc/egasub/branches{/branch}","tags_url":"https://api.github.com/repos/icgc-dcc/egasub/tags","blobs_url":"https://api.github.com/repos/icgc-dcc/egasub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icgc-dcc/egasub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icgc-dcc/egasub/git/refs{/sha}","trees_url":"https://api.github.com/repos/icgc-dcc/egasub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icgc-dcc/egasub/statuses/{sha}","languages_url":"https://api.github.com/repos/icgc-dcc/egasub/languages","stargazers_url":"https://api.github.com/repos/icgc-dcc/egasub/stargazers","contributors_url":"https://api.github.com/repos/icgc-dcc/egasub/contributors","subscribers_url":"https://api.github.com/repos/icgc-dcc/egasub/subscribers","subscription_url":"https://api.github.com/repos/icgc-dcc/egasub/subscription","commits_url":"https://api.github.com/repos/icgc-dcc/egasub/commits{/sha}","git_commits_url":"https://api.github.com/repos/icgc-dcc/egasub/git/commits{/sha}","comments_url":"https://api.github.com/repos/icgc-dcc/egasub/comments{/number}","issue_comment_url":"https://api.github.com/repos/icgc-dcc/egasub/issues/comments{/number}","contents_url":"https://api.github.com/repos/icgc-dcc/egasub/contents/{+path}","compare_url":"https://api.github.com/repos/icgc-dcc/egasub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icgc-dcc/egasub/merges","archive_url":"https://api.github.com/repos/icgc-dcc/egasub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icgc-dcc/egasub/downloads","issues_url":"https://api.github.com/repos/icgc-dcc/egasub/issues{/number}","pulls_url":"https://api.github.com/repos/icgc-dcc/egasub/pulls{/number}","milestones_url":"https://api.github.com/repos/icgc-dcc/egasub/milestones{/number}","notifications_url":"https://api.github.com/repos/icgc-dcc/egasub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icgc-dcc/egasub/labels{/name}","releases_url":"https://api.github.com/repos/icgc-dcc/egasub/releases{/id}","deployments_url":"https://api.github.com/repos/icgc-dcc/egasub/deployments","created_at":"2017-01-16T04:06:09Z","updated_at":"2017-01-27T15:47:37Z","pushed_at":"2017-02-02T20:38:01Z","git_url":"git://github.com/icgc-dcc/egasub.git","ssh_url":"git@github.com:icgc-dcc/egasub.git","clone_url":"https://github.com/icgc-dcc/egasub.git","svn_url":"https://github.com/icgc-dcc/egasub","homepage":null,"size":130,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25"},"html":{"href":"https://github.com/icgc-dcc/egasub/pull/25"},"issue":{"href":"https://api.github.com/repos/icgc-dcc/egasub/issues/25"},"comments":{"href":"https://api.github.com/repos/icgc-dcc/egasub/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icgc-dcc/egasub/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/icgc-dcc/egasub/statuses/d29e72d874ab44f0a7c26561d2ae7d172f172921"}}}}
{"actor":{"display_login":"junjun-zhang"}}