{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/67","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/67/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/67/events","html_url":"https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/67","id":222887037,"number":67,"title":"glTF 2.0","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars1.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-19T22:09:24Z","updated_at":"2017-04-27T11:49:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/pulls/67","html_url":"https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/67","diff_url":"https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/67.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/67.patch"},"body":"This has initial support for gltf 2.0.\r\n\r\nI would like some input on my approach on converting traditional diffuse/specular materials to pbr metallic-roughness materials. These are the basic steps:\r\n\r\n* Specular intensity is extracted from the specular color and treated as the metallic factor.\r\n* Specular shininess is typically an exponent from 0 to 1000, and is converted to a 0-1 range as the roughness factor.\r\n* Diffuse stays as is\r\n\r\nAlso I have one comment left in the code that I'm wondering about. Is there a convention for lighting models when they don't contain normals? Should `pbrMetallicRoughness` be left `undefined` and let the implementation figure it out? Right now I do keep the pbr material but set all the values to either black or 0.0, and set the emissive color instead. I'm wondering what different glTF 2.0 viewers might do with a material like this.\r\n\r\nTo-do:\r\n* [ ] More manual testing. Fix tests.\r\n* [ ] Figure out how to get pngjs to write out a 24-bit png with their sync packer. May require a PR there."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/comments/297691609","html_url":"https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/67#issuecomment-297691609","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/obj2gltf/issues/67","id":297691609,"user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars1.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T11:49:42Z","updated_at":"2017-04-27T11:49:42Z","body":"It sounds great to have the flexibility that @emackey suggests (contributions welcome, of course!); however, obj2gltf will still need some reasonable default way to create glTF models **without** the user having to think about the materials. like today's workflow.  This can be built on top of the flexibility, but we are making the barrier-to-entry for glTF too high if we go without it."}}
{"actor":{"display_login":"pjcozzi"}}