{"action":"created","issue":{"url":"https://api.github.com/repos/sidorares/dbus-native/issues/175","repository_url":"https://api.github.com/repos/sidorares/dbus-native","labels_url":"https://api.github.com/repos/sidorares/dbus-native/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/sidorares/dbus-native/issues/175/comments","events_url":"https://api.github.com/repos/sidorares/dbus-native/issues/175/events","html_url":"https://github.com/sidorares/dbus-native/issues/175","id":263768871,"number":175,"title":"ESLint Q&A","user":{"login":"jrobeson","id":56908,"avatar_url":"https://avatars0.githubusercontent.com/u/56908?v=4","gravatar_id":"","url":"https://api.github.com/users/jrobeson","html_url":"https://github.com/jrobeson","followers_url":"https://api.github.com/users/jrobeson/followers","following_url":"https://api.github.com/users/jrobeson/following{/other_user}","gists_url":"https://api.github.com/users/jrobeson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobeson/subscriptions","organizations_url":"https://api.github.com/users/jrobeson/orgs","repos_url":"https://api.github.com/users/jrobeson/repos","events_url":"https://api.github.com/users/jrobeson/events{/privacy}","received_events_url":"https://api.github.com/users/jrobeson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-10-09T01:30:11Z","updated_at":"2017-10-11T04:42:09Z","closed_at":null,"author_association":"COLLABORATOR","body":"I'm not familiar with the code base so I wanna use this as placeholder to ask some questions to guide me.\r\n\r\nI'll use the results to submit a set of focused PRs."},"comment":{"url":"https://api.github.com/repos/sidorares/dbus-native/issues/comments/335680634","html_url":"https://github.com/sidorares/dbus-native/issues/175#issuecomment-335680634","issue_url":"https://api.github.com/repos/sidorares/dbus-native/issues/175","id":335680634,"user":{"login":"jrobeson","id":56908,"avatar_url":"https://avatars0.githubusercontent.com/u/56908?v=4","gravatar_id":"","url":"https://api.github.com/users/jrobeson","html_url":"https://github.com/jrobeson","followers_url":"https://api.github.com/users/jrobeson/followers","following_url":"https://api.github.com/users/jrobeson/following{/other_user}","gists_url":"https://api.github.com/users/jrobeson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobeson/subscriptions","organizations_url":"https://api.github.com/users/jrobeson/orgs","repos_url":"https://api.github.com/users/jrobeson/repos","events_url":"https://api.github.com/users/jrobeson/events{/privacy}","received_events_url":"https://api.github.com/users/jrobeson/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T04:42:09Z","updated_at":"2017-10-11T04:42:09Z","author_association":"COLLABORATOR","body":"Also some of this is down to persona preference.\r\n\r\nFor example:\r\n\r\nThese `var word? cause a redeclare eslint error. \r\n```js\r\n    case 'x': //signed\r\n      this.align(3);\r\n      var word0 = this.readInt32();\r\n      var word1 = this.readInt32();\r\n      var data = Long.fromBits(word0, word1, false);\r\n      if (this.options.ReturnLongjs) return data;\r\n      return data.toNumber(); // convert to number (good up to 53 bits)\r\n```\r\n\r\nI could move the var declarations outside the `switch` or I could scope them by adding `{}` like `case 'whatever': { ... }` or I could inline them into the `this.read*()`.  I'm not sure if I could inline all places where this is the case though."}}
{"actor":{"display_login":"jrobeson"}}