{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/130355778","pull_request_review_id":53220277,"id":130355778,"diff_hunk":"@@ -205,21 +218,46 @@ class KubernetesServerGroupCachingAgent extends KubernetesCachingAgent implement\n     credentials.apiAdaptor.getReplicationController(namespace, name)\n   }\n \n-  List<Pod> loadPods(ReplicaSetOrController serverGroup) {\n+  List<Pod> loadPods(KubernetesController serverGroup) {\n     credentials.apiAdaptor.getPods(serverGroup.namespace, serverGroup.selector)\n   }\n \n+  V1beta1DaemonSetList loadDaemonSets() {\n+    credentials.apiAdaptor.getDaemonSetsForAllNamespace()\n+  }\n+\n+  V1beta1StatefulSetList loadStatefulSets() {\n+    credentials.apiAdaptor.getStatefulSetsForAllNamespace()\n+  }\n+\n+  V1beta1DaemonSet loadDaemonSet(String namespace, String name) {\n+    credentials.apiAdaptor.getDaemonSet(namespace, name)\n+  }\n+\n+  V1beta1StatefulSet loadStatefulSet(String namespace, String name) {\n+    credentials.apiAdaptor.getStatefulSet(namespace, name)\n+  }\n+\n+\n   @Override\n   CacheResult loadData(ProviderCache providerCache) {\n     reloadNamespaces()\n     Long start = System.currentTimeMillis()\n     List<ReplicationController> replicationControllerList = loadReplicationControllers()\n     List<ReplicaSet> replicaSetList = loadReplicaSets()\n-    List<ReplicaSetOrController> serverGroups = (replicationControllerList.collect {\n-      it ? new ReplicaSetOrController(replicationController: it) : null\n+    V1beta1DaemonSetList daemonSetList = loadDaemonSets()\n+    V1beta1StatefulSetList statefulSetList = loadStatefulSets()\n+\n+    //System.out.println (\"JAI 1\" + daemonSetList.toString() + daemonSetList.items.get(0))","path":"clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/provider/agent/KubernetesServerGroupCachingAgent.groovy","position":67,"original_position":67,"commit_id":"575176ecd2b5d0d6b34dda589d38e1613403cf34","original_commit_id":"575176ecd2b5d0d6b34dda589d38e1613403cf34","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"Extraneous code","created_at":"2017-07-31T13:45:05Z","updated_at":"2017-07-31T13:48:26Z","html_url":"https://github.com/spinnaker/clouddriver/pull/1771#discussion_r130355778","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/130355778"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/1771#discussion_r130355778"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771","id":133195364,"html_url":"https://github.com/spinnaker/clouddriver/pull/1771","diff_url":"https://github.com/spinnaker/clouddriver/pull/1771.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/1771.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/1771","number":1771,"state":"open","locked":false,"title":"feat(provider/kubernetes) :  Add statefulset and daemonset controllers  using new  java Client Library","user":{"login":"jatinbajaj1","id":24909748,"avatar_url":"https://avatars1.githubusercontent.com/u/24909748?v=4","gravatar_id":"","url":"https://api.github.com/users/jatinbajaj1","html_url":"https://github.com/jatinbajaj1","followers_url":"https://api.github.com/users/jatinbajaj1/followers","following_url":"https://api.github.com/users/jatinbajaj1/following{/other_user}","gists_url":"https://api.github.com/users/jatinbajaj1/gists{/gist_id}","starred_url":"https://api.github.com/users/jatinbajaj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jatinbajaj1/subscriptions","organizations_url":"https://api.github.com/users/jatinbajaj1/orgs","repos_url":"https://api.github.com/users/jatinbajaj1/repos","events_url":"https://api.github.com/users/jatinbajaj1/events{/privacy}","received_events_url":"https://api.github.com/users/jatinbajaj1/received_events","type":"User","site_admin":false},"body":"\r\n@lwander  -  Please review my changes for  using new library  for DaemonSet and StatefulSet controllers only. \r\n\r\n**- New java Kubernetes client  (i.e. https://github.com/kubernetes-client/java)  used in parallel with Fabric one. \r\n\r\n- New Library is used for  DaemonSet and Stateful set controllers only**\r\n\r\n**-Currently  libs folder with all Jars files are used and checkedin   for compilation ,  as Maven repo is not available yet** \r\n\r\n-  All above changes are in  reference to  Pull request no:  1644  ,   LInk :  https://github.com/spinnaker/clouddriver/pull/1644/files\r\n\r\n- in KubernetesApiConvertor , right now  there is lot of duplicate code as signature and names of classes were  different , We would need a parent Class/Interface  for all V1Beta1Daemon and V1StatefulSet  classes  to avoid duplicate  code. \r\n\r\n\r\nRegards,\r\nJatin Bajaj\r\n\r\nWe prefer small, well tested pull requests.\r\n\r\nPlease refer to [Contributing to Spinnaker](https://spinnaker.io/community/contributing/).\r\n\r\nWhen filling out a pull request, please consider the following:\r\n\r\n* Follow the commit message conventions [found here](http://www.spinnaker.io/v1.0/docs/how-to-submit-a-patch).\r\n* Provide a descriptive summary for your changes.\r\n* If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n* Add inline code comments to changes that might not be obvious.\r\n* Squash your commits as you keep adding changes.\r\n* Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.\r\n\r\nNote that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.\r\n","created_at":"2017-07-31T08:58:09Z","updated_at":"2017-07-31T13:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fa8324f7d8827edda10c59058cbd0c3745daddc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/1771/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/575176ecd2b5d0d6b34dda589d38e1613403cf34","head":{"label":"jatinbajaj1:feature/newlibrary","ref":"feature/newlibrary","sha":"575176ecd2b5d0d6b34dda589d38e1613403cf34","user":{"login":"jatinbajaj1","id":24909748,"avatar_url":"https://avatars1.githubusercontent.com/u/24909748?v=4","gravatar_id":"","url":"https://api.github.com/users/jatinbajaj1","html_url":"https://github.com/jatinbajaj1","followers_url":"https://api.github.com/users/jatinbajaj1/followers","following_url":"https://api.github.com/users/jatinbajaj1/following{/other_user}","gists_url":"https://api.github.com/users/jatinbajaj1/gists{/gist_id}","starred_url":"https://api.github.com/users/jatinbajaj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jatinbajaj1/subscriptions","organizations_url":"https://api.github.com/users/jatinbajaj1/orgs","repos_url":"https://api.github.com/users/jatinbajaj1/repos","events_url":"https://api.github.com/users/jatinbajaj1/events{/privacy}","received_events_url":"https://api.github.com/users/jatinbajaj1/received_events","type":"User","site_admin":false},"repo":{"id":92325800,"name":"clouddriver","full_name":"jatinbajaj1/clouddriver","owner":{"login":"jatinbajaj1","id":24909748,"avatar_url":"https://avatars1.githubusercontent.com/u/24909748?v=4","gravatar_id":"","url":"https://api.github.com/users/jatinbajaj1","html_url":"https://github.com/jatinbajaj1","followers_url":"https://api.github.com/users/jatinbajaj1/followers","following_url":"https://api.github.com/users/jatinbajaj1/following{/other_user}","gists_url":"https://api.github.com/users/jatinbajaj1/gists{/gist_id}","starred_url":"https://api.github.com/users/jatinbajaj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jatinbajaj1/subscriptions","organizations_url":"https://api.github.com/users/jatinbajaj1/orgs","repos_url":"https://api.github.com/users/jatinbajaj1/repos","events_url":"https://api.github.com/users/jatinbajaj1/events{/privacy}","received_events_url":"https://api.github.com/users/jatinbajaj1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jatinbajaj1/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/jatinbajaj1/clouddriver","forks_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/forks","keys_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/teams","hooks_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/events","assignees_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/tags","blobs_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/languages","stargazers_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/subscription","commits_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/merges","archive_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/downloads","issues_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/jatinbajaj1/clouddriver/deployments","created_at":"2017-05-24T18:50:30Z","updated_at":"2017-05-24T18:50:38Z","pushed_at":"2017-07-31T08:47:40Z","git_url":"git://github.com/jatinbajaj1/clouddriver.git","ssh_url":"git@github.com:jatinbajaj1/clouddriver.git","clone_url":"https://github.com/jatinbajaj1/clouddriver.git","svn_url":"https://github.com/jatinbajaj1/clouddriver","homepage":null,"size":44354,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"651194f1cac23a6e05802d5860bddeb21420a8c5","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2017-07-23T13:56:57Z","pushed_at":"2017-07-31T08:58:10Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":31823,"stargazers_count":96,"watchers_count":96,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":13,"forks":180,"open_issues":13,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/1771"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/1771"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/1771/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1771/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/575176ecd2b5d0d6b34dda589d38e1613403cf34"}}}}
{"actor":{"display_login":"lwander"}}