{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/108266895","pull_request_review_id":29100514,"id":108266895,"diff_hunk":"@@ -362,7 +401,7 @@ class LogManager(val logDirs: Array[File],\n         val dataDir = nextLogDir()\n         val dir = new File(dataDir, topicPartition.topic + \"-\" + topicPartition.partition)\n         dir.mkdirs()\n-        val log = new Log(dir, config, recoveryPoint = 0L, scheduler, time)\n+        val log = new Log(dir, config, logStartOffset = 0L, recoveryPoint = 0L, scheduler, time)","path":"core/src/main/scala/kafka/log/LogManager.scala","position":128,"original_position":128,"commit_id":"ad9033da68b76e717a62538a21a5952fa776f841","original_commit_id":"ad9033da68b76e717a62538a21a5952fa776f841","user":{"login":"junrao","id":132330,"avatar_url":"https://avatars1.githubusercontent.com/u/132330?v=3","gravatar_id":"","url":"https://api.github.com/users/junrao","html_url":"https://github.com/junrao","followers_url":"https://api.github.com/users/junrao/followers","following_url":"https://api.github.com/users/junrao/following{/other_user}","gists_url":"https://api.github.com/users/junrao/gists{/gist_id}","starred_url":"https://api.github.com/users/junrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junrao/subscriptions","organizations_url":"https://api.github.com/users/junrao/orgs","repos_url":"https://api.github.com/users/junrao/repos","events_url":"https://api.github.com/users/junrao/events{/privacy}","received_events_url":"https://api.github.com/users/junrao/received_events","type":"User","site_admin":false},"body":"We don't read the logStartOffset from the checkpoint in this case, which is a bit inconsistent with how we load the log when the broker starts up. This seems ok for now since in the rare case when a follower loses the whole log (but still has the logStartOffset checkpoint), it can discover the logStartOffset from the leader quickly. Not sure if we want to add a comment on this.","created_at":"2017-03-27T20:08:06Z","updated_at":"2017-03-27T20:15:05Z","html_url":"https://github.com/apache/kafka/pull/2476#discussion_r108266895","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2476","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/108266895"},"html":{"href":"https://github.com/apache/kafka/pull/2476#discussion_r108266895"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2476"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2476","id":104076260,"html_url":"https://github.com/apache/kafka/pull/2476","diff_url":"https://github.com/apache/kafka/pull/2476.diff","patch_url":"https://github.com/apache/kafka/pull/2476.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2476","number":2476,"state":"open","locked":false,"title":"KAFKA-4586; Add purgeDataBefore() API (KIP-107)","user":{"login":"lindong28","id":5873403,"avatar_url":"https://avatars3.githubusercontent.com/u/5873403?v=3","gravatar_id":"","url":"https://api.github.com/users/lindong28","html_url":"https://github.com/lindong28","followers_url":"https://api.github.com/users/lindong28/followers","following_url":"https://api.github.com/users/lindong28/following{/other_user}","gists_url":"https://api.github.com/users/lindong28/gists{/gist_id}","starred_url":"https://api.github.com/users/lindong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindong28/subscriptions","organizations_url":"https://api.github.com/users/lindong28/orgs","repos_url":"https://api.github.com/users/lindong28/repos","events_url":"https://api.github.com/users/lindong28/events{/privacy}","received_events_url":"https://api.github.com/users/lindong28/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-01T05:11:37Z","updated_at":"2017-03-27T20:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c8c6ce55ff98736315bd2aaeae16078247fa012","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2476/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2476/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2476/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/ad9033da68b76e717a62538a21a5952fa776f841","head":{"label":"lindong28:KAFKA-4586","ref":"KAFKA-4586","sha":"ad9033da68b76e717a62538a21a5952fa776f841","user":{"login":"lindong28","id":5873403,"avatar_url":"https://avatars3.githubusercontent.com/u/5873403?v=3","gravatar_id":"","url":"https://api.github.com/users/lindong28","html_url":"https://github.com/lindong28","followers_url":"https://api.github.com/users/lindong28/followers","following_url":"https://api.github.com/users/lindong28/following{/other_user}","gists_url":"https://api.github.com/users/lindong28/gists{/gist_id}","starred_url":"https://api.github.com/users/lindong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindong28/subscriptions","organizations_url":"https://api.github.com/users/lindong28/orgs","repos_url":"https://api.github.com/users/lindong28/repos","events_url":"https://api.github.com/users/lindong28/events{/privacy}","received_events_url":"https://api.github.com/users/lindong28/received_events","type":"User","site_admin":false},"repo":{"id":21054638,"name":"kafka","full_name":"lindong28/kafka","owner":{"login":"lindong28","id":5873403,"avatar_url":"https://avatars3.githubusercontent.com/u/5873403?v=3","gravatar_id":"","url":"https://api.github.com/users/lindong28","html_url":"https://github.com/lindong28","followers_url":"https://api.github.com/users/lindong28/followers","following_url":"https://api.github.com/users/lindong28/following{/other_user}","gists_url":"https://api.github.com/users/lindong28/gists{/gist_id}","starred_url":"https://api.github.com/users/lindong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindong28/subscriptions","organizations_url":"https://api.github.com/users/lindong28/orgs","repos_url":"https://api.github.com/users/lindong28/repos","events_url":"https://api.github.com/users/lindong28/events{/privacy}","received_events_url":"https://api.github.com/users/lindong28/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lindong28/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/lindong28/kafka","forks_url":"https://api.github.com/repos/lindong28/kafka/forks","keys_url":"https://api.github.com/repos/lindong28/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lindong28/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lindong28/kafka/teams","hooks_url":"https://api.github.com/repos/lindong28/kafka/hooks","issue_events_url":"https://api.github.com/repos/lindong28/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/lindong28/kafka/events","assignees_url":"https://api.github.com/repos/lindong28/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/lindong28/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/lindong28/kafka/tags","blobs_url":"https://api.github.com/repos/lindong28/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lindong28/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lindong28/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/lindong28/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lindong28/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/lindong28/kafka/languages","stargazers_url":"https://api.github.com/repos/lindong28/kafka/stargazers","contributors_url":"https://api.github.com/repos/lindong28/kafka/contributors","subscribers_url":"https://api.github.com/repos/lindong28/kafka/subscribers","subscription_url":"https://api.github.com/repos/lindong28/kafka/subscription","commits_url":"https://api.github.com/repos/lindong28/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/lindong28/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/lindong28/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/lindong28/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/lindong28/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/lindong28/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lindong28/kafka/merges","archive_url":"https://api.github.com/repos/lindong28/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lindong28/kafka/downloads","issues_url":"https://api.github.com/repos/lindong28/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/lindong28/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/lindong28/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/lindong28/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lindong28/kafka/labels{/name}","releases_url":"https://api.github.com/repos/lindong28/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/lindong28/kafka/deployments","created_at":"2014-06-20T22:40:57Z","updated_at":"2016-08-24T10:00:38Z","pushed_at":"2017-03-27T19:54:11Z","git_url":"git://github.com/lindong28/kafka.git","ssh_url":"git@github.com:lindong28/kafka.git","clone_url":"https://github.com/lindong28/kafka.git","svn_url":"https://github.com/lindong28/kafka","homepage":null,"size":43731,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"d348ac92c80b6426864e3ed68b89bad341b3bda5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-03-27T16:12:48Z","pushed_at":"2017-03-27T20:13:56Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":45276,"stargazers_count":4860,"watchers_count":4860,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3032,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":312,"forks":3032,"open_issues":312,"watchers":4860,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2476"},"html":{"href":"https://github.com/apache/kafka/pull/2476"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2476"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2476/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2476/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2476/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/ad9033da68b76e717a62538a21a5952fa776f841"}}}}
{"actor":{"display_login":"junrao"}}