{"action":"created","comment":{"url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments/134034458","pull_request_review_id":57288059,"id":134034458,"diff_hunk":"@@ -1372,3 +1372,16 @@ @mastersthesis{holloway:1988a\n \turl = {http://ir.library.oregonstate.edu/xmlui/bitstream/handle/1957/39942/HollowayJamesL1989.pdf},\n \tyear = {1988}\n }\n+\n+@article{baudin:2012,","path":"docs/references/bib.bib","position":5,"original_position":5,"commit_id":"4ec2645e131a04f06a1d2b2748253cfe463ba876","original_commit_id":"4ec2645e131a04f06a1d2b2748253cfe463ba876","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"body":"Is there any better way to add/lint these than just editing by hand?","created_at":"2017-08-18T19:09:25Z","updated_at":"2017-08-18T19:09:25Z","html_url":"https://github.com/stdlib-js/stdlib/pull/97#discussion_r134034458","pull_request_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments/134034458"},"html":{"href":"https://github.com/stdlib-js/stdlib/pull/97#discussion_r134034458"},"pull_request":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97","id":136539716,"html_url":"https://github.com/stdlib-js/stdlib/pull/97","diff_url":"https://github.com/stdlib-js/stdlib/pull/97.diff","patch_url":"https://github.com/stdlib-js/stdlib/pull/97.patch","issue_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/97","number":97,"state":"open","locked":false,"title":"Complex division","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"body":"Resolves #96.\r\n\r\n<!--lint disable first-heading-level-->\r\n\r\n## Checklist\r\n\r\n> Please ensure the following tasks are completed before submitting this pull request.\r\n\r\n* [x] Read, understood, and followed the [contributing guidelines][contributing], including the relevant style guides.\r\n* [x] Read and understand the [Code of Conduct][code-of-conduct].\r\n* [x] Read and understood the [licensing terms][license].\r\n* [x] Searched for existing issues and pull requests __before__ submitting this pull request.\r\n* [x] Filed an issue (or an issue already existed) __prior to__ submitting this pull request.\r\n* [x] Rebased onto latest `develop`.\r\n* [x] Submitted against `develop` branch.\r\n\r\n\r\n## Description\r\n\r\n> What is the purpose of this pull request?\r\n\r\nThis pull request:\r\n\r\n* adds robust complex division using the algorithm from [A Robust Complex Division in Scilab](https://arxiv.org/abs/1210.4539)\r\n\r\n\r\n## Questions\r\n\r\n> Any questions for reviewers of this pull request?\r\n\r\nThe benchmarks run and compute a result, but I haven't put much effort into making them particularly informative/useful. Do the results go somewhere or do something? I suspect that `Math.random` might eat up most of the time so that the benchmarks aren't all that representative of the actual performance comparison. Is there something I can do to make them better?\r\n\r\nShould I probe it with thousands of examples? I instead aimed for just enough cases to achieve 100% test coverage (which isn't trivial do to all the switching going on).\r\n\r\nFinally, how do you feel about the format:\r\n\r\n```javascript\r\nfunction complexDivision ( re1, im1, re2, im2, output ) {\r\n  output = output || [];\r\n  ...\r\n  output[0] = re;\r\n  output[1] = im;\r\n  return output\r\n}\r\n```\r\n\r\ninstead of \r\n\r\n```javascript\r\nfunction complexDivision ( re1, im1, re2, im2 ) {\r\n  ...\r\n  return [re, im];\r\n}\r\n```\r\n\r\nso that in case you use this heavily you can avoid allocating thousands of two-element arrays. Perhaps a better approach is that `cdiv.js` has that call signature and the main export allocates storage when necessary. Perhaps this is premature optimization, but leaving the option to avoid lots of extra allocation seems friendly.\r\n\r\n---\r\n\r\n@stdlib-js/reviewers\r\n\r\n\r\n<!-- <links> -->\r\n\r\n[contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md\r\n[code-of-conduct]: https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md\r\n[license]: https://github.com/stdlib-js/stdlib/blob/develop/LICENSE\r\n\r\n<!-- </links> -->\r\n","created_at":"2017-08-18T18:35:51Z","updated_at":"2017-08-18T19:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc798bba460bc553c74853d2b3d1920f6a3c1220","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97/commits","review_comments_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97/comments","review_comment_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/97/comments","statuses_url":"https://api.github.com/repos/stdlib-js/stdlib/statuses/4ec2645e131a04f06a1d2b2748253cfe463ba876","head":{"label":"rreusser:complex-division","ref":"complex-division","sha":"4ec2645e131a04f06a1d2b2748253cfe463ba876","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"repo":{"id":90491573,"name":"stdlib","full_name":"rreusser/stdlib","owner":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rreusser/stdlib","description":"Standard library for JavaScript and Node.js.","fork":true,"url":"https://api.github.com/repos/rreusser/stdlib","forks_url":"https://api.github.com/repos/rreusser/stdlib/forks","keys_url":"https://api.github.com/repos/rreusser/stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rreusser/stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rreusser/stdlib/teams","hooks_url":"https://api.github.com/repos/rreusser/stdlib/hooks","issue_events_url":"https://api.github.com/repos/rreusser/stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/rreusser/stdlib/events","assignees_url":"https://api.github.com/repos/rreusser/stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/rreusser/stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/rreusser/stdlib/tags","blobs_url":"https://api.github.com/repos/rreusser/stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rreusser/stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rreusser/stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/rreusser/stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rreusser/stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/rreusser/stdlib/languages","stargazers_url":"https://api.github.com/repos/rreusser/stdlib/stargazers","contributors_url":"https://api.github.com/repos/rreusser/stdlib/contributors","subscribers_url":"https://api.github.com/repos/rreusser/stdlib/subscribers","subscription_url":"https://api.github.com/repos/rreusser/stdlib/subscription","commits_url":"https://api.github.com/repos/rreusser/stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/rreusser/stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/rreusser/stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/rreusser/stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/rreusser/stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/rreusser/stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rreusser/stdlib/merges","archive_url":"https://api.github.com/repos/rreusser/stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rreusser/stdlib/downloads","issues_url":"https://api.github.com/repos/rreusser/stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/rreusser/stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/rreusser/stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/rreusser/stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rreusser/stdlib/labels{/name}","releases_url":"https://api.github.com/repos/rreusser/stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/rreusser/stdlib/deployments","created_at":"2017-05-06T21:15:05Z","updated_at":"2017-05-06T21:15:08Z","pushed_at":"2017-08-18T19:08:54Z","git_url":"git://github.com/rreusser/stdlib.git","ssh_url":"git@github.com:rreusser/stdlib.git","clone_url":"https://github.com/rreusser/stdlib.git","svn_url":"https://github.com/rreusser/stdlib","homepage":"http://stdlib.io","size":105685,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"stdlib-js:develop","ref":"develop","sha":"ba110a0f2abdf2c8346b63f7b434712274723435","user":{"login":"stdlib-js","id":17805691,"avatar_url":"https://avatars2.githubusercontent.com/u/17805691?v=4","gravatar_id":"","url":"https://api.github.com/users/stdlib-js","html_url":"https://github.com/stdlib-js","followers_url":"https://api.github.com/users/stdlib-js/followers","following_url":"https://api.github.com/users/stdlib-js/following{/other_user}","gists_url":"https://api.github.com/users/stdlib-js/gists{/gist_id}","starred_url":"https://api.github.com/users/stdlib-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdlib-js/subscriptions","organizations_url":"https://api.github.com/users/stdlib-js/orgs","repos_url":"https://api.github.com/users/stdlib-js/repos","events_url":"https://api.github.com/users/stdlib-js/events{/privacy}","received_events_url":"https://api.github.com/users/stdlib-js/received_events","type":"Organization","site_admin":false},"repo":{"id":54614238,"name":"stdlib","full_name":"stdlib-js/stdlib","owner":{"login":"stdlib-js","id":17805691,"avatar_url":"https://avatars2.githubusercontent.com/u/17805691?v=4","gravatar_id":"","url":"https://api.github.com/users/stdlib-js","html_url":"https://github.com/stdlib-js","followers_url":"https://api.github.com/users/stdlib-js/followers","following_url":"https://api.github.com/users/stdlib-js/following{/other_user}","gists_url":"https://api.github.com/users/stdlib-js/gists{/gist_id}","starred_url":"https://api.github.com/users/stdlib-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdlib-js/subscriptions","organizations_url":"https://api.github.com/users/stdlib-js/orgs","repos_url":"https://api.github.com/users/stdlib-js/repos","events_url":"https://api.github.com/users/stdlib-js/events{/privacy}","received_events_url":"https://api.github.com/users/stdlib-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stdlib-js/stdlib","description":"Standard library for JavaScript and Node.js.","fork":false,"url":"https://api.github.com/repos/stdlib-js/stdlib","forks_url":"https://api.github.com/repos/stdlib-js/stdlib/forks","keys_url":"https://api.github.com/repos/stdlib-js/stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdlib-js/stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdlib-js/stdlib/teams","hooks_url":"https://api.github.com/repos/stdlib-js/stdlib/hooks","issue_events_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/stdlib-js/stdlib/events","assignees_url":"https://api.github.com/repos/stdlib-js/stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/stdlib-js/stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/stdlib-js/stdlib/tags","blobs_url":"https://api.github.com/repos/stdlib-js/stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdlib-js/stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdlib-js/stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdlib-js/stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdlib-js/stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/stdlib-js/stdlib/languages","stargazers_url":"https://api.github.com/repos/stdlib-js/stdlib/stargazers","contributors_url":"https://api.github.com/repos/stdlib-js/stdlib/contributors","subscribers_url":"https://api.github.com/repos/stdlib-js/stdlib/subscribers","subscription_url":"https://api.github.com/repos/stdlib-js/stdlib/subscription","commits_url":"https://api.github.com/repos/stdlib-js/stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdlib-js/stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdlib-js/stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdlib-js/stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/stdlib-js/stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdlib-js/stdlib/merges","archive_url":"https://api.github.com/repos/stdlib-js/stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdlib-js/stdlib/downloads","issues_url":"https://api.github.com/repos/stdlib-js/stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/stdlib-js/stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/stdlib-js/stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdlib-js/stdlib/labels{/name}","releases_url":"https://api.github.com/repos/stdlib-js/stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/stdlib-js/stdlib/deployments","created_at":"2016-03-24T04:19:52Z","updated_at":"2017-08-18T18:44:00Z","pushed_at":"2017-08-18T19:08:56Z","git_url":"git://github.com/stdlib-js/stdlib.git","ssh_url":"git@github.com:stdlib-js/stdlib.git","clone_url":"https://github.com/stdlib-js/stdlib.git","svn_url":"https://github.com/stdlib-js/stdlib","homepage":"http://stdlib.io","size":105682,"stargazers_count":333,"watchers_count":333,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":56,"forks":18,"open_issues":56,"watchers":333,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97"},"html":{"href":"https://github.com/stdlib-js/stdlib/pull/97"},"issue":{"href":"https://api.github.com/repos/stdlib-js/stdlib/issues/97"},"comments":{"href":"https://api.github.com/repos/stdlib-js/stdlib/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/stdlib-js/stdlib/statuses/4ec2645e131a04f06a1d2b2748253cfe463ba876"}}}}
{"actor":{"display_login":"rreusser"}}