{"action":"created","issue":{"url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/38","repository_url":"https://api.github.com/repos/flywheelsports/fwsp-hydra","labels_url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/38/comments","events_url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/38/events","html_url":"https://github.com/flywheelsports/fwsp-hydra/pull/38","id":200389521,"number":38,"title":"allow more redis connection options","user":{"login":"emadum","id":300409,"avatar_url":"https://avatars.githubusercontent.com/u/300409?v=3","gravatar_id":"","url":"https://api.github.com/users/emadum","html_url":"https://github.com/emadum","followers_url":"https://api.github.com/users/emadum/followers","following_url":"https://api.github.com/users/emadum/following{/other_user}","gists_url":"https://api.github.com/users/emadum/gists{/gist_id}","starred_url":"https://api.github.com/users/emadum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emadum/subscriptions","organizations_url":"https://api.github.com/users/emadum/orgs","repos_url":"https://api.github.com/users/emadum/repos","events_url":"https://api.github.com/users/emadum/events{/privacy}","received_events_url":"https://api.github.com/users/emadum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-12T15:02:24Z","updated_at":"2017-01-12T18:45:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/pulls/38","html_url":"https://github.com/flywheelsports/fwsp-hydra/pull/38","diff_url":"https://github.com/flywheelsports/fwsp-hydra/pull/38.diff","patch_url":"https://github.com/flywheelsports/fwsp-hydra/pull/38.patch"},"body":"This PR improves the handling of connecting to Redis.\r\n\r\n- pass options from hydra.redis config entry to redis.createClient\r\n- Extracted retry strategy to _redisRetryStrategy (so the retry strategy can be easily overridden by extending Hydra)\r\n- Options for _redisRetryStrategy are passed in via the hydra.redis.retry_strategy config entry, since redis.createClient requires a function for that option. This is the only option that won't be passed through unmodified to redis.createClient."},"comment":{"url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/comments/272246582","html_url":"https://github.com/flywheelsports/fwsp-hydra/pull/38#issuecomment-272246582","issue_url":"https://api.github.com/repos/flywheelsports/fwsp-hydra/issues/38","id":272246582,"user":{"login":"cjus","id":387129,"avatar_url":"https://avatars.githubusercontent.com/u/387129?v=3","gravatar_id":"","url":"https://api.github.com/users/cjus","html_url":"https://github.com/cjus","followers_url":"https://api.github.com/users/cjus/followers","following_url":"https://api.github.com/users/cjus/following{/other_user}","gists_url":"https://api.github.com/users/cjus/gists{/gist_id}","starred_url":"https://api.github.com/users/cjus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjus/subscriptions","organizations_url":"https://api.github.com/users/cjus/orgs","repos_url":"https://api.github.com/users/cjus/repos","events_url":"https://api.github.com/users/cjus/events{/privacy}","received_events_url":"https://api.github.com/users/cjus/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T18:45:23Z","updated_at":"2017-01-12T18:45:23Z","body":"Looks good but this documentation section needs to be updated to document the new behavior. \r\nhttps://github.com/flywheelsports/fwsp-hydra/blob/master/documentation.md#initialization"}}
{"actor":{"display_login":"cjus"}}