{"action":"created","comment":{"url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/comments/155757882","pull_request_review_id":82131243,"id":155757882,"diff_hunk":"@@ -233,9 +274,22 @@ class SearchBox extends Component {\n             {...searchInputEvents}\n             {...cx('input')}\n           />\n+          {this.props.showLoadingIndicator && (\n+            <div\n+              style={{\n+                display: isSearchStalled ? 'block' : 'none',\n+              }}\n+              {...cx('loading-indicator')}\n+            >\n+              {loadingIndicatorComponent}\n+            </div>\n+          )}","path":"packages/react-instantsearch/src/components/SearchBox.js","position":134,"original_position":134,"commit_id":"a14ed1a43f83fa90e61a09bf3751f651992506f9","original_commit_id":"a14ed1a43f83fa90e61a09bf3751f651992506f9","user":{"login":"samouss","id":6513513,"avatar_url":"https://avatars2.githubusercontent.com/u/6513513?v=4","gravatar_id":"","url":"https://api.github.com/users/samouss","html_url":"https://github.com/samouss","followers_url":"https://api.github.com/users/samouss/followers","following_url":"https://api.github.com/users/samouss/following{/other_user}","gists_url":"https://api.github.com/users/samouss/gists{/gist_id}","starred_url":"https://api.github.com/users/samouss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouss/subscriptions","organizations_url":"https://api.github.com/users/samouss/orgs","repos_url":"https://api.github.com/users/samouss/repos","events_url":"https://api.github.com/users/samouss/events{/privacy}","received_events_url":"https://api.github.com/users/samouss/received_events","type":"User","site_admin":false},"body":"We could add a test for this logic. Verify depending on the given props that the loading component is displayed or not (with a Snapshot).","created_at":"2017-12-08T11:31:26Z","updated_at":"2017-12-08T11:34:22Z","html_url":"https://github.com/algolia/react-instantsearch/pull/544#discussion_r155757882","pull_request_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/comments/155757882"},"html":{"href":"https://github.com/algolia/react-instantsearch/pull/544#discussion_r155757882"},"pull_request":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544"}}},"pull_request":{"url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544","id":149795581,"html_url":"https://github.com/algolia/react-instantsearch/pull/544","diff_url":"https://github.com/algolia/react-instantsearch/pull/544.diff","patch_url":"https://github.com/algolia/react-instantsearch/pull/544.patch","issue_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/544","number":544,"state":"open","locked":false,"title":"feat: loading indicator","user":{"login":"bobylito","id":393765,"avatar_url":"https://avatars3.githubusercontent.com/u/393765?v=4","gravatar_id":"","url":"https://api.github.com/users/bobylito","html_url":"https://github.com/bobylito","followers_url":"https://api.github.com/users/bobylito/followers","following_url":"https://api.github.com/users/bobylito/following{/other_user}","gists_url":"https://api.github.com/users/bobylito/gists{/gist_id}","starred_url":"https://api.github.com/users/bobylito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobylito/subscriptions","organizations_url":"https://api.github.com/users/bobylito/orgs","repos_url":"https://api.github.com/users/bobylito/repos","events_url":"https://api.github.com/users/bobylito/events{/privacy}","received_events_url":"https://api.github.com/users/bobylito/received_events","type":"User","site_admin":false},"body":"This PR adds a loading indicator based on the [proposal made here](https://github.com/algolia/instantsearch.js/issues/2315). However this version has changed a little:\r\n - the mechanics that determine if the search is stalled is implemented in the core of the library\r\n - there are options both on `<InstantSearch>` and `<SearchBox>`. The first one is for configuring the timer and the other is for displaying a loading indicator.\r\n\r\nThis is a POC implementation and the there is no design for the indicator (it's a red background) on purpose. Happy to discuss the API and the implementation.","created_at":"2017-10-31T14:08:02Z","updated_at":"2017-12-08T11:34:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeffb4fad7c4eae84510aa59f650e98c453d6893","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544/commits","review_comments_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544/comments","review_comment_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/544/comments","statuses_url":"https://api.github.com/repos/algolia/react-instantsearch/statuses/a14ed1a43f83fa90e61a09bf3751f651992506f9","head":{"label":"algolia:feat/searchbox-loading-indicator","ref":"feat/searchbox-loading-indicator","sha":"a14ed1a43f83fa90e61a09bf3751f651992506f9","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":87180009,"name":"react-instantsearch","full_name":"algolia/react-instantsearch","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/react-instantsearch","description":"⚡ Lightning-fast search for React and React Native apps, by Algolia.","fork":false,"url":"https://api.github.com/repos/algolia/react-instantsearch","forks_url":"https://api.github.com/repos/algolia/react-instantsearch/forks","keys_url":"https://api.github.com/repos/algolia/react-instantsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/react-instantsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/react-instantsearch/teams","hooks_url":"https://api.github.com/repos/algolia/react-instantsearch/hooks","issue_events_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/react-instantsearch/events","assignees_url":"https://api.github.com/repos/algolia/react-instantsearch/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/react-instantsearch/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/react-instantsearch/tags","blobs_url":"https://api.github.com/repos/algolia/react-instantsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/react-instantsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/react-instantsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/react-instantsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/react-instantsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/react-instantsearch/languages","stargazers_url":"https://api.github.com/repos/algolia/react-instantsearch/stargazers","contributors_url":"https://api.github.com/repos/algolia/react-instantsearch/contributors","subscribers_url":"https://api.github.com/repos/algolia/react-instantsearch/subscribers","subscription_url":"https://api.github.com/repos/algolia/react-instantsearch/subscription","commits_url":"https://api.github.com/repos/algolia/react-instantsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/react-instantsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/react-instantsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/react-instantsearch/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/react-instantsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/react-instantsearch/merges","archive_url":"https://api.github.com/repos/algolia/react-instantsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/react-instantsearch/downloads","issues_url":"https://api.github.com/repos/algolia/react-instantsearch/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/react-instantsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/react-instantsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/react-instantsearch/labels{/name}","releases_url":"https://api.github.com/repos/algolia/react-instantsearch/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/react-instantsearch/deployments","created_at":"2017-04-04T11:45:29Z","updated_at":"2017-12-08T00:21:06Z","pushed_at":"2017-12-08T10:03:03Z","git_url":"git://github.com/algolia/react-instantsearch.git","ssh_url":"git@github.com:algolia/react-instantsearch.git","clone_url":"https://github.com/algolia/react-instantsearch.git","svn_url":"https://github.com/algolia/react-instantsearch","homepage":"https://community.algolia.com/react-instantsearch","size":57035,"stargazers_count":302,"watchers_count":302,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":58,"open_issues":77,"watchers":302,"default_branch":"master"}},"base":{"label":"algolia:master","ref":"master","sha":"746e362d936c5c0d5a79e2320e085b7b49855256","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":87180009,"name":"react-instantsearch","full_name":"algolia/react-instantsearch","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/react-instantsearch","description":"⚡ Lightning-fast search for React and React Native apps, by Algolia.","fork":false,"url":"https://api.github.com/repos/algolia/react-instantsearch","forks_url":"https://api.github.com/repos/algolia/react-instantsearch/forks","keys_url":"https://api.github.com/repos/algolia/react-instantsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/react-instantsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/react-instantsearch/teams","hooks_url":"https://api.github.com/repos/algolia/react-instantsearch/hooks","issue_events_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/react-instantsearch/events","assignees_url":"https://api.github.com/repos/algolia/react-instantsearch/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/react-instantsearch/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/react-instantsearch/tags","blobs_url":"https://api.github.com/repos/algolia/react-instantsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/react-instantsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/react-instantsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/react-instantsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/react-instantsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/react-instantsearch/languages","stargazers_url":"https://api.github.com/repos/algolia/react-instantsearch/stargazers","contributors_url":"https://api.github.com/repos/algolia/react-instantsearch/contributors","subscribers_url":"https://api.github.com/repos/algolia/react-instantsearch/subscribers","subscription_url":"https://api.github.com/repos/algolia/react-instantsearch/subscription","commits_url":"https://api.github.com/repos/algolia/react-instantsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/react-instantsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/react-instantsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/react-instantsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/react-instantsearch/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/react-instantsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/react-instantsearch/merges","archive_url":"https://api.github.com/repos/algolia/react-instantsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/react-instantsearch/downloads","issues_url":"https://api.github.com/repos/algolia/react-instantsearch/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/react-instantsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/react-instantsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/react-instantsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/react-instantsearch/labels{/name}","releases_url":"https://api.github.com/repos/algolia/react-instantsearch/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/react-instantsearch/deployments","created_at":"2017-04-04T11:45:29Z","updated_at":"2017-12-08T00:21:06Z","pushed_at":"2017-12-08T10:03:03Z","git_url":"git://github.com/algolia/react-instantsearch.git","ssh_url":"git@github.com:algolia/react-instantsearch.git","clone_url":"https://github.com/algolia/react-instantsearch.git","svn_url":"https://github.com/algolia/react-instantsearch","homepage":"https://community.algolia.com/react-instantsearch","size":57035,"stargazers_count":302,"watchers_count":302,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":58,"open_issues":77,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544"},"html":{"href":"https://github.com/algolia/react-instantsearch/pull/544"},"issue":{"href":"https://api.github.com/repos/algolia/react-instantsearch/issues/544"},"comments":{"href":"https://api.github.com/repos/algolia/react-instantsearch/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/react-instantsearch/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/react-instantsearch/statuses/a14ed1a43f83fa90e61a09bf3751f651992506f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"samouss"}}