{"action":"opened","number":83,"pull_request":{"url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83","id":132883560,"html_url":"https://github.com/ActsAsParanoid/acts_as_paranoid/pull/83","diff_url":"https://github.com/ActsAsParanoid/acts_as_paranoid/pull/83.diff","patch_url":"https://github.com/ActsAsParanoid/acts_as_paranoid/pull/83.patch","issue_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/83","number":83,"state":"open","locked":false,"title":"Rails 5 test fix","user":{"login":"patientdev","id":7495328,"avatar_url":"https://avatars2.githubusercontent.com/u/7495328?v=4","gravatar_id":"","url":"https://api.github.com/users/patientdev","html_url":"https://github.com/patientdev","followers_url":"https://api.github.com/users/patientdev/followers","following_url":"https://api.github.com/users/patientdev/following{/other_user}","gists_url":"https://api.github.com/users/patientdev/gists{/gist_id}","starred_url":"https://api.github.com/users/patientdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patientdev/subscriptions","organizations_url":"https://api.github.com/users/patientdev/orgs","repos_url":"https://api.github.com/users/patientdev/repos","events_url":"https://api.github.com/users/patientdev/events{/privacy}","received_events_url":"https://api.github.com/users/patientdev/received_events","type":"User","site_admin":false},"body":"I'd like some guidance on this if possible. The tests are passing, but I have limited understanding of why these changes work and why the offending code was there in the first place. This PR fixes two issues with `validate_each`:\r\n\r\n1. `type_case_for_schema` for a string simply calls `.inspect ` which returns a string _with_ quotation marks. So `build_relation` didn't find the similarly named record.\r\n\r\n1. Once that was sorted, `relation.where(finder_class.paranoid_default_scope).where(relation).exists?` returned `ArgumentError: Unsupported argument type`. Moving `relation` to be an argument on `exists?` fixed that.\r\n\r\nThe test for `rails_edge` isn't working because `bundle install` is failing. `activerecord 5.2.0alpha` is looking for `areal 9.0.0.alpha` which hasn't been released yet.","created_at":"2017-07-28T02:34:41Z","updated_at":"2017-07-28T02:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83/commits","review_comments_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83/comments","review_comment_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/83/comments","statuses_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/statuses/16b2df9973b71fe88418d81ed3e632624ec6c8ba","head":{"label":"patientdev:rails_5_test_fix","ref":"rails_5_test_fix","sha":"16b2df9973b71fe88418d81ed3e632624ec6c8ba","user":{"login":"patientdev","id":7495328,"avatar_url":"https://avatars2.githubusercontent.com/u/7495328?v=4","gravatar_id":"","url":"https://api.github.com/users/patientdev","html_url":"https://github.com/patientdev","followers_url":"https://api.github.com/users/patientdev/followers","following_url":"https://api.github.com/users/patientdev/following{/other_user}","gists_url":"https://api.github.com/users/patientdev/gists{/gist_id}","starred_url":"https://api.github.com/users/patientdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patientdev/subscriptions","organizations_url":"https://api.github.com/users/patientdev/orgs","repos_url":"https://api.github.com/users/patientdev/repos","events_url":"https://api.github.com/users/patientdev/events{/privacy}","received_events_url":"https://api.github.com/users/patientdev/received_events","type":"User","site_admin":false},"repo":{"id":98598843,"name":"acts_as_paranoid","full_name":"patientdev/acts_as_paranoid","owner":{"login":"patientdev","id":7495328,"avatar_url":"https://avatars2.githubusercontent.com/u/7495328?v=4","gravatar_id":"","url":"https://api.github.com/users/patientdev","html_url":"https://github.com/patientdev","followers_url":"https://api.github.com/users/patientdev/followers","following_url":"https://api.github.com/users/patientdev/following{/other_user}","gists_url":"https://api.github.com/users/patientdev/gists{/gist_id}","starred_url":"https://api.github.com/users/patientdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patientdev/subscriptions","organizations_url":"https://api.github.com/users/patientdev/orgs","repos_url":"https://api.github.com/users/patientdev/repos","events_url":"https://api.github.com/users/patientdev/events{/privacy}","received_events_url":"https://api.github.com/users/patientdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patientdev/acts_as_paranoid","description":"ActiveRecord plugin allowing you to hide and restore records without actually deleting them.","fork":true,"url":"https://api.github.com/repos/patientdev/acts_as_paranoid","forks_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/forks","keys_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/teams","hooks_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/hooks","issue_events_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/issues/events{/number}","events_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/events","assignees_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/assignees{/user}","branches_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/branches{/branch}","tags_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/tags","blobs_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/git/refs{/sha}","trees_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/statuses/{sha}","languages_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/languages","stargazers_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/stargazers","contributors_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/contributors","subscribers_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/subscribers","subscription_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/subscription","commits_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/commits{/sha}","git_commits_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/git/commits{/sha}","comments_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/comments{/number}","issue_comment_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/issues/comments{/number}","contents_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/contents/{+path}","compare_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/merges","archive_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/downloads","issues_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/issues{/number}","pulls_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/pulls{/number}","milestones_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/milestones{/number}","notifications_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/labels{/name}","releases_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/releases{/id}","deployments_url":"https://api.github.com/repos/patientdev/acts_as_paranoid/deployments","created_at":"2017-07-28T02:23:27Z","updated_at":"2017-07-28T02:23:29Z","pushed_at":"2017-07-28T02:23:53Z","git_url":"git://github.com/patientdev/acts_as_paranoid.git","ssh_url":"git@github.com:patientdev/acts_as_paranoid.git","clone_url":"https://github.com/patientdev/acts_as_paranoid.git","svn_url":"https://github.com/patientdev/acts_as_paranoid","homepage":"","size":299,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ActsAsParanoid:master","ref":"master","sha":"0d4af4e0b1bc7035a0b6be87237986ffbf6b3843","user":{"login":"ActsAsParanoid","id":8550547,"avatar_url":"https://avatars0.githubusercontent.com/u/8550547?v=4","gravatar_id":"","url":"https://api.github.com/users/ActsAsParanoid","html_url":"https://github.com/ActsAsParanoid","followers_url":"https://api.github.com/users/ActsAsParanoid/followers","following_url":"https://api.github.com/users/ActsAsParanoid/following{/other_user}","gists_url":"https://api.github.com/users/ActsAsParanoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ActsAsParanoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActsAsParanoid/subscriptions","organizations_url":"https://api.github.com/users/ActsAsParanoid/orgs","repos_url":"https://api.github.com/users/ActsAsParanoid/repos","events_url":"https://api.github.com/users/ActsAsParanoid/events{/privacy}","received_events_url":"https://api.github.com/users/ActsAsParanoid/received_events","type":"Organization","site_admin":false},"repo":{"id":2376,"name":"acts_as_paranoid","full_name":"ActsAsParanoid/acts_as_paranoid","owner":{"login":"ActsAsParanoid","id":8550547,"avatar_url":"https://avatars0.githubusercontent.com/u/8550547?v=4","gravatar_id":"","url":"https://api.github.com/users/ActsAsParanoid","html_url":"https://github.com/ActsAsParanoid","followers_url":"https://api.github.com/users/ActsAsParanoid/followers","following_url":"https://api.github.com/users/ActsAsParanoid/following{/other_user}","gists_url":"https://api.github.com/users/ActsAsParanoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ActsAsParanoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActsAsParanoid/subscriptions","organizations_url":"https://api.github.com/users/ActsAsParanoid/orgs","repos_url":"https://api.github.com/users/ActsAsParanoid/repos","events_url":"https://api.github.com/users/ActsAsParanoid/events{/privacy}","received_events_url":"https://api.github.com/users/ActsAsParanoid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ActsAsParanoid/acts_as_paranoid","description":"ActiveRecord plugin allowing you to hide and restore records without actually deleting them.","fork":false,"url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid","forks_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/forks","keys_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/teams","hooks_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/hooks","issue_events_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/events{/number}","events_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/events","assignees_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/assignees{/user}","branches_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/branches{/branch}","tags_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/tags","blobs_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/statuses/{sha}","languages_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/languages","stargazers_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/stargazers","contributors_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/contributors","subscribers_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/subscribers","subscription_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/subscription","commits_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/contents/{+path}","compare_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/merges","archive_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/downloads","issues_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues{/number}","pulls_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls{/number}","milestones_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/milestones{/number}","notifications_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/labels{/name}","releases_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/releases{/id}","deployments_url":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/deployments","created_at":"2008-03-04T04:48:18Z","updated_at":"2017-07-27T13:30:46Z","pushed_at":"2017-05-10T13:15:47Z","git_url":"git://github.com/ActsAsParanoid/acts_as_paranoid.git","ssh_url":"git@github.com:ActsAsParanoid/acts_as_paranoid.git","clone_url":"https://github.com/ActsAsParanoid/acts_as_paranoid.git","svn_url":"https://github.com/ActsAsParanoid/acts_as_paranoid","homepage":"","size":299,"stargazers_count":871,"watchers_count":871,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":23,"forks":147,"open_issues":23,"watchers":871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83"},"html":{"href":"https://github.com/ActsAsParanoid/acts_as_paranoid/pull/83"},"issue":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/83"},"comments":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/ActsAsParanoid/acts_as_paranoid/statuses/16b2df9973b71fe88418d81ed3e632624ec6c8ba"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":19,"deletions":22,"changed_files":4}}
{"actor":{"display_login":"patientdev"}}