{"action":"created","comment":{"url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/comments/99246846","pull_request_review_id":19918594,"id":99246846,"diff_hunk":"@@ -26,30 +26,70 @@ namespace Serilog\n     public static class LoggerConfigurationSignalRExtensions\n     {\n         /// <summary>\n-        /// Adds a sink that writes log events as documents to a SignalR hub. \n+        /// Adds a sink that writes log events as documents to a SignalR server. \n         /// </summary>\n         /// <param name=\"loggerConfiguration\">The logger configuration.</param>\n         /// <param name=\"context\">The hub context.</param>\n         /// <param name=\"restrictedToMinimumLevel\">The minimum log event level required in order to write an event to the sink.</param>\n         /// <param name=\"batchPostingLimit\">The maximum number of events to post in a single batch.</param>\n         /// <param name=\"period\">The time to wait between checking for event batches.</param>\n         /// <param name=\"formatProvider\">Supplies culture-specific formatting information, or null.</param>\n+        /// <param name=\"groupNames\">Names of the Signalr groups you are broadcasting the log event to. Default is All Groups.</param>\n+        /// <param name=\"userIds\">ID's of the Signalr Users you are broadcasting the log event to. Default is All Users.</param>\n+        /// <param name=\"excludedConnectionIds\">Signalr connection ID's to exclude from broadcast.</param>\n         /// <returns>Logger configuration, allowing configuration to continue.</returns>\n         /// <exception cref=\"ArgumentNullException\">A required parameter is null.</exception>\n-        public static LoggerConfiguration SignalR(\n+        public static LoggerConfiguration SignalRServer(","path":"src/Serilog.Sinks.SignalR/LoggerConfigurationSignalRExtensions.cs","position":19,"original_position":19,"commit_id":"57a3fcc88f85c6e897a078a7a1863709ebcf9ab0","original_commit_id":"57a3fcc88f85c6e897a078a7a1863709ebcf9ab0","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"Ha :-) Yes, I think that might be as good as it gets... Sorry about the mix-up!","created_at":"2017-02-02T23:32:44Z","updated_at":"2017-02-02T23:32:44Z","html_url":"https://github.com/serilog/serilog-sinks-signalr/pull/2#discussion_r99246846","pull_request_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/comments/99246846"},"html":{"href":"https://github.com/serilog/serilog-sinks-signalr/pull/2#discussion_r99246846"},"pull_request":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2","id":103949458,"html_url":"https://github.com/serilog/serilog-sinks-signalr/pull/2","diff_url":"https://github.com/serilog/serilog-sinks-signalr/pull/2.diff","patch_url":"https://github.com/serilog/serilog-sinks-signalr/pull/2.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/2","number":2,"state":"open","locked":false,"title":"Groups and Users support. V2 Upgrade","user":{"login":"sirkirby","id":740137,"avatar_url":"https://avatars.githubusercontent.com/u/740137?v=3","gravatar_id":"","url":"https://api.github.com/users/sirkirby","html_url":"https://github.com/sirkirby","followers_url":"https://api.github.com/users/sirkirby/followers","following_url":"https://api.github.com/users/sirkirby/following{/other_user}","gists_url":"https://api.github.com/users/sirkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/sirkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirkirby/subscriptions","organizations_url":"https://api.github.com/users/sirkirby/orgs","repos_url":"https://api.github.com/users/sirkirby/repos","events_url":"https://api.github.com/users/sirkirby/events{/privacy}","received_events_url":"https://api.github.com/users/sirkirby/received_events","type":"User","site_admin":false},"body":"* added group name and excluded connection support\r\n* updated to latest version of serilog and signalr\r\n* added support for multiple groups and users\r\n* added support for a proxy based sink\r\n* new extension method for creating the client sink\r\n* new sink which accepts the uri, hubname, groups and users args to create a client connection which enables logging from other applications.\r\n* added usage documentation to the readme","created_at":"2017-01-31T14:45:21Z","updated_at":"2017-02-02T23:32:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fe221b3a86f6c026180f350d17aa592636f726f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/2/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/statuses/57a3fcc88f85c6e897a078a7a1863709ebcf9ab0","head":{"label":"Authenticom:master","ref":"master","sha":"57a3fcc88f85c6e897a078a7a1863709ebcf9ab0","user":{"login":"Authenticom","id":10658689,"avatar_url":"https://avatars.githubusercontent.com/u/10658689?v=3","gravatar_id":"","url":"https://api.github.com/users/Authenticom","html_url":"https://github.com/Authenticom","followers_url":"https://api.github.com/users/Authenticom/followers","following_url":"https://api.github.com/users/Authenticom/following{/other_user}","gists_url":"https://api.github.com/users/Authenticom/gists{/gist_id}","starred_url":"https://api.github.com/users/Authenticom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Authenticom/subscriptions","organizations_url":"https://api.github.com/users/Authenticom/orgs","repos_url":"https://api.github.com/users/Authenticom/repos","events_url":"https://api.github.com/users/Authenticom/events{/privacy}","received_events_url":"https://api.github.com/users/Authenticom/received_events","type":"Organization","site_admin":false},"repo":{"id":80066590,"name":"serilog-sinks-signalr","full_name":"Authenticom/serilog-sinks-signalr","owner":{"login":"Authenticom","id":10658689,"avatar_url":"https://avatars.githubusercontent.com/u/10658689?v=3","gravatar_id":"","url":"https://api.github.com/users/Authenticom","html_url":"https://github.com/Authenticom","followers_url":"https://api.github.com/users/Authenticom/followers","following_url":"https://api.github.com/users/Authenticom/following{/other_user}","gists_url":"https://api.github.com/users/Authenticom/gists{/gist_id}","starred_url":"https://api.github.com/users/Authenticom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Authenticom/subscriptions","organizations_url":"https://api.github.com/users/Authenticom/orgs","repos_url":"https://api.github.com/users/Authenticom/repos","events_url":"https://api.github.com/users/Authenticom/events{/privacy}","received_events_url":"https://api.github.com/users/Authenticom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Authenticom/serilog-sinks-signalr","description":"A Serilog sink that writes events to SignalR","fork":true,"url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr","forks_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/forks","keys_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/teams","hooks_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/hooks","issue_events_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/issues/events{/number}","events_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/events","assignees_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/assignees{/user}","branches_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/branches{/branch}","tags_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/tags","blobs_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/statuses/{sha}","languages_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/languages","stargazers_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/stargazers","contributors_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/contributors","subscribers_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/subscribers","subscription_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/subscription","commits_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/contents/{+path}","compare_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/merges","archive_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/downloads","issues_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/issues{/number}","pulls_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/pulls{/number}","milestones_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/milestones{/number}","notifications_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/labels{/name}","releases_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/releases{/id}","deployments_url":"https://api.github.com/repos/Authenticom/serilog-sinks-signalr/deployments","created_at":"2017-01-25T23:00:18Z","updated_at":"2017-01-25T23:00:20Z","pushed_at":"2017-02-01T15:52:33Z","git_url":"git://github.com/Authenticom/serilog-sinks-signalr.git","ssh_url":"git@github.com:Authenticom/serilog-sinks-signalr.git","clone_url":"https://github.com/Authenticom/serilog-sinks-signalr.git","svn_url":"https://github.com/Authenticom/serilog-sinks-signalr","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serilog:master","ref":"master","sha":"6828d72220354d7c3e87ed3aa7efa860b6a3febe","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":31802022,"name":"serilog-sinks-signalr","full_name":"serilog/serilog-sinks-signalr","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-signalr","description":"A Serilog sink that writes events to SignalR","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-signalr","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-sinks-signalr/deployments","created_at":"2015-03-07T05:15:26Z","updated_at":"2016-09-09T21:13:23Z","pushed_at":"2017-02-01T15:52:34Z","git_url":"git://github.com/serilog/serilog-sinks-signalr.git","ssh_url":"git@github.com:serilog/serilog-sinks-signalr.git","clone_url":"https://github.com/serilog/serilog-sinks-signalr.git","svn_url":"https://github.com/serilog/serilog-sinks-signalr","homepage":null,"size":176,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2"},"html":{"href":"https://github.com/serilog/serilog-sinks-signalr/pull/2"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/2"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-signalr/statuses/57a3fcc88f85c6e897a078a7a1863709ebcf9ab0"}}}}
{"actor":{"display_login":"nblumhardt"}}