{"action":"created","comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/95562712","pull_request_review_id":16120279,"id":95562712,"diff_hunk":"@@ -10,7 +10,7 @@ import { homedir } from \"os\"\n import { statOrNull } from \"electron-builder-util/out/fs\"\n import isCi from \"is-ci\"\n \n-export const appleCertificatePrefixes = [\"Developer ID Application:\", \"Developer ID Installer:\", \"3rd Party Mac Developer Application:\", \"3rd Party Mac Developer Installer:\"]\n+export const appleCertificatePrefixes = [\"Developer ID Application:\", \"Developer ID Installer:\", \"3rd Party Mac Developer Application:\", \"3rd Party Mac Developer Installer:\", \"Mac Developer:\"]","path":"packages/electron-builder/src/codeSign.ts","position":5,"original_position":5,"commit_id":"0cded52e11268931c4adb7f7b04a39474b36e124","original_commit_id":"0cded52e11268931c4adb7f7b04a39474b36e124","user":{"login":"develar","id":350686,"avatar_url":"https://avatars.githubusercontent.com/u/350686?v=3","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"body":"Not necessary and can lead to major issues. ","created_at":"2017-01-11T11:44:20Z","updated_at":"2017-01-11T11:46:42Z","html_url":"https://github.com/electron-userland/electron-builder/pull/1103#discussion_r95562712","pull_request_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103","_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/95562712"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/1103#discussion_r95562712"},"pull_request":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103","id":101048020,"html_url":"https://github.com/electron-userland/electron-builder/pull/1103","diff_url":"https://github.com/electron-userland/electron-builder/pull/1103.diff","patch_url":"https://github.com/electron-userland/electron-builder/pull/1103.patch","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1103","number":1103,"state":"open","locked":false,"title":"fix(codeSign): signing with 'Mac Developer' failed","user":{"login":"ericzhangjx","id":11440841,"avatar_url":"https://avatars.githubusercontent.com/u/11440841?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzhangjx","html_url":"https://github.com/ericzhangjx","followers_url":"https://api.github.com/users/ericzhangjx/followers","following_url":"https://api.github.com/users/ericzhangjx/following{/other_user}","gists_url":"https://api.github.com/users/ericzhangjx/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzhangjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzhangjx/subscriptions","organizations_url":"https://api.github.com/users/ericzhangjx/orgs","repos_url":"https://api.github.com/users/ericzhangjx/repos","events_url":"https://api.github.com/users/ericzhangjx/events{/privacy}","received_events_url":"https://api.github.com/users/ericzhangjx/received_events","type":"User","site_admin":false},"body":"Removed codes of throwing exceptions inside `findIdentity()`, and let the `sign()` in `macPackager.ts` itself handle the returned value of `findIdentity()` (which should be string|null) and then try to sign with certType==='Mac Developer' before exporting unsigned application;","created_at":"2017-01-11T11:23:34Z","updated_at":"2017-01-11T11:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76bda718ababd8bebfeae7246c1410ad17f2c01e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1103/comments","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/0cded52e11268931c4adb7f7b04a39474b36e124","head":{"label":"ericzhangjx:patch-1","ref":"patch-1","sha":"0cded52e11268931c4adb7f7b04a39474b36e124","user":{"login":"ericzhangjx","id":11440841,"avatar_url":"https://avatars.githubusercontent.com/u/11440841?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzhangjx","html_url":"https://github.com/ericzhangjx","followers_url":"https://api.github.com/users/ericzhangjx/followers","following_url":"https://api.github.com/users/ericzhangjx/following{/other_user}","gists_url":"https://api.github.com/users/ericzhangjx/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzhangjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzhangjx/subscriptions","organizations_url":"https://api.github.com/users/ericzhangjx/orgs","repos_url":"https://api.github.com/users/ericzhangjx/repos","events_url":"https://api.github.com/users/ericzhangjx/events{/privacy}","received_events_url":"https://api.github.com/users/ericzhangjx/received_events","type":"User","site_admin":false},"repo":{"id":78631124,"name":"electron-builder","full_name":"ericzhangjx/electron-builder","owner":{"login":"ericzhangjx","id":11440841,"avatar_url":"https://avatars.githubusercontent.com/u/11440841?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzhangjx","html_url":"https://github.com/ericzhangjx","followers_url":"https://api.github.com/users/ericzhangjx/followers","following_url":"https://api.github.com/users/ericzhangjx/following{/other_user}","gists_url":"https://api.github.com/users/ericzhangjx/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzhangjx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzhangjx/subscriptions","organizations_url":"https://api.github.com/users/ericzhangjx/orgs","repos_url":"https://api.github.com/users/ericzhangjx/repos","events_url":"https://api.github.com/users/ericzhangjx/events{/privacy}","received_events_url":"https://api.github.com/users/ericzhangjx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericzhangjx/electron-builder","description":"A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box","fork":true,"url":"https://api.github.com/repos/ericzhangjx/electron-builder","forks_url":"https://api.github.com/repos/ericzhangjx/electron-builder/forks","keys_url":"https://api.github.com/repos/ericzhangjx/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericzhangjx/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericzhangjx/electron-builder/teams","hooks_url":"https://api.github.com/repos/ericzhangjx/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/ericzhangjx/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/ericzhangjx/electron-builder/events","assignees_url":"https://api.github.com/repos/ericzhangjx/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/ericzhangjx/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/ericzhangjx/electron-builder/tags","blobs_url":"https://api.github.com/repos/ericzhangjx/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericzhangjx/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericzhangjx/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericzhangjx/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericzhangjx/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/ericzhangjx/electron-builder/languages","stargazers_url":"https://api.github.com/repos/ericzhangjx/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/ericzhangjx/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/ericzhangjx/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/ericzhangjx/electron-builder/subscription","commits_url":"https://api.github.com/repos/ericzhangjx/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericzhangjx/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericzhangjx/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericzhangjx/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericzhangjx/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/ericzhangjx/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericzhangjx/electron-builder/merges","archive_url":"https://api.github.com/repos/ericzhangjx/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericzhangjx/electron-builder/downloads","issues_url":"https://api.github.com/repos/ericzhangjx/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/ericzhangjx/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/ericzhangjx/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/ericzhangjx/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericzhangjx/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/ericzhangjx/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/ericzhangjx/electron-builder/deployments","created_at":"2017-01-11T11:08:12Z","updated_at":"2017-01-11T11:08:16Z","pushed_at":"2017-01-11T11:12:23Z","git_url":"git://github.com/ericzhangjx/electron-builder.git","ssh_url":"git@github.com:ericzhangjx/electron-builder.git","clone_url":"https://github.com/ericzhangjx/electron-builder.git","svn_url":"https://github.com/ericzhangjx/electron-builder","homepage":"","size":108334,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron-userland:master","ref":"master","sha":"bb8081c2d36db728eebab9f5bf5e9f0ce723f05d","user":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"repo":{"id":35998691,"name":"electron-builder","full_name":"electron-userland/electron-builder","owner":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron-userland/electron-builder","description":"A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box","fork":false,"url":"https://api.github.com/repos/electron-userland/electron-builder","forks_url":"https://api.github.com/repos/electron-userland/electron-builder/forks","keys_url":"https://api.github.com/repos/electron-userland/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron-userland/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron-userland/electron-builder/teams","hooks_url":"https://api.github.com/repos/electron-userland/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/electron-userland/electron-builder/events","assignees_url":"https://api.github.com/repos/electron-userland/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/electron-userland/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/electron-userland/electron-builder/tags","blobs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron-userland/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron-userland/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/electron-userland/electron-builder/languages","stargazers_url":"https://api.github.com/repos/electron-userland/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/electron-userland/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/electron-userland/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/electron-userland/electron-builder/subscription","commits_url":"https://api.github.com/repos/electron-userland/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron-userland/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron-userland/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/electron-userland/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron-userland/electron-builder/merges","archive_url":"https://api.github.com/repos/electron-userland/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron-userland/electron-builder/downloads","issues_url":"https://api.github.com/repos/electron-userland/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/electron-userland/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/electron-userland/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/electron-userland/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/electron-userland/electron-builder/deployments","created_at":"2015-05-21T07:45:02Z","updated_at":"2017-01-11T10:59:34Z","pushed_at":"2017-01-11T11:23:35Z","git_url":"git://github.com/electron-userland/electron-builder.git","ssh_url":"git@github.com:electron-userland/electron-builder.git","clone_url":"https://github.com/electron-userland/electron-builder.git","svn_url":"https://github.com/electron-userland/electron-builder","homepage":"","size":108461,"stargazers_count":2012,"watchers_count":2012,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":41,"forks":217,"open_issues":41,"watchers":2012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/1103"},"issue":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/1103"},"comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/electron-userland/electron-builder/statuses/0cded52e11268931c4adb7f7b04a39474b36e124"}}}}
{"actor":{"display_login":"develar"}}