{"action":"created","issue":{"url":"https://api.github.com/repos/danielpclark/faster_path/issues/129","repository_url":"https://api.github.com/repos/danielpclark/faster_path","labels_url":"https://api.github.com/repos/danielpclark/faster_path/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/danielpclark/faster_path/issues/129/comments","events_url":"https://api.github.com/repos/danielpclark/faster_path/issues/129/events","html_url":"https://github.com/danielpclark/faster_path/issues/129","id":281589234,"number":129,"title":"Refactor unsafe blocks","user":{"login":"danielpclark","id":319081,"avatar_url":"https://avatars1.githubusercontent.com/u/319081?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpclark","html_url":"https://github.com/danielpclark","followers_url":"https://api.github.com/users/danielpclark/followers","following_url":"https://api.github.com/users/danielpclark/following{/other_user}","gists_url":"https://api.github.com/users/danielpclark/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpclark/subscriptions","organizations_url":"https://api.github.com/users/danielpclark/orgs","repos_url":"https://api.github.com/users/danielpclark/repos","events_url":"https://api.github.com/users/danielpclark/events{/privacy}","received_events_url":"https://api.github.com/users/danielpclark/received_events","type":"User","site_admin":false},"labels":[{"id":390103203,"url":"https://api.github.com/repos/danielpclark/faster_path/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":390103204,"url":"https://api.github.com/repos/danielpclark/faster_path/labels/help%20welcome","name":"help welcome","color":"128A0C","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-13T00:56:01Z","updated_at":"2017-12-14T06:28:10Z","closed_at":null,"author_association":"OWNER","body":"> The `unsafe` blocks are a bit worrisome, it does not inspire confidence, after all, the idea to use Rust instead of C is that it can ensure memory management safety.\r\n>\r\n>Saying that(without a suggestion probably would of not mentioned it), I offer a suggestion: https://docs.rs/memchr/2/memchr/fn.memrchr.html (this is also used by ripgrep, also, perf benchmarks: https://github.com/BurntSushi/rust-memchr#performance  — Lilian A. Moraru "},"comment":{"url":"https://api.github.com/repos/danielpclark/faster_path/issues/comments/351620817","html_url":"https://github.com/danielpclark/faster_path/issues/129#issuecomment-351620817","issue_url":"https://api.github.com/repos/danielpclark/faster_path/issues/129","id":351620817,"user":{"login":"danielpclark","id":319081,"avatar_url":"https://avatars1.githubusercontent.com/u/319081?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpclark","html_url":"https://github.com/danielpclark","followers_url":"https://api.github.com/users/danielpclark/followers","following_url":"https://api.github.com/users/danielpclark/following{/other_user}","gists_url":"https://api.github.com/users/danielpclark/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpclark/subscriptions","organizations_url":"https://api.github.com/users/danielpclark/orgs","repos_url":"https://api.github.com/users/danielpclark/repos","events_url":"https://api.github.com/users/danielpclark/events{/privacy}","received_events_url":"https://api.github.com/users/danielpclark/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T06:28:10Z","updated_at":"2017-12-14T06:28:10Z","author_association":"OWNER","body":"@glebm Only one unsafe left https://github.com/danielpclark/faster_path/blob/0d74190590e40ba3e380742d3c17865913ba8ccf/src/path_parsing.rs#L28  Do you think this is a good candidate for refactoring with memchr/memrchr?"}}
{"actor":{"display_login":"danielpclark"}}