{"action":"created","issue":{"url":"https://api.github.com/repos/lammps/lammps/issues/741","repository_url":"https://api.github.com/repos/lammps/lammps","labels_url":"https://api.github.com/repos/lammps/lammps/issues/741/labels{/name}","comments_url":"https://api.github.com/repos/lammps/lammps/issues/741/comments","events_url":"https://api.github.com/repos/lammps/lammps/issues/741/events","html_url":"https://github.com/lammps/lammps/pull/741","id":278538209,"number":741,"title":"Reduce Kokkos compile dependencies","user":{"login":"stanmoore1","id":18146301,"avatar_url":"https://avatars2.githubusercontent.com/u/18146301?v=4","gravatar_id":"","url":"https://api.github.com/users/stanmoore1","html_url":"https://github.com/stanmoore1","followers_url":"https://api.github.com/users/stanmoore1/followers","following_url":"https://api.github.com/users/stanmoore1/following{/other_user}","gists_url":"https://api.github.com/users/stanmoore1/gists{/gist_id}","starred_url":"https://api.github.com/users/stanmoore1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanmoore1/subscriptions","organizations_url":"https://api.github.com/users/stanmoore1/orgs","repos_url":"https://api.github.com/users/stanmoore1/repos","events_url":"https://api.github.com/users/stanmoore1/events{/privacy}","received_events_url":"https://api.github.com/users/stanmoore1/received_events","type":"User","site_admin":false},"labels":[{"id":432621454,"url":"https://api.github.com/repos/lammps/lammps/labels/build_system","name":"build_system","color":"006b75","default":false},{"id":51423230,"url":"https://api.github.com/repos/lammps/lammps/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":419661607,"url":"https://api.github.com/repos/lammps/lammps/labels/kokkos_package","name":"kokkos_package","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"stanmoore1","id":18146301,"avatar_url":"https://avatars2.githubusercontent.com/u/18146301?v=4","gravatar_id":"","url":"https://api.github.com/users/stanmoore1","html_url":"https://github.com/stanmoore1","followers_url":"https://api.github.com/users/stanmoore1/followers","following_url":"https://api.github.com/users/stanmoore1/following{/other_user}","gists_url":"https://api.github.com/users/stanmoore1/gists{/gist_id}","starred_url":"https://api.github.com/users/stanmoore1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanmoore1/subscriptions","organizations_url":"https://api.github.com/users/stanmoore1/orgs","repos_url":"https://api.github.com/users/stanmoore1/repos","events_url":"https://api.github.com/users/stanmoore1/events{/privacy}","received_events_url":"https://api.github.com/users/stanmoore1/received_events","type":"User","site_admin":false},"assignees":[{"login":"stanmoore1","id":18146301,"avatar_url":"https://avatars2.githubusercontent.com/u/18146301?v=4","gravatar_id":"","url":"https://api.github.com/users/stanmoore1","html_url":"https://github.com/stanmoore1","followers_url":"https://api.github.com/users/stanmoore1/followers","following_url":"https://api.github.com/users/stanmoore1/following{/other_user}","gists_url":"https://api.github.com/users/stanmoore1/gists{/gist_id}","starred_url":"https://api.github.com/users/stanmoore1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanmoore1/subscriptions","organizations_url":"https://api.github.com/users/stanmoore1/orgs","repos_url":"https://api.github.com/users/stanmoore1/repos","events_url":"https://api.github.com/users/stanmoore1/events{/privacy}","received_events_url":"https://api.github.com/users/stanmoore1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-12-01T17:26:18Z","updated_at":"2017-12-01T17:39:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lammps/lammps/pulls/741","html_url":"https://github.com/lammps/lammps/pull/741","diff_url":"https://github.com/lammps/lammps/pull/741.diff","patch_url":"https://github.com/lammps/lammps/pull/741.patch"},"body":"## Purpose\r\n\r\nFixes #148. Use multiple inheritance to remove `accelerator_kokkos.h` out of `pair.h`, `region.h`, and `kspace.h`. Also remove `memory_kokkos.h` out of `memory.h`. Now the `#ifdef LMP_KOKKOS` is only in `accelerator_kokkos.h`, and compile time is greatly reduced when the KOKKOS package is uninstalled. \r\n\r\n## Author(s)\r\n\r\nStan Moore\r\n\r\n## Backward Compatibility\r\n\r\nNo issues"},"comment":{"url":"https://api.github.com/repos/lammps/lammps/issues/comments/348559498","html_url":"https://github.com/lammps/lammps/pull/741#issuecomment-348559498","issue_url":"https://api.github.com/repos/lammps/lammps/issues/741","id":348559498,"user":{"login":"stanmoore1","id":18146301,"avatar_url":"https://avatars2.githubusercontent.com/u/18146301?v=4","gravatar_id":"","url":"https://api.github.com/users/stanmoore1","html_url":"https://github.com/stanmoore1","followers_url":"https://api.github.com/users/stanmoore1/followers","following_url":"https://api.github.com/users/stanmoore1/following{/other_user}","gists_url":"https://api.github.com/users/stanmoore1/gists{/gist_id}","starred_url":"https://api.github.com/users/stanmoore1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanmoore1/subscriptions","organizations_url":"https://api.github.com/users/stanmoore1/orgs","repos_url":"https://api.github.com/users/stanmoore1/repos","events_url":"https://api.github.com/users/stanmoore1/events{/privacy}","received_events_url":"https://api.github.com/users/stanmoore1/received_events","type":"User","site_admin":false},"created_at":"2017-12-01T17:39:47Z","updated_at":"2017-12-01T17:39:47Z","author_association":"CONTRIBUTOR","body":"I sort of opened a can of worms when I removed `accelerator_kokkos.h` out of those top level header files. There are lots of `#include` s missing that need to be added back in."}}
{"actor":{"display_login":"stanmoore1"}}