{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/19884","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19884/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19884/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19884/events","html_url":"https://github.com/cms-sw/cmssw/pull/19884","id":245131919,"number":19884,"title":"Fixing a BS Issue affecting the Egamma HLT","user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69","html_url":"https://github.com/cms-sw/cmssw/milestone/69","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69/labels","id":2604328,"number":69,"title":"CMSSW_9_3_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":120,"closed_issues":309,"state":"open","created_at":"2017-06-26T12:15:20Z","updated_at":"2017-07-28T05:48:18Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2017-07-24T16:12:29Z","updated_at":"2017-07-28T08:15:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19884","html_url":"https://github.com/cms-sw/cmssw/pull/19884","diff_url":"https://github.com/cms-sw/cmssw/pull/19884.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/19884.patch"},"body":"Dear All,\r\n\r\nThe online beamspot issues persist and this is impacting data taking efficiency for electrons. As such I have added more flexibility to the E/gamma code to deal with this. We now have various options available to us for tracking regions.\r\n\r\n1) use the primary vertex +/- X (existing)\r\n2) use the beamspot z +/-  N*sigmaZ  (the N being configurable is the new part, it was annoyingly hardcoded to 3\r\n3) use X+/-Y , eg 0 +/-20cm (my favoured solution however there are currently timing issues)\r\n4) use the beamspot z+/- N *sigmaZ where sigmaZ has a minimum allowed value, say 5cm\r\n\r\nThe TSG will decide which one we use, however having the options of all 4 are useful. \r\n\r\nWe really need this online as soon as possible as we are losing efficiency in electron triggers in a nasty way which is impossible to detect using t&p. \r\n\r\nThis code does not run at reco, it is HLT exclusive so far. It may well run in RECO in the future. \r\n\r\nValidation: \r\n\r\n- run on the DoubleEG dataset of 299480 (about a million events, also includes a triggers which do not use tracking)\r\n   - when used with an existing config, no changes to unprescaled paths are observed which is what I was testing\r\n- run on 100K Z->ee MC events (83X samples) with the online beamspot forced to have a too small deltaZ\r\n   -  the fixes successfully recovered the efficiency \r\n\r\nWill run over data as soon possible but this is more the TSG, the MC tests show the code is functioning as expected. \r\n\r\nPasses the scramv1 b run tests and runTheMatrix.py -l limited -i all\r\n\r\n@Martin-Grunewald \r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/318590828","html_url":"https://github.com/cms-sw/cmssw/pull/19884#issuecomment-318590828","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19884","id":318590828,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-07-28T08:15:01Z","updated_at":"2017-07-28T08:15:01Z","body":"+1\nTested at: ae3c2ea0b7bdf232c2031233b4557f59ac4e40c5\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19884/21844/summary.html\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/29a96fd9faa51bfd72d75319945a4ca549228bc2\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19884/21844/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19884/21844/git-merge-result\n"}}
{"actor":{"display_login":"cmsbuild"}}