{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10","id":138205783,"html_url":"https://github.com/jetstack-experimental/navigator/pull/10","diff_url":"https://github.com/jetstack-experimental/navigator/pull/10.diff","patch_url":"https://github.com/jetstack-experimental/navigator/pull/10.patch","issue_url":"https://api.github.com/repos/jetstack-experimental/navigator/issues/10","number":10,"state":"closed","locked":false,"title":"Use `dep` rather than `godep` for dependency management","user":{"login":"wallrj","id":978965,"avatar_url":"https://avatars3.githubusercontent.com/u/978965?v=4","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"body":"On running `dep` it converted the Godep.json file and pulled in a ton of missing vendor files.\r\n\r\nI'm not sure why? At a glance, it seems that godep may have only imported the `.go` files, while `dep` imports the entire working directory for each vendored project...including test fixtures etc.\r\n\r\nI'm also not sure why only logrus has been pinned in the `Gopkg.toml` file.\r\nIn https://gitlab.jetstack.net/marshal/navigator/blob/master/Godeps/Godeps.json there are a bunch of packages with a version specified in the comment attribute.\r\n\r\nhttps://gitlab.jetstack.net/marshal/navigator/issues/13","created_at":"2017-08-29T15:00:01Z","updated_at":"2017-08-31T09:02:59Z","closed_at":"2017-08-31T09:02:59Z","merged_at":"2017-08-31T09:02:59Z","merge_commit_sha":"390b5a6457a1e00b4f856e927e62ec0a9d048d1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack-experimental/navigator/issues/10/comments","statuses_url":"https://api.github.com/repos/jetstack-experimental/navigator/statuses/2bf799cc0c5cc50715cfdfa88430bb11a563fbba","head":{"label":"wallrj:13-dep-not-godep","ref":"13-dep-not-godep","sha":"2bf799cc0c5cc50715cfdfa88430bb11a563fbba","user":{"login":"wallrj","id":978965,"avatar_url":"https://avatars3.githubusercontent.com/u/978965?v=4","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"repo":{"id":101772590,"name":"navigator","full_name":"wallrj/navigator","owner":{"login":"wallrj","id":978965,"avatar_url":"https://avatars3.githubusercontent.com/u/978965?v=4","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wallrj/navigator","description":"Navigator - managed DBaaS on Kubernetes","fork":true,"url":"https://api.github.com/repos/wallrj/navigator","forks_url":"https://api.github.com/repos/wallrj/navigator/forks","keys_url":"https://api.github.com/repos/wallrj/navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallrj/navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallrj/navigator/teams","hooks_url":"https://api.github.com/repos/wallrj/navigator/hooks","issue_events_url":"https://api.github.com/repos/wallrj/navigator/issues/events{/number}","events_url":"https://api.github.com/repos/wallrj/navigator/events","assignees_url":"https://api.github.com/repos/wallrj/navigator/assignees{/user}","branches_url":"https://api.github.com/repos/wallrj/navigator/branches{/branch}","tags_url":"https://api.github.com/repos/wallrj/navigator/tags","blobs_url":"https://api.github.com/repos/wallrj/navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallrj/navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallrj/navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallrj/navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallrj/navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/wallrj/navigator/languages","stargazers_url":"https://api.github.com/repos/wallrj/navigator/stargazers","contributors_url":"https://api.github.com/repos/wallrj/navigator/contributors","subscribers_url":"https://api.github.com/repos/wallrj/navigator/subscribers","subscription_url":"https://api.github.com/repos/wallrj/navigator/subscription","commits_url":"https://api.github.com/repos/wallrj/navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallrj/navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallrj/navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallrj/navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallrj/navigator/contents/{+path}","compare_url":"https://api.github.com/repos/wallrj/navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallrj/navigator/merges","archive_url":"https://api.github.com/repos/wallrj/navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallrj/navigator/downloads","issues_url":"https://api.github.com/repos/wallrj/navigator/issues{/number}","pulls_url":"https://api.github.com/repos/wallrj/navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/wallrj/navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/wallrj/navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallrj/navigator/labels{/name}","releases_url":"https://api.github.com/repos/wallrj/navigator/releases{/id}","deployments_url":"https://api.github.com/repos/wallrj/navigator/deployments","created_at":"2017-08-29T14:48:12Z","updated_at":"2017-08-29T14:48:15Z","pushed_at":"2017-08-31T09:00:09Z","git_url":"git://github.com/wallrj/navigator.git","ssh_url":"git@github.com:wallrj/navigator.git","clone_url":"https://github.com/wallrj/navigator.git","svn_url":"https://github.com/wallrj/navigator","homepage":"","size":14668,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack-experimental:master","ref":"master","sha":"6be75ff01cbcf8b331feadc27bf513e92f8e2b0b","user":{"login":"jetstack-experimental","id":22496943,"avatar_url":"https://avatars1.githubusercontent.com/u/22496943?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-experimental","html_url":"https://github.com/jetstack-experimental","followers_url":"https://api.github.com/users/jetstack-experimental/followers","following_url":"https://api.github.com/users/jetstack-experimental/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-experimental/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-experimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-experimental/subscriptions","organizations_url":"https://api.github.com/users/jetstack-experimental/orgs","repos_url":"https://api.github.com/users/jetstack-experimental/repos","events_url":"https://api.github.com/users/jetstack-experimental/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-experimental/received_events","type":"Organization","site_admin":false},"repo":{"id":86671327,"name":"navigator","full_name":"jetstack-experimental/navigator","owner":{"login":"jetstack-experimental","id":22496943,"avatar_url":"https://avatars1.githubusercontent.com/u/22496943?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-experimental","html_url":"https://github.com/jetstack-experimental","followers_url":"https://api.github.com/users/jetstack-experimental/followers","following_url":"https://api.github.com/users/jetstack-experimental/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-experimental/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-experimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-experimental/subscriptions","organizations_url":"https://api.github.com/users/jetstack-experimental/orgs","repos_url":"https://api.github.com/users/jetstack-experimental/repos","events_url":"https://api.github.com/users/jetstack-experimental/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-experimental/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack-experimental/navigator","description":"Navigator - managed DBaaS on Kubernetes","fork":false,"url":"https://api.github.com/repos/jetstack-experimental/navigator","forks_url":"https://api.github.com/repos/jetstack-experimental/navigator/forks","keys_url":"https://api.github.com/repos/jetstack-experimental/navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack-experimental/navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack-experimental/navigator/teams","hooks_url":"https://api.github.com/repos/jetstack-experimental/navigator/hooks","issue_events_url":"https://api.github.com/repos/jetstack-experimental/navigator/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack-experimental/navigator/events","assignees_url":"https://api.github.com/repos/jetstack-experimental/navigator/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack-experimental/navigator/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack-experimental/navigator/tags","blobs_url":"https://api.github.com/repos/jetstack-experimental/navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack-experimental/navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack-experimental/navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack-experimental/navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack-experimental/navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack-experimental/navigator/languages","stargazers_url":"https://api.github.com/repos/jetstack-experimental/navigator/stargazers","contributors_url":"https://api.github.com/repos/jetstack-experimental/navigator/contributors","subscribers_url":"https://api.github.com/repos/jetstack-experimental/navigator/subscribers","subscription_url":"https://api.github.com/repos/jetstack-experimental/navigator/subscription","commits_url":"https://api.github.com/repos/jetstack-experimental/navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack-experimental/navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack-experimental/navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack-experimental/navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack-experimental/navigator/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack-experimental/navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack-experimental/navigator/merges","archive_url":"https://api.github.com/repos/jetstack-experimental/navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack-experimental/navigator/downloads","issues_url":"https://api.github.com/repos/jetstack-experimental/navigator/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack-experimental/navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack-experimental/navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack-experimental/navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack-experimental/navigator/labels{/name}","releases_url":"https://api.github.com/repos/jetstack-experimental/navigator/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack-experimental/navigator/deployments","created_at":"2017-03-30T07:15:57Z","updated_at":"2017-08-08T12:35:55Z","pushed_at":"2017-08-31T09:02:58Z","git_url":"git://github.com/jetstack-experimental/navigator.git","ssh_url":"git@github.com:jetstack-experimental/navigator.git","clone_url":"https://github.com/jetstack-experimental/navigator.git","svn_url":"https://github.com/jetstack-experimental/navigator","homepage":"","size":5206,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10"},"html":{"href":"https://github.com/jetstack-experimental/navigator/pull/10"},"issue":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/issues/10"},"comments":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack-experimental/navigator/statuses/2bf799cc0c5cc50715cfdfa88430bb11a563fbba"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wallrj","id":978965,"avatar_url":"https://avatars3.githubusercontent.com/u/978965?v=4","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1641924,"deletions":1212,"changed_files":3707}}
{"actor":{"display_login":"wallrj"}}