{"action":"closed","number":148,"pull_request":{"url":"https://api.github.com/repos/videojs/mux.js/pulls/148","id":114154575,"html_url":"https://github.com/videojs/mux.js/pull/148","diff_url":"https://github.com/videojs/mux.js/pull/148.diff","patch_url":"https://github.com/videojs/mux.js/pull/148.patch","issue_url":"https://api.github.com/repos/videojs/mux.js/issues/148","number":148,"state":"closed","locked":false,"title":"Update metadata-stream.js so TXXX are not clipped","user":{"login":"RevinKey","id":9756614,"avatar_url":"https://avatars3.githubusercontent.com/u/9756614?v=3","gravatar_id":"","url":"https://api.github.com/users/RevinKey","html_url":"https://github.com/RevinKey","followers_url":"https://api.github.com/users/RevinKey/followers","following_url":"https://api.github.com/users/RevinKey/following{/other_user}","gists_url":"https://api.github.com/users/RevinKey/gists{/gist_id}","starred_url":"https://api.github.com/users/RevinKey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RevinKey/subscriptions","organizations_url":"https://api.github.com/users/RevinKey/orgs","repos_url":"https://api.github.com/users/RevinKey/repos","events_url":"https://api.github.com/users/RevinKey/events{/privacy}","received_events_url":"https://api.github.com/users/RevinKey/received_events","type":"User","site_admin":false},"body":"## Description\r\nParsing of TXXX tag is cutting off last character of tag. \r\nDo not need to account for a null terminator.\r\n\r\n## Sample with Brightcove (videojs)player:\r\ncurrent: http://cs1.brightcodes.net/kreynolds/BrightcoveExamples/test/414473/current.html\r\nproposed: http://cs1.brightcodes.net/kreynolds/BrightcoveExamples/test/414473/index.html\r\n\r\n## Specific Changes proposed\r\nchange line48 in file metadata-stream.js to \r\n          tag.value = parseUtf8(tag.data, i + 1, tag.data.length).replace('\\0','');\r\n\r\n## Requirements Checklist\r\n- [ ] Feature implemented \r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [x] Example created ([starter template on JSBin](http://jsbin.com/axedog/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n","created_at":"2017-04-04T13:56:57Z","updated_at":"2017-04-10T16:03:05Z","closed_at":"2017-04-10T16:03:05Z","merged_at":null,"merge_commit_sha":"b8052292b378156287335b79bdf54c617e000152","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/mux.js/pulls/148/commits","review_comments_url":"https://api.github.com/repos/videojs/mux.js/pulls/148/comments","review_comment_url":"https://api.github.com/repos/videojs/mux.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/mux.js/issues/148/comments","statuses_url":"https://api.github.com/repos/videojs/mux.js/statuses/cc7eb6b0ecbb9cc7a3617420e5b7c8ea30398a90","head":{"label":"RevinKey:master","ref":"master","sha":"cc7eb6b0ecbb9cc7a3617420e5b7c8ea30398a90","user":{"login":"RevinKey","id":9756614,"avatar_url":"https://avatars3.githubusercontent.com/u/9756614?v=3","gravatar_id":"","url":"https://api.github.com/users/RevinKey","html_url":"https://github.com/RevinKey","followers_url":"https://api.github.com/users/RevinKey/followers","following_url":"https://api.github.com/users/RevinKey/following{/other_user}","gists_url":"https://api.github.com/users/RevinKey/gists{/gist_id}","starred_url":"https://api.github.com/users/RevinKey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RevinKey/subscriptions","organizations_url":"https://api.github.com/users/RevinKey/orgs","repos_url":"https://api.github.com/users/RevinKey/repos","events_url":"https://api.github.com/users/RevinKey/events{/privacy}","received_events_url":"https://api.github.com/users/RevinKey/received_events","type":"User","site_admin":false},"repo":{"id":87191428,"name":"mux.js","full_name":"RevinKey/mux.js","owner":{"login":"RevinKey","id":9756614,"avatar_url":"https://avatars3.githubusercontent.com/u/9756614?v=3","gravatar_id":"","url":"https://api.github.com/users/RevinKey","html_url":"https://github.com/RevinKey","followers_url":"https://api.github.com/users/RevinKey/followers","following_url":"https://api.github.com/users/RevinKey/following{/other_user}","gists_url":"https://api.github.com/users/RevinKey/gists{/gist_id}","starred_url":"https://api.github.com/users/RevinKey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RevinKey/subscriptions","organizations_url":"https://api.github.com/users/RevinKey/orgs","repos_url":"https://api.github.com/users/RevinKey/repos","events_url":"https://api.github.com/users/RevinKey/events{/privacy}","received_events_url":"https://api.github.com/users/RevinKey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RevinKey/mux.js","description":"Lightweight utilities for inspecting and manipulating video container formats.","fork":true,"url":"https://api.github.com/repos/RevinKey/mux.js","forks_url":"https://api.github.com/repos/RevinKey/mux.js/forks","keys_url":"https://api.github.com/repos/RevinKey/mux.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RevinKey/mux.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RevinKey/mux.js/teams","hooks_url":"https://api.github.com/repos/RevinKey/mux.js/hooks","issue_events_url":"https://api.github.com/repos/RevinKey/mux.js/issues/events{/number}","events_url":"https://api.github.com/repos/RevinKey/mux.js/events","assignees_url":"https://api.github.com/repos/RevinKey/mux.js/assignees{/user}","branches_url":"https://api.github.com/repos/RevinKey/mux.js/branches{/branch}","tags_url":"https://api.github.com/repos/RevinKey/mux.js/tags","blobs_url":"https://api.github.com/repos/RevinKey/mux.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RevinKey/mux.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RevinKey/mux.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/RevinKey/mux.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RevinKey/mux.js/statuses/{sha}","languages_url":"https://api.github.com/repos/RevinKey/mux.js/languages","stargazers_url":"https://api.github.com/repos/RevinKey/mux.js/stargazers","contributors_url":"https://api.github.com/repos/RevinKey/mux.js/contributors","subscribers_url":"https://api.github.com/repos/RevinKey/mux.js/subscribers","subscription_url":"https://api.github.com/repos/RevinKey/mux.js/subscription","commits_url":"https://api.github.com/repos/RevinKey/mux.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/RevinKey/mux.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/RevinKey/mux.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/RevinKey/mux.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/RevinKey/mux.js/contents/{+path}","compare_url":"https://api.github.com/repos/RevinKey/mux.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RevinKey/mux.js/merges","archive_url":"https://api.github.com/repos/RevinKey/mux.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RevinKey/mux.js/downloads","issues_url":"https://api.github.com/repos/RevinKey/mux.js/issues{/number}","pulls_url":"https://api.github.com/repos/RevinKey/mux.js/pulls{/number}","milestones_url":"https://api.github.com/repos/RevinKey/mux.js/milestones{/number}","notifications_url":"https://api.github.com/repos/RevinKey/mux.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RevinKey/mux.js/labels{/name}","releases_url":"https://api.github.com/repos/RevinKey/mux.js/releases{/id}","deployments_url":"https://api.github.com/repos/RevinKey/mux.js/deployments","created_at":"2017-04-04T13:41:28Z","updated_at":"2017-04-04T13:41:29Z","pushed_at":"2017-04-07T20:35:35Z","git_url":"git://github.com/RevinKey/mux.js.git","ssh_url":"git@github.com:RevinKey/mux.js.git","clone_url":"https://github.com/RevinKey/mux.js.git","svn_url":"https://github.com/RevinKey/mux.js","homepage":null,"size":4619,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"173a622c7059289c8b0ed3cd5e90f8a967942409","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars1.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":40461390,"name":"mux.js","full_name":"videojs/mux.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars1.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/mux.js","description":"Lightweight utilities for inspecting and manipulating video container formats.","fork":false,"url":"https://api.github.com/repos/videojs/mux.js","forks_url":"https://api.github.com/repos/videojs/mux.js/forks","keys_url":"https://api.github.com/repos/videojs/mux.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/mux.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/mux.js/teams","hooks_url":"https://api.github.com/repos/videojs/mux.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/mux.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/mux.js/events","assignees_url":"https://api.github.com/repos/videojs/mux.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/mux.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/mux.js/tags","blobs_url":"https://api.github.com/repos/videojs/mux.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/mux.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/mux.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/mux.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/mux.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/mux.js/languages","stargazers_url":"https://api.github.com/repos/videojs/mux.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/mux.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/mux.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/mux.js/subscription","commits_url":"https://api.github.com/repos/videojs/mux.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/mux.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/mux.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/mux.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/mux.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/mux.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/mux.js/merges","archive_url":"https://api.github.com/repos/videojs/mux.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/mux.js/downloads","issues_url":"https://api.github.com/repos/videojs/mux.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/mux.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/mux.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/mux.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/mux.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/mux.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/mux.js/deployments","created_at":"2015-08-10T03:31:07Z","updated_at":"2017-04-10T12:54:15Z","pushed_at":"2017-04-07T20:35:36Z","git_url":"git://github.com/videojs/mux.js.git","ssh_url":"git@github.com:videojs/mux.js.git","clone_url":"https://github.com/videojs/mux.js.git","svn_url":"https://github.com/videojs/mux.js","homepage":null,"size":4610,"stargazers_count":133,"watchers_count":133,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":18,"forks":50,"open_issues":18,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/148"},"html":{"href":"https://github.com/videojs/mux.js/pull/148"},"issue":{"href":"https://api.github.com/repos/videojs/mux.js/issues/148"},"comments":{"href":"https://api.github.com/repos/videojs/mux.js/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/mux.js/statuses/cc7eb6b0ecbb9cc7a3617420e5b7c8ea30398a90"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":2,"maintainer_can_modify":false,"commits":6,"additions":216,"deletions":216,"changed_files":1}}
{"actor":{"display_login":"RevinKey"}}