{"action":"created","comment":{"url":"https://api.github.com/repos/interledgerjs/ilp/pulls/comments/102468757","pull_request_review_id":23223823,"id":102468757,"diff_hunk":"@@ -118,11 +118,11 @@ describe('SPSP Module', function () {\n         .get('/spsp')\n         .reply(200, spspResponse)\n \n-      const payment = yield SPSP.quoteDestination(this.plugin, 'alice@example.com', '10')\n+      const payment = yield SPSP.quoteSource(this.plugin, 'alice@example.com', '12')\n       assert.deepEqual(payment, {\n         destinationAccount: \"example.alice\",\n         connectorAccount: \"example.connie\",\n-        sourceAmount: \"10\",\n+        sourceAmount: \"12\",","path":"test/spspSpec.js","position":26,"original_position":26,"commit_id":"18a8faad83ad894f2228e5485895259aa2dac972","original_commit_id":"0ec2867da89582a3d95134e4544c3cd1773c9853","user":{"login":"emschwartz","id":3262610,"avatar_url":"https://avatars.githubusercontent.com/u/3262610?v=3","gravatar_id":"","url":"https://api.github.com/users/emschwartz","html_url":"https://github.com/emschwartz","followers_url":"https://api.github.com/users/emschwartz/followers","following_url":"https://api.github.com/users/emschwartz/following{/other_user}","gists_url":"https://api.github.com/users/emschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/emschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emschwartz/subscriptions","organizations_url":"https://api.github.com/users/emschwartz/orgs","repos_url":"https://api.github.com/users/emschwartz/repos","events_url":"https://api.github.com/users/emschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/emschwartz/received_events","type":"User","site_admin":false},"body":"I got that, I'm just suggesting that in both cases you make the sourceAmount 12 and the destinationAmount 10 (or vice versa)","created_at":"2017-02-22T14:06:17Z","updated_at":"2017-02-22T14:06:17Z","html_url":"https://github.com/interledgerjs/ilp/pull/74#discussion_r102468757","pull_request_url":"https://api.github.com/repos/interledgerjs/ilp/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/comments/102468757"},"html":{"href":"https://github.com/interledgerjs/ilp/pull/74#discussion_r102468757"},"pull_request":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/interledgerjs/ilp/pulls/74","id":107403666,"html_url":"https://github.com/interledgerjs/ilp/pull/74","diff_url":"https://github.com/interledgerjs/ilp/pull/74.diff","patch_url":"https://github.com/interledgerjs/ilp/pull/74.patch","issue_url":"https://api.github.com/repos/interledgerjs/ilp/issues/74","number":74,"state":"open","locked":false,"title":"Fix: fix quoting logic and errors in spsp","user":{"login":"sharafian","id":3362563,"avatar_url":"https://avatars.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-22T13:10:48Z","updated_at":"2017-02-22T14:06:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87f4732c69877c708ad951dd628c68bc33ce5aea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledgerjs/ilp/pulls/74/commits","review_comments_url":"https://api.github.com/repos/interledgerjs/ilp/pulls/74/comments","review_comment_url":"https://api.github.com/repos/interledgerjs/ilp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledgerjs/ilp/issues/74/comments","statuses_url":"https://api.github.com/repos/interledgerjs/ilp/statuses/18a8faad83ad894f2228e5485895259aa2dac972","head":{"label":"interledgerjs:bs-fix-spsp","ref":"bs-fix-spsp","sha":"18a8faad83ad894f2228e5485895259aa2dac972","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":59520462,"name":"ilp","full_name":"interledgerjs/ilp","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp","description":"ILP client for browsers/Node.js","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp","forks_url":"https://api.github.com/repos/interledgerjs/ilp/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp/deployments","created_at":"2016-05-23T21:44:52Z","updated_at":"2017-02-21T13:09:03Z","pushed_at":"2017-02-22T13:29:12Z","git_url":"git://github.com/interledgerjs/ilp.git","ssh_url":"git@github.com:interledgerjs/ilp.git","clone_url":"https://github.com/interledgerjs/ilp.git","svn_url":"https://github.com/interledgerjs/ilp","homepage":null,"size":292,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":33,"default_branch":"master"}},"base":{"label":"interledgerjs:master","ref":"master","sha":"725f49c90806f889726345af5ed1aec3c7feb6f3","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":59520462,"name":"ilp","full_name":"interledgerjs/ilp","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp","description":"ILP client for browsers/Node.js","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp","forks_url":"https://api.github.com/repos/interledgerjs/ilp/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp/deployments","created_at":"2016-05-23T21:44:52Z","updated_at":"2017-02-21T13:09:03Z","pushed_at":"2017-02-22T13:29:12Z","git_url":"git://github.com/interledgerjs/ilp.git","ssh_url":"git@github.com:interledgerjs/ilp.git","clone_url":"https://github.com/interledgerjs/ilp.git","svn_url":"https://github.com/interledgerjs/ilp","homepage":null,"size":292,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/74"},"html":{"href":"https://github.com/interledgerjs/ilp/pull/74"},"issue":{"href":"https://api.github.com/repos/interledgerjs/ilp/issues/74"},"comments":{"href":"https://api.github.com/repos/interledgerjs/ilp/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledgerjs/ilp/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/interledgerjs/ilp/statuses/18a8faad83ad894f2228e5485895259aa2dac972"}}}}
{"actor":{"display_login":"emschwartz"}}