{"action":"created","comment":{"url":"https://api.github.com/repos/blueapron/marinator/pulls/comments/148795367","pull_request_review_id":74095056,"id":148795367,"diff_hunk":"@@ -148,10 +148,17 @@ private JavaFile constructClass(Map<TypeElement, List<InjectorRecord>> injectors\n             }\n         }\n \n+        // Sort the parameters by class name. This guarantees that the generated constructor has\n+        // a stable signature, regardless of the file traversal order.\n+        params.sort(new ParameterComparator());","path":"marinator-processor/src/main/java/com/blueapron/marinator/processor/InjectorProcessor.java","position":31,"original_position":31,"commit_id":"93b178242fd34871d88b2fde4a739206fa67aad3","original_commit_id":"93b178242fd34871d88b2fde4a739206fa67aad3","user":{"login":"premnirmal","id":1255689,"avatar_url":"https://avatars3.githubusercontent.com/u/1255689?v=4","gravatar_id":"","url":"https://api.github.com/users/premnirmal","html_url":"https://github.com/premnirmal","followers_url":"https://api.github.com/users/premnirmal/followers","following_url":"https://api.github.com/users/premnirmal/following{/other_user}","gists_url":"https://api.github.com/users/premnirmal/gists{/gist_id}","starred_url":"https://api.github.com/users/premnirmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premnirmal/subscriptions","organizations_url":"https://api.github.com/users/premnirmal/orgs","repos_url":"https://api.github.com/users/premnirmal/repos","events_url":"https://api.github.com/users/premnirmal/events{/privacy}","received_events_url":"https://api.github.com/users/premnirmal/received_events","type":"User","site_admin":false},"body":":+1:","created_at":"2017-11-03T14:24:03Z","updated_at":"2017-11-03T14:24:03Z","html_url":"https://github.com/blueapron/marinator/pull/10#discussion_r148795367","pull_request_url":"https://api.github.com/repos/blueapron/marinator/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/comments/148795367"},"html":{"href":"https://github.com/blueapron/marinator/pull/10#discussion_r148795367"},"pull_request":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/blueapron/marinator/pulls/10","id":150428364,"html_url":"https://github.com/blueapron/marinator/pull/10","diff_url":"https://github.com/blueapron/marinator/pull/10.diff","patch_url":"https://github.com/blueapron/marinator/pull/10.patch","issue_url":"https://api.github.com/repos/blueapron/marinator/issues/10","number":10,"state":"open","locked":false,"title":"Adding a sort to guarantee stable parameters","user":{"login":"tmtrademarked","id":16063079,"avatar_url":"https://avatars0.githubusercontent.com/u/16063079?v=4","gravatar_id":"","url":"https://api.github.com/users/tmtrademarked","html_url":"https://github.com/tmtrademarked","followers_url":"https://api.github.com/users/tmtrademarked/followers","following_url":"https://api.github.com/users/tmtrademarked/following{/other_user}","gists_url":"https://api.github.com/users/tmtrademarked/gists{/gist_id}","starred_url":"https://api.github.com/users/tmtrademarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmtrademarked/subscriptions","organizations_url":"https://api.github.com/users/tmtrademarked/orgs","repos_url":"https://api.github.com/users/tmtrademarked/repos","events_url":"https://api.github.com/users/tmtrademarked/events{/privacy}","received_events_url":"https://api.github.com/users/tmtrademarked/received_events","type":"User","site_admin":false},"body":"Marinator had a very subtle bug previously. The order of the parameters for the MarinadeHelper and the constructor were determined by file traversal order. It's possible that this is different across different build environments, which leads to compilation errors.\r\n\r\nThe fix is to sort the parameters in a deterministic order. This allows us to guarantee the order of the constructor params.\r\n\r\nAdditionally, this PR adds the correct attribution for third-party libraries used in Marinator.","created_at":"2017-11-02T23:28:02Z","updated_at":"2017-11-03T14:24:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00379da027305f566a73a2318a9f785978451699","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rhill345","id":16248687,"avatar_url":"https://avatars3.githubusercontent.com/u/16248687?v=4","gravatar_id":"","url":"https://api.github.com/users/rhill345","html_url":"https://github.com/rhill345","followers_url":"https://api.github.com/users/rhill345/followers","following_url":"https://api.github.com/users/rhill345/following{/other_user}","gists_url":"https://api.github.com/users/rhill345/gists{/gist_id}","starred_url":"https://api.github.com/users/rhill345/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhill345/subscriptions","organizations_url":"https://api.github.com/users/rhill345/orgs","repos_url":"https://api.github.com/users/rhill345/repos","events_url":"https://api.github.com/users/rhill345/events{/privacy}","received_events_url":"https://api.github.com/users/rhill345/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/blueapron/marinator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/blueapron/marinator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/blueapron/marinator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blueapron/marinator/issues/10/comments","statuses_url":"https://api.github.com/repos/blueapron/marinator/statuses/93b178242fd34871d88b2fde4a739206fa67aad3","head":{"label":"blueapron:sort_order","ref":"sort_order","sha":"93b178242fd34871d88b2fde4a739206fa67aad3","user":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars2.githubusercontent.com/u/1420060?v=4","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"repo":{"id":74244998,"name":"marinator","full_name":"blueapron/marinator","owner":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars2.githubusercontent.com/u/1420060?v=4","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blueapron/marinator","description":"Delicious Dependency Injection","fork":false,"url":"https://api.github.com/repos/blueapron/marinator","forks_url":"https://api.github.com/repos/blueapron/marinator/forks","keys_url":"https://api.github.com/repos/blueapron/marinator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blueapron/marinator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blueapron/marinator/teams","hooks_url":"https://api.github.com/repos/blueapron/marinator/hooks","issue_events_url":"https://api.github.com/repos/blueapron/marinator/issues/events{/number}","events_url":"https://api.github.com/repos/blueapron/marinator/events","assignees_url":"https://api.github.com/repos/blueapron/marinator/assignees{/user}","branches_url":"https://api.github.com/repos/blueapron/marinator/branches{/branch}","tags_url":"https://api.github.com/repos/blueapron/marinator/tags","blobs_url":"https://api.github.com/repos/blueapron/marinator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blueapron/marinator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blueapron/marinator/git/refs{/sha}","trees_url":"https://api.github.com/repos/blueapron/marinator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blueapron/marinator/statuses/{sha}","languages_url":"https://api.github.com/repos/blueapron/marinator/languages","stargazers_url":"https://api.github.com/repos/blueapron/marinator/stargazers","contributors_url":"https://api.github.com/repos/blueapron/marinator/contributors","subscribers_url":"https://api.github.com/repos/blueapron/marinator/subscribers","subscription_url":"https://api.github.com/repos/blueapron/marinator/subscription","commits_url":"https://api.github.com/repos/blueapron/marinator/commits{/sha}","git_commits_url":"https://api.github.com/repos/blueapron/marinator/git/commits{/sha}","comments_url":"https://api.github.com/repos/blueapron/marinator/comments{/number}","issue_comment_url":"https://api.github.com/repos/blueapron/marinator/issues/comments{/number}","contents_url":"https://api.github.com/repos/blueapron/marinator/contents/{+path}","compare_url":"https://api.github.com/repos/blueapron/marinator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blueapron/marinator/merges","archive_url":"https://api.github.com/repos/blueapron/marinator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blueapron/marinator/downloads","issues_url":"https://api.github.com/repos/blueapron/marinator/issues{/number}","pulls_url":"https://api.github.com/repos/blueapron/marinator/pulls{/number}","milestones_url":"https://api.github.com/repos/blueapron/marinator/milestones{/number}","notifications_url":"https://api.github.com/repos/blueapron/marinator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blueapron/marinator/labels{/name}","releases_url":"https://api.github.com/repos/blueapron/marinator/releases{/id}","deployments_url":"https://api.github.com/repos/blueapron/marinator/deployments","created_at":"2016-11-20T01:00:16Z","updated_at":"2017-11-02T11:02:10Z","pushed_at":"2017-11-02T23:37:06Z","git_url":"git://github.com/blueapron/marinator.git","ssh_url":"git@github.com:blueapron/marinator.git","clone_url":"https://github.com/blueapron/marinator.git","svn_url":"https://github.com/blueapron/marinator","homepage":"http://blueapron.io","size":88,"stargazers_count":84,"watchers_count":84,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":84,"default_branch":"master"}},"base":{"label":"blueapron:master","ref":"master","sha":"45b311890758714ff49f64f8fd76a2bf25282665","user":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars2.githubusercontent.com/u/1420060?v=4","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"repo":{"id":74244998,"name":"marinator","full_name":"blueapron/marinator","owner":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars2.githubusercontent.com/u/1420060?v=4","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blueapron/marinator","description":"Delicious Dependency Injection","fork":false,"url":"https://api.github.com/repos/blueapron/marinator","forks_url":"https://api.github.com/repos/blueapron/marinator/forks","keys_url":"https://api.github.com/repos/blueapron/marinator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blueapron/marinator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blueapron/marinator/teams","hooks_url":"https://api.github.com/repos/blueapron/marinator/hooks","issue_events_url":"https://api.github.com/repos/blueapron/marinator/issues/events{/number}","events_url":"https://api.github.com/repos/blueapron/marinator/events","assignees_url":"https://api.github.com/repos/blueapron/marinator/assignees{/user}","branches_url":"https://api.github.com/repos/blueapron/marinator/branches{/branch}","tags_url":"https://api.github.com/repos/blueapron/marinator/tags","blobs_url":"https://api.github.com/repos/blueapron/marinator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blueapron/marinator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blueapron/marinator/git/refs{/sha}","trees_url":"https://api.github.com/repos/blueapron/marinator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blueapron/marinator/statuses/{sha}","languages_url":"https://api.github.com/repos/blueapron/marinator/languages","stargazers_url":"https://api.github.com/repos/blueapron/marinator/stargazers","contributors_url":"https://api.github.com/repos/blueapron/marinator/contributors","subscribers_url":"https://api.github.com/repos/blueapron/marinator/subscribers","subscription_url":"https://api.github.com/repos/blueapron/marinator/subscription","commits_url":"https://api.github.com/repos/blueapron/marinator/commits{/sha}","git_commits_url":"https://api.github.com/repos/blueapron/marinator/git/commits{/sha}","comments_url":"https://api.github.com/repos/blueapron/marinator/comments{/number}","issue_comment_url":"https://api.github.com/repos/blueapron/marinator/issues/comments{/number}","contents_url":"https://api.github.com/repos/blueapron/marinator/contents/{+path}","compare_url":"https://api.github.com/repos/blueapron/marinator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blueapron/marinator/merges","archive_url":"https://api.github.com/repos/blueapron/marinator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blueapron/marinator/downloads","issues_url":"https://api.github.com/repos/blueapron/marinator/issues{/number}","pulls_url":"https://api.github.com/repos/blueapron/marinator/pulls{/number}","milestones_url":"https://api.github.com/repos/blueapron/marinator/milestones{/number}","notifications_url":"https://api.github.com/repos/blueapron/marinator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blueapron/marinator/labels{/name}","releases_url":"https://api.github.com/repos/blueapron/marinator/releases{/id}","deployments_url":"https://api.github.com/repos/blueapron/marinator/deployments","created_at":"2016-11-20T01:00:16Z","updated_at":"2017-11-02T11:02:10Z","pushed_at":"2017-11-02T23:37:06Z","git_url":"git://github.com/blueapron/marinator.git","ssh_url":"git@github.com:blueapron/marinator.git","clone_url":"https://github.com/blueapron/marinator.git","svn_url":"https://github.com/blueapron/marinator","homepage":"http://blueapron.io","size":88,"stargazers_count":84,"watchers_count":84,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/10"},"html":{"href":"https://github.com/blueapron/marinator/pull/10"},"issue":{"href":"https://api.github.com/repos/blueapron/marinator/issues/10"},"comments":{"href":"https://api.github.com/repos/blueapron/marinator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blueapron/marinator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/blueapron/marinator/statuses/93b178242fd34871d88b2fde4a739206fa67aad3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"premnirmal"}}