{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20432","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20432/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20432/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20432/events","html_url":"https://github.com/cockroachdb/cockroach/pull/20432","id":278811926,"number":20432,"title":"storage: Include command timestamps in command queue debug string","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-03T19:32:13Z","updated_at":"2017-12-03T20:27:00Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/20432","html_url":"https://github.com/cockroachdb/cockroach/pull/20432","diff_url":"https://github.com/cockroachdb/cockroach/pull/20432.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/20432.patch"},"body":"Would have been nice when looking into #20114 to get a sense of whether progress was being made and whether new requests were coming in."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/348811742","html_url":"https://github.com/cockroachdb/cockroach/pull/20432#issuecomment-348811742","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20432","id":348811742,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2017-12-03T20:27:00Z","updated_at":"2017-12-03T20:27:00Z","author_association":"CONTRIBUTOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n*[pkg/storage/command_queue.go, line 127 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/20432#-L-T2nieBOq_o2GfykIA:-L-T2nieBOq_o2GfykIB:btl6ssx) ([raw file](https://github.com/cockroachdb/cockroach/blob/5162005f3073b2b959757326115dca163eeb5e54/pkg/storage/command_queue.go#L127)):*\n> ```Go\n> \t\treadOnly = \" readonly\"\n> \t}\n> \tfmt.Fprintf(&buf, \"%d %v%s [%s\", c.id, c.timestamp, readOnly, roachpb.Key(c.key.Start))\n> ```\n\nShould that be `%s`? Does it matter?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/20432#-:-L-T2rc9u7OOQaRVMZ4h:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}