{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/comments/120125823","pull_request_review_id":42063520,"id":120125823,"diff_hunk":"@@ -58,10 +58,18 @@ class TemplateCompiler extends Filter {\n   }\n \n   processString(string, relativePath) {\n-    return 'export default ' + utils.template(this.options.templateCompiler, stripBom(string), {\n-      contents: string,\n-      moduleName: relativePath\n-    }) + ';';\n+    try {\n+      return 'export default ' + utils.template(this.options.templateCompiler, stripBom(string), {\n+        contents: string,\n+        moduleName: relativePath\n+      }) + ';';\n+    } catch(error) {\n+      // augment with location and type information and re-throw.\n+      error.type = 'Template Compiler Error';\n+      error.location = error.location.start;","path":"index.js","position":16,"original_position":16,"commit_id":"207954582fcc67d4d8a495c3e0193d1328793e39","original_commit_id":"207954582fcc67d4d8a495c3e0193d1328793e39","user":{"login":"twokul","id":1131196,"avatar_url":"https://avatars1.githubusercontent.com/u/1131196?v=3","gravatar_id":"","url":"https://api.github.com/users/twokul","html_url":"https://github.com/twokul","followers_url":"https://api.github.com/users/twokul/followers","following_url":"https://api.github.com/users/twokul/following{/other_user}","gists_url":"https://api.github.com/users/twokul/gists{/gist_id}","starred_url":"https://api.github.com/users/twokul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twokul/subscriptions","organizations_url":"https://api.github.com/users/twokul/orgs","repos_url":"https://api.github.com/users/twokul/repos","events_url":"https://api.github.com/users/twokul/events{/privacy}","received_events_url":"https://api.github.com/users/twokul/received_events","type":"User","site_admin":false},"body":"oh? `error` here comes from `ember-template-compiler`/`broccoli-persistent-filter` and I thought it always is going to be an object. As far as  `location` property goes, it should be there because https://github.com/glimmerjs/glimmer-vm/pull/540.\r\n\r\nhaving said that, I'm happy to make it more resilient","created_at":"2017-06-05T14:51:53Z","updated_at":"2017-06-05T14:51:53Z","html_url":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115#discussion_r120125823","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/comments/120125823"},"html":{"href":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115#discussion_r120125823"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115","id":123852728,"html_url":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115","diff_url":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115.diff","patch_url":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/115","number":115,"state":"open","locked":false,"title":"Re-throw compilation errors with additional information","user":{"login":"twokul","id":1131196,"avatar_url":"https://avatars1.githubusercontent.com/u/1131196?v=3","gravatar_id":"","url":"https://api.github.com/users/twokul","html_url":"https://github.com/twokul","followers_url":"https://api.github.com/users/twokul/followers","following_url":"https://api.github.com/users/twokul/following{/other_user}","gists_url":"https://api.github.com/users/twokul/gists{/gist_id}","starred_url":"https://api.github.com/users/twokul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twokul/subscriptions","organizations_url":"https://api.github.com/users/twokul/orgs","repos_url":"https://api.github.com/users/twokul/repos","events_url":"https://api.github.com/users/twokul/events{/privacy}","received_events_url":"https://api.github.com/users/twokul/received_events","type":"User","site_admin":false},"body":"Depends on https://github.com/glimmerjs/glimmer-vm/pull/540.\r\n\r\nOnce we agree on `BuildError` interface, we can replace the code in a `catch` block to:\r\n\r\n```javascript\r\nimport { BuildError } from 'ember-build-utilities';\r\n\r\n// code\r\n\r\ntry {\r\n  // code\r\n} catch(e) {\r\n  throw new BuildError('Template Compiler Error', e.message, e.stack, e.location.start);\r\n}\r\n```","created_at":"2017-06-03T19:04:28Z","updated_at":"2017-06-05T14:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d67d3c8d1a87ffa7fb34a755429779defe101046","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/115/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/statuses/207954582fcc67d4d8a495c3e0193d1328793e39","head":{"label":"twokul:errors","ref":"errors","sha":"207954582fcc67d4d8a495c3e0193d1328793e39","user":{"login":"twokul","id":1131196,"avatar_url":"https://avatars1.githubusercontent.com/u/1131196?v=3","gravatar_id":"","url":"https://api.github.com/users/twokul","html_url":"https://github.com/twokul","followers_url":"https://api.github.com/users/twokul/followers","following_url":"https://api.github.com/users/twokul/following{/other_user}","gists_url":"https://api.github.com/users/twokul/gists{/gist_id}","starred_url":"https://api.github.com/users/twokul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twokul/subscriptions","organizations_url":"https://api.github.com/users/twokul/orgs","repos_url":"https://api.github.com/users/twokul/repos","events_url":"https://api.github.com/users/twokul/events{/privacy}","received_events_url":"https://api.github.com/users/twokul/received_events","type":"User","site_admin":false},"repo":{"id":65049962,"name":"ember-cli-htmlbars","full_name":"twokul/ember-cli-htmlbars","owner":{"login":"twokul","id":1131196,"avatar_url":"https://avatars1.githubusercontent.com/u/1131196?v=3","gravatar_id":"","url":"https://api.github.com/users/twokul","html_url":"https://github.com/twokul","followers_url":"https://api.github.com/users/twokul/followers","following_url":"https://api.github.com/users/twokul/following{/other_user}","gists_url":"https://api.github.com/users/twokul/gists{/gist_id}","starred_url":"https://api.github.com/users/twokul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twokul/subscriptions","organizations_url":"https://api.github.com/users/twokul/orgs","repos_url":"https://api.github.com/users/twokul/repos","events_url":"https://api.github.com/users/twokul/events{/privacy}","received_events_url":"https://api.github.com/users/twokul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twokul/ember-cli-htmlbars","description":null,"fork":true,"url":"https://api.github.com/repos/twokul/ember-cli-htmlbars","forks_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/forks","keys_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/teams","hooks_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/hooks","issue_events_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/issues/events{/number}","events_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/events","assignees_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/assignees{/user}","branches_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/branches{/branch}","tags_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/tags","blobs_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/git/refs{/sha}","trees_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/statuses/{sha}","languages_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/languages","stargazers_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/stargazers","contributors_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/contributors","subscribers_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/subscribers","subscription_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/subscription","commits_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/commits{/sha}","git_commits_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/git/commits{/sha}","comments_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/comments{/number}","issue_comment_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/issues/comments{/number}","contents_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/contents/{+path}","compare_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/merges","archive_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/downloads","issues_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/issues{/number}","pulls_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/pulls{/number}","milestones_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/milestones{/number}","notifications_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/labels{/name}","releases_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/releases{/id}","deployments_url":"https://api.github.com/repos/twokul/ember-cli-htmlbars/deployments","created_at":"2016-08-05T21:23:32Z","updated_at":"2016-08-05T21:23:33Z","pushed_at":"2017-06-03T22:45:32Z","git_url":"git://github.com/twokul/ember-cli-htmlbars.git","ssh_url":"git@github.com:twokul/ember-cli-htmlbars.git","clone_url":"https://github.com/twokul/ember-cli-htmlbars.git","svn_url":"https://github.com/twokul/ember-cli-htmlbars","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"31a474cd9aa95f4863a19410f86da186f5a75427","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars0.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":24438846,"name":"ember-cli-htmlbars","full_name":"ember-cli/ember-cli-htmlbars","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars0.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli-htmlbars","description":null,"fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars","forks_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/deployments","created_at":"2014-09-25T01:23:48Z","updated_at":"2017-06-03T20:28:17Z","pushed_at":"2017-06-03T22:45:34Z","git_url":"git://github.com/ember-cli/ember-cli-htmlbars.git","ssh_url":"git@github.com:ember-cli/ember-cli-htmlbars.git","clone_url":"https://github.com/ember-cli/ember-cli-htmlbars.git","svn_url":"https://github.com/ember-cli/ember-cli-htmlbars","homepage":null,"size":206,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":6,"forks":33,"open_issues":6,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115"},"html":{"href":"https://github.com/ember-cli/ember-cli-htmlbars/pull/115"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/115"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli-htmlbars/statuses/207954582fcc67d4d8a495c3e0193d1328793e39"}}}}
{"actor":{"display_login":"twokul"}}