{"push_id":1609216662,"size":1,"distinct_size":1,"ref":"refs/heads/patch-1","head":"375e935f68e18b2893a3dac80491d3ddfa751ce3","before":"1dd774fa838aa6eddfdfb95896eacbf86a905cda","commits":[{"sha":"375e935f68e18b2893a3dac80491d3ddfa751ce3","author":{"name":"George G","email":"797aad5562340a9a5e7fb0052b338e22c7f76469@users.noreply.github.com"},"message":"install_extracted: fix bug in copying into symlinked folders\n\nThe install_extracted method may be used to copy files inside target directories which are symlinks, and not actual folders, like in the case of libs in /vendor/lib* in devices with separate /vendor partition, like the Nexus 5X and the Nexus 6P.\r\n\r\nHowever, the recursive option of cp can't handle it, as it is already documented as a linux bug here:\r\nhttps://lists.freebsd.org/pipermail/freebsd-bugs/2013-February/051809.html\r\n\r\nwhich produces the below output in recovery.log:\r\n```\r\nextracting: /tmp/GApps/faceunlock-lib-arm64.tar.lz  \r\nFound GApps/faceunlock-lib-arm64 DPI path: unknown\r\ncp: target '/system/./vendor' is not a directory\r\n```\r\n\r\nThis important bug was somewhat \"hidden\" as the only file that Open-GApps currently try to copy into /vendor/lib* is libfrsdk.so, required only for a working Facelock app. This was also the way the bug was found, libfrsdk.so was never copied, resulting in Facelock FCing with the following logcat:\r\n```\r\n03-12 17:11:23.028  8038  8038 E AndroidRuntime: FATAL EXCEPTION: main\r\n03-12 17:11:23.028  8038  8038 E AndroidRuntime: Process: com.android.facelock, PID: 8038\r\n03-12 17:11:23.028  8038  8038 E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: library \"libfrsdk.so\" not found\r\n```\r\n\r\nMoving the copying of the files inside the \"for loop\", and replacing cp with install, (so all subdirectories can be created on the fly), seems to solve the problem during my tests (the lib is correctly copied), while no regressions were found.","distinct":true,"url":"https://api.github.com/repos/KreAch3R/opengapps/commits/375e935f68e18b2893a3dac80491d3ddfa751ce3"}]}
{"actor":{"display_login":"KreAch3R"}}