{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/117016490","pull_request_review_id":38684457,"id":117016490,"diff_hunk":"@@ -15,14 +15,16 @@ def self.generate(objects, headers=[], &gen_csv)\n   end\n \n   # Performs an action for each object in a collection represented by\n-  # a CSV string. 'input' is the input string, and parse_obj is a block which\n-  # takes a line and performs an action, or raises CSVInvalidLineError.\n+  # a CSV string. 'input' is the input string, 'header_count' is the\n+  # number of header lines to remove from the displayed valid_line_count\n+  # and parse_obj is a block which takes a line and performs an action,\n+  # or raises CSVInvalidLineError.\n   # Returns a result hash, containing a success message with the number of\n   # successful rows parsed, as well as an error message, consisting of one\n   # of the following:\n   #   1) A string listing all erroneous lines.\n   #   2) A more generic error message for invalid files.\n-  def self.parse(input, options = {}, &parse_obj)\n+  def self.parse(input, options = {}, header_count = 0, &parse_obj)","path":"lib/classes/markus_csv.rb","position":16,"original_position":16,"commit_id":"77178812495bea385ce567638397aaf5efe553c0","original_commit_id":"77178812495bea385ce567638397aaf5efe553c0","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars1.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"Oh geez, it looks like it's the `CSV.parse` method specifically that is rejecting options that aren't recognized. I forgot that we passed the options hash to this method. In this case, use `options.delete(:header_count)` to both extract the option and remove it from `options`. (This returns `nil` if the key is not present, so you still need to specify the default value.)","created_at":"2017-05-17T14:27:48Z","updated_at":"2017-05-17T14:27:48Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2986#discussion_r117016490","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/117016490"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2986#discussion_r117016490"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986","id":120169830,"html_url":"https://github.com/MarkUsProject/Markus/pull/2986","diff_url":"https://github.com/MarkUsProject/Markus/pull/2986.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2986.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2986","number":2986,"state":"open","locked":false,"title":"Remove header rows from valid_line_count, so entry count is accurate","user":{"login":"rathukugan","id":10248992,"avatar_url":"https://avatars3.githubusercontent.com/u/10248992?v=3","gravatar_id":"","url":"https://api.github.com/users/rathukugan","html_url":"https://github.com/rathukugan","followers_url":"https://api.github.com/users/rathukugan/followers","following_url":"https://api.github.com/users/rathukugan/following{/other_user}","gists_url":"https://api.github.com/users/rathukugan/gists{/gist_id}","starred_url":"https://api.github.com/users/rathukugan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathukugan/subscriptions","organizations_url":"https://api.github.com/users/rathukugan/orgs","repos_url":"https://api.github.com/users/rathukugan/repos","events_url":"https://api.github.com/users/rathukugan/events{/privacy}","received_events_url":"https://api.github.com/users/rathukugan/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-11T18:18:20Z","updated_at":"2017-05-17T14:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f675c14e7fc520588fe21c7049c80317a438de92","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2986/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/77178812495bea385ce567638397aaf5efe553c0","head":{"label":"rathukugan:fix-upload-entries-count","ref":"fix-upload-entries-count","sha":"77178812495bea385ce567638397aaf5efe553c0","user":{"login":"rathukugan","id":10248992,"avatar_url":"https://avatars3.githubusercontent.com/u/10248992?v=3","gravatar_id":"","url":"https://api.github.com/users/rathukugan","html_url":"https://github.com/rathukugan","followers_url":"https://api.github.com/users/rathukugan/followers","following_url":"https://api.github.com/users/rathukugan/following{/other_user}","gists_url":"https://api.github.com/users/rathukugan/gists{/gist_id}","starred_url":"https://api.github.com/users/rathukugan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathukugan/subscriptions","organizations_url":"https://api.github.com/users/rathukugan/orgs","repos_url":"https://api.github.com/users/rathukugan/repos","events_url":"https://api.github.com/users/rathukugan/events{/privacy}","received_events_url":"https://api.github.com/users/rathukugan/received_events","type":"User","site_admin":false},"repo":{"id":90039027,"name":"Markus","full_name":"rathukugan/Markus","owner":{"login":"rathukugan","id":10248992,"avatar_url":"https://avatars3.githubusercontent.com/u/10248992?v=3","gravatar_id":"","url":"https://api.github.com/users/rathukugan","html_url":"https://github.com/rathukugan","followers_url":"https://api.github.com/users/rathukugan/followers","following_url":"https://api.github.com/users/rathukugan/following{/other_user}","gists_url":"https://api.github.com/users/rathukugan/gists{/gist_id}","starred_url":"https://api.github.com/users/rathukugan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathukugan/subscriptions","organizations_url":"https://api.github.com/users/rathukugan/orgs","repos_url":"https://api.github.com/users/rathukugan/repos","events_url":"https://api.github.com/users/rathukugan/events{/privacy}","received_events_url":"https://api.github.com/users/rathukugan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rathukugan/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/rathukugan/Markus","forks_url":"https://api.github.com/repos/rathukugan/Markus/forks","keys_url":"https://api.github.com/repos/rathukugan/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rathukugan/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rathukugan/Markus/teams","hooks_url":"https://api.github.com/repos/rathukugan/Markus/hooks","issue_events_url":"https://api.github.com/repos/rathukugan/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/rathukugan/Markus/events","assignees_url":"https://api.github.com/repos/rathukugan/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/rathukugan/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/rathukugan/Markus/tags","blobs_url":"https://api.github.com/repos/rathukugan/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rathukugan/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rathukugan/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/rathukugan/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rathukugan/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/rathukugan/Markus/languages","stargazers_url":"https://api.github.com/repos/rathukugan/Markus/stargazers","contributors_url":"https://api.github.com/repos/rathukugan/Markus/contributors","subscribers_url":"https://api.github.com/repos/rathukugan/Markus/subscribers","subscription_url":"https://api.github.com/repos/rathukugan/Markus/subscription","commits_url":"https://api.github.com/repos/rathukugan/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/rathukugan/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/rathukugan/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/rathukugan/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/rathukugan/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/rathukugan/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rathukugan/Markus/merges","archive_url":"https://api.github.com/repos/rathukugan/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rathukugan/Markus/downloads","issues_url":"https://api.github.com/repos/rathukugan/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/rathukugan/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/rathukugan/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/rathukugan/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rathukugan/Markus/labels{/name}","releases_url":"https://api.github.com/repos/rathukugan/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/rathukugan/Markus/deployments","created_at":"2017-05-02T13:52:40Z","updated_at":"2017-05-02T13:52:45Z","pushed_at":"2017-05-13T01:35:32Z","git_url":"git://github.com/rathukugan/Markus.git","ssh_url":"git@github.com:rathukugan/Markus.git","clone_url":"https://github.com/rathukugan/Markus.git","svn_url":"https://github.com/rathukugan/Markus","homepage":"http://www.markusproject.org","size":30713,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"8ef5f1b8dcb3d3a3b94b26b93e7d38b9175f6077","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars2.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars2.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/MarkUsProject/Markus/deployments","created_at":"2010-09-26T16:18:08Z","updated_at":"2017-04-19T15:16:32Z","pushed_at":"2017-05-17T13:19:54Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":30767,"stargazers_count":158,"watchers_count":158,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":142,"forks":183,"open_issues":142,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2986"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2986"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2986/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2986/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/77178812495bea385ce567638397aaf5efe553c0"}}}}
{"actor":{"display_login":"david-yz-liu"}}