{"action":"created","issue":{"url":"https://api.github.com/repos/uber/zanzibar/issues/210","repository_url":"https://api.github.com/repos/uber/zanzibar","labels_url":"https://api.github.com/repos/uber/zanzibar/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/uber/zanzibar/issues/210/comments","events_url":"https://api.github.com/repos/uber/zanzibar/issues/210/events","html_url":"https://github.com/uber/zanzibar/pull/210","id":259274329,"number":210,"title":"Add option to use sidecar router for generated clients","user":{"login":"ChuntaoLu","id":5065819,"avatar_url":"https://avatars0.githubusercontent.com/u/5065819?v=4","gravatar_id":"","url":"https://api.github.com/users/ChuntaoLu","html_url":"https://github.com/ChuntaoLu","followers_url":"https://api.github.com/users/ChuntaoLu/followers","following_url":"https://api.github.com/users/ChuntaoLu/following{/other_user}","gists_url":"https://api.github.com/users/ChuntaoLu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChuntaoLu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChuntaoLu/subscriptions","organizations_url":"https://api.github.com/users/ChuntaoLu/orgs","repos_url":"https://api.github.com/users/ChuntaoLu/repos","events_url":"https://api.github.com/users/ChuntaoLu/events{/privacy}","received_events_url":"https://api.github.com/users/ChuntaoLu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-20T19:24:26Z","updated_at":"2017-09-20T21:40:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/210","html_url":"https://github.com/uber/zanzibar/pull/210","diff_url":"https://github.com/uber/zanzibar/pull/210.diff","patch_url":"https://github.com/uber/zanzibar/pull/210.patch"},"body":"This PR adds a `useSidecarRouter` boolean field in client-config.json to indicate the generated client should use `sidecarRouter.$type.ip` and `sidecarRouter.$type.port` config to communicate with its backend.\n\nThe tchannel client integration is complete in this PR, http client integration involves extra headers and will be done in a future PR."},"comment":{"url":"https://api.github.com/repos/uber/zanzibar/issues/comments/330989029","html_url":"https://github.com/uber/zanzibar/pull/210#issuecomment-330989029","issue_url":"https://api.github.com/repos/uber/zanzibar/issues/210","id":330989029,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T21:40:10Z","updated_at":"2017-09-20T21:40:10Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13361873/badge)](https://coveralls.io/builds/13361873)\n\nCoverage decreased (-0.4%) to 75.478% when pulling **640c9123770f9730ea6a8969e5ac7fcd024fb7c8 on lu.tchan** into **1a16c6132a540841234fba72e50d3256306644b8 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}