{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/723","repository_url":"https://api.github.com/repos/Microsoft/vscode-mssql","labels_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/723/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/723/events","html_url":"https://github.com/Microsoft/vscode-mssql/pull/723","id":210175294,"number":723,"title":"Telemetry fix: promise.all not receiving promises","user":{"login":"kevcunnane","id":10819925,"avatar_url":"https://avatars.githubusercontent.com/u/10819925?v=3","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"labels":[{"id":482970112,"url":"https://api.github.com/repos/Microsoft/vscode-mssql/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-24T22:28:15Z","updated_at":"2017-02-24T22:38:49Z","closed_at":"2017-02-24T22:35:18Z","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/pulls/723","html_url":"https://github.com/Microsoft/vscode-mssql/pull/723","diff_url":"https://github.com/Microsoft/vscode-mssql/pull/723.diff","patch_url":"https://github.com/Microsoft/vscode-mssql/pull/723.patch"},"body":"- Promise.all requires either an array of PromiseLike objects or objects of type T. A change when upgrading to Typescript 2.1.5 caused us to pass in the functions, rather than the promises returned by those functions as previously happened. This meant that Promises.all returned immediately as it thought it was returning an array of functions.\r\n- Fix is to explicitly define the promise return types, and go back to calling the methods so that we get promises back to wait on."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/comments/282425046","html_url":"https://github.com/Microsoft/vscode-mssql/pull/723#issuecomment-282425046","issue_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/723","id":282425046,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-02-24T22:38:49Z","updated_at":"2017-02-24T22:38:49Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10323635/badge)](https://coveralls.io/builds/10323635)\n\nCoverage remained the same at 64.0% when pulling **6c8e14fc17aff921ed3b649106922f94dbe70b3a on fix/telemetryProperties** into **7cf26f4454b456fb3ae0eb722a59efc696972309 on dev**.\n"}}
{"actor":{"display_login":"coveralls"}}