{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/1044","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/1044/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/1044/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/1044/events","html_url":"https://github.com/junit-team/junit5/issues/1044","id":255317939,"number":1044,"title":"Remove Class-Path attribute from standalone JAR manifest","user":{"login":"sormuras","id":2319838,"avatar_url":"https://avatars1.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false},"labels":[{"id":371966680,"url":"https://api.github.com/repos/junit-team/junit5/labels/theme:%20build","name":"theme: build","color":"0052cc","default":false},{"id":165165178,"url":"https://api.github.com/repos/junit-team/junit5/labels/type:%20bug","name":"type: bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"sormuras","id":2319838,"avatar_url":"https://avatars1.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false},"assignees":[{"login":"sormuras","id":2319838,"avatar_url":"https://avatars1.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/junit-team/junit5/milestones/10","html_url":"https://github.com/junit-team/junit5/milestone/10","labels_url":"https://api.github.com/repos/junit-team/junit5/milestones/10/labels","id":2299774,"number":10,"title":"5.0 GA","description":"First General Availability Release","creator":{"login":"marcphilipp","id":214207,"avatar_url":"https://avatars2.githubusercontent.com/u/214207?v=4","gravatar_id":"","url":"https://api.github.com/users/marcphilipp","html_url":"https://github.com/marcphilipp","followers_url":"https://api.github.com/users/marcphilipp/followers","following_url":"https://api.github.com/users/marcphilipp/following{/other_user}","gists_url":"https://api.github.com/users/marcphilipp/gists{/gist_id}","starred_url":"https://api.github.com/users/marcphilipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcphilipp/subscriptions","organizations_url":"https://api.github.com/users/marcphilipp/orgs","repos_url":"https://api.github.com/users/marcphilipp/repos","events_url":"https://api.github.com/users/marcphilipp/events{/privacy}","received_events_url":"https://api.github.com/users/marcphilipp/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":5,"state":"open","created_at":"2017-02-04T15:48:18Z","updated_at":"2017-09-06T13:02:46Z","due_on":"2017-09-07T07:00:00Z","closed_at":null},"comments":14,"created_at":"2017-09-05T15:29:29Z","updated_at":"2017-09-06T14:17:09Z","closed_at":null,"author_association":"MEMBER","body":"## Overview\r\n\r\nRC3 ships the `junit-platform-console-standalone-1.0.0-RC3.jar` with the following `META-INF/MANIFEST.MF` file:\r\n\r\n```\r\nManifest-Version: 1.0\r\nImplementation-Title: junit-platform-console-standalone\r\nBuild-Date: 2017-08-23\r\nImplementation-Version: 1.0.0-RC3\r\nBuilt-By: JUnit Team\r\nSpecification-Vendor: junit.org\r\nSpecification-Title: junit-platform-console-standalone\r\nClass-Path: junit-platform-console-1.0.0-RC3.jar junit-jupiter-engine-\r\n 5.0.0-RC3.jar junit-jupiter-params-5.0.0-RC3.jar junit-vintage-engine\r\n -4.12.0-RC3.jar junit-platform-launcher-1.0.0-RC3.jar junit-platform-\r\n engine-1.0.0-RC3.jar junit-jupiter-api-5.0.0-RC3.jar junit-4.12.jar j\r\n unit-platform-commons-1.0.0-RC3.jar opentest4j-1.0.0-RC1.jar hamcrest\r\n -core-1.3.jar\r\nImplementation-Vendor: junit.org\r\nMain-Class: org.junit.platform.console.ConsoleLauncher\r\nBuild-Revision: e0af182b1440da44af16a7181cd3b03d1a3fe82d\r\nBuild-Time: 20:40:28.393+0200\r\nEngine-Version-junit-vintage: 4.12.0-RC3\r\nCreated-By: 1.8.0_131 (Oracle Corporation 25.131-b11)\r\nSpecification-Version: 1.0.0\r\nEngine-Version-junit-jupiter: 5.0.0-RC3\r\n```\r\n\r\nThe `Class-Path` attribute refers to all jars that are shadowed into this standalone artifact. Therefore the `Class-Path` attribute should be removed from the manifest file.\r\n\r\n## Deliverables\r\n\r\n- [ ] Configure the Gradle jar task to exclude any class-path entry.\r\n"},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/327497457","html_url":"https://github.com/junit-team/junit5/issues/1044#issuecomment-327497457","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/1044","id":327497457,"user":{"login":"sbrannen","id":104798,"avatar_url":"https://avatars0.githubusercontent.com/u/104798?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrannen","html_url":"https://github.com/sbrannen","followers_url":"https://api.github.com/users/sbrannen/followers","following_url":"https://api.github.com/users/sbrannen/following{/other_user}","gists_url":"https://api.github.com/users/sbrannen/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrannen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrannen/subscriptions","organizations_url":"https://api.github.com/users/sbrannen/orgs","repos_url":"https://api.github.com/users/sbrannen/repos","events_url":"https://api.github.com/users/sbrannen/events{/privacy}","received_events_url":"https://api.github.com/users/sbrannen/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T14:17:09Z","updated_at":"2017-09-06T14:17:09Z","author_association":"MEMBER","body":"@aalmiray Thanks for the feedback and insight!\r\n\r\n> there's nothing you can do from an external POV to change this default behavior as there's no chance to tweak the updated manifest.\r\n\r\nMmmmmm... that's a real shame! I _assumed_ it would be possible with some Gradle voodoo, but oh well. 😞 \r\n\r\nHaving said that, it should still be possible (even if totally ugly) with Gradle/Groovy to unpack the JAR, rewrite the manifest, and repack the JAR after the `shadowJar` and `jar` tasks have completed -- right?"}}
{"actor":{"display_login":"sbrannen"}}