{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/libpalaso/issues/546","repository_url":"https://api.github.com/repos/sillsdev/libpalaso","labels_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/546/comments","events_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/546/events","html_url":"https://github.com/sillsdev/libpalaso/pull/546","id":237653324,"number":546,"title":"Fixed a few bugs found in the Versification.Table class","user":{"login":"FoolRunning","id":4229836,"avatar_url":"https://avatars3.githubusercontent.com/u/4229836?v=3","gravatar_id":"","url":"https://api.github.com/users/FoolRunning","html_url":"https://github.com/FoolRunning","followers_url":"https://api.github.com/users/FoolRunning/followers","following_url":"https://api.github.com/users/FoolRunning/following{/other_user}","gists_url":"https://api.github.com/users/FoolRunning/gists{/gist_id}","starred_url":"https://api.github.com/users/FoolRunning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoolRunning/subscriptions","organizations_url":"https://api.github.com/users/FoolRunning/orgs","repos_url":"https://api.github.com/users/FoolRunning/repos","events_url":"https://api.github.com/users/FoolRunning/events{/privacy}","received_events_url":"https://api.github.com/users/FoolRunning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-21T20:22:47Z","updated_at":"2017-06-22T12:13:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sillsdev/libpalaso/pulls/546","html_url":"https://github.com/sillsdev/libpalaso/pull/546","diff_url":"https://github.com/sillsdev/libpalaso/pull/546.diff","patch_url":"https://github.com/sillsdev/libpalaso/pull/546.patch"},"body":"Fixed not all versifications being returned by the VersificationTables method (i.e. no built-in versifications were ever being included).\r\n\r\nFixed built-in versifications not being cached so a new one was created each time. This resulted in significantly increased memory usage and decreased performance (because a deep-compare was then necessary).\r\n\r\nFixed a versification named a number (e.g. \"30\") throwing an exception (caused by **Enum.TryParse** accepting the string representation of a number as a valid value)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/libpalaso/546)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/libpalaso/issues/comments/310362125","html_url":"https://github.com/sillsdev/libpalaso/pull/546#issuecomment-310362125","issue_url":"https://api.github.com/repos/sillsdev/libpalaso/issues/546","id":310362125,"user":{"login":"andrew-polk","id":5847219,"avatar_url":"https://avatars2.githubusercontent.com/u/5847219?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew-polk","html_url":"https://github.com/andrew-polk","followers_url":"https://api.github.com/users/andrew-polk/followers","following_url":"https://api.github.com/users/andrew-polk/following{/other_user}","gists_url":"https://api.github.com/users/andrew-polk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-polk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-polk/subscriptions","organizations_url":"https://api.github.com/users/andrew-polk/orgs","repos_url":"https://api.github.com/users/andrew-polk/repos","events_url":"https://api.github.com/users/andrew-polk/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-polk/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T12:13:39Z","updated_at":"2017-06-22T12:13:39Z","body":"A minor niggle. Otherwise, <img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> \n\n---\n\nReviewed 3 of 3 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[SIL.Scripture.Tests/ScrVersTests.cs, line 949 at r1](https://reviewable.io:443/reviews/sillsdev/libpalaso/546#-KnEhpOm65jEUB9RpZAy:-KnEhpOm65jEUB9RpZAz:b-euh1fd) ([raw file](https://github.com/sillsdev/libpalaso/blob/71caa3de5121193cd7a1ad20f7d48f54b367c561/SIL.Scripture.Tests/ScrVersTests.cs#L949)):*\n> versification\n\nlibpalaso convention is that private members start with _.\nThat would have saved me a few seconds understanding this test. : )\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/sillsdev/libpalaso/546#-:-KnEi9Ym91ALqxIU9xs0:b-88r6zj)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"andrew-polk"}}