{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/157277531","pull_request_review_id":83899413,"id":157277531,"diff_hunk":"@@ -11,6 +11,7 @@\n \n import type {Path} from 'types/Config';\n import path from 'path';\n+import * as fs from 'fs';","path":"packages/jest-resolve/src/node_modules_paths.js","position":4,"original_position":4,"commit_id":"866dc5cd0b1494d28769e8d935ef6424f77d955d","original_commit_id":"866dc5cd0b1494d28769e8d935ef6424f77d955d","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars0.githubusercontent.com/u/17131271?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"Changed!","created_at":"2017-12-15T19:12:25Z","updated_at":"2017-12-15T19:12:25Z","html_url":"https://github.com/facebook/jest/pull/5085#discussion_r157277531","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/5085","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/157277531"},"html":{"href":"https://github.com/facebook/jest/pull/5085#discussion_r157277531"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/5085"}},"in_reply_to_id":157164772},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/5085","id":158496576,"html_url":"https://github.com/facebook/jest/pull/5085","diff_url":"https://github.com/facebook/jest/pull/5085.diff","patch_url":"https://github.com/facebook/jest/pull/5085.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/5085","number":5085,"state":"open","locked":false,"title":"Update node_modules_path to resolve symlinks to real paths","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars0.githubusercontent.com/u/17131271?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"body":"**Summary**\r\n\r\nWe are using [pnpm](https://github.com/pnpm/pnpm) as our package manager, which creates the dependency graph using symlinks in the node_modules folder. NodeJS's & TypeScript's resolution algorithm currently resolves basedir to real path before resolving the module, it does not preserve symlinks by default. Right now, Jest cannot be used with  [pnpm](https://github.com/pnpm/pnpm) and also does not resolve packages the same was as NodeJS does, which is problematic.\r\n\r\n**Test plan**\r\n\r\nUpdated this code in our repo, everything continued to build successfully when using `npm`, but now also builds correctly when using `pnpm`.\r\n\r\n\r\n","created_at":"2017-12-15T00:23:28Z","updated_at":"2017-12-15T19:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82cef072cf2f9993b1b81ce576df834b2f620adb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/5085/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/5085/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/5085/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/866dc5cd0b1494d28769e8d935ef6424f77d955d","head":{"label":"nickpape-msft:nickpape-msft-patch-1","ref":"nickpape-msft-patch-1","sha":"866dc5cd0b1494d28769e8d935ef6424f77d955d","user":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars0.githubusercontent.com/u/17131271?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"repo":{"id":114308556,"name":"jest","full_name":"nickpape-msft/jest","owner":{"login":"nickpape-msft","id":17131271,"avatar_url":"https://avatars0.githubusercontent.com/u/17131271?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpape-msft","html_url":"https://github.com/nickpape-msft","followers_url":"https://api.github.com/users/nickpape-msft/followers","following_url":"https://api.github.com/users/nickpape-msft/following{/other_user}","gists_url":"https://api.github.com/users/nickpape-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpape-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpape-msft/subscriptions","organizations_url":"https://api.github.com/users/nickpape-msft/orgs","repos_url":"https://api.github.com/users/nickpape-msft/repos","events_url":"https://api.github.com/users/nickpape-msft/events{/privacy}","received_events_url":"https://api.github.com/users/nickpape-msft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickpape-msft/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/nickpape-msft/jest","forks_url":"https://api.github.com/repos/nickpape-msft/jest/forks","keys_url":"https://api.github.com/repos/nickpape-msft/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickpape-msft/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickpape-msft/jest/teams","hooks_url":"https://api.github.com/repos/nickpape-msft/jest/hooks","issue_events_url":"https://api.github.com/repos/nickpape-msft/jest/issues/events{/number}","events_url":"https://api.github.com/repos/nickpape-msft/jest/events","assignees_url":"https://api.github.com/repos/nickpape-msft/jest/assignees{/user}","branches_url":"https://api.github.com/repos/nickpape-msft/jest/branches{/branch}","tags_url":"https://api.github.com/repos/nickpape-msft/jest/tags","blobs_url":"https://api.github.com/repos/nickpape-msft/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickpape-msft/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickpape-msft/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickpape-msft/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickpape-msft/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/nickpape-msft/jest/languages","stargazers_url":"https://api.github.com/repos/nickpape-msft/jest/stargazers","contributors_url":"https://api.github.com/repos/nickpape-msft/jest/contributors","subscribers_url":"https://api.github.com/repos/nickpape-msft/jest/subscribers","subscription_url":"https://api.github.com/repos/nickpape-msft/jest/subscription","commits_url":"https://api.github.com/repos/nickpape-msft/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickpape-msft/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickpape-msft/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickpape-msft/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickpape-msft/jest/contents/{+path}","compare_url":"https://api.github.com/repos/nickpape-msft/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickpape-msft/jest/merges","archive_url":"https://api.github.com/repos/nickpape-msft/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickpape-msft/jest/downloads","issues_url":"https://api.github.com/repos/nickpape-msft/jest/issues{/number}","pulls_url":"https://api.github.com/repos/nickpape-msft/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/nickpape-msft/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/nickpape-msft/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickpape-msft/jest/labels{/name}","releases_url":"https://api.github.com/repos/nickpape-msft/jest/releases{/id}","deployments_url":"https://api.github.com/repos/nickpape-msft/jest/deployments","created_at":"2017-12-15T00:12:51Z","updated_at":"2017-12-15T00:12:55Z","pushed_at":"2017-12-15T01:02:09Z","git_url":"git://github.com/nickpape-msft/jest.git","ssh_url":"git@github.com:nickpape-msft/jest.git","clone_url":"https://github.com/nickpape-msft/jest.git","svn_url":"https://github.com/nickpape-msft/jest","homepage":"http://facebook.github.io/jest/","size":27904,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"cfb7ee107271f6b0d3921839699e313b9411c794","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2017-12-15T18:54:10Z","pushed_at":"2017-12-15T18:36:03Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"http://facebook.github.io/jest/","size":27883,"stargazers_count":14097,"watchers_count":14097,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1783,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1783,"open_issues":215,"watchers":14097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/5085"},"html":{"href":"https://github.com/facebook/jest/pull/5085"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/5085"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/5085/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/5085/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/5085/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/866dc5cd0b1494d28769e8d935ef6424f77d955d"}},"author_association":"NONE"}}
{"actor":{"display_login":"nickpape-msft"}}