{"action":"created","issue":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/1981","repository_url":"https://api.github.com/repos/urho3d/Urho3D","labels_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1981/labels{/name}","comments_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1981/comments","events_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1981/events","html_url":"https://github.com/urho3d/Urho3D/pull/1981","id":235641574,"number":1981,"title":"Fixed PBR artifacts","user":{"login":"dragonCASTjosh","id":3044415,"avatar_url":"https://avatars1.githubusercontent.com/u/3044415?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonCASTjosh","html_url":"https://github.com/dragonCASTjosh","followers_url":"https://api.github.com/users/dragonCASTjosh/followers","following_url":"https://api.github.com/users/dragonCASTjosh/following{/other_user}","gists_url":"https://api.github.com/users/dragonCASTjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonCASTjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonCASTjosh/subscriptions","organizations_url":"https://api.github.com/users/dragonCASTjosh/orgs","repos_url":"https://api.github.com/users/dragonCASTjosh/repos","events_url":"https://api.github.com/users/dragonCASTjosh/events{/privacy}","received_events_url":"https://api.github.com/users/dragonCASTjosh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-13T18:12:45Z","updated_at":"2017-06-16T22:47:04Z","closed_at":"2017-06-16T22:46:46Z","pull_request":{"url":"https://api.github.com/repos/urho3d/Urho3D/pulls/1981","html_url":"https://github.com/urho3d/Urho3D/pull/1981","diff_url":"https://github.com/urho3d/Urho3D/pull/1981.diff","patch_url":"https://github.com/urho3d/Urho3D/pull/1981.patch"},"body":"Fixed the issues noted in https://github.com/urho3d/Urho3D/issues/1916\r\n\r\nThis was done by rebuilding the sphere lights, changing the visibility model and expanding the diffuse and fresnel models.\r\n\r\nThe new diffuse model should be more performant due to much less and much more simple math in the shader.\r\n\r\nIn addition to fixing the issue noted i also resolved another issue i didnt realise existed until tackling this fix, the old PBR implementation didnt correctly match the physical light values, now the light values should map to real world equivalents."},"comment":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/comments/309156207","html_url":"https://github.com/urho3d/Urho3D/pull/1981#issuecomment-309156207","issue_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1981","id":309156207,"user":{"login":"cadaver","id":51361,"avatar_url":"https://avatars0.githubusercontent.com/u/51361?v=3","gravatar_id":"","url":"https://api.github.com/users/cadaver","html_url":"https://github.com/cadaver","followers_url":"https://api.github.com/users/cadaver/followers","following_url":"https://api.github.com/users/cadaver/following{/other_user}","gists_url":"https://api.github.com/users/cadaver/gists{/gist_id}","starred_url":"https://api.github.com/users/cadaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadaver/subscriptions","organizations_url":"https://api.github.com/users/cadaver/orgs","repos_url":"https://api.github.com/users/cadaver/repos","events_url":"https://api.github.com/users/cadaver/events{/privacy}","received_events_url":"https://api.github.com/users/cadaver/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T22:47:04Z","updated_at":"2017-06-16T22:47:04Z","body":"Merged, thanks!"}}
{"actor":{"display_login":"cadaver"}}