{"action":"created","comment":{"url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/comments/96090358","pull_request_review_id":16669262,"id":96090358,"diff_hunk":"@@ -3715,37 +3605,31 @@ PREFIX (atomic_op) (int op, caf_token_t token ,\n \n   selectType (kind, &dt);\n \n-# ifdef CAF_MPI_LOCK_UNLOCK\n-      MPI_Win_lock (MPI_LOCK_EXCLUSIVE, image, 0, *p);\n-# endif // CAF_MPI_LOCK_UNLOCK\n+  CAF_Win_lock (MPI_LOCK_EXCLUSIVE, image, *p);\n   /* Atomic_add */\n-      switch(op) {\n-          case 1:\n-              ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_SUM, *p);\n-              break;\n-          case 2:\n-              ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BAND, *p);\n-              break;\n-          case 4:\n-              ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BOR, *p);\n-              break;\n-          case 5:\n-              ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BXOR, *p);\n-              break;\n-          default:\n-              printf (\"We apologize but the atomic operation requested for MPI is not yet implemented\\n\");\n-              break;\n-      }\n-# ifdef CAF_MPI_LOCK_UNLOCK\n-      MPI_Win_unlock (image, *p);\n-# else // CAF_MPI_LOCK_UNLOCK\n-      MPI_Win_flush (image, *p);\n-# endif // CAF_MPI_LOCK_UNLOCK\n+  switch(op) {\n+    case 1:\n+      ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_SUM, *p);\n+      break;\n+    case 2:\n+      ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BAND, *p);\n+      break;\n+    case 4:\n+      ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BOR, *p);\n+      break;\n+    case 5:\n+      ierr = MPI_Fetch_and_op(value, old, dt, image, offset, MPI_BXOR, *p);\n+      break;\n+    default:\n+      printf (\"We apologize but the atomic operation requested for MPI < 3 is not yet implemented\\n\");\n+      break;\n+    }","path":"src/mpi/mpi_caf.c","position":488,"original_position":488,"commit_id":"b70c19aaf7649c58394981487a8b52426daad38f","original_commit_id":"b70c19aaf7649c58394981487a8b52426daad38f","user":{"login":"zbeekman","id":279612,"avatar_url":"https://avatars.githubusercontent.com/u/279612?v=3","gravatar_id":"","url":"https://api.github.com/users/zbeekman","html_url":"https://github.com/zbeekman","followers_url":"https://api.github.com/users/zbeekman/followers","following_url":"https://api.github.com/users/zbeekman/following{/other_user}","gists_url":"https://api.github.com/users/zbeekman/gists{/gist_id}","starred_url":"https://api.github.com/users/zbeekman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbeekman/subscriptions","organizations_url":"https://api.github.com/users/zbeekman/orgs","repos_url":"https://api.github.com/users/zbeekman/repos","events_url":"https://api.github.com/users/zbeekman/events{/privacy}","received_events_url":"https://api.github.com/users/zbeekman/received_events","type":"User","site_admin":false},"body":"@vehre Did anything other than indentation change here? Are you comfortable amending commits? If so could you changed the indentation back? It's hard to see what has changed when there are trivial indentation changes introduced.","created_at":"2017-01-13T22:56:04Z","updated_at":"2017-01-13T22:56:24Z","html_url":"https://github.com/sourceryinstitute/opencoarrays/pull/303#discussion_r96090358","pull_request_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/comments/96090358"},"html":{"href":"https://github.com/sourceryinstitute/opencoarrays/pull/303#discussion_r96090358"},"pull_request":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303","id":100687263,"html_url":"https://github.com/sourceryinstitute/opencoarrays/pull/303","diff_url":"https://github.com/sourceryinstitute/opencoarrays/pull/303.diff","patch_url":"https://github.com/sourceryinstitute/opencoarrays/pull/303.patch","issue_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/303","number":303,"state":"open","locked":false,"title":"Reduce code complexity","user":{"login":"vehre","id":4761547,"avatar_url":"https://avatars.githubusercontent.com/u/4761547?v=3","gravatar_id":"","url":"https://api.github.com/users/vehre","html_url":"https://github.com/vehre","followers_url":"https://api.github.com/users/vehre/followers","following_url":"https://api.github.com/users/vehre/following{/other_user}","gists_url":"https://api.github.com/users/vehre/gists{/gist_id}","starred_url":"https://api.github.com/users/vehre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vehre/subscriptions","organizations_url":"https://api.github.com/users/vehre/orgs","repos_url":"https://api.github.com/users/vehre/repos","events_url":"https://api.github.com/users/vehre/events{/privacy}","received_events_url":"https://api.github.com/users/vehre/received_events","type":"User","site_admin":false},"body":"This pull request removes code complexity and improves readability by replacing conditional compilation blocks by macro calls. The macros contain exactly the same code like the conditional compilation blocks, but are far easier to read and understand.\r\n\r\nThis pull request replaces #300.","created_at":"2017-01-09T13:46:32Z","updated_at":"2017-01-13T22:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ffc1ab29d56e9ca1956d3472063941811b24e18","assignee":{"login":"zbeekman","id":279612,"avatar_url":"https://avatars.githubusercontent.com/u/279612?v=3","gravatar_id":"","url":"https://api.github.com/users/zbeekman","html_url":"https://github.com/zbeekman","followers_url":"https://api.github.com/users/zbeekman/followers","following_url":"https://api.github.com/users/zbeekman/following{/other_user}","gists_url":"https://api.github.com/users/zbeekman/gists{/gist_id}","starred_url":"https://api.github.com/users/zbeekman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbeekman/subscriptions","organizations_url":"https://api.github.com/users/zbeekman/orgs","repos_url":"https://api.github.com/users/zbeekman/repos","events_url":"https://api.github.com/users/zbeekman/events{/privacy}","received_events_url":"https://api.github.com/users/zbeekman/received_events","type":"User","site_admin":false},"assignees":[{"login":"zbeekman","id":279612,"avatar_url":"https://avatars.githubusercontent.com/u/279612?v=3","gravatar_id":"","url":"https://api.github.com/users/zbeekman","html_url":"https://github.com/zbeekman","followers_url":"https://api.github.com/users/zbeekman/followers","following_url":"https://api.github.com/users/zbeekman/following{/other_user}","gists_url":"https://api.github.com/users/zbeekman/gists{/gist_id}","starred_url":"https://api.github.com/users/zbeekman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbeekman/subscriptions","organizations_url":"https://api.github.com/users/zbeekman/orgs","repos_url":"https://api.github.com/users/zbeekman/repos","events_url":"https://api.github.com/users/zbeekman/events{/privacy}","received_events_url":"https://api.github.com/users/zbeekman/received_events","type":"User","site_admin":false},{"login":"afanfa","id":8441559,"avatar_url":"https://avatars.githubusercontent.com/u/8441559?v=3","gravatar_id":"","url":"https://api.github.com/users/afanfa","html_url":"https://github.com/afanfa","followers_url":"https://api.github.com/users/afanfa/followers","following_url":"https://api.github.com/users/afanfa/following{/other_user}","gists_url":"https://api.github.com/users/afanfa/gists{/gist_id}","starred_url":"https://api.github.com/users/afanfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afanfa/subscriptions","organizations_url":"https://api.github.com/users/afanfa/orgs","repos_url":"https://api.github.com/users/afanfa/repos","events_url":"https://api.github.com/users/afanfa/events{/privacy}","received_events_url":"https://api.github.com/users/afanfa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303/commits","review_comments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303/comments","review_comment_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/303/comments","statuses_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/statuses/b70c19aaf7649c58394981487a8b52426daad38f","head":{"label":"sourceryinstitute:vehre/reduce_code_complexity","ref":"vehre/reduce_code_complexity","sha":"b70c19aaf7649c58394981487a8b52426daad38f","user":{"login":"sourceryinstitute","id":1010472,"avatar_url":"https://avatars.githubusercontent.com/u/1010472?v=3","gravatar_id":"","url":"https://api.github.com/users/sourceryinstitute","html_url":"https://github.com/sourceryinstitute","followers_url":"https://api.github.com/users/sourceryinstitute/followers","following_url":"https://api.github.com/users/sourceryinstitute/following{/other_user}","gists_url":"https://api.github.com/users/sourceryinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/sourceryinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourceryinstitute/subscriptions","organizations_url":"https://api.github.com/users/sourceryinstitute/orgs","repos_url":"https://api.github.com/users/sourceryinstitute/repos","events_url":"https://api.github.com/users/sourceryinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/sourceryinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34347971,"name":"opencoarrays","full_name":"sourceryinstitute/opencoarrays","owner":{"login":"sourceryinstitute","id":1010472,"avatar_url":"https://avatars.githubusercontent.com/u/1010472?v=3","gravatar_id":"","url":"https://api.github.com/users/sourceryinstitute","html_url":"https://github.com/sourceryinstitute","followers_url":"https://api.github.com/users/sourceryinstitute/followers","following_url":"https://api.github.com/users/sourceryinstitute/following{/other_user}","gists_url":"https://api.github.com/users/sourceryinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/sourceryinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourceryinstitute/subscriptions","organizations_url":"https://api.github.com/users/sourceryinstitute/orgs","repos_url":"https://api.github.com/users/sourceryinstitute/repos","events_url":"https://api.github.com/users/sourceryinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/sourceryinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourceryinstitute/opencoarrays","description":"A transport layer for coarray Fortran compilers. ","fork":false,"url":"https://api.github.com/repos/sourceryinstitute/opencoarrays","forks_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/forks","keys_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/teams","hooks_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/hooks","issue_events_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/events{/number}","events_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/events","assignees_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/assignees{/user}","branches_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/branches{/branch}","tags_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/tags","blobs_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/statuses/{sha}","languages_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/languages","stargazers_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/stargazers","contributors_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/contributors","subscribers_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/subscribers","subscription_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/subscription","commits_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/contents/{+path}","compare_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/merges","archive_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/downloads","issues_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues{/number}","pulls_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls{/number}","milestones_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/milestones{/number}","notifications_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/labels{/name}","releases_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/releases{/id}","deployments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/deployments","created_at":"2015-04-21T19:32:26Z","updated_at":"2017-01-13T14:20:18Z","pushed_at":"2017-01-13T16:46:13Z","git_url":"git://github.com/sourceryinstitute/opencoarrays.git","ssh_url":"git@github.com:sourceryinstitute/opencoarrays.git","clone_url":"https://github.com/sourceryinstitute/opencoarrays.git","svn_url":"https://github.com/sourceryinstitute/opencoarrays","homepage":"www.opencoarrays.org","size":5813,"stargazers_count":38,"watchers_count":38,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":42,"forks":22,"open_issues":42,"watchers":38,"default_branch":"master"}},"base":{"label":"sourceryinstitute:master","ref":"master","sha":"805347575955b7cb30e603ac3b8512e04cadb80e","user":{"login":"sourceryinstitute","id":1010472,"avatar_url":"https://avatars.githubusercontent.com/u/1010472?v=3","gravatar_id":"","url":"https://api.github.com/users/sourceryinstitute","html_url":"https://github.com/sourceryinstitute","followers_url":"https://api.github.com/users/sourceryinstitute/followers","following_url":"https://api.github.com/users/sourceryinstitute/following{/other_user}","gists_url":"https://api.github.com/users/sourceryinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/sourceryinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourceryinstitute/subscriptions","organizations_url":"https://api.github.com/users/sourceryinstitute/orgs","repos_url":"https://api.github.com/users/sourceryinstitute/repos","events_url":"https://api.github.com/users/sourceryinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/sourceryinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34347971,"name":"opencoarrays","full_name":"sourceryinstitute/opencoarrays","owner":{"login":"sourceryinstitute","id":1010472,"avatar_url":"https://avatars.githubusercontent.com/u/1010472?v=3","gravatar_id":"","url":"https://api.github.com/users/sourceryinstitute","html_url":"https://github.com/sourceryinstitute","followers_url":"https://api.github.com/users/sourceryinstitute/followers","following_url":"https://api.github.com/users/sourceryinstitute/following{/other_user}","gists_url":"https://api.github.com/users/sourceryinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/sourceryinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourceryinstitute/subscriptions","organizations_url":"https://api.github.com/users/sourceryinstitute/orgs","repos_url":"https://api.github.com/users/sourceryinstitute/repos","events_url":"https://api.github.com/users/sourceryinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/sourceryinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourceryinstitute/opencoarrays","description":"A transport layer for coarray Fortran compilers. ","fork":false,"url":"https://api.github.com/repos/sourceryinstitute/opencoarrays","forks_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/forks","keys_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/teams","hooks_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/hooks","issue_events_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/events{/number}","events_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/events","assignees_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/assignees{/user}","branches_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/branches{/branch}","tags_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/tags","blobs_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/statuses/{sha}","languages_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/languages","stargazers_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/stargazers","contributors_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/contributors","subscribers_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/subscribers","subscription_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/subscription","commits_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/contents/{+path}","compare_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/merges","archive_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/downloads","issues_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues{/number}","pulls_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls{/number}","milestones_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/milestones{/number}","notifications_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/labels{/name}","releases_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/releases{/id}","deployments_url":"https://api.github.com/repos/sourceryinstitute/opencoarrays/deployments","created_at":"2015-04-21T19:32:26Z","updated_at":"2017-01-13T14:20:18Z","pushed_at":"2017-01-13T16:46:13Z","git_url":"git://github.com/sourceryinstitute/opencoarrays.git","ssh_url":"git@github.com:sourceryinstitute/opencoarrays.git","clone_url":"https://github.com/sourceryinstitute/opencoarrays.git","svn_url":"https://github.com/sourceryinstitute/opencoarrays","homepage":"www.opencoarrays.org","size":5813,"stargazers_count":38,"watchers_count":38,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":42,"forks":22,"open_issues":42,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303"},"html":{"href":"https://github.com/sourceryinstitute/opencoarrays/pull/303"},"issue":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/303"},"comments":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/sourceryinstitute/opencoarrays/statuses/b70c19aaf7649c58394981487a8b52426daad38f"}}}}
{"actor":{"display_login":"zbeekman"}}