{"action":"opened","number":58,"pull_request":{"url":"https://api.github.com/repos/Avaq/Fluture/pulls/58","id":99955216,"html_url":"https://github.com/Avaq/Fluture/pull/58","diff_url":"https://github.com/Avaq/Fluture/pull/58.diff","patch_url":"https://github.com/Avaq/Fluture/pull/58.patch","issue_url":"https://api.github.com/repos/Avaq/Fluture/issues/58","number":58,"state":"open","locked":false,"title":"Add es5 support","user":{"login":"lithin","id":6726858,"avatar_url":"https://avatars.githubusercontent.com/u/6726858?v=3","gravatar_id":"","url":"https://api.github.com/users/lithin","html_url":"https://github.com/lithin","followers_url":"https://api.github.com/users/lithin/followers","following_url":"https://api.github.com/users/lithin/following{/other_user}","gists_url":"https://api.github.com/users/lithin/gists{/gist_id}","starred_url":"https://api.github.com/users/lithin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lithin/subscriptions","organizations_url":"https://api.github.com/users/lithin/orgs","repos_url":"https://api.github.com/users/lithin/repos","events_url":"https://api.github.com/users/lithin/events{/privacy}","received_events_url":"https://api.github.com/users/lithin/received_events","type":"User","site_admin":false},"body":"## Problem\r\nWhen doing uglification for our production app, we ran into problems with UglifyJS2 not supporting ES6.\r\n\r\n## Solution\r\nNormally, npm packages are transpiled when published so that users of the packages don't have to worry about their compatibility. I thought it might be best to give users the choice - by default they import ES6 version but optionally can `require('Fluture/es5')` to avoid issues when compiling for production.\r\n\r\nSame thing will need to be done for `inspect-f` as it's a dependency for Fluture. In which case, Fluture will need to require ES5 version of `inspect-f`.\r\n\r\nDo you think this would be a good way to go?\r\n","created_at":"2017-01-03T13:35:15Z","updated_at":"2017-01-03T13:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Avaq/Fluture/pulls/58/commits","review_comments_url":"https://api.github.com/repos/Avaq/Fluture/pulls/58/comments","review_comment_url":"https://api.github.com/repos/Avaq/Fluture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Avaq/Fluture/issues/58/comments","statuses_url":"https://api.github.com/repos/Avaq/Fluture/statuses/ab71b4c6c669d07c48547d3ccde584b7aeb4bb25","head":{"label":"lithin:add-es5-support","ref":"add-es5-support","sha":"ab71b4c6c669d07c48547d3ccde584b7aeb4bb25","user":{"login":"lithin","id":6726858,"avatar_url":"https://avatars.githubusercontent.com/u/6726858?v=3","gravatar_id":"","url":"https://api.github.com/users/lithin","html_url":"https://github.com/lithin","followers_url":"https://api.github.com/users/lithin/followers","following_url":"https://api.github.com/users/lithin/following{/other_user}","gists_url":"https://api.github.com/users/lithin/gists{/gist_id}","starred_url":"https://api.github.com/users/lithin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lithin/subscriptions","organizations_url":"https://api.github.com/users/lithin/orgs","repos_url":"https://api.github.com/users/lithin/repos","events_url":"https://api.github.com/users/lithin/events{/privacy}","received_events_url":"https://api.github.com/users/lithin/received_events","type":"User","site_admin":false},"repo":{"id":77906854,"name":"Fluture","full_name":"lithin/Fluture","owner":{"login":"lithin","id":6726858,"avatar_url":"https://avatars.githubusercontent.com/u/6726858?v=3","gravatar_id":"","url":"https://api.github.com/users/lithin","html_url":"https://github.com/lithin","followers_url":"https://api.github.com/users/lithin/followers","following_url":"https://api.github.com/users/lithin/following{/other_user}","gists_url":"https://api.github.com/users/lithin/gists{/gist_id}","starred_url":"https://api.github.com/users/lithin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lithin/subscriptions","organizations_url":"https://api.github.com/users/lithin/orgs","repos_url":"https://api.github.com/users/lithin/repos","events_url":"https://api.github.com/users/lithin/events{/privacy}","received_events_url":"https://api.github.com/users/lithin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lithin/Fluture","description":"FantasyLand compliant (monadic) alternative to Promises","fork":true,"url":"https://api.github.com/repos/lithin/Fluture","forks_url":"https://api.github.com/repos/lithin/Fluture/forks","keys_url":"https://api.github.com/repos/lithin/Fluture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lithin/Fluture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lithin/Fluture/teams","hooks_url":"https://api.github.com/repos/lithin/Fluture/hooks","issue_events_url":"https://api.github.com/repos/lithin/Fluture/issues/events{/number}","events_url":"https://api.github.com/repos/lithin/Fluture/events","assignees_url":"https://api.github.com/repos/lithin/Fluture/assignees{/user}","branches_url":"https://api.github.com/repos/lithin/Fluture/branches{/branch}","tags_url":"https://api.github.com/repos/lithin/Fluture/tags","blobs_url":"https://api.github.com/repos/lithin/Fluture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lithin/Fluture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lithin/Fluture/git/refs{/sha}","trees_url":"https://api.github.com/repos/lithin/Fluture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lithin/Fluture/statuses/{sha}","languages_url":"https://api.github.com/repos/lithin/Fluture/languages","stargazers_url":"https://api.github.com/repos/lithin/Fluture/stargazers","contributors_url":"https://api.github.com/repos/lithin/Fluture/contributors","subscribers_url":"https://api.github.com/repos/lithin/Fluture/subscribers","subscription_url":"https://api.github.com/repos/lithin/Fluture/subscription","commits_url":"https://api.github.com/repos/lithin/Fluture/commits{/sha}","git_commits_url":"https://api.github.com/repos/lithin/Fluture/git/commits{/sha}","comments_url":"https://api.github.com/repos/lithin/Fluture/comments{/number}","issue_comment_url":"https://api.github.com/repos/lithin/Fluture/issues/comments{/number}","contents_url":"https://api.github.com/repos/lithin/Fluture/contents/{+path}","compare_url":"https://api.github.com/repos/lithin/Fluture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lithin/Fluture/merges","archive_url":"https://api.github.com/repos/lithin/Fluture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lithin/Fluture/downloads","issues_url":"https://api.github.com/repos/lithin/Fluture/issues{/number}","pulls_url":"https://api.github.com/repos/lithin/Fluture/pulls{/number}","milestones_url":"https://api.github.com/repos/lithin/Fluture/milestones{/number}","notifications_url":"https://api.github.com/repos/lithin/Fluture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lithin/Fluture/labels{/name}","releases_url":"https://api.github.com/repos/lithin/Fluture/releases{/id}","deployments_url":"https://api.github.com/repos/lithin/Fluture/deployments","created_at":"2017-01-03T10:26:59Z","updated_at":"2017-01-03T10:27:03Z","pushed_at":"2017-01-03T12:18:25Z","git_url":"git://github.com/lithin/Fluture.git","ssh_url":"git@github.com:lithin/Fluture.git","clone_url":"https://github.com/lithin/Fluture.git","svn_url":"https://github.com/lithin/Fluture","homepage":"","size":378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Avaq:master","ref":"master","sha":"d9e7fffc386da872c7a47b4d9b6deb05424550c8","user":{"login":"Avaq","id":1217745,"avatar_url":"https://avatars.githubusercontent.com/u/1217745?v=3","gravatar_id":"","url":"https://api.github.com/users/Avaq","html_url":"https://github.com/Avaq","followers_url":"https://api.github.com/users/Avaq/followers","following_url":"https://api.github.com/users/Avaq/following{/other_user}","gists_url":"https://api.github.com/users/Avaq/gists{/gist_id}","starred_url":"https://api.github.com/users/Avaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avaq/subscriptions","organizations_url":"https://api.github.com/users/Avaq/orgs","repos_url":"https://api.github.com/users/Avaq/repos","events_url":"https://api.github.com/users/Avaq/events{/privacy}","received_events_url":"https://api.github.com/users/Avaq/received_events","type":"User","site_admin":false},"repo":{"id":53253439,"name":"Fluture","full_name":"Avaq/Fluture","owner":{"login":"Avaq","id":1217745,"avatar_url":"https://avatars.githubusercontent.com/u/1217745?v=3","gravatar_id":"","url":"https://api.github.com/users/Avaq","html_url":"https://github.com/Avaq","followers_url":"https://api.github.com/users/Avaq/followers","following_url":"https://api.github.com/users/Avaq/following{/other_user}","gists_url":"https://api.github.com/users/Avaq/gists{/gist_id}","starred_url":"https://api.github.com/users/Avaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avaq/subscriptions","organizations_url":"https://api.github.com/users/Avaq/orgs","repos_url":"https://api.github.com/users/Avaq/repos","events_url":"https://api.github.com/users/Avaq/events{/privacy}","received_events_url":"https://api.github.com/users/Avaq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Avaq/Fluture","description":"FantasyLand compliant (monadic) alternative to Promises","fork":false,"url":"https://api.github.com/repos/Avaq/Fluture","forks_url":"https://api.github.com/repos/Avaq/Fluture/forks","keys_url":"https://api.github.com/repos/Avaq/Fluture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Avaq/Fluture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Avaq/Fluture/teams","hooks_url":"https://api.github.com/repos/Avaq/Fluture/hooks","issue_events_url":"https://api.github.com/repos/Avaq/Fluture/issues/events{/number}","events_url":"https://api.github.com/repos/Avaq/Fluture/events","assignees_url":"https://api.github.com/repos/Avaq/Fluture/assignees{/user}","branches_url":"https://api.github.com/repos/Avaq/Fluture/branches{/branch}","tags_url":"https://api.github.com/repos/Avaq/Fluture/tags","blobs_url":"https://api.github.com/repos/Avaq/Fluture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Avaq/Fluture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Avaq/Fluture/git/refs{/sha}","trees_url":"https://api.github.com/repos/Avaq/Fluture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Avaq/Fluture/statuses/{sha}","languages_url":"https://api.github.com/repos/Avaq/Fluture/languages","stargazers_url":"https://api.github.com/repos/Avaq/Fluture/stargazers","contributors_url":"https://api.github.com/repos/Avaq/Fluture/contributors","subscribers_url":"https://api.github.com/repos/Avaq/Fluture/subscribers","subscription_url":"https://api.github.com/repos/Avaq/Fluture/subscription","commits_url":"https://api.github.com/repos/Avaq/Fluture/commits{/sha}","git_commits_url":"https://api.github.com/repos/Avaq/Fluture/git/commits{/sha}","comments_url":"https://api.github.com/repos/Avaq/Fluture/comments{/number}","issue_comment_url":"https://api.github.com/repos/Avaq/Fluture/issues/comments{/number}","contents_url":"https://api.github.com/repos/Avaq/Fluture/contents/{+path}","compare_url":"https://api.github.com/repos/Avaq/Fluture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Avaq/Fluture/merges","archive_url":"https://api.github.com/repos/Avaq/Fluture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Avaq/Fluture/downloads","issues_url":"https://api.github.com/repos/Avaq/Fluture/issues{/number}","pulls_url":"https://api.github.com/repos/Avaq/Fluture/pulls{/number}","milestones_url":"https://api.github.com/repos/Avaq/Fluture/milestones{/number}","notifications_url":"https://api.github.com/repos/Avaq/Fluture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Avaq/Fluture/labels{/name}","releases_url":"https://api.github.com/repos/Avaq/Fluture/releases{/id}","deployments_url":"https://api.github.com/repos/Avaq/Fluture/deployments","created_at":"2016-03-06T12:20:57Z","updated_at":"2017-01-03T11:42:40Z","pushed_at":"2017-01-03T11:00:10Z","git_url":"git://github.com/Avaq/Fluture.git","ssh_url":"git@github.com:Avaq/Fluture.git","clone_url":"https://github.com/Avaq/Fluture.git","svn_url":"https://github.com/Avaq/Fluture","homepage":"","size":384,"stargazers_count":232,"watchers_count":232,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Avaq/Fluture/pulls/58"},"html":{"href":"https://github.com/Avaq/Fluture/pull/58"},"issue":{"href":"https://api.github.com/repos/Avaq/Fluture/issues/58"},"comments":{"href":"https://api.github.com/repos/Avaq/Fluture/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/Avaq/Fluture/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/Avaq/Fluture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Avaq/Fluture/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/Avaq/Fluture/statuses/ab71b4c6c669d07c48547d3ccde584b7aeb4bb25"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":1611,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"lithin"}}