{"action":"created","comment":{"url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/comments/134454448","pull_request_review_id":57745371,"id":134454448,"diff_hunk":"@@ -1,60 +1,23 @@\n module V3\n   module Auth\n     class FederationController < ApplicationController\n-      TIME_FORMAT = '%Y-%m-%dT%H:%M:%S.%L000Z'.freeze\n+      include Timestampable\n+      include TokenRespondable\n \n       def oidc\n-        credentials = ::Auth::Oidc.unified_credentials(ENV.select { |name| name.start_with?('OIDC') })\n-        headers['X-Subject-Token'] = Utils::Tokenator.to_token(credentials.to_hash)\n-        render json: response_hash(credentials, 'oidc')\n+        auth_response(::Auth::Oidc, 'OIDC')","path":"app/controllers/v3/auth/federation_controller.rb","position":12,"original_position":12,"commit_id":"21effc0b4422180a3e50a5e6e76e6c370336e9ef","original_commit_id":"21effc0b4422180a3e50a5e6e76e6c370336e9ef","user":{"login":"arax","id":513793,"avatar_url":"https://avatars1.githubusercontent.com/u/513793?v=4","gravatar_id":"","url":"https://api.github.com/users/arax","html_url":"https://github.com/arax","followers_url":"https://api.github.com/users/arax/followers","following_url":"https://api.github.com/users/arax/following{/other_user}","gists_url":"https://api.github.com/users/arax/gists{/gist_id}","starred_url":"https://api.github.com/users/arax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arax/subscriptions","organizations_url":"https://api.github.com/users/arax/orgs","repos_url":"https://api.github.com/users/arax/repos","events_url":"https://api.github.com/users/arax/events{/privacy}","received_events_url":"https://api.github.com/users/arax/received_events","type":"User","site_admin":false},"body":"Unnecessary parentheses?","created_at":"2017-08-22T11:36:24Z","updated_at":"2017-08-22T11:56:59Z","html_url":"https://github.com/the-rocci-project/keystorm/pull/16#discussion_r134454448","pull_request_url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/comments/134454448"},"html":{"href":"https://github.com/the-rocci-project/keystorm/pull/16#discussion_r134454448"},"pull_request":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16","id":136932629,"html_url":"https://github.com/the-rocci-project/keystorm/pull/16","diff_url":"https://github.com/the-rocci-project/keystorm/pull/16.diff","patch_url":"https://github.com/the-rocci-project/keystorm/pull/16.patch","issue_url":"https://api.github.com/repos/the-rocci-project/keystorm/issues/16","number":16,"state":"open","locked":false,"title":"Scoped token generation","user":{"login":"Misenko","id":1655405,"avatar_url":"https://avatars0.githubusercontent.com/u/1655405?v=4","gravatar_id":"","url":"https://api.github.com/users/Misenko","html_url":"https://github.com/Misenko","followers_url":"https://api.github.com/users/Misenko/followers","following_url":"https://api.github.com/users/Misenko/following{/other_user}","gists_url":"https://api.github.com/users/Misenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Misenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misenko/subscriptions","organizations_url":"https://api.github.com/users/Misenko/orgs","repos_url":"https://api.github.com/users/Misenko/repos","events_url":"https://api.github.com/users/Misenko/events{/privacy}","received_events_url":"https://api.github.com/users/Misenko/received_events","type":"User","site_admin":false},"body":"Contains mainly changes for successful scoped token generation but contains also some not really related bugfixes.\r\n \r\nCloses #12 (among others)","created_at":"2017-08-22T09:29:44Z","updated_at":"2017-08-22T11:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4615b2cde45e08b7b99f72be7d3dbd496da0419a","assignee":{"login":"Misenko","id":1655405,"avatar_url":"https://avatars0.githubusercontent.com/u/1655405?v=4","gravatar_id":"","url":"https://api.github.com/users/Misenko","html_url":"https://github.com/Misenko","followers_url":"https://api.github.com/users/Misenko/followers","following_url":"https://api.github.com/users/Misenko/following{/other_user}","gists_url":"https://api.github.com/users/Misenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Misenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misenko/subscriptions","organizations_url":"https://api.github.com/users/Misenko/orgs","repos_url":"https://api.github.com/users/Misenko/repos","events_url":"https://api.github.com/users/Misenko/events{/privacy}","received_events_url":"https://api.github.com/users/Misenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"Misenko","id":1655405,"avatar_url":"https://avatars0.githubusercontent.com/u/1655405?v=4","gravatar_id":"","url":"https://api.github.com/users/Misenko","html_url":"https://github.com/Misenko","followers_url":"https://api.github.com/users/Misenko/followers","following_url":"https://api.github.com/users/Misenko/following{/other_user}","gists_url":"https://api.github.com/users/Misenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Misenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misenko/subscriptions","organizations_url":"https://api.github.com/users/Misenko/orgs","repos_url":"https://api.github.com/users/Misenko/repos","events_url":"https://api.github.com/users/Misenko/events{/privacy}","received_events_url":"https://api.github.com/users/Misenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16/commits","review_comments_url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16/comments","review_comment_url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/the-rocci-project/keystorm/issues/16/comments","statuses_url":"https://api.github.com/repos/the-rocci-project/keystorm/statuses/21effc0b4422180a3e50a5e6e76e6c370336e9ef","head":{"label":"Misenko:feature-scoped_token","ref":"feature-scoped_token","sha":"21effc0b4422180a3e50a5e6e76e6c370336e9ef","user":{"login":"Misenko","id":1655405,"avatar_url":"https://avatars0.githubusercontent.com/u/1655405?v=4","gravatar_id":"","url":"https://api.github.com/users/Misenko","html_url":"https://github.com/Misenko","followers_url":"https://api.github.com/users/Misenko/followers","following_url":"https://api.github.com/users/Misenko/following{/other_user}","gists_url":"https://api.github.com/users/Misenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Misenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misenko/subscriptions","organizations_url":"https://api.github.com/users/Misenko/orgs","repos_url":"https://api.github.com/users/Misenko/repos","events_url":"https://api.github.com/users/Misenko/events{/privacy}","received_events_url":"https://api.github.com/users/Misenko/received_events","type":"User","site_admin":false},"repo":{"id":97576349,"name":"keystorm","full_name":"Misenko/keystorm","owner":{"login":"Misenko","id":1655405,"avatar_url":"https://avatars0.githubusercontent.com/u/1655405?v=4","gravatar_id":"","url":"https://api.github.com/users/Misenko","html_url":"https://github.com/Misenko","followers_url":"https://api.github.com/users/Misenko/followers","following_url":"https://api.github.com/users/Misenko/following{/other_user}","gists_url":"https://api.github.com/users/Misenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Misenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misenko/subscriptions","organizations_url":"https://api.github.com/users/Misenko/orgs","repos_url":"https://api.github.com/users/Misenko/repos","events_url":"https://api.github.com/users/Misenko/events{/privacy}","received_events_url":"https://api.github.com/users/Misenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Misenko/keystorm","description":"Federated authentication component for rOCCI-server","fork":true,"url":"https://api.github.com/repos/Misenko/keystorm","forks_url":"https://api.github.com/repos/Misenko/keystorm/forks","keys_url":"https://api.github.com/repos/Misenko/keystorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Misenko/keystorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Misenko/keystorm/teams","hooks_url":"https://api.github.com/repos/Misenko/keystorm/hooks","issue_events_url":"https://api.github.com/repos/Misenko/keystorm/issues/events{/number}","events_url":"https://api.github.com/repos/Misenko/keystorm/events","assignees_url":"https://api.github.com/repos/Misenko/keystorm/assignees{/user}","branches_url":"https://api.github.com/repos/Misenko/keystorm/branches{/branch}","tags_url":"https://api.github.com/repos/Misenko/keystorm/tags","blobs_url":"https://api.github.com/repos/Misenko/keystorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Misenko/keystorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Misenko/keystorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Misenko/keystorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Misenko/keystorm/statuses/{sha}","languages_url":"https://api.github.com/repos/Misenko/keystorm/languages","stargazers_url":"https://api.github.com/repos/Misenko/keystorm/stargazers","contributors_url":"https://api.github.com/repos/Misenko/keystorm/contributors","subscribers_url":"https://api.github.com/repos/Misenko/keystorm/subscribers","subscription_url":"https://api.github.com/repos/Misenko/keystorm/subscription","commits_url":"https://api.github.com/repos/Misenko/keystorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Misenko/keystorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Misenko/keystorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Misenko/keystorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Misenko/keystorm/contents/{+path}","compare_url":"https://api.github.com/repos/Misenko/keystorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Misenko/keystorm/merges","archive_url":"https://api.github.com/repos/Misenko/keystorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Misenko/keystorm/downloads","issues_url":"https://api.github.com/repos/Misenko/keystorm/issues{/number}","pulls_url":"https://api.github.com/repos/Misenko/keystorm/pulls{/number}","milestones_url":"https://api.github.com/repos/Misenko/keystorm/milestones{/number}","notifications_url":"https://api.github.com/repos/Misenko/keystorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Misenko/keystorm/labels{/name}","releases_url":"https://api.github.com/repos/Misenko/keystorm/releases{/id}","deployments_url":"https://api.github.com/repos/Misenko/keystorm/deployments","created_at":"2017-07-18T08:53:08Z","updated_at":"2017-07-24T13:25:13Z","pushed_at":"2017-08-22T09:25:07Z","git_url":"git://github.com/Misenko/keystorm.git","ssh_url":"git@github.com:Misenko/keystorm.git","clone_url":"https://github.com/Misenko/keystorm.git","svn_url":"https://github.com/Misenko/keystorm","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"the-rocci-project:master","ref":"master","sha":"cc55ec21828b4d2b997c6ade61aa299c36623c76","user":{"login":"the-rocci-project","id":21381968,"avatar_url":"https://avatars1.githubusercontent.com/u/21381968?v=4","gravatar_id":"","url":"https://api.github.com/users/the-rocci-project","html_url":"https://github.com/the-rocci-project","followers_url":"https://api.github.com/users/the-rocci-project/followers","following_url":"https://api.github.com/users/the-rocci-project/following{/other_user}","gists_url":"https://api.github.com/users/the-rocci-project/gists{/gist_id}","starred_url":"https://api.github.com/users/the-rocci-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-rocci-project/subscriptions","organizations_url":"https://api.github.com/users/the-rocci-project/orgs","repos_url":"https://api.github.com/users/the-rocci-project/repos","events_url":"https://api.github.com/users/the-rocci-project/events{/privacy}","received_events_url":"https://api.github.com/users/the-rocci-project/received_events","type":"Organization","site_admin":false},"repo":{"id":97573069,"name":"keystorm","full_name":"the-rocci-project/keystorm","owner":{"login":"the-rocci-project","id":21381968,"avatar_url":"https://avatars1.githubusercontent.com/u/21381968?v=4","gravatar_id":"","url":"https://api.github.com/users/the-rocci-project","html_url":"https://github.com/the-rocci-project","followers_url":"https://api.github.com/users/the-rocci-project/followers","following_url":"https://api.github.com/users/the-rocci-project/following{/other_user}","gists_url":"https://api.github.com/users/the-rocci-project/gists{/gist_id}","starred_url":"https://api.github.com/users/the-rocci-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-rocci-project/subscriptions","organizations_url":"https://api.github.com/users/the-rocci-project/orgs","repos_url":"https://api.github.com/users/the-rocci-project/repos","events_url":"https://api.github.com/users/the-rocci-project/events{/privacy}","received_events_url":"https://api.github.com/users/the-rocci-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-rocci-project/keystorm","description":"Federated authentication component for rOCCI-server","fork":false,"url":"https://api.github.com/repos/the-rocci-project/keystorm","forks_url":"https://api.github.com/repos/the-rocci-project/keystorm/forks","keys_url":"https://api.github.com/repos/the-rocci-project/keystorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-rocci-project/keystorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-rocci-project/keystorm/teams","hooks_url":"https://api.github.com/repos/the-rocci-project/keystorm/hooks","issue_events_url":"https://api.github.com/repos/the-rocci-project/keystorm/issues/events{/number}","events_url":"https://api.github.com/repos/the-rocci-project/keystorm/events","assignees_url":"https://api.github.com/repos/the-rocci-project/keystorm/assignees{/user}","branches_url":"https://api.github.com/repos/the-rocci-project/keystorm/branches{/branch}","tags_url":"https://api.github.com/repos/the-rocci-project/keystorm/tags","blobs_url":"https://api.github.com/repos/the-rocci-project/keystorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-rocci-project/keystorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-rocci-project/keystorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-rocci-project/keystorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-rocci-project/keystorm/statuses/{sha}","languages_url":"https://api.github.com/repos/the-rocci-project/keystorm/languages","stargazers_url":"https://api.github.com/repos/the-rocci-project/keystorm/stargazers","contributors_url":"https://api.github.com/repos/the-rocci-project/keystorm/contributors","subscribers_url":"https://api.github.com/repos/the-rocci-project/keystorm/subscribers","subscription_url":"https://api.github.com/repos/the-rocci-project/keystorm/subscription","commits_url":"https://api.github.com/repos/the-rocci-project/keystorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-rocci-project/keystorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-rocci-project/keystorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-rocci-project/keystorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-rocci-project/keystorm/contents/{+path}","compare_url":"https://api.github.com/repos/the-rocci-project/keystorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-rocci-project/keystorm/merges","archive_url":"https://api.github.com/repos/the-rocci-project/keystorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-rocci-project/keystorm/downloads","issues_url":"https://api.github.com/repos/the-rocci-project/keystorm/issues{/number}","pulls_url":"https://api.github.com/repos/the-rocci-project/keystorm/pulls{/number}","milestones_url":"https://api.github.com/repos/the-rocci-project/keystorm/milestones{/number}","notifications_url":"https://api.github.com/repos/the-rocci-project/keystorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-rocci-project/keystorm/labels{/name}","releases_url":"https://api.github.com/repos/the-rocci-project/keystorm/releases{/id}","deployments_url":"https://api.github.com/repos/the-rocci-project/keystorm/deployments","created_at":"2017-07-18T08:22:07Z","updated_at":"2017-07-20T08:35:51Z","pushed_at":"2017-08-22T09:29:45Z","git_url":"git://github.com/the-rocci-project/keystorm.git","ssh_url":"git@github.com:the-rocci-project/keystorm.git","clone_url":"https://github.com/the-rocci-project/keystorm.git","svn_url":"https://github.com/the-rocci-project/keystorm","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16"},"html":{"href":"https://github.com/the-rocci-project/keystorm/pull/16"},"issue":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/issues/16"},"comments":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/the-rocci-project/keystorm/statuses/21effc0b4422180a3e50a5e6e76e6c370336e9ef"}}}}
{"actor":{"display_login":"arax"}}