{"action":"closed","number":41687,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/41687","id":124973883,"html_url":"https://github.com/saltstack/salt/pull/41687","diff_url":"https://github.com/saltstack/salt/pull/41687.diff","patch_url":"https://github.com/saltstack/salt/pull/41687.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/41687","number":41687,"state":"closed","locked":false,"title":"Return an event when salt runner has an Salt exception","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars3.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nAdds the ability for events to fire back to the event bus when non-existing runner functions are called.\r\n\r\n### What issues does this PR fix or reference?\r\n#41618 \r\n\r\n### Previous Behavior\r\nPreviously when running a Salt runner that did not exist, the CLI would return stating that the desired function did not exist but no event was fired to the event bus.\r\n\r\n### New Behavior\r\nThis change changes the functionality and in the event that an exception is caught when running a salt runner is called an event is fired to the event bus with the information about the failed salt runner.\r\n\r\n### Tests written?\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n","created_at":"2017-06-10T01:47:39Z","updated_at":"2017-06-14T21:55:36Z","closed_at":"2017-06-14T21:55:36Z","merged_at":"2017-06-14T21:55:36Z","merge_commit_sha":"e932f43bbffc12216c0fd6f5ad0fda2e1e53b297","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/41687/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/41687/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/41687/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/54dcbcadb3c9d4589a06c52110d4b802a2394b78","head":{"label":"garethgreenaway:41618_runner_return_event_bad_function","ref":"41618_runner_return_event_bad_function","sha":"54dcbcadb3c9d4589a06c52110d4b802a2394b78","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars3.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"repo":{"id":29325120,"name":"salt","full_name":"garethgreenaway/salt","owner":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars3.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethgreenaway/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/garethgreenaway/salt","forks_url":"https://api.github.com/repos/garethgreenaway/salt/forks","keys_url":"https://api.github.com/repos/garethgreenaway/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethgreenaway/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethgreenaway/salt/teams","hooks_url":"https://api.github.com/repos/garethgreenaway/salt/hooks","issue_events_url":"https://api.github.com/repos/garethgreenaway/salt/issues/events{/number}","events_url":"https://api.github.com/repos/garethgreenaway/salt/events","assignees_url":"https://api.github.com/repos/garethgreenaway/salt/assignees{/user}","branches_url":"https://api.github.com/repos/garethgreenaway/salt/branches{/branch}","tags_url":"https://api.github.com/repos/garethgreenaway/salt/tags","blobs_url":"https://api.github.com/repos/garethgreenaway/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethgreenaway/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethgreenaway/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethgreenaway/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethgreenaway/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/garethgreenaway/salt/languages","stargazers_url":"https://api.github.com/repos/garethgreenaway/salt/stargazers","contributors_url":"https://api.github.com/repos/garethgreenaway/salt/contributors","subscribers_url":"https://api.github.com/repos/garethgreenaway/salt/subscribers","subscription_url":"https://api.github.com/repos/garethgreenaway/salt/subscription","commits_url":"https://api.github.com/repos/garethgreenaway/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethgreenaway/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethgreenaway/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethgreenaway/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethgreenaway/salt/contents/{+path}","compare_url":"https://api.github.com/repos/garethgreenaway/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethgreenaway/salt/merges","archive_url":"https://api.github.com/repos/garethgreenaway/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethgreenaway/salt/downloads","issues_url":"https://api.github.com/repos/garethgreenaway/salt/issues{/number}","pulls_url":"https://api.github.com/repos/garethgreenaway/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/garethgreenaway/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/garethgreenaway/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethgreenaway/salt/labels{/name}","releases_url":"https://api.github.com/repos/garethgreenaway/salt/releases{/id}","deployments_url":"https://api.github.com/repos/garethgreenaway/salt/deployments","created_at":"2015-01-16T00:28:10Z","updated_at":"2016-02-08T00:06:44Z","pushed_at":"2017-06-14T17:46:47Z","git_url":"git://github.com/garethgreenaway/salt.git","ssh_url":"git@github.com:garethgreenaway/salt.git","clone_url":"https://github.com/garethgreenaway/salt.git","svn_url":"https://github.com/garethgreenaway/salt","homepage":"saltstack.com","size":168503,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"b095ce87982558bb227139d3ee5a80e8ad790da6","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-06-14T19:44:21Z","pushed_at":"2017-06-14T21:55:36Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":170576,"stargazers_count":7771,"watchers_count":7771,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3604,"mirror_url":null,"open_issues_count":4448,"forks":3604,"open_issues":4448,"watchers":7771,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/41687"},"html":{"href":"https://github.com/saltstack/salt/pull/41687"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/41687"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/41687/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/41687/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/41687/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/54dcbcadb3c9d4589a06c52110d4b802a2394b78"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars0.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":17,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"cachedout"}}