{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/12810","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/12810/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/12810/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/12810/events","html_url":"https://github.com/Automattic/wp-calypso/pull/12810","id":219570319,"number":12810,"title":"Signup: Add a new WPCC flow to accept signups coming from DOPS","user":{"login":"scruffian","id":275961,"avatar_url":"https://avatars2.githubusercontent.com/u/275961?v=3","gravatar_id":"","url":"https://api.github.com/users/scruffian","html_url":"https://github.com/scruffian","followers_url":"https://api.github.com/users/scruffian/followers","following_url":"https://api.github.com/users/scruffian/following{/other_user}","gists_url":"https://api.github.com/users/scruffian/gists{/gist_id}","starred_url":"https://api.github.com/users/scruffian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scruffian/subscriptions","organizations_url":"https://api.github.com/users/scruffian/orgs","repos_url":"https://api.github.com/users/scruffian/repos","events_url":"https://api.github.com/users/scruffian/events{/privacy}","received_events_url":"https://api.github.com/users/scruffian/received_events","type":"User","site_admin":false},"labels":[{"id":285010049,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Signup","name":"Signup","color":"006b75","default":false},{"id":542899089,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Size]%20M","name":"[Size] M","color":"8d478a","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"scruffian","id":275961,"avatar_url":"https://avatars2.githubusercontent.com/u/275961?v=3","gravatar_id":"","url":"https://api.github.com/users/scruffian","html_url":"https://github.com/scruffian","followers_url":"https://api.github.com/users/scruffian/followers","following_url":"https://api.github.com/users/scruffian/following{/other_user}","gists_url":"https://api.github.com/users/scruffian/gists{/gist_id}","starred_url":"https://api.github.com/users/scruffian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scruffian/subscriptions","organizations_url":"https://api.github.com/users/scruffian/orgs","repos_url":"https://api.github.com/users/scruffian/repos","events_url":"https://api.github.com/users/scruffian/events{/privacy}","received_events_url":"https://api.github.com/users/scruffian/received_events","type":"User","site_admin":false},"assignees":[{"login":"scruffian","id":275961,"avatar_url":"https://avatars2.githubusercontent.com/u/275961?v=3","gravatar_id":"","url":"https://api.github.com/users/scruffian","html_url":"https://github.com/scruffian","followers_url":"https://api.github.com/users/scruffian/followers","following_url":"https://api.github.com/users/scruffian/following{/other_user}","gists_url":"https://api.github.com/users/scruffian/gists{/gist_id}","starred_url":"https://api.github.com/users/scruffian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scruffian/subscriptions","organizations_url":"https://api.github.com/users/scruffian/orgs","repos_url":"https://api.github.com/users/scruffian/repos","events_url":"https://api.github.com/users/scruffian/events{/privacy}","received_events_url":"https://api.github.com/users/scruffian/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-04-05T12:45:30Z","updated_at":"2017-05-17T15:41:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/12810","html_url":"https://github.com/Automattic/wp-calypso/pull/12810","diff_url":"https://github.com/Automattic/wp-calypso/pull/12810.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/12810.patch"},"body":"This pull request adds a new signup flow which accepts signup for DOPS. It accepts an oauth2_redirect parameter and uses this to redirect the user back to the service they came from.\r\n\r\nRight now this doesn't customize the flows at all. We should do this, but I propose we leave that for a subsequent PR.\r\n  \r\n#### Testing instructions\r\n  \r\n1. Run `git checkout add/wpcc` and start your server\r\n2. Apply patch D5640-code\r\n2. Open the [Akismet](http://akismet.com/) in an incognito window\r\n3. Selet WordPress.com Connect and then \"Create an account\"\r\n3. You should be redirect the http://calypso.localhost:3000/start/wpcc, with a long query string.\r\n3. Create an account, and check that you are redirected back to Akismet and logged in to WordPress.com\r\n  \r\n#### Additional notes\r\n\r\nWe need to test all DOPS.\r\nWe should confirm that invalid values for oauth2_redirect do not work.\r\n  \r\n#### Reviews\r\n  \r\n- [ ] Code\r\n- [ ] Product\r\n   \r\n@Automattic/sdev-feed"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/302131335","html_url":"https://github.com/Automattic/wp-calypso/pull/12810#issuecomment-302131335","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/12810","id":302131335,"user":{"login":"fabianapsimoes","id":1248436,"avatar_url":"https://avatars1.githubusercontent.com/u/1248436?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianapsimoes","html_url":"https://github.com/fabianapsimoes","followers_url":"https://api.github.com/users/fabianapsimoes/followers","following_url":"https://api.github.com/users/fabianapsimoes/following{/other_user}","gists_url":"https://api.github.com/users/fabianapsimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianapsimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianapsimoes/subscriptions","organizations_url":"https://api.github.com/users/fabianapsimoes/orgs","repos_url":"https://api.github.com/users/fabianapsimoes/repos","events_url":"https://api.github.com/users/fabianapsimoes/events{/privacy}","received_events_url":"https://api.github.com/users/fabianapsimoes/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T15:41:18Z","updated_at":"2017-05-17T15:41:18Z","body":"Right now, I'm redirected to `wp-login.php` after I click Continue in the processing screen. I see an error saying: \"Your account has not been activated. We sent you an email with a link to activate\". I suppose that should have been displayed back in the service's website.\r\n\r\nFor the record, the account is created and I do receive the confirmation email. Tested with both Akismet and VaultPress. \r\n\r\nAnother issue is that if I use the login flow via the link in `/start/wpcc`, I'm redirected to Calypso and not back to the service's website."}}
{"actor":{"display_login":"fabianapsimoes"}}