{"action":"created","issue":{"url":"https://api.github.com/repos/getsentry/sentry/issues/5913","repository_url":"https://api.github.com/repos/getsentry/sentry","labels_url":"https://api.github.com/repos/getsentry/sentry/issues/5913/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/5913/comments","events_url":"https://api.github.com/repos/getsentry/sentry/issues/5913/events","html_url":"https://github.com/getsentry/sentry/pull/5913","id":251103361,"number":5913,"title":"Adding global email model","user":{"login":"ehfeng","id":279398,"avatar_url":"https://avatars0.githubusercontent.com/u/279398?v=4","gravatar_id":"","url":"https://api.github.com/users/ehfeng","html_url":"https://github.com/ehfeng","followers_url":"https://api.github.com/users/ehfeng/followers","following_url":"https://api.github.com/users/ehfeng/following{/other_user}","gists_url":"https://api.github.com/users/ehfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/ehfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehfeng/subscriptions","organizations_url":"https://api.github.com/users/ehfeng/orgs","repos_url":"https://api.github.com/users/ehfeng/repos","events_url":"https://api.github.com/users/ehfeng/events{/privacy}","received_events_url":"https://api.github.com/users/ehfeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-17T23:50:05Z","updated_at":"2017-08-21T18:44:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/5913","html_url":"https://github.com/getsentry/sentry/pull/5913","diff_url":"https://github.com/getsentry/sentry/pull/5913.diff","patch_url":"https://github.com/getsentry/sentry/pull/5913.patch"},"body":"Because emails are not distinct per `User`, we're using the `Email` to store email-specific settings (email subscription state). `UserEmail` will represent verification that a given user \"owns\" an email address.\r\n\r\nAlternatively, `UserEmail.email` could just be a key for `Email.id`, where the id value is the email string. The value for this seems minimal (`UserEmail.email` is never updated in place, so the chance of `UserEmail.email != UserEmail.global_email.email` is low), so I've done the more naive approach."},"comment":{"url":"https://api.github.com/repos/getsentry/sentry/issues/comments/323820960","html_url":"https://github.com/getsentry/sentry/pull/5913#issuecomment-323820960","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/5913","id":323820960,"user":{"login":"ehfeng","id":279398,"avatar_url":"https://avatars0.githubusercontent.com/u/279398?v=4","gravatar_id":"","url":"https://api.github.com/users/ehfeng","html_url":"https://github.com/ehfeng","followers_url":"https://api.github.com/users/ehfeng/followers","following_url":"https://api.github.com/users/ehfeng/following{/other_user}","gists_url":"https://api.github.com/users/ehfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/ehfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehfeng/subscriptions","organizations_url":"https://api.github.com/users/ehfeng/orgs","repos_url":"https://api.github.com/users/ehfeng/repos","events_url":"https://api.github.com/users/ehfeng/events{/privacy}","received_events_url":"https://api.github.com/users/ehfeng/received_events","type":"User","site_admin":false},"created_at":"2017-08-21T18:44:53Z","updated_at":"2017-08-21T18:44:53Z","body":"@mattrobenolt I could modify it such that the host is case insensitive, but the username part of email [can be case-sensitive](https://stackoverflow.com/questions/9807909/are-email-addresses-case-sensitive). Obviously, Gmail, Yahoo, and Outlook make the username case-insensitive, so we could be the same, but email standard itself mandates case sensitivity.\r\n\r\nI'm not sure if this would be a security issue—I'll defer to whatever you decide."}}
{"actor":{"display_login":"ehfeng"}}