{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/755","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/755/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/755/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/755/events","html_url":"https://github.com/junit-team/junit5/issues/755","id":218134133,"number":755,"title":"Remove final from EngineDescriptor.getType()","user":{"login":"jlink","id":103937,"avatar_url":"https://avatars0.githubusercontent.com/u/103937?v=3","gravatar_id":"","url":"https://api.github.com/users/jlink","html_url":"https://github.com/jlink","followers_url":"https://api.github.com/users/jlink/followers","following_url":"https://api.github.com/users/jlink/following{/other_user}","gists_url":"https://api.github.com/users/jlink/gists{/gist_id}","starred_url":"https://api.github.com/users/jlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlink/subscriptions","organizations_url":"https://api.github.com/users/jlink/orgs","repos_url":"https://api.github.com/users/jlink/repos","events_url":"https://api.github.com/users/jlink/events{/privacy}","received_events_url":"https://api.github.com/users/jlink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mmerdes","id":9845887,"avatar_url":"https://avatars3.githubusercontent.com/u/9845887?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerdes","html_url":"https://github.com/mmerdes","followers_url":"https://api.github.com/users/mmerdes/followers","following_url":"https://api.github.com/users/mmerdes/following{/other_user}","gists_url":"https://api.github.com/users/mmerdes/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerdes/subscriptions","organizations_url":"https://api.github.com/users/mmerdes/orgs","repos_url":"https://api.github.com/users/mmerdes/repos","events_url":"https://api.github.com/users/mmerdes/events{/privacy}","received_events_url":"https://api.github.com/users/mmerdes/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmerdes","id":9845887,"avatar_url":"https://avatars3.githubusercontent.com/u/9845887?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerdes","html_url":"https://github.com/mmerdes","followers_url":"https://api.github.com/users/mmerdes/followers","following_url":"https://api.github.com/users/mmerdes/following{/other_user}","gists_url":"https://api.github.com/users/mmerdes/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerdes/subscriptions","organizations_url":"https://api.github.com/users/mmerdes/orgs","repos_url":"https://api.github.com/users/mmerdes/repos","events_url":"https://api.github.com/users/mmerdes/events{/privacy}","received_events_url":"https://api.github.com/users/mmerdes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-30T09:26:36Z","updated_at":"2017-03-30T14:09:12Z","closed_at":null,"body":"While implementing a minimal engine with @mmerdes we got bitten by the fact that we cannot override `EngineDescriptor.getType()` with `return Type.Test`. \r\n\r\nThis would be very useful for an engine that does nothing but delegate to an external tool for running tests. In case there is no strong rationale for not allowing an engine to be an executable test itself. \r\n\r\nA possible workaroung might be to override `TestDescriptor.isTest()` and `isContainer()` but then `getType()` and `isTest()` would no longer be consistent."},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/290422055","html_url":"https://github.com/junit-team/junit5/issues/755#issuecomment-290422055","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/755","id":290422055,"user":{"login":"sormuras","id":2319838,"avatar_url":"https://avatars2.githubusercontent.com/u/2319838?v=3","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T14:09:12Z","updated_at":"2017-03-30T14:09:12Z","body":"The `final` was only introduced because of the `Type.ENGINE` constant, which I thought was a fundamental building block that never will neither be a container nor a test. What about an explicite `Type.ENGINE_AND_TEST` constant? Feels a bit like an overkill."}}
{"actor":{"display_login":"sormuras"}}