{"action":"created","issue":{"url":"https://api.github.com/repos/erlang/otp/issues/1396","repository_url":"https://api.github.com/repos/erlang/otp","labels_url":"https://api.github.com/repos/erlang/otp/issues/1396/labels{/name}","comments_url":"https://api.github.com/repos/erlang/otp/issues/1396/comments","events_url":"https://api.github.com/repos/erlang/otp/issues/1396/events","html_url":"https://github.com/erlang/otp/pull/1396","id":218191919,"number":1396,"title":"crypto: replace AES test vectors with validation data from NIST CAVP program","user":{"login":"RoadRunnr","id":336945,"avatar_url":"https://avatars0.githubusercontent.com/u/336945?v=3","gravatar_id":"","url":"https://api.github.com/users/RoadRunnr","html_url":"https://github.com/RoadRunnr","followers_url":"https://api.github.com/users/RoadRunnr/followers","following_url":"https://api.github.com/users/RoadRunnr/following{/other_user}","gists_url":"https://api.github.com/users/RoadRunnr/gists{/gist_id}","starred_url":"https://api.github.com/users/RoadRunnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoadRunnr/subscriptions","organizations_url":"https://api.github.com/users/RoadRunnr/orgs","repos_url":"https://api.github.com/users/RoadRunnr/repos","events_url":"https://api.github.com/users/RoadRunnr/events{/privacy}","received_events_url":"https://api.github.com/users/RoadRunnr/received_events","type":"User","site_admin":false},"labels":[{"id":356873828,"url":"https://api.github.com/repos/erlang/otp/labels/stalled","name":"stalled","color":"b60205","default":false},{"id":356265357,"url":"https://api.github.com/repos/erlang/otp/labels/team:PS","name":"team:PS","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-30T13:10:41Z","updated_at":"2017-05-03T14:32:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/1396","html_url":"https://github.com/erlang/otp/pull/1396","diff_url":"https://github.com/erlang/otp/pull/1396.diff","patch_url":"https://github.com/erlang/otp/pull/1396.patch"},"body":"This replaces the hard coded test values for AES, CMAC and GCM ciphers with the full validation set from NIST's CAVP program.\r\n\r\nWithout #1393 this causes the aes_cfb128 for keysize != 128 to fail. This is expected as aes_cfb128 is broken without the fixes from #1393.\r\n\r\nThe CMAC and especially the GCM test data take a lot of memory, up to 10GByte for the full data set without a intermediate garbage collection. A forced garbage collection after the data loading helps a bit and brings down the memory usage to about 5GByte."},"comment":{"url":"https://api.github.com/repos/erlang/otp/issues/comments/298928707","html_url":"https://github.com/erlang/otp/pull/1396#issuecomment-298928707","issue_url":"https://api.github.com/repos/erlang/otp/issues/1396","id":298928707,"user":{"login":"RoadRunnr","id":336945,"avatar_url":"https://avatars0.githubusercontent.com/u/336945?v=3","gravatar_id":"","url":"https://api.github.com/users/RoadRunnr","html_url":"https://github.com/RoadRunnr","followers_url":"https://api.github.com/users/RoadRunnr/followers","following_url":"https://api.github.com/users/RoadRunnr/following{/other_user}","gists_url":"https://api.github.com/users/RoadRunnr/gists{/gist_id}","starred_url":"https://api.github.com/users/RoadRunnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoadRunnr/subscriptions","organizations_url":"https://api.github.com/users/RoadRunnr/orgs","repos_url":"https://api.github.com/users/RoadRunnr/repos","events_url":"https://api.github.com/users/RoadRunnr/events{/privacy}","received_events_url":"https://api.github.com/users/RoadRunnr/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T14:32:37Z","updated_at":"2017-05-03T14:32:37Z","body":"Found the cause for the excessive memory usage. Turns out it's common_test fault. When it attempts to serialize the config, it uses all the memory.\r\n\r\nSwitching to laze_eval solves that and keep the test data out of the log."}}
{"actor":{"display_login":"RoadRunnr"}}