{"action":"created","comment":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/140079608","pull_request_review_id":64101297,"id":140079608,"diff_hunk":"@@ -86,12 +86,14 @@ azkaban.JobEditView = Backbone.View.extend({\n       mythis.overrideParams = overrideParams;\n       mythis.generalParams = generalParams;\n \n-      for (var okey in overrideParams) {\n-        if (okey != 'type' && okey != 'dependencies') {\n-          var row = handleAddRow();\n-          var td = $(row).find('span');\n-          $(td[0]).text(okey);\n-          $(td[1]).text(overrideParams[okey]);\n+      if (overrideParams && $(\".editRow\").length == 0)  {","path":"azkaban-web-server/src/web/js/azkaban/view/job-edit.js","position":10,"original_position":10,"commit_id":"1303053287335b1e57536c20caf4eee12a1d0658","original_commit_id":"1303053287335b1e57536c20caf4eee12a1d0658","user":{"login":"armisael","id":71387,"avatar_url":"https://avatars1.githubusercontent.com/u/71387?v=4","gravatar_id":"","url":"https://api.github.com/users/armisael","html_url":"https://github.com/armisael","followers_url":"https://api.github.com/users/armisael/followers","following_url":"https://api.github.com/users/armisael/following{/other_user}","gists_url":"https://api.github.com/users/armisael/gists{/gist_id}","starred_url":"https://api.github.com/users/armisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armisael/subscriptions","organizations_url":"https://api.github.com/users/armisael/orgs","repos_url":"https://api.github.com/users/armisael/repos","events_url":"https://api.github.com/users/armisael/events{/privacy}","received_events_url":"https://api.github.com/users/armisael/received_events","type":"User","site_admin":false},"body":"Apparently the bug appears only if you close the dialog by clicking outside of it; if you hit `Cancel` instead, the properties correctly appear only once.","created_at":"2017-09-20T20:11:53Z","updated_at":"2017-09-20T20:11:54Z","html_url":"https://github.com/azkaban/azkaban/pull/1493#discussion_r140079608","pull_request_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1493","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/140079608"},"html":{"href":"https://github.com/azkaban/azkaban/pull/1493#discussion_r140079608"},"pull_request":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1493"}},"in_reply_to_id":140031227},"pull_request":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/1493","id":142021259,"html_url":"https://github.com/azkaban/azkaban/pull/1493","diff_url":"https://github.com/azkaban/azkaban/pull/1493.diff","patch_url":"https://github.com/azkaban/azkaban/pull/1493.patch","issue_url":"https://api.github.com/repos/azkaban/azkaban/issues/1493","number":1493,"state":"open","locked":false,"title":"fix bug #1481: avoid duplicate properties when closing/reopening dialog","user":{"login":"armisael","id":71387,"avatar_url":"https://avatars1.githubusercontent.com/u/71387?v=4","gravatar_id":"","url":"https://api.github.com/users/armisael","html_url":"https://github.com/armisael","followers_url":"https://api.github.com/users/armisael/followers","following_url":"https://api.github.com/users/armisael/following{/other_user}","gists_url":"https://api.github.com/users/armisael/gists{/gist_id}","starred_url":"https://api.github.com/users/armisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armisael/subscriptions","organizations_url":"https://api.github.com/users/armisael/orgs","repos_url":"https://api.github.com/users/armisael/repos","events_url":"https://api.github.com/users/armisael/events{/privacy}","received_events_url":"https://api.github.com/users/armisael/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-20T06:43:14Z","updated_at":"2017-09-20T20:11:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65ae776866f8b7ca0292d50e73e1dc4471415388","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azkaban/azkaban/issues/1493/comments","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/1303053287335b1e57536c20caf4eee12a1d0658","head":{"label":"armisael:bugfix/1481","ref":"bugfix/1481","sha":"1303053287335b1e57536c20caf4eee12a1d0658","user":{"login":"armisael","id":71387,"avatar_url":"https://avatars1.githubusercontent.com/u/71387?v=4","gravatar_id":"","url":"https://api.github.com/users/armisael","html_url":"https://github.com/armisael","followers_url":"https://api.github.com/users/armisael/followers","following_url":"https://api.github.com/users/armisael/following{/other_user}","gists_url":"https://api.github.com/users/armisael/gists{/gist_id}","starred_url":"https://api.github.com/users/armisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armisael/subscriptions","organizations_url":"https://api.github.com/users/armisael/orgs","repos_url":"https://api.github.com/users/armisael/repos","events_url":"https://api.github.com/users/armisael/events{/privacy}","received_events_url":"https://api.github.com/users/armisael/received_events","type":"User","site_admin":false},"repo":{"id":104176227,"name":"azkaban","full_name":"armisael/azkaban","owner":{"login":"armisael","id":71387,"avatar_url":"https://avatars1.githubusercontent.com/u/71387?v=4","gravatar_id":"","url":"https://api.github.com/users/armisael","html_url":"https://github.com/armisael","followers_url":"https://api.github.com/users/armisael/followers","following_url":"https://api.github.com/users/armisael/following{/other_user}","gists_url":"https://api.github.com/users/armisael/gists{/gist_id}","starred_url":"https://api.github.com/users/armisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armisael/subscriptions","organizations_url":"https://api.github.com/users/armisael/orgs","repos_url":"https://api.github.com/users/armisael/repos","events_url":"https://api.github.com/users/armisael/events{/privacy}","received_events_url":"https://api.github.com/users/armisael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/armisael/azkaban","description":"Azkaban workflow manager.","fork":true,"url":"https://api.github.com/repos/armisael/azkaban","forks_url":"https://api.github.com/repos/armisael/azkaban/forks","keys_url":"https://api.github.com/repos/armisael/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armisael/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armisael/azkaban/teams","hooks_url":"https://api.github.com/repos/armisael/azkaban/hooks","issue_events_url":"https://api.github.com/repos/armisael/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/armisael/azkaban/events","assignees_url":"https://api.github.com/repos/armisael/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/armisael/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/armisael/azkaban/tags","blobs_url":"https://api.github.com/repos/armisael/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armisael/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armisael/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/armisael/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armisael/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/armisael/azkaban/languages","stargazers_url":"https://api.github.com/repos/armisael/azkaban/stargazers","contributors_url":"https://api.github.com/repos/armisael/azkaban/contributors","subscribers_url":"https://api.github.com/repos/armisael/azkaban/subscribers","subscription_url":"https://api.github.com/repos/armisael/azkaban/subscription","commits_url":"https://api.github.com/repos/armisael/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/armisael/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/armisael/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/armisael/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/armisael/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/armisael/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armisael/azkaban/merges","archive_url":"https://api.github.com/repos/armisael/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armisael/azkaban/downloads","issues_url":"https://api.github.com/repos/armisael/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/armisael/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/armisael/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/armisael/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armisael/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/armisael/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/armisael/azkaban/deployments","created_at":"2017-09-20T06:39:51Z","updated_at":"2017-09-20T06:39:55Z","pushed_at":"2017-09-20T06:42:37Z","git_url":"git://github.com/armisael/azkaban.git","ssh_url":"git@github.com:armisael/azkaban.git","clone_url":"https://github.com/armisael/azkaban.git","svn_url":"https://github.com/armisael/azkaban","homepage":"https://azkaban.github.io","size":35508,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azkaban:master","ref":"master","sha":"b4d893fd7fd02fe50c090a1de55e6baf26ee5108","user":{"login":"azkaban","id":213618,"avatar_url":"https://avatars0.githubusercontent.com/u/213618?v=4","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"repo":{"id":6271421,"name":"azkaban","full_name":"azkaban/azkaban","owner":{"login":"azkaban","id":213618,"avatar_url":"https://avatars0.githubusercontent.com/u/213618?v=4","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azkaban/azkaban","description":"Azkaban workflow manager.","fork":false,"url":"https://api.github.com/repos/azkaban/azkaban","forks_url":"https://api.github.com/repos/azkaban/azkaban/forks","keys_url":"https://api.github.com/repos/azkaban/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azkaban/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azkaban/azkaban/teams","hooks_url":"https://api.github.com/repos/azkaban/azkaban/hooks","issue_events_url":"https://api.github.com/repos/azkaban/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/azkaban/azkaban/events","assignees_url":"https://api.github.com/repos/azkaban/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/azkaban/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/azkaban/azkaban/tags","blobs_url":"https://api.github.com/repos/azkaban/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azkaban/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azkaban/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/azkaban/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/azkaban/azkaban/languages","stargazers_url":"https://api.github.com/repos/azkaban/azkaban/stargazers","contributors_url":"https://api.github.com/repos/azkaban/azkaban/contributors","subscribers_url":"https://api.github.com/repos/azkaban/azkaban/subscribers","subscription_url":"https://api.github.com/repos/azkaban/azkaban/subscription","commits_url":"https://api.github.com/repos/azkaban/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/azkaban/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/azkaban/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/azkaban/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/azkaban/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/azkaban/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azkaban/azkaban/merges","archive_url":"https://api.github.com/repos/azkaban/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azkaban/azkaban/downloads","issues_url":"https://api.github.com/repos/azkaban/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/azkaban/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/azkaban/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/azkaban/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azkaban/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/azkaban/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/azkaban/azkaban/deployments","created_at":"2012-10-18T01:34:53Z","updated_at":"2017-09-20T15:54:00Z","pushed_at":"2017-09-20T19:07:56Z","git_url":"git://github.com/azkaban/azkaban.git","ssh_url":"git@github.com:azkaban/azkaban.git","clone_url":"https://github.com/azkaban/azkaban.git","svn_url":"https://github.com/azkaban/azkaban","homepage":"https://azkaban.github.io","size":35507,"stargazers_count":1377,"watchers_count":1377,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":675,"mirror_url":null,"open_issues_count":352,"forks":675,"open_issues":352,"watchers":1377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1493"},"html":{"href":"https://github.com/azkaban/azkaban/pull/1493"},"issue":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/1493"},"comments":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/azkaban/azkaban/statuses/1303053287335b1e57536c20caf4eee12a1d0658"}},"author_association":"NONE"}}
{"actor":{"display_login":"armisael"}}