{"action":"created","issue":{"url":"https://api.github.com/repos/xcat2/xcat-core/issues/2320","repository_url":"https://api.github.com/repos/xcat2/xcat-core","labels_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2320/labels{/name}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2320/comments","events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2320/events","html_url":"https://github.com/xcat2/xcat-core/issues/2320","id":195883768,"number":2320,"title":"Request changing xcatprobe xcatmn output messages for checking services","user":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"labels":[{"id":390408061,"url":"https://api.github.com/repos/xcat2/xcat-core/labels/component:xcatprobe","name":"component:xcatprobe","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"assignees":[{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/22","html_url":"https://github.com/xcat2/xcat-core/milestone/22","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/22/labels","id":2160125,"number":22,"title":"2.13.1","description":"","creator":{"login":"zet809","id":8222144,"avatar_url":"https://avatars.githubusercontent.com/u/8222144?v=3","gravatar_id":"","url":"https://api.github.com/users/zet809","html_url":"https://github.com/zet809","followers_url":"https://api.github.com/users/zet809/followers","following_url":"https://api.github.com/users/zet809/following{/other_user}","gists_url":"https://api.github.com/users/zet809/gists{/gist_id}","starred_url":"https://api.github.com/users/zet809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zet809/subscriptions","organizations_url":"https://api.github.com/users/zet809/orgs","repos_url":"https://api.github.com/users/zet809/repos","events_url":"https://api.github.com/users/zet809/events{/privacy}","received_events_url":"https://api.github.com/users/zet809/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":51,"state":"open","created_at":"2016-11-28T06:21:07Z","updated_at":"2017-01-05T08:12:42Z","due_on":"2017-01-13T08:00:00Z","closed_at":null},"comments":2,"created_at":"2016-12-15T18:47:31Z","updated_at":"2017-01-05T08:14:39Z","closed_at":null,"body":"@hu-weihua  From my last comment in Issue #2193 , I think we should improve this messages for checking services can be improved..\r\n\r\nLooking at the current output: \r\n\r\n```\r\n[root@fs4 ~]# xcatprobe xcatmn -i enP4p1s0f2\r\n<mn>: All xCAT deamons are running                                                                                [ OK ]\r\n<mn>: xcatd can receive command request                                                                           [ OK ]\r\n<mn>: 'site' table is configured correctly                                                                        [ OK ]\r\n<mn>: Provision network is configured correctly                                                                   [ OK ]\r\n<mn>: 'passwd' table is configured correctly                                                                      [ OK ]\r\n<mn>: Important directory is configured correctly                                                                 [ OK ]\r\n<mn>: SELinux is disabled on current server                                                                       [ OK ]\r\n<mn>: HTTP service works well                                                                                     [ OK ]\r\n<mn>: TFTP service works well                                                                                     [ OK ]\r\n<mn>: DNS service works well                                                                                      [FAIL]\r\n<mn>: DNS service isn't ready on 192.168.3.25                                                                     \r\n<mn>: DHCP service works well                                                                                     [ OK ]\r\n<mn>: Firewall is closed on current server                                                                        [ OK ]\r\n<mn>: The disk space is enough for xCAT to work                                                                   [ OK ]\r\n<mn>: The IP of master is a static IP address                                                                     [ OK ]\r\n<mn>: The dhcpd.leases file is less than 100M                                                                     [ OK ]\r\n======================do summary=====================                                                             \r\n[MN]: Check on MN FAILED.                                                                                         [FAIL]\r\n    DNS service works well                                                                                        [FAIL]\r\n        DNS service isn't ready on 192.168.3.25                                                                   \r\n```\r\n\r\nIt seems like we are writing statements and then the response is \"OK\" or \"FAIL\". \r\n\r\nLooking at the full list, I have some problem with the following messages:\r\n\r\n* Important directory is configured correctly  \r\n\r\n  What is the important directory? If it's not configured correctly, what is the user to do? \r\n\r\n* \\<SERVICE\\> service works well \r\n\r\n   Suggest changing to \\<SERVICE\\> is configured... or Checking \\<SERVICE\\> is configured...\r\n\r\n* The disk space is enough for xCAT to work\r\n\r\n   Suggest printing out the testing threshold.   ==> \"Checking for mininum availble disks space of XX GB...\"\r\n\r\n* The IP of master is a static IP address \r\n\r\n   Suggest:  The xCAT management node IP: \\<IP ADDRESS\\> is configured to static\r\n\r\n* Firewall is closed on current server \r\n\r\n   Suggest: Firewall is disabled \r\n\r\n* SELinux is disabled on current server, suggest removing \"current server\"  because the probe is checking THIS server.   (We may need to potentially support xCAT with SELinux enabled... just FYI) "},"comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments/270587244","html_url":"https://github.com/xcat2/xcat-core/issues/2320#issuecomment-270587244","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2320","id":270587244,"user":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"created_at":"2017-01-05T08:14:39Z","updated_at":"2017-01-05T08:14:39Z","body":"@whowutwut , I have refine the code depending on your comment by PR #2370. Could you help to review the change, thanks."}}
{"actor":{"display_login":"hu-weihua"}}