{"action":"opened","issue":{"url":"https://api.github.com/repos/golang/go/issues/20760","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/20760/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/20760/comments","events_url":"https://api.github.com/repos/golang/go/issues/20760/events","html_url":"https://github.com/golang/go/issues/20760","id":237997368,"number":20760,"title":"cmd/go: rethink 'go get' skipping test-only packages","user":{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"labels":[{"id":373401956,"url":"https://api.github.com/repos/golang/go/labels/NeedsDecision","name":"NeedsDecision","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/56","html_url":"https://github.com/golang/go/milestone/56","labels_url":"https://api.github.com/repos/golang/go/milestones/56/labels","id":2473074,"number":56,"title":"Go1.10","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":474,"closed_issues":31,"state":"open","created_at":"2017-04-21T19:22:29Z","updated_at":"2017-06-22T23:01:26Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"comments":0,"created_at":"2017-06-22T23:01:25Z","updated_at":"2017-06-22T23:01:25Z","closed_at":null,"body":"Issue #15093 complained that go get x.com/y/... can match (via the wildcard) a directory x.com/y/z that only has tests in it, and then the 'go get' fails, because it cannot run 'go install x.com/y/z'. A fix was made for that CL, which silences the reporting of the \"no Go files\" error in x.com/y/z during 'go get', provided there are test files in that directory.\n\nThat fixes the problem reported, but it introduces other problems:\n\n1. It makes go get behave differently from go install, even though get is defined as download + install.\n2. go get x.com/y/z probably _should_ report the error, while 'go get x.com/y/...' might reasonably omit it.\n3. If x.com/y/p incorrectly imports x.com/y/z, the error building z is not reported, and p silently fails to build, and the overall go get exits 0 as if everything was OK.\n4. The fix was considered only TestGoFiles and not XTestGoFiles.\n\nA pending CL of mine will address 3 and 4; we should reconsider 1 and 2 at some later point."}}
{"actor":{"display_login":"rsc"}}