{"action":"created","issue":{"url":"https://api.github.com/repos/Keroberos/sam/issues/54","repository_url":"https://api.github.com/repos/Keroberos/sam","labels_url":"https://api.github.com/repos/Keroberos/sam/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/Keroberos/sam/issues/54/comments","events_url":"https://api.github.com/repos/Keroberos/sam/issues/54/events","html_url":"https://github.com/Keroberos/sam/issues/54","id":243498820,"number":54,"title":"VAT Return Updates","user":{"login":"fergalddaly","id":2511712,"avatar_url":"https://avatars0.githubusercontent.com/u/2511712?v=4","gravatar_id":"","url":"https://api.github.com/users/fergalddaly","html_url":"https://github.com/fergalddaly","followers_url":"https://api.github.com/users/fergalddaly/followers","following_url":"https://api.github.com/users/fergalddaly/following{/other_user}","gists_url":"https://api.github.com/users/fergalddaly/gists{/gist_id}","starred_url":"https://api.github.com/users/fergalddaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fergalddaly/subscriptions","organizations_url":"https://api.github.com/users/fergalddaly/orgs","repos_url":"https://api.github.com/users/fergalddaly/repos","events_url":"https://api.github.com/users/fergalddaly/events{/privacy}","received_events_url":"https://api.github.com/users/fergalddaly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Keroberos","id":546027,"avatar_url":"https://avatars3.githubusercontent.com/u/546027?v=4","gravatar_id":"","url":"https://api.github.com/users/Keroberos","html_url":"https://github.com/Keroberos","followers_url":"https://api.github.com/users/Keroberos/followers","following_url":"https://api.github.com/users/Keroberos/following{/other_user}","gists_url":"https://api.github.com/users/Keroberos/gists{/gist_id}","starred_url":"https://api.github.com/users/Keroberos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keroberos/subscriptions","organizations_url":"https://api.github.com/users/Keroberos/orgs","repos_url":"https://api.github.com/users/Keroberos/repos","events_url":"https://api.github.com/users/Keroberos/events{/privacy}","received_events_url":"https://api.github.com/users/Keroberos/received_events","type":"User","site_admin":false},"assignees":[{"login":"Keroberos","id":546027,"avatar_url":"https://avatars3.githubusercontent.com/u/546027?v=4","gravatar_id":"","url":"https://api.github.com/users/Keroberos","html_url":"https://github.com/Keroberos","followers_url":"https://api.github.com/users/Keroberos/followers","following_url":"https://api.github.com/users/Keroberos/following{/other_user}","gists_url":"https://api.github.com/users/Keroberos/gists{/gist_id}","starred_url":"https://api.github.com/users/Keroberos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keroberos/subscriptions","organizations_url":"https://api.github.com/users/Keroberos/orgs","repos_url":"https://api.github.com/users/Keroberos/repos","events_url":"https://api.github.com/users/Keroberos/events{/privacy}","received_events_url":"https://api.github.com/users/Keroberos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-07-17T19:20:26Z","updated_at":"2017-07-22T00:10:40Z","closed_at":"2017-07-22T00:10:40Z","body":"- Add new status ROS_PAYMENT_MADE to VAT returns\r\n- remove the action button (and drop down menu)\r\n- add a new button at the very end called \"record ros payment.\"\r\n- this button and the 2 payment details fields are disabled until the status = totalled.\r\n- once this button is pressed, validate that the payment details have data.\r\n- make a rest call to the server to record the payment details and change the status to ROS_PAYMENT_MADE\r\n- disable the button and the fields (angular will do this with the status change).\r\n- change the title of columns Payment Date to ROS Payment Date\r\n- change the title of columns Payment Number to ROS Payment Number\r\n"},"comment":{"url":"https://api.github.com/repos/Keroberos/sam/issues/comments/317139096","html_url":"https://github.com/Keroberos/sam/issues/54#issuecomment-317139096","issue_url":"https://api.github.com/repos/Keroberos/sam/issues/54","id":317139096,"user":{"login":"fergalddaly","id":2511712,"avatar_url":"https://avatars0.githubusercontent.com/u/2511712?v=4","gravatar_id":"","url":"https://api.github.com/users/fergalddaly","html_url":"https://github.com/fergalddaly","followers_url":"https://api.github.com/users/fergalddaly/followers","following_url":"https://api.github.com/users/fergalddaly/following{/other_user}","gists_url":"https://api.github.com/users/fergalddaly/gists{/gist_id}","starred_url":"https://api.github.com/users/fergalddaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fergalddaly/subscriptions","organizations_url":"https://api.github.com/users/fergalddaly/orgs","repos_url":"https://api.github.com/users/fergalddaly/repos","events_url":"https://api.github.com/users/fergalddaly/events{/privacy}","received_events_url":"https://api.github.com/users/fergalddaly/received_events","type":"User","site_admin":false},"created_at":"2017-07-22T00:10:40Z","updated_at":"2017-07-22T00:10:40Z","body":"I made a few mistakes in stating the requirements.\r\nI've made an additional commit here:\r\n0042f5663effaaa441eed5a31d37e5e1bcd78abe\r\nto resolve the issue.\r\n\r\nBasically, now you can execute calculate when the vat return is created.\r\nOnce it has been calculated you can record the ros payment details.\r\nThen when the vat return is paid, no button is shown.\r\n\r\nAbove working fine now.\r\n\r\nFurther updates will be required:\r\n- calculate will be rejected if prerequiste data (invoices, expenses) not finalised for month.\r\nthis will be covered in a different task.\r\n\r\nGreat. Can move on from this now.\r\n"}}
{"actor":{"display_login":"fergalddaly"}}