{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/comments/157474689","pull_request_review_id":84121057,"id":157474689,"diff_hunk":"@@ -0,0 +1,11 @@\n+'use strict'\n+\n+// Local dependencies\n+const countries = require('../../common/middleware/countries')\n+\n+module.exports = (req, res) => {","path":"app/index/get.controller.js","position":6,"original_position":6,"commit_id":"3010d019488ef6f98fc6878bae538f30681d7b92","original_commit_id":"3010d019488ef6f98fc6878bae538f30681d7b92","user":{"login":"rauligs","id":17246560,"avatar_url":"https://avatars0.githubusercontent.com/u/17246560?v=4","gravatar_id":"","url":"https://api.github.com/users/rauligs","html_url":"https://github.com/rauligs","followers_url":"https://api.github.com/users/rauligs/followers","following_url":"https://api.github.com/users/rauligs/following{/other_user}","gists_url":"https://api.github.com/users/rauligs/gists{/gist_id}","starred_url":"https://api.github.com/users/rauligs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauligs/subscriptions","organizations_url":"https://api.github.com/users/rauligs/orgs","repos_url":"https://api.github.com/users/rauligs/repos","events_url":"https://api.github.com/users/rauligs/events{/privacy}","received_events_url":"https://api.github.com/users/rauligs/received_events","type":"User","site_admin":false},"body":"I would use another name, since _get controller_ is not telling anything about what is it about","created_at":"2017-12-18T12:46:06Z","updated_at":"2017-12-18T12:55:02Z","html_url":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17#discussion_r157474689","pull_request_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/comments/157474689"},"html":{"href":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17#discussion_r157474689"},"pull_request":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17","id":158582977,"html_url":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17","diff_url":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17.diff","patch_url":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17.patch","issue_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/17","number":17,"state":"open","locked":false,"title":"PP-2937 Static pages","user":{"login":"DanailMinchev","id":7883702,"avatar_url":"https://avatars1.githubusercontent.com/u/7883702?v=4","gravatar_id":"","url":"https://api.github.com/users/DanailMinchev","html_url":"https://github.com/DanailMinchev","followers_url":"https://api.github.com/users/DanailMinchev/followers","following_url":"https://api.github.com/users/DanailMinchev/following{/other_user}","gists_url":"https://api.github.com/users/DanailMinchev/gists{/gist_id}","starred_url":"https://api.github.com/users/DanailMinchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanailMinchev/subscriptions","organizations_url":"https://api.github.com/users/DanailMinchev/orgs","repos_url":"https://api.github.com/users/DanailMinchev/repos","events_url":"https://api.github.com/users/DanailMinchev/events{/privacy}","received_events_url":"https://api.github.com/users/DanailMinchev/received_events","type":"User","site_admin":false},"body":"## WHAT\r\n\r\n- Better directory structure and file naming [e2cfc3c]\r\n  - Moved `/app/common/*` files to `/common/*`\r\n  The `/app` directory should have only `feature` directories and files, not shared logic\r\n  - Renamed the controllers to have only corresponding HTTP methods as a main name (the `feature` directory name is enough to distinguish multiple controllers)\r\n  - Updated `server.js` to reference common root path\r\n  - Renamed `common/views` to `common/templates`\r\n\r\n- Page skeletons [f12ee46] [e3bc586], page markups [100b16c] [22e1156] [b6727cb]\r\n\r\n- Client side validation [f156e14]\r\n\r\n- Styling and improvements [684a708] [cd0fb4b] [a0b9114] [3010d01]","created_at":"2017-12-15T11:34:34Z","updated_at":"2017-12-18T12:55:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"841a96281f789dc72dfacf9aa1016c62bb8345ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/17/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/statuses/3010d019488ef6f98fc6878bae538f30681d7b92","head":{"label":"alphagov:PP-2937_static-pages","ref":"PP-2937_static-pages","sha":"3010d019488ef6f98fc6878bae538f30681d7b92","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":107575251,"name":"pay-direct-debit-frontend","full_name":"alphagov/pay-direct-debit-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pay-direct-debit-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend","forks_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/deployments","created_at":"2017-10-19T17:03:00Z","updated_at":"2017-11-09T09:56:48Z","pushed_at":"2017-12-18T11:59:05Z","git_url":"git://github.com/alphagov/pay-direct-debit-frontend.git","ssh_url":"git@github.com:alphagov/pay-direct-debit-frontend.git","clone_url":"https://github.com/alphagov/pay-direct-debit-frontend.git","svn_url":"https://github.com/alphagov/pay-direct-debit-frontend","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"5c70573b2f622d3b8f10614db464b59071189b0f","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":107575251,"name":"pay-direct-debit-frontend","full_name":"alphagov/pay-direct-debit-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pay-direct-debit-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend","forks_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/deployments","created_at":"2017-10-19T17:03:00Z","updated_at":"2017-11-09T09:56:48Z","pushed_at":"2017-12-18T11:59:05Z","git_url":"git://github.com/alphagov/pay-direct-debit-frontend.git","ssh_url":"git@github.com:alphagov/pay-direct-debit-frontend.git","clone_url":"https://github.com/alphagov/pay-direct-debit-frontend.git","svn_url":"https://github.com/alphagov/pay-direct-debit-frontend","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17"},"html":{"href":"https://github.com/alphagov/pay-direct-debit-frontend/pull/17"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/17"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-direct-debit-frontend/statuses/3010d019488ef6f98fc6878bae538f30681d7b92"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rauligs"}}