{"action":"created","comment":{"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments/129657047","pull_request_review_id":52454019,"id":129657047,"diff_hunk":"@@ -0,0 +1,68 @@\n+package protocolsupport.protocol.packet.middleimpl.clientbound.play.v_pe;\n+\n+import gnu.trove.map.hash.TIntObjectHashMap;\n+import protocolsupport.api.ProtocolVersion;\n+import protocolsupport.protocol.packet.middle.clientbound.play.MiddleBlockBreakAnimation;\n+import protocolsupport.protocol.packet.middleimpl.ClientBoundPacketData;\n+import protocolsupport.protocol.typeremapper.pe.PELevelEvent;\n+import protocolsupport.utils.recyclable.RecyclableCollection;\n+import protocolsupport.utils.recyclable.RecyclableEmptyList;\n+import protocolsupport.utils.recyclable.RecyclableSingletonList;\n+\n+public class BlockBreakAnimation extends MiddleBlockBreakAnimation {\n+\n+\tprivate final TIntObjectHashMap<TimePle> animation = new TIntObjectHashMap<>();\n+\t\n+\t@Override\n+\tpublic RecyclableCollection<ClientBoundPacketData> toData(ProtocolVersion version) {\n+\t\tif (stage >= 1 && stage <= 9) {\n+\t\t\tif (!animation.containsKey(entityId)) {\n+\t\t\t\tanimation.put(entityId, new TimePle(false, System.nanoTime(), stage));\n+\t\t\t} else {\n+\t\t\t\tif (!animation.get(entityId).getStarted() && stage > animation.get(entityId).getStartStage()) {","path":"src/protocolsupport/protocol/packet/middleimpl/clientbound/play/v_pe/BlockBreakAnimation.java","position":22,"original_position":22,"commit_id":"fd39cf6ce19bb5db2aba2f3f73ce92fe0ea4f61c","original_commit_id":"fd39cf6ce19bb5db2aba2f3f73ce92fe0ea4f61c","user":{"login":"7kasper","id":6474340,"avatar_url":"https://avatars2.githubusercontent.com/u/6474340?v=4","gravatar_id":"","url":"https://api.github.com/users/7kasper","html_url":"https://github.com/7kasper","followers_url":"https://api.github.com/users/7kasper/followers","following_url":"https://api.github.com/users/7kasper/following{/other_user}","gists_url":"https://api.github.com/users/7kasper/gists{/gist_id}","starred_url":"https://api.github.com/users/7kasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7kasper/subscriptions","organizations_url":"https://api.github.com/users/7kasper/orgs","repos_url":"https://api.github.com/users/7kasper/repos","events_url":"https://api.github.com/users/7kasper/events{/privacy}","received_events_url":"https://api.github.com/users/7kasper/received_events","type":"User","site_admin":false},"body":"What do you mean?","created_at":"2017-07-26T18:24:42Z","updated_at":"2017-07-26T18:24:48Z","html_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579#discussion_r129657047","pull_request_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579","_links":{"self":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments/129657047"},"html":{"href":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579#discussion_r129657047"},"pull_request":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579","id":132581168,"html_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579","diff_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579.diff","patch_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579.patch","issue_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/579","number":579,"state":"open","locked":false,"title":"[PSPE] Break animations","user":{"login":"7kasper","id":6474340,"avatar_url":"https://avatars2.githubusercontent.com/u/6474340?v=4","gravatar_id":"","url":"https://api.github.com/users/7kasper","html_url":"https://github.com/7kasper","followers_url":"https://api.github.com/users/7kasper/followers","following_url":"https://api.github.com/users/7kasper/following{/other_user}","gists_url":"https://api.github.com/users/7kasper/gists{/gist_id}","starred_url":"https://api.github.com/users/7kasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7kasper/subscriptions","organizations_url":"https://api.github.com/users/7kasper/orgs","repos_url":"https://api.github.com/users/7kasper/repos","events_url":"https://api.github.com/users/7kasper/events{/privacy}","received_events_url":"https://api.github.com/users/7kasper/received_events","type":"User","site_admin":false},"body":"It's much hacking again but it works okay.\r\nNot perfect. But okay.\r\n\r\nTiming will never be perfect. Since we are kind of limited to ticks there will always be a change we're just hitting one tick off or maybe there's some network lagg. This will make it so the animation finishes too early or late. I think this is however the best we can do.","created_at":"2017-07-26T18:20:03Z","updated_at":"2017-07-26T18:24:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef4808f0315b260f235669411168066f2748042","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579/commits","review_comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579/comments","review_comment_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/579/comments","statuses_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/fd39cf6ce19bb5db2aba2f3f73ce92fe0ea4f61c","head":{"label":"7kasper:BreakAnimation","ref":"BreakAnimation","sha":"fd39cf6ce19bb5db2aba2f3f73ce92fe0ea4f61c","user":{"login":"7kasper","id":6474340,"avatar_url":"https://avatars2.githubusercontent.com/u/6474340?v=4","gravatar_id":"","url":"https://api.github.com/users/7kasper","html_url":"https://github.com/7kasper","followers_url":"https://api.github.com/users/7kasper/followers","following_url":"https://api.github.com/users/7kasper/following{/other_user}","gists_url":"https://api.github.com/users/7kasper/gists{/gist_id}","starred_url":"https://api.github.com/users/7kasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7kasper/subscriptions","organizations_url":"https://api.github.com/users/7kasper/orgs","repos_url":"https://api.github.com/users/7kasper/repos","events_url":"https://api.github.com/users/7kasper/events{/privacy}","received_events_url":"https://api.github.com/users/7kasper/received_events","type":"User","site_admin":false},"repo":{"id":85831181,"name":"ProtocolSupport","full_name":"7kasper/ProtocolSupport","owner":{"login":"7kasper","id":6474340,"avatar_url":"https://avatars2.githubusercontent.com/u/6474340?v=4","gravatar_id":"","url":"https://api.github.com/users/7kasper","html_url":"https://github.com/7kasper","followers_url":"https://api.github.com/users/7kasper/followers","following_url":"https://api.github.com/users/7kasper/following{/other_user}","gists_url":"https://api.github.com/users/7kasper/gists{/gist_id}","starred_url":"https://api.github.com/users/7kasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7kasper/subscriptions","organizations_url":"https://api.github.com/users/7kasper/orgs","repos_url":"https://api.github.com/users/7kasper/repos","events_url":"https://api.github.com/users/7kasper/events{/privacy}","received_events_url":"https://api.github.com/users/7kasper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/7kasper/ProtocolSupport","description":"Support 1.10.*, 1.9.*, 1.8.*, 1.7.*, 1.6.*, 1.5.*, 1.4.7 on spigot 1.11.2 and GlowStone","fork":true,"url":"https://api.github.com/repos/7kasper/ProtocolSupport","forks_url":"https://api.github.com/repos/7kasper/ProtocolSupport/forks","keys_url":"https://api.github.com/repos/7kasper/ProtocolSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7kasper/ProtocolSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7kasper/ProtocolSupport/teams","hooks_url":"https://api.github.com/repos/7kasper/ProtocolSupport/hooks","issue_events_url":"https://api.github.com/repos/7kasper/ProtocolSupport/issues/events{/number}","events_url":"https://api.github.com/repos/7kasper/ProtocolSupport/events","assignees_url":"https://api.github.com/repos/7kasper/ProtocolSupport/assignees{/user}","branches_url":"https://api.github.com/repos/7kasper/ProtocolSupport/branches{/branch}","tags_url":"https://api.github.com/repos/7kasper/ProtocolSupport/tags","blobs_url":"https://api.github.com/repos/7kasper/ProtocolSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7kasper/ProtocolSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7kasper/ProtocolSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/7kasper/ProtocolSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7kasper/ProtocolSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/7kasper/ProtocolSupport/languages","stargazers_url":"https://api.github.com/repos/7kasper/ProtocolSupport/stargazers","contributors_url":"https://api.github.com/repos/7kasper/ProtocolSupport/contributors","subscribers_url":"https://api.github.com/repos/7kasper/ProtocolSupport/subscribers","subscription_url":"https://api.github.com/repos/7kasper/ProtocolSupport/subscription","commits_url":"https://api.github.com/repos/7kasper/ProtocolSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/7kasper/ProtocolSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/7kasper/ProtocolSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/7kasper/ProtocolSupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/7kasper/ProtocolSupport/contents/{+path}","compare_url":"https://api.github.com/repos/7kasper/ProtocolSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7kasper/ProtocolSupport/merges","archive_url":"https://api.github.com/repos/7kasper/ProtocolSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7kasper/ProtocolSupport/downloads","issues_url":"https://api.github.com/repos/7kasper/ProtocolSupport/issues{/number}","pulls_url":"https://api.github.com/repos/7kasper/ProtocolSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/7kasper/ProtocolSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/7kasper/ProtocolSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7kasper/ProtocolSupport/labels{/name}","releases_url":"https://api.github.com/repos/7kasper/ProtocolSupport/releases{/id}","deployments_url":"https://api.github.com/repos/7kasper/ProtocolSupport/deployments","created_at":"2017-03-22T13:31:04Z","updated_at":"2017-07-08T15:56:17Z","pushed_at":"2017-07-26T18:17:13Z","git_url":"git://github.com/7kasper/ProtocolSupport.git","ssh_url":"git@github.com:7kasper/ProtocolSupport.git","clone_url":"https://github.com/7kasper/ProtocolSupport.git","svn_url":"https://github.com/7kasper/ProtocolSupport","homepage":"","size":7659,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ProtocolSupport:mcpenew","ref":"mcpenew","sha":"9f8b0f88f7c7ce04ddc0bef908428b7c5f7fc2f8","user":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"repo":{"id":27644576,"name":"ProtocolSupport","full_name":"ProtocolSupport/ProtocolSupport","owner":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProtocolSupport/ProtocolSupport","description":"Support 1.10.*, 1.9.*, 1.8.*, 1.7.*, 1.6.*, 1.5.*, 1.4.7 on spigot 1.11.2 and GlowStone","fork":false,"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport","forks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/forks","keys_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/teams","hooks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/hooks","issue_events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/events{/number}","events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/events","assignees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/assignees{/user}","branches_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/branches{/branch}","tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/tags","blobs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/languages","stargazers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/stargazers","contributors_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contributors","subscribers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscribers","subscription_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscription","commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contents/{+path}","compare_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/merges","archive_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/downloads","issues_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues{/number}","pulls_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/labels{/name}","releases_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/releases{/id}","deployments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/deployments","created_at":"2014-12-06T18:35:33Z","updated_at":"2017-07-24T11:26:32Z","pushed_at":"2017-07-26T18:20:03Z","git_url":"git://github.com/ProtocolSupport/ProtocolSupport.git","ssh_url":"git@github.com:ProtocolSupport/ProtocolSupport.git","clone_url":"https://github.com/ProtocolSupport/ProtocolSupport.git","svn_url":"https://github.com/ProtocolSupport/ProtocolSupport","homepage":"","size":7549,"stargazers_count":123,"watchers_count":123,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":13,"forks":73,"open_issues":13,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579"},"html":{"href":"https://github.com/ProtocolSupport/ProtocolSupport/pull/579"},"issue":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/579"},"comments":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/fd39cf6ce19bb5db2aba2f3f73ce92fe0ea4f61c"}}}}
{"actor":{"display_login":"7kasper"}}