{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29","id":116300336,"html_url":"https://github.com/appcelerator/appc.arrowdb/pull/29","diff_url":"https://github.com/appcelerator/appc.arrowdb/pull/29.diff","patch_url":"https://github.com/appcelerator/appc.arrowdb/pull/29.patch","issue_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/29","number":29,"state":"closed","locked":false,"title":"WIP: [ARRSOF-212] Stop swallowing errors thrown in callbacks","user":{"login":"alasdairhurst","id":8441810,"avatar_url":"https://avatars3.githubusercontent.com/u/8441810?v=3","gravatar_id":"","url":"https://api.github.com/users/alasdairhurst","html_url":"https://github.com/alasdairhurst","followers_url":"https://api.github.com/users/alasdairhurst/followers","following_url":"https://api.github.com/users/alasdairhurst/following{/other_user}","gists_url":"https://api.github.com/users/alasdairhurst/gists{/gist_id}","starred_url":"https://api.github.com/users/alasdairhurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alasdairhurst/subscriptions","organizations_url":"https://api.github.com/users/alasdairhurst/orgs","repos_url":"https://api.github.com/users/alasdairhurst/repos","events_url":"https://api.github.com/users/alasdairhurst/events{/privacy}","received_events_url":"https://api.github.com/users/alasdairhurst/received_events","type":"User","site_admin":false},"body":"https://techweb.axway.com/jira/browse/ARRSOF-212\r\n\r\nMakes sure that callbacks are called outside try blocks so that the connector doesn't catch errors which don't relate to it and call the callback twice.\r\n\r\nresp.stream has its own try/catch logic within so anything should be handled there and passed to the callback.\r\n","created_at":"2017-04-18T10:49:36Z","updated_at":"2017-06-01T09:33:49Z","closed_at":"2017-06-01T09:33:49Z","merged_at":"2017-06-01T09:33:49Z","merge_commit_sha":"b71d5709a252d9601f9df5b0b77e0a297d52f265","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29/commits","review_comments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29/comments","review_comment_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/29/comments","statuses_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/statuses/03b46b31158f485edead7a52bb3b978449387b7b","head":{"label":"appcelerator:arrsof-212","ref":"arrsof-212","sha":"03b46b31158f485edead7a52bb3b978449387b7b","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars0.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":23553662,"name":"appc.arrowdb","full_name":"appcelerator/appc.arrowdb","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars0.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/appc.arrowdb","description":"Arrow connector to ArrowDB","fork":false,"url":"https://api.github.com/repos/appcelerator/appc.arrowdb","forks_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/forks","keys_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/teams","hooks_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/events","assignees_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/tags","blobs_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/languages","stargazers_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/subscription","commits_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/merges","archive_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/downloads","issues_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/deployments","created_at":"2014-09-01T19:35:55Z","updated_at":"2016-12-06T14:07:35Z","pushed_at":"2017-06-01T09:33:49Z","git_url":"git://github.com/appcelerator/appc.arrowdb.git","ssh_url":"git@github.com:appcelerator/appc.arrowdb.git","clone_url":"https://github.com/appcelerator/appc.arrowdb.git","svn_url":"https://github.com/appcelerator/appc.arrowdb","homepage":"","size":896,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"787a3e345f8077c957e26e96f292a71f6d74c3d5","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars0.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":23553662,"name":"appc.arrowdb","full_name":"appcelerator/appc.arrowdb","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars0.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/appc.arrowdb","description":"Arrow connector to ArrowDB","fork":false,"url":"https://api.github.com/repos/appcelerator/appc.arrowdb","forks_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/forks","keys_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/teams","hooks_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/events","assignees_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/tags","blobs_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/languages","stargazers_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/subscription","commits_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/merges","archive_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/downloads","issues_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/appc.arrowdb/deployments","created_at":"2014-09-01T19:35:55Z","updated_at":"2016-12-06T14:07:35Z","pushed_at":"2017-06-01T09:33:49Z","git_url":"git://github.com/appcelerator/appc.arrowdb.git","ssh_url":"git@github.com:appcelerator/appc.arrowdb.git","clone_url":"https://github.com/appcelerator/appc.arrowdb.git","svn_url":"https://github.com/appcelerator/appc.arrowdb","homepage":"","size":896,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29"},"html":{"href":"https://github.com/appcelerator/appc.arrowdb/pull/29"},"issue":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/29"},"comments":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/appc.arrowdb/statuses/03b46b31158f485edead7a52bb3b978449387b7b"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pltod2","id":20239625,"avatar_url":"https://avatars2.githubusercontent.com/u/20239625?v=3","gravatar_id":"","url":"https://api.github.com/users/pltod2","html_url":"https://github.com/pltod2","followers_url":"https://api.github.com/users/pltod2/followers","following_url":"https://api.github.com/users/pltod2/following{/other_user}","gists_url":"https://api.github.com/users/pltod2/gists{/gist_id}","starred_url":"https://api.github.com/users/pltod2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pltod2/subscriptions","organizations_url":"https://api.github.com/users/pltod2/orgs","repos_url":"https://api.github.com/users/pltod2/repos","events_url":"https://api.github.com/users/pltod2/events{/privacy}","received_events_url":"https://api.github.com/users/pltod2/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":17,"changed_files":4}}
{"actor":{"display_login":"pltod2"}}