{"action":"closed","number":649,"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/649","id":131658973,"html_url":"https://github.com/apache/geode/pull/649","diff_url":"https://github.com/apache/geode/pull/649.diff","patch_url":"https://github.com/apache/geode/pull/649.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/649","number":649,"state":"closed","locked":false,"title":"GEODE-2997: Change new protocol GetAllResponse.","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"body":"@kohlmu-pivotal @hiteshk25 @WireBaron @pivotal-amurmann @bschuchardt \r\n\r\nI think it's better to return the errors and the successful keys so that\r\none failed lookup doesn't mess up the whole request.\r\n\r\nImagining this as a conversational PR to see what the response is.\r\n\r\nSigned-off-by: Galen O'Sullivan <gosullivan@pivotal.io>\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [X] Is your initial contribution a single, squashed commit?\r\n\r\n- [NO.] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2017-07-20T21:56:20Z","updated_at":"2017-08-23T22:49:42Z","closed_at":"2017-08-23T22:49:42Z","merged_at":null,"merge_commit_sha":"213c63affc36bdc125c7e78bf5e92e784dbaae50","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/649/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/649/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/649/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/2b07dfc3cae729b8e23655fa11f3e8d485c520c4","head":{"label":"galen-pivotal:changeGetAllAPI","ref":"changeGetAllAPI","sha":"2b07dfc3cae729b8e23655fa11f3e8d485c520c4","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"repo":{"id":75438678,"name":"geode","full_name":"galen-pivotal/geode","owner":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galen-pivotal/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/galen-pivotal/geode","forks_url":"https://api.github.com/repos/galen-pivotal/geode/forks","keys_url":"https://api.github.com/repos/galen-pivotal/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galen-pivotal/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galen-pivotal/geode/teams","hooks_url":"https://api.github.com/repos/galen-pivotal/geode/hooks","issue_events_url":"https://api.github.com/repos/galen-pivotal/geode/issues/events{/number}","events_url":"https://api.github.com/repos/galen-pivotal/geode/events","assignees_url":"https://api.github.com/repos/galen-pivotal/geode/assignees{/user}","branches_url":"https://api.github.com/repos/galen-pivotal/geode/branches{/branch}","tags_url":"https://api.github.com/repos/galen-pivotal/geode/tags","blobs_url":"https://api.github.com/repos/galen-pivotal/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galen-pivotal/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galen-pivotal/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/galen-pivotal/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galen-pivotal/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/galen-pivotal/geode/languages","stargazers_url":"https://api.github.com/repos/galen-pivotal/geode/stargazers","contributors_url":"https://api.github.com/repos/galen-pivotal/geode/contributors","subscribers_url":"https://api.github.com/repos/galen-pivotal/geode/subscribers","subscription_url":"https://api.github.com/repos/galen-pivotal/geode/subscription","commits_url":"https://api.github.com/repos/galen-pivotal/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/galen-pivotal/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/galen-pivotal/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/galen-pivotal/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/galen-pivotal/geode/contents/{+path}","compare_url":"https://api.github.com/repos/galen-pivotal/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galen-pivotal/geode/merges","archive_url":"https://api.github.com/repos/galen-pivotal/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galen-pivotal/geode/downloads","issues_url":"https://api.github.com/repos/galen-pivotal/geode/issues{/number}","pulls_url":"https://api.github.com/repos/galen-pivotal/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/galen-pivotal/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/galen-pivotal/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galen-pivotal/geode/labels{/name}","releases_url":"https://api.github.com/repos/galen-pivotal/geode/releases{/id}","deployments_url":"https://api.github.com/repos/galen-pivotal/geode/deployments","created_at":"2016-12-02T23:21:54Z","updated_at":"2017-03-23T17:13:31Z","pushed_at":"2017-08-23T22:45:43Z","git_url":"git://github.com/galen-pivotal/geode.git","ssh_url":"git@github.com:galen-pivotal/geode.git","clone_url":"https://github.com/galen-pivotal/geode.git","svn_url":"https://github.com/galen-pivotal/geode","homepage":"","size":137567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"571239151ea941ea7c09dc21a570c0e8e5e853b3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Mirror of Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-08-23T08:34:22Z","pushed_at":"2017-08-23T22:45:44Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":134405,"stargazers_count":1037,"watchers_count":1037,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":379,"mirror_url":"git://git.apache.org/geode.git","open_issues_count":24,"forks":379,"open_issues":24,"watchers":1037,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/649"},"html":{"href":"https://github.com/apache/geode/pull/649"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/649"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/2b07dfc3cae729b8e23655fa11f3e8d485c520c4"}},"merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"galen-pivotal"}}