{"action":"created","issue":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/858","repository_url":"https://api.github.com/repos/vulkano-rs/vulkano","labels_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/858/labels{/name}","comments_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/858/comments","events_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/858/events","html_url":"https://github.com/vulkano-rs/vulkano/issues/858","id":263685033,"number":858,"title":"Support for dynamic buffers in PersistentDescriptorSet","user":{"login":"Ralith","id":104558,"avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-08T01:32:36Z","updated_at":"2017-10-08T07:27:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is useful for when you want to use a single buffer to store a large, statically unknown number of uniforms for efficient allocation and streaming.\r\n\r\nI'm happy to implement this myself, but I'd like to know what the desired API is. Adding new dedicated methods to `PersistentDescriptorSetBuilder`(`Array`) for each type starts to get into a combinatorial explosion with the existing buffer vs. buffer view duplication. A `dynamic: bool` argument could be added to the `add_buffer` methods, but this would be a breaking API change."},"comment":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/comments/334988561","html_url":"https://github.com/vulkano-rs/vulkano/issues/858#issuecomment-334988561","issue_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/858","id":334988561,"user":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"created_at":"2017-10-08T07:27:03Z","updated_at":"2017-10-08T07:27:03Z","author_association":"OWNER","body":"You don't need to add a `dynamic` parameter to `add_buffer`. The pipeline layout already knows whether the buffer is dynamic.\r\n\r\nThe most annoying problem with dynamic buffers is how to indicate the actual offset when binding the descriptor set.\r\n"}}
{"actor":{"display_login":"tomaka"}}