{"action":"created","comment":{"url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/comments/102040887","pull_request_review_id":22784414,"id":102040887,"diff_hunk":"@@ -1,17 +1,21 @@\n import Ember from 'ember';\n \n-var route = function(funcs) {\n+var route = function(props) {\n   return function wrapWithRoute(IncomingRoute) {\n     var WrappedRoute = IncomingRoute || Ember.Route;\n     return WrappedRoute.extend({\n       redux: Ember.inject.service('redux'),\n       init() {\n         var redux = this.get('redux');\n         var route = this;\n-        Object.keys(funcs).forEach(function(func) {\n-          route[func] = function(...args) {\n+        Object.keys(props).forEach(function(key) {\n+          if (typeof props[key] !== 'function') {\n+            route[key] = props[key]","path":"addon/route.js","position":16,"original_position":16,"commit_id":"8c9a254026d6eeddb863eea5835375358a8984b0","original_commit_id":"8c9a254026d6eeddb863eea5835375358a8984b0","user":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"body":"semicolon on lines 13/14? :)","created_at":"2017-02-20T15:26:22Z","updated_at":"2017-02-20T15:33:41Z","html_url":"https://github.com/ember-redux/ember-redux/pull/98#discussion_r102040887","pull_request_url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/comments/102040887"},"html":{"href":"https://github.com/ember-redux/ember-redux/pull/98#discussion_r102040887"},"pull_request":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98","id":106876746,"html_url":"https://github.com/ember-redux/ember-redux/pull/98","diff_url":"https://github.com/ember-redux/ember-redux/pull/98.diff","patch_url":"https://github.com/ember-redux/ember-redux/pull/98.patch","issue_url":"https://api.github.com/repos/ember-redux/ember-redux/issues/98","number":98,"state":"open","locked":false,"title":"Support non-function properties in route","user":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-18T21:09:37Z","updated_at":"2017-02-20T15:33:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb1e9f74b800696112c49298ee62567540576e92","assignee":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"assignees":[{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98/commits","review_comments_url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98/comments","review_comment_url":"https://api.github.com/repos/ember-redux/ember-redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-redux/ember-redux/issues/98/comments","statuses_url":"https://api.github.com/repos/ember-redux/ember-redux/statuses/8c9a254026d6eeddb863eea5835375358a8984b0","head":{"label":"sandersky:master","ref":"master","sha":"8c9a254026d6eeddb863eea5835375358a8984b0","user":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"repo":{"id":76291850,"name":"ember-redux","full_name":"sandersky/ember-redux","owner":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandersky/ember-redux","description":"ember-cli addon that provides simple redux bindings for ember.js","fork":true,"url":"https://api.github.com/repos/sandersky/ember-redux","forks_url":"https://api.github.com/repos/sandersky/ember-redux/forks","keys_url":"https://api.github.com/repos/sandersky/ember-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandersky/ember-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandersky/ember-redux/teams","hooks_url":"https://api.github.com/repos/sandersky/ember-redux/hooks","issue_events_url":"https://api.github.com/repos/sandersky/ember-redux/issues/events{/number}","events_url":"https://api.github.com/repos/sandersky/ember-redux/events","assignees_url":"https://api.github.com/repos/sandersky/ember-redux/assignees{/user}","branches_url":"https://api.github.com/repos/sandersky/ember-redux/branches{/branch}","tags_url":"https://api.github.com/repos/sandersky/ember-redux/tags","blobs_url":"https://api.github.com/repos/sandersky/ember-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandersky/ember-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandersky/ember-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandersky/ember-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandersky/ember-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/sandersky/ember-redux/languages","stargazers_url":"https://api.github.com/repos/sandersky/ember-redux/stargazers","contributors_url":"https://api.github.com/repos/sandersky/ember-redux/contributors","subscribers_url":"https://api.github.com/repos/sandersky/ember-redux/subscribers","subscription_url":"https://api.github.com/repos/sandersky/ember-redux/subscription","commits_url":"https://api.github.com/repos/sandersky/ember-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandersky/ember-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandersky/ember-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandersky/ember-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandersky/ember-redux/contents/{+path}","compare_url":"https://api.github.com/repos/sandersky/ember-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandersky/ember-redux/merges","archive_url":"https://api.github.com/repos/sandersky/ember-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandersky/ember-redux/downloads","issues_url":"https://api.github.com/repos/sandersky/ember-redux/issues{/number}","pulls_url":"https://api.github.com/repos/sandersky/ember-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/sandersky/ember-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/sandersky/ember-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandersky/ember-redux/labels{/name}","releases_url":"https://api.github.com/repos/sandersky/ember-redux/releases{/id}","deployments_url":"https://api.github.com/repos/sandersky/ember-redux/deployments","created_at":"2016-12-12T20:14:16Z","updated_at":"2016-12-12T20:14:18Z","pushed_at":"2017-02-18T21:07:57Z","git_url":"git://github.com/sandersky/ember-redux.git","ssh_url":"git@github.com:sandersky/ember-redux.git","clone_url":"https://github.com/sandersky/ember-redux.git","svn_url":"https://github.com/sandersky/ember-redux","homepage":null,"size":225,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-redux:master","ref":"master","sha":"1cb04085281472be0a9dcdc91c50b46766637685","user":{"login":"ember-redux","id":24817857,"avatar_url":"https://avatars.githubusercontent.com/u/24817857?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-redux","html_url":"https://github.com/ember-redux","followers_url":"https://api.github.com/users/ember-redux/followers","following_url":"https://api.github.com/users/ember-redux/following{/other_user}","gists_url":"https://api.github.com/users/ember-redux/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-redux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-redux/subscriptions","organizations_url":"https://api.github.com/users/ember-redux/orgs","repos_url":"https://api.github.com/users/ember-redux/repos","events_url":"https://api.github.com/users/ember-redux/events{/privacy}","received_events_url":"https://api.github.com/users/ember-redux/received_events","type":"Organization","site_admin":false},"repo":{"id":54754271,"name":"ember-redux","full_name":"ember-redux/ember-redux","owner":{"login":"ember-redux","id":24817857,"avatar_url":"https://avatars.githubusercontent.com/u/24817857?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-redux","html_url":"https://github.com/ember-redux","followers_url":"https://api.github.com/users/ember-redux/followers","following_url":"https://api.github.com/users/ember-redux/following{/other_user}","gists_url":"https://api.github.com/users/ember-redux/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-redux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-redux/subscriptions","organizations_url":"https://api.github.com/users/ember-redux/orgs","repos_url":"https://api.github.com/users/ember-redux/repos","events_url":"https://api.github.com/users/ember-redux/events{/privacy}","received_events_url":"https://api.github.com/users/ember-redux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-redux/ember-redux","description":"ember-cli addon that provides simple redux bindings for ember.js","fork":false,"url":"https://api.github.com/repos/ember-redux/ember-redux","forks_url":"https://api.github.com/repos/ember-redux/ember-redux/forks","keys_url":"https://api.github.com/repos/ember-redux/ember-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-redux/ember-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-redux/ember-redux/teams","hooks_url":"https://api.github.com/repos/ember-redux/ember-redux/hooks","issue_events_url":"https://api.github.com/repos/ember-redux/ember-redux/issues/events{/number}","events_url":"https://api.github.com/repos/ember-redux/ember-redux/events","assignees_url":"https://api.github.com/repos/ember-redux/ember-redux/assignees{/user}","branches_url":"https://api.github.com/repos/ember-redux/ember-redux/branches{/branch}","tags_url":"https://api.github.com/repos/ember-redux/ember-redux/tags","blobs_url":"https://api.github.com/repos/ember-redux/ember-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-redux/ember-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-redux/ember-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-redux/ember-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-redux/ember-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-redux/ember-redux/languages","stargazers_url":"https://api.github.com/repos/ember-redux/ember-redux/stargazers","contributors_url":"https://api.github.com/repos/ember-redux/ember-redux/contributors","subscribers_url":"https://api.github.com/repos/ember-redux/ember-redux/subscribers","subscription_url":"https://api.github.com/repos/ember-redux/ember-redux/subscription","commits_url":"https://api.github.com/repos/ember-redux/ember-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-redux/ember-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-redux/ember-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-redux/ember-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-redux/ember-redux/contents/{+path}","compare_url":"https://api.github.com/repos/ember-redux/ember-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-redux/ember-redux/merges","archive_url":"https://api.github.com/repos/ember-redux/ember-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-redux/ember-redux/downloads","issues_url":"https://api.github.com/repos/ember-redux/ember-redux/issues{/number}","pulls_url":"https://api.github.com/repos/ember-redux/ember-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-redux/ember-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-redux/ember-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-redux/ember-redux/labels{/name}","releases_url":"https://api.github.com/repos/ember-redux/ember-redux/releases{/id}","deployments_url":"https://api.github.com/repos/ember-redux/ember-redux/deployments","created_at":"2016-03-26T00:04:28Z","updated_at":"2017-02-10T17:54:21Z","pushed_at":"2017-02-18T21:09:38Z","git_url":"git://github.com/ember-redux/ember-redux.git","ssh_url":"git@github.com:ember-redux/ember-redux.git","clone_url":"https://github.com/ember-redux/ember-redux.git","svn_url":"https://github.com/ember-redux/ember-redux","homepage":null,"size":221,"stargazers_count":147,"watchers_count":147,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98"},"html":{"href":"https://github.com/ember-redux/ember-redux/pull/98"},"issue":{"href":"https://api.github.com/repos/ember-redux/ember-redux/issues/98"},"comments":{"href":"https://api.github.com/repos/ember-redux/ember-redux/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-redux/ember-redux/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/ember-redux/ember-redux/statuses/8c9a254026d6eeddb863eea5835375358a8984b0"}}}}
{"actor":{"display_login":"toranb"}}