{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/ghetzel/webfriend/pulls/4","id":143727192,"html_url":"https://github.com/ghetzel/webfriend/pull/4","diff_url":"https://github.com/ghetzel/webfriend/pull/4.diff","patch_url":"https://github.com/ghetzel/webfriend/pull/4.patch","issue_url":"https://api.github.com/repos/ghetzel/webfriend/issues/4","number":4,"state":"open","locked":false,"title":"Updating capture_screenshot and navigation timeout","user":{"login":"ghetzel","id":1638515,"avatar_url":"https://avatars2.githubusercontent.com/u/1638515?v=4","gravatar_id":"","url":"https://api.github.com/users/ghetzel","html_url":"https://github.com/ghetzel","followers_url":"https://api.github.com/users/ghetzel/followers","following_url":"https://api.github.com/users/ghetzel/following{/other_user}","gists_url":"https://api.github.com/users/ghetzel/gists{/gist_id}","starred_url":"https://api.github.com/users/ghetzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghetzel/subscriptions","organizations_url":"https://api.github.com/users/ghetzel/orgs","repos_url":"https://api.github.com/users/ghetzel/repos","events_url":"https://api.github.com/users/ghetzel/events{/privacy}","received_events_url":"https://api.github.com/users/ghetzel/received_events","type":"User","site_admin":false},"body":"## webfriend.rpc.page.capture_screenshot\r\n\r\n- Updated how `Page.captureScreenshot` is called to make use of the new \"clip\" parameter introduced in Chromium 61.  This parameter is only added if the (x,y) coordinates of an element matching the given `selector` are >0.  This provides support for taking screenshots of specific page elements (which was broken before this change).  If `x == y == 0`, the old method (using `Emulation.setDeviceMetricsOverride`) is still used to maintain backwards compatibility.\r\n\r\n- Added statements at the end of capture_screenshot that reset the viewport and screen size to default dimensions when completed.\r\n\r\n## webfriend.rpc.emulation.set_device_metrics_override\r\n\r\n- Four kwargs (`mobile_{screen_width,screen_height,position_x,position_y}`) were removed in favor of `screen_width`, `screen_height`, `position_x`, `position_y` to more closely match the `Emulation.setDeviceMetricsOverride` API.\r\n\r\n## webfriend.scripting.commands.core\r\n\r\n- **configure**: Added `referrer_prefix`, allowing implementers to specify the prefix that is used in the \"Referer\" tag when making requests.  Defaults to the Github project URL.\r\n\r\n- **go**: Added `continue_on_timeout` (default: True) to allow the script to continue execution (or not) if there is a timeout waiting for the load event.  Added `load_event_name`, allowing implementers to specify which RPC event to wait for.  As a result, `continue_on_error` no longer covers timeout exceptions, but still covers all other WebfriendError exceptions.\r\n\r\n","created_at":"2017-09-28T18:51:12Z","updated_at":"2017-09-28T18:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghetzel/webfriend/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ghetzel/webfriend/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ghetzel/webfriend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghetzel/webfriend/issues/4/comments","statuses_url":"https://api.github.com/repos/ghetzel/webfriend/statuses/c001f32e9c0c8573b15b8688a7db9db54744d504","head":{"label":"ghetzel:gh-fix-page-capture","ref":"gh-fix-page-capture","sha":"c001f32e9c0c8573b15b8688a7db9db54744d504","user":{"login":"ghetzel","id":1638515,"avatar_url":"https://avatars2.githubusercontent.com/u/1638515?v=4","gravatar_id":"","url":"https://api.github.com/users/ghetzel","html_url":"https://github.com/ghetzel","followers_url":"https://api.github.com/users/ghetzel/followers","following_url":"https://api.github.com/users/ghetzel/following{/other_user}","gists_url":"https://api.github.com/users/ghetzel/gists{/gist_id}","starred_url":"https://api.github.com/users/ghetzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghetzel/subscriptions","organizations_url":"https://api.github.com/users/ghetzel/orgs","repos_url":"https://api.github.com/users/ghetzel/repos","events_url":"https://api.github.com/users/ghetzel/events{/privacy}","received_events_url":"https://api.github.com/users/ghetzel/received_events","type":"User","site_admin":false},"repo":{"id":92885634,"name":"webfriend","full_name":"ghetzel/webfriend","owner":{"login":"ghetzel","id":1638515,"avatar_url":"https://avatars2.githubusercontent.com/u/1638515?v=4","gravatar_id":"","url":"https://api.github.com/users/ghetzel","html_url":"https://github.com/ghetzel","followers_url":"https://api.github.com/users/ghetzel/followers","following_url":"https://api.github.com/users/ghetzel/following{/other_user}","gists_url":"https://api.github.com/users/ghetzel/gists{/gist_id}","starred_url":"https://api.github.com/users/ghetzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghetzel/subscriptions","organizations_url":"https://api.github.com/users/ghetzel/orgs","repos_url":"https://api.github.com/users/ghetzel/repos","events_url":"https://api.github.com/users/ghetzel/events{/privacy}","received_events_url":"https://api.github.com/users/ghetzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghetzel/webfriend","description":"Your friendly friend in modern web automation and testing.","fork":false,"url":"https://api.github.com/repos/ghetzel/webfriend","forks_url":"https://api.github.com/repos/ghetzel/webfriend/forks","keys_url":"https://api.github.com/repos/ghetzel/webfriend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghetzel/webfriend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghetzel/webfriend/teams","hooks_url":"https://api.github.com/repos/ghetzel/webfriend/hooks","issue_events_url":"https://api.github.com/repos/ghetzel/webfriend/issues/events{/number}","events_url":"https://api.github.com/repos/ghetzel/webfriend/events","assignees_url":"https://api.github.com/repos/ghetzel/webfriend/assignees{/user}","branches_url":"https://api.github.com/repos/ghetzel/webfriend/branches{/branch}","tags_url":"https://api.github.com/repos/ghetzel/webfriend/tags","blobs_url":"https://api.github.com/repos/ghetzel/webfriend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghetzel/webfriend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghetzel/webfriend/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghetzel/webfriend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghetzel/webfriend/statuses/{sha}","languages_url":"https://api.github.com/repos/ghetzel/webfriend/languages","stargazers_url":"https://api.github.com/repos/ghetzel/webfriend/stargazers","contributors_url":"https://api.github.com/repos/ghetzel/webfriend/contributors","subscribers_url":"https://api.github.com/repos/ghetzel/webfriend/subscribers","subscription_url":"https://api.github.com/repos/ghetzel/webfriend/subscription","commits_url":"https://api.github.com/repos/ghetzel/webfriend/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghetzel/webfriend/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghetzel/webfriend/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghetzel/webfriend/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghetzel/webfriend/contents/{+path}","compare_url":"https://api.github.com/repos/ghetzel/webfriend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghetzel/webfriend/merges","archive_url":"https://api.github.com/repos/ghetzel/webfriend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghetzel/webfriend/downloads","issues_url":"https://api.github.com/repos/ghetzel/webfriend/issues{/number}","pulls_url":"https://api.github.com/repos/ghetzel/webfriend/pulls{/number}","milestones_url":"https://api.github.com/repos/ghetzel/webfriend/milestones{/number}","notifications_url":"https://api.github.com/repos/ghetzel/webfriend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghetzel/webfriend/labels{/name}","releases_url":"https://api.github.com/repos/ghetzel/webfriend/releases{/id}","deployments_url":"https://api.github.com/repos/ghetzel/webfriend/deployments","created_at":"2017-05-30T23:43:47Z","updated_at":"2017-09-09T23:57:58Z","pushed_at":"2017-09-28T18:38:07Z","git_url":"git://github.com/ghetzel/webfriend.git","ssh_url":"git@github.com:ghetzel/webfriend.git","clone_url":"https://github.com/ghetzel/webfriend.git","svn_url":"https://github.com/ghetzel/webfriend","homepage":null,"size":377,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":16,"default_branch":"master"}},"base":{"label":"ghetzel:master","ref":"master","sha":"7ac21566e665320375b8d91c0c820f19ef1bd63f","user":{"login":"ghetzel","id":1638515,"avatar_url":"https://avatars2.githubusercontent.com/u/1638515?v=4","gravatar_id":"","url":"https://api.github.com/users/ghetzel","html_url":"https://github.com/ghetzel","followers_url":"https://api.github.com/users/ghetzel/followers","following_url":"https://api.github.com/users/ghetzel/following{/other_user}","gists_url":"https://api.github.com/users/ghetzel/gists{/gist_id}","starred_url":"https://api.github.com/users/ghetzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghetzel/subscriptions","organizations_url":"https://api.github.com/users/ghetzel/orgs","repos_url":"https://api.github.com/users/ghetzel/repos","events_url":"https://api.github.com/users/ghetzel/events{/privacy}","received_events_url":"https://api.github.com/users/ghetzel/received_events","type":"User","site_admin":false},"repo":{"id":92885634,"name":"webfriend","full_name":"ghetzel/webfriend","owner":{"login":"ghetzel","id":1638515,"avatar_url":"https://avatars2.githubusercontent.com/u/1638515?v=4","gravatar_id":"","url":"https://api.github.com/users/ghetzel","html_url":"https://github.com/ghetzel","followers_url":"https://api.github.com/users/ghetzel/followers","following_url":"https://api.github.com/users/ghetzel/following{/other_user}","gists_url":"https://api.github.com/users/ghetzel/gists{/gist_id}","starred_url":"https://api.github.com/users/ghetzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghetzel/subscriptions","organizations_url":"https://api.github.com/users/ghetzel/orgs","repos_url":"https://api.github.com/users/ghetzel/repos","events_url":"https://api.github.com/users/ghetzel/events{/privacy}","received_events_url":"https://api.github.com/users/ghetzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghetzel/webfriend","description":"Your friendly friend in modern web automation and testing.","fork":false,"url":"https://api.github.com/repos/ghetzel/webfriend","forks_url":"https://api.github.com/repos/ghetzel/webfriend/forks","keys_url":"https://api.github.com/repos/ghetzel/webfriend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghetzel/webfriend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghetzel/webfriend/teams","hooks_url":"https://api.github.com/repos/ghetzel/webfriend/hooks","issue_events_url":"https://api.github.com/repos/ghetzel/webfriend/issues/events{/number}","events_url":"https://api.github.com/repos/ghetzel/webfriend/events","assignees_url":"https://api.github.com/repos/ghetzel/webfriend/assignees{/user}","branches_url":"https://api.github.com/repos/ghetzel/webfriend/branches{/branch}","tags_url":"https://api.github.com/repos/ghetzel/webfriend/tags","blobs_url":"https://api.github.com/repos/ghetzel/webfriend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghetzel/webfriend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghetzel/webfriend/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghetzel/webfriend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghetzel/webfriend/statuses/{sha}","languages_url":"https://api.github.com/repos/ghetzel/webfriend/languages","stargazers_url":"https://api.github.com/repos/ghetzel/webfriend/stargazers","contributors_url":"https://api.github.com/repos/ghetzel/webfriend/contributors","subscribers_url":"https://api.github.com/repos/ghetzel/webfriend/subscribers","subscription_url":"https://api.github.com/repos/ghetzel/webfriend/subscription","commits_url":"https://api.github.com/repos/ghetzel/webfriend/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghetzel/webfriend/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghetzel/webfriend/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghetzel/webfriend/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghetzel/webfriend/contents/{+path}","compare_url":"https://api.github.com/repos/ghetzel/webfriend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghetzel/webfriend/merges","archive_url":"https://api.github.com/repos/ghetzel/webfriend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghetzel/webfriend/downloads","issues_url":"https://api.github.com/repos/ghetzel/webfriend/issues{/number}","pulls_url":"https://api.github.com/repos/ghetzel/webfriend/pulls{/number}","milestones_url":"https://api.github.com/repos/ghetzel/webfriend/milestones{/number}","notifications_url":"https://api.github.com/repos/ghetzel/webfriend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghetzel/webfriend/labels{/name}","releases_url":"https://api.github.com/repos/ghetzel/webfriend/releases{/id}","deployments_url":"https://api.github.com/repos/ghetzel/webfriend/deployments","created_at":"2017-05-30T23:43:47Z","updated_at":"2017-09-09T23:57:58Z","pushed_at":"2017-09-28T18:38:07Z","git_url":"git://github.com/ghetzel/webfriend.git","ssh_url":"git@github.com:ghetzel/webfriend.git","clone_url":"https://github.com/ghetzel/webfriend.git","svn_url":"https://github.com/ghetzel/webfriend","homepage":null,"size":377,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghetzel/webfriend/pulls/4"},"html":{"href":"https://github.com/ghetzel/webfriend/pull/4"},"issue":{"href":"https://api.github.com/repos/ghetzel/webfriend/issues/4"},"comments":{"href":"https://api.github.com/repos/ghetzel/webfriend/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ghetzel/webfriend/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ghetzel/webfriend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghetzel/webfriend/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ghetzel/webfriend/statuses/c001f32e9c0c8573b15b8688a7db9db54744d504"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":234,"deletions":93,"changed_files":8}}
{"actor":{"display_login":"ghetzel"}}