{"action":"created","issue":{"url":"https://api.github.com/repos/heptio/ark/issues/98","repository_url":"https://api.github.com/repos/heptio/ark","labels_url":"https://api.github.com/repos/heptio/ark/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/heptio/ark/issues/98/comments","events_url":"https://api.github.com/repos/heptio/ark/issues/98/events","html_url":"https://github.com/heptio/ark/pull/98","id":257863014,"number":98,"title":"[WIP] migrate from glog to logrus","user":{"login":"skriss","id":5241206,"avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ncdc","id":354,"avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncdc","id":354,"avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-09-14T21:31:57Z","updated_at":"2017-10-02T20:44:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/98","html_url":"https://github.com/heptio/ark/pull/98","diff_url":"https://github.com/heptio/ark/pull/98.diff","patch_url":"https://github.com/heptio/ark/pull/98.patch"},"body":"Starting the migration to logrus. Appreciate any input before I continue across the rest of the codebase, particularly on what we should be logging at each level -- @davecheney, I know you have [thoughts](https://dave.cheney.net/2015/11/05/lets-talk-about-logging) on the matter :)\r\n\r\nFixes #70 "},"comment":{"url":"https://api.github.com/repos/heptio/ark/issues/comments/333659459","html_url":"https://github.com/heptio/ark/pull/98#issuecomment-333659459","issue_url":"https://api.github.com/repos/heptio/ark/issues/98","id":333659459,"user":{"login":"ncdc","id":354,"avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"created_at":"2017-10-02T20:44:57Z","updated_at":"2017-10-02T20:44:57Z","author_association":"CONTRIBUTOR","body":"@davecheney @skriss what do you think of the way that the docker/distribution project has organized its logging? To summarize:\r\n\r\n- It has its own `context` package that supports retrieving a logger, with or without ad-hoc fields as well as predefined context values\r\n- Major components embed a `Context` in the structs for component-scoped information\r\n- Individual methods can create new subcontexts with method-scoped fields\r\n\r\nSee e.g. docs at https://github.com/docker/distribution/blob/master/context/doc.go\r\n\r\nI'm trying to avoid having to pass loggers into lots and lots of functions. I think I'd prefer they exist as part of a Context, and optionally that our major structs embed the Context for easier access.\r\n\r\nWDYT?"}}
{"actor":{"display_login":"ncdc"}}