{"action":"created","issue":{"url":"https://api.github.com/repos/oe-alliance/satip-client/issues/3","repository_url":"https://api.github.com/repos/oe-alliance/satip-client","labels_url":"https://api.github.com/repos/oe-alliance/satip-client/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/oe-alliance/satip-client/issues/3/comments","events_url":"https://api.github.com/repos/oe-alliance/satip-client/issues/3/events","html_url":"https://github.com/oe-alliance/satip-client/pull/3","id":210474256,"number":3,"title":"auto detect and avoid ioctl conflicts","user":{"login":"pieterg","id":1038561,"avatar_url":"https://avatars.githubusercontent.com/u/1038561?v=3","gravatar_id":"","url":"https://api.github.com/users/pieterg","html_url":"https://github.com/pieterg","followers_url":"https://api.github.com/users/pieterg/followers","following_url":"https://api.github.com/users/pieterg/following{/other_user}","gists_url":"https://api.github.com/users/pieterg/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterg/subscriptions","organizations_url":"https://api.github.com/users/pieterg/orgs","repos_url":"https://api.github.com/users/pieterg/repos","events_url":"https://api.github.com/users/pieterg/events{/privacy}","received_events_url":"https://api.github.com/users/pieterg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-27T12:47:58Z","updated_at":"2017-02-28T08:24:30Z","closed_at":"2017-02-27T23:02:00Z","pull_request":{"url":"https://api.github.com/repos/oe-alliance/satip-client/pulls/3","html_url":"https://github.com/oe-alliance/satip-client/pull/3","diff_url":"https://github.com/oe-alliance/satip-client/pull/3.diff","patch_url":"https://github.com/oe-alliance/satip-client/pull/3.patch"},"body":"The vtuner interface does not use proper ioctl defines, causing\r\npotential ioctl number conflicts with kernel built-in ioctls (such as\r\nthe bmap ioctls).\r\nWhether or not these conflicts will occur, depends on the architecture\r\ndefinition of _IOC_NONE. When _IOC_NONE is zero, the vtuner ioctls 1 and\r\n2 will conflict with the bmap ioctls, therefore we should not use them.\r\nInstead, use higher numbers in that case and expect the vtuner driver on\r\nthat particular platform to support them.\r\n(this would have been a good time to introduce proper ioctl numbers\r\nusing the ioctl macros, however we do depend on the vtuner driver\r\ndevelopers to make those definitions)\r\n\r\nAuto detecting and working around this situation avoids the need to\r\ncreate manual exceptions for each new platform to be supported.\r\nVMSG_TYPE2 no longer needs to be defined."},"comment":{"url":"https://api.github.com/repos/oe-alliance/satip-client/issues/comments/282973830","html_url":"https://github.com/oe-alliance/satip-client/pull/3#issuecomment-282973830","issue_url":"https://api.github.com/repos/oe-alliance/satip-client/issues/3","id":282973830,"user":{"login":"pieterg","id":1038561,"avatar_url":"https://avatars.githubusercontent.com/u/1038561?v=3","gravatar_id":"","url":"https://api.github.com/users/pieterg","html_url":"https://github.com/pieterg","followers_url":"https://api.github.com/users/pieterg/followers","following_url":"https://api.github.com/users/pieterg/following{/other_user}","gists_url":"https://api.github.com/users/pieterg/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterg/subscriptions","organizations_url":"https://api.github.com/users/pieterg/orgs","repos_url":"https://api.github.com/users/pieterg/repos","events_url":"https://api.github.com/users/pieterg/events{/privacy}","received_events_url":"https://api.github.com/users/pieterg/received_events","type":"User","site_admin":false},"created_at":"2017-02-28T08:24:30Z","updated_at":"2017-02-28T08:24:30Z","body":"and yes indeed, the usbtunerhelper could use the same check"}}
{"actor":{"display_login":"pieterg"}}