{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9439","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9439/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9439/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9439/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9439","id":244924103,"number":9439,"title":"[WIP] Make knn kernel undirected.","user":{"login":"musically-ut","id":502876,"avatar_url":"https://avatars1.githubusercontent.com/u/502876?v=4","gravatar_id":"","url":"https://api.github.com/users/musically-ut","html_url":"https://github.com/musically-ut","followers_url":"https://api.github.com/users/musically-ut/followers","following_url":"https://api.github.com/users/musically-ut/following{/other_user}","gists_url":"https://api.github.com/users/musically-ut/gists{/gist_id}","starred_url":"https://api.github.com/users/musically-ut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musically-ut/subscriptions","organizations_url":"https://api.github.com/users/musically-ut/orgs","repos_url":"https://api.github.com/users/musically-ut/repos","events_url":"https://api.github.com/users/musically-ut/events{/privacy}","received_events_url":"https://api.github.com/users/musically-ut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-23T17:28:23Z","updated_at":"2017-07-23T23:08:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9439","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9439","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/9439.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/9439.patch"},"body":"This is a very simple way of making the `knn` kernel matrix symmetric. However, this slightly changes the meaning of `n_neighbors`: the _actual_ number of neighbors may vary from `n_neighbors` to `2 * n_neighbors` in the worst case.\r\n\r\n - [ ] Update tests after #5893 is merged.\r\n\r\nFixes #8008."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/317288995","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9439#issuecomment-317288995","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9439","id":317288995,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2017-07-23T23:08:56Z","updated_at":"2017-07-23T23:08:56Z","body":"do we have reference to guide this change? (sorry if they're listed in the\nissue)\n\nOn 24 Jul 2017 3:28 am, \"Utkarsh Upadhyay\" <notifications@github.com> wrote:\n\n> This is a very simple way of making the knn kernel matrix symmetric.\n> However, this slightly changes the meaning of n_neighbors: the *actual*\n> number of neighbors may vary from n_neighbors to 2 * n_neighbors in the\n> worst case.\n>\n>    - Update tests after #5893\n>    <https://github.com/scikit-learn/scikit-learn/pull/5893> is merged.\n>\n> Fixes #8008 <https://github.com/scikit-learn/scikit-learn/issues/8008>.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/scikit-learn/scikit-learn/pull/9439\n> Commit Summary\n>\n>    - Make knn kernel undirected.\n>\n> File Changes\n>\n>    - *M* sklearn/semi_supervised/label_propagation.py\n>    <https://github.com/scikit-learn/scikit-learn/pull/9439/files#diff-0>\n>    (13)\n>    - *M* sklearn/semi_supervised/tests/test_label_propagation.py\n>    <https://github.com/scikit-learn/scikit-learn/pull/9439/files#diff-1>\n>    (40)\n>\n> Patch Links:\n>\n>    - https://github.com/scikit-learn/scikit-learn/pull/9439.patch\n>    - https://github.com/scikit-learn/scikit-learn/pull/9439.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/scikit-learn/scikit-learn/pull/9439>, or mute the\n> thread\n> <https://github.com/notifications/unsubscribe-auth/AAEz64rv6gXp9bvPcQNKetvMyKrQW-Uhks5sQ4K5gaJpZM4Ogg-1>\n> .\n>\n"}}
{"actor":{"display_login":"jnothman"}}