{"action":"opened","number":107,"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107","id":119026703,"html_url":"https://github.com/endlessm/eos-boot-helper/pull/107","diff_url":"https://github.com/endlessm/eos-boot-helper/pull/107.diff","patch_url":"https://github.com/endlessm/eos-boot-helper/pull/107.patch","issue_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/107","number":107,"state":"open","locked":false,"title":"Only allow admins to mount image host partition","user":{"login":"wjt","id":86760,"avatar_url":"https://avatars1.githubusercontent.com/u/86760?v=3","gravatar_id":"","url":"https://api.github.com/users/wjt","html_url":"https://github.com/wjt","followers_url":"https://api.github.com/users/wjt/followers","following_url":"https://api.github.com/users/wjt/following{/other_user}","gists_url":"https://api.github.com/users/wjt/gists{/gist_id}","starred_url":"https://api.github.com/users/wjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjt/subscriptions","organizations_url":"https://api.github.com/users/wjt/orgs","repos_url":"https://api.github.com/users/wjt/repos","events_url":"https://api.github.com/users/wjt/events{/privacy}","received_events_url":"https://api.github.com/users/wjt/received_events","type":"User","site_admin":false},"body":"Previously, a standard user (such as the passwordless `shared` user) could mount the partition hosting the `endless.img` file without any authentication. On a dual-boot system, this is the Windows `C:` drive.  We do not enforce any per-file access controls within the NTFS partition (it's hard to map between Windows and Endless OS users, we don't even try) so this allowed a non-admin user on Endless OS to read and write any file on the Windows drive.\n\nWith this change, only administrators will be able to mount the image host partition without authentication. If a standard user tries to mount it, they're asked to authenticate with an administrator's password.\n\nIf `alice`, an administrator, mounts the device, and `bob`, a standard user, logs in on VT2, `bob` cannot access the mounted device because it is mounted at `/run/media/alice/$LABEL`. That mount point itself, and all its contents, are world-readable and world-writable, but `/run/media/alice` is only readable by `root` and `alice`.\n\nhttps://phabricator.endlessm.com/T16890","created_at":"2017-05-04T17:33:36Z","updated_at":"2017-05-04T17:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/107/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/46138345f2bcb48bc16171838d2ff11f1336ef03","head":{"label":"endlessm:T16890","ref":"T16890","sha":"46138345f2bcb48bc16171838d2ff11f1336ef03","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-05-04T17:32:02Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"git@github.com:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":192,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"bec2afd7f7ab4492f3a68f38186afce63ea26e42","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-05-04T17:32:02Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"git@github.com:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":192,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/107"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/107"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/46138345f2bcb48bc16171838d2ff11f1336ef03"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"wjt"}}