{"action":"created","comment":{"url":"https://api.github.com/repos/naemon/naemon-core/pulls/comments/111398190","pull_request_review_id":32634230,"id":111398190,"diff_hunk":"@@ -0,0 +1,139 @@\n+class NaemonObjectConfig(object):\n+\n+    filename = 'oconf.cfg'\n+\n+    def __init__(self):\n+        self.current_config = {\n+            'contact': [{\n+                'name': 'default-contact',\n+                'contact_name': 'default-contact',\n+                'host_notifications_enabled': '1',\n+                'service_notifications_enabled': '1',\n+                'host_notification_period': '24x7',\n+                'service_notification_period': '24x7',\n+                'host_notification_options': 'a',\n+                'service_notification_options': 'a',\n+                'host_notification_commands': 'log_notif_host',\n+                'service_notification_commands': 'log_notif_service',\n+            }],\n+            'timeperiod': [{\n+                'timeperiod_name': '24x7',\n+                'alias': '24x7',\n+                'sunday': '00:00-24:00',\n+                'monday': '00:00-24:00',\n+                'tuesday': '00:00-24:00',\n+                'wednesday': '00:00-24:00',\n+                'thursday': '00:00-24:00',\n+                'friday': '00:00-24:00',\n+                'saturday': '00:00-24:00'\n+            }],\n+            'command': [{\n+                'command_name': 'log_check_host',\n+                'command_line': './check_cmd check host $HOSTNAME$'\n+            }, {\n+                'command_name': 'log_check_service',\n+                'command_line': (\n+                    './check_cmd check service $HOSTNAME$ $SERVICEDESC$'\n+                )\n+            }, {\n+                'command_name': 'log_notif_host',\n+                'command_line': (\n+                    './notif_cmd notif host'\n+                    ' hostname=\"$HOSTNAME$\"'\n+                    ' notificationcomment=\"$NOTIFICATIONCOMMENT$\"'\n+                    ' notificationtype=\"$NOTIFICATIONTYPE$\"'\n+                    ' hoststate=\"$HOSTSTATE$\"'\n+                    ' hostoutput=\"$HOSTOUTPUT$\"'\n+                    ' longhostoutput=\"$LONGHOSTOUTPUT$\"'\n+                )\n+            }, {\n+                'command_name': 'log_notif_service',\n+                'command_line': (\n+                    './notif_cmd notif service'\n+                    ' hostname=\"$HOSTNAME$\"'\n+                    ' servicedesc=\"$SERVICEDESC$\"'\n+                    ' notificationcomment=\"$NOTIFICATIONCOMMENT$\"'\n+                    ' notificationtype=\"$NOTIFICATIONTYPE$\"'\n+                    ' servicestate=\"$SERVICESTATE$\"'\n+                    ' serviceoutput=\"$SERVICEOUTPUT$\"'\n+                    ' longserviceoutput=\"$LONGSERVICEOUTPUT$\"'\n+                )\n+            }, {\n+                'command_name': 'check_long_output',\n+                'command_line': './output_cmd'\n+            }, {\n+                'command_name': 'check_active_ok',\n+                'command_line': './active_ok_cmd'","path":"features/support/naemon_object_config.py","position":66,"original_position":66,"commit_id":"6d55c6ffb41c927d4e47393279d720ca1079270d","original_commit_id":"c52868f51d1dbd82ba8725e57ccec4d26ab505b0","user":{"login":"tvestelind","id":699403,"avatar_url":"https://avatars0.githubusercontent.com/u/699403?v=3","gravatar_id":"","url":"https://api.github.com/users/tvestelind","html_url":"https://github.com/tvestelind","followers_url":"https://api.github.com/users/tvestelind/followers","following_url":"https://api.github.com/users/tvestelind/following{/other_user}","gists_url":"https://api.github.com/users/tvestelind/gists{/gist_id}","starred_url":"https://api.github.com/users/tvestelind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvestelind/subscriptions","organizations_url":"https://api.github.com/users/tvestelind/orgs","repos_url":"https://api.github.com/users/tvestelind/repos","events_url":"https://api.github.com/users/tvestelind/events{/privacy}","received_events_url":"https://api.github.com/users/tvestelind/received_events","type":"User","site_admin":false},"body":"same as `exit 0` right?","created_at":"2017-04-13T14:08:32Z","updated_at":"2017-04-13T14:32:39Z","html_url":"https://github.com/naemon/naemon-core/pull/175#discussion_r111398190","pull_request_url":"https://api.github.com/repos/naemon/naemon-core/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/comments/111398190"},"html":{"href":"https://github.com/naemon/naemon-core/pull/175#discussion_r111398190"},"pull_request":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/naemon/naemon-core/pulls/175","id":115535241,"html_url":"https://github.com/naemon/naemon-core/pull/175","diff_url":"https://github.com/naemon/naemon-core/pull/175.diff","patch_url":"https://github.com/naemon/naemon-core/pull/175.patch","issue_url":"https://api.github.com/repos/naemon/naemon-core/issues/175","number":175,"state":"open","locked":false,"title":"Feature/mon 10198 fail naemon start when daemonizing","user":{"login":"roengstrom","id":26772201,"avatar_url":"https://avatars3.githubusercontent.com/u/26772201?v=3","gravatar_id":"","url":"https://api.github.com/users/roengstrom","html_url":"https://github.com/roengstrom","followers_url":"https://api.github.com/users/roengstrom/followers","following_url":"https://api.github.com/users/roengstrom/following{/other_user}","gists_url":"https://api.github.com/users/roengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/roengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roengstrom/subscriptions","organizations_url":"https://api.github.com/users/roengstrom/orgs","repos_url":"https://api.github.com/users/roengstrom/repos","events_url":"https://api.github.com/users/roengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/roengstrom/received_events","type":"User","site_admin":false},"body":"Doing configuration changes in a large environments with big configuration files and then restarting naemon will take a very long time. We would like to remove all verification done when starting and restarting and make configuration verification explicit through `naemon -v`.\r\n\r\nThis patch removes the verification done in the init script. It also makes the parent wait for the child to be fully initialized before exiting the parent, making it possible to catch if the child fails during the initialization.","created_at":"2017-04-12T12:54:22Z","updated_at":"2017-04-13T14:32:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac768560c3de45f6fae68ca86138059c14326b30","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/naemon/naemon-core/pulls/175/commits","review_comments_url":"https://api.github.com/repos/naemon/naemon-core/pulls/175/comments","review_comment_url":"https://api.github.com/repos/naemon/naemon-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/naemon/naemon-core/issues/175/comments","statuses_url":"https://api.github.com/repos/naemon/naemon-core/statuses/6d55c6ffb41c927d4e47393279d720ca1079270d","head":{"label":"roengstrom:feature/MON-10198-fail-naemon-start-when-daemonizing","ref":"feature/MON-10198-fail-naemon-start-when-daemonizing","sha":"6d55c6ffb41c927d4e47393279d720ca1079270d","user":{"login":"roengstrom","id":26772201,"avatar_url":"https://avatars3.githubusercontent.com/u/26772201?v=3","gravatar_id":"","url":"https://api.github.com/users/roengstrom","html_url":"https://github.com/roengstrom","followers_url":"https://api.github.com/users/roengstrom/followers","following_url":"https://api.github.com/users/roengstrom/following{/other_user}","gists_url":"https://api.github.com/users/roengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/roengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roengstrom/subscriptions","organizations_url":"https://api.github.com/users/roengstrom/orgs","repos_url":"https://api.github.com/users/roengstrom/repos","events_url":"https://api.github.com/users/roengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/roengstrom/received_events","type":"User","site_admin":false},"repo":{"id":88045309,"name":"naemon-core","full_name":"roengstrom/naemon-core","owner":{"login":"roengstrom","id":26772201,"avatar_url":"https://avatars3.githubusercontent.com/u/26772201?v=3","gravatar_id":"","url":"https://api.github.com/users/roengstrom","html_url":"https://github.com/roengstrom","followers_url":"https://api.github.com/users/roengstrom/followers","following_url":"https://api.github.com/users/roengstrom/following{/other_user}","gists_url":"https://api.github.com/users/roengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/roengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roengstrom/subscriptions","organizations_url":"https://api.github.com/users/roengstrom/orgs","repos_url":"https://api.github.com/users/roengstrom/repos","events_url":"https://api.github.com/users/roengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/roengstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roengstrom/naemon-core","description":"Networks, Applications and Event Monitor","fork":true,"url":"https://api.github.com/repos/roengstrom/naemon-core","forks_url":"https://api.github.com/repos/roengstrom/naemon-core/forks","keys_url":"https://api.github.com/repos/roengstrom/naemon-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roengstrom/naemon-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roengstrom/naemon-core/teams","hooks_url":"https://api.github.com/repos/roengstrom/naemon-core/hooks","issue_events_url":"https://api.github.com/repos/roengstrom/naemon-core/issues/events{/number}","events_url":"https://api.github.com/repos/roengstrom/naemon-core/events","assignees_url":"https://api.github.com/repos/roengstrom/naemon-core/assignees{/user}","branches_url":"https://api.github.com/repos/roengstrom/naemon-core/branches{/branch}","tags_url":"https://api.github.com/repos/roengstrom/naemon-core/tags","blobs_url":"https://api.github.com/repos/roengstrom/naemon-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roengstrom/naemon-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roengstrom/naemon-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/roengstrom/naemon-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roengstrom/naemon-core/statuses/{sha}","languages_url":"https://api.github.com/repos/roengstrom/naemon-core/languages","stargazers_url":"https://api.github.com/repos/roengstrom/naemon-core/stargazers","contributors_url":"https://api.github.com/repos/roengstrom/naemon-core/contributors","subscribers_url":"https://api.github.com/repos/roengstrom/naemon-core/subscribers","subscription_url":"https://api.github.com/repos/roengstrom/naemon-core/subscription","commits_url":"https://api.github.com/repos/roengstrom/naemon-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/roengstrom/naemon-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/roengstrom/naemon-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/roengstrom/naemon-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/roengstrom/naemon-core/contents/{+path}","compare_url":"https://api.github.com/repos/roengstrom/naemon-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roengstrom/naemon-core/merges","archive_url":"https://api.github.com/repos/roengstrom/naemon-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roengstrom/naemon-core/downloads","issues_url":"https://api.github.com/repos/roengstrom/naemon-core/issues{/number}","pulls_url":"https://api.github.com/repos/roengstrom/naemon-core/pulls{/number}","milestones_url":"https://api.github.com/repos/roengstrom/naemon-core/milestones{/number}","notifications_url":"https://api.github.com/repos/roengstrom/naemon-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roengstrom/naemon-core/labels{/name}","releases_url":"https://api.github.com/repos/roengstrom/naemon-core/releases{/id}","deployments_url":"https://api.github.com/repos/roengstrom/naemon-core/deployments","created_at":"2017-04-12T11:41:08Z","updated_at":"2017-04-12T11:41:10Z","pushed_at":"2017-04-13T14:27:37Z","git_url":"git://github.com/roengstrom/naemon-core.git","ssh_url":"git@github.com:roengstrom/naemon-core.git","clone_url":"https://github.com/roengstrom/naemon-core.git","svn_url":"https://github.com/roengstrom/naemon-core","homepage":null,"size":16771,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"naemon:master","ref":"master","sha":"4b1d7c77c3771267ae32f01449d1966b1f333c6b","user":{"login":"naemon","id":5692075,"avatar_url":"https://avatars3.githubusercontent.com/u/5692075?v=3","gravatar_id":"","url":"https://api.github.com/users/naemon","html_url":"https://github.com/naemon","followers_url":"https://api.github.com/users/naemon/followers","following_url":"https://api.github.com/users/naemon/following{/other_user}","gists_url":"https://api.github.com/users/naemon/gists{/gist_id}","starred_url":"https://api.github.com/users/naemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naemon/subscriptions","organizations_url":"https://api.github.com/users/naemon/orgs","repos_url":"https://api.github.com/users/naemon/repos","events_url":"https://api.github.com/users/naemon/events{/privacy}","received_events_url":"https://api.github.com/users/naemon/received_events","type":"Organization","site_admin":false},"repo":{"id":14040015,"name":"naemon-core","full_name":"naemon/naemon-core","owner":{"login":"naemon","id":5692075,"avatar_url":"https://avatars3.githubusercontent.com/u/5692075?v=3","gravatar_id":"","url":"https://api.github.com/users/naemon","html_url":"https://github.com/naemon","followers_url":"https://api.github.com/users/naemon/followers","following_url":"https://api.github.com/users/naemon/following{/other_user}","gists_url":"https://api.github.com/users/naemon/gists{/gist_id}","starred_url":"https://api.github.com/users/naemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naemon/subscriptions","organizations_url":"https://api.github.com/users/naemon/orgs","repos_url":"https://api.github.com/users/naemon/repos","events_url":"https://api.github.com/users/naemon/events{/privacy}","received_events_url":"https://api.github.com/users/naemon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/naemon/naemon-core","description":"Networks, Applications and Event Monitor","fork":false,"url":"https://api.github.com/repos/naemon/naemon-core","forks_url":"https://api.github.com/repos/naemon/naemon-core/forks","keys_url":"https://api.github.com/repos/naemon/naemon-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naemon/naemon-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naemon/naemon-core/teams","hooks_url":"https://api.github.com/repos/naemon/naemon-core/hooks","issue_events_url":"https://api.github.com/repos/naemon/naemon-core/issues/events{/number}","events_url":"https://api.github.com/repos/naemon/naemon-core/events","assignees_url":"https://api.github.com/repos/naemon/naemon-core/assignees{/user}","branches_url":"https://api.github.com/repos/naemon/naemon-core/branches{/branch}","tags_url":"https://api.github.com/repos/naemon/naemon-core/tags","blobs_url":"https://api.github.com/repos/naemon/naemon-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naemon/naemon-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naemon/naemon-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/naemon/naemon-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naemon/naemon-core/statuses/{sha}","languages_url":"https://api.github.com/repos/naemon/naemon-core/languages","stargazers_url":"https://api.github.com/repos/naemon/naemon-core/stargazers","contributors_url":"https://api.github.com/repos/naemon/naemon-core/contributors","subscribers_url":"https://api.github.com/repos/naemon/naemon-core/subscribers","subscription_url":"https://api.github.com/repos/naemon/naemon-core/subscription","commits_url":"https://api.github.com/repos/naemon/naemon-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/naemon/naemon-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/naemon/naemon-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/naemon/naemon-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/naemon/naemon-core/contents/{+path}","compare_url":"https://api.github.com/repos/naemon/naemon-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naemon/naemon-core/merges","archive_url":"https://api.github.com/repos/naemon/naemon-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naemon/naemon-core/downloads","issues_url":"https://api.github.com/repos/naemon/naemon-core/issues{/number}","pulls_url":"https://api.github.com/repos/naemon/naemon-core/pulls{/number}","milestones_url":"https://api.github.com/repos/naemon/naemon-core/milestones{/number}","notifications_url":"https://api.github.com/repos/naemon/naemon-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naemon/naemon-core/labels{/name}","releases_url":"https://api.github.com/repos/naemon/naemon-core/releases{/id}","deployments_url":"https://api.github.com/repos/naemon/naemon-core/deployments","created_at":"2013-11-01T09:49:48Z","updated_at":"2017-03-16T16:59:23Z","pushed_at":"2017-04-13T14:27:38Z","git_url":"git://github.com/naemon/naemon-core.git","ssh_url":"git@github.com:naemon/naemon-core.git","clone_url":"https://github.com/naemon/naemon-core.git","svn_url":"https://github.com/naemon/naemon-core","homepage":null,"size":16763,"stargazers_count":81,"watchers_count":81,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":25,"forks":37,"open_issues":25,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/175"},"html":{"href":"https://github.com/naemon/naemon-core/pull/175"},"issue":{"href":"https://api.github.com/repos/naemon/naemon-core/issues/175"},"comments":{"href":"https://api.github.com/repos/naemon/naemon-core/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/naemon/naemon-core/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/naemon/naemon-core/statuses/6d55c6ffb41c927d4e47393279d720ca1079270d"}}}}
{"actor":{"display_login":"tvestelind"}}