{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments/154603783","pull_request_review_id":80788028,"id":154603783,"diff_hunk":"@@ -122,4 +122,20 @@ extern const TEEC_UUID socket_ta_uuid;\n extern const TEEC_UUID sdp_basic_ta_uuid;\n extern char *_device;\n \n+#ifndef TA_DIR\n+# ifdef __ANDROID__\n+#define TA_DIR \"/system/lib/optee_armtz\"\n+# else\n+#define TA_DIR \"/lib/optee_armtz\"\n+# endif\n+#endif\n+\n+#ifndef TA_TEST_DIR","path":"host/xtest/xtest_test.h","position":12,"original_position":12,"commit_id":"80b8e59415794013dfab02f722fd763ac589dd80","original_commit_id":"80b8e59415794013dfab02f722fd763ac589dd80","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars2.githubusercontent.com/u/8288195?v=4","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"It's not used in the HEAD of this PR, right?\r\n\r\n```\r\n$ git fetch origin pull/240/head\r\nFrom https://github.com/OP-TEE/optee_test\r\n * branch                      refs/pull/240/head -> FETCH_HEAD\r\n$ git checkout FETCH_HEAD \r\nHEAD is now at 80b8e5941579... [review] xtest: add --install-tas argument\r\n$ git grep TA_TEST_DIR\r\nhost/xtest/xtest_test.h:#ifndef TA_TEST_DIR\r\nhost/xtest/xtest_test.h:#  define TA_TEST_DIR \"/data/tee/optee_armtz\"\r\nhost/xtest/xtest_test.h:#  define TA_TEST_DIR \"/tmp/optee_armtz\"\r\n```\r\n\r\nSo I think it should remain in `host/xtest/regression_1000.c` until it finally gets removed by \"regression 1008: test with corrupt BSTA\".","created_at":"2017-12-04T10:03:59Z","updated_at":"2017-12-04T10:03:59Z","html_url":"https://github.com/OP-TEE/optee_test/pull/240#discussion_r154603783","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments/154603783"},"html":{"href":"https://github.com/OP-TEE/optee_test/pull/240#discussion_r154603783"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240"}},"in_reply_to_id":154572520},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240","id":151689582,"html_url":"https://github.com/OP-TEE/optee_test/pull/240","diff_url":"https://github.com/OP-TEE/optee_test/pull/240.diff","patch_url":"https://github.com/OP-TEE/optee_test/pull/240.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/240","number":240,"state":"open","locked":false,"title":"xtest: add --install-tas argument","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"Adds --install-tas argument which will install all bootstrap TAs\r\n(/lib/optee_armtz/*.bsta) in the OP-TEE TA database.\r\n\r\nSigned-off-by: Jens Wiklander <jens.wiklander@linaro.org>\r\n\r\nNeeded by https://github.com/OP-TEE/optee_os/pull/1928 to install bootstrap TAs.","created_at":"2017-11-09T15:55:49Z","updated_at":"2017-12-04T10:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0e0441842514a0190bbbc7096ba7b0586825655","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/240/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_test/statuses/80b8e59415794013dfab02f722fd763ac589dd80","head":{"label":"jenswi-linaro:ta_mgt","ref":"ta_mgt","sha":"80b8e59415794013dfab02f722fd763ac589dd80","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"repo":{"id":38651052,"name":"optee_test","full_name":"jenswi-linaro/optee_test","owner":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenswi-linaro/optee_test","description":"Test suite","fork":true,"url":"https://api.github.com/repos/jenswi-linaro/optee_test","forks_url":"https://api.github.com/repos/jenswi-linaro/optee_test/forks","keys_url":"https://api.github.com/repos/jenswi-linaro/optee_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenswi-linaro/optee_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenswi-linaro/optee_test/teams","hooks_url":"https://api.github.com/repos/jenswi-linaro/optee_test/hooks","issue_events_url":"https://api.github.com/repos/jenswi-linaro/optee_test/issues/events{/number}","events_url":"https://api.github.com/repos/jenswi-linaro/optee_test/events","assignees_url":"https://api.github.com/repos/jenswi-linaro/optee_test/assignees{/user}","branches_url":"https://api.github.com/repos/jenswi-linaro/optee_test/branches{/branch}","tags_url":"https://api.github.com/repos/jenswi-linaro/optee_test/tags","blobs_url":"https://api.github.com/repos/jenswi-linaro/optee_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenswi-linaro/optee_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenswi-linaro/optee_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenswi-linaro/optee_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenswi-linaro/optee_test/statuses/{sha}","languages_url":"https://api.github.com/repos/jenswi-linaro/optee_test/languages","stargazers_url":"https://api.github.com/repos/jenswi-linaro/optee_test/stargazers","contributors_url":"https://api.github.com/repos/jenswi-linaro/optee_test/contributors","subscribers_url":"https://api.github.com/repos/jenswi-linaro/optee_test/subscribers","subscription_url":"https://api.github.com/repos/jenswi-linaro/optee_test/subscription","commits_url":"https://api.github.com/repos/jenswi-linaro/optee_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenswi-linaro/optee_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenswi-linaro/optee_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenswi-linaro/optee_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenswi-linaro/optee_test/contents/{+path}","compare_url":"https://api.github.com/repos/jenswi-linaro/optee_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenswi-linaro/optee_test/merges","archive_url":"https://api.github.com/repos/jenswi-linaro/optee_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenswi-linaro/optee_test/downloads","issues_url":"https://api.github.com/repos/jenswi-linaro/optee_test/issues{/number}","pulls_url":"https://api.github.com/repos/jenswi-linaro/optee_test/pulls{/number}","milestones_url":"https://api.github.com/repos/jenswi-linaro/optee_test/milestones{/number}","notifications_url":"https://api.github.com/repos/jenswi-linaro/optee_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenswi-linaro/optee_test/labels{/name}","releases_url":"https://api.github.com/repos/jenswi-linaro/optee_test/releases{/id}","deployments_url":"https://api.github.com/repos/jenswi-linaro/optee_test/deployments","created_at":"2015-07-06T23:01:55Z","updated_at":"2016-01-26T13:05:31Z","pushed_at":"2017-11-29T14:33:42Z","git_url":"git://github.com/jenswi-linaro/optee_test.git","ssh_url":"git@github.com:jenswi-linaro/optee_test.git","clone_url":"https://github.com/jenswi-linaro/optee_test.git","svn_url":"https://github.com/jenswi-linaro/optee_test","homepage":null,"size":3516,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"b31d4a96882bf0036e518c40500b35a788b0c120","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":38317938,"name":"optee_test","full_name":"OP-TEE/optee_test","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_test","description":"Test suite","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_test","forks_url":"https://api.github.com/repos/OP-TEE/optee_test/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_test/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_test/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_test/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_test/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_test/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_test/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_test/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_test/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_test/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_test/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_test/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_test/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_test/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_test/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_test/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_test/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_test/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_test/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_test/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_test/deployments","created_at":"2015-06-30T15:40:48Z","updated_at":"2017-10-06T21:42:02Z","pushed_at":"2017-11-29T14:33:44Z","git_url":"git://github.com/OP-TEE/optee_test.git","ssh_url":"git@github.com:OP-TEE/optee_test.git","clone_url":"https://github.com/OP-TEE/optee_test.git","svn_url":"https://github.com/OP-TEE/optee_test","homepage":null,"size":3470,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":62,"open_issues":10,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240"},"html":{"href":"https://github.com/OP-TEE/optee_test/pull/240"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_test/issues/240"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_test/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_test/statuses/80b8e59415794013dfab02f722fd763ac589dd80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jforissier"}}