{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/113331755","pull_request_review_id":34710566,"id":113331755,"diff_hunk":"@@ -110,9 +110,9 @@ class AndroidDevice extends Device {\n   @override\n   String get sdkNameAndVersion => 'Android $_sdkVersion (API $_apiVersion)';","path":"packages/flutter_tools/lib/src/android/android_device.dart","position":35,"original_position":35,"commit_id":"328bc089646a891aa88a30ec8da3d97f5edc0db4","original_commit_id":"328bc089646a891aa88a30ec8da3d97f5edc0db4","user":{"login":"goderbauer","id":1227763,"avatar_url":"https://avatars1.githubusercontent.com/u/1227763?v=3","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"Do you need to await _sdkVerion and _apiVersion here?","created_at":"2017-04-25T22:59:08Z","updated_at":"2017-04-25T22:59:08Z","html_url":"https://github.com/flutter/flutter/pull/9587#discussion_r113331755","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/9587","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/113331755"},"html":{"href":"https://github.com/flutter/flutter/pull/9587#discussion_r113331755"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9587"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/9587","id":117580799,"html_url":"https://github.com/flutter/flutter/pull/9587","diff_url":"https://github.com/flutter/flutter/pull/9587.diff","patch_url":"https://github.com/flutter/flutter/pull/9587.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/9587","number":9587,"state":"open","locked":false,"title":"Switch many `Device` methods to be async","user":{"login":"tvolkert","id":15253456,"avatar_url":"https://avatars3.githubusercontent.com/u/15253456?v=3","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false},"body":"`adb` can sometimes hang, which will in turn hang the Dart isolate if\r\nwe're using `Process.runSync()`. This changes many of the `Device` methods\r\nto return `Future<T>` in order to allow them to use the async process\r\nmethods. A future change will add timeouts to the associated calls so\r\nthat we can properly alert the user to the hung `adb` process.\r\n\r\nThis is work towards #7102, #9567","created_at":"2017-04-25T21:04:13Z","updated_at":"2017-04-25T22:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57fd9328d7948d50be90dd08a5eb6e730e5d23b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/9587/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/9587/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/9587/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/328bc089646a891aa88a30ec8da3d97f5edc0db4","head":{"label":"tvolkert:async","ref":"async","sha":"328bc089646a891aa88a30ec8da3d97f5edc0db4","user":{"login":"tvolkert","id":15253456,"avatar_url":"https://avatars3.githubusercontent.com/u/15253456?v=3","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false},"repo":{"id":59706548,"name":"flutter","full_name":"tvolkert/flutter","owner":{"login":"tvolkert","id":15253456,"avatar_url":"https://avatars3.githubusercontent.com/u/15253456?v=3","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvolkert/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/tvolkert/flutter","forks_url":"https://api.github.com/repos/tvolkert/flutter/forks","keys_url":"https://api.github.com/repos/tvolkert/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvolkert/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvolkert/flutter/teams","hooks_url":"https://api.github.com/repos/tvolkert/flutter/hooks","issue_events_url":"https://api.github.com/repos/tvolkert/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/tvolkert/flutter/events","assignees_url":"https://api.github.com/repos/tvolkert/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/tvolkert/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/tvolkert/flutter/tags","blobs_url":"https://api.github.com/repos/tvolkert/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvolkert/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvolkert/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvolkert/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvolkert/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/tvolkert/flutter/languages","stargazers_url":"https://api.github.com/repos/tvolkert/flutter/stargazers","contributors_url":"https://api.github.com/repos/tvolkert/flutter/contributors","subscribers_url":"https://api.github.com/repos/tvolkert/flutter/subscribers","subscription_url":"https://api.github.com/repos/tvolkert/flutter/subscription","commits_url":"https://api.github.com/repos/tvolkert/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvolkert/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvolkert/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvolkert/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvolkert/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/tvolkert/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvolkert/flutter/merges","archive_url":"https://api.github.com/repos/tvolkert/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvolkert/flutter/downloads","issues_url":"https://api.github.com/repos/tvolkert/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/tvolkert/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/tvolkert/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/tvolkert/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvolkert/flutter/labels{/name}","releases_url":"https://api.github.com/repos/tvolkert/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/tvolkert/flutter/deployments","created_at":"2016-05-26T00:15:42Z","updated_at":"2016-05-26T00:15:45Z","pushed_at":"2017-04-25T22:48:18Z","git_url":"git://github.com/tvolkert/flutter.git","ssh_url":"git@github.com:tvolkert/flutter.git","clone_url":"https://github.com/tvolkert/flutter.git","svn_url":"https://github.com/tvolkert/flutter","homepage":"https://flutter.io","size":25273,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"24b40d87d658b5dfefbb2ba39242b7a956814254","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-04-25T17:13:47Z","pushed_at":"2017-04-25T22:48:19Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":25286,"stargazers_count":4294,"watchers_count":4294,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":1400,"forks":467,"open_issues":1400,"watchers":4294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9587"},"html":{"href":"https://github.com/flutter/flutter/pull/9587"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/9587"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/9587/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9587/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9587/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/328bc089646a891aa88a30ec8da3d97f5edc0db4"}}}}
{"actor":{"display_login":"goderbauer"}}