{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2610","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2610/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2610/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2610/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2610","id":272982857,"number":2610,"title":"TraceServiceSettings.Builder not very idiomatic","user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"labels":[{"id":144595208,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels/type:%20question","name":"type: question","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-10T16:13:21Z","updated_at":"2017-11-13T16:27:24Z","closed_at":"2017-11-13T16:27:24Z","author_association":"MEMBER","body":"I'm having to do this weird cast, which should be avoidable:\r\n\r\n```\r\nTraceServiceClient.create(\r\n\t((TraceServiceSettings.Builder) TraceServiceSettings.newBuilder()\r\n\t.setCredentialsProvider(\r\n\t\tStackdriverTraceAutoConfiguration.this.finalCredentialsProvider)\r\n\t.setExecutorProvider(executorProvider))\r\n\t.build())\r\n```\r\n\r\nNotice the `(TraceServiceSettings.Builder)` cast, because `setExecutorProvider()` is inherited from the abstract `ClientSettings` and should probably be overwritten to return a `TraceServiceSettings.Builder`."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments/343974261","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2610#issuecomment-343974261","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2610","id":343974261,"user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T16:27:24Z","updated_at":"2017-11-13T16:27:24Z","author_association":"MEMBER","body":"Apologies, user error. `gax` version was being set to 1.8.1 where it shouldn't."}}
{"actor":{"display_login":"joaoandremartins"}}