{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/130270577","pull_request_review_id":53124431,"id":130270577,"diff_hunk":"@@ -68,32 +68,35 @@\n          for (int j1 = 0; j1 < this.field_185954_p.nextInt(this.field_185954_p.nextInt(10) + 1); ++j1)\n          {\n              this.field_177469_u.func_180709_b(this.field_185952_n, this.field_185954_p, blockpos.func_177982_a(this.field_185954_p.nextInt(16) + 8, this.field_185954_p.nextInt(120) + 4, this.field_185954_p.nextInt(16) + 8));\n-@@ -384,7 +407,13 @@\n+@@ -384,17 +407,25 @@\n          {\n              this.field_177468_v.func_180709_b(this.field_185952_n, this.field_185954_p, blockpos.func_177982_a(this.field_185954_p.nextInt(16) + 8, this.field_185954_p.nextInt(128), this.field_185954_p.nextInt(16) + 8));\n          }\n +        }//Forge: End doGLowstone\n  \n+-        if (this.field_185954_p.nextBoolean())\n +        net.minecraftforge.event.ForgeEventFactory.onChunkPopulate(false, this, this.field_185952_n, this.field_185954_p, p_185931_1_, p_185931_2_, false);\n +        net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(new net.minecraftforge.event.terraingen.DecorateBiomeEvent.Pre(this.field_185952_n, this.field_185954_p, blockpos));\n +\n-+        if (net.minecraftforge.event.terraingen.TerrainGen.decorate(this.field_185952_n, this.field_185954_p, blockpos, net.minecraftforge.event.terraingen.DecorateBiomeEvent.Decorate.EventType.SHROOM))\n-+        {\n-         if (this.field_185954_p.nextBoolean())\n++//        if (this.rand.nextBoolean())","path":"patches/minecraft/net/minecraft/world/gen/ChunkGeneratorHell.java.patch","position":18,"original_position":18,"commit_id":"ef9b4014bb075dea5afc98aa77751b0cbfbb30eb","original_commit_id":"ef9b4014bb075dea5afc98aa77751b0cbfbb30eb","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars1.githubusercontent.com/u/916092?v=4","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"body":"comment in patch","created_at":"2017-07-31T04:27:58Z","updated_at":"2017-07-31T04:29:03Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4134#discussion_r130270577","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/130270577"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/4134#discussion_r130270577"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134","id":128847315,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4134","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4134.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4134.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4134","number":4134,"state":"open","locked":false,"title":"[1.12] Add amount and contextual data to DecorateBiomeEvent.Decorate","user":{"login":"Ivorforce","id":2308167,"avatar_url":"https://avatars1.githubusercontent.com/u/2308167?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivorforce","html_url":"https://github.com/Ivorforce","followers_url":"https://api.github.com/users/Ivorforce/followers","following_url":"https://api.github.com/users/Ivorforce/following{/other_user}","gists_url":"https://api.github.com/users/Ivorforce/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivorforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivorforce/subscriptions","organizations_url":"https://api.github.com/users/Ivorforce/orgs","repos_url":"https://api.github.com/users/Ivorforce/repos","events_url":"https://api.github.com/users/Ivorforce/events{/privacy}","received_events_url":"https://api.github.com/users/Ivorforce/received_events","type":"User","site_admin":false},"body":"Originally from https://github.com/MinecraftForge/MinecraftForge/pull/3318 - the PR didn't want to update anymore.\r\n\r\nThis PR adds amount and contextual data to the decoration events.\r\n\r\nExamples:\r\n\r\nWith this PR, a decoration / world generation mod can now \r\n- Cancel only parts of a decoration aspect (e.g. replace only 5 out of 10 trees, effectively providing an opportunity to inject weighted decorations (e.g. different tree types while honouring default ones)) \r\n- Distinguish between more different decoration types using contextual information (e.g. cancel only red mushrooms, but not brown ones)\r\n- Modify the amount of a decoration aspect (e.g. change plains to generate 10 instead of 4 trees per biome). This is different from overriding the decorator's amount field directly since some amounts are dynamically calculated, especially by world generation mods.\r\n\r\nWith the current event implementation, you can only cancel any whole decoration aspect of the biome. Since in various places (e.g. roofed forests) it is not guaranteed for an event to be fired just once per biome, you cannot act on these events and use them to decorate the biome yourself. \r\n\r\nThis also greatly helps decoration mods and biome mods to interact, as many biome mods do not use the default decorator, and can now pass the actual calculated amount and context through the event.\r\n\r\nNote that it keeps backwards compatibility by continuing to provide the old event constructor, fire method, and cancellation capability. \r\n","created_at":"2017-07-04T18:50:57Z","updated_at":"2017-07-31T04:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44d8ca59ce5fd1528b957d82c5bbf5936eb52ad3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4134/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/ef9b4014bb075dea5afc98aa77751b0cbfbb30eb","head":{"label":"Ivorforce:decorate-event-amount","ref":"decorate-event-amount","sha":"ef9b4014bb075dea5afc98aa77751b0cbfbb30eb","user":{"login":"Ivorforce","id":2308167,"avatar_url":"https://avatars1.githubusercontent.com/u/2308167?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivorforce","html_url":"https://github.com/Ivorforce","followers_url":"https://api.github.com/users/Ivorforce/followers","following_url":"https://api.github.com/users/Ivorforce/following{/other_user}","gists_url":"https://api.github.com/users/Ivorforce/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivorforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivorforce/subscriptions","organizations_url":"https://api.github.com/users/Ivorforce/orgs","repos_url":"https://api.github.com/users/Ivorforce/repos","events_url":"https://api.github.com/users/Ivorforce/events{/privacy}","received_events_url":"https://api.github.com/users/Ivorforce/received_events","type":"User","site_admin":false},"repo":{"id":71264158,"name":"MinecraftForge","full_name":"Ivorforce/MinecraftForge","owner":{"login":"Ivorforce","id":2308167,"avatar_url":"https://avatars1.githubusercontent.com/u/2308167?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivorforce","html_url":"https://github.com/Ivorforce","followers_url":"https://api.github.com/users/Ivorforce/followers","following_url":"https://api.github.com/users/Ivorforce/following{/other_user}","gists_url":"https://api.github.com/users/Ivorforce/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivorforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivorforce/subscriptions","organizations_url":"https://api.github.com/users/Ivorforce/orgs","repos_url":"https://api.github.com/users/Ivorforce/repos","events_url":"https://api.github.com/users/Ivorforce/events{/privacy}","received_events_url":"https://api.github.com/users/Ivorforce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ivorforce/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/Ivorforce/MinecraftForge","forks_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/forks","keys_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/events","assignees_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/merges","archive_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/Ivorforce/MinecraftForge/deployments","created_at":"2016-10-18T15:42:25Z","updated_at":"2016-10-18T15:42:29Z","pushed_at":"2017-07-04T19:03:18Z","git_url":"git://github.com/Ivorforce/MinecraftForge.git","ssh_url":"git@github.com:Ivorforce/MinecraftForge.git","clone_url":"https://github.com/Ivorforce/MinecraftForge.git","svn_url":"https://github.com/Ivorforce/MinecraftForge","homepage":"","size":89904,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.10.x"}},"base":{"label":"MinecraftForge:1.12.x","ref":"1.12.x","sha":"03b7885aa6a514ce01eef54e93ed6e775575c660","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2017-07-29T15:35:12Z","pushed_at":"2017-07-31T04:10:51Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":90196,"stargazers_count":1959,"watchers_count":1959,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":938,"mirror_url":null,"open_issues_count":346,"forks":938,"open_issues":346,"watchers":1959,"default_branch":"1.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/4134"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4134"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4134/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4134/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/ef9b4014bb075dea5afc98aa77751b0cbfbb30eb"}}}}
{"actor":{"display_login":"mezz"}}