{"action":"closed","number":106,"pull_request":{"url":"https://api.github.com/repos/pi-hole/FTL/pulls/106","id":127950010,"html_url":"https://github.com/pi-hole/FTL/pull/106","diff_url":"https://github.com/pi-hole/FTL/pull/106.diff","patch_url":"https://github.com/pi-hole/FTL/pull/106.patch","issue_url":"https://api.github.com/repos/pi-hole/FTL/issues/106","number":106,"state":"closed","locked":false,"title":"Try again to open pihole.log if necessary","user":{"login":"DL6ER","id":16748619,"avatar_url":"https://avatars1.githubusercontent.com/u/16748619?v=3","gravatar_id":"","url":"https://api.github.com/users/DL6ER","html_url":"https://github.com/DL6ER","followers_url":"https://api.github.com/users/DL6ER/followers","following_url":"https://api.github.com/users/DL6ER/following{/other_user}","gists_url":"https://api.github.com/users/DL6ER/gists{/gist_id}","starred_url":"https://api.github.com/users/DL6ER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DL6ER/subscriptions","organizations_url":"https://api.github.com/users/DL6ER/orgs","repos_url":"https://api.github.com/users/DL6ER/repos","events_url":"https://api.github.com/users/DL6ER/events{/privacy}","received_events_url":"https://api.github.com/users/DL6ER/received_events","type":"User","site_admin":false},"body":"**By submitting this pull request, I confirm the following (please check boxes, eg [X]) _Failure to fill the template will close your PR_:**\r\n\r\n***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***\r\n\r\n- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).\r\n- [X] I have checked that [another pull request](https://github.com/pi-hole/FTL/pulls) for this purpose does not exist.\r\n- [X] I have considered, and confirmed that this submission will be valuable to others.\r\n- [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.\r\n- [X] I give this submission freely, and claim no ownership to its content.\r\n\r\n**How familiar are you with the codebase?:**\r\n\r\n## 10\r\n\r\n---\r\n\r\nAssume a user has configured his `/var/log` using `ramfs` or some other mechanism that results in an *empty* log folder on startup.\r\n\r\nIf, by chance, `FTL` is getting started before `dnsmasq` has created its log file, `FTL` will exit with status `FAILURE`.\r\n\r\nWith these proposed changes, we pause for 15 seconds if we cannot find `pihole.log` and then test again. If the log file is there, `FTL` will continue as usual. If the file can still not be opened in the second attempt, it will exit only then.\r\n\r\n_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._\r\n","created_at":"2017-06-28T15:21:04Z","updated_at":"2017-06-28T16:56:15Z","closed_at":"2017-06-28T16:56:14Z","merged_at":"2017-06-28T16:56:14Z","merge_commit_sha":"0cad09d44d376394786cd460419c2cbb17962852","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pi-hole/FTL/pulls/106/commits","review_comments_url":"https://api.github.com/repos/pi-hole/FTL/pulls/106/comments","review_comment_url":"https://api.github.com/repos/pi-hole/FTL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pi-hole/FTL/issues/106/comments","statuses_url":"https://api.github.com/repos/pi-hole/FTL/statuses/47fd38c7fc3c0ed6401691c3bc719c7d0f84b17f","head":{"label":"pi-hole:tweak/try_again_pihole.log","ref":"tweak/try_again_pihole.log","sha":"47fd38c7fc3c0ed6401691c3bc719c7d0f84b17f","user":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars1.githubusercontent.com/u/16827203?v=3","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"repo":{"id":80716356,"name":"FTL","full_name":"pi-hole/FTL","owner":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars1.githubusercontent.com/u/16827203?v=3","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pi-hole/FTL","description":"The Pi-hole FTL engine","fork":false,"url":"https://api.github.com/repos/pi-hole/FTL","forks_url":"https://api.github.com/repos/pi-hole/FTL/forks","keys_url":"https://api.github.com/repos/pi-hole/FTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pi-hole/FTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pi-hole/FTL/teams","hooks_url":"https://api.github.com/repos/pi-hole/FTL/hooks","issue_events_url":"https://api.github.com/repos/pi-hole/FTL/issues/events{/number}","events_url":"https://api.github.com/repos/pi-hole/FTL/events","assignees_url":"https://api.github.com/repos/pi-hole/FTL/assignees{/user}","branches_url":"https://api.github.com/repos/pi-hole/FTL/branches{/branch}","tags_url":"https://api.github.com/repos/pi-hole/FTL/tags","blobs_url":"https://api.github.com/repos/pi-hole/FTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pi-hole/FTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pi-hole/FTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/pi-hole/FTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pi-hole/FTL/statuses/{sha}","languages_url":"https://api.github.com/repos/pi-hole/FTL/languages","stargazers_url":"https://api.github.com/repos/pi-hole/FTL/stargazers","contributors_url":"https://api.github.com/repos/pi-hole/FTL/contributors","subscribers_url":"https://api.github.com/repos/pi-hole/FTL/subscribers","subscription_url":"https://api.github.com/repos/pi-hole/FTL/subscription","commits_url":"https://api.github.com/repos/pi-hole/FTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/pi-hole/FTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/pi-hole/FTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/pi-hole/FTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/pi-hole/FTL/contents/{+path}","compare_url":"https://api.github.com/repos/pi-hole/FTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pi-hole/FTL/merges","archive_url":"https://api.github.com/repos/pi-hole/FTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pi-hole/FTL/downloads","issues_url":"https://api.github.com/repos/pi-hole/FTL/issues{/number}","pulls_url":"https://api.github.com/repos/pi-hole/FTL/pulls{/number}","milestones_url":"https://api.github.com/repos/pi-hole/FTL/milestones{/number}","notifications_url":"https://api.github.com/repos/pi-hole/FTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pi-hole/FTL/labels{/name}","releases_url":"https://api.github.com/repos/pi-hole/FTL/releases{/id}","deployments_url":"https://api.github.com/repos/pi-hole/FTL/deployments","created_at":"2017-02-02T10:52:55Z","updated_at":"2017-06-23T20:05:45Z","pushed_at":"2017-06-28T16:56:14Z","git_url":"git://github.com/pi-hole/FTL.git","ssh_url":"git@github.com:pi-hole/FTL.git","clone_url":"https://github.com/pi-hole/FTL.git","svn_url":"https://github.com/pi-hole/FTL","homepage":null,"size":2465,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":32,"default_branch":"master"}},"base":{"label":"pi-hole:development","ref":"development","sha":"9976ff74252464b208e2c0ddc32fbe621dd99e2f","user":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars1.githubusercontent.com/u/16827203?v=3","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"repo":{"id":80716356,"name":"FTL","full_name":"pi-hole/FTL","owner":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars1.githubusercontent.com/u/16827203?v=3","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pi-hole/FTL","description":"The Pi-hole FTL engine","fork":false,"url":"https://api.github.com/repos/pi-hole/FTL","forks_url":"https://api.github.com/repos/pi-hole/FTL/forks","keys_url":"https://api.github.com/repos/pi-hole/FTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pi-hole/FTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pi-hole/FTL/teams","hooks_url":"https://api.github.com/repos/pi-hole/FTL/hooks","issue_events_url":"https://api.github.com/repos/pi-hole/FTL/issues/events{/number}","events_url":"https://api.github.com/repos/pi-hole/FTL/events","assignees_url":"https://api.github.com/repos/pi-hole/FTL/assignees{/user}","branches_url":"https://api.github.com/repos/pi-hole/FTL/branches{/branch}","tags_url":"https://api.github.com/repos/pi-hole/FTL/tags","blobs_url":"https://api.github.com/repos/pi-hole/FTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pi-hole/FTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pi-hole/FTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/pi-hole/FTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pi-hole/FTL/statuses/{sha}","languages_url":"https://api.github.com/repos/pi-hole/FTL/languages","stargazers_url":"https://api.github.com/repos/pi-hole/FTL/stargazers","contributors_url":"https://api.github.com/repos/pi-hole/FTL/contributors","subscribers_url":"https://api.github.com/repos/pi-hole/FTL/subscribers","subscription_url":"https://api.github.com/repos/pi-hole/FTL/subscription","commits_url":"https://api.github.com/repos/pi-hole/FTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/pi-hole/FTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/pi-hole/FTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/pi-hole/FTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/pi-hole/FTL/contents/{+path}","compare_url":"https://api.github.com/repos/pi-hole/FTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pi-hole/FTL/merges","archive_url":"https://api.github.com/repos/pi-hole/FTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pi-hole/FTL/downloads","issues_url":"https://api.github.com/repos/pi-hole/FTL/issues{/number}","pulls_url":"https://api.github.com/repos/pi-hole/FTL/pulls{/number}","milestones_url":"https://api.github.com/repos/pi-hole/FTL/milestones{/number}","notifications_url":"https://api.github.com/repos/pi-hole/FTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pi-hole/FTL/labels{/name}","releases_url":"https://api.github.com/repos/pi-hole/FTL/releases{/id}","deployments_url":"https://api.github.com/repos/pi-hole/FTL/deployments","created_at":"2017-02-02T10:52:55Z","updated_at":"2017-06-23T20:05:45Z","pushed_at":"2017-06-28T16:56:14Z","git_url":"git://github.com/pi-hole/FTL.git","ssh_url":"git@github.com:pi-hole/FTL.git","clone_url":"https://github.com/pi-hole/FTL.git","svn_url":"https://github.com/pi-hole/FTL","homepage":null,"size":2465,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pi-hole/FTL/pulls/106"},"html":{"href":"https://github.com/pi-hole/FTL/pull/106"},"issue":{"href":"https://api.github.com/repos/pi-hole/FTL/issues/106"},"comments":{"href":"https://api.github.com/repos/pi-hole/FTL/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/pi-hole/FTL/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/pi-hole/FTL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pi-hole/FTL/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/pi-hole/FTL/statuses/47fd38c7fc3c0ed6401691c3bc719c7d0f84b17f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DL6ER","id":16748619,"avatar_url":"https://avatars1.githubusercontent.com/u/16748619?v=3","gravatar_id":"","url":"https://api.github.com/users/DL6ER","html_url":"https://github.com/DL6ER","followers_url":"https://api.github.com/users/DL6ER/followers","following_url":"https://api.github.com/users/DL6ER/following{/other_user}","gists_url":"https://api.github.com/users/DL6ER/gists{/gist_id}","starred_url":"https://api.github.com/users/DL6ER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DL6ER/subscriptions","organizations_url":"https://api.github.com/users/DL6ER/orgs","repos_url":"https://api.github.com/users/DL6ER/repos","events_url":"https://api.github.com/users/DL6ER/events{/privacy}","received_events_url":"https://api.github.com/users/DL6ER/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"DL6ER"}}