{"action":"created","comment":{"url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments/115005610","pull_request_review_id":36516855,"id":115005610,"diff_hunk":"@@ -75,6 +84,14 @@ TF_CALL_complex128(TENSOR_ARRAY_SET_ZERO_GPU);\n \n #endif  // GOOGLE_CUDA\n \n+#ifdef TENSORFLOW_USE_SYCL\n+\n+#define TENSOR_ARRAY_SET_ZERO_SYCL(T) TENSOR_ARRAY_SET_ZERO(SYCLDevice, T)\n+TF_CALL_GPU_NUMBER_TYPES_NO_HALF(TENSOR_ARRAY_SET_ZERO_SYCL);\n+#undef TENSOR_ARRAY_SET_ZERO_SYCL\n+","path":"tensorflow/core/kernels/tensor_array.cc","position":25,"original_position":25,"commit_id":"bb78c4b4febb5461f1ecf7830a53f8fd24dc7d0a","original_commit_id":"bb78c4b4febb5461f1ecf7830a53f8fd24dc7d0a","user":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars2.githubusercontent.com/u/8373795?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"body":"spare new line?","created_at":"2017-05-05T14:13:18Z","updated_at":"2017-05-05T14:26:01Z","html_url":"https://github.com/lukeiwanski/tensorflow/pull/8#discussion_r115005610","pull_request_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments/115005610"},"html":{"href":"https://github.com/lukeiwanski/tensorflow/pull/8#discussion_r115005610"},"pull_request":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8","id":118926547,"html_url":"https://github.com/lukeiwanski/tensorflow/pull/8","diff_url":"https://github.com/lukeiwanski/tensorflow/pull/8.diff","patch_url":"https://github.com/lukeiwanski/tensorflow/pull/8.patch","issue_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/8","number":8,"state":"open","locked":false,"title":"[OpenCL] Fixes core_rnn_test and core_rnn_cell_test","user":{"login":"Zakor94","id":2519608,"avatar_url":"https://avatars2.githubusercontent.com/u/2519608?v=3","gravatar_id":"","url":"https://api.github.com/users/Zakor94","html_url":"https://github.com/Zakor94","followers_url":"https://api.github.com/users/Zakor94/followers","following_url":"https://api.github.com/users/Zakor94/following{/other_user}","gists_url":"https://api.github.com/users/Zakor94/gists{/gist_id}","starred_url":"https://api.github.com/users/Zakor94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zakor94/subscriptions","organizations_url":"https://api.github.com/users/Zakor94/orgs","repos_url":"https://api.github.com/users/Zakor94/repos","events_url":"https://api.github.com/users/Zakor94/events{/privacy}","received_events_url":"https://api.github.com/users/Zakor94/received_events","type":"User","site_admin":false},"body":"I made SYCL use the same implementation as the CPU for AddBias, not sure if this is a good idea though? The test passes but it only check if the Cell has been allocated on a sycl device so it is a bit easy.\r\nI haven't changed anything for core_rnn_test yet but 2 functions seem to pass.","created_at":"2017-05-04T09:02:43Z","updated_at":"2017-05-05T14:26:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbb5adf68d1bd282e002389108bae194f6051f44","assignee":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars2.githubusercontent.com/u/8373795?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars2.githubusercontent.com/u/8373795?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8/commits","review_comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8/comments","review_comment_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/8/comments","statuses_url":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/bb78c4b4febb5461f1ecf7830a53f8fd24dc7d0a","head":{"label":"Zakor94:eigen_mehdi","ref":"eigen_mehdi","sha":"bb78c4b4febb5461f1ecf7830a53f8fd24dc7d0a","user":{"login":"Zakor94","id":2519608,"avatar_url":"https://avatars2.githubusercontent.com/u/2519608?v=3","gravatar_id":"","url":"https://api.github.com/users/Zakor94","html_url":"https://github.com/Zakor94","followers_url":"https://api.github.com/users/Zakor94/followers","following_url":"https://api.github.com/users/Zakor94/following{/other_user}","gists_url":"https://api.github.com/users/Zakor94/gists{/gist_id}","starred_url":"https://api.github.com/users/Zakor94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zakor94/subscriptions","organizations_url":"https://api.github.com/users/Zakor94/orgs","repos_url":"https://api.github.com/users/Zakor94/repos","events_url":"https://api.github.com/users/Zakor94/events{/privacy}","received_events_url":"https://api.github.com/users/Zakor94/received_events","type":"User","site_admin":false},"repo":{"id":88073261,"name":"tensorflow","full_name":"Zakor94/tensorflow","owner":{"login":"Zakor94","id":2519608,"avatar_url":"https://avatars2.githubusercontent.com/u/2519608?v=3","gravatar_id":"","url":"https://api.github.com/users/Zakor94","html_url":"https://github.com/Zakor94","followers_url":"https://api.github.com/users/Zakor94/followers","following_url":"https://api.github.com/users/Zakor94/following{/other_user}","gists_url":"https://api.github.com/users/Zakor94/gists{/gist_id}","starred_url":"https://api.github.com/users/Zakor94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zakor94/subscriptions","organizations_url":"https://api.github.com/users/Zakor94/orgs","repos_url":"https://api.github.com/users/Zakor94/repos","events_url":"https://api.github.com/users/Zakor94/events{/privacy}","received_events_url":"https://api.github.com/users/Zakor94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zakor94/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/Zakor94/tensorflow","forks_url":"https://api.github.com/repos/Zakor94/tensorflow/forks","keys_url":"https://api.github.com/repos/Zakor94/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zakor94/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zakor94/tensorflow/teams","hooks_url":"https://api.github.com/repos/Zakor94/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/Zakor94/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/Zakor94/tensorflow/events","assignees_url":"https://api.github.com/repos/Zakor94/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/Zakor94/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/Zakor94/tensorflow/tags","blobs_url":"https://api.github.com/repos/Zakor94/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zakor94/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zakor94/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zakor94/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zakor94/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/Zakor94/tensorflow/languages","stargazers_url":"https://api.github.com/repos/Zakor94/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/Zakor94/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/Zakor94/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/Zakor94/tensorflow/subscription","commits_url":"https://api.github.com/repos/Zakor94/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zakor94/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zakor94/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zakor94/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zakor94/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/Zakor94/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zakor94/tensorflow/merges","archive_url":"https://api.github.com/repos/Zakor94/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zakor94/tensorflow/downloads","issues_url":"https://api.github.com/repos/Zakor94/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/Zakor94/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/Zakor94/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/Zakor94/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zakor94/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/Zakor94/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/Zakor94/tensorflow/deployments","created_at":"2017-04-12T16:25:43Z","updated_at":"2017-04-12T16:26:06Z","pushed_at":"2017-05-05T13:44:37Z","git_url":"git://github.com/Zakor94/tensorflow.git","ssh_url":"git@github.com:Zakor94/tensorflow.git","clone_url":"https://github.com/Zakor94/tensorflow.git","svn_url":"https://github.com/Zakor94/tensorflow","homepage":"http://tensorflow.org","size":96926,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lukeiwanski:eigen_mehdi","ref":"eigen_mehdi","sha":"5cbaab5f079fffd829a2ab5fbfc42958935b54d5","user":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars2.githubusercontent.com/u/8373795?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"repo":{"id":87582233,"name":"tensorflow","full_name":"lukeiwanski/tensorflow","owner":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars2.githubusercontent.com/u/8373795?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukeiwanski/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/lukeiwanski/tensorflow","forks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/forks","keys_url":"https://api.github.com/repos/lukeiwanski/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukeiwanski/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukeiwanski/tensorflow/teams","hooks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/events","assignees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/lukeiwanski/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/tags","blobs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/lukeiwanski/tensorflow/languages","stargazers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscription","commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/lukeiwanski/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukeiwanski/tensorflow/merges","archive_url":"https://api.github.com/repos/lukeiwanski/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukeiwanski/tensorflow/downloads","issues_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/lukeiwanski/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/lukeiwanski/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukeiwanski/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/lukeiwanski/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/deployments","created_at":"2017-04-07T19:56:43Z","updated_at":"2017-04-25T15:04:19Z","pushed_at":"2017-05-05T13:44:39Z","git_url":"git://github.com/lukeiwanski/tensorflow.git","ssh_url":"git@github.com:lukeiwanski/tensorflow.git","clone_url":"https://github.com/lukeiwanski/tensorflow.git","svn_url":"https://github.com/lukeiwanski/tensorflow","homepage":"http://tensorflow.org","size":96928,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8"},"html":{"href":"https://github.com/lukeiwanski/tensorflow/pull/8"},"issue":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/8"},"comments":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/bb78c4b4febb5461f1ecf7830a53f8fd24dc7d0a"}}}}
{"actor":{"display_login":"lukeiwanski"}}