{"action":"created","issue":{"url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/72","repository_url":"https://api.github.com/repos/iotaledger/iota.lib.py","labels_url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/72/comments","events_url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/72/events","html_url":"https://github.com/iotaledger/iota.lib.py/issues/72","id":261163501,"number":72,"title":"transfer = ProposedTransaction(...) naming convention doesn't follow other libs","user":{"login":"alon-e","id":25587995,"avatar_url":"https://avatars3.githubusercontent.com/u/25587995?v=4","gravatar_id":"","url":"https://api.github.com/users/alon-e","html_url":"https://github.com/alon-e","followers_url":"https://api.github.com/users/alon-e/followers","following_url":"https://api.github.com/users/alon-e/following{/other_user}","gists_url":"https://api.github.com/users/alon-e/gists{/gist_id}","starred_url":"https://api.github.com/users/alon-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alon-e/subscriptions","organizations_url":"https://api.github.com/users/alon-e/orgs","repos_url":"https://api.github.com/users/alon-e/repos","events_url":"https://api.github.com/users/alon-e/events{/privacy}","received_events_url":"https://api.github.com/users/alon-e/received_events","type":"User","site_admin":false},"labels":[{"id":489655765,"url":"https://api.github.com/repos/iotaledger/iota.lib.py/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":489655766,"url":"https://api.github.com/repos/iotaledger/iota.lib.py/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-28T01:11:24Z","updated_at":"2017-10-03T07:41:56Z","closed_at":"2017-10-03T07:41:56Z","author_association":"NONE","body":"both in `iota.lib.js` and `iota.lib.java` there are explicit `transfer` objects.\r\n[iota.lib.js](https://github.com/iotaledger/iota.lib.js/blob/master/lib/api/api.js#L1024)\r\n[iota.lib.java](https://github.com/iotaledger/iota.lib.java/blob/master/src/main/java/jota/IotaAPI.java#L366)\r\n\r\nhowever, in `iota.lib.py` these objects are constructed with `iota.ProposedTransaction(...)`, which is also used as an intermediary representation of [transactions](https://github.com/iotaledger/iota.lib.py/blob/master/iota/transaction/creation.py#L28) & bundles.\r\nfrom examples:\r\nhttps://github.com/iotaledger/iota.lib.py/blob/master/examples/send_transfer.py#L24\r\n\r\nthis is confusing for users moving from other library implementations. like myself. :)\r\n\r\n---\r\nI propose a new class named `Transfer`, that inherits from `ProposedTransaction` and is functionally the same, but adheres to the naming conventions of the other libs. (without breaking code that already uses `ProposedTransaction` of course)."},"comment":{"url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/comments/333765172","html_url":"https://github.com/iotaledger/iota.lib.py/issues/72#issuecomment-333765172","issue_url":"https://api.github.com/repos/iotaledger/iota.lib.py/issues/72","id":333765172,"user":{"login":"todofixthis","id":202040,"avatar_url":"https://avatars1.githubusercontent.com/u/202040?v=4","gravatar_id":"","url":"https://api.github.com/users/todofixthis","html_url":"https://github.com/todofixthis","followers_url":"https://api.github.com/users/todofixthis/followers","following_url":"https://api.github.com/users/todofixthis/following{/other_user}","gists_url":"https://api.github.com/users/todofixthis/gists{/gist_id}","starred_url":"https://api.github.com/users/todofixthis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todofixthis/subscriptions","organizations_url":"https://api.github.com/users/todofixthis/orgs","repos_url":"https://api.github.com/users/todofixthis/repos","events_url":"https://api.github.com/users/todofixthis/events{/privacy}","received_events_url":"https://api.github.com/users/todofixthis/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T07:41:56Z","updated_at":"2017-10-03T07:41:56Z","author_association":"MEMBER","body":"Scheduled for release: 2.0.1"}}
{"actor":{"display_login":"todofixthis"}}