{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/104121036","pull_request_review_id":24938481,"id":104121036,"diff_hunk":"@@ -25,6 +25,7 @@ defmodule ExDoc do\n       project: nil,\n       retriever: ExDoc.Retriever,\n       source_beam: nil,","path":"lib/ex_doc.ex","position":3,"original_position":3,"commit_id":"ea6cf10265d82a20b585bec6feffb76c07a3b2cf","original_commit_id":"ea6cf10265d82a20b585bec6feffb76c07a3b2cf","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars3.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"> I will be submitting another PR, and because we are using nil I need to check agains nil, false or \"\" to see if an option is unset.\r\n\r\nWe should continue only checking for `nil`. In Elixir, `nil` is used for absence of information (except if we have a field that may be boolean).\r\n\r\nIf the field can be an empty string and an empty string also mean \"emptiness\", we need to convert the empty string to nil before putting it in the struct.","created_at":"2017-03-03T09:56:49Z","updated_at":"2017-03-03T09:56:49Z","html_url":"https://github.com/elixir-lang/ex_doc/pull/680#discussion_r104121036","pull_request_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/104121036"},"html":{"href":"https://github.com/elixir-lang/ex_doc/pull/680#discussion_r104121036"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680","id":108902025,"html_url":"https://github.com/elixir-lang/ex_doc/pull/680","diff_url":"https://github.com/elixir-lang/ex_doc/pull/680.diff","patch_url":"https://github.com/elixir-lang/ex_doc/pull/680.patch","issue_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/680","number":680,"state":"open","locked":false,"title":"Fix ExDoc.CLI.main/2 to keep --source-ref ","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"--source-ref passed to the CLI was being lost,\r\nmeaning all links to commits/tags were being lost and the docs were always\r\nlinked to master","created_at":"2017-03-03T03:45:10Z","updated_at":"2017-03-03T09:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8010532a8e55df422b6615f395d4c398349ba34e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/680/comments","statuses_url":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/ea6cf10265d82a20b585bec6feffb76c07a3b2cf","head":{"label":"eksperimental:source_ref2","ref":"source_ref2","sha":"ea6cf10265d82a20b585bec6feffb76c07a3b2cf","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"repo":{"id":25037635,"name":"ex_doc","full_name":"eksperimental/ex_doc","owner":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eksperimental/ex_doc","description":"ExDoc produces HTML and online documentation for Elixir projects","fork":true,"url":"https://api.github.com/repos/eksperimental/ex_doc","forks_url":"https://api.github.com/repos/eksperimental/ex_doc/forks","keys_url":"https://api.github.com/repos/eksperimental/ex_doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eksperimental/ex_doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eksperimental/ex_doc/teams","hooks_url":"https://api.github.com/repos/eksperimental/ex_doc/hooks","issue_events_url":"https://api.github.com/repos/eksperimental/ex_doc/issues/events{/number}","events_url":"https://api.github.com/repos/eksperimental/ex_doc/events","assignees_url":"https://api.github.com/repos/eksperimental/ex_doc/assignees{/user}","branches_url":"https://api.github.com/repos/eksperimental/ex_doc/branches{/branch}","tags_url":"https://api.github.com/repos/eksperimental/ex_doc/tags","blobs_url":"https://api.github.com/repos/eksperimental/ex_doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eksperimental/ex_doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eksperimental/ex_doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/eksperimental/ex_doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eksperimental/ex_doc/statuses/{sha}","languages_url":"https://api.github.com/repos/eksperimental/ex_doc/languages","stargazers_url":"https://api.github.com/repos/eksperimental/ex_doc/stargazers","contributors_url":"https://api.github.com/repos/eksperimental/ex_doc/contributors","subscribers_url":"https://api.github.com/repos/eksperimental/ex_doc/subscribers","subscription_url":"https://api.github.com/repos/eksperimental/ex_doc/subscription","commits_url":"https://api.github.com/repos/eksperimental/ex_doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/eksperimental/ex_doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/eksperimental/ex_doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/eksperimental/ex_doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/eksperimental/ex_doc/contents/{+path}","compare_url":"https://api.github.com/repos/eksperimental/ex_doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eksperimental/ex_doc/merges","archive_url":"https://api.github.com/repos/eksperimental/ex_doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eksperimental/ex_doc/downloads","issues_url":"https://api.github.com/repos/eksperimental/ex_doc/issues{/number}","pulls_url":"https://api.github.com/repos/eksperimental/ex_doc/pulls{/number}","milestones_url":"https://api.github.com/repos/eksperimental/ex_doc/milestones{/number}","notifications_url":"https://api.github.com/repos/eksperimental/ex_doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eksperimental/ex_doc/labels{/name}","releases_url":"https://api.github.com/repos/eksperimental/ex_doc/releases{/id}","deployments_url":"https://api.github.com/repos/eksperimental/ex_doc/deployments","created_at":"2014-10-10T13:52:43Z","updated_at":"2016-05-07T02:36:28Z","pushed_at":"2017-03-03T04:15:03Z","git_url":"git://github.com/eksperimental/ex_doc.git","ssh_url":"git@github.com:eksperimental/ex_doc.git","clone_url":"https://github.com/eksperimental/ex_doc.git","svn_url":"https://github.com/eksperimental/ex_doc","homepage":"http://elixir-lang.org","size":3326,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"8c7b5fdc26a8e8c035d1d1146985d1619994e450","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars2.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":3642931,"name":"ex_doc","full_name":"elixir-lang/ex_doc","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars2.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/ex_doc","description":"ExDoc produces HTML and EPUB documentation for Elixir projects","fork":false,"url":"https://api.github.com/repos/elixir-lang/ex_doc","forks_url":"https://api.github.com/repos/elixir-lang/ex_doc/forks","keys_url":"https://api.github.com/repos/elixir-lang/ex_doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/ex_doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/ex_doc/teams","hooks_url":"https://api.github.com/repos/elixir-lang/ex_doc/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/ex_doc/events","assignees_url":"https://api.github.com/repos/elixir-lang/ex_doc/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/ex_doc/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/ex_doc/tags","blobs_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/ex_doc/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/ex_doc/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/ex_doc/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/ex_doc/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/ex_doc/subscription","commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/ex_doc/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/ex_doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/ex_doc/merges","archive_url":"https://api.github.com/repos/elixir-lang/ex_doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/ex_doc/downloads","issues_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/ex_doc/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/ex_doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/ex_doc/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/ex_doc/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/ex_doc/deployments","created_at":"2012-03-06T21:35:38Z","updated_at":"2017-03-03T01:05:37Z","pushed_at":"2017-03-03T04:15:04Z","git_url":"git://github.com/elixir-lang/ex_doc.git","ssh_url":"git@github.com:elixir-lang/ex_doc.git","clone_url":"https://github.com/elixir-lang/ex_doc.git","svn_url":"https://github.com/elixir-lang/ex_doc","homepage":"http://elixir-lang.org","size":3300,"stargazers_count":357,"watchers_count":357,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":15,"forks":96,"open_issues":15,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680"},"html":{"href":"https://github.com/elixir-lang/ex_doc/pull/680"},"issue":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/issues/680"},"comments":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/ea6cf10265d82a20b585bec6feffb76c07a3b2cf"}}}}
{"actor":{"display_login":"josevalim"}}