{"action":"created","issue":{"url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/11","repository_url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView","labels_url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/11/comments","events_url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/11/events","html_url":"https://github.com/yayaa/ParallaxRecyclerView/pull/11","id":201924094,"number":11,"title":"Allow more complex elements","user":{"login":"alex-gutierrez","id":2658394,"avatar_url":"https://avatars.githubusercontent.com/u/2658394?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-gutierrez","html_url":"https://github.com/alex-gutierrez","followers_url":"https://api.github.com/users/alex-gutierrez/followers","following_url":"https://api.github.com/users/alex-gutierrez/following{/other_user}","gists_url":"https://api.github.com/users/alex-gutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-gutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-gutierrez/subscriptions","organizations_url":"https://api.github.com/users/alex-gutierrez/orgs","repos_url":"https://api.github.com/users/alex-gutierrez/repos","events_url":"https://api.github.com/users/alex-gutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/alex-gutierrez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-19T17:26:25Z","updated_at":"2017-01-31T10:58:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/pulls/11","html_url":"https://github.com/yayaa/ParallaxRecyclerView/pull/11","diff_url":"https://github.com/yayaa/ParallaxRecyclerView/pull/11.diff","patch_url":"https://github.com/yayaa/ParallaxRecyclerView/pull/11.patch"},"body":"I have made two changes to improve the versatility of the component:\r\n\r\n1. Included a sanity check in RecyclerView to only perform parallax animation on ViewHolders that extends ParallaxViewHolder, ignoring the rest and behaving like a standard RecyclerView to them\r\n2. Modified ParallaxImageView to calculate the difference between available space and drawable size taking into account the ImageView height instead of the row height. This will allow to include the ParallaxImageView in cells without the need to fill the row height.\r\n\r\nThe changes does not break compatibility with previous versions but allows to use the component with different ViewHolder types in the same RecyclerView and to include complex cells with parallax images that does not necessary match parent height."},"comment":{"url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/comments/276333807","html_url":"https://github.com/yayaa/ParallaxRecyclerView/pull/11#issuecomment-276333807","issue_url":"https://api.github.com/repos/yayaa/ParallaxRecyclerView/issues/11","id":276333807,"user":{"login":"hhoang","id":482679,"avatar_url":"https://avatars.githubusercontent.com/u/482679?v=3","gravatar_id":"","url":"https://api.github.com/users/hhoang","html_url":"https://github.com/hhoang","followers_url":"https://api.github.com/users/hhoang/followers","following_url":"https://api.github.com/users/hhoang/following{/other_user}","gists_url":"https://api.github.com/users/hhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/hhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhoang/subscriptions","organizations_url":"https://api.github.com/users/hhoang/orgs","repos_url":"https://api.github.com/users/hhoang/repos","events_url":"https://api.github.com/users/hhoang/events{/privacy}","received_events_url":"https://api.github.com/users/hhoang/received_events","type":"User","site_admin":false},"created_at":"2017-01-31T10:58:25Z","updated_at":"2017-01-31T10:58:25Z","body":"👍 This is a pretty useful addition to the library."}}
{"actor":{"display_login":"hhoang"}}