{"action":"created","comment":{"url":"https://api.github.com/repos/yt-project/yt/pulls/comments/153909892","pull_request_review_id":79990353,"id":153909892,"diff_hunk":"@@ -319,9 +319,7 @@ def _read_amr(self):\n         self.oct_handler.allocate_domains(self.total_oct_count, root_nodes)\n         fb = open(self.amr_fn, \"rb\")","path":"yt/frontends/ramses/data_structures.py","position":18,"original_position":18,"commit_id":"fb32161846e5b3f597c55ec1e42ea62dbb9bee59","original_commit_id":"fb32161846e5b3f597c55ec1e42ea62dbb9bee59","user":{"login":"ngoldbaum","id":3126246,"avatar_url":"https://avatars2.githubusercontent.com/u/3126246?v=4","gravatar_id":"","url":"https://api.github.com/users/ngoldbaum","html_url":"https://github.com/ngoldbaum","followers_url":"https://api.github.com/users/ngoldbaum/followers","following_url":"https://api.github.com/users/ngoldbaum/following{/other_user}","gists_url":"https://api.github.com/users/ngoldbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoldbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoldbaum/subscriptions","organizations_url":"https://api.github.com/users/ngoldbaum/orgs","repos_url":"https://api.github.com/users/ngoldbaum/repos","events_url":"https://api.github.com/users/ngoldbaum/events{/privacy}","received_events_url":"https://api.github.com/users/ngoldbaum/received_events","type":"User","site_admin":false},"body":"Maybe rename this to `f` so you don't need to define the alias below","created_at":"2017-11-29T20:45:38Z","updated_at":"2017-11-29T20:48:45Z","html_url":"https://github.com/yt-project/yt/pull/1637#discussion_r153909892","pull_request_url":"https://api.github.com/repos/yt-project/yt/pulls/1637","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yt-project/yt/pulls/comments/153909892"},"html":{"href":"https://github.com/yt-project/yt/pull/1637#discussion_r153909892"},"pull_request":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1637"}}},"pull_request":{"url":"https://api.github.com/repos/yt-project/yt/pulls/1637","id":155415125,"html_url":"https://github.com/yt-project/yt/pull/1637","diff_url":"https://github.com/yt-project/yt/pull/1637.diff","patch_url":"https://github.com/yt-project/yt/pull/1637.patch","issue_url":"https://api.github.com/repos/yt-project/yt/issues/1637","number":1637,"state":"open","locked":false,"title":"Add bbox feature","user":{"login":"cphyc","id":5411875,"avatar_url":"https://avatars1.githubusercontent.com/u/5411875?v=4","gravatar_id":"","url":"https://api.github.com/users/cphyc","html_url":"https://github.com/cphyc","followers_url":"https://api.github.com/users/cphyc/followers","following_url":"https://api.github.com/users/cphyc/following{/other_user}","gists_url":"https://api.github.com/users/cphyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cphyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cphyc/subscriptions","organizations_url":"https://api.github.com/users/cphyc/orgs","repos_url":"https://api.github.com/users/cphyc/repos","events_url":"https://api.github.com/users/cphyc/events{/privacy}","received_events_url":"https://api.github.com/users/cphyc/received_events","type":"User","site_admin":false},"body":"<!--Provide a general summary of your changes in the title above, for\r\nexample \"Raises ValueError on Non-Numeric Input to set_xlim\".  Please avoid\r\nnon-descriptive titles such as \"Addresses issue #8576\".-->\r\n\r\nProvide a new argument to the `yt.load` for ramses datasets to only load a subset of a simulation.\r\n\r\nThe drawback is that once you loaded your dataset, you cannot access any of the skipped domains.\r\n\r\n<!--If you are able to do so, please do not create the PR out of master, but out\r\nof a separate branch. -->\r\n\r\n## PR Summary\r\n\r\nThe new argument won't change the dataset itself (same domain width, …) but only which domains are red from disk. This is useful for people doing zoom-in simulations (like me) or cosmological simulations (like me), as it prevents yt from loading the entire AMR structure and can result in significantly faster access to small parts of simulations.\r\n\r\nIt would be good to have a bit more tests, but I didn't have time until now, any help is welcome!\r\n<!--If it fixes an open issue, please link to the issue here.-->\r\n\r\n## PR Checklist\r\n\r\n<!-- Note that some of these check boxes may not apply to all pull requests -->\r\n\r\n- [x] Code passes flake8 checker\r\n- [x] New features are documented, with docstrings and narrative docs\r\n- [ ] Adds a test for any bugs fixed. Adds tests for new features.\r\n\r\n<!--We understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or the\r\nrecommended next step seems overly demanding , or if you would like help in\r\naddressing a reviewer's comments.  And please ping us if you've been waiting\r\ntoo long to hear back on your PR.-->\r\n","created_at":"2017-11-29T18:15:58Z","updated_at":"2017-11-29T20:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f92fa0616cceebe22a50979191d0edf9c0aa2c43","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yt-project/yt/pulls/1637/commits","review_comments_url":"https://api.github.com/repos/yt-project/yt/pulls/1637/comments","review_comment_url":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yt-project/yt/issues/1637/comments","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/fb32161846e5b3f597c55ec1e42ea62dbb9bee59","head":{"label":"cphyc:add-bbox-feature2","ref":"add-bbox-feature2","sha":"fb32161846e5b3f597c55ec1e42ea62dbb9bee59","user":{"login":"cphyc","id":5411875,"avatar_url":"https://avatars1.githubusercontent.com/u/5411875?v=4","gravatar_id":"","url":"https://api.github.com/users/cphyc","html_url":"https://github.com/cphyc","followers_url":"https://api.github.com/users/cphyc/followers","following_url":"https://api.github.com/users/cphyc/following{/other_user}","gists_url":"https://api.github.com/users/cphyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cphyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cphyc/subscriptions","organizations_url":"https://api.github.com/users/cphyc/orgs","repos_url":"https://api.github.com/users/cphyc/repos","events_url":"https://api.github.com/users/cphyc/events{/privacy}","received_events_url":"https://api.github.com/users/cphyc/received_events","type":"User","site_admin":false},"repo":{"id":95677956,"name":"yt","full_name":"cphyc/yt","owner":{"login":"cphyc","id":5411875,"avatar_url":"https://avatars1.githubusercontent.com/u/5411875?v=4","gravatar_id":"","url":"https://api.github.com/users/cphyc","html_url":"https://github.com/cphyc","followers_url":"https://api.github.com/users/cphyc/followers","following_url":"https://api.github.com/users/cphyc/following{/other_user}","gists_url":"https://api.github.com/users/cphyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cphyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cphyc/subscriptions","organizations_url":"https://api.github.com/users/cphyc/orgs","repos_url":"https://api.github.com/users/cphyc/repos","events_url":"https://api.github.com/users/cphyc/events{/privacy}","received_events_url":"https://api.github.com/users/cphyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cphyc/yt","description":"Main yt repository","fork":true,"url":"https://api.github.com/repos/cphyc/yt","forks_url":"https://api.github.com/repos/cphyc/yt/forks","keys_url":"https://api.github.com/repos/cphyc/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cphyc/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cphyc/yt/teams","hooks_url":"https://api.github.com/repos/cphyc/yt/hooks","issue_events_url":"https://api.github.com/repos/cphyc/yt/issues/events{/number}","events_url":"https://api.github.com/repos/cphyc/yt/events","assignees_url":"https://api.github.com/repos/cphyc/yt/assignees{/user}","branches_url":"https://api.github.com/repos/cphyc/yt/branches{/branch}","tags_url":"https://api.github.com/repos/cphyc/yt/tags","blobs_url":"https://api.github.com/repos/cphyc/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cphyc/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cphyc/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cphyc/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cphyc/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/cphyc/yt/languages","stargazers_url":"https://api.github.com/repos/cphyc/yt/stargazers","contributors_url":"https://api.github.com/repos/cphyc/yt/contributors","subscribers_url":"https://api.github.com/repos/cphyc/yt/subscribers","subscription_url":"https://api.github.com/repos/cphyc/yt/subscription","commits_url":"https://api.github.com/repos/cphyc/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cphyc/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cphyc/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cphyc/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cphyc/yt/contents/{+path}","compare_url":"https://api.github.com/repos/cphyc/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cphyc/yt/merges","archive_url":"https://api.github.com/repos/cphyc/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cphyc/yt/downloads","issues_url":"https://api.github.com/repos/cphyc/yt/issues{/number}","pulls_url":"https://api.github.com/repos/cphyc/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/cphyc/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/cphyc/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cphyc/yt/labels{/name}","releases_url":"https://api.github.com/repos/cphyc/yt/releases{/id}","deployments_url":"https://api.github.com/repos/cphyc/yt/deployments","created_at":"2017-06-28T14:29:53Z","updated_at":"2017-06-28T14:29:59Z","pushed_at":"2017-11-29T18:10:56Z","git_url":"git://github.com/cphyc/yt.git","ssh_url":"git@github.com:cphyc/yt.git","clone_url":"https://github.com/cphyc/yt.git","svn_url":"https://github.com/cphyc/yt","homepage":"http://yt-project.org","size":262675,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yt-project:master","ref":"master","sha":"14bdad210b44d6dacec42f99c42db039400307fa","user":{"login":"yt-project","id":20566579,"avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"repo":{"id":88776493,"name":"yt","full_name":"yt-project/yt","owner":{"login":"yt-project","id":20566579,"avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yt-project/yt","description":"Main yt repository","fork":false,"url":"https://api.github.com/repos/yt-project/yt","forks_url":"https://api.github.com/repos/yt-project/yt/forks","keys_url":"https://api.github.com/repos/yt-project/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yt-project/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yt-project/yt/teams","hooks_url":"https://api.github.com/repos/yt-project/yt/hooks","issue_events_url":"https://api.github.com/repos/yt-project/yt/issues/events{/number}","events_url":"https://api.github.com/repos/yt-project/yt/events","assignees_url":"https://api.github.com/repos/yt-project/yt/assignees{/user}","branches_url":"https://api.github.com/repos/yt-project/yt/branches{/branch}","tags_url":"https://api.github.com/repos/yt-project/yt/tags","blobs_url":"https://api.github.com/repos/yt-project/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yt-project/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yt-project/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yt-project/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/yt-project/yt/languages","stargazers_url":"https://api.github.com/repos/yt-project/yt/stargazers","contributors_url":"https://api.github.com/repos/yt-project/yt/contributors","subscribers_url":"https://api.github.com/repos/yt-project/yt/subscribers","subscription_url":"https://api.github.com/repos/yt-project/yt/subscription","commits_url":"https://api.github.com/repos/yt-project/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yt-project/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yt-project/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yt-project/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yt-project/yt/contents/{+path}","compare_url":"https://api.github.com/repos/yt-project/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yt-project/yt/merges","archive_url":"https://api.github.com/repos/yt-project/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yt-project/yt/downloads","issues_url":"https://api.github.com/repos/yt-project/yt/issues{/number}","pulls_url":"https://api.github.com/repos/yt-project/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/yt-project/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/yt-project/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yt-project/yt/labels{/name}","releases_url":"https://api.github.com/repos/yt-project/yt/releases{/id}","deployments_url":"https://api.github.com/repos/yt-project/yt/deployments","created_at":"2017-04-19T18:16:11Z","updated_at":"2017-11-20T02:05:05Z","pushed_at":"2017-11-29T19:02:07Z","git_url":"git://github.com/yt-project/yt.git","ssh_url":"git@github.com:yt-project/yt.git","clone_url":"https://github.com/yt-project/yt.git","svn_url":"https://github.com/yt-project/yt","homepage":"http://yt-project.org","size":262631,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":59,"open_issues":135,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1637"},"html":{"href":"https://github.com/yt-project/yt/pull/1637"},"issue":{"href":"https://api.github.com/repos/yt-project/yt/issues/1637"},"comments":{"href":"https://api.github.com/repos/yt-project/yt/issues/1637/comments"},"review_comments":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1637/comments"},"review_comment":{"href":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1637/commits"},"statuses":{"href":"https://api.github.com/repos/yt-project/yt/statuses/fb32161846e5b3f597c55ec1e42ea62dbb9bee59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ngoldbaum"}}