{"action":"opened","number":1977,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977","id":103646642,"html_url":"https://github.com/openmrs/openmrs-core/pull/1977","diff_url":"https://github.com/openmrs/openmrs-core/pull/1977.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/1977.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1977","number":1977,"state":"open","locked":false,"title":"Add JUnit @should annotations according to code comments","user":{"login":"hilz041","id":16336185,"avatar_url":"https://avatars.githubusercontent.com/u/16336185?v=3","gravatar_id":"","url":"https://api.github.com/users/hilz041","html_url":"https://github.com/hilz041","followers_url":"https://api.github.com/users/hilz041/followers","following_url":"https://api.github.com/users/hilz041/following{/other_user}","gists_url":"https://api.github.com/users/hilz041/gists{/gist_id}","starred_url":"https://api.github.com/users/hilz041/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hilz041/subscriptions","organizations_url":"https://api.github.com/users/hilz041/orgs","repos_url":"https://api.github.com/users/hilz041/repos","events_url":"https://api.github.com/users/hilz041/events{/privacy}","received_events_url":"https://api.github.com/users/hilz041/received_events","type":"User","site_admin":false},"body":"<!--- 'TRUNK-248 Add JUnit @should annotations according to code comments' -->\r\n\r\n## Description\r\nI put a @should annotation describing what the unit test should confirm \r\n\r\n- @should return a criterion when identifierTypes is not empty\r\n- @should return a list of patientIdentifiers when patientIdentifierTypes is not null\r\n- @sholud return a list of patientIdentifiers when patient is not empty\r\n- @should return criteria if containingAnyFormField any formField is not empty\r\n\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue\r\nfirst -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to\r\nreproduce -->\r\nsee https://issues.openmrs.org/browse/TRUNK-248\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that\r\napply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to\r\nhelp! -->\r\n- [x ] My pull request only contains one single commit.\r\n- [x ] My pull request is based on the latest master branch\r\n  `git pull --rebase upstream master`.\r\n- [x ] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n- [x ] My code follows the code style of this project.\r\n- [ x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ x] All new and existing tests passed.\r\n\r\n","created_at":"2017-01-29T13:54:27Z","updated_at":"2017-01-29T13:54:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1977/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/56b976bf10a821d7eb2f31fe80931ddf9e6d36ff","head":{"label":"hilz041:master","ref":"master","sha":"56b976bf10a821d7eb2f31fe80931ddf9e6d36ff","user":{"login":"hilz041","id":16336185,"avatar_url":"https://avatars.githubusercontent.com/u/16336185?v=3","gravatar_id":"","url":"https://api.github.com/users/hilz041","html_url":"https://github.com/hilz041","followers_url":"https://api.github.com/users/hilz041/followers","following_url":"https://api.github.com/users/hilz041/following{/other_user}","gists_url":"https://api.github.com/users/hilz041/gists{/gist_id}","starred_url":"https://api.github.com/users/hilz041/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hilz041/subscriptions","organizations_url":"https://api.github.com/users/hilz041/orgs","repos_url":"https://api.github.com/users/hilz041/repos","events_url":"https://api.github.com/users/hilz041/events{/privacy}","received_events_url":"https://api.github.com/users/hilz041/received_events","type":"User","site_admin":false},"repo":{"id":67132502,"name":"openmrs-core","full_name":"hilz041/openmrs-core","owner":{"login":"hilz041","id":16336185,"avatar_url":"https://avatars.githubusercontent.com/u/16336185?v=3","gravatar_id":"","url":"https://api.github.com/users/hilz041","html_url":"https://github.com/hilz041","followers_url":"https://api.github.com/users/hilz041/followers","following_url":"https://api.github.com/users/hilz041/following{/other_user}","gists_url":"https://api.github.com/users/hilz041/gists{/gist_id}","starred_url":"https://api.github.com/users/hilz041/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hilz041/subscriptions","organizations_url":"https://api.github.com/users/hilz041/orgs","repos_url":"https://api.github.com/users/hilz041/repos","events_url":"https://api.github.com/users/hilz041/events{/privacy}","received_events_url":"https://api.github.com/users/hilz041/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hilz041/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/hilz041/openmrs-core","forks_url":"https://api.github.com/repos/hilz041/openmrs-core/forks","keys_url":"https://api.github.com/repos/hilz041/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hilz041/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hilz041/openmrs-core/teams","hooks_url":"https://api.github.com/repos/hilz041/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/hilz041/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/hilz041/openmrs-core/events","assignees_url":"https://api.github.com/repos/hilz041/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/hilz041/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/hilz041/openmrs-core/tags","blobs_url":"https://api.github.com/repos/hilz041/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hilz041/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hilz041/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hilz041/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hilz041/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hilz041/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/hilz041/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/hilz041/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/hilz041/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/hilz041/openmrs-core/subscription","commits_url":"https://api.github.com/repos/hilz041/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hilz041/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hilz041/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hilz041/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hilz041/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/hilz041/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hilz041/openmrs-core/merges","archive_url":"https://api.github.com/repos/hilz041/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hilz041/openmrs-core/downloads","issues_url":"https://api.github.com/repos/hilz041/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/hilz041/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hilz041/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hilz041/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hilz041/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/hilz041/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/hilz041/openmrs-core/deployments","created_at":"2016-09-01T13:14:34Z","updated_at":"2016-09-01T13:14:49Z","pushed_at":"2017-01-29T13:15:10Z","git_url":"git://github.com/hilz041/openmrs-core.git","ssh_url":"git@github.com:hilz041/openmrs-core.git","clone_url":"https://github.com/hilz041/openmrs-core.git","svn_url":"https://github.com/hilz041/openmrs-core","homepage":"http://openmrs.org","size":222469,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"3ea3d01e65999f2887804c53d9deef5d0887fda3","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2017-01-29T03:14:51Z","pushed_at":"2017-01-29T12:06:30Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":222628,"stargazers_count":402,"watchers_count":402,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1662,"mirror_url":null,"open_issues_count":5,"forks":1662,"open_issues":5,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/1977"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1977"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1977/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1977/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/56b976bf10a821d7eb2f31fe80931ddf9e6d36ff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":13,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"hilz041"}}