{"action":"created","comment":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/103933518","pull_request_review_id":24740707,"id":103933518,"diff_hunk":"@@ -1028,13 +1028,34 @@ WebDriverServer.prototype.onTracingMessage_ = function(message) {\n };\r\n \r\n /**\r\n- * Runs lighthouse with the options specified by the task and dumps data into \r\n+ * Runs lighthouse with the options specified by the task and dumps data into\r\n  * a directory.\r\n  * @private\r\n  */\r\n WebDriverServer.prototype.runLighthouse_ = function() {\r\n-  // TODO(phulce): actually run lighthouse\r\n-  this.onPageLoad_(new Error('Lighthouse not yet implemented!'));\r\n+  this.lighthouseFile_ = path.join(this.runTempDir_, 'lighthouse.html');\r\n+  this.app_.timeout(1000, 'Waiting for Chrome to be available...');\r\n+  process_utils.scheduleExec(this.app_,\r\n+    'lighthouse',\r","path":"agent/js/src/wd_server.js","position":15,"original_position":15,"commit_id":"b14392620001c3e3ef980d3e24d4a250ee77811c","original_commit_id":"b14392620001c3e3ef980d3e24d4a250ee77811c","user":{"login":"pmeenan","id":444165,"avatar_url":"https://avatars1.githubusercontent.com/u/444165?v=3","gravatar_id":"","url":"https://api.github.com/users/pmeenan","html_url":"https://github.com/pmeenan","followers_url":"https://api.github.com/users/pmeenan/followers","following_url":"https://api.github.com/users/pmeenan/following{/other_user}","gists_url":"https://api.github.com/users/pmeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeenan/subscriptions","organizations_url":"https://api.github.com/users/pmeenan/orgs","repos_url":"https://api.github.com/users/pmeenan/repos","events_url":"https://api.github.com/users/pmeenan/events{/privacy}","received_events_url":"https://api.github.com/users/pmeenan/received_events","type":"User","site_admin":false},"body":"How big is it and is it feasible to include directly?  Worst case I'll add logic to the agent at startup to look for it and try to install if it isn't there (and automatically update if it is) but if we can eliminate the need for manually installing then all of the existing agents will pick up lighthouse support automatically.\r\n\r\nAlso, does running it as \"lighthouse\" work on Windows as well or does Node need to explicitly be referenced?  Just checking since the Node agent runs across all platforms.","created_at":"2017-03-02T14:21:55Z","updated_at":"2017-03-02T14:29:20Z","html_url":"https://github.com/WPO-Foundation/webpagetest/pull/825#discussion_r103933518","pull_request_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825","_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/103933518"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/825#discussion_r103933518"},"pull_request":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825"}}},"pull_request":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825","id":108667464,"html_url":"https://github.com/WPO-Foundation/webpagetest/pull/825","diff_url":"https://github.com/WPO-Foundation/webpagetest/pull/825.diff","patch_url":"https://github.com/WPO-Foundation/webpagetest/pull/825.patch","issue_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/825","number":825,"state":"open","locked":false,"title":"feat: add basic lighthouse functionality","user":{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars1.githubusercontent.com/u/2301202?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false},"body":"cc: @paulirish @ebidel @brendankenny\r\n\r\n**The Lighthouse**\r\n![http://g.recordit.co/jouv3SIcwe.gif](http://g.recordit.co/jouv3SIcwe.gif)\r\n\r\n**The Run**\r\n![image](http://g.recordit.co/qvGM9F5d4P.gif)\r\n\r\n**The Report** (video is available on mobile)\r\n![image](http://g.recordit.co/cPnONMjIea.gif)\r\n","created_at":"2017-03-02T01:26:27Z","updated_at":"2017-03-02T14:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d6b0b23ef8132063169c2ae687fde05bed9ec4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825/commits","review_comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825/comments","review_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/825/comments","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/b14392620001c3e3ef980d3e24d4a250ee77811c","head":{"label":"patrickhulce:lighthouse_run","ref":"lighthouse_run","sha":"b14392620001c3e3ef980d3e24d4a250ee77811c","user":{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars1.githubusercontent.com/u/2301202?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false},"repo":{"id":80076299,"name":"webpagetest","full_name":"patrickhulce/webpagetest","owner":{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars1.githubusercontent.com/u/2301202?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickhulce/webpagetest","description":"Official repository for WebPagetest","fork":true,"url":"https://api.github.com/repos/patrickhulce/webpagetest","forks_url":"https://api.github.com/repos/patrickhulce/webpagetest/forks","keys_url":"https://api.github.com/repos/patrickhulce/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickhulce/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickhulce/webpagetest/teams","hooks_url":"https://api.github.com/repos/patrickhulce/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/patrickhulce/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/patrickhulce/webpagetest/events","assignees_url":"https://api.github.com/repos/patrickhulce/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/patrickhulce/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/patrickhulce/webpagetest/tags","blobs_url":"https://api.github.com/repos/patrickhulce/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickhulce/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickhulce/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickhulce/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickhulce/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickhulce/webpagetest/languages","stargazers_url":"https://api.github.com/repos/patrickhulce/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/patrickhulce/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/patrickhulce/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/patrickhulce/webpagetest/subscription","commits_url":"https://api.github.com/repos/patrickhulce/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickhulce/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickhulce/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickhulce/webpagetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickhulce/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/patrickhulce/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickhulce/webpagetest/merges","archive_url":"https://api.github.com/repos/patrickhulce/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickhulce/webpagetest/downloads","issues_url":"https://api.github.com/repos/patrickhulce/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/patrickhulce/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickhulce/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickhulce/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickhulce/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/patrickhulce/webpagetest/releases{/id}","deployments_url":"https://api.github.com/repos/patrickhulce/webpagetest/deployments","created_at":"2017-01-26T01:36:36Z","updated_at":"2017-01-26T01:36:53Z","pushed_at":"2017-03-02T01:25:35Z","git_url":"git://github.com/patrickhulce/webpagetest.git","ssh_url":"git@github.com:patrickhulce/webpagetest.git","clone_url":"https://github.com/patrickhulce/webpagetest.git","svn_url":"https://github.com/patrickhulce/webpagetest","homepage":null,"size":639029,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WPO-Foundation:master","ref":"master","sha":"77a4a7d8ededfc2aebef4209c28b48a3d53dc389","user":{"login":"WPO-Foundation","id":4622875,"avatar_url":"https://avatars1.githubusercontent.com/u/4622875?v=3","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":11029192,"name":"webpagetest","full_name":"WPO-Foundation/webpagetest","owner":{"login":"WPO-Foundation","id":4622875,"avatar_url":"https://avatars1.githubusercontent.com/u/4622875?v=3","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WPO-Foundation/webpagetest","description":"Official repository for WebPagetest","fork":false,"url":"https://api.github.com/repos/WPO-Foundation/webpagetest","forks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/forks","keys_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/teams","hooks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/events","assignees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/tags","blobs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/languages","stargazers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscription","commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/merges","archive_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/downloads","issues_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/releases{/id}","deployments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/deployments","created_at":"2013-06-28T14:54:54Z","updated_at":"2017-03-02T08:04:21Z","pushed_at":"2017-03-02T11:12:47Z","git_url":"git://github.com/WPO-Foundation/webpagetest.git","ssh_url":"git@github.com:WPO-Foundation/webpagetest.git","clone_url":"https://github.com/WPO-Foundation/webpagetest.git","svn_url":"https://github.com/WPO-Foundation/webpagetest","homepage":null,"size":639022,"stargazers_count":1359,"watchers_count":1359,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":365,"mirror_url":null,"open_issues_count":258,"forks":365,"open_issues":258,"watchers":1359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/825"},"issue":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/825"},"comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/825/comments"},"review_comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825/comments"},"review_comment":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/825/commits"},"statuses":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/b14392620001c3e3ef980d3e24d4a250ee77811c"}}}}
{"actor":{"display_login":"pmeenan"}}