{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/133585012","pull_request_review_id":56784463,"id":133585012,"diff_hunk":"@@ -284,6 +284,16 @@ func (cnc *CloudNodeController) AddCloudNode(obj interface{}) {\n \t\t\treturn err\n \t\t}\n \n+\t\tproviderID, err := cloudprovider.GetInstanceProviderID(cnc.cloud, types.NodeName(curNode.Name))\n+\t\tif err == nil {\n+\t\t\tcurNode.Spec.ProviderID = providerID\n+\t\t} else {\n+\t\t\t// we should attempt to set providerID on curNode, but\n+\t\t\t// we can continue if we fail since we will attempt to set\n+\t\t\t// node addresses given the node name in getNodeAddressesByProviderIDOrName\n+\t\t\tglog.Errorf(\"%v\", err)","path":"pkg/controller/cloud/node_controller.go","position":11,"original_position":11,"commit_id":"76c436b280cc6bc1e5344e5feb99208edaf07a14","original_commit_id":"76c436b280cc6bc1e5344e5feb99208edaf07a14","user":{"login":"jhorwit2","id":3876739,"avatar_url":"https://avatars1.githubusercontent.com/u/3876739?v=4","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},"body":"This is changing logic from the kubelet. If the kubelet encounters an error getting the ProviderID it won't continue fetching subsequent information from the cloud provider. https://github.com/kubernetes/kubernetes/blob/02b520f0a40be2056d91fc0661c2b4fdb2694c30/pkg/kubelet/kubelet_node_status.go#L295","created_at":"2017-08-16T22:38:04Z","updated_at":"2017-08-16T22:38:04Z","html_url":"https://github.com/kubernetes/kubernetes/pull/50730#discussion_r133585012","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/133585012"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50730#discussion_r133585012"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730","id":135934907,"html_url":"https://github.com/kubernetes/kubernetes/pull/50730","diff_url":"https://github.com/kubernetes/kubernetes/pull/50730.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50730.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50730","number":50730,"state":"open","locked":false,"title":"Cloud Controller Manager now sets Node.Spec.ProviderID","user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nCloud Controller Manager now sets `Node.Spec.ProviderID`.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\nhttps://github.com/kubernetes/kubernetes/issues/49836. \r\n\r\n**Special notes for your reviewer**:\r\n* As part of an effort to move cloud controller manager into beta https://github.com/kubernetes/kubernetes/issues/48690. \r\n","created_at":"2017-08-16T03:38:03Z","updated_at":"2017-08-16T22:38:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"197867195e89c85f8073720b8492ea22d79c000c","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50730/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/76c436b280cc6bc1e5344e5feb99208edaf07a14","head":{"label":"andrewsykim:49836","ref":"49836","sha":"76c436b280cc6bc1e5344e5feb99208edaf07a14","user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"repo":{"id":73117920,"name":"kubernetes","full_name":"andrewsykim/kubernetes","owner":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewsykim/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/andrewsykim/kubernetes","forks_url":"https://api.github.com/repos/andrewsykim/kubernetes/forks","keys_url":"https://api.github.com/repos/andrewsykim/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewsykim/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewsykim/kubernetes/teams","hooks_url":"https://api.github.com/repos/andrewsykim/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/andrewsykim/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/andrewsykim/kubernetes/events","assignees_url":"https://api.github.com/repos/andrewsykim/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/andrewsykim/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/andrewsykim/kubernetes/tags","blobs_url":"https://api.github.com/repos/andrewsykim/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewsykim/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewsykim/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewsykim/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewsykim/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewsykim/kubernetes/languages","stargazers_url":"https://api.github.com/repos/andrewsykim/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/andrewsykim/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/andrewsykim/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/andrewsykim/kubernetes/subscription","commits_url":"https://api.github.com/repos/andrewsykim/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewsykim/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewsykim/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewsykim/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewsykim/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/andrewsykim/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewsykim/kubernetes/merges","archive_url":"https://api.github.com/repos/andrewsykim/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewsykim/kubernetes/downloads","issues_url":"https://api.github.com/repos/andrewsykim/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/andrewsykim/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewsykim/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewsykim/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewsykim/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/andrewsykim/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/andrewsykim/kubernetes/deployments","created_at":"2016-11-07T20:27:07Z","updated_at":"2016-11-07T20:27:43Z","pushed_at":"2017-08-16T03:35:04Z","git_url":"git://github.com/andrewsykim/kubernetes.git","ssh_url":"git@github.com:andrewsykim/kubernetes.git","clone_url":"https://github.com/andrewsykim/kubernetes.git","svn_url":"https://github.com/andrewsykim/kubernetes","homepage":"http://kubernetes.io","size":455789,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"da00e92f87c53c0edde5b49096116aa0e925d870","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-16T22:28:53Z","pushed_at":"2017-08-16T22:38:03Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":675961,"stargazers_count":25952,"watchers_count":25952,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9252,"mirror_url":null,"open_issues_count":5249,"forks":9252,"open_issues":5249,"watchers":25952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50730"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50730"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50730/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50730/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/76c436b280cc6bc1e5344e5feb99208edaf07a14"}}}}
{"actor":{"display_login":"jhorwit2"}}