{"action":"created","comment":{"url":"https://api.github.com/repos/open-power-host-os/builds/pulls/comments/115848738","pull_request_review_id":37424344,"id":115848738,"diff_hunk":"@@ -155,18 +155,12 @@ def _save(self):\n                                   LATEST_SYMLINK_NAME)\n         utils.force_symlink(self.timestamp, latest_dir)\n \n-        iso_file = \"%s-DVD-%s-%s.iso\" % (self.distro, self.arch, self.version)\n-        checksum_file = (\"%s-%s-%s-CHECKSUM\" %\n-                         (self.distro, self.version, self.arch))\n         iso_dir = \"/%s/%s/iso\" % (self.version, self.arch)\n-        iso_path = os.path.join(iso_dir, iso_file)\n-        checksum_path = os.path.join(iso_dir, checksum_file)\n-        chroot_files = \"%s %s\" % (iso_path, checksum_path)\n+        iso_files = \"%s/*\" % iso_dir","path":"lib/iso_builder.py","position":11,"original_position":11,"commit_id":"ba51ffedabdbcc85b70b5ff49b645b4b3bb829d0","original_commit_id":"ba51ffedabdbcc85b70b5ff49b645b4b3bb829d0","user":{"login":"olavph","id":693694,"avatar_url":"https://avatars1.githubusercontent.com/u/693694?v=3","gravatar_id":"","url":"https://api.github.com/users/olavph","html_url":"https://github.com/olavph","followers_url":"https://api.github.com/users/olavph/followers","following_url":"https://api.github.com/users/olavph/following{/other_user}","gists_url":"https://api.github.com/users/olavph/gists{/gist_id}","starred_url":"https://api.github.com/users/olavph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olavph/subscriptions","organizations_url":"https://api.github.com/users/olavph/orgs","repos_url":"https://api.github.com/users/olavph/repos","events_url":"https://api.github.com/users/olavph/events{/privacy}","received_events_url":"https://api.github.com/users/olavph/received_events","type":"User","site_admin":false},"body":"I'd call this `iso_files_pattern` so no one confuses it with a list of files, but that's a matter of taste.","created_at":"2017-05-10T20:48:22Z","updated_at":"2017-05-10T20:49:13Z","html_url":"https://github.com/open-power-host-os/builds/pull/258#discussion_r115848738","pull_request_url":"https://api.github.com/repos/open-power-host-os/builds/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/comments/115848738"},"html":{"href":"https://github.com/open-power-host-os/builds/pull/258#discussion_r115848738"},"pull_request":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/open-power-host-os/builds/pulls/258","id":119743502,"html_url":"https://github.com/open-power-host-os/builds/pull/258","diff_url":"https://github.com/open-power-host-os/builds/pull/258.diff","patch_url":"https://github.com/open-power-host-os/builds/pull/258.patch","issue_url":"https://api.github.com/repos/open-power-host-os/builds/issues/258","number":258,"state":"open","locked":false,"title":"Save netinst ISO image","user":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars2.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"body":"The netinst image is already generated by the compose tool but it is not\r\ncurrently saved as part of the resulting artifacts.\r\n\r\nThis patch saves the DVD and netinst images along with the checksum file.\r\n\r\nSigned-off-by: Murilo Opsfelder Araujo <muriloo@linux.vnet.ibm.com>","created_at":"2017-05-09T20:14:36Z","updated_at":"2017-05-10T20:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7811384425f935a840e244fd2f5167318ee7a8f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-power-host-os/builds/pulls/258/commits","review_comments_url":"https://api.github.com/repos/open-power-host-os/builds/pulls/258/comments","review_comment_url":"https://api.github.com/repos/open-power-host-os/builds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-power-host-os/builds/issues/258/comments","statuses_url":"https://api.github.com/repos/open-power-host-os/builds/statuses/ba51ffedabdbcc85b70b5ff49b645b4b3bb829d0","head":{"label":"mopsfelder:save_all_isos","ref":"save_all_isos","sha":"ba51ffedabdbcc85b70b5ff49b645b4b3bb829d0","user":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars2.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"repo":{"id":68956892,"name":"builds","full_name":"mopsfelder/builds","owner":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars2.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mopsfelder/builds","description":"OpenPOWER Host OS builds repository","fork":true,"url":"https://api.github.com/repos/mopsfelder/builds","forks_url":"https://api.github.com/repos/mopsfelder/builds/forks","keys_url":"https://api.github.com/repos/mopsfelder/builds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mopsfelder/builds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mopsfelder/builds/teams","hooks_url":"https://api.github.com/repos/mopsfelder/builds/hooks","issue_events_url":"https://api.github.com/repos/mopsfelder/builds/issues/events{/number}","events_url":"https://api.github.com/repos/mopsfelder/builds/events","assignees_url":"https://api.github.com/repos/mopsfelder/builds/assignees{/user}","branches_url":"https://api.github.com/repos/mopsfelder/builds/branches{/branch}","tags_url":"https://api.github.com/repos/mopsfelder/builds/tags","blobs_url":"https://api.github.com/repos/mopsfelder/builds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mopsfelder/builds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mopsfelder/builds/git/refs{/sha}","trees_url":"https://api.github.com/repos/mopsfelder/builds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mopsfelder/builds/statuses/{sha}","languages_url":"https://api.github.com/repos/mopsfelder/builds/languages","stargazers_url":"https://api.github.com/repos/mopsfelder/builds/stargazers","contributors_url":"https://api.github.com/repos/mopsfelder/builds/contributors","subscribers_url":"https://api.github.com/repos/mopsfelder/builds/subscribers","subscription_url":"https://api.github.com/repos/mopsfelder/builds/subscription","commits_url":"https://api.github.com/repos/mopsfelder/builds/commits{/sha}","git_commits_url":"https://api.github.com/repos/mopsfelder/builds/git/commits{/sha}","comments_url":"https://api.github.com/repos/mopsfelder/builds/comments{/number}","issue_comment_url":"https://api.github.com/repos/mopsfelder/builds/issues/comments{/number}","contents_url":"https://api.github.com/repos/mopsfelder/builds/contents/{+path}","compare_url":"https://api.github.com/repos/mopsfelder/builds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mopsfelder/builds/merges","archive_url":"https://api.github.com/repos/mopsfelder/builds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mopsfelder/builds/downloads","issues_url":"https://api.github.com/repos/mopsfelder/builds/issues{/number}","pulls_url":"https://api.github.com/repos/mopsfelder/builds/pulls{/number}","milestones_url":"https://api.github.com/repos/mopsfelder/builds/milestones{/number}","notifications_url":"https://api.github.com/repos/mopsfelder/builds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mopsfelder/builds/labels{/name}","releases_url":"https://api.github.com/repos/mopsfelder/builds/releases{/id}","deployments_url":"https://api.github.com/repos/mopsfelder/builds/deployments","created_at":"2016-09-22T19:51:19Z","updated_at":"2016-09-22T19:51:20Z","pushed_at":"2017-05-10T17:32:59Z","git_url":"git://github.com/mopsfelder/builds.git","ssh_url":"git@github.com:mopsfelder/builds.git","clone_url":"https://github.com/mopsfelder/builds.git","svn_url":"https://github.com/mopsfelder/builds","homepage":null,"size":841,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-power-host-os:master","ref":"master","sha":"6291babb0b2034df62cbd5a1251202886e65d53e","user":{"login":"open-power-host-os","id":19573150,"avatar_url":"https://avatars0.githubusercontent.com/u/19573150?v=3","gravatar_id":"","url":"https://api.github.com/users/open-power-host-os","html_url":"https://github.com/open-power-host-os","followers_url":"https://api.github.com/users/open-power-host-os/followers","following_url":"https://api.github.com/users/open-power-host-os/following{/other_user}","gists_url":"https://api.github.com/users/open-power-host-os/gists{/gist_id}","starred_url":"https://api.github.com/users/open-power-host-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-power-host-os/subscriptions","organizations_url":"https://api.github.com/users/open-power-host-os/orgs","repos_url":"https://api.github.com/users/open-power-host-os/repos","events_url":"https://api.github.com/users/open-power-host-os/events{/privacy}","received_events_url":"https://api.github.com/users/open-power-host-os/received_events","type":"Organization","site_admin":false},"repo":{"id":60042057,"name":"builds","full_name":"open-power-host-os/builds","owner":{"login":"open-power-host-os","id":19573150,"avatar_url":"https://avatars0.githubusercontent.com/u/19573150?v=3","gravatar_id":"","url":"https://api.github.com/users/open-power-host-os","html_url":"https://github.com/open-power-host-os","followers_url":"https://api.github.com/users/open-power-host-os/followers","following_url":"https://api.github.com/users/open-power-host-os/following{/other_user}","gists_url":"https://api.github.com/users/open-power-host-os/gists{/gist_id}","starred_url":"https://api.github.com/users/open-power-host-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-power-host-os/subscriptions","organizations_url":"https://api.github.com/users/open-power-host-os/orgs","repos_url":"https://api.github.com/users/open-power-host-os/repos","events_url":"https://api.github.com/users/open-power-host-os/events{/privacy}","received_events_url":"https://api.github.com/users/open-power-host-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-power-host-os/builds","description":"OpenPOWER Host OS builds repository","fork":false,"url":"https://api.github.com/repos/open-power-host-os/builds","forks_url":"https://api.github.com/repos/open-power-host-os/builds/forks","keys_url":"https://api.github.com/repos/open-power-host-os/builds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-power-host-os/builds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-power-host-os/builds/teams","hooks_url":"https://api.github.com/repos/open-power-host-os/builds/hooks","issue_events_url":"https://api.github.com/repos/open-power-host-os/builds/issues/events{/number}","events_url":"https://api.github.com/repos/open-power-host-os/builds/events","assignees_url":"https://api.github.com/repos/open-power-host-os/builds/assignees{/user}","branches_url":"https://api.github.com/repos/open-power-host-os/builds/branches{/branch}","tags_url":"https://api.github.com/repos/open-power-host-os/builds/tags","blobs_url":"https://api.github.com/repos/open-power-host-os/builds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-power-host-os/builds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-power-host-os/builds/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-power-host-os/builds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-power-host-os/builds/statuses/{sha}","languages_url":"https://api.github.com/repos/open-power-host-os/builds/languages","stargazers_url":"https://api.github.com/repos/open-power-host-os/builds/stargazers","contributors_url":"https://api.github.com/repos/open-power-host-os/builds/contributors","subscribers_url":"https://api.github.com/repos/open-power-host-os/builds/subscribers","subscription_url":"https://api.github.com/repos/open-power-host-os/builds/subscription","commits_url":"https://api.github.com/repos/open-power-host-os/builds/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-power-host-os/builds/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-power-host-os/builds/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-power-host-os/builds/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-power-host-os/builds/contents/{+path}","compare_url":"https://api.github.com/repos/open-power-host-os/builds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-power-host-os/builds/merges","archive_url":"https://api.github.com/repos/open-power-host-os/builds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-power-host-os/builds/downloads","issues_url":"https://api.github.com/repos/open-power-host-os/builds/issues{/number}","pulls_url":"https://api.github.com/repos/open-power-host-os/builds/pulls{/number}","milestones_url":"https://api.github.com/repos/open-power-host-os/builds/milestones{/number}","notifications_url":"https://api.github.com/repos/open-power-host-os/builds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-power-host-os/builds/labels{/name}","releases_url":"https://api.github.com/repos/open-power-host-os/builds/releases{/id}","deployments_url":"https://api.github.com/repos/open-power-host-os/builds/deployments","created_at":"2016-05-30T22:19:14Z","updated_at":"2017-02-16T01:40:41Z","pushed_at":"2017-05-10T17:33:01Z","git_url":"git://github.com/open-power-host-os/builds.git","ssh_url":"git@github.com:open-power-host-os/builds.git","clone_url":"https://github.com/open-power-host-os/builds.git","svn_url":"https://github.com/open-power-host-os/builds","homepage":null,"size":1380,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":13,"forks":18,"open_issues":13,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/258"},"html":{"href":"https://github.com/open-power-host-os/builds/pull/258"},"issue":{"href":"https://api.github.com/repos/open-power-host-os/builds/issues/258"},"comments":{"href":"https://api.github.com/repos/open-power-host-os/builds/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-power-host-os/builds/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/open-power-host-os/builds/statuses/ba51ffedabdbcc85b70b5ff49b645b4b3bb829d0"}}}}
{"actor":{"display_login":"olavph"}}