{"action":"created","issue":{"url":"https://api.github.com/repos/bitshares/bitshares-core/issues/429","repository_url":"https://api.github.com/repos/bitshares/bitshares-core","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/429/comments","events_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/429/events","html_url":"https://github.com/bitshares/bitshares-core/issues/429","id":266483780,"number":429,"title":"Total CORE supply may be inaccurate due to rounding issue when creating assets","user":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"labels":[{"id":520505743,"url":"https://api.github.com/repos/bitshares/bitshares-core/labels/hardfork","name":"hardfork","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-18T13:00:05Z","updated_at":"2017-10-18T13:08:43Z","closed_at":null,"author_association":"NONE","body":"When creating an asset, fees that goes to the referral program is adjusted with [this code](https://github.com/bitshares/bitshares-core/blob/2.0.170710/libraries/chain/asset_evaluator.cpp#L94):\r\n```\r\n   core_fee_paid -= core_fee_paid.value/2;\r\n```\r\nAnd same amount will also be sent to the fee pool of the new asset with [this code](https://github.com/bitshares/bitshares-core/blob/2.0.170710/libraries/chain/asset_evaluator.cpp#L127):\r\n```\r\n         a.fee_pool = core_fee_paid; //op.calculate_fee(db().current_fee_schedule()).value / 2;\r\n```\r\nAccording to [the fee schedule](https://cryptofresh.com/fees), current asset creation fees are all odd numbers, thus one Satoshi of CORE asset has been created from nowhere after every asset created, and probably have gone to circulation (have been spent), although 20% of fees has been destroyed / has went back to the network.\r\n\r\nFix is needed for \r\n* future asset creation, and\r\n* retroactive total supply calculation\r\n\r\nTotal supply affects budgets, fortunately we've always have a refund worker so likely it will not cause trouble if we don't touch the budget calculation code (still need to check).\r\n"},"comment":{"url":"https://api.github.com/repos/bitshares/bitshares-core/issues/comments/337584558","html_url":"https://github.com/bitshares/bitshares-core/issues/429#issuecomment-337584558","issue_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/429","id":337584558,"user":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T13:08:43Z","updated_at":"2017-10-18T13:08:43Z","author_association":"NONE","body":"I'm suspect the issue is even worse. Investigating."}}
{"actor":{"display_login":"abitmore"}}