{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/127134913","pull_request_review_id":49686386,"id":127134913,"diff_hunk":"@@ -522,3 +523,39 @@ func isInstanceReady(instance *v1alpha1.Instance) bool {\n \n \treturn false\n }\n+","path":"pkg/controller/controller.go","position":12,"original_position":12,"commit_id":"fc7cf829e0b01e575544700e28af121a3492bfa6","original_commit_id":"c139e1810b63e3124fb6617719f68a270130fe3c","user":{"login":"nilebox","id":6176360,"avatar_url":"https://avatars3.githubusercontent.com/u/6176360?v=3","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"body":"@pmorie actually this PR is already merged into apimachinery. but we can't delete this code yet since it will be released only in 1.8. Might leave TODO there.","created_at":"2017-07-13T06:08:14Z","updated_at":"2017-07-13T06:08:14Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/979#discussion_r127134913","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/127134913"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/979#discussion_r127134913"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979","id":127365542,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/979","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/979.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/979.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/979","number":979,"state":"open","locked":false,"title":"Secret upsert: OwnerReference, safe Secret create/update, appropriate error messages","user":{"login":"nilebox","id":6176360,"avatar_url":"https://avatars3.githubusercontent.com/u/6176360?v=3","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"body":"See https://github.com/kubernetes-incubator/service-catalog/issues/978:\r\n`Binding` implicitly creates `Secret` and `PodPreset` objects.\r\nWe need to set the `ownerReferences` meta field to link those objects with parent Binding. We should also check this link before updating the existing Secret/PodPreset object.","created_at":"2017-06-25T14:19:55Z","updated_at":"2017-07-13T06:08:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af56bb9be576b9d8a5d0b567cc751b78afa6c2b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/979/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/fc7cf829e0b01e575544700e28af121a3492bfa6","head":{"label":"atlassian:nilebox/owner-references-binding","ref":"nilebox/owner-references-binding","sha":"fc7cf829e0b01e575544700e28af121a3492bfa6","user":{"login":"atlassian","id":168166,"avatar_url":"https://avatars0.githubusercontent.com/u/168166?v=3","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":94383517,"name":"service-catalog","full_name":"atlassian/service-catalog","owner":{"login":"atlassian","id":168166,"avatar_url":"https://avatars0.githubusercontent.com/u/168166?v=3","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atlassian/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":true,"url":"https://api.github.com/repos/atlassian/service-catalog","forks_url":"https://api.github.com/repos/atlassian/service-catalog/forks","keys_url":"https://api.github.com/repos/atlassian/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/service-catalog/teams","hooks_url":"https://api.github.com/repos/atlassian/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/atlassian/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/service-catalog/events","assignees_url":"https://api.github.com/repos/atlassian/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/service-catalog/tags","blobs_url":"https://api.github.com/repos/atlassian/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/service-catalog/languages","stargazers_url":"https://api.github.com/repos/atlassian/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/atlassian/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/atlassian/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/atlassian/service-catalog/subscription","commits_url":"https://api.github.com/repos/atlassian/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/service-catalog/merges","archive_url":"https://api.github.com/repos/atlassian/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/service-catalog/downloads","issues_url":"https://api.github.com/repos/atlassian/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/service-catalog/deployments","created_at":"2017-06-15T00:26:04Z","updated_at":"2017-06-15T00:26:07Z","pushed_at":"2017-07-13T05:39:43Z","git_url":"git://github.com/atlassian/service-catalog.git","ssh_url":"git@github.com:atlassian/service-catalog.git","clone_url":"https://github.com/atlassian/service-catalog.git","svn_url":"https://github.com/atlassian/service-catalog","homepage":"","size":75421,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"79d5206eba585721fd22aff53cb265ccf05855b0","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2017-07-13T02:21:14Z","pushed_at":"2017-07-13T05:48:26Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":69516,"stargazers_count":181,"watchers_count":181,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":154,"forks":70,"open_issues":154,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/979"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/979"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/fc7cf829e0b01e575544700e28af121a3492bfa6"}}}}
{"actor":{"display_login":"nilebox"}}