{"action":"created","issue":{"url":"https://api.github.com/repos/wix/redux-saga-tester/issues/43","repository_url":"https://api.github.com/repos/wix/redux-saga-tester","labels_url":"https://api.github.com/repos/wix/redux-saga-tester/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/wix/redux-saga-tester/issues/43/comments","events_url":"https://api.github.com/repos/wix/redux-saga-tester/issues/43/events","html_url":"https://github.com/wix/redux-saga-tester/pull/43","id":282654831,"number":43,"title":"Cause waitFor to reject if awaited action is never called.","user":{"login":"haroldtreen","id":1745854,"avatar_url":"https://avatars2.githubusercontent.com/u/1745854?v=4","gravatar_id":"","url":"https://api.github.com/users/haroldtreen","html_url":"https://github.com/haroldtreen","followers_url":"https://api.github.com/users/haroldtreen/followers","following_url":"https://api.github.com/users/haroldtreen/following{/other_user}","gists_url":"https://api.github.com/users/haroldtreen/gists{/gist_id}","starred_url":"https://api.github.com/users/haroldtreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haroldtreen/subscriptions","organizations_url":"https://api.github.com/users/haroldtreen/orgs","repos_url":"https://api.github.com/users/haroldtreen/repos","events_url":"https://api.github.com/users/haroldtreen/events{/privacy}","received_events_url":"https://api.github.com/users/haroldtreen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-16T22:24:18Z","updated_at":"2017-12-27T12:18:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wix/redux-saga-tester/pulls/43","html_url":"https://github.com/wix/redux-saga-tester/pull/43","diff_url":"https://github.com/wix/redux-saga-tester/pull/43.diff","patch_url":"https://github.com/wix/redux-saga-tester/pull/43.patch"},"body":"### Description\r\n\r\nChanges the `waitFor` promise to reject if the provided action is never called.\r\n\r\n### Example\r\n\r\n```js\r\nit('must call SOME_ACTION_THAT_WILL_NEVER_FIRE', () => { \r\n    const saga = function*() { yield; }\r\n    sagaTester.start(saga);\r\n   return sagaTester.waitFor('SOME_ACTION_THAT_WILL_NEVER_FIRE');\r\n});\r\n```\r\n\r\n**Before**\r\n\r\n```\r\nError: Timeout of 2000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n```\r\n\r\n- ❌  Not clear what went wrong. \r\n- ❌  Test hangs for 2 seconds before failing.\r\n\r\n**After**\r\n\r\n```\r\nError: SOME_ACTION_THAT_WILL_NEVER_FIRE was waited for but never called.\r\n```\r\n\r\n- ✅  Communicates that the expected behavior didn't occur.\r\n- ✅  Fails as soon as the saga is exhausted."},"comment":{"url":"https://api.github.com/repos/wix/redux-saga-tester/issues/comments/354105933","html_url":"https://github.com/wix/redux-saga-tester/pull/43#issuecomment-354105933","issue_url":"https://api.github.com/repos/wix/redux-saga-tester/issues/43","id":354105933,"user":{"login":"3LOK","id":1582694,"avatar_url":"https://avatars0.githubusercontent.com/u/1582694?v=4","gravatar_id":"","url":"https://api.github.com/users/3LOK","html_url":"https://github.com/3LOK","followers_url":"https://api.github.com/users/3LOK/followers","following_url":"https://api.github.com/users/3LOK/following{/other_user}","gists_url":"https://api.github.com/users/3LOK/gists{/gist_id}","starred_url":"https://api.github.com/users/3LOK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3LOK/subscriptions","organizations_url":"https://api.github.com/users/3LOK/orgs","repos_url":"https://api.github.com/users/3LOK/repos","events_url":"https://api.github.com/users/3LOK/events{/privacy}","received_events_url":"https://api.github.com/users/3LOK/received_events","type":"User","site_admin":false},"created_at":"2017-12-27T12:18:37Z","updated_at":"2017-12-27T12:18:37Z","author_association":"MEMBER","body":"@haroldtreen well, could find a use case to make it fail. merging and keeping my ears open to issues."}}
{"actor":{"display_login":"3LOK"}}