{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/135676789","pull_request_review_id":59113365,"id":135676789,"diff_hunk":"@@ -393,7 +393,10 @@ func (e extractStrategy) Extract(project, zone string) error {\n \t\t}\n \t\treturn getKube(url, release)\n \tcase gcs:\n-\t\treturn getKube(path.Dir(e.option), path.Base(e.option))\n+\t\t// strip gs://foo -> /foo\n+\t\twithoutGS := e.option[3:]","path":"kubetest/extract.go","position":6,"original_position":6,"commit_id":"eec243bae2e7ad2d6e2cd37b61d8bdc8cdd1eb11","original_commit_id":"eec243bae2e7ad2d6e2cd37b61d8bdc8cdd1eb11","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars3.githubusercontent.com/u/8061296?v=4","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"nit: `strings.TrimPrefix` is a more self-documenting way of achieving same.","created_at":"2017-08-29T01:47:50Z","updated_at":"2017-08-29T01:47:50Z","html_url":"https://github.com/kubernetes/test-infra/pull/4227#discussion_r135676789","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/135676789"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/4227#discussion_r135676789"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227","id":138067991,"html_url":"https://github.com/kubernetes/test-infra/pull/4227","diff_url":"https://github.com/kubernetes/test-infra/pull/4227.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/4227.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/4227","number":4227,"state":"closed","locked":false,"title":"fix kubetest for gs:// paths","user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"body":"`path.Dir` alone still gives you a `gs://` path (actually it munges `gs://` to `gs:/` too), whereas we want something we can `GET` in get-kube: this makes sure we form a base URL instead of a base path.\r\n\r\nThis also adds a unit test for this strategy.","created_at":"2017-08-29T00:42:10Z","updated_at":"2017-08-29T01:47:50Z","closed_at":"2017-08-29T01:32:33Z","merged_at":"2017-08-29T01:32:33Z","merge_commit_sha":"37583373cbf71f59566babfbcd187daa1eb5e453","assignee":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars3.githubusercontent.com/u/1108148?v=4","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"assignees":[{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars3.githubusercontent.com/u/1108148?v=4","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars3.githubusercontent.com/u/1108148?v=4","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/4227/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/eec243bae2e7ad2d6e2cd37b61d8bdc8cdd1eb11","head":{"label":"BenTheElder:fix_kubetest","ref":"fix_kubetest","sha":"eec243bae2e7ad2d6e2cd37b61d8bdc8cdd1eb11","user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"repo":{"id":97753110,"name":"test-infra","full_name":"BenTheElder/test-infra","owner":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenTheElder/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/BenTheElder/test-infra","forks_url":"https://api.github.com/repos/BenTheElder/test-infra/forks","keys_url":"https://api.github.com/repos/BenTheElder/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenTheElder/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenTheElder/test-infra/teams","hooks_url":"https://api.github.com/repos/BenTheElder/test-infra/hooks","issue_events_url":"https://api.github.com/repos/BenTheElder/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/BenTheElder/test-infra/events","assignees_url":"https://api.github.com/repos/BenTheElder/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/BenTheElder/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/BenTheElder/test-infra/tags","blobs_url":"https://api.github.com/repos/BenTheElder/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenTheElder/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenTheElder/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenTheElder/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenTheElder/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/BenTheElder/test-infra/languages","stargazers_url":"https://api.github.com/repos/BenTheElder/test-infra/stargazers","contributors_url":"https://api.github.com/repos/BenTheElder/test-infra/contributors","subscribers_url":"https://api.github.com/repos/BenTheElder/test-infra/subscribers","subscription_url":"https://api.github.com/repos/BenTheElder/test-infra/subscription","commits_url":"https://api.github.com/repos/BenTheElder/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenTheElder/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenTheElder/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenTheElder/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/BenTheElder/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/BenTheElder/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenTheElder/test-infra/merges","archive_url":"https://api.github.com/repos/BenTheElder/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenTheElder/test-infra/downloads","issues_url":"https://api.github.com/repos/BenTheElder/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/BenTheElder/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/BenTheElder/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/BenTheElder/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenTheElder/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/BenTheElder/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/BenTheElder/test-infra/deployments","created_at":"2017-07-19T19:21:39Z","updated_at":"2017-07-19T19:21:43Z","pushed_at":"2017-08-29T01:46:49Z","git_url":"git://github.com/BenTheElder/test-infra.git","ssh_url":"git@github.com:BenTheElder/test-infra.git","clone_url":"https://github.com/BenTheElder/test-infra.git","svn_url":"https://github.com/BenTheElder/test-infra","homepage":null,"size":24646,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"396e7e57d1df273626ced12d8fb23ac2ca72f1e0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2017-08-28T09:36:03Z","pushed_at":"2017-08-29T01:32:34Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":25491,"stargazers_count":127,"watchers_count":127,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":null,"open_issues_count":293,"forks":195,"open_issues":293,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/4227"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/4227"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/4227/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/4227/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/eec243bae2e7ad2d6e2cd37b61d8bdc8cdd1eb11"}}}}
{"actor":{"display_login":"ixdy"}}