{"action":"created","issue":{"url":"https://api.github.com/repos/samvera-labs/hyrax/issues/790","repository_url":"https://api.github.com/repos/samvera-labs/hyrax","labels_url":"https://api.github.com/repos/samvera-labs/hyrax/issues/790/labels{/name}","comments_url":"https://api.github.com/repos/samvera-labs/hyrax/issues/790/comments","events_url":"https://api.github.com/repos/samvera-labs/hyrax/issues/790/events","html_url":"https://github.com/samvera-labs/hyrax/issues/790","id":221719758,"number":790,"title":"When I select a thumbnail_id for an admin set it doesn't show up on the front page.","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars1.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"labels":[{"id":491302911,"url":"https://api.github.com/repos/samvera-labs/hyrax/labels/bug","name":"bug","color":"eb6420","default":true},{"id":505053955,"url":"https://api.github.com/repos/samvera-labs/hyrax/labels/collections/admin%20sets","name":"collections/admin sets","color":"0b02e1","default":false},{"id":503705298,"url":"https://api.github.com/repos/samvera-labs/hyrax/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"randalldfloyd","id":6411186,"avatar_url":"https://avatars1.githubusercontent.com/u/6411186?v=3","gravatar_id":"","url":"https://api.github.com/users/randalldfloyd","html_url":"https://github.com/randalldfloyd","followers_url":"https://api.github.com/users/randalldfloyd/followers","following_url":"https://api.github.com/users/randalldfloyd/following{/other_user}","gists_url":"https://api.github.com/users/randalldfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/randalldfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randalldfloyd/subscriptions","organizations_url":"https://api.github.com/users/randalldfloyd/orgs","repos_url":"https://api.github.com/users/randalldfloyd/repos","events_url":"https://api.github.com/users/randalldfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/randalldfloyd/received_events","type":"User","site_admin":false},"assignees":[{"login":"randalldfloyd","id":6411186,"avatar_url":"https://avatars1.githubusercontent.com/u/6411186?v=3","gravatar_id":"","url":"https://api.github.com/users/randalldfloyd","html_url":"https://github.com/randalldfloyd","followers_url":"https://api.github.com/users/randalldfloyd/followers","following_url":"https://api.github.com/users/randalldfloyd/following{/other_user}","gists_url":"https://api.github.com/users/randalldfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/randalldfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randalldfloyd/subscriptions","organizations_url":"https://api.github.com/users/randalldfloyd/orgs","repos_url":"https://api.github.com/users/randalldfloyd/repos","events_url":"https://api.github.com/users/randalldfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/randalldfloyd/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/samvera-labs/hyrax/milestones/2","html_url":"https://github.com/samvera-labs/hyrax/milestone/2","labels_url":"https://api.github.com/repos/samvera-labs/hyrax/milestones/2/labels","id":2210734,"number":2,"title":"2.0.0","description":"2.0.0 marks the first release of Hyrax that has a tested upgrade path from both Sufia 7.3.0 and CurationConcerns 2.0.0.\r\n\r\nIt may or may not also include features extracted via the plugin WG's recommendations.\r\n\r\nThis will probably have UI changes different from Sufia 7.","creator":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars3.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"open_issues":76,"closed_issues":110,"state":"open","created_at":"2016-12-21T19:47:40Z","updated_at":"2017-05-26T05:38:10Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-04-14T01:11:15Z","updated_at":"2017-05-26T15:47:14Z","closed_at":null,"body":"\r\n<img width=\"961\" alt=\"screen shot 2017-04-13 at 8 12 26 pm\" src=\"https://cloud.githubusercontent.com/assets/92044/25029728/98924f38-2085-11e7-9829-2c155a39ccab.png\">\r\n\r\nIt just shows the default admin set.\r\n<img width=\"579\" alt=\"screen shot 2017-04-13 at 8 10 57 pm\" src=\"https://cloud.githubusercontent.com/assets/92044/25029705/7121c7e4-2085-11e7-9b30-22f2e2859dcf.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/samvera-labs/hyrax/issues/comments/304317465","html_url":"https://github.com/samvera-labs/hyrax/issues/790#issuecomment-304317465","issue_url":"https://api.github.com/repos/samvera-labs/hyrax/issues/790","id":304317465,"user":{"login":"randalldfloyd","id":6411186,"avatar_url":"https://avatars1.githubusercontent.com/u/6411186?v=3","gravatar_id":"","url":"https://api.github.com/users/randalldfloyd","html_url":"https://github.com/randalldfloyd","followers_url":"https://api.github.com/users/randalldfloyd/followers","following_url":"https://api.github.com/users/randalldfloyd/following{/other_user}","gists_url":"https://api.github.com/users/randalldfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/randalldfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randalldfloyd/subscriptions","organizations_url":"https://api.github.com/users/randalldfloyd/orgs","repos_url":"https://api.github.com/users/randalldfloyd/repos","events_url":"https://api.github.com/users/randalldfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/randalldfloyd/received_events","type":"User","site_admin":false},"created_at":"2017-05-26T15:47:14Z","updated_at":"2017-05-26T15:47:14Z","body":"@mjgiarlo @jcoyne  I need a some guidance or opinions on this one...\r\n\r\nHere's the problem on this issue.  If user1 can enumerate files in an admin set and select one of them to be the representative thumbnail, then there's a pretty good chance that other users will not have ability to view the thumbnail (i.e. the file_set/files are private).  Those users therefore get the default image asset per the ability check and the thumbnail helper. As it turns out, being able to select the file while editing the admin set as user1 is actually no guarantee that user1 can even view the thumbnail, hence the behavior as described in this issue. \r\n\r\nSo, I was trying to approach this as an ability issue on the thumbnail rendering end, but really this is a problem of even being able to select a representative image that may not be public.  It seems like a design oversight. Either the admin set editor should not be able to assign non-public files, or there should be a bit of magic to render a nicer thumbnail representing an admin set instead of getting the ugly-too-big standin that Blacklight returns. Thoughts?"}}
{"actor":{"display_login":"randalldfloyd"}}