{"action":"created","comment":{"url":"https://api.github.com/repos/fommil/stalagmite/pulls/comments/133027663","pull_request_review_id":56164756,"id":133027663,"diff_hunk":"@@ -4,109 +4,134 @@ import org.openjdk.jmh.annotations.Benchmark\n \n import testing.meta._\n import testing.{ caseclass, memoised, optimiseheap, weakmemoised }\n-import scala.util.Random\n \n class CopyBenchmark {\n   import BenchmarkData._\n \n   // jmh:run -i 15 -wi 15 -f1 -t10 .*CopyBenchmark\n   // Benchmark                             Mode  Cnt    Score    Error  Units\n-  // CopyBenchmark.caseClass              thrpt   15  327.730 ± 18.481  ops/s\n-  // CopyBenchmark.caseClassMeta          thrpt   15  349.824 ±  4.059  ops/s\n-  // CopyBenchmark.caseClassSpec          thrpt   15  352.282 ±  2.965  ops/s\n-  // CopyBenchmark.memoisedCaseClass      thrpt   15  468.774 ± 23.296  ops/s\n-  // CopyBenchmark.memoisedMeta           thrpt   15  168.356 ± 15.942  ops/s\n-  // CopyBenchmark.memoisedSpec           thrpt   15  140.182 ±  7.951  ops/s\n-  // CopyBenchmark.memoisedWeak           thrpt   15  145.621 ± 23.489  ops/s\n-  // CopyBenchmark.optimizeHeapCaseClass  thrpt   15  786.416 ± 37.324  ops/s\n-  // CopyBenchmark.optimizeHeapMeta       thrpt   15  481.235 ±  6.521  ops/s\n-  // CopyBenchmark.optimizeHeapSpec       thrpt   15  469.321 ±  8.296  ops/s\n+  // CopyBenchmark.caseClass              thrpt   15  1152.476 ± 265.676  ops/s\n+  // CopyBenchmark.caseClassMeta          thrpt   15  1369.821 ±  58.396  ops/s","path":"bench/src/test/scala/fommil/stalagmite/benchmarks/CopyBenchmark.scala","position":null,"original_position":22,"commit_id":"fcfc98b4e34c3f52b8f3bd427fbc7913182151bf","original_commit_id":"fcfc98b4e34c3f52b8f3bd427fbc7913182151bf","user":{"login":"vovapolu","id":4629312,"avatar_url":"https://avatars3.githubusercontent.com/u/4629312?v=4","gravatar_id":"","url":"https://api.github.com/users/vovapolu","html_url":"https://github.com/vovapolu","followers_url":"https://api.github.com/users/vovapolu/followers","following_url":"https://api.github.com/users/vovapolu/following{/other_user}","gists_url":"https://api.github.com/users/vovapolu/gists{/gist_id}","starred_url":"https://api.github.com/users/vovapolu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vovapolu/subscriptions","organizations_url":"https://api.github.com/users/vovapolu/orgs","repos_url":"https://api.github.com/users/vovapolu/repos","events_url":"https://api.github.com/users/vovapolu/events{/privacy}","received_events_url":"https://api.github.com/users/vovapolu/received_events","type":"User","site_admin":false},"body":"Yep, they're already incorrect, since I changed data a little","created_at":"2017-08-14T18:37:54Z","updated_at":"2017-08-14T18:37:54Z","html_url":"https://github.com/fommil/stalagmite/pull/39#discussion_r133027663","pull_request_url":"https://api.github.com/repos/fommil/stalagmite/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/comments/133027663"},"html":{"href":"https://github.com/fommil/stalagmite/pull/39#discussion_r133027663"},"pull_request":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/fommil/stalagmite/pulls/39","id":134633985,"html_url":"https://github.com/fommil/stalagmite/pull/39","diff_url":"https://github.com/fommil/stalagmite/pull/39.diff","patch_url":"https://github.com/fommil/stalagmite/pull/39.patch","issue_url":"https://api.github.com/repos/fommil/stalagmite/issues/39","number":39,"state":"open","locked":false,"title":"Weak Memoisation and Benchmarks","user":{"login":"vovapolu","id":4629312,"avatar_url":"https://avatars3.githubusercontent.com/u/4629312?v=4","gravatar_id":"","url":"https://api.github.com/users/vovapolu","html_url":"https://github.com/vovapolu","followers_url":"https://api.github.com/users/vovapolu/followers","following_url":"https://api.github.com/users/vovapolu/following{/other_user}","gists_url":"https://api.github.com/users/vovapolu/gists{/gist_id}","starred_url":"https://api.github.com/users/vovapolu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vovapolu/subscriptions","organizations_url":"https://api.github.com/users/vovapolu/orgs","repos_url":"https://api.github.com/users/vovapolu/repos","events_url":"https://api.github.com/users/vovapolu/events{/privacy}","received_events_url":"https://api.github.com/users/vovapolu/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-08T11:08:37Z","updated_at":"2017-08-14T18:37:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adcc919c75e54ad58dd21b12529925ab3fa38daa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fommil/stalagmite/pulls/39/commits","review_comments_url":"https://api.github.com/repos/fommil/stalagmite/pulls/39/comments","review_comment_url":"https://api.github.com/repos/fommil/stalagmite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fommil/stalagmite/issues/39/comments","statuses_url":"https://api.github.com/repos/fommil/stalagmite/statuses/fcfc98b4e34c3f52b8f3bd427fbc7913182151bf","head":{"label":"vovapolu:master","ref":"master","sha":"fcfc98b4e34c3f52b8f3bd427fbc7913182151bf","user":{"login":"vovapolu","id":4629312,"avatar_url":"https://avatars3.githubusercontent.com/u/4629312?v=4","gravatar_id":"","url":"https://api.github.com/users/vovapolu","html_url":"https://github.com/vovapolu","followers_url":"https://api.github.com/users/vovapolu/followers","following_url":"https://api.github.com/users/vovapolu/following{/other_user}","gists_url":"https://api.github.com/users/vovapolu/gists{/gist_id}","starred_url":"https://api.github.com/users/vovapolu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vovapolu/subscriptions","organizations_url":"https://api.github.com/users/vovapolu/orgs","repos_url":"https://api.github.com/users/vovapolu/repos","events_url":"https://api.github.com/users/vovapolu/events{/privacy}","received_events_url":"https://api.github.com/users/vovapolu/received_events","type":"User","site_admin":false},"repo":{"id":93866659,"name":"scala-data-classes","full_name":"vovapolu/scala-data-classes","owner":{"login":"vovapolu","id":4629312,"avatar_url":"https://avatars3.githubusercontent.com/u/4629312?v=4","gravatar_id":"","url":"https://api.github.com/users/vovapolu","html_url":"https://github.com/vovapolu","followers_url":"https://api.github.com/users/vovapolu/followers","following_url":"https://api.github.com/users/vovapolu/following{/other_user}","gists_url":"https://api.github.com/users/vovapolu/gists{/gist_id}","starred_url":"https://api.github.com/users/vovapolu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vovapolu/subscriptions","organizations_url":"https://api.github.com/users/vovapolu/orgs","repos_url":"https://api.github.com/users/vovapolu/repos","events_url":"https://api.github.com/users/vovapolu/events{/privacy}","received_events_url":"https://api.github.com/users/vovapolu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vovapolu/scala-data-classes","description":"data classes a la carte","fork":true,"url":"https://api.github.com/repos/vovapolu/scala-data-classes","forks_url":"https://api.github.com/repos/vovapolu/scala-data-classes/forks","keys_url":"https://api.github.com/repos/vovapolu/scala-data-classes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vovapolu/scala-data-classes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vovapolu/scala-data-classes/teams","hooks_url":"https://api.github.com/repos/vovapolu/scala-data-classes/hooks","issue_events_url":"https://api.github.com/repos/vovapolu/scala-data-classes/issues/events{/number}","events_url":"https://api.github.com/repos/vovapolu/scala-data-classes/events","assignees_url":"https://api.github.com/repos/vovapolu/scala-data-classes/assignees{/user}","branches_url":"https://api.github.com/repos/vovapolu/scala-data-classes/branches{/branch}","tags_url":"https://api.github.com/repos/vovapolu/scala-data-classes/tags","blobs_url":"https://api.github.com/repos/vovapolu/scala-data-classes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vovapolu/scala-data-classes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vovapolu/scala-data-classes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vovapolu/scala-data-classes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vovapolu/scala-data-classes/statuses/{sha}","languages_url":"https://api.github.com/repos/vovapolu/scala-data-classes/languages","stargazers_url":"https://api.github.com/repos/vovapolu/scala-data-classes/stargazers","contributors_url":"https://api.github.com/repos/vovapolu/scala-data-classes/contributors","subscribers_url":"https://api.github.com/repos/vovapolu/scala-data-classes/subscribers","subscription_url":"https://api.github.com/repos/vovapolu/scala-data-classes/subscription","commits_url":"https://api.github.com/repos/vovapolu/scala-data-classes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vovapolu/scala-data-classes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vovapolu/scala-data-classes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vovapolu/scala-data-classes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vovapolu/scala-data-classes/contents/{+path}","compare_url":"https://api.github.com/repos/vovapolu/scala-data-classes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vovapolu/scala-data-classes/merges","archive_url":"https://api.github.com/repos/vovapolu/scala-data-classes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vovapolu/scala-data-classes/downloads","issues_url":"https://api.github.com/repos/vovapolu/scala-data-classes/issues{/number}","pulls_url":"https://api.github.com/repos/vovapolu/scala-data-classes/pulls{/number}","milestones_url":"https://api.github.com/repos/vovapolu/scala-data-classes/milestones{/number}","notifications_url":"https://api.github.com/repos/vovapolu/scala-data-classes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vovapolu/scala-data-classes/labels{/name}","releases_url":"https://api.github.com/repos/vovapolu/scala-data-classes/releases{/id}","deployments_url":"https://api.github.com/repos/vovapolu/scala-data-classes/deployments","created_at":"2017-06-09T14:25:14Z","updated_at":"2017-06-09T14:25:16Z","pushed_at":"2017-08-14T18:24:26Z","git_url":"git://github.com/vovapolu/scala-data-classes.git","ssh_url":"git@github.com:vovapolu/scala-data-classes.git","clone_url":"https://github.com/vovapolu/scala-data-classes.git","svn_url":"https://github.com/vovapolu/scala-data-classes","homepage":"","size":248,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fommil:master","ref":"master","sha":"7f2efa8b87796390a0451a04b778497e5168c4f6","user":{"login":"fommil","id":1914041,"avatar_url":"https://avatars2.githubusercontent.com/u/1914041?v=4","gravatar_id":"","url":"https://api.github.com/users/fommil","html_url":"https://github.com/fommil","followers_url":"https://api.github.com/users/fommil/followers","following_url":"https://api.github.com/users/fommil/following{/other_user}","gists_url":"https://api.github.com/users/fommil/gists{/gist_id}","starred_url":"https://api.github.com/users/fommil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fommil/subscriptions","organizations_url":"https://api.github.com/users/fommil/orgs","repos_url":"https://api.github.com/users/fommil/repos","events_url":"https://api.github.com/users/fommil/events{/privacy}","received_events_url":"https://api.github.com/users/fommil/received_events","type":"User","site_admin":false},"repo":{"id":84584507,"name":"stalagmite","full_name":"fommil/stalagmite","owner":{"login":"fommil","id":1914041,"avatar_url":"https://avatars2.githubusercontent.com/u/1914041?v=4","gravatar_id":"","url":"https://api.github.com/users/fommil","html_url":"https://github.com/fommil","followers_url":"https://api.github.com/users/fommil/followers","following_url":"https://api.github.com/users/fommil/following{/other_user}","gists_url":"https://api.github.com/users/fommil/gists{/gist_id}","starred_url":"https://api.github.com/users/fommil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fommil/subscriptions","organizations_url":"https://api.github.com/users/fommil/orgs","repos_url":"https://api.github.com/users/fommil/repos","events_url":"https://api.github.com/users/fommil/events{/privacy}","received_events_url":"https://api.github.com/users/fommil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fommil/stalagmite","description":"optimised alternative to case classes","fork":false,"url":"https://api.github.com/repos/fommil/stalagmite","forks_url":"https://api.github.com/repos/fommil/stalagmite/forks","keys_url":"https://api.github.com/repos/fommil/stalagmite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fommil/stalagmite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fommil/stalagmite/teams","hooks_url":"https://api.github.com/repos/fommil/stalagmite/hooks","issue_events_url":"https://api.github.com/repos/fommil/stalagmite/issues/events{/number}","events_url":"https://api.github.com/repos/fommil/stalagmite/events","assignees_url":"https://api.github.com/repos/fommil/stalagmite/assignees{/user}","branches_url":"https://api.github.com/repos/fommil/stalagmite/branches{/branch}","tags_url":"https://api.github.com/repos/fommil/stalagmite/tags","blobs_url":"https://api.github.com/repos/fommil/stalagmite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fommil/stalagmite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fommil/stalagmite/git/refs{/sha}","trees_url":"https://api.github.com/repos/fommil/stalagmite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fommil/stalagmite/statuses/{sha}","languages_url":"https://api.github.com/repos/fommil/stalagmite/languages","stargazers_url":"https://api.github.com/repos/fommil/stalagmite/stargazers","contributors_url":"https://api.github.com/repos/fommil/stalagmite/contributors","subscribers_url":"https://api.github.com/repos/fommil/stalagmite/subscribers","subscription_url":"https://api.github.com/repos/fommil/stalagmite/subscription","commits_url":"https://api.github.com/repos/fommil/stalagmite/commits{/sha}","git_commits_url":"https://api.github.com/repos/fommil/stalagmite/git/commits{/sha}","comments_url":"https://api.github.com/repos/fommil/stalagmite/comments{/number}","issue_comment_url":"https://api.github.com/repos/fommil/stalagmite/issues/comments{/number}","contents_url":"https://api.github.com/repos/fommil/stalagmite/contents/{+path}","compare_url":"https://api.github.com/repos/fommil/stalagmite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fommil/stalagmite/merges","archive_url":"https://api.github.com/repos/fommil/stalagmite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fommil/stalagmite/downloads","issues_url":"https://api.github.com/repos/fommil/stalagmite/issues{/number}","pulls_url":"https://api.github.com/repos/fommil/stalagmite/pulls{/number}","milestones_url":"https://api.github.com/repos/fommil/stalagmite/milestones{/number}","notifications_url":"https://api.github.com/repos/fommil/stalagmite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fommil/stalagmite/labels{/name}","releases_url":"https://api.github.com/repos/fommil/stalagmite/releases{/id}","deployments_url":"https://api.github.com/repos/fommil/stalagmite/deployments","created_at":"2017-03-10T17:28:31Z","updated_at":"2017-08-10T01:48:01Z","pushed_at":"2017-08-14T18:24:27Z","git_url":"git://github.com/fommil/stalagmite.git","ssh_url":"git@github.com:fommil/stalagmite.git","clone_url":"https://github.com/fommil/stalagmite.git","svn_url":"https://github.com/fommil/stalagmite","homepage":"","size":123,"stargazers_count":49,"watchers_count":49,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":27,"forks":3,"open_issues":27,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/39"},"html":{"href":"https://github.com/fommil/stalagmite/pull/39"},"issue":{"href":"https://api.github.com/repos/fommil/stalagmite/issues/39"},"comments":{"href":"https://api.github.com/repos/fommil/stalagmite/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fommil/stalagmite/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/fommil/stalagmite/statuses/fcfc98b4e34c3f52b8f3bd427fbc7913182151bf"}}}}
{"actor":{"display_login":"vovapolu"}}