{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/155468306","pull_request_review_id":81790124,"id":155468306,"diff_hunk":"@@ -499,6 +499,46 @@\n             });\n         },\n         isArray: isArray,\n-        template: template\n+        template: template,\n+        parseVersionString: function(versionString){\n+            var _sp = versionString.split('.');\n+            return {\n+                major: parseInt(_sp[0].replace('v','')),\n+                minor: parseInt(_sp[1]),\n+                patch: parseInt(_sp[2].split('-')[0]),\n+            };\n+        },\n+        retrofit_114_serialization: function(state,replacement_version) {\n+            replacement_version = !replacement_version || replacement_version === '1.14.2-dev' ? '1.18.0' : replacement_version;\n+            if(!state.__version)return state;\n+            var state_version_obj = this.parseVersionString(state.__version);\n+            var target_version_obj = this.parseVersionString(replacement_version);\n+            if(state_version_obj.major === 1 && state_version_obj.minor === 14){\n+                console.log(\"Upgrading old persist from \"+state.__version+\" to \"+replacement_version);\n+                var _json_str = JSON.stringify(state);\n+                _json_str = _json_str.split('\"'+state.__version).join('\"'+replacement_version);\n+    \n+                var ret_obj = JSON.parse(_json_str);","path":"src/common/Utility.js","position":24,"original_position":24,"commit_id":"6f64922d2223f40046d99dc69d97cab657ad8a03","original_commit_id":"6f64922d2223f40046d99dc69d97cab657ad8a03","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars2.githubusercontent.com/u/966863?v=4","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"Not sure I would have done it that way, but rather walked (visited) the structure and changed the version per item (and then testing for \"graph_Graph\" at the same time.\r\n\r\nYou could also abort early at the first instance of a version > 1.14","created_at":"2017-12-07T09:29:00Z","updated_at":"2017-12-07T09:29:00Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/2326#discussion_r155468306","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/155468306"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/2326#discussion_r155468306"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326","id":154196663,"html_url":"https://github.com/hpcc-systems/Visualization/pull/2326","diff_url":"https://github.com/hpcc-systems/Visualization/pull/2326.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/2326.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/2326","number":2326,"state":"open","locked":false,"title":"GH-2322 Adds 114 to 118 retrofit logic to loader","user":{"login":"jbrundage","id":1891935,"avatar_url":"https://avatars3.githubusercontent.com/u/1891935?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrundage","html_url":"https://github.com/jbrundage","followers_url":"https://api.github.com/users/jbrundage/followers","following_url":"https://api.github.com/users/jbrundage/following{/other_user}","gists_url":"https://api.github.com/users/jbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrundage/subscriptions","organizations_url":"https://api.github.com/users/jbrundage/orgs","repos_url":"https://api.github.com/users/jbrundage/repos","events_url":"https://api.github.com/users/jbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/jbrundage/received_events","type":"User","site_admin":false},"body":"Fixes GH-2322\r\n\r\n@GordonSmith please review","created_at":"2017-11-22T16:16:01Z","updated_at":"2017-12-07T09:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5590379e87b13ffa144cb960acd4640fc879713","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/2326/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/6f64922d2223f40046d99dc69d97cab657ad8a03","head":{"label":"jbrundage:GH2322_b","ref":"GH2322_b","sha":"6f64922d2223f40046d99dc69d97cab657ad8a03","user":{"login":"jbrundage","id":1891935,"avatar_url":"https://avatars3.githubusercontent.com/u/1891935?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrundage","html_url":"https://github.com/jbrundage","followers_url":"https://api.github.com/users/jbrundage/followers","following_url":"https://api.github.com/users/jbrundage/following{/other_user}","gists_url":"https://api.github.com/users/jbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrundage/subscriptions","organizations_url":"https://api.github.com/users/jbrundage/orgs","repos_url":"https://api.github.com/users/jbrundage/repos","events_url":"https://api.github.com/users/jbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/jbrundage/received_events","type":"User","site_admin":false},"repo":{"id":30040848,"name":"Visualization","full_name":"jbrundage/Visualization","owner":{"login":"jbrundage","id":1891935,"avatar_url":"https://avatars3.githubusercontent.com/u/1891935?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrundage","html_url":"https://github.com/jbrundage","followers_url":"https://api.github.com/users/jbrundage/followers","following_url":"https://api.github.com/users/jbrundage/following{/other_user}","gists_url":"https://api.github.com/users/jbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrundage/subscriptions","organizations_url":"https://api.github.com/users/jbrundage/orgs","repos_url":"https://api.github.com/users/jbrundage/repos","events_url":"https://api.github.com/users/jbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/jbrundage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbrundage/Visualization","description":"Common Visualization Components","fork":true,"url":"https://api.github.com/repos/jbrundage/Visualization","forks_url":"https://api.github.com/repos/jbrundage/Visualization/forks","keys_url":"https://api.github.com/repos/jbrundage/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrundage/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrundage/Visualization/teams","hooks_url":"https://api.github.com/repos/jbrundage/Visualization/hooks","issue_events_url":"https://api.github.com/repos/jbrundage/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/jbrundage/Visualization/events","assignees_url":"https://api.github.com/repos/jbrundage/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/jbrundage/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/jbrundage/Visualization/tags","blobs_url":"https://api.github.com/repos/jbrundage/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrundage/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrundage/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrundage/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrundage/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrundage/Visualization/languages","stargazers_url":"https://api.github.com/repos/jbrundage/Visualization/stargazers","contributors_url":"https://api.github.com/repos/jbrundage/Visualization/contributors","subscribers_url":"https://api.github.com/repos/jbrundage/Visualization/subscribers","subscription_url":"https://api.github.com/repos/jbrundage/Visualization/subscription","commits_url":"https://api.github.com/repos/jbrundage/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrundage/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrundage/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrundage/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrundage/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/jbrundage/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrundage/Visualization/merges","archive_url":"https://api.github.com/repos/jbrundage/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrundage/Visualization/downloads","issues_url":"https://api.github.com/repos/jbrundage/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/jbrundage/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrundage/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrundage/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrundage/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/jbrundage/Visualization/releases{/id}","deployments_url":"https://api.github.com/repos/jbrundage/Visualization/deployments","created_at":"2015-01-29T20:55:48Z","updated_at":"2015-04-06T14:57:29Z","pushed_at":"2017-12-06T22:17:50Z","git_url":"git://github.com/jbrundage/Visualization.git","ssh_url":"git@github.com:jbrundage/Visualization.git","clone_url":"https://github.com/jbrundage/Visualization.git","svn_url":"https://github.com/jbrundage/Visualization","homepage":"","size":13500,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-1.20.x","ref":"candidate-1.20.x","sha":"072d2181c9525621bb7dc75b4a5e0f710a384fcf","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"HPCC Visualization Framework","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/Visualization/deployments","created_at":"2014-07-22T19:13:04Z","updated_at":"2017-11-21T17:10:31Z","pushed_at":"2017-12-06T22:17:51Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"http://rawgit.com/hpcc-systems/Visualization/master/demos/dermatology.html","size":25196,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":48,"open_issues":66,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/2326"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/2326"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/2326/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/2326/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/6f64922d2223f40046d99dc69d97cab657ad8a03"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GordonSmith"}}