{"action":"created","comment":{"url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/comments/149441683","pull_request_review_id":74833529,"id":149441683,"diff_hunk":"@@ -0,0 +1,108 @@\n+package com.nordstrom.xrpc.http;\n+\n+import io.netty.buffer.ByteBuf;\n+import io.netty.channel.ChannelHandlerContext;\n+import io.netty.handler.codec.http2.DefaultHttp2DataFrame;\n+import io.netty.handler.codec.http2.Http2Exception;\n+import io.netty.handler.codec.http2.Http2Flags;\n+import io.netty.handler.codec.http2.Http2FrameListener;\n+import io.netty.handler.codec.http2.Http2Headers;\n+import io.netty.handler.codec.http2.Http2Settings;\n+\n+/**\n+ * Forwards the frame with stream id to the next handler in the pipeline\n+ */\n+public class Http2FrameForwarder implements Http2FrameListener {\n+\n+  private final boolean isServer;\n+\n+  public Http2FrameForwarder(boolean isServer) {","path":"src/main/java/com/nordstrom/xrpc/http/Http2FrameForwarder.java","position":19,"original_position":19,"commit_id":"a2eace446fe13628d4b9858775d716b4bead6448","original_commit_id":"a2eace446fe13628d4b9858775d716b4bead6448","user":{"login":"jkinkead","id":1548392,"avatar_url":"https://avatars3.githubusercontent.com/u/1548392?v=4","gravatar_id":"","url":"https://api.github.com/users/jkinkead","html_url":"https://github.com/jkinkead","followers_url":"https://api.github.com/users/jkinkead/followers","following_url":"https://api.github.com/users/jkinkead/following{/other_user}","gists_url":"https://api.github.com/users/jkinkead/gists{/gist_id}","starred_url":"https://api.github.com/users/jkinkead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkinkead/subscriptions","organizations_url":"https://api.github.com/users/jkinkead/orgs","repos_url":"https://api.github.com/users/jkinkead/repos","events_url":"https://api.github.com/users/jkinkead/events{/privacy}","received_events_url":"https://api.github.com/users/jkinkead/received_events","type":"User","site_admin":false},"body":"Document parameter / member? It's not obvious what this means.","created_at":"2017-11-07T17:16:50Z","updated_at":"2017-11-07T17:27:05Z","html_url":"https://github.com/Nordstrom/xrpc/pull/21#discussion_r149441683","pull_request_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/comments/149441683"},"html":{"href":"https://github.com/Nordstrom/xrpc/pull/21#discussion_r149441683"},"pull_request":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21","id":151026878,"html_url":"https://github.com/Nordstrom/xrpc/pull/21","diff_url":"https://github.com/Nordstrom/xrpc/pull/21.diff","patch_url":"https://github.com/Nordstrom/xrpc/pull/21.patch","issue_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/21","number":21,"state":"open","locked":false,"title":"Add Http/2 Server","user":{"login":"xjdr","id":2508631,"avatar_url":"https://avatars3.githubusercontent.com/u/2508631?v=4","gravatar_id":"","url":"https://api.github.com/users/xjdr","html_url":"https://github.com/xjdr","followers_url":"https://api.github.com/users/xjdr/followers","following_url":"https://api.github.com/users/xjdr/following{/other_user}","gists_url":"https://api.github.com/users/xjdr/gists{/gist_id}","starred_url":"https://api.github.com/users/xjdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjdr/subscriptions","organizations_url":"https://api.github.com/users/xjdr/orgs","repos_url":"https://api.github.com/users/xjdr/repos","events_url":"https://api.github.com/users/xjdr/events{/privacy}","received_events_url":"https://api.github.com/users/xjdr/received_events","type":"User","site_admin":false},"body":"This is a basic implementation of Http/2 which will auto-negotiate and\r\nshould return the same value for Http/1.1 and Http/2 requests. This commit\r\ndoes not handle anything in the request body as of yet but is a good\r\nstarting point.","created_at":"2017-11-07T05:16:45Z","updated_at":"2017-11-07T17:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"050e07349c3ff59bd3f4b81c7041d47cf120fecb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/21/comments","statuses_url":"https://api.github.com/repos/Nordstrom/xrpc/statuses/a2eace446fe13628d4b9858775d716b4bead6448","head":{"label":"Nordstrom:http2","ref":"http2","sha":"a2eace446fe13628d4b9858775d716b4bead6448","user":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"repo":{"id":107729923,"name":"xrpc","full_name":"Nordstrom/xrpc","owner":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nordstrom/xrpc","description":"Simple, production ready Java API server built on top of functional composition.","fork":false,"url":"https://api.github.com/repos/Nordstrom/xrpc","forks_url":"https://api.github.com/repos/Nordstrom/xrpc/forks","keys_url":"https://api.github.com/repos/Nordstrom/xrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nordstrom/xrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nordstrom/xrpc/teams","hooks_url":"https://api.github.com/repos/Nordstrom/xrpc/hooks","issue_events_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/events{/number}","events_url":"https://api.github.com/repos/Nordstrom/xrpc/events","assignees_url":"https://api.github.com/repos/Nordstrom/xrpc/assignees{/user}","branches_url":"https://api.github.com/repos/Nordstrom/xrpc/branches{/branch}","tags_url":"https://api.github.com/repos/Nordstrom/xrpc/tags","blobs_url":"https://api.github.com/repos/Nordstrom/xrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nordstrom/xrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nordstrom/xrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nordstrom/xrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nordstrom/xrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/Nordstrom/xrpc/languages","stargazers_url":"https://api.github.com/repos/Nordstrom/xrpc/stargazers","contributors_url":"https://api.github.com/repos/Nordstrom/xrpc/contributors","subscribers_url":"https://api.github.com/repos/Nordstrom/xrpc/subscribers","subscription_url":"https://api.github.com/repos/Nordstrom/xrpc/subscription","commits_url":"https://api.github.com/repos/Nordstrom/xrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nordstrom/xrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nordstrom/xrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nordstrom/xrpc/contents/{+path}","compare_url":"https://api.github.com/repos/Nordstrom/xrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nordstrom/xrpc/merges","archive_url":"https://api.github.com/repos/Nordstrom/xrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nordstrom/xrpc/downloads","issues_url":"https://api.github.com/repos/Nordstrom/xrpc/issues{/number}","pulls_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/Nordstrom/xrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/Nordstrom/xrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nordstrom/xrpc/labels{/name}","releases_url":"https://api.github.com/repos/Nordstrom/xrpc/releases{/id}","deployments_url":"https://api.github.com/repos/Nordstrom/xrpc/deployments","created_at":"2017-10-20T21:52:54Z","updated_at":"2017-10-20T21:56:50Z","pushed_at":"2017-11-07T05:16:45Z","git_url":"git://github.com/Nordstrom/xrpc.git","ssh_url":"git@github.com:Nordstrom/xrpc.git","clone_url":"https://github.com/Nordstrom/xrpc.git","svn_url":"https://github.com/Nordstrom/xrpc","homepage":null,"size":6821,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Nordstrom:master","ref":"master","sha":"7fa0f0b90b0ebd409ecdbd5b3f8e230805070108","user":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"repo":{"id":107729923,"name":"xrpc","full_name":"Nordstrom/xrpc","owner":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nordstrom/xrpc","description":"Simple, production ready Java API server built on top of functional composition.","fork":false,"url":"https://api.github.com/repos/Nordstrom/xrpc","forks_url":"https://api.github.com/repos/Nordstrom/xrpc/forks","keys_url":"https://api.github.com/repos/Nordstrom/xrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nordstrom/xrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nordstrom/xrpc/teams","hooks_url":"https://api.github.com/repos/Nordstrom/xrpc/hooks","issue_events_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/events{/number}","events_url":"https://api.github.com/repos/Nordstrom/xrpc/events","assignees_url":"https://api.github.com/repos/Nordstrom/xrpc/assignees{/user}","branches_url":"https://api.github.com/repos/Nordstrom/xrpc/branches{/branch}","tags_url":"https://api.github.com/repos/Nordstrom/xrpc/tags","blobs_url":"https://api.github.com/repos/Nordstrom/xrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nordstrom/xrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nordstrom/xrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nordstrom/xrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nordstrom/xrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/Nordstrom/xrpc/languages","stargazers_url":"https://api.github.com/repos/Nordstrom/xrpc/stargazers","contributors_url":"https://api.github.com/repos/Nordstrom/xrpc/contributors","subscribers_url":"https://api.github.com/repos/Nordstrom/xrpc/subscribers","subscription_url":"https://api.github.com/repos/Nordstrom/xrpc/subscription","commits_url":"https://api.github.com/repos/Nordstrom/xrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nordstrom/xrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nordstrom/xrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nordstrom/xrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nordstrom/xrpc/contents/{+path}","compare_url":"https://api.github.com/repos/Nordstrom/xrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nordstrom/xrpc/merges","archive_url":"https://api.github.com/repos/Nordstrom/xrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nordstrom/xrpc/downloads","issues_url":"https://api.github.com/repos/Nordstrom/xrpc/issues{/number}","pulls_url":"https://api.github.com/repos/Nordstrom/xrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/Nordstrom/xrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/Nordstrom/xrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nordstrom/xrpc/labels{/name}","releases_url":"https://api.github.com/repos/Nordstrom/xrpc/releases{/id}","deployments_url":"https://api.github.com/repos/Nordstrom/xrpc/deployments","created_at":"2017-10-20T21:52:54Z","updated_at":"2017-10-20T21:56:50Z","pushed_at":"2017-11-07T05:16:45Z","git_url":"git://github.com/Nordstrom/xrpc.git","ssh_url":"git@github.com:Nordstrom/xrpc.git","clone_url":"https://github.com/Nordstrom/xrpc.git","svn_url":"https://github.com/Nordstrom/xrpc","homepage":null,"size":6821,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21"},"html":{"href":"https://github.com/Nordstrom/xrpc/pull/21"},"issue":{"href":"https://api.github.com/repos/Nordstrom/xrpc/issues/21"},"comments":{"href":"https://api.github.com/repos/Nordstrom/xrpc/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nordstrom/xrpc/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Nordstrom/xrpc/statuses/a2eace446fe13628d4b9858775d716b4bead6448"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jkinkead"}}