{"action":"created","comment":{"url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/comments/125816856","pull_request_review_id":48240837,"id":125816856,"diff_hunk":"@@ -4,14 +4,18 @@ import LeafletMap from './LeafletMap'\n import Locator from './Locator'\n \n export default class Map extends Component {\n-  render() {\n-    const { user, addresses, selectedAddress, coords, fullscreen, displayAddress, closeMenu } = this.props\n+\n+  componentDidUpdate() {\n     if (this.leafletMap) this.leafletMap.forceUpdate()\n+  }\n+\n+  render() {\n+    const { userToken, addresses, selectedAddress, coords, fullscreen, displayAddress, closeMenu } = this.props\n \n     return (\n       <div>\n-        <LeafletMap ref={ref => this.leafletMap = ref} user={user} addresses={addresses} selectedAddress={selectedAddress} displayAddress={displayAddress} onCloseMenu={closeMenu} coords={coords} fullscreen={fullscreen} />\n-        {!selectedAddress ? <Locator accuracy={coords.accuracy} fullscreen={fullscreen} /> : null}\n+        <LeafletMap ref={ref => this.leafletMap = ref} userToken={userToken} addresses={addresses} selectedAddress={selectedAddress} displayAddress={displayAddress} onCloseMenu={closeMenu} coords={coords} fullscreen={fullscreen} />\n+        <Locator accuracy={coords.accuracy} fullscreen={fullscreen} display={!selectedAddress} />","path":"front/src/Map.js","position":19,"original_position":19,"commit_id":"3443b5ee550c37d55295e9699a69a1adab29798d","original_commit_id":"3443b5ee550c37d55295e9699a69a1adab29798d","user":{"login":"tmerlier","id":7040549,"avatar_url":"https://avatars3.githubusercontent.com/u/7040549?v=3","gravatar_id":"","url":"https://api.github.com/users/tmerlier","html_url":"https://github.com/tmerlier","followers_url":"https://api.github.com/users/tmerlier/followers","following_url":"https://api.github.com/users/tmerlier/following{/other_user}","gists_url":"https://api.github.com/users/tmerlier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmerlier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmerlier/subscriptions","organizations_url":"https://api.github.com/users/tmerlier/orgs","repos_url":"https://api.github.com/users/tmerlier/repos","events_url":"https://api.github.com/users/tmerlier/events{/privacy}","received_events_url":"https://api.github.com/users/tmerlier/received_events","type":"User","site_admin":false},"body":"Pour ce projet il est assez fréquent d'afficher un composant ou non en fonction d'un `booléen`. À terme, je trouve que ça nuit à la lecture du `render`.","created_at":"2017-07-06T06:00:42Z","updated_at":"2017-07-06T06:00:42Z","html_url":"https://github.com/etalab/contribution-adresse/pull/41#discussion_r125816856","pull_request_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/comments/125816856"},"html":{"href":"https://github.com/etalab/contribution-adresse/pull/41#discussion_r125816856"},"pull_request":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41","id":127462261,"html_url":"https://github.com/etalab/contribution-adresse/pull/41","diff_url":"https://github.com/etalab/contribution-adresse/pull/41.diff","patch_url":"https://github.com/etalab/contribution-adresse/pull/41.patch","issue_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/41","number":41,"state":"open","locked":false,"title":"Corrections mineurs sur la carte","user":{"login":"tmerlier","id":7040549,"avatar_url":"https://avatars3.githubusercontent.com/u/7040549?v=3","gravatar_id":"","url":"https://api.github.com/users/tmerlier","html_url":"https://github.com/tmerlier","followers_url":"https://api.github.com/users/tmerlier/followers","following_url":"https://api.github.com/users/tmerlier/following{/other_user}","gists_url":"https://api.github.com/users/tmerlier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmerlier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmerlier/subscriptions","organizations_url":"https://api.github.com/users/tmerlier/orgs","repos_url":"https://api.github.com/users/tmerlier/repos","events_url":"https://api.github.com/users/tmerlier/events{/privacy}","received_events_url":"https://api.github.com/users/tmerlier/received_events","type":"User","site_admin":false},"body":"- Le curseur de l'utilisateur s'affiche lors de la création d'adresse\r\n- La carte s'actualise correctement\r\n- Et quelques autres améliorations mineurs...\r\n\r\n**/ ! \\ Cette branche est basé sur la PR #40 Refonte du formulaire d'adresses.**","created_at":"2017-06-26T12:45:21Z","updated_at":"2017-07-06T06:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a4a19d4b8a7dbe800da2aba4c41935d647e7061","assignee":{"login":"tmerlier","id":7040549,"avatar_url":"https://avatars3.githubusercontent.com/u/7040549?v=3","gravatar_id":"","url":"https://api.github.com/users/tmerlier","html_url":"https://github.com/tmerlier","followers_url":"https://api.github.com/users/tmerlier/followers","following_url":"https://api.github.com/users/tmerlier/following{/other_user}","gists_url":"https://api.github.com/users/tmerlier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmerlier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmerlier/subscriptions","organizations_url":"https://api.github.com/users/tmerlier/orgs","repos_url":"https://api.github.com/users/tmerlier/repos","events_url":"https://api.github.com/users/tmerlier/events{/privacy}","received_events_url":"https://api.github.com/users/tmerlier/received_events","type":"User","site_admin":false},"assignees":[{"login":"tmerlier","id":7040549,"avatar_url":"https://avatars3.githubusercontent.com/u/7040549?v=3","gravatar_id":"","url":"https://api.github.com/users/tmerlier","html_url":"https://github.com/tmerlier","followers_url":"https://api.github.com/users/tmerlier/followers","following_url":"https://api.github.com/users/tmerlier/following{/other_user}","gists_url":"https://api.github.com/users/tmerlier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmerlier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmerlier/subscriptions","organizations_url":"https://api.github.com/users/tmerlier/orgs","repos_url":"https://api.github.com/users/tmerlier/repos","events_url":"https://api.github.com/users/tmerlier/events{/privacy}","received_events_url":"https://api.github.com/users/tmerlier/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41/commits","review_comments_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41/comments","review_comment_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/41/comments","statuses_url":"https://api.github.com/repos/etalab/contribution-adresse/statuses/3443b5ee550c37d55295e9699a69a1adab29798d","head":{"label":"etalab:map-and-locator","ref":"map-and-locator","sha":"3443b5ee550c37d55295e9699a69a1adab29798d","user":{"login":"etalab","id":5313610,"avatar_url":"https://avatars2.githubusercontent.com/u/5313610?v=3","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"repo":{"id":90990169,"name":"contribution-adresse","full_name":"etalab/contribution-adresse","owner":{"login":"etalab","id":5313610,"avatar_url":"https://avatars2.githubusercontent.com/u/5313610?v=3","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etalab/contribution-adresse","description":"Outil de contribution citoyenne aux référentiels d'adresses","fork":false,"url":"https://api.github.com/repos/etalab/contribution-adresse","forks_url":"https://api.github.com/repos/etalab/contribution-adresse/forks","keys_url":"https://api.github.com/repos/etalab/contribution-adresse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etalab/contribution-adresse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etalab/contribution-adresse/teams","hooks_url":"https://api.github.com/repos/etalab/contribution-adresse/hooks","issue_events_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/events{/number}","events_url":"https://api.github.com/repos/etalab/contribution-adresse/events","assignees_url":"https://api.github.com/repos/etalab/contribution-adresse/assignees{/user}","branches_url":"https://api.github.com/repos/etalab/contribution-adresse/branches{/branch}","tags_url":"https://api.github.com/repos/etalab/contribution-adresse/tags","blobs_url":"https://api.github.com/repos/etalab/contribution-adresse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etalab/contribution-adresse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etalab/contribution-adresse/git/refs{/sha}","trees_url":"https://api.github.com/repos/etalab/contribution-adresse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etalab/contribution-adresse/statuses/{sha}","languages_url":"https://api.github.com/repos/etalab/contribution-adresse/languages","stargazers_url":"https://api.github.com/repos/etalab/contribution-adresse/stargazers","contributors_url":"https://api.github.com/repos/etalab/contribution-adresse/contributors","subscribers_url":"https://api.github.com/repos/etalab/contribution-adresse/subscribers","subscription_url":"https://api.github.com/repos/etalab/contribution-adresse/subscription","commits_url":"https://api.github.com/repos/etalab/contribution-adresse/commits{/sha}","git_commits_url":"https://api.github.com/repos/etalab/contribution-adresse/git/commits{/sha}","comments_url":"https://api.github.com/repos/etalab/contribution-adresse/comments{/number}","issue_comment_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/comments{/number}","contents_url":"https://api.github.com/repos/etalab/contribution-adresse/contents/{+path}","compare_url":"https://api.github.com/repos/etalab/contribution-adresse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etalab/contribution-adresse/merges","archive_url":"https://api.github.com/repos/etalab/contribution-adresse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etalab/contribution-adresse/downloads","issues_url":"https://api.github.com/repos/etalab/contribution-adresse/issues{/number}","pulls_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls{/number}","milestones_url":"https://api.github.com/repos/etalab/contribution-adresse/milestones{/number}","notifications_url":"https://api.github.com/repos/etalab/contribution-adresse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etalab/contribution-adresse/labels{/name}","releases_url":"https://api.github.com/repos/etalab/contribution-adresse/releases{/id}","deployments_url":"https://api.github.com/repos/etalab/contribution-adresse/deployments","created_at":"2017-05-11T14:44:12Z","updated_at":"2017-07-05T08:27:49Z","pushed_at":"2017-07-05T19:23:29Z","git_url":"git://github.com/etalab/contribution-adresse.git","ssh_url":"git@github.com:etalab/contribution-adresse.git","clone_url":"https://github.com/etalab/contribution-adresse.git","svn_url":"https://github.com/etalab/contribution-adresse","homepage":"https://contribution-adresse.herokuapp.com","size":426,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"etalab:master","ref":"master","sha":"45eba135ef72196f06d7f7b9d8b272cc99894b83","user":{"login":"etalab","id":5313610,"avatar_url":"https://avatars2.githubusercontent.com/u/5313610?v=3","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"repo":{"id":90990169,"name":"contribution-adresse","full_name":"etalab/contribution-adresse","owner":{"login":"etalab","id":5313610,"avatar_url":"https://avatars2.githubusercontent.com/u/5313610?v=3","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etalab/contribution-adresse","description":"Outil de contribution citoyenne aux référentiels d'adresses","fork":false,"url":"https://api.github.com/repos/etalab/contribution-adresse","forks_url":"https://api.github.com/repos/etalab/contribution-adresse/forks","keys_url":"https://api.github.com/repos/etalab/contribution-adresse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etalab/contribution-adresse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etalab/contribution-adresse/teams","hooks_url":"https://api.github.com/repos/etalab/contribution-adresse/hooks","issue_events_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/events{/number}","events_url":"https://api.github.com/repos/etalab/contribution-adresse/events","assignees_url":"https://api.github.com/repos/etalab/contribution-adresse/assignees{/user}","branches_url":"https://api.github.com/repos/etalab/contribution-adresse/branches{/branch}","tags_url":"https://api.github.com/repos/etalab/contribution-adresse/tags","blobs_url":"https://api.github.com/repos/etalab/contribution-adresse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etalab/contribution-adresse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etalab/contribution-adresse/git/refs{/sha}","trees_url":"https://api.github.com/repos/etalab/contribution-adresse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etalab/contribution-adresse/statuses/{sha}","languages_url":"https://api.github.com/repos/etalab/contribution-adresse/languages","stargazers_url":"https://api.github.com/repos/etalab/contribution-adresse/stargazers","contributors_url":"https://api.github.com/repos/etalab/contribution-adresse/contributors","subscribers_url":"https://api.github.com/repos/etalab/contribution-adresse/subscribers","subscription_url":"https://api.github.com/repos/etalab/contribution-adresse/subscription","commits_url":"https://api.github.com/repos/etalab/contribution-adresse/commits{/sha}","git_commits_url":"https://api.github.com/repos/etalab/contribution-adresse/git/commits{/sha}","comments_url":"https://api.github.com/repos/etalab/contribution-adresse/comments{/number}","issue_comment_url":"https://api.github.com/repos/etalab/contribution-adresse/issues/comments{/number}","contents_url":"https://api.github.com/repos/etalab/contribution-adresse/contents/{+path}","compare_url":"https://api.github.com/repos/etalab/contribution-adresse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etalab/contribution-adresse/merges","archive_url":"https://api.github.com/repos/etalab/contribution-adresse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etalab/contribution-adresse/downloads","issues_url":"https://api.github.com/repos/etalab/contribution-adresse/issues{/number}","pulls_url":"https://api.github.com/repos/etalab/contribution-adresse/pulls{/number}","milestones_url":"https://api.github.com/repos/etalab/contribution-adresse/milestones{/number}","notifications_url":"https://api.github.com/repos/etalab/contribution-adresse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etalab/contribution-adresse/labels{/name}","releases_url":"https://api.github.com/repos/etalab/contribution-adresse/releases{/id}","deployments_url":"https://api.github.com/repos/etalab/contribution-adresse/deployments","created_at":"2017-05-11T14:44:12Z","updated_at":"2017-07-05T08:27:49Z","pushed_at":"2017-07-05T19:23:29Z","git_url":"git://github.com/etalab/contribution-adresse.git","ssh_url":"git@github.com:etalab/contribution-adresse.git","clone_url":"https://github.com/etalab/contribution-adresse.git","svn_url":"https://github.com/etalab/contribution-adresse","homepage":"https://contribution-adresse.herokuapp.com","size":426,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41"},"html":{"href":"https://github.com/etalab/contribution-adresse/pull/41"},"issue":{"href":"https://api.github.com/repos/etalab/contribution-adresse/issues/41"},"comments":{"href":"https://api.github.com/repos/etalab/contribution-adresse/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etalab/contribution-adresse/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/etalab/contribution-adresse/statuses/3443b5ee550c37d55295e9699a69a1adab29798d"}}}}
{"actor":{"display_login":"tmerlier"}}