{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/158283542","pull_request_review_id":85068572,"id":158283542,"diff_hunk":"@@ -58,8 +59,7 @@ public override void OnStartConnect()\n             this.CurrentParameters.PeerAddressManagerBehaviour().Mode = PeerAddressManagerBehaviourMode.AdvertiseDiscover;\n         }\n \n-        /// <inheritdoc/>\n-        public override PeerAddress FindPeerToConnectTo()\n+        public async override Task OnConnectAsync()","path":"src/Stratis.Bitcoin/P2P/PeerConnectorDiscovery.cs","position":12,"original_position":12,"commit_id":"99e16374da52125bd0bda8490339b9f6715ee7bf","original_commit_id":"99e16374da52125bd0bda8490339b9f6715ee7bf","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"body":"Done 👍","created_at":"2017-12-21T14:00:55Z","updated_at":"2017-12-21T14:00:55Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970#discussion_r158283542","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/158283542"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970#discussion_r158283542"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970"}},"in_reply_to_id":158280696},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970","id":159645965,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/970","number":970,"state":"open","locked":false,"title":"[PeerConnectors] Fix connecting to multiple nodes when -addnode and -connect args are specfied and one peer fails.","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"body":"This fixes #967 .","created_at":"2017-12-21T12:27:58Z","updated_at":"2017-12-21T14:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9de3a4ca7a592db2ce6b406c5ca4ef5fb14b9439","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/970/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/99e16374da52125bd0bda8490339b9f6715ee7bf","head":{"label":"fassadlr:fix-peerconnector-addnode","ref":"fix-peerconnector-addnode","sha":"99e16374da52125bd0bda8490339b9f6715ee7bf","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"repo":{"id":102562819,"name":"StratisBitcoinFullNode","full_name":"fassadlr/StratisBitcoinFullNode","owner":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fassadlr/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/deployments","created_at":"2017-09-06T04:31:20Z","updated_at":"2017-09-06T04:31:22Z","pushed_at":"2017-12-21T13:55:22Z","git_url":"git://github.com/fassadlr/StratisBitcoinFullNode.git","ssh_url":"git@github.com:fassadlr/StratisBitcoinFullNode.git","clone_url":"https://github.com/fassadlr/StratisBitcoinFullNode.git","svn_url":"https://github.com/fassadlr/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":9493,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"eb641acabfd96d17d314a84b245d0117d0007eaa","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2017-12-21T12:16:00Z","pushed_at":"2017-12-21T12:32:07Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":13564,"stargazers_count":256,"watchers_count":256,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":118,"open_issues":89,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/970"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/970"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/970/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/970/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/99e16374da52125bd0bda8490339b9f6715ee7bf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fassadlr"}}