{"action":"opened","number":7462,"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/7462","id":133375688,"html_url":"https://github.com/nvaccess/nvda/pull/7462","diff_url":"https://github.com/nvaccess/nvda/pull/7462.diff","patch_url":"https://github.com/nvaccess/nvda/pull/7462.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/7462","number":7462,"state":"open","locked":false,"title":"Move sounds and images from miscDeps into the NVDA repository itself","user":{"login":"jcsteh","id":4166475,"avatar_url":"https://avatars1.githubusercontent.com/u/4166475?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsteh","html_url":"https://github.com/jcsteh","followers_url":"https://api.github.com/users/jcsteh/followers","following_url":"https://api.github.com/users/jcsteh/following{/other_user}","gists_url":"https://api.github.com/users/jcsteh/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsteh/subscriptions","organizations_url":"https://api.github.com/users/jcsteh/orgs","repos_url":"https://api.github.com/users/jcsteh/repos","events_url":"https://api.github.com/users/jcsteh/events{/privacy}","received_events_url":"https://api.github.com/users/jcsteh/received_events","type":"User","site_admin":false},"body":"### Link to issue number:\r\nNone specifically. However, this is required for #7446; see below.\r\n\r\n### Summary of the issue:\r\nWe've made (or considered) several updates to media lately, including the new suggestion open/close sounds (#6241), the new default sounds (#7218, although we decided not to go ahead with this) and the new icon (#7446). It's likely there will be more such updates in future. Updating miscDeps for these cases is tedious and error prone. Furthermore, sounds and images are specific to NVDA (i.e. they aren't dependencies) and are quite small, so having them in miscDeps doesn't make a great deal of sense.\r\n\r\n### Description of how this pull request fixes the issue:\r\n1. Adds source/waves and source/images to the NVDA repo.\r\n2. Removes them from miscDeps.\r\n\r\n### Testing performed:\r\n1. Ran locally and confirmed that sounds play.\r\n2. This is pretty much the same change as #7218, except with the old sounds instead of the proposed new ones. That change has been incubating on next for weeks with no problems.\r\n\r\n### Known issues with pull request:\r\nNone.\r\n\r\n### Change log entry:\r\nNone needed; related only to the repositories.\r\n\r\n### Merge notes:\r\n\r\nWe want to merge this straight to master:\r\n\r\n1. For #7446, we want to put the icon into the NVDA repo instead of miscDeps, so #7446 depends on this work. We want to get #7446 into 2017.3, so this needs to be done ASAP.\r\n2. This is pretty much the same change as #7218, except with the old sounds instead of the proposed new ones. That change has been incubating on next for weeks with no problems.","created_at":"2017-08-01T02:22:50Z","updated_at":"2017-08-01T02:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/7462/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/7462/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/7462/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/7528aa69d0447f297fb8533f928e270cb7c6fcbf","head":{"label":"nvaccess:moveMedia","ref":"moveMedia","sha":"7528aa69d0447f297fb8533f928e270cb7c6fcbf","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2017-07-31T05:49:42Z","pushed_at":"2017-08-01T02:06:25Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":111802,"stargazers_count":319,"watchers_count":319,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":2433,"forks":146,"open_issues":2433,"watchers":319,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"57432f41593655ed00b70142df2a97f046e1eeae","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2017-07-31T05:49:42Z","pushed_at":"2017-08-01T02:06:25Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":111802,"stargazers_count":319,"watchers_count":319,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":2433,"forks":146,"open_issues":2433,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7462"},"html":{"href":"https://github.com/nvaccess/nvda/pull/7462"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/7462"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/7462/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7462/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7462/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/7528aa69d0447f297fb8533f928e270cb7c6fcbf"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":3,"changed_files":11}}
{"actor":{"display_login":"jcsteh"}}