{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/148836890","pull_request_review_id":74144356,"id":148836890,"diff_hunk":"@@ -786,11 +786,11 @@ var PDFPageProxy = (function PDFPageProxyClosure() {\n      * @return {PageViewport} Contains 'width' and 'height' properties\n      * along with transforms required for rendering.\n      */\n-    getViewport: function PDFPageProxy_getViewport(scale, rotate) {\n-      if (arguments.length < 2) {\n-        rotate = this.rotate;\n+    getViewport: function PDFPageProxy_getViewport(scale, rotate, dontFlip) {","path":"src/display/api.js","position":7,"original_position":7,"commit_id":"4111d06223582edb944bc2dc77c850b8a927be0c","original_commit_id":"4111d06223582edb944bc2dc77c850b8a927be0c","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Since we now live in an ES6 world, can't we simplify things by using the following method signature instead?\r\n```javascript\r\ngetViewport(scale, rotate = this.rotate, dontFlip = false) {\r\n```","created_at":"2017-11-03T16:50:28Z","updated_at":"2017-11-03T16:58:33Z","html_url":"https://github.com/mozilla/pdf.js/pull/9099#discussion_r148836890","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/148836890"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/9099#discussion_r148836890"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099","id":150567346,"html_url":"https://github.com/mozilla/pdf.js/pull/9099","diff_url":"https://github.com/mozilla/pdf.js/pull/9099.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/9099.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9099","number":9099,"state":"open","locked":false,"title":"Allows 'dontFlip' as third arg in PDFPageProxy.getViewport","user":{"login":"tiriana","id":5216143,"avatar_url":"https://avatars2.githubusercontent.com/u/5216143?v=4","gravatar_id":"","url":"https://api.github.com/users/tiriana","html_url":"https://github.com/tiriana","followers_url":"https://api.github.com/users/tiriana/followers","following_url":"https://api.github.com/users/tiriana/following{/other_user}","gists_url":"https://api.github.com/users/tiriana/gists{/gist_id}","starred_url":"https://api.github.com/users/tiriana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiriana/subscriptions","organizations_url":"https://api.github.com/users/tiriana/orgs","repos_url":"https://api.github.com/users/tiriana/repos","events_url":"https://api.github.com/users/tiriana/events{/privacy}","received_events_url":"https://api.github.com/users/tiriana/received_events","type":"User","site_admin":false},"body":"Right now if you wanted to have Viewport with 'dontFlip' you need to get the viewport from page with `getViewport(scale, rotate)` and then clone it with `.clone({ dontFlip: true })`. \r\n\r\nThis PR allows to do it like this:\r\n\r\n```\r\npage.getViewport(scale, rotate, dontFlip)\r\n```","created_at":"2017-11-03T16:07:59Z","updated_at":"2017-11-03T16:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28533172f6e76428e873262d6751a47f648d7364","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9099/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/4111d06223582edb944bc2dc77c850b8a927be0c","head":{"label":"tiriana:allow-dontFlip-in-PDFPageProxy-getViewport","ref":"allow-dontFlip-in-PDFPageProxy-getViewport","sha":"4111d06223582edb944bc2dc77c850b8a927be0c","user":{"login":"tiriana","id":5216143,"avatar_url":"https://avatars2.githubusercontent.com/u/5216143?v=4","gravatar_id":"","url":"https://api.github.com/users/tiriana","html_url":"https://github.com/tiriana","followers_url":"https://api.github.com/users/tiriana/followers","following_url":"https://api.github.com/users/tiriana/following{/other_user}","gists_url":"https://api.github.com/users/tiriana/gists{/gist_id}","starred_url":"https://api.github.com/users/tiriana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiriana/subscriptions","organizations_url":"https://api.github.com/users/tiriana/orgs","repos_url":"https://api.github.com/users/tiriana/repos","events_url":"https://api.github.com/users/tiriana/events{/privacy}","received_events_url":"https://api.github.com/users/tiriana/received_events","type":"User","site_admin":false},"repo":{"id":109415108,"name":"pdf.js","full_name":"tiriana/pdf.js","owner":{"login":"tiriana","id":5216143,"avatar_url":"https://avatars2.githubusercontent.com/u/5216143?v=4","gravatar_id":"","url":"https://api.github.com/users/tiriana","html_url":"https://github.com/tiriana","followers_url":"https://api.github.com/users/tiriana/followers","following_url":"https://api.github.com/users/tiriana/following{/other_user}","gists_url":"https://api.github.com/users/tiriana/gists{/gist_id}","starred_url":"https://api.github.com/users/tiriana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiriana/subscriptions","organizations_url":"https://api.github.com/users/tiriana/orgs","repos_url":"https://api.github.com/users/tiriana/repos","events_url":"https://api.github.com/users/tiriana/events{/privacy}","received_events_url":"https://api.github.com/users/tiriana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiriana/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/tiriana/pdf.js","forks_url":"https://api.github.com/repos/tiriana/pdf.js/forks","keys_url":"https://api.github.com/repos/tiriana/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiriana/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiriana/pdf.js/teams","hooks_url":"https://api.github.com/repos/tiriana/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/tiriana/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/tiriana/pdf.js/events","assignees_url":"https://api.github.com/repos/tiriana/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/tiriana/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/tiriana/pdf.js/tags","blobs_url":"https://api.github.com/repos/tiriana/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiriana/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiriana/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiriana/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiriana/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/tiriana/pdf.js/languages","stargazers_url":"https://api.github.com/repos/tiriana/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/tiriana/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/tiriana/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/tiriana/pdf.js/subscription","commits_url":"https://api.github.com/repos/tiriana/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiriana/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiriana/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiriana/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiriana/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/tiriana/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiriana/pdf.js/merges","archive_url":"https://api.github.com/repos/tiriana/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiriana/pdf.js/downloads","issues_url":"https://api.github.com/repos/tiriana/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/tiriana/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/tiriana/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/tiriana/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiriana/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/tiriana/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/tiriana/pdf.js/deployments","created_at":"2017-11-03T15:59:47Z","updated_at":"2017-11-03T15:59:52Z","pushed_at":"2017-11-03T16:12:58Z","git_url":"git://github.com/tiriana/pdf.js.git","ssh_url":"git@github.com:tiriana/pdf.js.git","clone_url":"https://github.com/tiriana/pdf.js.git","svn_url":"https://github.com/tiriana/pdf.js","homepage":"","size":67267,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6521d2fd941f26a1b7ae9b97f71842e49f5ff241","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2017-11-03T16:08:18Z","pushed_at":"2017-11-03T16:42:04Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":67267,"stargazers_count":19767,"watchers_count":19767,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4875,"mirror_url":null,"archived":false,"open_issues_count":689,"forks":4875,"open_issues":689,"watchers":19767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/9099"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/9099"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/9099/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9099/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/4111d06223582edb944bc2dc77c850b8a927be0c"}},"author_association":"NONE"}}
{"actor":{"display_login":"Snuffleupagus"}}