{"action":"closed","issue":{"url":"https://api.github.com/repos/rook/rook/issues/1091","repository_url":"https://api.github.com/repos/rook/rook","labels_url":"https://api.github.com/repos/rook/rook/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/rook/rook/issues/1091/comments","events_url":"https://api.github.com/repos/rook/rook/issues/1091/events","html_url":"https://github.com/rook/rook/issues/1091","id":266237818,"number":1091,"title":"rook-api should use prometheus annotations","user":{"login":"jpds","id":29158971,"avatar_url":"https://avatars1.githubusercontent.com/u/29158971?v=4","gravatar_id":"","url":"https://api.github.com/users/jpds","html_url":"https://github.com/jpds","followers_url":"https://api.github.com/users/jpds/followers","following_url":"https://api.github.com/users/jpds/following{/other_user}","gists_url":"https://api.github.com/users/jpds/gists{/gist_id}","starred_url":"https://api.github.com/users/jpds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpds/subscriptions","organizations_url":"https://api.github.com/users/jpds/orgs","repos_url":"https://api.github.com/users/jpds/repos","events_url":"https://api.github.com/users/jpds/events{/privacy}","received_events_url":"https://api.github.com/users/jpds/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-10-17T18:50:40Z","updated_at":"2017-11-13T15:46:23Z","closed_at":"2017-11-13T15:46:23Z","author_association":"NONE","body":"rook-api currently uses this[1] configuration to configure a monitoring endpoint. However it would be better if the service definition had these annotations from here in its metadata:\r\n\r\n- https://github.com/prometheus/prometheus/blob/5ab8834befbd92241a88976c790ace7543edcd59/documentation/examples/prometheus-kubernetes.yml#L133\r\n\r\nThis way a Prometheus instance that's monitoring kubernetes-services can autodetect the rook-api service metrics.\r\n\r\n[1]: https://github.com/rook/rook/blob/c6bb14ad28c5540e536e3bc8e838b9dda80f5409/cluster/examples/kubernetes/monitoring/service-monitor.yaml#L13"}}
{"actor":{"display_login":"jpds"}}