{"action":"created","comment":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/comments/139934339","pull_request_review_id":63934086,"id":139934339,"diff_hunk":"@@ -58,7 +58,7 @@ func NewMessageFrom(to []string, from, subject, body string) *Message {\n \n // NewMessage creates new mail message object with default From header.\n func NewMessage(to []string, subject, body string) *Message {\n-\treturn NewMessageFrom(to, setting.MailService.From, subject, body)\n+\treturn NewMessageFrom(to, setting.MailService.From, \"\", subject, body)","path":"modules/mailer/mailer.go","position":19,"original_position":19,"commit_id":"56f9555cbb914a9b281a08f5fb8c5301aade441b","original_commit_id":"56f9555cbb914a9b281a08f5fb8c5301aade441b","user":{"login":"lafriks","id":165205,"avatar_url":"https://avatars2.githubusercontent.com/u/165205?v=4","gravatar_id":"","url":"https://api.github.com/users/lafriks","html_url":"https://github.com/lafriks","followers_url":"https://api.github.com/users/lafriks/followers","following_url":"https://api.github.com/users/lafriks/following{/other_user}","gists_url":"https://api.github.com/users/lafriks/gists{/gist_id}","starred_url":"https://api.github.com/users/lafriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafriks/subscriptions","organizations_url":"https://api.github.com/users/lafriks/orgs","repos_url":"https://api.github.com/users/lafriks/repos","events_url":"https://api.github.com/users/lafriks/events{/privacy}","received_events_url":"https://api.github.com/users/lafriks/received_events","type":"User","site_admin":false},"body":"But as stated in https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L312 From can be in format `\"Sender\" <sender@domain.ext>` so it should be parsed somehow and passed in both arguments","created_at":"2017-09-20T10:42:15Z","updated_at":"2017-09-20T10:42:23Z","html_url":"https://github.com/go-gitea/gitea/pull/2559#discussion_r139934339","pull_request_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2559","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/comments/139934339"},"html":{"href":"https://github.com/go-gitea/gitea/pull/2559#discussion_r139934339"},"pull_request":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2559"}}},"pull_request":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/2559","id":142051836,"html_url":"https://github.com/go-gitea/gitea/pull/2559","diff_url":"https://github.com/go-gitea/gitea/pull/2559.diff","patch_url":"https://github.com/go-gitea/gitea/pull/2559.patch","issue_url":"https://api.github.com/repos/go-gitea/gitea/issues/2559","number":2559,"state":"open","locked":false,"title":"Fix sending mail with a non-latin display name. #2102","user":{"login":"rems4e","id":11176837,"avatar_url":"https://avatars2.githubusercontent.com/u/11176837?v=4","gravatar_id":"","url":"https://api.github.com/users/rems4e","html_url":"https://github.com/rems4e","followers_url":"https://api.github.com/users/rems4e/followers","following_url":"https://api.github.com/users/rems4e/following{/other_user}","gists_url":"https://api.github.com/users/rems4e/gists{/gist_id}","starred_url":"https://api.github.com/users/rems4e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rems4e/subscriptions","organizations_url":"https://api.github.com/users/rems4e/orgs","repos_url":"https://api.github.com/users/rems4e/repos","events_url":"https://api.github.com/users/rems4e/events{/privacy}","received_events_url":"https://api.github.com/users/rems4e/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Rémi Saurel <contact@remi-saurel.com>\r\n\r\nThis pull request fixes #2102, where display name of email addresses containing non-latin characters cannot be used in the From: field when creating/updating issues (resulting in no email sent at all).\r\n\r\nThe fix is simple, it uses `Message.SetAddressHeader`, instead of `Message.SetHeader` with a custom-formatted `DisplayName <email@address>` from address.\r\n","created_at":"2017-09-20T09:33:06Z","updated_at":"2017-09-20T10:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb9cd61056da2ca59edc0bd439f1a9ec32ee9b35","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2559/commits","review_comments_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2559/comments","review_comment_url":"https://api.github.com/repos/go-gitea/gitea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/2559/comments","statuses_url":"https://api.github.com/repos/go-gitea/gitea/statuses/56f9555cbb914a9b281a08f5fb8c5301aade441b","head":{"label":"rems4e:master","ref":"master","sha":"56f9555cbb914a9b281a08f5fb8c5301aade441b","user":{"login":"rems4e","id":11176837,"avatar_url":"https://avatars2.githubusercontent.com/u/11176837?v=4","gravatar_id":"","url":"https://api.github.com/users/rems4e","html_url":"https://github.com/rems4e","followers_url":"https://api.github.com/users/rems4e/followers","following_url":"https://api.github.com/users/rems4e/following{/other_user}","gists_url":"https://api.github.com/users/rems4e/gists{/gist_id}","starred_url":"https://api.github.com/users/rems4e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rems4e/subscriptions","organizations_url":"https://api.github.com/users/rems4e/orgs","repos_url":"https://api.github.com/users/rems4e/repos","events_url":"https://api.github.com/users/rems4e/events{/privacy}","received_events_url":"https://api.github.com/users/rems4e/received_events","type":"User","site_admin":false},"repo":{"id":104193563,"name":"gitea","full_name":"rems4e/gitea","owner":{"login":"rems4e","id":11176837,"avatar_url":"https://avatars2.githubusercontent.com/u/11176837?v=4","gravatar_id":"","url":"https://api.github.com/users/rems4e","html_url":"https://github.com/rems4e","followers_url":"https://api.github.com/users/rems4e/followers","following_url":"https://api.github.com/users/rems4e/following{/other_user}","gists_url":"https://api.github.com/users/rems4e/gists{/gist_id}","starred_url":"https://api.github.com/users/rems4e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rems4e/subscriptions","organizations_url":"https://api.github.com/users/rems4e/orgs","repos_url":"https://api.github.com/users/rems4e/repos","events_url":"https://api.github.com/users/rems4e/events{/privacy}","received_events_url":"https://api.github.com/users/rems4e/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rems4e/gitea","description":"Gitea: Git with a cup of tea","fork":true,"url":"https://api.github.com/repos/rems4e/gitea","forks_url":"https://api.github.com/repos/rems4e/gitea/forks","keys_url":"https://api.github.com/repos/rems4e/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rems4e/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rems4e/gitea/teams","hooks_url":"https://api.github.com/repos/rems4e/gitea/hooks","issue_events_url":"https://api.github.com/repos/rems4e/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/rems4e/gitea/events","assignees_url":"https://api.github.com/repos/rems4e/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/rems4e/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/rems4e/gitea/tags","blobs_url":"https://api.github.com/repos/rems4e/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rems4e/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rems4e/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/rems4e/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rems4e/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/rems4e/gitea/languages","stargazers_url":"https://api.github.com/repos/rems4e/gitea/stargazers","contributors_url":"https://api.github.com/repos/rems4e/gitea/contributors","subscribers_url":"https://api.github.com/repos/rems4e/gitea/subscribers","subscription_url":"https://api.github.com/repos/rems4e/gitea/subscription","commits_url":"https://api.github.com/repos/rems4e/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/rems4e/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/rems4e/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/rems4e/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/rems4e/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/rems4e/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rems4e/gitea/merges","archive_url":"https://api.github.com/repos/rems4e/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rems4e/gitea/downloads","issues_url":"https://api.github.com/repos/rems4e/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/rems4e/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/rems4e/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/rems4e/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rems4e/gitea/labels{/name}","releases_url":"https://api.github.com/repos/rems4e/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/rems4e/gitea/deployments","created_at":"2017-09-20T09:19:05Z","updated_at":"2017-09-20T09:19:08Z","pushed_at":"2017-09-20T09:28:46Z","git_url":"git://github.com/rems4e/gitea.git","ssh_url":"git@github.com:rems4e/gitea.git","clone_url":"https://github.com/rems4e/gitea.git","svn_url":"https://github.com/rems4e/gitea","homepage":"http://gitea.io","size":103782,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-gitea:master","ref":"master","sha":"80b430d7c07a48f4b3e3c96b821105c8e4789c69","user":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars1.githubusercontent.com/u/12724356?v=4","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"repo":{"id":72495579,"name":"gitea","full_name":"go-gitea/gitea","owner":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars1.githubusercontent.com/u/12724356?v=4","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-gitea/gitea","description":"Gitea: Git with a cup of tea","fork":false,"url":"https://api.github.com/repos/go-gitea/gitea","forks_url":"https://api.github.com/repos/go-gitea/gitea/forks","keys_url":"https://api.github.com/repos/go-gitea/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-gitea/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-gitea/gitea/teams","hooks_url":"https://api.github.com/repos/go-gitea/gitea/hooks","issue_events_url":"https://api.github.com/repos/go-gitea/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/go-gitea/gitea/events","assignees_url":"https://api.github.com/repos/go-gitea/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/go-gitea/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/go-gitea/gitea/tags","blobs_url":"https://api.github.com/repos/go-gitea/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-gitea/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-gitea/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-gitea/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-gitea/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/go-gitea/gitea/languages","stargazers_url":"https://api.github.com/repos/go-gitea/gitea/stargazers","contributors_url":"https://api.github.com/repos/go-gitea/gitea/contributors","subscribers_url":"https://api.github.com/repos/go-gitea/gitea/subscribers","subscription_url":"https://api.github.com/repos/go-gitea/gitea/subscription","commits_url":"https://api.github.com/repos/go-gitea/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-gitea/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-gitea/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-gitea/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-gitea/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/go-gitea/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-gitea/gitea/merges","archive_url":"https://api.github.com/repos/go-gitea/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-gitea/gitea/downloads","issues_url":"https://api.github.com/repos/go-gitea/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/go-gitea/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/go-gitea/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/go-gitea/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-gitea/gitea/labels{/name}","releases_url":"https://api.github.com/repos/go-gitea/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/go-gitea/gitea/deployments","created_at":"2016-11-01T02:13:26Z","updated_at":"2017-09-20T10:24:33Z","pushed_at":"2017-09-20T09:33:07Z","git_url":"git://github.com/go-gitea/gitea.git","ssh_url":"git@github.com:go-gitea/gitea.git","clone_url":"https://github.com/go-gitea/gitea.git","svn_url":"https://github.com/go-gitea/gitea","homepage":"http://gitea.io","size":103782,"stargazers_count":3606,"watchers_count":3606,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":532,"forks":383,"open_issues":532,"watchers":3606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2559"},"html":{"href":"https://github.com/go-gitea/gitea/pull/2559"},"issue":{"href":"https://api.github.com/repos/go-gitea/gitea/issues/2559"},"comments":{"href":"https://api.github.com/repos/go-gitea/gitea/issues/2559/comments"},"review_comments":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2559/comments"},"review_comment":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2559/commits"},"statuses":{"href":"https://api.github.com/repos/go-gitea/gitea/statuses/56f9555cbb914a9b281a08f5fb8c5301aade441b"}},"author_association":"NONE"}}
{"actor":{"display_login":"lafriks"}}