{"action":"created","issue":{"url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/222","repository_url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle","labels_url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/222/comments","events_url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/222/events","html_url":"https://github.com/GeniusesOfSymfony/WebSocketBundle/pull/222","id":209816996,"number":222,"title":"Added firewalled topic","user":{"login":"MicioBaus","id":10188393,"avatar_url":"https://avatars2.githubusercontent.com/u/10188393?v=3","gravatar_id":"","url":"https://api.github.com/users/MicioBaus","html_url":"https://github.com/MicioBaus","followers_url":"https://api.github.com/users/MicioBaus/followers","following_url":"https://api.github.com/users/MicioBaus/following{/other_user}","gists_url":"https://api.github.com/users/MicioBaus/gists{/gist_id}","starred_url":"https://api.github.com/users/MicioBaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicioBaus/subscriptions","organizations_url":"https://api.github.com/users/MicioBaus/orgs","repos_url":"https://api.github.com/users/MicioBaus/repos","events_url":"https://api.github.com/users/MicioBaus/events{/privacy}","received_events_url":"https://api.github.com/users/MicioBaus/received_events","type":"User","site_admin":false},"labels":[{"id":193906249,"url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/labels/feature","name":"feature","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-23T16:43:21Z","updated_at":"2017-03-27T13:08:49Z","closed_at":"2017-03-27T09:13:41Z","pull_request":{"url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/pulls/222","html_url":"https://github.com/GeniusesOfSymfony/WebSocketBundle/pull/222","diff_url":"https://github.com/GeniusesOfSymfony/WebSocketBundle/pull/222.diff","patch_url":"https://github.com/GeniusesOfSymfony/WebSocketBundle/pull/222.patch"},"body":"I added a new interface, `FirewalledTopicInterface`, that allows adding logic inside user's topic service to close unwanted connections.\r\n\r\nI extended the current TopicDispatcher to handle this type of topic service. \r\n\r\nModifications are pretty strightforward, the only issue is that:\r\n- IF a client connects to more than one topic\r\n- AND one of them fails\r\n- the connection is closed, disconnecting from ALL topics\r\n\r\nI do not know if this is the correct behaviour, it is a conservative approach though.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/comments/289448112","html_url":"https://github.com/GeniusesOfSymfony/WebSocketBundle/pull/222#issuecomment-289448112","issue_url":"https://api.github.com/repos/GeniusesOfSymfony/WebSocketBundle/issues/222","id":289448112,"user":{"login":"ProPheT777","id":1763341,"avatar_url":"https://avatars3.githubusercontent.com/u/1763341?v=3","gravatar_id":"","url":"https://api.github.com/users/ProPheT777","html_url":"https://github.com/ProPheT777","followers_url":"https://api.github.com/users/ProPheT777/followers","following_url":"https://api.github.com/users/ProPheT777/following{/other_user}","gists_url":"https://api.github.com/users/ProPheT777/gists{/gist_id}","starred_url":"https://api.github.com/users/ProPheT777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProPheT777/subscriptions","organizations_url":"https://api.github.com/users/ProPheT777/orgs","repos_url":"https://api.github.com/users/ProPheT777/repos","events_url":"https://api.github.com/users/ProPheT777/events{/privacy}","received_events_url":"https://api.github.com/users/ProPheT777/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T13:08:49Z","updated_at":"2017-03-27T13:08:49Z","body":"Why did you close this PR ? you should add your commit where you change stuff to this branch @MicioBaus it can't work otherwise :p\r\n\r\nI let you reopen it and repush on it "}}
{"actor":{"display_login":"ProPheT777"}}