{"action":"created","issue":{"url":"https://api.github.com/repos/ApiGen/ApiGen/issues/998","repository_url":"https://api.github.com/repos/ApiGen/ApiGen","labels_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/998/labels{/name}","comments_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/998/comments","events_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/998/events","html_url":"https://github.com/ApiGen/ApiGen/pull/998","id":255193915,"number":998,"title":"fix broken BetterReflection's behavior","user":{"login":"vlastavesely","id":22521379,"avatar_url":"https://avatars2.githubusercontent.com/u/22521379?v=4","gravatar_id":"","url":"https://api.github.com/users/vlastavesely","html_url":"https://github.com/vlastavesely","followers_url":"https://api.github.com/users/vlastavesely/followers","following_url":"https://api.github.com/users/vlastavesely/following{/other_user}","gists_url":"https://api.github.com/users/vlastavesely/gists{/gist_id}","starred_url":"https://api.github.com/users/vlastavesely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlastavesely/subscriptions","organizations_url":"https://api.github.com/users/vlastavesely/orgs","repos_url":"https://api.github.com/users/vlastavesely/repos","events_url":"https://api.github.com/users/vlastavesely/events{/privacy}","received_events_url":"https://api.github.com/users/vlastavesely/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-09-05T08:12:27Z","updated_at":"2017-09-19T19:30:25Z","closed_at":"2017-09-19T19:21:21Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ApiGen/ApiGen/pulls/998","html_url":"https://github.com/ApiGen/ApiGen/pull/998","diff_url":"https://github.com/ApiGen/ApiGen/pull/998.diff","patch_url":"https://github.com/ApiGen/ApiGen/pull/998.patch"},"body":"I tested this:\r\n\r\n```php\r\n<?php\r\n\r\ninclude __DIR__ . '/vendor/autoload.php';\r\n\r\nuse Roave\\BetterReflection\\BetterReflection;\r\n\r\n$classInfo = (new BetterReflection())\r\n    ->classReflector()\r\n    ->reflect(Exception::class);\r\n\r\nprint_r(array_keys($classInfo->getInterfaces()));\r\n```\r\n\r\nit shown that problem is in BR.I updated dependency and two broken tests pass now. I will check the last also."},"comment":{"url":"https://api.github.com/repos/ApiGen/ApiGen/issues/comments/330648693","html_url":"https://github.com/ApiGen/ApiGen/pull/998#issuecomment-330648693","issue_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/998","id":330648693,"user":{"login":"TomasVotruba","id":924196,"avatar_url":"https://avatars1.githubusercontent.com/u/924196?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasVotruba","html_url":"https://github.com/TomasVotruba","followers_url":"https://api.github.com/users/TomasVotruba/followers","following_url":"https://api.github.com/users/TomasVotruba/following{/other_user}","gists_url":"https://api.github.com/users/TomasVotruba/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasVotruba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasVotruba/subscriptions","organizations_url":"https://api.github.com/users/TomasVotruba/orgs","repos_url":"https://api.github.com/users/TomasVotruba/repos","events_url":"https://api.github.com/users/TomasVotruba/events{/privacy}","received_events_url":"https://api.github.com/users/TomasVotruba/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T19:30:25Z","updated_at":"2017-09-19T19:30:25Z","author_association":"CONTRIBUTOR","body":"> So, I am closing this also for it depended on your PR.\r\n\r\nSure.\r\n\r\n> I am not having any time now, I am not sure when I will able to work on ApiGen but I would like to do all my best to make 5.0 release possible.\r\n\r\nTake your time. It's also up to other contributors to make progress to ApiGen 5.\r\n\r\nIt helps me to take 1 PR at a time. It might be exhausting to manage multiple issues at once.\r\n\r\nBut the most: **enjoy it or don't do it** :+1:  It's open source after all :tulip:  "}}
{"actor":{"display_login":"TomasVotruba"}}