{"action":"created","issue":{"url":"https://api.github.com/repos/fraywing/textAngular/issues/1434","repository_url":"https://api.github.com/repos/fraywing/textAngular","labels_url":"https://api.github.com/repos/fraywing/textAngular/issues/1434/labels{/name}","comments_url":"https://api.github.com/repos/fraywing/textAngular/issues/1434/comments","events_url":"https://api.github.com/repos/fraywing/textAngular/issues/1434/events","html_url":"https://github.com/fraywing/textAngular/issues/1434","id":200072497,"number":1434,"title":"Please properly fork ng-sanitize","user":{"login":"TomMettam","id":2168418,"avatar_url":"https://avatars.githubusercontent.com/u/2168418?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMettam","html_url":"https://github.com/TomMettam","followers_url":"https://api.github.com/users/TomMettam/followers","following_url":"https://api.github.com/users/TomMettam/following{/other_user}","gists_url":"https://api.github.com/users/TomMettam/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMettam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMettam/subscriptions","organizations_url":"https://api.github.com/users/TomMettam/orgs","repos_url":"https://api.github.com/users/TomMettam/repos","events_url":"https://api.github.com/users/TomMettam/events{/privacy}","received_events_url":"https://api.github.com/users/TomMettam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-11T11:46:53Z","updated_at":"2017-01-12T17:19:18Z","closed_at":null,"body":"Your drop-in replacement for ng-sanitize works well when being included in the usual way via <script> tags.\r\n\r\nHowever, when used in projects which use npm modules like browserify, it causes big problems with other packages which require angular-sanitize.\r\n\r\nIn addition to this, there's the security implication - angular-sanitize is much more frequently updated than your version, and after performing a (admittedly, not very thorough) comparison of bugs lodged against angular-sanitize, there seem to be many bugfixes which have not made it to your build.\r\n\r\nMaintaining a different version of a package with the same name just won't fly.\r\n\r\nPlease consider either:\r\n\r\n- A complete fork, with a new name used throughout so that it doesn't cause conflicts with angular-sanitize.\r\n\r\n- Adding needed functionality to angular-sanitize and submit upstream."},"comment":{"url":"https://api.github.com/repos/fraywing/textAngular/issues/comments/272224792","html_url":"https://github.com/fraywing/textAngular/issues/1434#issuecomment-272224792","issue_url":"https://api.github.com/repos/fraywing/textAngular/issues/1434","id":272224792,"user":{"login":"JoelParke","id":12278498,"avatar_url":"https://avatars.githubusercontent.com/u/12278498?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelParke","html_url":"https://github.com/JoelParke","followers_url":"https://api.github.com/users/JoelParke/followers","following_url":"https://api.github.com/users/JoelParke/following{/other_user}","gists_url":"https://api.github.com/users/JoelParke/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelParke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelParke/subscriptions","organizations_url":"https://api.github.com/users/JoelParke/orgs","repos_url":"https://api.github.com/users/JoelParke/repos","events_url":"https://api.github.com/users/JoelParke/events{/privacy}","received_events_url":"https://api.github.com/users/JoelParke/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T17:19:18Z","updated_at":"2017-01-12T17:19:18Z","body":"<p>The issue is that ng-sanitize (as you pointed out) accepts many more tags etc.   One can use angular-sanitize without the ng-sanitize, however that breaks cases where the tags etc are not passed in.  </p><p>It would be great to have an updated version of angular-sanitize integrated into textAngular, but it is beyond the scope of what I can do at this point as I am the only developer at present who is attempting to maintain, etc. I would however love to expand the team.   I am at present shifting to angular2 and webpack, but on a different project and would love to see textAngular -&gt; textAngular for angular2.</p><p><br/></p>"}}
{"actor":{"display_login":"JoelParke"}}