{"action":"created","comment":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/100179312","pull_request_review_id":20874579,"id":100179312,"diff_hunk":"@@ -8,185 +7,154 @@\n #  which is included in the file license.txt, found at the root\n #  of the RDKit source tree.\n #\n-\"\"\" unit testing code for molecule drawing\n-\"\"\"\n-from rdkit import RDConfig\n-import unittest, os, tempfile\n+import os\n+import sys\n+import tempfile\n+import unittest\n+\n from rdkit import Chem\n from rdkit.Chem import Draw\n-from rdkit.RDLogger import logger\n+\n try:\n   from rdkit.Chem.Draw import IPythonConsole\n except ImportError:\n   IPythonConsole = None\n-\n-logger = logger()\n+try:\n+  from rdkit.Chem.Draw import cairoCanvas\n+except ImportError:\n+  cairoCanvas = None\n+try:\n+  from rdkit.Chem.Draw import spingCanvas\n+except ImportError:\n+  spingCanvas = None\n+try:\n+  from rdkit.Chem.Draw import aggCanvas\n+except ImportError:\n+  aggCanvas = None\n+try:\n+  from rdkit.Chem.Draw import qtCanvas\n+except ImportError:\n+  qtCanvas = None\n \n \n class TestCase(unittest.TestCase):\n+  showAllImages = False","path":"rdkit/Chem/Draw/UnitTestDraw.py","position":47,"original_position":47,"commit_id":"ea42497e5518ebcb8aab5073f56b969cf61e2acd","original_commit_id":"435985205414f536158ab6331f2030b93c969efe","user":{"login":"gedeck","id":8720575,"avatar_url":"https://avatars.githubusercontent.com/u/8720575?v=3","gravatar_id":"","url":"https://api.github.com/users/gedeck","html_url":"https://github.com/gedeck","followers_url":"https://api.github.com/users/gedeck/followers","following_url":"https://api.github.com/users/gedeck/following{/other_user}","gists_url":"https://api.github.com/users/gedeck/gists{/gist_id}","starred_url":"https://api.github.com/users/gedeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedeck/subscriptions","organizations_url":"https://api.github.com/users/gedeck/orgs","repos_url":"https://api.github.com/users/gedeck/repos","events_url":"https://api.github.com/users/gedeck/events{/privacy}","received_events_url":"https://api.github.com/users/gedeck/received_events","type":"User","site_admin":false},"body":"This flag allows to show the sping generated images. Default should be `False`.","created_at":"2017-02-08T21:51:51Z","updated_at":"2017-02-08T22:04:10Z","html_url":"https://github.com/rdkit/rdkit/pull/1301#discussion_r100179312","pull_request_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1301","_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/100179312"},"html":{"href":"https://github.com/rdkit/rdkit/pull/1301#discussion_r100179312"},"pull_request":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1301"}}},"pull_request":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/1301","id":105309682,"html_url":"https://github.com/rdkit/rdkit/pull/1301","diff_url":"https://github.com/rdkit/rdkit/pull/1301.diff","patch_url":"https://github.com/rdkit/rdkit/pull/1301.patch","issue_url":"https://api.github.com/repos/rdkit/rdkit/issues/1301","number":1301,"state":"open","locked":false,"title":"Review of rdkit.Chem code - 1","user":{"login":"gedeck","id":8720575,"avatar_url":"https://avatars.githubusercontent.com/u/8720575?v=3","gravatar_id":"","url":"https://api.github.com/users/gedeck","html_url":"https://github.com/gedeck","followers_url":"https://api.github.com/users/gedeck/followers","following_url":"https://api.github.com/users/gedeck/following{/other_user}","gists_url":"https://api.github.com/users/gedeck/gists{/gist_id}","starred_url":"https://api.github.com/users/gedeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedeck/subscriptions","organizations_url":"https://api.github.com/users/gedeck/orgs","repos_url":"https://api.github.com/users/gedeck/repos","events_url":"https://api.github.com/users/gedeck/events{/privacy}","received_events_url":"https://api.github.com/users/gedeck/received_events","type":"User","site_admin":false},"body":"Formatting changes\r\nChanged handling of initialisation arguments on several cases.\r\nAnd minor refactoring - I'll highlight with comments.","created_at":"2017-02-08T21:32:55Z","updated_at":"2017-02-08T22:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"797af76d8452b8667a99803f708f4fffbbd69746","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1301/commits","review_comments_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1301/comments","review_comment_url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdkit/rdkit/issues/1301/comments","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/ea42497e5518ebcb8aab5073f56b969cf61e2acd","head":{"label":"gedeck:gedeck-rdkitChemDraw-pr1","ref":"gedeck-rdkitChemDraw-pr1","sha":"ea42497e5518ebcb8aab5073f56b969cf61e2acd","user":{"login":"gedeck","id":8720575,"avatar_url":"https://avatars.githubusercontent.com/u/8720575?v=3","gravatar_id":"","url":"https://api.github.com/users/gedeck","html_url":"https://github.com/gedeck","followers_url":"https://api.github.com/users/gedeck/followers","following_url":"https://api.github.com/users/gedeck/following{/other_user}","gists_url":"https://api.github.com/users/gedeck/gists{/gist_id}","starred_url":"https://api.github.com/users/gedeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedeck/subscriptions","organizations_url":"https://api.github.com/users/gedeck/orgs","repos_url":"https://api.github.com/users/gedeck/repos","events_url":"https://api.github.com/users/gedeck/events{/privacy}","received_events_url":"https://api.github.com/users/gedeck/received_events","type":"User","site_admin":false},"repo":{"id":68383385,"name":"rdkit","full_name":"gedeck/rdkit","owner":{"login":"gedeck","id":8720575,"avatar_url":"https://avatars.githubusercontent.com/u/8720575?v=3","gravatar_id":"","url":"https://api.github.com/users/gedeck","html_url":"https://github.com/gedeck","followers_url":"https://api.github.com/users/gedeck/followers","following_url":"https://api.github.com/users/gedeck/following{/other_user}","gists_url":"https://api.github.com/users/gedeck/gists{/gist_id}","starred_url":"https://api.github.com/users/gedeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedeck/subscriptions","organizations_url":"https://api.github.com/users/gedeck/orgs","repos_url":"https://api.github.com/users/gedeck/repos","events_url":"https://api.github.com/users/gedeck/events{/privacy}","received_events_url":"https://api.github.com/users/gedeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gedeck/rdkit","description":"The official sources for the RDKit library","fork":true,"url":"https://api.github.com/repos/gedeck/rdkit","forks_url":"https://api.github.com/repos/gedeck/rdkit/forks","keys_url":"https://api.github.com/repos/gedeck/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gedeck/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gedeck/rdkit/teams","hooks_url":"https://api.github.com/repos/gedeck/rdkit/hooks","issue_events_url":"https://api.github.com/repos/gedeck/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/gedeck/rdkit/events","assignees_url":"https://api.github.com/repos/gedeck/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/gedeck/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/gedeck/rdkit/tags","blobs_url":"https://api.github.com/repos/gedeck/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gedeck/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gedeck/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/gedeck/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gedeck/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/gedeck/rdkit/languages","stargazers_url":"https://api.github.com/repos/gedeck/rdkit/stargazers","contributors_url":"https://api.github.com/repos/gedeck/rdkit/contributors","subscribers_url":"https://api.github.com/repos/gedeck/rdkit/subscribers","subscription_url":"https://api.github.com/repos/gedeck/rdkit/subscription","commits_url":"https://api.github.com/repos/gedeck/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/gedeck/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/gedeck/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/gedeck/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/gedeck/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/gedeck/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gedeck/rdkit/merges","archive_url":"https://api.github.com/repos/gedeck/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gedeck/rdkit/downloads","issues_url":"https://api.github.com/repos/gedeck/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/gedeck/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/gedeck/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/gedeck/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gedeck/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/gedeck/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/gedeck/rdkit/deployments","created_at":"2016-09-16T13:46:05Z","updated_at":"2016-09-16T13:46:18Z","pushed_at":"2017-02-08T22:03:28Z","git_url":"git://github.com/gedeck/rdkit.git","ssh_url":"git@github.com:gedeck/rdkit.git","clone_url":"https://github.com/gedeck/rdkit.git","svn_url":"https://github.com/gedeck/rdkit","homepage":"","size":100807,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdkit:master","ref":"master","sha":"fb57081b66e7b69d095e1ad0bf4a1a213ac30320","user":{"login":"rdkit","id":2018047,"avatar_url":"https://avatars.githubusercontent.com/u/2018047?v=3","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"repo":{"id":10009991,"name":"rdkit","full_name":"rdkit/rdkit","owner":{"login":"rdkit","id":2018047,"avatar_url":"https://avatars.githubusercontent.com/u/2018047?v=3","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdkit/rdkit","description":"The official sources for the RDKit library","fork":false,"url":"https://api.github.com/repos/rdkit/rdkit","forks_url":"https://api.github.com/repos/rdkit/rdkit/forks","keys_url":"https://api.github.com/repos/rdkit/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdkit/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdkit/rdkit/teams","hooks_url":"https://api.github.com/repos/rdkit/rdkit/hooks","issue_events_url":"https://api.github.com/repos/rdkit/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/rdkit/rdkit/events","assignees_url":"https://api.github.com/repos/rdkit/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/rdkit/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/rdkit/rdkit/tags","blobs_url":"https://api.github.com/repos/rdkit/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdkit/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdkit/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdkit/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/rdkit/rdkit/languages","stargazers_url":"https://api.github.com/repos/rdkit/rdkit/stargazers","contributors_url":"https://api.github.com/repos/rdkit/rdkit/contributors","subscribers_url":"https://api.github.com/repos/rdkit/rdkit/subscribers","subscription_url":"https://api.github.com/repos/rdkit/rdkit/subscription","commits_url":"https://api.github.com/repos/rdkit/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdkit/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdkit/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdkit/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdkit/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/rdkit/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdkit/rdkit/merges","archive_url":"https://api.github.com/repos/rdkit/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdkit/rdkit/downloads","issues_url":"https://api.github.com/repos/rdkit/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/rdkit/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/rdkit/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/rdkit/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdkit/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/rdkit/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/rdkit/rdkit/deployments","created_at":"2013-05-12T06:19:15Z","updated_at":"2017-02-08T15:32:31Z","pushed_at":"2017-02-08T22:03:30Z","git_url":"git://github.com/rdkit/rdkit.git","ssh_url":"git@github.com:rdkit/rdkit.git","clone_url":"https://github.com/rdkit/rdkit.git","svn_url":"https://github.com/rdkit/rdkit","homepage":"","size":101729,"stargazers_count":208,"watchers_count":208,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":222,"forks":133,"open_issues":222,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1301"},"html":{"href":"https://github.com/rdkit/rdkit/pull/1301"},"issue":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/1301"},"comments":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/1301/comments"},"review_comments":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1301/comments"},"review_comment":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1301/commits"},"statuses":{"href":"https://api.github.com/repos/rdkit/rdkit/statuses/ea42497e5518ebcb8aab5073f56b969cf61e2acd"}}}}
{"actor":{"display_login":"gedeck"}}