{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/111625169","pull_request_review_id":32885550,"id":111625169,"diff_hunk":"@@ -135,14 +135,14 @@ def start(self, node_config):\n         if node_config.genesis:\n             command = 'bash -c \"sawtooth admin keygen && \\\n             sawtooth admin genesis && \\\n-            validator {} -v\"'\n+            validator {} -v --public-uri tcp://{}:8800\"'\n         else:\n             command = 'bash -c \"sawtooth admin keygen && \\\n-            validator {} -v\"'\n+            validator {} -v --public-uri tcp://{}:8800\"'\n         if len(peers) > 0:\n-            command = command.format('--peers ' + \",\".join(peers))\n+            command = command.format('--peers ' + \" \".join(peers), node_name)","path":"manage/sawtooth_manage/docker.py","position":null,"original_position":12,"commit_id":"e8cd30dd82c0f47ca9c55a4de0e6f922391c0e71","original_commit_id":"7609a4000cf39570380264f11655d7b141b4a609","user":{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false},"body":"Fixed this for both docker and subprocess. ","created_at":"2017-04-14T19:40:50Z","updated_at":"2017-04-14T19:40:50Z","html_url":"https://github.com/hyperledger/sawtooth-core/pull/329#discussion_r111625169","pull_request_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/111625169"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/329#discussion_r111625169"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329","id":115624050,"html_url":"https://github.com/hyperledger/sawtooth-core/pull/329","diff_url":"https://github.com/hyperledger/sawtooth-core/pull/329.diff","patch_url":"https://github.com/hyperledger/sawtooth-core/pull/329.patch","issue_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/329","number":329,"state":"open","locked":false,"title":"Cluster command fixed for public-uri parameter","user":{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false},"body":"Added --public-uri argument to cluster command.\r\nFixed for both subprocess and docker.\r\n\r\nSigned-off-by: Todd Ojala <todd@bitwise.io>","created_at":"2017-04-12T20:03:15Z","updated_at":"2017-04-14T19:40:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52899b31e9defb84b0a2dbbda5e3ffebf19c9344","assignee":{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false},"assignees":[{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329/commits","review_comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329/comments","review_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/329/comments","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/e8cd30dd82c0f47ca9c55a4de0e6f922391c0e71","head":{"label":"ojalatodd:cluster_fix_public_uri_missing","ref":"cluster_fix_public_uri_missing","sha":"e8cd30dd82c0f47ca9c55a4de0e6f922391c0e71","user":{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false},"repo":{"id":81615338,"name":"sawtooth-core","full_name":"ojalatodd/sawtooth-core","owner":{"login":"ojalatodd","id":19579183,"avatar_url":"https://avatars2.githubusercontent.com/u/19579183?v=3","gravatar_id":"","url":"https://api.github.com/users/ojalatodd","html_url":"https://github.com/ojalatodd","followers_url":"https://api.github.com/users/ojalatodd/followers","following_url":"https://api.github.com/users/ojalatodd/following{/other_user}","gists_url":"https://api.github.com/users/ojalatodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ojalatodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojalatodd/subscriptions","organizations_url":"https://api.github.com/users/ojalatodd/orgs","repos_url":"https://api.github.com/users/ojalatodd/repos","events_url":"https://api.github.com/users/ojalatodd/events{/privacy}","received_events_url":"https://api.github.com/users/ojalatodd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ojalatodd/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":true,"url":"https://api.github.com/repos/ojalatodd/sawtooth-core","forks_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/forks","keys_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/events","assignees_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/merges","archive_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/ojalatodd/sawtooth-core/deployments","created_at":"2017-02-10T23:09:59Z","updated_at":"2017-02-10T23:10:02Z","pushed_at":"2017-04-14T19:39:52Z","git_url":"git://github.com/ojalatodd/sawtooth-core.git","ssh_url":"git@github.com:ojalatodd/sawtooth-core.git","clone_url":"https://github.com/ojalatodd/sawtooth-core.git","svn_url":"https://github.com/ojalatodd/sawtooth-core","homepage":"http://intelledger.github.io/","size":17849,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"fcc8e88d9acb7b201888a457f084efdc8a6e169e","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":57901437,"name":"sawtooth-core","full_name":"hyperledger/sawtooth-core","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/sawtooth-core","forks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/forks","keys_url":"https://api.github.com/repos/hyperledger/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/events","assignees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/sawtooth-core/merges","archive_url":"https://api.github.com/repos/hyperledger/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/deployments","created_at":"2016-05-02T15:51:53Z","updated_at":"2017-04-11T15:00:38Z","pushed_at":"2017-04-14T19:39:53Z","git_url":"git://github.com/hyperledger/sawtooth-core.git","ssh_url":"git@github.com:hyperledger/sawtooth-core.git","clone_url":"https://github.com/hyperledger/sawtooth-core.git","svn_url":"https://github.com/hyperledger/sawtooth-core","homepage":"http://intelledger.github.io/","size":17848,"stargazers_count":228,"watchers_count":228,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":16,"forks":111,"open_issues":16,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/329"},"issue":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/329"},"comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/e8cd30dd82c0f47ca9c55a4de0e6f922391c0e71"}}}}
{"actor":{"display_login":"ojalatodd"}}