{"action":"created","issue":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/14893","repository_url":"https://api.github.com/repos/vgstation-coders/vgstation13","labels_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/14893/labels{/name}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/14893/comments","events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/14893/events","html_url":"https://github.com/vgstation-coders/vgstation13/pull/14893","id":229750016,"number":14893,"title":"Bringing back flavor text","user":{"login":"CodenameB","id":6396485,"avatar_url":"https://avatars2.githubusercontent.com/u/6396485?v=3","gravatar_id":"","url":"https://api.github.com/users/CodenameB","html_url":"https://github.com/CodenameB","followers_url":"https://api.github.com/users/CodenameB/followers","following_url":"https://api.github.com/users/CodenameB/following{/other_user}","gists_url":"https://api.github.com/users/CodenameB/gists{/gist_id}","starred_url":"https://api.github.com/users/CodenameB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodenameB/subscriptions","organizations_url":"https://api.github.com/users/CodenameB/orgs","repos_url":"https://api.github.com/users/CodenameB/repos","events_url":"https://api.github.com/users/CodenameB/events{/privacy}","received_events_url":"https://api.github.com/users/CodenameB/received_events","type":"User","site_admin":false},"labels":[{"id":316586563,"url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/Muh%20Immulsions","name":"Muh Immulsions","color":"5319e7","default":false},{"id":435705647,"url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/Secret%20repo%20conflict.","name":"Secret repo conflict.","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":55,"created_at":"2017-05-18T17:33:55Z","updated_at":"2017-06-19T03:39:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/14893","html_url":"https://github.com/vgstation-coders/vgstation13/pull/14893","diff_url":"https://github.com/vgstation-coders/vgstation13/pull/14893.diff","patch_url":"https://github.com/vgstation-coders/vgstation13/pull/14893.patch"},"body":"This PR will bring back flavor text, reverting it's deletion some time ago.\r\n\r\nAdditionally, this adds a dna.flavor_text variable that has been used to fix changelings, cloning, and DNA modifiers to allow them to copy flavor text correctly. \r\n\r\nAnother feature makes it so that your flavor text will not appear if your face isn't recognizable. \r\n\r\nThese two fixes should prevent all of the metagaming problems that the previous incarnation of flavor text had. \r\n\r\nThis is my first PR in a long time, so I may be doing this wrong. There may be ways to simplify my code, I don't really understand byond that well yet.\r\n\r\nThanks to DamianQ on discord for the help in bugfixes.\r\n\r\n:cl:\r\n * rscadd: Flavor text re-enabled. Now, changelings and genetics can copy flavor text. Flavor text will not be visible if anything would cause your face to be unrecognizable."},"comment":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/comments/309331245","html_url":"https://github.com/vgstation-coders/vgstation13/pull/14893#issuecomment-309331245","issue_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/14893","id":309331245,"user":{"login":"Shadowmech88","id":3991927,"avatar_url":"https://avatars2.githubusercontent.com/u/3991927?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmech88","html_url":"https://github.com/Shadowmech88","followers_url":"https://api.github.com/users/Shadowmech88/followers","following_url":"https://api.github.com/users/Shadowmech88/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmech88/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmech88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmech88/subscriptions","organizations_url":"https://api.github.com/users/Shadowmech88/orgs","repos_url":"https://api.github.com/users/Shadowmech88/repos","events_url":"https://api.github.com/users/Shadowmech88/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmech88/received_events","type":"User","site_admin":false},"created_at":"2017-06-19T03:39:42Z","updated_at":"2017-06-19T03:39:42Z","body":"I think the issue is people metagaming in ways that can't be reliably tracked, or reliably judged due to plausible deniability.\r\nSure, you can't *call them out* as an antag due to flavor text or whatever, but you could be more cautious around them than you would otherwise, in a way that can't be detected by others but still impacts the round nonetheless.\r\n\r\nIf we have the ability to patch those holes via code without any major impact to the quality of the feature, shouldn't we?\r\n"}}
{"actor":{"display_login":"Shadowmech88"}}