{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/svt/pulls/comments/121715666","pull_request_review_id":43765492,"id":121715666,"diff_hunk":"@@ -4,38 +4,53 @@\n     policy: targeted\n     state: enforcing\n \n-- name: copy docker-storage-setup config when storage driver is devicemapper\n+- name: copy docker-storage-setup config\n   template:\n-    src: etc/sysconfig/docker-storage-setup.j2\n+    src: etc/sysconfig/docker-storage-{{ docker_storage_driver}}-setup.j2\n     dest: /etc/sysconfig/docker-storage-setup\n-  when: docker_storage_driver == \"devicemapper\"\n-\n-- name: copy docker-storage-setup config when storage mapper is overlay\n-  template:\n-    src: etc/sysconfig/docker-storage-overlay-setup.j2\n-    dest: /etc/sysconfig/docker-storage-setup\n-  when: docker_storage_driver == \"overlay2\"\n \n - name: create docker config directory\n   file:\n     path: /root/.docker\n     state: directory\n \n-- name: download docker login config.json\n-  copy:\n-    src: /root/{{ config_repo }}/image_provisioner/config.json\n-    dest: /root/.docker/\n-    remote_src: true\n+- block:\n+    - name: download docker login config.json on originating/master machine\n+      copy:\n+        src: /root/{{ config_repo }}/image_provisioner/config.json\n+        dest: /root/.docker/\n+    \n+    - name: remove docker-storage entry\n+      file:\n+        path: /etc/sysconfig/docker-storage\n+        state: absent\n+  when:  atomic | default(False) | bool","path":"image_provisioner/playbooks/roles/docker-config/tasks/main.yaml","position":38,"original_position":38,"commit_id":"f73d156cd676f66e3ff3c21d2281b532ea5ef6b1","original_commit_id":"f73d156cd676f66e3ff3c21d2281b532ea5ef6b1","user":{"login":"sjug","id":7550641,"avatar_url":"https://avatars0.githubusercontent.com/u/7550641?v=3","gravatar_id":"","url":"https://api.github.com/users/sjug","html_url":"https://github.com/sjug","followers_url":"https://api.github.com/users/sjug/followers","following_url":"https://api.github.com/users/sjug/following{/other_user}","gists_url":"https://api.github.com/users/sjug/gists{/gist_id}","starred_url":"https://api.github.com/users/sjug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjug/subscriptions","organizations_url":"https://api.github.com/users/sjug/orgs","repos_url":"https://api.github.com/users/sjug/repos","events_url":"https://api.github.com/users/sjug/events{/privacy}","received_events_url":"https://api.github.com/users/sjug/received_events","type":"User","site_admin":false},"body":"Pretty sure you want this to happen for `not atomic`?","created_at":"2017-06-13T15:37:52Z","updated_at":"2017-06-13T15:37:52Z","html_url":"https://github.com/openshift/svt/pull/217#discussion_r121715666","pull_request_url":"https://api.github.com/repos/openshift/svt/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/openshift/svt/pulls/comments/121715666"},"html":{"href":"https://github.com/openshift/svt/pull/217#discussion_r121715666"},"pull_request":{"href":"https://api.github.com/repos/openshift/svt/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/svt/pulls/217","id":124277284,"html_url":"https://github.com/openshift/svt/pull/217","diff_url":"https://github.com/openshift/svt/pull/217.diff","patch_url":"https://github.com/openshift/svt/pull/217.patch","issue_url":"https://api.github.com/repos/openshift/svt/issues/217","number":217,"state":"open","locked":false,"title":"Add support to image provisioner to generate atomic image","user":{"login":"chaitanyaenr","id":14077093,"avatar_url":"https://avatars2.githubusercontent.com/u/14077093?v=3","gravatar_id":"","url":"https://api.github.com/users/chaitanyaenr","html_url":"https://github.com/chaitanyaenr","followers_url":"https://api.github.com/users/chaitanyaenr/followers","following_url":"https://api.github.com/users/chaitanyaenr/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyaenr/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyaenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyaenr/subscriptions","organizations_url":"https://api.github.com/users/chaitanyaenr/orgs","repos_url":"https://api.github.com/users/chaitanyaenr/repos","events_url":"https://api.github.com/users/chaitanyaenr/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyaenr/received_events","type":"User","site_admin":false},"body":"- set atomic variable to True and run build_atomic_ami.yaml to generate\r\n  an atomic ami.\r\n- pbench-agent, pbench-controller, collectd images are included in ami.\r\n- openshift template to launch pbench-agent pods is included in the ami.","created_at":"2017-06-06T20:09:43Z","updated_at":"2017-06-13T15:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f39620d54963c9c9237fa36d845abd5cab08802","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/svt/pulls/217/commits","review_comments_url":"https://api.github.com/repos/openshift/svt/pulls/217/comments","review_comment_url":"https://api.github.com/repos/openshift/svt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/svt/issues/217/comments","statuses_url":"https://api.github.com/repos/openshift/svt/statuses/f73d156cd676f66e3ff3c21d2281b532ea5ef6b1","head":{"label":"chaitanyaenr:atomic_image","ref":"atomic_image","sha":"f73d156cd676f66e3ff3c21d2281b532ea5ef6b1","user":{"login":"chaitanyaenr","id":14077093,"avatar_url":"https://avatars2.githubusercontent.com/u/14077093?v=3","gravatar_id":"","url":"https://api.github.com/users/chaitanyaenr","html_url":"https://github.com/chaitanyaenr","followers_url":"https://api.github.com/users/chaitanyaenr/followers","following_url":"https://api.github.com/users/chaitanyaenr/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyaenr/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyaenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyaenr/subscriptions","organizations_url":"https://api.github.com/users/chaitanyaenr/orgs","repos_url":"https://api.github.com/users/chaitanyaenr/repos","events_url":"https://api.github.com/users/chaitanyaenr/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyaenr/received_events","type":"User","site_admin":false},"repo":{"id":81843738,"name":"svt","full_name":"chaitanyaenr/svt","owner":{"login":"chaitanyaenr","id":14077093,"avatar_url":"https://avatars2.githubusercontent.com/u/14077093?v=3","gravatar_id":"","url":"https://api.github.com/users/chaitanyaenr","html_url":"https://github.com/chaitanyaenr","followers_url":"https://api.github.com/users/chaitanyaenr/followers","following_url":"https://api.github.com/users/chaitanyaenr/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyaenr/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyaenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyaenr/subscriptions","organizations_url":"https://api.github.com/users/chaitanyaenr/orgs","repos_url":"https://api.github.com/users/chaitanyaenr/repos","events_url":"https://api.github.com/users/chaitanyaenr/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyaenr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaitanyaenr/svt","description":null,"fork":true,"url":"https://api.github.com/repos/chaitanyaenr/svt","forks_url":"https://api.github.com/repos/chaitanyaenr/svt/forks","keys_url":"https://api.github.com/repos/chaitanyaenr/svt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaitanyaenr/svt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaitanyaenr/svt/teams","hooks_url":"https://api.github.com/repos/chaitanyaenr/svt/hooks","issue_events_url":"https://api.github.com/repos/chaitanyaenr/svt/issues/events{/number}","events_url":"https://api.github.com/repos/chaitanyaenr/svt/events","assignees_url":"https://api.github.com/repos/chaitanyaenr/svt/assignees{/user}","branches_url":"https://api.github.com/repos/chaitanyaenr/svt/branches{/branch}","tags_url":"https://api.github.com/repos/chaitanyaenr/svt/tags","blobs_url":"https://api.github.com/repos/chaitanyaenr/svt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaitanyaenr/svt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaitanyaenr/svt/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaitanyaenr/svt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaitanyaenr/svt/statuses/{sha}","languages_url":"https://api.github.com/repos/chaitanyaenr/svt/languages","stargazers_url":"https://api.github.com/repos/chaitanyaenr/svt/stargazers","contributors_url":"https://api.github.com/repos/chaitanyaenr/svt/contributors","subscribers_url":"https://api.github.com/repos/chaitanyaenr/svt/subscribers","subscription_url":"https://api.github.com/repos/chaitanyaenr/svt/subscription","commits_url":"https://api.github.com/repos/chaitanyaenr/svt/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaitanyaenr/svt/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaitanyaenr/svt/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaitanyaenr/svt/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaitanyaenr/svt/contents/{+path}","compare_url":"https://api.github.com/repos/chaitanyaenr/svt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaitanyaenr/svt/merges","archive_url":"https://api.github.com/repos/chaitanyaenr/svt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaitanyaenr/svt/downloads","issues_url":"https://api.github.com/repos/chaitanyaenr/svt/issues{/number}","pulls_url":"https://api.github.com/repos/chaitanyaenr/svt/pulls{/number}","milestones_url":"https://api.github.com/repos/chaitanyaenr/svt/milestones{/number}","notifications_url":"https://api.github.com/repos/chaitanyaenr/svt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaitanyaenr/svt/labels{/name}","releases_url":"https://api.github.com/repos/chaitanyaenr/svt/releases{/id}","deployments_url":"https://api.github.com/repos/chaitanyaenr/svt/deployments","created_at":"2017-02-13T16:07:43Z","updated_at":"2017-02-13T16:07:46Z","pushed_at":"2017-06-13T15:20:48Z","git_url":"git://github.com/chaitanyaenr/svt.git","ssh_url":"git@github.com:chaitanyaenr/svt.git","clone_url":"https://github.com/chaitanyaenr/svt.git","svn_url":"https://github.com/chaitanyaenr/svt","homepage":null,"size":9592,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"35374a52a4e8f3a612526d554cecc90c0151914e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58750160,"name":"svt","full_name":"openshift/svt","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/svt","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/svt","forks_url":"https://api.github.com/repos/openshift/svt/forks","keys_url":"https://api.github.com/repos/openshift/svt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/svt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/svt/teams","hooks_url":"https://api.github.com/repos/openshift/svt/hooks","issue_events_url":"https://api.github.com/repos/openshift/svt/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/svt/events","assignees_url":"https://api.github.com/repos/openshift/svt/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/svt/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/svt/tags","blobs_url":"https://api.github.com/repos/openshift/svt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/svt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/svt/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/svt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/svt/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/svt/languages","stargazers_url":"https://api.github.com/repos/openshift/svt/stargazers","contributors_url":"https://api.github.com/repos/openshift/svt/contributors","subscribers_url":"https://api.github.com/repos/openshift/svt/subscribers","subscription_url":"https://api.github.com/repos/openshift/svt/subscription","commits_url":"https://api.github.com/repos/openshift/svt/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/svt/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/svt/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/svt/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/svt/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/svt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/svt/merges","archive_url":"https://api.github.com/repos/openshift/svt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/svt/downloads","issues_url":"https://api.github.com/repos/openshift/svt/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/svt/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/svt/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/svt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/svt/labels{/name}","releases_url":"https://api.github.com/repos/openshift/svt/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/svt/deployments","created_at":"2016-05-13T15:07:19Z","updated_at":"2017-06-01T12:16:11Z","pushed_at":"2017-06-13T15:22:24Z","git_url":"git://github.com/openshift/svt.git","ssh_url":"git@github.com:openshift/svt.git","clone_url":"https://github.com/openshift/svt.git","svn_url":"https://github.com/openshift/svt","homepage":null,"size":9599,"stargazers_count":35,"watchers_count":35,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":53,"forks":28,"open_issues":53,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/svt/pulls/217"},"html":{"href":"https://github.com/openshift/svt/pull/217"},"issue":{"href":"https://api.github.com/repos/openshift/svt/issues/217"},"comments":{"href":"https://api.github.com/repos/openshift/svt/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/svt/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/svt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/svt/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/svt/statuses/f73d156cd676f66e3ff3c21d2281b532ea5ef6b1"}}}}
{"actor":{"display_login":"sjug"}}