{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments/145868136","pull_request_review_id":70732754,"id":145868136,"diff_hunk":"@@ -143,12 +143,12 @@ public void updateAsyncTest() throws BaseException, ExecutionException, Interrup\n         HttpResponse response = new HttpResponse();\n         response.setStatusCode(200);\n         ValueApiModel model = new ValueApiModel(key, data, etagNew, null);\n-        response.setContent(Json.stringify(Json.toJson(model)));\n+        response.setContent(Json.stringify(Json.toJson(model)).replace(\"ETag\", \"Etag\"));","path":"test/com/microsoft/azure/iotsolutions/uiconfig/services/StorageAdapterClientTest.java","position":60,"original_position":60,"commit_id":"b0e8c081e0bf3c0efd86a9674b93d165e08f9cc7","original_commit_id":"b0e8c081e0bf3c0efd86a9674b93d165e08f9cc7","user":{"login":"v-limliu","id":26808087,"avatar_url":"https://avatars0.githubusercontent.com/u/26808087?v=4","gravatar_id":"","url":"https://api.github.com/users/v-limliu","html_url":"https://github.com/v-limliu","followers_url":"https://api.github.com/users/v-limliu/followers","following_url":"https://api.github.com/users/v-limliu/following{/other_user}","gists_url":"https://api.github.com/users/v-limliu/gists{/gist_id}","starred_url":"https://api.github.com/users/v-limliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-limliu/subscriptions","organizations_url":"https://api.github.com/users/v-limliu/orgs","repos_url":"https://api.github.com/users/v-limliu/repos","events_url":"https://api.github.com/users/v-limliu/events{/privacy}","received_events_url":"https://api.github.com/users/v-limliu/received_events","type":"User","site_admin":false},"body":"have open  an  bug :https://github.com/Azure/pcs-storage-adapter-java/issues/42","created_at":"2017-10-20T02:46:18Z","updated_at":"2017-10-20T02:46:18Z","html_url":"https://github.com/Azure/pcs-config-java/pull/47#discussion_r145868136","pull_request_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments/145868136"},"html":{"href":"https://github.com/Azure/pcs-config-java/pull/47#discussion_r145868136"},"pull_request":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47"}},"in_reply_to_id":145860157},"pull_request":{"url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47","id":147465087,"html_url":"https://github.com/Azure/pcs-config-java/pull/47","diff_url":"https://github.com/Azure/pcs-config-java/pull/47.diff","patch_url":"https://github.com/Azure/pcs-config-java/pull/47.patch","issue_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/47","number":47,"state":"open","locked":false,"title":"Apply white-list feature  for cache module","user":{"login":"v-limliu","id":26808087,"avatar_url":"https://avatars0.githubusercontent.com/u/26808087?v=4","gravatar_id":"","url":"https://api.github.com/users/v-limliu","html_url":"https://github.com/v-limliu","followers_url":"https://api.github.com/users/v-limliu/followers","following_url":"https://api.github.com/users/v-limliu/following{/other_user}","gists_url":"https://api.github.com/users/v-limliu/gists{/gist_id}","starred_url":"https://api.github.com/users/v-limliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-limliu/subscriptions","organizations_url":"https://api.github.com/users/v-limliu/orgs","repos_url":"https://api.github.com/users/v-limliu/repos","events_url":"https://api.github.com/users/v-limliu/events{/privacy}","received_events_url":"https://api.github.com/users/v-limliu/received_events","type":"User","site_admin":false},"body":"# Types of changes\r\n\r\n<!-- Please put an `x` without spaces (e.g. [x]) in all the boxes that apply: -->\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n# Checklist:\r\n\r\n<!-- Please put an `x` without spaces (e.g. [x]) in all the boxes that apply: -->\r\n\r\n- [x] The code follows the code style and conventions of this project.\r\n- [x] All new and existing tests passed.\r\n- [ ] The change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n# Description of the change\r\n\r\nCache module has added more unexpected tag ,properties.So need a white-list to filter these ones.\r\n\r\n This PR will apply white-list to tag or property names retrieved from IoTHub while rebuilding the device group filter cache\r\n\r\n# Motivation for the change\r\n\r\nIt is a new feature \r\n\r\n","created_at":"2017-10-19T04:30:43Z","updated_at":"2017-10-20T02:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e9c646a2e4424dec8f6399e35c9673c1e43943","assignee":{"login":"v-limliu","id":26808087,"avatar_url":"https://avatars0.githubusercontent.com/u/26808087?v=4","gravatar_id":"","url":"https://api.github.com/users/v-limliu","html_url":"https://github.com/v-limliu","followers_url":"https://api.github.com/users/v-limliu/followers","following_url":"https://api.github.com/users/v-limliu/following{/other_user}","gists_url":"https://api.github.com/users/v-limliu/gists{/gist_id}","starred_url":"https://api.github.com/users/v-limliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-limliu/subscriptions","organizations_url":"https://api.github.com/users/v-limliu/orgs","repos_url":"https://api.github.com/users/v-limliu/repos","events_url":"https://api.github.com/users/v-limliu/events{/privacy}","received_events_url":"https://api.github.com/users/v-limliu/received_events","type":"User","site_admin":false},"assignees":[{"login":"v-limliu","id":26808087,"avatar_url":"https://avatars0.githubusercontent.com/u/26808087?v=4","gravatar_id":"","url":"https://api.github.com/users/v-limliu","html_url":"https://github.com/v-limliu","followers_url":"https://api.github.com/users/v-limliu/followers","following_url":"https://api.github.com/users/v-limliu/following{/other_user}","gists_url":"https://api.github.com/users/v-limliu/gists{/gist_id}","starred_url":"https://api.github.com/users/v-limliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-limliu/subscriptions","organizations_url":"https://api.github.com/users/v-limliu/orgs","repos_url":"https://api.github.com/users/v-limliu/repos","events_url":"https://api.github.com/users/v-limliu/events{/privacy}","received_events_url":"https://api.github.com/users/v-limliu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zhang-hua","id":2011059,"avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47/commits","review_comments_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47/comments","review_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/47/comments","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/b0e8c081e0bf3c0efd86a9674b93d165e08f9cc7","head":{"label":"Azure:whitelist","ref":"whitelist","sha":"b0e8c081e0bf3c0efd86a9674b93d165e08f9cc7","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":96269429,"name":"pcs-config-java","full_name":"Azure/pcs-config-java","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-config-java","description":"The configuration microservice for Azure IoT Solutions","fork":false,"url":"https://api.github.com/repos/Azure/pcs-config-java","forks_url":"https://api.github.com/repos/Azure/pcs-config-java/forks","keys_url":"https://api.github.com/repos/Azure/pcs-config-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-config-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-config-java/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-config-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-config-java/events","assignees_url":"https://api.github.com/repos/Azure/pcs-config-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-config-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-config-java/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-config-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-config-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-config-java/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-config-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-config-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-config-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-config-java/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-config-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-config-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-config-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-config-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-config-java/merges","archive_url":"https://api.github.com/repos/Azure/pcs-config-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-config-java/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-config-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-config-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-config-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-config-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-config-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-config-java/deployments","created_at":"2017-07-05T02:37:33Z","updated_at":"2017-10-02T23:40:44Z","pushed_at":"2017-10-20T01:22:10Z","git_url":"git://github.com/Azure/pcs-config-java.git","ssh_url":"git@github.com:Azure/pcs-config-java.git","clone_url":"https://github.com/Azure/pcs-config-java.git","svn_url":"https://github.com/Azure/pcs-config-java","homepage":"","size":1209,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"33aaa69d4931d840e6b38383a8878539ae8b088e","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":96269429,"name":"pcs-config-java","full_name":"Azure/pcs-config-java","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-config-java","description":"The configuration microservice for Azure IoT Solutions","fork":false,"url":"https://api.github.com/repos/Azure/pcs-config-java","forks_url":"https://api.github.com/repos/Azure/pcs-config-java/forks","keys_url":"https://api.github.com/repos/Azure/pcs-config-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-config-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-config-java/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-config-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-config-java/events","assignees_url":"https://api.github.com/repos/Azure/pcs-config-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-config-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-config-java/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-config-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-config-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-config-java/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-config-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-config-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-config-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-config-java/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-config-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-config-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-config-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-config-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-config-java/merges","archive_url":"https://api.github.com/repos/Azure/pcs-config-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-config-java/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-config-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-config-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-config-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-config-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-config-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-config-java/deployments","created_at":"2017-07-05T02:37:33Z","updated_at":"2017-10-02T23:40:44Z","pushed_at":"2017-10-20T01:22:10Z","git_url":"git://github.com/Azure/pcs-config-java.git","ssh_url":"git@github.com:Azure/pcs-config-java.git","clone_url":"https://github.com/Azure/pcs-config-java.git","svn_url":"https://github.com/Azure/pcs-config-java","homepage":"","size":1209,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47"},"html":{"href":"https://github.com/Azure/pcs-config-java/pull/47"},"issue":{"href":"https://api.github.com/repos/Azure/pcs-config-java/issues/47"},"comments":{"href":"https://api.github.com/repos/Azure/pcs-config-java/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/pcs-config-java/statuses/b0e8c081e0bf3c0efd86a9674b93d165e08f9cc7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"v-limliu"}}