{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/119315288","pull_request_review_id":41181330,"id":119315288,"diff_hunk":"@@ -18,10 +18,14 @@\n       line_items_price BigDecimal.new(10)\n     end\n \n+    # TODO: Improve the name of this factory.","path":"core/lib/spree/testing_support/factories/order_factory.rb","position":null,"original_position":4,"commit_id":"745cdcf92eeaac3d922ee38629f3cd78f34c4a5d","original_commit_id":"73f603ae6d1f671606fb30ca8d475cd46c944abf","user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars3.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"body":"Fixed in a fixup commit 745cdcf9","created_at":"2017-05-31T09:44:53Z","updated_at":"2017-05-31T09:44:53Z","html_url":"https://github.com/solidusio/solidus/pull/1980#discussion_r119315288","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1980","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/119315288"},"html":{"href":"https://github.com/solidusio/solidus/pull/1980#discussion_r119315288"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1980"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1980","id":123010231,"html_url":"https://github.com/solidusio/solidus/pull/1980","diff_url":"https://github.com/solidusio/solidus/pull/1980.diff","patch_url":"https://github.com/solidusio/solidus/pull/1980.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1980","number":1980,"state":"open","locked":false,"title":"Improve order factories","user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars3.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"body":"This change mostly adds improved test coverage for the order factories, but does modify the behavior of the order factories as well:\r\n* `order_with_totals` can now be built instead of just being created\r\n* `completed_order_with_totals` was calling `refresh_shipment_rates` which was causing the `shipping_method` argument passed to the factory to be ignored. Removing that call resulted in no test failures and the requested `shipping_method` to be assigned correctly.\r\n\r\nOne question this PR raises for me is building the factories does not result in the same output as creating. If we don't care about being able to build, I would like to find some way to raise an exception when we call build on a factory known not to produce the expected outputs. I'm not sure how to do this.","created_at":"2017-05-30T09:46:49Z","updated_at":"2017-05-31T09:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec3e09f37bfea578407325dcbd96edfe1d59e7e6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1980/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1980/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1980/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/745cdcf92eeaac3d922ee38629f3cd78f34c4a5d","head":{"label":"TommyJohnWear:order_Factory_test_master","ref":"order_Factory_test_master","sha":"745cdcf92eeaac3d922ee38629f3cd78f34c4a5d","user":{"login":"TommyJohnWear","id":7293672,"avatar_url":"https://avatars0.githubusercontent.com/u/7293672?v=3","gravatar_id":"","url":"https://api.github.com/users/TommyJohnWear","html_url":"https://github.com/TommyJohnWear","followers_url":"https://api.github.com/users/TommyJohnWear/followers","following_url":"https://api.github.com/users/TommyJohnWear/following{/other_user}","gists_url":"https://api.github.com/users/TommyJohnWear/gists{/gist_id}","starred_url":"https://api.github.com/users/TommyJohnWear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TommyJohnWear/subscriptions","organizations_url":"https://api.github.com/users/TommyJohnWear/orgs","repos_url":"https://api.github.com/users/TommyJohnWear/repos","events_url":"https://api.github.com/users/TommyJohnWear/events{/privacy}","received_events_url":"https://api.github.com/users/TommyJohnWear/received_events","type":"Organization","site_admin":false},"repo":{"id":37993649,"name":"solidus","full_name":"TommyJohnWear/solidus","owner":{"login":"TommyJohnWear","id":7293672,"avatar_url":"https://avatars0.githubusercontent.com/u/7293672?v=3","gravatar_id":"","url":"https://api.github.com/users/TommyJohnWear","html_url":"https://github.com/TommyJohnWear","followers_url":"https://api.github.com/users/TommyJohnWear/followers","following_url":"https://api.github.com/users/TommyJohnWear/following{/other_user}","gists_url":"https://api.github.com/users/TommyJohnWear/gists{/gist_id}","starred_url":"https://api.github.com/users/TommyJohnWear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TommyJohnWear/subscriptions","organizations_url":"https://api.github.com/users/TommyJohnWear/orgs","repos_url":"https://api.github.com/users/TommyJohnWear/repos","events_url":"https://api.github.com/users/TommyJohnWear/events{/privacy}","received_events_url":"https://api.github.com/users/TommyJohnWear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TommyJohnWear/solidus","description":"Solidus e-commerce system","fork":true,"url":"https://api.github.com/repos/TommyJohnWear/solidus","forks_url":"https://api.github.com/repos/TommyJohnWear/solidus/forks","keys_url":"https://api.github.com/repos/TommyJohnWear/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TommyJohnWear/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TommyJohnWear/solidus/teams","hooks_url":"https://api.github.com/repos/TommyJohnWear/solidus/hooks","issue_events_url":"https://api.github.com/repos/TommyJohnWear/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/TommyJohnWear/solidus/events","assignees_url":"https://api.github.com/repos/TommyJohnWear/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/TommyJohnWear/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/TommyJohnWear/solidus/tags","blobs_url":"https://api.github.com/repos/TommyJohnWear/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TommyJohnWear/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TommyJohnWear/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/TommyJohnWear/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TommyJohnWear/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/TommyJohnWear/solidus/languages","stargazers_url":"https://api.github.com/repos/TommyJohnWear/solidus/stargazers","contributors_url":"https://api.github.com/repos/TommyJohnWear/solidus/contributors","subscribers_url":"https://api.github.com/repos/TommyJohnWear/solidus/subscribers","subscription_url":"https://api.github.com/repos/TommyJohnWear/solidus/subscription","commits_url":"https://api.github.com/repos/TommyJohnWear/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/TommyJohnWear/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/TommyJohnWear/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/TommyJohnWear/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/TommyJohnWear/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/TommyJohnWear/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TommyJohnWear/solidus/merges","archive_url":"https://api.github.com/repos/TommyJohnWear/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TommyJohnWear/solidus/downloads","issues_url":"https://api.github.com/repos/TommyJohnWear/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/TommyJohnWear/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/TommyJohnWear/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/TommyJohnWear/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TommyJohnWear/solidus/labels{/name}","releases_url":"https://api.github.com/repos/TommyJohnWear/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/TommyJohnWear/solidus/deployments","created_at":"2015-06-24T15:36:04Z","updated_at":"2016-10-26T15:12:43Z","pushed_at":"2017-05-31T09:44:28Z","git_url":"git://github.com/TommyJohnWear/solidus.git","ssh_url":"git@github.com:TommyJohnWear/solidus.git","clone_url":"https://github.com/TommyJohnWear/solidus.git","svn_url":"https://github.com/TommyJohnWear/solidus","homepage":"","size":69962,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"2e7ea309e2bf2e1cd556159fefa9c5d1d2b0e86c","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars2.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars2.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2017-05-29T10:41:11Z","pushed_at":"2017-05-31T09:44:30Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":66143,"stargazers_count":1383,"watchers_count":1383,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":449,"mirror_url":null,"open_issues_count":230,"forks":449,"open_issues":230,"watchers":1383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1980"},"html":{"href":"https://github.com/solidusio/solidus/pull/1980"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1980"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1980/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1980/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1980/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/745cdcf92eeaac3d922ee38629f3cd78f34c4a5d"}}}}
{"actor":{"display_login":"bbuchalter"}}