{"action":"created","comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/145005774","pull_request_review_id":69741503,"id":145005774,"diff_hunk":"@@ -142,8 +142,8 @@ void DlgUpdate::finishedUpdateCheck(bool needToUpdate, bool isCompatible, Releas\n             tr(\"A new version of Cockatrice is available!\") + \"<br><br>\"\n             + \"<b>\" + tr(\"New version\") + QString(\":</b> %1<br>\").arg(release->getName())\n             + \"<b>\" + tr(\"Released\") + QString(\":</b> %1 <a href=\\\"%2\\\">(\").arg(publishDate, release->getDescriptionUrl()) + tr(\"Changelog\") + \")</a><br><br>\"\n-            + tr(\"Unfortunately there are no download packages available for your operating system. \\nYou may have to build from source yourself.\") + \"<br><br>\"\n-            + tr(\"Please check the download page manually and visit the wiki for instructions on compiling.\"));\n+            + tr(\"Unfortunately there could no download package for your operating system be found. Please check the download page manually.\") + \"<br><br>\"","path":"cockatrice/src/dlg_update.cpp","position":null,"original_position":6,"commit_id":"02a75adf1a19a6384f1dfa2f7ee92b4516304b3e","original_commit_id":"c63e0995296514450164b115c3d86ba8106af632","user":{"login":"Nightfirecat","id":2199511,"avatar_url":"https://avatars2.githubusercontent.com/u/2199511?v=4","gravatar_id":"","url":"https://api.github.com/users/Nightfirecat","html_url":"https://github.com/Nightfirecat","followers_url":"https://api.github.com/users/Nightfirecat/followers","following_url":"https://api.github.com/users/Nightfirecat/following{/other_user}","gists_url":"https://api.github.com/users/Nightfirecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Nightfirecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nightfirecat/subscriptions","organizations_url":"https://api.github.com/users/Nightfirecat/orgs","repos_url":"https://api.github.com/users/Nightfirecat/repos","events_url":"https://api.github.com/users/Nightfirecat/events{/privacy}","received_events_url":"https://api.github.com/users/Nightfirecat/received_events","type":"User","site_admin":false},"body":"???","created_at":"2017-10-17T00:52:14Z","updated_at":"2017-10-17T00:52:14Z","html_url":"https://github.com/Cockatrice/Cockatrice/pull/2718#discussion_r145005774","pull_request_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/145005774"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/2718#discussion_r145005774"},"pull_request":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718"}}},"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718","id":120483279,"html_url":"https://github.com/Cockatrice/Cockatrice/pull/2718","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/2718.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/2718.patch","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2718","number":2718,"state":"open","locked":false,"title":"string reworks","user":{"login":"tooomm","id":9874850,"avatar_url":"https://avatars1.githubusercontent.com/u/9874850?v=4","gravatar_id":"","url":"https://api.github.com/users/tooomm","html_url":"https://github.com/tooomm","followers_url":"https://api.github.com/users/tooomm/followers","following_url":"https://api.github.com/users/tooomm/following{/other_user}","gists_url":"https://api.github.com/users/tooomm/gists{/gist_id}","starred_url":"https://api.github.com/users/tooomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooomm/subscriptions","organizations_url":"https://api.github.com/users/tooomm/orgs","repos_url":"https://api.github.com/users/tooomm/repos","events_url":"https://api.github.com/users/tooomm/events{/privacy}","received_events_url":"https://api.github.com/users/tooomm/received_events","type":"User","site_admin":false},"body":"## Short roundup of the initial problem\r\n- outdated update description\r\n- `\\n` at start of translation strings\r\n- `%1` in translation strings\r\n- possible html injections, because of `<br>` tags in messages from the server\r\n\r\n## What will change with this Pull Request?\r\n- correct update description\r\n- clean-up translation strings, split up text and formatting\r\n- easier for translators\r\n- better string readability in the code\r\n- always use `\\n` instead of html (`<br>`) to prevent possible code injection (if no other html is needed + wanted anyway)","created_at":"2017-05-14T11:55:41Z","updated_at":"2017-10-17T00:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c00fe2c73cf2af8c98c427647c882439b58e7f30","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718/commits","review_comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718/comments","review_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2718/comments","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/02a75adf1a19a6384f1dfa2f7ee92b4516304b3e","head":{"label":"Cockatrice:tooomm-missing_feature_msg_udpate","ref":"tooomm-missing_feature_msg_udpate","sha":"02a75adf1a19a6384f1dfa2f7ee92b4516304b3e","user":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/deployments","created_at":"2011-12-03T20:58:09Z","updated_at":"2017-10-16T19:30:34Z","pushed_at":"2017-10-16T12:11:24Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"https://cockatrice.github.io","size":39256,"stargazers_count":583,"watchers_count":583,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":486,"forks":273,"open_issues":486,"watchers":583,"default_branch":"master"}},"base":{"label":"Cockatrice:master","ref":"master","sha":"aca6917d42bf693037b1db7e57b62b7e1a744fa1","user":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/deployments","created_at":"2011-12-03T20:58:09Z","updated_at":"2017-10-16T19:30:34Z","pushed_at":"2017-10-16T12:11:24Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"https://cockatrice.github.io","size":39256,"stargazers_count":583,"watchers_count":583,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":486,"forks":273,"open_issues":486,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/2718"},"issue":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2718"},"comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2718/comments"},"review_comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718/comments"},"review_comment":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2718/commits"},"statuses":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/02a75adf1a19a6384f1dfa2f7ee92b4516304b3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Nightfirecat"}}