{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/137006063","pull_request_review_id":60619310,"id":137006063,"diff_hunk":"@@ -152,9 +158,20 @@ func PullImage(store storage.Store, imgName string, allTags, quiet bool, sc *typ\n \t\t\t\t}\n \t\t\t}\n \t\t}\n-\t} else if splitArr[0] == \"oci\" {\n-\t\t// needs to be implemented in future\n-\t\treturn errors.Errorf(\"oci not supported\")\n+\t} else if splitArr[0] == \"oci-archive\" {\n+\t\t// generate image reference with specified image:tag\n+\t\tif len(options.OciImage) > 0 {\n+\t\t\tsrcRef, err = ociarchive.NewReference(splitArr[len(splitArr)-1], options.OciImage)\n+\t\t\tif err != nil {\n+\t\t\t\treturn errors.Wrapf(err, \"error parsing image name %q\", options.OciImage)\n+\t\t\t}\n+\t\t}\n+\t\t// retrieve the manifest from index.json to access the image name\n+\t\tmanifest, err := ociarchive.LoadManifestDescriptor(srcRef)\n+\t\tif err != nil {\n+\t\t\treturn errors.Wrapf(err, \"error loading manifest for %q\", srcRef)\n+\t\t}\n+\t\timages = append(images, manifest.Annotations[\"org.opencontainers.image.ref.name\"])","path":"libkpod/image/copy.go","position":87,"original_position":61,"commit_id":"ab01f43f45dbd808f5c77536da807a8ec0da86f1","original_commit_id":"d4e6875a6bcc356f43df0ed5e3bb592bff6c82ff","user":{"login":"mtrmac","id":7052838,"avatar_url":"https://avatars2.githubusercontent.com/u/7052838?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"body":"What about archives generated by other tools?","created_at":"2017-09-05T14:36:32Z","updated_at":"2017-09-05T14:36:32Z","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/830#discussion_r137006063","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/137006063"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/830#discussion_r137006063"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830"}},"in_reply_to_id":136659593},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830","id":138756954,"html_url":"https://github.com/kubernetes-incubator/cri-o/pull/830","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/830.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/830.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/830","number":830,"state":"open","locked":false,"title":"Update kpod load and save for oci-archive","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"body":"https://github.com/kubernetes-incubator/cri-o/pull/829 needs to be merged in first.\r\n\r\nSigned-off-by: umohnani8 <umohnani@redhat.com>","created_at":"2017-08-31T20:18:46Z","updated_at":"2017-09-05T14:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06d04068a22dc8165318204288fa0d2771f95a62","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/830/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/ab01f43f45dbd808f5c77536da807a8ec0da86f1","head":{"label":"umohnani8:update_load-save","ref":"update_load-save","sha":"ab01f43f45dbd808f5c77536da807a8ec0da86f1","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"repo":{"id":94122280,"name":"cri-o","full_name":"umohnani8/cri-o","owner":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umohnani8/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/umohnani8/cri-o","forks_url":"https://api.github.com/repos/umohnani8/cri-o/forks","keys_url":"https://api.github.com/repos/umohnani8/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umohnani8/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umohnani8/cri-o/teams","hooks_url":"https://api.github.com/repos/umohnani8/cri-o/hooks","issue_events_url":"https://api.github.com/repos/umohnani8/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/umohnani8/cri-o/events","assignees_url":"https://api.github.com/repos/umohnani8/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/umohnani8/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/umohnani8/cri-o/tags","blobs_url":"https://api.github.com/repos/umohnani8/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umohnani8/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umohnani8/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/umohnani8/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umohnani8/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/umohnani8/cri-o/languages","stargazers_url":"https://api.github.com/repos/umohnani8/cri-o/stargazers","contributors_url":"https://api.github.com/repos/umohnani8/cri-o/contributors","subscribers_url":"https://api.github.com/repos/umohnani8/cri-o/subscribers","subscription_url":"https://api.github.com/repos/umohnani8/cri-o/subscription","commits_url":"https://api.github.com/repos/umohnani8/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/umohnani8/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/umohnani8/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/umohnani8/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/umohnani8/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/umohnani8/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umohnani8/cri-o/merges","archive_url":"https://api.github.com/repos/umohnani8/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umohnani8/cri-o/downloads","issues_url":"https://api.github.com/repos/umohnani8/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/umohnani8/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/umohnani8/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/umohnani8/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umohnani8/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/umohnani8/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/umohnani8/cri-o/deployments","created_at":"2017-06-12T17:25:43Z","updated_at":"2017-06-12T17:25:45Z","pushed_at":"2017-09-05T14:02:45Z","git_url":"git://github.com/umohnani8/cri-o.git","ssh_url":"git@github.com:umohnani8/cri-o.git","clone_url":"https://github.com/umohnani8/cri-o.git","svn_url":"https://github.com/umohnani8/cri-o","homepage":"","size":41074,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"8538c4067a9862c6c319cf2e9ddf2c264ce608f3","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":67828134,"name":"cri-o","full_name":"kubernetes-incubator/cri-o","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/deployments","created_at":"2016-09-09T19:56:31Z","updated_at":"2017-09-05T10:21:10Z","pushed_at":"2017-09-05T14:09:16Z","git_url":"git://github.com/kubernetes-incubator/cri-o.git","ssh_url":"git@github.com:kubernetes-incubator/cri-o.git","clone_url":"https://github.com/kubernetes-incubator/cri-o.git","svn_url":"https://github.com/kubernetes-incubator/cri-o","homepage":"","size":37169,"stargazers_count":596,"watchers_count":596,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":73,"forks":117,"open_issues":73,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/830"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/830"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/ab01f43f45dbd808f5c77536da807a8ec0da86f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mtrmac"}}