{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/141653550","pull_request_review_id":65902416,"id":141653550,"diff_hunk":"@@ -1,69 +1,185 @@\n-.heading {\n-    display: flex;\n-    font-family: \"Guardian Egyptian Web\", \"Guardian Text Egyptian Web\", Georgia, serif;\n-    font-size: 24px;\n-    font-weight: normal;\n-    line-height: 30px;\n-    margin: 10px 0 0;\n+wrapper {\n+    &:before {\n+        content: '';\n+        background: #005689;\n+        position: fixed;\n+        top: 0;\n+        right: 0;\n+        bottom: 0;\n+        left: 0;\n+        z-index: -1;\n+    }\n }\n \n-.logo {\n-    width: 250px;\n+mainContent {\n+    box-sizing: border-box;\n+    margin: 0 auto;\n+    padding: 0 10px 24px;\n+    position: relative;\n+\n+    @media (--from-tablet) {\n+        padding: 0;\n+        width: 740px;\n+    }\n \n-    & .guardian {\n-        @supports (fill: hotpink) {\n-            fill: var(--colour-brand-blue);\n+    @media (--from-desktop) {\n+        width: 980px;\n+    }\n \n-            /* example of a width media query range */\n-            @media (--from-tablet) and (--until-desktop) {\n-                fill: var(--colour-brand-blue);\n-            }\n-        }\n+    @media (--from-leftCol) {\n+        width: 1140px;\n     }\n+\n+     @media (--from-wide) {\n+         width: 1300px;\n+     }\n }\n \n-.fluidWrap {\n-    margin: 0 auto;\n-    max-width: 940px;\n-    padding: 0 10px;\n+logoWrapper {\n+    display: block;\n+    margin: 6px 0 36px auto;\n+    max-width: 384px;\n+    width: 65%;\n+    position: relative;\n+    z-index: 1;\n+\n+    @media (--from-tablet) {\n+        width: 384px;\n+    }\n+\n+    @media (--from-desktop) {\n+        margin-bottom: -60px;\n+    }\n+\n+    & svg .guardian path {","path":"ui/src/views/404/style.css","position":75,"original_position":75,"commit_id":"9a146009e0ef5af861ff5bcb3fbb10e1e079ddea","original_commit_id":"9a146009e0ef5af861ff5bcb3fbb10e1e079ddea","user":{"login":"sndrs","id":867233,"avatar_url":"https://avatars3.githubusercontent.com/u/867233?v=4","gravatar_id":"","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false},"body":"`svg` needed here?","created_at":"2017-09-28T15:33:58Z","updated_at":"2017-09-28T15:35:37Z","html_url":"https://github.com/guardian/frontend/pull/17889#discussion_r141653550","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/17889","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/141653550"},"html":{"href":"https://github.com/guardian/frontend/pull/17889#discussion_r141653550"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17889"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/17889","id":143676986,"html_url":"https://github.com/guardian/frontend/pull/17889","diff_url":"https://github.com/guardian/frontend/pull/17889.diff","patch_url":"https://github.com/guardian/frontend/pull/17889.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/17889","number":17889,"state":"open","locked":false,"title":"404 page new design","user":{"login":"SiAdcock","id":5931528,"avatar_url":"https://avatars1.githubusercontent.com/u/5931528?v=4","gravatar_id":"","url":"https://api.github.com/users/SiAdcock","html_url":"https://github.com/SiAdcock","followers_url":"https://api.github.com/users/SiAdcock/followers","following_url":"https://api.github.com/users/SiAdcock/following{/other_user}","gists_url":"https://api.github.com/users/SiAdcock/gists{/gist_id}","starred_url":"https://api.github.com/users/SiAdcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiAdcock/subscriptions","organizations_url":"https://api.github.com/users/SiAdcock/orgs","repos_url":"https://api.github.com/users/SiAdcock/repos","events_url":"https://api.github.com/users/SiAdcock/events{/privacy}","received_events_url":"https://api.github.com/users/SiAdcock/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\n\r\nRedesign the 404 page using our CSS componentisation solution. \r\n\r\n## What is the value of this and can you measure success?\r\n\r\n- Part of the value has been to test the developer experience of CSS components\r\n- Provides a jumping off point for future feature tests, such as lazy loading\r\n- Responsive design\r\n- And this design looks so much nicer doesn't it?\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNo\r\n\r\n## Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\n<!-- if there are versions of this content with the paid styling (teal and grey) then they will need to be checked -->\r\n<!-- content can be found here: https://www.theguardian.com/tone/advertisement-features -->\r\n\r\nNo\r\n\r\n## Screenshots\r\n\r\n**Before**\r\n\r\n![picture 296](https://user-images.githubusercontent.com/5931528/30974621-ff8d6662-a467-11e7-870b-f328f8f23c37.png)\r\n\r\n**After - Desktop**\r\n\r\n![picture 293](https://user-images.githubusercontent.com/5931528/30974631-04d61560-a468-11e7-83f7-28ce97d2fcb4.png)\r\n\r\n**After - Tablet**\r\n\r\n![picture 294](https://user-images.githubusercontent.com/5931528/30974639-086b2e36-a468-11e7-86b3-34fc4e227f13.png)\r\n\r\n**After - Mobile**\r\n\r\n![picture 295](https://user-images.githubusercontent.com/5931528/30974648-0db4738e-a468-11e7-8a97-15d88e52d28e.png)\r\n\r\n## Tested in CODE?\r\n\r\nNo\r\n\r\nc/c @zeftilldeath @blongden73 ","created_at":"2017-09-28T15:14:15Z","updated_at":"2017-09-28T15:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8996e3d2c5839f2653383b021ac2b60c65513cd4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GHaberis","id":1590704,"avatar_url":"https://avatars2.githubusercontent.com/u/1590704?v=4","gravatar_id":"","url":"https://api.github.com/users/GHaberis","html_url":"https://github.com/GHaberis","followers_url":"https://api.github.com/users/GHaberis/followers","following_url":"https://api.github.com/users/GHaberis/following{/other_user}","gists_url":"https://api.github.com/users/GHaberis/gists{/gist_id}","starred_url":"https://api.github.com/users/GHaberis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GHaberis/subscriptions","organizations_url":"https://api.github.com/users/GHaberis/orgs","repos_url":"https://api.github.com/users/GHaberis/repos","events_url":"https://api.github.com/users/GHaberis/events{/privacy}","received_events_url":"https://api.github.com/users/GHaberis/received_events","type":"User","site_admin":false},{"login":"NataliaLKB","id":8774970,"avatar_url":"https://avatars3.githubusercontent.com/u/8774970?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaLKB","html_url":"https://github.com/NataliaLKB","followers_url":"https://api.github.com/users/NataliaLKB/followers","following_url":"https://api.github.com/users/NataliaLKB/following{/other_user}","gists_url":"https://api.github.com/users/NataliaLKB/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaLKB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaLKB/subscriptions","organizations_url":"https://api.github.com/users/NataliaLKB/orgs","repos_url":"https://api.github.com/users/NataliaLKB/repos","events_url":"https://api.github.com/users/NataliaLKB/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaLKB/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/17889/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/17889/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/17889/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/9a146009e0ef5af861ff5bcb3fbb10e1e079ddea","head":{"label":"guardian:404-new-design","ref":"404-new-design","sha":"9a146009e0ef5af861ff5bcb3fbb10e1e079ddea","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-09-24T13:34:52Z","pushed_at":"2017-09-28T15:22:30Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":532448,"stargazers_count":3641,"watchers_count":3641,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":62,"forks":393,"open_issues":62,"watchers":3641,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ab059f872075ce88229e273f51d5d45bf21db890","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-09-24T13:34:52Z","pushed_at":"2017-09-28T15:22:30Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":532448,"stargazers_count":3641,"watchers_count":3641,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":62,"forks":393,"open_issues":62,"watchers":3641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17889"},"html":{"href":"https://github.com/guardian/frontend/pull/17889"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/17889"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/17889/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17889/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17889/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/9a146009e0ef5af861ff5bcb3fbb10e1e079ddea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sndrs"}}