{"action":"created","comment":{"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments/155228666","pull_request_review_id":81510350,"id":155228666,"diff_hunk":"@@ -1,17 +1,20 @@\n //@flow\n import React, { Component } from \"react\";\n import \"./SelectTab.css\";\n+\n type Props = {\n   tabs: string[],\n   onChange: Function,\n-  selected: number\n+  selected: number,\n+  theme?: \"inline\" | \"header\"\n };\n \n export default class SelectTab extends Component<Props, {}> {\n   render() {\n     const { tabs, onChange, selected } = this.props;\n+    const theme = this.props.theme ? this.props.theme : \"header\";","path":"src/components/SelectTab/SelectTab.js","position":16,"original_position":16,"commit_id":"03656e6c1bcee0f1a93eb680c7b6157bf44c3bb5","original_commit_id":"03656e6c1bcee0f1a93eb680c7b6157bf44c3bb5","user":{"login":"gre","id":211411,"avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"body":"probably could use a `static defaultProps` to default it. if you do so, I think you can use `theme: \"inline\" | \"header\"` (without the `?`)","created_at":"2017-12-06T12:58:56Z","updated_at":"2017-12-06T12:59:26Z","html_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/44#discussion_r155228666","pull_request_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments/155228666"},"html":{"href":"https://github.com/LedgerHQ/ledger-vault-front/pull/44#discussion_r155228666"},"pull_request":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44","id":156721376,"html_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/44","diff_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/44.diff","patch_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/44.patch","issue_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/44","number":44,"state":"open","locked":false,"title":"Select fix","user":{"login":"malikfassi","id":2527857,"avatar_url":"https://avatars1.githubusercontent.com/u/2527857?v=4","gravatar_id":"","url":"https://api.github.com/users/malikfassi","html_url":"https://github.com/malikfassi","followers_url":"https://api.github.com/users/malikfassi/followers","following_url":"https://api.github.com/users/malikfassi/following{/other_user}","gists_url":"https://api.github.com/users/malikfassi/gists{/gist_id}","starred_url":"https://api.github.com/users/malikfassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malikfassi/subscriptions","organizations_url":"https://api.github.com/users/malikfassi/orgs","repos_url":"https://api.github.com/users/malikfassi/repos","events_url":"https://api.github.com/users/malikfassi/events{/privacy}","received_events_url":"https://api.github.com/users/malikfassi/received_events","type":"User","site_admin":false},"body":"- Added theme prop to Select component. Two choices : -`header` or `inline`\r\n- Removed use of react tabs in Settings view. Used new SelectTab component instead","created_at":"2017-12-06T12:50:32Z","updated_at":"2017-12-06T12:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2373a40a68cf50b53d5e6fc1d71aee7023edc01","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/44/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/03656e6c1bcee0f1a93eb680c7b6157bf44c3bb5","head":{"label":"LedgerHQ:select-fix","ref":"select-fix","sha":"03656e6c1bcee0f1a93eb680c7b6157bf44c3bb5","user":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":92170617,"name":"ledger-vault-front","full_name":"LedgerHQ/ledger-vault-front","owner":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-vault-front","description":null,"fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/deployments","created_at":"2017-05-23T12:31:49Z","updated_at":"2017-11-27T19:56:53Z","pushed_at":"2017-12-06T12:57:13Z","git_url":"git://github.com/LedgerHQ/ledger-vault-front.git","ssh_url":"git@github.com:LedgerHQ/ledger-vault-front.git","clone_url":"https://github.com/LedgerHQ/ledger-vault-front.git","svn_url":"https://github.com/LedgerHQ/ledger-vault-front","homepage":null,"size":2915,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":3,"watchers":4,"default_branch":"develop"}},"base":{"label":"LedgerHQ:develop","ref":"develop","sha":"e9d07c4ee88c33fbddb38cc954171bfcb910f7a2","user":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":92170617,"name":"ledger-vault-front","full_name":"LedgerHQ/ledger-vault-front","owner":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-vault-front","description":null,"fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/deployments","created_at":"2017-05-23T12:31:49Z","updated_at":"2017-11-27T19:56:53Z","pushed_at":"2017-12-06T12:57:13Z","git_url":"git://github.com/LedgerHQ/ledger-vault-front.git","ssh_url":"git@github.com:LedgerHQ/ledger-vault-front.git","clone_url":"https://github.com/LedgerHQ/ledger-vault-front.git","svn_url":"https://github.com/LedgerHQ/ledger-vault-front","homepage":null,"size":2915,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":3,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44"},"html":{"href":"https://github.com/LedgerHQ/ledger-vault-front/pull/44"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/44"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/03656e6c1bcee0f1a93eb680c7b6157bf44c3bb5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gre"}}