{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19530","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19530/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19530/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19530/events","html_url":"https://github.com/cockroachdb/cockroach/issues/19530","id":268444027,"number":19530,"title":"build: make protobuf results are system-dependent","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-25T15:31:43Z","updated_at":"2017-10-25T15:39:06Z","closed_at":null,"author_association":"OWNER","body":"If I do `make protobufs` locally, I get the diffs below. I think the problem is that on my system the relative ordering of `mvcc.proto` and `mvcc_network_stats.proto` is different. Indeed, if I do `LC_COLLATE=C make protobuf`, the results are consistent with what's checked in. I think the makefile should do the `LC_COLLATE` thing internally. CC @benesch \r\n\r\n```diff\r\ndiff --git a/pkg/storage/engine/enginepb/mvcc.pb.go b/pkg/storage/engine/enginepb/mvcc.pb.go\r\nindex 40d5f06..e302b62 100644\r\n--- a/pkg/storage/engine/enginepb/mvcc.pb.go\r\n+++ b/pkg/storage/engine/enginepb/mvcc.pb.go\r\n@@ -1,22 +1,6 @@\r\n // Code generated by protoc-gen-gogo. DO NOT EDIT.\r\n // source: cockroach/pkg/storage/engine/enginepb/mvcc.proto\r\n \r\n-/*\r\n-\tPackage enginepb is a generated protocol buffer package.\r\n-\r\n-\tIt is generated from these files:\r\n-\t\tcockroach/pkg/storage/engine/enginepb/mvcc.proto\r\n-\t\tcockroach/pkg/storage/engine/enginepb/mvcc_network_stats.proto\r\n-\t\tcockroach/pkg/storage/engine/enginepb/rocksdb.proto\r\n-\r\n-\tIt has these top-level messages:\r\n-\t\tTxnMeta\r\n-\t\tMVCCMetadata\r\n-\t\tMVCCStats\r\n-\t\tMVCCNetworkStats\r\n-\t\tSSTUserProperties\r\n-\t\tSSTUserPropertiesCollection\r\n-*/\r\n package enginepb\r\n \r\n import proto \"github.com/gogo/protobuf/proto\"\r\n@@ -38,12 +22,6 @@ var _ = proto.Marshal\r\n var _ = fmt.Errorf\r\n var _ = math.Inf\r\n \r\n-// This is a compile-time assertion to ensure that this generated file\r\n-// is compatible with the proto package it is being compiled against.\r\n-// A compilation error at this line likely means your copy of the\r\n-// proto package needs to be updated.\r\n-const _ = proto.GoGoProtoPackageIsVersion2 // please upgrade the proto package\r\n-\r\n // TODO(tschottdorf): Should not live in enginepb (but can't live in roachpb\r\n // either).\r\n type IsolationType int32\r\ndiff --git a/pkg/storage/engine/enginepb/mvcc_network_stats.pb.go b/pkg/storage/engine/enginepb/mvcc_network_stats.pb.go\r\nindex a275ac1..194e566 100644\r\n--- a/pkg/storage/engine/enginepb/mvcc_network_stats.pb.go\r\n+++ b/pkg/storage/engine/enginepb/mvcc_network_stats.pb.go\r\n@@ -1,6 +1,22 @@\r\n // Code generated by protoc-gen-gogo. DO NOT EDIT.\r\n // source: cockroach/pkg/storage/engine/enginepb/mvcc_network_stats.proto\r\n \r\n+/*\r\n+\tPackage enginepb is a generated protocol buffer package.\r\n+\r\n+\tIt is generated from these files:\r\n+\t\tcockroach/pkg/storage/engine/enginepb/mvcc_network_stats.proto\r\n+\t\tcockroach/pkg/storage/engine/enginepb/mvcc.proto\r\n+\t\tcockroach/pkg/storage/engine/enginepb/rocksdb.proto\r\n+\r\n+\tIt has these top-level messages:\r\n+\t\tMVCCNetworkStats\r\n+\t\tTxnMeta\r\n+\t\tMVCCMetadata\r\n+\t\tMVCCStats\r\n+\t\tSSTUserProperties\r\n+\t\tSSTUserPropertiesCollection\r\n+*/\r\n package enginepb\r\n \r\n import proto \"github.com/gogo/protobuf/proto\"\r\n@@ -16,6 +32,12 @@ var _ = proto.Marshal\r\n var _ = fmt.Errorf\r\n var _ = math.Inf\r\n \r\n+// This is a compile-time assertion to ensure that this generated file\r\n+// is compatible with the proto package it is being compiled against.\r\n+// A compilation error at this line likely means your copy of the\r\n+// proto package needs to be updated.\r\n+const _ = proto.GoGoProtoPackageIsVersion2 // please upgrade the proto package\r\n+\r\n // MVCCNetworkStats is convertible to MVCCStats, but uses variable width\r\n // encodings for most fields. This makes the encodings incompatible. Note that\r\n // with proto3, zero-valued primitive types will not be encoded at all.\r\n```"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/339372879","html_url":"https://github.com/cockroachdb/cockroach/issues/19530#issuecomment-339372879","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19530","id":339372879,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars1.githubusercontent.com/u/160562?v=4","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T15:39:06Z","updated_at":"2017-10-25T15:39:06Z","author_association":"OWNER","body":"There's another `LC_COLLATE=C sort` invocation in `common.mk`. Maybe we should just export that as an environment variable in the top-level `Makefile` instead of stumbling across individual commands that require it? "}}
{"actor":{"display_login":"bdarnell"}}