{"action":"created","issue":{"url":"https://api.github.com/repos/contao/core-bundle/issues/1130","repository_url":"https://api.github.com/repos/contao/core-bundle","labels_url":"https://api.github.com/repos/contao/core-bundle/issues/1130/labels{/name}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/1130/comments","events_url":"https://api.github.com/repos/contao/core-bundle/issues/1130/events","html_url":"https://github.com/contao/core-bundle/issues/1130","id":263405524,"number":1130,"title":"Edit all crashes if you edit pageTree fields or add a link in TinyMCE","user":{"login":"bezin","id":4400435,"avatar_url":"https://avatars2.githubusercontent.com/u/4400435?v=4","gravatar_id":"","url":"https://api.github.com/users/bezin","html_url":"https://github.com/bezin","followers_url":"https://api.github.com/users/bezin/followers","following_url":"https://api.github.com/users/bezin/following{/other_user}","gists_url":"https://api.github.com/users/bezin/gists{/gist_id}","starred_url":"https://api.github.com/users/bezin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezin/subscriptions","organizations_url":"https://api.github.com/users/bezin/orgs","repos_url":"https://api.github.com/users/bezin/repos","events_url":"https://api.github.com/users/bezin/events{/privacy}","received_events_url":"https://api.github.com/users/bezin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-06T10:44:36Z","updated_at":"2017-10-13T10:18:35Z","closed_at":null,"author_association":"NONE","body":"Hello there,\r\n\r\nthe Edit All functionality fails under specific circumstances. \r\n\r\nTo reproduce, do the following in the online demo:\r\n\r\n1. Edit article \"Home\" \r\n2. Edit all > select both content elements > Select field \"text\"\r\n3. Select some text and format it as bold with the toolbar button\r\n4. Save > Everything works fine\r\n5. Select some text and mark it up as link with the toolbar button\r\n6. Select any page with the page picker\r\n7. Save > You will get the following output and an otherwise blank page:\r\n\r\n```\r\nWarning: implode(): Invalid arguments passed in /home/www/releases/12/vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php on line 342\r\n\r\nWarning: implode(): Invalid arguments passed in /home/www/releases/12/vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php on line 342\r\n\r\nWarning: implode(): Invalid arguments passed in /home/www/releases/12/vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php on line 342\r\n\r\nWarning: implode(): Invalid arguments passed in /home/www/releases/12/vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php on line 342\r\n\r\nWarning: implode(): Invalid arguments passed in /home/www/releases/12/vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php on line 342\r\n\r\n```\r\nThis also happens, if you multi edit a field of input type pageTree.\r\n\r\nIn an local Contao 4.4.5 installation: The $key = \"FORM_FIELDS_40\", that causes the warning in this setting, is a content element in a different article, on a different page, on a different root page. Anyhow, I did not figure out where this field ID is coming from.\r\n\r\n![contao_edit_all](https://user-images.githubusercontent.com/4400435/31274477-58f6495e-aa93-11e7-81c0-2b78e8c2b2e3.jpg)\r\n\r\nIf you need any more information, I willll try to provide them :)\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/contao/core-bundle/issues/comments/336412687","html_url":"https://github.com/contao/core-bundle/issues/1130#issuecomment-336412687","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/1130","id":336412687,"user":{"login":"leofeyer","id":1192057,"avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T10:18:35Z","updated_at":"2017-10-13T10:18:35Z","author_association":"OWNER","body":"This is because `$session['CURRENT']['IDS']` is overwritten as soon as you open the picker (which calls the `showAll()` method).\r\n\r\nhttps://github.com/contao/core-bundle/blob/a3b68142c327b787e01090d7d9c9737e699122b2/src/Resources/contao/drivers/DC_Table.php#L359\r\n\r\n@contao/developers IMO this is a left-over from the older days where Contao did not have checkboxes to select the records to edit in \"edit multiple\" mode. The IDs are actually set in line 147 now.\r\n\r\nhttps://github.com/contao/core-bundle/blob/a3b68142c327b787e01090d7d9c9737e699122b2/src/Resources/contao/drivers/DC_Table.php#L147\r\n\r\nI would therefore remove line 357 to 360. Any objections?"}}
{"actor":{"display_login":"leofeyer"}}