{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/realitix/vulkan/pulls/27","id":135188235,"html_url":"https://github.com/realitix/vulkan/pull/27","diff_url":"https://github.com/realitix/vulkan/pull/27.diff","patch_url":"https://github.com/realitix/vulkan/pull/27.patch","issue_url":"https://api.github.com/repos/realitix/vulkan/issues/27","number":27,"state":"closed","locked":false,"title":"Performance improvement in _callApi","user":{"login":"Berserker66","id":3189725,"avatar_url":"https://avatars2.githubusercontent.com/u/3189725?v=4","gravatar_id":"","url":"https://api.github.com/users/Berserker66","html_url":"https://github.com/Berserker66","followers_url":"https://api.github.com/users/Berserker66/followers","following_url":"https://api.github.com/users/Berserker66/following{/other_user}","gists_url":"https://api.github.com/users/Berserker66/gists{/gist_id}","starred_url":"https://api.github.com/users/Berserker66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Berserker66/subscriptions","organizations_url":"https://api.github.com/users/Berserker66/orgs","repos_url":"https://api.github.com/users/Berserker66/repos","events_url":"https://api.github.com/users/Berserker66/events{/privacy}","received_events_url":"https://api.github.com/users/Berserker66/received_events","type":"User","site_admin":false},"body":"In my test setup the _callApi function was taking over 90% of the render thread time.\r\nThis small change reduced that to 70-75% and improved performance a lot by giving more time to other tasks.","created_at":"2017-08-10T18:11:29Z","updated_at":"2017-08-13T05:45:03Z","closed_at":"2017-08-13T05:45:03Z","merged_at":null,"merge_commit_sha":"fba53e54f812491c72c81a3192e3f944ef6978b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/realitix/vulkan/pulls/27/commits","review_comments_url":"https://api.github.com/repos/realitix/vulkan/pulls/27/comments","review_comment_url":"https://api.github.com/repos/realitix/vulkan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realitix/vulkan/issues/27/comments","statuses_url":"https://api.github.com/repos/realitix/vulkan/statuses/fca44b35d1a23aad3ef6a2f243209718a6f18ed5","head":{"label":"Berserker66:master","ref":"master","sha":"fca44b35d1a23aad3ef6a2f243209718a6f18ed5","user":{"login":"Berserker66","id":3189725,"avatar_url":"https://avatars2.githubusercontent.com/u/3189725?v=4","gravatar_id":"","url":"https://api.github.com/users/Berserker66","html_url":"https://github.com/Berserker66","followers_url":"https://api.github.com/users/Berserker66/followers","following_url":"https://api.github.com/users/Berserker66/following{/other_user}","gists_url":"https://api.github.com/users/Berserker66/gists{/gist_id}","starred_url":"https://api.github.com/users/Berserker66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Berserker66/subscriptions","organizations_url":"https://api.github.com/users/Berserker66/orgs","repos_url":"https://api.github.com/users/Berserker66/repos","events_url":"https://api.github.com/users/Berserker66/events{/privacy}","received_events_url":"https://api.github.com/users/Berserker66/received_events","type":"User","site_admin":false},"repo":{"id":98342130,"name":"vulkan","full_name":"Berserker66/vulkan","owner":{"login":"Berserker66","id":3189725,"avatar_url":"https://avatars2.githubusercontent.com/u/3189725?v=4","gravatar_id":"","url":"https://api.github.com/users/Berserker66","html_url":"https://github.com/Berserker66","followers_url":"https://api.github.com/users/Berserker66/followers","following_url":"https://api.github.com/users/Berserker66/following{/other_user}","gists_url":"https://api.github.com/users/Berserker66/gists{/gist_id}","starred_url":"https://api.github.com/users/Berserker66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Berserker66/subscriptions","organizations_url":"https://api.github.com/users/Berserker66/orgs","repos_url":"https://api.github.com/users/Berserker66/repos","events_url":"https://api.github.com/users/Berserker66/events{/privacy}","received_events_url":"https://api.github.com/users/Berserker66/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Berserker66/vulkan","description":"The ultimate Python binding for Vulkan API","fork":true,"url":"https://api.github.com/repos/Berserker66/vulkan","forks_url":"https://api.github.com/repos/Berserker66/vulkan/forks","keys_url":"https://api.github.com/repos/Berserker66/vulkan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Berserker66/vulkan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Berserker66/vulkan/teams","hooks_url":"https://api.github.com/repos/Berserker66/vulkan/hooks","issue_events_url":"https://api.github.com/repos/Berserker66/vulkan/issues/events{/number}","events_url":"https://api.github.com/repos/Berserker66/vulkan/events","assignees_url":"https://api.github.com/repos/Berserker66/vulkan/assignees{/user}","branches_url":"https://api.github.com/repos/Berserker66/vulkan/branches{/branch}","tags_url":"https://api.github.com/repos/Berserker66/vulkan/tags","blobs_url":"https://api.github.com/repos/Berserker66/vulkan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Berserker66/vulkan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Berserker66/vulkan/git/refs{/sha}","trees_url":"https://api.github.com/repos/Berserker66/vulkan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Berserker66/vulkan/statuses/{sha}","languages_url":"https://api.github.com/repos/Berserker66/vulkan/languages","stargazers_url":"https://api.github.com/repos/Berserker66/vulkan/stargazers","contributors_url":"https://api.github.com/repos/Berserker66/vulkan/contributors","subscribers_url":"https://api.github.com/repos/Berserker66/vulkan/subscribers","subscription_url":"https://api.github.com/repos/Berserker66/vulkan/subscription","commits_url":"https://api.github.com/repos/Berserker66/vulkan/commits{/sha}","git_commits_url":"https://api.github.com/repos/Berserker66/vulkan/git/commits{/sha}","comments_url":"https://api.github.com/repos/Berserker66/vulkan/comments{/number}","issue_comment_url":"https://api.github.com/repos/Berserker66/vulkan/issues/comments{/number}","contents_url":"https://api.github.com/repos/Berserker66/vulkan/contents/{+path}","compare_url":"https://api.github.com/repos/Berserker66/vulkan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Berserker66/vulkan/merges","archive_url":"https://api.github.com/repos/Berserker66/vulkan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Berserker66/vulkan/downloads","issues_url":"https://api.github.com/repos/Berserker66/vulkan/issues{/number}","pulls_url":"https://api.github.com/repos/Berserker66/vulkan/pulls{/number}","milestones_url":"https://api.github.com/repos/Berserker66/vulkan/milestones{/number}","notifications_url":"https://api.github.com/repos/Berserker66/vulkan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Berserker66/vulkan/labels{/name}","releases_url":"https://api.github.com/repos/Berserker66/vulkan/releases{/id}","deployments_url":"https://api.github.com/repos/Berserker66/vulkan/deployments","created_at":"2017-07-25T19:24:06Z","updated_at":"2017-07-25T19:24:07Z","pushed_at":"2017-08-10T23:47:49Z","git_url":"git://github.com/Berserker66/vulkan.git","ssh_url":"git@github.com:Berserker66/vulkan.git","clone_url":"https://github.com/Berserker66/vulkan.git","svn_url":"https://github.com/Berserker66/vulkan","homepage":null,"size":506,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"realitix:master","ref":"master","sha":"4baa72d444e7445d6eafec0c65d77ebc607d3171","user":{"login":"realitix","id":6367936,"avatar_url":"https://avatars1.githubusercontent.com/u/6367936?v=4","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"repo":{"id":86040574,"name":"vulkan","full_name":"realitix/vulkan","owner":{"login":"realitix","id":6367936,"avatar_url":"https://avatars1.githubusercontent.com/u/6367936?v=4","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/realitix/vulkan","description":"The ultimate Python binding for Vulkan API","fork":false,"url":"https://api.github.com/repos/realitix/vulkan","forks_url":"https://api.github.com/repos/realitix/vulkan/forks","keys_url":"https://api.github.com/repos/realitix/vulkan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realitix/vulkan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realitix/vulkan/teams","hooks_url":"https://api.github.com/repos/realitix/vulkan/hooks","issue_events_url":"https://api.github.com/repos/realitix/vulkan/issues/events{/number}","events_url":"https://api.github.com/repos/realitix/vulkan/events","assignees_url":"https://api.github.com/repos/realitix/vulkan/assignees{/user}","branches_url":"https://api.github.com/repos/realitix/vulkan/branches{/branch}","tags_url":"https://api.github.com/repos/realitix/vulkan/tags","blobs_url":"https://api.github.com/repos/realitix/vulkan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realitix/vulkan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realitix/vulkan/git/refs{/sha}","trees_url":"https://api.github.com/repos/realitix/vulkan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realitix/vulkan/statuses/{sha}","languages_url":"https://api.github.com/repos/realitix/vulkan/languages","stargazers_url":"https://api.github.com/repos/realitix/vulkan/stargazers","contributors_url":"https://api.github.com/repos/realitix/vulkan/contributors","subscribers_url":"https://api.github.com/repos/realitix/vulkan/subscribers","subscription_url":"https://api.github.com/repos/realitix/vulkan/subscription","commits_url":"https://api.github.com/repos/realitix/vulkan/commits{/sha}","git_commits_url":"https://api.github.com/repos/realitix/vulkan/git/commits{/sha}","comments_url":"https://api.github.com/repos/realitix/vulkan/comments{/number}","issue_comment_url":"https://api.github.com/repos/realitix/vulkan/issues/comments{/number}","contents_url":"https://api.github.com/repos/realitix/vulkan/contents/{+path}","compare_url":"https://api.github.com/repos/realitix/vulkan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realitix/vulkan/merges","archive_url":"https://api.github.com/repos/realitix/vulkan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realitix/vulkan/downloads","issues_url":"https://api.github.com/repos/realitix/vulkan/issues{/number}","pulls_url":"https://api.github.com/repos/realitix/vulkan/pulls{/number}","milestones_url":"https://api.github.com/repos/realitix/vulkan/milestones{/number}","notifications_url":"https://api.github.com/repos/realitix/vulkan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realitix/vulkan/labels{/name}","releases_url":"https://api.github.com/repos/realitix/vulkan/releases{/id}","deployments_url":"https://api.github.com/repos/realitix/vulkan/deployments","created_at":"2017-03-24T07:40:36Z","updated_at":"2017-08-02T10:29:34Z","pushed_at":"2017-08-13T05:43:24Z","git_url":"git://github.com/realitix/vulkan.git","ssh_url":"git@github.com:realitix/vulkan.git","clone_url":"https://github.com/realitix/vulkan.git","svn_url":"https://github.com/realitix/vulkan","homepage":null,"size":522,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realitix/vulkan/pulls/27"},"html":{"href":"https://github.com/realitix/vulkan/pull/27"},"issue":{"href":"https://api.github.com/repos/realitix/vulkan/issues/27"},"comments":{"href":"https://api.github.com/repos/realitix/vulkan/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/realitix/vulkan/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/realitix/vulkan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realitix/vulkan/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/realitix/vulkan/statuses/fca44b35d1a23aad3ef6a2f243209718a6f18ed5"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":17,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"realitix"}}