{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/comments/105587238","pull_request_review_id":26472976,"id":105587238,"diff_hunk":"@@ -0,0 +1,53 @@\n+/*\n+Copyright 2017 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package validate\n+\n+import (\n+\t\"github.com/kubernetes-incubator/cri-tools/pkg/framework\"\n+\tinternalapi \"k8s.io/kubernetes/pkg/kubelet/api\"\n+\n+\t\"fmt\"\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+)\n+\n+var _ = framework.KubeDescribe(\"Version\", func() {\n+\tf := framework.NewDefaultCRIFramework()\n+\n+\tvar c internalapi.RuntimeService\n+\tvar count int\n+\n+\tBeforeEach(func() {\n+\t\tc = f.CRIClient.CRIRuntimeClient\n+\t})\n+\n+\tIt(\"runtime should return runtime conditions [Conformance]\", func() {\n+\t\tBy(\"test runtime status\")\n+\t\tstatus, err := c.Status()\n+\t\tframework.ExpectNoError(err, \"failed to get runtime conditions: %v\", err)\n+\n+\t\tfor _, condition := range status.Conditions {\n+\t\t\tif condition.Type == \"RuntimeReady\" && condition.Status == true {\n+\t\t\t\tcount = count + 1\n+\t\t\t}\n+\t\t\tif condition.Type == \"NetworkReady\" && condition.Status == true {\n+\t\t\t\tcount = count + 1\n+\t\t\t}\n+\t\t}\n+\t\tExpect(count).To(Equal(2), \"should return all the required runtime cinditions\")","path":"pkg/validate/status.go","position":51,"original_position":51,"commit_id":"0a4113387edb5554c7e920a83e060eeaed94b283","original_commit_id":"0a4113387edb5554c7e920a83e060eeaed94b283","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars1.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"Should be `>=2`, runtime should return at least two conditions","created_at":"2017-03-13T04:04:31Z","updated_at":"2017-03-13T04:04:45Z","html_url":"https://github.com/kubernetes-incubator/cri-tools/pull/11#discussion_r105587238","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/comments/105587238"},"html":{"href":"https://github.com/kubernetes-incubator/cri-tools/pull/11#discussion_r105587238"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11","id":110335133,"html_url":"https://github.com/kubernetes-incubator/cri-tools/pull/11","diff_url":"https://github.com/kubernetes-incubator/cri-tools/pull/11.diff","patch_url":"https://github.com/kubernetes-incubator/cri-tools/pull/11.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/11","number":11,"state":"open","locked":false,"title":"add runtime status test case","user":{"login":"Helen-Xie","id":18390810,"avatar_url":"https://avatars3.githubusercontent.com/u/18390810?v=3","gravatar_id":"","url":"https://api.github.com/users/Helen-Xie","html_url":"https://github.com/Helen-Xie","followers_url":"https://api.github.com/users/Helen-Xie/followers","following_url":"https://api.github.com/users/Helen-Xie/following{/other_user}","gists_url":"https://api.github.com/users/Helen-Xie/gists{/gist_id}","starred_url":"https://api.github.com/users/Helen-Xie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helen-Xie/subscriptions","organizations_url":"https://api.github.com/users/Helen-Xie/orgs","repos_url":"https://api.github.com/users/Helen-Xie/repos","events_url":"https://api.github.com/users/Helen-Xie/events{/privacy}","received_events_url":"https://api.github.com/users/Helen-Xie/received_events","type":"User","site_admin":false},"body":"part of #4 \r\n\r\nSigned-off-by: Helen-Xie <yulinxie@zju.edu.cn>","created_at":"2017-03-13T03:48:17Z","updated_at":"2017-03-13T04:04:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d995ece1037b82ca9cdd9cb62f08a751febf39","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/11/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/statuses/0a4113387edb5554c7e920a83e060eeaed94b283","head":{"label":"Helen-Xie:status-test-case","ref":"status-test-case","sha":"0a4113387edb5554c7e920a83e060eeaed94b283","user":{"login":"Helen-Xie","id":18390810,"avatar_url":"https://avatars3.githubusercontent.com/u/18390810?v=3","gravatar_id":"","url":"https://api.github.com/users/Helen-Xie","html_url":"https://github.com/Helen-Xie","followers_url":"https://api.github.com/users/Helen-Xie/followers","following_url":"https://api.github.com/users/Helen-Xie/following{/other_user}","gists_url":"https://api.github.com/users/Helen-Xie/gists{/gist_id}","starred_url":"https://api.github.com/users/Helen-Xie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helen-Xie/subscriptions","organizations_url":"https://api.github.com/users/Helen-Xie/orgs","repos_url":"https://api.github.com/users/Helen-Xie/repos","events_url":"https://api.github.com/users/Helen-Xie/events{/privacy}","received_events_url":"https://api.github.com/users/Helen-Xie/received_events","type":"User","site_admin":false},"repo":{"id":82031171,"name":"cri-tools","full_name":"Helen-Xie/cri-tools","owner":{"login":"Helen-Xie","id":18390810,"avatar_url":"https://avatars3.githubusercontent.com/u/18390810?v=3","gravatar_id":"","url":"https://api.github.com/users/Helen-Xie","html_url":"https://github.com/Helen-Xie","followers_url":"https://api.github.com/users/Helen-Xie/followers","following_url":"https://api.github.com/users/Helen-Xie/following{/other_user}","gists_url":"https://api.github.com/users/Helen-Xie/gists{/gist_id}","starred_url":"https://api.github.com/users/Helen-Xie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helen-Xie/subscriptions","organizations_url":"https://api.github.com/users/Helen-Xie/orgs","repos_url":"https://api.github.com/users/Helen-Xie/repos","events_url":"https://api.github.com/users/Helen-Xie/events{/privacy}","received_events_url":"https://api.github.com/users/Helen-Xie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Helen-Xie/cri-tools","description":"CRI tools for dev and test","fork":true,"url":"https://api.github.com/repos/Helen-Xie/cri-tools","forks_url":"https://api.github.com/repos/Helen-Xie/cri-tools/forks","keys_url":"https://api.github.com/repos/Helen-Xie/cri-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Helen-Xie/cri-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Helen-Xie/cri-tools/teams","hooks_url":"https://api.github.com/repos/Helen-Xie/cri-tools/hooks","issue_events_url":"https://api.github.com/repos/Helen-Xie/cri-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Helen-Xie/cri-tools/events","assignees_url":"https://api.github.com/repos/Helen-Xie/cri-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Helen-Xie/cri-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Helen-Xie/cri-tools/tags","blobs_url":"https://api.github.com/repos/Helen-Xie/cri-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Helen-Xie/cri-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Helen-Xie/cri-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Helen-Xie/cri-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Helen-Xie/cri-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Helen-Xie/cri-tools/languages","stargazers_url":"https://api.github.com/repos/Helen-Xie/cri-tools/stargazers","contributors_url":"https://api.github.com/repos/Helen-Xie/cri-tools/contributors","subscribers_url":"https://api.github.com/repos/Helen-Xie/cri-tools/subscribers","subscription_url":"https://api.github.com/repos/Helen-Xie/cri-tools/subscription","commits_url":"https://api.github.com/repos/Helen-Xie/cri-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Helen-Xie/cri-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Helen-Xie/cri-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Helen-Xie/cri-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Helen-Xie/cri-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Helen-Xie/cri-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Helen-Xie/cri-tools/merges","archive_url":"https://api.github.com/repos/Helen-Xie/cri-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Helen-Xie/cri-tools/downloads","issues_url":"https://api.github.com/repos/Helen-Xie/cri-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Helen-Xie/cri-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Helen-Xie/cri-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Helen-Xie/cri-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Helen-Xie/cri-tools/labels{/name}","releases_url":"https://api.github.com/repos/Helen-Xie/cri-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Helen-Xie/cri-tools/deployments","created_at":"2017-02-15T07:12:46Z","updated_at":"2017-02-15T07:12:48Z","pushed_at":"2017-03-13T03:56:05Z","git_url":"git://github.com/Helen-Xie/cri-tools.git","ssh_url":"git@github.com:Helen-Xie/cri-tools.git","clone_url":"https://github.com/Helen-Xie/cri-tools.git","svn_url":"https://github.com/Helen-Xie/cri-tools","homepage":null,"size":1161,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"cd0a503ef9e5236633f934b5814c50d821ab8342","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":80172100,"name":"cri-tools","full_name":"kubernetes-incubator/cri-tools","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-tools","description":"CRI tools for dev and test","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-tools","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-tools/deployments","created_at":"2017-01-27T01:22:52Z","updated_at":"2017-02-27T00:44:27Z","pushed_at":"2017-03-13T03:56:06Z","git_url":"git://github.com/kubernetes-incubator/cri-tools.git","ssh_url":"git@github.com:kubernetes-incubator/cri-tools.git","clone_url":"https://github.com/kubernetes-incubator/cri-tools.git","svn_url":"https://github.com/kubernetes-incubator/cri-tools","homepage":null,"size":1163,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11"},"html":{"href":"https://github.com/kubernetes-incubator/cri-tools/pull/11"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/11"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-tools/statuses/0a4113387edb5554c7e920a83e060eeaed94b283"}}}}
{"actor":{"display_login":"feiskyer"}}