{"action":"created","issue":{"url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1","repository_url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P","labels_url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1/comments","events_url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1/events","html_url":"https://github.com/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1","id":207089298,"number":1,"title":"Project Feedback","user":{"login":"qassisju","id":15862682,"avatar_url":"https://avatars.githubusercontent.com/u/15862682?v=3","gravatar_id":"","url":"https://api.github.com/users/qassisju","html_url":"https://github.com/qassisju","followers_url":"https://api.github.com/users/qassisju/followers","following_url":"https://api.github.com/users/qassisju/following{/other_user}","gists_url":"https://api.github.com/users/qassisju/gists{/gist_id}","starred_url":"https://api.github.com/users/qassisju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qassisju/subscriptions","organizations_url":"https://api.github.com/users/qassisju/orgs","repos_url":"https://api.github.com/users/qassisju/repos","events_url":"https://api.github.com/users/qassisju/events{/privacy}","received_events_url":"https://api.github.com/users/qassisju/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-12T23:01:06Z","updated_at":"2017-02-13T19:33:54Z","closed_at":null,"body":"@chrisvfritz Can you take a look at this? It's [hosted here](https://qassisju.github.io/MI-449-SS17-741-js-conditionals-uMDt4P/) and meets the following criteria:\r\n\r\n- [x] Use the `prompt` and `confirm` functions (each at least once) to collect choices from the user (the entire story will take place in dialog boxes, so your `body` element could actually be empty, apart from the `script` element to include your JavaScript)\r\n- [x] Use `if`, `else if`, and `else` to branch the story, based on user choices\r\n- [x] In at least one branch, there should be at least 3 choices for the user to make\r\n- [x] Include at least one branch where different things can happen each time with `Math.random()`\r\n- [x] Use a logical operator (`&&` or `||`) at least once, where it makes sense\r\n- [x] It should be impossible for an error to ever occur when playing your game, including handling for `null`/`undefined` where appropriate\r\n- [x] All string input should be normalized, so that extra whitespace or a letter that's the wrong case will never cause a failed match\r\n- [x] At least one number value is collected and used in a comparison (don't forget to convert it into a number first)\r\n- [x] Don't get _too_ carried away -- it can be tempting to build a complex video game, but remember, you can always come back and build on this project later\r\n\r\n<!-- ADD YOUR OWN NOTES, IF ANY, BELOW THIS LINE -->"},"comment":{"url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/comments/279497535","html_url":"https://github.com/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1#issuecomment-279497535","issue_url":"https://api.github.com/repos/qassisju/MI-449-SS17-741-js-conditionals-uMDt4P/issues/1","id":279497535,"user":{"login":"egillespie","id":5572255,"avatar_url":"https://avatars.githubusercontent.com/u/5572255?v=3","gravatar_id":"","url":"https://api.github.com/users/egillespie","html_url":"https://github.com/egillespie","followers_url":"https://api.github.com/users/egillespie/followers","following_url":"https://api.github.com/users/egillespie/following{/other_user}","gists_url":"https://api.github.com/users/egillespie/gists{/gist_id}","starred_url":"https://api.github.com/users/egillespie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egillespie/subscriptions","organizations_url":"https://api.github.com/users/egillespie/orgs","repos_url":"https://api.github.com/users/egillespie/repos","events_url":"https://api.github.com/users/egillespie/events{/privacy}","received_events_url":"https://api.github.com/users/egillespie/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T19:33:54Z","updated_at":"2017-02-13T19:33:54Z","body":"Hi @qassisju, this is a pretty fun game! :scissors: It looks like you're missing some criteria for the project. Let me point them out and offer some suggestions.\r\n\r\n### Use `prompt` and `confirm`\r\n\r\nYou're not calling `confirm` in your code. >_< One way you could approach this is to ask the user if they would like to play again.\r\n\r\n### Use `if`, `else if`, and `else`\r\n\r\nYou're missing an `else` in your project. Without an `else`, a random number less than 0.1 or greater than 0.7 causes the game to start over. By adding an `else`, you can avoid this quirk.\r\n\r\n### All string input should be normalized\r\n\r\nYou are collecting a string, but not normalizing it. Without an `else`, this means if I type \"rock\" instead of \"1\", the game starts over. One idea I have for introducing the string normalizing functions introduced in this lesson would be to ask the player to type \"rock\", \"paper\", or \"scissor\".\r\n\r\n### At least one number value is collected\r\n\r\nIf you take my advice and ask the player to type \"rock\", \"paper\", or \"scissor\", you would need to also ask for a number somewhere. Since you have a game loop that plays five times, your first `prompt` could ask the player how many games they want to play.\r\n\r\n### Code quality\r\n\r\nWe're always trying to make your code as readable as possible. This will help down the road when you work in a team and good habits also help avoid bugs.\r\n\r\nIn [the previous lesson](https://msu.lansing.codes/courses/MI-449-SS17-741/lessons/js-collect-and-display-information/1) we provided steps to add a JavaScript linter to Atom. Do you mind revisiting those steps and making sure the code in this lesson doesn't have any issues?\r\n\r\n---\r\n\r\nAfter you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.\r\n\r\nThanks! :rocket:"}}
{"actor":{"display_login":"egillespie"}}