{"action":"created","issue":{"url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/3","repository_url":"https://api.github.com/repos/konsumer/tplink-lightbulb","labels_url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/3/comments","events_url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/3/events","html_url":"https://github.com/konsumer/tplink-lightbulb/pull/3","id":210938285,"number":3,"title":"Add sysinfo to discovered bulbs","user":{"login":"leematt","id":5168190,"avatar_url":"https://avatars3.githubusercontent.com/u/5168190?v=3","gravatar_id":"","url":"https://api.github.com/users/leematt","html_url":"https://github.com/leematt","followers_url":"https://api.github.com/users/leematt/followers","following_url":"https://api.github.com/users/leematt/following{/other_user}","gists_url":"https://api.github.com/users/leematt/gists{/gist_id}","starred_url":"https://api.github.com/users/leematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leematt/subscriptions","organizations_url":"https://api.github.com/users/leematt/orgs","repos_url":"https://api.github.com/users/leematt/repos","events_url":"https://api.github.com/users/leematt/events{/privacy}","received_events_url":"https://api.github.com/users/leematt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-28T23:50:23Z","updated_at":"2017-03-02T00:27:05Z","closed_at":"2017-03-01T19:51:04Z","pull_request":{"url":"https://api.github.com/repos/konsumer/tplink-lightbulb/pulls/3","html_url":"https://github.com/konsumer/tplink-lightbulb/pull/3","diff_url":"https://github.com/konsumer/tplink-lightbulb/pull/3.diff","patch_url":"https://github.com/konsumer/tplink-lightbulb/pull/3.patch"},"body":"Adds `sysinfo` to bulbs, and ignores other TP-Link IOT devices (e.g. smart plugs) that are discovered.\r\n\r\nI've only tested with LB120, and don't have other bulbs yet. I am hoping that the `sysinfo` structure is similar across other bulb models, but the TP-Link smart plugs have a different key on the device type (`sysinfo.type` instead of `sysinfo.mic_type`), so I'm slightly concerned about inadvertently ignoring other bulb models if they're also different. Thoughts? I need access to some `sysinfo` values in a package I wrote using this ([homebridge-tplink-lightbulb](https://github.com/leematt/homebridge-tplink-lightbulb)), but could do the filtering on that end instead."},"comment":{"url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/comments/283516755","html_url":"https://github.com/konsumer/tplink-lightbulb/pull/3#issuecomment-283516755","issue_url":"https://api.github.com/repos/konsumer/tplink-lightbulb/issues/3","id":283516755,"user":{"login":"leematt","id":5168190,"avatar_url":"https://avatars3.githubusercontent.com/u/5168190?v=3","gravatar_id":"","url":"https://api.github.com/users/leematt","html_url":"https://github.com/leematt","followers_url":"https://api.github.com/users/leematt/followers","following_url":"https://api.github.com/users/leematt/following{/other_user}","gists_url":"https://api.github.com/users/leematt/gists{/gist_id}","starred_url":"https://api.github.com/users/leematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leematt/subscriptions","organizations_url":"https://api.github.com/users/leematt/orgs","repos_url":"https://api.github.com/users/leematt/repos","events_url":"https://api.github.com/users/leematt/events{/privacy}","received_events_url":"https://api.github.com/users/leematt/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T00:27:05Z","updated_at":"2017-03-02T00:27:05Z","body":"Thanks! I've updated `homebridge-tplink-lightbulb` to use the new filter and everything is great. I agree that that's a better implementation, especially if you want to generalize the package for other devices. And thanks for the branching tips. I'm relieved to have not mucked things up here. Hoping to contribute more as I go deeper into my project."}}
{"actor":{"display_login":"leematt"}}