{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/comments/122452984","pull_request_review_id":44296846,"id":122452984,"diff_hunk":"@@ -376,56 +377,51 @@ func (k *Kubernetes) ConfigVolumes(name string, service kobject.ServiceConfig) (\n \tvolumeMounts := []api.VolumeMount{}\n \tvolumes := []api.Volume{}\n \tvar PVCs []*api.PersistentVolumeClaim\n+\tvar volumeName string\n \n-\t// Set a var based on if the user wants to use emtpy volumes\n+\t// Set a var based on if the user wants to use empty volumes\n \t// as opposed to persistent volumes and volume claims\n \tuseEmptyVolumes := k.Opt.EmptyVols\n \n \tvar count int\n-\tfor _, volume := range service.Volumes {\n-\n-\t\tvolumeName, host, container, mode, err := transformer.ParseVolume(volume)\n-\t\tif err != nil {\n-\t\t\tlog.Warningf(\"Failed to configure container volume: %v\", err)\n-\t\t\tcontinue\n-\t\t}\n-\n-\t\tlog.Debug(\"Volume name %s\", volumeName)\n+\t//POC work ############################","path":"pkg/transformer/kubernetes/kubernetes.go","position":29,"original_position":29,"commit_id":"56a1d60928fa05bbf74e1de2d0e2175bba98cf8b","original_commit_id":"56a1d60928fa05bbf74e1de2d0e2175bba98cf8b","user":{"login":"cdrage","id":6422176,"avatar_url":"https://avatars2.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/cdrage","html_url":"https://github.com/cdrage","followers_url":"https://api.github.com/users/cdrage/followers","following_url":"https://api.github.com/users/cdrage/following{/other_user}","gists_url":"https://api.github.com/users/cdrage/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrage/subscriptions","organizations_url":"https://api.github.com/users/cdrage/orgs","repos_url":"https://api.github.com/users/cdrage/repos","events_url":"https://api.github.com/users/cdrage/events{/privacy}","received_events_url":"https://api.github.com/users/cdrage/received_events","type":"User","site_admin":false},"body":"remove this comment","created_at":"2017-06-16T14:22:07Z","updated_at":"2017-06-16T14:26:58Z","html_url":"https://github.com/kubernetes-incubator/kompose/pull/626#discussion_r122452984","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/comments/122452984"},"html":{"href":"https://github.com/kubernetes-incubator/kompose/pull/626#discussion_r122452984"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626","id":123044507,"html_url":"https://github.com/kubernetes-incubator/kompose/pull/626","diff_url":"https://github.com/kubernetes-incubator/kompose/pull/626.diff","patch_url":"https://github.com/kubernetes-incubator/kompose/pull/626.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/626","number":626,"state":"open","locked":false,"title":"[WIP]Handling Volume at early stage","user":{"login":"surajnarwade","id":17265451,"avatar_url":"https://avatars0.githubusercontent.com/u/17265451?v=3","gravatar_id":"","url":"https://api.github.com/users/surajnarwade","html_url":"https://github.com/surajnarwade","followers_url":"https://api.github.com/users/surajnarwade/followers","following_url":"https://api.github.com/users/surajnarwade/following{/other_user}","gists_url":"https://api.github.com/users/surajnarwade/gists{/gist_id}","starred_url":"https://api.github.com/users/surajnarwade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajnarwade/subscriptions","organizations_url":"https://api.github.com/users/surajnarwade/orgs","repos_url":"https://api.github.com/users/surajnarwade/repos","events_url":"https://api.github.com/users/surajnarwade/events{/privacy}","received_events_url":"https://api.github.com/users/surajnarwade/received_events","type":"User","site_admin":false},"body":"It will resolve #544 as well as refactor volume handling part.","created_at":"2017-05-30T13:02:32Z","updated_at":"2017-06-16T14:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7d142124cfe49dd3030d1c30a2e213aa4fa592e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/626/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kompose/statuses/56a1d60928fa05bbf74e1de2d0e2175bba98cf8b","head":{"label":"surajnarwade:handle_volume","ref":"handle_volume","sha":"56a1d60928fa05bbf74e1de2d0e2175bba98cf8b","user":{"login":"surajnarwade","id":17265451,"avatar_url":"https://avatars0.githubusercontent.com/u/17265451?v=3","gravatar_id":"","url":"https://api.github.com/users/surajnarwade","html_url":"https://github.com/surajnarwade","followers_url":"https://api.github.com/users/surajnarwade/followers","following_url":"https://api.github.com/users/surajnarwade/following{/other_user}","gists_url":"https://api.github.com/users/surajnarwade/gists{/gist_id}","starred_url":"https://api.github.com/users/surajnarwade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajnarwade/subscriptions","organizations_url":"https://api.github.com/users/surajnarwade/orgs","repos_url":"https://api.github.com/users/surajnarwade/repos","events_url":"https://api.github.com/users/surajnarwade/events{/privacy}","received_events_url":"https://api.github.com/users/surajnarwade/received_events","type":"User","site_admin":false},"repo":{"id":79789396,"name":"kompose","full_name":"surajnarwade/kompose","owner":{"login":"surajnarwade","id":17265451,"avatar_url":"https://avatars0.githubusercontent.com/u/17265451?v=3","gravatar_id":"","url":"https://api.github.com/users/surajnarwade","html_url":"https://github.com/surajnarwade","followers_url":"https://api.github.com/users/surajnarwade/followers","following_url":"https://api.github.com/users/surajnarwade/following{/other_user}","gists_url":"https://api.github.com/users/surajnarwade/gists{/gist_id}","starred_url":"https://api.github.com/users/surajnarwade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajnarwade/subscriptions","organizations_url":"https://api.github.com/users/surajnarwade/orgs","repos_url":"https://api.github.com/users/surajnarwade/repos","events_url":"https://api.github.com/users/surajnarwade/events{/privacy}","received_events_url":"https://api.github.com/users/surajnarwade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/surajnarwade/kompose","description":"Tool to move from `docker-compose` to Kubernetes","fork":true,"url":"https://api.github.com/repos/surajnarwade/kompose","forks_url":"https://api.github.com/repos/surajnarwade/kompose/forks","keys_url":"https://api.github.com/repos/surajnarwade/kompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/surajnarwade/kompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/surajnarwade/kompose/teams","hooks_url":"https://api.github.com/repos/surajnarwade/kompose/hooks","issue_events_url":"https://api.github.com/repos/surajnarwade/kompose/issues/events{/number}","events_url":"https://api.github.com/repos/surajnarwade/kompose/events","assignees_url":"https://api.github.com/repos/surajnarwade/kompose/assignees{/user}","branches_url":"https://api.github.com/repos/surajnarwade/kompose/branches{/branch}","tags_url":"https://api.github.com/repos/surajnarwade/kompose/tags","blobs_url":"https://api.github.com/repos/surajnarwade/kompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/surajnarwade/kompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/surajnarwade/kompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/surajnarwade/kompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/surajnarwade/kompose/statuses/{sha}","languages_url":"https://api.github.com/repos/surajnarwade/kompose/languages","stargazers_url":"https://api.github.com/repos/surajnarwade/kompose/stargazers","contributors_url":"https://api.github.com/repos/surajnarwade/kompose/contributors","subscribers_url":"https://api.github.com/repos/surajnarwade/kompose/subscribers","subscription_url":"https://api.github.com/repos/surajnarwade/kompose/subscription","commits_url":"https://api.github.com/repos/surajnarwade/kompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/surajnarwade/kompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/surajnarwade/kompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/surajnarwade/kompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/surajnarwade/kompose/contents/{+path}","compare_url":"https://api.github.com/repos/surajnarwade/kompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/surajnarwade/kompose/merges","archive_url":"https://api.github.com/repos/surajnarwade/kompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/surajnarwade/kompose/downloads","issues_url":"https://api.github.com/repos/surajnarwade/kompose/issues{/number}","pulls_url":"https://api.github.com/repos/surajnarwade/kompose/pulls{/number}","milestones_url":"https://api.github.com/repos/surajnarwade/kompose/milestones{/number}","notifications_url":"https://api.github.com/repos/surajnarwade/kompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/surajnarwade/kompose/labels{/name}","releases_url":"https://api.github.com/repos/surajnarwade/kompose/releases{/id}","deployments_url":"https://api.github.com/repos/surajnarwade/kompose/deployments","created_at":"2017-01-23T09:25:27Z","updated_at":"2017-01-23T09:25:30Z","pushed_at":"2017-06-16T12:28:27Z","git_url":"git://github.com/surajnarwade/kompose.git","ssh_url":"git@github.com:surajnarwade/kompose.git","clone_url":"https://github.com/surajnarwade/kompose.git","svn_url":"https://github.com/surajnarwade/kompose","homepage":"http://kompose.io","size":19961,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"f823a22e64db80319f80628283d9ff0a927daa94","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":62088377,"name":"kompose","full_name":"kubernetes-incubator/kompose","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kompose","description":"Tool to move from `docker-compose` to Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kompose","forks_url":"https://api.github.com/repos/kubernetes-incubator/kompose/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kompose/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kompose/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kompose/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kompose/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kompose/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kompose/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kompose/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kompose/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kompose/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kompose/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kompose/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kompose/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kompose/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kompose/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kompose/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kompose/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kompose/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kompose/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kompose/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kompose/deployments","created_at":"2016-06-27T21:08:18Z","updated_at":"2017-06-16T11:01:11Z","pushed_at":"2017-06-16T12:30:39Z","git_url":"git://github.com/kubernetes-incubator/kompose.git","ssh_url":"git@github.com:kubernetes-incubator/kompose.git","clone_url":"https://github.com/kubernetes-incubator/kompose.git","svn_url":"https://github.com/kubernetes-incubator/kompose","homepage":"http://kompose.io","size":19986,"stargazers_count":1288,"watchers_count":1288,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":71,"forks":76,"open_issues":71,"watchers":1288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626"},"html":{"href":"https://github.com/kubernetes-incubator/kompose/pull/626"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/626"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/issues/626/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/pulls/626/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kompose/statuses/56a1d60928fa05bbf74e1de2d0e2175bba98cf8b"}}}}
{"actor":{"display_login":"cdrage"}}