{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/choojs/nanocomponent/pulls/58","id":140750736,"html_url":"https://github.com/choojs/nanocomponent/pull/58","diff_url":"https://github.com/choojs/nanocomponent/pull/58.diff","patch_url":"https://github.com/choojs/nanocomponent/pull/58.patch","issue_url":"https://api.github.com/repos/choojs/nanocomponent/issues/58","number":58,"state":"closed","locked":false,"title":"Run afterreorder immediately","user":{"login":"tornqvist","id":985518,"avatar_url":"https://avatars2.githubusercontent.com/u/985518?v=4","gravatar_id":"","url":"https://api.github.com/users/tornqvist","html_url":"https://github.com/tornqvist","followers_url":"https://api.github.com/users/tornqvist/followers","following_url":"https://api.github.com/users/tornqvist/following{/other_user}","gists_url":"https://api.github.com/users/tornqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/tornqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornqvist/subscriptions","organizations_url":"https://api.github.com/users/tornqvist/orgs","repos_url":"https://api.github.com/users/tornqvist/repos","events_url":"https://api.github.com/users/tornqvist/events{/privacy}","received_events_url":"https://api.github.com/users/tornqvist/received_events","type":"User","site_admin":false},"body":"Offsetting `afterreorder` to next animation frame makes it difficult to do any kind of animation in reaction to reordering, seeing as the new order will already have been repainted by the browser before the callback is fired.\r\n\r\nChrome and Firefox handles it quite nicely offsetting the repaint two frames so that the animation runs smoothly but *Safari* seems to perform an intermediate paint between the `requestAnimationFrame` in nanocomponent and the `requestAnimationFrame` in my script which is needed to make the animation happen, (see source: https://github.com/tornqvist/fun-component/blob/master/examples/list/index.js#L32)\r\n\r\nHere's an example illustrating the issue: https://fun-component-list.now.sh\r\n\r\nAm I missing an apparent reason for offsetting the callback? There are some other issues, e.g. not all elements are considered being reordered but just switch places, this is also visible in the example. But I think removing the `requestAnimationFrame` fixes the most pressing issue.","created_at":"2017-09-13T07:16:36Z","updated_at":"2017-09-18T20:56:42Z","closed_at":"2017-09-18T20:56:42Z","merged_at":"2017-09-18T20:56:42Z","merge_commit_sha":"027702898c219dc651fa19c0b81bb6a96d4c9a1d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/choojs/nanocomponent/pulls/58/commits","review_comments_url":"https://api.github.com/repos/choojs/nanocomponent/pulls/58/comments","review_comment_url":"https://api.github.com/repos/choojs/nanocomponent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/choojs/nanocomponent/issues/58/comments","statuses_url":"https://api.github.com/repos/choojs/nanocomponent/statuses/027702898c219dc651fa19c0b81bb6a96d4c9a1d","head":{"label":"tornqvist:fix/immediate-afterreorder","ref":"fix/immediate-afterreorder","sha":"027702898c219dc651fa19c0b81bb6a96d4c9a1d","user":{"login":"tornqvist","id":985518,"avatar_url":"https://avatars2.githubusercontent.com/u/985518?v=4","gravatar_id":"","url":"https://api.github.com/users/tornqvist","html_url":"https://github.com/tornqvist","followers_url":"https://api.github.com/users/tornqvist/followers","following_url":"https://api.github.com/users/tornqvist/following{/other_user}","gists_url":"https://api.github.com/users/tornqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/tornqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornqvist/subscriptions","organizations_url":"https://api.github.com/users/tornqvist/orgs","repos_url":"https://api.github.com/users/tornqvist/repos","events_url":"https://api.github.com/users/tornqvist/events{/privacy}","received_events_url":"https://api.github.com/users/tornqvist/received_events","type":"User","site_admin":false},"repo":{"id":102515985,"name":"nanocomponent","full_name":"tornqvist/nanocomponent","owner":{"login":"tornqvist","id":985518,"avatar_url":"https://avatars2.githubusercontent.com/u/985518?v=4","gravatar_id":"","url":"https://api.github.com/users/tornqvist","html_url":"https://github.com/tornqvist","followers_url":"https://api.github.com/users/tornqvist/followers","following_url":"https://api.github.com/users/tornqvist/following{/other_user}","gists_url":"https://api.github.com/users/tornqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/tornqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornqvist/subscriptions","organizations_url":"https://api.github.com/users/tornqvist/orgs","repos_url":"https://api.github.com/users/tornqvist/repos","events_url":"https://api.github.com/users/tornqvist/events{/privacy}","received_events_url":"https://api.github.com/users/tornqvist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tornqvist/nanocomponent","description":"🚋 - create performant HTML components","fork":true,"url":"https://api.github.com/repos/tornqvist/nanocomponent","forks_url":"https://api.github.com/repos/tornqvist/nanocomponent/forks","keys_url":"https://api.github.com/repos/tornqvist/nanocomponent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tornqvist/nanocomponent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tornqvist/nanocomponent/teams","hooks_url":"https://api.github.com/repos/tornqvist/nanocomponent/hooks","issue_events_url":"https://api.github.com/repos/tornqvist/nanocomponent/issues/events{/number}","events_url":"https://api.github.com/repos/tornqvist/nanocomponent/events","assignees_url":"https://api.github.com/repos/tornqvist/nanocomponent/assignees{/user}","branches_url":"https://api.github.com/repos/tornqvist/nanocomponent/branches{/branch}","tags_url":"https://api.github.com/repos/tornqvist/nanocomponent/tags","blobs_url":"https://api.github.com/repos/tornqvist/nanocomponent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tornqvist/nanocomponent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tornqvist/nanocomponent/git/refs{/sha}","trees_url":"https://api.github.com/repos/tornqvist/nanocomponent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tornqvist/nanocomponent/statuses/{sha}","languages_url":"https://api.github.com/repos/tornqvist/nanocomponent/languages","stargazers_url":"https://api.github.com/repos/tornqvist/nanocomponent/stargazers","contributors_url":"https://api.github.com/repos/tornqvist/nanocomponent/contributors","subscribers_url":"https://api.github.com/repos/tornqvist/nanocomponent/subscribers","subscription_url":"https://api.github.com/repos/tornqvist/nanocomponent/subscription","commits_url":"https://api.github.com/repos/tornqvist/nanocomponent/commits{/sha}","git_commits_url":"https://api.github.com/repos/tornqvist/nanocomponent/git/commits{/sha}","comments_url":"https://api.github.com/repos/tornqvist/nanocomponent/comments{/number}","issue_comment_url":"https://api.github.com/repos/tornqvist/nanocomponent/issues/comments{/number}","contents_url":"https://api.github.com/repos/tornqvist/nanocomponent/contents/{+path}","compare_url":"https://api.github.com/repos/tornqvist/nanocomponent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tornqvist/nanocomponent/merges","archive_url":"https://api.github.com/repos/tornqvist/nanocomponent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tornqvist/nanocomponent/downloads","issues_url":"https://api.github.com/repos/tornqvist/nanocomponent/issues{/number}","pulls_url":"https://api.github.com/repos/tornqvist/nanocomponent/pulls{/number}","milestones_url":"https://api.github.com/repos/tornqvist/nanocomponent/milestones{/number}","notifications_url":"https://api.github.com/repos/tornqvist/nanocomponent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tornqvist/nanocomponent/labels{/name}","releases_url":"https://api.github.com/repos/tornqvist/nanocomponent/releases{/id}","deployments_url":"https://api.github.com/repos/tornqvist/nanocomponent/deployments","created_at":"2017-09-05T18:27:28Z","updated_at":"2017-09-05T18:27:29Z","pushed_at":"2017-09-13T06:48:00Z","git_url":"git://github.com/tornqvist/nanocomponent.git","ssh_url":"git@github.com:tornqvist/nanocomponent.git","clone_url":"https://github.com/tornqvist/nanocomponent.git","svn_url":"https://github.com/tornqvist/nanocomponent","homepage":"https://leaflet.choo.io/","size":406,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"choojs:master","ref":"master","sha":"9de677bd32a0d939d9a105deb2591c2fa171a08f","user":{"login":"choojs","id":29929674,"avatar_url":"https://avatars3.githubusercontent.com/u/29929674?v=4","gravatar_id":"","url":"https://api.github.com/users/choojs","html_url":"https://github.com/choojs","followers_url":"https://api.github.com/users/choojs/followers","following_url":"https://api.github.com/users/choojs/following{/other_user}","gists_url":"https://api.github.com/users/choojs/gists{/gist_id}","starred_url":"https://api.github.com/users/choojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choojs/subscriptions","organizations_url":"https://api.github.com/users/choojs/orgs","repos_url":"https://api.github.com/users/choojs/repos","events_url":"https://api.github.com/users/choojs/events{/privacy}","received_events_url":"https://api.github.com/users/choojs/received_events","type":"Organization","site_admin":false},"repo":{"id":78044158,"name":"nanocomponent","full_name":"choojs/nanocomponent","owner":{"login":"choojs","id":29929674,"avatar_url":"https://avatars3.githubusercontent.com/u/29929674?v=4","gravatar_id":"","url":"https://api.github.com/users/choojs","html_url":"https://github.com/choojs","followers_url":"https://api.github.com/users/choojs/followers","following_url":"https://api.github.com/users/choojs/following{/other_user}","gists_url":"https://api.github.com/users/choojs/gists{/gist_id}","starred_url":"https://api.github.com/users/choojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choojs/subscriptions","organizations_url":"https://api.github.com/users/choojs/orgs","repos_url":"https://api.github.com/users/choojs/repos","events_url":"https://api.github.com/users/choojs/events{/privacy}","received_events_url":"https://api.github.com/users/choojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/choojs/nanocomponent","description":"🚋 - create performant HTML components","fork":false,"url":"https://api.github.com/repos/choojs/nanocomponent","forks_url":"https://api.github.com/repos/choojs/nanocomponent/forks","keys_url":"https://api.github.com/repos/choojs/nanocomponent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choojs/nanocomponent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choojs/nanocomponent/teams","hooks_url":"https://api.github.com/repos/choojs/nanocomponent/hooks","issue_events_url":"https://api.github.com/repos/choojs/nanocomponent/issues/events{/number}","events_url":"https://api.github.com/repos/choojs/nanocomponent/events","assignees_url":"https://api.github.com/repos/choojs/nanocomponent/assignees{/user}","branches_url":"https://api.github.com/repos/choojs/nanocomponent/branches{/branch}","tags_url":"https://api.github.com/repos/choojs/nanocomponent/tags","blobs_url":"https://api.github.com/repos/choojs/nanocomponent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choojs/nanocomponent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choojs/nanocomponent/git/refs{/sha}","trees_url":"https://api.github.com/repos/choojs/nanocomponent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choojs/nanocomponent/statuses/{sha}","languages_url":"https://api.github.com/repos/choojs/nanocomponent/languages","stargazers_url":"https://api.github.com/repos/choojs/nanocomponent/stargazers","contributors_url":"https://api.github.com/repos/choojs/nanocomponent/contributors","subscribers_url":"https://api.github.com/repos/choojs/nanocomponent/subscribers","subscription_url":"https://api.github.com/repos/choojs/nanocomponent/subscription","commits_url":"https://api.github.com/repos/choojs/nanocomponent/commits{/sha}","git_commits_url":"https://api.github.com/repos/choojs/nanocomponent/git/commits{/sha}","comments_url":"https://api.github.com/repos/choojs/nanocomponent/comments{/number}","issue_comment_url":"https://api.github.com/repos/choojs/nanocomponent/issues/comments{/number}","contents_url":"https://api.github.com/repos/choojs/nanocomponent/contents/{+path}","compare_url":"https://api.github.com/repos/choojs/nanocomponent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choojs/nanocomponent/merges","archive_url":"https://api.github.com/repos/choojs/nanocomponent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choojs/nanocomponent/downloads","issues_url":"https://api.github.com/repos/choojs/nanocomponent/issues{/number}","pulls_url":"https://api.github.com/repos/choojs/nanocomponent/pulls{/number}","milestones_url":"https://api.github.com/repos/choojs/nanocomponent/milestones{/number}","notifications_url":"https://api.github.com/repos/choojs/nanocomponent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choojs/nanocomponent/labels{/name}","releases_url":"https://api.github.com/repos/choojs/nanocomponent/releases{/id}","deployments_url":"https://api.github.com/repos/choojs/nanocomponent/deployments","created_at":"2017-01-04T19:03:00Z","updated_at":"2017-09-18T10:54:43Z","pushed_at":"2017-09-18T20:56:42Z","git_url":"git://github.com/choojs/nanocomponent.git","ssh_url":"git@github.com:choojs/nanocomponent.git","clone_url":"https://github.com/choojs/nanocomponent.git","svn_url":"https://github.com/choojs/nanocomponent","homepage":"https://leaflet.choo.io/","size":419,"stargazers_count":219,"watchers_count":219,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/choojs/nanocomponent/pulls/58"},"html":{"href":"https://github.com/choojs/nanocomponent/pull/58"},"issue":{"href":"https://api.github.com/repos/choojs/nanocomponent/issues/58"},"comments":{"href":"https://api.github.com/repos/choojs/nanocomponent/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/choojs/nanocomponent/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/choojs/nanocomponent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/choojs/nanocomponent/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/choojs/nanocomponent/statuses/027702898c219dc651fa19c0b81bb6a96d4c9a1d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"toddself","id":193412,"avatar_url":"https://avatars3.githubusercontent.com/u/193412?v=4","gravatar_id":"","url":"https://api.github.com/users/toddself","html_url":"https://github.com/toddself","followers_url":"https://api.github.com/users/toddself/followers","following_url":"https://api.github.com/users/toddself/following{/other_user}","gists_url":"https://api.github.com/users/toddself/gists{/gist_id}","starred_url":"https://api.github.com/users/toddself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddself/subscriptions","organizations_url":"https://api.github.com/users/toddself/orgs","repos_url":"https://api.github.com/users/toddself/repos","events_url":"https://api.github.com/users/toddself/events{/privacy}","received_events_url":"https://api.github.com/users/toddself/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"toddself"}}