{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/114123238","pull_request_review_id":35564526,"id":114123238,"diff_hunk":"@@ -1,35 +1,88 @@\n-/***************************************************************************\n-  qgsfieldformatterregistry.sip - QgsFieldFormatterRegistry\n-\n- ---------------------\n- begin                : 2.12.2016\n- copyright            : (C) 2016 by Matthias Kuhn\n- email                : matthias@opengis.ch\n- ***************************************************************************\n- *                                                                         *\n- *   This program is free software; you can redistribute it and/or modify  *\n- *   it under the terms of the GNU General Public License as published by  *\n- *   the Free Software Foundation; either version 2 of the License, or     *\n- *   (at your option) any later version.                                   *\n- *                                                                         *\n- ***************************************************************************/\n+/************************************************************************\n+ * This file has been generated automatically from                      *\n+ *                                                                      *\n+ * src/core/qgsfieldformatterregistry.h                                 *\n+ *                                                                      *\n+ * Do not edit manually ! Edit header and run scripts/sipify.pl again   *\n+ ************************************************************************/\n+\n+\n+\n+\n class QgsFieldFormatterRegistry : QObject\n {\n+%Docstring\n+ The QgsFieldFormatterRegistry manages registered classes of QgsFieldFormatter.\n+ A reference to the QgsFieldFormatterRegistry can be obtained from\n+ QgsApplication.fieldFormatterRegistry().\n+\n+.. versionadded:: 3.0\n+%End\n+\n %TypeHeaderCode\n #include \"qgsfieldformatterregistry.h\"\n %End\n   public:\n \n-    QgsFieldFormatterRegistry( QObject* parent /TransferThis/ );\n+    explicit QgsFieldFormatterRegistry( QObject *parent = 0 /TransferThis/ );","path":"python/core/qgsfieldformatterregistry.sip","position":43,"original_position":43,"commit_id":"89ffb3a945128a0034c7033e8db423ae38960327","original_commit_id":"89ffb3a945128a0034c7033e8db423ae38960327","user":{"login":"3nids","id":127259,"avatar_url":"https://avatars2.githubusercontent.com/u/127259?v=3","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"body":"transferthis should be before = sign","created_at":"2017-05-01T13:05:50Z","updated_at":"2017-05-01T13:05:56Z","html_url":"https://github.com/qgis/QGIS/pull/4467#discussion_r114123238","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/4467","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/114123238"},"html":{"href":"https://github.com/qgis/QGIS/pull/4467#discussion_r114123238"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4467"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/4467","id":118368925,"html_url":"https://github.com/qgis/QGIS/pull/4467","diff_url":"https://github.com/qgis/QGIS/pull/4467.diff","patch_url":"https://github.com/qgis/QGIS/pull/4467.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/4467","number":4467,"state":"open","locked":false,"title":"Sipify qgsfieldconstraints QgsFieldFormatter and QgsFieldFormatterRegistry","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars3.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nNote that some function parameter names have changed in QgsFieldFormatter.\r\n* vl => layer\r\n* fieldIdx =>  fieldIndex\r\n\r\nBut this seems good for consistency and it seems to be the right time now to do that.\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [ ] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [ ] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n","created_at":"2017-05-01T11:34:07Z","updated_at":"2017-05-01T13:05:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd361ef9a0b71d224c7f4fee03cebe418268c84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/4467/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/4467/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/4467/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/89ffb3a945128a0034c7033e8db423ae38960327","head":{"label":"arnaud-morvan:sipify_qgsfieldconstraints","ref":"sipify_qgsfieldconstraints","sha":"89ffb3a945128a0034c7033e8db423ae38960327","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars3.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"repo":{"id":15884637,"name":"QGIS","full_name":"arnaud-morvan/QGIS","owner":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars3.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnaud-morvan/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/arnaud-morvan/QGIS","forks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/forks","keys_url":"https://api.github.com/repos/arnaud-morvan/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnaud-morvan/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnaud-morvan/QGIS/teams","hooks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/hooks","issue_events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/events","assignees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/arnaud-morvan/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/tags","blobs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnaud-morvan/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/arnaud-morvan/QGIS/languages","stargazers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/stargazers","contributors_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contributors","subscribers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscribers","subscription_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscription","commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/arnaud-morvan/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnaud-morvan/QGIS/merges","archive_url":"https://api.github.com/repos/arnaud-morvan/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnaud-morvan/QGIS/downloads","issues_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/arnaud-morvan/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/arnaud-morvan/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/arnaud-morvan/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnaud-morvan/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/arnaud-morvan/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/deployments","created_at":"2014-01-13T22:47:33Z","updated_at":"2017-02-09T13:10:29Z","pushed_at":"2017-05-01T11:52:53Z","git_url":"git://github.com/arnaud-morvan/QGIS.git","ssh_url":"git@github.com:arnaud-morvan/QGIS.git","clone_url":"https://github.com/arnaud-morvan/QGIS.git","svn_url":"https://github.com/arnaud-morvan/QGIS","homepage":"http://qgis.org","size":1160931,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"1ed8880c47e5b9ea1254ece490104571fcfb02e0","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars0.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars0.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2017-04-30T16:14:56Z","pushed_at":"2017-05-01T12:54:51Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1279957,"stargazers_count":1371,"watchers_count":1371,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1027,"mirror_url":null,"open_issues_count":81,"forks":1027,"open_issues":81,"watchers":1371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4467"},"html":{"href":"https://github.com/qgis/QGIS/pull/4467"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/4467"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/4467/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4467/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4467/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/89ffb3a945128a0034c7033e8db423ae38960327"}}}}
{"actor":{"display_login":"3nids"}}