{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4448","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4448/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4448/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4448/events","html_url":"https://github.com/fish-shell/fish-shell/pull/4448","id":262681485,"number":4448,"title":"Python's pip and pipenv completions","user":{"login":"cprieto","id":94194,"avatar_url":"https://avatars3.githubusercontent.com/u/94194?v=4","gravatar_id":"","url":"https://api.github.com/users/cprieto","html_url":"https://github.com/cprieto","followers_url":"https://api.github.com/users/cprieto/followers","following_url":"https://api.github.com/users/cprieto/following{/other_user}","gists_url":"https://api.github.com/users/cprieto/gists{/gist_id}","starred_url":"https://api.github.com/users/cprieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprieto/subscriptions","organizations_url":"https://api.github.com/users/cprieto/orgs","repos_url":"https://api.github.com/users/cprieto/repos","events_url":"https://api.github.com/users/cprieto/events{/privacy}","received_events_url":"https://api.github.com/users/cprieto/received_events","type":"User","site_admin":false},"labels":[{"id":252196718,"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/completions","name":"completions","color":"E6C0E5","default":false}],"state":"closed","locked":false,"assignee":{"login":"floam","id":291142,"avatar_url":"https://avatars1.githubusercontent.com/u/291142?v=4","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"assignees":[{"login":"floam","id":291142,"avatar_url":"https://avatars1.githubusercontent.com/u/291142?v=4","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/17","html_url":"https://github.com/fish-shell/fish-shell/milestone/17","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/17/labels","id":2533678,"number":17,"title":"fish 2.7.0","description":"The next minor release after 2.6.0","creator":{"login":"faho","id":5185367,"avatar_url":"https://avatars3.githubusercontent.com/u/5185367?v=4","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":151,"state":"open","created_at":"2017-05-21T13:49:12Z","updated_at":"2017-10-05T04:15:42Z","due_on":"2017-09-01T07:00:00Z","closed_at":null},"comments":5,"created_at":"2017-10-04T06:37:07Z","updated_at":"2017-10-05T04:21:43Z","closed_at":"2017-10-05T04:15:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4448","html_url":"https://github.com/fish-shell/fish-shell/pull/4448","diff_url":"https://github.com/fish-shell/fish-shell/pull/4448.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/4448.patch"},"body":"## pip and pipenv completions\r\n\r\nBoth pip and pipenv has its own completion support for fish, so we only call their native completion support if the command is installed in the path, nothing fancy but this avoids having to manually install the completion."},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/334354891","html_url":"https://github.com/fish-shell/fish-shell/pull/4448#issuecomment-334354891","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4448","id":334354891,"user":{"login":"floam","id":291142,"avatar_url":"https://avatars1.githubusercontent.com/u/291142?v=4","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T04:21:43Z","updated_at":"2017-10-05T04:21:43Z","author_association":"MEMBER","body":"Hm, I do notice something keeping pip2 completions from working here, but this should be fixed upstream:\r\n\r\n```fish\r\n$ pip2 completion --fish\r\n\r\n# pip fish completion start\r\nfunction __fish_complete_pip\r\n    set -lx COMP_WORDS (commandline -o) \"\"\r\n    set -lx COMP_CWORD (math (contains -i -- (commandline -t) $COMP_WORDS)-1)\r\n    set -lx PIP_AUTO_COMPLETE 1\r\n    string split \\  -- (eval $COMP_WORDS[1])\r\nend\r\ncomplete -fa \"(__fish_complete_pip)\" -c pip\r\n# pip fish completion end\r\n```\r\n\r\nRunning `pip2 completion --fish` outputs a `complete` command for `pip`, not `pip2`."}}
{"actor":{"display_login":"floam"}}