{"action":"created","comment":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/123346663","pull_request_review_id":45541056,"id":123346663,"diff_hunk":"@@ -909,7 +909,7 @@ void TSatProof<Solver>::finalizeProof(typename Solver::TCRef conflict_ref) {\n     typename Solver::TLit lit = conflict[i];\n     ClauseId res_id = resolveUnit(~lit);\n     res->addStep(lit, res_id, !sign(lit));\n-    conflict_size = conflict.size();\n+    conflict_size = getClause(conflict_ref).size();","path":"src/proof/sat_proof_implementation.h","position":5,"original_position":5,"commit_id":"ee04b653cb054fcb8483f4d4701848c84fc3b139","original_commit_id":"ee04b653cb054fcb8483f4d4701848c84fc3b139","user":{"login":"timothy-king","id":797368,"avatar_url":"https://avatars2.githubusercontent.com/u/797368?v=3","gravatar_id":"","url":"https://api.github.com/users/timothy-king","html_url":"https://github.com/timothy-king","followers_url":"https://api.github.com/users/timothy-king/followers","following_url":"https://api.github.com/users/timothy-king/following{/other_user}","gists_url":"https://api.github.com/users/timothy-king/gists{/gist_id}","starred_url":"https://api.github.com/users/timothy-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothy-king/subscriptions","organizations_url":"https://api.github.com/users/timothy-king/orgs","repos_url":"https://api.github.com/users/timothy-king/repos","events_url":"https://api.github.com/users/timothy-king/events{/privacy}","received_events_url":"https://api.github.com/users/timothy-king/received_events","type":"User","site_admin":false},"body":"How about just changing the loop condition to \"i < getClause(conflict_ref).size();\" and dropping conflict_size?","created_at":"2017-06-21T19:41:00Z","updated_at":"2017-06-21T19:41:16Z","html_url":"https://github.com/CVC4/CVC4/pull/174#discussion_r123346663","pull_request_url":"https://api.github.com/repos/CVC4/CVC4/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/123346663"},"html":{"href":"https://github.com/CVC4/CVC4/pull/174#discussion_r123346663"},"pull_request":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/174","id":126799250,"html_url":"https://github.com/CVC4/CVC4/pull/174","diff_url":"https://github.com/CVC4/CVC4/pull/174.diff","patch_url":"https://github.com/CVC4/CVC4/pull/174.patch","issue_url":"https://api.github.com/repos/CVC4/CVC4/issues/174","number":174,"state":"open","locked":false,"title":"Fix use-after-free with unsat cores/proofs","user":{"login":"4tXJ7f","id":1926228,"avatar_url":"https://avatars0.githubusercontent.com/u/1926228?v=3","gravatar_id":"","url":"https://api.github.com/users/4tXJ7f","html_url":"https://github.com/4tXJ7f","followers_url":"https://api.github.com/users/4tXJ7f/followers","following_url":"https://api.github.com/users/4tXJ7f/following{/other_user}","gists_url":"https://api.github.com/users/4tXJ7f/gists{/gist_id}","starred_url":"https://api.github.com/users/4tXJ7f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4tXJ7f/subscriptions","organizations_url":"https://api.github.com/users/4tXJ7f/orgs","repos_url":"https://api.github.com/users/4tXJ7f/repos","events_url":"https://api.github.com/users/4tXJ7f/events{/privacy}","received_events_url":"https://api.github.com/users/4tXJ7f/received_events","type":"User","site_admin":false},"body":"In TSatProof<Solver>::finalizeProof(), we got a clause from the clause\r\nallocator, called resolveUnit() and then size() on the clause. The problem is\r\nthat resolveUnit() can reallocate memory (and there is even a comment warning\r\nabout that in finalizeProof()), which invalidates the clause. This commit gets\r\nthe clause again from the clause allocator before calling size().","created_at":"2017-06-21T15:51:47Z","updated_at":"2017-06-21T19:41:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6644b343ccbb0f647ee79328afaf4740b4fedbd9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"guykatzz","id":15022045,"avatar_url":"https://avatars3.githubusercontent.com/u/15022045?v=3","gravatar_id":"","url":"https://api.github.com/users/guykatzz","html_url":"https://github.com/guykatzz","followers_url":"https://api.github.com/users/guykatzz/followers","following_url":"https://api.github.com/users/guykatzz/following{/other_user}","gists_url":"https://api.github.com/users/guykatzz/gists{/gist_id}","starred_url":"https://api.github.com/users/guykatzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guykatzz/subscriptions","organizations_url":"https://api.github.com/users/guykatzz/orgs","repos_url":"https://api.github.com/users/guykatzz/repos","events_url":"https://api.github.com/users/guykatzz/events{/privacy}","received_events_url":"https://api.github.com/users/guykatzz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CVC4/CVC4/pulls/174/commits","review_comments_url":"https://api.github.com/repos/CVC4/CVC4/pulls/174/comments","review_comment_url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CVC4/CVC4/issues/174/comments","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/ee04b653cb054fcb8483f4d4701848c84fc3b139","head":{"label":"CVC4:uaf_proof","ref":"uaf_proof","sha":"ee04b653cb054fcb8483f4d4701848c84fc3b139","user":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars3.githubusercontent.com/u/2973223?v=3","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"repo":{"id":7040894,"name":"CVC4","full_name":"CVC4/CVC4","owner":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars3.githubusercontent.com/u/2973223?v=3","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CVC4/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":false,"url":"https://api.github.com/repos/CVC4/CVC4","forks_url":"https://api.github.com/repos/CVC4/CVC4/forks","keys_url":"https://api.github.com/repos/CVC4/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVC4/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVC4/CVC4/teams","hooks_url":"https://api.github.com/repos/CVC4/CVC4/hooks","issue_events_url":"https://api.github.com/repos/CVC4/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/CVC4/CVC4/events","assignees_url":"https://api.github.com/repos/CVC4/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/CVC4/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/CVC4/CVC4/tags","blobs_url":"https://api.github.com/repos/CVC4/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVC4/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVC4/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVC4/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/CVC4/CVC4/languages","stargazers_url":"https://api.github.com/repos/CVC4/CVC4/stargazers","contributors_url":"https://api.github.com/repos/CVC4/CVC4/contributors","subscribers_url":"https://api.github.com/repos/CVC4/CVC4/subscribers","subscription_url":"https://api.github.com/repos/CVC4/CVC4/subscription","commits_url":"https://api.github.com/repos/CVC4/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVC4/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVC4/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVC4/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVC4/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/CVC4/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVC4/CVC4/merges","archive_url":"https://api.github.com/repos/CVC4/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVC4/CVC4/downloads","issues_url":"https://api.github.com/repos/CVC4/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/CVC4/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/CVC4/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/CVC4/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVC4/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/CVC4/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/CVC4/CVC4/deployments","created_at":"2012-12-06T18:45:04Z","updated_at":"2017-06-17T01:43:15Z","pushed_at":"2017-06-21T19:27:44Z","git_url":"git://github.com/CVC4/CVC4.git","ssh_url":"git@github.com:CVC4/CVC4.git","clone_url":"https://github.com/CVC4/CVC4.git","svn_url":"https://github.com/CVC4/CVC4","homepage":null,"size":37713,"stargazers_count":148,"watchers_count":148,"language":"SMT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":12,"forks":64,"open_issues":12,"watchers":148,"default_branch":"master"}},"base":{"label":"CVC4:master","ref":"master","sha":"cdf019f8be3b4affdb582ceb95054b327006521c","user":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars3.githubusercontent.com/u/2973223?v=3","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"repo":{"id":7040894,"name":"CVC4","full_name":"CVC4/CVC4","owner":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars3.githubusercontent.com/u/2973223?v=3","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CVC4/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":false,"url":"https://api.github.com/repos/CVC4/CVC4","forks_url":"https://api.github.com/repos/CVC4/CVC4/forks","keys_url":"https://api.github.com/repos/CVC4/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVC4/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVC4/CVC4/teams","hooks_url":"https://api.github.com/repos/CVC4/CVC4/hooks","issue_events_url":"https://api.github.com/repos/CVC4/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/CVC4/CVC4/events","assignees_url":"https://api.github.com/repos/CVC4/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/CVC4/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/CVC4/CVC4/tags","blobs_url":"https://api.github.com/repos/CVC4/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVC4/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVC4/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVC4/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/CVC4/CVC4/languages","stargazers_url":"https://api.github.com/repos/CVC4/CVC4/stargazers","contributors_url":"https://api.github.com/repos/CVC4/CVC4/contributors","subscribers_url":"https://api.github.com/repos/CVC4/CVC4/subscribers","subscription_url":"https://api.github.com/repos/CVC4/CVC4/subscription","commits_url":"https://api.github.com/repos/CVC4/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVC4/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVC4/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVC4/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVC4/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/CVC4/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVC4/CVC4/merges","archive_url":"https://api.github.com/repos/CVC4/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVC4/CVC4/downloads","issues_url":"https://api.github.com/repos/CVC4/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/CVC4/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/CVC4/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/CVC4/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVC4/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/CVC4/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/CVC4/CVC4/deployments","created_at":"2012-12-06T18:45:04Z","updated_at":"2017-06-17T01:43:15Z","pushed_at":"2017-06-21T19:27:44Z","git_url":"git://github.com/CVC4/CVC4.git","ssh_url":"git@github.com:CVC4/CVC4.git","clone_url":"https://github.com/CVC4/CVC4.git","svn_url":"https://github.com/CVC4/CVC4","homepage":null,"size":37713,"stargazers_count":148,"watchers_count":148,"language":"SMT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":12,"forks":64,"open_issues":12,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/174"},"html":{"href":"https://github.com/CVC4/CVC4/pull/174"},"issue":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/174"},"comments":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/CVC4/CVC4/statuses/ee04b653cb054fcb8483f4d4701848c84fc3b139"}}}}
{"actor":{"display_login":"timothy-king"}}