{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/122942284","pull_request_review_id":45098647,"id":122942284,"diff_hunk":"@@ -4,6 +4,31 @@ using Base.Test\n \n using Base.LinAlg: BlasComplex, BlasFloat, BlasReal, QRPivoted\n \n+@testset \"Simple svdvals / svdfact tests\" begin\n+    ≈(x,y) = isapprox(x,y,rtol=1e-15)","path":"test/linalg/svd.jl","position":5,"original_position":5,"commit_id":"799ccc7ee46be6362d856c799270f5286995d307","original_commit_id":"799ccc7ee46be6362d856c799270f5286995d307","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars3.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"probably better to use the kwarg capability of at-test for this, or an operator that doesn't already have a meaning","created_at":"2017-06-20T10:50:09Z","updated_at":"2017-06-20T10:50:09Z","html_url":"https://github.com/JuliaLang/julia/pull/22443#discussion_r122942284","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22443","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/122942284"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22443#discussion_r122942284"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22443"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/22443","id":126428129,"html_url":"https://github.com/JuliaLang/julia/pull/22443","diff_url":"https://github.com/JuliaLang/julia/pull/22443.diff","patch_url":"https://github.com/JuliaLang/julia/pull/22443.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/22443","number":22443,"state":"open","locked":false,"title":"Make svdvals(::Matrix{<:Complex}) type inferrable","user":{"login":"c42f","id":601473,"avatar_url":"https://avatars2.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"body":"Ensure that svdvals(zeros(Complex128,0,0)) returns a complex real matrix\r\nto avoid type instability.  Also add some simplistic but explicit tests\r\nfor svdvals and svdfact, including ensuring this case is inferred.","created_at":"2017-06-20T01:07:17Z","updated_at":"2017-06-20T10:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f99bb541040074707f3ede4211ea7389c0779b26","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22443/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22443/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/22443/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/799ccc7ee46be6362d856c799270f5286995d307","head":{"label":"c42f:typestable-complex-svdvals","ref":"typestable-complex-svdvals","sha":"799ccc7ee46be6362d856c799270f5286995d307","user":{"login":"c42f","id":601473,"avatar_url":"https://avatars2.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"repo":{"id":10584812,"name":"julia","full_name":"c42f/julia","owner":{"login":"c42f","id":601473,"avatar_url":"https://avatars2.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c42f/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/c42f/julia","forks_url":"https://api.github.com/repos/c42f/julia/forks","keys_url":"https://api.github.com/repos/c42f/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c42f/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c42f/julia/teams","hooks_url":"https://api.github.com/repos/c42f/julia/hooks","issue_events_url":"https://api.github.com/repos/c42f/julia/issues/events{/number}","events_url":"https://api.github.com/repos/c42f/julia/events","assignees_url":"https://api.github.com/repos/c42f/julia/assignees{/user}","branches_url":"https://api.github.com/repos/c42f/julia/branches{/branch}","tags_url":"https://api.github.com/repos/c42f/julia/tags","blobs_url":"https://api.github.com/repos/c42f/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c42f/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c42f/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/c42f/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c42f/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/c42f/julia/languages","stargazers_url":"https://api.github.com/repos/c42f/julia/stargazers","contributors_url":"https://api.github.com/repos/c42f/julia/contributors","subscribers_url":"https://api.github.com/repos/c42f/julia/subscribers","subscription_url":"https://api.github.com/repos/c42f/julia/subscription","commits_url":"https://api.github.com/repos/c42f/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/c42f/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/c42f/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/c42f/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/c42f/julia/contents/{+path}","compare_url":"https://api.github.com/repos/c42f/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c42f/julia/merges","archive_url":"https://api.github.com/repos/c42f/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c42f/julia/downloads","issues_url":"https://api.github.com/repos/c42f/julia/issues{/number}","pulls_url":"https://api.github.com/repos/c42f/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/c42f/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/c42f/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c42f/julia/labels{/name}","releases_url":"https://api.github.com/repos/c42f/julia/releases{/id}","deployments_url":"https://api.github.com/repos/c42f/julia/deployments","created_at":"2013-06-09T15:11:45Z","updated_at":"2015-09-19T15:34:03Z","pushed_at":"2017-06-20T07:12:43Z","git_url":"git://github.com/c42f/julia.git","ssh_url":"git@github.com:c42f/julia.git","clone_url":"https://github.com/c42f/julia.git","svn_url":"https://github.com/c42f/julia","homepage":"http://julialang.org/","size":109379,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"401b724fbbf5a59cc47cb624b01d563517857234","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2017-06-20T09:51:32Z","pushed_at":"2017-06-20T08:11:11Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":183814,"stargazers_count":8737,"watchers_count":8737,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1997,"mirror_url":null,"open_issues_count":2305,"forks":1997,"open_issues":2305,"watchers":8737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22443"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22443"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22443"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22443/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22443/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22443/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/799ccc7ee46be6362d856c799270f5286995d307"}}}}
{"actor":{"display_login":"tkelman"}}