{"action":"created","comment":{"url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/comments/125006543","pull_request_review_id":47348545,"id":125006543,"diff_hunk":"@@ -0,0 +1,17 @@\n+Reactive API Documentation\n+--------------------------\n+\n+\n+.. toctree::\n+\n+    charms.reactive.decorators\n+    charms.reactive.helpers\n+    charms.reactive.relations\n+    charms.reactive.bus\n+    charms.reactive.cli","path":"docs/api.rst","position":11,"original_position":11,"commit_id":"368853aacf239828d46abcbfb1c919b5a7624c5e","original_commit_id":"368853aacf239828d46abcbfb1c919b5a7624c5e","user":{"login":"stub42","id":2928805,"avatar_url":"https://avatars3.githubusercontent.com/u/2928805?v=3","gravatar_id":"","url":"https://api.github.com/users/stub42","html_url":"https://github.com/stub42","followers_url":"https://api.github.com/users/stub42/followers","following_url":"https://api.github.com/users/stub42/following{/other_user}","gists_url":"https://api.github.com/users/stub42/gists{/gist_id}","starred_url":"https://api.github.com/users/stub42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stub42/subscriptions","organizations_url":"https://api.github.com/users/stub42/orgs","repos_url":"https://api.github.com/users/stub42/repos","events_url":"https://api.github.com/users/stub42/events{/privacy}","received_events_url":"https://api.github.com/users/stub42/received_events","type":"User","site_admin":false},"body":"Consider only having the actual API in the documentation. Does charms.reactive.bus need to be here encouraging people to use internal only functions? Are these internal only functions? Do we need to separate internals from API better?","created_at":"2017-06-30T10:06:18Z","updated_at":"2017-06-30T10:24:43Z","html_url":"https://github.com/juju-solutions/charms.reactive/pull/112#discussion_r125006543","pull_request_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/comments/125006543"},"html":{"href":"https://github.com/juju-solutions/charms.reactive/pull/112#discussion_r125006543"},"pull_request":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112","id":128258809,"html_url":"https://github.com/juju-solutions/charms.reactive/pull/112","diff_url":"https://github.com/juju-solutions/charms.reactive/pull/112.diff","patch_url":"https://github.com/juju-solutions/charms.reactive/pull/112.patch","issue_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/112","number":112,"state":"open","locked":false,"title":"Refactor \"state\" to \"flag\"","user":{"login":"johnsca","id":406082,"avatar_url":"https://avatars0.githubusercontent.com/u/406082?v=3","gravatar_id":"","url":"https://api.github.com/users/johnsca","html_url":"https://github.com/johnsca","followers_url":"https://api.github.com/users/johnsca/followers","following_url":"https://api.github.com/users/johnsca/following{/other_user}","gists_url":"https://api.github.com/users/johnsca/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsca/subscriptions","organizations_url":"https://api.github.com/users/johnsca/orgs","repos_url":"https://api.github.com/users/johnsca/repos","events_url":"https://api.github.com/users/johnsca/events{/privacy}","received_events_url":"https://api.github.com/users/johnsca/received_events","type":"User","site_admin":false},"body":"Rename \"states\" to \"flags\" because \"flag\" better represents the role they perform and how they work.  It also avoids confusion between `status_set` (from `charmhelpers.core.hookenv`) and `set_state` (from `charms.reactive`).\r\n\r\nAlso refactor the documentation to be better organized and hopefully a bit more clear, particularly to new users.","created_at":"2017-06-29T22:13:47Z","updated_at":"2017-06-30T10:24:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2dde0b898f49d8423b515166910bcbcfa522896","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112/commits","review_comments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112/comments","review_comment_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/112/comments","statuses_url":"https://api.github.com/repos/juju-solutions/charms.reactive/statuses/368853aacf239828d46abcbfb1c919b5a7624c5e","head":{"label":"juju-solutions:refactor/state-flags","ref":"refactor/state-flags","sha":"368853aacf239828d46abcbfb1c919b5a7624c5e","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars2.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":39858489,"name":"charms.reactive","full_name":"juju-solutions/charms.reactive","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars2.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/charms.reactive","description":"Framework for developing charms and relations using the reactive pattern","fork":false,"url":"https://api.github.com/repos/juju-solutions/charms.reactive","forks_url":"https://api.github.com/repos/juju-solutions/charms.reactive/forks","keys_url":"https://api.github.com/repos/juju-solutions/charms.reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/charms.reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/charms.reactive/teams","hooks_url":"https://api.github.com/repos/juju-solutions/charms.reactive/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/charms.reactive/events","assignees_url":"https://api.github.com/repos/juju-solutions/charms.reactive/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/charms.reactive/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/charms.reactive/tags","blobs_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/charms.reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/charms.reactive/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/charms.reactive/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/charms.reactive/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/charms.reactive/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/charms.reactive/subscription","commits_url":"https://api.github.com/repos/juju-solutions/charms.reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/charms.reactive/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/charms.reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/charms.reactive/merges","archive_url":"https://api.github.com/repos/juju-solutions/charms.reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/charms.reactive/downloads","issues_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/charms.reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/charms.reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/charms.reactive/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/charms.reactive/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/deployments","created_at":"2015-07-28T21:22:48Z","updated_at":"2017-02-01T08:54:40Z","pushed_at":"2017-06-29T22:18:12Z","git_url":"git://github.com/juju-solutions/charms.reactive.git","ssh_url":"git@github.com:juju-solutions/charms.reactive.git","clone_url":"https://github.com/juju-solutions/charms.reactive.git","svn_url":"https://github.com/juju-solutions/charms.reactive","homepage":null,"size":491,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":7,"default_branch":"master"}},"base":{"label":"juju-solutions:master","ref":"master","sha":"95493a4dfe4d25a4d5e87342626ffe456873d360","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars2.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":39858489,"name":"charms.reactive","full_name":"juju-solutions/charms.reactive","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars2.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/charms.reactive","description":"Framework for developing charms and relations using the reactive pattern","fork":false,"url":"https://api.github.com/repos/juju-solutions/charms.reactive","forks_url":"https://api.github.com/repos/juju-solutions/charms.reactive/forks","keys_url":"https://api.github.com/repos/juju-solutions/charms.reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/charms.reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/charms.reactive/teams","hooks_url":"https://api.github.com/repos/juju-solutions/charms.reactive/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/charms.reactive/events","assignees_url":"https://api.github.com/repos/juju-solutions/charms.reactive/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/charms.reactive/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/charms.reactive/tags","blobs_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/charms.reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/charms.reactive/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/charms.reactive/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/charms.reactive/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/charms.reactive/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/charms.reactive/subscription","commits_url":"https://api.github.com/repos/juju-solutions/charms.reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/charms.reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/charms.reactive/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/charms.reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/charms.reactive/merges","archive_url":"https://api.github.com/repos/juju-solutions/charms.reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/charms.reactive/downloads","issues_url":"https://api.github.com/repos/juju-solutions/charms.reactive/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/charms.reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/charms.reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/charms.reactive/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/charms.reactive/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/charms.reactive/deployments","created_at":"2015-07-28T21:22:48Z","updated_at":"2017-02-01T08:54:40Z","pushed_at":"2017-06-29T22:18:12Z","git_url":"git://github.com/juju-solutions/charms.reactive.git","ssh_url":"git@github.com:juju-solutions/charms.reactive.git","clone_url":"https://github.com/juju-solutions/charms.reactive.git","svn_url":"https://github.com/juju-solutions/charms.reactive","homepage":null,"size":491,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112"},"html":{"href":"https://github.com/juju-solutions/charms.reactive/pull/112"},"issue":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/112"},"comments":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/juju-solutions/charms.reactive/statuses/368853aacf239828d46abcbfb1c919b5a7624c5e"}}}}
{"actor":{"display_login":"stub42"}}