{"action":"created","issue":{"url":"https://api.github.com/repos/tngan/express-saml2/issues/31","repository_url":"https://api.github.com/repos/tngan/express-saml2","labels_url":"https://api.github.com/repos/tngan/express-saml2/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/tngan/express-saml2/issues/31/comments","events_url":"https://api.github.com/repos/tngan/express-saml2/issues/31/events","html_url":"https://github.com/tngan/express-saml2/issues/31","id":203265788,"number":31,"title":"Query parameter for SLO should be SAMLRequest/SAMLResponse instead of LogoutRequest/LogoutResponse","user":{"login":"tngan","id":10245912,"avatar_url":"https://avatars.githubusercontent.com/u/10245912?v=3","gravatar_id":"","url":"https://api.github.com/users/tngan","html_url":"https://github.com/tngan","followers_url":"https://api.github.com/users/tngan/followers","following_url":"https://api.github.com/users/tngan/following{/other_user}","gists_url":"https://api.github.com/users/tngan/gists{/gist_id}","starred_url":"https://api.github.com/users/tngan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tngan/subscriptions","organizations_url":"https://api.github.com/users/tngan/orgs","repos_url":"https://api.github.com/users/tngan/repos","events_url":"https://api.github.com/users/tngan/events{/privacy}","received_events_url":"https://api.github.com/users/tngan/received_events","type":"User","site_admin":false},"labels":[{"id":247751119,"url":"https://api.github.com/repos/tngan/express-saml2/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-26T00:47:46Z","updated_at":"2017-01-26T06:51:46Z","closed_at":null,"body":"as discussed in #26 "},"comment":{"url":"https://api.github.com/repos/tngan/express-saml2/issues/comments/275319414","html_url":"https://github.com/tngan/express-saml2/issues/31#issuecomment-275319414","issue_url":"https://api.github.com/repos/tngan/express-saml2/issues/31","id":275319414,"user":{"login":"AlexeySafronov","id":8580545,"avatar_url":"https://avatars.githubusercontent.com/u/8580545?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexeySafronov","html_url":"https://github.com/AlexeySafronov","followers_url":"https://api.github.com/users/AlexeySafronov/followers","following_url":"https://api.github.com/users/AlexeySafronov/following{/other_user}","gists_url":"https://api.github.com/users/AlexeySafronov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexeySafronov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexeySafronov/subscriptions","organizations_url":"https://api.github.com/users/AlexeySafronov/orgs","repos_url":"https://api.github.com/users/AlexeySafronov/repos","events_url":"https://api.github.com/users/AlexeySafronov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexeySafronov/received_events","type":"User","site_admin":false},"created_at":"2017-01-26T06:51:46Z","updated_at":"2017-01-26T06:51:46Z","body":"@tngan, you wrote:\r\n> @CatBakun @AlexeySafronov Yes, the string parameter should be only SAMLRequest /SAMLResponse instead of LogoutRequest/LogoutResponse, which are the message body but not the query parameter, thank you for pointing out, will update it soon.\r\n\r\nThanks for quick answer! I still think that query parameter must be SAMLRequest /SAMLResponse too.\r\n\r\nI have created a new application in OneLogin (from template ''SAML Test Connector (IdP w/ attr w/ sign response) '') and set up as follows:\r\n\r\n![6a17f7712b](https://cloud.githubusercontent.com/assets/8580545/22321913/70eb99f8-e3a9-11e6-86ff-8759e45953bb.jpg)\r\n\r\nThen i wrote SP sample app based on your lib. When i try to logout from OneLogin (Idp-initiated logout ), I gets redirect with this query from OneLogin: \r\n\r\n> /sso/slo/callback?SAMLRequest=ndE9b4MwEIDhv8LmCWwwkOQEqJWyIKUd2qprZYyTIoGP%2Bg6pP7%2FkY4g6dOh4%0A0t3zDleRmcYZDnjChV%2Fc1%2BKIo3Zfi49N2neF1iq2RXeMVarz2O52ZazK3BzT%0AXrui34moJVpc64mN51pkKt2sq3FWvqkSdA55JqLvafQEl04tluABDQ0E3kyO%0AgC28Pj4dIEsUzAEZLY4ieneBBvQrmCjRVOdbuJTCnfY3Zohc4BURzSfzTCCl%0AmecEvRvxNPjE4iTPipwcm96wkWW63WpVybvaLf286u3%2BP%2Bl%2BCM4yhgd265np%0AkgFvgavZXKdfD2h%2BAA%3D%3D%0A\r\n\r\n![51ad130fe2](https://cloud.githubusercontent.com/assets/8580545/22322189/4330428c-e3ab-11e6-8ea7-1bdbef2f4b00.jpg)\r\n\r\nThen It was failed in original version of you lib.\r\n\r\nI have changed [this line](https://github.com/tngan/express-saml2/blob/master/lib/Entity.js#L304) to \"parserType: 'SAMLRequest',\" and method bigin work.\r\n\r\n[wiki HTTP Redirect Binding](https://en.wikipedia.org/wiki/SAML_2.0):\r\n\r\n> SAML requests or responses transmitted via HTTP Redirect have a SAMLRequest or SAMLResponse query string parameter, respectively.\r\n\r\nMy logout route:\r\n\r\n```javascript\r\napp.get('/sso/slo/callback',\r\n        function(req, res) {\r\n                        sp.parseLogoutRequest(idp,\r\n                            'redirect',\r\n                            req,\r\n                            function(requestInfo) {\r\n                                logger.info(JSON.stringify(requestInfo));\r\n\r\n                                //TODO: Logout from portal\r\n\r\n                                sp.sendLogoutResponse(idp,\r\n                                    requestInfo,\r\n                                    'redirect',\r\n                                    null,\r\n                                    function cb(url) {\r\n                                        res.redirect(url);\r\n                                    });\r\n                            });\r\n        });\r\n```"}}
{"actor":{"display_login":"AlexeySafronov"}}