{"action":"created","issue":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/305","repository_url":"https://api.github.com/repos/Interkarma/daggerfall-unity","labels_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/305/labels{/name}","comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/305/comments","events_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/305/events","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/305","id":231267376,"number":305,"title":"Fix rest health rate calculation","user":{"login":"Allofich","id":19624336,"avatar_url":"https://avatars1.githubusercontent.com/u/19624336?v=3","gravatar_id":"","url":"https://api.github.com/users/Allofich","html_url":"https://github.com/Allofich","followers_url":"https://api.github.com/users/Allofich/followers","following_url":"https://api.github.com/users/Allofich/following{/other_user}","gists_url":"https://api.github.com/users/Allofich/gists{/gist_id}","starred_url":"https://api.github.com/users/Allofich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Allofich/subscriptions","organizations_url":"https://api.github.com/users/Allofich/orgs","repos_url":"https://api.github.com/users/Allofich/repos","events_url":"https://api.github.com/users/Allofich/events{/privacy}","received_events_url":"https://api.github.com/users/Allofich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-05-25T07:56:16Z","updated_at":"2017-05-25T10:26:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/305","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/305","diff_url":"https://github.com/Interkarma/daggerfall-unity/pull/305.diff","patch_url":"https://github.com/Interkarma/daggerfall-unity/pull/305.patch"},"body":"The problem with the resting function was with the endurance modifier. If you had a negative endurance modifier you could regain no health or even lose health. In classic you regain a minimum of 1 no matter how low your endurance modifier is, and this PR makes DF Unity the same."},"comment":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/comments/303977537","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/305#issuecomment-303977537","issue_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/305","id":303977537,"user":{"login":"Interkarma","id":10426244,"avatar_url":"https://avatars0.githubusercontent.com/u/10426244?v=3","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"created_at":"2017-05-25T10:26:13Z","updated_at":"2017-05-25T10:26:13Z","body":"Thank you Allofich. :) I agree it shouldn't matter in this case because one side is an explicit float. But I've been caught out enough around this issue between what VS suggests as an optimisation and what Unity's Mono C# compiler actually does. I had to work around unexpected outcomes with the old compiler several times prior to 5.3.\r\n\r\nAnyway, it might be unnecessary here, but it's still part of my coding style now to be defensive when dividing around ints. I prefer for the casts to be left in this case. Thank you mate. :)"}}
{"actor":{"display_login":"Interkarma"}}