{"action":"closed","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2864","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2864/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2864/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2864/events","html_url":"https://github.com/Microsoft/visualfsharp/issues/2864","id":221976834,"number":2864,"title":"Incorrect code comment for revAcc function in FSharp.Core/local.fs","user":{"login":"Treit","id":8271812,"avatar_url":"https://avatars1.githubusercontent.com/u/8271812?v=3","gravatar_id":"","url":"https://api.github.com/users/Treit","html_url":"https://github.com/Treit","followers_url":"https://api.github.com/users/Treit/followers","following_url":"https://api.github.com/users/Treit/following{/other_user}","gists_url":"https://api.github.com/users/Treit/gists{/gist_id}","starred_url":"https://api.github.com/users/Treit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treit/subscriptions","organizations_url":"https://api.github.com/users/Treit/orgs","repos_url":"https://api.github.com/users/Treit/repos","events_url":"https://api.github.com/users/Treit/events{/privacy}","received_events_url":"https://api.github.com/users/Treit/received_events","type":"User","site_admin":false},"labels":[{"id":308829999,"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/Area-Library","name":"Area-Library","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-15T22:36:57Z","updated_at":"2017-06-22T15:12:02Z","closed_at":"2017-06-22T15:12:02Z","body":"The following comment on line 412 of FSharp.Core/local.fs implies the following revAcc function uses mutation. However, the implementation does not use mutation so the comment appears to be incorrect.\r\n\r\n        412     // optimized mutation-based implementation. This code is only valid in fslib, where mutation of private \r\n        413     // tail cons cells is permitted in carefully written library code. \r\n        414     let rec revAcc xs acc =  \r\n        415         match xs with  \r\n        416         | [] -> acc \r\n        417         | h::t -> revAcc t (h::acc) \r\n        418 \r\n \r\n        419     let rev xs =  \r\n        420         match xs with  \r\n        421         | [] -> xs \r\n        422         | [_] -> xs \r\n        423         | h1::h2::t -> revAcc t [h2;h1] \r\n\r\nThe incorrect comment should be removed or updated."}}
{"actor":{"display_login":"dsyme"}}