{"action":"created","comment":{"url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/comments/151939335","pull_request_review_id":77720222,"id":151939335,"diff_hunk":"@@ -1,54 +1,71 @@\n .textfield {\n-\tpadding-top: _component(\"textfield.padding-top\");\n+\tdisplay: flex;\n+\tflex-direction: column;\n \tposition: relative;\n \twidth: _component(\"textfield.sizes.default\");\n }\n \n .textfield-input {\n-\tbackground: transparent;\n+\tbackground: _component(\"textfield.background\");\n \tborder: 0;\n-\tbox-shadow: 0 1px 0 0 #CCCCCC;\n-\tcolor: _color(\"text.default\");\n+\tborder-radius: _component(\"textfield.border-radius\");\n+\tbox-shadow: 0 0 0 1px _component(\"textfield.border.color\");\n+\tcolor: _component(\"textfield.input.color\");\n \tfont-family: unquote(_theme(\"commons.font.family\"));\n \tfont-size: _component(\"textfield.font-size\");\n-\tfont-weight: 400;\n-\tmargin-bottom: _component(\"textfield.input.margin-bottom\");\n \toutline: 0;\n-\tpadding: _component(\"textfield.input.padding-vertical\") 0;\n+\tpadding: _component(\"textfield.input.padding-vertical\") _component(\"textfield.input.padding-horizontal\");\n \tposition: relative;\n \ttransition: box-shadow 150ms ease, color 150ms ease;\n \twidth: 100%;\n \n \t&::placeholder {\n \t\tcolor: _color(\"text.placeholder\");\n-\t\topacity: 0;\n \t\ttransition: opacity 150ms ease;\n \t}\n \n \t&:focus {\n-\t\t&::placeholder {\n-\t\t\topacity: 1;\n-\t\t}\n-\n-\t\t~ .textfield-label {\n-\t\t\tfont-size: _theme(\"sizes.small.font-size\");\n-\t\t\ttop: 0;\n-\t\t}\n+\t\tbox-shadow: 0 0 0 1px _component(\"textfield.border.focus\");\n \t}\n }\n \n+.textfield-suffix {\n+\tbottom: _component(\"textfield.input.padding-vertical\");","path":"packages/scss/src/components/inputs/textfield/_textfield.scss","position":49,"original_position":49,"commit_id":"65c416af232daf203d15d1c49f1f43aefe20031f","original_commit_id":"995e003751f05c68112304efe5dc53636d20c595","user":{"login":"sanlucca","id":26228000,"avatar_url":"https://avatars2.githubusercontent.com/u/26228000?v=4","gravatar_id":"","url":"https://api.github.com/users/sanlucca","html_url":"https://github.com/sanlucca","followers_url":"https://api.github.com/users/sanlucca/followers","following_url":"https://api.github.com/users/sanlucca/following{/other_user}","gists_url":"https://api.github.com/users/sanlucca/gists{/gist_id}","starred_url":"https://api.github.com/users/sanlucca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanlucca/subscriptions","organizations_url":"https://api.github.com/users/sanlucca/orgs","repos_url":"https://api.github.com/users/sanlucca/repos","events_url":"https://api.github.com/users/sanlucca/events{/privacy}","received_events_url":"https://api.github.com/users/sanlucca/received_events","type":"User","site_admin":false},"body":"We should anchor it from the top and handle the `mod-noLabel` to avoir any issue with textfield-messages and other stuff that could extend the size of the `textfield`","created_at":"2017-11-20T09:33:10Z","updated_at":"2017-11-20T09:37:35Z","html_url":"https://github.com/LuccaSA/lucca-front/pull/153#discussion_r151939335","pull_request_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/comments/151939335"},"html":{"href":"https://github.com/LuccaSA/lucca-front/pull/153#discussion_r151939335"},"pull_request":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153","id":152817309,"html_url":"https://github.com/LuccaSA/lucca-front/pull/153","diff_url":"https://github.com/LuccaSA/lucca-front/pull/153.diff","patch_url":"https://github.com/LuccaSA/lucca-front/pull/153.patch","issue_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/153","number":153,"state":"open","locked":false,"title":"[add] textfield classic","user":{"login":"jeremie-lucca","id":25581936,"avatar_url":"https://avatars2.githubusercontent.com/u/25581936?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremie-lucca","html_url":"https://github.com/jeremie-lucca","followers_url":"https://api.github.com/users/jeremie-lucca/followers","following_url":"https://api.github.com/users/jeremie-lucca/following{/other_user}","gists_url":"https://api.github.com/users/jeremie-lucca/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremie-lucca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremie-lucca/subscriptions","organizations_url":"https://api.github.com/users/jeremie-lucca/orgs","repos_url":"https://api.github.com/users/jeremie-lucca/repos","events_url":"https://api.github.com/users/jeremie-lucca/events{/privacy}","received_events_url":"https://api.github.com/users/jeremie-lucca/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/25581936/32846546-dd55ff2e-ca27-11e7-8027-3cebae15da72.png)\r\n\r\n![image](https://user-images.githubusercontent.com/25581936/32846589-e753f8be-ca27-11e7-8988-f126a52529f3.png)\r\n\r\n![image](https://user-images.githubusercontent.com/25581936/32846606-f58e1716-ca27-11e7-96e9-6a1910425e1b.png)\r\n","created_at":"2017-11-15T16:11:19Z","updated_at":"2017-11-20T09:37:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b08c224c402d68c04e709742b5cd32b44c45fe4","assignee":{"login":"lucienbertin","id":10089239,"avatar_url":"https://avatars2.githubusercontent.com/u/10089239?v=4","gravatar_id":"","url":"https://api.github.com/users/lucienbertin","html_url":"https://github.com/lucienbertin","followers_url":"https://api.github.com/users/lucienbertin/followers","following_url":"https://api.github.com/users/lucienbertin/following{/other_user}","gists_url":"https://api.github.com/users/lucienbertin/gists{/gist_id}","starred_url":"https://api.github.com/users/lucienbertin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucienbertin/subscriptions","organizations_url":"https://api.github.com/users/lucienbertin/orgs","repos_url":"https://api.github.com/users/lucienbertin/repos","events_url":"https://api.github.com/users/lucienbertin/events{/privacy}","received_events_url":"https://api.github.com/users/lucienbertin/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucienbertin","id":10089239,"avatar_url":"https://avatars2.githubusercontent.com/u/10089239?v=4","gravatar_id":"","url":"https://api.github.com/users/lucienbertin","html_url":"https://github.com/lucienbertin","followers_url":"https://api.github.com/users/lucienbertin/followers","following_url":"https://api.github.com/users/lucienbertin/following{/other_user}","gists_url":"https://api.github.com/users/lucienbertin/gists{/gist_id}","starred_url":"https://api.github.com/users/lucienbertin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucienbertin/subscriptions","organizations_url":"https://api.github.com/users/lucienbertin/orgs","repos_url":"https://api.github.com/users/lucienbertin/repos","events_url":"https://api.github.com/users/lucienbertin/events{/privacy}","received_events_url":"https://api.github.com/users/lucienbertin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153/commits","review_comments_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153/comments","review_comment_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/153/comments","statuses_url":"https://api.github.com/repos/LuccaSA/lucca-front/statuses/65c416af232daf203d15d1c49f1f43aefe20031f","head":{"label":"LuccaSA:scss.textfield.classic","ref":"scss.textfield.classic","sha":"65c416af232daf203d15d1c49f1f43aefe20031f","user":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":88067368,"name":"lucca-front","full_name":"LuccaSA/lucca-front","owner":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuccaSA/lucca-front","description":"TBA","fork":false,"url":"https://api.github.com/repos/LuccaSA/lucca-front","forks_url":"https://api.github.com/repos/LuccaSA/lucca-front/forks","keys_url":"https://api.github.com/repos/LuccaSA/lucca-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/lucca-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/lucca-front/teams","hooks_url":"https://api.github.com/repos/LuccaSA/lucca-front/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/lucca-front/events","assignees_url":"https://api.github.com/repos/LuccaSA/lucca-front/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/lucca-front/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/lucca-front/tags","blobs_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/lucca-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/lucca-front/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/lucca-front/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/lucca-front/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/lucca-front/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/lucca-front/subscription","commits_url":"https://api.github.com/repos/LuccaSA/lucca-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/lucca-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/lucca-front/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/lucca-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/lucca-front/merges","archive_url":"https://api.github.com/repos/LuccaSA/lucca-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/lucca-front/downloads","issues_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/lucca-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/lucca-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/lucca-front/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/lucca-front/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/lucca-front/deployments","created_at":"2017-04-12T15:25:46Z","updated_at":"2017-11-09T10:59:06Z","pushed_at":"2017-11-20T09:21:31Z","git_url":"git://github.com/LuccaSA/lucca-front.git","ssh_url":"git@github.com:LuccaSA/lucca-front.git","clone_url":"https://github.com/LuccaSA/lucca-front.git","svn_url":"https://github.com/LuccaSA/lucca-front","homepage":null,"size":1160,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":2,"default_branch":"master"}},"base":{"label":"LuccaSA:master","ref":"master","sha":"af87cccdad9ea477dfdef7bd1513b973bc29b81b","user":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":88067368,"name":"lucca-front","full_name":"LuccaSA/lucca-front","owner":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuccaSA/lucca-front","description":"TBA","fork":false,"url":"https://api.github.com/repos/LuccaSA/lucca-front","forks_url":"https://api.github.com/repos/LuccaSA/lucca-front/forks","keys_url":"https://api.github.com/repos/LuccaSA/lucca-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/lucca-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/lucca-front/teams","hooks_url":"https://api.github.com/repos/LuccaSA/lucca-front/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/lucca-front/events","assignees_url":"https://api.github.com/repos/LuccaSA/lucca-front/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/lucca-front/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/lucca-front/tags","blobs_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/lucca-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/lucca-front/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/lucca-front/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/lucca-front/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/lucca-front/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/lucca-front/subscription","commits_url":"https://api.github.com/repos/LuccaSA/lucca-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/lucca-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/lucca-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/lucca-front/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/lucca-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/lucca-front/merges","archive_url":"https://api.github.com/repos/LuccaSA/lucca-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/lucca-front/downloads","issues_url":"https://api.github.com/repos/LuccaSA/lucca-front/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/lucca-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/lucca-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/lucca-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/lucca-front/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/lucca-front/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/lucca-front/deployments","created_at":"2017-04-12T15:25:46Z","updated_at":"2017-11-09T10:59:06Z","pushed_at":"2017-11-20T09:21:31Z","git_url":"git://github.com/LuccaSA/lucca-front.git","ssh_url":"git@github.com:LuccaSA/lucca-front.git","clone_url":"https://github.com/LuccaSA/lucca-front.git","svn_url":"https://github.com/LuccaSA/lucca-front","homepage":null,"size":1160,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153"},"html":{"href":"https://github.com/LuccaSA/lucca-front/pull/153"},"issue":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/issues/153"},"comments":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/LuccaSA/lucca-front/statuses/65c416af232daf203d15d1c49f1f43aefe20031f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sanlucca"}}