{"action":"created","comment":{"url":"https://api.github.com/repos/PyCQA/pylint/pulls/comments/97865631","pull_request_review_id":18487500,"id":97865631,"diff_hunk":"@@ -842,3 +842,41 @@ def is_registered_in_singledispatch_function(node):\n             return decorated_with(func_def, singledispatch_qnames)\n \n     return False\n+\n+\n+def splitlines(value, keepends=False):\n+    \"\"\"Splitlines only on universal newlines for consistency across python2","path":"pylint/checkers/utils.py","position":7,"original_position":7,"commit_id":"c67174783c8fcfd8278cf0ac7f69b406d8129414","original_commit_id":"c67174783c8fcfd8278cf0ac7f69b406d8129414","user":{"login":"PCManticore","id":448166,"avatar_url":"https://avatars.githubusercontent.com/u/448166?v=3","gravatar_id":"","url":"https://api.github.com/users/PCManticore","html_url":"https://github.com/PCManticore","followers_url":"https://api.github.com/users/PCManticore/followers","following_url":"https://api.github.com/users/PCManticore/following{/other_user}","gists_url":"https://api.github.com/users/PCManticore/gists{/gist_id}","starred_url":"https://api.github.com/users/PCManticore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCManticore/subscriptions","organizations_url":"https://api.github.com/users/PCManticore/orgs","repos_url":"https://api.github.com/users/PCManticore/repos","events_url":"https://api.github.com/users/PCManticore/events{/privacy}","received_events_url":"https://api.github.com/users/PCManticore/received_events","type":"User","site_admin":false},"body":"I think this is too heavy-weight for our purpose. Also, I'm not too keen on keeping compatibility between Python 2 and 3, we are going to drop support for the former in one-two years max, so I would not want to have code tailored for the former in particular. Why can't we use the builtin ``.splitlines`` here?","created_at":"2017-01-25T19:59:06Z","updated_at":"2017-01-25T20:01:50Z","html_url":"https://github.com/PyCQA/pylint/pull/1283#discussion_r97865631","pull_request_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1283","_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/comments/97865631"},"html":{"href":"https://github.com/PyCQA/pylint/pull/1283#discussion_r97865631"},"pull_request":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1283"}}},"pull_request":{"url":"https://api.github.com/repos/PyCQA/pylint/pulls/1283","id":102564449,"html_url":"https://github.com/PyCQA/pylint/pull/1283","diff_url":"https://github.com/PyCQA/pylint/pull/1283.diff","patch_url":"https://github.com/PyCQA/pylint/pull/1283.patch","issue_url":"https://api.github.com/repos/PyCQA/pylint/issues/1283","number":1283,"state":"open","locked":false,"title":"Don't emit missing-final-newline or trailing-whitespace for formfeeds.","user":{"login":"vinnyrose","id":94764,"avatar_url":"https://avatars.githubusercontent.com/u/94764?v=3","gravatar_id":"","url":"https://api.github.com/users/vinnyrose","html_url":"https://github.com/vinnyrose","followers_url":"https://api.github.com/users/vinnyrose/followers","following_url":"https://api.github.com/users/vinnyrose/following{/other_user}","gists_url":"https://api.github.com/users/vinnyrose/gists{/gist_id}","starred_url":"https://api.github.com/users/vinnyrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinnyrose/subscriptions","organizations_url":"https://api.github.com/users/vinnyrose/orgs","repos_url":"https://api.github.com/users/vinnyrose/repos","events_url":"https://api.github.com/users/vinnyrose/events{/privacy}","received_events_url":"https://api.github.com/users/vinnyrose/received_events","type":"User","site_admin":false},"body":"### Fixes / new features\r\n- Splitlines function that is consistent across py2/3 and str/unicode in py2. Fixes #1218\r\n- Do not treat formfeeds (page breaks) as whitespace. Fixes #1219","created_at":"2017-01-21T01:36:09Z","updated_at":"2017-01-25T20:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92337278b805768a3f06a2e209ab49d4a0dee04c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1283/commits","review_comments_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1283/comments","review_comment_url":"https://api.github.com/repos/PyCQA/pylint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PyCQA/pylint/issues/1283/comments","statuses_url":"https://api.github.com/repos/PyCQA/pylint/statuses/c67174783c8fcfd8278cf0ac7f69b406d8129414","head":{"label":"vinnyrose:issue1218and1219","ref":"issue1218and1219","sha":"c67174783c8fcfd8278cf0ac7f69b406d8129414","user":{"login":"vinnyrose","id":94764,"avatar_url":"https://avatars.githubusercontent.com/u/94764?v=3","gravatar_id":"","url":"https://api.github.com/users/vinnyrose","html_url":"https://github.com/vinnyrose","followers_url":"https://api.github.com/users/vinnyrose/followers","following_url":"https://api.github.com/users/vinnyrose/following{/other_user}","gists_url":"https://api.github.com/users/vinnyrose/gists{/gist_id}","starred_url":"https://api.github.com/users/vinnyrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinnyrose/subscriptions","organizations_url":"https://api.github.com/users/vinnyrose/orgs","repos_url":"https://api.github.com/users/vinnyrose/repos","events_url":"https://api.github.com/users/vinnyrose/events{/privacy}","received_events_url":"https://api.github.com/users/vinnyrose/received_events","type":"User","site_admin":false},"repo":{"id":76732600,"name":"pylint","full_name":"vinnyrose/pylint","owner":{"login":"vinnyrose","id":94764,"avatar_url":"https://avatars.githubusercontent.com/u/94764?v=3","gravatar_id":"","url":"https://api.github.com/users/vinnyrose","html_url":"https://github.com/vinnyrose","followers_url":"https://api.github.com/users/vinnyrose/followers","following_url":"https://api.github.com/users/vinnyrose/following{/other_user}","gists_url":"https://api.github.com/users/vinnyrose/gists{/gist_id}","starred_url":"https://api.github.com/users/vinnyrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinnyrose/subscriptions","organizations_url":"https://api.github.com/users/vinnyrose/orgs","repos_url":"https://api.github.com/users/vinnyrose/repos","events_url":"https://api.github.com/users/vinnyrose/events{/privacy}","received_events_url":"https://api.github.com/users/vinnyrose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinnyrose/pylint","description":"A Python source code analyzer which looks for programming errors, helps enforcing a coding standard and sniffs for some code smells","fork":true,"url":"https://api.github.com/repos/vinnyrose/pylint","forks_url":"https://api.github.com/repos/vinnyrose/pylint/forks","keys_url":"https://api.github.com/repos/vinnyrose/pylint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinnyrose/pylint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinnyrose/pylint/teams","hooks_url":"https://api.github.com/repos/vinnyrose/pylint/hooks","issue_events_url":"https://api.github.com/repos/vinnyrose/pylint/issues/events{/number}","events_url":"https://api.github.com/repos/vinnyrose/pylint/events","assignees_url":"https://api.github.com/repos/vinnyrose/pylint/assignees{/user}","branches_url":"https://api.github.com/repos/vinnyrose/pylint/branches{/branch}","tags_url":"https://api.github.com/repos/vinnyrose/pylint/tags","blobs_url":"https://api.github.com/repos/vinnyrose/pylint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinnyrose/pylint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinnyrose/pylint/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinnyrose/pylint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinnyrose/pylint/statuses/{sha}","languages_url":"https://api.github.com/repos/vinnyrose/pylint/languages","stargazers_url":"https://api.github.com/repos/vinnyrose/pylint/stargazers","contributors_url":"https://api.github.com/repos/vinnyrose/pylint/contributors","subscribers_url":"https://api.github.com/repos/vinnyrose/pylint/subscribers","subscription_url":"https://api.github.com/repos/vinnyrose/pylint/subscription","commits_url":"https://api.github.com/repos/vinnyrose/pylint/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinnyrose/pylint/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinnyrose/pylint/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinnyrose/pylint/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinnyrose/pylint/contents/{+path}","compare_url":"https://api.github.com/repos/vinnyrose/pylint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinnyrose/pylint/merges","archive_url":"https://api.github.com/repos/vinnyrose/pylint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinnyrose/pylint/downloads","issues_url":"https://api.github.com/repos/vinnyrose/pylint/issues{/number}","pulls_url":"https://api.github.com/repos/vinnyrose/pylint/pulls{/number}","milestones_url":"https://api.github.com/repos/vinnyrose/pylint/milestones{/number}","notifications_url":"https://api.github.com/repos/vinnyrose/pylint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinnyrose/pylint/labels{/name}","releases_url":"https://api.github.com/repos/vinnyrose/pylint/releases{/id}","deployments_url":"https://api.github.com/repos/vinnyrose/pylint/deployments","created_at":"2016-12-17T15:51:03Z","updated_at":"2016-12-17T15:51:06Z","pushed_at":"2017-01-21T02:08:31Z","git_url":"git://github.com/vinnyrose/pylint.git","ssh_url":"git@github.com:vinnyrose/pylint.git","clone_url":"https://github.com/vinnyrose/pylint.git","svn_url":"https://github.com/vinnyrose/pylint","homepage":null,"size":21102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PyCQA:master","ref":"master","sha":"fa980eed41be93b9bb880ea114237dce63af9a8b","user":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars.githubusercontent.com/u/8749848?v=3","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"repo":{"id":47671127,"name":"pylint","full_name":"PyCQA/pylint","owner":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars.githubusercontent.com/u/8749848?v=3","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyCQA/pylint","description":"A Python source code analyzer which looks for programming errors, helps enforcing a coding standard and sniffs for some code smells","fork":false,"url":"https://api.github.com/repos/PyCQA/pylint","forks_url":"https://api.github.com/repos/PyCQA/pylint/forks","keys_url":"https://api.github.com/repos/PyCQA/pylint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyCQA/pylint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyCQA/pylint/teams","hooks_url":"https://api.github.com/repos/PyCQA/pylint/hooks","issue_events_url":"https://api.github.com/repos/PyCQA/pylint/issues/events{/number}","events_url":"https://api.github.com/repos/PyCQA/pylint/events","assignees_url":"https://api.github.com/repos/PyCQA/pylint/assignees{/user}","branches_url":"https://api.github.com/repos/PyCQA/pylint/branches{/branch}","tags_url":"https://api.github.com/repos/PyCQA/pylint/tags","blobs_url":"https://api.github.com/repos/PyCQA/pylint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyCQA/pylint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyCQA/pylint/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyCQA/pylint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyCQA/pylint/statuses/{sha}","languages_url":"https://api.github.com/repos/PyCQA/pylint/languages","stargazers_url":"https://api.github.com/repos/PyCQA/pylint/stargazers","contributors_url":"https://api.github.com/repos/PyCQA/pylint/contributors","subscribers_url":"https://api.github.com/repos/PyCQA/pylint/subscribers","subscription_url":"https://api.github.com/repos/PyCQA/pylint/subscription","commits_url":"https://api.github.com/repos/PyCQA/pylint/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyCQA/pylint/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyCQA/pylint/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyCQA/pylint/issues/comments{/number}","contents_url":"https://api.github.com/repos/PyCQA/pylint/contents/{+path}","compare_url":"https://api.github.com/repos/PyCQA/pylint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyCQA/pylint/merges","archive_url":"https://api.github.com/repos/PyCQA/pylint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyCQA/pylint/downloads","issues_url":"https://api.github.com/repos/PyCQA/pylint/issues{/number}","pulls_url":"https://api.github.com/repos/PyCQA/pylint/pulls{/number}","milestones_url":"https://api.github.com/repos/PyCQA/pylint/milestones{/number}","notifications_url":"https://api.github.com/repos/PyCQA/pylint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyCQA/pylint/labels{/name}","releases_url":"https://api.github.com/repos/PyCQA/pylint/releases{/id}","deployments_url":"https://api.github.com/repos/PyCQA/pylint/deployments","created_at":"2015-12-09T05:40:02Z","updated_at":"2017-01-25T14:34:13Z","pushed_at":"2017-01-25T19:58:26Z","git_url":"git://github.com/PyCQA/pylint.git","ssh_url":"git@github.com:PyCQA/pylint.git","clone_url":"https://github.com/PyCQA/pylint.git","svn_url":"https://github.com/PyCQA/pylint","homepage":null,"size":21163,"stargazers_count":476,"watchers_count":476,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":248,"forks":110,"open_issues":248,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1283"},"html":{"href":"https://github.com/PyCQA/pylint/pull/1283"},"issue":{"href":"https://api.github.com/repos/PyCQA/pylint/issues/1283"},"comments":{"href":"https://api.github.com/repos/PyCQA/pylint/issues/1283/comments"},"review_comments":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1283/comments"},"review_comment":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1283/commits"},"statuses":{"href":"https://api.github.com/repos/PyCQA/pylint/statuses/c67174783c8fcfd8278cf0ac7f69b406d8129414"}}}}
{"actor":{"display_login":"PCManticore"}}