{"action":"created","comment":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/126452748","pull_request_review_id":48937674,"id":126452748,"diff_hunk":"@@ -11,7 +11,7 @@\n from abc import ABCMeta, abstractmethod\n \n \n-class BaseSklearnWrapper(object):\n+class BaseTransformer(object):","path":"gensim/sklearn_api/basemodel.py","position":5,"original_position":5,"commit_id":"4d1eaf449beae273fbfe5c121e449a76b54b4082","original_commit_id":"4d1eaf449beae273fbfe5c121e449a76b54b4082","user":{"login":"gojomo","id":1641,"avatar_url":"https://avatars0.githubusercontent.com/u/1641?v=3","gravatar_id":"","url":"https://api.github.com/users/gojomo","html_url":"https://github.com/gojomo","followers_url":"https://api.github.com/users/gojomo/followers","following_url":"https://api.github.com/users/gojomo/following{/other_user}","gists_url":"https://api.github.com/users/gojomo/gists{/gist_id}","starred_url":"https://api.github.com/users/gojomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gojomo/subscriptions","organizations_url":"https://api.github.com/users/gojomo/orgs","repos_url":"https://api.github.com/users/gojomo/repos","events_url":"https://api.github.com/users/gojomo/events{/privacy}","received_events_url":"https://api.github.com/users/gojomo/received_events","type":"User","site_admin":false},"body":"With this refactoring... I'm again wondering, is this class even helpful? Its `set_params()` does less than the implementation that would be inherited from sklearn's own `BaseEstimator`. The other methods just serve to enforce that any subclass override certain methods – a rigor that is possibly useful, but that sklearn does not, itself, impose within its own superclass-hierarchy. ","created_at":"2017-07-10T15:17:49Z","updated_at":"2017-07-10T15:17:50Z","html_url":"https://github.com/RaRe-Technologies/gensim/pull/1473#discussion_r126452748","pull_request_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473","_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/126452748"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/1473#discussion_r126452748"},"pull_request":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473"}}},"pull_request":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473","id":129300868,"html_url":"https://github.com/RaRe-Technologies/gensim/pull/1473","diff_url":"https://github.com/RaRe-Technologies/gensim/pull/1473.diff","patch_url":"https://github.com/RaRe-Technologies/gensim/pull/1473.patch","issue_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1473","number":1473,"state":"open","locked":false,"title":"Renaming sklearn wrapper classes","user":{"login":"chinmayapancholi13","id":10104911,"avatar_url":"https://avatars2.githubusercontent.com/u/10104911?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmayapancholi13","html_url":"https://github.com/chinmayapancholi13","followers_url":"https://api.github.com/users/chinmayapancholi13/followers","following_url":"https://api.github.com/users/chinmayapancholi13/following{/other_user}","gists_url":"https://api.github.com/users/chinmayapancholi13/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmayapancholi13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmayapancholi13/subscriptions","organizations_url":"https://api.github.com/users/chinmayapancholi13/orgs","repos_url":"https://api.github.com/users/chinmayapancholi13/repos","events_url":"https://api.github.com/users/chinmayapancholi13/events{/privacy}","received_events_url":"https://api.github.com/users/chinmayapancholi13/received_events","type":"User","site_admin":false},"body":"This PR renames scikit-learn wrapper classes for Gensim models as suggested [here](https://github.com/RaRe-Technologies/gensim/pull/1437/#discussion_r123593796).","created_at":"2017-07-06T23:17:57Z","updated_at":"2017-07-10T15:17:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdf6b12c1a89fcda5b938f2c4f533e843356eb6d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473/commits","review_comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473/comments","review_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1473/comments","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/4d1eaf449beae273fbfe5c121e449a76b54b4082","head":{"label":"chinmayapancholi13:renaming_skl_wrappers","ref":"renaming_skl_wrappers","sha":"4d1eaf449beae273fbfe5c121e449a76b54b4082","user":{"login":"chinmayapancholi13","id":10104911,"avatar_url":"https://avatars2.githubusercontent.com/u/10104911?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmayapancholi13","html_url":"https://github.com/chinmayapancholi13","followers_url":"https://api.github.com/users/chinmayapancholi13/followers","following_url":"https://api.github.com/users/chinmayapancholi13/following{/other_user}","gists_url":"https://api.github.com/users/chinmayapancholi13/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmayapancholi13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmayapancholi13/subscriptions","organizations_url":"https://api.github.com/users/chinmayapancholi13/orgs","repos_url":"https://api.github.com/users/chinmayapancholi13/repos","events_url":"https://api.github.com/users/chinmayapancholi13/events{/privacy}","received_events_url":"https://api.github.com/users/chinmayapancholi13/received_events","type":"User","site_admin":false},"repo":{"id":83887199,"name":"gensim","full_name":"chinmayapancholi13/gensim","owner":{"login":"chinmayapancholi13","id":10104911,"avatar_url":"https://avatars2.githubusercontent.com/u/10104911?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmayapancholi13","html_url":"https://github.com/chinmayapancholi13","followers_url":"https://api.github.com/users/chinmayapancholi13/followers","following_url":"https://api.github.com/users/chinmayapancholi13/following{/other_user}","gists_url":"https://api.github.com/users/chinmayapancholi13/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmayapancholi13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmayapancholi13/subscriptions","organizations_url":"https://api.github.com/users/chinmayapancholi13/orgs","repos_url":"https://api.github.com/users/chinmayapancholi13/repos","events_url":"https://api.github.com/users/chinmayapancholi13/events{/privacy}","received_events_url":"https://api.github.com/users/chinmayapancholi13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmayapancholi13/gensim","description":"Topic Modelling for Humans","fork":true,"url":"https://api.github.com/repos/chinmayapancholi13/gensim","forks_url":"https://api.github.com/repos/chinmayapancholi13/gensim/forks","keys_url":"https://api.github.com/repos/chinmayapancholi13/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmayapancholi13/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmayapancholi13/gensim/teams","hooks_url":"https://api.github.com/repos/chinmayapancholi13/gensim/hooks","issue_events_url":"https://api.github.com/repos/chinmayapancholi13/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/chinmayapancholi13/gensim/events","assignees_url":"https://api.github.com/repos/chinmayapancholi13/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/chinmayapancholi13/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/chinmayapancholi13/gensim/tags","blobs_url":"https://api.github.com/repos/chinmayapancholi13/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmayapancholi13/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmayapancholi13/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmayapancholi13/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmayapancholi13/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmayapancholi13/gensim/languages","stargazers_url":"https://api.github.com/repos/chinmayapancholi13/gensim/stargazers","contributors_url":"https://api.github.com/repos/chinmayapancholi13/gensim/contributors","subscribers_url":"https://api.github.com/repos/chinmayapancholi13/gensim/subscribers","subscription_url":"https://api.github.com/repos/chinmayapancholi13/gensim/subscription","commits_url":"https://api.github.com/repos/chinmayapancholi13/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmayapancholi13/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmayapancholi13/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmayapancholi13/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmayapancholi13/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/chinmayapancholi13/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmayapancholi13/gensim/merges","archive_url":"https://api.github.com/repos/chinmayapancholi13/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmayapancholi13/gensim/downloads","issues_url":"https://api.github.com/repos/chinmayapancholi13/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/chinmayapancholi13/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmayapancholi13/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmayapancholi13/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmayapancholi13/gensim/labels{/name}","releases_url":"https://api.github.com/repos/chinmayapancholi13/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/chinmayapancholi13/gensim/deployments","created_at":"2017-03-04T11:01:45Z","updated_at":"2017-05-28T20:40:39Z","pushed_at":"2017-07-10T10:49:40Z","git_url":"git://github.com/chinmayapancholi13/gensim.git","ssh_url":"git@github.com:chinmayapancholi13/gensim.git","clone_url":"https://github.com/chinmayapancholi13/gensim.git","svn_url":"https://github.com/chinmayapancholi13/gensim","homepage":"http://radimrehurek.com/gensim/","size":36402,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"RaRe-Technologies:develop","ref":"develop","sha":"e9e223e021c6293dcf4ee7e4860d29071c4617ce","user":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars0.githubusercontent.com/u/12515886?v=3","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":1349775,"name":"gensim","full_name":"RaRe-Technologies/gensim","owner":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars0.githubusercontent.com/u/12515886?v=3","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RaRe-Technologies/gensim","description":"Topic Modelling for Humans","fork":false,"url":"https://api.github.com/repos/RaRe-Technologies/gensim","forks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/forks","keys_url":"https://api.github.com/repos/RaRe-Technologies/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaRe-Technologies/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaRe-Technologies/gensim/teams","hooks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/hooks","issue_events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/events","assignees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/RaRe-Technologies/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/tags","blobs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/RaRe-Technologies/gensim/languages","stargazers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/stargazers","contributors_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contributors","subscribers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscribers","subscription_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscription","commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/RaRe-Technologies/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaRe-Technologies/gensim/merges","archive_url":"https://api.github.com/repos/RaRe-Technologies/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaRe-Technologies/gensim/downloads","issues_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/RaRe-Technologies/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/RaRe-Technologies/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaRe-Technologies/gensim/labels{/name}","releases_url":"https://api.github.com/repos/RaRe-Technologies/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/deployments","created_at":"2011-02-10T07:43:04Z","updated_at":"2017-07-10T14:10:15Z","pushed_at":"2017-07-10T13:37:17Z","git_url":"git://github.com/RaRe-Technologies/gensim.git","ssh_url":"git@github.com:RaRe-Technologies/gensim.git","clone_url":"https://github.com/RaRe-Technologies/gensim.git","svn_url":"https://github.com/RaRe-Technologies/gensim","homepage":"http://radimrehurek.com/gensim/","size":36278,"stargazers_count":4659,"watchers_count":4659,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1836,"mirror_url":null,"open_issues_count":194,"forks":1836,"open_issues":194,"watchers":4659,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/1473"},"issue":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1473"},"comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1473/comments"},"review_comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473/comments"},"review_comment":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1473/commits"},"statuses":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/4d1eaf449beae273fbfe5c121e449a76b54b4082"}}}}
{"actor":{"display_login":"gojomo"}}