{"action":"created","issue":{"url":"https://api.github.com/repos/lob/lob-python/issues/136","repository_url":"https://api.github.com/repos/lob/lob-python","labels_url":"https://api.github.com/repos/lob/lob-python/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/lob/lob-python/issues/136/comments","events_url":"https://api.github.com/repos/lob/lob-python/issues/136/events","html_url":"https://github.com/lob/lob-python/pull/136","id":246880477,"number":136,"title":"chore(py3): copy params before iterating and mutating","user":{"login":"dmlittle","id":3803621,"avatar_url":"https://avatars0.githubusercontent.com/u/3803621?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlittle","html_url":"https://github.com/dmlittle","followers_url":"https://api.github.com/users/dmlittle/followers","following_url":"https://api.github.com/users/dmlittle/following{/other_user}","gists_url":"https://api.github.com/users/dmlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlittle/subscriptions","organizations_url":"https://api.github.com/users/dmlittle/orgs","repos_url":"https://api.github.com/users/dmlittle/repos","events_url":"https://api.github.com/users/dmlittle/events{/privacy}","received_events_url":"https://api.github.com/users/dmlittle/received_events","type":"User","site_admin":false},"labels":[{"id":47252196,"url":"https://api.github.com/repos/lob/lob-python/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T20:51:54Z","updated_at":"2017-07-31T21:14:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lob/lob-python/pulls/136","html_url":"https://github.com/lob/lob-python/pull/136","diff_url":"https://github.com/lob/lob-python/pull/136.diff","patch_url":"https://github.com/lob/lob-python/pull/136.patch"},"body":"**What**\r\n- [x] Make a copy of `params` in `ListableAPIResource` `list` function before iterating and modifying them.\r\n\r\n**Why**\r\nPython2 creates a copy of the dictionary you call `.items()` however Python3 returns an iterator. As such when using Python3, you'll be modifying the same object which you're currently iterating which causes problems (Python3 actually detects this and throws a `RuntimeError`).\r\n\r\nFixes #134 "},"comment":{"url":"https://api.github.com/repos/lob/lob-python/issues/comments/319198503","html_url":"https://github.com/lob/lob-python/pull/136#issuecomment-319198503","issue_url":"https://api.github.com/repos/lob/lob-python/issues/136","id":319198503,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T21:14:27Z","updated_at":"2017-07-31T21:14:27Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12629245/badge)](https://coveralls.io/builds/12629245)\n\nCoverage remained the same at 98.522% when pulling **2ce3b5cd700ce244896ab449148dcbdb701d8ee8 on fix-list-py3** into **f0b71e90d08c658d180afdf9d6f6f7a19c1857fc on master**.\n"}}
{"actor":{"display_login":"coveralls"}}