{"action":"created","issue":{"url":"https://api.github.com/repos/opendatakit/collect/issues/1649","repository_url":"https://api.github.com/repos/opendatakit/collect","labels_url":"https://api.github.com/repos/opendatakit/collect/issues/1649/labels{/name}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/1649/comments","events_url":"https://api.github.com/repos/opendatakit/collect/issues/1649/events","html_url":"https://github.com/opendatakit/collect/pull/1649","id":274850593,"number":1649,"title":"Make offline basemaps available from general settings","user":{"login":"grzesiek2010","id":3276264,"avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"labels":[{"id":612677864,"url":"https://api.github.com/repos/opendatakit/collect/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-17T12:31:25Z","updated_at":"2017-11-21T20:52:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/1649","html_url":"https://github.com/opendatakit/collect/pull/1649","diff_url":"https://github.com/opendatakit/collect/pull/1649.diff","patch_url":"https://github.com/opendatakit/collect/pull/1649.patch"},"body":"Closes #1610 \r\n\r\n#### What has been done to verify that this works as intended?\r\nI've tested new options.\r\nI used a sample map from http://geoodk.com/mbtiles_howto.html\r\nI used also not supported `PBF` format from https://www.mapbox.com/help/define-mbtiles/ to confirm this case is still handled properly.\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nIt's the only solution I can see it's the easiest way.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nIt should be safe.\r\n\r\n#### Do we need any specific form for testing your changes? If so, please attach one.\r\nWe can use AllWidgets form."},"comment":{"url":"https://api.github.com/repos/opendatakit/collect/issues/comments/346157259","html_url":"https://github.com/opendatakit/collect/pull/1649#issuecomment-346157259","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/1649","id":346157259,"user":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T20:52:44Z","updated_at":"2017-11-21T20:52:44Z","author_association":"OWNER","body":"👍 This works really well when the Mapping SDK is set to OSM. The offline options are also available for Google Maps and that doesn't work. I think they should only be available for selection when the SDK is set to Google Maps."}}
{"actor":{"display_login":"lognaturel"}}