{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/gdeploy/pulls/comments/129825457","pull_request_review_id":52636671,"id":129825457,"diff_hunk":"@@ -35,26 +39,44 @@\n         description: Disks from which the Physical Volumes are to be created,\n                      or Physical Volumes that are to be removed needs to be\n                      specified here.\n-    options:\n-        required: false\n-        description: Extra options that needs to be passed while creating the\n-                     Physical Volumes can be given here. Check the man page of\n-                     pvcreate for more info.\n     size:\n-        required: true if action is resize and opertion is shrink\n+        required: true\n         description: Specifies to what size the physical volume is to be\n                      shrunken\n+    force:\n+        required: true\n+        description: Force  the  creation  without  any confirmation.\n+    uuid:\n+        required: true\n+        description: Specify the uuid for the device.  Without this option,\n+                     pvcreate generates a random uuid.\n+    zero:\n+        required: true","path":"modules/pv.py","position":45,"original_position":45,"commit_id":"54379910e28779dd56cf31d35688f334a91915e4","original_commit_id":"d9eb1005e74fd21c02ddc2847dc109fdd15f3a3e","user":{"login":"sac","id":414248,"avatar_url":"https://avatars2.githubusercontent.com/u/414248?v=4","gravatar_id":"","url":"https://api.github.com/users/sac","html_url":"https://github.com/sac","followers_url":"https://api.github.com/users/sac/followers","following_url":"https://api.github.com/users/sac/following{/other_user}","gists_url":"https://api.github.com/users/sac/gists{/gist_id}","starred_url":"https://api.github.com/users/sac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sac/subscriptions","organizations_url":"https://api.github.com/users/sac/orgs","repos_url":"https://api.github.com/users/sac/repos","events_url":"https://api.github.com/users/sac/events{/privacy}","received_events_url":"https://api.github.com/users/sac/received_events","type":"User","site_admin":false},"body":"Required is false. They can choose not to use zero.","created_at":"2017-07-27T12:17:22Z","updated_at":"2017-07-27T12:37:47Z","html_url":"https://github.com/gluster/gdeploy/pull/403#discussion_r129825457","pull_request_url":"https://api.github.com/repos/gluster/gdeploy/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/comments/129825457"},"html":{"href":"https://github.com/gluster/gdeploy/pull/403#discussion_r129825457"},"pull_request":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/gluster/gdeploy/pulls/403","id":132733297,"html_url":"https://github.com/gluster/gdeploy/pull/403","diff_url":"https://github.com/gluster/gdeploy/pull/403.diff","patch_url":"https://github.com/gluster/gdeploy/pull/403.patch","issue_url":"https://api.github.com/repos/gluster/gdeploy/issues/403","number":403,"state":"open","locked":false,"title":"added new options like force, metadatasize etc","user":{"login":"ashmitha7","id":28265276,"avatar_url":"https://avatars0.githubusercontent.com/u/28265276?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmitha7","html_url":"https://github.com/ashmitha7","followers_url":"https://api.github.com/users/ashmitha7/followers","following_url":"https://api.github.com/users/ashmitha7/following{/other_user}","gists_url":"https://api.github.com/users/ashmitha7/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmitha7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmitha7/subscriptions","organizations_url":"https://api.github.com/users/ashmitha7/orgs","repos_url":"https://api.github.com/users/ashmitha7/repos","events_url":"https://api.github.com/users/ashmitha7/events{/privacy}","received_events_url":"https://api.github.com/users/ashmitha7/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-27T12:09:48Z","updated_at":"2017-07-27T12:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d2234af34a9f0aa7d0904be171d4019441ea789","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/gdeploy/pulls/403/commits","review_comments_url":"https://api.github.com/repos/gluster/gdeploy/pulls/403/comments","review_comment_url":"https://api.github.com/repos/gluster/gdeploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/gdeploy/issues/403/comments","statuses_url":"https://api.github.com/repos/gluster/gdeploy/statuses/54379910e28779dd56cf31d35688f334a91915e4","head":{"label":"ashmitha7:gdeploy3.0","ref":"gdeploy3.0","sha":"54379910e28779dd56cf31d35688f334a91915e4","user":{"login":"ashmitha7","id":28265276,"avatar_url":"https://avatars0.githubusercontent.com/u/28265276?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmitha7","html_url":"https://github.com/ashmitha7","followers_url":"https://api.github.com/users/ashmitha7/followers","following_url":"https://api.github.com/users/ashmitha7/following{/other_user}","gists_url":"https://api.github.com/users/ashmitha7/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmitha7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmitha7/subscriptions","organizations_url":"https://api.github.com/users/ashmitha7/orgs","repos_url":"https://api.github.com/users/ashmitha7/repos","events_url":"https://api.github.com/users/ashmitha7/events{/privacy}","received_events_url":"https://api.github.com/users/ashmitha7/received_events","type":"User","site_admin":false},"repo":{"id":96502047,"name":"gdeploy","full_name":"ashmitha7/gdeploy","owner":{"login":"ashmitha7","id":28265276,"avatar_url":"https://avatars0.githubusercontent.com/u/28265276?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmitha7","html_url":"https://github.com/ashmitha7","followers_url":"https://api.github.com/users/ashmitha7/followers","following_url":"https://api.github.com/users/ashmitha7/following{/other_user}","gists_url":"https://api.github.com/users/ashmitha7/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmitha7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmitha7/subscriptions","organizations_url":"https://api.github.com/users/ashmitha7/orgs","repos_url":"https://api.github.com/users/ashmitha7/repos","events_url":"https://api.github.com/users/ashmitha7/events{/privacy}","received_events_url":"https://api.github.com/users/ashmitha7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashmitha7/gdeploy","description":"Tool to deploy glusterfs ","fork":true,"url":"https://api.github.com/repos/ashmitha7/gdeploy","forks_url":"https://api.github.com/repos/ashmitha7/gdeploy/forks","keys_url":"https://api.github.com/repos/ashmitha7/gdeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashmitha7/gdeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashmitha7/gdeploy/teams","hooks_url":"https://api.github.com/repos/ashmitha7/gdeploy/hooks","issue_events_url":"https://api.github.com/repos/ashmitha7/gdeploy/issues/events{/number}","events_url":"https://api.github.com/repos/ashmitha7/gdeploy/events","assignees_url":"https://api.github.com/repos/ashmitha7/gdeploy/assignees{/user}","branches_url":"https://api.github.com/repos/ashmitha7/gdeploy/branches{/branch}","tags_url":"https://api.github.com/repos/ashmitha7/gdeploy/tags","blobs_url":"https://api.github.com/repos/ashmitha7/gdeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashmitha7/gdeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashmitha7/gdeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashmitha7/gdeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashmitha7/gdeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/ashmitha7/gdeploy/languages","stargazers_url":"https://api.github.com/repos/ashmitha7/gdeploy/stargazers","contributors_url":"https://api.github.com/repos/ashmitha7/gdeploy/contributors","subscribers_url":"https://api.github.com/repos/ashmitha7/gdeploy/subscribers","subscription_url":"https://api.github.com/repos/ashmitha7/gdeploy/subscription","commits_url":"https://api.github.com/repos/ashmitha7/gdeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashmitha7/gdeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashmitha7/gdeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashmitha7/gdeploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashmitha7/gdeploy/contents/{+path}","compare_url":"https://api.github.com/repos/ashmitha7/gdeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashmitha7/gdeploy/merges","archive_url":"https://api.github.com/repos/ashmitha7/gdeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashmitha7/gdeploy/downloads","issues_url":"https://api.github.com/repos/ashmitha7/gdeploy/issues{/number}","pulls_url":"https://api.github.com/repos/ashmitha7/gdeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/ashmitha7/gdeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/ashmitha7/gdeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashmitha7/gdeploy/labels{/name}","releases_url":"https://api.github.com/repos/ashmitha7/gdeploy/releases{/id}","deployments_url":"https://api.github.com/repos/ashmitha7/gdeploy/deployments","created_at":"2017-07-07T05:23:34Z","updated_at":"2017-07-07T05:23:36Z","pushed_at":"2017-07-27T12:11:14Z","git_url":"git://github.com/ashmitha7/gdeploy.git","ssh_url":"git@github.com:ashmitha7/gdeploy.git","clone_url":"https://github.com/ashmitha7/gdeploy.git","svn_url":"https://github.com/ashmitha7/gdeploy","homepage":null,"size":3247,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"ceb405135c6b786fdcd0c8a34e9b0a5835b1e349","user":{"login":"gluster","id":622644,"avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":40538342,"name":"gdeploy","full_name":"gluster/gdeploy","owner":{"login":"gluster","id":622644,"avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/gdeploy","description":"Tool to deploy glusterfs ","fork":false,"url":"https://api.github.com/repos/gluster/gdeploy","forks_url":"https://api.github.com/repos/gluster/gdeploy/forks","keys_url":"https://api.github.com/repos/gluster/gdeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/gdeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/gdeploy/teams","hooks_url":"https://api.github.com/repos/gluster/gdeploy/hooks","issue_events_url":"https://api.github.com/repos/gluster/gdeploy/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/gdeploy/events","assignees_url":"https://api.github.com/repos/gluster/gdeploy/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/gdeploy/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/gdeploy/tags","blobs_url":"https://api.github.com/repos/gluster/gdeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/gdeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/gdeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/gdeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/gdeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/gdeploy/languages","stargazers_url":"https://api.github.com/repos/gluster/gdeploy/stargazers","contributors_url":"https://api.github.com/repos/gluster/gdeploy/contributors","subscribers_url":"https://api.github.com/repos/gluster/gdeploy/subscribers","subscription_url":"https://api.github.com/repos/gluster/gdeploy/subscription","commits_url":"https://api.github.com/repos/gluster/gdeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/gdeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/gdeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/gdeploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/gdeploy/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/gdeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/gdeploy/merges","archive_url":"https://api.github.com/repos/gluster/gdeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/gdeploy/downloads","issues_url":"https://api.github.com/repos/gluster/gdeploy/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/gdeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/gdeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/gdeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/gdeploy/labels{/name}","releases_url":"https://api.github.com/repos/gluster/gdeploy/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/gdeploy/deployments","created_at":"2015-08-11T11:35:05Z","updated_at":"2017-07-26T18:12:53Z","pushed_at":"2017-07-27T12:22:23Z","git_url":"git://github.com/gluster/gdeploy.git","ssh_url":"git@github.com:gluster/gdeploy.git","clone_url":"https://github.com/gluster/gdeploy.git","svn_url":"https://github.com/gluster/gdeploy","homepage":null,"size":3275,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":32,"forks":36,"open_issues":32,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/403"},"html":{"href":"https://github.com/gluster/gdeploy/pull/403"},"issue":{"href":"https://api.github.com/repos/gluster/gdeploy/issues/403"},"comments":{"href":"https://api.github.com/repos/gluster/gdeploy/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/gdeploy/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/gdeploy/statuses/54379910e28779dd56cf31d35688f334a91915e4"}}}}
{"actor":{"display_login":"sac"}}