{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/121549931","pull_request_review_id":43587169,"id":121549931,"diff_hunk":"@@ -477,6 +477,11 @@ func NewProxyServer(config *componentconfig.KubeProxyConfiguration, cleanupAndEx\n \t\t\treturn nil, fmt.Errorf(\"unable to read IPTables MasqueradeBit from config\")\n \t\t}\n \n+\t\tnodeIP, err := getNodeIP(client, hostname)\n+\t\tif err != nil {\n+\t\t\treturn nil, fmt.Errorf(\"unable to fetch node IP: %v\", err)","path":"cmd/kube-proxy/app/server.go","position":6,"original_position":6,"commit_id":"f5db9271fa63d78afa7cd871a4281b7f277e4f5f","original_commit_id":"f5db9271fa63d78afa7cd871a4281b7f277e4f5f","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars0.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"@MikeSpreitzer  I know. With this change, if someone is running a standalone kube-proxy. It will fail. So I am wondering if it is reasonable to grab bind-address for this. ","created_at":"2017-06-12T23:13:29Z","updated_at":"2017-06-12T23:13:31Z","html_url":"https://github.com/kubernetes/kubernetes/pull/47262#discussion_r121549931","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/121549931"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47262#discussion_r121549931"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262","id":124928719,"html_url":"https://github.com/kubernetes/kubernetes/pull/47262","diff_url":"https://github.com/kubernetes/kubernetes/pull/47262.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47262.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47262","number":47262,"state":"open","locked":false,"title":"kube-proxy: wait, if necessary, for node to be defined","user":{"login":"MikeSpreitzer","id":14296719,"avatar_url":"https://avatars1.githubusercontent.com/u/14296719?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeSpreitzer","html_url":"https://github.com/MikeSpreitzer","followers_url":"https://api.github.com/users/MikeSpreitzer/followers","following_url":"https://api.github.com/users/MikeSpreitzer/following{/other_user}","gists_url":"https://api.github.com/users/MikeSpreitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSpreitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSpreitzer/subscriptions","organizations_url":"https://api.github.com/users/MikeSpreitzer/orgs","repos_url":"https://api.github.com/users/MikeSpreitzer/repos","events_url":"https://api.github.com/users/MikeSpreitzer/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSpreitzer/received_events","type":"User","site_admin":false},"body":"Make the kube-proxy retry fetching the local Node a few times with\r\nexponential backoff, to resolve the race between startup of kube-proxy\r\nand kubelet.  There is a limited number of retries, and if the Node\r\ncan not be fetched within the limit then the kube-proxy exits with an\r\nerror so that a higher-level thing can deal with the problem.\r\n\r\nResolves issue #37414\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**: this fixes a bug that causes tests to flake\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #37414 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-06-09T18:51:32Z","updated_at":"2017-06-12T23:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea32d820ab752d484d3bdd965274867f50213d19","assignee":{"login":"freehan","id":1332699,"avatar_url":"https://avatars0.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"assignees":[{"login":"freehan","id":1332699,"avatar_url":"https://avatars0.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars1.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47262/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f5db9271fa63d78afa7cd871a4281b7f277e4f5f","head":{"label":"MikeSpreitzer:issue37414","ref":"issue37414","sha":"f5db9271fa63d78afa7cd871a4281b7f277e4f5f","user":{"login":"MikeSpreitzer","id":14296719,"avatar_url":"https://avatars1.githubusercontent.com/u/14296719?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeSpreitzer","html_url":"https://github.com/MikeSpreitzer","followers_url":"https://api.github.com/users/MikeSpreitzer/followers","following_url":"https://api.github.com/users/MikeSpreitzer/following{/other_user}","gists_url":"https://api.github.com/users/MikeSpreitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSpreitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSpreitzer/subscriptions","organizations_url":"https://api.github.com/users/MikeSpreitzer/orgs","repos_url":"https://api.github.com/users/MikeSpreitzer/repos","events_url":"https://api.github.com/users/MikeSpreitzer/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSpreitzer/received_events","type":"User","site_admin":false},"repo":{"id":45766031,"name":"kubernetes","full_name":"MikeSpreitzer/kubernetes","owner":{"login":"MikeSpreitzer","id":14296719,"avatar_url":"https://avatars1.githubusercontent.com/u/14296719?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeSpreitzer","html_url":"https://github.com/MikeSpreitzer","followers_url":"https://api.github.com/users/MikeSpreitzer/followers","following_url":"https://api.github.com/users/MikeSpreitzer/following{/other_user}","gists_url":"https://api.github.com/users/MikeSpreitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSpreitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSpreitzer/subscriptions","organizations_url":"https://api.github.com/users/MikeSpreitzer/orgs","repos_url":"https://api.github.com/users/MikeSpreitzer/repos","events_url":"https://api.github.com/users/MikeSpreitzer/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSpreitzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikeSpreitzer/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/MikeSpreitzer/kubernetes","forks_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/forks","keys_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/teams","hooks_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/events","assignees_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/tags","blobs_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/subscription","commits_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/merges","archive_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/downloads","issues_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/MikeSpreitzer/kubernetes/deployments","created_at":"2015-11-08T03:53:14Z","updated_at":"2017-05-03T03:08:13Z","pushed_at":"2017-06-12T20:38:11Z","git_url":"git://github.com/MikeSpreitzer/kubernetes.git","ssh_url":"git@github.com:MikeSpreitzer/kubernetes.git","clone_url":"https://github.com/MikeSpreitzer/kubernetes.git","svn_url":"https://github.com/MikeSpreitzer/kubernetes","homepage":"http://kubernetes.io","size":446242,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"695d4385085beb1112f61b7ec7397596b6e82e8e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-06-12T22:25:18Z","pushed_at":"2017-06-12T23:03:45Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":664194,"stargazers_count":23947,"watchers_count":23947,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8475,"mirror_url":null,"open_issues_count":5135,"forks":8475,"open_issues":5135,"watchers":23947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47262"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47262"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47262/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47262/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f5db9271fa63d78afa7cd871a4281b7f277e4f5f"}}}}
{"actor":{"display_login":"freehan"}}