{"action":"opened","issue":{"url":"https://api.github.com/repos/UW-Hydro/VIC/issues/749","repository_url":"https://api.github.com/repos/UW-Hydro/VIC","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/749/labels{/name}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/749/comments","events_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/749/events","html_url":"https://github.com/UW-Hydro/VIC/issues/749","id":259917979,"number":749,"title":"CLEANUP: remove unused parameter `annual_prec` from driver code and soil_con","user":{"login":"tbohn","id":3496314,"avatar_url":"https://avatars0.githubusercontent.com/u/3496314?v=4","gravatar_id":"","url":"https://api.github.com/users/tbohn","html_url":"https://github.com/tbohn","followers_url":"https://api.github.com/users/tbohn/followers","following_url":"https://api.github.com/users/tbohn/following{/other_user}","gists_url":"https://api.github.com/users/tbohn/gists{/gist_id}","starred_url":"https://api.github.com/users/tbohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbohn/subscriptions","organizations_url":"https://api.github.com/users/tbohn/orgs","repos_url":"https://api.github.com/users/tbohn/repos","events_url":"https://api.github.com/users/tbohn/events{/privacy}","received_events_url":"https://api.github.com/users/tbohn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-22T19:46:06Z","updated_at":"2017-09-22T19:46:06Z","closed_at":null,"author_association":"COLLABORATOR","body":"Version: VIC 5.0 and later (all drivers)\r\nDescription: the parameter `annual_prec` is read from the parameter file(s) but never used.  I propose to remove the reading of annual_prec from the following files:\r\n- vic/vic_run/include/vic_def.h\r\n- vic/drivers/classic/src/read_soilparam.c (although may disrupt backwards-compatibility, see below)\r\n- vic/drivers/shared_all/src/print_library_shared.c\r\n- vic/drivers/shared_image/src/init_library.c\r\n- vic/drivers/shared_image/src/vic_init.c\r\nBackwards compatibility:\r\n- Image mode: backwards compatible, since reading the other variables in the netcdf-format parameter file does not depend the presence/absence of annual_prec\r\n- Classic mode: not backwards compatible, unless some provision is made for the potential presence of annual_prec in the soil parameter file.  This could be accomplished with an option similar to the JULY_TAVG_SUPPLIED flag, which if `TRUE` would tell `read_soilparam()` to skip that column of the file.  But such an option seems somewhat silly (a lot of effort for a parameter that is not used)"}}
{"actor":{"display_login":"tbohn"}}