{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/121458663","pull_request_review_id":43488521,"id":121458663,"diff_hunk":"@@ -79,6 +79,10 @@ _:-ms-lang(x), _:-webkit-full-screen, kubernetes-topology-icon svg /* Edge hack\n   stroke: #bbb;\n }\n \n+.kube-topology g circle.information {\n+  stroke: #00c;\n+}\n+","path":"app/assets/stylesheets/topology.css","position":7,"original_position":7,"commit_id":"b94810471e69f81651d78e2c81f12c4870690114","original_commit_id":"fa401f28bde17c252492655b69a290e66357e010","user":{"login":"mtho11","id":1312165,"avatar_url":"https://avatars0.githubusercontent.com/u/1312165?v=3","gravatar_id":"","url":"https://api.github.com/users/mtho11","html_url":"https://github.com/mtho11","followers_url":"https://api.github.com/users/mtho11/followers","following_url":"https://api.github.com/users/mtho11/following{/other_user}","gists_url":"https://api.github.com/users/mtho11/gists{/gist_id}","starred_url":"https://api.github.com/users/mtho11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtho11/subscriptions","organizations_url":"https://api.github.com/users/mtho11/orgs","repos_url":"https://api.github.com/users/mtho11/repos","events_url":"https://api.github.com/users/mtho11/events{/privacy}","received_events_url":"https://api.github.com/users/mtho11/received_events","type":"User","site_admin":false},"body":"Yes, I agree with having the css in middleware topology as well.","created_at":"2017-06-12T16:17:40Z","updated_at":"2017-06-12T16:17:40Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461#discussion_r121458663","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/121458663"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461#discussion_r121458663"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461","id":123085212,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1461","number":1461,"state":"open","locked":false,"title":"Rendering status for servers and deployments in middleware topology","user":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"body":"Status of middleware servers and deployments are set when building\r\ntopology view. This renders the status in tooltips in related\r\ntopology nodes and also renders status colors.\r\n\r\nRegarding colors:\r\n- For middleware servers, when status is:\r\n  * Down => red\r\n  * Running => green\r\n  * Reload required => amber\r\n  * Starting => blue\r\n- For deployments:\r\n  * Enabled => green\r\n  * Disabled => amber\r\n\r\nThis is the first step to cover ManageIQ/manageiq-providers-hawkular#5\r\n\r\n![topology_screenshot](https://user-images.githubusercontent.com/23639005/26904309-f77d6860-4ba6-11e7-9807-6ebe90b4b804.png)\r\n","created_at":"2017-05-30T15:58:07Z","updated_at":"2017-06-12T16:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1902e703c170588489ce1c5b6b9d6ac18a18a7e2","assignee":{"login":"abonas","id":6277245,"avatar_url":"https://avatars1.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"assignees":[{"login":"abonas","id":6277245,"avatar_url":"https://avatars1.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1461/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/b94810471e69f81651d78e2c81f12c4870690114","head":{"label":"israel-hdez:topology_servers_deployments_status","ref":"topology_servers_deployments_status","sha":"b94810471e69f81651d78e2c81f12c4870690114","user":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"repo":{"id":84598032,"name":"manageiq-ui-classic","full_name":"israel-hdez/manageiq-ui-classic","owner":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/israel-hdez/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic","forks_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/israel-hdez/manageiq-ui-classic/deployments","created_at":"2017-03-10T20:26:30Z","updated_at":"2017-03-10T20:26:37Z","pushed_at":"2017-06-07T22:27:17Z","git_url":"git://github.com/israel-hdez/manageiq-ui-classic.git","ssh_url":"git@github.com:israel-hdez/manageiq-ui-classic.git","clone_url":"https://github.com/israel-hdez/manageiq-ui-classic.git","svn_url":"https://github.com/israel-hdez/manageiq-ui-classic","homepage":null,"size":43213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a1c738946bce3c3bb312d648e6ce11a947d25943","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2017-04-28T15:50:11Z","pushed_at":"2017-06-12T15:41:17Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":45130,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":190,"forks":140,"open_issues":190,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1461"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1461"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1461/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1461/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/b94810471e69f81651d78e2c81f12c4870690114"}}}}
{"actor":{"display_login":"mtho11"}}