{"action":"created","issue":{"url":"https://api.github.com/repos/nextic/IC/issues/406","repository_url":"https://api.github.com/repos/nextic/IC","labels_url":"https://api.github.com/repos/nextic/IC/issues/406/labels{/name}","comments_url":"https://api.github.com/repos/nextic/IC/issues/406/comments","events_url":"https://api.github.com/repos/nextic/IC/issues/406/events","html_url":"https://github.com/nextic/IC/pull/406","id":277422099,"number":406,"title":"Implementation of new PMAPs interface","user":{"login":"abotas","id":19876752,"avatar_url":"https://avatars1.githubusercontent.com/u/19876752?v=4","gravatar_id":"","url":"https://api.github.com/users/abotas","html_url":"https://github.com/abotas","followers_url":"https://api.github.com/users/abotas/followers","following_url":"https://api.github.com/users/abotas/following{/other_user}","gists_url":"https://api.github.com/users/abotas/gists{/gist_id}","starred_url":"https://api.github.com/users/abotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abotas/subscriptions","organizations_url":"https://api.github.com/users/abotas/orgs","repos_url":"https://api.github.com/users/abotas/repos","events_url":"https://api.github.com/users/abotas/events{/privacy}","received_events_url":"https://api.github.com/users/abotas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jahernando","id":8170501,"avatar_url":"https://avatars2.githubusercontent.com/u/8170501?v=4","gravatar_id":"","url":"https://api.github.com/users/jahernando","html_url":"https://github.com/jahernando","followers_url":"https://api.github.com/users/jahernando/followers","following_url":"https://api.github.com/users/jahernando/following{/other_user}","gists_url":"https://api.github.com/users/jahernando/gists{/gist_id}","starred_url":"https://api.github.com/users/jahernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahernando/subscriptions","organizations_url":"https://api.github.com/users/jahernando/orgs","repos_url":"https://api.github.com/users/jahernando/repos","events_url":"https://api.github.com/users/jahernando/events{/privacy}","received_events_url":"https://api.github.com/users/jahernando/received_events","type":"User","site_admin":false},"assignees":[{"login":"jahernando","id":8170501,"avatar_url":"https://avatars2.githubusercontent.com/u/8170501?v=4","gravatar_id":"","url":"https://api.github.com/users/jahernando","html_url":"https://github.com/jahernando","followers_url":"https://api.github.com/users/jahernando/followers","following_url":"https://api.github.com/users/jahernando/following{/other_user}","gists_url":"https://api.github.com/users/jahernando/gists{/gist_id}","starred_url":"https://api.github.com/users/jahernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahernando/subscriptions","organizations_url":"https://api.github.com/users/jahernando/orgs","repos_url":"https://api.github.com/users/jahernando/repos","events_url":"https://api.github.com/users/jahernando/events{/privacy}","received_events_url":"https://api.github.com/users/jahernando/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2017-11-28T15:17:58Z","updated_at":"2017-11-28T21:19:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/nextic/IC/pulls/406","html_url":"https://github.com/nextic/IC/pull/406","diff_url":"https://github.com/nextic/IC/pull/406.diff","patch_url":"https://github.com/nextic/IC/pull/406.patch"},"body":"This PR consists of a full parallel python implementation with a corresponding test suite for the new PMAPs following their interface defined in PR #394, and is meant to fulfill step 2 in @jacg's comment at the end of issue #177 [edit] ... and, more importantly, step 2 of #407."},"comment":{"url":"https://api.github.com/repos/nextic/IC/issues/comments/347667074","html_url":"https://github.com/nextic/IC/pull/406#issuecomment-347667074","issue_url":"https://api.github.com/repos/nextic/IC/issues/406","id":347667074,"user":{"login":"jacg","id":2570854,"avatar_url":"https://avatars3.githubusercontent.com/u/2570854?v=4","gravatar_id":"","url":"https://api.github.com/users/jacg","html_url":"https://github.com/jacg","followers_url":"https://api.github.com/users/jacg/followers","following_url":"https://api.github.com/users/jacg/following{/other_user}","gists_url":"https://api.github.com/users/jacg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacg/subscriptions","organizations_url":"https://api.github.com/users/jacg/orgs","repos_url":"https://api.github.com/users/jacg/repos","events_url":"https://api.github.com/users/jacg/events{/privacy}","received_events_url":"https://api.github.com/users/jacg/received_events","type":"User","site_admin":false},"created_at":"2017-11-28T21:19:30Z","updated_at":"2017-11-28T21:19:30Z","author_association":"COLLABORATOR","body":"+ I appreciate where you're coming from, but I find the double underscore in `test__Peak_*` a bit much.\r\n\r\n+ The first three commits have titles which claim to add generators, but generator has a quite specific technical meaning in Python, and it's not the things being added in those commits. The things being added also have a very specific technical name: *fixtures*. Please reword these.\r\n\r\n+ By the end of *The Big Refactor*, `new_pmaps` will have to be renamed to `pmaps`.\r\n\r\n+ Isn't `one_of(just(S1), just(S2))` a long-winded way of writing `sampled_from((S1, S2))` ?\r\n\r\n+ Prefer `pytest.approx` to `nupmy.allclose` etc.\r\n\r\n+ Please squash out commits which fix mistakes in prevous commits in this PR, such as 'Demand absolute equality in new pmaps tests (not allclose)'.\r\n\r\n"}}
{"actor":{"display_login":"jacg"}}