{"action":"created","issue":{"url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1451","repository_url":"https://api.github.com/repos/fossasia/open-event-webapp","labels_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1451/labels{/name}","comments_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1451/comments","events_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1451/events","html_url":"https://github.com/fossasia/open-event-webapp/pull/1451","id":251446440,"number":1451,"title":"Fixes #1450:Error displays in logs when unable to send email","user":{"login":"agbilotia1998","id":21157929,"avatar_url":"https://avatars2.githubusercontent.com/u/21157929?v=4","gravatar_id":"","url":"https://api.github.com/users/agbilotia1998","html_url":"https://github.com/agbilotia1998","followers_url":"https://api.github.com/users/agbilotia1998/followers","following_url":"https://api.github.com/users/agbilotia1998/following{/other_user}","gists_url":"https://api.github.com/users/agbilotia1998/gists{/gist_id}","starred_url":"https://api.github.com/users/agbilotia1998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbilotia1998/subscriptions","organizations_url":"https://api.github.com/users/agbilotia1998/orgs","repos_url":"https://api.github.com/users/agbilotia1998/repos","events_url":"https://api.github.com/users/agbilotia1998/events{/privacy}","received_events_url":"https://api.github.com/users/agbilotia1998/received_events","type":"User","site_admin":false},"labels":[{"id":634391771,"url":"https://api.github.com/repos/fossasia/open-event-webapp/labels/needs-review","name":"needs-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"agbilotia1998","id":21157929,"avatar_url":"https://avatars2.githubusercontent.com/u/21157929?v=4","gravatar_id":"","url":"https://api.github.com/users/agbilotia1998","html_url":"https://github.com/agbilotia1998","followers_url":"https://api.github.com/users/agbilotia1998/followers","following_url":"https://api.github.com/users/agbilotia1998/following{/other_user}","gists_url":"https://api.github.com/users/agbilotia1998/gists{/gist_id}","starred_url":"https://api.github.com/users/agbilotia1998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbilotia1998/subscriptions","organizations_url":"https://api.github.com/users/agbilotia1998/orgs","repos_url":"https://api.github.com/users/agbilotia1998/repos","events_url":"https://api.github.com/users/agbilotia1998/events{/privacy}","received_events_url":"https://api.github.com/users/agbilotia1998/received_events","type":"User","site_admin":false},"assignees":[{"login":"agbilotia1998","id":21157929,"avatar_url":"https://avatars2.githubusercontent.com/u/21157929?v=4","gravatar_id":"","url":"https://api.github.com/users/agbilotia1998","html_url":"https://github.com/agbilotia1998","followers_url":"https://api.github.com/users/agbilotia1998/followers","following_url":"https://api.github.com/users/agbilotia1998/following{/other_user}","gists_url":"https://api.github.com/users/agbilotia1998/gists{/gist_id}","starred_url":"https://api.github.com/users/agbilotia1998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbilotia1998/subscriptions","organizations_url":"https://api.github.com/users/agbilotia1998/orgs","repos_url":"https://api.github.com/users/agbilotia1998/repos","events_url":"https://api.github.com/users/agbilotia1998/events{/privacy}","received_events_url":"https://api.github.com/users/agbilotia1998/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-08-19T19:55:14Z","updated_at":"2017-08-20T07:50:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1451","html_url":"https://github.com/fossasia/open-event-webapp/pull/1451","diff_url":"https://github.com/fossasia/open-event-webapp/pull/1451.diff","patch_url":"https://github.com/fossasia/open-event-webapp/pull/1451.patch"},"body":"Fixes #1450 \r\n\r\nChanges: Added if statement in generator.js for correctly displaying the logs.\r\n\r\nScreenshots for the change: \r\n![screenshot from 2017-08-20 01-24-56](https://user-images.githubusercontent.com/21157929/29489783-6493bade-8546-11e7-9dce-d4fba20df237.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/comments/323569780","html_url":"https://github.com/fossasia/open-event-webapp/pull/1451#issuecomment-323569780","issue_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1451","id":323569780,"user":{"login":"Princu7","id":8847265,"avatar_url":"https://avatars3.githubusercontent.com/u/8847265?v=4","gravatar_id":"","url":"https://api.github.com/users/Princu7","html_url":"https://github.com/Princu7","followers_url":"https://api.github.com/users/Princu7/followers","following_url":"https://api.github.com/users/Princu7/following{/other_user}","gists_url":"https://api.github.com/users/Princu7/gists{/gist_id}","starred_url":"https://api.github.com/users/Princu7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Princu7/subscriptions","organizations_url":"https://api.github.com/users/Princu7/orgs","repos_url":"https://api.github.com/users/Princu7/repos","events_url":"https://api.github.com/users/Princu7/events{/privacy}","received_events_url":"https://api.github.com/users/Princu7/received_events","type":"User","site_admin":false},"created_at":"2017-08-20T07:50:32Z","updated_at":"2017-08-20T07:50:32Z","body":"Thanks for the PR :grinning: Good work!\r\nWhile we are at it, there are some more things to consider here. This is the workflow\r\n* We generate the event folder and then upload to the cloud storage and get the URL of the uploaded folder.\r\n* We then mail the user about the generated event which also contains a link to the uploaded event folder.\r\n\r\nThe question is what should we do when the upload to the cloud upload fails? Directly sending the mail to the user does not make sense since the download location of the uploaded event folder will be null.\r\n\r\nSo, we have two options maybe:-\r\n\r\n* Don't send a mail to the user if the cloud upload fails.\r\n* Send a different email telling that the cloud upload has failed and present the user the download link of the event folder currently present on the Heroku app itself along with the warning that it will expire within few hours.\r\n\r\nThoughts @aayusharora @geekyd @sumedh123 @harshitagupta30 I also think that it might be out of the scope of this issue so we can open a new issue for it I guess."}}
{"actor":{"display_login":"Princu7"}}