{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments/156214397","pull_request_review_id":82649845,"id":156214397,"diff_hunk":"@@ -100,40 +101,40 @@ public String getErrorPropertyPath(String property) {\n         return \"ErrorResponse/Error/\" + property;\n     }\n \n-    public AmazonServiceException standardErrorPathException(String errorCode, Node in, XPath xpath) throws Exception {\n+    public SdkServiceException standardErrorPathException(String errorCode, Node in, XPath xpath) throws Exception {\n \n         String errorType = asString(\"ErrorResponse/Error/Type\", in, xpath);\n         String requestId = asString(\"ErrorResponse/RequestId\", in, xpath);\n         String message = asString(\"ErrorResponse/Error/Message\", in, xpath);\n \n-        AmazonServiceException ase = newException(message);\n-        ase.setErrorCode(errorCode);\n-        ase.setRequestId(requestId);\n+        SdkServiceException exception = newException(message);\n+        exception.errorCode(errorCode);\n+        exception.requestId(requestId);\n \n-        if (errorType == null) {\n-            ase.setErrorType(AmazonServiceException.ErrorType.Unknown);\n-        } else if (errorType.equalsIgnoreCase(\"Receiver\")) {\n-            ase.setErrorType(AmazonServiceException.ErrorType.Service);\n-        } else if (errorType.equalsIgnoreCase(\"Sender\")) {\n-            ase.setErrorType(AmazonServiceException.ErrorType.Client);\n+        if (\"Receiver\".equals(errorType)) {","path":"core/src/main/java/software/amazon/awssdk/core/runtime/transform/StandardErrorUnmarshaller.java","position":74,"original_position":74,"commit_id":"bd6510d7954779b4ee14b6dad6181113c6d8d759","original_commit_id":"bd6510d7954779b4ee14b6dad6181113c6d8d759","user":{"login":"varunnvs92","id":17261531,"avatar_url":"https://avatars0.githubusercontent.com/u/17261531?v=4","gravatar_id":"","url":"https://api.github.com/users/varunnvs92","html_url":"https://github.com/varunnvs92","followers_url":"https://api.github.com/users/varunnvs92/followers","following_url":"https://api.github.com/users/varunnvs92/following{/other_user}","gists_url":"https://api.github.com/users/varunnvs92/gists{/gist_id}","starred_url":"https://api.github.com/users/varunnvs92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varunnvs92/subscriptions","organizations_url":"https://api.github.com/users/varunnvs92/orgs","repos_url":"https://api.github.com/users/varunnvs92/repos","events_url":"https://api.github.com/users/varunnvs92/events{/privacy}","received_events_url":"https://api.github.com/users/varunnvs92/received_events","type":"User","site_admin":false},"body":"where do the values \"Receiver\" and \"Sender\"? Also document it","created_at":"2017-12-11T22:09:08Z","updated_at":"2017-12-11T22:18:13Z","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/301#discussion_r156214397","pull_request_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments/156214397"},"html":{"href":"https://github.com/aws/aws-sdk-java-v2/pull/301#discussion_r156214397"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301","id":154222263,"html_url":"https://github.com/aws/aws-sdk-java-v2/pull/301","diff_url":"https://github.com/aws/aws-sdk-java-v2/pull/301.diff","patch_url":"https://github.com/aws/aws-sdk-java-v2/pull/301.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/301","number":301,"state":"open","locked":false,"title":"Updating SDK exceptions","user":{"login":"spfink","id":20525381,"avatar_url":"https://avatars1.githubusercontent.com/u/20525381?v=4","gravatar_id":"","url":"https://api.github.com/users/spfink","html_url":"https://github.com/spfink","followers_url":"https://api.github.com/users/spfink/followers","following_url":"https://api.github.com/users/spfink/following{/other_user}","gists_url":"https://api.github.com/users/spfink/gists{/gist_id}","starred_url":"https://api.github.com/users/spfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spfink/subscriptions","organizations_url":"https://api.github.com/users/spfink/orgs","repos_url":"https://api.github.com/users/spfink/repos","events_url":"https://api.github.com/users/spfink/events{/privacy}","received_events_url":"https://api.github.com/users/spfink/received_events","type":"User","site_admin":false},"body":"Updates the exceptions used by the SDK. Lots of files here but mostly just updating to use the new exceptions. Part 1 of additional changes around exceptions.\r\n\r\n## Description\r\nRemoves AmazonClientException, AmazonServiceException, and SdkBaseException.\r\n\r\nAdds SdkClientException, SdkServiceException and SdkException.\r\n\r\nSdkClientException extends SdkException\r\nSdkServiceException extends SdkException\r\n\r\nSdkException has a retryable() method that will allow generated exceptions to override and set this value.\r\n\r\nAlso adds NonRetryableException and RetryableException which are meant to be used by customers to explicitly mark exceptions in interceptors or lambdas.\r\n\r\n## Testing\r\nAll unit tests pass and have been updated as needed.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist\r\n- [X] I have read the **CONTRIBUTING** document\r\n- [X] Local run of `mvn install` succeeds\r\n- [X] My code follows the code style of this project\r\n- [X] My change requires a change to the Javadoc documentation\r\n- [X] I have updated the Javadoc documentation accordingly\r\n- [X] I have read the **README** document\r\n- [X] I have added tests to cover my changes\r\n- [X] All new and existing tests passed\r\n- [ ] A short description of the change has been added to the **CHANGELOG**\r\n\r\n## License\r\n<!--- The SDK is released under the Apache 2.0 license (http://aws.amazon.com/apache2.0/), so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a Contributor License Agreement (http://en.wikipedia.org/wiki/Contributor_License_Agreement) -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [X] I confirm that this pull request can be released under the Apache 2 license\r\n","created_at":"2017-11-22T18:03:15Z","updated_at":"2017-12-11T22:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2343e817bb1b9b7851dc301d5931baf53971949","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/301/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/bd6510d7954779b4ee14b6dad6181113c6d8d759","head":{"label":"aws:finks/exceptions","ref":"finks/exceptions","sha":"bd6510d7954779b4ee14b6dad6181113c6d8d759","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":95247959,"name":"aws-sdk-java-v2","full_name":"aws/aws-sdk-java-v2","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-java-v2","description":"The official AWS SDK for Java - Version 2 (Developer Preview)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-java-v2","forks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/deployments","created_at":"2017-06-23T18:56:01Z","updated_at":"2017-12-11T08:19:45Z","pushed_at":"2017-12-11T22:01:30Z","git_url":"git://github.com/aws/aws-sdk-java-v2.git","ssh_url":"git@github.com:aws/aws-sdk-java-v2.git","clone_url":"https://github.com/aws/aws-sdk-java-v2.git","svn_url":"https://github.com/aws/aws-sdk-java-v2","homepage":"","size":8354,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":100,"watchers":127,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"b3ad669b4e54a616bd8d3cb2d3172b4e95124368","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":95247959,"name":"aws-sdk-java-v2","full_name":"aws/aws-sdk-java-v2","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-java-v2","description":"The official AWS SDK for Java - Version 2 (Developer Preview)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-java-v2","forks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/deployments","created_at":"2017-06-23T18:56:01Z","updated_at":"2017-12-11T08:19:45Z","pushed_at":"2017-12-11T22:01:30Z","git_url":"git://github.com/aws/aws-sdk-java-v2.git","ssh_url":"git@github.com:aws/aws-sdk-java-v2.git","clone_url":"https://github.com/aws/aws-sdk-java-v2.git","svn_url":"https://github.com/aws/aws-sdk-java-v2","homepage":"","size":8354,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":100,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301"},"html":{"href":"https://github.com/aws/aws-sdk-java-v2/pull/301"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/301"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/bd6510d7954779b4ee14b6dad6181113c6d8d759"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"varunnvs92"}}