{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/11632","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/11632/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/11632/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/11632/events","html_url":"https://github.com/facebook/react-native/pull/11632","id":197619410,"number":11632,"title":"Fix Step 3 in section - Debugging with Stetho on Android","user":{"login":"pavansin","id":1500434,"avatar_url":"https://avatars.githubusercontent.com/u/1500434?v=3","gravatar_id":"","url":"https://api.github.com/users/pavansin","html_url":"https://github.com/pavansin","followers_url":"https://api.github.com/users/pavansin/followers","following_url":"https://api.github.com/users/pavansin/following{/other_user}","gists_url":"https://api.github.com/users/pavansin/gists{/gist_id}","starred_url":"https://api.github.com/users/pavansin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavansin/subscriptions","organizations_url":"https://api.github.com/users/pavansin/orgs","repos_url":"https://api.github.com/users/pavansin/repos","events_url":"https://api.github.com/users/pavansin/events{/privacy}","received_events_url":"https://api.github.com/users/pavansin/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-26T20:59:00Z","updated_at":"2017-02-08T23:10:04Z","closed_at":"2017-02-08T23:10:04Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/11632","html_url":"https://github.com/facebook/react-native/pull/11632","diff_url":"https://github.com/facebook/react-native/pull/11632.diff","patch_url":"https://github.com/facebook/react-native/pull/11632.patch"},"body":"The change should be made in MainActivity.java and not MainApplication.java.\r\n\r\nThanks for submitting a pull request! Please provide enough information so that others can review your pull request:\r\n\r\n> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**\r\n\r\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\r\n\r\nPrefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\r\n\r\n**Test plan (required)**\r\n\r\nDemonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.\r\n\r\nMake sure tests pass on both Travis and Circle CI.\r\n\r\n**Code formatting**\r\n\r\nLook around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).\r\n\r\nFor more info, see the [\"Pull Requests\" section of our \"Contributing\" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests).\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/278492979","html_url":"https://github.com/facebook/react-native/pull/11632#issuecomment-278492979","issue_url":"https://api.github.com/repos/facebook/react-native/issues/11632","id":278492979,"user":{"login":"lacker","id":106475,"avatar_url":"https://avatars.githubusercontent.com/u/106475?v=3","gravatar_id":"","url":"https://api.github.com/users/lacker","html_url":"https://github.com/lacker","followers_url":"https://api.github.com/users/lacker/followers","following_url":"https://api.github.com/users/lacker/following{/other_user}","gists_url":"https://api.github.com/users/lacker/gists{/gist_id}","starred_url":"https://api.github.com/users/lacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacker/subscriptions","organizations_url":"https://api.github.com/users/lacker/orgs","repos_url":"https://api.github.com/users/lacker/repos","events_url":"https://api.github.com/users/lacker/events{/privacy}","received_events_url":"https://api.github.com/users/lacker/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T23:10:04Z","updated_at":"2017-02-08T23:10:04Z","body":"I don't think that is correct. In general Stetho supports initialization in the Application object so it seems like we should encourage people to do that same thing in React Native. See http://facebook.github.io/stetho/ for details. I am going to close this pull request but if I am wrong here please feel free to let me know!"}}
{"actor":{"display_login":"lacker"}}