{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/comments/98607835","pull_request_review_id":19252820,"id":98607835,"diff_hunk":"@@ -9,6 +9,9 @@ const debug_memory = false # Set this to true to debug gc of nodes\n \n const nodes = WeakKeyDict()\n const io_lock = ReentrantLock()\n+const node_count = Ref(1) #1 since auto_name gets called before count is incremented\n+\n+auto_name() = string(node_count[])","path":"src/core.jl","position":6,"original_position":6,"commit_id":"9ed503e94dd8ef9a250b90d1ce6c5488c897e68c","original_commit_id":"9ed503e94dd8ef9a250b90d1ce6c5488c897e68c","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?v=3","gravatar_id":"","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"body":"maybe `string(\"signal-\", node_count[])`?","created_at":"2017-01-31T06:57:28Z","updated_at":"2017-01-31T07:03:02Z","html_url":"https://github.com/JuliaGizmos/Reactive.jl/pull/121#discussion_r98607835","pull_request_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/comments/98607835"},"html":{"href":"https://github.com/JuliaGizmos/Reactive.jl/pull/121#discussion_r98607835"},"pull_request":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121","id":103878891,"html_url":"https://github.com/JuliaGizmos/Reactive.jl/pull/121","diff_url":"https://github.com/JuliaGizmos/Reactive.jl/pull/121.diff","patch_url":"https://github.com/JuliaGizmos/Reactive.jl/pull/121.patch","issue_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/121","number":121,"state":"open","locked":false,"title":"Allows naming signals","user":{"login":"JobJob","id":854183,"avatar_url":"https://avatars.githubusercontent.com/u/854183?v=3","gravatar_id":"","url":"https://api.github.com/users/JobJob","html_url":"https://github.com/JobJob","followers_url":"https://api.github.com/users/JobJob/followers","following_url":"https://api.github.com/users/JobJob/following{/other_user}","gists_url":"https://api.github.com/users/JobJob/gists{/gist_id}","starred_url":"https://api.github.com/users/JobJob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JobJob/subscriptions","organizations_url":"https://api.github.com/users/JobJob/orgs","repos_url":"https://api.github.com/users/JobJob/repos","events_url":"https://api.github.com/users/JobJob/events{/privacy}","received_events_url":"https://api.github.com/users/JobJob/received_events","type":"User","site_admin":false},"body":"Useful for debugging and could be used for visualising signal graphs\r\nThey will get an auto-incremented node-number as their name if none is provided.\r\n\r\nAside: I'm a little busy right now so if you want to make changes yourself that would be so lovely :D","created_at":"2017-01-31T06:28:11Z","updated_at":"2017-01-31T07:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d52c568a583c4ec32cb86b00d360ecad2f705d7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121/commits","review_comments_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121/comments","review_comment_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/121/comments","statuses_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/statuses/9ed503e94dd8ef9a250b90d1ce6c5488c897e68c","head":{"label":"JobJob:named_signals","ref":"named_signals","sha":"9ed503e94dd8ef9a250b90d1ce6c5488c897e68c","user":{"login":"JobJob","id":854183,"avatar_url":"https://avatars.githubusercontent.com/u/854183?v=3","gravatar_id":"","url":"https://api.github.com/users/JobJob","html_url":"https://github.com/JobJob","followers_url":"https://api.github.com/users/JobJob/followers","following_url":"https://api.github.com/users/JobJob/following{/other_user}","gists_url":"https://api.github.com/users/JobJob/gists{/gist_id}","starred_url":"https://api.github.com/users/JobJob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JobJob/subscriptions","organizations_url":"https://api.github.com/users/JobJob/orgs","repos_url":"https://api.github.com/users/JobJob/repos","events_url":"https://api.github.com/users/JobJob/events{/privacy}","received_events_url":"https://api.github.com/users/JobJob/received_events","type":"User","site_admin":false},"repo":{"id":72756307,"name":"Reactive.jl","full_name":"JobJob/Reactive.jl","owner":{"login":"JobJob","id":854183,"avatar_url":"https://avatars.githubusercontent.com/u/854183?v=3","gravatar_id":"","url":"https://api.github.com/users/JobJob","html_url":"https://github.com/JobJob","followers_url":"https://api.github.com/users/JobJob/followers","following_url":"https://api.github.com/users/JobJob/following{/other_user}","gists_url":"https://api.github.com/users/JobJob/gists{/gist_id}","starred_url":"https://api.github.com/users/JobJob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JobJob/subscriptions","organizations_url":"https://api.github.com/users/JobJob/orgs","repos_url":"https://api.github.com/users/JobJob/repos","events_url":"https://api.github.com/users/JobJob/events{/privacy}","received_events_url":"https://api.github.com/users/JobJob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JobJob/Reactive.jl","description":"Reactive programming primitives for Julia","fork":true,"url":"https://api.github.com/repos/JobJob/Reactive.jl","forks_url":"https://api.github.com/repos/JobJob/Reactive.jl/forks","keys_url":"https://api.github.com/repos/JobJob/Reactive.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JobJob/Reactive.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JobJob/Reactive.jl/teams","hooks_url":"https://api.github.com/repos/JobJob/Reactive.jl/hooks","issue_events_url":"https://api.github.com/repos/JobJob/Reactive.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JobJob/Reactive.jl/events","assignees_url":"https://api.github.com/repos/JobJob/Reactive.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JobJob/Reactive.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JobJob/Reactive.jl/tags","blobs_url":"https://api.github.com/repos/JobJob/Reactive.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JobJob/Reactive.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JobJob/Reactive.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JobJob/Reactive.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JobJob/Reactive.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JobJob/Reactive.jl/languages","stargazers_url":"https://api.github.com/repos/JobJob/Reactive.jl/stargazers","contributors_url":"https://api.github.com/repos/JobJob/Reactive.jl/contributors","subscribers_url":"https://api.github.com/repos/JobJob/Reactive.jl/subscribers","subscription_url":"https://api.github.com/repos/JobJob/Reactive.jl/subscription","commits_url":"https://api.github.com/repos/JobJob/Reactive.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JobJob/Reactive.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JobJob/Reactive.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JobJob/Reactive.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JobJob/Reactive.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JobJob/Reactive.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JobJob/Reactive.jl/merges","archive_url":"https://api.github.com/repos/JobJob/Reactive.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JobJob/Reactive.jl/downloads","issues_url":"https://api.github.com/repos/JobJob/Reactive.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JobJob/Reactive.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JobJob/Reactive.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JobJob/Reactive.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JobJob/Reactive.jl/labels{/name}","releases_url":"https://api.github.com/repos/JobJob/Reactive.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JobJob/Reactive.jl/deployments","created_at":"2016-11-03T14:56:10Z","updated_at":"2016-11-03T14:56:10Z","pushed_at":"2017-01-31T06:56:31Z","git_url":"git://github.com/JobJob/Reactive.jl.git","ssh_url":"git@github.com:JobJob/Reactive.jl.git","clone_url":"https://github.com/JobJob/Reactive.jl.git","svn_url":"https://github.com/JobJob/Reactive.jl","homepage":"http://julialang.github.io/Reactive.jl/","size":394,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaGizmos:master","ref":"master","sha":"1b4e2c050ffa65238a6082117a99732d7a437ea0","user":{"login":"JuliaGizmos","id":24488080,"avatar_url":"https://avatars.githubusercontent.com/u/24488080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGizmos","html_url":"https://github.com/JuliaGizmos","followers_url":"https://api.github.com/users/JuliaGizmos/followers","following_url":"https://api.github.com/users/JuliaGizmos/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGizmos/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGizmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGizmos/subscriptions","organizations_url":"https://api.github.com/users/JuliaGizmos/orgs","repos_url":"https://api.github.com/users/JuliaGizmos/repos","events_url":"https://api.github.com/users/JuliaGizmos/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGizmos/received_events","type":"Organization","site_admin":false},"repo":{"id":20048467,"name":"Reactive.jl","full_name":"JuliaGizmos/Reactive.jl","owner":{"login":"JuliaGizmos","id":24488080,"avatar_url":"https://avatars.githubusercontent.com/u/24488080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGizmos","html_url":"https://github.com/JuliaGizmos","followers_url":"https://api.github.com/users/JuliaGizmos/followers","following_url":"https://api.github.com/users/JuliaGizmos/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGizmos/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGizmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGizmos/subscriptions","organizations_url":"https://api.github.com/users/JuliaGizmos/orgs","repos_url":"https://api.github.com/users/JuliaGizmos/repos","events_url":"https://api.github.com/users/JuliaGizmos/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGizmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGizmos/Reactive.jl","description":"Reactive programming primitives for Julia","fork":false,"url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl","forks_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/forks","keys_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/events","assignees_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/merges","archive_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/deployments","created_at":"2014-05-22T05:00:10Z","updated_at":"2017-01-30T07:14:43Z","pushed_at":"2017-01-31T06:56:32Z","git_url":"git://github.com/JuliaGizmos/Reactive.jl.git","ssh_url":"git@github.com:JuliaGizmos/Reactive.jl.git","clone_url":"https://github.com/JuliaGizmos/Reactive.jl.git","svn_url":"https://github.com/JuliaGizmos/Reactive.jl","homepage":"http://juliagizmos.github.io/Reactive.jl/","size":379,"stargazers_count":99,"watchers_count":99,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":17,"forks":32,"open_issues":17,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121"},"html":{"href":"https://github.com/JuliaGizmos/Reactive.jl/pull/121"},"issue":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/121"},"comments":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGizmos/Reactive.jl/statuses/9ed503e94dd8ef9a250b90d1ce6c5488c897e68c"}}}}
{"actor":{"display_login":"shashi"}}