{"action":"opened","number":59,"pull_request":{"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59","id":112593911,"html_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/59","diff_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/59.diff","patch_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/59.patch","issue_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/59","number":59,"state":"open","locked":false,"title":"feature flag `logging`","user":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars0.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"body":"- put logging behind a feature flag to improve compile time,\r\n  since we have unit tests, this is far less important than before.\r\n\r\n**Open Question**: I wonder how I should adapt the [travis configuration](https://github.com/colin-kiegel/rust-derive-builder/blob/feature/logging_optional/.travis.yml#L53-L55) to test for features.\r\n- Would it be sufficient to just test `--features \"compiletests logging\"` on nightly?\r\n- Or should I have one run with default features, and one with full features (except dev_nightly) on each rust release?\r\n\r\ncc @killercup in case you want to give feedback. :-)","created_at":"2017-03-25T17:06:02Z","updated_at":"2017-03-25T17:06:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59/commits","review_comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59/comments","review_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/59/comments","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/eb8b974faf3b9ddec900bd9dc2e4a648d1f2097e","head":{"label":"colin-kiegel:feature/logging_optional","ref":"feature/logging_optional","sha":"eb8b974faf3b9ddec900bd9dc2e4a648d1f2097e","user":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars0.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"repo":{"id":65087808,"name":"rust-derive-builder","full_name":"colin-kiegel/rust-derive-builder","owner":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars0.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colin-kiegel/rust-derive-builder","description":"derive builder implementation for rust structs","fork":false,"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder","forks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/deployments","created_at":"2016-08-06T15:03:46Z","updated_at":"2017-03-22T06:32:16Z","pushed_at":"2017-03-25T17:01:47Z","git_url":"git://github.com/colin-kiegel/rust-derive-builder.git","ssh_url":"git@github.com:colin-kiegel/rust-derive-builder.git","clone_url":"https://github.com/colin-kiegel/rust-derive-builder.git","svn_url":"https://github.com/colin-kiegel/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":737,"stargazers_count":100,"watchers_count":100,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":17,"forks":8,"open_issues":17,"watchers":100,"default_branch":"master"}},"base":{"label":"colin-kiegel:master","ref":"master","sha":"3cc98dd6102780482d746372983cb115da2c0475","user":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars0.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"repo":{"id":65087808,"name":"rust-derive-builder","full_name":"colin-kiegel/rust-derive-builder","owner":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars0.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colin-kiegel/rust-derive-builder","description":"derive builder implementation for rust structs","fork":false,"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder","forks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/deployments","created_at":"2016-08-06T15:03:46Z","updated_at":"2017-03-22T06:32:16Z","pushed_at":"2017-03-25T17:01:47Z","git_url":"git://github.com/colin-kiegel/rust-derive-builder.git","ssh_url":"git@github.com:colin-kiegel/rust-derive-builder.git","clone_url":"https://github.com/colin-kiegel/rust-derive-builder.git","svn_url":"https://github.com/colin-kiegel/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":737,"stargazers_count":100,"watchers_count":100,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":17,"forks":8,"open_issues":17,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59"},"html":{"href":"https://github.com/colin-kiegel/rust-derive-builder/pull/59"},"issue":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/59"},"comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/eb8b974faf3b9ddec900bd9dc2e4a648d1f2097e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":78,"deletions":9,"changed_files":10}}
{"actor":{"display_login":"colin-kiegel"}}