{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/1607","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/1607/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/1607/comments","events_url":"https://api.github.com/repos/istio/istio/issues/1607/events","html_url":"https://github.com/istio/istio/pull/1607","id":272381812,"number":1607,"title":"Add fields to mesh configs to (always) disable mTLS on control services.","user":{"login":"diemtvu","id":25132401,"avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"c2e0c6","default":false},{"id":737750176,"url":"https://api.github.com/repos/istio/istio/labels/pilot","name":"pilot","color":"c11783","default":false},{"id":660558399,"url":"https://api.github.com/repos/istio/istio/labels/release-note-none","name":"release-note-none","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},{"login":"rshriram","id":8202871,"avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2017-11-08T23:03:50Z","updated_at":"2017-11-15T00:52:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1607","html_url":"https://github.com/istio/istio/pull/1607","diff_url":"https://github.com/istio/istio/pull/1607.diff","patch_url":"https://github.com/istio/istio/pull/1607.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nk8s control service (e.g API server) don't have envoy in front, so clients (with envoy) should never use mTLS to talk to them. This PR provides a way to listed those services so that pilot can always skip adding ssl_context to the outbound cluster to those services.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\nhttps://github.com/istio/istio/issues/1232\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis is work-in-progress, to make sure the it go in the right direction. The PR required API changes to add 2 repeated fields to the mesh config to keep the list of services and namespaces that should be blacklisted for auth-enable.\r\n\r\n\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```NONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/344450262","html_url":"https://github.com/istio/istio/pull/1607#issuecomment-344450262","issue_url":"https://api.github.com/repos/istio/istio/issues/1607","id":344450262,"user":{"login":"istio-merge-robot","id":30445278,"avatar_url":"https://avatars2.githubusercontent.com/u/30445278?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-merge-robot","html_url":"https://github.com/istio-merge-robot","followers_url":"https://api.github.com/users/istio-merge-robot/followers","following_url":"https://api.github.com/users/istio-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/istio-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/istio-merge-robot/orgs","repos_url":"https://api.github.com/users/istio-merge-robot/repos","events_url":"https://api.github.com/users/istio-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/istio-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T00:52:38Z","updated_at":"2017-11-15T00:52:38Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/1607#issuecomment-344450119\" title=\"LGTM\">ZackButcher</a>*\nWe suggest the following additional approver: **rshriram**\n\nAssign the PR to them by writing `/assign @rshriram` in a comment when ready.\n\n\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[OWNERS](https://github.com/istio/istio/blob/master/OWNERS)**\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"rshriram\"]} -->"}}
{"actor":{"display_login":"istio-merge-robot"}}