{"action":"created","comment":{"url":"https://api.github.com/repos/I2PC/scipion/pulls/comments/139097454","pull_request_review_id":62984099,"id":139097454,"diff_hunk":"@@ -88,7 +88,8 @@ def readCtfModel(ctfModel, filename, ctf4=False):\n         defocusU, defocusV, defocusAngle, ctfFit, ctfResolution = result\n         ctfModel.setStandardDefocus(defocusU, defocusV, defocusAngle)\n     ctfModel._gctf_crossCorrelation = Float(ctfFit)\n-    ctfModel._gctf_ctfResolution = Float(ctfResolution)\n+#    ctfModel._gctf_ctfResolution = Float(ctfResolution)\n+    ctfModel.setResolution(Float(ctfResolution))","path":"pyworkflow/em/packages/gctf/convert.py","position":6,"original_position":6,"commit_id":"f532e6ff0fc4544d11f8714647f6ef7546599271","original_commit_id":"7247673a35fc587a93109583120de0b7c7694d55","user":{"login":"delarosatrevin","id":8441688,"avatar_url":"https://avatars0.githubusercontent.com/u/8441688?v=4","gravatar_id":"","url":"https://api.github.com/users/delarosatrevin","html_url":"https://github.com/delarosatrevin","followers_url":"https://api.github.com/users/delarosatrevin/followers","following_url":"https://api.github.com/users/delarosatrevin/following{/other_user}","gists_url":"https://api.github.com/users/delarosatrevin/gists{/gist_id}","starred_url":"https://api.github.com/users/delarosatrevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delarosatrevin/subscriptions","organizations_url":"https://api.github.com/users/delarosatrevin/orgs","repos_url":"https://api.github.com/users/delarosatrevin/repos","events_url":"https://api.github.com/users/delarosatrevin/events{/privacy}","received_events_url":"https://api.github.com/users/delarosatrevin/received_events","type":"User","site_admin":false},"body":"Float() is not needed here around ctfResoultion, the value should be properly converted","created_at":"2017-09-15T09:02:28Z","updated_at":"2017-09-15T09:21:28Z","html_url":"https://github.com/I2PC/scipion/pull/1201#discussion_r139097454","pull_request_url":"https://api.github.com/repos/I2PC/scipion/pulls/1201","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/comments/139097454"},"html":{"href":"https://github.com/I2PC/scipion/pull/1201#discussion_r139097454"},"pull_request":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/1201"}}},"pull_request":{"url":"https://api.github.com/repos/I2PC/scipion/pulls/1201","id":141258814,"html_url":"https://github.com/I2PC/scipion/pull/1201","diff_url":"https://github.com/I2PC/scipion/pull/1201.diff","patch_url":"https://github.com/I2PC/scipion/pull/1201.patch","issue_url":"https://api.github.com/repos/I2PC/scipion/issues/1201","number":1201,"state":"open","locked":false,"title":"Rm solved merge v2","user":{"login":"joton","id":8802162,"avatar_url":"https://avatars2.githubusercontent.com/u/8802162?v=4","gravatar_id":"","url":"https://api.github.com/users/joton","html_url":"https://github.com/joton","followers_url":"https://api.github.com/users/joton/followers","following_url":"https://api.github.com/users/joton/following{/other_user}","gists_url":"https://api.github.com/users/joton/gists{/gist_id}","starred_url":"https://api.github.com/users/joton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joton/subscriptions","organizations_url":"https://api.github.com/users/joton/orgs","repos_url":"https://api.github.com/users/joton/repos","events_url":"https://api.github.com/users/joton/events{/privacy}","received_events_url":"https://api.github.com/users/joton/received_events","type":"User","site_admin":false},"body":"add resolution attribute to CTFModel before we were using three different labels depending on the software:\r\n\r\n'_ctffind4_ctfResolution'\r\n'_gctf_ctfResolution'\r\n'_xmipp_ctfCritMaxFreq'\r\n\r\nnow we use just\r\n\r\n_resolution\r\n\r\nNOTE: @joton  is just a victim, the perpetrator is @rmarabini ","created_at":"2017-09-15T08:50:03Z","updated_at":"2017-09-15T09:21:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1a3f33a69398964245731bbfe980ad84eb03d64","assignee":{"login":"josuegbl","id":12274357,"avatar_url":"https://avatars2.githubusercontent.com/u/12274357?v=4","gravatar_id":"","url":"https://api.github.com/users/josuegbl","html_url":"https://github.com/josuegbl","followers_url":"https://api.github.com/users/josuegbl/followers","following_url":"https://api.github.com/users/josuegbl/following{/other_user}","gists_url":"https://api.github.com/users/josuegbl/gists{/gist_id}","starred_url":"https://api.github.com/users/josuegbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josuegbl/subscriptions","organizations_url":"https://api.github.com/users/josuegbl/orgs","repos_url":"https://api.github.com/users/josuegbl/repos","events_url":"https://api.github.com/users/josuegbl/events{/privacy}","received_events_url":"https://api.github.com/users/josuegbl/received_events","type":"User","site_admin":false},"assignees":[{"login":"josuegbl","id":12274357,"avatar_url":"https://avatars2.githubusercontent.com/u/12274357?v=4","gravatar_id":"","url":"https://api.github.com/users/josuegbl","html_url":"https://github.com/josuegbl","followers_url":"https://api.github.com/users/josuegbl/followers","following_url":"https://api.github.com/users/josuegbl/following{/other_user}","gists_url":"https://api.github.com/users/josuegbl/gists{/gist_id}","starred_url":"https://api.github.com/users/josuegbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josuegbl/subscriptions","organizations_url":"https://api.github.com/users/josuegbl/orgs","repos_url":"https://api.github.com/users/josuegbl/repos","events_url":"https://api.github.com/users/josuegbl/events{/privacy}","received_events_url":"https://api.github.com/users/josuegbl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/I2PC/scipion/pulls/1201/commits","review_comments_url":"https://api.github.com/repos/I2PC/scipion/pulls/1201/comments","review_comment_url":"https://api.github.com/repos/I2PC/scipion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/I2PC/scipion/issues/1201/comments","statuses_url":"https://api.github.com/repos/I2PC/scipion/statuses/f532e6ff0fc4544d11f8714647f6ef7546599271","head":{"label":"I2PC:rm-solved-merge_v2","ref":"rm-solved-merge_v2","sha":"f532e6ff0fc4544d11f8714647f6ef7546599271","user":{"login":"I2PC","id":16493564,"avatar_url":"https://avatars0.githubusercontent.com/u/16493564?v=4","gravatar_id":"","url":"https://api.github.com/users/I2PC","html_url":"https://github.com/I2PC","followers_url":"https://api.github.com/users/I2PC/followers","following_url":"https://api.github.com/users/I2PC/following{/other_user}","gists_url":"https://api.github.com/users/I2PC/gists{/gist_id}","starred_url":"https://api.github.com/users/I2PC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/I2PC/subscriptions","organizations_url":"https://api.github.com/users/I2PC/orgs","repos_url":"https://api.github.com/users/I2PC/repos","events_url":"https://api.github.com/users/I2PC/events{/privacy}","received_events_url":"https://api.github.com/users/I2PC/received_events","type":"Organization","site_admin":false},"repo":{"id":35214502,"name":"scipion","full_name":"I2PC/scipion","owner":{"login":"I2PC","id":16493564,"avatar_url":"https://avatars0.githubusercontent.com/u/16493564?v=4","gravatar_id":"","url":"https://api.github.com/users/I2PC","html_url":"https://github.com/I2PC","followers_url":"https://api.github.com/users/I2PC/followers","following_url":"https://api.github.com/users/I2PC/following{/other_user}","gists_url":"https://api.github.com/users/I2PC/gists{/gist_id}","starred_url":"https://api.github.com/users/I2PC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/I2PC/subscriptions","organizations_url":"https://api.github.com/users/I2PC/orgs","repos_url":"https://api.github.com/users/I2PC/repos","events_url":"https://api.github.com/users/I2PC/events{/privacy}","received_events_url":"https://api.github.com/users/I2PC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/I2PC/scipion","description":"Scipion is an image processing framework to obtain 3D models of macromolecular complexes using Electron Microscopy (3DEM)","fork":false,"url":"https://api.github.com/repos/I2PC/scipion","forks_url":"https://api.github.com/repos/I2PC/scipion/forks","keys_url":"https://api.github.com/repos/I2PC/scipion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/I2PC/scipion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/I2PC/scipion/teams","hooks_url":"https://api.github.com/repos/I2PC/scipion/hooks","issue_events_url":"https://api.github.com/repos/I2PC/scipion/issues/events{/number}","events_url":"https://api.github.com/repos/I2PC/scipion/events","assignees_url":"https://api.github.com/repos/I2PC/scipion/assignees{/user}","branches_url":"https://api.github.com/repos/I2PC/scipion/branches{/branch}","tags_url":"https://api.github.com/repos/I2PC/scipion/tags","blobs_url":"https://api.github.com/repos/I2PC/scipion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/I2PC/scipion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/I2PC/scipion/git/refs{/sha}","trees_url":"https://api.github.com/repos/I2PC/scipion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/I2PC/scipion/statuses/{sha}","languages_url":"https://api.github.com/repos/I2PC/scipion/languages","stargazers_url":"https://api.github.com/repos/I2PC/scipion/stargazers","contributors_url":"https://api.github.com/repos/I2PC/scipion/contributors","subscribers_url":"https://api.github.com/repos/I2PC/scipion/subscribers","subscription_url":"https://api.github.com/repos/I2PC/scipion/subscription","commits_url":"https://api.github.com/repos/I2PC/scipion/commits{/sha}","git_commits_url":"https://api.github.com/repos/I2PC/scipion/git/commits{/sha}","comments_url":"https://api.github.com/repos/I2PC/scipion/comments{/number}","issue_comment_url":"https://api.github.com/repos/I2PC/scipion/issues/comments{/number}","contents_url":"https://api.github.com/repos/I2PC/scipion/contents/{+path}","compare_url":"https://api.github.com/repos/I2PC/scipion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/I2PC/scipion/merges","archive_url":"https://api.github.com/repos/I2PC/scipion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/I2PC/scipion/downloads","issues_url":"https://api.github.com/repos/I2PC/scipion/issues{/number}","pulls_url":"https://api.github.com/repos/I2PC/scipion/pulls{/number}","milestones_url":"https://api.github.com/repos/I2PC/scipion/milestones{/number}","notifications_url":"https://api.github.com/repos/I2PC/scipion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/I2PC/scipion/labels{/name}","releases_url":"https://api.github.com/repos/I2PC/scipion/releases{/id}","deployments_url":"https://api.github.com/repos/I2PC/scipion/deployments","created_at":"2015-05-07T10:44:31Z","updated_at":"2017-08-09T06:58:41Z","pushed_at":"2017-09-15T09:03:27Z","git_url":"git://github.com/I2PC/scipion.git","ssh_url":"git@github.com:I2PC/scipion.git","clone_url":"https://github.com/I2PC/scipion.git","svn_url":"https://github.com/I2PC/scipion","homepage":"http://scipion.cnb.csic.es","size":114774,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":218,"forks":20,"open_issues":218,"watchers":24,"default_branch":"master"}},"base":{"label":"I2PC:release-1.1.facilities-devel","ref":"release-1.1.facilities-devel","sha":"1eb2bc2770351bb24386f17b012fd573488e233b","user":{"login":"I2PC","id":16493564,"avatar_url":"https://avatars0.githubusercontent.com/u/16493564?v=4","gravatar_id":"","url":"https://api.github.com/users/I2PC","html_url":"https://github.com/I2PC","followers_url":"https://api.github.com/users/I2PC/followers","following_url":"https://api.github.com/users/I2PC/following{/other_user}","gists_url":"https://api.github.com/users/I2PC/gists{/gist_id}","starred_url":"https://api.github.com/users/I2PC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/I2PC/subscriptions","organizations_url":"https://api.github.com/users/I2PC/orgs","repos_url":"https://api.github.com/users/I2PC/repos","events_url":"https://api.github.com/users/I2PC/events{/privacy}","received_events_url":"https://api.github.com/users/I2PC/received_events","type":"Organization","site_admin":false},"repo":{"id":35214502,"name":"scipion","full_name":"I2PC/scipion","owner":{"login":"I2PC","id":16493564,"avatar_url":"https://avatars0.githubusercontent.com/u/16493564?v=4","gravatar_id":"","url":"https://api.github.com/users/I2PC","html_url":"https://github.com/I2PC","followers_url":"https://api.github.com/users/I2PC/followers","following_url":"https://api.github.com/users/I2PC/following{/other_user}","gists_url":"https://api.github.com/users/I2PC/gists{/gist_id}","starred_url":"https://api.github.com/users/I2PC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/I2PC/subscriptions","organizations_url":"https://api.github.com/users/I2PC/orgs","repos_url":"https://api.github.com/users/I2PC/repos","events_url":"https://api.github.com/users/I2PC/events{/privacy}","received_events_url":"https://api.github.com/users/I2PC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/I2PC/scipion","description":"Scipion is an image processing framework to obtain 3D models of macromolecular complexes using Electron Microscopy (3DEM)","fork":false,"url":"https://api.github.com/repos/I2PC/scipion","forks_url":"https://api.github.com/repos/I2PC/scipion/forks","keys_url":"https://api.github.com/repos/I2PC/scipion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/I2PC/scipion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/I2PC/scipion/teams","hooks_url":"https://api.github.com/repos/I2PC/scipion/hooks","issue_events_url":"https://api.github.com/repos/I2PC/scipion/issues/events{/number}","events_url":"https://api.github.com/repos/I2PC/scipion/events","assignees_url":"https://api.github.com/repos/I2PC/scipion/assignees{/user}","branches_url":"https://api.github.com/repos/I2PC/scipion/branches{/branch}","tags_url":"https://api.github.com/repos/I2PC/scipion/tags","blobs_url":"https://api.github.com/repos/I2PC/scipion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/I2PC/scipion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/I2PC/scipion/git/refs{/sha}","trees_url":"https://api.github.com/repos/I2PC/scipion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/I2PC/scipion/statuses/{sha}","languages_url":"https://api.github.com/repos/I2PC/scipion/languages","stargazers_url":"https://api.github.com/repos/I2PC/scipion/stargazers","contributors_url":"https://api.github.com/repos/I2PC/scipion/contributors","subscribers_url":"https://api.github.com/repos/I2PC/scipion/subscribers","subscription_url":"https://api.github.com/repos/I2PC/scipion/subscription","commits_url":"https://api.github.com/repos/I2PC/scipion/commits{/sha}","git_commits_url":"https://api.github.com/repos/I2PC/scipion/git/commits{/sha}","comments_url":"https://api.github.com/repos/I2PC/scipion/comments{/number}","issue_comment_url":"https://api.github.com/repos/I2PC/scipion/issues/comments{/number}","contents_url":"https://api.github.com/repos/I2PC/scipion/contents/{+path}","compare_url":"https://api.github.com/repos/I2PC/scipion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/I2PC/scipion/merges","archive_url":"https://api.github.com/repos/I2PC/scipion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/I2PC/scipion/downloads","issues_url":"https://api.github.com/repos/I2PC/scipion/issues{/number}","pulls_url":"https://api.github.com/repos/I2PC/scipion/pulls{/number}","milestones_url":"https://api.github.com/repos/I2PC/scipion/milestones{/number}","notifications_url":"https://api.github.com/repos/I2PC/scipion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/I2PC/scipion/labels{/name}","releases_url":"https://api.github.com/repos/I2PC/scipion/releases{/id}","deployments_url":"https://api.github.com/repos/I2PC/scipion/deployments","created_at":"2015-05-07T10:44:31Z","updated_at":"2017-08-09T06:58:41Z","pushed_at":"2017-09-15T09:03:27Z","git_url":"git://github.com/I2PC/scipion.git","ssh_url":"git@github.com:I2PC/scipion.git","clone_url":"https://github.com/I2PC/scipion.git","svn_url":"https://github.com/I2PC/scipion","homepage":"http://scipion.cnb.csic.es","size":114774,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":218,"forks":20,"open_issues":218,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/1201"},"html":{"href":"https://github.com/I2PC/scipion/pull/1201"},"issue":{"href":"https://api.github.com/repos/I2PC/scipion/issues/1201"},"comments":{"href":"https://api.github.com/repos/I2PC/scipion/issues/1201/comments"},"review_comments":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/1201/comments"},"review_comment":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/I2PC/scipion/pulls/1201/commits"},"statuses":{"href":"https://api.github.com/repos/I2PC/scipion/statuses/f532e6ff0fc4544d11f8714647f6ef7546599271"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"delarosatrevin"}}