{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/liota/pulls/comments/152900075","pull_request_review_id":78832718,"id":152900075,"diff_hunk":"@@ -1140,13 +1162,20 @@ def _package_delete(self, file_name):\n     def _terminate_all(self):\n         global package_messenger_thread\n         global package_messenger_pipe\n+        global package_responser_pipe\n \n         log.info(\"Shutting down package messenger...\")\n         if package_messenger_thread.isAlive():\n             with open(package_messenger_pipe, \"w\") as fp:\n                 fp.write(\n                     \"terminate_messenger_but_you_should_not_do_this_yourself\\n\")\n \n+        log.info(\"Shutting down package responser...\")\n+        if package_messenger_thread.isAlive():\n+            with open(package_responser_pipe, \"w\") as fp:\n+                fp.write(\n+                    \"terminate_responser_but_you_should_not_do_this_yourself\\n\")","path":"liota/core/package_manager.py","position":null,"original_position":90,"commit_id":"34ff337be27fc2b1d7aea745462140ff078f51d6","original_commit_id":"e7137b954ee638e674490f1ae9b21a88255b6b20","user":{"login":"winniex1","id":17712390,"avatar_url":"https://avatars2.githubusercontent.com/u/17712390?v=4","gravatar_id":"","url":"https://api.github.com/users/winniex1","html_url":"https://github.com/winniex1","followers_url":"https://api.github.com/users/winniex1/followers","following_url":"https://api.github.com/users/winniex1/following{/other_user}","gists_url":"https://api.github.com/users/winniex1/gists{/gist_id}","starred_url":"https://api.github.com/users/winniex1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniex1/subscriptions","organizations_url":"https://api.github.com/users/winniex1/orgs","repos_url":"https://api.github.com/users/winniex1/repos","events_url":"https://api.github.com/users/winniex1/events{/privacy}","received_events_url":"https://api.github.com/users/winniex1/received_events","type":"User","site_admin":false},"body":"Thought this over again and feel it is not necessary, so removed it.\r\nThe previous purpose is that when execute a \"terminate\" cmd, notify the user that package thread is executing it. But since we will pass \"Success\" back, no need to do this.","created_at":"2017-11-24T05:35:37Z","updated_at":"2017-11-24T05:35:37Z","html_url":"https://github.com/vmware/liota/pull/191#discussion_r152900075","pull_request_url":"https://api.github.com/repos/vmware/liota/pulls/191","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/liota/pulls/comments/152900075"},"html":{"href":"https://github.com/vmware/liota/pull/191#discussion_r152900075"},"pull_request":{"href":"https://api.github.com/repos/vmware/liota/pulls/191"}},"in_reply_to_id":152857486},"pull_request":{"url":"https://api.github.com/repos/vmware/liota/pulls/191","id":154282115,"html_url":"https://github.com/vmware/liota/pull/191","diff_url":"https://github.com/vmware/liota/pull/191.diff","patch_url":"https://github.com/vmware/liota/pull/191.patch","issue_url":"https://api.github.com/repos/vmware/liota/issues/191","number":191,"state":"open","locked":false,"title":"Let package manager return command execution status:","user":{"login":"winniex1","id":17712390,"avatar_url":"https://avatars2.githubusercontent.com/u/17712390?v=4","gravatar_id":"","url":"https://api.github.com/users/winniex1","html_url":"https://github.com/winniex1","followers_url":"https://api.github.com/users/winniex1/followers","following_url":"https://api.github.com/users/winniex1/following{/other_user}","gists_url":"https://api.github.com/users/winniex1/gists{/gist_id}","starred_url":"https://api.github.com/users/winniex1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniex1/subscriptions","organizations_url":"https://api.github.com/users/winniex1/orgs","repos_url":"https://api.github.com/users/winniex1/repos","events_url":"https://api.github.com/users/winniex1/events{/privacy}","received_events_url":"https://api.github.com/users/winniex1/received_events","type":"User","site_admin":false},"body":"1. package manager creates one more namedPipe to pass status\r\n2. once user passes commands to messenger namedPipe through liotapkg,\r\nliotapkg will read from reponser namedPipe to get status\r\n3. for commands of [\"unload\", \"delete\", \"list\", \"stat\", \"unload_all\",\r\n   \"unload_all\", \"terminate\"], 'Success' means that package manager\r\n   has successfully received these commands;\r\n   for commands of [\"load\", \"reload\", \"update\"], 'Success' means that\r\n   verification of the package checksum succeeds, while 'Failure'\r\n   means that verification fails;\r\n   'Unsupported' means that receives some unsupported commands.","created_at":"2017-11-23T00:41:04Z","updated_at":"2017-11-24T05:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e76c2d48b2200eac78f68cf0fe1c38d6d26faf0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"KohliDev","id":5468034,"avatar_url":"https://avatars2.githubusercontent.com/u/5468034?v=4","gravatar_id":"","url":"https://api.github.com/users/KohliDev","html_url":"https://github.com/KohliDev","followers_url":"https://api.github.com/users/KohliDev/followers","following_url":"https://api.github.com/users/KohliDev/following{/other_user}","gists_url":"https://api.github.com/users/KohliDev/gists{/gist_id}","starred_url":"https://api.github.com/users/KohliDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KohliDev/subscriptions","organizations_url":"https://api.github.com/users/KohliDev/orgs","repos_url":"https://api.github.com/users/KohliDev/repos","events_url":"https://api.github.com/users/KohliDev/events{/privacy}","received_events_url":"https://api.github.com/users/KohliDev/received_events","type":"User","site_admin":false},{"login":"GregBollella","id":7319340,"avatar_url":"https://avatars0.githubusercontent.com/u/7319340?v=4","gravatar_id":"","url":"https://api.github.com/users/GregBollella","html_url":"https://github.com/GregBollella","followers_url":"https://api.github.com/users/GregBollella/followers","following_url":"https://api.github.com/users/GregBollella/following{/other_user}","gists_url":"https://api.github.com/users/GregBollella/gists{/gist_id}","starred_url":"https://api.github.com/users/GregBollella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregBollella/subscriptions","organizations_url":"https://api.github.com/users/GregBollella/orgs","repos_url":"https://api.github.com/users/GregBollella/repos","events_url":"https://api.github.com/users/GregBollella/events{/privacy}","received_events_url":"https://api.github.com/users/GregBollella/received_events","type":"User","site_admin":false},{"login":"pmasrani","id":17191813,"avatar_url":"https://avatars1.githubusercontent.com/u/17191813?v=4","gravatar_id":"","url":"https://api.github.com/users/pmasrani","html_url":"https://github.com/pmasrani","followers_url":"https://api.github.com/users/pmasrani/followers","following_url":"https://api.github.com/users/pmasrani/following{/other_user}","gists_url":"https://api.github.com/users/pmasrani/gists{/gist_id}","starred_url":"https://api.github.com/users/pmasrani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmasrani/subscriptions","organizations_url":"https://api.github.com/users/pmasrani/orgs","repos_url":"https://api.github.com/users/pmasrani/repos","events_url":"https://api.github.com/users/pmasrani/events{/privacy}","received_events_url":"https://api.github.com/users/pmasrani/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/liota/pulls/191/commits","review_comments_url":"https://api.github.com/repos/vmware/liota/pulls/191/comments","review_comment_url":"https://api.github.com/repos/vmware/liota/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/liota/issues/191/comments","statuses_url":"https://api.github.com/repos/vmware/liota/statuses/34ff337be27fc2b1d7aea745462140ff078f51d6","head":{"label":"winniex1:get_property","ref":"get_property","sha":"34ff337be27fc2b1d7aea745462140ff078f51d6","user":{"login":"winniex1","id":17712390,"avatar_url":"https://avatars2.githubusercontent.com/u/17712390?v=4","gravatar_id":"","url":"https://api.github.com/users/winniex1","html_url":"https://github.com/winniex1","followers_url":"https://api.github.com/users/winniex1/followers","following_url":"https://api.github.com/users/winniex1/following{/other_user}","gists_url":"https://api.github.com/users/winniex1/gists{/gist_id}","starred_url":"https://api.github.com/users/winniex1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniex1/subscriptions","organizations_url":"https://api.github.com/users/winniex1/orgs","repos_url":"https://api.github.com/users/winniex1/repos","events_url":"https://api.github.com/users/winniex1/events{/privacy}","received_events_url":"https://api.github.com/users/winniex1/received_events","type":"User","site_admin":false},"repo":{"id":102035205,"name":"liota","full_name":"winniex1/liota","owner":{"login":"winniex1","id":17712390,"avatar_url":"https://avatars2.githubusercontent.com/u/17712390?v=4","gravatar_id":"","url":"https://api.github.com/users/winniex1","html_url":"https://github.com/winniex1","followers_url":"https://api.github.com/users/winniex1/followers","following_url":"https://api.github.com/users/winniex1/following{/other_user}","gists_url":"https://api.github.com/users/winniex1/gists{/gist_id}","starred_url":"https://api.github.com/users/winniex1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniex1/subscriptions","organizations_url":"https://api.github.com/users/winniex1/orgs","repos_url":"https://api.github.com/users/winniex1/repos","events_url":"https://api.github.com/users/winniex1/events{/privacy}","received_events_url":"https://api.github.com/users/winniex1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/winniex1/liota","description":null,"fork":true,"url":"https://api.github.com/repos/winniex1/liota","forks_url":"https://api.github.com/repos/winniex1/liota/forks","keys_url":"https://api.github.com/repos/winniex1/liota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winniex1/liota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winniex1/liota/teams","hooks_url":"https://api.github.com/repos/winniex1/liota/hooks","issue_events_url":"https://api.github.com/repos/winniex1/liota/issues/events{/number}","events_url":"https://api.github.com/repos/winniex1/liota/events","assignees_url":"https://api.github.com/repos/winniex1/liota/assignees{/user}","branches_url":"https://api.github.com/repos/winniex1/liota/branches{/branch}","tags_url":"https://api.github.com/repos/winniex1/liota/tags","blobs_url":"https://api.github.com/repos/winniex1/liota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winniex1/liota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winniex1/liota/git/refs{/sha}","trees_url":"https://api.github.com/repos/winniex1/liota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winniex1/liota/statuses/{sha}","languages_url":"https://api.github.com/repos/winniex1/liota/languages","stargazers_url":"https://api.github.com/repos/winniex1/liota/stargazers","contributors_url":"https://api.github.com/repos/winniex1/liota/contributors","subscribers_url":"https://api.github.com/repos/winniex1/liota/subscribers","subscription_url":"https://api.github.com/repos/winniex1/liota/subscription","commits_url":"https://api.github.com/repos/winniex1/liota/commits{/sha}","git_commits_url":"https://api.github.com/repos/winniex1/liota/git/commits{/sha}","comments_url":"https://api.github.com/repos/winniex1/liota/comments{/number}","issue_comment_url":"https://api.github.com/repos/winniex1/liota/issues/comments{/number}","contents_url":"https://api.github.com/repos/winniex1/liota/contents/{+path}","compare_url":"https://api.github.com/repos/winniex1/liota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winniex1/liota/merges","archive_url":"https://api.github.com/repos/winniex1/liota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winniex1/liota/downloads","issues_url":"https://api.github.com/repos/winniex1/liota/issues{/number}","pulls_url":"https://api.github.com/repos/winniex1/liota/pulls{/number}","milestones_url":"https://api.github.com/repos/winniex1/liota/milestones{/number}","notifications_url":"https://api.github.com/repos/winniex1/liota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winniex1/liota/labels{/name}","releases_url":"https://api.github.com/repos/winniex1/liota/releases{/id}","deployments_url":"https://api.github.com/repos/winniex1/liota/deployments","created_at":"2017-08-31T19:04:45Z","updated_at":"2017-08-31T19:04:47Z","pushed_at":"2017-11-24T05:24:43Z","git_url":"git://github.com/winniex1/liota.git","ssh_url":"git@github.com:winniex1/liota.git","clone_url":"https://github.com/winniex1/liota.git","svn_url":"https://github.com/winniex1/liota","homepage":null,"size":792,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"fb2009dead31d938986b3da73f34e4106da7b3b1","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":51544954,"name":"liota","full_name":"vmware/liota","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/liota","description":null,"fork":false,"url":"https://api.github.com/repos/vmware/liota","forks_url":"https://api.github.com/repos/vmware/liota/forks","keys_url":"https://api.github.com/repos/vmware/liota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/liota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/liota/teams","hooks_url":"https://api.github.com/repos/vmware/liota/hooks","issue_events_url":"https://api.github.com/repos/vmware/liota/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/liota/events","assignees_url":"https://api.github.com/repos/vmware/liota/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/liota/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/liota/tags","blobs_url":"https://api.github.com/repos/vmware/liota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/liota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/liota/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/liota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/liota/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/liota/languages","stargazers_url":"https://api.github.com/repos/vmware/liota/stargazers","contributors_url":"https://api.github.com/repos/vmware/liota/contributors","subscribers_url":"https://api.github.com/repos/vmware/liota/subscribers","subscription_url":"https://api.github.com/repos/vmware/liota/subscription","commits_url":"https://api.github.com/repos/vmware/liota/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/liota/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/liota/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/liota/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/liota/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/liota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/liota/merges","archive_url":"https://api.github.com/repos/vmware/liota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/liota/downloads","issues_url":"https://api.github.com/repos/vmware/liota/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/liota/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/liota/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/liota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/liota/labels{/name}","releases_url":"https://api.github.com/repos/vmware/liota/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/liota/deployments","created_at":"2016-02-11T20:31:26Z","updated_at":"2017-11-21T19:48:15Z","pushed_at":"2017-11-24T05:24:45Z","git_url":"git://github.com/vmware/liota.git","ssh_url":"git@github.com:vmware/liota.git","clone_url":"https://github.com/vmware/liota.git","svn_url":"https://github.com/vmware/liota","homepage":null,"size":784,"stargazers_count":255,"watchers_count":255,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":63,"forks":94,"open_issues":63,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/liota/pulls/191"},"html":{"href":"https://github.com/vmware/liota/pull/191"},"issue":{"href":"https://api.github.com/repos/vmware/liota/issues/191"},"comments":{"href":"https://api.github.com/repos/vmware/liota/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/liota/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/liota/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/liota/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/liota/statuses/34ff337be27fc2b1d7aea745462140ff078f51d6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"winniex1"}}