{"action":"created","comment":{"url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/comments/152662169","pull_request_review_id":78559551,"id":152662169,"diff_hunk":"@@ -7,14 +7,14 @@ const { RangeError } = require('../errors');\n  */\n class Permissions {\n   /**\n-   * @param {number|PermissionResolvable[]} permissions Permissions or bitfield to read from\n+   * @param {PermissionResolvable|PermissionResolvable[]} permissions Permission(s) to read from\n    */\n   constructor(permissions) {\n     /**\n      * Bitfield of the packed permissions\n      * @type {number}\n      */\n-    this.bitfield = typeof permissions === 'number' ? permissions : this.constructor.resolve(permissions);\n+    this.bitfield = this.constructor.resolve(permissions);","path":"src/util/Permissions.js","position":13,"original_position":13,"commit_id":"8c869a3cca2dde41a98724082aa0fcc980133f12","original_commit_id":"8c869a3cca2dde41a98724082aa0fcc980133f12","user":{"login":"ZLima12","id":17912528,"avatar_url":"https://avatars1.githubusercontent.com/u/17912528?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLima12","html_url":"https://github.com/ZLima12","followers_url":"https://api.github.com/users/ZLima12/followers","following_url":"https://api.github.com/users/ZLima12/following{/other_user}","gists_url":"https://api.github.com/users/ZLima12/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLima12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLima12/subscriptions","organizations_url":"https://api.github.com/users/ZLima12/orgs","repos_url":"https://api.github.com/users/ZLima12/repos","events_url":"https://api.github.com/users/ZLima12/events{/privacy}","received_events_url":"https://api.github.com/users/ZLima12/received_events","type":"User","site_admin":false},"body":"why?","created_at":"2017-11-22T19:42:32Z","updated_at":"2017-11-22T19:42:32Z","html_url":"https://github.com/hydrabolt/discord.js/pull/2126#discussion_r152662169","pull_request_url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/comments/152662169"},"html":{"href":"https://github.com/hydrabolt/discord.js/pull/2126#discussion_r152662169"},"pull_request":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126"}},"in_reply_to_id":152661803},"pull_request":{"url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126","id":153816518,"html_url":"https://github.com/hydrabolt/discord.js/pull/2126","diff_url":"https://github.com/hydrabolt/discord.js/pull/2126.diff","patch_url":"https://github.com/hydrabolt/discord.js/pull/2126.patch","issue_url":"https://api.github.com/repos/hydrabolt/discord.js/issues/2126","number":2126,"state":"open","locked":false,"title":"Permissions improvements","user":{"login":"ZLima12","id":17912528,"avatar_url":"https://avatars1.githubusercontent.com/u/17912528?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLima12","html_url":"https://github.com/ZLima12","followers_url":"https://api.github.com/users/ZLima12/followers","following_url":"https://api.github.com/users/ZLima12/following{/other_user}","gists_url":"https://api.github.com/users/ZLima12/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLima12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLima12/subscriptions","organizations_url":"https://api.github.com/users/ZLima12/orgs","repos_url":"https://api.github.com/users/ZLima12/repos","events_url":"https://api.github.com/users/ZLima12/events{/privacy}","received_events_url":"https://api.github.com/users/ZLima12/received_events","type":"User","site_admin":false},"body":"- Added `Permission#missing`.\r\n- Allow singular `PermissionResolvable`s as parameter to `Permissions#missing`.\r\n- Fix JSDoc.\r\n- Allow `Permissions` to be iterated over.\r\n- Removed unnecessary (and bugged) conditional statement in constructor. (could accept negative bitfields before)\r\n- [Updated typings](https://github.com/ZLima12/discord.js-typings/tree/permissions-improvements) will be submitted as a PR when/if this one gets merged.\r\n\r\n**Semantic versioning classification:**  \r\n- [x] This PR changes the library's interface (methods or parameters added)\r\n  - [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)\r\n- [ ] This PR **only** includes non-code changes, like changes to documentation, README, etc.\r\n","created_at":"2017-11-21T07:32:04Z","updated_at":"2017-11-22T19:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5973bdb07022c9b1eb62da5332787044f38001c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126/commits","review_comments_url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126/comments","review_comment_url":"https://api.github.com/repos/hydrabolt/discord.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hydrabolt/discord.js/issues/2126/comments","statuses_url":"https://api.github.com/repos/hydrabolt/discord.js/statuses/8c869a3cca2dde41a98724082aa0fcc980133f12","head":{"label":"ZLima12:permissions-improvements","ref":"permissions-improvements","sha":"8c869a3cca2dde41a98724082aa0fcc980133f12","user":{"login":"ZLima12","id":17912528,"avatar_url":"https://avatars1.githubusercontent.com/u/17912528?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLima12","html_url":"https://github.com/ZLima12","followers_url":"https://api.github.com/users/ZLima12/followers","following_url":"https://api.github.com/users/ZLima12/following{/other_user}","gists_url":"https://api.github.com/users/ZLima12/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLima12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLima12/subscriptions","organizations_url":"https://api.github.com/users/ZLima12/orgs","repos_url":"https://api.github.com/users/ZLima12/repos","events_url":"https://api.github.com/users/ZLima12/events{/privacy}","received_events_url":"https://api.github.com/users/ZLima12/received_events","type":"User","site_admin":false},"repo":{"id":111505104,"name":"discord.js","full_name":"ZLima12/discord.js","owner":{"login":"ZLima12","id":17912528,"avatar_url":"https://avatars1.githubusercontent.com/u/17912528?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLima12","html_url":"https://github.com/ZLima12","followers_url":"https://api.github.com/users/ZLima12/followers","following_url":"https://api.github.com/users/ZLima12/following{/other_user}","gists_url":"https://api.github.com/users/ZLima12/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLima12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLima12/subscriptions","organizations_url":"https://api.github.com/users/ZLima12/orgs","repos_url":"https://api.github.com/users/ZLima12/repos","events_url":"https://api.github.com/users/ZLima12/events{/privacy}","received_events_url":"https://api.github.com/users/ZLima12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZLima12/discord.js","description":"A powerful JavaScript library for interacting with the Discord API","fork":true,"url":"https://api.github.com/repos/ZLima12/discord.js","forks_url":"https://api.github.com/repos/ZLima12/discord.js/forks","keys_url":"https://api.github.com/repos/ZLima12/discord.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZLima12/discord.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZLima12/discord.js/teams","hooks_url":"https://api.github.com/repos/ZLima12/discord.js/hooks","issue_events_url":"https://api.github.com/repos/ZLima12/discord.js/issues/events{/number}","events_url":"https://api.github.com/repos/ZLima12/discord.js/events","assignees_url":"https://api.github.com/repos/ZLima12/discord.js/assignees{/user}","branches_url":"https://api.github.com/repos/ZLima12/discord.js/branches{/branch}","tags_url":"https://api.github.com/repos/ZLima12/discord.js/tags","blobs_url":"https://api.github.com/repos/ZLima12/discord.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZLima12/discord.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZLima12/discord.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZLima12/discord.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZLima12/discord.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ZLima12/discord.js/languages","stargazers_url":"https://api.github.com/repos/ZLima12/discord.js/stargazers","contributors_url":"https://api.github.com/repos/ZLima12/discord.js/contributors","subscribers_url":"https://api.github.com/repos/ZLima12/discord.js/subscribers","subscription_url":"https://api.github.com/repos/ZLima12/discord.js/subscription","commits_url":"https://api.github.com/repos/ZLima12/discord.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZLima12/discord.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZLima12/discord.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZLima12/discord.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZLima12/discord.js/contents/{+path}","compare_url":"https://api.github.com/repos/ZLima12/discord.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZLima12/discord.js/merges","archive_url":"https://api.github.com/repos/ZLima12/discord.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZLima12/discord.js/downloads","issues_url":"https://api.github.com/repos/ZLima12/discord.js/issues{/number}","pulls_url":"https://api.github.com/repos/ZLima12/discord.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ZLima12/discord.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ZLima12/discord.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZLima12/discord.js/labels{/name}","releases_url":"https://api.github.com/repos/ZLima12/discord.js/releases{/id}","deployments_url":"https://api.github.com/repos/ZLima12/discord.js/deployments","created_at":"2017-11-21T05:48:07Z","updated_at":"2017-11-21T05:48:10Z","pushed_at":"2017-11-22T19:27:51Z","git_url":"git://github.com/ZLima12/discord.js.git","ssh_url":"git@github.com:ZLima12/discord.js.git","clone_url":"https://github.com/ZLima12/discord.js.git","svn_url":"https://github.com/ZLima12/discord.js","homepage":"https://discord.js.org","size":37634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hydrabolt:master","ref":"master","sha":"aaa92c0b05f6b4abadeaa74b7acce626acca030b","user":{"login":"hydrabolt","id":10330923,"avatar_url":"https://avatars1.githubusercontent.com/u/10330923?v=4","gravatar_id":"","url":"https://api.github.com/users/hydrabolt","html_url":"https://github.com/hydrabolt","followers_url":"https://api.github.com/users/hydrabolt/followers","following_url":"https://api.github.com/users/hydrabolt/following{/other_user}","gists_url":"https://api.github.com/users/hydrabolt/gists{/gist_id}","starred_url":"https://api.github.com/users/hydrabolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydrabolt/subscriptions","organizations_url":"https://api.github.com/users/hydrabolt/orgs","repos_url":"https://api.github.com/users/hydrabolt/repos","events_url":"https://api.github.com/users/hydrabolt/events{/privacy}","received_events_url":"https://api.github.com/users/hydrabolt/received_events","type":"User","site_admin":false},"repo":{"id":40484398,"name":"discord.js","full_name":"hydrabolt/discord.js","owner":{"login":"hydrabolt","id":10330923,"avatar_url":"https://avatars1.githubusercontent.com/u/10330923?v=4","gravatar_id":"","url":"https://api.github.com/users/hydrabolt","html_url":"https://github.com/hydrabolt","followers_url":"https://api.github.com/users/hydrabolt/followers","following_url":"https://api.github.com/users/hydrabolt/following{/other_user}","gists_url":"https://api.github.com/users/hydrabolt/gists{/gist_id}","starred_url":"https://api.github.com/users/hydrabolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydrabolt/subscriptions","organizations_url":"https://api.github.com/users/hydrabolt/orgs","repos_url":"https://api.github.com/users/hydrabolt/repos","events_url":"https://api.github.com/users/hydrabolt/events{/privacy}","received_events_url":"https://api.github.com/users/hydrabolt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hydrabolt/discord.js","description":"A powerful JavaScript library for interacting with the Discord API","fork":false,"url":"https://api.github.com/repos/hydrabolt/discord.js","forks_url":"https://api.github.com/repos/hydrabolt/discord.js/forks","keys_url":"https://api.github.com/repos/hydrabolt/discord.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hydrabolt/discord.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hydrabolt/discord.js/teams","hooks_url":"https://api.github.com/repos/hydrabolt/discord.js/hooks","issue_events_url":"https://api.github.com/repos/hydrabolt/discord.js/issues/events{/number}","events_url":"https://api.github.com/repos/hydrabolt/discord.js/events","assignees_url":"https://api.github.com/repos/hydrabolt/discord.js/assignees{/user}","branches_url":"https://api.github.com/repos/hydrabolt/discord.js/branches{/branch}","tags_url":"https://api.github.com/repos/hydrabolt/discord.js/tags","blobs_url":"https://api.github.com/repos/hydrabolt/discord.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hydrabolt/discord.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hydrabolt/discord.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/hydrabolt/discord.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hydrabolt/discord.js/statuses/{sha}","languages_url":"https://api.github.com/repos/hydrabolt/discord.js/languages","stargazers_url":"https://api.github.com/repos/hydrabolt/discord.js/stargazers","contributors_url":"https://api.github.com/repos/hydrabolt/discord.js/contributors","subscribers_url":"https://api.github.com/repos/hydrabolt/discord.js/subscribers","subscription_url":"https://api.github.com/repos/hydrabolt/discord.js/subscription","commits_url":"https://api.github.com/repos/hydrabolt/discord.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/hydrabolt/discord.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/hydrabolt/discord.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/hydrabolt/discord.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/hydrabolt/discord.js/contents/{+path}","compare_url":"https://api.github.com/repos/hydrabolt/discord.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hydrabolt/discord.js/merges","archive_url":"https://api.github.com/repos/hydrabolt/discord.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hydrabolt/discord.js/downloads","issues_url":"https://api.github.com/repos/hydrabolt/discord.js/issues{/number}","pulls_url":"https://api.github.com/repos/hydrabolt/discord.js/pulls{/number}","milestones_url":"https://api.github.com/repos/hydrabolt/discord.js/milestones{/number}","notifications_url":"https://api.github.com/repos/hydrabolt/discord.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hydrabolt/discord.js/labels{/name}","releases_url":"https://api.github.com/repos/hydrabolt/discord.js/releases{/id}","deployments_url":"https://api.github.com/repos/hydrabolt/discord.js/deployments","created_at":"2015-08-10T13:36:26Z","updated_at":"2017-11-22T15:23:03Z","pushed_at":"2017-11-22T19:27:52Z","git_url":"git://github.com/hydrabolt/discord.js.git","ssh_url":"git@github.com:hydrabolt/discord.js.git","clone_url":"https://github.com/hydrabolt/discord.js.git","svn_url":"https://github.com/hydrabolt/discord.js","homepage":"https://discord.js.org","size":38455,"stargazers_count":1761,"watchers_count":1761,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":474,"mirror_url":null,"archived":false,"open_issues_count":43,"forks":474,"open_issues":43,"watchers":1761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126"},"html":{"href":"https://github.com/hydrabolt/discord.js/pull/2126"},"issue":{"href":"https://api.github.com/repos/hydrabolt/discord.js/issues/2126"},"comments":{"href":"https://api.github.com/repos/hydrabolt/discord.js/issues/2126/comments"},"review_comments":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126/comments"},"review_comment":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hydrabolt/discord.js/pulls/2126/commits"},"statuses":{"href":"https://api.github.com/repos/hydrabolt/discord.js/statuses/8c869a3cca2dde41a98724082aa0fcc980133f12"}},"author_association":"NONE"}}
{"actor":{"display_login":"ZLima12"}}