{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/4631","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/4631/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/4631/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/4631/events","html_url":"https://github.com/theforeman/foreman/pull/4631","id":239403656,"number":4631,"title":"Fixes #20146 - domain-less server email errors fixed","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars3.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"labels":[{"id":79040160,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":79040689,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-29T08:33:52Z","updated_at":"2017-07-11T10:25:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/4631","html_url":"https://github.com/theforeman/foreman/pull/4631","diff_url":"https://github.com/theforeman/foreman/pull/4631.diff","patch_url":"https://github.com/theforeman/foreman/pull/4631.patch"},"body":"On a server without domain (e.g. `hostname -f` returning just host name) there were email validation errors because domain part was `nil` via Facter. This fixes it - it falls back to hostname if domain is not set.\n\nMore than that, our design was weird - there is a config setting `domain` in `settings.yaml` which I believe should override what's set on system but it does not - Facter wins. I refactored the code so it really overrides when it is present.\n\nAlso lowered case for the default \"Foreman-noreply\" email which looks much saner to me."},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/314402180","html_url":"https://github.com/theforeman/foreman/pull/4631#issuecomment-314402180","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/4631","id":314402180,"user":{"login":"lzap","id":49752,"avatar_url":"https://avatars3.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"created_at":"2017-07-11T10:25:38Z","updated_at":"2017-07-11T10:25:38Z","body":"Rebased, @dLobatog I wish I could test but this is Rails initialize code (foreman/config/settings.rb), I'd need to extract this into external class like DefaultSettings and then test that. Is it worth the effort tho? The other two files simply uses the global setting \"domain\"."}}
{"actor":{"display_login":"lzap"}}