{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/145915979","pull_request_review_id":70786627,"id":145915979,"diff_hunk":"@@ -95,14 +113,25 @@ def get_random_instances(cls, provider, count=1, appliance=None):\n         return [collection.instantiate(obj.name, provider)\n                 for obj in itertools.islice(node_list, count)]\n \n+    @property\n+    def exists(self):","path":"cfme/containers/node.py","position":166,"original_position":165,"commit_id":"9e0b963d50e20e2e31f7d78dd23ee09029a38c7b","original_commit_id":"ce973c31dac6dc26245e93f6d78a1e3928b76af4","user":{"login":"psav","id":5639745,"avatar_url":"https://avatars0.githubusercontent.com/u/5639745?v=4","gravatar_id":"","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},"body":"```.exists``` here should check the UI\r\nMethods against the models are related to the objects in MiQ therefore it does not make sense to check against the mgmt system. There are many places in the codebase right now where ```self.exists``` on an object checks either via REST or UI, but always MiQ. That's kinda why ```self.mgmt.exists``` is there, so that you can do a check of the management system.","created_at":"2017-10-20T09:22:09Z","updated_at":"2017-10-20T09:22:09Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/5592#discussion_r145915979","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/145915979"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/5592#discussion_r145915979"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592"}},"in_reply_to_id":144854432},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592","id":146296989,"html_url":"https://github.com/ManageIQ/integration_tests/pull/5592","diff_url":"https://github.com/ManageIQ/integration_tests/pull/5592.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/5592.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5592","number":5592,"state":"open","locked":false,"title":"[RFR] Updates to container.node","user":{"login":"jawatts","id":31294478,"avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"body":"Updates to container.node to further integrate with widgetastic/collectionsv3.\r\n\r\nUpdates:\r\nAdded toolbar views for Node,NodeDetails\r\nAdded accordion for NodeDetails\r\nUpdated NodeView to use BaseLoggedInPage\r\nRemoved unused impor\r\nCommented out any import/reference to Node in existing test cases until they can be updated to use the widgetastic views/widgets \r\n \r\nFurther Actions Needed:\r\nMissing navigation to Ad hoc Metrics, External Logging, and Web Console. ","created_at":"2017-10-12T19:42:49Z","updated_at":"2017-10-20T09:22:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ee2157920b1eb716ee27c7da4d971f554a33b56","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5592/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/9e0b963d50e20e2e31f7d78dd23ee09029a38c7b","head":{"label":"jawatts:updateContainerNode-Collectionv3--4823","ref":"updateContainerNode-Collectionv3--4823","sha":"9e0b963d50e20e2e31f7d78dd23ee09029a38c7b","user":{"login":"jawatts","id":31294478,"avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"repo":{"id":101302879,"name":"integration_tests","full_name":"jawatts/integration_tests","owner":{"login":"jawatts","id":31294478,"avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jawatts/integration_tests","description":"ManageIQ integration tests","fork":true,"url":"https://api.github.com/repos/jawatts/integration_tests","forks_url":"https://api.github.com/repos/jawatts/integration_tests/forks","keys_url":"https://api.github.com/repos/jawatts/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jawatts/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jawatts/integration_tests/teams","hooks_url":"https://api.github.com/repos/jawatts/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/jawatts/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/jawatts/integration_tests/events","assignees_url":"https://api.github.com/repos/jawatts/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/jawatts/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/jawatts/integration_tests/tags","blobs_url":"https://api.github.com/repos/jawatts/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jawatts/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jawatts/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/jawatts/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jawatts/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/jawatts/integration_tests/languages","stargazers_url":"https://api.github.com/repos/jawatts/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/jawatts/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/jawatts/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/jawatts/integration_tests/subscription","commits_url":"https://api.github.com/repos/jawatts/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/jawatts/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/jawatts/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/jawatts/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/jawatts/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/jawatts/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jawatts/integration_tests/merges","archive_url":"https://api.github.com/repos/jawatts/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jawatts/integration_tests/downloads","issues_url":"https://api.github.com/repos/jawatts/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/jawatts/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/jawatts/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/jawatts/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jawatts/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/jawatts/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/jawatts/integration_tests/deployments","created_at":"2017-08-24T14:17:34Z","updated_at":"2017-08-24T14:17:38Z","pushed_at":"2017-10-19T15:10:34Z","git_url":"git://github.com/jawatts/integration_tests.git","ssh_url":"git@github.com:jawatts/integration_tests.git","clone_url":"https://github.com/jawatts/integration_tests.git","svn_url":"https://github.com/jawatts/integration_tests","homepage":"","size":19088,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"d76ab4033359e57c119378e412cabe0d09953edb","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2017-10-18T08:00:26Z","pushed_at":"2017-10-20T09:10:23Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":19368,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":110,"forks":99,"open_issues":110,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/5592"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5592"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5592/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5592/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/9e0b963d50e20e2e31f7d78dd23ee09029a38c7b"}},"author_association":"NONE"}}
{"actor":{"display_login":"psav"}}