{"action":"created","comment":{"url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/comments/157760654","pull_request_review_id":84455638,"id":157760654,"diff_hunk":"@@ -148,7 +165,9 @@ Oskari.clazz.define('Oskari.mapframework.bundle.publisher2.PublisherBundleInstan\n             // trigger an event letting other bundles know we require the whole UI\n             var eventBuilder = Oskari.eventBuilder('UIChangeEvent');\n             this.sandbox.notifyAll(eventBuilder(this.mediator.bundleId));\n-\n+            if ( !!this.configurationHasCustomElement ) {","path":"bundles/framework/publisher2/instance.js","position":47,"original_position":47,"commit_id":"f5443930c9e4f33872e7647f22434fe41aecb451","original_commit_id":"f5443930c9e4f33872e7647f22434fe41aecb451","user":{"login":"ZakarFin","id":2210335,"avatar_url":"https://avatars3.githubusercontent.com/u/2210335?v=4","gravatar_id":"","url":"https://api.github.com/users/ZakarFin","html_url":"https://github.com/ZakarFin","followers_url":"https://api.github.com/users/ZakarFin/followers","following_url":"https://api.github.com/users/ZakarFin/following{/other_user}","gists_url":"https://api.github.com/users/ZakarFin/gists{/gist_id}","starred_url":"https://api.github.com/users/ZakarFin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZakarFin/subscriptions","organizations_url":"https://api.github.com/users/ZakarFin/orgs","repos_url":"https://api.github.com/users/ZakarFin/repos","events_url":"https://api.github.com/users/ZakarFin/events{/privacy}","received_events_url":"https://api.github.com/users/ZakarFin/received_events","type":"User","site_admin":false},"body":"This is always true","created_at":"2017-12-19T13:58:08Z","updated_at":"2017-12-19T13:58:08Z","html_url":"https://github.com/oskariorg/oskari-frontend/pull/216#discussion_r157760654","pull_request_url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/comments/157760654"},"html":{"href":"https://github.com/oskariorg/oskari-frontend/pull/216#discussion_r157760654"},"pull_request":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216","id":158906559,"html_url":"https://github.com/oskariorg/oskari-frontend/pull/216","diff_url":"https://github.com/oskariorg/oskari-frontend/pull/216.diff","patch_url":"https://github.com/oskariorg/oskari-frontend/pull/216.patch","issue_url":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/216","number":216,"state":"open","locked":false,"title":"publisher2/custom ui","user":{"login":"nxholm","id":9434350,"avatar_url":"https://avatars1.githubusercontent.com/u/9434350?v=4","gravatar_id":"","url":"https://api.github.com/users/nxholm","html_url":"https://github.com/nxholm","followers_url":"https://api.github.com/users/nxholm/followers","following_url":"https://api.github.com/users/nxholm/following{/other_user}","gists_url":"https://api.github.com/users/nxholm/gists{/gist_id}","starred_url":"https://api.github.com/users/nxholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxholm/subscriptions","organizations_url":"https://api.github.com/users/nxholm/orgs","repos_url":"https://api.github.com/users/nxholm/repos","events_url":"https://api.github.com/users/nxholm/events{/privacy}","received_events_url":"https://api.github.com/users/nxholm/received_events","type":"User","site_admin":false},"body":"- add function to check if a element reference has been passed in config, if true, disable tile and use custom element as starting point","created_at":"2017-12-18T12:53:18Z","updated_at":"2017-12-19T13:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032b5e80da2839da664e3834492488a7d340281f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216/commits","review_comments_url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216/comments","review_comment_url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/216/comments","statuses_url":"https://api.github.com/repos/oskariorg/oskari-frontend/statuses/f5443930c9e4f33872e7647f22434fe41aecb451","head":{"label":"nxholm:publisher2/customUI","ref":"publisher2/customUI","sha":"f5443930c9e4f33872e7647f22434fe41aecb451","user":{"login":"nxholm","id":9434350,"avatar_url":"https://avatars1.githubusercontent.com/u/9434350?v=4","gravatar_id":"","url":"https://api.github.com/users/nxholm","html_url":"https://github.com/nxholm","followers_url":"https://api.github.com/users/nxholm/followers","following_url":"https://api.github.com/users/nxholm/following{/other_user}","gists_url":"https://api.github.com/users/nxholm/gists{/gist_id}","starred_url":"https://api.github.com/users/nxholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxholm/subscriptions","organizations_url":"https://api.github.com/users/nxholm/orgs","repos_url":"https://api.github.com/users/nxholm/repos","events_url":"https://api.github.com/users/nxholm/events{/privacy}","received_events_url":"https://api.github.com/users/nxholm/received_events","type":"User","site_admin":false},"repo":{"id":84958359,"name":"oskari-frontend","full_name":"nxholm/oskari-frontend","owner":{"login":"nxholm","id":9434350,"avatar_url":"https://avatars1.githubusercontent.com/u/9434350?v=4","gravatar_id":"","url":"https://api.github.com/users/nxholm","html_url":"https://github.com/nxholm","followers_url":"https://api.github.com/users/nxholm/followers","following_url":"https://api.github.com/users/nxholm/following{/other_user}","gists_url":"https://api.github.com/users/nxholm/gists{/gist_id}","starred_url":"https://api.github.com/users/nxholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxholm/subscriptions","organizations_url":"https://api.github.com/users/nxholm/orgs","repos_url":"https://api.github.com/users/nxholm/repos","events_url":"https://api.github.com/users/nxholm/events{/privacy}","received_events_url":"https://api.github.com/users/nxholm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nxholm/oskari-frontend","description":"Frontend implementation for Oskari Map Application Framework","fork":true,"url":"https://api.github.com/repos/nxholm/oskari-frontend","forks_url":"https://api.github.com/repos/nxholm/oskari-frontend/forks","keys_url":"https://api.github.com/repos/nxholm/oskari-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nxholm/oskari-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nxholm/oskari-frontend/teams","hooks_url":"https://api.github.com/repos/nxholm/oskari-frontend/hooks","issue_events_url":"https://api.github.com/repos/nxholm/oskari-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/nxholm/oskari-frontend/events","assignees_url":"https://api.github.com/repos/nxholm/oskari-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/nxholm/oskari-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/nxholm/oskari-frontend/tags","blobs_url":"https://api.github.com/repos/nxholm/oskari-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nxholm/oskari-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nxholm/oskari-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/nxholm/oskari-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nxholm/oskari-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/nxholm/oskari-frontend/languages","stargazers_url":"https://api.github.com/repos/nxholm/oskari-frontend/stargazers","contributors_url":"https://api.github.com/repos/nxholm/oskari-frontend/contributors","subscribers_url":"https://api.github.com/repos/nxholm/oskari-frontend/subscribers","subscription_url":"https://api.github.com/repos/nxholm/oskari-frontend/subscription","commits_url":"https://api.github.com/repos/nxholm/oskari-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/nxholm/oskari-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/nxholm/oskari-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/nxholm/oskari-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/nxholm/oskari-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/nxholm/oskari-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nxholm/oskari-frontend/merges","archive_url":"https://api.github.com/repos/nxholm/oskari-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nxholm/oskari-frontend/downloads","issues_url":"https://api.github.com/repos/nxholm/oskari-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/nxholm/oskari-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/nxholm/oskari-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/nxholm/oskari-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nxholm/oskari-frontend/labels{/name}","releases_url":"https://api.github.com/repos/nxholm/oskari-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/nxholm/oskari-frontend/deployments","created_at":"2017-03-14T14:26:30Z","updated_at":"2017-08-11T10:28:55Z","pushed_at":"2017-12-19T13:29:48Z","git_url":"git://github.com/nxholm/oskari-frontend.git","ssh_url":"git@github.com:nxholm/oskari-frontend.git","clone_url":"https://github.com/nxholm/oskari-frontend.git","svn_url":"https://github.com/nxholm/oskari-frontend","homepage":"http://www.oskari.org","size":115781,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"oskariorg:develop","ref":"develop","sha":"ad20b3c3eec7ddc8f560c64fec9c53f760f8e999","user":{"login":"oskariorg","id":25427941,"avatar_url":"https://avatars1.githubusercontent.com/u/25427941?v=4","gravatar_id":"","url":"https://api.github.com/users/oskariorg","html_url":"https://github.com/oskariorg","followers_url":"https://api.github.com/users/oskariorg/followers","following_url":"https://api.github.com/users/oskariorg/following{/other_user}","gists_url":"https://api.github.com/users/oskariorg/gists{/gist_id}","starred_url":"https://api.github.com/users/oskariorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskariorg/subscriptions","organizations_url":"https://api.github.com/users/oskariorg/orgs","repos_url":"https://api.github.com/users/oskariorg/repos","events_url":"https://api.github.com/users/oskariorg/events{/privacy}","received_events_url":"https://api.github.com/users/oskariorg/received_events","type":"Organization","site_admin":false},"repo":{"id":5537779,"name":"oskari-frontend","full_name":"oskariorg/oskari-frontend","owner":{"login":"oskariorg","id":25427941,"avatar_url":"https://avatars1.githubusercontent.com/u/25427941?v=4","gravatar_id":"","url":"https://api.github.com/users/oskariorg","html_url":"https://github.com/oskariorg","followers_url":"https://api.github.com/users/oskariorg/followers","following_url":"https://api.github.com/users/oskariorg/following{/other_user}","gists_url":"https://api.github.com/users/oskariorg/gists{/gist_id}","starred_url":"https://api.github.com/users/oskariorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskariorg/subscriptions","organizations_url":"https://api.github.com/users/oskariorg/orgs","repos_url":"https://api.github.com/users/oskariorg/repos","events_url":"https://api.github.com/users/oskariorg/events{/privacy}","received_events_url":"https://api.github.com/users/oskariorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oskariorg/oskari-frontend","description":"Frontend implementation for Oskari Map Application Framework","fork":false,"url":"https://api.github.com/repos/oskariorg/oskari-frontend","forks_url":"https://api.github.com/repos/oskariorg/oskari-frontend/forks","keys_url":"https://api.github.com/repos/oskariorg/oskari-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oskariorg/oskari-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oskariorg/oskari-frontend/teams","hooks_url":"https://api.github.com/repos/oskariorg/oskari-frontend/hooks","issue_events_url":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/oskariorg/oskari-frontend/events","assignees_url":"https://api.github.com/repos/oskariorg/oskari-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/oskariorg/oskari-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/oskariorg/oskari-frontend/tags","blobs_url":"https://api.github.com/repos/oskariorg/oskari-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oskariorg/oskari-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oskariorg/oskari-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/oskariorg/oskari-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oskariorg/oskari-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/oskariorg/oskari-frontend/languages","stargazers_url":"https://api.github.com/repos/oskariorg/oskari-frontend/stargazers","contributors_url":"https://api.github.com/repos/oskariorg/oskari-frontend/contributors","subscribers_url":"https://api.github.com/repos/oskariorg/oskari-frontend/subscribers","subscription_url":"https://api.github.com/repos/oskariorg/oskari-frontend/subscription","commits_url":"https://api.github.com/repos/oskariorg/oskari-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/oskariorg/oskari-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/oskariorg/oskari-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/oskariorg/oskari-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/oskariorg/oskari-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oskariorg/oskari-frontend/merges","archive_url":"https://api.github.com/repos/oskariorg/oskari-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oskariorg/oskari-frontend/downloads","issues_url":"https://api.github.com/repos/oskariorg/oskari-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/oskariorg/oskari-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/oskariorg/oskari-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oskariorg/oskari-frontend/labels{/name}","releases_url":"https://api.github.com/repos/oskariorg/oskari-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/oskariorg/oskari-frontend/deployments","created_at":"2012-08-24T08:44:24Z","updated_at":"2017-11-16T13:06:26Z","pushed_at":"2017-12-19T13:34:28Z","git_url":"git://github.com/oskariorg/oskari-frontend.git","ssh_url":"git@github.com:oskariorg/oskari-frontend.git","clone_url":"https://github.com/oskariorg/oskari-frontend.git","svn_url":"https://github.com/oskariorg/oskari-frontend","homepage":"http://www.oskari.org","size":115570,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":3,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216"},"html":{"href":"https://github.com/oskariorg/oskari-frontend/pull/216"},"issue":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/216"},"comments":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/oskariorg/oskari-frontend/statuses/f5443930c9e4f33872e7647f22434fe41aecb451"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ZakarFin"}}