{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/101802538","pull_request_review_id":22545137,"id":101802538,"diff_hunk":"@@ -74,6 +75,35 @@ def _generator(self):\n \n         raise ConanException(\"Unknown cmake generator for these settings\")\n \n+    def _cmake_compiler_options(self, target_os, target_arch, target_comp):\n+        host_platform = platform.system()\n+        same_platform = (target_os == host_platform)\n+\n+        cmake_flags = []\n+\n+        if not same_platform:\n+            cmake_flags.append(\"-DCMAKE_SYSTEM_NAME=%s\" % target_os)","path":"conans/client/cmake.py","position":43,"original_position":43,"commit_id":"3502691be5cd9e5d12e3885cb19d5aa48edcdc6c","original_commit_id":"3502691be5cd9e5d12e3885cb19d5aa48edcdc6c","user":{"login":"sixten-hilborn","id":729451,"avatar_url":"https://avatars.githubusercontent.com/u/729451?v=3","gravatar_id":"","url":"https://api.github.com/users/sixten-hilborn","html_url":"https://github.com/sixten-hilborn","followers_url":"https://api.github.com/users/sixten-hilborn/followers","following_url":"https://api.github.com/users/sixten-hilborn/following{/other_user}","gists_url":"https://api.github.com/users/sixten-hilborn/gists{/gist_id}","starred_url":"https://api.github.com/users/sixten-hilborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixten-hilborn/subscriptions","organizations_url":"https://api.github.com/users/sixten-hilborn/orgs","repos_url":"https://api.github.com/users/sixten-hilborn/repos","events_url":"https://api.github.com/users/sixten-hilborn/events{/privacy}","received_events_url":"https://api.github.com/users/sixten-hilborn/received_events","type":"User","site_admin":false},"body":"CMAKE_SYSTEM_NAME should be \"Darwin\" if Macos is the target_os, and \"Generic\" if target_os is unknown/None.","created_at":"2017-02-17T17:13:10Z","updated_at":"2017-02-17T17:15:33Z","html_url":"https://github.com/conan-io/conan/pull/874#discussion_r101802538","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/874","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/101802538"},"html":{"href":"https://github.com/conan-io/conan/pull/874#discussion_r101802538"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/874"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/874","id":101903443,"html_url":"https://github.com/conan-io/conan/pull/874","diff_url":"https://github.com/conan-io/conan/pull/874.diff","patch_url":"https://github.com/conan-io/conan/pull/874.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/874","number":874,"state":"open","locked":false,"title":"extended CMake flags for MinGW","user":{"login":"madduci","id":371042,"avatar_url":"https://avatars.githubusercontent.com/u/371042?v=3","gravatar_id":"","url":"https://api.github.com/users/madduci","html_url":"https://github.com/madduci","followers_url":"https://api.github.com/users/madduci/followers","following_url":"https://api.github.com/users/madduci/following{/other_user}","gists_url":"https://api.github.com/users/madduci/gists{/gist_id}","starred_url":"https://api.github.com/users/madduci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madduci/subscriptions","organizations_url":"https://api.github.com/users/madduci/orgs","repos_url":"https://api.github.com/users/madduci/repos","events_url":"https://api.github.com/users/madduci/events{/privacy}","received_events_url":"https://api.github.com/users/madduci/received_events","type":"User","site_admin":false},"body":"Added extra flags for CMake when using MinGW on a platform different from Windows.\r\nIn particular, MinGW Makefiles is a valid generator only when running under Windows, otherwise \"Unix Makefiles\" should be preferred and CMake flags \r\n\r\n- CMAKE_C_COMPILER\r\n- CMAKE_CXX_COMPILER\r\n- CMAKE_SYSTEM_NAME\r\n\r\nshould be set accordingly to generate Win32 targets","created_at":"2017-01-17T16:55:33Z","updated_at":"2017-02-17T17:15:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"496a87f1a6fd2db0276de3d03a5a5d902aa7147e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/13","html_url":"https://github.com/conan-io/conan/milestone/13","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/13/labels","id":2269978,"number":13,"title":"0.20","description":"The environment release.","creator":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":9,"state":"open","created_at":"2017-01-22T21:17:16Z","updated_at":"2017-02-17T11:51:42Z","due_on":"2017-02-27T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/874/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/874/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/874/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/3502691be5cd9e5d12e3885cb19d5aa48edcdc6c","head":{"label":"madduci:develop","ref":"develop","sha":"3502691be5cd9e5d12e3885cb19d5aa48edcdc6c","user":{"login":"madduci","id":371042,"avatar_url":"https://avatars.githubusercontent.com/u/371042?v=3","gravatar_id":"","url":"https://api.github.com/users/madduci","html_url":"https://github.com/madduci","followers_url":"https://api.github.com/users/madduci/followers","following_url":"https://api.github.com/users/madduci/following{/other_user}","gists_url":"https://api.github.com/users/madduci/gists{/gist_id}","starred_url":"https://api.github.com/users/madduci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madduci/subscriptions","organizations_url":"https://api.github.com/users/madduci/orgs","repos_url":"https://api.github.com/users/madduci/repos","events_url":"https://api.github.com/users/madduci/events{/privacy}","received_events_url":"https://api.github.com/users/madduci/received_events","type":"User","site_admin":false},"repo":{"id":79249607,"name":"conan","full_name":"madduci/conan","owner":{"login":"madduci","id":371042,"avatar_url":"https://avatars.githubusercontent.com/u/371042?v=3","gravatar_id":"","url":"https://api.github.com/users/madduci","html_url":"https://github.com/madduci","followers_url":"https://api.github.com/users/madduci/followers","following_url":"https://api.github.com/users/madduci/following{/other_user}","gists_url":"https://api.github.com/users/madduci/gists{/gist_id}","starred_url":"https://api.github.com/users/madduci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madduci/subscriptions","organizations_url":"https://api.github.com/users/madduci/orgs","repos_url":"https://api.github.com/users/madduci/repos","events_url":"https://api.github.com/users/madduci/events{/privacy}","received_events_url":"https://api.github.com/users/madduci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madduci/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/madduci/conan","forks_url":"https://api.github.com/repos/madduci/conan/forks","keys_url":"https://api.github.com/repos/madduci/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madduci/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madduci/conan/teams","hooks_url":"https://api.github.com/repos/madduci/conan/hooks","issue_events_url":"https://api.github.com/repos/madduci/conan/issues/events{/number}","events_url":"https://api.github.com/repos/madduci/conan/events","assignees_url":"https://api.github.com/repos/madduci/conan/assignees{/user}","branches_url":"https://api.github.com/repos/madduci/conan/branches{/branch}","tags_url":"https://api.github.com/repos/madduci/conan/tags","blobs_url":"https://api.github.com/repos/madduci/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madduci/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madduci/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/madduci/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madduci/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/madduci/conan/languages","stargazers_url":"https://api.github.com/repos/madduci/conan/stargazers","contributors_url":"https://api.github.com/repos/madduci/conan/contributors","subscribers_url":"https://api.github.com/repos/madduci/conan/subscribers","subscription_url":"https://api.github.com/repos/madduci/conan/subscription","commits_url":"https://api.github.com/repos/madduci/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/madduci/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/madduci/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/madduci/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/madduci/conan/contents/{+path}","compare_url":"https://api.github.com/repos/madduci/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madduci/conan/merges","archive_url":"https://api.github.com/repos/madduci/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madduci/conan/downloads","issues_url":"https://api.github.com/repos/madduci/conan/issues{/number}","pulls_url":"https://api.github.com/repos/madduci/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/madduci/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/madduci/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madduci/conan/labels{/name}","releases_url":"https://api.github.com/repos/madduci/conan/releases{/id}","deployments_url":"https://api.github.com/repos/madduci/conan/deployments","created_at":"2017-01-17T16:51:29Z","updated_at":"2017-01-17T16:51:32Z","pushed_at":"2017-01-24T11:13:53Z","git_url":"git://github.com/madduci/conan.git","ssh_url":"git@github.com:madduci/conan.git","clone_url":"https://github.com/madduci/conan.git","svn_url":"https://github.com/madduci/conan","homepage":"https://conan.io","size":1677,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"316e4d3e4c82c3e40bc16fc0a63be31eb449c40f","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2017-02-17T06:13:01Z","pushed_at":"2017-02-17T12:50:35Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":1835,"stargazers_count":801,"watchers_count":801,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":149,"forks":111,"open_issues":149,"watchers":801,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/874"},"html":{"href":"https://github.com/conan-io/conan/pull/874"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/874"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/3502691be5cd9e5d12e3885cb19d5aa48edcdc6c"}}}}
{"actor":{"display_login":"sixten-hilborn"}}