{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/146494003","pull_request_review_id":71441642,"id":146494003,"diff_hunk":"@@ -122,6 +124,22 @@ func (s *testMainSuite) TestRetryOpenStore(c *C) {\n \tc.Assert(uint64(elapse), GreaterEqual, uint64(3*time.Second))\n }\n \n+func (s *testMainSuite) TestRetryDialPumpClient(c *C) {\n+\tretryDialPumlClientMustFail := func(binlogSocket string, clientCon *grpc.ClientConn, maxRetries int, dialerOpt grpc.DialOption) (err error) {\n+\t\treturn util.RunWithRetry(maxRetries, 10, func() (bool, error) {\n+\t\t\tclientCon, err = grpc.Dial(binlogSocket, grpc.WithInsecure(), dialerOpt)","path":"tidb_test.go","position":20,"original_position":20,"commit_id":"c4fd5c5cab5524b25f4b3d9ce4e6b9e3d8e7dff6","original_commit_id":"c4fd5c5cab5524b25f4b3d9ce4e6b9e3d8e7dff6","user":{"login":"zimulala","id":4242506,"avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"body":"This code doesn't use. We can remove it or add some comments.","created_at":"2017-10-24T08:53:43Z","updated_at":"2017-10-24T08:54:08Z","html_url":"https://github.com/pingcap/tidb/pull/4879#discussion_r146494003","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/4879","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/146494003"},"html":{"href":"https://github.com/pingcap/tidb/pull/4879#discussion_r146494003"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4879"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/4879","id":148302127,"html_url":"https://github.com/pingcap/tidb/pull/4879","diff_url":"https://github.com/pingcap/tidb/pull/4879.diff","patch_url":"https://github.com/pingcap/tidb/pull/4879.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/4879","number":4879,"state":"open","locked":false,"title":"Add retry for dialPumpClient","user":{"login":"XuHuaiyu","id":9039012,"avatar_url":"https://avatars1.githubusercontent.com/u/9039012?v=4","gravatar_id":"","url":"https://api.github.com/users/XuHuaiyu","html_url":"https://github.com/XuHuaiyu","followers_url":"https://api.github.com/users/XuHuaiyu/followers","following_url":"https://api.github.com/users/XuHuaiyu/following{/other_user}","gists_url":"https://api.github.com/users/XuHuaiyu/gists{/gist_id}","starred_url":"https://api.github.com/users/XuHuaiyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuHuaiyu/subscriptions","organizations_url":"https://api.github.com/users/XuHuaiyu/orgs","repos_url":"https://api.github.com/users/XuHuaiyu/repos","events_url":"https://api.github.com/users/XuHuaiyu/events{/privacy}","received_events_url":"https://api.github.com/users/XuHuaiyu/received_events","type":"User","site_admin":false},"body":"fix #4848 \r\nPTAL @coocood ","created_at":"2017-10-24T05:42:30Z","updated_at":"2017-10-24T08:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"193c5538e053fd70188209c58cc69276333420a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/4879/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/4879/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/4879/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/c4fd5c5cab5524b25f4b3d9ce4e6b9e3d8e7dff6","head":{"label":"XuHuaiyu:issue4848","ref":"issue4848","sha":"c4fd5c5cab5524b25f4b3d9ce4e6b9e3d8e7dff6","user":{"login":"XuHuaiyu","id":9039012,"avatar_url":"https://avatars1.githubusercontent.com/u/9039012?v=4","gravatar_id":"","url":"https://api.github.com/users/XuHuaiyu","html_url":"https://github.com/XuHuaiyu","followers_url":"https://api.github.com/users/XuHuaiyu/followers","following_url":"https://api.github.com/users/XuHuaiyu/following{/other_user}","gists_url":"https://api.github.com/users/XuHuaiyu/gists{/gist_id}","starred_url":"https://api.github.com/users/XuHuaiyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuHuaiyu/subscriptions","organizations_url":"https://api.github.com/users/XuHuaiyu/orgs","repos_url":"https://api.github.com/users/XuHuaiyu/repos","events_url":"https://api.github.com/users/XuHuaiyu/events{/privacy}","received_events_url":"https://api.github.com/users/XuHuaiyu/received_events","type":"User","site_admin":false},"repo":{"id":63865082,"name":"tidb","full_name":"XuHuaiyu/tidb","owner":{"login":"XuHuaiyu","id":9039012,"avatar_url":"https://avatars1.githubusercontent.com/u/9039012?v=4","gravatar_id":"","url":"https://api.github.com/users/XuHuaiyu","html_url":"https://github.com/XuHuaiyu","followers_url":"https://api.github.com/users/XuHuaiyu/followers","following_url":"https://api.github.com/users/XuHuaiyu/following{/other_user}","gists_url":"https://api.github.com/users/XuHuaiyu/gists{/gist_id}","starred_url":"https://api.github.com/users/XuHuaiyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuHuaiyu/subscriptions","organizations_url":"https://api.github.com/users/XuHuaiyu/orgs","repos_url":"https://api.github.com/users/XuHuaiyu/repos","events_url":"https://api.github.com/users/XuHuaiyu/events{/privacy}","received_events_url":"https://api.github.com/users/XuHuaiyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XuHuaiyu/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/XuHuaiyu/tidb","forks_url":"https://api.github.com/repos/XuHuaiyu/tidb/forks","keys_url":"https://api.github.com/repos/XuHuaiyu/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XuHuaiyu/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XuHuaiyu/tidb/teams","hooks_url":"https://api.github.com/repos/XuHuaiyu/tidb/hooks","issue_events_url":"https://api.github.com/repos/XuHuaiyu/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/XuHuaiyu/tidb/events","assignees_url":"https://api.github.com/repos/XuHuaiyu/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/XuHuaiyu/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/XuHuaiyu/tidb/tags","blobs_url":"https://api.github.com/repos/XuHuaiyu/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XuHuaiyu/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XuHuaiyu/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/XuHuaiyu/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XuHuaiyu/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/XuHuaiyu/tidb/languages","stargazers_url":"https://api.github.com/repos/XuHuaiyu/tidb/stargazers","contributors_url":"https://api.github.com/repos/XuHuaiyu/tidb/contributors","subscribers_url":"https://api.github.com/repos/XuHuaiyu/tidb/subscribers","subscription_url":"https://api.github.com/repos/XuHuaiyu/tidb/subscription","commits_url":"https://api.github.com/repos/XuHuaiyu/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/XuHuaiyu/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/XuHuaiyu/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/XuHuaiyu/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/XuHuaiyu/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/XuHuaiyu/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XuHuaiyu/tidb/merges","archive_url":"https://api.github.com/repos/XuHuaiyu/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XuHuaiyu/tidb/downloads","issues_url":"https://api.github.com/repos/XuHuaiyu/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/XuHuaiyu/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/XuHuaiyu/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/XuHuaiyu/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XuHuaiyu/tidb/labels{/name}","releases_url":"https://api.github.com/repos/XuHuaiyu/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/XuHuaiyu/tidb/deployments","created_at":"2016-07-21T11:50:49Z","updated_at":"2016-07-21T11:50:51Z","pushed_at":"2017-10-24T08:38:04Z","git_url":"git://github.com/XuHuaiyu/tidb.git","ssh_url":"git@github.com:XuHuaiyu/tidb.git","clone_url":"https://github.com/XuHuaiyu/tidb.git","svn_url":"https://github.com/XuHuaiyu/tidb","homepage":"","size":33827,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"0306bb007066a452da0e9802267344c742e93fbb","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-10-24T08:53:30Z","pushed_at":"2017-10-24T08:46:41Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":45080,"stargazers_count":10280,"watchers_count":10280,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1382,"mirror_url":null,"archived":false,"open_issues_count":353,"forks":1382,"open_issues":353,"watchers":10280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4879"},"html":{"href":"https://github.com/pingcap/tidb/pull/4879"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4879"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4879/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4879/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4879/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/c4fd5c5cab5524b25f4b3d9ce4e6b9e3d8e7dff6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zimulala"}}