{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/141823604","pull_request_review_id":66098065,"id":141823604,"diff_hunk":"@@ -0,0 +1,73 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<thing:thing-descriptions bindingId=\"elerotransmitterstick\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"","path":"addons/binding/org.openhab.binding.elerotransmitterstick/ESH-INF/thing/thing-types.xml","position":2,"original_position":2,"commit_id":"5bbf3ea4b67ba384cb3e19d15784822d2ee21aaa","original_commit_id":"5bbf3ea4b67ba384cb3e19d15784822d2ee21aaa","user":{"login":"triller-telekom","id":26876013,"avatar_url":"https://avatars3.githubusercontent.com/u/26876013?v=4","gravatar_id":"","url":"https://api.github.com/users/triller-telekom","html_url":"https://github.com/triller-telekom","followers_url":"https://api.github.com/users/triller-telekom/followers","following_url":"https://api.github.com/users/triller-telekom/following{/other_user}","gists_url":"https://api.github.com/users/triller-telekom/gists{/gist_id}","starred_url":"https://api.github.com/users/triller-telekom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triller-telekom/subscriptions","organizations_url":"https://api.github.com/users/triller-telekom/orgs","repos_url":"https://api.github.com/users/triller-telekom/repos","events_url":"https://api.github.com/users/triller-telekom/events{/privacy}","received_events_url":"https://api.github.com/users/triller-telekom/received_events","type":"User","site_admin":false},"body":"I thought about your modelling of things again and I do not like the way you are handling the elero-channelIDs...\r\n\r\nI propose that you change your model as follows:\r\n\r\n- have one bridge which is the stick with parameters `portName` and `updateInterval` (i.e. keep the one you have)\r\n- only have ONE thing-type `eleroThing` which has:\r\n-- a parameter (in a config-description) `channelIDs` which is set as \"multiple\" (see [here](https://www.eclipse.org/smarthome/documentation/development/bindings/xml-reference.html#xml-structure-for-configuration-descriptions)) containing the values 0 to 15.\r\n-- a channel group with your 2 channels `control` and `status`\r\n- drop the thing-type \"elerochannel\"\r\n\r\nThis is much cleaner than your solution because it has the relevant elero-channel-ID as a thing parameter and not in an array index or thing property where it doesn't belong. Also it saves you from parsing a comma separated string of channelIDs for your group because the parameter will be handed over to you as a list.","created_at":"2017-09-29T09:15:23Z","updated_at":"2017-09-29T09:15:39Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2659#discussion_r141823604","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/141823604"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2659#discussion_r141823604"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659","id":138828424,"html_url":"https://github.com/openhab/openhab2-addons/pull/2659","diff_url":"https://github.com/openhab/openhab2-addons/pull/2659.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2659.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2659","number":2659,"state":"open","locked":false,"title":"initial contribution of an Elero Transmitter Stick binding","user":{"login":"vbier","id":22752389,"avatar_url":"https://avatars0.githubusercontent.com/u/22752389?v=4","gravatar_id":"","url":"https://api.github.com/users/vbier","html_url":"https://github.com/vbier","followers_url":"https://api.github.com/users/vbier/followers","following_url":"https://api.github.com/users/vbier/following{/other_user}","gists_url":"https://api.github.com/users/vbier/gists{/gist_id}","starred_url":"https://api.github.com/users/vbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbier/subscriptions","organizations_url":"https://api.github.com/users/vbier/orgs","repos_url":"https://api.github.com/users/vbier/repos","events_url":"https://api.github.com/users/vbier/events{/privacy}","received_events_url":"https://api.github.com/users/vbier/received_events","type":"User","site_admin":false},"body":"This adds support for Elero Transmitter Sticks which allow to control blinds and rollershutters from Elero (and compatible hardware from other manufacturers like Weinor).\r\n\r\nSigned-off-by: Volker Bier volker.bier@web.de","created_at":"2017-09-01T07:10:12Z","updated_at":"2017-09-29T09:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f278227f7708937c02355358deddba98b8ebb0f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2659/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/5bbf3ea4b67ba384cb3e19d15784822d2ee21aaa","head":{"label":"vbier:elerostick","ref":"elerostick","sha":"5bbf3ea4b67ba384cb3e19d15784822d2ee21aaa","user":{"login":"vbier","id":22752389,"avatar_url":"https://avatars0.githubusercontent.com/u/22752389?v=4","gravatar_id":"","url":"https://api.github.com/users/vbier","html_url":"https://github.com/vbier","followers_url":"https://api.github.com/users/vbier/followers","following_url":"https://api.github.com/users/vbier/following{/other_user}","gists_url":"https://api.github.com/users/vbier/gists{/gist_id}","starred_url":"https://api.github.com/users/vbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbier/subscriptions","organizations_url":"https://api.github.com/users/vbier/orgs","repos_url":"https://api.github.com/users/vbier/repos","events_url":"https://api.github.com/users/vbier/events{/privacy}","received_events_url":"https://api.github.com/users/vbier/received_events","type":"User","site_admin":false},"repo":{"id":70514010,"name":"openhab2-addons","full_name":"vbier/openhab2-addons","owner":{"login":"vbier","id":22752389,"avatar_url":"https://avatars0.githubusercontent.com/u/22752389?v=4","gravatar_id":"","url":"https://api.github.com/users/vbier","html_url":"https://github.com/vbier","followers_url":"https://api.github.com/users/vbier/followers","following_url":"https://api.github.com/users/vbier/following{/other_user}","gists_url":"https://api.github.com/users/vbier/gists{/gist_id}","starred_url":"https://api.github.com/users/vbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbier/subscriptions","organizations_url":"https://api.github.com/users/vbier/orgs","repos_url":"https://api.github.com/users/vbier/repos","events_url":"https://api.github.com/users/vbier/events{/privacy}","received_events_url":"https://api.github.com/users/vbier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbier/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/vbier/openhab2-addons","forks_url":"https://api.github.com/repos/vbier/openhab2-addons/forks","keys_url":"https://api.github.com/repos/vbier/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbier/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbier/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/vbier/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/vbier/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/vbier/openhab2-addons/events","assignees_url":"https://api.github.com/repos/vbier/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/vbier/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/vbier/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/vbier/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbier/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbier/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbier/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbier/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/vbier/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/vbier/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/vbier/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/vbier/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/vbier/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/vbier/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbier/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbier/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbier/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbier/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/vbier/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbier/openhab2-addons/merges","archive_url":"https://api.github.com/repos/vbier/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbier/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/vbier/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/vbier/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/vbier/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/vbier/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbier/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/vbier/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/vbier/openhab2-addons/deployments","created_at":"2016-10-10T17:52:44Z","updated_at":"2017-07-08T13:50:38Z","pushed_at":"2017-09-24T09:56:50Z","git_url":"git://github.com/vbier/openhab2-addons.git","ssh_url":"git@github.com:vbier/openhab2-addons.git","clone_url":"https://github.com/vbier/openhab2-addons.git","svn_url":"https://github.com/vbier/openhab2-addons","homepage":null,"size":83542,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"0cdadafe6baef8314b50fb830d9b85bb4d96a8d0","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2017-09-27T06:11:01Z","pushed_at":"2017-09-28T22:11:10Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":258980,"stargazers_count":655,"watchers_count":655,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1142,"mirror_url":null,"open_issues_count":340,"forks":1142,"open_issues":340,"watchers":655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2659"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2659"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2659/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2659/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/5bbf3ea4b67ba384cb3e19d15784822d2ee21aaa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"triller-telekom"}}