{"action":"created","issue":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9306","repository_url":"https://api.github.com/repos/qooxdoo/qooxdoo","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9306/labels{/name}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9306/comments","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9306/events","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9306","id":216959863,"number":9306,"title":"Issue #9303: Improve mouse wheel normalization code to adjust scrolling sensitivity for touchpads","user":{"login":"vvandens","id":832886,"avatar_url":"https://avatars2.githubusercontent.com/u/832886?v=3","gravatar_id":"","url":"https://api.github.com/users/vvandens","html_url":"https://github.com/vvandens","followers_url":"https://api.github.com/users/vvandens/followers","following_url":"https://api.github.com/users/vvandens/following{/other_user}","gists_url":"https://api.github.com/users/vvandens/gists{/gist_id}","starred_url":"https://api.github.com/users/vvandens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvandens/subscriptions","organizations_url":"https://api.github.com/users/vvandens/orgs","repos_url":"https://api.github.com/users/vvandens/repos","events_url":"https://api.github.com/users/vvandens/events{/privacy}","received_events_url":"https://api.github.com/users/vvandens/received_events","type":"User","site_admin":false},"labels":[{"id":369678733,"url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels/C:core.event","name":"C:core.event","color":"ffe502","default":false},{"id":346854769,"url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels/enhancement","name":"enhancement","color":"207de5","default":true},{"id":447403994,"url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels/OS:MacOS","name":"OS:MacOS","color":"c5def5","default":false},{"id":423628277,"url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels/VOTING","name":"VOTING","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-25T08:32:01Z","updated_at":"2017-03-28T18:27:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9306","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9306","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9306.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9306.patch"},"body":"- Touch pad detection limited to Mac OS after Sierra (>= 10.12). But still don't know if other combinations should be included.\r\n\r\n- Events occurring during detection are now buffered and scheduled for fire after the detection period ends if no other wheel events come. This will prevent single wheel events to be swallowed and physical wheels to seem broken.\r\n\r\n- If a touch pad is detected, the delta normalization code is ignored and a factor of 1 is applied to the delta of the DOM event. This lets the native delta computation happen. My understanding is that the `qx.util.Wheel.FACTOR` should not be used for the Macbook trackpad (and for others ?). It is computed (and reduced) everytime the `qx.util.Wheel.MAXSCROLL` increases. And it is *one way only*. If a user swipes fast, then the `MAXSCROLL` increases a lot and the `FACTOR` decreases a lot which makes the scrolling sensitivity of the trackpad lowered a lot for the whole session. There is no way to come back. I think this computation is certainly useful for fixed-delta physical wheels, but cannot be applied when the delta varies.\r\n\r\n- Constants have been reviewed. The TOUCHPAD_WHEEL_EVENTS_TIMEOUT has been set to 5s in order to trigger a new detection process.\r\n\r\n- A new qx.core.Environment entry (qx.debug.touchpad.detection) has been  added to print touchpad debug messages. It is set to false by default.\r\n\r\nSince the code is now limited to Mac OS Sierra and above, it wont happen obviously on other platforms. However, I still don't know if this should not be more largely applied (I think so actually). In order to remove the platform limitation for a test, just patch the new method `qx.event.handler.GestureCore._isTouchPadDetectionEnabled` to return true."},"comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments/289861440","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9306#issuecomment-289861440","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9306","id":289861440,"user":{"login":"vvandens","id":832886,"avatar_url":"https://avatars2.githubusercontent.com/u/832886?v=3","gravatar_id":"","url":"https://api.github.com/users/vvandens","html_url":"https://github.com/vvandens","followers_url":"https://api.github.com/users/vvandens/followers","following_url":"https://api.github.com/users/vvandens/following{/other_user}","gists_url":"https://api.github.com/users/vvandens/gists{/gist_id}","starred_url":"https://api.github.com/users/vvandens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvandens/subscriptions","organizations_url":"https://api.github.com/users/vvandens/orgs","repos_url":"https://api.github.com/users/vvandens/repos","events_url":"https://api.github.com/users/vvandens/events{/privacy}","received_events_url":"https://api.github.com/users/vvandens/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T18:27:12Z","updated_at":"2017-03-28T18:27:12Z","body":"I've just added a commit that includes all the requested changes by @derrell and @level420 "}}
{"actor":{"display_login":"vvandens"}}