{"action":"opened","number":710,"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710","id":137587562,"html_url":"https://github.com/smartdevicelink/sdl_ios/pull/710","diff_url":"https://github.com/smartdevicelink/sdl_ios/pull/710.diff","patch_url":"https://github.com/smartdevicelink/sdl_ios/pull/710.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/710","number":710,"state":"open","locked":false,"title":"#382 Timers are not appropriately stopped when deallocated.","user":{"login":"cromotron","id":2170584,"avatar_url":"https://avatars3.githubusercontent.com/u/2170584?v=4","gravatar_id":"","url":"https://api.github.com/users/cromotron","html_url":"https://github.com/cromotron","followers_url":"https://api.github.com/users/cromotron/followers","following_url":"https://api.github.com/users/cromotron/following{/other_user}","gists_url":"https://api.github.com/users/cromotron/gists{/gist_id}","starred_url":"https://api.github.com/users/cromotron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromotron/subscriptions","organizations_url":"https://api.github.com/users/cromotron/orgs","repos_url":"https://api.github.com/users/cromotron/repos","events_url":"https://api.github.com/users/cromotron/events{/privacy}","received_events_url":"https://api.github.com/users/cromotron/received_events","type":"User","site_admin":false},"body":"Fixes #382\r\n\r\nThis PR is ready for review.\r\n\r\n### Risk\r\nThis PR makes no API changes.\r\n\r\n### Summary\r\nNSTimer has a strong reference to its target, therefore the SDLTimer never gets release and dealloc isn’t called.\r\nI eliminated the deadlock by adding a separate target.\r\n\r\n##### Enhancements\r\nTimer is stopped when the reference to the SDLTimer is set to nil\r\n\r\n##### Bug Fixes\r\nTimers are not appropriately stopped when deallocated.\r\n\r\n### CLA\r\n- [X] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)\r\n","created_at":"2017-08-25T02:13:35Z","updated_at":"2017-08-25T02:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/710/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/e76d8ba9f9871030e4cb6b090b9f33529dba5e41","head":{"label":"cromotron:bugfix/issue_382_timer_is_not_deallocated","ref":"bugfix/issue_382_timer_is_not_deallocated","sha":"e76d8ba9f9871030e4cb6b090b9f33529dba5e41","user":{"login":"cromotron","id":2170584,"avatar_url":"https://avatars3.githubusercontent.com/u/2170584?v=4","gravatar_id":"","url":"https://api.github.com/users/cromotron","html_url":"https://github.com/cromotron","followers_url":"https://api.github.com/users/cromotron/followers","following_url":"https://api.github.com/users/cromotron/following{/other_user}","gists_url":"https://api.github.com/users/cromotron/gists{/gist_id}","starred_url":"https://api.github.com/users/cromotron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromotron/subscriptions","organizations_url":"https://api.github.com/users/cromotron/orgs","repos_url":"https://api.github.com/users/cromotron/repos","events_url":"https://api.github.com/users/cromotron/events{/privacy}","received_events_url":"https://api.github.com/users/cromotron/received_events","type":"User","site_admin":false},"repo":{"id":101342270,"name":"sdl_ios","full_name":"cromotron/sdl_ios","owner":{"login":"cromotron","id":2170584,"avatar_url":"https://avatars3.githubusercontent.com/u/2170584?v=4","gravatar_id":"","url":"https://api.github.com/users/cromotron","html_url":"https://github.com/cromotron","followers_url":"https://api.github.com/users/cromotron/followers","following_url":"https://api.github.com/users/cromotron/following{/other_user}","gists_url":"https://api.github.com/users/cromotron/gists{/gist_id}","starred_url":"https://api.github.com/users/cromotron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromotron/subscriptions","organizations_url":"https://api.github.com/users/cromotron/orgs","repos_url":"https://api.github.com/users/cromotron/repos","events_url":"https://api.github.com/users/cromotron/events{/privacy}","received_events_url":"https://api.github.com/users/cromotron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cromotron/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":true,"url":"https://api.github.com/repos/cromotron/sdl_ios","forks_url":"https://api.github.com/repos/cromotron/sdl_ios/forks","keys_url":"https://api.github.com/repos/cromotron/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cromotron/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cromotron/sdl_ios/teams","hooks_url":"https://api.github.com/repos/cromotron/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/cromotron/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/cromotron/sdl_ios/events","assignees_url":"https://api.github.com/repos/cromotron/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/cromotron/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/cromotron/sdl_ios/tags","blobs_url":"https://api.github.com/repos/cromotron/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cromotron/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cromotron/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/cromotron/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cromotron/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/cromotron/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/cromotron/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/cromotron/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/cromotron/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/cromotron/sdl_ios/subscription","commits_url":"https://api.github.com/repos/cromotron/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/cromotron/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/cromotron/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/cromotron/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/cromotron/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/cromotron/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cromotron/sdl_ios/merges","archive_url":"https://api.github.com/repos/cromotron/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cromotron/sdl_ios/downloads","issues_url":"https://api.github.com/repos/cromotron/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/cromotron/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/cromotron/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/cromotron/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cromotron/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/cromotron/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/cromotron/sdl_ios/deployments","created_at":"2017-08-24T22:21:30Z","updated_at":"2017-08-24T22:21:33Z","pushed_at":"2017-08-25T01:37:35Z","git_url":"git://github.com/cromotron/sdl_ios.git","ssh_url":"git@github.com:cromotron/sdl_ios.git","clone_url":"https://github.com/cromotron/sdl_ios.git","svn_url":"https://github.com/cromotron/sdl_ios","homepage":"www.smartdevicelink.com","size":25983,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"c2efbea5fba8344406956fa3f02d5fb67537b672","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2017-08-17T08:54:53Z","pushed_at":"2017-08-24T19:35:59Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"git@github.com:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":25963,"stargazers_count":85,"watchers_count":85,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":60,"forks":53,"open_issues":60,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/710"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/710"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/e76d8ba9f9871030e4cb6b090b9f33529dba5e41"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":33,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"cromotron"}}