{"action":"created","comment":{"url":"https://api.github.com/repos/dssg/collate/pulls/comments/116811674","pull_request_review_id":38462941,"id":116811674,"diff_hunk":"@@ -7,6 +7,23 @@\n from .sql import make_sql_clause, to_sql_name, CreateTableAs, InsertFromSelect\n \n \n+def execute_insert(get_engine, insert):","path":"collate/collate.py","position":null,"original_position":4,"commit_id":"661d32caef2ea05c2a8a6fad8a785afcf397da27","original_commit_id":"c5d07919561bc29d3a9a15eda3c24760b6a917e5","user":{"login":"kenben","id":1703541,"avatar_url":"https://avatars3.githubusercontent.com/u/1703541?v=3","gravatar_id":"","url":"https://api.github.com/users/kenben","html_url":"https://github.com/kenben","followers_url":"https://api.github.com/users/kenben/followers","following_url":"https://api.github.com/users/kenben/following{/other_user}","gists_url":"https://api.github.com/users/kenben/gists{/gist_id}","starred_url":"https://api.github.com/users/kenben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenben/subscriptions","organizations_url":"https://api.github.com/users/kenben/orgs","repos_url":"https://api.github.com/users/kenben/repos","events_url":"https://api.github.com/users/kenben/events{/privacy}","received_events_url":"https://api.github.com/users/kenben/received_events","type":"User","site_admin":false},"body":"Moved this.","created_at":"2017-05-16T17:49:50Z","updated_at":"2017-05-16T17:49:50Z","html_url":"https://github.com/dssg/collate/pull/87#discussion_r116811674","pull_request_url":"https://api.github.com/repos/dssg/collate/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/dssg/collate/pulls/comments/116811674"},"html":{"href":"https://github.com/dssg/collate/pull/87#discussion_r116811674"},"pull_request":{"href":"https://api.github.com/repos/dssg/collate/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/dssg/collate/pulls/87","id":120690894,"html_url":"https://github.com/dssg/collate/pull/87","diff_url":"https://github.com/dssg/collate/pull/87.diff","patch_url":"https://github.com/dssg/collate/pull/87.patch","issue_url":"https://api.github.com/repos/dssg/collate/issues/87","number":87,"state":"open","locked":false,"title":"move execute_insert to top module nesting so pickle does not err","user":{"login":"kenben","id":1703541,"avatar_url":"https://avatars3.githubusercontent.com/u/1703541?v=3","gravatar_id":"","url":"https://api.github.com/users/kenben","html_url":"https://github.com/kenben","followers_url":"https://api.github.com/users/kenben/followers","following_url":"https://api.github.com/users/kenben/following{/other_user}","gists_url":"https://api.github.com/users/kenben/gists{/gist_id}","starred_url":"https://api.github.com/users/kenben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenben/subscriptions","organizations_url":"https://api.github.com/users/kenben/orgs","repos_url":"https://api.github.com/users/kenben/repos","events_url":"https://api.github.com/users/kenben/events{/privacy}","received_events_url":"https://api.github.com/users/kenben/received_events","type":"User","site_admin":false},"body":"I got a `pickle.PicklingError: Can't pickle <function Aggregation.execute_insert at [...]>`; moving the `execute_insert` out of the Class makes it OK to pickle.","created_at":"2017-05-15T20:46:58Z","updated_at":"2017-05-16T17:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf4d33a6e6dc56069805398f17017e90a6b4ba7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dssg/collate/pulls/87/commits","review_comments_url":"https://api.github.com/repos/dssg/collate/pulls/87/comments","review_comment_url":"https://api.github.com/repos/dssg/collate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dssg/collate/issues/87/comments","statuses_url":"https://api.github.com/repos/dssg/collate/statuses/661d32caef2ea05c2a8a6fad8a785afcf397da27","head":{"label":"dssg:ka/parallel_pickle_error","ref":"ka/parallel_pickle_error","sha":"661d32caef2ea05c2a8a6fad8a785afcf397da27","user":{"login":"dssg","id":3827384,"avatar_url":"https://avatars2.githubusercontent.com/u/3827384?v=3","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"repo":{"id":71167444,"name":"collate","full_name":"dssg/collate","owner":{"login":"dssg","id":3827384,"avatar_url":"https://avatars2.githubusercontent.com/u/3827384?v=3","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dssg/collate","description":"Aggregation SQL Query Builder","fork":false,"url":"https://api.github.com/repos/dssg/collate","forks_url":"https://api.github.com/repos/dssg/collate/forks","keys_url":"https://api.github.com/repos/dssg/collate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dssg/collate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dssg/collate/teams","hooks_url":"https://api.github.com/repos/dssg/collate/hooks","issue_events_url":"https://api.github.com/repos/dssg/collate/issues/events{/number}","events_url":"https://api.github.com/repos/dssg/collate/events","assignees_url":"https://api.github.com/repos/dssg/collate/assignees{/user}","branches_url":"https://api.github.com/repos/dssg/collate/branches{/branch}","tags_url":"https://api.github.com/repos/dssg/collate/tags","blobs_url":"https://api.github.com/repos/dssg/collate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dssg/collate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dssg/collate/git/refs{/sha}","trees_url":"https://api.github.com/repos/dssg/collate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dssg/collate/statuses/{sha}","languages_url":"https://api.github.com/repos/dssg/collate/languages","stargazers_url":"https://api.github.com/repos/dssg/collate/stargazers","contributors_url":"https://api.github.com/repos/dssg/collate/contributors","subscribers_url":"https://api.github.com/repos/dssg/collate/subscribers","subscription_url":"https://api.github.com/repos/dssg/collate/subscription","commits_url":"https://api.github.com/repos/dssg/collate/commits{/sha}","git_commits_url":"https://api.github.com/repos/dssg/collate/git/commits{/sha}","comments_url":"https://api.github.com/repos/dssg/collate/comments{/number}","issue_comment_url":"https://api.github.com/repos/dssg/collate/issues/comments{/number}","contents_url":"https://api.github.com/repos/dssg/collate/contents/{+path}","compare_url":"https://api.github.com/repos/dssg/collate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dssg/collate/merges","archive_url":"https://api.github.com/repos/dssg/collate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dssg/collate/downloads","issues_url":"https://api.github.com/repos/dssg/collate/issues{/number}","pulls_url":"https://api.github.com/repos/dssg/collate/pulls{/number}","milestones_url":"https://api.github.com/repos/dssg/collate/milestones{/number}","notifications_url":"https://api.github.com/repos/dssg/collate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dssg/collate/labels{/name}","releases_url":"https://api.github.com/repos/dssg/collate/releases{/id}","deployments_url":"https://api.github.com/repos/dssg/collate/deployments","created_at":"2016-10-17T18:14:02Z","updated_at":"2016-10-25T21:14:03Z","pushed_at":"2017-05-16T17:45:29Z","git_url":"git://github.com/dssg/collate.git","ssh_url":"git@github.com:dssg/collate.git","clone_url":"https://github.com/dssg/collate.git","svn_url":"https://github.com/dssg/collate","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"dssg:ka/parallel","ref":"ka/parallel","sha":"fed96cefed6983b0075482d421a6c481dd4229ff","user":{"login":"dssg","id":3827384,"avatar_url":"https://avatars2.githubusercontent.com/u/3827384?v=3","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"repo":{"id":71167444,"name":"collate","full_name":"dssg/collate","owner":{"login":"dssg","id":3827384,"avatar_url":"https://avatars2.githubusercontent.com/u/3827384?v=3","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dssg/collate","description":"Aggregation SQL Query Builder","fork":false,"url":"https://api.github.com/repos/dssg/collate","forks_url":"https://api.github.com/repos/dssg/collate/forks","keys_url":"https://api.github.com/repos/dssg/collate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dssg/collate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dssg/collate/teams","hooks_url":"https://api.github.com/repos/dssg/collate/hooks","issue_events_url":"https://api.github.com/repos/dssg/collate/issues/events{/number}","events_url":"https://api.github.com/repos/dssg/collate/events","assignees_url":"https://api.github.com/repos/dssg/collate/assignees{/user}","branches_url":"https://api.github.com/repos/dssg/collate/branches{/branch}","tags_url":"https://api.github.com/repos/dssg/collate/tags","blobs_url":"https://api.github.com/repos/dssg/collate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dssg/collate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dssg/collate/git/refs{/sha}","trees_url":"https://api.github.com/repos/dssg/collate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dssg/collate/statuses/{sha}","languages_url":"https://api.github.com/repos/dssg/collate/languages","stargazers_url":"https://api.github.com/repos/dssg/collate/stargazers","contributors_url":"https://api.github.com/repos/dssg/collate/contributors","subscribers_url":"https://api.github.com/repos/dssg/collate/subscribers","subscription_url":"https://api.github.com/repos/dssg/collate/subscription","commits_url":"https://api.github.com/repos/dssg/collate/commits{/sha}","git_commits_url":"https://api.github.com/repos/dssg/collate/git/commits{/sha}","comments_url":"https://api.github.com/repos/dssg/collate/comments{/number}","issue_comment_url":"https://api.github.com/repos/dssg/collate/issues/comments{/number}","contents_url":"https://api.github.com/repos/dssg/collate/contents/{+path}","compare_url":"https://api.github.com/repos/dssg/collate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dssg/collate/merges","archive_url":"https://api.github.com/repos/dssg/collate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dssg/collate/downloads","issues_url":"https://api.github.com/repos/dssg/collate/issues{/number}","pulls_url":"https://api.github.com/repos/dssg/collate/pulls{/number}","milestones_url":"https://api.github.com/repos/dssg/collate/milestones{/number}","notifications_url":"https://api.github.com/repos/dssg/collate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dssg/collate/labels{/name}","releases_url":"https://api.github.com/repos/dssg/collate/releases{/id}","deployments_url":"https://api.github.com/repos/dssg/collate/deployments","created_at":"2016-10-17T18:14:02Z","updated_at":"2016-10-25T21:14:03Z","pushed_at":"2017-05-16T17:45:29Z","git_url":"git://github.com/dssg/collate.git","ssh_url":"git@github.com:dssg/collate.git","clone_url":"https://github.com/dssg/collate.git","svn_url":"https://github.com/dssg/collate","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dssg/collate/pulls/87"},"html":{"href":"https://github.com/dssg/collate/pull/87"},"issue":{"href":"https://api.github.com/repos/dssg/collate/issues/87"},"comments":{"href":"https://api.github.com/repos/dssg/collate/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/dssg/collate/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/dssg/collate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dssg/collate/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/dssg/collate/statuses/661d32caef2ea05c2a8a6fad8a785afcf397da27"}}}}
{"actor":{"display_login":"kenben"}}