{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/106789413","pull_request_review_id":27732613,"id":106789413,"diff_hunk":"@@ -73,22 +75,32 @@ public IEnumerable<IOrderTargeter> Orders\n \t\tpublic Order IssueOrder(Actor self, IOrderTargeter order, Target target, bool queued)\n \t\t{\n \t\t\tif (order.OrderID == \"SetRallyPoint\")\n-\t\t\t\treturn new Order(order.OrderID, self, false) { TargetLocation = self.World.Map.CellContaining(target.CenterPosition), SuppressVisualFeedback = true };\n+\t\t\t\treturn new Order(order.OrderID, self, false) { TargetLocation = self.World.Map.CellContaining(target.CenterPosition), SuppressVisualFeedback = true,\n+\t\t\t\t\tExtraData = ((RallyPointOrderTargeter)order).SetPrimaryBuilding ? ExtraDataSetPrimaryBuilding : 0 };\n \n \t\t\treturn null;\n \t\t}\n \n \t\tpublic void ResolveOrder(Actor self, Order order)\n \t\t{\n \t\t\tif (order.OrderString == \"SetRallyPoint\")\n+\t\t\t{\n \t\t\t\tLocation = order.TargetLocation;\n+\t\t\t\tif (order.ExtraData == ExtraDataSetPrimaryBuilding)\n+\t\t\t\t{\n+\t\t\t\t\tvar primaryBuildingTrait = self.TraitOrDefault<PrimaryBuilding>();","path":"OpenRA.Mods.Common/Traits/Buildings/RallyPoint.cs","position":27,"original_position":27,"commit_id":"5f3a596742cc259857ce99ea4851836b3a621a43","original_commit_id":"5f3a596742cc259857ce99ea4851836b3a621a43","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars2.githubusercontent.com/u/167819?v=3","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"The benefit of this approach is that other mods that don't use `PrimaryBuilding` can attach their own special behaviour to the force-set command if they want to.  e.g. setting the rally point for all production structures.","created_at":"2017-03-18T19:49:57Z","updated_at":"2017-03-18T19:49:57Z","html_url":"https://github.com/OpenRA/OpenRA/pull/12977#discussion_r106789413","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/106789413"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/12977#discussion_r106789413"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977","id":111263777,"html_url":"https://github.com/OpenRA/OpenRA/pull/12977","diff_url":"https://github.com/OpenRA/OpenRA/pull/12977.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/12977.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/12977","number":12977,"state":"open","locked":false,"title":"When changing rally point also make primary #12855","user":{"login":"rob-v","id":16348750,"avatar_url":"https://avatars0.githubusercontent.com/u/16348750?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-v","html_url":"https://github.com/rob-v","followers_url":"https://api.github.com/users/rob-v/followers","following_url":"https://api.github.com/users/rob-v/following{/other_user}","gists_url":"https://api.github.com/users/rob-v/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-v/subscriptions","organizations_url":"https://api.github.com/users/rob-v/orgs","repos_url":"https://api.github.com/users/rob-v/repos","events_url":"https://api.github.com/users/rob-v/events{/privacy}","received_events_url":"https://api.github.com/users/rob-v/received_events","type":"User","site_admin":false},"body":"Set PrimaryBuilding together with RallyPoint when Ctrl is pressed for each building which is the only selected building of that type. Ctrl is optional, could be removed to set PrimaryBuilding.\r\n\r\nBarracks + Light factory, Ctrl+Right click = RallyPoint + PrimaryBuilding\r\n\r\n![rallypointwithprimarybuilding](https://cloud.githubusercontent.com/assets/16348750/24041726/fbc08714-0b0e-11e7-910c-f92842d8723c.jpg)\r\n\r\n2 Barracks = only RallyPoint\r\n\r\n","created_at":"2017-03-17T11:39:31Z","updated_at":"2017-03-18T19:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac59e9d9d5734bddd45b98f7ba4f154269423513","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/12977/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/5f3a596742cc259857ce99ea4851836b3a621a43","head":{"label":"rob-v:RallyPointPrimaryBuilding","ref":"RallyPointPrimaryBuilding","sha":"5f3a596742cc259857ce99ea4851836b3a621a43","user":{"login":"rob-v","id":16348750,"avatar_url":"https://avatars0.githubusercontent.com/u/16348750?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-v","html_url":"https://github.com/rob-v","followers_url":"https://api.github.com/users/rob-v/followers","following_url":"https://api.github.com/users/rob-v/following{/other_user}","gists_url":"https://api.github.com/users/rob-v/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-v/subscriptions","organizations_url":"https://api.github.com/users/rob-v/orgs","repos_url":"https://api.github.com/users/rob-v/repos","events_url":"https://api.github.com/users/rob-v/events{/privacy}","received_events_url":"https://api.github.com/users/rob-v/received_events","type":"User","site_admin":false},"repo":{"id":85210650,"name":"OpenRA","full_name":"rob-v/OpenRA","owner":{"login":"rob-v","id":16348750,"avatar_url":"https://avatars0.githubusercontent.com/u/16348750?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-v","html_url":"https://github.com/rob-v","followers_url":"https://api.github.com/users/rob-v/followers","following_url":"https://api.github.com/users/rob-v/following{/other_user}","gists_url":"https://api.github.com/users/rob-v/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-v/subscriptions","organizations_url":"https://api.github.com/users/rob-v/orgs","repos_url":"https://api.github.com/users/rob-v/repos","events_url":"https://api.github.com/users/rob-v/events{/privacy}","received_events_url":"https://api.github.com/users/rob-v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rob-v/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/rob-v/OpenRA","forks_url":"https://api.github.com/repos/rob-v/OpenRA/forks","keys_url":"https://api.github.com/repos/rob-v/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rob-v/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rob-v/OpenRA/teams","hooks_url":"https://api.github.com/repos/rob-v/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/rob-v/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/rob-v/OpenRA/events","assignees_url":"https://api.github.com/repos/rob-v/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/rob-v/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/rob-v/OpenRA/tags","blobs_url":"https://api.github.com/repos/rob-v/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rob-v/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rob-v/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/rob-v/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rob-v/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/rob-v/OpenRA/languages","stargazers_url":"https://api.github.com/repos/rob-v/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/rob-v/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/rob-v/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/rob-v/OpenRA/subscription","commits_url":"https://api.github.com/repos/rob-v/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/rob-v/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/rob-v/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/rob-v/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/rob-v/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/rob-v/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rob-v/OpenRA/merges","archive_url":"https://api.github.com/repos/rob-v/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rob-v/OpenRA/downloads","issues_url":"https://api.github.com/repos/rob-v/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/rob-v/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/rob-v/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/rob-v/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rob-v/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/rob-v/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/rob-v/OpenRA/deployments","created_at":"2017-03-16T15:19:28Z","updated_at":"2017-03-16T15:19:38Z","pushed_at":"2017-03-18T19:17:19Z","git_url":"git://github.com/rob-v/OpenRA.git","ssh_url":"git@github.com:rob-v/OpenRA.git","clone_url":"https://github.com/rob-v/OpenRA.git","svn_url":"https://github.com/rob-v/OpenRA","homepage":"http://www.openra.net","size":114490,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"eb77c57ac305498684d086adc737154e8f763356","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars3.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars3.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2017-03-17T20:55:07Z","pushed_at":"2017-03-18T19:16:46Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":114479,"stargazers_count":3862,"watchers_count":3862,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1257,"mirror_url":null,"open_issues_count":1149,"forks":1257,"open_issues":1149,"watchers":3862,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/12977"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/12977"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/12977/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/12977/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/5f3a596742cc259857ce99ea4851836b3a621a43"}}}}
{"actor":{"display_login":"pchote"}}