{"action":"created","issue":{"url":"https://api.github.com/repos/smeighan/xLights/issues/921","repository_url":"https://api.github.com/repos/smeighan/xLights","labels_url":"https://api.github.com/repos/smeighan/xLights/issues/921/labels{/name}","comments_url":"https://api.github.com/repos/smeighan/xLights/issues/921/comments","events_url":"https://api.github.com/repos/smeighan/xLights/issues/921/events","html_url":"https://github.com/smeighan/xLights/pull/921","id":259244791,"number":921,"title":"Enhanced the Wave Effect, such that the \"Y Position\" of the wave is animateable","user":{"login":"davidmpeace","id":2800023,"avatar_url":"https://avatars1.githubusercontent.com/u/2800023?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmpeace","html_url":"https://github.com/davidmpeace","followers_url":"https://api.github.com/users/davidmpeace/followers","following_url":"https://api.github.com/users/davidmpeace/following{/other_user}","gists_url":"https://api.github.com/users/davidmpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmpeace/subscriptions","organizations_url":"https://api.github.com/users/davidmpeace/orgs","repos_url":"https://api.github.com/users/davidmpeace/repos","events_url":"https://api.github.com/users/davidmpeace/events{/privacy}","received_events_url":"https://api.github.com/users/davidmpeace/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-20T17:39:00Z","updated_at":"2017-09-20T17:58:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/smeighan/xLights/pulls/921","html_url":"https://github.com/smeighan/xLights/pull/921","diff_url":"https://github.com/smeighan/xLights/pull/921.diff","patch_url":"https://github.com/smeighan/xLights/pull/921.patch"},"body":"I needed the Wave effect to raise up from the bottom for my sequence, so I decided to update the code to support this.  I added a new animateable property to the wave effect called \"Y Position\"\r\n\r\nThis is my first pull request for X Lights, so if I did something out of process, please let me know."},"comment":{"url":"https://api.github.com/repos/smeighan/xLights/issues/comments/330931552","html_url":"https://github.com/smeighan/xLights/pull/921#issuecomment-330931552","issue_url":"https://api.github.com/repos/smeighan/xLights/issues/921","id":330931552,"user":{"login":"AzGilrock","id":2024669,"avatar_url":"https://avatars0.githubusercontent.com/u/2024669?v=4","gravatar_id":"","url":"https://api.github.com/users/AzGilrock","html_url":"https://github.com/AzGilrock","followers_url":"https://api.github.com/users/AzGilrock/followers","following_url":"https://api.github.com/users/AzGilrock/following{/other_user}","gists_url":"https://api.github.com/users/AzGilrock/gists{/gist_id}","starred_url":"https://api.github.com/users/AzGilrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzGilrock/subscriptions","organizations_url":"https://api.github.com/users/AzGilrock/orgs","repos_url":"https://api.github.com/users/AzGilrock/repos","events_url":"https://api.github.com/users/AzGilrock/events{/privacy}","received_events_url":"https://api.github.com/users/AzGilrock/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T17:58:34Z","updated_at":"2017-09-20T17:58:34Z","author_association":"COLLABORATOR","body":"I'm thinking it would be better to make the range of the slider go from -250 to +250 and then turn that into the percentage.  That way if down the road we decide to make it -300 to +300 it won't impact existing sequences.  If we later wanted to change the 2.5 multiplier to 3.0 you would have to do conversions on all the existing sequences."}}
{"actor":{"display_login":"AzGilrock"}}