{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8654","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8654/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8654/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8654/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/8654","id":219694228,"number":8654,"title":"Respect 'base' in composite functions","user":{"login":"anandthakker","id":4974151,"avatar_url":"https://avatars0.githubusercontent.com/u/4974151?v=3","gravatar_id":"","url":"https://api.github.com/users/anandthakker","html_url":"https://github.com/anandthakker","followers_url":"https://api.github.com/users/anandthakker/followers","following_url":"https://api.github.com/users/anandthakker/following{/other_user}","gists_url":"https://api.github.com/users/anandthakker/gists{/gist_id}","starred_url":"https://api.github.com/users/anandthakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandthakker/subscriptions","organizations_url":"https://api.github.com/users/anandthakker/orgs","repos_url":"https://api.github.com/users/anandthakker/repos","events_url":"https://api.github.com/users/anandthakker/events{/privacy}","received_events_url":"https://api.github.com/users/anandthakker/received_events","type":"User","site_admin":false},"labels":[{"id":352634063,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Core%20GL","name":"Core GL","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-05T19:45:54Z","updated_at":"2017-04-05T20:22:19Z","closed_at":null,"body":"In GL JS, we use the `base` property to interpolate the zoom component of composite functions of all types (not just for `type: exponential`).  [Ref](https://github.com/mapbox/mapbox-gl-js/blob/a73a85b06b21b23814d30ca434b94040e9f26bb8/src/style-spec/function/index.js#L124)\r\n\r\nHere, it looks like we [always assume a base of `1.0f`](https://github.com/mapbox/mapbox-gl-native/blob/master/include/mbgl/style/function/composite_function.hpp#L109)\r\n\r\nFor consistency with GL JS, we should include a `base` property on each `Composite*Stops<T>` type--or maybe as a member of the function itself? I'm not sure--and use when we compute the interpolation factor."},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/291985379","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/8654#issuecomment-291985379","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8654","id":291985379,"user":{"login":"anandthakker","id":4974151,"avatar_url":"https://avatars0.githubusercontent.com/u/4974151?v=3","gravatar_id":"","url":"https://api.github.com/users/anandthakker","html_url":"https://github.com/anandthakker","followers_url":"https://api.github.com/users/anandthakker/followers","following_url":"https://api.github.com/users/anandthakker/following{/other_user}","gists_url":"https://api.github.com/users/anandthakker/gists{/gist_id}","starred_url":"https://api.github.com/users/anandthakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandthakker/subscriptions","organizations_url":"https://api.github.com/users/anandthakker/orgs","repos_url":"https://api.github.com/users/anandthakker/repos","events_url":"https://api.github.com/users/anandthakker/events{/privacy}","received_events_url":"https://api.github.com/users/anandthakker/received_events","type":"User","site_admin":false},"created_at":"2017-04-05T20:22:19Z","updated_at":"2017-04-05T20:22:19Z","body":"Agreed @jfirebaugh - though I think we should keep this issue open to track the short/medium-term  problem, since fixing the spec may take longer."}}
{"actor":{"display_login":"anandthakker"}}