{"action":"opened","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2213","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2213/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2213/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2213/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2213","id":221083745,"number":2213,"title":"Incorrectly formatted FQDN's to googleapis.com","user":{"login":"ericuldall","id":3223296,"avatar_url":"https://avatars0.githubusercontent.com/u/3223296?v=3","gravatar_id":"","url":"https://api.github.com/users/ericuldall","html_url":"https://github.com/ericuldall","followers_url":"https://api.github.com/users/ericuldall/followers","following_url":"https://api.github.com/users/ericuldall/following{/other_user}","gists_url":"https://api.github.com/users/ericuldall/gists{/gist_id}","starred_url":"https://api.github.com/users/ericuldall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericuldall/subscriptions","organizations_url":"https://api.github.com/users/ericuldall/orgs","repos_url":"https://api.github.com/users/ericuldall/repos","events_url":"https://api.github.com/users/ericuldall/events{/privacy}","received_events_url":"https://api.github.com/users/ericuldall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-11T21:19:03Z","updated_at":"2017-04-11T21:19:03Z","closed_at":null,"body":"I've noticed all of the references to the Fully Qualified Domain Name \"googleapis.com\" are incorrectly formatted. Per [RFC 1034](http://www.ietf.org/rfc/rfc1034.txt) FQDN's should have a trailing dot in order to remove any ambiguity and unnecessary lookups.\r\n\r\nExplanatory documentation [HERE](http://www.dns-sd.org/trailingdotsindomainnames.html)\r\n\r\nWe were pointed to this doc by a Kubernetes network engineer at Google after having many DNS lookup issues inside of our GKE clusters. After running some tests we noticed a minimum 100ms improvement per request after adding the trailing dot.\r\n\r\nI have a PR ready that I will post for review.\r\n"}}
{"actor":{"display_login":"ericuldall"}}