{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/comments/157261720","pull_request_review_id":83880728,"id":157261720,"diff_hunk":"@@ -134,6 +134,19 @@ export abstract class DocDBDatabaseTreeItemBase extends DocDBTreeItemBase<Collec\n         } catch (err) {\n             return \"Input must be a number\"\n         }\n-        return null;\n+        return undefined;\n+    }\n+\n+    private static validateCollectionName(name: string): string | undefined | null {","path":"src/docdb/tree/DocDBDatabaseTreeItemBase.ts","position":17,"original_position":17,"commit_id":"0f854ae256de7504521e98ce46f336f4f375275d","original_commit_id":"0f854ae256de7504521e98ce46f336f4f375275d","user":{"login":"EricJizbaMSFT","id":11282622,"avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"I don't see this being used","created_at":"2017-12-15T17:56:31Z","updated_at":"2017-12-15T18:04:11Z","html_url":"https://github.com/Microsoft/vscode-cosmosdb/pull/293#discussion_r157261720","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/comments/157261720"},"html":{"href":"https://github.com/Microsoft/vscode-cosmosdb/pull/293#discussion_r157261720"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293","id":158505321,"html_url":"https://github.com/Microsoft/vscode-cosmosdb/pull/293","diff_url":"https://github.com/Microsoft/vscode-cosmosdb/pull/293.diff","patch_url":"https://github.com/Microsoft/vscode-cosmosdb/pull/293.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/293","number":293,"state":"open","locked":false,"title":"Name validation - DocDB DB+Collections, Mongo collections","user":{"login":"PrashanthCorp","id":30420973,"avatar_url":"https://avatars3.githubusercontent.com/u/30420973?v=4","gravatar_id":"","url":"https://api.github.com/users/PrashanthCorp","html_url":"https://github.com/PrashanthCorp","followers_url":"https://api.github.com/users/PrashanthCorp/followers","following_url":"https://api.github.com/users/PrashanthCorp/following{/other_user}","gists_url":"https://api.github.com/users/PrashanthCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/PrashanthCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrashanthCorp/subscriptions","organizations_url":"https://api.github.com/users/PrashanthCorp/orgs","repos_url":"https://api.github.com/users/PrashanthCorp/repos","events_url":"https://api.github.com/users/PrashanthCorp/events{/privacy}","received_events_url":"https://api.github.com/users/PrashanthCorp/received_events","type":"User","site_admin":false},"body":"Fixes #139 ","created_at":"2017-12-15T01:41:13Z","updated_at":"2017-12-15T18:04:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f77419706e67ef652256e420170b387574eaafc2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/293/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/statuses/0f854ae256de7504521e98ce46f336f4f375275d","head":{"label":"Microsoft:ps/I139","ref":"ps/I139","sha":"0f854ae256de7504521e98ce46f336f4f375275d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":100298835,"name":"vscode-cosmosdb","full_name":"Microsoft/vscode-cosmosdb","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-cosmosdb","description":"VS Code extension for Azure Cosmos DB","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb","forks_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/deployments","created_at":"2017-08-14T18:43:46Z","updated_at":"2017-12-12T01:15:41Z","pushed_at":"2017-12-15T11:15:26Z","git_url":"git://github.com/Microsoft/vscode-cosmosdb.git","ssh_url":"git@github.com:Microsoft/vscode-cosmosdb.git","clone_url":"https://github.com/Microsoft/vscode-cosmosdb.git","svn_url":"https://github.com/Microsoft/vscode-cosmosdb","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-cosmosdb","size":15418,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":43,"watchers":19,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"27d7e723c3ffacef94df850cb5b9d17adea94a1d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":100298835,"name":"vscode-cosmosdb","full_name":"Microsoft/vscode-cosmosdb","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-cosmosdb","description":"VS Code extension for Azure Cosmos DB","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb","forks_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/deployments","created_at":"2017-08-14T18:43:46Z","updated_at":"2017-12-12T01:15:41Z","pushed_at":"2017-12-15T11:15:26Z","git_url":"git://github.com/Microsoft/vscode-cosmosdb.git","ssh_url":"git@github.com:Microsoft/vscode-cosmosdb.git","clone_url":"https://github.com/Microsoft/vscode-cosmosdb.git","svn_url":"https://github.com/Microsoft/vscode-cosmosdb","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-cosmosdb","size":15418,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":43,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293"},"html":{"href":"https://github.com/Microsoft/vscode-cosmosdb/pull/293"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/293"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-cosmosdb/statuses/0f854ae256de7504521e98ce46f336f4f375275d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"EricJizbaMSFT"}}