{"action":"created","comment":{"url":"https://api.github.com/repos/vlm/asn1c/pulls/comments/150944133","pull_request_review_id":76572072,"id":150944133,"diff_hunk":"@@ -179,6 +186,11 @@ main(int ac, char **av) {\n         case 'S':\n             skeletons_dir = optarg;\n             break;\n+        case 'D':\n+            strncat(destdir, optarg, PATH_MAX - 2); /* leave room for possible trailing '/' */\n+            if(destdir[strlen(destdir)-1] != '/')\n+                strncat(destdir, \"/\", PATH_MAX - 1);","path":"asn1c/asn1c.c","position":46,"original_position":46,"commit_id":"529d7463b7e0571832fb5d9ab7973a1b52e30b3d","original_commit_id":"529d7463b7e0571832fb5d9ab7973a1b52e30b3d","user":{"login":"ringlej","id":100756,"avatar_url":"https://avatars0.githubusercontent.com/u/100756?v=4","gravatar_id":"","url":"https://api.github.com/users/ringlej","html_url":"https://github.com/ringlej","followers_url":"https://api.github.com/users/ringlej/followers","following_url":"https://api.github.com/users/ringlej/following{/other_user}","gists_url":"https://api.github.com/users/ringlej/gists{/gist_id}","starred_url":"https://api.github.com/users/ringlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringlej/subscriptions","organizations_url":"https://api.github.com/users/ringlej/orgs","repos_url":"https://api.github.com/users/ringlej/repos","events_url":"https://api.github.com/users/ringlej/events{/privacy}","received_events_url":"https://api.github.com/users/ringlej/received_events","type":"User","site_admin":false},"body":"Ok. I see now... That line should be:\r\n```c\r\nstrncat(destdir, \"/\", 1);\r\n```\r\nI will fix it.","created_at":"2017-11-14T19:50:23Z","updated_at":"2017-11-14T19:50:23Z","html_url":"https://github.com/vlm/asn1c/pull/245#discussion_r150944133","pull_request_url":"https://api.github.com/repos/vlm/asn1c/pulls/245","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/comments/150944133"},"html":{"href":"https://github.com/vlm/asn1c/pull/245#discussion_r150944133"},"pull_request":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/245"}},"in_reply_to_id":150914090},"pull_request":{"url":"https://api.github.com/repos/vlm/asn1c/pulls/245","id":152438446,"html_url":"https://github.com/vlm/asn1c/pull/245","diff_url":"https://github.com/vlm/asn1c/pull/245.diff","patch_url":"https://github.com/vlm/asn1c/pull/245.patch","issue_url":"https://api.github.com/repos/vlm/asn1c/issues/245","number":245,"state":"open","locked":false,"title":"Cleanup generated makefiles and make it work better with autotools","user":{"login":"ringlej","id":100756,"avatar_url":"https://avatars0.githubusercontent.com/u/100756?v=4","gravatar_id":"","url":"https://api.github.com/users/ringlej","html_url":"https://github.com/ringlej","followers_url":"https://api.github.com/users/ringlej/followers","following_url":"https://api.github.com/users/ringlej/following{/other_user}","gists_url":"https://api.github.com/users/ringlej/gists{/gist_id}","starred_url":"https://api.github.com/users/ringlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringlej/subscriptions","organizations_url":"https://api.github.com/users/ringlej/orgs","repos_url":"https://api.github.com/users/ringlej/repos","events_url":"https://api.github.com/users/ringlej/events{/privacy}","received_events_url":"https://api.github.com/users/ringlej/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-14T08:18:03Z","updated_at":"2017-11-14T19:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb57a27a54d2adc335deb19957af8c9dd3ee23be","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vlm/asn1c/pulls/245/commits","review_comments_url":"https://api.github.com/repos/vlm/asn1c/pulls/245/comments","review_comment_url":"https://api.github.com/repos/vlm/asn1c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vlm/asn1c/issues/245/comments","statuses_url":"https://api.github.com/repos/vlm/asn1c/statuses/529d7463b7e0571832fb5d9ab7973a1b52e30b3d","head":{"label":"ringlej:feature/autotools-gen","ref":"feature/autotools-gen","sha":"529d7463b7e0571832fb5d9ab7973a1b52e30b3d","user":{"login":"ringlej","id":100756,"avatar_url":"https://avatars0.githubusercontent.com/u/100756?v=4","gravatar_id":"","url":"https://api.github.com/users/ringlej","html_url":"https://github.com/ringlej","followers_url":"https://api.github.com/users/ringlej/followers","following_url":"https://api.github.com/users/ringlej/following{/other_user}","gists_url":"https://api.github.com/users/ringlej/gists{/gist_id}","starred_url":"https://api.github.com/users/ringlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringlej/subscriptions","organizations_url":"https://api.github.com/users/ringlej/orgs","repos_url":"https://api.github.com/users/ringlej/repos","events_url":"https://api.github.com/users/ringlej/events{/privacy}","received_events_url":"https://api.github.com/users/ringlej/received_events","type":"User","site_admin":false},"repo":{"id":100152372,"name":"asn1c","full_name":"ringlej/asn1c","owner":{"login":"ringlej","id":100756,"avatar_url":"https://avatars0.githubusercontent.com/u/100756?v=4","gravatar_id":"","url":"https://api.github.com/users/ringlej","html_url":"https://github.com/ringlej","followers_url":"https://api.github.com/users/ringlej/followers","following_url":"https://api.github.com/users/ringlej/following{/other_user}","gists_url":"https://api.github.com/users/ringlej/gists{/gist_id}","starred_url":"https://api.github.com/users/ringlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringlej/subscriptions","organizations_url":"https://api.github.com/users/ringlej/orgs","repos_url":"https://api.github.com/users/ringlej/repos","events_url":"https://api.github.com/users/ringlej/events{/privacy}","received_events_url":"https://api.github.com/users/ringlej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ringlej/asn1c","description":"The ASN.1 Compiler","fork":true,"url":"https://api.github.com/repos/ringlej/asn1c","forks_url":"https://api.github.com/repos/ringlej/asn1c/forks","keys_url":"https://api.github.com/repos/ringlej/asn1c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringlej/asn1c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringlej/asn1c/teams","hooks_url":"https://api.github.com/repos/ringlej/asn1c/hooks","issue_events_url":"https://api.github.com/repos/ringlej/asn1c/issues/events{/number}","events_url":"https://api.github.com/repos/ringlej/asn1c/events","assignees_url":"https://api.github.com/repos/ringlej/asn1c/assignees{/user}","branches_url":"https://api.github.com/repos/ringlej/asn1c/branches{/branch}","tags_url":"https://api.github.com/repos/ringlej/asn1c/tags","blobs_url":"https://api.github.com/repos/ringlej/asn1c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringlej/asn1c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringlej/asn1c/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringlej/asn1c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringlej/asn1c/statuses/{sha}","languages_url":"https://api.github.com/repos/ringlej/asn1c/languages","stargazers_url":"https://api.github.com/repos/ringlej/asn1c/stargazers","contributors_url":"https://api.github.com/repos/ringlej/asn1c/contributors","subscribers_url":"https://api.github.com/repos/ringlej/asn1c/subscribers","subscription_url":"https://api.github.com/repos/ringlej/asn1c/subscription","commits_url":"https://api.github.com/repos/ringlej/asn1c/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringlej/asn1c/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringlej/asn1c/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringlej/asn1c/issues/comments{/number}","contents_url":"https://api.github.com/repos/ringlej/asn1c/contents/{+path}","compare_url":"https://api.github.com/repos/ringlej/asn1c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringlej/asn1c/merges","archive_url":"https://api.github.com/repos/ringlej/asn1c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringlej/asn1c/downloads","issues_url":"https://api.github.com/repos/ringlej/asn1c/issues{/number}","pulls_url":"https://api.github.com/repos/ringlej/asn1c/pulls{/number}","milestones_url":"https://api.github.com/repos/ringlej/asn1c/milestones{/number}","notifications_url":"https://api.github.com/repos/ringlej/asn1c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringlej/asn1c/labels{/name}","releases_url":"https://api.github.com/repos/ringlej/asn1c/releases{/id}","deployments_url":"https://api.github.com/repos/ringlej/asn1c/deployments","created_at":"2017-08-13T03:51:08Z","updated_at":"2017-08-13T03:51:11Z","pushed_at":"2017-11-14T16:16:11Z","git_url":"git://github.com/ringlej/asn1c.git","ssh_url":"git@github.com:ringlej/asn1c.git","clone_url":"https://github.com/ringlej/asn1c.git","svn_url":"https://github.com/ringlej/asn1c","homepage":"http://lionet.info/asn1c/","size":15101,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vlm:master","ref":"master","sha":"d0ee2b143613a1629317d8c8da6e2b60865d955b","user":{"login":"vlm","id":145781,"avatar_url":"https://avatars2.githubusercontent.com/u/145781?v=4","gravatar_id":"","url":"https://api.github.com/users/vlm","html_url":"https://github.com/vlm","followers_url":"https://api.github.com/users/vlm/followers","following_url":"https://api.github.com/users/vlm/following{/other_user}","gists_url":"https://api.github.com/users/vlm/gists{/gist_id}","starred_url":"https://api.github.com/users/vlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlm/subscriptions","organizations_url":"https://api.github.com/users/vlm/orgs","repos_url":"https://api.github.com/users/vlm/repos","events_url":"https://api.github.com/users/vlm/events{/privacy}","received_events_url":"https://api.github.com/users/vlm/received_events","type":"User","site_admin":false},"repo":{"id":989603,"name":"asn1c","full_name":"vlm/asn1c","owner":{"login":"vlm","id":145781,"avatar_url":"https://avatars2.githubusercontent.com/u/145781?v=4","gravatar_id":"","url":"https://api.github.com/users/vlm","html_url":"https://github.com/vlm","followers_url":"https://api.github.com/users/vlm/followers","following_url":"https://api.github.com/users/vlm/following{/other_user}","gists_url":"https://api.github.com/users/vlm/gists{/gist_id}","starred_url":"https://api.github.com/users/vlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlm/subscriptions","organizations_url":"https://api.github.com/users/vlm/orgs","repos_url":"https://api.github.com/users/vlm/repos","events_url":"https://api.github.com/users/vlm/events{/privacy}","received_events_url":"https://api.github.com/users/vlm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlm/asn1c","description":"The ASN.1 Compiler","fork":false,"url":"https://api.github.com/repos/vlm/asn1c","forks_url":"https://api.github.com/repos/vlm/asn1c/forks","keys_url":"https://api.github.com/repos/vlm/asn1c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlm/asn1c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlm/asn1c/teams","hooks_url":"https://api.github.com/repos/vlm/asn1c/hooks","issue_events_url":"https://api.github.com/repos/vlm/asn1c/issues/events{/number}","events_url":"https://api.github.com/repos/vlm/asn1c/events","assignees_url":"https://api.github.com/repos/vlm/asn1c/assignees{/user}","branches_url":"https://api.github.com/repos/vlm/asn1c/branches{/branch}","tags_url":"https://api.github.com/repos/vlm/asn1c/tags","blobs_url":"https://api.github.com/repos/vlm/asn1c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlm/asn1c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlm/asn1c/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlm/asn1c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlm/asn1c/statuses/{sha}","languages_url":"https://api.github.com/repos/vlm/asn1c/languages","stargazers_url":"https://api.github.com/repos/vlm/asn1c/stargazers","contributors_url":"https://api.github.com/repos/vlm/asn1c/contributors","subscribers_url":"https://api.github.com/repos/vlm/asn1c/subscribers","subscription_url":"https://api.github.com/repos/vlm/asn1c/subscription","commits_url":"https://api.github.com/repos/vlm/asn1c/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlm/asn1c/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlm/asn1c/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlm/asn1c/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlm/asn1c/contents/{+path}","compare_url":"https://api.github.com/repos/vlm/asn1c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlm/asn1c/merges","archive_url":"https://api.github.com/repos/vlm/asn1c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlm/asn1c/downloads","issues_url":"https://api.github.com/repos/vlm/asn1c/issues{/number}","pulls_url":"https://api.github.com/repos/vlm/asn1c/pulls{/number}","milestones_url":"https://api.github.com/repos/vlm/asn1c/milestones{/number}","notifications_url":"https://api.github.com/repos/vlm/asn1c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlm/asn1c/labels{/name}","releases_url":"https://api.github.com/repos/vlm/asn1c/releases{/id}","deployments_url":"https://api.github.com/repos/vlm/asn1c/deployments","created_at":"2010-10-15T10:38:58Z","updated_at":"2017-11-14T11:08:13Z","pushed_at":"2017-11-14T16:16:12Z","git_url":"git://github.com/vlm/asn1c.git","ssh_url":"git@github.com:vlm/asn1c.git","clone_url":"https://github.com/vlm/asn1c.git","svn_url":"https://github.com/vlm/asn1c","homepage":"http://lionet.info/asn1c/","size":15089,"stargazers_count":322,"watchers_count":322,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"open_issues_count":66,"forks":170,"open_issues":66,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/245"},"html":{"href":"https://github.com/vlm/asn1c/pull/245"},"issue":{"href":"https://api.github.com/repos/vlm/asn1c/issues/245"},"comments":{"href":"https://api.github.com/repos/vlm/asn1c/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vlm/asn1c/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/vlm/asn1c/statuses/529d7463b7e0571832fb5d9ab7973a1b52e30b3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ringlej"}}