{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/132256923","pull_request_review_id":55318324,"id":132256923,"diff_hunk":"@@ -571,10 +571,10 @@ export interface ServerEventCriteria {\n  * Related to [See docs](https://hapijs.com/api/16.1.1#servermethodname-method-options)\n  */\n export interface ServerMethod {\n-    /** Not possible to improve this typing due to this unresolvable issue:  https://github.com/Microsoft/TypeScript/issues/15190 */\n-    (...args: (any | ServerMethodNext)[]): void;\n     /** the method must return a value (result, Error, or a promise) or throw an Error. */\n     (...args: any[]): any | Error | Promise<any>;\n+    /** Not possible to improve this typing due to this unresolvable issue:  https://github.com/Microsoft/TypeScript/issues/15190 */\n+    (...args: (any | ServerMethodNext)[]): void;","path":"types/hapi/index.d.ts","position":9,"original_position":9,"commit_id":"5dbc2b63970fe20695d1030b35778eb205a296d6","original_commit_id":"5dbc2b63970fe20695d1030b35778eb205a296d6","user":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars3.githubusercontent.com/u/8000722?v=4","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"body":"> That was not part of my pull request.\r\n\r\nso how is in the PR? do you want to rebase?","created_at":"2017-08-09T17:49:57Z","updated_at":"2017-08-09T17:49:57Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540#discussion_r132256923","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/132256923"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540#discussion_r132256923"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540","id":133495017,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18540","number":18540,"state":"open","locked":false,"title":"[meteor] Added optional parameters to Meteor's apply function","user":{"login":"stefanholzapfel","id":9963536,"avatar_url":"https://avatars0.githubusercontent.com/u/9963536?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanholzapfel","html_url":"https://github.com/stefanholzapfel","followers_url":"https://api.github.com/users/stefanholzapfel/followers","following_url":"https://api.github.com/users/stefanholzapfel/following{/other_user}","gists_url":"https://api.github.com/users/stefanholzapfel/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanholzapfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanholzapfel/subscriptions","organizations_url":"https://api.github.com/users/stefanholzapfel/orgs","repos_url":"https://api.github.com/users/stefanholzapfel/repos","events_url":"https://api.github.com/users/stefanholzapfel/events{/privacy}","received_events_url":"https://api.github.com/users/stefanholzapfel/received_events","type":"User","site_admin":false},"body":"- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ ] Test the change in your own code. (Compile and run.) I think no tests are affected/necessary\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nChange in existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: \r\nAdded two missing parameters to Meteor.apply(). Info can be found here:\r\nhttps://docs.meteor.com/api/methods.html#Meteor-apply\r\nand\r\nhttps://github.com/meteor/meteor/blob/e22702be4557df2539c646bd010484bdac747db7/packages/ddp/livedata_connection.js#L654\r\n\r\nSorry if there are any formal mistakes in that pull request, it's my first one. You're welcome to give critical/constructive feedback.","created_at":"2017-08-01T14:58:06Z","updated_at":"2017-08-09T17:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb28d8f6e6b298ba326607429104f06f02af713c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18540/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/5dbc2b63970fe20695d1030b35778eb205a296d6","head":{"label":"stefanholzapfel:master","ref":"master","sha":"5dbc2b63970fe20695d1030b35778eb205a296d6","user":{"login":"stefanholzapfel","id":9963536,"avatar_url":"https://avatars0.githubusercontent.com/u/9963536?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanholzapfel","html_url":"https://github.com/stefanholzapfel","followers_url":"https://api.github.com/users/stefanholzapfel/followers","following_url":"https://api.github.com/users/stefanholzapfel/following{/other_user}","gists_url":"https://api.github.com/users/stefanholzapfel/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanholzapfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanholzapfel/subscriptions","organizations_url":"https://api.github.com/users/stefanholzapfel/orgs","repos_url":"https://api.github.com/users/stefanholzapfel/repos","events_url":"https://api.github.com/users/stefanholzapfel/events{/privacy}","received_events_url":"https://api.github.com/users/stefanholzapfel/received_events","type":"User","site_admin":false},"repo":{"id":99010775,"name":"DefinitelyTyped","full_name":"stefanholzapfel/DefinitelyTyped","owner":{"login":"stefanholzapfel","id":9963536,"avatar_url":"https://avatars0.githubusercontent.com/u/9963536?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanholzapfel","html_url":"https://github.com/stefanholzapfel","followers_url":"https://api.github.com/users/stefanholzapfel/followers","following_url":"https://api.github.com/users/stefanholzapfel/following{/other_user}","gists_url":"https://api.github.com/users/stefanholzapfel/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanholzapfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanholzapfel/subscriptions","organizations_url":"https://api.github.com/users/stefanholzapfel/orgs","repos_url":"https://api.github.com/users/stefanholzapfel/repos","events_url":"https://api.github.com/users/stefanholzapfel/events{/privacy}","received_events_url":"https://api.github.com/users/stefanholzapfel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanholzapfel/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped","forks_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/stefanholzapfel/DefinitelyTyped/deployments","created_at":"2017-08-01T14:33:52Z","updated_at":"2017-08-01T14:34:10Z","pushed_at":"2017-08-01T17:35:29Z","git_url":"git://github.com/stefanholzapfel/DefinitelyTyped.git","ssh_url":"git@github.com:stefanholzapfel/DefinitelyTyped.git","clone_url":"https://github.com/stefanholzapfel/DefinitelyTyped.git","svn_url":"https://github.com/stefanholzapfel/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":223829,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"0df7e8bc93004fbfed94169f38e51dd5817e9279","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-08-09T17:32:56Z","pushed_at":"2017-08-09T17:48:13Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":224630,"stargazers_count":11769,"watchers_count":11769,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9767,"mirror_url":null,"open_issues_count":1645,"forks":9767,"open_issues":1645,"watchers":11769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18540"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18540"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18540/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18540/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/5dbc2b63970fe20695d1030b35778eb205a296d6"}}}}
{"actor":{"display_login":"mhegazy"}}