{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/apache/mina-sshd/pulls/38","id":145882807,"html_url":"https://github.com/apache/mina-sshd/pull/38","diff_url":"https://github.com/apache/mina-sshd/pull/38.diff","patch_url":"https://github.com/apache/mina-sshd/pull/38.patch","issue_url":"https://api.github.com/repos/apache/mina-sshd/issues/38","number":38,"state":"closed","locked":false,"title":"[SSHD-776] SSHD local port forwarding close session unexpectedly","user":{"login":"fcav1973","id":19611357,"avatar_url":"https://avatars2.githubusercontent.com/u/19611357?v=4","gravatar_id":"","url":"https://api.github.com/users/fcav1973","html_url":"https://github.com/fcav1973","followers_url":"https://api.github.com/users/fcav1973/followers","following_url":"https://api.github.com/users/fcav1973/following{/other_user}","gists_url":"https://api.github.com/users/fcav1973/gists{/gist_id}","starred_url":"https://api.github.com/users/fcav1973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcav1973/subscriptions","organizations_url":"https://api.github.com/users/fcav1973/orgs","repos_url":"https://api.github.com/users/fcav1973/repos","events_url":"https://api.github.com/users/fcav1973/events{/privacy}","received_events_url":"https://api.github.com/users/fcav1973/received_events","type":"User","site_admin":false},"body":"This patch contains the following modifications:\r\n\r\n1. _AbstractConnectionService.channelWindowAdjust_: we did the same modifications as for channelEof; checking RFC there is the same level of ambiguity\r\n2. _Nio2Session.exceptionCaught_: the session should be closed anyway (the close method is already resilient to subsequent calls). This was necessary because we found some messages in write queue after the exception management.\r\n3. _TcpipServerChannel.close_: this have been changed to let the connector to close immediatly os gracefully, accordingly to the way the API is called. Most of the problem we have found where related write messages still pending during a gracefull close\r\n4. _TcpipServerChannel.handleWriteDataFailure_: this have been necessary because in case the remote server had closed the connection, some data could be still waiting in the channel to be written to the outgoing session (even if channel close have been already sent) that could be already closed. In that case we should simply have to discard those error.\r\n","created_at":"2017-10-11T08:17:17Z","updated_at":"2017-10-11T19:08:23Z","closed_at":"2017-10-11T19:08:23Z","merged_at":null,"merge_commit_sha":"5f5149ef60ce371aab9fb263c8e8625de02e3b21","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/mina-sshd/pulls/38/commits","review_comments_url":"https://api.github.com/repos/apache/mina-sshd/pulls/38/comments","review_comment_url":"https://api.github.com/repos/apache/mina-sshd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/mina-sshd/issues/38/comments","statuses_url":"https://api.github.com/repos/apache/mina-sshd/statuses/ad67d269d982e0144d085bd08e50cf778cf68e96","head":{"label":"fcav1973:master","ref":"master","sha":"ad67d269d982e0144d085bd08e50cf778cf68e96","user":{"login":"fcav1973","id":19611357,"avatar_url":"https://avatars2.githubusercontent.com/u/19611357?v=4","gravatar_id":"","url":"https://api.github.com/users/fcav1973","html_url":"https://github.com/fcav1973","followers_url":"https://api.github.com/users/fcav1973/followers","following_url":"https://api.github.com/users/fcav1973/following{/other_user}","gists_url":"https://api.github.com/users/fcav1973/gists{/gist_id}","starred_url":"https://api.github.com/users/fcav1973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcav1973/subscriptions","organizations_url":"https://api.github.com/users/fcav1973/orgs","repos_url":"https://api.github.com/users/fcav1973/repos","events_url":"https://api.github.com/users/fcav1973/events{/privacy}","received_events_url":"https://api.github.com/users/fcav1973/received_events","type":"User","site_admin":false},"repo":{"id":106522104,"name":"mina-sshd","full_name":"fcav1973/mina-sshd","owner":{"login":"fcav1973","id":19611357,"avatar_url":"https://avatars2.githubusercontent.com/u/19611357?v=4","gravatar_id":"","url":"https://api.github.com/users/fcav1973","html_url":"https://github.com/fcav1973","followers_url":"https://api.github.com/users/fcav1973/followers","following_url":"https://api.github.com/users/fcav1973/following{/other_user}","gists_url":"https://api.github.com/users/fcav1973/gists{/gist_id}","starred_url":"https://api.github.com/users/fcav1973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcav1973/subscriptions","organizations_url":"https://api.github.com/users/fcav1973/orgs","repos_url":"https://api.github.com/users/fcav1973/repos","events_url":"https://api.github.com/users/fcav1973/events{/privacy}","received_events_url":"https://api.github.com/users/fcav1973/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fcav1973/mina-sshd","description":"Mirror of Apache MINA SSHD","fork":true,"url":"https://api.github.com/repos/fcav1973/mina-sshd","forks_url":"https://api.github.com/repos/fcav1973/mina-sshd/forks","keys_url":"https://api.github.com/repos/fcav1973/mina-sshd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcav1973/mina-sshd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcav1973/mina-sshd/teams","hooks_url":"https://api.github.com/repos/fcav1973/mina-sshd/hooks","issue_events_url":"https://api.github.com/repos/fcav1973/mina-sshd/issues/events{/number}","events_url":"https://api.github.com/repos/fcav1973/mina-sshd/events","assignees_url":"https://api.github.com/repos/fcav1973/mina-sshd/assignees{/user}","branches_url":"https://api.github.com/repos/fcav1973/mina-sshd/branches{/branch}","tags_url":"https://api.github.com/repos/fcav1973/mina-sshd/tags","blobs_url":"https://api.github.com/repos/fcav1973/mina-sshd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcav1973/mina-sshd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcav1973/mina-sshd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcav1973/mina-sshd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcav1973/mina-sshd/statuses/{sha}","languages_url":"https://api.github.com/repos/fcav1973/mina-sshd/languages","stargazers_url":"https://api.github.com/repos/fcav1973/mina-sshd/stargazers","contributors_url":"https://api.github.com/repos/fcav1973/mina-sshd/contributors","subscribers_url":"https://api.github.com/repos/fcav1973/mina-sshd/subscribers","subscription_url":"https://api.github.com/repos/fcav1973/mina-sshd/subscription","commits_url":"https://api.github.com/repos/fcav1973/mina-sshd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcav1973/mina-sshd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcav1973/mina-sshd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcav1973/mina-sshd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcav1973/mina-sshd/contents/{+path}","compare_url":"https://api.github.com/repos/fcav1973/mina-sshd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcav1973/mina-sshd/merges","archive_url":"https://api.github.com/repos/fcav1973/mina-sshd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcav1973/mina-sshd/downloads","issues_url":"https://api.github.com/repos/fcav1973/mina-sshd/issues{/number}","pulls_url":"https://api.github.com/repos/fcav1973/mina-sshd/pulls{/number}","milestones_url":"https://api.github.com/repos/fcav1973/mina-sshd/milestones{/number}","notifications_url":"https://api.github.com/repos/fcav1973/mina-sshd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcav1973/mina-sshd/labels{/name}","releases_url":"https://api.github.com/repos/fcav1973/mina-sshd/releases{/id}","deployments_url":"https://api.github.com/repos/fcav1973/mina-sshd/deployments","created_at":"2017-10-11T07:43:40Z","updated_at":"2017-10-11T07:43:45Z","pushed_at":"2017-10-11T08:11:05Z","git_url":"git://github.com/fcav1973/mina-sshd.git","ssh_url":"git@github.com:fcav1973/mina-sshd.git","clone_url":"https://github.com/fcav1973/mina-sshd.git","svn_url":"https://github.com/fcav1973/mina-sshd","homepage":null,"size":10089,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2529a4c3da8635ca350cd85ae76b0df5ac3b39d0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":688360,"name":"mina-sshd","full_name":"apache/mina-sshd","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/mina-sshd","description":"Mirror of Apache MINA SSHD","fork":false,"url":"https://api.github.com/repos/apache/mina-sshd","forks_url":"https://api.github.com/repos/apache/mina-sshd/forks","keys_url":"https://api.github.com/repos/apache/mina-sshd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/mina-sshd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/mina-sshd/teams","hooks_url":"https://api.github.com/repos/apache/mina-sshd/hooks","issue_events_url":"https://api.github.com/repos/apache/mina-sshd/issues/events{/number}","events_url":"https://api.github.com/repos/apache/mina-sshd/events","assignees_url":"https://api.github.com/repos/apache/mina-sshd/assignees{/user}","branches_url":"https://api.github.com/repos/apache/mina-sshd/branches{/branch}","tags_url":"https://api.github.com/repos/apache/mina-sshd/tags","blobs_url":"https://api.github.com/repos/apache/mina-sshd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/mina-sshd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/mina-sshd/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/mina-sshd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/mina-sshd/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/mina-sshd/languages","stargazers_url":"https://api.github.com/repos/apache/mina-sshd/stargazers","contributors_url":"https://api.github.com/repos/apache/mina-sshd/contributors","subscribers_url":"https://api.github.com/repos/apache/mina-sshd/subscribers","subscription_url":"https://api.github.com/repos/apache/mina-sshd/subscription","commits_url":"https://api.github.com/repos/apache/mina-sshd/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/mina-sshd/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/mina-sshd/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/mina-sshd/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/mina-sshd/contents/{+path}","compare_url":"https://api.github.com/repos/apache/mina-sshd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/mina-sshd/merges","archive_url":"https://api.github.com/repos/apache/mina-sshd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/mina-sshd/downloads","issues_url":"https://api.github.com/repos/apache/mina-sshd/issues{/number}","pulls_url":"https://api.github.com/repos/apache/mina-sshd/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/mina-sshd/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/mina-sshd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/mina-sshd/labels{/name}","releases_url":"https://api.github.com/repos/apache/mina-sshd/releases{/id}","deployments_url":"https://api.github.com/repos/apache/mina-sshd/deployments","created_at":"2010-05-26T23:38:08Z","updated_at":"2017-09-30T04:04:07Z","pushed_at":"2017-10-11T17:34:31Z","git_url":"git://github.com/apache/mina-sshd.git","ssh_url":"git@github.com:apache/mina-sshd.git","clone_url":"https://github.com/apache/mina-sshd.git","svn_url":"https://github.com/apache/mina-sshd","homepage":null,"size":10131,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":"git://git.apache.org/mina-sshd.git","open_issues_count":6,"forks":90,"open_issues":6,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/mina-sshd/pulls/38"},"html":{"href":"https://github.com/apache/mina-sshd/pull/38"},"issue":{"href":"https://api.github.com/repos/apache/mina-sshd/issues/38"},"comments":{"href":"https://api.github.com/repos/apache/mina-sshd/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/mina-sshd/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/mina-sshd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/mina-sshd/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/apache/mina-sshd/statuses/ad67d269d982e0144d085bd08e50cf778cf68e96"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":53,"deletions":35,"changed_files":3}}
{"actor":{"display_login":"fcav1973"}}