{"action":"created","issue":{"url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/1","repository_url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon","labels_url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/1/comments","events_url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/1/events","html_url":"https://github.com/janwh/miflora-mqtt-daemon/pull/1","id":245185562,"number":1,"title":"Update just about everything","user":{"login":"ThomDietrich","id":2870104,"avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-07-24T19:34:06Z","updated_at":"2017-07-25T21:16:59Z","closed_at":"2017-07-25T16:26:09Z","pull_request":{"url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/pulls/1","html_url":"https://github.com/janwh/miflora-mqtt-daemon/pull/1","diff_url":"https://github.com/janwh/miflora-mqtt-daemon/pull/1.diff","patch_url":"https://github.com/janwh/miflora-mqtt-daemon/pull/1.patch"},"body":"Hello @janwh 👋 \r\n\r\nI started to look at the Mi Flora sensors I had lying around for months this weekend.\r\nYour daemon looked quite promising and I had immediate results. Excellent.\r\nI wanted to add some enhancements and ended up doing a bunch of things.\r\nFeel free to comment or merge (if okay with you a Rebase Merge would be nice).\r\n\r\n* Add README.md\r\n* Add GIF eyecandy\r\n* Make daemon an option\r\n* Refactor a few parameters for better clarity\r\n* Add battery state\r\n* Add MQTT authentication\r\n* Add ~500% more command line output, errors sent to &2 (discard with `> /dev/null`)\r\n* Make config file case sensitive (sensor names)\r\n* Check for all kinds of errors (connection or publication errors are not handled, best effort should/will hopefully suffice)\r\n\r\nI'll be using this script in combination with openHAB. I've mentioned it in the README parallel to HA. Hope that's fine with you.\r\n\r\nCheers and Happy Hacking ;) Thomas"},"comment":{"url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/comments/317875145","html_url":"https://github.com/janwh/miflora-mqtt-daemon/pull/1#issuecomment-317875145","issue_url":"https://api.github.com/repos/janwh/miflora-mqtt-daemon/issues/1","id":317875145,"user":{"login":"ThomDietrich","id":2870104,"avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T21:16:59Z","updated_at":"2017-07-25T21:16:59Z","body":"I believe that is totally normal and sane if you just need a tool for yourself. My intentions were indeed more focused at the community.\r\n\r\nRegarding daemontools: I didn't know about it. I'd look into defining a systemd service unit. Every Linux user should be acquainted with it. What do we need logging for? Isn't sending data over time to an MQTT broker not logging enough? 😄 \r\n\r\nNo experience needed, don't worry, it's a small project after all ;) I'd be happy to host the main repo. I've prepared everything [here](https://github.com/ThomDietrich/miflora-mqtt-daemon/). You just have to click on the \"Fork\" button on the top right and off we go 🎆 \r\nYou can start opening Issues and PRs right away ;) Looking forward to working together! Best, Thomas 🍻 "}}
{"actor":{"display_login":"ThomDietrich"}}