{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/139187220","pull_request_review_id":63088102,"id":139187220,"diff_hunk":"@@ -7,7 +7,15 @@ locals {\n module \"bootstrapper\" {","path":"platforms/azure/bootstrap.tf","position":1,"original_position":1,"commit_id":"4a75f67dd6b7264d4ec9ccd07466bb5efe5479f2","original_commit_id":"4a75f67dd6b7264d4ec9ccd07466bb5efe5479f2","user":{"login":"alexsomesan","id":1097371,"avatar_url":"https://avatars0.githubusercontent.com/u/1097371?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsomesan","html_url":"https://github.com/alexsomesan","followers_url":"https://api.github.com/users/alexsomesan/followers","following_url":"https://api.github.com/users/alexsomesan/following{/other_user}","gists_url":"https://api.github.com/users/alexsomesan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomesan/subscriptions","organizations_url":"https://api.github.com/users/alexsomesan/orgs","repos_url":"https://api.github.com/users/alexsomesan/repos","events_url":"https://api.github.com/users/alexsomesan/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomesan/received_events","type":"User","site_admin":false},"body":"100% agree. I just want to bake it here a bit, see how well it's fighting flakiness.\r\nI'll follow up with the other platforms in the coming days.","created_at":"2017-09-15T15:59:29Z","updated_at":"2017-09-15T15:59:29Z","html_url":"https://github.com/coreos/tectonic-installer/pull/1923#discussion_r139187220","pull_request_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/139187220"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1923#discussion_r139187220"},"pull_request":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923"}},"in_reply_to_id":139179685},"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923","id":141338257,"html_url":"https://github.com/coreos/tectonic-installer/pull/1923","diff_url":"https://github.com/coreos/tectonic-installer/pull/1923.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/1923.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1923","number":1923,"state":"open","locked":false,"title":"Consolidate Azure bootstrapper dependencies","user":{"login":"alexsomesan","id":1097371,"avatar_url":"https://avatars0.githubusercontent.com/u/1097371?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsomesan","html_url":"https://github.com/alexsomesan","followers_url":"https://api.github.com/users/alexsomesan/followers","following_url":"https://api.github.com/users/alexsomesan/following{/other_user}","gists_url":"https://api.github.com/users/alexsomesan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomesan/subscriptions","organizations_url":"https://api.github.com/users/alexsomesan/orgs","repos_url":"https://api.github.com/users/alexsomesan/repos","events_url":"https://api.github.com/users/alexsomesan/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomesan/received_events","type":"User","site_admin":false},"body":"With this change we make sure that the bootstrapping module kicks off only after all it's dependencies have been created.\r\nPreviously this was accomplished by a 'depends_on' keyword but since the bootstrapper has now been moved to it's own module, that approach no longer works (Terraform limitation).","created_at":"2017-09-15T15:25:47Z","updated_at":"2017-09-15T15:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e8ec0b6c8d241c29dde23ecb864c055619be0f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"squat","id":20484159,"avatar_url":"https://avatars1.githubusercontent.com/u/20484159?v=4","gravatar_id":"","url":"https://api.github.com/users/squat","html_url":"https://github.com/squat","followers_url":"https://api.github.com/users/squat/followers","following_url":"https://api.github.com/users/squat/following{/other_user}","gists_url":"https://api.github.com/users/squat/gists{/gist_id}","starred_url":"https://api.github.com/users/squat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squat/subscriptions","organizations_url":"https://api.github.com/users/squat/orgs","repos_url":"https://api.github.com/users/squat/repos","events_url":"https://api.github.com/users/squat/events{/privacy}","received_events_url":"https://api.github.com/users/squat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1923/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/4a75f67dd6b7264d4ec9ccd07466bb5efe5479f2","head":{"label":"alexsomesan:consolidate-bootstrapper-deps","ref":"consolidate-bootstrapper-deps","sha":"4a75f67dd6b7264d4ec9ccd07466bb5efe5479f2","user":{"login":"alexsomesan","id":1097371,"avatar_url":"https://avatars0.githubusercontent.com/u/1097371?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsomesan","html_url":"https://github.com/alexsomesan","followers_url":"https://api.github.com/users/alexsomesan/followers","following_url":"https://api.github.com/users/alexsomesan/following{/other_user}","gists_url":"https://api.github.com/users/alexsomesan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomesan/subscriptions","organizations_url":"https://api.github.com/users/alexsomesan/orgs","repos_url":"https://api.github.com/users/alexsomesan/repos","events_url":"https://api.github.com/users/alexsomesan/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomesan/received_events","type":"User","site_admin":false},"repo":{"id":86052380,"name":"tectonic-installer","full_name":"alexsomesan/tectonic-installer","owner":{"login":"alexsomesan","id":1097371,"avatar_url":"https://avatars0.githubusercontent.com/u/1097371?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsomesan","html_url":"https://github.com/alexsomesan","followers_url":"https://api.github.com/users/alexsomesan/followers","following_url":"https://api.github.com/users/alexsomesan/following{/other_user}","gists_url":"https://api.github.com/users/alexsomesan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomesan/subscriptions","organizations_url":"https://api.github.com/users/alexsomesan/orgs","repos_url":"https://api.github.com/users/alexsomesan/repos","events_url":"https://api.github.com/users/alexsomesan/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomesan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexsomesan/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":true,"url":"https://api.github.com/repos/alexsomesan/tectonic-installer","forks_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/forks","keys_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/events","assignees_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/merges","archive_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/alexsomesan/tectonic-installer/deployments","created_at":"2017-03-24T09:47:10Z","updated_at":"2017-06-13T09:19:08Z","pushed_at":"2017-09-15T15:56:46Z","git_url":"git://github.com/alexsomesan/tectonic-installer.git","ssh_url":"git@github.com:alexsomesan/tectonic-installer.git","clone_url":"https://github.com/alexsomesan/tectonic-installer.git","svn_url":"https://github.com/alexsomesan/tectonic-installer","homepage":"","size":28415,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"4051399ddee2d6e4028ce5552b2ff13d3dd09f73","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":81620471,"name":"tectonic-installer","full_name":"coreos/tectonic-installer","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-installer","forks_url":"https://api.github.com/repos/coreos/tectonic-installer/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-installer/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-installer/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-installer/deployments","created_at":"2017-02-11T00:52:23Z","updated_at":"2017-09-14T10:04:06Z","pushed_at":"2017-09-15T15:56:48Z","git_url":"git://github.com/coreos/tectonic-installer.git","ssh_url":"git@github.com:coreos/tectonic-installer.git","clone_url":"https://github.com/coreos/tectonic-installer.git","svn_url":"https://github.com/coreos/tectonic-installer","homepage":"","size":28407,"stargazers_count":289,"watchers_count":289,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"open_issues_count":121,"forks":188,"open_issues":121,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1923"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1923"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-installer/statuses/4a75f67dd6b7264d4ec9ccd07466bb5efe5479f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexsomesan"}}