{"action":"opened","number":92,"pull_request":{"url":"https://api.github.com/repos/openregister/registers-frontend/pulls/92","id":158904572,"html_url":"https://github.com/openregister/registers-frontend/pull/92","diff_url":"https://github.com/openregister/registers-frontend/pull/92.diff","patch_url":"https://github.com/openregister/registers-frontend/pull/92.patch","issue_url":"https://api.github.com/repos/openregister/registers-frontend/issues/92","number":92,"state":"open","locked":false,"title":"Store System Keys in DB and use in view","user":{"login":"gidsg","id":1764158,"avatar_url":"https://avatars0.githubusercontent.com/u/1764158?v=4","gravatar_id":"","url":"https://api.github.com/users/gidsg","html_url":"https://github.com/gidsg","followers_url":"https://api.github.com/users/gidsg/followers","following_url":"https://api.github.com/users/gidsg/following{/other_user}","gists_url":"https://api.github.com/users/gidsg/gists{/gist_id}","starred_url":"https://api.github.com/users/gidsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidsg/subscriptions","organizations_url":"https://api.github.com/users/gidsg/orgs","repos_url":"https://api.github.com/users/gidsg/repos","events_url":"https://api.github.com/users/gidsg/events{/privacy}","received_events_url":"https://api.github.com/users/gidsg/received_events","type":"User","site_admin":false},"body":"### Context\r\nPreviously we were not correctly storing system entry keys in the DB. This resulted in some placeholders and sub-optimal lookups.\r\n\r\n### Changes proposed in this pull request\r\n* Store system entry keys in the DB\r\n* Show register definition text in frontend\r\n* Sort fields according to register definition\r\n\r\n#### Before\r\n\r\n<img width=\"1011\" alt=\"screen shot 2017-12-18 at 12 34 56\" src=\"https://user-images.githubusercontent.com/1764158/34106534-7dc714c0-e3f0-11e7-9524-2a6f77195dbe.png\">\r\n<img width=\"332\" alt=\"screen shot 2017-12-18 at 12 34 51\" src=\"https://user-images.githubusercontent.com/1764158/34106535-7ddc1514-e3f0-11e7-920b-fc7e2780b22a.png\">\r\n\r\n#### After \r\n<img width=\"455\" alt=\"screen shot 2017-12-18 at 12 34 27\" src=\"https://user-images.githubusercontent.com/1764158/34106557-8eb7240a-e3f0-11e7-8d11-ddf44c7ada1e.png\">\r\n<img width=\"1006\" alt=\"screen shot 2017-12-18 at 12 34 34\" src=\"https://user-images.githubusercontent.com/1764158/34106556-8ea25386-e3f0-11e7-8f20-5541eb7142d5.png\">\r\n\r\n\r\n\r\n\r\n### Guidance to review\r\n","created_at":"2017-12-18T12:43:07Z","updated_at":"2017-12-18T12:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/92/commits","review_comments_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/92/comments","review_comment_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/issues/92/comments","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/24b7b3ca137874e048dc41f70cc6c513286e0f72","head":{"label":"openregister:system-key","ref":"system-key","sha":"24b7b3ca137874e048dc41f70cc6c513286e0f72","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"name":"registers-frontend","full_name":"openregister/registers-frontend","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2017-12-12T16:34:33Z","pushed_at":"2017-12-18T12:33:36Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://registers.cloudapps.digital/","size":874,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"beta-assessment"}},"base":{"label":"openregister:postgres_based_performance","ref":"postgres_based_performance","sha":"6401c1738bdaa17b7e59edb5b715d73e08c30f1e","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"name":"registers-frontend","full_name":"openregister/registers-frontend","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2017-12-12T16:34:33Z","pushed_at":"2017-12-18T12:33:36Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://registers.cloudapps.digital/","size":874,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"beta-assessment"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/92"},"html":{"href":"https://github.com/openregister/registers-frontend/pull/92"},"issue":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/92"},"comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/registers-frontend/statuses/24b7b3ca137874e048dc41f70cc6c513286e0f72"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":7,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"gidsg"}}