{"action":"closed","number":1887,"pull_request":{"url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887","id":152175418,"html_url":"https://github.com/kduske/TrenchBroom/pull/1887","diff_url":"https://github.com/kduske/TrenchBroom/pull/1887.diff","patch_url":"https://github.com/kduske/TrenchBroom/pull/1887.patch","issue_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1887","number":1887,"state":"closed","locked":false,"title":"1843: Camera::setDirection: handle `direction` and `up` being colinear","user":{"login":"ericwa","id":239161,"avatar_url":"https://avatars1.githubusercontent.com/u/239161?v=4","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"body":"This is invalid, but previously the camera state would get polluted with NAN's.\r\nNow it's handled by picking an arbitrary m_right that's perpendicular to the provided direction.\r\n\r\nFixes #1843","created_at":"2017-11-13T08:14:42Z","updated_at":"2017-11-13T11:49:59Z","closed_at":"2017-11-13T11:49:59Z","merged_at":"2017-11-13T11:49:59Z","merge_commit_sha":"946de23d6767d03dc1e94bbd8a149db86c64e696","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887/commits","review_comments_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887/comments","review_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/1887/comments","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/f818e47f17f84ac5e5d2b02ac1df68b9368b49f4","head":{"label":"kduske:feature/1843","ref":"feature/1843","sha":"f818e47f17f84ac5e5d2b02ac1df68b9368b49f4","user":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"repo":{"id":4003232,"name":"TrenchBroom","full_name":"kduske/TrenchBroom","owner":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kduske/TrenchBroom","description":"Cross-Platform Level Editor","fork":false,"url":"https://api.github.com/repos/kduske/TrenchBroom","forks_url":"https://api.github.com/repos/kduske/TrenchBroom/forks","keys_url":"https://api.github.com/repos/kduske/TrenchBroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kduske/TrenchBroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kduske/TrenchBroom/teams","hooks_url":"https://api.github.com/repos/kduske/TrenchBroom/hooks","issue_events_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/events{/number}","events_url":"https://api.github.com/repos/kduske/TrenchBroom/events","assignees_url":"https://api.github.com/repos/kduske/TrenchBroom/assignees{/user}","branches_url":"https://api.github.com/repos/kduske/TrenchBroom/branches{/branch}","tags_url":"https://api.github.com/repos/kduske/TrenchBroom/tags","blobs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kduske/TrenchBroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kduske/TrenchBroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/{sha}","languages_url":"https://api.github.com/repos/kduske/TrenchBroom/languages","stargazers_url":"https://api.github.com/repos/kduske/TrenchBroom/stargazers","contributors_url":"https://api.github.com/repos/kduske/TrenchBroom/contributors","subscribers_url":"https://api.github.com/repos/kduske/TrenchBroom/subscribers","subscription_url":"https://api.github.com/repos/kduske/TrenchBroom/subscription","commits_url":"https://api.github.com/repos/kduske/TrenchBroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kduske/TrenchBroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/kduske/TrenchBroom/contents/{+path}","compare_url":"https://api.github.com/repos/kduske/TrenchBroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kduske/TrenchBroom/merges","archive_url":"https://api.github.com/repos/kduske/TrenchBroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kduske/TrenchBroom/downloads","issues_url":"https://api.github.com/repos/kduske/TrenchBroom/issues{/number}","pulls_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls{/number}","milestones_url":"https://api.github.com/repos/kduske/TrenchBroom/milestones{/number}","notifications_url":"https://api.github.com/repos/kduske/TrenchBroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/labels{/name}","releases_url":"https://api.github.com/repos/kduske/TrenchBroom/releases{/id}","deployments_url":"https://api.github.com/repos/kduske/TrenchBroom/deployments","created_at":"2012-04-12T09:39:51Z","updated_at":"2017-11-11T18:34:47Z","pushed_at":"2017-11-13T11:49:59Z","git_url":"git://github.com/kduske/TrenchBroom.git","ssh_url":"git@github.com:kduske/TrenchBroom.git","clone_url":"https://github.com/kduske/TrenchBroom.git","svn_url":"https://github.com/kduske/TrenchBroom","homepage":"kristianduske.com/trenchbroom","size":110098,"stargazers_count":249,"watchers_count":249,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":233,"forks":34,"open_issues":233,"watchers":249,"default_branch":"master"}},"base":{"label":"kduske:release/v2.0.0","ref":"release/v2.0.0","sha":"7231c6b3345e9a9ba5d7ea853dd6d984406e5f4f","user":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"repo":{"id":4003232,"name":"TrenchBroom","full_name":"kduske/TrenchBroom","owner":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kduske/TrenchBroom","description":"Cross-Platform Level Editor","fork":false,"url":"https://api.github.com/repos/kduske/TrenchBroom","forks_url":"https://api.github.com/repos/kduske/TrenchBroom/forks","keys_url":"https://api.github.com/repos/kduske/TrenchBroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kduske/TrenchBroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kduske/TrenchBroom/teams","hooks_url":"https://api.github.com/repos/kduske/TrenchBroom/hooks","issue_events_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/events{/number}","events_url":"https://api.github.com/repos/kduske/TrenchBroom/events","assignees_url":"https://api.github.com/repos/kduske/TrenchBroom/assignees{/user}","branches_url":"https://api.github.com/repos/kduske/TrenchBroom/branches{/branch}","tags_url":"https://api.github.com/repos/kduske/TrenchBroom/tags","blobs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kduske/TrenchBroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kduske/TrenchBroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/{sha}","languages_url":"https://api.github.com/repos/kduske/TrenchBroom/languages","stargazers_url":"https://api.github.com/repos/kduske/TrenchBroom/stargazers","contributors_url":"https://api.github.com/repos/kduske/TrenchBroom/contributors","subscribers_url":"https://api.github.com/repos/kduske/TrenchBroom/subscribers","subscription_url":"https://api.github.com/repos/kduske/TrenchBroom/subscription","commits_url":"https://api.github.com/repos/kduske/TrenchBroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kduske/TrenchBroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/kduske/TrenchBroom/contents/{+path}","compare_url":"https://api.github.com/repos/kduske/TrenchBroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kduske/TrenchBroom/merges","archive_url":"https://api.github.com/repos/kduske/TrenchBroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kduske/TrenchBroom/downloads","issues_url":"https://api.github.com/repos/kduske/TrenchBroom/issues{/number}","pulls_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls{/number}","milestones_url":"https://api.github.com/repos/kduske/TrenchBroom/milestones{/number}","notifications_url":"https://api.github.com/repos/kduske/TrenchBroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/labels{/name}","releases_url":"https://api.github.com/repos/kduske/TrenchBroom/releases{/id}","deployments_url":"https://api.github.com/repos/kduske/TrenchBroom/deployments","created_at":"2012-04-12T09:39:51Z","updated_at":"2017-11-11T18:34:47Z","pushed_at":"2017-11-13T11:49:59Z","git_url":"git://github.com/kduske/TrenchBroom.git","ssh_url":"git@github.com:kduske/TrenchBroom.git","clone_url":"https://github.com/kduske/TrenchBroom.git","svn_url":"https://github.com/kduske/TrenchBroom","homepage":"kristianduske.com/trenchbroom","size":110098,"stargazers_count":249,"watchers_count":249,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":233,"forks":34,"open_issues":233,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887"},"html":{"href":"https://github.com/kduske/TrenchBroom/pull/1887"},"issue":{"href":"https://api.github.com/repos/kduske/TrenchBroom/issues/1887"},"comments":{"href":"https://api.github.com/repos/kduske/TrenchBroom/issues/1887/comments"},"review_comments":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887/comments"},"review_comment":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/1887/commits"},"statuses":{"href":"https://api.github.com/repos/kduske/TrenchBroom/statuses/f818e47f17f84ac5e5d2b02ac1df68b9368b49f4"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"kduske"}}