{"action":"created","comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/114249713","pull_request_review_id":35698988,"id":114249713,"diff_hunk":"@@ -10,6 +10,7 @@\n - Fish is now more forgiving of missing or invalid $TERM values (#3850).\n - The `string` command now supports a `repeat` subcommand with the obvious behavior (#3864).\n - The `string match` command now supports a `--filter` flag to emit the entire string partially matched by a pattern (#3957).\n+- The `string replace` command now supports a `--filter` flag to limit output to strings which underwent a replacement (#3348).","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"090a4c26f602c5f8c1638b56c95f4477c3f2af37","original_commit_id":"090a4c26f602c5f8c1638b56c95f4477c3f2af37","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars1.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"body":"Scratch that. I'm going to replace `-f`/`--filter` on `string match` with `-e`/`--entire`. Better to avoid any confusion about the `-f` short flag.","created_at":"2017-05-02T05:16:46Z","updated_at":"2017-05-02T05:16:46Z","html_url":"https://github.com/fish-shell/fish-shell/pull/3998#discussion_r114249713","pull_request_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998","_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/114249713"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/3998#discussion_r114249713"},"pull_request":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998"}}},"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998","id":118264968,"html_url":"https://github.com/fish-shell/fish-shell/pull/3998","diff_url":"https://github.com/fish-shell/fish-shell/pull/3998.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/3998.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3998","number":3998,"state":"open","locked":false,"title":"add `string replace --filter` flag","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars1.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"body":"Fixes #3348","created_at":"2017-04-29T06:52:22Z","updated_at":"2017-05-02T05:16:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e8ee388e63d23307eb0dc38f56d86a554fe4b97","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/16","html_url":"https://github.com/fish-shell/fish-shell/milestone/16","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/16/labels","id":2146982,"number":16,"title":"2.6.0","description":"The next minor release (2.6.0)","creator":{"login":"faho","id":5185367,"avatar_url":"https://avatars0.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":156,"state":"open","created_at":"2016-11-20T22:01:32Z","updated_at":"2017-05-01T04:23:01Z","due_on":"2017-04-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3998/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/090a4c26f602c5f8c1638b56c95f4477c3f2af37","head":{"label":"krader1961:string-replace-filter","ref":"string-replace-filter","sha":"090a4c26f602c5f8c1638b56c95f4477c3f2af37","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars1.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"repo":{"id":46686263,"name":"fish-shell","full_name":"krader1961/fish-shell","owner":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars1.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krader1961/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/krader1961/fish-shell","forks_url":"https://api.github.com/repos/krader1961/fish-shell/forks","keys_url":"https://api.github.com/repos/krader1961/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krader1961/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krader1961/fish-shell/teams","hooks_url":"https://api.github.com/repos/krader1961/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/krader1961/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/krader1961/fish-shell/events","assignees_url":"https://api.github.com/repos/krader1961/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/krader1961/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/krader1961/fish-shell/tags","blobs_url":"https://api.github.com/repos/krader1961/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krader1961/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krader1961/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/krader1961/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krader1961/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/krader1961/fish-shell/languages","stargazers_url":"https://api.github.com/repos/krader1961/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/krader1961/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/krader1961/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/krader1961/fish-shell/subscription","commits_url":"https://api.github.com/repos/krader1961/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/krader1961/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/krader1961/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/krader1961/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/krader1961/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/krader1961/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krader1961/fish-shell/merges","archive_url":"https://api.github.com/repos/krader1961/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krader1961/fish-shell/downloads","issues_url":"https://api.github.com/repos/krader1961/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/krader1961/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/krader1961/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/krader1961/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krader1961/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/krader1961/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/krader1961/fish-shell/deployments","created_at":"2015-11-22T23:46:18Z","updated_at":"2016-08-17T03:04:38Z","pushed_at":"2017-05-02T04:45:20Z","git_url":"git://github.com/krader1961/fish-shell.git","ssh_url":"git@github.com:krader1961/fish-shell.git","clone_url":"https://github.com/krader1961/fish-shell.git","svn_url":"https://github.com/krader1961/fish-shell","homepage":"http://fishshell.com","size":34722,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"65c762f1e1b23ebda5ff6e204e11af4441ffa094","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars3.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"name":"fish-shell","full_name":"fish-shell/fish-shell","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars3.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/fish-shell/fish-shell/deployments","created_at":"2012-05-10T03:00:55Z","updated_at":"2017-05-02T03:54:48Z","pushed_at":"2017-05-02T05:05:54Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":35510,"stargazers_count":7490,"watchers_count":7490,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":731,"mirror_url":null,"open_issues_count":426,"forks":731,"open_issues":426,"watchers":7490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/3998"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/3998"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/3998/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3998/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/090a4c26f602c5f8c1638b56c95f4477c3f2af37"}}}}
{"actor":{"display_login":"krader1961"}}