{"action":"created","issue":{"url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/47","repository_url":"https://api.github.com/repos/google/mobly-snippet-lib","labels_url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/47/comments","events_url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/47/events","html_url":"https://github.com/google/mobly-snippet-lib/pull/47","id":210194631,"number":47,"title":"Invoke RPCs on the main thread if they are tagged with @RpcMainThread.","user":{"login":"adorokhine","id":2999402,"avatar_url":"https://avatars0.githubusercontent.com/u/2999402?v=3","gravatar_id":"","url":"https://api.github.com/users/adorokhine","html_url":"https://github.com/adorokhine","followers_url":"https://api.github.com/users/adorokhine/followers","following_url":"https://api.github.com/users/adorokhine/following{/other_user}","gists_url":"https://api.github.com/users/adorokhine/gists{/gist_id}","starred_url":"https://api.github.com/users/adorokhine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorokhine/subscriptions","organizations_url":"https://api.github.com/users/adorokhine/orgs","repos_url":"https://api.github.com/users/adorokhine/repos","events_url":"https://api.github.com/users/adorokhine/events{/privacy}","received_events_url":"https://api.github.com/users/adorokhine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-02-25T00:43:52Z","updated_at":"2017-03-09T06:01:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/mobly-snippet-lib/pulls/47","html_url":"https://github.com/google/mobly-snippet-lib/pull/47","diff_url":"https://github.com/google/mobly-snippet-lib/pull/47.diff","patch_url":"https://github.com/google/mobly-snippet-lib/pull/47.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/mobly-snippet-lib/47)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/comments/285262879","html_url":"https://github.com/google/mobly-snippet-lib/pull/47#issuecomment-285262879","issue_url":"https://api.github.com/repos/google/mobly-snippet-lib/issues/47","id":285262879,"user":{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars0.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"created_at":"2017-03-09T06:01:58Z","updated_at":"2017-03-09T06:01:58Z","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java, line 141 at r2](https://reviewable.io:443/reviews/google/mobly-snippet-lib/47#-Keldn3J1zxUYhS3RCpY:-Keldn3J1zxUYhS3RCpZ:b-8ttic8) ([raw file](https://github.com/google/mobly-snippet-lib/blob/218432431e8b14692252c9ce9945d6088ff4c0e3/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java#L141)):*\n> ```Java\n>         final Constructor<? extends Snippet> constructor = clazz.getConstructor();\n>         if (constructor.isAnnotationPresent(RpcMainThread.class)) {\n>             Log.i(\"Constructing \" + clazz + \" on the main thread\");\n> ```\n\nShould this be Log.d?\n\n---\n\n*[third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java, line 159 at r2](https://reviewable.io:443/reviews/google/mobly-snippet-lib/47#-KeldryCisxySJfOFiST:-KeldryDSjgqCwKtAq1j:bm0qz2r) ([raw file](https://github.com/google/mobly-snippet-lib/blob/218432431e8b14692252c9ce9945d6088ff4c0e3/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java#L159)):*\n> ```Java\n>             throws Throwable {\n>         if (method.isAnnotationPresent(RpcMainThread.class)) {\n>             Log.i(\"Invoking RPC method \" + method + \" on the main thread\");\n> ```\n\nshould this be Log.d?\n\nDiscussed offline:\nLog the fully qualified class name instead of full function signature.\nAdd the same log for non-mainthread calls too.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/google/mobly-snippet-lib/47)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"xpconanfan"}}