{"action":"created","comment":{"url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments/95467953","pull_request_review_id":16023689,"id":95467953,"diff_hunk":"@@ -891,14 +891,27 @@ DmtcpCoordinator::processDmtUserCmd(DmtcpMessage &hello_remote,\n   }\n }\n \n+/*\n+ * Returns the current timestamp with nanosecond resolution\n+ */\n+static uint64_t\n+getCurrTimestamp()\n+{\n+  struct timespec value;\n+  uint64_t nsecs = 0;\n+  JASSERT(clock_gettime(CLOCK_MONOTONIC, &value) == 0);\n+  nsecs = value.tv_sec*100000000L + value.tv_nsec;","path":"src/dmtcp_coordinator.cpp","position":null,"original_position":13,"commit_id":"0a6ca22f1e44ea1b0e38792ed09a2fbec49ede02","original_commit_id":"23804a421997aee4353181434e97a752e4dd2715","user":{"login":"rohgarg","id":1672104,"avatar_url":"https://avatars.githubusercontent.com/u/1672104?v=3","gravatar_id":"","url":"https://api.github.com/users/rohgarg","html_url":"https://github.com/rohgarg","followers_url":"https://api.github.com/users/rohgarg/followers","following_url":"https://api.github.com/users/rohgarg/following{/other_user}","gists_url":"https://api.github.com/users/rohgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/rohgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohgarg/subscriptions","organizations_url":"https://api.github.com/users/rohgarg/orgs","repos_url":"https://api.github.com/users/rohgarg/repos","events_url":"https://api.github.com/users/rohgarg/events{/privacy}","received_events_url":"https://api.github.com/users/rohgarg/received_events","type":"User","site_admin":false},"body":"Good catch! I have updated the PR now and fixed a similar bug in `UniquePid::ThisProcess()` where we were using the same code.","created_at":"2017-01-10T22:02:42Z","updated_at":"2017-01-10T22:02:42Z","html_url":"https://github.com/dmtcp/dmtcp/pull/513#discussion_r95467953","pull_request_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513","_links":{"self":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments/95467953"},"html":{"href":"https://github.com/dmtcp/dmtcp/pull/513#discussion_r95467953"},"pull_request":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513","id":100956559,"html_url":"https://github.com/dmtcp/dmtcp/pull/513","diff_url":"https://github.com/dmtcp/dmtcp/pull/513.diff","patch_url":"https://github.com/dmtcp/dmtcp/pull/513.patch","issue_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/513","number":513,"state":"open","locked":false,"title":"dmtcp_coordinator: Use higher resolution timer for coordTimeStamp","user":{"login":"rohgarg","id":1672104,"avatar_url":"https://avatars.githubusercontent.com/u/1672104?v=3","gravatar_id":"","url":"https://api.github.com/users/rohgarg","html_url":"https://github.com/rohgarg","followers_url":"https://api.github.com/users/rohgarg/followers","following_url":"https://api.github.com/users/rohgarg/following{/other_user}","gists_url":"https://api.github.com/users/rohgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/rohgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohgarg/subscriptions","organizations_url":"https://api.github.com/users/rohgarg/orgs","repos_url":"https://api.github.com/users/rohgarg/repos","events_url":"https://api.github.com/users/rohgarg/events{/privacy}","received_events_url":"https://api.github.com/users/rohgarg/received_events","type":"User","site_admin":false},"body":"An issue was observed where multiple parallel launches/restarts of independent computations on a single node would up using the incorrect shared-data files. The reason was that since a shared-data file's name is generated using the following tuple: _<hostid, virt. pid, coordinator timestamp>_, multiple independent coordinators would end up generating the same values when they were launched in parallel.\r\n\r\nThe fix is to use a nanosecond resolution timer for generating the coordinator timestamp. Although this doesn't fix the issue entirely, it does reduce the chances of two independently launched computations on a node mapping the same shared-data file. ","created_at":"2017-01-10T21:25:23Z","updated_at":"2017-01-10T22:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46a7aa7e508342f8f679a7f36383896da093d1ae","assignee":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"assignees":[{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},{"login":"gc00","id":1207321,"avatar_url":"https://avatars.githubusercontent.com/u/1207321?v=3","gravatar_id":"","url":"https://api.github.com/users/gc00","html_url":"https://github.com/gc00","followers_url":"https://api.github.com/users/gc00/followers","following_url":"https://api.github.com/users/gc00/following{/other_user}","gists_url":"https://api.github.com/users/gc00/gists{/gist_id}","starred_url":"https://api.github.com/users/gc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc00/subscriptions","organizations_url":"https://api.github.com/users/gc00/orgs","repos_url":"https://api.github.com/users/gc00/repos","events_url":"https://api.github.com/users/gc00/events{/privacy}","received_events_url":"https://api.github.com/users/gc00/received_events","type":"User","site_admin":false},{"login":"jiajuncao","id":6911345,"avatar_url":"https://avatars.githubusercontent.com/u/6911345?v=3","gravatar_id":"","url":"https://api.github.com/users/jiajuncao","html_url":"https://github.com/jiajuncao","followers_url":"https://api.github.com/users/jiajuncao/followers","following_url":"https://api.github.com/users/jiajuncao/following{/other_user}","gists_url":"https://api.github.com/users/jiajuncao/gists{/gist_id}","starred_url":"https://api.github.com/users/jiajuncao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiajuncao/subscriptions","organizations_url":"https://api.github.com/users/jiajuncao/orgs","repos_url":"https://api.github.com/users/jiajuncao/repos","events_url":"https://api.github.com/users/jiajuncao/events{/privacy}","received_events_url":"https://api.github.com/users/jiajuncao/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dmtcp/dmtcp/milestones/11","html_url":"https://github.com/dmtcp/dmtcp/milestone/11","labels_url":"https://api.github.com/repos/dmtcp/dmtcp/milestones/11/labels","id":2222271,"number":11,"title":"2.5.1","description":"Next point release after 2.5.0","creator":{"login":"gc00","id":1207321,"avatar_url":"https://avatars.githubusercontent.com/u/1207321?v=3","gravatar_id":"","url":"https://api.github.com/users/gc00","html_url":"https://github.com/gc00","followers_url":"https://api.github.com/users/gc00/followers","following_url":"https://api.github.com/users/gc00/following{/other_user}","gists_url":"https://api.github.com/users/gc00/gists{/gist_id}","starred_url":"https://api.github.com/users/gc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc00/subscriptions","organizations_url":"https://api.github.com/users/gc00/orgs","repos_url":"https://api.github.com/users/gc00/repos","events_url":"https://api.github.com/users/gc00/events{/privacy}","received_events_url":"https://api.github.com/users/gc00/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2017-01-01T03:37:14Z","updated_at":"2017-01-10T21:25:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513/commits","review_comments_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513/comments","review_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/513/comments","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/0a6ca22f1e44ea1b0e38792ed09a2fbec49ede02","head":{"label":"rohgarg:fix-coordinfo-timstamp","ref":"fix-coordinfo-timstamp","sha":"0a6ca22f1e44ea1b0e38792ed09a2fbec49ede02","user":{"login":"rohgarg","id":1672104,"avatar_url":"https://avatars.githubusercontent.com/u/1672104?v=3","gravatar_id":"","url":"https://api.github.com/users/rohgarg","html_url":"https://github.com/rohgarg","followers_url":"https://api.github.com/users/rohgarg/followers","following_url":"https://api.github.com/users/rohgarg/following{/other_user}","gists_url":"https://api.github.com/users/rohgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/rohgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohgarg/subscriptions","organizations_url":"https://api.github.com/users/rohgarg/orgs","repos_url":"https://api.github.com/users/rohgarg/repos","events_url":"https://api.github.com/users/rohgarg/events{/privacy}","received_events_url":"https://api.github.com/users/rohgarg/received_events","type":"User","site_admin":false},"repo":{"id":30499837,"name":"dmtcp-1","full_name":"rohgarg/dmtcp-1","owner":{"login":"rohgarg","id":1672104,"avatar_url":"https://avatars.githubusercontent.com/u/1672104?v=3","gravatar_id":"","url":"https://api.github.com/users/rohgarg","html_url":"https://github.com/rohgarg","followers_url":"https://api.github.com/users/rohgarg/followers","following_url":"https://api.github.com/users/rohgarg/following{/other_user}","gists_url":"https://api.github.com/users/rohgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/rohgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohgarg/subscriptions","organizations_url":"https://api.github.com/users/rohgarg/orgs","repos_url":"https://api.github.com/users/rohgarg/repos","events_url":"https://api.github.com/users/rohgarg/events{/privacy}","received_events_url":"https://api.github.com/users/rohgarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohgarg/dmtcp-1","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":true,"url":"https://api.github.com/repos/rohgarg/dmtcp-1","forks_url":"https://api.github.com/repos/rohgarg/dmtcp-1/forks","keys_url":"https://api.github.com/repos/rohgarg/dmtcp-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohgarg/dmtcp-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohgarg/dmtcp-1/teams","hooks_url":"https://api.github.com/repos/rohgarg/dmtcp-1/hooks","issue_events_url":"https://api.github.com/repos/rohgarg/dmtcp-1/issues/events{/number}","events_url":"https://api.github.com/repos/rohgarg/dmtcp-1/events","assignees_url":"https://api.github.com/repos/rohgarg/dmtcp-1/assignees{/user}","branches_url":"https://api.github.com/repos/rohgarg/dmtcp-1/branches{/branch}","tags_url":"https://api.github.com/repos/rohgarg/dmtcp-1/tags","blobs_url":"https://api.github.com/repos/rohgarg/dmtcp-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohgarg/dmtcp-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohgarg/dmtcp-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohgarg/dmtcp-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohgarg/dmtcp-1/statuses/{sha}","languages_url":"https://api.github.com/repos/rohgarg/dmtcp-1/languages","stargazers_url":"https://api.github.com/repos/rohgarg/dmtcp-1/stargazers","contributors_url":"https://api.github.com/repos/rohgarg/dmtcp-1/contributors","subscribers_url":"https://api.github.com/repos/rohgarg/dmtcp-1/subscribers","subscription_url":"https://api.github.com/repos/rohgarg/dmtcp-1/subscription","commits_url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohgarg/dmtcp-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohgarg/dmtcp-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohgarg/dmtcp-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohgarg/dmtcp-1/contents/{+path}","compare_url":"https://api.github.com/repos/rohgarg/dmtcp-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohgarg/dmtcp-1/merges","archive_url":"https://api.github.com/repos/rohgarg/dmtcp-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohgarg/dmtcp-1/downloads","issues_url":"https://api.github.com/repos/rohgarg/dmtcp-1/issues{/number}","pulls_url":"https://api.github.com/repos/rohgarg/dmtcp-1/pulls{/number}","milestones_url":"https://api.github.com/repos/rohgarg/dmtcp-1/milestones{/number}","notifications_url":"https://api.github.com/repos/rohgarg/dmtcp-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohgarg/dmtcp-1/labels{/name}","releases_url":"https://api.github.com/repos/rohgarg/dmtcp-1/releases{/id}","deployments_url":"https://api.github.com/repos/rohgarg/dmtcp-1/deployments","created_at":"2015-02-08T17:56:51Z","updated_at":"2016-11-11T16:06:13Z","pushed_at":"2017-01-10T22:01:33Z","git_url":"git://github.com/rohgarg/dmtcp-1.git","ssh_url":"git@github.com:rohgarg/dmtcp-1.git","clone_url":"https://github.com/rohgarg/dmtcp-1.git","svn_url":"https://github.com/rohgarg/dmtcp-1","homepage":"http://dmtcp.sourceforge.net/","size":13971,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmtcp:master","ref":"master","sha":"a8cfd66664fdfda5d6cd5ffff4f1fbee50243d61","user":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"repo":{"id":24297650,"name":"dmtcp","full_name":"dmtcp/dmtcp","owner":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmtcp/dmtcp","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":false,"url":"https://api.github.com/repos/dmtcp/dmtcp","forks_url":"https://api.github.com/repos/dmtcp/dmtcp/forks","keys_url":"https://api.github.com/repos/dmtcp/dmtcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmtcp/dmtcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmtcp/dmtcp/teams","hooks_url":"https://api.github.com/repos/dmtcp/dmtcp/hooks","issue_events_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/events{/number}","events_url":"https://api.github.com/repos/dmtcp/dmtcp/events","assignees_url":"https://api.github.com/repos/dmtcp/dmtcp/assignees{/user}","branches_url":"https://api.github.com/repos/dmtcp/dmtcp/branches{/branch}","tags_url":"https://api.github.com/repos/dmtcp/dmtcp/tags","blobs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmtcp/dmtcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmtcp/dmtcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/{sha}","languages_url":"https://api.github.com/repos/dmtcp/dmtcp/languages","stargazers_url":"https://api.github.com/repos/dmtcp/dmtcp/stargazers","contributors_url":"https://api.github.com/repos/dmtcp/dmtcp/contributors","subscribers_url":"https://api.github.com/repos/dmtcp/dmtcp/subscribers","subscription_url":"https://api.github.com/repos/dmtcp/dmtcp/subscription","commits_url":"https://api.github.com/repos/dmtcp/dmtcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmtcp/dmtcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmtcp/dmtcp/contents/{+path}","compare_url":"https://api.github.com/repos/dmtcp/dmtcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmtcp/dmtcp/merges","archive_url":"https://api.github.com/repos/dmtcp/dmtcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmtcp/dmtcp/downloads","issues_url":"https://api.github.com/repos/dmtcp/dmtcp/issues{/number}","pulls_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls{/number}","milestones_url":"https://api.github.com/repos/dmtcp/dmtcp/milestones{/number}","notifications_url":"https://api.github.com/repos/dmtcp/dmtcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmtcp/dmtcp/labels{/name}","releases_url":"https://api.github.com/repos/dmtcp/dmtcp/releases{/id}","deployments_url":"https://api.github.com/repos/dmtcp/dmtcp/deployments","created_at":"2014-09-21T17:21:59Z","updated_at":"2017-01-09T10:33:02Z","pushed_at":"2017-01-10T22:01:35Z","git_url":"git://github.com/dmtcp/dmtcp.git","ssh_url":"git@github.com:dmtcp/dmtcp.git","clone_url":"https://github.com/dmtcp/dmtcp.git","svn_url":"https://github.com/dmtcp/dmtcp","homepage":"http://dmtcp.sourceforge.net/","size":14627,"stargazers_count":63,"watchers_count":63,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":134,"forks":38,"open_issues":134,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513"},"html":{"href":"https://github.com/dmtcp/dmtcp/pull/513"},"issue":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/513"},"comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/dmtcp/dmtcp/statuses/0a6ca22f1e44ea1b0e38792ed09a2fbec49ede02"}}}}
{"actor":{"display_login":"rohgarg"}}