{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/122566488","pull_request_review_id":44698230,"id":122566488,"diff_hunk":"@@ -1330,54 +1330,8 @@ void Network::ProcessPacket(NetworkConnection& connection, NetworkPacket& packet\n     packet.Clear();\n }\n \n-void Network::ProcessGameCommandQueue()\n-{\n-    while (game_command_queue.begin() != game_command_queue.end()) {\n-\n-        // run all the game commands at the current tick\n-        const GameCommand& gc = (*game_command_queue.begin());\n-\n-        // If our tick is higher than the command tick we are in trouble.\n-        if (mode == NETWORK_MODE_CLIENT) {\n-\n-            if (game_command_queue.begin()->tick < gCurrentTicks) {\n-                // Having old command from a tick where we have not been active yet or malicious server,\n-                // the command is useless so lets not keep it.\n-                game_command_queue.erase(game_command_queue.begin());\n-\n-                log_warning(\"Discarding game command from tick behind current tick, CMD: %08X, CMD Tick: %08X, Current Tick: %08X\\n\",\n-                            gc.esi,\n-                            gc.tick,\n-                            gCurrentTicks);\n+=======","path":"src/openrct2/network/network.cpp","position":23,"original_position":23,"commit_id":"be16f17fa30764c21d28f60165b7666bf1e25ae2","original_commit_id":"be16f17fa30764c21d28f60165b7666bf1e25ae2","user":{"login":"janisozaur","id":550290,"avatar_url":"https://avatars2.githubusercontent.com/u/550290?v=3","gravatar_id":"","url":"https://api.github.com/users/janisozaur","html_url":"https://github.com/janisozaur","followers_url":"https://api.github.com/users/janisozaur/followers","following_url":"https://api.github.com/users/janisozaur/following{/other_user}","gists_url":"https://api.github.com/users/janisozaur/gists{/gist_id}","starred_url":"https://api.github.com/users/janisozaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisozaur/subscriptions","organizations_url":"https://api.github.com/users/janisozaur/orgs","repos_url":"https://api.github.com/users/janisozaur/repos","events_url":"https://api.github.com/users/janisozaur/events{/privacy}","received_events_url":"https://api.github.com/users/janisozaur/received_events","type":"User","site_admin":false},"body":"Whole rebase went south.","created_at":"2017-06-17T11:03:23Z","updated_at":"2017-06-17T11:03:23Z","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5634#discussion_r122566488","pull_request_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634","_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/122566488"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/5634#discussion_r122566488"},"pull_request":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634","id":126022417,"html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5634","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5634.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5634.patch","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5634","number":5634,"state":"open","locked":false,"title":"Fixed game commands being directly executed from within network_update.","user":{"login":"ZehM4tt","id":5415177,"avatar_url":"https://avatars3.githubusercontent.com/u/5415177?v=3","gravatar_id":"","url":"https://api.github.com/users/ZehM4tt","html_url":"https://github.com/ZehM4tt","followers_url":"https://api.github.com/users/ZehM4tt/followers","following_url":"https://api.github.com/users/ZehM4tt/following{/other_user}","gists_url":"https://api.github.com/users/ZehM4tt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehM4tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehM4tt/subscriptions","organizations_url":"https://api.github.com/users/ZehM4tt/orgs","repos_url":"https://api.github.com/users/ZehM4tt/repos","events_url":"https://api.github.com/users/ZehM4tt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehM4tt/received_events","type":"User","site_admin":false},"body":"Refactored the network code to use the game command queue to not directly execute game commands from within network_update. This should also fix false positives when calling scenario_rand within game command callbacks.","created_at":"2017-06-16T12:27:40Z","updated_at":"2017-06-17T11:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d124b0d22381f58639192409b9b5fc528f74dd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634/commits","review_comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634/comments","review_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5634/comments","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/be16f17fa30764c21d28f60165b7666bf1e25ae2","head":{"label":"ZehM4tt:command-order-issue","ref":"command-order-issue","sha":"be16f17fa30764c21d28f60165b7666bf1e25ae2","user":{"login":"ZehM4tt","id":5415177,"avatar_url":"https://avatars3.githubusercontent.com/u/5415177?v=3","gravatar_id":"","url":"https://api.github.com/users/ZehM4tt","html_url":"https://github.com/ZehM4tt","followers_url":"https://api.github.com/users/ZehM4tt/followers","following_url":"https://api.github.com/users/ZehM4tt/following{/other_user}","gists_url":"https://api.github.com/users/ZehM4tt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehM4tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehM4tt/subscriptions","organizations_url":"https://api.github.com/users/ZehM4tt/orgs","repos_url":"https://api.github.com/users/ZehM4tt/repos","events_url":"https://api.github.com/users/ZehM4tt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehM4tt/received_events","type":"User","site_admin":false},"repo":{"id":93884749,"name":"OpenRCT2","full_name":"ZehM4tt/OpenRCT2","owner":{"login":"ZehM4tt","id":5415177,"avatar_url":"https://avatars3.githubusercontent.com/u/5415177?v=3","gravatar_id":"","url":"https://api.github.com/users/ZehM4tt","html_url":"https://github.com/ZehM4tt","followers_url":"https://api.github.com/users/ZehM4tt/followers","following_url":"https://api.github.com/users/ZehM4tt/following{/other_user}","gists_url":"https://api.github.com/users/ZehM4tt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehM4tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehM4tt/subscriptions","organizations_url":"https://api.github.com/users/ZehM4tt/orgs","repos_url":"https://api.github.com/users/ZehM4tt/repos","events_url":"https://api.github.com/users/ZehM4tt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehM4tt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZehM4tt/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":true,"url":"https://api.github.com/repos/ZehM4tt/OpenRCT2","forks_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/forks","keys_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/events","assignees_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/merges","archive_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/ZehM4tt/OpenRCT2/deployments","created_at":"2017-06-09T18:07:22Z","updated_at":"2017-06-09T18:07:27Z","pushed_at":"2017-06-17T10:54:54Z","git_url":"git://github.com/ZehM4tt/OpenRCT2.git","ssh_url":"git@github.com:ZehM4tt/OpenRCT2.git","clone_url":"https://github.com/ZehM4tt/OpenRCT2.git","svn_url":"https://github.com/ZehM4tt/OpenRCT2","homepage":"http://openrct2.website","size":52979,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenRCT2:develop","ref":"develop","sha":"7094bbf74a42d828c57b052f71b62d2657ba6590","user":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars3.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"repo":{"id":18348651,"name":"OpenRCT2","full_name":"OpenRCT2/OpenRCT2","owner":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars3.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRCT2/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":false,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","forks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/forks","keys_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/events","assignees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/merges","archive_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/deployments","created_at":"2014-04-01T23:32:25Z","updated_at":"2017-06-16T23:42:07Z","pushed_at":"2017-06-17T10:55:41Z","git_url":"git://github.com/OpenRCT2/OpenRCT2.git","ssh_url":"git@github.com:OpenRCT2/OpenRCT2.git","clone_url":"https://github.com/OpenRCT2/OpenRCT2.git","svn_url":"https://github.com/OpenRCT2/OpenRCT2","homepage":"http://openrct2.website","size":53097,"stargazers_count":2783,"watchers_count":2783,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":454,"mirror_url":null,"open_issues_count":627,"forks":454,"open_issues":627,"watchers":2783,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/5634"},"issue":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5634"},"comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5634/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5634/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/be16f17fa30764c21d28f60165b7666bf1e25ae2"}}}}
{"actor":{"display_login":"janisozaur"}}