{"action":"created","issue":{"url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/725","repository_url":"https://api.github.com/repos/dcodeIO/protobuf.js","labels_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/725/comments","events_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/725/events","html_url":"https://github.com/dcodeIO/protobuf.js/pull/725","id":216773070,"number":725,"title":"fix: pass output to callback if out is not a file","user":{"login":"joscha","id":188038,"avatar_url":"https://avatars0.githubusercontent.com/u/188038?v=3","gravatar_id":"","url":"https://api.github.com/users/joscha","html_url":"https://github.com/joscha","followers_url":"https://api.github.com/users/joscha/followers","following_url":"https://api.github.com/users/joscha/following{/other_user}","gists_url":"https://api.github.com/users/joscha/gists{/gist_id}","starred_url":"https://api.github.com/users/joscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscha/subscriptions","organizations_url":"https://api.github.com/users/joscha/orgs","repos_url":"https://api.github.com/users/joscha/repos","events_url":"https://api.github.com/users/joscha/events{/privacy}","received_events_url":"https://api.github.com/users/joscha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-24T12:36:19Z","updated_at":"2017-03-24T15:29:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/725","html_url":"https://github.com/dcodeIO/protobuf.js/pull/725","diff_url":"https://github.com/dcodeIO/protobuf.js/pull/725.diff","patch_url":"https://github.com/dcodeIO/protobuf.js/pull/725.patch"},"body":"Currently, the output is not passed to the callback if the output target is not a file. It is written to stdout even with programmatic access.\r\n\r\nThis pull request fixes that by only writing to stdout if invoked non-programmatically and only passing the output to the callback if the target is not a file.\r\n\r\nfixes #724 "},"comment":{"url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/comments/289055543","html_url":"https://github.com/dcodeIO/protobuf.js/pull/725#issuecomment-289055543","issue_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/725","id":289055543,"user":{"login":"dcodeIO","id":1136893,"avatar_url":"https://avatars3.githubusercontent.com/u/1136893?v=3","gravatar_id":"","url":"https://api.github.com/users/dcodeIO","html_url":"https://github.com/dcodeIO","followers_url":"https://api.github.com/users/dcodeIO/followers","following_url":"https://api.github.com/users/dcodeIO/following{/other_user}","gists_url":"https://api.github.com/users/dcodeIO/gists{/gist_id}","starred_url":"https://api.github.com/users/dcodeIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcodeIO/subscriptions","organizations_url":"https://api.github.com/users/dcodeIO/orgs","repos_url":"https://api.github.com/users/dcodeIO/repos","events_url":"https://api.github.com/users/dcodeIO/events{/privacy}","received_events_url":"https://api.github.com/users/dcodeIO/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T15:29:16Z","updated_at":"2017-03-24T15:29:16Z","body":"See: https://github.com/dcodeIO/protobuf.js/issues/724\r\n\r\nBasically, I applied your fix to both pbjs and pbts."}}
{"actor":{"display_login":"dcodeIO"}}