{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-java/pulls/comments/119902489","pull_request_review_id":41826705,"id":119902489,"diff_hunk":"@@ -82,8 +83,38 @@ public void basic() {\n      * if either arg is an int. That will cause sign extension.\n      */\n     @Test\n-    public void getters() {\n-        RealmInteger ri = new RealmInteger(0x5555444433332211L);\n+    public void unmanaged_getters() {","path":"realm/realm-library/src/androidTest/java/io/realm/RealmIntegerTests.java","position":31,"original_position":31,"commit_id":"da2f458b770492084564acb5ea24050a37748079","original_commit_id":"da2f458b770492084564acb5ea24050a37748079","user":{"login":"cmelchior","id":406066,"avatar_url":"https://avatars0.githubusercontent.com/u/406066?v=3","gravatar_id":"","url":"https://api.github.com/users/cmelchior","html_url":"https://github.com/cmelchior","followers_url":"https://api.github.com/users/cmelchior/followers","following_url":"https://api.github.com/users/cmelchior/following{/other_user}","gists_url":"https://api.github.com/users/cmelchior/gists{/gist_id}","starred_url":"https://api.github.com/users/cmelchior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmelchior/subscriptions","organizations_url":"https://api.github.com/users/cmelchior/orgs","repos_url":"https://api.github.com/users/cmelchior/repos","events_url":"https://api.github.com/users/cmelchior/events{/privacy}","received_events_url":"https://api.github.com/users/cmelchior/received_events","type":"User","site_admin":false},"body":"It is sorted into categories, by the function under test? In this case you get all `getters_<x>`, `setters_<x>` and so on instead of `unmanaged_<x>` and `managed_<x>`. You approach is isn't wrong as such and kinda makes sense since you have more heavy-weight unit tests than normal, but it just break the style of all other unit tests.","created_at":"2017-06-02T16:47:50Z","updated_at":"2017-06-02T16:47:50Z","html_url":"https://github.com/realm/realm-java/pull/4748#discussion_r119902489","pull_request_url":"https://api.github.com/repos/realm/realm-java/pulls/4748","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments/119902489"},"html":{"href":"https://github.com/realm/realm-java/pull/4748#discussion_r119902489"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4748"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-java/pulls/4748","id":123557228,"html_url":"https://github.com/realm/realm-java/pull/4748","diff_url":"https://github.com/realm/realm-java/pull/4748.diff","patch_url":"https://github.com/realm/realm-java/pull/4748.patch","issue_url":"https://api.github.com/repos/realm/realm-java/issues/4748","number":4748,"state":"open","locked":false,"title":"Managed and Unmanaged subclasses of RealmInteger; partial implementation of the proxy","user":{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false},"body":"Separate the base type RealmInteger into its Managed and Unmanaged subtypes.\r\n\r\nCreate begin the implementation of the proxy and fix the corresponding UTs.","created_at":"2017-06-01T17:53:54Z","updated_at":"2017-06-02T16:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c4318d9e4dd051b7472a1eed4970dac58c5df08","assignee":{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zaki50","id":406660,"avatar_url":"https://avatars2.githubusercontent.com/u/406660?v=3","gravatar_id":"","url":"https://api.github.com/users/zaki50","html_url":"https://github.com/zaki50","followers_url":"https://api.github.com/users/zaki50/followers","following_url":"https://api.github.com/users/zaki50/following{/other_user}","gists_url":"https://api.github.com/users/zaki50/gists{/gist_id}","starred_url":"https://api.github.com/users/zaki50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaki50/subscriptions","organizations_url":"https://api.github.com/users/zaki50/orgs","repos_url":"https://api.github.com/users/zaki50/repos","events_url":"https://api.github.com/users/zaki50/events{/privacy}","received_events_url":"https://api.github.com/users/zaki50/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-java/pulls/4748/commits","review_comments_url":"https://api.github.com/repos/realm/realm-java/pulls/4748/comments","review_comment_url":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-java/issues/4748/comments","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/da2f458b770492084564acb5ea24050a37748079","head":{"label":"realm:gbm/counters","ref":"gbm/counters","sha":"da2f458b770492084564acb5ea24050a37748079","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-06-02T10:45:03Z","pushed_at":"2017-06-02T14:02:37Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":52698,"stargazers_count":7812,"watchers_count":7812,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"open_issues_count":342,"forks":1220,"open_issues":342,"watchers":7812,"default_branch":"master"}},"base":{"label":"realm:feature/counters","ref":"feature/counters","sha":"a9444f946feeb6eb7e711dcadf5aa0e3d2b4e143","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-06-02T10:45:03Z","pushed_at":"2017-06-02T14:02:37Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":52698,"stargazers_count":7812,"watchers_count":7812,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"open_issues_count":342,"forks":1220,"open_issues":342,"watchers":7812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4748"},"html":{"href":"https://github.com/realm/realm-java/pull/4748"},"issue":{"href":"https://api.github.com/repos/realm/realm-java/issues/4748"},"comments":{"href":"https://api.github.com/repos/realm/realm-java/issues/4748/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4748/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4748/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-java/statuses/da2f458b770492084564acb5ea24050a37748079"}}}}
{"actor":{"display_login":"cmelchior"}}