{"push_id":1776325887,"size":13,"distinct_size":0,"ref":"refs/heads/master","head":"47f9d2a9451b125a48c4a9144be2176736530e6a","before":"e8e1cd988f1a9c519c78d8b07d61b2613538ada5","commits":[{"sha":"379b34ffdd316f067fdf985db0fdedf59b9ecea6","author":{"name":"Juan Pablo Ugarte","email":"490e983b26a17de383f2edd2e076655872a18ba7@endlessm.com"},"message":"Cards: remove bottom right arrow\n\nRemove bottom right arrow from deck, defaultFamily and list cards\n\nhttps://phabricator.endlessm.com/T17305","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/379b34ffdd316f067fdf985db0fdedf59b9ecea6"},{"sha":"d3115bfb8a1150409acca2527cb3033c96b41ff9","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"CSS/JS/UI - Fix default theme specs in modules\n\nRefactored a lot of the modules in hopes of detangling things.\n\nCSS\n\narrangement/_sideBySide.scss\n- Card.Title: fixed highlighted hover state issue & made font-weight: bold\n              $title-font\n              replaced $white-60-color with white 60%\n\nbanner/_app.scss\n- deleted composite font-size comment; unnecessary\n\nbanner/_context.scss\n- made this styling more in line with BannerSet and BannerSearch, and moved\n  previous styling into Layout.SideMenu__contextBar\n\nbanner/_dynamic.scss\n- deleted composite font-size comment; unnecessary\n\nbanner/_search.scss\n- title: color $primary-medium-color\n         deleted padding from &__title, and added margin-top to module\n- deleted background-color: transparent (not needed)\n\nbanner/_set.scss\n- cleaned up .CardTitle styling inside module\n- &__title: color: $primary-medium-color\n            font weight bold\n            added padding:0 and margin:0 to offset \".Card\" styling\n            added color: white styling to title when in .LayoutDynamicBackground\n\ncard/_base.scss\n- changed code to have each sub class have minimum font & color specs, with\n  further changes to individual cards defined in its own file\n- title: font $title-font\n         color $primary-medium-color\n- replaced $black-60-color with black 60%\n- deleted highlighted title color white\n\ncard/_deck.scss\n- deleted title color (defined in base)\n\ncard/_defaultFamily.scss\n- deleted title color (defined in base)\n\ncard/_knowledgeDocument.scss\n- deleted code for .DocumentCard title, and added padding to\n  toolbarFrame instead\n- replaced $black-60-color with black 60%\n- WebviewTooltip: background color from $black-60-color to black 60%\n                  label font $support-font instead of $display-font\n- deleted background-color: transparent from Table of Contents\n- InArticleSearch styling tweaked\n- added some .CardKnowledgeDocument styling to composite\n\ncard/_legacyPolaroid.scss\n- deleted title padding/color(defined in base)/highlighted styling\n- deleted synopsis padding & highlighted styling\n\ncard/_legacyPost.scss\n- title: font weight bold\n         color white\n         bg-color 60% black\n- $legacy-post-card-border-color: changed from black 70% to 100%\n\ncard/_list.scss\n- deleted title color (defined in base)\n- synopsis color black 60% instead of $black-60-color\n\ncard/_media.scss\n- card styling tweaked to reflect design specs, using new class selections\n  if both the attribution text & caption are visible\n\ncard/_title.scss\nDELETED! :)\n\ncard/_sequence.scss\n- deleted title color (defined in base)\n\ncard/_video.scss\n- deleted title color (defined in base)\n- synopsis color black 60% istead of $black-60-color\n\ncontentGroup/_contentGroup.scss\n- deleted CG.NoResultsMessage title padding\n- centralized all general CG styling in .ContentGroupContentGroup\n- adjusted &__trigger .ThemeableImage margins larger, delete image hover (does it\n  anyway)\n- added &__title_clickableStyle styling (for clickable title)\n- Deleted .search-page-suggestions, search-results, .no-results, .highlights,\n  .hierarchical-set.\n  Replaced with a new ContentGroup styling system. These new style classes are\n  aimed to make sense of the varying, and often overlapping, uses of\n  ContentGroups to a new set of eyes looking at our CSS and YAML files,\n  so the CG's may be styled individually for whatever the person may want, like\n  background, extra margin/padding, etc.\n  All of these classes are set in the YAML files, NOT in the JS files at the moment.\n  In the default theme, the only CSS properties defined by these class names are\n  spacing (margin/padding) of all these modules in relation to each other.\n  The naming system roughly follows its own BEM naming system. i.e.:\n  \"ContentGroup--highlightsset\" = Content Group (showing) Highlights (from a) Set.\n  Further note: `ContentGroup--outercontainer` is the only one that doesn't actually\n  have to be set to a Content Group module. It's intended to be set to the outer module\n  so that its internal modules are styled correctly.\n      - ContentGroup--outercontainer:\n        The parent container of content. This exists in order to properly space\n        the elements inside. For example, this can contain different content\n        groups, (or Card.ContentGroup's) and can control the padding and margin\n        of its children.\n      - ContentGroup--highlightsall:\n        A CG of highlights from entire app. Usually at the top of a page (but not\n        necessarily).\n      - ContentGroup--highlightsset:\n        A CG of highlights from a set of articles. Usually shown along with a\n        ContentGroup--highlightsall group (but not necessarily).\n      - ContentGroup--previewset:\n        A CG of a few articles from a set.\n      - ContentGroup--complementarycontent:\n        A CG of complementary content, usually either \"suggested\" or \"related\"\n        content.\n           - (Additionally:) LayoutResponsiveMargins--complementarycontent:\n             Is essentially the same as ContentGroup--complementarycontent, but for a\n             Layout.ResponsiveMargin module.\n             This is because some complementary content modules (like in Buffet & News)\n             are Layout.ResponsiveMargin modules, and in order to style correct margin/\n             padding, it can't be set on the actual Content Group. Once we get rid of\n             Layout.ResponsiveMargins, we can delete this class.\n      - ContentGroup--sets:\n        A CG of sets, either from the entire app, or subsets of the current set.\n      - ContentGroup--articles:\n        A CG of articles, either from the entire app, or from the current set.\n        Often are an arrangement.\n- added padding of 50px 0px to new class naming system.\n- took composite styling out of \"spinner\".\n\ncontentGroup/_mediaLightBox.scss\n- separated nav button \"navigationButton\" class into \"navigationButtonNext\" and\n  \"navigationButtonPrevious\"\n    - navigationButtonNext & navigationButtonPrevious:\n      - border radius: 50% sinstead of 27px\n      - bg-color white 15% instead of 20%\n      - hover bg-color white 30% instead of 40%\n    - gave navigationButtonNext & navigationButtonPrevious individual padding & margin\n- deleted shadow styling\n- LightboxContainer bg-color black 90%\n\ncontentGroup/_noResultsMessage.scss\n- font-family deleted\n- title: font $display-font\n         deleted padding\n- subtitle: font $body-font\n            font-style deleted\n            font-size 20px from 22px\n            padding-bottom deleted\n            margin-top added\n            color black 60% intead of $black-60-color\n- added padding when inside of .ContentGroupContainer\n- composite:\n      ContentGroup.NoResultsMessage title: $support-font-composite instead of $title-...\n                                    subtitle: $body-font-composite instead of $display...\n\ndocumentCard/_base.scss\n- deleted WebKitWebView styling\n\nlayout/_dynamicBackground.scss\n- added styling for BannerSet and BannerSearch color white when in this module\n\nlayout/_hamburgerBasement.scss\n- made $tab-button-background color $accent-light-color\n\nlayout/_sideMenu.scss\n- .Card__title: font $title-font\n- &__contextBar and &__menu box shadow fixed\n- &__contextBar bg-color instead of bg-image (no gradient)\n- &__menu: changed a lot of small styling in order to match design specs, including\n  internal .CardTitle styling and hover states, borders, margins, padding,\n  .ArrangementList margins, etc.\n- previous BannerContext styling moved into this file for this specific use case\n\nlayout/_sidebar.scss\n- .sidebar\n    - sidebar styling edited to follow same visuals as Layout.SideMenu (almost exact\n      same CSS as Layout.SideMenu, except for the CardTitle__title padding-left)\n    - CG.NoResultsMessage: added margin\n- .content\n    - deleted background gradient\n    - BannerSet/BannerSearch styling moved in here\n\nlayout/_topMenu.scss\n- menu: background-color $primary-dark-color instead of $primary-medium-color\n        box-shadow fixed\n\nnavigation/_searchBox.scss\n- .cell color: black 80% instead of $black-80-color\n- font $context-font instead of $display-font\n- border color black 20% instead of 19%\n- magnify glass margins adjusted, color black 40%\n\npager/_simple.scss\n- bg-color: $background-light-color. (This should be the main, default\n  background color for all page apps, and is the reason that background-color\n  has been taken out of almost all modules except this one. The Pager.Simple\n  subclasses, like .home-page, .set-page, etc., can layer over this.)\n\npager/_parallaxBackground.scss\n- added LayoutSidebar .sidebar margin\n\nwindow/_simple.scss\n- search-page separator code deleted (no longer needed in designs)\n- tweaked scrollbar styling\n\n---\n\nUI\n\ncard/media.ui\n- deleted GtkSeparator\n- got rid of row-spacing\n\ncontentGroup/_noResultsMessage.ui\n- parent widget: halign=start instead of center\n- message-title: \"halign\" property deleted (moved to template-level definition)\n- deleted GtkSeparator\n- message-subtitle: \"halign\" property deleted (moved to template-level definition)\n                    message text: deleted bullet points\n\nlayout/sideMenu.ui\n- made \"Home\" not all caps\n\n---\n\nJS\n\ncard/media.js\n- deleted \"separator\" child & code, deleted .toUpperCase() function from\n  attribution_label, added class 'CaptionAndAttrVisible' when both are visible\n\ncontentGroup/contentGroup.js\n- added style class \"title--clickable\" to title_button when there's a\n  trigger, so the color can be properly styled\n\ncontentGroup/noResultsMessage.js\n- deleted \"justify\" property on the module; doesn't work properly. Moved \"justify\"\n  definitions into UI file\n- edited _message_title.label, and deleted newline code from inside the label\n- trigger button valign: center\n\ncontentGroup/staticText.js\n- made staticText a FormattableLabel instead of simply Gtk.Label, in order to\n  allow text-transform CSS properties when needed\n\nlayout/dynamicBackground.js\n- changed default height to 140, so the default theme news app & travel app\n  doesn't align weirdly with the title on set pages\n\nwidgets/inArticleSearch.js\n- separated 'button' class into 'nextButton' and 'previousButton' classes\n\nwidgets/lightbox.js\n- made _ICON_SIZE smaller, changed button margins, add navigationButtonNext class\n\nhttps://phabricator.endlessm.com/T16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/d3115bfb8a1150409acca2527cb3033c96b41ff9"},{"sha":"354df43d4d51c60648a35995a58db99a34bd1bb9","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"CSS/YAML - Refactor templates to reflect default theme changes\n\nRefactoring the template YAML files and CSS override files to reflect changes\nin the default theme.\n\n- Mesh: Deleted completely, merged into preset_a, preset_b, and library_list;\n  preset_a, preset_b, and library_list refactored based on default theme changes\n- Buffet & News: Refactored based on default theme changes\n- Escola & Course: Did not touch; unsure of how these will be edited or merged\n  in future\n\nFurther note:\nIn a related commit where most of our module CSS is refactored to implement the default\ntheme, I started a little system for CSS classes for Content Groups, so a person doing\noverrides can make sense of all the content groups.\nHere is a paste of the explanation:\n\n  A new ContentGroup styling system. These new style classes are\n  aimed to make sense of the varying, and often overlapping, uses of\n  ContentGroups to a new set of eyes looking at our CSS and YAML files,\n  so the CG's may be styled individually for whatever the person may want, like\n  background, extra margin/padding, etc.\n  All of these classes are set in the YAML files, NOT in the JS files at the moment.\n  In the default theme, the only CSS properties defined by these class names are\n  spacing (margin/padding) of all these modules in relation to each other.\n  The naming system roughly follows its own BEM naming system. i.e.:\n  \"ContentGroup--highlightsset\" = Content Group (showing) Highlights (from a) Set.\n  Further note: `ContentGroup--outercontainer` is the only one that doesn't actually\n  have to be set to a Content Group module. It's intended to be set to the outer module\n  so that its internal modules are styled correctly.\n      - ContentGroup--outercontainer:\n        The parent container of content. This exists in order to properly space\n        the elements inside. For example, this can contain different content\n        groups, (or Card.ContentGroup's) and can control the padding and margin\n        of its children.\n      - ContentGroup--highlightsall:\n        A CG of highlights from entire app. Usually at the top of a page (but not\n        necessarily).\n      - ContentGroup--highlightsset:\n        A CG of highlights from a set of articles. Usually shown along with a\n        ContentGroup--highlightsall group (but not necessarily).\n      - ContentGroup--previewset:\n        A CG of a few articles from a set.\n      - ContentGroup--complementarycontent:\n        A CG of complementary content, usually either \"suggested\" or \"related\"\n        content.\n           - (Additionally:) LayoutResponsiveMargins--complementarycontent:\n             Is essentially the same as ContentGroup--complementarycontent, but for a\n             Layout.ResponsiveMargin module.\n             This is because some complementary content modules (like in Buffet & News)\n             are Layout.ResponsiveMargin modules, and in order to style correct margin/\n             padding, it can't be set on the actual Content Group. Once we get rid of\n             Layout.ResponsiveMargins, we can delete this class.\n      - ContentGroup--sets:\n        A CG of sets, either from the entire app, or subsets of the current set.\n      - ContentGroup--articles:\n        A CG of articles, either from the entire app, or from the current set.\n        Often are an arrangement.\n\nhttps://phabricator.endlessm.com/T16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/354df43d4d51c60648a35995a58db99a34bd1bb9"},{"sha":"8a69900601672369b7e6269a2ef9195e5a0aee36","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"CSS - Fix default theme specs in _typography and _colors\n\nDeleted some variables from the _typography.scss and _colors.scss\nfiles to reflect the designers' default theme specs\n\ntypography:\n- Add necessary fonts: $body-font-composite\n                       $logo-font-composite\n                       $context-font-composite\n                       $support-font-composite\n- Reorder $title-font & $body-font in code (Easier mental flow for\n  designers; trying to match design specs as closely as possible (in\n  specs, $body-font always comes first)\n\ncolors:\n- deleted $white-60-color, $black-20-color, $black-60-color, and\n  $black-80-color. These are constant values and it doesn't make\n  sense to have variables for them.\n- deleted $tab-background-color; this should be $accent-light-color anyway\n\nhttps://phabricator.endlessm.com/T16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/8a69900601672369b7e6269a2ef9195e5a0aee36"},{"sha":"fb2603c56e08651a067b6756d397afbd9481f133","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Makefile: delete card/_title.scss and _mesh.scss\n\nDeleted Card.Title and _mesh CSS files from Makefile\n\nhttps://phabricator.endlessm.com/T16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/fb2603c56e08651a067b6756d397afbd9481f133"},{"sha":"feee56b9dae72d1ec56e8020ed9299049e03c842","author":{"name":"Philip Chimento","email":"bdbe007522dbb5441efb474fa64f45edd80c8549@endlessm.com"},"message":"tests: Remove obsolete test of Card.Media separator\n\nThere is no separator any more, so the regression test is not needed.\n\nhttps://phabricator.endlessm.com/T16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/feee56b9dae72d1ec56e8020ed9299049e03c842"},{"sha":"a0613483e8ee2c02686f8ce550367d54e1de1c93","author":{"name":"Martin Abente Lahaye","email":"0383496b920d1886a1092cfbb6d2388b77c1e41a@gmail.com"},"message":"Merge pull request #1436 from endlessm/T17305\n\nT17305","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/a0613483e8ee2c02686f8ce550367d54e1de1c93"},{"sha":"5d78e47bb574cdc6c67dc59ec60eebf6ee4c3eac","author":{"name":"Kate Lassalle-Klein","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Merge pull request #1426 from endlessm/T16238\n\nT16238","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/5d78e47bb574cdc6c67dc59ec60eebf6ee4c3eac"},{"sha":"c1e94beae11f577baf641f64d6c3e5547cf4bfdd","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Card.DefaultFamily design tweaks\n\nSome design edits to Card.DefaultFamily to improve some spacing\nand responsiveness\n\nCSS\n- various styling changes\n- responsive styling given to .CardText, .CardPolaroid, .CardPost\n\nJS\n- Made various tweaks for correct responsiveness based on designs\n  in Card.Text, Card.Polaroid (previously called \"Card.Thumb\"), and\n  Card.Post\n- Card.Polaroid horizontal:\n    - Constraints are now based on the text, not the\n      thumbnail\n    - The text box is always half of the card until\n      after a certain width, the text box takes a static width\n- Card.Polaroid vertical:\n    - Text layout is always a static height based on the card height,\n      in CARD_POLAROID_VERTICAL_HEIGHTS\n- Card.Post\n- in vfunc_size_allocate, alloc.width and alloc.height don't take\n  into account the card margins, so use real_alloc_width and\n  real_alloc_height\n\nUI\n- changed text-layout class to CardDefaultFamily__content_grid\n  (to match Card.List content name)\n- synopsis-label halign=start, valign=start, xalign=0 to align\n  property\n- title-label halign=start, valign=start\n\nhttps://phabricator.endlessm.com/T15932","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/c1e94beae11f577baf641f64d6c3e5547cf4bfdd"},{"sha":"d3d3104085543e8c145e406661c5d8292a3108c8","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Card base CSS design tweaks\n\nSome tweaks to improve the card base CSS\n- deleted base font size\n- &__title, &__synopsis, and &__context font/colors defined\n- deleted responsive styling\n\nhttps://phabricator.endlessm.com/T15932","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/d3d3104085543e8c145e406661c5d8292a3108c8"},{"sha":"95af911b768a931c18d8621db2de4a95dea12ee6","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Card.List design tweaks\n\nVarious design tweaks to the List card\n\nCSS\n- Various design edits on title, content_grid, etc.\n- Responsive design tweaked\n\nJS\n- deleted render_border_with_arrow() function\n\nUI\n- made context labels from GtkLabel's to EknFormattableLabel's\n\nhttp://phabricator.endlessm.com/T15932","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/95af911b768a931c18d8621db2de4a95dea12ee6"},{"sha":"590f5d19f3f1757d3a883bb86d30e282420ac9c2","author":{"name":"katelk28","email":"2e4ff5f088b39f9b64da499e23f7db3b0693d098@gmail.com"},"message":"Context widget (SpaceContainer widget) halign = start\n\nThis was messing up the context widget and making its halign property change from\nGtk.Align.START to Gtk.Align.CENTER when the card is minimized to a certain size,\nespecially when used in the Constrained Arrangement. The halign property for\ncontext should be Gtk.Align.START unless otherwise specified.\n\nhttp://phabricator.endlessm.com/T15932","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/590f5d19f3f1757d3a883bb86d30e282420ac9c2"},{"sha":"47f9d2a9451b125a48c4a9144be2176736530e6a","author":{"name":"Martin Abente Lahaye","email":"0383496b920d1886a1092cfbb6d2388b77c1e41a@gmail.com"},"message":"Merge pull request #1432 from endlessm/T15932\n\nT15932","distinct":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits/47f9d2a9451b125a48c4a9144be2176736530e6a"}]}
{"actor":{"display_login":"ebassi"}}