{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5559","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5559/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5559/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5559/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/5559","id":276216923,"number":5559,"title":"Fix for default test config file","user":{"login":"yennster","id":6963725,"avatar_url":"https://avatars2.githubusercontent.com/u/6963725?v=4","gravatar_id":"","url":"https://api.github.com/users/yennster","html_url":"https://github.com/yennster","followers_url":"https://api.github.com/users/yennster/followers","following_url":"https://api.github.com/users/yennster/following{/other_user}","gists_url":"https://api.github.com/users/yennster/gists{/gist_id}","starred_url":"https://api.github.com/users/yennster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yennster/subscriptions","organizations_url":"https://api.github.com/users/yennster/orgs","repos_url":"https://api.github.com/users/yennster/repos","events_url":"https://api.github.com/users/yennster/events{/privacy}","received_events_url":"https://api.github.com/users/yennster/received_events","type":"User","site_admin":false},"labels":[{"id":144902129,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-11-22T22:05:10Z","updated_at":"2017-12-07T13:47:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/5559","html_url":"https://github.com/ARMmbed/mbed-os/pull/5559","diff_url":"https://github.com/ARMmbed/mbed-os/pull/5559.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/5559.patch"},"body":"## Description\r\n\r\nRelated issue: https://github.com/ARMmbed/mbed-os/issues/5543\r\n\r\nThis change allows for `mbed test` to build with an `mbed_app.json` file by default if one exists in the project's root directory (i.e. for running the [ci-test-shield tests](https://github.com/ARMmbed/ci-test-shield)). However, if the `mbed_app.json` file is not in the root directory, then it's location needs to be specified in the command with the `--app-config` parameter.\r\n\r\n## Steps to test or reproduce\r\n\r\n**Before fix:**\r\nIf you run the [ci-test-shield tests](https://github.com/ARMmbed/ci-test-shield) with `mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile` without a specified `--app-config` you get the following errors related to the unspecified `mbed_app.json`:\r\n```\r\n        [Error] Mixed.cpp@68,22: 'MBED_CONF_APP_I2C_SDA' was not declared in this scope\r\n        [Error] Mixed.cpp@68,44: 'MBED_CONF_APP_I2C_SCL' was not declared in this scope\r\n        [Error] Mixed.cpp@68,66: 'MBED_CONF_APP_I2C_EEPROM_ADDR' was not declared in this scope\r\n        ...\r\n```\r\n\r\n**After fix:**\r\nIf you run the [ci-test-shield tests](https://github.com/ARMmbed/ci-test-shield) with `mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile` without a specified `--app-config`, if there exists an `mbed_app.json` in the root directory of the project then the tests compile and run successfully."},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/349971370","html_url":"https://github.com/ARMmbed/mbed-os/pull/5559#issuecomment-349971370","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5559","id":349971370,"user":{"login":"jeromecoutant","id":12710147,"avatar_url":"https://avatars2.githubusercontent.com/u/12710147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromecoutant","html_url":"https://github.com/jeromecoutant","followers_url":"https://api.github.com/users/jeromecoutant/followers","following_url":"https://api.github.com/users/jeromecoutant/following{/other_user}","gists_url":"https://api.github.com/users/jeromecoutant/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromecoutant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromecoutant/subscriptions","organizations_url":"https://api.github.com/users/jeromecoutant/orgs","repos_url":"https://api.github.com/users/jeromecoutant/repos","events_url":"https://api.github.com/users/jeromecoutant/events{/privacy}","received_events_url":"https://api.github.com/users/jeromecoutant/received_events","type":"User","site_admin":false},"created_at":"2017-12-07T13:47:26Z","updated_at":"2017-12-07T13:47:26Z","author_association":"CONTRIBUTOR","body":"Minor question about the TODO comment https://github.com/yennster/mbed-os/blob/b3ba9a55b900058c3317f707bc867c91ff70fb84/tools/test.py#L141\r\n\r\nIs this patch correcting it ?\r\n\r\n"}}
{"actor":{"display_login":"jeromecoutant"}}