{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/OpenMined/Sonar/pulls/15","id":136615882,"html_url":"https://github.com/OpenMined/Sonar/pull/15","diff_url":"https://github.com/OpenMined/Sonar/pull/15.diff","patch_url":"https://github.com/OpenMined/Sonar/pull/15.patch","issue_url":"https://api.github.com/repos/OpenMined/Sonar/issues/15","number":15,"state":"closed","locked":false,"title":"Includes ethereumjs-testrpc in dev dependencies","user":{"login":"carrollgt91","id":1665058,"avatar_url":"https://avatars0.githubusercontent.com/u/1665058?v=4","gravatar_id":"","url":"https://api.github.com/users/carrollgt91","html_url":"https://github.com/carrollgt91","followers_url":"https://api.github.com/users/carrollgt91/followers","following_url":"https://api.github.com/users/carrollgt91/following{/other_user}","gists_url":"https://api.github.com/users/carrollgt91/gists{/gist_id}","starred_url":"https://api.github.com/users/carrollgt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrollgt91/subscriptions","organizations_url":"https://api.github.com/users/carrollgt91/orgs","repos_url":"https://api.github.com/users/carrollgt91/repos","events_url":"https://api.github.com/users/carrollgt91/events{/privacy}","received_events_url":"https://api.github.com/users/carrollgt91/received_events","type":"User","site_admin":false},"body":"For some reason, the global install was failing to actually put the required executable in the `node_modules/.bin` directory. This fixes that issue by adding the package to Sonar's `devDependenices` instead. Also, this will allow us to version control the version of `testrpc` we use in that image, leading to more stable builds.","created_at":"2017-08-19T18:02:00Z","updated_at":"2017-08-19T18:04:55Z","closed_at":"2017-08-19T18:04:55Z","merged_at":null,"merge_commit_sha":"e59c9e9b836d5e7444aefc7f708a95d4961ede75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMined/Sonar/pulls/15/commits","review_comments_url":"https://api.github.com/repos/OpenMined/Sonar/pulls/15/comments","review_comment_url":"https://api.github.com/repos/OpenMined/Sonar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMined/Sonar/issues/15/comments","statuses_url":"https://api.github.com/repos/OpenMined/Sonar/statuses/4ca530b163d78bcd1a724f1da236a9bc0eba06d4","head":{"label":"carrollgt91:testrpc-build-fix","ref":"testrpc-build-fix","sha":"4ca530b163d78bcd1a724f1da236a9bc0eba06d4","user":{"login":"carrollgt91","id":1665058,"avatar_url":"https://avatars0.githubusercontent.com/u/1665058?v=4","gravatar_id":"","url":"https://api.github.com/users/carrollgt91","html_url":"https://github.com/carrollgt91","followers_url":"https://api.github.com/users/carrollgt91/followers","following_url":"https://api.github.com/users/carrollgt91/following{/other_user}","gists_url":"https://api.github.com/users/carrollgt91/gists{/gist_id}","starred_url":"https://api.github.com/users/carrollgt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrollgt91/subscriptions","organizations_url":"https://api.github.com/users/carrollgt91/orgs","repos_url":"https://api.github.com/users/carrollgt91/repos","events_url":"https://api.github.com/users/carrollgt91/events{/privacy}","received_events_url":"https://api.github.com/users/carrollgt91/received_events","type":"User","site_admin":false},"repo":{"id":100809392,"name":"Sonar","full_name":"carrollgt91/Sonar","owner":{"login":"carrollgt91","id":1665058,"avatar_url":"https://avatars0.githubusercontent.com/u/1665058?v=4","gravatar_id":"","url":"https://api.github.com/users/carrollgt91","html_url":"https://github.com/carrollgt91","followers_url":"https://api.github.com/users/carrollgt91/followers","following_url":"https://api.github.com/users/carrollgt91/following{/other_user}","gists_url":"https://api.github.com/users/carrollgt91/gists{/gist_id}","starred_url":"https://api.github.com/users/carrollgt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrollgt91/subscriptions","organizations_url":"https://api.github.com/users/carrollgt91/orgs","repos_url":"https://api.github.com/users/carrollgt91/repos","events_url":"https://api.github.com/users/carrollgt91/events{/privacy}","received_events_url":"https://api.github.com/users/carrollgt91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carrollgt91/Sonar","description":"Blockchain Federated Learning Smart Contracts","fork":true,"url":"https://api.github.com/repos/carrollgt91/Sonar","forks_url":"https://api.github.com/repos/carrollgt91/Sonar/forks","keys_url":"https://api.github.com/repos/carrollgt91/Sonar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carrollgt91/Sonar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carrollgt91/Sonar/teams","hooks_url":"https://api.github.com/repos/carrollgt91/Sonar/hooks","issue_events_url":"https://api.github.com/repos/carrollgt91/Sonar/issues/events{/number}","events_url":"https://api.github.com/repos/carrollgt91/Sonar/events","assignees_url":"https://api.github.com/repos/carrollgt91/Sonar/assignees{/user}","branches_url":"https://api.github.com/repos/carrollgt91/Sonar/branches{/branch}","tags_url":"https://api.github.com/repos/carrollgt91/Sonar/tags","blobs_url":"https://api.github.com/repos/carrollgt91/Sonar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carrollgt91/Sonar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carrollgt91/Sonar/git/refs{/sha}","trees_url":"https://api.github.com/repos/carrollgt91/Sonar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carrollgt91/Sonar/statuses/{sha}","languages_url":"https://api.github.com/repos/carrollgt91/Sonar/languages","stargazers_url":"https://api.github.com/repos/carrollgt91/Sonar/stargazers","contributors_url":"https://api.github.com/repos/carrollgt91/Sonar/contributors","subscribers_url":"https://api.github.com/repos/carrollgt91/Sonar/subscribers","subscription_url":"https://api.github.com/repos/carrollgt91/Sonar/subscription","commits_url":"https://api.github.com/repos/carrollgt91/Sonar/commits{/sha}","git_commits_url":"https://api.github.com/repos/carrollgt91/Sonar/git/commits{/sha}","comments_url":"https://api.github.com/repos/carrollgt91/Sonar/comments{/number}","issue_comment_url":"https://api.github.com/repos/carrollgt91/Sonar/issues/comments{/number}","contents_url":"https://api.github.com/repos/carrollgt91/Sonar/contents/{+path}","compare_url":"https://api.github.com/repos/carrollgt91/Sonar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carrollgt91/Sonar/merges","archive_url":"https://api.github.com/repos/carrollgt91/Sonar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carrollgt91/Sonar/downloads","issues_url":"https://api.github.com/repos/carrollgt91/Sonar/issues{/number}","pulls_url":"https://api.github.com/repos/carrollgt91/Sonar/pulls{/number}","milestones_url":"https://api.github.com/repos/carrollgt91/Sonar/milestones{/number}","notifications_url":"https://api.github.com/repos/carrollgt91/Sonar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carrollgt91/Sonar/labels{/name}","releases_url":"https://api.github.com/repos/carrollgt91/Sonar/releases{/id}","deployments_url":"https://api.github.com/repos/carrollgt91/Sonar/deployments","created_at":"2017-08-19T17:12:55Z","updated_at":"2017-08-19T17:12:56Z","pushed_at":"2017-08-19T18:00:25Z","git_url":"git://github.com/carrollgt91/Sonar.git","ssh_url":"git@github.com:carrollgt91/Sonar.git","clone_url":"https://github.com/carrollgt91/Sonar.git","svn_url":"https://github.com/carrollgt91/Sonar","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenMined:develop","ref":"develop","sha":"563192a5ebf0f52823ca92759ced45bf1caef34e","user":{"login":"OpenMined","id":30185530,"avatar_url":"https://avatars3.githubusercontent.com/u/30185530?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMined","html_url":"https://github.com/OpenMined","followers_url":"https://api.github.com/users/OpenMined/followers","following_url":"https://api.github.com/users/OpenMined/following{/other_user}","gists_url":"https://api.github.com/users/OpenMined/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMined/subscriptions","organizations_url":"https://api.github.com/users/OpenMined/orgs","repos_url":"https://api.github.com/users/OpenMined/repos","events_url":"https://api.github.com/users/OpenMined/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMined/received_events","type":"Organization","site_admin":false},"repo":{"id":98747522,"name":"Sonar","full_name":"OpenMined/Sonar","owner":{"login":"OpenMined","id":30185530,"avatar_url":"https://avatars3.githubusercontent.com/u/30185530?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMined","html_url":"https://github.com/OpenMined","followers_url":"https://api.github.com/users/OpenMined/followers","following_url":"https://api.github.com/users/OpenMined/following{/other_user}","gists_url":"https://api.github.com/users/OpenMined/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMined/subscriptions","organizations_url":"https://api.github.com/users/OpenMined/orgs","repos_url":"https://api.github.com/users/OpenMined/repos","events_url":"https://api.github.com/users/OpenMined/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMined/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMined/Sonar","description":"Blockchain Federated Learning Smart Contracts","fork":false,"url":"https://api.github.com/repos/OpenMined/Sonar","forks_url":"https://api.github.com/repos/OpenMined/Sonar/forks","keys_url":"https://api.github.com/repos/OpenMined/Sonar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMined/Sonar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMined/Sonar/teams","hooks_url":"https://api.github.com/repos/OpenMined/Sonar/hooks","issue_events_url":"https://api.github.com/repos/OpenMined/Sonar/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMined/Sonar/events","assignees_url":"https://api.github.com/repos/OpenMined/Sonar/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMined/Sonar/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMined/Sonar/tags","blobs_url":"https://api.github.com/repos/OpenMined/Sonar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMined/Sonar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMined/Sonar/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMined/Sonar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMined/Sonar/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMined/Sonar/languages","stargazers_url":"https://api.github.com/repos/OpenMined/Sonar/stargazers","contributors_url":"https://api.github.com/repos/OpenMined/Sonar/contributors","subscribers_url":"https://api.github.com/repos/OpenMined/Sonar/subscribers","subscription_url":"https://api.github.com/repos/OpenMined/Sonar/subscription","commits_url":"https://api.github.com/repos/OpenMined/Sonar/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMined/Sonar/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMined/Sonar/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMined/Sonar/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMined/Sonar/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMined/Sonar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMined/Sonar/merges","archive_url":"https://api.github.com/repos/OpenMined/Sonar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMined/Sonar/downloads","issues_url":"https://api.github.com/repos/OpenMined/Sonar/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMined/Sonar/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMined/Sonar/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMined/Sonar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMined/Sonar/labels{/name}","releases_url":"https://api.github.com/repos/OpenMined/Sonar/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMined/Sonar/deployments","created_at":"2017-07-29T17:10:15Z","updated_at":"2017-08-19T11:59:23Z","pushed_at":"2017-08-19T18:02:00Z","git_url":"git://github.com/OpenMined/Sonar.git","ssh_url":"git@github.com:OpenMined/Sonar.git","clone_url":"https://github.com/OpenMined/Sonar.git","svn_url":"https://github.com/OpenMined/Sonar","homepage":null,"size":35,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":11,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMined/Sonar/pulls/15"},"html":{"href":"https://github.com/OpenMined/Sonar/pull/15"},"issue":{"href":"https://api.github.com/repos/OpenMined/Sonar/issues/15"},"comments":{"href":"https://api.github.com/repos/OpenMined/Sonar/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMined/Sonar/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMined/Sonar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMined/Sonar/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMined/Sonar/statuses/4ca530b163d78bcd1a724f1da236a9bc0eba06d4"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"carrollgt91"}}