{"action":"created","issue":{"url":"https://api.github.com/repos/mapsforge/vtm/issues/343","repository_url":"https://api.github.com/repos/mapsforge/vtm","labels_url":"https://api.github.com/repos/mapsforge/vtm/issues/343/labels{/name}","comments_url":"https://api.github.com/repos/mapsforge/vtm/issues/343/comments","events_url":"https://api.github.com/repos/mapsforge/vtm/issues/343/events","html_url":"https://github.com/mapsforge/vtm/issues/343","id":217812325,"number":343,"title":"Short-overflow with Maprenderer.COORD_SCALE = 8","user":{"login":"Longri","id":2542295,"avatar_url":"https://avatars1.githubusercontent.com/u/2542295?v=3","gravatar_id":"","url":"https://api.github.com/users/Longri","html_url":"https://github.com/Longri","followers_url":"https://api.github.com/users/Longri/followers","following_url":"https://api.github.com/users/Longri/following{/other_user}","gists_url":"https://api.github.com/users/Longri/gists{/gist_id}","starred_url":"https://api.github.com/users/Longri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Longri/subscriptions","organizations_url":"https://api.github.com/users/Longri/orgs","repos_url":"https://api.github.com/users/Longri/repos","events_url":"https://api.github.com/users/Longri/events{/privacy}","received_events_url":"https://api.github.com/users/Longri/received_events","type":"User","site_admin":false},"labels":[{"id":393152176,"url":"https://api.github.com/repos/mapsforge/vtm/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-03-29T09:12:49Z","updated_at":"2017-03-29T19:08:57Z","closed_at":null,"body":"I do not know exactly how I should describe it, but there is a problem with devices that have a high resolution.\r\n\r\nI've been looking for a long time until I find the cause.\r\nMy Galaxy Note 4 has a resolution of 2240 * 1440 pixels.\r\nFor a tilt view (tilt >30), the function mMarkerLayer.map().viewport().getMapExtents(mBox, mExtents);  returns a  BoundingBox of\r\n0 = 497.63928\r\n1 = 1762.7147\r\n2 = -497.63928\r\n3 = 1762.7147\r\n4 = -1560.3398\r\n5 = -5526.964\r\n6 = 1560.3398\r\n7 = -5526.964\r\nThese values are also correct, but too large to multiply them with a COORD_SCALE and then cast them to a short.\r\n(-5526.964 * 8 = -44215.712 (short) = 21321)\r\n\r\nNow I see two possibilities.\r\n1. Clamp to Short.Max_Value! But that leads to that some things are not represented correctly.\r\n2. Decrease the value Maprenderer.COORD_SCALE = 8. This will break the API.\r\n\r\nI would prefer 2. But I know you have something against with break the API.\r\n\r\nA simple change of the one value does not help, however, because this scale factor (8) is also hard-coded at other places.\r\neg. In the SymbolBucket (private final static float SCALE = 8.0f;)\r\n\r\nI think however that it is the cleanest way, if this change is properly documented and the users, with an update, are informed about this.\r\n\r\nAnother point would be to ask @hjanetzek why this scale factor is so high, or for which he is there at all.\r\n\r\nI once made a video of my Note4 (with Cruiser-GL) to illustrate the problem!\r\nhttps://youtu.be/eaSmttPiBh4\r\n"},"comment":{"url":"https://api.github.com/repos/mapsforge/vtm/issues/comments/290194240","html_url":"https://github.com/mapsforge/vtm/issues/343#issuecomment-290194240","issue_url":"https://api.github.com/repos/mapsforge/vtm/issues/343","id":290194240,"user":{"login":"devemux86","id":3484020,"avatar_url":"https://avatars2.githubusercontent.com/u/3484020?v=3","gravatar_id":"","url":"https://api.github.com/users/devemux86","html_url":"https://github.com/devemux86","followers_url":"https://api.github.com/users/devemux86/followers","following_url":"https://api.github.com/users/devemux86/following{/other_user}","gists_url":"https://api.github.com/users/devemux86/gists{/gist_id}","starred_url":"https://api.github.com/users/devemux86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devemux86/subscriptions","organizations_url":"https://api.github.com/users/devemux86/orgs","repos_url":"https://api.github.com/users/devemux86/repos","events_url":"https://api.github.com/users/devemux86/events{/privacy}","received_events_url":"https://api.github.com/users/devemux86/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T19:08:56Z","updated_at":"2017-03-29T19:08:56Z","body":"@Longri are you testing on all platforms and preferably on high + low dpi screens?"}}
{"actor":{"display_login":"devemux86"}}