{"action":"created","issue":{"url":"https://api.github.com/repos/mockito/shipkit/issues/368","repository_url":"https://api.github.com/repos/mockito/shipkit","labels_url":"https://api.github.com/repos/mockito/shipkit/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/mockito/shipkit/issues/368/comments","events_url":"https://api.github.com/repos/mockito/shipkit/issues/368/events","html_url":"https://github.com/mockito/shipkit/issues/368","id":253117010,"number":368,"title":"Task that generates pull requests uses hardcoded values","user":{"login":"szczepiq","id":24743,"avatar_url":"https://avatars2.githubusercontent.com/u/24743?v=4","gravatar_id":"","url":"https://api.github.com/users/szczepiq","html_url":"https://github.com/szczepiq","followers_url":"https://api.github.com/users/szczepiq/followers","following_url":"https://api.github.com/users/szczepiq/following{/other_user}","gists_url":"https://api.github.com/users/szczepiq/gists{/gist_id}","starred_url":"https://api.github.com/users/szczepiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szczepiq/subscriptions","organizations_url":"https://api.github.com/users/szczepiq/orgs","repos_url":"https://api.github.com/users/szczepiq/repos","events_url":"https://api.github.com/users/szczepiq/events{/privacy}","received_events_url":"https://api.github.com/users/szczepiq/received_events","type":"User","site_admin":false},"labels":[{"id":477963998,"url":"https://api.github.com/repos/mockito/shipkit/labels/please%20contribute!","name":"please contribute!","color":"128A0C","default":false},{"id":671842667,"url":"https://api.github.com/repos/mockito/shipkit/labels/size:M","name":"size:M","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-26T19:16:44Z","updated_at":"2017-09-01T14:00:28Z","closed_at":null,"author_association":"OWNER","body":"## Problem\r\n\r\nOur really cool 'org.shipkit.upgrade-downstream' adds and configures CreatePullRequestTask. This task automatically creates pull requests to other projects with version bump. The task implementation [hardcodes pull request](https://github.com/mockito/shipkit/blob/a94f0a12f6070b1ba0be5127dfdab110f66ee154/src/main/groovy/org/shipkit/internal/gradle/versionupgrade/CreatePullRequest.java#L39) 'title' and 'description' values. This makes the task less robust, less configurable. It also ties implementation details with configuration.\r\n\r\n## Suggested solution\r\n\r\nLet's expose 'title' and 'description' properties on the [CreatePullRequestTask](https://github.com/mockito/shipkit/blob/master/src/main/groovy/org/shipkit/internal/gradle/git/tasks/CloneGitRepositoryTask.java). Ideally, the values of those properties should be configured by the plugin.\r\n\r\nThis ticket is marked as 'please-contribute'. Please let us know if you have questions on how to get started!"},"comment":{"url":"https://api.github.com/repos/mockito/shipkit/issues/comments/326587886","html_url":"https://github.com/mockito/shipkit/issues/368#issuecomment-326587886","issue_url":"https://api.github.com/repos/mockito/shipkit/issues/368","id":326587886,"user":{"login":"szczepiq","id":24743,"avatar_url":"https://avatars2.githubusercontent.com/u/24743?v=4","gravatar_id":"","url":"https://api.github.com/users/szczepiq","html_url":"https://github.com/szczepiq","followers_url":"https://api.github.com/users/szczepiq/followers","following_url":"https://api.github.com/users/szczepiq/following{/other_user}","gists_url":"https://api.github.com/users/szczepiq/gists{/gist_id}","starred_url":"https://api.github.com/users/szczepiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szczepiq/subscriptions","organizations_url":"https://api.github.com/users/szczepiq/orgs","repos_url":"https://api.github.com/users/szczepiq/repos","events_url":"https://api.github.com/users/szczepiq/events{/privacy}","received_events_url":"https://api.github.com/users/szczepiq/received_events","type":"User","site_admin":false},"created_at":"2017-09-01T14:00:28Z","updated_at":"2017-09-01T14:00:28Z","author_association":"OWNER","body":"+1 to all feedback from @wwilk\r\n\r\n>Especially the version number would be something that I would like to have filled in title of PR.\r\n\r\nI like this idea! It will make the title+description better, more specific."}}
{"actor":{"display_login":"szczepiq"}}