{"action":"created","issue":{"url":"https://api.github.com/repos/uber/cherami-server/issues/247","repository_url":"https://api.github.com/repos/uber/cherami-server","labels_url":"https://api.github.com/repos/uber/cherami-server/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/uber/cherami-server/issues/247/comments","events_url":"https://api.github.com/repos/uber/cherami-server/issues/247/events","html_url":"https://github.com/uber/cherami-server/pull/247","id":241179890,"number":247,"title":"Refactor cherami-admin and cherami-cli code","user":{"login":"kobeyang","id":4466295,"avatar_url":"https://avatars0.githubusercontent.com/u/4466295?v=3","gravatar_id":"","url":"https://api.github.com/users/kobeyang","html_url":"https://github.com/kobeyang","followers_url":"https://api.github.com/users/kobeyang/followers","following_url":"https://api.github.com/users/kobeyang/following{/other_user}","gists_url":"https://api.github.com/users/kobeyang/gists{/gist_id}","starred_url":"https://api.github.com/users/kobeyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobeyang/subscriptions","organizations_url":"https://api.github.com/users/kobeyang/orgs","repos_url":"https://api.github.com/users/kobeyang/repos","events_url":"https://api.github.com/users/kobeyang/events{/privacy}","received_events_url":"https://api.github.com/users/kobeyang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-07T07:25:11Z","updated_at":"2017-07-07T07:25:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/cherami-server/pulls/247","html_url":"https://github.com/uber/cherami-server/pull/247","diff_url":"https://github.com/uber/cherami-server/pull/247.diff","patch_url":"https://github.com/uber/cherami-server/pull/247.patch"},"body":"Basic idea:\r\n1. Create folder common under cmd/tools, and create lib.go in it to store the common flags and commands used by both cli and admin.\r\n2. Delete tools/cli/lib.go and move the corresponding functions to tools/common/lib.go. Add a parameter serviceName to these common functions to differentiate cli and admin.\r\n3. Cherami-cli will just use the common functions and Cherami-admin will use some admin-specific functions in tools/admin/lib.go.\r\n\r\nNot sure whether this is the best way to do this, please leave any suggestion whichever you want."},"comment":{"url":"https://api.github.com/repos/uber/cherami-server/issues/comments/313608176","html_url":"https://github.com/uber/cherami-server/pull/247#issuecomment-313608176","issue_url":"https://api.github.com/repos/uber/cherami-server/issues/247","id":313608176,"user":{"login":"CLAassistant","id":11571300,"avatar_url":"https://avatars2.githubusercontent.com/u/11571300?v=3","gravatar_id":"","url":"https://api.github.com/users/CLAassistant","html_url":"https://github.com/CLAassistant","followers_url":"https://api.github.com/users/CLAassistant/followers","following_url":"https://api.github.com/users/CLAassistant/following{/other_user}","gists_url":"https://api.github.com/users/CLAassistant/gists{/gist_id}","starred_url":"https://api.github.com/users/CLAassistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLAassistant/subscriptions","organizations_url":"https://api.github.com/users/CLAassistant/orgs","repos_url":"https://api.github.com/users/CLAassistant/repos","events_url":"https://api.github.com/users/CLAassistant/events{/privacy}","received_events_url":"https://api.github.com/users/CLAassistant/received_events","type":"User","site_admin":false},"created_at":"2017-07-07T07:25:17Z","updated_at":"2017-07-07T07:25:17Z","body":"[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/uber/cherami-server?pullRequest=247) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/uber/cherami-server?pullRequest=247) before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/uber/cherami-server?pullRequest=247) it.</sub>"}}
{"actor":{"display_login":"CLAassistant"}}