{"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/comments/122404582","pull_request_review_id":44517311,"id":122404582,"diff_hunk":"@@ -61,31 +68,27 @@\n     public RecordStorageQueryFactory(DataSourceWrapper dataSource,\n                                      Class<? extends Entity<I, ?>> entityClass,\n                                      Logger logger,\n-                                     IdColumn<I> idColumn) {\n+                                     IdColumn<I> idColumn,\n+                                     ColumnTypeRegistry<?\n+                                             extends JdbcColumnType<?, ?>> columnTypeRegistry) {\n         super();\n         this.idColumn = checkNotNull(idColumn);\n         this.dataSource = dataSource;\n         this.tableName = DbTableNameFactory.newTableName(entityClass);\n         this.logger = logger;\n+        this.columnTypeRegistry = columnTypeRegistry;\n     }\n \n-    public MarkEntityQuery<I> newMarkArchivedQuery(I id) {\n-        return newMarkQuery(id, VisibilityField.archived);\n-    }\n-\n-    public MarkEntityQuery<I> newMarkDeletedQuery(I id) {\n-        return newMarkQuery(id, VisibilityField.deleted);\n-    }\n-\n-    private MarkEntityQuery<I> newMarkQuery(I id, VisibilityField column) {\n-        final MarkEntityQuery<I> query = MarkEntityQuery.<I>newBuilder()\n-                .setDataSource(dataSource)\n-                .setLogger(getLogger())\n-                .setTableName(tableName)\n-                .setColumn(column)\n-                .setIdColumn(idColumn)\n-                .setId(id)\n-                .build();\n+    private MarkEntityQuery<I> newMarkQuery(I id, LifecycleFlagField column) {","path":"rdbms/src/main/java/io/spine/server/storage/jdbc/entity/query/RecordStorageQueryFactory.java","position":90,"original_position":90,"commit_id":"e363e41ca67d18ced3dffcd79a757244a8dd6738","original_commit_id":"e363e41ca67d18ced3dffcd79a757244a8dd6738","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private methods such as 'newMarkQuery(I,LifecycleFlagField)'.](https://www.codacy.com/app/SpineEventEngine/jdbc-storage/pullRequest?prid=701661)","created_at":"2017-06-16T09:39:51Z","updated_at":"2017-06-16T09:39:51Z","html_url":"https://github.com/SpineEventEngine/jdbc-storage/pull/27#discussion_r122404582","pull_request_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/comments/122404582"},"html":{"href":"https://github.com/SpineEventEngine/jdbc-storage/pull/27#discussion_r122404582"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27","id":124825444,"html_url":"https://github.com/SpineEventEngine/jdbc-storage/pull/27","diff_url":"https://github.com/SpineEventEngine/jdbc-storage/pull/27.diff","patch_url":"https://github.com/SpineEventEngine/jdbc-storage/pull/27.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/27","number":27,"state":"open","locked":false,"title":"Change domain name to `io.spine`","user":{"login":"alexander-aleksandrov","id":20936350,"avatar_url":"https://avatars2.githubusercontent.com/u/20936350?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-aleksandrov","html_url":"https://github.com/alexander-aleksandrov","followers_url":"https://api.github.com/users/alexander-aleksandrov/followers","following_url":"https://api.github.com/users/alexander-aleksandrov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-aleksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-aleksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-aleksandrov/subscriptions","organizations_url":"https://api.github.com/users/alexander-aleksandrov/orgs","repos_url":"https://api.github.com/users/alexander-aleksandrov/repos","events_url":"https://api.github.com/users/alexander-aleksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-aleksandrov/received_events","type":"User","site_admin":false},"body":"Also, update Jdbc to the new spine core version. Add EntityColumn functionality.","created_at":"2017-06-09T09:24:32Z","updated_at":"2017-06-16T09:39:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0325f7cebcf2e1e2fb3315e9e18d21e1f2f92261","assignee":{"login":"alexander-aleksandrov","id":20936350,"avatar_url":"https://avatars2.githubusercontent.com/u/20936350?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-aleksandrov","html_url":"https://github.com/alexander-aleksandrov","followers_url":"https://api.github.com/users/alexander-aleksandrov/followers","following_url":"https://api.github.com/users/alexander-aleksandrov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-aleksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-aleksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-aleksandrov/subscriptions","organizations_url":"https://api.github.com/users/alexander-aleksandrov/orgs","repos_url":"https://api.github.com/users/alexander-aleksandrov/repos","events_url":"https://api.github.com/users/alexander-aleksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-aleksandrov/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexander-aleksandrov","id":20936350,"avatar_url":"https://avatars2.githubusercontent.com/u/20936350?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-aleksandrov","html_url":"https://github.com/alexander-aleksandrov","followers_url":"https://api.github.com/users/alexander-aleksandrov/followers","following_url":"https://api.github.com/users/alexander-aleksandrov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-aleksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-aleksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-aleksandrov/subscriptions","organizations_url":"https://api.github.com/users/alexander-aleksandrov/orgs","repos_url":"https://api.github.com/users/alexander-aleksandrov/repos","events_url":"https://api.github.com/users/alexander-aleksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-aleksandrov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/27/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/statuses/e363e41ca67d18ced3dffcd79a757244a8dd6738","head":{"label":"SpineEventEngine:change-domain-name-to-spine-io","ref":"change-domain-name-to-spine-io","sha":"e363e41ca67d18ced3dffcd79a757244a8dd6738","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":48777453,"name":"jdbc-storage","full_name":"SpineEventEngine/jdbc-storage","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/jdbc-storage","description":"Support of storage in JDBC-compliant databases","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage","forks_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/deployments","created_at":"2015-12-30T02:36:43Z","updated_at":"2016-01-15T18:00:11Z","pushed_at":"2017-06-16T09:38:00Z","git_url":"git://github.com/SpineEventEngine/jdbc-storage.git","ssh_url":"git@github.com:SpineEventEngine/jdbc-storage.git","clone_url":"https://github.com/SpineEventEngine/jdbc-storage.git","svn_url":"https://github.com/SpineEventEngine/jdbc-storage","homepage":null,"size":1372,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"c154aef855bb1d048eb9d36aabd88cff1bad992f","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":48777453,"name":"jdbc-storage","full_name":"SpineEventEngine/jdbc-storage","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/jdbc-storage","description":"Support of storage in JDBC-compliant databases","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage","forks_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/deployments","created_at":"2015-12-30T02:36:43Z","updated_at":"2016-01-15T18:00:11Z","pushed_at":"2017-06-16T09:38:00Z","git_url":"git://github.com/SpineEventEngine/jdbc-storage.git","ssh_url":"git@github.com:SpineEventEngine/jdbc-storage.git","clone_url":"https://github.com/SpineEventEngine/jdbc-storage.git","svn_url":"https://github.com/SpineEventEngine/jdbc-storage","homepage":null,"size":1372,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27"},"html":{"href":"https://github.com/SpineEventEngine/jdbc-storage/pull/27"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/27"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/jdbc-storage/statuses/e363e41ca67d18ced3dffcd79a757244a8dd6738"}}}}
{"actor":{"display_login":"codacy-bot"}}