{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/97447499","pull_request_review_id":18057761,"id":97447499,"diff_hunk":"@@ -121,12 +121,13 @@ struct OpFinishEvent : public OpEventBase {\n \n struct SnapEventBase : public OpEventBase {\n   std::string snap_name;\n+  cls::rbd::SnapshotNamespace snap_namespace;","path":"src/librbd/journal/Types.h","position":4,"original_position":4,"commit_id":"3f0b60e09a35f92a72ebc3be915c56409f8a150d","original_commit_id":"2998e6c338e62024764faf0266682572b5789d52","user":{"login":"VictorDenisov","id":230213,"avatar_url":"https://avatars.githubusercontent.com/u/230213?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorDenisov","html_url":"https://github.com/VictorDenisov","followers_url":"https://api.github.com/users/VictorDenisov/followers","following_url":"https://api.github.com/users/VictorDenisov/following{/other_user}","gists_url":"https://api.github.com/users/VictorDenisov/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorDenisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorDenisov/subscriptions","organizations_url":"https://api.github.com/users/VictorDenisov/orgs","repos_url":"https://api.github.com/users/VictorDenisov/repos","events_url":"https://api.github.com/users/VictorDenisov/events{/privacy}","received_events_url":"https://api.github.com/users/VictorDenisov/received_events","type":"User","site_admin":false},"body":"I thought that only user facing functions assume UserSnapshotNamespace by default. Internally we may need to flatten image snapshots, protect and unprotect them. For example when we clone group snapshots into another consistency group). As far as I understand these types are required for those internal operations. Am I wrong?","created_at":"2017-01-24T00:09:35Z","updated_at":"2017-01-24T00:09:35Z","html_url":"https://github.com/ceph/ceph/pull/12970#discussion_r97447499","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12970","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/97447499"},"html":{"href":"https://github.com/ceph/ceph/pull/12970#discussion_r97447499"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12970"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12970","id":101964767,"html_url":"https://github.com/ceph/ceph/pull/12970","diff_url":"https://github.com/ceph/ceph/pull/12970.diff","patch_url":"https://github.com/ceph/ceph/pull/12970.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12970","number":12970,"state":"open","locked":false,"title":"[DNM] librbd: add SnapshotNamespace to ImageCtx","user":{"login":"VictorDenisov","id":230213,"avatar_url":"https://avatars.githubusercontent.com/u/230213?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorDenisov","html_url":"https://github.com/VictorDenisov","followers_url":"https://api.github.com/users/VictorDenisov/followers","following_url":"https://api.github.com/users/VictorDenisov/following{/other_user}","gists_url":"https://api.github.com/users/VictorDenisov/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorDenisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorDenisov/subscriptions","organizations_url":"https://api.github.com/users/VictorDenisov/orgs","repos_url":"https://api.github.com/users/VictorDenisov/repos","events_url":"https://api.github.com/users/VictorDenisov/events{/privacy}","received_events_url":"https://api.github.com/users/VictorDenisov/received_events","type":"User","site_admin":false},"body":"This PR is for preliminary review. PR #11544 is supposed to be rebased on top of this PR.","created_at":"2017-01-17T22:55:22Z","updated_at":"2017-01-24T00:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285b1cad63ec02053c0ac18a1f3e01357afcc19e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12970/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12970/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12970/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/3f0b60e09a35f92a72ebc3be915c56409f8a150d","head":{"label":"VictorDenisov:snapshot_namespace_index","ref":"snapshot_namespace_index","sha":"3f0b60e09a35f92a72ebc3be915c56409f8a150d","user":{"login":"VictorDenisov","id":230213,"avatar_url":"https://avatars.githubusercontent.com/u/230213?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorDenisov","html_url":"https://github.com/VictorDenisov","followers_url":"https://api.github.com/users/VictorDenisov/followers","following_url":"https://api.github.com/users/VictorDenisov/following{/other_user}","gists_url":"https://api.github.com/users/VictorDenisov/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorDenisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorDenisov/subscriptions","organizations_url":"https://api.github.com/users/VictorDenisov/orgs","repos_url":"https://api.github.com/users/VictorDenisov/repos","events_url":"https://api.github.com/users/VictorDenisov/events{/privacy}","received_events_url":"https://api.github.com/users/VictorDenisov/received_events","type":"User","site_admin":false},"repo":{"id":50964368,"name":"ceph","full_name":"VictorDenisov/ceph","owner":{"login":"VictorDenisov","id":230213,"avatar_url":"https://avatars.githubusercontent.com/u/230213?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorDenisov","html_url":"https://github.com/VictorDenisov","followers_url":"https://api.github.com/users/VictorDenisov/followers","following_url":"https://api.github.com/users/VictorDenisov/following{/other_user}","gists_url":"https://api.github.com/users/VictorDenisov/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorDenisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorDenisov/subscriptions","organizations_url":"https://api.github.com/users/VictorDenisov/orgs","repos_url":"https://api.github.com/users/VictorDenisov/repos","events_url":"https://api.github.com/users/VictorDenisov/events{/privacy}","received_events_url":"https://api.github.com/users/VictorDenisov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VictorDenisov/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/VictorDenisov/ceph","forks_url":"https://api.github.com/repos/VictorDenisov/ceph/forks","keys_url":"https://api.github.com/repos/VictorDenisov/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VictorDenisov/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VictorDenisov/ceph/teams","hooks_url":"https://api.github.com/repos/VictorDenisov/ceph/hooks","issue_events_url":"https://api.github.com/repos/VictorDenisov/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/VictorDenisov/ceph/events","assignees_url":"https://api.github.com/repos/VictorDenisov/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/VictorDenisov/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/VictorDenisov/ceph/tags","blobs_url":"https://api.github.com/repos/VictorDenisov/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VictorDenisov/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VictorDenisov/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/VictorDenisov/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VictorDenisov/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/VictorDenisov/ceph/languages","stargazers_url":"https://api.github.com/repos/VictorDenisov/ceph/stargazers","contributors_url":"https://api.github.com/repos/VictorDenisov/ceph/contributors","subscribers_url":"https://api.github.com/repos/VictorDenisov/ceph/subscribers","subscription_url":"https://api.github.com/repos/VictorDenisov/ceph/subscription","commits_url":"https://api.github.com/repos/VictorDenisov/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/VictorDenisov/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/VictorDenisov/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/VictorDenisov/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/VictorDenisov/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/VictorDenisov/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VictorDenisov/ceph/merges","archive_url":"https://api.github.com/repos/VictorDenisov/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VictorDenisov/ceph/downloads","issues_url":"https://api.github.com/repos/VictorDenisov/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/VictorDenisov/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/VictorDenisov/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/VictorDenisov/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VictorDenisov/ceph/labels{/name}","releases_url":"https://api.github.com/repos/VictorDenisov/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/VictorDenisov/ceph/deployments","created_at":"2016-02-03T01:17:23Z","updated_at":"2016-02-03T01:17:41Z","pushed_at":"2017-01-21T02:13:42Z","git_url":"git://github.com/VictorDenisov/ceph.git","ssh_url":"git@github.com:VictorDenisov/ceph.git","clone_url":"https://github.com/VictorDenisov/ceph.git","svn_url":"https://github.com/VictorDenisov/ceph","homepage":"http://ceph.com","size":192667,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"af9152f34a416a46bbf96b14b1416ca004c80f84","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-01-23T23:33:11Z","pushed_at":"2017-01-23T23:00:27Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":188946,"stargazers_count":2831,"watchers_count":2831,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1665,"mirror_url":null,"open_issues_count":469,"forks":1665,"open_issues":469,"watchers":2831,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12970"},"html":{"href":"https://github.com/ceph/ceph/pull/12970"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12970"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12970/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12970/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12970/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/3f0b60e09a35f92a72ebc3be915c56409f8a150d"}}}}
{"actor":{"display_login":"VictorDenisov"}}