{"action":"created","comment":{"url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/comments/136662334","pull_request_review_id":60238738,"id":136662334,"diff_hunk":"@@ -83,15 +84,19 @@ class BatchHandler(activityLog: ActivityLog,\n       processBatch(header, batch, batchQueries, connection)\n   }\n \n-  def processBatch(header: FrameHeader, batch: Batch, batchQueries: Seq[BatchQuery], recipient: ActorRef) = {\n+  def processBatch(header: FrameHeader, batch: Batch, batchQueries: Seq[BatchQuery], recipient: ActorRef): Unit = {\n     val execution = BatchExecution(batchQueries, batch.consistency, batch.serialConsistency, batch.batchType, batch.timestamp)\n-    activityLog.recordBatchExecution(execution)\n-    val prime = batchPrimeStore(execution)\n-    prime.foreach(p => log.info(\"Found prime {} for batch execution {}\", p, execution))\n-    writePrime(batch, prime, header, recipient=Some(recipient), alternative = Some(Reply(VoidResult)), consistency = Some(batch.consistency))\n+    activityLog ! RecordBatch(execution)","path":"server/src/main/scala/org/scassandra/server/actors/BatchHandler.scala","position":61,"original_position":61,"commit_id":"00749a048d278b6b06503a205d00910bd1b28f2f","original_commit_id":"00749a048d278b6b06503a205d00910bd1b28f2f","user":{"login":"chbatey","id":1866779,"avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"body":"Yeah good spot. I had to do this in all the routes for the same reason.","created_at":"2017-09-01T20:46:36Z","updated_at":"2017-09-01T20:46:36Z","html_url":"https://github.com/scassandra/scassandra-server/pull/192#discussion_r136662334","pull_request_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/comments/136662334"},"html":{"href":"https://github.com/scassandra/scassandra-server/pull/192#discussion_r136662334"},"pull_request":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192"}},"in_reply_to_id":136604733},"pull_request":{"url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192","id":136621641,"html_url":"https://github.com/scassandra/scassandra-server/pull/192","diff_url":"https://github.com/scassandra/scassandra-server/pull/192.diff","patch_url":"https://github.com/scassandra/scassandra-server/pull/192.patch","issue_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/192","number":192,"state":"open","locked":false,"title":"Move activity log to be an actor","user":{"login":"chbatey","id":1866779,"avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"body":"The current activity log is not thread safe yet is accessed by actors\r\nand routes\r\n\r\nWill work on fixing the priming stores next\r\n\r\nWe also use a mix of scalatest testing styles so changing each to WordSpecs as I touch them\r\n\r\nMind taking a look @tolbertam ?","created_at":"2017-08-19T21:19:01Z","updated_at":"2017-09-01T20:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c73b2d52196afdb4724cc4f7066a3ea17b2e2673","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192/commits","review_comments_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192/comments","review_comment_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/192/comments","statuses_url":"https://api.github.com/repos/scassandra/scassandra-server/statuses/00749a048d278b6b06503a205d00910bd1b28f2f","head":{"label":"scassandra:fix-activity-concurrency","ref":"fix-activity-concurrency","sha":"00749a048d278b6b06503a205d00910bd1b28f2f","user":{"login":"scassandra","id":7254193,"avatar_url":"https://avatars0.githubusercontent.com/u/7254193?v=4","gravatar_id":"","url":"https://api.github.com/users/scassandra","html_url":"https://github.com/scassandra","followers_url":"https://api.github.com/users/scassandra/followers","following_url":"https://api.github.com/users/scassandra/following{/other_user}","gists_url":"https://api.github.com/users/scassandra/gists{/gist_id}","starred_url":"https://api.github.com/users/scassandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassandra/subscriptions","organizations_url":"https://api.github.com/users/scassandra/orgs","repos_url":"https://api.github.com/users/scassandra/repos","events_url":"https://api.github.com/users/scassandra/events{/privacy}","received_events_url":"https://api.github.com/users/scassandra/received_events","type":"Organization","site_admin":false},"repo":{"id":18759272,"name":"scassandra-server","full_name":"scassandra/scassandra-server","owner":{"login":"scassandra","id":7254193,"avatar_url":"https://avatars0.githubusercontent.com/u/7254193?v=4","gravatar_id":"","url":"https://api.github.com/users/scassandra","html_url":"https://github.com/scassandra","followers_url":"https://api.github.com/users/scassandra/followers","following_url":"https://api.github.com/users/scassandra/following{/other_user}","gists_url":"https://api.github.com/users/scassandra/gists{/gist_id}","starred_url":"https://api.github.com/users/scassandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassandra/subscriptions","organizations_url":"https://api.github.com/users/scassandra/orgs","repos_url":"https://api.github.com/users/scassandra/repos","events_url":"https://api.github.com/users/scassandra/events{/privacy}","received_events_url":"https://api.github.com/users/scassandra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scassandra/scassandra-server","description":"Stubbed Cassandra","fork":false,"url":"https://api.github.com/repos/scassandra/scassandra-server","forks_url":"https://api.github.com/repos/scassandra/scassandra-server/forks","keys_url":"https://api.github.com/repos/scassandra/scassandra-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scassandra/scassandra-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scassandra/scassandra-server/teams","hooks_url":"https://api.github.com/repos/scassandra/scassandra-server/hooks","issue_events_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/events{/number}","events_url":"https://api.github.com/repos/scassandra/scassandra-server/events","assignees_url":"https://api.github.com/repos/scassandra/scassandra-server/assignees{/user}","branches_url":"https://api.github.com/repos/scassandra/scassandra-server/branches{/branch}","tags_url":"https://api.github.com/repos/scassandra/scassandra-server/tags","blobs_url":"https://api.github.com/repos/scassandra/scassandra-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scassandra/scassandra-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scassandra/scassandra-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/scassandra/scassandra-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scassandra/scassandra-server/statuses/{sha}","languages_url":"https://api.github.com/repos/scassandra/scassandra-server/languages","stargazers_url":"https://api.github.com/repos/scassandra/scassandra-server/stargazers","contributors_url":"https://api.github.com/repos/scassandra/scassandra-server/contributors","subscribers_url":"https://api.github.com/repos/scassandra/scassandra-server/subscribers","subscription_url":"https://api.github.com/repos/scassandra/scassandra-server/subscription","commits_url":"https://api.github.com/repos/scassandra/scassandra-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/scassandra/scassandra-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/scassandra/scassandra-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/scassandra/scassandra-server/contents/{+path}","compare_url":"https://api.github.com/repos/scassandra/scassandra-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scassandra/scassandra-server/merges","archive_url":"https://api.github.com/repos/scassandra/scassandra-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scassandra/scassandra-server/downloads","issues_url":"https://api.github.com/repos/scassandra/scassandra-server/issues{/number}","pulls_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls{/number}","milestones_url":"https://api.github.com/repos/scassandra/scassandra-server/milestones{/number}","notifications_url":"https://api.github.com/repos/scassandra/scassandra-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scassandra/scassandra-server/labels{/name}","releases_url":"https://api.github.com/repos/scassandra/scassandra-server/releases{/id}","deployments_url":"https://api.github.com/repos/scassandra/scassandra-server/deployments","created_at":"2014-04-14T12:09:29Z","updated_at":"2017-09-01T09:40:40Z","pushed_at":"2017-08-30T14:45:46Z","git_url":"git://github.com/scassandra/scassandra-server.git","ssh_url":"git@github.com:scassandra/scassandra-server.git","clone_url":"https://github.com/scassandra/scassandra-server.git","svn_url":"https://github.com/scassandra/scassandra-server","homepage":"http://www.scassandra.org","size":5489,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":46,"forks":30,"open_issues":46,"watchers":75,"default_branch":"master"}},"base":{"label":"scassandra:master","ref":"master","sha":"b0409c5d6fe821bbadcf50b6724c24c993ef637c","user":{"login":"scassandra","id":7254193,"avatar_url":"https://avatars0.githubusercontent.com/u/7254193?v=4","gravatar_id":"","url":"https://api.github.com/users/scassandra","html_url":"https://github.com/scassandra","followers_url":"https://api.github.com/users/scassandra/followers","following_url":"https://api.github.com/users/scassandra/following{/other_user}","gists_url":"https://api.github.com/users/scassandra/gists{/gist_id}","starred_url":"https://api.github.com/users/scassandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassandra/subscriptions","organizations_url":"https://api.github.com/users/scassandra/orgs","repos_url":"https://api.github.com/users/scassandra/repos","events_url":"https://api.github.com/users/scassandra/events{/privacy}","received_events_url":"https://api.github.com/users/scassandra/received_events","type":"Organization","site_admin":false},"repo":{"id":18759272,"name":"scassandra-server","full_name":"scassandra/scassandra-server","owner":{"login":"scassandra","id":7254193,"avatar_url":"https://avatars0.githubusercontent.com/u/7254193?v=4","gravatar_id":"","url":"https://api.github.com/users/scassandra","html_url":"https://github.com/scassandra","followers_url":"https://api.github.com/users/scassandra/followers","following_url":"https://api.github.com/users/scassandra/following{/other_user}","gists_url":"https://api.github.com/users/scassandra/gists{/gist_id}","starred_url":"https://api.github.com/users/scassandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassandra/subscriptions","organizations_url":"https://api.github.com/users/scassandra/orgs","repos_url":"https://api.github.com/users/scassandra/repos","events_url":"https://api.github.com/users/scassandra/events{/privacy}","received_events_url":"https://api.github.com/users/scassandra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scassandra/scassandra-server","description":"Stubbed Cassandra","fork":false,"url":"https://api.github.com/repos/scassandra/scassandra-server","forks_url":"https://api.github.com/repos/scassandra/scassandra-server/forks","keys_url":"https://api.github.com/repos/scassandra/scassandra-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scassandra/scassandra-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scassandra/scassandra-server/teams","hooks_url":"https://api.github.com/repos/scassandra/scassandra-server/hooks","issue_events_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/events{/number}","events_url":"https://api.github.com/repos/scassandra/scassandra-server/events","assignees_url":"https://api.github.com/repos/scassandra/scassandra-server/assignees{/user}","branches_url":"https://api.github.com/repos/scassandra/scassandra-server/branches{/branch}","tags_url":"https://api.github.com/repos/scassandra/scassandra-server/tags","blobs_url":"https://api.github.com/repos/scassandra/scassandra-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scassandra/scassandra-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scassandra/scassandra-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/scassandra/scassandra-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scassandra/scassandra-server/statuses/{sha}","languages_url":"https://api.github.com/repos/scassandra/scassandra-server/languages","stargazers_url":"https://api.github.com/repos/scassandra/scassandra-server/stargazers","contributors_url":"https://api.github.com/repos/scassandra/scassandra-server/contributors","subscribers_url":"https://api.github.com/repos/scassandra/scassandra-server/subscribers","subscription_url":"https://api.github.com/repos/scassandra/scassandra-server/subscription","commits_url":"https://api.github.com/repos/scassandra/scassandra-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/scassandra/scassandra-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/scassandra/scassandra-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/scassandra/scassandra-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/scassandra/scassandra-server/contents/{+path}","compare_url":"https://api.github.com/repos/scassandra/scassandra-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scassandra/scassandra-server/merges","archive_url":"https://api.github.com/repos/scassandra/scassandra-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scassandra/scassandra-server/downloads","issues_url":"https://api.github.com/repos/scassandra/scassandra-server/issues{/number}","pulls_url":"https://api.github.com/repos/scassandra/scassandra-server/pulls{/number}","milestones_url":"https://api.github.com/repos/scassandra/scassandra-server/milestones{/number}","notifications_url":"https://api.github.com/repos/scassandra/scassandra-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scassandra/scassandra-server/labels{/name}","releases_url":"https://api.github.com/repos/scassandra/scassandra-server/releases{/id}","deployments_url":"https://api.github.com/repos/scassandra/scassandra-server/deployments","created_at":"2014-04-14T12:09:29Z","updated_at":"2017-09-01T09:40:40Z","pushed_at":"2017-08-30T14:45:46Z","git_url":"git://github.com/scassandra/scassandra-server.git","ssh_url":"git@github.com:scassandra/scassandra-server.git","clone_url":"https://github.com/scassandra/scassandra-server.git","svn_url":"https://github.com/scassandra/scassandra-server","homepage":"http://www.scassandra.org","size":5489,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":46,"forks":30,"open_issues":46,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192"},"html":{"href":"https://github.com/scassandra/scassandra-server/pull/192"},"issue":{"href":"https://api.github.com/repos/scassandra/scassandra-server/issues/192"},"comments":{"href":"https://api.github.com/repos/scassandra/scassandra-server/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scassandra/scassandra-server/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/scassandra/scassandra-server/statuses/00749a048d278b6b06503a205d00910bd1b28f2f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chbatey"}}