{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14","id":146295729,"html_url":"https://github.com/solidusio/solidus_asset_variant_options/pull/14","diff_url":"https://github.com/solidusio/solidus_asset_variant_options/pull/14.diff","patch_url":"https://github.com/solidusio/solidus_asset_variant_options/pull/14.patch","issue_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/14","number":14,"state":"closed","locked":false,"title":"Fix image variant validation","user":{"login":"fastjames","id":260739,"avatar_url":"https://avatars1.githubusercontent.com/u/260739?v=4","gravatar_id":"","url":"https://api.github.com/users/fastjames","html_url":"https://github.com/fastjames","followers_url":"https://api.github.com/users/fastjames/followers","following_url":"https://api.github.com/users/fastjames/following{/other_user}","gists_url":"https://api.github.com/users/fastjames/gists{/gist_id}","starred_url":"https://api.github.com/users/fastjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastjames/subscriptions","organizations_url":"https://api.github.com/users/fastjames/orgs","repos_url":"https://api.github.com/users/fastjames/repos","events_url":"https://api.github.com/users/fastjames/events{/privacy}","received_events_url":"https://api.github.com/users/fastjames/received_events","type":"User","site_admin":false},"body":"@WIP\r\n\r\nFixes issue 1 in the first commit\r\n\r\nThe second commit is an attempt at bringing in master variant images. It's failing 2 specs, one of which is because the object passed to the has_many proc is a Product in that test.\r\n\r\n","created_at":"2017-10-12T19:36:37Z","updated_at":"2017-10-12T19:45:16Z","closed_at":"2017-10-12T19:45:16Z","merged_at":null,"merge_commit_sha":"6e6e24a30482270aeea82c884393571f20bb337a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/14/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/statuses/a61104d272cb73b482fc571d5d91c1cc1a77b82c","head":{"label":"geminimvp:fix_image_variant_validation","ref":"fix_image_variant_validation","sha":"a61104d272cb73b482fc571d5d91c1cc1a77b82c","user":{"login":"geminimvp","id":18290828,"avatar_url":"https://avatars1.githubusercontent.com/u/18290828?v=4","gravatar_id":"","url":"https://api.github.com/users/geminimvp","html_url":"https://github.com/geminimvp","followers_url":"https://api.github.com/users/geminimvp/followers","following_url":"https://api.github.com/users/geminimvp/following{/other_user}","gists_url":"https://api.github.com/users/geminimvp/gists{/gist_id}","starred_url":"https://api.github.com/users/geminimvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geminimvp/subscriptions","organizations_url":"https://api.github.com/users/geminimvp/orgs","repos_url":"https://api.github.com/users/geminimvp/repos","events_url":"https://api.github.com/users/geminimvp/events{/privacy}","received_events_url":"https://api.github.com/users/geminimvp/received_events","type":"Organization","site_admin":false},"repo":{"id":104110137,"name":"solidus_asset_variant_options","full_name":"geminimvp/solidus_asset_variant_options","owner":{"login":"geminimvp","id":18290828,"avatar_url":"https://avatars1.githubusercontent.com/u/18290828?v=4","gravatar_id":"","url":"https://api.github.com/users/geminimvp","html_url":"https://github.com/geminimvp","followers_url":"https://api.github.com/users/geminimvp/followers","following_url":"https://api.github.com/users/geminimvp/following{/other_user}","gists_url":"https://api.github.com/users/geminimvp/gists{/gist_id}","starred_url":"https://api.github.com/users/geminimvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geminimvp/subscriptions","organizations_url":"https://api.github.com/users/geminimvp/orgs","repos_url":"https://api.github.com/users/geminimvp/repos","events_url":"https://api.github.com/users/geminimvp/events{/privacy}","received_events_url":"https://api.github.com/users/geminimvp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geminimvp/solidus_asset_variant_options","description":"Using image assets across multiple variants","fork":true,"url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options","forks_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/forks","keys_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/teams","hooks_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/hooks","issue_events_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/issues/events{/number}","events_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/events","assignees_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/assignees{/user}","branches_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/branches{/branch}","tags_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/tags","blobs_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/git/refs{/sha}","trees_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/statuses/{sha}","languages_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/languages","stargazers_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/stargazers","contributors_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/contributors","subscribers_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/subscribers","subscription_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/subscription","commits_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/commits{/sha}","git_commits_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/git/commits{/sha}","comments_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/comments{/number}","issue_comment_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/issues/comments{/number}","contents_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/contents/{+path}","compare_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/merges","archive_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/downloads","issues_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/issues{/number}","pulls_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/pulls{/number}","milestones_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/milestones{/number}","notifications_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/labels{/name}","releases_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/releases{/id}","deployments_url":"https://api.github.com/repos/geminimvp/solidus_asset_variant_options/deployments","created_at":"2017-09-19T18:07:33Z","updated_at":"2017-10-11T21:04:40Z","pushed_at":"2017-10-12T19:34:32Z","git_url":"git://github.com/geminimvp/solidus_asset_variant_options.git","ssh_url":"git@github.com:geminimvp/solidus_asset_variant_options.git","clone_url":"https://github.com/geminimvp/solidus_asset_variant_options.git","svn_url":"https://github.com/geminimvp/solidus_asset_variant_options","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"9d507a5764d80127b9708ed75c93a38ef7a51a8b","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":36393299,"name":"solidus_asset_variant_options","full_name":"solidusio/solidus_asset_variant_options","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus_asset_variant_options","description":"Using image assets across multiple variants","fork":false,"url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options","forks_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/forks","keys_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/events","assignees_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/merges","archive_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/deployments","created_at":"2015-05-27T20:18:31Z","updated_at":"2016-12-05T23:01:39Z","pushed_at":"2017-10-12T19:36:38Z","git_url":"git://github.com/solidusio/solidus_asset_variant_options.git","ssh_url":"git@github.com:solidusio/solidus_asset_variant_options.git","clone_url":"https://github.com/solidusio/solidus_asset_variant_options.git","svn_url":"https://github.com/solidusio/solidus_asset_variant_options","homepage":"","size":49,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14"},"html":{"href":"https://github.com/solidusio/solidus_asset_variant_options/pull/14"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/14"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus_asset_variant_options/statuses/a61104d272cb73b482fc571d5d91c1cc1a77b82c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":80,"deletions":17,"changed_files":9}}
{"actor":{"display_login":"fastjames"}}