{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/15278","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/15278/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/15278/comments","events_url":"https://api.github.com/repos/servo/servo/issues/15278/events","html_url":"https://github.com/servo/servo/pull/15278","id":203783371,"number":15278,"title":"Parsing \"0\" as Number for line-height and border-image-outset","user":{"login":"atheed","id":6478080,"avatar_url":"https://avatars.githubusercontent.com/u/6478080?v=3","gravatar_id":"","url":"https://api.github.com/users/atheed","html_url":"https://github.com/atheed","followers_url":"https://api.github.com/users/atheed/followers","following_url":"https://api.github.com/users/atheed/following{/other_user}","gists_url":"https://api.github.com/users/atheed/gists{/gist_id}","starred_url":"https://api.github.com/users/atheed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atheed/subscriptions","organizations_url":"https://api.github.com/users/atheed/orgs","repos_url":"https://api.github.com/users/atheed/repos","events_url":"https://api.github.com/users/atheed/events{/privacy}","received_events_url":"https://api.github.com/users/atheed/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-01-28T02:55:14Z","updated_at":"2017-01-28T03:50:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/15278","html_url":"https://github.com/servo/servo/pull/15278","diff_url":"https://github.com/servo/servo/pull/15278.diff","patch_url":"https://github.com/servo/servo/pull/15278.patch"},"body":"Fixes #15171 by correctly parsing `0` as `0` (rather than as `0px`, as was the case earlier) for the `line-height` and `border-image-outset` CSS properties. Wrote unit tests for both; `./mach test-unit -p style` passes all tests.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #15171 \r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes.\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/15278)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/275825055","html_url":"https://github.com/servo/servo/pull/15278#issuecomment-275825055","issue_url":"https://api.github.com/repos/servo/servo/issues/15278","id":275825055,"user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"created_at":"2017-01-28T03:50:06Z","updated_at":"2017-01-28T03:50:06Z","body":"The changes look good to me. Just a couple of nits :)"}}
{"actor":{"display_login":"Wafflespeanut"}}