{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/158162137","pull_request_review_id":84923667,"id":158162137,"diff_hunk":"@@ -40,12 +40,14 @@\n import javax.management.remote.rmi.RMIConnectorServer;\n import javax.management.remote.rmi.RMIJRMPServerImpl;\n import javax.management.remote.rmi.RMIServerImpl;\n+import javax.net.ssl.SSLContext;\n import javax.rmi.ssl.SslRMIClientSocketFactory;\n \n import org.apache.commons.lang.StringUtils;\n import org.apache.logging.log4j.Logger;\n import org.eclipse.jetty.server.Server;\n import org.eclipse.jetty.server.ServerConnector;\n+import org.eclipse.jetty.util.ssl.SslContextFactory;","path":"geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java","position":11,"original_position":11,"commit_id":"781739705f8a1a25fb0eeb410fe9057eb4b0428e","original_commit_id":"781739705f8a1a25fb0eeb410fe9057eb4b0428e","user":{"login":"pdxrunner","id":16668768,"avatar_url":"https://avatars2.githubusercontent.com/u/16668768?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxrunner","html_url":"https://github.com/pdxrunner","followers_url":"https://api.github.com/users/pdxrunner/followers","following_url":"https://api.github.com/users/pdxrunner/following{/other_user}","gists_url":"https://api.github.com/users/pdxrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxrunner/subscriptions","organizations_url":"https://api.github.com/users/pdxrunner/orgs","repos_url":"https://api.github.com/users/pdxrunner/repos","events_url":"https://api.github.com/users/pdxrunner/events{/privacy}","received_events_url":"https://api.github.com/users/pdxrunner/received_events","type":"User","site_admin":false},"body":"Unused imports","created_at":"2017-12-20T23:23:58Z","updated_at":"2017-12-20T23:38:25Z","html_url":"https://github.com/apache/geode/pull/1196#discussion_r158162137","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/1196","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/158162137"},"html":{"href":"https://github.com/apache/geode/pull/1196#discussion_r158162137"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/1196","id":159527065,"html_url":"https://github.com/apache/geode/pull/1196","diff_url":"https://github.com/apache/geode/pull/1196.diff","patch_url":"https://github.com/apache/geode/pull/1196.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/1196","number":1196,"state":"open","locked":false,"title":"Feature/geode 4087","user":{"login":"bschuchardt","id":7441204,"avatar_url":"https://avatars1.githubusercontent.com/u/7441204?v=4","gravatar_id":"","url":"https://api.github.com/users/bschuchardt","html_url":"https://github.com/bschuchardt","followers_url":"https://api.github.com/users/bschuchardt/followers","following_url":"https://api.github.com/users/bschuchardt/following{/other_user}","gists_url":"https://api.github.com/users/bschuchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/bschuchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschuchardt/subscriptions","organizations_url":"https://api.github.com/users/bschuchardt/orgs","repos_url":"https://api.github.com/users/bschuchardt/repos","events_url":"https://api.github.com/users/bschuchardt/events{/privacy}","received_events_url":"https://api.github.com/users/bschuchardt/received_events","type":"User","site_admin":false},"body":"*GEODE-4087 modify SocketCreator to not set the default SSLContext for the JVM*\r\n\r\n_SocketCreator no longer installs a default SSL context._\r\n\r\n\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n@jinmeiliao @PurelyApplied @PivotalSarge @galen-pivotal @upthewaterspout @WireBaron ","created_at":"2017-12-20T21:55:46Z","updated_at":"2017-12-20T23:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfc42edef38f47393f6dc3b08fb8c1ce4174a24f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/1196/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/781739705f8a1a25fb0eeb410fe9057eb4b0428e","head":{"label":"apache:feature/GEODE-4087","ref":"feature/GEODE-4087","sha":"781739705f8a1a25fb0eeb410fe9057eb4b0428e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-12-19T07:08:05Z","pushed_at":"2017-12-20T23:16:17Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":144054,"stargazers_count":1121,"watchers_count":1121,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":16,"watchers":1121,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"ed6bac5bc5cd73094e2b9073ff47e31e4e3503bd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-12-19T07:08:05Z","pushed_at":"2017-12-20T23:16:17Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":144054,"stargazers_count":1121,"watchers_count":1121,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":16,"watchers":1121,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/1196"},"html":{"href":"https://github.com/apache/geode/pull/1196"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/1196"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/781739705f8a1a25fb0eeb410fe9057eb4b0428e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pdxrunner"}}