{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments/121927371","pull_request_review_id":43995170,"id":121927371,"diff_hunk":"@@ -166,6 +157,47 @@ public BuildData(AbstractBuild<?, ?> build, Date currentTime) {\n     }\n   }\n \n+  // Pipeline project build\n+  public BuildData(Run<?, ?> build, Date currentTime, TaskListener listener) {\n+    initData(build, currentTime);\n+\n+    Executor executor = build.getExecutor();\n+    if (executor == null) {\n+      buildHost = \"master\";\n+    } else {\n+      buildHost = StringUtils.isBlank(executor.getDisplayName()) ? \"master\" : executor.getDisplayName();\n+    }\n+\n+    rootProjectName = projectName;\n+    rootProjectDisplayName = displayName;\n+    rootBuildNum = buildNum;\n+\n+    try {\n+      buildVariables = build.getEnvironment(listener);","path":"src/main/java/jenkins/plugins/logstash/persistence/BuildData.java","position":72,"original_position":72,"commit_id":"38aa65e9dd052cfb0a8caf95ee06dcc2c6aff5dc","original_commit_id":"38aa65e9dd052cfb0a8caf95ee06dcc2c6aff5dc","user":{"login":"jakub-bochenski","id":2794994,"avatar_url":"https://avatars2.githubusercontent.com/u/2794994?v=3","gravatar_id":"","url":"https://api.github.com/users/jakub-bochenski","html_url":"https://github.com/jakub-bochenski","followers_url":"https://api.github.com/users/jakub-bochenski/followers","following_url":"https://api.github.com/users/jakub-bochenski/following{/other_user}","gists_url":"https://api.github.com/users/jakub-bochenski/gists{/gist_id}","starred_url":"https://api.github.com/users/jakub-bochenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakub-bochenski/subscriptions","organizations_url":"https://api.github.com/users/jakub-bochenski/orgs","repos_url":"https://api.github.com/users/jakub-bochenski/repos","events_url":"https://api.github.com/users/jakub-bochenski/events{/privacy}","received_events_url":"https://api.github.com/users/jakub-bochenski/received_events","type":"User","site_admin":false},"body":"How are sensitive variables to be handled in pipeline jobs?\r\n\r\n`getSensitiveBuildVariables()` is only defined in `AbstractBuild`, so how is pipeline handling plugins like credentials binding?","created_at":"2017-06-14T12:06:52Z","updated_at":"2017-06-14T12:06:53Z","html_url":"https://github.com/jenkinsci/logstash-plugin/pull/28#discussion_r121927371","pull_request_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments/121927371"},"html":{"href":"https://github.com/jenkinsci/logstash-plugin/pull/28#discussion_r121927371"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28","id":124352618,"html_url":"https://github.com/jenkinsci/logstash-plugin/pull/28","diff_url":"https://github.com/jenkinsci/logstash-plugin/pull/28.diff","patch_url":"https://github.com/jenkinsci/logstash-plugin/pull/28.patch","issue_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/28","number":28,"state":"open","locked":false,"title":"Change logstash notifier to fit pipeline jobs","user":{"login":"hkbao","id":3104387,"avatar_url":"https://avatars1.githubusercontent.com/u/3104387?v=3","gravatar_id":"","url":"https://api.github.com/users/hkbao","html_url":"https://github.com/hkbao","followers_url":"https://api.github.com/users/hkbao/followers","following_url":"https://api.github.com/users/hkbao/following{/other_user}","gists_url":"https://api.github.com/users/hkbao/gists{/gist_id}","starred_url":"https://api.github.com/users/hkbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkbao/subscriptions","organizations_url":"https://api.github.com/users/hkbao/orgs","repos_url":"https://api.github.com/users/hkbao/repos","events_url":"https://api.github.com/users/hkbao/events{/privacy}","received_events_url":"https://api.github.com/users/hkbao/received_events","type":"User","site_admin":false},"body":"Changed LogstashNotifier.java and some other files to fit pipeline step call of logstash.\r\n#JENKINS-44712\r\n\r\nSigned-off-by: Haikuan Bao <hkbao2008@gmail.com>","created_at":"2017-06-07T07:26:59Z","updated_at":"2017-06-14T12:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea99b7d0d9a8831b3ce86a5257fb3f39ff92fb39","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/28/comments","statuses_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/38aa65e9dd052cfb0a8caf95ee06dcc2c6aff5dc","head":{"label":"hkbao:JENKINS-44712-pipeline-support","ref":"JENKINS-44712-pipeline-support","sha":"38aa65e9dd052cfb0a8caf95ee06dcc2c6aff5dc","user":{"login":"hkbao","id":3104387,"avatar_url":"https://avatars1.githubusercontent.com/u/3104387?v=3","gravatar_id":"","url":"https://api.github.com/users/hkbao","html_url":"https://github.com/hkbao","followers_url":"https://api.github.com/users/hkbao/followers","following_url":"https://api.github.com/users/hkbao/following{/other_user}","gists_url":"https://api.github.com/users/hkbao/gists{/gist_id}","starred_url":"https://api.github.com/users/hkbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkbao/subscriptions","organizations_url":"https://api.github.com/users/hkbao/orgs","repos_url":"https://api.github.com/users/hkbao/repos","events_url":"https://api.github.com/users/hkbao/events{/privacy}","received_events_url":"https://api.github.com/users/hkbao/received_events","type":"User","site_admin":false},"repo":{"id":93496890,"name":"logstash-plugin","full_name":"hkbao/logstash-plugin","owner":{"login":"hkbao","id":3104387,"avatar_url":"https://avatars1.githubusercontent.com/u/3104387?v=3","gravatar_id":"","url":"https://api.github.com/users/hkbao","html_url":"https://github.com/hkbao","followers_url":"https://api.github.com/users/hkbao/followers","following_url":"https://api.github.com/users/hkbao/following{/other_user}","gists_url":"https://api.github.com/users/hkbao/gists{/gist_id}","starred_url":"https://api.github.com/users/hkbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkbao/subscriptions","organizations_url":"https://api.github.com/users/hkbao/orgs","repos_url":"https://api.github.com/users/hkbao/repos","events_url":"https://api.github.com/users/hkbao/events{/privacy}","received_events_url":"https://api.github.com/users/hkbao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkbao/logstash-plugin","description":"Jenkins plugin to ship the console log off to Logstash","fork":true,"url":"https://api.github.com/repos/hkbao/logstash-plugin","forks_url":"https://api.github.com/repos/hkbao/logstash-plugin/forks","keys_url":"https://api.github.com/repos/hkbao/logstash-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkbao/logstash-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkbao/logstash-plugin/teams","hooks_url":"https://api.github.com/repos/hkbao/logstash-plugin/hooks","issue_events_url":"https://api.github.com/repos/hkbao/logstash-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/hkbao/logstash-plugin/events","assignees_url":"https://api.github.com/repos/hkbao/logstash-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/hkbao/logstash-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/hkbao/logstash-plugin/tags","blobs_url":"https://api.github.com/repos/hkbao/logstash-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkbao/logstash-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkbao/logstash-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkbao/logstash-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkbao/logstash-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/hkbao/logstash-plugin/languages","stargazers_url":"https://api.github.com/repos/hkbao/logstash-plugin/stargazers","contributors_url":"https://api.github.com/repos/hkbao/logstash-plugin/contributors","subscribers_url":"https://api.github.com/repos/hkbao/logstash-plugin/subscribers","subscription_url":"https://api.github.com/repos/hkbao/logstash-plugin/subscription","commits_url":"https://api.github.com/repos/hkbao/logstash-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkbao/logstash-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkbao/logstash-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkbao/logstash-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkbao/logstash-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/hkbao/logstash-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkbao/logstash-plugin/merges","archive_url":"https://api.github.com/repos/hkbao/logstash-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkbao/logstash-plugin/downloads","issues_url":"https://api.github.com/repos/hkbao/logstash-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/hkbao/logstash-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/hkbao/logstash-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/hkbao/logstash-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkbao/logstash-plugin/labels{/name}","releases_url":"https://api.github.com/repos/hkbao/logstash-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/hkbao/logstash-plugin/deployments","created_at":"2017-06-06T08:50:58Z","updated_at":"2017-06-14T11:59:42Z","pushed_at":"2017-06-13T06:33:42Z","git_url":"git://github.com/hkbao/logstash-plugin.git","ssh_url":"git@github.com:hkbao/logstash-plugin.git","clone_url":"https://github.com/hkbao/logstash-plugin.git","svn_url":"https://github.com/hkbao/logstash-plugin","homepage":null,"size":179,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"bcbc19ed733f87d520ab0cd47229195c29db3299","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":7866898,"name":"logstash-plugin","full_name":"jenkinsci/logstash-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/logstash-plugin","description":"Jenkins plugin to ship the console log off to Logstash","fork":true,"url":"https://api.github.com/repos/jenkinsci/logstash-plugin","forks_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/deployments","created_at":"2013-01-28T09:38:33Z","updated_at":"2017-06-08T03:45:59Z","pushed_at":"2017-06-13T06:33:43Z","git_url":"git://github.com/jenkinsci/logstash-plugin.git","ssh_url":"git@github.com:jenkinsci/logstash-plugin.git","clone_url":"https://github.com/jenkinsci/logstash-plugin.git","svn_url":"https://github.com/jenkinsci/logstash-plugin","homepage":null,"size":168,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":8,"forks":42,"open_issues":8,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28"},"html":{"href":"https://github.com/jenkinsci/logstash-plugin/pull/28"},"issue":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/28"},"comments":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/38aa65e9dd052cfb0a8caf95ee06dcc2c6aff5dc"}}}}
{"actor":{"display_login":"jakub-bochenski"}}