{"action":"opened","number":4288,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/4288","id":128353981,"html_url":"https://github.com/libgit2/libgit2/pull/4288","diff_url":"https://github.com/libgit2/libgit2/pull/4288.diff","patch_url":"https://github.com/libgit2/libgit2/pull/4288.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/4288","number":4288,"state":"open","locked":false,"title":"Include fixups","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars2.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"Up front: sorry for this big commit, I know it sucks. But as such I'm splitting this out from #4282 as it's too big to make it port of that one.\r\n\r\nThe first two commits fix up some small stuff regarding missing license headers and to fix some header files from not compiling which weren't included anywhere before. The next commit establishes a common include pattern across all our files in the \"src/\" folder. Quoting from its commit message:\r\n\r\n\"\"\"\r\n Make sure to always include \"common.h\" first\r\n\r\n Next to including several files, our \"common.h\" header also declares\r\n various macros which are then used throughout the project. As such, we\r\n have to make sure to always include this file first in all\r\n implementation files. Otherwise, we might encounter problems or even\r\n silent behavioural differences due to macros or defines not being\r\n defined as they should be. So in fact, our header and implementation\r\n files should make sure to always include \"common.h\" first.\r\n\r\n This commit does so by establishing a common include pattern. Header\r\n files inside of \"src\" will now always include \"common.h\" as its first\r\n other file, separated by a newline from all the other includes to make\r\n it stand out as special. There are two cases for the implementation\r\n files. If they do have a matching header file, they will always include\r\n this one first, leading to \"common.h\" being transitively included as\r\n first file. If they do not have a matching header file, they instead\r\n include \"common.h\" as first file themselves.\r\n\r\n This fixes the outlined problems and will become our standard practice\r\n for header and source files inside of the \"src/\" from now on.\r\n\"\"\"","created_at":"2017-06-30T11:53:39Z","updated_at":"2017-06-30T11:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4288/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4288/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/4288/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/17801f78426f69b5349c184a425b203df0022ec1","head":{"label":"pks-t:pks/include-fixups","ref":"pks/include-fixups","sha":"17801f78426f69b5349c184a425b203df0022ec1","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars2.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"repo":{"id":29849449,"name":"libgit2","full_name":"pks-t/libgit2","owner":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars2.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pks-t/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/pks-t/libgit2","forks_url":"https://api.github.com/repos/pks-t/libgit2/forks","keys_url":"https://api.github.com/repos/pks-t/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pks-t/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pks-t/libgit2/teams","hooks_url":"https://api.github.com/repos/pks-t/libgit2/hooks","issue_events_url":"https://api.github.com/repos/pks-t/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/pks-t/libgit2/events","assignees_url":"https://api.github.com/repos/pks-t/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/pks-t/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/pks-t/libgit2/tags","blobs_url":"https://api.github.com/repos/pks-t/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pks-t/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pks-t/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pks-t/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pks-t/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/pks-t/libgit2/languages","stargazers_url":"https://api.github.com/repos/pks-t/libgit2/stargazers","contributors_url":"https://api.github.com/repos/pks-t/libgit2/contributors","subscribers_url":"https://api.github.com/repos/pks-t/libgit2/subscribers","subscription_url":"https://api.github.com/repos/pks-t/libgit2/subscription","commits_url":"https://api.github.com/repos/pks-t/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pks-t/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pks-t/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pks-t/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pks-t/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/pks-t/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pks-t/libgit2/merges","archive_url":"https://api.github.com/repos/pks-t/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pks-t/libgit2/downloads","issues_url":"https://api.github.com/repos/pks-t/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/pks-t/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/pks-t/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/pks-t/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pks-t/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/pks-t/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/pks-t/libgit2/deployments","created_at":"2015-01-26T07:12:59Z","updated_at":"2016-10-28T10:37:55Z","pushed_at":"2017-06-30T11:49:33Z","git_url":"git://github.com/pks-t/libgit2.git","ssh_url":"git@github.com:pks-t/libgit2.git","clone_url":"https://github.com/pks-t/libgit2.git","svn_url":"https://github.com/pks-t/libgit2","homepage":"http://libgit2.github.com","size":22969,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"c26ce78404b7fc7356c56bd2c57611fd60a3705b","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars2.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars2.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2017-06-30T00:32:52Z","pushed_at":"2017-06-30T08:32:06Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"https://libgit2.github.com","size":36279,"stargazers_count":6104,"watchers_count":6104,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1549,"mirror_url":null,"open_issues_count":212,"forks":1549,"open_issues":212,"watchers":6104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4288"},"html":{"href":"https://github.com/libgit2/libgit2/pull/4288"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4288"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4288/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4288/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4288/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/17801f78426f69b5349c184a425b203df0022ec1"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":505,"deletions":146,"changed_files":236}}
{"actor":{"display_login":"pks-t"}}