{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/233","repository_url":"https://api.github.com/repos/DoSomething/gambit-conversations","labels_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/233/comments","events_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/233/events","html_url":"https://github.com/DoSomething/gambit-conversations/pull/233","id":275815899,"number":233,"title":"Import Message Broadcast TLC - part 1","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars2.githubusercontent.com/u/1236811?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-21T18:31:22Z","updated_at":"2017-11-21T18:32:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/233","html_url":"https://github.com/DoSomething/gambit-conversations/pull/233","diff_url":"https://github.com/DoSomething/gambit-conversations/pull/233.diff","patch_url":"https://github.com/DoSomething/gambit-conversations/pull/233.patch"},"body":"Splits the `lib/middleware/import-message/broadcast` into separate `broadcast-get` and `parse-broadcast` files, with some cleanup to Contentful.\r\n\r\n* Adds tests for `broadcast-get`\r\n\r\n* Adds a `contentfulId` function to  `lib/contentfulQueryBuilder` to fetch a Broadcast by its Contentful entry ID instead of the `broadcastId` field value -- fixes #116 \r\n\r\n* Moves throwing a 404 if broadcast not found into `contentful. fetchSingleEntry`, deprecating `helpers.getBroadcast`. A `POST /import-message` with a non-existing `broadcastId` will now throw a 404 instead of a 500 `Internal Server Error` - fixes #118 \r\n\r\n* Adds the `broadcastId` as a New Relic parameter - refs #214 \r\n\r\nTo test:\r\n* `POST /import-message` with both valid and invalid broadcast ID's to verify expected API response.\r\n\r\nFor Part 2:\r\n\r\n* Add New Relic params and tests for `parse-broadcast` middleware\r\n* Complete the TODO's of moving the Broadcast parsing functions (e.g. `getTopic(broadcastObject)` into `lib/contentful`\r\n"},"comment":{"url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/comments/346119218","html_url":"https://github.com/DoSomething/gambit-conversations/pull/233#issuecomment-346119218","issue_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/233","id":346119218,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T18:32:19Z","updated_at":"2017-11-21T18:32:19Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=h1) Report\n> Merging [#233](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=desc) into [master](https://codecov.io/gh/DoSomething/gambit-conversations/commit/79ce034ff39f806cf35ca04e512d0b8cd495464c?src=pr&el=desc) will **increase** coverage by `1.24%`.\n> The diff coverage is `36.66%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233/graphs/tree.svg?token=SR6PUbfk3s&src=pr&width=650&height=150)](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #233      +/-   ##\n==========================================\n+ Coverage   21.38%   22.62%   +1.24%     \n==========================================\n  Files          89       90       +1     \n  Lines        1557     1560       +3     \n==========================================\n+ Hits          333      353      +20     \n+ Misses       1224     1207      -17\n```\n\n\n| [Impacted Files](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [lib/middleware/import-message/parse-broadcast.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL21pZGRsZXdhcmUvaW1wb3J0LW1lc3NhZ2UvcGFyc2UtYnJvYWRjYXN0Lmpz) | `0% <0%> (ø)` | |\n| [lib/middleware/broadcast-settings/broadcast.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL21pZGRsZXdhcmUvYnJvYWRjYXN0LXNldHRpbmdzL2Jyb2FkY2FzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |\n| [app/routes/import-message.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-YXBwL3JvdXRlcy9pbXBvcnQtbWVzc2FnZS5qcw==) | `0% <0%> (ø)` | :arrow_up: |\n| [lib/helpers.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL2hlbHBlcnMuanM=) | `32.21% <0%> (+0.13%)` | :arrow_up: |\n| [lib/contentfulQueryBuilder.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL2NvbnRlbnRmdWxRdWVyeUJ1aWxkZXIuanM=) | `7.69% <0%> (ø)` | :arrow_up: |\n| [lib/contentful.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL2NvbnRlbnRmdWwuanM=) | `32.6% <14.28%> (-2.4%)` | :arrow_down: |\n| [lib/middleware/import-message/broadcast-get.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-bGliL21pZGRsZXdhcmUvaW1wb3J0LW1lc3NhZ2UvYnJvYWRjYXN0LWdldC5qcw==) | `80.76% <80.76%> (ø)` | |\n| [config/lib/middleware/import-message/broadcast.js](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=tree#diff-Y29uZmlnL2xpYi9taWRkbGV3YXJlL2ltcG9ydC1tZXNzYWdlL2Jyb2FkY2FzdC5qcw==) | `100% <0%> (+100%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=footer). Last update [79ce034...0118662](https://codecov.io/gh/DoSomething/gambit-conversations/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}