{"action":"created","comment":{"url":"https://api.github.com/repos/open-io/oio-sds/pulls/comments/143128229","pull_request_review_id":67594084,"id":143128229,"diff_hunk":"@@ -691,7 +713,20 @@ __open_not_cached(struct open_args_s *args, struct sqlx_sqlite3_s **result)\n \tsq3->admin = g_tree_new_full(metautils_strcmp3, NULL, g_free, g_free);\n \n \tsqlx_exec(handle, \"PRAGMA foreign_keys = OFF\");\n-\tsqlx_exec(handle, \"PRAGMA journal_mode = MEMORY\");\n+\n+\t/* We chose to check this call especially because it is able to detect\n+\t * a wrong/corrupted database file. */\n+\trc = sqlx_exec(handle, \"PRAGMA journal_mode = MEMORY\");\n+\tif (rc != SQLITE_OK) {\n+\t\terror = NEWERROR(CODE_INTERNAL_ERROR, \"failed to setup base: (%d) %s\",","path":"sqliterepo/repository.c","position":79,"original_position":79,"commit_id":"d6d0774255f10eef609b6c44f3bd87bbbfccf1d8","original_commit_id":"d6d0774255f10eef609b6c44f3bd87bbbfccf1d8","user":{"login":"jfsmig","id":2921642,"avatar_url":"https://avatars0.githubusercontent.com/u/2921642?v=4","gravatar_id":"","url":"https://api.github.com/users/jfsmig","html_url":"https://github.com/jfsmig","followers_url":"https://api.github.com/users/jfsmig/followers","following_url":"https://api.github.com/users/jfsmig/following{/other_user}","gists_url":"https://api.github.com/users/jfsmig/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsmig/subscriptions","organizations_url":"https://api.github.com/users/jfsmig/orgs","repos_url":"https://api.github.com/users/jfsmig/repos","events_url":"https://api.github.com/users/jfsmig/events{/privacy}","received_events_url":"https://api.github.com/users/jfsmig/received_events","type":"User","site_admin":false},"body":"I would suggest returning a new specific `5XX` code when a corruption is explicitly detected.\r\nNot that it is necessary immediately, but it might help to react on the error (from the client, the logs, etc)","created_at":"2017-10-06T07:53:56Z","updated_at":"2017-10-06T07:53:56Z","html_url":"https://github.com/open-io/oio-sds/pull/1183#discussion_r143128229","pull_request_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1183","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/comments/143128229"},"html":{"href":"https://github.com/open-io/oio-sds/pull/1183#discussion_r143128229"},"pull_request":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1183"}}},"pull_request":{"url":"https://api.github.com/repos/open-io/oio-sds/pulls/1183","id":142923346,"html_url":"https://github.com/open-io/oio-sds/pull/1183","diff_url":"https://github.com/open-io/oio-sds/pull/1183.diff","patch_url":"https://github.com/open-io/oio-sds/pull/1183.patch","issue_url":"https://api.github.com/repos/open-io/oio-sds/issues/1183","number":1183,"state":"open","locked":false,"title":"Peers cache, meta1 mover","user":{"login":"fvennetier","id":1398191,"avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"body":"- [x] cache peers in election structure\r\n- [x] disable resolver cache in sqliterepo-based services\r\n- [x] improve meta1 mover","created_at":"2017-09-25T16:07:18Z","updated_at":"2017-10-06T07:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48f1c43ac7bde5f77a4c831562e43331a0db3210","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/open-io/oio-sds/milestones/11","html_url":"https://github.com/open-io/oio-sds/milestone/11","labels_url":"https://api.github.com/repos/open-io/oio-sds/milestones/11/labels","id":2617987,"number":11,"title":"4.2","description":"* rawx: hard link\r\n* meta2: glacierisation of containers","creator":{"login":"jfsmig","id":2921642,"avatar_url":"https://avatars0.githubusercontent.com/u/2921642?v=4","gravatar_id":"","url":"https://api.github.com/users/jfsmig","html_url":"https://github.com/jfsmig","followers_url":"https://api.github.com/users/jfsmig/followers","following_url":"https://api.github.com/users/jfsmig/following{/other_user}","gists_url":"https://api.github.com/users/jfsmig/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsmig/subscriptions","organizations_url":"https://api.github.com/users/jfsmig/orgs","repos_url":"https://api.github.com/users/jfsmig/repos","events_url":"https://api.github.com/users/jfsmig/events{/privacy}","received_events_url":"https://api.github.com/users/jfsmig/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2017-07-03T08:45:18Z","updated_at":"2017-09-25T16:07:18Z","due_on":"2017-08-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1183/commits","review_comments_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1183/comments","review_comment_url":"https://api.github.com/repos/open-io/oio-sds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-io/oio-sds/issues/1183/comments","statuses_url":"https://api.github.com/repos/open-io/oio-sds/statuses/d6d0774255f10eef609b6c44f3bd87bbbfccf1d8","head":{"label":"fvennetier:movers","ref":"movers","sha":"d6d0774255f10eef609b6c44f3bd87bbbfccf1d8","user":{"login":"fvennetier","id":1398191,"avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"repo":{"id":49139579,"name":"oio-sds","full_name":"fvennetier/oio-sds","owner":{"login":"fvennetier","id":1398191,"avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fvennetier/oio-sds","description":"OpenIO Software Defined Storage","fork":true,"url":"https://api.github.com/repos/fvennetier/oio-sds","forks_url":"https://api.github.com/repos/fvennetier/oio-sds/forks","keys_url":"https://api.github.com/repos/fvennetier/oio-sds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvennetier/oio-sds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvennetier/oio-sds/teams","hooks_url":"https://api.github.com/repos/fvennetier/oio-sds/hooks","issue_events_url":"https://api.github.com/repos/fvennetier/oio-sds/issues/events{/number}","events_url":"https://api.github.com/repos/fvennetier/oio-sds/events","assignees_url":"https://api.github.com/repos/fvennetier/oio-sds/assignees{/user}","branches_url":"https://api.github.com/repos/fvennetier/oio-sds/branches{/branch}","tags_url":"https://api.github.com/repos/fvennetier/oio-sds/tags","blobs_url":"https://api.github.com/repos/fvennetier/oio-sds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvennetier/oio-sds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvennetier/oio-sds/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvennetier/oio-sds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvennetier/oio-sds/statuses/{sha}","languages_url":"https://api.github.com/repos/fvennetier/oio-sds/languages","stargazers_url":"https://api.github.com/repos/fvennetier/oio-sds/stargazers","contributors_url":"https://api.github.com/repos/fvennetier/oio-sds/contributors","subscribers_url":"https://api.github.com/repos/fvennetier/oio-sds/subscribers","subscription_url":"https://api.github.com/repos/fvennetier/oio-sds/subscription","commits_url":"https://api.github.com/repos/fvennetier/oio-sds/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvennetier/oio-sds/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvennetier/oio-sds/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvennetier/oio-sds/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvennetier/oio-sds/contents/{+path}","compare_url":"https://api.github.com/repos/fvennetier/oio-sds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvennetier/oio-sds/merges","archive_url":"https://api.github.com/repos/fvennetier/oio-sds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvennetier/oio-sds/downloads","issues_url":"https://api.github.com/repos/fvennetier/oio-sds/issues{/number}","pulls_url":"https://api.github.com/repos/fvennetier/oio-sds/pulls{/number}","milestones_url":"https://api.github.com/repos/fvennetier/oio-sds/milestones{/number}","notifications_url":"https://api.github.com/repos/fvennetier/oio-sds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvennetier/oio-sds/labels{/name}","releases_url":"https://api.github.com/repos/fvennetier/oio-sds/releases{/id}","deployments_url":"https://api.github.com/repos/fvennetier/oio-sds/deployments","created_at":"2016-01-06T14:21:10Z","updated_at":"2016-10-28T14:35:04Z","pushed_at":"2017-10-05T14:03:58Z","git_url":"git://github.com/fvennetier/oio-sds.git","ssh_url":"git@github.com:fvennetier/oio-sds.git","clone_url":"https://github.com/fvennetier/oio-sds.git","svn_url":"https://github.com/fvennetier/oio-sds","homepage":null,"size":13170,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"open-io:4.x","ref":"4.x","sha":"e525b2ded59fddd0f2bbd35ad8dc9f6a4493df82","user":{"login":"open-io","id":11300184,"avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"repo":{"id":32169193,"name":"oio-sds","full_name":"open-io/oio-sds","owner":{"login":"open-io","id":11300184,"avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-io/oio-sds","description":"OpenIO Software Defined Storage","fork":false,"url":"https://api.github.com/repos/open-io/oio-sds","forks_url":"https://api.github.com/repos/open-io/oio-sds/forks","keys_url":"https://api.github.com/repos/open-io/oio-sds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-io/oio-sds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-io/oio-sds/teams","hooks_url":"https://api.github.com/repos/open-io/oio-sds/hooks","issue_events_url":"https://api.github.com/repos/open-io/oio-sds/issues/events{/number}","events_url":"https://api.github.com/repos/open-io/oio-sds/events","assignees_url":"https://api.github.com/repos/open-io/oio-sds/assignees{/user}","branches_url":"https://api.github.com/repos/open-io/oio-sds/branches{/branch}","tags_url":"https://api.github.com/repos/open-io/oio-sds/tags","blobs_url":"https://api.github.com/repos/open-io/oio-sds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-io/oio-sds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-io/oio-sds/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-io/oio-sds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-io/oio-sds/statuses/{sha}","languages_url":"https://api.github.com/repos/open-io/oio-sds/languages","stargazers_url":"https://api.github.com/repos/open-io/oio-sds/stargazers","contributors_url":"https://api.github.com/repos/open-io/oio-sds/contributors","subscribers_url":"https://api.github.com/repos/open-io/oio-sds/subscribers","subscription_url":"https://api.github.com/repos/open-io/oio-sds/subscription","commits_url":"https://api.github.com/repos/open-io/oio-sds/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-io/oio-sds/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-io/oio-sds/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-io/oio-sds/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-io/oio-sds/contents/{+path}","compare_url":"https://api.github.com/repos/open-io/oio-sds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-io/oio-sds/merges","archive_url":"https://api.github.com/repos/open-io/oio-sds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-io/oio-sds/downloads","issues_url":"https://api.github.com/repos/open-io/oio-sds/issues{/number}","pulls_url":"https://api.github.com/repos/open-io/oio-sds/pulls{/number}","milestones_url":"https://api.github.com/repos/open-io/oio-sds/milestones{/number}","notifications_url":"https://api.github.com/repos/open-io/oio-sds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-io/oio-sds/labels{/name}","releases_url":"https://api.github.com/repos/open-io/oio-sds/releases{/id}","deployments_url":"https://api.github.com/repos/open-io/oio-sds/deployments","created_at":"2015-03-13T17:06:25Z","updated_at":"2017-10-04T16:35:34Z","pushed_at":"2017-10-06T07:45:08Z","git_url":"git://github.com/open-io/oio-sds.git","ssh_url":"git@github.com:open-io/oio-sds.git","clone_url":"https://github.com/open-io/oio-sds.git","svn_url":"https://github.com/open-io/oio-sds","homepage":null,"size":13272,"stargazers_count":218,"watchers_count":218,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":38,"forks":49,"open_issues":38,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1183"},"html":{"href":"https://github.com/open-io/oio-sds/pull/1183"},"issue":{"href":"https://api.github.com/repos/open-io/oio-sds/issues/1183"},"comments":{"href":"https://api.github.com/repos/open-io/oio-sds/issues/1183/comments"},"review_comments":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1183/comments"},"review_comment":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1183/commits"},"statuses":{"href":"https://api.github.com/repos/open-io/oio-sds/statuses/d6d0774255f10eef609b6c44f3bd87bbbfccf1d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfsmig"}}