{"action":"created","comment":{"url":"https://api.github.com/repos/control-center/serviced/pulls/comments/99146722","pull_request_review_id":19813490,"id":99146722,"diff_hunk":"@@ -577,8 +635,24 @@ func DeleteState(conn client.Connection, req StateRequest) error {\n \t\tlogger.Debug(\"No state to delete on host\")\n \t}\n \n-\t// Delete the service instance\n \tsspth := path.Join(basepth, \"/services\", req.ServiceID, req.StateID())\n+\n+\t// Delete the current state (status)","path":"zzk/service/state.go","position":140,"original_position":140,"commit_id":"d301f5e652c5cdba9546ed32f178ec1b6b605beb","original_commit_id":"d301f5e652c5cdba9546ed32f178ec1b6b605beb","user":{"login":"johnlhamilton","id":14060038,"avatar_url":"https://avatars.githubusercontent.com/u/14060038?v=3","gravatar_id":"","url":"https://api.github.com/users/johnlhamilton","html_url":"https://github.com/johnlhamilton","followers_url":"https://api.github.com/users/johnlhamilton/followers","following_url":"https://api.github.com/users/johnlhamilton/following{/other_user}","gists_url":"https://api.github.com/users/johnlhamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnlhamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnlhamilton/subscriptions","organizations_url":"https://api.github.com/users/johnlhamilton/orgs","repos_url":"https://api.github.com/users/johnlhamilton/repos","events_url":"https://api.github.com/users/johnlhamilton/events{/privacy}","received_events_url":"https://api.github.com/users/johnlhamilton/received_events","type":"User","site_admin":false},"body":"In that case, should we return an error (if the node is missing) or just continue and not include it in the transaction?","created_at":"2017-02-02T15:40:52Z","updated_at":"2017-02-02T15:40:52Z","html_url":"https://github.com/control-center/serviced/pull/3352#discussion_r99146722","pull_request_url":"https://api.github.com/repos/control-center/serviced/pulls/3352","_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments/99146722"},"html":{"href":"https://github.com/control-center/serviced/pull/3352#discussion_r99146722"},"pull_request":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3352"}}},"pull_request":{"url":"https://api.github.com/repos/control-center/serviced/pulls/3352","id":104224674,"html_url":"https://github.com/control-center/serviced/pull/3352","diff_url":"https://github.com/control-center/serviced/pull/3352.diff","patch_url":"https://github.com/control-center/serviced/pull/3352.patch","issue_url":"https://api.github.com/repos/control-center/serviced/issues/3352","number":3352,"state":"open","locked":false,"title":"Feature/cc 3200 state change notify","user":{"login":"mayathegreat","id":22079492,"avatar_url":"https://avatars.githubusercontent.com/u/22079492?v=3","gravatar_id":"","url":"https://api.github.com/users/mayathegreat","html_url":"https://github.com/mayathegreat","followers_url":"https://api.github.com/users/mayathegreat/followers","following_url":"https://api.github.com/users/mayathegreat/following{/other_user}","gists_url":"https://api.github.com/users/mayathegreat/gists{/gist_id}","starred_url":"https://api.github.com/users/mayathegreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayathegreat/subscriptions","organizations_url":"https://api.github.com/users/mayathegreat/orgs","repos_url":"https://api.github.com/users/mayathegreat/repos","events_url":"https://api.github.com/users/mayathegreat/events{/privacy}","received_events_url":"https://api.github.com/users/mayathegreat/received_events","type":"User","site_admin":false},"body":"* added service states\r\n* modified state changes to reflect new additional \"Instance State\"\r\n* test cases added for the above","created_at":"2017-02-01T21:23:02Z","updated_at":"2017-02-02T15:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a22851e0a5a0630f453f7d442342f0243f0e881","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/control-center/serviced/pulls/3352/commits","review_comments_url":"https://api.github.com/repos/control-center/serviced/pulls/3352/comments","review_comment_url":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/control-center/serviced/issues/3352/comments","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/d301f5e652c5cdba9546ed32f178ec1b6b605beb","head":{"label":"control-center:feature/CC-3200-state-change-notify","ref":"feature/CC-3200-state-change-notify","sha":"d301f5e652c5cdba9546ed32f178ec1b6b605beb","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2017-01-27T09:16:07Z","pushed_at":"2017-02-02T00:43:49Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":132225,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":4,"forks":14,"open_issues":4,"watchers":99,"default_branch":"develop"}},"base":{"label":"control-center:develop","ref":"develop","sha":"65e699054620c174d264e98da0bdaa42540e7372","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2017-01-27T09:16:07Z","pushed_at":"2017-02-02T00:43:49Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":132225,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":4,"forks":14,"open_issues":4,"watchers":99,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3352"},"html":{"href":"https://github.com/control-center/serviced/pull/3352"},"issue":{"href":"https://api.github.com/repos/control-center/serviced/issues/3352"},"comments":{"href":"https://api.github.com/repos/control-center/serviced/issues/3352/comments"},"review_comments":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3352/comments"},"review_comment":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3352/commits"},"statuses":{"href":"https://api.github.com/repos/control-center/serviced/statuses/d301f5e652c5cdba9546ed32f178ec1b6b605beb"}}}}
{"actor":{"display_login":"johnlhamilton"}}