{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/94917646","pull_request_review_id":15459590,"id":94917646,"diff_hunk":"@@ -1406,7 +1406,7 @@ instantiate a server with additional parameters\n     * `addDelay(netmask, n)`: delay answers within that netmask by n milliseconds\n     * `addDelay({netmask, netmask}, n)`: delay answers within those netmasks (together) by n milliseconds\n  * Answer changing functions:\n-    * `truncateTC(bool)`: if set (default) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22.\n+    * `truncateTC(bool)`: if set (default to no) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22. Note: turning this on breaks compatibility with RFC 6891.","path":"pdns/README-dnsdist.md","position":5,"original_position":5,"commit_id":"f4ca83fb745f0902136ed29db08de719cc16df3e","original_commit_id":"f4ca83fb745f0902136ed29db08de719cc16df3e","user":{"login":"pieterlexis","id":731232,"avatar_url":"https://avatars.githubusercontent.com/u/731232?v=3","gravatar_id":"","url":"https://api.github.com/users/pieterlexis","html_url":"https://github.com/pieterlexis","followers_url":"https://api.github.com/users/pieterlexis/followers","following_url":"https://api.github.com/users/pieterlexis/following{/other_user}","gists_url":"https://api.github.com/users/pieterlexis/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterlexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterlexis/subscriptions","organizations_url":"https://api.github.com/users/pieterlexis/orgs","repos_url":"https://api.github.com/users/pieterlexis/repos","events_url":"https://api.github.com/users/pieterlexis/events{/privacy}","received_events_url":"https://api.github.com/users/pieterlexis/received_events","type":"User","site_admin":false},"body":"\"Defaults to no starting with dnsdist 1.2.0\"","created_at":"2017-01-06T09:08:20Z","updated_at":"2017-01-06T09:08:20Z","html_url":"https://github.com/PowerDNS/pdns/pull/4859#discussion_r94917646","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/94917646"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4859#discussion_r94917646"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859","id":100428812,"html_url":"https://github.com/PowerDNS/pdns/pull/4859","diff_url":"https://github.com/PowerDNS/pdns/pull/4859.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/4859.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4859","number":4859,"state":"open","locked":false,"title":"Change truncateTC to defaulting to off","user":{"login":"RobinGeuze","id":8234736,"avatar_url":"https://avatars.githubusercontent.com/u/8234736?v=3","gravatar_id":"","url":"https://api.github.com/users/RobinGeuze","html_url":"https://github.com/RobinGeuze","followers_url":"https://api.github.com/users/RobinGeuze/followers","following_url":"https://api.github.com/users/RobinGeuze/following{/other_user}","gists_url":"https://api.github.com/users/RobinGeuze/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinGeuze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinGeuze/subscriptions","organizations_url":"https://api.github.com/users/RobinGeuze/orgs","repos_url":"https://api.github.com/users/RobinGeuze/repos","events_url":"https://api.github.com/users/RobinGeuze/events{/privacy}","received_events_url":"https://api.github.com/users/RobinGeuze/received_events","type":"User","site_admin":false},"body":"### Short description\r\nHaving truncateTC enabled by default causes dnsdist to break compatibility with RFC 6891 by default. Closes #4857\r\n\r\n### Checklist\r\nI have:\r\n- [x] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [x] compiled and tested this code\r\n- [x] included documentation (including possible behaviour changes)\r\n- [x] documented the code\r\n","created_at":"2017-01-06T08:59:36Z","updated_at":"2017-01-06T09:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40065dd0e67df8972e0e6adcf2acc6bdd31d8d33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4859/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/f4ca83fb745f0902136ed29db08de719cc16df3e","head":{"label":"RobinGeuze:changeTruncateTCToDefaultToOff","ref":"changeTruncateTCToDefaultToOff","sha":"f4ca83fb745f0902136ed29db08de719cc16df3e","user":{"login":"RobinGeuze","id":8234736,"avatar_url":"https://avatars.githubusercontent.com/u/8234736?v=3","gravatar_id":"","url":"https://api.github.com/users/RobinGeuze","html_url":"https://github.com/RobinGeuze","followers_url":"https://api.github.com/users/RobinGeuze/followers","following_url":"https://api.github.com/users/RobinGeuze/following{/other_user}","gists_url":"https://api.github.com/users/RobinGeuze/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinGeuze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinGeuze/subscriptions","organizations_url":"https://api.github.com/users/RobinGeuze/orgs","repos_url":"https://api.github.com/users/RobinGeuze/repos","events_url":"https://api.github.com/users/RobinGeuze/events{/privacy}","received_events_url":"https://api.github.com/users/RobinGeuze/received_events","type":"User","site_admin":false},"repo":{"id":65473731,"name":"pdns","full_name":"RobinGeuze/pdns","owner":{"login":"RobinGeuze","id":8234736,"avatar_url":"https://avatars.githubusercontent.com/u/8234736?v=3","gravatar_id":"","url":"https://api.github.com/users/RobinGeuze","html_url":"https://github.com/RobinGeuze","followers_url":"https://api.github.com/users/RobinGeuze/followers","following_url":"https://api.github.com/users/RobinGeuze/following{/other_user}","gists_url":"https://api.github.com/users/RobinGeuze/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinGeuze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinGeuze/subscriptions","organizations_url":"https://api.github.com/users/RobinGeuze/orgs","repos_url":"https://api.github.com/users/RobinGeuze/repos","events_url":"https://api.github.com/users/RobinGeuze/events{/privacy}","received_events_url":"https://api.github.com/users/RobinGeuze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RobinGeuze/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/RobinGeuze/pdns","forks_url":"https://api.github.com/repos/RobinGeuze/pdns/forks","keys_url":"https://api.github.com/repos/RobinGeuze/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobinGeuze/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobinGeuze/pdns/teams","hooks_url":"https://api.github.com/repos/RobinGeuze/pdns/hooks","issue_events_url":"https://api.github.com/repos/RobinGeuze/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/RobinGeuze/pdns/events","assignees_url":"https://api.github.com/repos/RobinGeuze/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/RobinGeuze/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/RobinGeuze/pdns/tags","blobs_url":"https://api.github.com/repos/RobinGeuze/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobinGeuze/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobinGeuze/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobinGeuze/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobinGeuze/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/RobinGeuze/pdns/languages","stargazers_url":"https://api.github.com/repos/RobinGeuze/pdns/stargazers","contributors_url":"https://api.github.com/repos/RobinGeuze/pdns/contributors","subscribers_url":"https://api.github.com/repos/RobinGeuze/pdns/subscribers","subscription_url":"https://api.github.com/repos/RobinGeuze/pdns/subscription","commits_url":"https://api.github.com/repos/RobinGeuze/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobinGeuze/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobinGeuze/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobinGeuze/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobinGeuze/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/RobinGeuze/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobinGeuze/pdns/merges","archive_url":"https://api.github.com/repos/RobinGeuze/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobinGeuze/pdns/downloads","issues_url":"https://api.github.com/repos/RobinGeuze/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/RobinGeuze/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/RobinGeuze/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/RobinGeuze/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobinGeuze/pdns/labels{/name}","releases_url":"https://api.github.com/repos/RobinGeuze/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/RobinGeuze/pdns/deployments","created_at":"2016-08-11T13:57:36Z","updated_at":"2016-08-11T13:57:41Z","pushed_at":"2017-01-06T07:54:26Z","git_url":"git://github.com/RobinGeuze/pdns.git","ssh_url":"git@github.com:RobinGeuze/pdns.git","clone_url":"https://github.com/RobinGeuze/pdns.git","svn_url":"https://github.com/RobinGeuze/pdns","homepage":null,"size":32930,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"567985feb4f3df152adcb79d5d963277c32a25f8","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2017-01-06T01:20:53Z","pushed_at":"2017-01-06T08:59:37Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":33160,"stargazers_count":747,"watchers_count":747,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"open_issues_count":549,"forks":302,"open_issues":549,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4859"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4859"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4859/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4859/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/f4ca83fb745f0902136ed29db08de719cc16df3e"}}}}
{"actor":{"display_login":"pieterlexis"}}