{"action":"created","comment":{"url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/104545768","pull_request_review_id":25388099,"id":104545768,"diff_hunk":"@@ -0,0 +1,72 @@\n+#include <segmentation/surface_segmentation.h>\n+#include <ros/ros.h>\n+\n+\n+/*\n+ * A stand-alone node that uses Godel's current surface segmentation algorithms","path":"godel_surface_detection/src/nodes/boundary_test_node.cpp","position":6,"original_position":6,"commit_id":"30ec00fc579c850eb845e206a996598fda2ce7f0","original_commit_id":"30ec00fc579c850eb845e206a996598fda2ce7f0","user":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars3.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2017-03-06T22:54:01Z","updated_at":"2017-03-06T22:54:01Z","html_url":"https://github.com/ros-industrial-consortium/godel/pull/184#discussion_r104545768","pull_request_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184","_links":{"self":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/104545768"},"html":{"href":"https://github.com/ros-industrial-consortium/godel/pull/184#discussion_r104545768"},"pull_request":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184"}}},"pull_request":{"url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184","id":109179848,"html_url":"https://github.com/ros-industrial-consortium/godel/pull/184","diff_url":"https://github.com/ros-industrial-consortium/godel/pull/184.diff","patch_url":"https://github.com/ros-industrial-consortium/godel/pull/184.patch","issue_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/184","number":184,"state":"open","locked":false,"title":"Used OMP to Parallelize the Boundary Search","user":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars3.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"body":"Copies the `pcl::BoundaryEstimation` class into our project, makes a few small changes, and uses OMP to parallelize the boundary search.\r\n\r\nNo significant changes from an algorithmic perspective. I may be able to speed up the boundary condition checking some, but I think there's also big wins available in the organization and searching of the point cloud. Using the `pcl::search::Octree` class got me a ~30% improvement. I'll make that a separate PR if needed.","created_at":"2017-03-06T02:23:03Z","updated_at":"2017-03-06T22:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9e9adc2b616d4ac6c8b6a88b0fd12f7249648b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184/commits","review_comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184/comments","review_comment_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/184/comments","statuses_url":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/30ec00fc579c850eb845e206a996598fda2ce7f0","head":{"label":"Jmeyer1292:speedup/boundary_detection","ref":"speedup/boundary_detection","sha":"30ec00fc579c850eb845e206a996598fda2ce7f0","user":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars3.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"repo":{"id":30308164,"name":"godel","full_name":"Jmeyer1292/godel","owner":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars3.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jmeyer1292/godel","description":"ROS-Industrial Focused Technical Project: Robotic Blending","fork":true,"url":"https://api.github.com/repos/Jmeyer1292/godel","forks_url":"https://api.github.com/repos/Jmeyer1292/godel/forks","keys_url":"https://api.github.com/repos/Jmeyer1292/godel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jmeyer1292/godel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jmeyer1292/godel/teams","hooks_url":"https://api.github.com/repos/Jmeyer1292/godel/hooks","issue_events_url":"https://api.github.com/repos/Jmeyer1292/godel/issues/events{/number}","events_url":"https://api.github.com/repos/Jmeyer1292/godel/events","assignees_url":"https://api.github.com/repos/Jmeyer1292/godel/assignees{/user}","branches_url":"https://api.github.com/repos/Jmeyer1292/godel/branches{/branch}","tags_url":"https://api.github.com/repos/Jmeyer1292/godel/tags","blobs_url":"https://api.github.com/repos/Jmeyer1292/godel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jmeyer1292/godel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jmeyer1292/godel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jmeyer1292/godel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jmeyer1292/godel/statuses/{sha}","languages_url":"https://api.github.com/repos/Jmeyer1292/godel/languages","stargazers_url":"https://api.github.com/repos/Jmeyer1292/godel/stargazers","contributors_url":"https://api.github.com/repos/Jmeyer1292/godel/contributors","subscribers_url":"https://api.github.com/repos/Jmeyer1292/godel/subscribers","subscription_url":"https://api.github.com/repos/Jmeyer1292/godel/subscription","commits_url":"https://api.github.com/repos/Jmeyer1292/godel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jmeyer1292/godel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jmeyer1292/godel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jmeyer1292/godel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jmeyer1292/godel/contents/{+path}","compare_url":"https://api.github.com/repos/Jmeyer1292/godel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jmeyer1292/godel/merges","archive_url":"https://api.github.com/repos/Jmeyer1292/godel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jmeyer1292/godel/downloads","issues_url":"https://api.github.com/repos/Jmeyer1292/godel/issues{/number}","pulls_url":"https://api.github.com/repos/Jmeyer1292/godel/pulls{/number}","milestones_url":"https://api.github.com/repos/Jmeyer1292/godel/milestones{/number}","notifications_url":"https://api.github.com/repos/Jmeyer1292/godel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jmeyer1292/godel/labels{/name}","releases_url":"https://api.github.com/repos/Jmeyer1292/godel/releases{/id}","deployments_url":"https://api.github.com/repos/Jmeyer1292/godel/deployments","created_at":"2015-02-04T16:20:33Z","updated_at":"2017-02-07T05:45:33Z","pushed_at":"2017-03-06T16:33:40Z","git_url":"git://github.com/Jmeyer1292/godel.git","ssh_url":"git@github.com:Jmeyer1292/godel.git","clone_url":"https://github.com/Jmeyer1292/godel.git","svn_url":"https://github.com/Jmeyer1292/godel","homepage":"","size":37619,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-industrial-consortium:kinetic-devel","ref":"kinetic-devel","sha":"2059108bb3063188745ab55f14873bcc4d01006d","user":{"login":"ros-industrial-consortium","id":6336074,"avatar_url":"https://avatars2.githubusercontent.com/u/6336074?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-industrial-consortium","html_url":"https://github.com/ros-industrial-consortium","followers_url":"https://api.github.com/users/ros-industrial-consortium/followers","following_url":"https://api.github.com/users/ros-industrial-consortium/following{/other_user}","gists_url":"https://api.github.com/users/ros-industrial-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-industrial-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-industrial-consortium/subscriptions","organizations_url":"https://api.github.com/users/ros-industrial-consortium/orgs","repos_url":"https://api.github.com/users/ros-industrial-consortium/repos","events_url":"https://api.github.com/users/ros-industrial-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/ros-industrial-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":17028696,"name":"godel","full_name":"ros-industrial-consortium/godel","owner":{"login":"ros-industrial-consortium","id":6336074,"avatar_url":"https://avatars2.githubusercontent.com/u/6336074?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-industrial-consortium","html_url":"https://github.com/ros-industrial-consortium","followers_url":"https://api.github.com/users/ros-industrial-consortium/followers","following_url":"https://api.github.com/users/ros-industrial-consortium/following{/other_user}","gists_url":"https://api.github.com/users/ros-industrial-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-industrial-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-industrial-consortium/subscriptions","organizations_url":"https://api.github.com/users/ros-industrial-consortium/orgs","repos_url":"https://api.github.com/users/ros-industrial-consortium/repos","events_url":"https://api.github.com/users/ros-industrial-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/ros-industrial-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-industrial-consortium/godel","description":"ROS-Industrial Focused Technical Project: Robotic Blending","fork":false,"url":"https://api.github.com/repos/ros-industrial-consortium/godel","forks_url":"https://api.github.com/repos/ros-industrial-consortium/godel/forks","keys_url":"https://api.github.com/repos/ros-industrial-consortium/godel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-industrial-consortium/godel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-industrial-consortium/godel/teams","hooks_url":"https://api.github.com/repos/ros-industrial-consortium/godel/hooks","issue_events_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/events{/number}","events_url":"https://api.github.com/repos/ros-industrial-consortium/godel/events","assignees_url":"https://api.github.com/repos/ros-industrial-consortium/godel/assignees{/user}","branches_url":"https://api.github.com/repos/ros-industrial-consortium/godel/branches{/branch}","tags_url":"https://api.github.com/repos/ros-industrial-consortium/godel/tags","blobs_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-industrial-consortium/godel/languages","stargazers_url":"https://api.github.com/repos/ros-industrial-consortium/godel/stargazers","contributors_url":"https://api.github.com/repos/ros-industrial-consortium/godel/contributors","subscribers_url":"https://api.github.com/repos/ros-industrial-consortium/godel/subscribers","subscription_url":"https://api.github.com/repos/ros-industrial-consortium/godel/subscription","commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-industrial-consortium/godel/contents/{+path}","compare_url":"https://api.github.com/repos/ros-industrial-consortium/godel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-industrial-consortium/godel/merges","archive_url":"https://api.github.com/repos/ros-industrial-consortium/godel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-industrial-consortium/godel/downloads","issues_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues{/number}","pulls_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-industrial-consortium/godel/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-industrial-consortium/godel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-industrial-consortium/godel/labels{/name}","releases_url":"https://api.github.com/repos/ros-industrial-consortium/godel/releases{/id}","deployments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/deployments","created_at":"2014-02-20T17:20:25Z","updated_at":"2017-02-18T04:29:08Z","pushed_at":"2017-03-06T22:47:57Z","git_url":"git://github.com/ros-industrial-consortium/godel.git","ssh_url":"git@github.com:ros-industrial-consortium/godel.git","clone_url":"https://github.com/ros-industrial-consortium/godel.git","svn_url":"https://github.com/ros-industrial-consortium/godel","homepage":"","size":33321,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":6,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184"},"html":{"href":"https://github.com/ros-industrial-consortium/godel/pull/184"},"issue":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/184"},"comments":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/30ec00fc579c850eb845e206a996598fda2ce7f0"}}}}
{"actor":{"display_login":"Jmeyer1292"}}