{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40639","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40639/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40639/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40639/events","html_url":"https://github.com/kubernetes/kubernetes/issues/40639","id":203782361,"number":40639,"title":"Only consider image locality for  'PullIfNotPresent' policy.","user":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars.githubusercontent.com/u/18107181?v=3","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-28T02:33:02Z","updated_at":"2017-01-30T18:03:56Z","closed_at":null,"body":"**Is this a BUG REPORT or FEATURE REQUEST?** (choose one):\r\nbug\r\n\r\n**Kubernetes version** (use `kubectl version`):\r\nmaster\r\n\r\n**Description**:\r\nThere's three different image pull policy here: Never, Always, PullIfNotPresent; the image locality should only consider the containers with PullIfNotPresent policy, there's no different for the other two policy in different node.\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/276140342","html_url":"https://github.com/kubernetes/kubernetes/issues/40639#issuecomment-276140342","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40639","id":276140342,"user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"created_at":"2017-01-30T18:03:56Z","updated_at":"2017-01-30T18:03:56Z","body":"> Agree; how about an estimation of those manifest? As \"big\" image may give \"incorrect\" priority.\r\n\r\nImage locality comes with a lot of caveats, so these cases don't bother me:\r\n* steer toward a node that had a version of an image over one that didn't (worst case, the node has to re-pull and it is no worse than the node that didn't have the image)\r\n* steer toward a node that had a bigger version of an image over one that has a smaller one (worst case, the node with the bigger image is out of date and has to re-pull the smaller one, which is better than the alternative)\r\n\r\n> Admin should pre-pull necessary images if never; image locality did not guarantee the image.\r\n\r\nI could maybe buy excluding PullNever from locality weight. @davidopp, your thoughts?"}}
{"actor":{"display_login":"liggitt"}}