{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/124988097","pull_request_review_id":47332846,"id":124988097,"diff_hunk":"@@ -321,6 +321,13 @@ public static FeedbackResponseCommentSearchResultBundle fromResults(\n             bundle.commentGiverTable.put(comment.getId().toString(),\n                     getFilteredCommentGiverName(bundle, instructorCourseIdList, response, comment, commentGiverName));\n             bundle.instructorEmailNameTable.put(comment.giverEmail, commentGiverName);\n+            if (!comment.lastEditorEmail.isEmpty()\n+                    && !bundle.instructorEmailNameTable.containsKey(comment.lastEditorEmail)) {\n+                InstructorAttributes instructor = instructorsDb.getInstructorForEmail(response.courseId,\n+                        comment.lastEditorEmail);\n+                String commentLastEditorName = instructor.displayedName + \" \" + instructor.name;\n+                bundle.instructorEmailNameTable.put(comment.lastEditorEmail, commentLastEditorName);\n+            }\n             bundle.numberOfResults++;","path":"src/main/java/teammates/storage/search/FeedbackResponseCommentSearchDocument.java","position":11,"original_position":11,"commit_id":"8716803b0cfbfe8f0712104118ede1a54089102b","original_commit_id":"8716803b0cfbfe8f0712104118ede1a54089102b","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"body":"Yes, we can add a test to cover this scenario. I'll update the PR with requested changes.","created_at":"2017-06-30T08:26:17Z","updated_at":"2017-06-30T08:26:17Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7641#discussion_r124988097","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/124988097"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7641#discussion_r124988097"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641","id":128255085,"html_url":"https://github.com/TEAMMATES/teammates/pull/7641","diff_url":"https://github.com/TEAMMATES/teammates/pull/7641.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7641.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7641","number":7641,"state":"open","locked":false,"title":"Instructor: search comments: Show name instead of null when comment author and editor are different #7640","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"body":"Fixes #7640 \r\nAdded lastEditorName in instructorEmailName map.","created_at":"2017-06-29T21:49:59Z","updated_at":"2017-06-30T08:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d85b8b1ba8d581069ea2062803bbf2d28a24e22","assignee":{"login":"chowyb","id":7546744,"avatar_url":"https://avatars0.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"chowyb","id":7546744,"avatar_url":"https://avatars0.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7641/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/8716803b0cfbfe8f0712104118ede1a54089102b","head":{"label":"Mynk96:7640-Instructor-search-comments-Shows-null-instead-of-comment-last-editor-name","ref":"7640-Instructor-search-comments-Shows-null-instead-of-comment-last-editor-name","sha":"8716803b0cfbfe8f0712104118ede1a54089102b","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"repo":{"id":88467207,"name":"teammates","full_name":"Mynk96/teammates","owner":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mynk96/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/Mynk96/teammates","forks_url":"https://api.github.com/repos/Mynk96/teammates/forks","keys_url":"https://api.github.com/repos/Mynk96/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mynk96/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mynk96/teammates/teams","hooks_url":"https://api.github.com/repos/Mynk96/teammates/hooks","issue_events_url":"https://api.github.com/repos/Mynk96/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/Mynk96/teammates/events","assignees_url":"https://api.github.com/repos/Mynk96/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/Mynk96/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/Mynk96/teammates/tags","blobs_url":"https://api.github.com/repos/Mynk96/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mynk96/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mynk96/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mynk96/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mynk96/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/Mynk96/teammates/languages","stargazers_url":"https://api.github.com/repos/Mynk96/teammates/stargazers","contributors_url":"https://api.github.com/repos/Mynk96/teammates/contributors","subscribers_url":"https://api.github.com/repos/Mynk96/teammates/subscribers","subscription_url":"https://api.github.com/repos/Mynk96/teammates/subscription","commits_url":"https://api.github.com/repos/Mynk96/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mynk96/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mynk96/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mynk96/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mynk96/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/Mynk96/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mynk96/teammates/merges","archive_url":"https://api.github.com/repos/Mynk96/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mynk96/teammates/downloads","issues_url":"https://api.github.com/repos/Mynk96/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/Mynk96/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/Mynk96/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/Mynk96/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mynk96/teammates/labels{/name}","releases_url":"https://api.github.com/repos/Mynk96/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/Mynk96/teammates/deployments","created_at":"2017-04-17T04:13:06Z","updated_at":"2017-04-17T04:13:12Z","pushed_at":"2017-06-30T07:41:10Z","git_url":"git://github.com/Mynk96/teammates.git","ssh_url":"git@github.com:Mynk96/teammates.git","clone_url":"https://github.com/Mynk96/teammates.git","svn_url":"https://github.com/Mynk96/teammates","homepage":"http://teammatesv4.appspot.com/","size":186719,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"5c940458d89b615f1c9cbbdae3d86513d99c11bf","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-06-29T15:15:29Z","pushed_at":"2017-06-30T08:22:47Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":188275,"stargazers_count":366,"watchers_count":366,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":839,"mirror_url":null,"open_issues_count":298,"forks":839,"open_issues":298,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7641"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7641"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7641/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7641/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/8716803b0cfbfe8f0712104118ede1a54089102b"}}}}
{"actor":{"display_login":"Mynk96"}}