{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/afw/pulls/comments/123820745","pull_request_review_id":46064375,"id":123820745,"diff_hunk":"@@ -136,13 +136,10 @@ FitsSchemaInputMapper::FitsSchemaInputMapper(daf::base::PropertyList &metadata,\n         // Read slots saved using an old mechanism in as aliases, since the new slot mechanism delegates\n         // slot definition to the AliasMap.\n         static std::array<std::pair<std::string, std::string>, 7> oldSlotKeys = {\n-                std::make_pair(\"PSF_FLUX\", \"slot_PsfFlux\"),\n-                std::make_pair(\"AP_FLUX\", \"slot_ApFlux\"),\n-                std::make_pair(\"INST_FLUX\", \"slot_InstFlux\"),\n-                std::make_pair(\"MODEL_FLUX\", \"slot_ModelFlux\"),\n-                std::make_pair(\"CALIB_FLUX\", \"slot_CalibFlux\"),\n-                std::make_pair(\"CENTROID\", \"slot_Centroid\"),\n-                std::make_pair(\"SHAPE\", \"slot_Shape\")};\n+                {std::make_pair(\"PSF_FLUX\", \"slot_PsfFlux\"), std::make_pair(\"AP_FLUX\", \"slot_ApFlux\"),\n+                 std::make_pair(\"INST_FLUX\", \"slot_InstFlux\"), std::make_pair(\"MODEL_FLUX\", \"slot_ModelFlux\"),\n+                 std::make_pair(\"CALIB_FLUX\", \"slot_CalibFlux\"), std::make_pair(\"CENTROID\", \"slot_Centroid\"),\n+                 std::make_pair(\"SHAPE\", \"slot_Shape\")}};","path":"src/table/io/FitsSchemaInputMapper.cc","position":23,"original_position":23,"commit_id":"9668c66ac2809fbb07b16b41e4d0f3b35872a29f","original_commit_id":"001f7f30364ab4fce0886c1252bcc824f5acb2be","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars0.githubusercontent.com/u/1606089?v=3","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"My format file looks the same as yours, except with a `---` as the first line, and `...` as the last line (copied directly from the [dev-guide](https://developer.lsst.io/tools/clang_format.html)).\r\n\r\nI just re-ran clang-format outside of sublimeText, and it didn't change the file as checked-in. My version is also installed via homebrew.","created_at":"2017-06-23T18:50:51Z","updated_at":"2017-06-23T18:50:52Z","html_url":"https://github.com/lsst/afw/pull/250#discussion_r123820745","pull_request_url":"https://api.github.com/repos/lsst/afw/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/lsst/afw/pulls/comments/123820745"},"html":{"href":"https://github.com/lsst/afw/pull/250#discussion_r123820745"},"pull_request":{"href":"https://api.github.com/repos/lsst/afw/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/afw/pulls/250","id":127114651,"html_url":"https://github.com/lsst/afw/pull/250","diff_url":"https://github.com/lsst/afw/pull/250.diff","patch_url":"https://github.com/lsst/afw/pull/250.patch","issue_url":"https://api.github.com/repos/lsst/afw/issues/250","number":250,"state":"open","locked":false,"title":"DM-10257: Fix compiler warnings in afw","user":{"login":"kfindeisen","id":8508260,"avatar_url":"https://avatars0.githubusercontent.com/u/8508260?v=3","gravatar_id":"","url":"https://api.github.com/users/kfindeisen","html_url":"https://github.com/kfindeisen","followers_url":"https://api.github.com/users/kfindeisen/followers","following_url":"https://api.github.com/users/kfindeisen/following{/other_user}","gists_url":"https://api.github.com/users/kfindeisen/gists{/gist_id}","starred_url":"https://api.github.com/users/kfindeisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfindeisen/subscriptions","organizations_url":"https://api.github.com/users/kfindeisen/orgs","repos_url":"https://api.github.com/users/kfindeisen/repos","events_url":"https://api.github.com/users/kfindeisen/events{/privacy}","received_events_url":"https://api.github.com/users/kfindeisen/received_events","type":"User","site_admin":false},"body":"This PR eliminates all but one compiler warning (unused `fits::{}::getFormatCode(int8_t)`) when building `afw` with Ubuntu+GCC and MacOS+Clang. Justifications for individual changes are included in the commit messages.\r\n\r\nDuring the MacOS port a few unrelated clang-format changes were made because of the mismatch in clang-format versions between Ubuntu and MacOS. @parejkoj and I allowed them to get committed on the grounds that we will probably standardize on clang-format 5 anyway.","created_at":"2017-06-23T00:35:54Z","updated_at":"2017-06-23T18:50:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b1dfef3c392661d067b914db86c3475670577d4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/afw/pulls/250/commits","review_comments_url":"https://api.github.com/repos/lsst/afw/pulls/250/comments","review_comment_url":"https://api.github.com/repos/lsst/afw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/afw/issues/250/comments","statuses_url":"https://api.github.com/repos/lsst/afw/statuses/9668c66ac2809fbb07b16b41e4d0f3b35872a29f","head":{"label":"lsst:tickets/DM-10257","ref":"tickets/DM-10257","sha":"9668c66ac2809fbb07b16b41e4d0f3b35872a29f","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars2.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013175,"name":"afw","full_name":"lsst/afw","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars2.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/afw","description":"LSST data management: astronomical framework, including images and tables","fork":false,"url":"https://api.github.com/repos/lsst/afw","forks_url":"https://api.github.com/repos/lsst/afw/forks","keys_url":"https://api.github.com/repos/lsst/afw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/afw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/afw/teams","hooks_url":"https://api.github.com/repos/lsst/afw/hooks","issue_events_url":"https://api.github.com/repos/lsst/afw/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/afw/events","assignees_url":"https://api.github.com/repos/lsst/afw/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/afw/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/afw/tags","blobs_url":"https://api.github.com/repos/lsst/afw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/afw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/afw/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/afw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/afw/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/afw/languages","stargazers_url":"https://api.github.com/repos/lsst/afw/stargazers","contributors_url":"https://api.github.com/repos/lsst/afw/contributors","subscribers_url":"https://api.github.com/repos/lsst/afw/subscribers","subscription_url":"https://api.github.com/repos/lsst/afw/subscription","commits_url":"https://api.github.com/repos/lsst/afw/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/afw/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/afw/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/afw/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/afw/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/afw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/afw/merges","archive_url":"https://api.github.com/repos/lsst/afw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/afw/downloads","issues_url":"https://api.github.com/repos/lsst/afw/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/afw/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/afw/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/afw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/afw/labels{/name}","releases_url":"https://api.github.com/repos/lsst/afw/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/afw/deployments","created_at":"2014-08-16T07:37:40Z","updated_at":"2017-05-04T19:08:03Z","pushed_at":"2017-06-23T18:45:16Z","git_url":"git://github.com/lsst/afw.git","ssh_url":"git@github.com:lsst/afw.git","clone_url":"https://github.com/lsst/afw.git","svn_url":"https://github.com/lsst/afw","homepage":"http://dm.lsst.org/","size":42465,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"3b0c5d9aec8340b5c3b72be2660f804ed2bb232c","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars2.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013175,"name":"afw","full_name":"lsst/afw","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars2.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/afw","description":"LSST data management: astronomical framework, including images and tables","fork":false,"url":"https://api.github.com/repos/lsst/afw","forks_url":"https://api.github.com/repos/lsst/afw/forks","keys_url":"https://api.github.com/repos/lsst/afw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/afw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/afw/teams","hooks_url":"https://api.github.com/repos/lsst/afw/hooks","issue_events_url":"https://api.github.com/repos/lsst/afw/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/afw/events","assignees_url":"https://api.github.com/repos/lsst/afw/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/afw/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/afw/tags","blobs_url":"https://api.github.com/repos/lsst/afw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/afw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/afw/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/afw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/afw/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/afw/languages","stargazers_url":"https://api.github.com/repos/lsst/afw/stargazers","contributors_url":"https://api.github.com/repos/lsst/afw/contributors","subscribers_url":"https://api.github.com/repos/lsst/afw/subscribers","subscription_url":"https://api.github.com/repos/lsst/afw/subscription","commits_url":"https://api.github.com/repos/lsst/afw/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/afw/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/afw/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/afw/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/afw/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/afw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/afw/merges","archive_url":"https://api.github.com/repos/lsst/afw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/afw/downloads","issues_url":"https://api.github.com/repos/lsst/afw/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/afw/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/afw/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/afw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/afw/labels{/name}","releases_url":"https://api.github.com/repos/lsst/afw/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/afw/deployments","created_at":"2014-08-16T07:37:40Z","updated_at":"2017-05-04T19:08:03Z","pushed_at":"2017-06-23T18:45:16Z","git_url":"git://github.com/lsst/afw.git","ssh_url":"git@github.com:lsst/afw.git","clone_url":"https://github.com/lsst/afw.git","svn_url":"https://github.com/lsst/afw","homepage":"http://dm.lsst.org/","size":42465,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/afw/pulls/250"},"html":{"href":"https://github.com/lsst/afw/pull/250"},"issue":{"href":"https://api.github.com/repos/lsst/afw/issues/250"},"comments":{"href":"https://api.github.com/repos/lsst/afw/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/afw/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/afw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/afw/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/afw/statuses/9668c66ac2809fbb07b16b41e4d0f3b35872a29f"}}}}
{"actor":{"display_login":"parejkoj"}}