{"action":"closed","number":8808,"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/8808","id":110940939,"html_url":"https://github.com/flutter/flutter/pull/8808","diff_url":"https://github.com/flutter/flutter/pull/8808.diff","patch_url":"https://github.com/flutter/flutter/pull/8808.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/8808","number":8808,"state":"closed","locked":false,"title":"update flutter analyze to call dartanalyzer","user":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars3.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"body":"Now that `dartanalyzer` uses the default Flutter analysis options (`package:flutter/analysis_options_user.yaml`) to analyze a flutter project,\r\nand a Dart SDK containing this functionality has rolled into Flutter...\r\n\r\nUpdate `flutter analyze` to use `dartanalyzer` for everything except analyzing the flutter repository. \r\n* Contains many but not all of the changes in [the original PR](https://github.com/flutter/flutter/pull/7444)\r\n* Fixes https://github.com/flutter/flutter/issues/8087 which appears to have regressed, and adds a test\r\n* Incrementally [improves `flutter analyze`](https://github.com/flutter/flutter/issues/7274)\r\n* One step closer to having `flutter analyze` always delegate to `dartanalyzer`\r\n  so that flutter tools might someday not be tightly coupled to analyzer\r\n\r\n@Hixie ","created_at":"2017-03-15T20:58:20Z","updated_at":"2017-03-28T12:24:12Z","closed_at":"2017-03-28T12:24:12Z","merged_at":null,"merge_commit_sha":"98149e1fd7c716665ab82c554d69f1e3f51650d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/8808/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/8808/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/8808/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/d374d1438ae5fc1fa42e9477701f550ff3c63a3f","head":{"label":"danrubel:flutter-analyze-call-dartanalyzer","ref":"flutter-analyze-call-dartanalyzer","sha":"d374d1438ae5fc1fa42e9477701f550ff3c63a3f","user":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars3.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"repo":{"id":66037711,"name":"flutter","full_name":"danrubel/flutter","owner":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars3.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrubel/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/danrubel/flutter","forks_url":"https://api.github.com/repos/danrubel/flutter/forks","keys_url":"https://api.github.com/repos/danrubel/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrubel/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrubel/flutter/teams","hooks_url":"https://api.github.com/repos/danrubel/flutter/hooks","issue_events_url":"https://api.github.com/repos/danrubel/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/danrubel/flutter/events","assignees_url":"https://api.github.com/repos/danrubel/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/danrubel/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/danrubel/flutter/tags","blobs_url":"https://api.github.com/repos/danrubel/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrubel/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrubel/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrubel/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrubel/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/danrubel/flutter/languages","stargazers_url":"https://api.github.com/repos/danrubel/flutter/stargazers","contributors_url":"https://api.github.com/repos/danrubel/flutter/contributors","subscribers_url":"https://api.github.com/repos/danrubel/flutter/subscribers","subscription_url":"https://api.github.com/repos/danrubel/flutter/subscription","commits_url":"https://api.github.com/repos/danrubel/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrubel/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrubel/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrubel/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/danrubel/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/danrubel/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrubel/flutter/merges","archive_url":"https://api.github.com/repos/danrubel/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrubel/flutter/downloads","issues_url":"https://api.github.com/repos/danrubel/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/danrubel/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/danrubel/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/danrubel/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrubel/flutter/labels{/name}","releases_url":"https://api.github.com/repos/danrubel/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/danrubel/flutter/deployments","created_at":"2016-08-18T23:40:06Z","updated_at":"2016-08-18T23:40:09Z","pushed_at":"2017-03-28T12:22:03Z","git_url":"git://github.com/danrubel/flutter.git","ssh_url":"git@github.com:danrubel/flutter.git","clone_url":"https://github.com/danrubel/flutter.git","svn_url":"https://github.com/danrubel/flutter","homepage":"https://flutter.io","size":23742,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"e0f26b44f202b198a4057ea1e39dc07df3cbe1f1","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-03-27T23:47:23Z","pushed_at":"2017-03-28T12:23:17Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":24040,"stargazers_count":4110,"watchers_count":4110,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":451,"mirror_url":null,"open_issues_count":1358,"forks":451,"open_issues":1358,"watchers":4110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8808"},"html":{"href":"https://github.com/flutter/flutter/pull/8808"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/8808"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/8808/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8808/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8808/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/d374d1438ae5fc1fa42e9477701f550ff3c63a3f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":48,"maintainer_can_modify":false,"commits":124,"additions":7363,"deletions":5954,"changed_files":388}}
{"actor":{"display_login":"danrubel"}}