{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12","id":112511133,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/12","diff_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/12.diff","patch_url":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/12.patch","issue_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/12","number":12,"state":"closed","locked":false,"title":"move to a prebuilt .so","user":{"login":"trevj","id":5142116,"avatar_url":"https://avatars0.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"body":"Following a bunch of work creating *another* Cordova plugin containing an `.so`, I'm convinced it's better to distribute the `.so` as part of the plugin rather than building it during the `cordova build` stage.\r\n\r\nI just couldn't make an app work which contains *two* plugins which *both* need to invoke `ndk build`: they conflict with each other in really annoying ways, partly due to how Cordova hoovers up output folders in a destructive way.\r\n\r\nI added instructions to the README on how to build the `.so`. It should be run whenever the source files change.","created_at":"2017-03-24T17:55:35Z","updated_at":"2017-03-24T18:15:43Z","closed_at":"2017-03-24T18:15:43Z","merged_at":"2017-03-24T18:15:43Z","merge_commit_sha":"2525a261470d1ef9ebea04f9d0a0e9582b89679a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12/commits","review_comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12/comments","review_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/12/comments","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/7c81ab55267f87ab6cc35f0cc239f905a5b8deae","head":{"label":"uProxy:trevj-prebuilt","ref":"trevj-prebuilt","sha":"7c81ab55267f87ab6cc35f0cc239f905a5b8deae","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars2.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":61642646,"name":"cordova-plugin-tun2socks","full_name":"uProxy/cordova-plugin-tun2socks","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars2.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks","description":"Cordova plugin to enable a system-wide VPN for Android devices.","fork":false,"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks","forks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/forks","keys_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/teams","hooks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/hooks","issue_events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/events","assignees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/tags","blobs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/languages","stargazers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/stargazers","contributors_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contributors","subscribers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscribers","subscription_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscription","commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/merges","archive_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/downloads","issues_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/deployments","created_at":"2016-06-21T14:53:44Z","updated_at":"2017-02-28T01:31:29Z","pushed_at":"2017-03-24T18:15:43Z","git_url":"git://github.com/uProxy/cordova-plugin-tun2socks.git","ssh_url":"git@github.com:uProxy/cordova-plugin-tun2socks.git","clone_url":"https://github.com/uProxy/cordova-plugin-tun2socks.git","svn_url":"https://github.com/uProxy/cordova-plugin-tun2socks","homepage":"","size":2042,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"4648afa6c1363d320110e940b2840d50655ce49b","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars2.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":61642646,"name":"cordova-plugin-tun2socks","full_name":"uProxy/cordova-plugin-tun2socks","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars2.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/cordova-plugin-tun2socks","description":"Cordova plugin to enable a system-wide VPN for Android devices.","fork":false,"url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks","forks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/forks","keys_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/teams","hooks_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/hooks","issue_events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/events","assignees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/tags","blobs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/languages","stargazers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/stargazers","contributors_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contributors","subscribers_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscribers","subscription_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/subscription","commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/merges","archive_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/downloads","issues_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/deployments","created_at":"2016-06-21T14:53:44Z","updated_at":"2017-02-28T01:31:29Z","pushed_at":"2017-03-24T18:15:43Z","git_url":"git://github.com/uProxy/cordova-plugin-tun2socks.git","ssh_url":"git@github.com:uProxy/cordova-plugin-tun2socks.git","clone_url":"https://github.com/uProxy/cordova-plugin-tun2socks.git","svn_url":"https://github.com/uProxy/cordova-plugin-tun2socks","homepage":"","size":2042,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12"},"html":{"href":"https://github.com/uProxy/cordova-plugin-tun2socks/pull/12"},"issue":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/12"},"comments":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/cordova-plugin-tun2socks/statuses/7c81ab55267f87ab6cc35f0cc239f905a5b8deae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"albertolalama","id":2132122,"avatar_url":"https://avatars0.githubusercontent.com/u/2132122?v=3","gravatar_id":"","url":"https://api.github.com/users/albertolalama","html_url":"https://github.com/albertolalama","followers_url":"https://api.github.com/users/albertolalama/followers","following_url":"https://api.github.com/users/albertolalama/following{/other_user}","gists_url":"https://api.github.com/users/albertolalama/gists{/gist_id}","starred_url":"https://api.github.com/users/albertolalama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertolalama/subscriptions","organizations_url":"https://api.github.com/users/albertolalama/orgs","repos_url":"https://api.github.com/users/albertolalama/repos","events_url":"https://api.github.com/users/albertolalama/events{/privacy}","received_events_url":"https://api.github.com/users/albertolalama/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":24,"deletions":74,"changed_files":979}}
{"actor":{"display_login":"albertolalama"}}