{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56956","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56956/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56956/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56956/events","html_url":"https://github.com/kubernetes/kubernetes/pull/56956","id":280407711,"number":56956,"title":"warning if AdvertiseAddress can't use in","user":{"login":"Lion-Wei","id":28696384,"avatar_url":"https://avatars1.githubusercontent.com/u/28696384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lion-Wei","html_url":"https://github.com/Lion-Wei","followers_url":"https://api.github.com/users/Lion-Wei/followers","following_url":"https://api.github.com/users/Lion-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Lion-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Lion-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lion-Wei/subscriptions","organizations_url":"https://api.github.com/users/Lion-Wei/orgs","repos_url":"https://api.github.com/users/Lion-Wei/repos","events_url":"https://api.github.com/users/Lion-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Lion-Wei/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"fabriziopandini","id":5013060,"avatar_url":"https://avatars0.githubusercontent.com/u/5013060?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziopandini","html_url":"https://github.com/fabriziopandini","followers_url":"https://api.github.com/users/fabriziopandini/followers","following_url":"https://api.github.com/users/fabriziopandini/following{/other_user}","gists_url":"https://api.github.com/users/fabriziopandini/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziopandini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziopandini/subscriptions","organizations_url":"https://api.github.com/users/fabriziopandini/orgs","repos_url":"https://api.github.com/users/fabriziopandini/repos","events_url":"https://api.github.com/users/fabriziopandini/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziopandini/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-12-08T08:16:15Z","updated_at":"2017-12-11T01:43:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56956","html_url":"https://github.com/kubernetes/kubernetes/pull/56956","diff_url":"https://github.com/kubernetes/kubernetes/pull/56956.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56956.patch"},"body":"\r\n**What this PR does / why we need it**:\r\n\r\nWhen using `kubeadm init --apiserver-advertise-address=****, `apiserver-advertise-address` can only be ipv4 or ipv6 address, if people use domain name in this field, will not use it and silently get hostIP.\r\n\r\nAdd a warning in this case.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes kubernetes/kubeadm#590\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/350602275","html_url":"https://github.com/kubernetes/kubernetes/pull/56956#issuecomment-350602275","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56956","id":350602275,"user":{"login":"Lion-Wei","id":28696384,"avatar_url":"https://avatars1.githubusercontent.com/u/28696384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lion-Wei","html_url":"https://github.com/Lion-Wei","followers_url":"https://api.github.com/users/Lion-Wei/followers","following_url":"https://api.github.com/users/Lion-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Lion-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Lion-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lion-Wei/subscriptions","organizations_url":"https://api.github.com/users/Lion-Wei/orgs","repos_url":"https://api.github.com/users/Lion-Wei/repos","events_url":"https://api.github.com/users/Lion-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Lion-Wei/received_events","type":"User","site_admin":false},"created_at":"2017-12-11T01:43:40Z","updated_at":"2017-12-11T01:43:40Z","author_association":"CONTRIBUTOR","body":"@fabriziopandini Thanks for replying. I'm not sure if make `--apiserver-advertise-address` accept dns name is a good idea, it's lots work, and I don't know weather there are other consideration, maybe need some discuss.\r\nAdd validation for `--apiserver-advertise-address` is a good idea for now, I think. There don't have any validate tight now, you can pass any string to this flag.\r\n"}}
{"actor":{"display_login":"Lion-Wei"}}