{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rcl/pulls/comments/112297276","pull_request_review_id":33601549,"id":112297276,"diff_hunk":"@@ -89,15 +88,28 @@ rcl_lifecycle_com_interface_init(rcl_lifecycle_com_interface_t * com_interface,\n   }\n \n   const char * node_name = rcl_node_get_name(node_handle);\n+  size_t node_name_length = strlen(node_name);\n+\n+  // Build topic, topic suffix hardcoded for now\n+  // and limited in length of 255\n+  // e.g. lc_talker__transition_event\n+  if ( ((node_name_length + 2 + strlen(pub_transition_event_suffix)) > 255) ||\n+    ((node_name_length + 2 + strlen(srv_get_state_suffix)) > 255) ||\n+    ((node_name_length + 2 + strlen(srv_change_state_suffix)) > 255) ||\n+    ((node_name_length + 2 + strlen(srv_get_available_states_suffix)) > 255) ||\n+    ((node_name_length + 2 + strlen(srv_get_available_transitions_suffix)) > 255))","path":"rcl_lifecycle/src/com_interface.c","position":null,"original_position":68,"commit_id":"6149a0c1e5feb009568947b9cf97e1d1ec9a6a91","original_commit_id":"98878f99d311c15581d01f047964e94449a1622f","user":{"login":"Karsten1987","id":5419873,"avatar_url":"https://avatars3.githubusercontent.com/u/5419873?v=3","gravatar_id":"","url":"https://api.github.com/users/Karsten1987","html_url":"https://github.com/Karsten1987","followers_url":"https://api.github.com/users/Karsten1987/followers","following_url":"https://api.github.com/users/Karsten1987/following{/other_user}","gists_url":"https://api.github.com/users/Karsten1987/gists{/gist_id}","starred_url":"https://api.github.com/users/Karsten1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karsten1987/subscriptions","organizations_url":"https://api.github.com/users/Karsten1987/orgs","repos_url":"https://api.github.com/users/Karsten1987/repos","events_url":"https://api.github.com/users/Karsten1987/events{/privacy}","received_events_url":"https://api.github.com/users/Karsten1987/received_events","type":"User","site_admin":false},"body":"I'd use the validation for now with the TODO here: https://github.com/ros2/rcl/pull/129/files#diff-adcd6db8c1d9559db68f3cf1dc285d61R56","created_at":"2017-04-19T19:49:39Z","updated_at":"2017-04-19T19:49:40Z","html_url":"https://github.com/ros2/rcl/pull/129#discussion_r112297276","pull_request_url":"https://api.github.com/repos/ros2/rcl/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments/112297276"},"html":{"href":"https://github.com/ros2/rcl/pull/129#discussion_r112297276"},"pull_request":{"href":"https://api.github.com/repos/ros2/rcl/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rcl/pulls/129","id":116452593,"html_url":"https://github.com/ros2/rcl/pull/129","diff_url":"https://github.com/ros2/rcl/pull/129.diff","patch_url":"https://github.com/ros2/rcl/pull/129.patch","issue_url":"https://api.github.com/repos/ros2/rcl/issues/129","number":129,"state":"open","locked":false,"title":"use c_utilities packages","user":{"login":"Karsten1987","id":5419873,"avatar_url":"https://avatars3.githubusercontent.com/u/5419873?v=3","gravatar_id":"","url":"https://api.github.com/users/Karsten1987","html_url":"https://github.com/Karsten1987","followers_url":"https://api.github.com/users/Karsten1987/followers","following_url":"https://api.github.com/users/Karsten1987/following{/other_user}","gists_url":"https://api.github.com/users/Karsten1987/gists{/gist_id}","starred_url":"https://api.github.com/users/Karsten1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karsten1987/subscriptions","organizations_url":"https://api.github.com/users/Karsten1987/orgs","repos_url":"https://api.github.com/users/Karsten1987/repos","events_url":"https://api.github.com/users/Karsten1987/events{/privacy}","received_events_url":"https://api.github.com/users/Karsten1987/received_events","type":"User","site_admin":false},"body":"connects to ros2/rcl#126\r\n\r\n","created_at":"2017-04-19T01:23:58Z","updated_at":"2017-04-19T19:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98e97b0296fd42b4d59d926d286ed373037bf3dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rcl/pulls/129/commits","review_comments_url":"https://api.github.com/repos/ros2/rcl/pulls/129/comments","review_comment_url":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rcl/issues/129/comments","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/6149a0c1e5feb009568947b9cf97e1d1ec9a6a91","head":{"label":"ros2:fix_concat","ref":"fix_concat","sha":"6149a0c1e5feb009568947b9cf97e1d1ec9a6a91","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"name":"rcl","full_name":"ros2/rcl","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2017-04-04T00:45:35Z","pushed_at":"2017-04-19T19:37:50Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":486,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":21,"forks":9,"open_issues":21,"watchers":7,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"415612f8af4b63b3b6cde677bb792a1e5bfdc61c","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"name":"rcl","full_name":"ros2/rcl","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2017-04-04T00:45:35Z","pushed_at":"2017-04-19T19:37:50Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":486,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":21,"forks":9,"open_issues":21,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/129"},"html":{"href":"https://github.com/ros2/rcl/pull/129"},"issue":{"href":"https://api.github.com/repos/ros2/rcl/issues/129"},"comments":{"href":"https://api.github.com/repos/ros2/rcl/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rcl/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rcl/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rcl/statuses/6149a0c1e5feb009568947b9cf97e1d1ec9a6a91"}}}}
{"actor":{"display_login":"Karsten1987"}}