{"action":"created","comment":{"url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments/118784280","pull_request_review_id":40613374,"id":118784280,"diff_hunk":"@@ -0,0 +1,5 @@\n+FactoryGirl.define do\n+  factory :knight do\n+    initialize_with { new(player) }","path":"spec/factories/knight_factory.rb","position":3,"original_position":3,"commit_id":"0903e73310f5d097fa95cfe964cf31d0bb3b9129","original_commit_id":"0903e73310f5d097fa95cfe964cf31d0bb3b9129","user":{"login":"natyork","id":17656034,"avatar_url":"https://avatars2.githubusercontent.com/u/17656034?v=3","gravatar_id":"","url":"https://api.github.com/users/natyork","html_url":"https://github.com/natyork","followers_url":"https://api.github.com/users/natyork/followers","following_url":"https://api.github.com/users/natyork/following{/other_user}","gists_url":"https://api.github.com/users/natyork/gists{/gist_id}","starred_url":"https://api.github.com/users/natyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natyork/subscriptions","organizations_url":"https://api.github.com/users/natyork/orgs","repos_url":"https://api.github.com/users/natyork/repos","events_url":"https://api.github.com/users/natyork/events{/privacy}","received_events_url":"https://api.github.com/users/natyork/received_events","type":"User","site_admin":false},"body":"@jacquesporveau I was just noodling this around as well...i think the reason this is used here is because we want to pass the player attribute into the Knight initialize method,\r\n so this seems to make sense to me from this perspective.\r\n (https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md#custom-construction) \r\n\r\nHowever, I am curious  whether there is an approach that will lead to less repetition overall than initializing each piece with a player. I'll need to think about that a bit. @swcraig have you looked at or discussed other design choices for this? I don't have one off the top of my head, but it might be an interesting discussion to have (maybe POODR will rescue us?)","created_at":"2017-05-26T20:30:05Z","updated_at":"2017-05-26T20:30:05Z","html_url":"https://github.com/swcraig/chess-stembolt/pull/27#discussion_r118784280","pull_request_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments/118784280"},"html":{"href":"https://github.com/swcraig/chess-stembolt/pull/27#discussion_r118784280"},"pull_request":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27","id":122699347,"html_url":"https://github.com/swcraig/chess-stembolt/pull/27","diff_url":"https://github.com/swcraig/chess-stembolt/pull/27.diff","patch_url":"https://github.com/swcraig/chess-stembolt/pull/27.patch","issue_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/27","number":27,"state":"open","locked":false,"title":"Add `Knight#movement_vectors`","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"body":"This returns an array of vectors that a Knight can move along.  `movement_vectors` is aliased to `knight_movement_vectors` since this is what the future `Piece` implementation of movement will call.","created_at":"2017-05-26T18:45:09Z","updated_at":"2017-05-26T20:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3138b7c34cb93416ce46f2683b1baa70c71052f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gregdaynes","id":43543,"avatar_url":"https://avatars3.githubusercontent.com/u/43543?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdaynes","html_url":"https://github.com/gregdaynes","followers_url":"https://api.github.com/users/gregdaynes/followers","following_url":"https://api.github.com/users/gregdaynes/following{/other_user}","gists_url":"https://api.github.com/users/gregdaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdaynes/subscriptions","organizations_url":"https://api.github.com/users/gregdaynes/orgs","repos_url":"https://api.github.com/users/gregdaynes/repos","events_url":"https://api.github.com/users/gregdaynes/events{/privacy}","received_events_url":"https://api.github.com/users/gregdaynes/received_events","type":"User","site_admin":false},{"login":"natyork","id":17656034,"avatar_url":"https://avatars2.githubusercontent.com/u/17656034?v=3","gravatar_id":"","url":"https://api.github.com/users/natyork","html_url":"https://github.com/natyork","followers_url":"https://api.github.com/users/natyork/followers","following_url":"https://api.github.com/users/natyork/following{/other_user}","gists_url":"https://api.github.com/users/natyork/gists{/gist_id}","starred_url":"https://api.github.com/users/natyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natyork/subscriptions","organizations_url":"https://api.github.com/users/natyork/orgs","repos_url":"https://api.github.com/users/natyork/repos","events_url":"https://api.github.com/users/natyork/events{/privacy}","received_events_url":"https://api.github.com/users/natyork/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27/commits","review_comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27/comments","review_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/27/comments","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/0903e73310f5d097fa95cfe964cf31d0bb3b9129","head":{"label":"swcraig:knight-move","ref":"knight-move","sha":"0903e73310f5d097fa95cfe964cf31d0bb3b9129","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"repo":{"id":90405359,"name":"chess-stembolt","full_name":"swcraig/chess-stembolt","owner":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swcraig/chess-stembolt","description":":white_square_button: ","fork":false,"url":"https://api.github.com/repos/swcraig/chess-stembolt","forks_url":"https://api.github.com/repos/swcraig/chess-stembolt/forks","keys_url":"https://api.github.com/repos/swcraig/chess-stembolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcraig/chess-stembolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcraig/chess-stembolt/teams","hooks_url":"https://api.github.com/repos/swcraig/chess-stembolt/hooks","issue_events_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/events{/number}","events_url":"https://api.github.com/repos/swcraig/chess-stembolt/events","assignees_url":"https://api.github.com/repos/swcraig/chess-stembolt/assignees{/user}","branches_url":"https://api.github.com/repos/swcraig/chess-stembolt/branches{/branch}","tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/tags","blobs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/{sha}","languages_url":"https://api.github.com/repos/swcraig/chess-stembolt/languages","stargazers_url":"https://api.github.com/repos/swcraig/chess-stembolt/stargazers","contributors_url":"https://api.github.com/repos/swcraig/chess-stembolt/contributors","subscribers_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscribers","subscription_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscription","commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcraig/chess-stembolt/contents/{+path}","compare_url":"https://api.github.com/repos/swcraig/chess-stembolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcraig/chess-stembolt/merges","archive_url":"https://api.github.com/repos/swcraig/chess-stembolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcraig/chess-stembolt/downloads","issues_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues{/number}","pulls_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls{/number}","milestones_url":"https://api.github.com/repos/swcraig/chess-stembolt/milestones{/number}","notifications_url":"https://api.github.com/repos/swcraig/chess-stembolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcraig/chess-stembolt/labels{/name}","releases_url":"https://api.github.com/repos/swcraig/chess-stembolt/releases{/id}","deployments_url":"https://api.github.com/repos/swcraig/chess-stembolt/deployments","created_at":"2017-05-05T18:28:41Z","updated_at":"2017-05-18T23:48:03Z","pushed_at":"2017-05-26T20:22:00Z","git_url":"git://github.com/swcraig/chess-stembolt.git","ssh_url":"git@github.com:swcraig/chess-stembolt.git","clone_url":"https://github.com/swcraig/chess-stembolt.git","svn_url":"https://github.com/swcraig/chess-stembolt","homepage":null,"size":63,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"dev"}},"base":{"label":"swcraig:dev","ref":"dev","sha":"35e3bae8e6986fda1b36f0333be70d733af15683","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"repo":{"id":90405359,"name":"chess-stembolt","full_name":"swcraig/chess-stembolt","owner":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swcraig/chess-stembolt","description":":white_square_button: ","fork":false,"url":"https://api.github.com/repos/swcraig/chess-stembolt","forks_url":"https://api.github.com/repos/swcraig/chess-stembolt/forks","keys_url":"https://api.github.com/repos/swcraig/chess-stembolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcraig/chess-stembolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcraig/chess-stembolt/teams","hooks_url":"https://api.github.com/repos/swcraig/chess-stembolt/hooks","issue_events_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/events{/number}","events_url":"https://api.github.com/repos/swcraig/chess-stembolt/events","assignees_url":"https://api.github.com/repos/swcraig/chess-stembolt/assignees{/user}","branches_url":"https://api.github.com/repos/swcraig/chess-stembolt/branches{/branch}","tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/tags","blobs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/{sha}","languages_url":"https://api.github.com/repos/swcraig/chess-stembolt/languages","stargazers_url":"https://api.github.com/repos/swcraig/chess-stembolt/stargazers","contributors_url":"https://api.github.com/repos/swcraig/chess-stembolt/contributors","subscribers_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscribers","subscription_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscription","commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcraig/chess-stembolt/contents/{+path}","compare_url":"https://api.github.com/repos/swcraig/chess-stembolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcraig/chess-stembolt/merges","archive_url":"https://api.github.com/repos/swcraig/chess-stembolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcraig/chess-stembolt/downloads","issues_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues{/number}","pulls_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls{/number}","milestones_url":"https://api.github.com/repos/swcraig/chess-stembolt/milestones{/number}","notifications_url":"https://api.github.com/repos/swcraig/chess-stembolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcraig/chess-stembolt/labels{/name}","releases_url":"https://api.github.com/repos/swcraig/chess-stembolt/releases{/id}","deployments_url":"https://api.github.com/repos/swcraig/chess-stembolt/deployments","created_at":"2017-05-05T18:28:41Z","updated_at":"2017-05-18T23:48:03Z","pushed_at":"2017-05-26T20:22:00Z","git_url":"git://github.com/swcraig/chess-stembolt.git","ssh_url":"git@github.com:swcraig/chess-stembolt.git","clone_url":"https://github.com/swcraig/chess-stembolt.git","svn_url":"https://github.com/swcraig/chess-stembolt","homepage":null,"size":63,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27"},"html":{"href":"https://github.com/swcraig/chess-stembolt/pull/27"},"issue":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/issues/27"},"comments":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/0903e73310f5d097fa95cfe964cf31d0bb3b9129"}}}}
{"actor":{"display_login":"natyork"}}