{"action":"created","comment":{"url":"https://api.github.com/repos/bundler/bundler/pulls/comments/132688504","pull_request_review_id":55798997,"id":132688504,"diff_hunk":"@@ -203,6 +203,17 @@ def md5_available?\n \n   private\n \n+    def validate_bundle_path\n+      return unless Bundler.bundle_path.to_s.match(File::PATH_SEPARATOR)","path":"lib/bundler/shared_helpers.rb","position":5,"original_position":5,"commit_id":"b7a412a2de9a562629aeeda4d83b10ac2b50887a","original_commit_id":"b7a412a2de9a562629aeeda4d83b10ac2b50887a","user":{"login":"segiddins","id":1946610,"avatar_url":"https://avatars1.githubusercontent.com/u/1946610?v=4","gravatar_id":"","url":"https://api.github.com/users/segiddins","html_url":"https://github.com/segiddins","followers_url":"https://api.github.com/users/segiddins/followers","following_url":"https://api.github.com/users/segiddins/following{/other_user}","gists_url":"https://api.github.com/users/segiddins/gists{/gist_id}","starred_url":"https://api.github.com/users/segiddins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segiddins/subscriptions","organizations_url":"https://api.github.com/users/segiddins/orgs","repos_url":"https://api.github.com/users/segiddins/repos","events_url":"https://api.github.com/users/segiddins/events{/privacy}","received_events_url":"https://api.github.com/users/segiddins/received_events","type":"User","site_admin":false},"body":"this can just use `include?(File::PATH_SEPARATOR)`","created_at":"2017-08-11T13:44:29Z","updated_at":"2017-08-11T13:44:29Z","html_url":"https://github.com/bundler/bundler/pull/5927#discussion_r132688504","pull_request_url":"https://api.github.com/repos/bundler/bundler/pulls/5927","_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments/132688504"},"html":{"href":"https://github.com/bundler/bundler/pull/5927#discussion_r132688504"},"pull_request":{"href":"https://api.github.com/repos/bundler/bundler/pulls/5927"}}},"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/5927","id":134332415,"html_url":"https://github.com/bundler/bundler/pull/5927","diff_url":"https://github.com/bundler/bundler/pull/5927.diff","patch_url":"https://github.com/bundler/bundler/pull/5927.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/5927","number":5927,"state":"open","locked":false,"title":"exit if bundle bin path contains a path separator","user":{"login":"ajwann","id":23248934,"avatar_url":"https://avatars3.githubusercontent.com/u/23248934?v=4","gravatar_id":"","url":"https://api.github.com/users/ajwann","html_url":"https://github.com/ajwann","followers_url":"https://api.github.com/users/ajwann/followers","following_url":"https://api.github.com/users/ajwann/following{/other_user}","gists_url":"https://api.github.com/users/ajwann/gists{/gist_id}","starred_url":"https://api.github.com/users/ajwann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajwann/subscriptions","organizations_url":"https://api.github.com/users/ajwann/orgs","repos_url":"https://api.github.com/users/ajwann/repos","events_url":"https://api.github.com/users/ajwann/events{/privacy}","received_events_url":"https://api.github.com/users/ajwann/received_events","type":"User","site_admin":false},"body":"fixes #5485\r\n\r\n### What was the end-user problem that led to this PR?\r\n\r\nBundler does not work with paths that contain the path separator.\r\n\r\n### What was your diagnosis of the problem?\r\n\r\nThe ```bundle_bin``` path can't contain a path separator.\r\n\r\n### What is your fix for the problem, implemented in this PR?\r\n\r\nWe can validate the ```bundle_path``` to make sure that it does not contain the\r\ncurrent ```File::PATH_SEPARATOR```. If we find the path separator, we exit with a non-zero\r\ncode and give the user an error message. \r\n\r\n### Why did you choose this fix out of the possible options?\r\n\r\nI chose this fix because it was recommended by @colby-swandale.\r\n","created_at":"2017-08-06T16:39:13Z","updated_at":"2017-08-11T13:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e3e3028a1edf1e2e87ea9e9e1a912ca5196355f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/5927/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/5927/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/5927/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/b7a412a2de9a562629aeeda4d83b10ac2b50887a","head":{"label":"ajwann:warn-if-path-contains-colon","ref":"warn-if-path-contains-colon","sha":"b7a412a2de9a562629aeeda4d83b10ac2b50887a","user":{"login":"ajwann","id":23248934,"avatar_url":"https://avatars3.githubusercontent.com/u/23248934?v=4","gravatar_id":"","url":"https://api.github.com/users/ajwann","html_url":"https://github.com/ajwann","followers_url":"https://api.github.com/users/ajwann/followers","following_url":"https://api.github.com/users/ajwann/following{/other_user}","gists_url":"https://api.github.com/users/ajwann/gists{/gist_id}","starred_url":"https://api.github.com/users/ajwann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajwann/subscriptions","organizations_url":"https://api.github.com/users/ajwann/orgs","repos_url":"https://api.github.com/users/ajwann/repos","events_url":"https://api.github.com/users/ajwann/events{/privacy}","received_events_url":"https://api.github.com/users/ajwann/received_events","type":"User","site_admin":false},"repo":{"id":98812972,"name":"bundler","full_name":"ajwann/bundler","owner":{"login":"ajwann","id":23248934,"avatar_url":"https://avatars3.githubusercontent.com/u/23248934?v=4","gravatar_id":"","url":"https://api.github.com/users/ajwann","html_url":"https://github.com/ajwann","followers_url":"https://api.github.com/users/ajwann/followers","following_url":"https://api.github.com/users/ajwann/following{/other_user}","gists_url":"https://api.github.com/users/ajwann/gists{/gist_id}","starred_url":"https://api.github.com/users/ajwann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajwann/subscriptions","organizations_url":"https://api.github.com/users/ajwann/orgs","repos_url":"https://api.github.com/users/ajwann/repos","events_url":"https://api.github.com/users/ajwann/events{/privacy}","received_events_url":"https://api.github.com/users/ajwann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajwann/bundler","description":"Manage your Ruby application's gem dependencies","fork":true,"url":"https://api.github.com/repos/ajwann/bundler","forks_url":"https://api.github.com/repos/ajwann/bundler/forks","keys_url":"https://api.github.com/repos/ajwann/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajwann/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajwann/bundler/teams","hooks_url":"https://api.github.com/repos/ajwann/bundler/hooks","issue_events_url":"https://api.github.com/repos/ajwann/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/ajwann/bundler/events","assignees_url":"https://api.github.com/repos/ajwann/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/ajwann/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/ajwann/bundler/tags","blobs_url":"https://api.github.com/repos/ajwann/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajwann/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajwann/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajwann/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajwann/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/ajwann/bundler/languages","stargazers_url":"https://api.github.com/repos/ajwann/bundler/stargazers","contributors_url":"https://api.github.com/repos/ajwann/bundler/contributors","subscribers_url":"https://api.github.com/repos/ajwann/bundler/subscribers","subscription_url":"https://api.github.com/repos/ajwann/bundler/subscription","commits_url":"https://api.github.com/repos/ajwann/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajwann/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajwann/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajwann/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajwann/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/ajwann/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajwann/bundler/merges","archive_url":"https://api.github.com/repos/ajwann/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajwann/bundler/downloads","issues_url":"https://api.github.com/repos/ajwann/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/ajwann/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/ajwann/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/ajwann/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajwann/bundler/labels{/name}","releases_url":"https://api.github.com/repos/ajwann/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/ajwann/bundler/deployments","created_at":"2017-07-30T17:16:13Z","updated_at":"2017-07-30T17:16:22Z","pushed_at":"2017-08-09T21:49:28Z","git_url":"git://github.com/ajwann/bundler.git","ssh_url":"git@github.com:ajwann/bundler.git","clone_url":"https://github.com/ajwann/bundler.git","svn_url":"https://github.com/ajwann/bundler","homepage":"https://bundler.io","size":32710,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"5f5a2f77f305655a1703b63df9cfebb8c3863670","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your Ruby application's gem dependencies","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/bundler/bundler/deployments","created_at":"2010-01-26T00:46:38Z","updated_at":"2017-08-11T09:25:05Z","pushed_at":"2017-08-11T00:55:56Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"https://bundler.io","size":32763,"stargazers_count":3867,"watchers_count":3867,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1813,"mirror_url":null,"open_issues_count":189,"forks":1813,"open_issues":189,"watchers":3867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/5927"},"html":{"href":"https://github.com/bundler/bundler/pull/5927"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/5927"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/5927/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/5927/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/5927/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/b7a412a2de9a562629aeeda4d83b10ac2b50887a"}}}}
{"actor":{"display_login":"segiddins"}}