{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/136719841","pull_request_review_id":60299023,"id":136719841,"diff_hunk":"@@ -602,65 +607,85 @@ class spell_rog_shiv : public SpellScriptLoader\n         }\n };\n \n-// 1784 - Stealth\n+/// Stealth - 1784, Subterfuge - 115191 and Subterfuge effect - 115192\n class spell_rog_stealth : public SpellScriptLoader\n {\n     public:\n         spell_rog_stealth() : SpellScriptLoader(\"spell_rog_stealth\") { }\n \n+        enum eSpells\n+        {\n+            Stealth = 1784,\n+            StealthSubterfuge = 115191,\n+            StealthSubterfugeEffect = 115192,\n+            StealthTriggered1 = 158188,\n+            StealthTriggered2 = 158185\n+        };\n+\n         class spell_rog_stealth_AuraScript : public AuraScript\n         {\n             PrepareAuraScript(spell_rog_stealth_AuraScript);\n \n-            bool Validate(SpellInfo const* /*spellInfo*/) override\n+            void OnApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)\n             {\n-                return ValidateSpellInfo(\n+                if (Unit* l_Caster = GetCaster())\n                 {\n-                    SPELL_ROGUE_MASTER_OF_SUBTLETY_PASSIVE,\n-                    SPELL_ROGUE_MASTER_OF_SUBTLETY_DAMAGE_PERCENT,\n-                    SPELL_ROGUE_MASTER_OF_SUBTLETY_PERIODIC,\n-                    SPELL_ROGUE_SANCTUARY,\n-                    SPELL_ROGUE_STEALTH_STEALTH_AURA,\n-                    SPELL_ROGUE_STEALTH_SHAPESHIFT_AURA\n-                });\n-            }\n-\n-            void HandleEffectApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)\n-            {\n-                Unit* target = GetTarget();\n+                    if (GetSpellInfo()->Id != eSpells::StealthSubterfugeEffect)\n+                    {\n+                        l_Caster->CastSpell(l_Caster, eSpells::StealthTriggered1, true);\n+                        l_Caster->CastSpell(l_Caster, eSpells::StealthTriggered2, true);\n \n-                // Master of Subtlety\n-                if (AuraEffect const* aurEff = target->GetAuraEffect(SPELL_ROGUE_MASTER_OF_SUBTLETY_PASSIVE, EFFECT_0))\n-                    target->CastCustomSpell(SPELL_ROGUE_MASTER_OF_SUBTLETY_DAMAGE_PERCENT, SPELLVALUE_BASE_POINT0, aurEff->GetAmount(), target, true);\n+                        if (l_Caster->HasAura(SPELL_ROGUE_NIGHTSTALKER_AURA))\n+                            l_Caster->CastSpell(l_Caster, SPELL_ROGUE_NIGHTSTALKER_DAMAGE_DONE, true);\n \n-                target->CastSpell(target, SPELL_ROGUE_SANCTUARY, TRIGGERED_FULL_MASK);\n-                target->CastSpell(target, SPELL_ROGUE_STEALTH_STEALTH_AURA, TRIGGERED_FULL_MASK);\n-                target->CastSpell(target, SPELL_ROGUE_STEALTH_SHAPESHIFT_AURA, TRIGGERED_FULL_MASK);\n+                        if (l_Caster->HasAura(SPELL_ROGUE_SHADOW_FOCUS_AURA))\n+                            l_Caster->CastSpell(l_Caster, SPELL_ROGUE_SHADOW_FOCUS_COST_PCT, true);\n+                    }\n+                    else\n+                    {\n+                        if (l_Caster->HasAura(eSpells::StealthSubterfuge))","path":"src/server/scripts/Spells/spell_rogue.cpp","position":82,"original_position":82,"commit_id":"18a86892ba753246b13cbb6a63ab28b644c16707","original_commit_id":"18a86892ba753246b13cbb6a63ab28b644c16707","user":{"login":"joschiwald","id":736792,"avatar_url":"https://avatars2.githubusercontent.com/u/736792?v=4","gravatar_id":"","url":"https://api.github.com/users/joschiwald","html_url":"https://github.com/joschiwald","followers_url":"https://api.github.com/users/joschiwald/followers","following_url":"https://api.github.com/users/joschiwald/following{/other_user}","gists_url":"https://api.github.com/users/joschiwald/gists{/gist_id}","starred_url":"https://api.github.com/users/joschiwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschiwald/subscriptions","organizations_url":"https://api.github.com/users/joschiwald/orgs","repos_url":"https://api.github.com/users/joschiwald/repos","events_url":"https://api.github.com/users/joschiwald/events{/privacy}","received_events_url":"https://api.github.com/users/joschiwald/received_events","type":"User","site_admin":false},"body":"useless hasaura check","created_at":"2017-09-03T15:50:43Z","updated_at":"2017-09-03T15:50:43Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/20237#discussion_r136719841","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/136719841"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/20237#discussion_r136719841"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237","id":139025033,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/20237","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/20237.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/20237.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20237","number":20237,"state":"open","locked":false,"title":"Core/Spells: Stealth, Subterfuge and Subterfuge effect","user":{"login":"Daniel25","id":11072783,"avatar_url":"https://avatars0.githubusercontent.com/u/11072783?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel25","html_url":"https://github.com/Daniel25","followers_url":"https://api.github.com/users/Daniel25/followers","following_url":"https://api.github.com/users/Daniel25/following{/other_user}","gists_url":"https://api.github.com/users/Daniel25/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel25/subscriptions","organizations_url":"https://api.github.com/users/Daniel25/orgs","repos_url":"https://api.github.com/users/Daniel25/repos","events_url":"https://api.github.com/users/Daniel25/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel25/received_events","type":"User","site_admin":false},"body":"-  Stealh working, it wasnt working.\r\n-  Subterfuge working, it wasnt working.\r\n\r\n- [ ] master\r\n- last commit: https://github.com/TrinityCore/TrinityCore/commit/52c7f12ed35f321dc97d8caea2b112287f5ac05b\r\n\r\n**It builds and works in game.\r\n\r\n","created_at":"2017-09-02T20:16:36Z","updated_at":"2017-09-03T15:50:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c53959445c82f792a614731690587f38758bae6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20237/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/18a86892ba753246b13cbb6a63ab28b644c16707","head":{"label":"Daniel25:master","ref":"master","sha":"18a86892ba753246b13cbb6a63ab28b644c16707","user":{"login":"Daniel25","id":11072783,"avatar_url":"https://avatars0.githubusercontent.com/u/11072783?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel25","html_url":"https://github.com/Daniel25","followers_url":"https://api.github.com/users/Daniel25/followers","following_url":"https://api.github.com/users/Daniel25/following{/other_user}","gists_url":"https://api.github.com/users/Daniel25/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel25/subscriptions","organizations_url":"https://api.github.com/users/Daniel25/orgs","repos_url":"https://api.github.com/users/Daniel25/repos","events_url":"https://api.github.com/users/Daniel25/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel25/received_events","type":"User","site_admin":false},"repo":{"id":102220011,"name":"TrinityCore","full_name":"Daniel25/TrinityCore","owner":{"login":"Daniel25","id":11072783,"avatar_url":"https://avatars0.githubusercontent.com/u/11072783?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel25","html_url":"https://github.com/Daniel25","followers_url":"https://api.github.com/users/Daniel25/followers","following_url":"https://api.github.com/users/Daniel25/following{/other_user}","gists_url":"https://api.github.com/users/Daniel25/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel25/subscriptions","organizations_url":"https://api.github.com/users/Daniel25/orgs","repos_url":"https://api.github.com/users/Daniel25/repos","events_url":"https://api.github.com/users/Daniel25/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daniel25/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.2.5.24742, 3.3.5 = 3.3.5a.12340)","fork":true,"url":"https://api.github.com/repos/Daniel25/TrinityCore","forks_url":"https://api.github.com/repos/Daniel25/TrinityCore/forks","keys_url":"https://api.github.com/repos/Daniel25/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daniel25/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daniel25/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Daniel25/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Daniel25/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Daniel25/TrinityCore/events","assignees_url":"https://api.github.com/repos/Daniel25/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Daniel25/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Daniel25/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Daniel25/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daniel25/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daniel25/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daniel25/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daniel25/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Daniel25/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Daniel25/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Daniel25/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Daniel25/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Daniel25/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Daniel25/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daniel25/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daniel25/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daniel25/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Daniel25/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Daniel25/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daniel25/TrinityCore/merges","archive_url":"https://api.github.com/repos/Daniel25/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daniel25/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Daniel25/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Daniel25/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Daniel25/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Daniel25/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daniel25/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Daniel25/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Daniel25/TrinityCore/deployments","created_at":"2017-09-02T19:50:50Z","updated_at":"2017-09-02T19:51:07Z","pushed_at":"2017-09-02T20:22:57Z","git_url":"git://github.com/Daniel25/TrinityCore.git","ssh_url":"git@github.com:Daniel25/TrinityCore.git","clone_url":"https://github.com/Daniel25/TrinityCore.git","svn_url":"https://github.com/Daniel25/TrinityCore","homepage":"http://www.trinitycore.org","size":463578,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityCore:master","ref":"master","sha":"52c7f12ed35f321dc97d8caea2b112287f5ac05b","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.2.5.24742, 3.3.5 = 3.3.5a.12340)","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2017-09-03T13:36:49Z","pushed_at":"2017-09-02T20:23:00Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":463566,"stargazers_count":3952,"watchers_count":3952,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3853,"mirror_url":null,"open_issues_count":1553,"forks":3853,"open_issues":1553,"watchers":3952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/20237"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20237"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20237/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20237/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/18a86892ba753246b13cbb6a63ab28b644c16707"}},"author_association":"NONE"}}
{"actor":{"display_login":"joschiwald"}}