{"action":"created","comment":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/111686534","pull_request_review_id":32946467,"id":111686534,"diff_hunk":"@@ -471,6 +473,9 @@ def initialize\n       # Used to set higher priority option values from the command line.\n       def force(hash)\n         ordering_manager.force(hash)\n+        [:deprecation_stream, :output_stream].each do |stream|\n+          hash[stream] = prepare_stream(hash[stream]) if hash.key?(stream)\n+        end","path":"lib/rspec/core/configuration.rb","position":51,"original_position":51,"commit_id":"2efdb70650e2400e34ec243c4fa8ef4b9696402c","original_commit_id":"2efdb70650e2400e34ec243c4fa8ef4b9696402c","user":{"login":"dzjuck","id":1269260,"avatar_url":"https://avatars0.githubusercontent.com/u/1269260?v=3","gravatar_id":"","url":"https://api.github.com/users/dzjuck","html_url":"https://github.com/dzjuck","followers_url":"https://api.github.com/users/dzjuck/followers","following_url":"https://api.github.com/users/dzjuck/following{/other_user}","gists_url":"https://api.github.com/users/dzjuck/gists{/gist_id}","starred_url":"https://api.github.com/users/dzjuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzjuck/subscriptions","organizations_url":"https://api.github.com/users/dzjuck/orgs","repos_url":"https://api.github.com/users/dzjuck/repos","events_url":"https://api.github.com/users/dzjuck/events{/privacy}","received_events_url":"https://api.github.com/users/dzjuck/received_events","type":"User","site_admin":false},"body":"There is one more place where `deprecation_stream` can be set.","created_at":"2017-04-16T15:51:50Z","updated_at":"2017-04-16T15:51:50Z","html_url":"https://github.com/rspec/rspec-core/pull/2401#discussion_r111686534","pull_request_url":"https://api.github.com/repos/rspec/rspec-core/pulls/2401","_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments/111686534"},"html":{"href":"https://github.com/rspec/rspec-core/pull/2401#discussion_r111686534"},"pull_request":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/2401"}}},"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/2401","id":111436825,"html_url":"https://github.com/rspec/rspec-core/pull/2401","diff_url":"https://github.com/rspec/rspec-core/pull/2401.diff","patch_url":"https://github.com/rspec/rspec-core/pull/2401.patch","issue_url":"https://api.github.com/repos/rspec/rspec-core/issues/2401","number":2401,"state":"open","locked":false,"title":"Add output stream changing for created formatters","user":{"login":"dzjuck","id":1269260,"avatar_url":"https://avatars0.githubusercontent.com/u/1269260?v=3","gravatar_id":"","url":"https://api.github.com/users/dzjuck","html_url":"https://github.com/dzjuck","followers_url":"https://api.github.com/users/dzjuck/followers","following_url":"https://api.github.com/users/dzjuck/following{/other_user}","gists_url":"https://api.github.com/users/dzjuck/gists{/gist_id}","starred_url":"https://api.github.com/users/dzjuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzjuck/subscriptions","organizations_url":"https://api.github.com/users/dzjuck/orgs","repos_url":"https://api.github.com/users/dzjuck/repos","events_url":"https://api.github.com/users/dzjuck/events{/privacy}","received_events_url":"https://api.github.com/users/dzjuck/received_events","type":"User","site_admin":false},"body":"Reason of bug described in #2216. I think easiest way to fix - update `output` of already created formatters at every change of config `output_stream`.\r\n\r\nI’m not sure how tests should be written for this fix. So if any thoughts how to tests should be done or how to make solution better - i will glad to make it.\r\n","created_at":"2017-03-19T04:34:38Z","updated_at":"2017-04-16T15:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83b138914e6664b44dec326672a6cdf65e5597a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rspec/rspec-core/pulls/2401/commits","review_comments_url":"https://api.github.com/repos/rspec/rspec-core/pulls/2401/comments","review_comment_url":"https://api.github.com/repos/rspec/rspec-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rspec/rspec-core/issues/2401/comments","statuses_url":"https://api.github.com/repos/rspec/rspec-core/statuses/2efdb70650e2400e34ec243c4fa8ef4b9696402c","head":{"label":"dzjuck:fix-output_stream-with-format","ref":"fix-output_stream-with-format","sha":"2efdb70650e2400e34ec243c4fa8ef4b9696402c","user":{"login":"dzjuck","id":1269260,"avatar_url":"https://avatars0.githubusercontent.com/u/1269260?v=3","gravatar_id":"","url":"https://api.github.com/users/dzjuck","html_url":"https://github.com/dzjuck","followers_url":"https://api.github.com/users/dzjuck/followers","following_url":"https://api.github.com/users/dzjuck/following{/other_user}","gists_url":"https://api.github.com/users/dzjuck/gists{/gist_id}","starred_url":"https://api.github.com/users/dzjuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzjuck/subscriptions","organizations_url":"https://api.github.com/users/dzjuck/orgs","repos_url":"https://api.github.com/users/dzjuck/repos","events_url":"https://api.github.com/users/dzjuck/events{/privacy}","received_events_url":"https://api.github.com/users/dzjuck/received_events","type":"User","site_admin":false},"repo":{"id":85393634,"name":"rspec-core","full_name":"dzjuck/rspec-core","owner":{"login":"dzjuck","id":1269260,"avatar_url":"https://avatars0.githubusercontent.com/u/1269260?v=3","gravatar_id":"","url":"https://api.github.com/users/dzjuck","html_url":"https://github.com/dzjuck","followers_url":"https://api.github.com/users/dzjuck/followers","following_url":"https://api.github.com/users/dzjuck/following{/other_user}","gists_url":"https://api.github.com/users/dzjuck/gists{/gist_id}","starred_url":"https://api.github.com/users/dzjuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzjuck/subscriptions","organizations_url":"https://api.github.com/users/dzjuck/orgs","repos_url":"https://api.github.com/users/dzjuck/repos","events_url":"https://api.github.com/users/dzjuck/events{/privacy}","received_events_url":"https://api.github.com/users/dzjuck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzjuck/rspec-core","description":"RSpec runner and formatters","fork":true,"url":"https://api.github.com/repos/dzjuck/rspec-core","forks_url":"https://api.github.com/repos/dzjuck/rspec-core/forks","keys_url":"https://api.github.com/repos/dzjuck/rspec-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzjuck/rspec-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzjuck/rspec-core/teams","hooks_url":"https://api.github.com/repos/dzjuck/rspec-core/hooks","issue_events_url":"https://api.github.com/repos/dzjuck/rspec-core/issues/events{/number}","events_url":"https://api.github.com/repos/dzjuck/rspec-core/events","assignees_url":"https://api.github.com/repos/dzjuck/rspec-core/assignees{/user}","branches_url":"https://api.github.com/repos/dzjuck/rspec-core/branches{/branch}","tags_url":"https://api.github.com/repos/dzjuck/rspec-core/tags","blobs_url":"https://api.github.com/repos/dzjuck/rspec-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzjuck/rspec-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzjuck/rspec-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzjuck/rspec-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzjuck/rspec-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dzjuck/rspec-core/languages","stargazers_url":"https://api.github.com/repos/dzjuck/rspec-core/stargazers","contributors_url":"https://api.github.com/repos/dzjuck/rspec-core/contributors","subscribers_url":"https://api.github.com/repos/dzjuck/rspec-core/subscribers","subscription_url":"https://api.github.com/repos/dzjuck/rspec-core/subscription","commits_url":"https://api.github.com/repos/dzjuck/rspec-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzjuck/rspec-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzjuck/rspec-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzjuck/rspec-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzjuck/rspec-core/contents/{+path}","compare_url":"https://api.github.com/repos/dzjuck/rspec-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzjuck/rspec-core/merges","archive_url":"https://api.github.com/repos/dzjuck/rspec-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzjuck/rspec-core/downloads","issues_url":"https://api.github.com/repos/dzjuck/rspec-core/issues{/number}","pulls_url":"https://api.github.com/repos/dzjuck/rspec-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dzjuck/rspec-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dzjuck/rspec-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzjuck/rspec-core/labels{/name}","releases_url":"https://api.github.com/repos/dzjuck/rspec-core/releases{/id}","deployments_url":"https://api.github.com/repos/dzjuck/rspec-core/deployments","created_at":"2017-03-18T10:38:05Z","updated_at":"2017-03-18T10:38:08Z","pushed_at":"2017-04-16T15:37:51Z","git_url":"git://github.com/dzjuck/rspec-core.git","ssh_url":"git@github.com:dzjuck/rspec-core.git","clone_url":"https://github.com/dzjuck/rspec-core.git","svn_url":"https://github.com/dzjuck/rspec-core","homepage":"http://relishapp.com/rspec/rspec-core","size":10321,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rspec:master","ref":"master","sha":"3db13ca670ad1d56370d9747b12f9555391653c2","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars3.githubusercontent.com/u/22388?v=3","gravatar_id":"","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":238972,"name":"rspec-core","full_name":"rspec/rspec-core","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars3.githubusercontent.com/u/22388?v=3","gravatar_id":"","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-core","description":"RSpec runner and formatters","fork":false,"url":"https://api.github.com/repos/rspec/rspec-core","forks_url":"https://api.github.com/repos/rspec/rspec-core/forks","keys_url":"https://api.github.com/repos/rspec/rspec-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-core/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-core/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-core/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-core/events","assignees_url":"https://api.github.com/repos/rspec/rspec-core/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-core/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-core/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-core/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-core/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-core/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-core/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-core/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rspec/rspec-core/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-core/merges","archive_url":"https://api.github.com/repos/rspec/rspec-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-core/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-core/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-core/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-core/releases{/id}","deployments_url":"https://api.github.com/repos/rspec/rspec-core/deployments","created_at":"2009-06-29T15:41:05Z","updated_at":"2017-04-14T15:23:16Z","pushed_at":"2017-04-16T15:37:53Z","git_url":"git://github.com/rspec/rspec-core.git","ssh_url":"git@github.com:rspec/rspec-core.git","clone_url":"https://github.com/rspec/rspec-core.git","svn_url":"https://github.com/rspec/rspec-core","homepage":"http://relishapp.com/rspec/rspec-core","size":10309,"stargazers_count":809,"watchers_count":809,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":582,"mirror_url":null,"open_issues_count":27,"forks":582,"open_issues":27,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/2401"},"html":{"href":"https://github.com/rspec/rspec-core/pull/2401"},"issue":{"href":"https://api.github.com/repos/rspec/rspec-core/issues/2401"},"comments":{"href":"https://api.github.com/repos/rspec/rspec-core/issues/2401/comments"},"review_comments":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/2401/comments"},"review_comment":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rspec/rspec-core/pulls/2401/commits"},"statuses":{"href":"https://api.github.com/repos/rspec/rspec-core/statuses/2efdb70650e2400e34ec243c4fa8ef4b9696402c"}}}}
{"actor":{"display_login":"dzjuck"}}