{"action":"created","issue":{"url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/30","repository_url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets","labels_url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/30/comments","events_url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/30/events","html_url":"https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/pull/30","id":228480408,"number":30,"title":"Adds support for several altcoins and more","user":{"login":"filidorwiese","id":864967,"avatar_url":"https://avatars2.githubusercontent.com/u/864967?v=3","gravatar_id":"","url":"https://api.github.com/users/filidorwiese","html_url":"https://github.com/filidorwiese","followers_url":"https://api.github.com/users/filidorwiese/followers","following_url":"https://api.github.com/users/filidorwiese/following{/other_user}","gists_url":"https://api.github.com/users/filidorwiese/gists{/gist_id}","starred_url":"https://api.github.com/users/filidorwiese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filidorwiese/subscriptions","organizations_url":"https://api.github.com/users/filidorwiese/orgs","repos_url":"https://api.github.com/users/filidorwiese/repos","events_url":"https://api.github.com/users/filidorwiese/events{/privacy}","received_events_url":"https://api.github.com/users/filidorwiese/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-13T15:28:28Z","updated_at":"2017-05-30T19:46:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/pulls/30","html_url":"https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/pull/30","diff_url":"https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/pull/30.diff","patch_url":"https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/pull/30.patch"},"body":"Hi! Thanks for the great Gnome Shell Bitcoin extension. I've made some changes on a fork that you'd might want to merge into your master.\r\n\r\nFunctionality:\r\n* Altcoins support for the existing providers\r\n* Adds BTC-E and Poloniex providers\r\n* Removes \"Unit\" from indicator settings, mBTC didn't make sense together with altcoins\r\n* Changes format of indicator to include currency plus chosen coin\r\n* Adds support for older version of Gnome shell (3.20)\r\n\r\nI've also been thinking about adding an amount field to the Provider dialog that you can use to fill in how much of a certain coin you have. This would allow you to see the value of your portfolio in a glance. Let me know if this is something you would like to merge."},"comment":{"url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/comments/304987321","html_url":"https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/pull/30#issuecomment-304987321","issue_url":"https://api.github.com/repos/OttoAllmendinger/gnome-shell-bitcoin-markets/issues/30","id":304987321,"user":{"login":"filidorwiese","id":864967,"avatar_url":"https://avatars2.githubusercontent.com/u/864967?v=3","gravatar_id":"","url":"https://api.github.com/users/filidorwiese","html_url":"https://github.com/filidorwiese","followers_url":"https://api.github.com/users/filidorwiese/followers","following_url":"https://api.github.com/users/filidorwiese/following{/other_user}","gists_url":"https://api.github.com/users/filidorwiese/gists{/gist_id}","starred_url":"https://api.github.com/users/filidorwiese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filidorwiese/subscriptions","organizations_url":"https://api.github.com/users/filidorwiese/orgs","repos_url":"https://api.github.com/users/filidorwiese/repos","events_url":"https://api.github.com/users/filidorwiese/events{/privacy}","received_events_url":"https://api.github.com/users/filidorwiese/received_events","type":"User","site_admin":false},"created_at":"2017-05-30T19:46:11Z","updated_at":"2017-05-30T19:46:11Z","body":"I've made some changes to the PR in accordance with your remarks, namely:\r\n\r\n- mBTC has been added as if it's an altcoin, this seemed the most logical way of integrating mBTC support together with altcoins\r\n- BTC no longer uses Thai Bath as the currency symbol\r\n- The coins and currency lists are sorted alphabetically\r\n\r\nLet me know if there is anything else I can do"}}
{"actor":{"display_login":"filidorwiese"}}