{"action":"created","issue":{"url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/39","repository_url":"https://api.github.com/repos/PlantPhenoOntology/ppo","labels_url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/39/comments","events_url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/39/events","html_url":"https://github.com/PlantPhenoOntology/ppo/issues/39","id":236351360,"number":39,"title":"Check definition of new above ground shoot borne shoot system","user":{"login":"ramonawalls","id":3310510,"avatar_url":"https://avatars3.githubusercontent.com/u/3310510?v=3","gravatar_id":"","url":"https://api.github.com/users/ramonawalls","html_url":"https://github.com/ramonawalls","followers_url":"https://api.github.com/users/ramonawalls/followers","following_url":"https://api.github.com/users/ramonawalls/following{/other_user}","gists_url":"https://api.github.com/users/ramonawalls/gists{/gist_id}","starred_url":"https://api.github.com/users/ramonawalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramonawalls/subscriptions","organizations_url":"https://api.github.com/users/ramonawalls/orgs","repos_url":"https://api.github.com/users/ramonawalls/repos","events_url":"https://api.github.com/users/ramonawalls/events{/privacy}","received_events_url":"https://api.github.com/users/ramonawalls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ramonawalls","id":3310510,"avatar_url":"https://avatars3.githubusercontent.com/u/3310510?v=3","gravatar_id":"","url":"https://api.github.com/users/ramonawalls","html_url":"https://github.com/ramonawalls","followers_url":"https://api.github.com/users/ramonawalls/followers","following_url":"https://api.github.com/users/ramonawalls/following{/other_user}","gists_url":"https://api.github.com/users/ramonawalls/gists{/gist_id}","starred_url":"https://api.github.com/users/ramonawalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramonawalls/subscriptions","organizations_url":"https://api.github.com/users/ramonawalls/orgs","repos_url":"https://api.github.com/users/ramonawalls/repos","events_url":"https://api.github.com/users/ramonawalls/events{/privacy}","received_events_url":"https://api.github.com/users/ramonawalls/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramonawalls","id":3310510,"avatar_url":"https://avatars3.githubusercontent.com/u/3310510?v=3","gravatar_id":"","url":"https://api.github.com/users/ramonawalls","html_url":"https://github.com/ramonawalls","followers_url":"https://api.github.com/users/ramonawalls/followers","following_url":"https://api.github.com/users/ramonawalls/following{/other_user}","gists_url":"https://api.github.com/users/ramonawalls/gists{/gist_id}","starred_url":"https://api.github.com/users/ramonawalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramonawalls/subscriptions","organizations_url":"https://api.github.com/users/ramonawalls/orgs","repos_url":"https://api.github.com/users/ramonawalls/repos","events_url":"https://api.github.com/users/ramonawalls/events{/privacy}","received_events_url":"https://api.github.com/users/ramonawalls/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-06-16T00:46:16Z","updated_at":"2017-06-19T21:08:34Z","closed_at":null,"body":"Comment from Ellen: New above-ground shoot-borne system: This supporting class is defined as \"... does not yet have any true leaves in the {vascular leaf post-expansion stage}.\" I think it should rather say that it does not yet have any true leaves that are \"unfolded\" (or whatever language we use for the issue #1 above) in order to fit in with the {new above-ground shoot-borne system presence}, right? As written it indicates none of the leaves are mature yet which is a much later point in time.\r\n\r\nThe goal here is to describe a shoot system that matches NPN's definition of initial growth, which is \"Growth is considered \"initial\" on each bud or shoot until the first leaf has fully unfolded.\"\r\n\r\nThe current definition of new above ground shoot-borne shoot system is \"An 'above-ground shoot-borne shoot system' (PPO:0000207) that does not yet have any true leaves in the 'vascular leaf post-expansion stage' (PO:0001053).\" \r\n\r\nThe issue here is that there may be leaves that are unfolded but not yet fully expanded, so the PPO description is broader than the NPN description. This means that our mapping of NPN to the PPO stage is correct, if not very precise. In order to make it more precise, we would have to define new subclasses for expanding leaves that include unfolding and unfolded. I will make a separate issue for that.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/comments/309574245","html_url":"https://github.com/PlantPhenoOntology/ppo/issues/39#issuecomment-309574245","issue_url":"https://api.github.com/repos/PlantPhenoOntology/ppo/issues/39","id":309574245,"user":{"login":"edenny","id":15466860,"avatar_url":"https://avatars3.githubusercontent.com/u/15466860?v=3","gravatar_id":"","url":"https://api.github.com/users/edenny","html_url":"https://github.com/edenny","followers_url":"https://api.github.com/users/edenny/followers","following_url":"https://api.github.com/users/edenny/following{/other_user}","gists_url":"https://api.github.com/users/edenny/gists{/gist_id}","starred_url":"https://api.github.com/users/edenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenny/subscriptions","organizations_url":"https://api.github.com/users/edenny/orgs","repos_url":"https://api.github.com/users/edenny/repos","events_url":"https://api.github.com/users/edenny/events{/privacy}","received_events_url":"https://api.github.com/users/edenny/received_events","type":"User","site_admin":false},"created_at":"2017-06-19T21:08:34Z","updated_at":"2017-06-19T21:08:34Z","body":"Yes, as I see it, it maps ok when \"Initial growth\" is present. The problem is that it does not map ok when \"initial growth\" is recorded as absent. After it ends by the NPN definition, there is still quite a bit of time for leaves to be expanding before it ends by this ontology definition."}}
{"actor":{"display_login":"edenny"}}