{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3","id":122753910,"html_url":"https://github.com/RedHatInsights/insights-core/pull/3","diff_url":"https://github.com/RedHatInsights/insights-core/pull/3.diff","patch_url":"https://github.com/RedHatInsights/insights-core/pull/3.patch","issue_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/3","number":3,"state":"closed","locked":false,"title":"Enhance grub_conf.py","user":{"login":"xiangce","id":16770981,"avatar_url":"https://avatars1.githubusercontent.com/u/16770981?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangce","html_url":"https://github.com/xiangce","followers_url":"https://api.github.com/users/xiangce/followers","following_url":"https://api.github.com/users/xiangce/following{/other_user}","gists_url":"https://api.github.com/users/xiangce/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangce/subscriptions","organizations_url":"https://api.github.com/users/xiangce/orgs","repos_url":"https://api.github.com/users/xiangce/repos","events_url":"https://api.github.com/users/xiangce/events{/privacy}","received_events_url":"https://api.github.com/users/xiangce/received_events","type":"User","site_admin":false},"body":"- Move Grub1Config and Grub2Config to grub_conf.py\r\n  Remove redundant functions among these 3 shared mappers\r\n- Remove some useless variables\r\n- Add get_grub_cmdlines(search_text) to shared reducer GrubConf\r\n- Modify the 2 associated reducers that used the old GrubConfig\r\n  - selinux.py and user_namespaces.py\r\n- Fix a bug in _parse_script to skip nested 'if'\r\n- Refine some docstring\r\n- Enhance coverage of grub_conf.py to 100%\r\n\r\nTODO:\r\n- Make GrubConfig not a shared mapper but a base class for Grub1Config\r\n  and Grub2Config\r\n- Remove the unused GrubConfig from reducers\r\n- To keep compatible with insights-plugins, these updates can only be done\r\n  after corresponding plugins being updated to use the latest reducer GrubConf","created_at":"2017-05-27T08:59:40Z","updated_at":"2017-05-31T06:02:00Z","closed_at":"2017-05-31T06:01:59Z","merged_at":null,"merge_commit_sha":"847266be470e7cb74773fa47420b4e76f0f25599","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lonicerae","id":322491,"avatar_url":"https://avatars3.githubusercontent.com/u/322491?v=3","gravatar_id":"","url":"https://api.github.com/users/lonicerae","html_url":"https://github.com/lonicerae","followers_url":"https://api.github.com/users/lonicerae/followers","following_url":"https://api.github.com/users/lonicerae/following{/other_user}","gists_url":"https://api.github.com/users/lonicerae/gists{/gist_id}","starred_url":"https://api.github.com/users/lonicerae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonicerae/subscriptions","organizations_url":"https://api.github.com/users/lonicerae/orgs","repos_url":"https://api.github.com/users/lonicerae/repos","events_url":"https://api.github.com/users/lonicerae/events{/privacy}","received_events_url":"https://api.github.com/users/lonicerae/received_events","type":"User","site_admin":false},{"login":"kylape","id":934951,"avatar_url":"https://avatars1.githubusercontent.com/u/934951?v=3","gravatar_id":"","url":"https://api.github.com/users/kylape","html_url":"https://github.com/kylape","followers_url":"https://api.github.com/users/kylape/followers","following_url":"https://api.github.com/users/kylape/following{/other_user}","gists_url":"https://api.github.com/users/kylape/gists{/gist_id}","starred_url":"https://api.github.com/users/kylape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylape/subscriptions","organizations_url":"https://api.github.com/users/kylape/orgs","repos_url":"https://api.github.com/users/kylape/repos","events_url":"https://api.github.com/users/kylape/events{/privacy}","received_events_url":"https://api.github.com/users/kylape/received_events","type":"User","site_admin":false},{"login":"csams","id":1062274,"avatar_url":"https://avatars2.githubusercontent.com/u/1062274?v=3","gravatar_id":"","url":"https://api.github.com/users/csams","html_url":"https://github.com/csams","followers_url":"https://api.github.com/users/csams/followers","following_url":"https://api.github.com/users/csams/following{/other_user}","gists_url":"https://api.github.com/users/csams/gists{/gist_id}","starred_url":"https://api.github.com/users/csams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csams/subscriptions","organizations_url":"https://api.github.com/users/csams/orgs","repos_url":"https://api.github.com/users/csams/repos","events_url":"https://api.github.com/users/csams/events{/privacy}","received_events_url":"https://api.github.com/users/csams/received_events","type":"User","site_admin":false},{"login":"PaulWay","id":1616393,"avatar_url":"https://avatars2.githubusercontent.com/u/1616393?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulWay","html_url":"https://github.com/PaulWay","followers_url":"https://api.github.com/users/PaulWay/followers","following_url":"https://api.github.com/users/PaulWay/following{/other_user}","gists_url":"https://api.github.com/users/PaulWay/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulWay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulWay/subscriptions","organizations_url":"https://api.github.com/users/PaulWay/orgs","repos_url":"https://api.github.com/users/PaulWay/repos","events_url":"https://api.github.com/users/PaulWay/events{/privacy}","received_events_url":"https://api.github.com/users/PaulWay/received_events","type":"User","site_admin":false},{"login":"lhuett","id":15021404,"avatar_url":"https://avatars1.githubusercontent.com/u/15021404?v=3","gravatar_id":"","url":"https://api.github.com/users/lhuett","html_url":"https://github.com/lhuett","followers_url":"https://api.github.com/users/lhuett/followers","following_url":"https://api.github.com/users/lhuett/following{/other_user}","gists_url":"https://api.github.com/users/lhuett/gists{/gist_id}","starred_url":"https://api.github.com/users/lhuett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhuett/subscriptions","organizations_url":"https://api.github.com/users/lhuett/orgs","repos_url":"https://api.github.com/users/lhuett/repos","events_url":"https://api.github.com/users/lhuett/events{/privacy}","received_events_url":"https://api.github.com/users/lhuett/received_events","type":"User","site_admin":false},{"login":"bfahr","id":20520336,"avatar_url":"https://avatars1.githubusercontent.com/u/20520336?v=3","gravatar_id":"","url":"https://api.github.com/users/bfahr","html_url":"https://github.com/bfahr","followers_url":"https://api.github.com/users/bfahr/followers","following_url":"https://api.github.com/users/bfahr/following{/other_user}","gists_url":"https://api.github.com/users/bfahr/gists{/gist_id}","starred_url":"https://api.github.com/users/bfahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfahr/subscriptions","organizations_url":"https://api.github.com/users/bfahr/orgs","repos_url":"https://api.github.com/users/bfahr/repos","events_url":"https://api.github.com/users/bfahr/events{/privacy}","received_events_url":"https://api.github.com/users/bfahr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3/commits","review_comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3/comments","review_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/3/comments","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/69aa0fe7bdfa83ed63616d81c425d506d996e245","head":{"label":"xiangce:en_grub_cov","ref":"en_grub_cov","sha":"69aa0fe7bdfa83ed63616d81c425d506d996e245","user":{"login":"xiangce","id":16770981,"avatar_url":"https://avatars1.githubusercontent.com/u/16770981?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangce","html_url":"https://github.com/xiangce","followers_url":"https://api.github.com/users/xiangce/followers","following_url":"https://api.github.com/users/xiangce/following{/other_user}","gists_url":"https://api.github.com/users/xiangce/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangce/subscriptions","organizations_url":"https://api.github.com/users/xiangce/orgs","repos_url":"https://api.github.com/users/xiangce/repos","events_url":"https://api.github.com/users/xiangce/events{/privacy}","received_events_url":"https://api.github.com/users/xiangce/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"RedHatInsights:master","ref":"master","sha":"12cd8c3837455163eebdcced598a7ee20487f843","user":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars1.githubusercontent.com/u/24939818?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":92518221,"name":"insights-core","full_name":"RedHatInsights/insights-core","owner":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars1.githubusercontent.com/u/24939818?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatInsights/insights-core","description":"Core rule execution framework","fork":false,"url":"https://api.github.com/repos/RedHatInsights/insights-core","forks_url":"https://api.github.com/repos/RedHatInsights/insights-core/forks","keys_url":"https://api.github.com/repos/RedHatInsights/insights-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/insights-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/insights-core/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/insights-core/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/insights-core/events","assignees_url":"https://api.github.com/repos/RedHatInsights/insights-core/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/insights-core/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/insights-core/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/insights-core/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/insights-core/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/insights-core/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/insights-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/insights-core/merges","archive_url":"https://api.github.com/repos/RedHatInsights/insights-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/insights-core/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/insights-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/insights-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/insights-core/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/insights-core/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/insights-core/deployments","created_at":"2017-05-26T14:23:11Z","updated_at":"2017-05-30T20:23:25Z","pushed_at":"2017-05-31T06:01:05Z","git_url":"git://github.com/RedHatInsights/insights-core.git","ssh_url":"git@github.com:RedHatInsights/insights-core.git","clone_url":"https://github.com/RedHatInsights/insights-core.git","svn_url":"https://github.com/RedHatInsights/insights-core","homepage":"https://access.redhat.com/insights","size":2493,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3"},"html":{"href":"https://github.com/RedHatInsights/insights-core/pull/3"},"issue":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/3"},"comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/69aa0fe7bdfa83ed63616d81c425d506d996e245"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":757,"deletions":897,"changed_files":16}}
{"actor":{"display_login":"xiangce"}}