{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/143520682","pull_request_review_id":68043979,"id":143520682,"diff_hunk":"@@ -42,6 +42,7 @@ void register_gdscript_types() {\n \n \tClassDB::register_class<GDScript>();\n \tClassDB::register_virtual_class<GDFunctionState>();\n+\tClassDB::register_virtual_class<GDNativeClass>();","path":"modules/gdscript/register_types.cpp","position":4,"original_position":4,"commit_id":"1b14b7842ea028e078c569f729aecef69e98c21a","original_commit_id":"1b14b7842ea028e078c569f729aecef69e98c21a","user":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"body":"Ah, right... my mistake. Should we rename GDNative to DLScript to avoid this confusion?\r\n","created_at":"2017-10-09T16:42:10Z","updated_at":"2017-10-09T16:42:10Z","html_url":"https://github.com/godotengine/godot/pull/11954#discussion_r143520682","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/11954","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/143520682"},"html":{"href":"https://github.com/godotengine/godot/pull/11954#discussion_r143520682"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11954"}},"in_reply_to_id":143369458},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/11954","id":145358030,"html_url":"https://github.com/godotengine/godot/pull/11954","diff_url":"https://github.com/godotengine/godot/pull/11954.diff","patch_url":"https://github.com/godotengine/godot/pull/11954.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/11954","number":11954,"state":"open","locked":false,"title":"Added 'exposed' field to ClassInfo for registered classes","user":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"body":"Closes #11913\r\n\r\nThis is my proposal at fixing the issue I [describe here](https://github.com/godotengine/godot/issues/11913#issuecomment-334967216).\r\n\r\nIt's a radical change because it forces classes to be registered manually in order to be exposed to scripting languages. However, I think this is the way to go.\r\n\r\nI didn't change anything regarding the class reference generation myself, but it should ignore classes that are not exposed.\r\n","created_at":"2017-10-08T23:04:36Z","updated_at":"2017-10-09T16:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd79da6fa02a1bfdb8a8996f29aad77cf75e50e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"reduz","id":6265307,"avatar_url":"https://avatars2.githubusercontent.com/u/6265307?v=4","gravatar_id":"","url":"https://api.github.com/users/reduz","html_url":"https://github.com/reduz","followers_url":"https://api.github.com/users/reduz/followers","following_url":"https://api.github.com/users/reduz/following{/other_user}","gists_url":"https://api.github.com/users/reduz/gists{/gist_id}","starred_url":"https://api.github.com/users/reduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reduz/subscriptions","organizations_url":"https://api.github.com/users/reduz/orgs","repos_url":"https://api.github.com/users/reduz/repos","events_url":"https://api.github.com/users/reduz/events{/privacy}","received_events_url":"https://api.github.com/users/reduz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/4","html_url":"https://github.com/godotengine/godot/milestone/4","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/4/labels","id":1449702,"number":4,"title":"3.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":321,"closed_issues":2908,"state":"open","created_at":"2015-12-08T11:42:08Z","updated_at":"2017-10-09T16:40:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/11954/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/11954/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/11954/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/1b14b7842ea028e078c569f729aecef69e98c21a","head":{"label":"neikeq:d","ref":"d","sha":"1b14b7842ea028e078c569f729aecef69e98c21a","user":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"repo":{"id":31860636,"name":"godot","full_name":"neikeq/godot","owner":{"login":"neikeq","id":7718100,"avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neikeq/godot","description":"Godot Game Engine","fork":true,"url":"https://api.github.com/repos/neikeq/godot","forks_url":"https://api.github.com/repos/neikeq/godot/forks","keys_url":"https://api.github.com/repos/neikeq/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neikeq/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neikeq/godot/teams","hooks_url":"https://api.github.com/repos/neikeq/godot/hooks","issue_events_url":"https://api.github.com/repos/neikeq/godot/issues/events{/number}","events_url":"https://api.github.com/repos/neikeq/godot/events","assignees_url":"https://api.github.com/repos/neikeq/godot/assignees{/user}","branches_url":"https://api.github.com/repos/neikeq/godot/branches{/branch}","tags_url":"https://api.github.com/repos/neikeq/godot/tags","blobs_url":"https://api.github.com/repos/neikeq/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neikeq/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neikeq/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/neikeq/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neikeq/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/neikeq/godot/languages","stargazers_url":"https://api.github.com/repos/neikeq/godot/stargazers","contributors_url":"https://api.github.com/repos/neikeq/godot/contributors","subscribers_url":"https://api.github.com/repos/neikeq/godot/subscribers","subscription_url":"https://api.github.com/repos/neikeq/godot/subscription","commits_url":"https://api.github.com/repos/neikeq/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/neikeq/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/neikeq/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/neikeq/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/neikeq/godot/contents/{+path}","compare_url":"https://api.github.com/repos/neikeq/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neikeq/godot/merges","archive_url":"https://api.github.com/repos/neikeq/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neikeq/godot/downloads","issues_url":"https://api.github.com/repos/neikeq/godot/issues{/number}","pulls_url":"https://api.github.com/repos/neikeq/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/neikeq/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/neikeq/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neikeq/godot/labels{/name}","releases_url":"https://api.github.com/repos/neikeq/godot/releases{/id}","deployments_url":"https://api.github.com/repos/neikeq/godot/deployments","created_at":"2015-03-08T18:35:47Z","updated_at":"2016-05-30T22:29:10Z","pushed_at":"2017-10-08T22:58:45Z","git_url":"git://github.com/neikeq/godot.git","ssh_url":"git@github.com:neikeq/godot.git","clone_url":"https://github.com/neikeq/godot.git","svn_url":"https://github.com/neikeq/godot","homepage":null,"size":175506,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"ff28569d16ad1558484b3029ac2fd52f7a411ffe","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2017-10-09T14:40:11Z","pushed_at":"2017-10-09T16:40:51Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":193316,"stargazers_count":9908,"watchers_count":9908,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2370,"mirror_url":null,"open_issues_count":2294,"forks":2370,"open_issues":2294,"watchers":9908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11954"},"html":{"href":"https://github.com/godotengine/godot/pull/11954"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/11954"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/11954/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11954/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11954/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/1b14b7842ea028e078c569f729aecef69e98c21a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"neikeq"}}