{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/148707643","pull_request_review_id":73993432,"id":148707643,"diff_hunk":"@@ -413,6 +413,26 @@ def find_dynamicsymbols(expression, exclude=None):\n \n     >>> find_dynamicsymbols(expr, [x, y])\n     {Derivative(x(t), t)}\n+\n+    Optional Parameter","path":"sympy/physics/mechanics/functions.py","position":14,"original_position":14,"commit_id":"e3bb089db686ce6a9cd3922bce6a53d0dfc6652d","original_commit_id":"ebe39717530511dd73d75e8cb3affcc1c5f5214d","user":{"login":"tosalonijain","id":31576507,"avatar_url":"https://avatars1.githubusercontent.com/u/31576507?v=4","gravatar_id":"","url":"https://api.github.com/users/tosalonijain","html_url":"https://github.com/tosalonijain","followers_url":"https://api.github.com/users/tosalonijain/followers","following_url":"https://api.github.com/users/tosalonijain/following{/other_user}","gists_url":"https://api.github.com/users/tosalonijain/gists{/gist_id}","starred_url":"https://api.github.com/users/tosalonijain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosalonijain/subscriptions","organizations_url":"https://api.github.com/users/tosalonijain/orgs","repos_url":"https://api.github.com/users/tosalonijain/repos","events_url":"https://api.github.com/users/tosalonijain/events{/privacy}","received_events_url":"https://api.github.com/users/tosalonijain/received_events","type":"User","site_admin":false},"body":"@moorepants and @gxyd please guide over this issue.","created_at":"2017-11-03T03:56:19Z","updated_at":"2017-11-03T03:56:19Z","html_url":"https://github.com/sympy/sympy/pull/13549#discussion_r148707643","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/13549","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/148707643"},"html":{"href":"https://github.com/sympy/sympy/pull/13549#discussion_r148707643"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/13549"}},"in_reply_to_id":147807499},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/13549","id":149385988,"html_url":"https://github.com/sympy/sympy/pull/13549","diff_url":"https://github.com/sympy/sympy/pull/13549.diff","patch_url":"https://github.com/sympy/sympy/pull/13549.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/13549","number":13549,"state":"open","locked":false,"title":"free_symbols and find_dynamicsymbols methods for vectors directly ","user":{"login":"tosalonijain","id":31576507,"avatar_url":"https://avatars1.githubusercontent.com/u/31576507?v=4","gravatar_id":"","url":"https://api.github.com/users/tosalonijain","html_url":"https://github.com/tosalonijain","followers_url":"https://api.github.com/users/tosalonijain/followers","following_url":"https://api.github.com/users/tosalonijain/following{/other_user}","gists_url":"https://api.github.com/users/tosalonijain/gists{/gist_id}","starred_url":"https://api.github.com/users/tosalonijain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosalonijain/subscriptions","organizations_url":"https://api.github.com/users/tosalonijain/orgs","repos_url":"https://api.github.com/users/tosalonijain/repos","events_url":"https://api.github.com/users/tosalonijain/events{/privacy}","received_events_url":"https://api.github.com/users/tosalonijain/received_events","type":"User","site_admin":false},"body":"Fixes #13398\r\nI have made changes in the physics module specifically. As the issue demanded that It would be nice to be able to call free_symbols and find_dynamicsymbols on a physics vector. A current hack is to convert to a matrix then use these functions.\r\nSo I made arrangements to internally transform a vector into a matrix provided the reference frame as argument and then use the same technique to find free_dynamicsymbols as for a matrix. I also created a small function in the vector class, named free_symbols that takes the vector and reference frame as arguments, converts the vector into matrix and returns the free_symbols out of it.","created_at":"2017-10-29T13:49:17Z","updated_at":"2017-11-03T03:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd9b1de0c149bdd1a3f5b35e844b93ff6d68a3fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/13549/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/13549/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/13549/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/e3bb089db686ce6a9cd3922bce6a53d0dfc6652d","head":{"label":"tosalonijain:saloni","ref":"saloni","sha":"e3bb089db686ce6a9cd3922bce6a53d0dfc6652d","user":{"login":"tosalonijain","id":31576507,"avatar_url":"https://avatars1.githubusercontent.com/u/31576507?v=4","gravatar_id":"","url":"https://api.github.com/users/tosalonijain","html_url":"https://github.com/tosalonijain","followers_url":"https://api.github.com/users/tosalonijain/followers","following_url":"https://api.github.com/users/tosalonijain/following{/other_user}","gists_url":"https://api.github.com/users/tosalonijain/gists{/gist_id}","starred_url":"https://api.github.com/users/tosalonijain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosalonijain/subscriptions","organizations_url":"https://api.github.com/users/tosalonijain/orgs","repos_url":"https://api.github.com/users/tosalonijain/repos","events_url":"https://api.github.com/users/tosalonijain/events{/privacy}","received_events_url":"https://api.github.com/users/tosalonijain/received_events","type":"User","site_admin":false},"repo":{"id":108547342,"name":"sympy","full_name":"tosalonijain/sympy","owner":{"login":"tosalonijain","id":31576507,"avatar_url":"https://avatars1.githubusercontent.com/u/31576507?v=4","gravatar_id":"","url":"https://api.github.com/users/tosalonijain","html_url":"https://github.com/tosalonijain","followers_url":"https://api.github.com/users/tosalonijain/followers","following_url":"https://api.github.com/users/tosalonijain/following{/other_user}","gists_url":"https://api.github.com/users/tosalonijain/gists{/gist_id}","starred_url":"https://api.github.com/users/tosalonijain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tosalonijain/subscriptions","organizations_url":"https://api.github.com/users/tosalonijain/orgs","repos_url":"https://api.github.com/users/tosalonijain/repos","events_url":"https://api.github.com/users/tosalonijain/events{/privacy}","received_events_url":"https://api.github.com/users/tosalonijain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tosalonijain/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/tosalonijain/sympy","forks_url":"https://api.github.com/repos/tosalonijain/sympy/forks","keys_url":"https://api.github.com/repos/tosalonijain/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tosalonijain/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tosalonijain/sympy/teams","hooks_url":"https://api.github.com/repos/tosalonijain/sympy/hooks","issue_events_url":"https://api.github.com/repos/tosalonijain/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/tosalonijain/sympy/events","assignees_url":"https://api.github.com/repos/tosalonijain/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/tosalonijain/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/tosalonijain/sympy/tags","blobs_url":"https://api.github.com/repos/tosalonijain/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tosalonijain/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tosalonijain/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tosalonijain/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tosalonijain/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/tosalonijain/sympy/languages","stargazers_url":"https://api.github.com/repos/tosalonijain/sympy/stargazers","contributors_url":"https://api.github.com/repos/tosalonijain/sympy/contributors","subscribers_url":"https://api.github.com/repos/tosalonijain/sympy/subscribers","subscription_url":"https://api.github.com/repos/tosalonijain/sympy/subscription","commits_url":"https://api.github.com/repos/tosalonijain/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tosalonijain/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tosalonijain/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tosalonijain/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tosalonijain/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/tosalonijain/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tosalonijain/sympy/merges","archive_url":"https://api.github.com/repos/tosalonijain/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tosalonijain/sympy/downloads","issues_url":"https://api.github.com/repos/tosalonijain/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/tosalonijain/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/tosalonijain/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/tosalonijain/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tosalonijain/sympy/labels{/name}","releases_url":"https://api.github.com/repos/tosalonijain/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/tosalonijain/sympy/deployments","created_at":"2017-10-27T13:07:24Z","updated_at":"2017-10-27T13:07:33Z","pushed_at":"2017-11-01T21:57:00Z","git_url":"git://github.com/tosalonijain/sympy.git","ssh_url":"git@github.com:tosalonijain/sympy.git","clone_url":"https://github.com/tosalonijain/sympy.git","svn_url":"https://github.com/tosalonijain/sympy","homepage":"http://sympy.org/","size":86360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"9476425b9e34363c2d9ac38e9f04aa75ae54a775","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2017-11-02T19:12:46Z","pushed_at":"2017-11-02T21:15:21Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":86362,"stargazers_count":4308,"watchers_count":4308,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2057,"mirror_url":null,"archived":false,"open_issues_count":3032,"forks":2057,"open_issues":3032,"watchers":4308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/13549"},"html":{"href":"https://github.com/sympy/sympy/pull/13549"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/13549"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/13549/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/13549/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/13549/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/e3bb089db686ce6a9cd3922bce6a53d0dfc6652d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tosalonijain"}}