{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/14365","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/14365/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/14365/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/14365/events","html_url":"https://github.com/edx/edx-platform/pull/14365","id":202525247,"number":14365,"title":"Log play_video event after seek_video event","user":{"login":"noraiz-anwar","id":22347092,"avatar_url":"https://avatars.githubusercontent.com/u/22347092?v=3","gravatar_id":"","url":"https://api.github.com/users/noraiz-anwar","html_url":"https://github.com/noraiz-anwar","followers_url":"https://api.github.com/users/noraiz-anwar/followers","following_url":"https://api.github.com/users/noraiz-anwar/following{/other_user}","gists_url":"https://api.github.com/users/noraiz-anwar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraiz-anwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraiz-anwar/subscriptions","organizations_url":"https://api.github.com/users/noraiz-anwar/orgs","repos_url":"https://api.github.com/users/noraiz-anwar/repos","events_url":"https://api.github.com/users/noraiz-anwar/events{/privacy}","received_events_url":"https://api.github.com/users/noraiz-anwar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-23T12:48:58Z","updated_at":"2017-01-23T14:58:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/14365","html_url":"https://github.com/edx/edx-platform/pull/14365","diff_url":"https://github.com/edx/edx-platform/pull/14365.diff","patch_url":"https://github.com/edx/edx-platform/pull/14365.patch"},"body":"## [TNL-6333](https://openedx.atlassian.net/browse/TNL-6333)\r\n\r\n### Description\r\n\r\n'play_video' event was being called after 'seek_video' event but implementation in 'play_video' event was not allowing to log this event to server. Previous implementation was set in a way that it only allowed logging of 'play_video' event followed by 'stop_video' or 'pause_video' event.\r\nI have enhanced this implementation to allow logging of 'play_video' after 'seek_video' event too.\r\nTests are added to ensure this change.\r\n\r\n### How to Test?\r\n\r\n**Stage** \r\nSeek video and observe XHR request.\r\n\r\n- A URL '/event' is called in response of this activity. Event type is 'seek_video'\r\n\r\n- No call is made for 'play_video' event after this.\r\n\r\n**Sandbox**\r\n[In progress](http://jenkins.edx.org:8080/view/Ansible/job/ansible-provision/10906/console)\r\n\r\n**Screenshots**\r\nNot applicable.\r\n\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Style and readability review: @asadazam93 \r\n- [ ] Code review: @Qubad786 \r\n- [ ] Code review: @Ayub-Khan \r\n\r\nFYI: Tag anyone who might be interested in this PR here.\r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/274509671","html_url":"https://github.com/edx/edx-platform/pull/14365#issuecomment-274509671","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/14365","id":274509671,"user":{"login":"mulby","id":627177,"avatar_url":"https://avatars.githubusercontent.com/u/627177?v=3","gravatar_id":"","url":"https://api.github.com/users/mulby","html_url":"https://github.com/mulby","followers_url":"https://api.github.com/users/mulby/followers","following_url":"https://api.github.com/users/mulby/following{/other_user}","gists_url":"https://api.github.com/users/mulby/gists{/gist_id}","starred_url":"https://api.github.com/users/mulby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulby/subscriptions","organizations_url":"https://api.github.com/users/mulby/orgs","repos_url":"https://api.github.com/users/mulby/repos","events_url":"https://api.github.com/users/mulby/events{/privacy}","received_events_url":"https://api.github.com/users/mulby/received_events","type":"User","site_admin":false},"created_at":"2017-01-23T14:58:27Z","updated_at":"2017-01-23T14:58:27Z","body":"Before merging this, we would like to do a bit more investigation to figure out this is a problem with our analysis or a problem with the event emission code.\r\n\r\nI know this was significantly refactored at one point, I'm wondering if the behavior changed during that process."}}
{"actor":{"display_login":"mulby"}}