{"action":"created","issue":{"url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/8","repository_url":"https://api.github.com/repos/phpseclib/mcrypt_compat","labels_url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/8/comments","events_url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/8/events","html_url":"https://github.com/phpseclib/mcrypt_compat/issues/8","id":246629252,"number":8,"title":"Use extension_loaded() instead of checking for a constant","user":{"login":"cweagans","id":101590,"avatar_url":"https://avatars0.githubusercontent.com/u/101590?v=4","gravatar_id":"","url":"https://api.github.com/users/cweagans","html_url":"https://github.com/cweagans","followers_url":"https://api.github.com/users/cweagans/followers","following_url":"https://api.github.com/users/cweagans/following{/other_user}","gists_url":"https://api.github.com/users/cweagans/gists{/gist_id}","starred_url":"https://api.github.com/users/cweagans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweagans/subscriptions","organizations_url":"https://api.github.com/users/cweagans/orgs","repos_url":"https://api.github.com/users/cweagans/repos","events_url":"https://api.github.com/users/cweagans/events{/privacy}","received_events_url":"https://api.github.com/users/cweagans/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T02:26:22Z","updated_at":"2017-07-31T13:19:44Z","closed_at":null,"body":"https://github.com/phpseclib/mcrypt_compat/blob/master/lib/mcrypt.php#L44 should be `if (!extension_loaded('mcrypt')) {`"},"comment":{"url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/comments/319064796","html_url":"https://github.com/phpseclib/mcrypt_compat/issues/8#issuecomment-319064796","issue_url":"https://api.github.com/repos/phpseclib/mcrypt_compat/issues/8","id":319064796,"user":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars0.githubusercontent.com/u/214474?v=4","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T13:19:44Z","updated_at":"2017-07-31T13:19:44Z","body":"The concern I'd have with that is mcrypt_compat being loaded twice. phpseclib used to have issues with it being included twice:\r\n\r\nhttps://github.com/phpseclib/phpseclib/pull/217\r\n\r\nrandom_compat works similarly to mcrypt_compat:\r\n\r\nhttps://github.com/paragonie/random_compat/blob/master/lib/random.php\r\n\r\nMind you, whereas mcrypt_compat just does one `if` check before defining everything random_compat does `if` checks for everything."}}
{"actor":{"display_login":"terrafrost"}}