{"action":"created","comment":{"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments/113254351","pull_request_review_id":34626356,"id":113254351,"diff_hunk":"@@ -1,33 +1,37 @@\n #pragma once\n \n+#include <initializer_list>\n #include <Vector.hpp>\n+#include <EnumUtils.hpp>\n #include \"ComponentBase.hpp\"\n #include \"KeyBindings.hpp\"\n \n namespace Poly\n {\n-\tnamespace InputSystem\n+\tclass ENGINE_DLLEXPORT InputWorldComponent : public ComponentBase\n \t{\n-\t\tclass InputWorldComponent : public ComponentBase\n+\tfriend void InputSystem::InputPhase(World*);\n+\tpublic:\n+\t\tconst bool IsPressed(const std::initializer_list<eKey>& list)\t","path":"PolyEngine/Engine/Src/InputWorldComponent.hpp","position":null,"original_position":17,"commit_id":"908ddcd4d7451dabe2cd0f16dee78c16e5c94051","original_commit_id":"908ddcd4d7451dabe2cd0f16dee78c16e5c94051","user":{"login":"MuniuDev","id":8275106,"avatar_url":"https://avatars1.githubusercontent.com/u/8275106?v=3","gravatar_id":"","url":"https://api.github.com/users/MuniuDev","html_url":"https://github.com/MuniuDev","followers_url":"https://api.github.com/users/MuniuDev/followers","following_url":"https://api.github.com/users/MuniuDev/following{/other_user}","gists_url":"https://api.github.com/users/MuniuDev/gists{/gist_id}","starred_url":"https://api.github.com/users/MuniuDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuniuDev/subscriptions","organizations_url":"https://api.github.com/users/MuniuDev/orgs","repos_url":"https://api.github.com/users/MuniuDev/repos","events_url":"https://api.github.com/users/MuniuDev/events{/privacy}","received_events_url":"https://api.github.com/users/MuniuDev/received_events","type":"User","site_admin":false},"body":"Alongside this method please add `bool IsPressed(eKey key)` as a convinience. Move the implementation to cpp.\r\nAnd the const needs to be after method specification. for example: `bool IsPressed(const std::initializer_list<eKey>& list) const;`","created_at":"2017-04-25T17:06:25Z","updated_at":"2017-04-25T17:10:40Z","html_url":"https://github.com/KNTGPolygon/PolyEngine/pull/8#discussion_r113254351","pull_request_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments/113254351"},"html":{"href":"https://github.com/KNTGPolygon/PolyEngine/pull/8#discussion_r113254351"},"pull_request":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8","id":117403310,"html_url":"https://github.com/KNTGPolygon/PolyEngine/pull/8","diff_url":"https://github.com/KNTGPolygon/PolyEngine/pull/8.diff","patch_url":"https://github.com/KNTGPolygon/PolyEngine/pull/8.patch","issue_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/8","number":8,"state":"open","locked":false,"title":"InputPhase","user":{"login":"PiotrMoscicki","id":25487864,"avatar_url":"https://avatars3.githubusercontent.com/u/25487864?v=3","gravatar_id":"","url":"https://api.github.com/users/PiotrMoscicki","html_url":"https://github.com/PiotrMoscicki","followers_url":"https://api.github.com/users/PiotrMoscicki/followers","following_url":"https://api.github.com/users/PiotrMoscicki/following{/other_user}","gists_url":"https://api.github.com/users/PiotrMoscicki/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrMoscicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrMoscicki/subscriptions","organizations_url":"https://api.github.com/users/PiotrMoscicki/orgs","repos_url":"https://api.github.com/users/PiotrMoscicki/repos","events_url":"https://api.github.com/users/PiotrMoscicki/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrMoscicki/received_events","type":"User","site_admin":false},"body":"- registered InputPhase\r\n- tests for WorldInputComponent in InputPhase","created_at":"2017-04-25T04:43:48Z","updated_at":"2017-04-25T17:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c013d00620e201cb654d66e4d5a9fa92c7992e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8/commits","review_comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8/comments","review_comment_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/8/comments","statuses_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/908ddcd4d7451dabe2cd0f16dee78c16e5c94051","head":{"label":"PiotrMoscicki:InputPhase","ref":"InputPhase","sha":"908ddcd4d7451dabe2cd0f16dee78c16e5c94051","user":{"login":"PiotrMoscicki","id":25487864,"avatar_url":"https://avatars3.githubusercontent.com/u/25487864?v=3","gravatar_id":"","url":"https://api.github.com/users/PiotrMoscicki","html_url":"https://github.com/PiotrMoscicki","followers_url":"https://api.github.com/users/PiotrMoscicki/followers","following_url":"https://api.github.com/users/PiotrMoscicki/following{/other_user}","gists_url":"https://api.github.com/users/PiotrMoscicki/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrMoscicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrMoscicki/subscriptions","organizations_url":"https://api.github.com/users/PiotrMoscicki/orgs","repos_url":"https://api.github.com/users/PiotrMoscicki/repos","events_url":"https://api.github.com/users/PiotrMoscicki/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrMoscicki/received_events","type":"User","site_admin":false},"repo":{"id":88090348,"name":"PolyEngine","full_name":"PiotrMoscicki/PolyEngine","owner":{"login":"PiotrMoscicki","id":25487864,"avatar_url":"https://avatars3.githubusercontent.com/u/25487864?v=3","gravatar_id":"","url":"https://api.github.com/users/PiotrMoscicki","html_url":"https://github.com/PiotrMoscicki","followers_url":"https://api.github.com/users/PiotrMoscicki/followers","following_url":"https://api.github.com/users/PiotrMoscicki/following{/other_user}","gists_url":"https://api.github.com/users/PiotrMoscicki/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrMoscicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrMoscicki/subscriptions","organizations_url":"https://api.github.com/users/PiotrMoscicki/orgs","repos_url":"https://api.github.com/users/PiotrMoscicki/repos","events_url":"https://api.github.com/users/PiotrMoscicki/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrMoscicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PiotrMoscicki/PolyEngine","description":"PolyEngine project repository","fork":true,"url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine","forks_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/forks","keys_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/teams","hooks_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/hooks","issue_events_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/issues/events{/number}","events_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/events","assignees_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/assignees{/user}","branches_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/branches{/branch}","tags_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/tags","blobs_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/languages","stargazers_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/stargazers","contributors_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/contributors","subscribers_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/subscribers","subscription_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/subscription","commits_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/contents/{+path}","compare_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/merges","archive_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/downloads","issues_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/issues{/number}","pulls_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/labels{/name}","releases_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/releases{/id}","deployments_url":"https://api.github.com/repos/PiotrMoscicki/PolyEngine/deployments","created_at":"2017-04-12T19:48:46Z","updated_at":"2017-04-16T21:11:37Z","pushed_at":"2017-04-25T14:47:43Z","git_url":"git://github.com/PiotrMoscicki/PolyEngine.git","ssh_url":"git@github.com:PiotrMoscicki/PolyEngine.git","clone_url":"https://github.com/PiotrMoscicki/PolyEngine.git","svn_url":"https://github.com/PiotrMoscicki/PolyEngine","homepage":null,"size":1680,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KNTGPolygon:dev","ref":"dev","sha":"8766e7e28f90f1a5ece2f59c99ed18bafc05406a","user":{"login":"KNTGPolygon","id":2945433,"avatar_url":"https://avatars2.githubusercontent.com/u/2945433?v=3","gravatar_id":"","url":"https://api.github.com/users/KNTGPolygon","html_url":"https://github.com/KNTGPolygon","followers_url":"https://api.github.com/users/KNTGPolygon/followers","following_url":"https://api.github.com/users/KNTGPolygon/following{/other_user}","gists_url":"https://api.github.com/users/KNTGPolygon/gists{/gist_id}","starred_url":"https://api.github.com/users/KNTGPolygon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KNTGPolygon/subscriptions","organizations_url":"https://api.github.com/users/KNTGPolygon/orgs","repos_url":"https://api.github.com/users/KNTGPolygon/repos","events_url":"https://api.github.com/users/KNTGPolygon/events{/privacy}","received_events_url":"https://api.github.com/users/KNTGPolygon/received_events","type":"Organization","site_admin":false},"repo":{"id":87123282,"name":"PolyEngine","full_name":"KNTGPolygon/PolyEngine","owner":{"login":"KNTGPolygon","id":2945433,"avatar_url":"https://avatars2.githubusercontent.com/u/2945433?v=3","gravatar_id":"","url":"https://api.github.com/users/KNTGPolygon","html_url":"https://github.com/KNTGPolygon","followers_url":"https://api.github.com/users/KNTGPolygon/followers","following_url":"https://api.github.com/users/KNTGPolygon/following{/other_user}","gists_url":"https://api.github.com/users/KNTGPolygon/gists{/gist_id}","starred_url":"https://api.github.com/users/KNTGPolygon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KNTGPolygon/subscriptions","organizations_url":"https://api.github.com/users/KNTGPolygon/orgs","repos_url":"https://api.github.com/users/KNTGPolygon/repos","events_url":"https://api.github.com/users/KNTGPolygon/events{/privacy}","received_events_url":"https://api.github.com/users/KNTGPolygon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KNTGPolygon/PolyEngine","description":"PolyEngine project repository","fork":false,"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine","forks_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/forks","keys_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/teams","hooks_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/hooks","issue_events_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/events{/number}","events_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/events","assignees_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/assignees{/user}","branches_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/branches{/branch}","tags_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/tags","blobs_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/languages","stargazers_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/stargazers","contributors_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/contributors","subscribers_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/subscribers","subscription_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/subscription","commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/contents/{+path}","compare_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/merges","archive_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/downloads","issues_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues{/number}","pulls_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/labels{/name}","releases_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/releases{/id}","deployments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/deployments","created_at":"2017-04-03T21:37:53Z","updated_at":"2017-04-23T16:06:38Z","pushed_at":"2017-04-25T14:47:45Z","git_url":"git://github.com/KNTGPolygon/PolyEngine.git","ssh_url":"git@github.com:KNTGPolygon/PolyEngine.git","clone_url":"https://github.com/KNTGPolygon/PolyEngine.git","svn_url":"https://github.com/KNTGPolygon/PolyEngine","homepage":null,"size":1652,"stargazers_count":8,"watchers_count":8,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8"},"html":{"href":"https://github.com/KNTGPolygon/PolyEngine/pull/8"},"issue":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/8"},"comments":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/908ddcd4d7451dabe2cd0f16dee78c16e5c94051"}}}}
{"actor":{"display_login":"MuniuDev"}}