{"action":"closed","number":1088,"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088","id":115464557,"html_url":"https://github.com/Microsoft/react-native-windows/pull/1088","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1088.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1088.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1088","number":1088,"state":"closed","locked":false,"title":"Wpf generator improvements","user":{"login":"morganhoke","id":1375608,"avatar_url":"https://avatars1.githubusercontent.com/u/1375608?v=3","gravatar_id":"","url":"https://api.github.com/users/morganhoke","html_url":"https://github.com/morganhoke","followers_url":"https://api.github.com/users/morganhoke/followers","following_url":"https://api.github.com/users/morganhoke/following{/other_user}","gists_url":"https://api.github.com/users/morganhoke/gists{/gist_id}","starred_url":"https://api.github.com/users/morganhoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morganhoke/subscriptions","organizations_url":"https://api.github.com/users/morganhoke/orgs","repos_url":"https://api.github.com/users/morganhoke/repos","events_url":"https://api.github.com/users/morganhoke/events{/privacy}","received_events_url":"https://api.github.com/users/morganhoke/received_events","type":"User","site_admin":false},"body":"This should make the wpf generator work a little better out of the box.  As it stands, it always points at index.windows.js, and the included index.wpf.js template was just a copypasta of index.windows.js, so the dev messages weren't super helpful.  Now you can have a side-by-side of both the wpf and windows flavors of the pacakage and have independent entry points.\r\n\r\nI also removed arm configurations from the .sln template.  AFAIK arm is not a supported platform for WPF, so that doesn't make a ton of sense to me to leave in.\r\n\r\nI'm new to this, and I haven't dealt with writing generators before, so if there's a pointer on how to best test this, I'd love to see it.  There are no changes to the actual cs files, so unit tests won't help.  I am new-ish to react-native dev, so I'm not sure how to run my new generator.  Help with that would be appreciated","created_at":"2017-04-12T05:06:03Z","updated_at":"2017-04-25T19:14:29Z","closed_at":"2017-04-25T19:14:29Z","merged_at":"2017-04-25T19:14:29Z","merge_commit_sha":"557e5be194ba4e042294ba7e78fd438eacbb53c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1088/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/96f0522f07aedbe55697d2840890e50f0e393c70","head":{"label":"morganhoke:wpf_generator_improvements","ref":"wpf_generator_improvements","sha":"96f0522f07aedbe55697d2840890e50f0e393c70","user":{"login":"morganhoke","id":1375608,"avatar_url":"https://avatars1.githubusercontent.com/u/1375608?v=3","gravatar_id":"","url":"https://api.github.com/users/morganhoke","html_url":"https://github.com/morganhoke","followers_url":"https://api.github.com/users/morganhoke/followers","following_url":"https://api.github.com/users/morganhoke/following{/other_user}","gists_url":"https://api.github.com/users/morganhoke/gists{/gist_id}","starred_url":"https://api.github.com/users/morganhoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morganhoke/subscriptions","organizations_url":"https://api.github.com/users/morganhoke/orgs","repos_url":"https://api.github.com/users/morganhoke/repos","events_url":"https://api.github.com/users/morganhoke/events{/privacy}","received_events_url":"https://api.github.com/users/morganhoke/received_events","type":"User","site_admin":false},"repo":{"id":88011267,"name":"react-native-windows","full_name":"morganhoke/react-native-windows","owner":{"login":"morganhoke","id":1375608,"avatar_url":"https://avatars1.githubusercontent.com/u/1375608?v=3","gravatar_id":"","url":"https://api.github.com/users/morganhoke","html_url":"https://github.com/morganhoke","followers_url":"https://api.github.com/users/morganhoke/followers","following_url":"https://api.github.com/users/morganhoke/following{/other_user}","gists_url":"https://api.github.com/users/morganhoke/gists{/gist_id}","starred_url":"https://api.github.com/users/morganhoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morganhoke/subscriptions","organizations_url":"https://api.github.com/users/morganhoke/orgs","repos_url":"https://api.github.com/users/morganhoke/repos","events_url":"https://api.github.com/users/morganhoke/events{/privacy}","received_events_url":"https://api.github.com/users/morganhoke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morganhoke/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/morganhoke/react-native-windows","forks_url":"https://api.github.com/repos/morganhoke/react-native-windows/forks","keys_url":"https://api.github.com/repos/morganhoke/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morganhoke/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morganhoke/react-native-windows/teams","hooks_url":"https://api.github.com/repos/morganhoke/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/morganhoke/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/morganhoke/react-native-windows/events","assignees_url":"https://api.github.com/repos/morganhoke/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/morganhoke/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/morganhoke/react-native-windows/tags","blobs_url":"https://api.github.com/repos/morganhoke/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morganhoke/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morganhoke/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/morganhoke/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morganhoke/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/morganhoke/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/morganhoke/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/morganhoke/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/morganhoke/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/morganhoke/react-native-windows/subscription","commits_url":"https://api.github.com/repos/morganhoke/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/morganhoke/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/morganhoke/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/morganhoke/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/morganhoke/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/morganhoke/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morganhoke/react-native-windows/merges","archive_url":"https://api.github.com/repos/morganhoke/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morganhoke/react-native-windows/downloads","issues_url":"https://api.github.com/repos/morganhoke/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/morganhoke/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/morganhoke/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/morganhoke/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morganhoke/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/morganhoke/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/morganhoke/react-native-windows/deployments","created_at":"2017-04-12T04:56:34Z","updated_at":"2017-04-12T04:56:37Z","pushed_at":"2017-04-25T19:08:03Z","git_url":"git://github.com/morganhoke/react-native-windows.git","ssh_url":"git@github.com:morganhoke/react-native-windows.git","clone_url":"https://github.com/morganhoke/react-native-windows.git","svn_url":"https://github.com/morganhoke/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":147045,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0d3bc8845e73c990e1d81a585d11f2abaa69971c","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"Microsoft/react-native-windows","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2017-04-25T12:51:59Z","pushed_at":"2017-04-25T19:14:29Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":147149,"stargazers_count":2130,"watchers_count":2130,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":163,"forks":160,"open_issues":163,"watchers":2130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1088"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1088"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/96f0522f07aedbe55697d2840890e50f0e393c70"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"matthargett","id":1550766,"avatar_url":"https://avatars0.githubusercontent.com/u/1550766?v=3","gravatar_id":"","url":"https://api.github.com/users/matthargett","html_url":"https://github.com/matthargett","followers_url":"https://api.github.com/users/matthargett/followers","following_url":"https://api.github.com/users/matthargett/following{/other_user}","gists_url":"https://api.github.com/users/matthargett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthargett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthargett/subscriptions","organizations_url":"https://api.github.com/users/matthargett/orgs","repos_url":"https://api.github.com/users/matthargett/repos","events_url":"https://api.github.com/users/matthargett/events{/privacy}","received_events_url":"https://api.github.com/users/matthargett/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":8,"deletions":18,"changed_files":4}}
{"actor":{"display_login":"matthargett"}}