{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/158206796","pull_request_review_id":84975399,"id":158206796,"diff_hunk":"@@ -27,11 +30,22 @@ class Inbox[T](name: String) {\n     new FunctionRef[T](path, (msg, self) ⇒ q.add(msg), (self) ⇒ ())\n   }\n \n+  /**\n+   * Get and remove the oldest message\n+   */\n   def receiveMsg(): T = q.poll() match {\n     case null ⇒ throw new NoSuchElementException(s\"polling on an empty inbox: $name\")\n     case x    ⇒ x\n   }\n \n+  /**\n+   * Assert and remove the the oldest message.\n+   */\n+  def expectMsg(expectedMessage: String): Unit = q.poll() match {","path":"akka-testkit-typed/src/main/scala/akka/typed/testkit/TestInbox.scala","position":41,"original_position":41,"commit_id":"6c5fff2e8614cb84a055e3069beea90a201b82ff","original_commit_id":"6c5fff2e8614cb84a055e3069beea90a201b82ff","user":{"login":"patriknw","id":336161,"avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"should we return `this` to allow for fluent api?","created_at":"2017-12-21T06:49:36Z","updated_at":"2017-12-21T06:53:15Z","html_url":"https://github.com/akka/akka/pull/24187#discussion_r158206796","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/24187","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/158206796"},"html":{"href":"https://github.com/akka/akka/pull/24187#discussion_r158206796"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/24187"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/24187","id":159459223,"html_url":"https://github.com/akka/akka/pull/24187","diff_url":"https://github.com/akka/akka/pull/24187.diff","patch_url":"https://github.com/akka/akka/pull/24187.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/24187","number":24187,"state":"open","locked":false,"title":"Initial pass of typed testkits + documenation","user":{"login":"chbatey","id":1866779,"avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"body":"Not expecting this to be the final API just want to get some\r\nexamples documented and internals hidden for testing behaviour.\r\n\r\nRefs #23667 and #22764\r\n\r\nI've branched off my other PR #24182 as i wanted to add a doc page in the new structure so please review that one first then i'll rebase.\r\n\r\nIf you want to look at the testkits just see the final commit of this branch.\r\n\r\n@raboof i didn't end up creating per effect assertion methods as there are a lot of different effects, i figure users can use the allEffects and filter etc but might still be worth adding","created_at":"2017-12-20T16:22:17Z","updated_at":"2017-12-21T06:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b1bd86465c19aebac4ee34cbb231e361c56155c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/24187/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/24187/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/24187/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/6c5fff2e8614cb84a055e3069beea90a201b82ff","head":{"label":"chbatey:typed-testkits","ref":"typed-testkits","sha":"6c5fff2e8614cb84a055e3069beea90a201b82ff","user":{"login":"chbatey","id":1866779,"avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"repo":{"id":38327023,"name":"akka","full_name":"chbatey/akka","owner":{"login":"chbatey","id":1866779,"avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chbatey/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/chbatey/akka","forks_url":"https://api.github.com/repos/chbatey/akka/forks","keys_url":"https://api.github.com/repos/chbatey/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chbatey/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chbatey/akka/teams","hooks_url":"https://api.github.com/repos/chbatey/akka/hooks","issue_events_url":"https://api.github.com/repos/chbatey/akka/issues/events{/number}","events_url":"https://api.github.com/repos/chbatey/akka/events","assignees_url":"https://api.github.com/repos/chbatey/akka/assignees{/user}","branches_url":"https://api.github.com/repos/chbatey/akka/branches{/branch}","tags_url":"https://api.github.com/repos/chbatey/akka/tags","blobs_url":"https://api.github.com/repos/chbatey/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chbatey/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chbatey/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/chbatey/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chbatey/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/chbatey/akka/languages","stargazers_url":"https://api.github.com/repos/chbatey/akka/stargazers","contributors_url":"https://api.github.com/repos/chbatey/akka/contributors","subscribers_url":"https://api.github.com/repos/chbatey/akka/subscribers","subscription_url":"https://api.github.com/repos/chbatey/akka/subscription","commits_url":"https://api.github.com/repos/chbatey/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/chbatey/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/chbatey/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/chbatey/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/chbatey/akka/contents/{+path}","compare_url":"https://api.github.com/repos/chbatey/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chbatey/akka/merges","archive_url":"https://api.github.com/repos/chbatey/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chbatey/akka/downloads","issues_url":"https://api.github.com/repos/chbatey/akka/issues{/number}","pulls_url":"https://api.github.com/repos/chbatey/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/chbatey/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/chbatey/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chbatey/akka/labels{/name}","releases_url":"https://api.github.com/repos/chbatey/akka/releases{/id}","deployments_url":"https://api.github.com/repos/chbatey/akka/deployments","created_at":"2015-06-30T18:49:03Z","updated_at":"2017-09-23T08:17:34Z","pushed_at":"2017-12-20T16:19:36Z","git_url":"git://github.com/chbatey/akka.git","ssh_url":"git@github.com:chbatey/akka.git","clone_url":"https://github.com/chbatey/akka.git","svn_url":"https://github.com/chbatey/akka","homepage":"http://akka.io","size":201395,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"bd71487646b3846d7bbc6deafae7a6bbce6a15c5","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2017-12-20T21:24:25Z","pushed_at":"2017-12-20T18:50:19Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":204994,"stargazers_count":7980,"watchers_count":7980,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2540,"mirror_url":null,"archived":false,"open_issues_count":612,"license":null,"forks":2540,"open_issues":612,"watchers":7980,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/24187"},"html":{"href":"https://github.com/akka/akka/pull/24187"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/24187"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/24187/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/24187/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/24187/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/6c5fff2e8614cb84a055e3069beea90a201b82ff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"patriknw"}}