{"action":"created","comment":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/comments/101838422","pull_request_review_id":22582818,"id":101838422,"diff_hunk":"@@ -58,7 +58,9 @@ def render_template_for(message, action_url, type)\n   end\n \n   def apply_secure_headers_override\n-    use_secure_headers_override(:saml)\n+    override_content_security_policy_directives(\n+      form_action: [\"'self'\", *SecureHeadersWhitelister.whitelisted_domains]","path":"app/controllers/saml_idp_controller.rb","position":6,"original_position":6,"commit_id":"dedd1d5e96e1b58e8c7a9bdb1ca8b4a0c90f5a2a","original_commit_id":"dedd1d5e96e1b58e8c7a9bdb1ca8b4a0c90f5a2a","user":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"body":"Originally I wanted to try to do the domain only for the service provider in question, however, for things like the `/saml/test` endpoint, our specs expect to see *all* domains, so I didn't want to change that at this time.\r\n\r\nMaybe we could make sure the `/auth` endpoint only pulls the `acl_url` for the current service provder, and the `/test` endpoint still shows all?","created_at":"2017-02-17T20:12:21Z","updated_at":"2017-02-17T20:12:21Z","html_url":"https://github.com/18F/identity-idp/pull/1120#discussion_r101838422","pull_request_url":"https://api.github.com/repos/18F/identity-idp/pulls/1120","_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments/101838422"},"html":{"href":"https://github.com/18F/identity-idp/pull/1120#discussion_r101838422"},"pull_request":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1120"}}},"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/1120","id":106803558,"html_url":"https://github.com/18F/identity-idp/pull/1120","diff_url":"https://github.com/18F/identity-idp/pull/1120.diff","patch_url":"https://github.com/18F/identity-idp/pull/1120.patch","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/1120","number":1120,"state":"open","locked":false,"title":"No more SecureHeadersWhitelister#run","user":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"body":"Builds on @pkarman 's PR: https://github.com/18F/identity-idp/pull/1107, we should merge that first\r\n\r\n","created_at":"2017-02-17T20:10:42Z","updated_at":"2017-02-17T20:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4fcb161a672defd5cea7d8558e697899b21206e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/identity-idp/pulls/1120/commits","review_comments_url":"https://api.github.com/repos/18F/identity-idp/pulls/1120/comments","review_comment_url":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/1120/comments","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/dedd1d5e96e1b58e8c7a9bdb1ca8b4a0c90f5a2a","head":{"label":"18F:margolis-no-more-secure-headers-whitelister","ref":"margolis-no-more-secure-headers-whitelister","sha":"dedd1d5e96e1b58e8c7a9bdb1ca8b4a0c90f5a2a","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-02-09T14:59:20Z","pushed_at":"2017-02-17T20:12:05Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":7554,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":29,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"92cd9e95fdd0384d075b43e6e7076d7f62a08f06","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-02-09T14:59:20Z","pushed_at":"2017-02-17T20:12:05Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":7554,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1120"},"html":{"href":"https://github.com/18F/identity-idp/pull/1120"},"issue":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1120"},"comments":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1120/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1120/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1120/commits"},"statuses":{"href":"https://api.github.com/repos/18F/identity-idp/statuses/dedd1d5e96e1b58e8c7a9bdb1ca8b4a0c90f5a2a"}}}}
{"actor":{"display_login":"zachmargolis"}}