{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5842","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5842/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5842/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5842/events","html_url":"https://github.com/openshift/openshift-ansible/issues/5842","id":267662720,"number":5842,"title":"Undefined variables in openshift_metrics role","user":{"login":"ksemaev","id":20893598,"avatar_url":"https://avatars1.githubusercontent.com/u/20893598?v=4","gravatar_id":"","url":"https://api.github.com/users/ksemaev","html_url":"https://github.com/ksemaev","followers_url":"https://api.github.com/users/ksemaev/followers","following_url":"https://api.github.com/users/ksemaev/following{/other_user}","gists_url":"https://api.github.com/users/ksemaev/gists{/gist_id}","starred_url":"https://api.github.com/users/ksemaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksemaev/subscriptions","organizations_url":"https://api.github.com/users/ksemaev/orgs","repos_url":"https://api.github.com/users/ksemaev/repos","events_url":"https://api.github.com/users/ksemaev/events{/privacy}","received_events_url":"https://api.github.com/users/ksemaev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-10-23T13:13:10Z","updated_at":"2017-10-25T13:01:59Z","closed_at":null,"author_association":"NONE","body":"#### Description\r\nUndefined variables in openshift_metrics role in jinja template for pvc.\r\n1) (**critical**) File _openshift-ansible\\roles\\openshift_metrics\\templates\\pvc.j2_ consists varaible _storage_class_name_;\r\nwhich is defined in file _openshift-ansible\\roles\\openshift_metrics\\tasks\\install_cassandra.yaml_ for storage type **pv**, but not defined for storage type **dynamic**, which gives an error described in https://github.com/openshift/openshift-ansible/issues/5750 (\"no storage class is set\")\r\n\r\nbut even defining it with type=pv gives empty value, beacuse _openshift_metrics_cassanda_pvc_storage_class_name_ variable is not defined anywhere and we have the same https://github.com/openshift/openshift-ansible/issues/5750\r\n\r\nSo for this time we have to manually set this variable in inventory (or somehow ask for inserting used storage plugins).\r\n\r\n2) (not critical)  _File openshift-ansible\\roles\\openshift_metrics\\templates\\pvc.j2_ consitsts variable pv_selector;\r\nwhich defines in _openshift-ansible\\roles\\openshift_metrics\\tasks\\install_cassandra.yaml_ as\r\n_pv_selector: \"{{ openshift_metrics_cassandra_pv_selector }}\"_;\r\nwhich defines in _openshift-ansible\\roles\\openshift_metrics\\defaults\\main.yaml_ as\r\n_openshift_metrics_cassandra_pv_selector: \"{{ openshift_hosted_metrics_storage_labels | default('') }}\"_;\r\nand this _openshift_hosted_metrics_storage_labels_ is not defined anywhere, so why do we need this variable?\r\n\r\n##### Version\r\n```\r\nansible 2.3.2.0\r\nopenshift-ansible-3.6.173.0.58-1\r\noc v3.6.0+c4dd4cf\r\nkubernetes v1.6.1+5115d708d7\r\nfeatures: Basic-Auth GSSAPI Kerberos SPNEGO\r\n```\r\n\r\n\r\n##### Additional Information\r\nhttps://github.com/openshift/openshift-ansible/issues/5750\r\n\r\nI could try to create neede changes, but need to contact with developers of role first.\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/339322145","html_url":"https://github.com/openshift/openshift-ansible/issues/5842#issuecomment-339322145","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5842","id":339322145,"user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T13:01:59Z","updated_at":"2017-10-25T13:01:59Z","author_association":"CONTRIBUTOR","body":"@mwringe Are you familiar with these variables?"}}
{"actor":{"display_login":"jcantrill"}}