{"action":"created","issue":{"url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/152","repository_url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows","labels_url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/152/comments","events_url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/152/events","html_url":"https://github.com/virtio-win/kvm-guest-drivers-windows/issues/152","id":245296113,"number":152,"title":"Current HLK failures on vioscsi","user":{"login":"ben-skyportsystems","id":8432404,"avatar_url":"https://avatars3.githubusercontent.com/u/8432404?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-skyportsystems","html_url":"https://github.com/ben-skyportsystems","followers_url":"https://api.github.com/users/ben-skyportsystems/followers","following_url":"https://api.github.com/users/ben-skyportsystems/following{/other_user}","gists_url":"https://api.github.com/users/ben-skyportsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-skyportsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-skyportsystems/subscriptions","organizations_url":"https://api.github.com/users/ben-skyportsystems/orgs","repos_url":"https://api.github.com/users/ben-skyportsystems/repos","events_url":"https://api.github.com/users/ben-skyportsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ben-skyportsystems/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-07-25T06:15:46Z","updated_at":"2017-08-10T13:38:48Z","closed_at":null,"body":"I'm trying to pass the HLK test suite for Windows 10/Server 2016 and have a few failures that seem to be code-related, rather than setup.\r\n\r\n- Storage Query Property (both Win10 and 2k16): Error is \"0 is an invalid value for SerialNumberOffset\".  This test doesn't have any parameters.\r\n- Static Tools Logo Test (2k16): This requires running of the Static Driver Verifier in Visual Studio, but it fails the \"MustFix Defect\" rules in **storportfindadapter** and **storportspinlock3**.  If I go ahead and install the DVL files on my HLK test machine, the STL test fails, mentioning the \"MustFix\" failures.\r\n- Storage Firmware Update: I imagine this can be made to pass.  What do you put as a firmware file for this test?\r\n\r\nIn addition, the CHAOS tests fail on both targets for \"Reliability\" and \"Development and Integration\", but when I look in the test logs, there are no failures.  I expect this is an HLK problem, not a code problem, so will ask MSFT for clarity.\r\n\r\nNote that I'm testing code very close to top-of-tree (commit 7b4c78b), and am compiling on VS15.  I've used your scripts for partitioning the hard disks (Thanks!)\r\n\r\nIf you know how to get around the above-mentioned failures, I'd love to hear it.  If not, I'll try to fix them in code, but will take some time to familiarize myself to the code base."},"comment":{"url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/comments/321553505","html_url":"https://github.com/virtio-win/kvm-guest-drivers-windows/issues/152#issuecomment-321553505","issue_url":"https://api.github.com/repos/virtio-win/kvm-guest-drivers-windows/issues/152","id":321553505,"user":{"login":"ben-skyportsystems","id":8432404,"avatar_url":"https://avatars3.githubusercontent.com/u/8432404?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-skyportsystems","html_url":"https://github.com/ben-skyportsystems","followers_url":"https://api.github.com/users/ben-skyportsystems/followers","following_url":"https://api.github.com/users/ben-skyportsystems/following{/other_user}","gists_url":"https://api.github.com/users/ben-skyportsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-skyportsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-skyportsystems/subscriptions","organizations_url":"https://api.github.com/users/ben-skyportsystems/orgs","repos_url":"https://api.github.com/users/ben-skyportsystems/repos","events_url":"https://api.github.com/users/ben-skyportsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ben-skyportsystems/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T13:38:48Z","updated_at":"2017-08-10T13:38:48Z","body":"Hi,\r\n\r\nYes, I re-downloaded this playlist and it's the same, see here:\r\n\r\n<img width=\"1399\" alt=\"screen shot 2017-08-10 at 6 29 28 am\" src=\"https://user-images.githubusercontent.com/8432404/29172653-729f29be-7d95-11e7-9db2-02be4109ebb3.png\">\r\n\r\nPay no attention to the failing \"Storage Query Property\" tests, I just haven't had time yet to change the QEMU command line for drive serial number but will hopefully get to that today.\r\n\r\nAs for the \"Static Tools Logo Test\", I was able to get it to pass after changing the \"Rules Set\" in SDV to \"VirtualStorport\".  If set to \"All\", there's one spinlock test that can only pass by essentially removing all multi-queue capabilities, and that seems like a really stupid and intrusive thing to do in order to pass a test.\r\n\r\nThanks again for all the help!\r\n--Ben\r\n"}}
{"actor":{"display_login":"ben-skyportsystems"}}