{"action":"closed","issue":{"url":"https://api.github.com/repos/retep998/winapi-rs/issues/534","repository_url":"https://api.github.com/repos/retep998/winapi-rs","labels_url":"https://api.github.com/repos/retep998/winapi-rs/issues/534/labels{/name}","comments_url":"https://api.github.com/repos/retep998/winapi-rs/issues/534/comments","events_url":"https://api.github.com/repos/retep998/winapi-rs/issues/534/events","html_url":"https://github.com/retep998/winapi-rs/issues/534","id":282847678,"number":534,"title":"type of SOCKET has changed in 0.3","user":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-18T11:31:10Z","updated_at":"2017-12-18T12:00:05Z","closed_at":"2017-12-18T12:00:05Z","author_association":"NONE","body":"The `SOCKET` defined [here](https://github.com/retep998/winapi-rs/blob/70e1da884554825a084bea0f9762dc1f91b51c93/src/um/winsock2.rs#L44) no longer agrees with the `SOCKET` defined by the [standard library](https://github.com/rust-lang/rust/blob/b1363a73ede57ae595f3a1be2bb75d308ba4f7f6/src/libstd/sys/windows/ext/raw.rs#L18-L21).\r\n\r\nThat's because you now define `UINTPTR` simply as `usize`, where it used to be either `c_uint` or `__uint64`.\r\n\r\nI see this because I try to use `::winapi::um::winsock2::INVALID_SOCKET` where a `::std::os::windows::io::RawSocket` is expected: this was fine at 0.2, but at 0.3 I get \"expected u64, found usize\" errors.\r\n\r\nNo doubt I can cast my way around this, but I thought I should draw it to your attention in case you weren't aware of it.  \r\n\r\nDoes this library even need its own definition of a `SOCKET`?  The current situation of two not-quite-duplicate definitions seems sub-optimal."}}
{"actor":{"display_login":"retep998"}}