{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/comments/131398851","pull_request_review_id":54370913,"id":131398851,"diff_hunk":"@@ -22,17 +22,17 @@\n             <artifactId>sdk-http</artifactId>\n             <version>${project.version}</version>\n         </dependency>\n-\n+        <dependency>\n+            <groupId>javax.money</groupId>\n+            <artifactId>money-api</artifactId>\n+            <version>1.0.1</version>","path":"commercetools-sdk-base/pom.xml","position":17,"original_position":17,"commit_id":"a78ae0eecc69790149e56ad2ff932a3f00f89a45","original_commit_id":"a78ae0eecc69790149e56ad2ff932a3f00f89a45","user":{"login":"katmatt","id":231232,"avatar_url":"https://avatars2.githubusercontent.com/u/231232?v=4","gravatar_id":"","url":"https://api.github.com/users/katmatt","html_url":"https://github.com/katmatt","followers_url":"https://api.github.com/users/katmatt/followers","following_url":"https://api.github.com/users/katmatt/following{/other_user}","gists_url":"https://api.github.com/users/katmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/katmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katmatt/subscriptions","organizations_url":"https://api.github.com/users/katmatt/orgs","repos_url":"https://api.github.com/users/katmatt/repos","events_url":"https://api.github.com/users/katmatt/events{/privacy}","received_events_url":"https://api.github.com/users/katmatt/received_events","type":"User","site_admin":false},"body":"Here we should introduce a new property `money-api.version` to our parent pom and reference it here with `${money-api.version}`.","created_at":"2017-08-04T14:14:08Z","updated_at":"2017-08-04T14:48:07Z","html_url":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493#discussion_r131398851","pull_request_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493","_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/comments/131398851"},"html":{"href":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493#discussion_r131398851"},"pull_request":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493"}}},"pull_request":{"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493","id":133683772,"html_url":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493","diff_url":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493.diff","patch_url":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493.patch","issue_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/1493","number":1493,"state":"open","locked":false,"title":"Sdk osgi support","user":{"login":"acbeni","id":4366702,"avatar_url":"https://avatars1.githubusercontent.com/u/4366702?v=4","gravatar_id":"","url":"https://api.github.com/users/acbeni","html_url":"https://github.com/acbeni","followers_url":"https://api.github.com/users/acbeni/followers","following_url":"https://api.github.com/users/acbeni/following{/other_user}","gists_url":"https://api.github.com/users/acbeni/gists{/gist_id}","starred_url":"https://api.github.com/users/acbeni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acbeni/subscriptions","organizations_url":"https://api.github.com/users/acbeni/orgs","repos_url":"https://api.github.com/users/acbeni/repos","events_url":"https://api.github.com/users/acbeni/events{/privacy}","received_events_url":"https://api.github.com/users/acbeni/received_events","type":"User","site_admin":false},"body":"@katmatt can you please review my code,\r\n\r\n\r\nPS:The build is still failing due to the queue problem but locally they run fine ","created_at":"2017-08-02T11:23:13Z","updated_at":"2017-08-04T14:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23816bb73fdb2252ed58bfcfbdfd346089738959","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/1493/comments","statuses_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/statuses/a78ae0eecc69790149e56ad2ff932a3f00f89a45","head":{"label":"commercetools:sdk-osgi-support","ref":"sdk-osgi-support","sha":"a78ae0eecc69790149e56ad2ff932a3f00f89a45","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":20855247,"name":"commercetools-jvm-sdk","full_name":"commercetools/commercetools-jvm-sdk","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/commercetools-jvm-sdk","description":"The e-commerce SDK from commercetools running on the Java virtual machine.","fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk","forks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/deployments","created_at":"2014-06-15T12:46:24Z","updated_at":"2017-07-28T09:04:04Z","pushed_at":"2017-08-04T13:43:21Z","git_url":"git://github.com/commercetools/commercetools-jvm-sdk.git","ssh_url":"git@github.com:commercetools/commercetools-jvm-sdk.git","clone_url":"https://github.com/commercetools/commercetools-jvm-sdk.git","svn_url":"https://github.com/commercetools/commercetools-jvm-sdk","homepage":"http://dev.commercetools.com/jvm/","size":125537,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":95,"forks":13,"open_issues":95,"watchers":30,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"b054b1435249a5793df724ae73f682ddfa49e061","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":20855247,"name":"commercetools-jvm-sdk","full_name":"commercetools/commercetools-jvm-sdk","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/commercetools-jvm-sdk","description":"The e-commerce SDK from commercetools running on the Java virtual machine.","fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk","forks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/deployments","created_at":"2014-06-15T12:46:24Z","updated_at":"2017-07-28T09:04:04Z","pushed_at":"2017-08-04T13:43:21Z","git_url":"git://github.com/commercetools/commercetools-jvm-sdk.git","ssh_url":"git@github.com:commercetools/commercetools-jvm-sdk.git","clone_url":"https://github.com/commercetools/commercetools-jvm-sdk.git","svn_url":"https://github.com/commercetools/commercetools-jvm-sdk","homepage":"http://dev.commercetools.com/jvm/","size":125537,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":95,"forks":13,"open_issues":95,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493"},"html":{"href":"https://github.com/commercetools/commercetools-jvm-sdk/pull/1493"},"issue":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/1493"},"comments":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk/statuses/a78ae0eecc69790149e56ad2ff932a3f00f89a45"}}}}
{"actor":{"display_login":"katmatt"}}