{"action":"created","issue":{"url":"https://api.github.com/repos/sensu/sensu-puppet/issues/849","repository_url":"https://api.github.com/repos/sensu/sensu-puppet","labels_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/849/labels{/name}","comments_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/849/comments","events_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/849/events","html_url":"https://github.com/sensu/sensu-puppet/issues/849","id":276241754,"number":849,"title":"MAX_OPEN_FILES should be configurable for Sensu Enterprise","user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars1.githubusercontent.com/u/148017?v=4","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"labels":[{"id":3587097,"url":"https://api.github.com/repos/sensu/sensu-puppet/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":655756538,"url":"https://api.github.com/repos/sensu/sensu-puppet/labels/parity","name":"parity","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"alvagante","id":283804,"avatar_url":"https://avatars2.githubusercontent.com/u/283804?v=4","gravatar_id":"","url":"https://api.github.com/users/alvagante","html_url":"https://github.com/alvagante","followers_url":"https://api.github.com/users/alvagante/followers","following_url":"https://api.github.com/users/alvagante/following{/other_user}","gists_url":"https://api.github.com/users/alvagante/gists{/gist_id}","starred_url":"https://api.github.com/users/alvagante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvagante/subscriptions","organizations_url":"https://api.github.com/users/alvagante/orgs","repos_url":"https://api.github.com/users/alvagante/repos","events_url":"https://api.github.com/users/alvagante/events{/privacy}","received_events_url":"https://api.github.com/users/alvagante/received_events","type":"User","site_admin":false},"assignees":[{"login":"alvagante","id":283804,"avatar_url":"https://avatars2.githubusercontent.com/u/283804?v=4","gravatar_id":"","url":"https://api.github.com/users/alvagante","html_url":"https://github.com/alvagante","followers_url":"https://api.github.com/users/alvagante/followers","following_url":"https://api.github.com/users/alvagante/following{/other_user}","gists_url":"https://api.github.com/users/alvagante/gists{/gist_id}","starred_url":"https://api.github.com/users/alvagante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvagante/subscriptions","organizations_url":"https://api.github.com/users/alvagante/orgs","repos_url":"https://api.github.com/users/alvagante/repos","events_url":"https://api.github.com/users/alvagante/events{/privacy}","received_events_url":"https://api.github.com/users/alvagante/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-11-23T00:47:49Z","updated_at":"2017-11-29T18:38:33Z","closed_at":null,"author_association":"OWNER","body":"## Description of problem\r\n\r\nSensu Enterprise uses the value of MAX_OPEN_FILES environment variable to configure ulimit settings prior to starting the JVM. The value of this environment variable can be configured by editing /etc/default/sensu-enterprise, but is not present in [the template](https://github.com/sensu/sensu-puppet/blob/v2.40.1/templates/sensu.erb) used by this module to render that file. As a result, users cannot configure the number of file handles Sensu Enterprise can open when using this module.\r\n\r\n## Platform and version information\r\n\r\n- Your OS: Centos 7\r\n- Your version of Sensu: Sensu Enterprise 2.7.0\r\n- Your version of this module: 2.40.1\r\n"},"comment":{"url":"https://api.github.com/repos/sensu/sensu-puppet/issues/comments/347954806","html_url":"https://github.com/sensu/sensu-puppet/issues/849#issuecomment-347954806","issue_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/849","id":347954806,"user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars1.githubusercontent.com/u/148017?v=4","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"created_at":"2017-11-29T18:38:33Z","updated_at":"2017-11-29T18:38:33Z","author_association":"OWNER","body":"@alvagante to circle back to your prior comment about vars shared by Core and Enterprise, I believe the following env vars should not be managed by this module:\r\n\r\n> SENSU_CLIENT_NAME\r\n> SENSU_CLIENT_ADDRESS\r\n> SENSU_CLIENT_SUBSCRIPTIONS\r\n> SENSU_TRANSPORT_NAME\r\n> RABBITMQ_URL\r\n> REDIS_URL\r\n> REDIS_SENTINEL_URLS\r\n> SENSU_API_PORT\r\n \r\nThe values for these env vars are overridden by JSON configuration on disk, and the module manages  JSON configuration for each of these settings. I think having values set for these in both environment variables and in JSON on disk is likely to create confusion.\r\n\r\nFrom my perspective, env vars like `MAX_OPEN_FILES`, `JAVA_OPTS`, `CONFD_DIR` and `CONFIG_FILE` are different because they are used by service management (sysv init scripts, sensu-service wrapper script) to influence the runtime environment of Sensu processes in a way that can't be achieved via JSON configs on disk."}}
{"actor":{"display_login":"cwjohnston"}}