{"action":"created","issue":{"url":"https://api.github.com/repos/lede-project/source/issues/1028","repository_url":"https://api.github.com/repos/lede-project/source","labels_url":"https://api.github.com/repos/lede-project/source/issues/1028/labels{/name}","comments_url":"https://api.github.com/repos/lede-project/source/issues/1028/comments","events_url":"https://api.github.com/repos/lede-project/source/issues/1028/events","html_url":"https://github.com/lede-project/source/pull/1028","id":220705746,"number":1028,"title":"Enable RTC_SUPPORT as a config option","user":{"login":"nwf","id":156882,"avatar_url":"https://avatars0.githubusercontent.com/u/156882?v=3","gravatar_id":"","url":"https://api.github.com/users/nwf","html_url":"https://github.com/nwf","followers_url":"https://api.github.com/users/nwf/followers","following_url":"https://api.github.com/users/nwf/following{/other_user}","gists_url":"https://api.github.com/users/nwf/gists{/gist_id}","starred_url":"https://api.github.com/users/nwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwf/subscriptions","organizations_url":"https://api.github.com/users/nwf/orgs","repos_url":"https://api.github.com/users/nwf/repos","events_url":"https://api.github.com/users/nwf/events{/privacy}","received_events_url":"https://api.github.com/users/nwf/received_events","type":"User","site_admin":false},"labels":[{"id":566696095,"url":"https://api.github.com/repos/lede-project/source/labels/build/scripts/tools","name":"build/scripts/tools","color":"08A98B","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-10T16:52:03Z","updated_at":"2017-04-12T07:17:29Z","closed_at":"2017-04-12T07:17:29Z","pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/1028","html_url":"https://github.com/lede-project/source/pull/1028","diff_url":"https://github.com/lede-project/source/pull/1028.diff","patch_url":"https://github.com/lede-project/source/pull/1028.patch"},"body":"Move RTC_SUPPORT from target/Config.in to config/Config-build.in, making it subject to manipulation by .config.  Some platforms that do not have onboard RTCs can nevertheless have them added (using, e.g. a i2c-tiny-usb and a ds3231 I2C RTC module) and being blocked from building the kernel modules is annoying.\r\n\r\nThis may not be the correct course of action; RTC_SUPPORT is used sparsely enough around the tree that perhaps removing it is the right answer instead."},"comment":{"url":"https://api.github.com/repos/lede-project/source/issues/comments/293494651","html_url":"https://github.com/lede-project/source/pull/1028#issuecomment-293494651","issue_url":"https://api.github.com/repos/lede-project/source/issues/1028","id":293494651,"user":{"login":"nbd168","id":2529314,"avatar_url":"https://avatars0.githubusercontent.com/u/2529314?v=3","gravatar_id":"","url":"https://api.github.com/users/nbd168","html_url":"https://github.com/nbd168","followers_url":"https://api.github.com/users/nbd168/followers","following_url":"https://api.github.com/users/nbd168/following{/other_user}","gists_url":"https://api.github.com/users/nbd168/gists{/gist_id}","starred_url":"https://api.github.com/users/nbd168/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbd168/subscriptions","organizations_url":"https://api.github.com/users/nbd168/orgs","repos_url":"https://api.github.com/users/nbd168/repos","events_url":"https://api.github.com/users/nbd168/events{/privacy}","received_events_url":"https://api.github.com/users/nbd168/received_events","type":"User","site_admin":false},"created_at":"2017-04-12T07:17:29Z","updated_at":"2017-04-12T07:17:29Z","body":"The reason that RTC_SUPPORT was added is the fact that compiling some RTC drivers as module in the release build pushes some bloat into the kernel image.\r\nI've pushed a different change in my staging tree that should also address the problem. Please review it and let me know if this covers your use case as well.\r\n\r\nhttps://git.lede-project.org/79daae59ba1fdb670d379b31f3572ead418e1fb2"}}
{"actor":{"display_login":"nbd168"}}