{"action":"closed","number":249,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249","id":130455976,"html_url":"https://github.com/input-output-hk/etc-client/pull/249","diff_url":"https://github.com/input-output-hk/etc-client/pull/249.diff","patch_url":"https://github.com/input-output-hk/etc-client/pull/249.patch","issue_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/249","number":249,"state":"closed","locked":false,"title":"[EC-239] Fixed TODOs in the codebase","user":{"login":"ntallar","id":23455124,"avatar_url":"https://avatars0.githubusercontent.com/u/23455124?v=4","gravatar_id":"","url":"https://api.github.com/users/ntallar","html_url":"https://github.com/ntallar","followers_url":"https://api.github.com/users/ntallar/followers","following_url":"https://api.github.com/users/ntallar/following{/other_user}","gists_url":"https://api.github.com/users/ntallar/gists{/gist_id}","starred_url":"https://api.github.com/users/ntallar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntallar/subscriptions","organizations_url":"https://api.github.com/users/ntallar/orgs","repos_url":"https://api.github.com/users/ntallar/repos","events_url":"https://api.github.com/users/ntallar/events{/privacy}","received_events_url":"https://api.github.com/users/ntallar/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nIncludes fixes to several `TODO`s in the codebase. The remaining `TODO`s were analyzed (with conclusions in task). The fixed `TODO`s in this PR are:\r\n- *InMemoryWorldStateProxy: change to MerklePatriciaTree[Address, Account] and use an Address seraializer that is defined in one place -> Fixed TODO*.\r\n- *EthService: Configure timeout -> Fixed TODO*\r\n- *SyncController: refactor to provide ActorRefs differently -> Removed TODO*: The idea of this TODO is reducing the number of parameters for the props function, however there's not much relation between those ActorRefs so it's not worth grouping actors.\r\n- *InMemoryWorldStateProxy: why do we create blockchain every time we are calling this function? -> Fixed TODO*: Blockchain is now being created before creating funcion for accessing blocks, so as to fix this problem.\r\n- *DumpChainActor: ask for block headers -> Removed TODO*: outdated TODO already fixed.\r\n- *Ledger: why do we require in executeBlockTransactions separate blockchain and blockchain storage -> Left TODO*: Task [EC-253] was created to investigate this.\r\n- *SyncControllerSpec: Investigate long timeouts -> Removed TODO*: This problems seems to have been caused by grouping several unconnected messages. Removed awaiting for unnecessary messages that were not being tested in these tests, which allowed lowering the timeout.\r\n- *BlockHeaderValidator: should we report this? -> Removed TODO*: Reported difference between clients and YP. The use of 5000 as MinGasPrice can be seen for example in geth-classic: https://github.com/ethereumproject/go-ethereum/blob/master/core/block_validator.go#L36 and in parity: https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/classic.json#L29. Created issue https://github.com/ethereum/yellowpaper/issues/317.","created_at":"2017-07-13T20:07:25Z","updated_at":"2017-07-20T12:58:20Z","closed_at":"2017-07-20T12:58:20Z","merged_at":"2017-07-20T12:58:20Z","merge_commit_sha":"29c3803752b48b764e760e076005897dac9f9bbf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/249/comments","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/29c3803752b48b764e760e076005897dac9f9bbf","head":{"label":"input-output-hk:feature/fixTODOs","ref":"feature/fixTODOs","sha":"29c3803752b48b764e760e076005897dac9f9bbf","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-06-27T15:46:35Z","pushed_at":"2017-07-20T12:58:19Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":5422,"stargazers_count":10,"watchers_count":10,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":10,"default_branch":"master"}},"base":{"label":"input-output-hk:phase/beta1","ref":"phase/beta1","sha":"c585470c53b30f6d65f54ffe89e263eba030dac7","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-06-27T15:46:35Z","pushed_at":"2017-07-20T12:58:19Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":5422,"stargazers_count":10,"watchers_count":10,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249"},"html":{"href":"https://github.com/input-output-hk/etc-client/pull/249"},"issue":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/249"},"comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/etc-client/statuses/29c3803752b48b764e760e076005897dac9f9bbf"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ntallar","id":23455124,"avatar_url":"https://avatars0.githubusercontent.com/u/23455124?v=4","gravatar_id":"","url":"https://api.github.com/users/ntallar","html_url":"https://github.com/ntallar","followers_url":"https://api.github.com/users/ntallar/followers","following_url":"https://api.github.com/users/ntallar/following{/other_user}","gists_url":"https://api.github.com/users/ntallar/gists{/gist_id}","starred_url":"https://api.github.com/users/ntallar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntallar/subscriptions","organizations_url":"https://api.github.com/users/ntallar/orgs","repos_url":"https://api.github.com/users/ntallar/repos","events_url":"https://api.github.com/users/ntallar/events{/privacy}","received_events_url":"https://api.github.com/users/ntallar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"maintainer_can_modify":false,"commits":6,"additions":44,"deletions":53,"changed_files":17}}
{"actor":{"display_login":"ntallar"}}