{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/132806142","pull_request_review_id":55932134,"id":132806142,"diff_hunk":"@@ -0,0 +1,70 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+\n+    Licensed to the Apache Software Foundation (ASF) under one\n+    or more contributor license agreements.  See the NOTICE file\n+    distributed with this work for additional information\n+    regarding copyright ownership.  The ASF licenses this file\n+    to you under the Apache License, Version 2.0 (the\n+    \"License\"); you may not use this file except in compliance\n+    with the License.  You may obtain a copy of the License at\n+\n+      http://www.apache.org/licenses/LICENSE-2.0\n+\n+    Unless required by applicable law or agreed to in writing,\n+    software distributed under the License is distributed on an\n+    \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+    KIND, either express or implied.  See the License for the\n+    specific language governing permissions and limitations\n+    under the License.\n+\n+-->\n+\n+<Configuration status=\"INFO\" monitorInterval=\"5\" name=\"pulsar\">\n+\n+\t<!-- Example: This is a sample filter file: which can be added to appender to filter \n+\t\t\t\t  logs based on the contextual-data\n+\t<Scripts>\n+\t\t  <ScriptFile name=\"filter.js\" language=\"JavaScript\"\n+\t\t\tpath=\"/conf/log4j2-scripts/filter.js\" charset=\"UTF-8\" />\n+\t</Scripts>\n+\t-->\n+\t<Appenders>\n+\t\t<Console name=\"console\" target=\"SYSTEM_OUT\">\n+\t\t\t<PatternLayout\n+\t\t\t\tpattern=\"[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} [%t] %c{1} - %msg%n\" />\n+\t\t</Console>\n+\t\t<!-- Example: Rolling file appender to writes log into log file. Change the file-location \n+\t\t\t          to appropriate path before using it\n+\t\t<RollingFile name=\"RollingFile\" fileName=\"/pulsar-broker.log\"","path":"conf/log4j2.xml","position":39,"original_position":39,"commit_id":"b9808bfb4a025bc5074c1e953996dcde2c66c8a1","original_commit_id":"b9808bfb4a025bc5074c1e953996dcde2c66c8a1","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"body":"I commented it out because log4j tries to create that file on init even though we don't use that appender in the file anywhere.\r\n\r\nI will check if is there anyway to not to create the file.\r\n\r\n```\r\n2017-08-11 18:08:09,417 main ERROR Unable to create file /pulsar-broker.log java.io.IOException: Permission denied\r\n        at java.io.UnixFileSystem.createFileExclusively(Native Method)\r\n        at java.io.File.createNewFile(File.java:1012)\r\n        at org.apache.logging.log4j.core.appender.rolling.RollingFileManager$RollingFileManagerFactory.createManager(RollingFileManager.java:409)\r\n        at org.apache.logging.log4j.core.appender.rolling.RollingFileManager$RollingFileManagerFactory.createManager(RollingFileManager.java:391)\r\n        at org.apache.logging.log4j.core.appender.AbstractManager.getManager(AbstractManager.java:73)\r\n        at org.apache.logging.log4j.core.appender.OutputStreamManager.getManager(OutputStreamManager.java:81)\r\n```","created_at":"2017-08-12T01:09:41Z","updated_at":"2017-08-12T01:09:41Z","html_url":"https://github.com/apache/incubator-pulsar/pull/680#discussion_r132806142","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/132806142"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/680#discussion_r132806142"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680","id":135440145,"html_url":"https://github.com/apache/incubator-pulsar/pull/680","diff_url":"https://github.com/apache/incubator-pulsar/pull/680.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/680.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/680","number":680,"state":"open","locked":false,"title":"Upgrade to log4j2 dependency and configuration","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"body":"### Motivation\r\n\r\nReplacing log4j with log4j2 for better performance and other useful feature such as filtering. \r\nTherefore, also added sample [filtering-example](https://github.com/rdhabalia/pulsar/blob/b9808bfb4a025bc5074c1e953996dcde2c66c8a1/conf/log4j2-scripts/filter.js) along with configuration.\r\n\r\n","created_at":"2017-08-12T00:35:42Z","updated_at":"2017-08-12T01:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f843597da092cae1c624605bc028add27f169c","assignee":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/9","html_url":"https://github.com/apache/incubator-pulsar/milestone/9","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/9/labels","id":2642162,"number":9,"title":"1.20.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":39,"state":"open","created_at":"2017-07-14T21:07:07Z","updated_at":"2017-08-12T00:35:42Z","due_on":"2017-08-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/680/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/b9808bfb4a025bc5074c1e953996dcde2c66c8a1","head":{"label":"rdhabalia:log4j2","ref":"log4j2","sha":"b9808bfb4a025bc5074c1e953996dcde2c66c8a1","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"repo":{"id":67649596,"name":"pulsar","full_name":"rdhabalia/pulsar","owner":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdhabalia/pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/rdhabalia/pulsar","forks_url":"https://api.github.com/repos/rdhabalia/pulsar/forks","keys_url":"https://api.github.com/repos/rdhabalia/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdhabalia/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdhabalia/pulsar/teams","hooks_url":"https://api.github.com/repos/rdhabalia/pulsar/hooks","issue_events_url":"https://api.github.com/repos/rdhabalia/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/rdhabalia/pulsar/events","assignees_url":"https://api.github.com/repos/rdhabalia/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/rdhabalia/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/rdhabalia/pulsar/tags","blobs_url":"https://api.github.com/repos/rdhabalia/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdhabalia/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdhabalia/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdhabalia/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdhabalia/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/rdhabalia/pulsar/languages","stargazers_url":"https://api.github.com/repos/rdhabalia/pulsar/stargazers","contributors_url":"https://api.github.com/repos/rdhabalia/pulsar/contributors","subscribers_url":"https://api.github.com/repos/rdhabalia/pulsar/subscribers","subscription_url":"https://api.github.com/repos/rdhabalia/pulsar/subscription","commits_url":"https://api.github.com/repos/rdhabalia/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdhabalia/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdhabalia/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdhabalia/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdhabalia/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/rdhabalia/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdhabalia/pulsar/merges","archive_url":"https://api.github.com/repos/rdhabalia/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdhabalia/pulsar/downloads","issues_url":"https://api.github.com/repos/rdhabalia/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/rdhabalia/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/rdhabalia/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/rdhabalia/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdhabalia/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/rdhabalia/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/rdhabalia/pulsar/deployments","created_at":"2016-09-07T22:57:02Z","updated_at":"2016-09-07T22:57:05Z","pushed_at":"2017-08-12T01:03:26Z","git_url":"git://github.com/rdhabalia/pulsar.git","ssh_url":"git@github.com:rdhabalia/pulsar.git","clone_url":"https://github.com/rdhabalia/pulsar.git","svn_url":"https://github.com/rdhabalia/pulsar","homepage":"","size":7491,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c51eaad9745d36d737b30d645fa1db753ae87246","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2017-08-10T05:54:45Z","pushed_at":"2017-08-12T01:03:27Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":8088,"stargazers_count":1269,"watchers_count":1269,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":78,"forks":277,"open_issues":78,"watchers":1269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/680"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/680"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/b9808bfb4a025bc5074c1e953996dcde2c66c8a1"}}}}
{"actor":{"display_login":"rdhabalia"}}