{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/comments/113033935","pull_request_review_id":34392977,"id":113033935,"diff_hunk":"@@ -301,25 +356,50 @@ public void onMessage(ConsumerRecord<K, V> record, Acknowledgment acknowledgment\n \t\t\tMessage<?> message = null;\n \t\t\ttry {\n \t\t\t\tmessage = toMessagingMessage(record, acknowledgment);\n+\t\t\t\tsetAttributesIfNecessary(record, message);\n \t\t\t}\n \t\t\tcatch (RuntimeException e) {\n-\t\t\t\tException exception = new ConversionException(\"Failed to convert to message for: \" + record, e);\n-\t\t\t\tif (getErrorChannel() != null) {\n-\t\t\t\t\tgetMessagingTemplate().send(getErrorChannel(), new ErrorMessage(exception));\n-\t\t\t\t}\n+\t\t\t\tRuntimeException exception = new ConversionException(\"Failed to convert to message for: \" + record, e);\n+\t\t\t\tsendErrorMessageIfNecessary(null, exception);\n \t\t\t}\n \t\t\tif (message != null) {\n-\t\t\t\tsendMessage(message);\n+\t\t\t\ttry {\n+\t\t\t\t\tsendMessage(message);\n+\t\t\t\t}\n+\t\t\t\tfinally {\n+\t\t\t\t\tattributesHolder.remove();","path":"src/main/java/org/springframework/integration/kafka/inbound/KafkaMessageDrivenChannelAdapter.java","position":176,"original_position":164,"commit_id":"c8c30ee58943d09856fd04f31f1d12511f39106e","original_commit_id":"08c8b72efb0e0cc5f4bd508955daf882a5ceda8b","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars0.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"Any comments here?\r\nAnd I think we still need something for the `EnchancedErrorMessage` in the SI-4.3.10 to support this PR.\r\nThanks","created_at":"2017-04-24T19:21:43Z","updated_at":"2017-04-24T19:21:43Z","html_url":"https://github.com/spring-projects/spring-integration-kafka/pull/163#discussion_r113033935","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/comments/113033935"},"html":{"href":"https://github.com/spring-projects/spring-integration-kafka/pull/163#discussion_r113033935"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163","id":116208246,"html_url":"https://github.com/spring-projects/spring-integration-kafka/pull/163","diff_url":"https://github.com/spring-projects/spring-integration-kafka/pull/163.diff","patch_url":"https://github.com/spring-projects/spring-integration-kafka/pull/163.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/163","number":163,"state":"open","locked":false,"title":"Add Support for Enhanced SCSt Error Handling [PoC]","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars0.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"- bind input message, raw record to retry context\r\n- support recover without retry (recover after a single shot)\r\n\r\n__requires https://github.com/spring-projects/spring-integration/pull/2091 + polishing commits__","created_at":"2017-04-17T21:35:38Z","updated_at":"2017-04-24T19:21:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5567e4e87c39db69a141c690c1f42ba27df5635b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/163/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/statuses/c8c30ee58943d09856fd04f31f1d12511f39106e","head":{"label":"garyrussell:errorHandling","ref":"errorHandling","sha":"c8c30ee58943d09856fd04f31f1d12511f39106e","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars0.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"repo":{"id":27182911,"name":"spring-integration-kafka","full_name":"garyrussell/spring-integration-kafka","owner":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars0.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyrussell/spring-integration-kafka","description":null,"fork":true,"url":"https://api.github.com/repos/garyrussell/spring-integration-kafka","forks_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/forks","keys_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/teams","hooks_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/hooks","issue_events_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/events","assignees_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/tags","blobs_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/languages","stargazers_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/stargazers","contributors_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/contributors","subscribers_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/subscribers","subscription_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/subscription","commits_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/merges","archive_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/downloads","issues_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/labels{/name}","releases_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/garyrussell/spring-integration-kafka/deployments","created_at":"2014-11-26T15:22:37Z","updated_at":"2016-08-12T13:28:00Z","pushed_at":"2017-04-24T17:27:08Z","git_url":"git://github.com/garyrussell/spring-integration-kafka.git","ssh_url":"git@github.com:garyrussell/spring-integration-kafka.git","clone_url":"https://github.com/garyrussell/spring-integration-kafka.git","svn_url":"https://github.com/garyrussell/spring-integration-kafka","homepage":null,"size":1247,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:2.1.x","ref":"2.1.x","sha":"0392413a4e4061a952b83c4cc6e4075608826961","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars3.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":26547822,"name":"spring-integration-kafka","full_name":"spring-projects/spring-integration-kafka","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars3.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration-kafka","description":null,"fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration-kafka","forks_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-integration-kafka/deployments","created_at":"2014-11-12T17:35:29Z","updated_at":"2017-04-21T06:47:43Z","pushed_at":"2017-04-24T17:27:09Z","git_url":"git://github.com/spring-projects/spring-integration-kafka.git","ssh_url":"git@github.com:spring-projects/spring-integration-kafka.git","clone_url":"https://github.com/spring-projects/spring-integration-kafka.git","svn_url":"https://github.com/spring-projects/spring-integration-kafka","homepage":null,"size":1089,"stargazers_count":196,"watchers_count":196,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":8,"forks":122,"open_issues":8,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163"},"html":{"href":"https://github.com/spring-projects/spring-integration-kafka/pull/163"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/163"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration-kafka/statuses/c8c30ee58943d09856fd04f31f1d12511f39106e"}}}}
{"actor":{"display_login":"artembilan"}}