{"action":"created","comment":{"url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/comments/150990311","pull_request_review_id":76626646,"id":150990311,"diff_hunk":"@@ -0,0 +1,53 @@\n+from flask import url_for\n+from mongoengine import signals, ValidationError\n+\n+from .. import app, db\n+from ..users.models import User\n+from ..articles.models import Article\n+\n+\n+class Translation(Article):","path":"cafebabel/translations/models.py","position":9,"original_position":9,"commit_id":"5089142a700408e5aafc58dbe5a01d8d64599564","original_commit_id":"5089142a700408e5aafc58dbe5a01d8d64599564","user":{"login":"vinyll","id":145172,"avatar_url":"https://avatars1.githubusercontent.com/u/145172?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyll","html_url":"https://github.com/vinyll","followers_url":"https://api.github.com/users/vinyll/followers","following_url":"https://api.github.com/users/vinyll/following{/other_user}","gists_url":"https://api.github.com/users/vinyll/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyll/subscriptions","organizations_url":"https://api.github.com/users/vinyll/orgs","repos_url":"https://api.github.com/users/vinyll/repos","events_url":"https://api.github.com/users/vinyll/events{/privacy}","received_events_url":"https://api.github.com/users/vinyll/received_events","type":"User","site_admin":false},"body":"`translations.models.Translation` sounds very generic while we are being as specific as the translation of an article.\r\nWould it make sense to give a more specific name?\r\n\r\nSame question for the indenpendant package. if is so related to the _articles_ package that I'm wondering why extracting it.\r\n\r\nWe will have translations soon for the system, maybe we don't want the names to be confusing. (Or should we merge the _translations_ module and make it the website translation module? In which case the `class Translation` would still be too specific) 🤔 ","created_at":"2017-11-14T23:01:39Z","updated_at":"2017-11-14T23:01:40Z","html_url":"https://github.com/cafebabel/cafebabel.com/pull/60#discussion_r150990311","pull_request_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/comments/150990311"},"html":{"href":"https://github.com/cafebabel/cafebabel.com/pull/60#discussion_r150990311"},"pull_request":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60","id":152637611,"html_url":"https://github.com/cafebabel/cafebabel.com/pull/60","diff_url":"https://github.com/cafebabel/cafebabel.com/pull/60.diff","patch_url":"https://github.com/cafebabel/cafebabel.com/pull/60.patch","issue_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/60","number":60,"state":"open","locked":false,"title":"Deal with translations","user":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars2.githubusercontent.com/u/3556?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"body":"More than the translations feature described on #20 it's a proposition for a couple of other things:\r\n\r\n* using inheritance in models\r\n* having dedicated folder per kind (should be done for draft for consistency)\r\n* the coupling urls/views/permissions is a bit different to what has been done for now\r\n* separating templates too\r\n* the responsibility of the model for cleaning internal data\r\n* the responsibility of the model for returning its current URL\r\n\r\nAs always, I'm open to all comments :)","created_at":"2017-11-14T22:38:01Z","updated_at":"2017-11-14T23:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27738f6adb39ec5e52529c1256122fdd126d56eb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60/commits","review_comments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60/comments","review_comment_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/60/comments","statuses_url":"https://api.github.com/repos/cafebabel/cafebabel.com/statuses/5089142a700408e5aafc58dbe5a01d8d64599564","head":{"label":"cafebabel:translations","ref":"translations","sha":"5089142a700408e5aafc58dbe5a01d8d64599564","user":{"login":"cafebabel","id":7603230,"avatar_url":"https://avatars3.githubusercontent.com/u/7603230?v=4","gravatar_id":"","url":"https://api.github.com/users/cafebabel","html_url":"https://github.com/cafebabel","followers_url":"https://api.github.com/users/cafebabel/followers","following_url":"https://api.github.com/users/cafebabel/following{/other_user}","gists_url":"https://api.github.com/users/cafebabel/gists{/gist_id}","starred_url":"https://api.github.com/users/cafebabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafebabel/subscriptions","organizations_url":"https://api.github.com/users/cafebabel/orgs","repos_url":"https://api.github.com/users/cafebabel/repos","events_url":"https://api.github.com/users/cafebabel/events{/privacy}","received_events_url":"https://api.github.com/users/cafebabel/received_events","type":"Organization","site_admin":false},"repo":{"id":101271167,"name":"cafebabel.com","full_name":"cafebabel/cafebabel.com","owner":{"login":"cafebabel","id":7603230,"avatar_url":"https://avatars3.githubusercontent.com/u/7603230?v=4","gravatar_id":"","url":"https://api.github.com/users/cafebabel","html_url":"https://github.com/cafebabel","followers_url":"https://api.github.com/users/cafebabel/followers","following_url":"https://api.github.com/users/cafebabel/following{/other_user}","gists_url":"https://api.github.com/users/cafebabel/gists{/gist_id}","starred_url":"https://api.github.com/users/cafebabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafebabel/subscriptions","organizations_url":"https://api.github.com/users/cafebabel/orgs","repos_url":"https://api.github.com/users/cafebabel/repos","events_url":"https://api.github.com/users/cafebabel/events{/privacy}","received_events_url":"https://api.github.com/users/cafebabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafebabel/cafebabel.com","description":"The future of Cafebabel","fork":false,"url":"https://api.github.com/repos/cafebabel/cafebabel.com","forks_url":"https://api.github.com/repos/cafebabel/cafebabel.com/forks","keys_url":"https://api.github.com/repos/cafebabel/cafebabel.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafebabel/cafebabel.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafebabel/cafebabel.com/teams","hooks_url":"https://api.github.com/repos/cafebabel/cafebabel.com/hooks","issue_events_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/events{/number}","events_url":"https://api.github.com/repos/cafebabel/cafebabel.com/events","assignees_url":"https://api.github.com/repos/cafebabel/cafebabel.com/assignees{/user}","branches_url":"https://api.github.com/repos/cafebabel/cafebabel.com/branches{/branch}","tags_url":"https://api.github.com/repos/cafebabel/cafebabel.com/tags","blobs_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafebabel/cafebabel.com/statuses/{sha}","languages_url":"https://api.github.com/repos/cafebabel/cafebabel.com/languages","stargazers_url":"https://api.github.com/repos/cafebabel/cafebabel.com/stargazers","contributors_url":"https://api.github.com/repos/cafebabel/cafebabel.com/contributors","subscribers_url":"https://api.github.com/repos/cafebabel/cafebabel.com/subscribers","subscription_url":"https://api.github.com/repos/cafebabel/cafebabel.com/subscription","commits_url":"https://api.github.com/repos/cafebabel/cafebabel.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafebabel/cafebabel.com/contents/{+path}","compare_url":"https://api.github.com/repos/cafebabel/cafebabel.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafebabel/cafebabel.com/merges","archive_url":"https://api.github.com/repos/cafebabel/cafebabel.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafebabel/cafebabel.com/downloads","issues_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues{/number}","pulls_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls{/number}","milestones_url":"https://api.github.com/repos/cafebabel/cafebabel.com/milestones{/number}","notifications_url":"https://api.github.com/repos/cafebabel/cafebabel.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafebabel/cafebabel.com/labels{/name}","releases_url":"https://api.github.com/repos/cafebabel/cafebabel.com/releases{/id}","deployments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/deployments","created_at":"2017-08-24T08:17:26Z","updated_at":"2017-11-03T03:14:59Z","pushed_at":"2017-11-14T22:38:01Z","git_url":"git://github.com/cafebabel/cafebabel.com.git","ssh_url":"git@github.com:cafebabel/cafebabel.com.git","clone_url":"https://github.com/cafebabel/cafebabel.com.git","svn_url":"https://github.com/cafebabel/cafebabel.com","homepage":"http://cafebabel.com","size":324,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":1,"default_branch":"master"}},"base":{"label":"cafebabel:master","ref":"master","sha":"d827829d2952b3d3ecb3df3ae20c79c9a6511897","user":{"login":"cafebabel","id":7603230,"avatar_url":"https://avatars3.githubusercontent.com/u/7603230?v=4","gravatar_id":"","url":"https://api.github.com/users/cafebabel","html_url":"https://github.com/cafebabel","followers_url":"https://api.github.com/users/cafebabel/followers","following_url":"https://api.github.com/users/cafebabel/following{/other_user}","gists_url":"https://api.github.com/users/cafebabel/gists{/gist_id}","starred_url":"https://api.github.com/users/cafebabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafebabel/subscriptions","organizations_url":"https://api.github.com/users/cafebabel/orgs","repos_url":"https://api.github.com/users/cafebabel/repos","events_url":"https://api.github.com/users/cafebabel/events{/privacy}","received_events_url":"https://api.github.com/users/cafebabel/received_events","type":"Organization","site_admin":false},"repo":{"id":101271167,"name":"cafebabel.com","full_name":"cafebabel/cafebabel.com","owner":{"login":"cafebabel","id":7603230,"avatar_url":"https://avatars3.githubusercontent.com/u/7603230?v=4","gravatar_id":"","url":"https://api.github.com/users/cafebabel","html_url":"https://github.com/cafebabel","followers_url":"https://api.github.com/users/cafebabel/followers","following_url":"https://api.github.com/users/cafebabel/following{/other_user}","gists_url":"https://api.github.com/users/cafebabel/gists{/gist_id}","starred_url":"https://api.github.com/users/cafebabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafebabel/subscriptions","organizations_url":"https://api.github.com/users/cafebabel/orgs","repos_url":"https://api.github.com/users/cafebabel/repos","events_url":"https://api.github.com/users/cafebabel/events{/privacy}","received_events_url":"https://api.github.com/users/cafebabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafebabel/cafebabel.com","description":"The future of Cafebabel","fork":false,"url":"https://api.github.com/repos/cafebabel/cafebabel.com","forks_url":"https://api.github.com/repos/cafebabel/cafebabel.com/forks","keys_url":"https://api.github.com/repos/cafebabel/cafebabel.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafebabel/cafebabel.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafebabel/cafebabel.com/teams","hooks_url":"https://api.github.com/repos/cafebabel/cafebabel.com/hooks","issue_events_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/events{/number}","events_url":"https://api.github.com/repos/cafebabel/cafebabel.com/events","assignees_url":"https://api.github.com/repos/cafebabel/cafebabel.com/assignees{/user}","branches_url":"https://api.github.com/repos/cafebabel/cafebabel.com/branches{/branch}","tags_url":"https://api.github.com/repos/cafebabel/cafebabel.com/tags","blobs_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafebabel/cafebabel.com/statuses/{sha}","languages_url":"https://api.github.com/repos/cafebabel/cafebabel.com/languages","stargazers_url":"https://api.github.com/repos/cafebabel/cafebabel.com/stargazers","contributors_url":"https://api.github.com/repos/cafebabel/cafebabel.com/contributors","subscribers_url":"https://api.github.com/repos/cafebabel/cafebabel.com/subscribers","subscription_url":"https://api.github.com/repos/cafebabel/cafebabel.com/subscription","commits_url":"https://api.github.com/repos/cafebabel/cafebabel.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafebabel/cafebabel.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafebabel/cafebabel.com/contents/{+path}","compare_url":"https://api.github.com/repos/cafebabel/cafebabel.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafebabel/cafebabel.com/merges","archive_url":"https://api.github.com/repos/cafebabel/cafebabel.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafebabel/cafebabel.com/downloads","issues_url":"https://api.github.com/repos/cafebabel/cafebabel.com/issues{/number}","pulls_url":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls{/number}","milestones_url":"https://api.github.com/repos/cafebabel/cafebabel.com/milestones{/number}","notifications_url":"https://api.github.com/repos/cafebabel/cafebabel.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafebabel/cafebabel.com/labels{/name}","releases_url":"https://api.github.com/repos/cafebabel/cafebabel.com/releases{/id}","deployments_url":"https://api.github.com/repos/cafebabel/cafebabel.com/deployments","created_at":"2017-08-24T08:17:26Z","updated_at":"2017-11-03T03:14:59Z","pushed_at":"2017-11-14T22:38:01Z","git_url":"git://github.com/cafebabel/cafebabel.com.git","ssh_url":"git@github.com:cafebabel/cafebabel.com.git","clone_url":"https://github.com/cafebabel/cafebabel.com.git","svn_url":"https://github.com/cafebabel/cafebabel.com","homepage":"http://cafebabel.com","size":324,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60"},"html":{"href":"https://github.com/cafebabel/cafebabel.com/pull/60"},"issue":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/60"},"comments":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/cafebabel/cafebabel.com/statuses/5089142a700408e5aafc58dbe5a01d8d64599564"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vinyll"}}