{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/comments/119737113","pull_request_review_id":41643515,"id":119737113,"diff_hunk":"@@ -5,8 +5,8 @@ using Base.Test\n tests = [\n     \"tst_expand.jl\"\n     \"tst_center.jl\"\n-    \"tst_rescale.jl\"","path":"test/runtests.jl","position":4,"original_position":4,"commit_id":"2c34c73f844b8bc4eb6abb5e1a8f6f1aba1ec0b8","original_commit_id":"2c34c73f844b8bc4eb6abb5e1a8f6f1aba1ec0b8","user":{"login":"Evizero","id":10854026,"avatar_url":"https://avatars2.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false},"body":"since this file isn't executed anymore, do you mean to delete it?","created_at":"2017-06-01T21:45:53Z","updated_at":"2017-06-01T21:46:54Z","html_url":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1#discussion_r119737113","pull_request_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/comments/119737113"},"html":{"href":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1#discussion_r119737113"},"pull_request":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1","id":118323840,"html_url":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1","diff_url":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1.diff","patch_url":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1.patch","issue_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/1","number":1,"state":"open","locked":false,"title":"WIP feature scalings","user":{"login":"abieler","id":7083141,"avatar_url":"https://avatars2.githubusercontent.com/u/7083141?v=3","gravatar_id":"","url":"https://api.github.com/users/abieler","html_url":"https://github.com/abieler","followers_url":"https://api.github.com/users/abieler/followers","following_url":"https://api.github.com/users/abieler/following{/other_user}","gists_url":"https://api.github.com/users/abieler/gists{/gist_id}","starred_url":"https://api.github.com/users/abieler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abieler/subscriptions","organizations_url":"https://api.github.com/users/abieler/orgs","repos_url":"https://api.github.com/users/abieler/repos","events_url":"https://api.github.com/users/abieler/events{/privacy}","received_events_url":"https://api.github.com/users/abieler/received_events","type":"User","site_admin":false},"body":"Got started on the feature scaling. A few changes I suggest:\r\n\r\n1) rename `rescale` to `standardize`\r\n2) rename `FeatureNormalizer` to `StandardScaler`\r\n3) use `transform` instead of `predict` for rescaling data\r\n4) Add `fixedrange` as scaling function which scales the data to a fixed range\r\n(lower:upper) which defaults to  (0:1).\r\n5) Add `FixedRangeScaler`\r\n\r\nThis all is still not fully functional and I ll keep working on it in the next few days.","created_at":"2017-04-30T19:35:44Z","updated_at":"2017-06-01T21:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df2cadf6b5b79cfbd5bf23ac852b96e022f3b363","assignee":{"login":"Evizero","id":10854026,"avatar_url":"https://avatars2.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false},"assignees":[{"login":"Evizero","id":10854026,"avatar_url":"https://avatars2.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1/commits","review_comments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1/comments","review_comment_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/1/comments","statuses_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/statuses/2c34c73f844b8bc4eb6abb5e1a8f6f1aba1ec0b8","head":{"label":"JuliaML:fixedrange","ref":"fixedrange","sha":"2c34c73f844b8bc4eb6abb5e1a8f6f1aba1ec0b8","user":{"login":"JuliaML","id":15799035,"avatar_url":"https://avatars1.githubusercontent.com/u/15799035?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaML","html_url":"https://github.com/JuliaML","followers_url":"https://api.github.com/users/JuliaML/followers","following_url":"https://api.github.com/users/JuliaML/following{/other_user}","gists_url":"https://api.github.com/users/JuliaML/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaML/subscriptions","organizations_url":"https://api.github.com/users/JuliaML/orgs","repos_url":"https://api.github.com/users/JuliaML/repos","events_url":"https://api.github.com/users/JuliaML/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaML/received_events","type":"Organization","site_admin":false},"repo":{"id":89599188,"name":"MLPreprocessing.jl","full_name":"JuliaML/MLPreprocessing.jl","owner":{"login":"JuliaML","id":15799035,"avatar_url":"https://avatars1.githubusercontent.com/u/15799035?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaML","html_url":"https://github.com/JuliaML","followers_url":"https://api.github.com/users/JuliaML/followers","following_url":"https://api.github.com/users/JuliaML/following{/other_user}","gists_url":"https://api.github.com/users/JuliaML/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaML/subscriptions","organizations_url":"https://api.github.com/users/JuliaML/orgs","repos_url":"https://api.github.com/users/JuliaML/repos","events_url":"https://api.github.com/users/JuliaML/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaML/MLPreprocessing.jl","description":null,"fork":false,"url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl","forks_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/forks","keys_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/teams","hooks_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/events","assignees_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/tags","blobs_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/subscription","commits_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/merges","archive_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/downloads","issues_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/deployments","created_at":"2017-04-27T13:14:11Z","updated_at":"2017-04-27T13:17:52Z","pushed_at":"2017-06-01T15:54:01Z","git_url":"git://github.com/JuliaML/MLPreprocessing.jl.git","ssh_url":"git@github.com:JuliaML/MLPreprocessing.jl.git","clone_url":"https://github.com/JuliaML/MLPreprocessing.jl.git","svn_url":"https://github.com/JuliaML/MLPreprocessing.jl","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaML:master","ref":"master","sha":"25f6d6053b4b9ab5a626b6f449588db409bc4a2d","user":{"login":"JuliaML","id":15799035,"avatar_url":"https://avatars1.githubusercontent.com/u/15799035?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaML","html_url":"https://github.com/JuliaML","followers_url":"https://api.github.com/users/JuliaML/followers","following_url":"https://api.github.com/users/JuliaML/following{/other_user}","gists_url":"https://api.github.com/users/JuliaML/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaML/subscriptions","organizations_url":"https://api.github.com/users/JuliaML/orgs","repos_url":"https://api.github.com/users/JuliaML/repos","events_url":"https://api.github.com/users/JuliaML/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaML/received_events","type":"Organization","site_admin":false},"repo":{"id":89599188,"name":"MLPreprocessing.jl","full_name":"JuliaML/MLPreprocessing.jl","owner":{"login":"JuliaML","id":15799035,"avatar_url":"https://avatars1.githubusercontent.com/u/15799035?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaML","html_url":"https://github.com/JuliaML","followers_url":"https://api.github.com/users/JuliaML/followers","following_url":"https://api.github.com/users/JuliaML/following{/other_user}","gists_url":"https://api.github.com/users/JuliaML/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaML/subscriptions","organizations_url":"https://api.github.com/users/JuliaML/orgs","repos_url":"https://api.github.com/users/JuliaML/repos","events_url":"https://api.github.com/users/JuliaML/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaML/MLPreprocessing.jl","description":null,"fork":false,"url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl","forks_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/forks","keys_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/teams","hooks_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/events","assignees_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/tags","blobs_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/subscription","commits_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/merges","archive_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/downloads","issues_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/deployments","created_at":"2017-04-27T13:14:11Z","updated_at":"2017-04-27T13:17:52Z","pushed_at":"2017-06-01T15:54:01Z","git_url":"git://github.com/JuliaML/MLPreprocessing.jl.git","ssh_url":"git@github.com:JuliaML/MLPreprocessing.jl.git","clone_url":"https://github.com/JuliaML/MLPreprocessing.jl.git","svn_url":"https://github.com/JuliaML/MLPreprocessing.jl","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1"},"html":{"href":"https://github.com/JuliaML/MLPreprocessing.jl/pull/1"},"issue":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/1"},"comments":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaML/MLPreprocessing.jl/statuses/2c34c73f844b8bc4eb6abb5e1a8f6f1aba1ec0b8"}}}}
{"actor":{"display_login":"Evizero"}}