{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/156872549","pull_request_review_id":83418357,"id":156872549,"diff_hunk":"@@ -679,29 +681,24 @@ const std::string& TextFieldTTF::getPlaceHolder() const\n \n void TextFieldTTF::setCursorEnabled(bool enabled)\n {\n-    if (_currentLabelType == LabelType::TTF)\n-    {\n-        if (_cursorEnabled != enabled)\n-        {\n-            _cursorEnabled = enabled;\n-            if (_cursorEnabled)\n-            {\n-                _cursorPosition = _charCount;\n-\n-                scheduleUpdate();\n-            }\n-            else\n-            {\n-                _cursorPosition = 0;\n-\n-                unscheduleUpdate();\n-            }\n-        }\n-    }\n-    else\n-    {\n-        CCLOG(\"TextFieldTTF cursor worked only LabelType::TTF\");\n-    }\n+\tif (_cursorEnabled != enabled)\n+\t{\n+\t    _cursorEnabled = enabled;\n+\t    if (_cursorEnabled)\n+\t    {\n+\t        _cursorPosition = _charCount;\n+\t\n+\t\t\tif (_currentLabelType == LabelType::TTF)","path":"cocos/2d/CCTextFieldTTF.cpp","position":54,"original_position":54,"commit_id":"3320d62b235314c7c45e45a42c87a62c5b4c9542","original_commit_id":"3320d62b235314c7c45e45a42c87a62c5b4c9542","user":{"login":"drelaptop","id":26329291,"avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"body":"format error, a `Tab` should be replaced by 4 `Space`, and can you add a test case to show the fix? I noticed that the old test didn't test cursor. \r\n\r\n> the content needed to add test case, you can refer to [pull/18552/files](https://github.com/cocos2d/cocos2d-x/pull/18552/files)","created_at":"2017-12-14T07:46:30Z","updated_at":"2017-12-14T07:46:51Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/18555#discussion_r156872549","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/156872549"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/18555#discussion_r156872549"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555","id":157771205,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/18555","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/18555.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/18555.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18555","number":18555,"state":"open","locked":false,"title":"Partial cursor support for text field with system font","user":{"login":"sbrednikhin","id":4668006,"avatar_url":"https://avatars1.githubusercontent.com/u/4668006?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrednikhin","html_url":"https://github.com/sbrednikhin","followers_url":"https://api.github.com/users/sbrednikhin/followers","following_url":"https://api.github.com/users/sbrednikhin/following{/other_user}","gists_url":"https://api.github.com/users/sbrednikhin/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrednikhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrednikhin/subscriptions","organizations_url":"https://api.github.com/users/sbrednikhin/orgs","repos_url":"https://api.github.com/users/sbrednikhin/repos","events_url":"https://api.github.com/users/sbrednikhin/events{/privacy}","received_events_url":"https://api.github.com/users/sbrednikhin/received_events","type":"User","site_admin":false},"body":"Enables cursor support without cursor blinking an zero with of cursor symbol. In case of system font usage magical \"/b\" symbol won't be used, also update won't be scheduled.\r\nIssue #18554","created_at":"2017-12-12T09:05:33Z","updated_at":"2017-12-14T07:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b4d8bf88984f78cbc28e101d5a37cf6196e7110","assignee":{"login":"drelaptop","id":26329291,"avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"assignees":[{"login":"drelaptop","id":26329291,"avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18555/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/3320d62b235314c7c45e45a42c87a62c5b4c9542","head":{"label":"sbrednikhin:patch-6","ref":"patch-6","sha":"3320d62b235314c7c45e45a42c87a62c5b4c9542","user":{"login":"sbrednikhin","id":4668006,"avatar_url":"https://avatars1.githubusercontent.com/u/4668006?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrednikhin","html_url":"https://github.com/sbrednikhin","followers_url":"https://api.github.com/users/sbrednikhin/followers","following_url":"https://api.github.com/users/sbrednikhin/following{/other_user}","gists_url":"https://api.github.com/users/sbrednikhin/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrednikhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrednikhin/subscriptions","organizations_url":"https://api.github.com/users/sbrednikhin/orgs","repos_url":"https://api.github.com/users/sbrednikhin/repos","events_url":"https://api.github.com/users/sbrednikhin/events{/privacy}","received_events_url":"https://api.github.com/users/sbrednikhin/received_events","type":"User","site_admin":false},"repo":{"id":19849439,"name":"cocos2d-x","full_name":"sbrednikhin/cocos2d-x","owner":{"login":"sbrednikhin","id":4668006,"avatar_url":"https://avatars1.githubusercontent.com/u/4668006?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrednikhin","html_url":"https://github.com/sbrednikhin","followers_url":"https://api.github.com/users/sbrednikhin/followers","following_url":"https://api.github.com/users/sbrednikhin/following{/other_user}","gists_url":"https://api.github.com/users/sbrednikhin/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrednikhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrednikhin/subscriptions","organizations_url":"https://api.github.com/users/sbrednikhin/orgs","repos_url":"https://api.github.com/users/sbrednikhin/repos","events_url":"https://api.github.com/users/sbrednikhin/events{/privacy}","received_events_url":"https://api.github.com/users/sbrednikhin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbrednikhin/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/sbrednikhin/cocos2d-x","forks_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/forks","keys_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/events","assignees_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/merges","archive_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/sbrednikhin/cocos2d-x/deployments","created_at":"2014-05-16T08:18:36Z","updated_at":"2014-05-16T09:05:58Z","pushed_at":"2017-12-13T07:37:21Z","git_url":"git://github.com/sbrednikhin/cocos2d-x.git","ssh_url":"git@github.com:sbrednikhin/cocos2d-x.git","clone_url":"https://github.com/sbrednikhin/cocos2d-x.git","svn_url":"https://github.com/sbrednikhin/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":281843,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"7916beb314ed2947959c98fefd82d7c98e88e31e","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"Cocos2d-x is a suite of open-source, cross-platform, game-development tools used by millions of developers all over the world.","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2017-12-14T05:35:39Z","pushed_at":"2017-12-14T05:45:22Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":912524,"stargazers_count":11266,"watchers_count":11266,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6434,"mirror_url":null,"archived":false,"open_issues_count":1211,"license":null,"forks":6434,"open_issues":1211,"watchers":11266,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/18555"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18555"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18555/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18555/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/3320d62b235314c7c45e45a42c87a62c5b4c9542"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drelaptop"}}