{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/114074883","pull_request_review_id":35516411,"id":114074883,"diff_hunk":"@@ -53,9 +56,49 @@ def install\n     # potential to break scripts, so recreate it for now.\n     # Debian have done the same thing.\n     bin.install_symlink bin/\"ssh\" => \"slogin\"\n+\n+    # https://opensource.apple.com/source/OpenSSH/OpenSSH-209.30.4/com.openssh.sshd.sb\n+    (buildpath/\"org.openssh.sshd.sb\").write <<-EOS.undent\n+      ;; Copyright (c) 2008 Apple Inc.  All Rights reserved.\n+      ;;\n+      ;; sshd - profile for privilege separated children\n+      ;;\n+      ;; WARNING: The sandbox rules in this file currently constitute\n+      ;; Apple System Private Interface and are subject to change at any time and\n+      ;; without notice.\n+      ;;\n+\n+      (version 1)\n+\n+      (deny default)\n+\n+      (allow file-chroot)\n+      (allow file-read-metadata (literal \"/var\"))\n+\n+      (allow sysctl-read)\n+      (allow mach-per-user-lookup)\n+      (allow mach-lookup\n+        (global-name \"com.apple.system.notification_center\")\n+        (global-name \"com.apple.system.opendirectoryd.libinfo\")\n+        (global-name \"com.apple.system.opendirectoryd.libinfo\") ;; duplicate name as a work-around for 19978803\n+        (global-name \"com.apple.system.logger\"))\n+    EOS\n+    (etc/\"ssh\").install \"org.openssh.sshd.sb\"\n   end\n \n   test do\n     assert_match \"OpenSSH_\", shell_output(\"#{bin}/ssh -V 2>&1\")\n+\n+    begin\n+      system sbin/\"sshd\", \"-p\", \"8022\"\n+      sleep 2\n+      assert_match \"sshd\", shell_output(\"lsof -i :8022\")\n+    ensure\n+      # sshd keeps running even after a Process.kill so\n+      # we have to lean on the system to handle it.\n+      # The \"-n\" flag means only the newest sshd will be killed\n+      # which should be the one we've just launched for testing.\n+      system \"/usr/bin/pkill\", \"-n\", \"sshd\"","path":"Formula/openssh.rb","position":69,"original_position":69,"commit_id":"319dd05ffeb6540e4ba0dcb376e1fa8fb8e6fec2","original_commit_id":"319dd05ffeb6540e4ba0dcb376e1fa8fb8e6fec2","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars1.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"Can you double check that the system `sshd` isn't run as a user that this will kill? ","created_at":"2017-04-30T13:01:44Z","updated_at":"2017-04-30T13:01:48Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/13045#discussion_r114074883","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/114074883"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/13045#discussion_r114074883"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045","id":118288791,"html_url":"https://github.com/Homebrew/homebrew-core/pull/13045","diff_url":"https://github.com/Homebrew/homebrew-core/pull/13045.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/13045.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/13045","number":13045,"state":"open","locked":false,"title":"openssh: fix sandbox profile location","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars3.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nI left a comment in dupes somewhere _months ago_ about how to fix this but nobody filed a PR, and to be fair, neither did I, so I guess I can't blame anyone but myself for leaving this broken for so long eh.\r\n\r\nFixes https://github.com/Homebrew/homebrew-core/issues/12488.","created_at":"2017-04-29T20:20:27Z","updated_at":"2017-04-30T13:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ffd4d9bcdc19439983949ee1904c11e88ad4827","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/13045/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/319dd05ffeb6540e4ba0dcb376e1fa8fb8e6fec2","head":{"label":"DomT4:openssh","ref":"openssh","sha":"319dd05ffeb6540e4ba0dcb376e1fa8fb8e6fec2","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars3.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":55303615,"name":"homebrew-core","full_name":"DomT4/homebrew-core","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars3.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/DomT4/homebrew-core","forks_url":"https://api.github.com/repos/DomT4/homebrew-core/forks","keys_url":"https://api.github.com/repos/DomT4/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/homebrew-core/teams","hooks_url":"https://api.github.com/repos/DomT4/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/DomT4/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/homebrew-core/events","assignees_url":"https://api.github.com/repos/DomT4/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/homebrew-core/tags","blobs_url":"https://api.github.com/repos/DomT4/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/DomT4/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/DomT4/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/DomT4/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/DomT4/homebrew-core/subscription","commits_url":"https://api.github.com/repos/DomT4/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DomT4/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/homebrew-core/merges","archive_url":"https://api.github.com/repos/DomT4/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/homebrew-core/downloads","issues_url":"https://api.github.com/repos/DomT4/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/DomT4/homebrew-core/deployments","created_at":"2016-04-02T16:09:23Z","updated_at":"2016-04-02T16:09:36Z","pushed_at":"2017-04-29T20:19:07Z","git_url":"git://github.com/DomT4/homebrew-core.git","ssh_url":"git@github.com:DomT4/homebrew-core.git","clone_url":"https://github.com/DomT4/homebrew-core.git","svn_url":"https://github.com/DomT4/homebrew-core","homepage":"","size":116676,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"fb4429fa4b75db8e4c4fe925e26d8a23ed8e6fb6","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars1.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars1.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-04-30T07:05:10Z","pushed_at":"2017-04-30T12:26:57Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":116222,"stargazers_count":1569,"watchers_count":1569,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2588,"mirror_url":null,"open_issues_count":133,"forks":2588,"open_issues":133,"watchers":1569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/13045"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/13045"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/13045/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/13045/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/319dd05ffeb6540e4ba0dcb376e1fa8fb8e6fec2"}}}}
{"actor":{"display_login":"MikeMcQuaid"}}