{"action":"closed","issue":{"url":"https://api.github.com/repos/creationix/nvm/issues/1649","repository_url":"https://api.github.com/repos/creationix/nvm","labels_url":"https://api.github.com/repos/creationix/nvm/issues/1649/labels{/name}","comments_url":"https://api.github.com/repos/creationix/nvm/issues/1649/comments","events_url":"https://api.github.com/repos/creationix/nvm/issues/1649/events","html_url":"https://github.com/creationix/nvm/issues/1649","id":270510168,"number":1649,"title":"install script installs bad .zprofile commands","user":{"login":"mikeyb","id":36461,"avatar_url":"https://avatars2.githubusercontent.com/u/36461?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeyb","html_url":"https://github.com/mikeyb","followers_url":"https://api.github.com/users/mikeyb/followers","following_url":"https://api.github.com/users/mikeyb/following{/other_user}","gists_url":"https://api.github.com/users/mikeyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeyb/subscriptions","organizations_url":"https://api.github.com/users/mikeyb/orgs","repos_url":"https://api.github.com/users/mikeyb/repos","events_url":"https://api.github.com/users/mikeyb/events{/privacy}","received_events_url":"https://api.github.com/users/mikeyb/received_events","type":"User","site_admin":false},"labels":[{"id":401143427,"url":"https://api.github.com/repos/creationix/nvm/labels/installing%20nvm","name":"installing nvm","color":"fef2c0","default":false},{"id":132570776,"url":"https://api.github.com/repos/creationix/nvm/labels/needs%20followup","name":"needs followup","color":"FA94FD","default":false},{"id":43482627,"url":"https://api.github.com/repos/creationix/nvm/labels/shell:%20zsh","name":"shell: zsh","color":"f7c6c7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-11-02T02:11:50Z","updated_at":"2017-11-02T16:14:54Z","closed_at":"2017-11-02T16:14:54Z","author_association":"NONE","body":"- Operating system and version:\r\n```sh\r\nuname -a: 'Linux 4.4.0-97-generic #120-Ubuntu SMP Tue Sep 19 17:28:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux'\r\n```\r\n\r\n- `nvm debug` output:\r\n<details>\r\n<!-- do not delete the following blank line -->\r\n\r\n```sh\r\nnvm --version: v0.33.6\r\n$SHELL: /bin/zsh\r\n$HOME: /root\r\n$NVM_DIR: '$HOME/.nvm'\r\n$PREFIX: ''\r\n$NPM_CONFIG_PREFIX: ''\r\n$NVM_NODEJS_ORG_MIRROR: ''\r\n$NVM_IOJS_ORG_MIRROR: ''\r\nshell version: 'zsh 5.1.1 (x86_64-ubuntu-linux-gnu)'\r\nuname -a: 'Linux 4.4.0-97-generic #120-Ubuntu SMP Tue Sep 19 17:28:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux'\r\nOS version: Ubuntu 16.04.3 LTS  \r\ncurl: /usr/bin/curl, curl 7.47.0 (x86_64-pc-linux-gnu) libcurl/7.47.0 GnuTLS/3.4.10 zlib/1.2.8 libidn/1.32 librtmp/2.3\r\nwget: /usr/bin/wget, GNU Wget 1.17.1 built on linux-gnu.\r\ngit: /usr/bin/git, git version 2.7.4\r\ngrep: grep: aliased to nocorrect grep --color=auto (nocorrect grep --color=auto), grep (GNU grep) 2.25\r\nawk: /usr/bin/awk, GNU Awk 4.1.3, API: 1.1 (GNU MPFR 3.1.4, GNU MP 6.1.0)\r\nsed: /bin/sed, sed (GNU sed) 4.2.2\r\ncut: /usr/bin/cut, cut (GNU coreutils) 8.25\r\nbasename: /usr/bin/basename, basename (GNU coreutils) 8.25\r\nrm: rm: aliased to nocorrect rm -i (nocorrect rm -i), rm (GNU coreutils) 8.25\r\nmkdir: mkdir: aliased to nocorrect mkdir -p (nocorrect mkdir -p), mkdir (GNU coreutils) 8.25\r\nxargs: /usr/bin/xargs, xargs (GNU findutils) 4.7.0-git\r\nnvm current: v8.9.0\r\nwhich node: $NVM_DIR/versions/node/v8.9.0/bin/node\r\nwhich iojs: iojs not found\r\nwhich npm: $NVM_DIR/versions/node/v8.9.0/bin/npm\r\nnpm config get prefix: $NVM_DIR/versions/node/v8.9.0\r\nnpm root -g: $NVM_DIR/versions/node/v8.9.0/lib/node_modules\r\n\r\n```\r\n</details>\r\n\r\n- `nvm ls` output:\r\n<details>\r\n<!-- do not delete the following blank line -->\r\n\r\n```sh\r\n->       v8.9.0\r\ndefault -> lts/carbon (-> v8.9.0)\r\nnode -> stable (-> v8.9.0) (default)\r\nstable -> 8.9 (-> v8.9.0) (default)\r\niojs -> N/A (default)\r\nlts/* -> lts/carbon (-> v8.9.0)\r\nlts/argon -> v4.8.5 (-> N/A)\r\nlts/boron -> v6.11.5 (-> N/A)\r\nlts/carbon -> v8.9.0\r\n```\r\n</details>\r\n\r\n- How did you install `nvm`? (e.g. install script in readme, homebrew):\r\ninstall script in readme\r\n\r\n- What happened?\r\nWhen installing nvm using zsh, bash style comments are appended to the ~/.zprofile entry\r\nsee: https://github.com/creationix/nvm/blob/9953a52afb275617fe5d108cefcd1354cf47bfc0/install.sh#L328-L329\r\n\r\nThis causes error in execution in zsh ( http://zsh.sourceforge.net/Doc/Release/Shell-Builtin-Commands.html )\r\n\r\n```\r\n❯❯❯ [ -s \"$NVM_DIR/nvm.sh\" ] && \\. \"$NVM_DIR/nvm.sh\"  # This loads nvm\r\nzsh: bad pattern: #\r\n```\r\n```\r\n'#' (EXTENDED_GLOB)\r\nThe pattern character # wherever it occurs, both for repetition of a previous pattern and for indicating globbing flags.\r\n```\r\n- What did you expect to happen?\r\nno error :)\r\n"}}
{"actor":{"display_login":"mikeyb"}}