{"action":"created","comment":{"url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments/154715451","pull_request_review_id":80917440,"id":154715451,"diff_hunk":"@@ -782,17 +784,17 @@ def findPlatforms(db_path):\n     platforms = set()\n     # Walk all the directories\n     for db_dir in db_path:\n-        try:\n-            # Look for JSON files in each directory\n-            for fn in os.listdir(db_dir):\n-                if fn.endswith('.json'):\n+        # Look for JSON files in each directory\n+        for fn in os.listdir(db_dir):\n+            if fn.endswith('.json'):\n+                try:\n                     with open(os.path.join(db_dir, fn)) as f:\n                         # Does it have a platform name field?\n                         db = json.load(f)\n                         platforms.add(db['platform-name'])\n-        except Exception:\n-            # Give up on this file or directory if there is any error\n-            None\n+                except Exception:\n+                    # Give up on this file or directory if there is any error\n+                    None","path":"platforms/scripts/afu_platform_config","position":43,"original_position":43,"commit_id":"09f0fefd1df74181a2df09d3846c2ba6aca21ae2","original_commit_id":"efe16d6718589128df5846ffd74ce4e01ab954bc","user":{"login":"r-rojo","id":22808196,"avatar_url":"https://avatars3.githubusercontent.com/u/22808196?v=4","gravatar_id":"","url":"https://api.github.com/users/r-rojo","html_url":"https://github.com/r-rojo","followers_url":"https://api.github.com/users/r-rojo/followers","following_url":"https://api.github.com/users/r-rojo/following{/other_user}","gists_url":"https://api.github.com/users/r-rojo/gists{/gist_id}","starred_url":"https://api.github.com/users/r-rojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-rojo/subscriptions","organizations_url":"https://api.github.com/users/r-rojo/orgs","repos_url":"https://api.github.com/users/r-rojo/repos","events_url":"https://api.github.com/users/r-rojo/events{/privacy}","received_events_url":"https://api.github.com/users/r-rojo/received_events","type":"User","site_admin":false},"body":"Do we want to give up on a directory if there is an error in just one JSON file? Wouldn't it be better to give up on just that file? Perhaps a little more explicit exception handling could help?","created_at":"2017-12-04T17:21:52Z","updated_at":"2017-12-04T17:22:08Z","html_url":"https://github.com/OPAE/opae-sdk/pull/65#discussion_r154715451","pull_request_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments/154715451"},"html":{"href":"https://github.com/OPAE/opae-sdk/pull/65#discussion_r154715451"},"pull_request":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65","id":156015601,"html_url":"https://github.com/OPAE/opae-sdk/pull/65","diff_url":"https://github.com/OPAE/opae-sdk/pull/65.diff","patch_url":"https://github.com/OPAE/opae-sdk/pull/65.patch","issue_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/65","number":65,"state":"open","locked":false,"title":"Fix method for finding the installed share/opae directory.","user":{"login":"michael-adler","id":10950878,"avatar_url":"https://avatars0.githubusercontent.com/u/10950878?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-adler","html_url":"https://github.com/michael-adler","followers_url":"https://api.github.com/users/michael-adler/followers","following_url":"https://api.github.com/users/michael-adler/following{/other_user}","gists_url":"https://api.github.com/users/michael-adler/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-adler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-adler/subscriptions","organizations_url":"https://api.github.com/users/michael-adler/orgs","repos_url":"https://api.github.com/users/michael-adler/repos","events_url":"https://api.github.com/users/michael-adler/events{/privacy}","received_events_url":"https://api.github.com/users/michael-adler/received_events","type":"User","site_admin":false},"body":"The true installation path is unknown when users install from an RPM.\r\nAll we can count on is the relative positions of the installed\r\nbin and share directories.\r\n\r\nAlso fixed an error in finding all the platforms and interfaces for the\r\n--help message.\r\n\r\nThese are both needed for release/0.13.","created_at":"2017-12-02T14:28:02Z","updated_at":"2017-12-04T17:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9455932857e7f0d74222d5506d2e074aa1a1124d","assignee":{"login":"michael-adler","id":10950878,"avatar_url":"https://avatars0.githubusercontent.com/u/10950878?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-adler","html_url":"https://github.com/michael-adler","followers_url":"https://api.github.com/users/michael-adler/followers","following_url":"https://api.github.com/users/michael-adler/following{/other_user}","gists_url":"https://api.github.com/users/michael-adler/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-adler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-adler/subscriptions","organizations_url":"https://api.github.com/users/michael-adler/orgs","repos_url":"https://api.github.com/users/michael-adler/repos","events_url":"https://api.github.com/users/michael-adler/events{/privacy}","received_events_url":"https://api.github.com/users/michael-adler/received_events","type":"User","site_admin":false},"assignees":[{"login":"michael-adler","id":10950878,"avatar_url":"https://avatars0.githubusercontent.com/u/10950878?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-adler","html_url":"https://github.com/michael-adler","followers_url":"https://api.github.com/users/michael-adler/followers","following_url":"https://api.github.com/users/michael-adler/following{/other_user}","gists_url":"https://api.github.com/users/michael-adler/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-adler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-adler/subscriptions","organizations_url":"https://api.github.com/users/michael-adler/orgs","repos_url":"https://api.github.com/users/michael-adler/repos","events_url":"https://api.github.com/users/michael-adler/events{/privacy}","received_events_url":"https://api.github.com/users/michael-adler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shivarao","id":1483374,"avatar_url":"https://avatars3.githubusercontent.com/u/1483374?v=4","gravatar_id":"","url":"https://api.github.com/users/shivarao","html_url":"https://github.com/shivarao","followers_url":"https://api.github.com/users/shivarao/followers","following_url":"https://api.github.com/users/shivarao/following{/other_user}","gists_url":"https://api.github.com/users/shivarao/gists{/gist_id}","starred_url":"https://api.github.com/users/shivarao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivarao/subscriptions","organizations_url":"https://api.github.com/users/shivarao/orgs","repos_url":"https://api.github.com/users/shivarao/repos","events_url":"https://api.github.com/users/shivarao/events{/privacy}","received_events_url":"https://api.github.com/users/shivarao/received_events","type":"User","site_admin":false},{"login":"southerngs","id":3270868,"avatar_url":"https://avatars1.githubusercontent.com/u/3270868?v=4","gravatar_id":"","url":"https://api.github.com/users/southerngs","html_url":"https://github.com/southerngs","followers_url":"https://api.github.com/users/southerngs/followers","following_url":"https://api.github.com/users/southerngs/following{/other_user}","gists_url":"https://api.github.com/users/southerngs/gists{/gist_id}","starred_url":"https://api.github.com/users/southerngs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southerngs/subscriptions","organizations_url":"https://api.github.com/users/southerngs/orgs","repos_url":"https://api.github.com/users/southerngs/repos","events_url":"https://api.github.com/users/southerngs/events{/privacy}","received_events_url":"https://api.github.com/users/southerngs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65/commits","review_comments_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65/comments","review_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/65/comments","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/09f0fefd1df74181a2df09d3846c2ba6aca21ae2","head":{"label":"OPAE:mcadler/share_platform_path","ref":"mcadler/share_platform_path","sha":"09f0fefd1df74181a2df09d3846c2ba6aca21ae2","user":{"login":"OPAE","id":30705801,"avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"repo":{"id":102083635,"name":"opae-sdk","full_name":"OPAE/opae-sdk","owner":{"login":"OPAE","id":30705801,"avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPAE/opae-sdk","description":"Open Programmable Acceleration Engine","fork":false,"url":"https://api.github.com/repos/OPAE/opae-sdk","forks_url":"https://api.github.com/repos/OPAE/opae-sdk/forks","keys_url":"https://api.github.com/repos/OPAE/opae-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPAE/opae-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPAE/opae-sdk/teams","hooks_url":"https://api.github.com/repos/OPAE/opae-sdk/hooks","issue_events_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/OPAE/opae-sdk/events","assignees_url":"https://api.github.com/repos/OPAE/opae-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/OPAE/opae-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/OPAE/opae-sdk/tags","blobs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPAE/opae-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPAE/opae-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/OPAE/opae-sdk/languages","stargazers_url":"https://api.github.com/repos/OPAE/opae-sdk/stargazers","contributors_url":"https://api.github.com/repos/OPAE/opae-sdk/contributors","subscribers_url":"https://api.github.com/repos/OPAE/opae-sdk/subscribers","subscription_url":"https://api.github.com/repos/OPAE/opae-sdk/subscription","commits_url":"https://api.github.com/repos/OPAE/opae-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPAE/opae-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPAE/opae-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/OPAE/opae-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPAE/opae-sdk/merges","archive_url":"https://api.github.com/repos/OPAE/opae-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPAE/opae-sdk/downloads","issues_url":"https://api.github.com/repos/OPAE/opae-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/OPAE/opae-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/OPAE/opae-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPAE/opae-sdk/labels{/name}","releases_url":"https://api.github.com/repos/OPAE/opae-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/OPAE/opae-sdk/deployments","created_at":"2017-09-01T07:00:50Z","updated_at":"2017-11-29T11:00:26Z","pushed_at":"2017-12-04T17:11:34Z","git_url":"git://github.com/OPAE/opae-sdk.git","ssh_url":"git@github.com:OPAE/opae-sdk.git","clone_url":"https://github.com/OPAE/opae-sdk.git","svn_url":"https://github.com/OPAE/opae-sdk","homepage":"https://01.org/OPAE","size":2527,"stargazers_count":56,"watchers_count":56,"language":"Verilog","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":11,"watchers":56,"default_branch":"master"}},"base":{"label":"OPAE:master","ref":"master","sha":"197913730536b320b0d19a4e92803672bab30d72","user":{"login":"OPAE","id":30705801,"avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"repo":{"id":102083635,"name":"opae-sdk","full_name":"OPAE/opae-sdk","owner":{"login":"OPAE","id":30705801,"avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPAE/opae-sdk","description":"Open Programmable Acceleration Engine","fork":false,"url":"https://api.github.com/repos/OPAE/opae-sdk","forks_url":"https://api.github.com/repos/OPAE/opae-sdk/forks","keys_url":"https://api.github.com/repos/OPAE/opae-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPAE/opae-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPAE/opae-sdk/teams","hooks_url":"https://api.github.com/repos/OPAE/opae-sdk/hooks","issue_events_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/OPAE/opae-sdk/events","assignees_url":"https://api.github.com/repos/OPAE/opae-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/OPAE/opae-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/OPAE/opae-sdk/tags","blobs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPAE/opae-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPAE/opae-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/OPAE/opae-sdk/languages","stargazers_url":"https://api.github.com/repos/OPAE/opae-sdk/stargazers","contributors_url":"https://api.github.com/repos/OPAE/opae-sdk/contributors","subscribers_url":"https://api.github.com/repos/OPAE/opae-sdk/subscribers","subscription_url":"https://api.github.com/repos/OPAE/opae-sdk/subscription","commits_url":"https://api.github.com/repos/OPAE/opae-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPAE/opae-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPAE/opae-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/OPAE/opae-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPAE/opae-sdk/merges","archive_url":"https://api.github.com/repos/OPAE/opae-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPAE/opae-sdk/downloads","issues_url":"https://api.github.com/repos/OPAE/opae-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/OPAE/opae-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/OPAE/opae-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPAE/opae-sdk/labels{/name}","releases_url":"https://api.github.com/repos/OPAE/opae-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/OPAE/opae-sdk/deployments","created_at":"2017-09-01T07:00:50Z","updated_at":"2017-11-29T11:00:26Z","pushed_at":"2017-12-04T17:11:34Z","git_url":"git://github.com/OPAE/opae-sdk.git","ssh_url":"git@github.com:OPAE/opae-sdk.git","clone_url":"https://github.com/OPAE/opae-sdk.git","svn_url":"https://github.com/OPAE/opae-sdk","homepage":"https://01.org/OPAE","size":2527,"stargazers_count":56,"watchers_count":56,"language":"Verilog","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":11,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65"},"html":{"href":"https://github.com/OPAE/opae-sdk/pull/65"},"issue":{"href":"https://api.github.com/repos/OPAE/opae-sdk/issues/65"},"comments":{"href":"https://api.github.com/repos/OPAE/opae-sdk/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/OPAE/opae-sdk/statuses/09f0fefd1df74181a2df09d3846c2ba6aca21ae2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"r-rojo"}}