{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1611","repository_url":"https://api.github.com/repos/Azure/azure-functions-ux","labels_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1611/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1611/comments","events_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1611/events","html_url":"https://github.com/Azure/azure-functions-ux/pull/1611","id":246885857,"number":1611,"title":"Fixes #1599 - Improve the Function apps browse list","user":{"login":"agruning","id":8560637,"avatar_url":"https://avatars0.githubusercontent.com/u/8560637?v=4","gravatar_id":"","url":"https://api.github.com/users/agruning","html_url":"https://github.com/agruning","followers_url":"https://api.github.com/users/agruning/followers","following_url":"https://api.github.com/users/agruning/following{/other_user}","gists_url":"https://api.github.com/users/agruning/gists{/gist_id}","starred_url":"https://api.github.com/users/agruning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agruning/subscriptions","organizations_url":"https://api.github.com/users/agruning/orgs","repos_url":"https://api.github.com/users/agruning/repos","events_url":"https://api.github.com/users/agruning/events{/privacy}","received_events_url":"https://api.github.com/users/agruning/received_events","type":"User","site_admin":false},"labels":[{"id":611783704,"url":"https://api.github.com/repos/Azure/azure-functions-ux/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-31T21:11:15Z","updated_at":"2017-07-31T21:54:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1611","html_url":"https://github.com/Azure/azure-functions-ux/pull/1611","diff_url":"https://github.com/Azure/azure-functions-ux/pull/1611.diff","patch_url":"https://github.com/Azure/azure-functions-ux/pull/1611.patch"},"body":"![image](https://user-images.githubusercontent.com/8560637/28798605-da440cb8-75f9-11e7-9248-080729f57e5e.png)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/azure-functions-ux/1611)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/comments/319207749","html_url":"https://github.com/Azure/azure-functions-ux/pull/1611#issuecomment-319207749","issue_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1611","id":319207749,"user":{"login":"ehamai","id":5695405,"avatar_url":"https://avatars2.githubusercontent.com/u/5695405?v=4","gravatar_id":"","url":"https://api.github.com/users/ehamai","html_url":"https://github.com/ehamai","followers_url":"https://api.github.com/users/ehamai/followers","following_url":"https://api.github.com/users/ehamai/following{/other_user}","gists_url":"https://api.github.com/users/ehamai/gists{/gist_id}","starred_url":"https://api.github.com/users/ehamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehamai/subscriptions","organizations_url":"https://api.github.com/users/ehamai/orgs","repos_url":"https://api.github.com/users/ehamai/repos","events_url":"https://api.github.com/users/ehamai/events{/privacy}","received_events_url":"https://api.github.com/users/ehamai/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T21:54:15Z","updated_at":"2017-07-31T21:54:15Z","body":"\n\n\n\nReviewed 1 of 9 files at r1.\nReview status: 1 of 9 files reviewed at latest revision, 9 unresolved discussions.\n\n---\n\n*[a discussion](https://reviewable.io:443/reviews/azure/azure-functions-ux/1611#-KqP_28_fHcnxTC33pSC:-KqP_28ajoHthkaUSGvz:b-jc8yb9) (no related file):*\nHaven't looked at the code yet, but the UI looks very nice!  Can you also please make sure that keyboard navigation still works?\n\n---\n\n*[AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html, line 20 at r1](https://reviewable.io:443/reviews/azure/azure-functions-ux/1611#-KqPbRN-6DFL7e36SCkI:-KqPbRN-6DFL7e36SCkJ:b-oghrjq) ([raw file](https://github.com/azure/azure-functions-ux/blob/e78f0dc72570818193a30fdbfdfe08dca7796792/AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html#L20)):*\n> ```HTML\n> </div> \n> \n> <tbl [items]=\"tableItems\" #table=\"tbl\" id=\"apps-list\" [name]='Resources.functionApps | translate'>\n> ```\n\nI think you can just do [name]=\"'functionApps' | translate\"\n\n---\n\n*[AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html, line 34 at r1](https://reviewable.io:443/reviews/azure/azure-functions-ux/1611#-KqPbm0V13eOHnvkB0EC:-KqPbm0V13eOHnvkB0ED:bj23nyn) ([raw file](https://github.com/azure/azure-functions-ux/blob/e78f0dc72570818193a30fdbfdfe08dca7796792/AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html#L34)):*\n> ```HTML\n>     <td *ngIf=\"item.type === 'row' && table.groupedBy === 'none'\">{{item.location}}</td>\n>     \n>     <td class='tabbed' *ngIf=\"item.type === 'row' && table.groupedBy !== 'none'\"><a (click)=\"clickRow(item)\">{{item.title}}</a></td>\n> ```\n\nI just learned about using ng-container from Aniello.  Basically you should be able to wrap your <td> elements with a single <ng-container *ngIf=\"item.type === 'row' && table.groupedBy === 'none'\"> element.  When Angular renders the DOM, it will remove the ng-container element but apply the same view logic to the internal elements like you're doing.  This will help to keep your HTML clean.\n\n---\n\n*[AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html, line 39 at r1](https://reviewable.io:443/reviews/azure/azure-functions-ux/1611#-KqPd1Lo_bbocCc_PcgZ:-KqPd1Lo_bbocCc_Pcg_:b-ngkw8q) ([raw file](https://github.com/azure/azure-functions-ux/blob/e78f0dc72570818193a30fdbfdfe08dca7796792/AzureFunctions.AngularClient/src/app/apps-list/apps-list.component.html#L39)):*\n<details><summary><i alt=\"summary\">Quoted 4 lines of code…</i></summary>\n>     <td *ngIf=\"item.type === 'group'\">{{item.title}}</td>\n>     <td *ngIf=\"item.type === 'group'\"></td>\n>     <td *ngIf=\"item.type === 'group'\"></td>\n>     <td *ngIf=\"item.type === 'group'\"></td>\n</details>\n\nInstead of defining 3 td elements, just use colspan on the first\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/azure/azure-functions-ux/1611)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ehamai"}}