{"action":"created","comment":{"url":"https://api.github.com/repos/storaged-project/udisks/pulls/comments/113128067","pull_request_review_id":34490783,"id":113128067,"diff_hunk":"@@ -246,7 +251,8 @@ class UDisksTestCase(unittest.TestCase):\n         If cd is True, return the CD device, otherwise the hard disk device.\n         \"\"\"\n         block = klass.udisks_block(partition, cd)\n-        return klass.client.get_object(block.get_object_path()).get_filesystem()\n+        return klass.client.get_object(\n+            block.get_object_path()).get_filesystem()","path":"src/tests/integration-test","position":null,"original_position":62,"commit_id":"b9efce3008bac7fb255969caf47a90ae5880110f","original_commit_id":"a921dd0f756637509b82e230709fec59d44ff416","user":{"login":"vpodzime","id":1044278,"avatar_url":"https://avatars2.githubusercontent.com/u/1044278?v=3","gravatar_id":"","url":"https://api.github.com/users/vpodzime","html_url":"https://github.com/vpodzime","followers_url":"https://api.github.com/users/vpodzime/followers","following_url":"https://api.github.com/users/vpodzime/following{/other_user}","gists_url":"https://api.github.com/users/vpodzime/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodzime/subscriptions","organizations_url":"https://api.github.com/users/vpodzime/orgs","repos_url":"https://api.github.com/users/vpodzime/repos","events_url":"https://api.github.com/users/vpodzime/events{/privacy}","received_events_url":"https://api.github.com/users/vpodzime/received_events","type":"User","site_admin":false},"body":"Sure, but all those tools have ways to disable specific checks/errors/warnings. PEP is not a standard, the PEP 8 is titled as *Style Guide for Python Code*. Good, a nice guide. But that doesn't mean we have to do exactly as it says. Don't take me wrong, I was the one who started pushing PEP 8 and PEP 257 in Anaconda and Blivet some time ago I know they make things much better. But the 7**2**-characters-per-line is just nonsense these days. And the guide even mentions this:\r\n\r\n> Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the nominal line length from 80 to 100 characters (effectively increasing the maximum length to 99 characters), provided that comments and docstrings are still wrapped at 72 characters.\r\n\r\nAs for tests being as good as the code -- sure, let's start with the code then, it's much worse than our tests.","created_at":"2017-04-25T07:56:22Z","updated_at":"2017-04-25T07:56:22Z","html_url":"https://github.com/storaged-project/udisks/pull/240#discussion_r113128067","pull_request_url":"https://api.github.com/repos/storaged-project/udisks/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/comments/113128067"},"html":{"href":"https://github.com/storaged-project/udisks/pull/240#discussion_r113128067"},"pull_request":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/storaged-project/udisks/pulls/240","id":115857197,"html_url":"https://github.com/storaged-project/udisks/pull/240","diff_url":"https://github.com/storaged-project/udisks/pull/240.diff","patch_url":"https://github.com/storaged-project/udisks/pull/240.patch","issue_url":"https://api.github.com/repos/storaged-project/udisks/issues/240","number":240,"state":"open","locked":false,"title":"Misc test fixes","user":{"login":"tasleson","id":2520480,"avatar_url":"https://avatars1.githubusercontent.com/u/2520480?v=3","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"body":"The root of all my local problems was caused because I was **missing the udev rules file**!  This PR adds code to copy that over too in the CI `run_tests.py` code.  It also adds code to remove the files that we copied over if no files existed before, so that we leave the system in the same state.  The actual unlink is commented out right now as the `intergration-test` doesn't do this copying.  I will work on moving this setup/teardown into a separate library so that we can share it across different tests cases.\r\n\r\nNote: I also re-factored the copy code into one common function.","created_at":"2017-04-13T22:42:24Z","updated_at":"2017-04-25T07:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7ffc14817561b82bb737a82155ed68cd2eea759","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/storaged-project/udisks/pulls/240/commits","review_comments_url":"https://api.github.com/repos/storaged-project/udisks/pulls/240/comments","review_comment_url":"https://api.github.com/repos/storaged-project/udisks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storaged-project/udisks/issues/240/comments","statuses_url":"https://api.github.com/repos/storaged-project/udisks/statuses/b9efce3008bac7fb255969caf47a90ae5880110f","head":{"label":"tasleson:misc_test_fixes","ref":"misc_test_fixes","sha":"b9efce3008bac7fb255969caf47a90ae5880110f","user":{"login":"tasleson","id":2520480,"avatar_url":"https://avatars1.githubusercontent.com/u/2520480?v=3","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"repo":{"id":69982489,"name":"udisks","full_name":"tasleson/udisks","owner":{"login":"tasleson","id":2520480,"avatar_url":"https://avatars1.githubusercontent.com/u/2520480?v=3","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tasleson/udisks","description":"The Storaged project provides a daemon, tools and libraries to access and manipulate disks, storage devices and technologies.","fork":true,"url":"https://api.github.com/repos/tasleson/udisks","forks_url":"https://api.github.com/repos/tasleson/udisks/forks","keys_url":"https://api.github.com/repos/tasleson/udisks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tasleson/udisks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tasleson/udisks/teams","hooks_url":"https://api.github.com/repos/tasleson/udisks/hooks","issue_events_url":"https://api.github.com/repos/tasleson/udisks/issues/events{/number}","events_url":"https://api.github.com/repos/tasleson/udisks/events","assignees_url":"https://api.github.com/repos/tasleson/udisks/assignees{/user}","branches_url":"https://api.github.com/repos/tasleson/udisks/branches{/branch}","tags_url":"https://api.github.com/repos/tasleson/udisks/tags","blobs_url":"https://api.github.com/repos/tasleson/udisks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tasleson/udisks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tasleson/udisks/git/refs{/sha}","trees_url":"https://api.github.com/repos/tasleson/udisks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tasleson/udisks/statuses/{sha}","languages_url":"https://api.github.com/repos/tasleson/udisks/languages","stargazers_url":"https://api.github.com/repos/tasleson/udisks/stargazers","contributors_url":"https://api.github.com/repos/tasleson/udisks/contributors","subscribers_url":"https://api.github.com/repos/tasleson/udisks/subscribers","subscription_url":"https://api.github.com/repos/tasleson/udisks/subscription","commits_url":"https://api.github.com/repos/tasleson/udisks/commits{/sha}","git_commits_url":"https://api.github.com/repos/tasleson/udisks/git/commits{/sha}","comments_url":"https://api.github.com/repos/tasleson/udisks/comments{/number}","issue_comment_url":"https://api.github.com/repos/tasleson/udisks/issues/comments{/number}","contents_url":"https://api.github.com/repos/tasleson/udisks/contents/{+path}","compare_url":"https://api.github.com/repos/tasleson/udisks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tasleson/udisks/merges","archive_url":"https://api.github.com/repos/tasleson/udisks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tasleson/udisks/downloads","issues_url":"https://api.github.com/repos/tasleson/udisks/issues{/number}","pulls_url":"https://api.github.com/repos/tasleson/udisks/pulls{/number}","milestones_url":"https://api.github.com/repos/tasleson/udisks/milestones{/number}","notifications_url":"https://api.github.com/repos/tasleson/udisks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tasleson/udisks/labels{/name}","releases_url":"https://api.github.com/repos/tasleson/udisks/releases{/id}","deployments_url":"https://api.github.com/repos/tasleson/udisks/deployments","created_at":"2016-10-04T16:08:50Z","updated_at":"2017-03-29T20:18:05Z","pushed_at":"2017-04-24T12:43:53Z","git_url":"git://github.com/tasleson/udisks.git","ssh_url":"git@github.com:tasleson/udisks.git","clone_url":"https://github.com/tasleson/udisks.git","svn_url":"https://github.com/tasleson/udisks","homepage":"","size":6333,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"storaged-project:master-libblockdev","ref":"master-libblockdev","sha":"2a4576d1a478aec133007425f373690cb7f19da3","user":{"login":"storaged-project","id":11505466,"avatar_url":"https://avatars2.githubusercontent.com/u/11505466?v=3","gravatar_id":"","url":"https://api.github.com/users/storaged-project","html_url":"https://github.com/storaged-project","followers_url":"https://api.github.com/users/storaged-project/followers","following_url":"https://api.github.com/users/storaged-project/following{/other_user}","gists_url":"https://api.github.com/users/storaged-project/gists{/gist_id}","starred_url":"https://api.github.com/users/storaged-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storaged-project/subscriptions","organizations_url":"https://api.github.com/users/storaged-project/orgs","repos_url":"https://api.github.com/users/storaged-project/repos","events_url":"https://api.github.com/users/storaged-project/events{/privacy}","received_events_url":"https://api.github.com/users/storaged-project/received_events","type":"Organization","site_admin":false},"repo":{"id":31362286,"name":"udisks","full_name":"storaged-project/udisks","owner":{"login":"storaged-project","id":11505466,"avatar_url":"https://avatars2.githubusercontent.com/u/11505466?v=3","gravatar_id":"","url":"https://api.github.com/users/storaged-project","html_url":"https://github.com/storaged-project","followers_url":"https://api.github.com/users/storaged-project/followers","following_url":"https://api.github.com/users/storaged-project/following{/other_user}","gists_url":"https://api.github.com/users/storaged-project/gists{/gist_id}","starred_url":"https://api.github.com/users/storaged-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storaged-project/subscriptions","organizations_url":"https://api.github.com/users/storaged-project/orgs","repos_url":"https://api.github.com/users/storaged-project/repos","events_url":"https://api.github.com/users/storaged-project/events{/privacy}","received_events_url":"https://api.github.com/users/storaged-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storaged-project/udisks","description":"The Storaged project provides a daemon, tools and libraries to access and manipulate disks, storage devices and technologies.","fork":false,"url":"https://api.github.com/repos/storaged-project/udisks","forks_url":"https://api.github.com/repos/storaged-project/udisks/forks","keys_url":"https://api.github.com/repos/storaged-project/udisks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storaged-project/udisks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storaged-project/udisks/teams","hooks_url":"https://api.github.com/repos/storaged-project/udisks/hooks","issue_events_url":"https://api.github.com/repos/storaged-project/udisks/issues/events{/number}","events_url":"https://api.github.com/repos/storaged-project/udisks/events","assignees_url":"https://api.github.com/repos/storaged-project/udisks/assignees{/user}","branches_url":"https://api.github.com/repos/storaged-project/udisks/branches{/branch}","tags_url":"https://api.github.com/repos/storaged-project/udisks/tags","blobs_url":"https://api.github.com/repos/storaged-project/udisks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storaged-project/udisks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storaged-project/udisks/git/refs{/sha}","trees_url":"https://api.github.com/repos/storaged-project/udisks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storaged-project/udisks/statuses/{sha}","languages_url":"https://api.github.com/repos/storaged-project/udisks/languages","stargazers_url":"https://api.github.com/repos/storaged-project/udisks/stargazers","contributors_url":"https://api.github.com/repos/storaged-project/udisks/contributors","subscribers_url":"https://api.github.com/repos/storaged-project/udisks/subscribers","subscription_url":"https://api.github.com/repos/storaged-project/udisks/subscription","commits_url":"https://api.github.com/repos/storaged-project/udisks/commits{/sha}","git_commits_url":"https://api.github.com/repos/storaged-project/udisks/git/commits{/sha}","comments_url":"https://api.github.com/repos/storaged-project/udisks/comments{/number}","issue_comment_url":"https://api.github.com/repos/storaged-project/udisks/issues/comments{/number}","contents_url":"https://api.github.com/repos/storaged-project/udisks/contents/{+path}","compare_url":"https://api.github.com/repos/storaged-project/udisks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storaged-project/udisks/merges","archive_url":"https://api.github.com/repos/storaged-project/udisks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storaged-project/udisks/downloads","issues_url":"https://api.github.com/repos/storaged-project/udisks/issues{/number}","pulls_url":"https://api.github.com/repos/storaged-project/udisks/pulls{/number}","milestones_url":"https://api.github.com/repos/storaged-project/udisks/milestones{/number}","notifications_url":"https://api.github.com/repos/storaged-project/udisks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storaged-project/udisks/labels{/name}","releases_url":"https://api.github.com/repos/storaged-project/udisks/releases{/id}","deployments_url":"https://api.github.com/repos/storaged-project/udisks/deployments","created_at":"2015-02-26T10:34:18Z","updated_at":"2017-04-22T18:35:17Z","pushed_at":"2017-04-24T12:43:55Z","git_url":"git://github.com/storaged-project/udisks.git","ssh_url":"git@github.com:storaged-project/udisks.git","clone_url":"https://github.com/storaged-project/udisks.git","svn_url":"https://github.com/storaged-project/udisks","homepage":"","size":6310,"stargazers_count":38,"watchers_count":38,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":36,"forks":24,"open_issues":36,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/240"},"html":{"href":"https://github.com/storaged-project/udisks/pull/240"},"issue":{"href":"https://api.github.com/repos/storaged-project/udisks/issues/240"},"comments":{"href":"https://api.github.com/repos/storaged-project/udisks/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storaged-project/udisks/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/storaged-project/udisks/statuses/b9efce3008bac7fb255969caf47a90ae5880110f"}}}}
{"actor":{"display_login":"vpodzime"}}