{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4628","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4628/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4628/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4628/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4628","id":284633393,"number":4628,"title":"Adjust vanilla advancements to consider ore dictionary entries","user":{"login":"SirWindfield","id":5113257,"avatar_url":"https://avatars1.githubusercontent.com/u/5113257?v=4","gravatar_id":"","url":"https://api.github.com/users/SirWindfield","html_url":"https://github.com/SirWindfield","followers_url":"https://api.github.com/users/SirWindfield/followers","following_url":"https://api.github.com/users/SirWindfield/following{/other_user}","gists_url":"https://api.github.com/users/SirWindfield/gists{/gist_id}","starred_url":"https://api.github.com/users/SirWindfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirWindfield/subscriptions","organizations_url":"https://api.github.com/users/SirWindfield/orgs","repos_url":"https://api.github.com/users/SirWindfield/repos","events_url":"https://api.github.com/users/SirWindfield/events{/privacy}","received_events_url":"https://api.github.com/users/SirWindfield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-27T02:01:13Z","updated_at":"2017-12-27T21:47:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4628","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4628","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4628.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4628.patch"},"body":"This PR overwrites some Vanilla advancements so that the ore dictionary entries are used for speicifc criteria. Currently the following advancements have been modified (devided by category):\r\nThis will resolve #4341.\r\n\r\n## Changes made\r\n### Combat\r\n- Wooden Sword. Now uses `stickWood` instead of `stick`.\r\n### Decorations\r\n- Crafting Table. Now uses `plankWood` instead of `planks`.\r\n- Ladder. Now uses `stickWood` instead of `stick`.\r\n- Sign. Now uses `plankWood` instead of `planks`.\r\n### Misc\r\n- Stick. Now uses `plankWood` instead of `planks`.\r\n### Redstone\r\n- Trapdoor. Now uses `plankWood` instead of `planks`.\r\n- Wooden Button. Now uses `plankWood` instead of `planks`.\r\n- Wooden Pressure Plate. Now uses `plankWood` instead of `planks`.\r\n### Tools\r\n- Wooden Axe. Now uses `stickWood` instead of `stick`.\r\n- Wooden Hoe. Now uses `stickWood` instead of `stick`.\r\n- Wooden Pickaxe. Now uses `stickWood` instead of `stick`.\r\n- Wooden Shovel. Now uses `stickWood` instead of `stick`.\r\n\r\n\r\nI have found some other advancements that I didn't want to change before discussing them here:\r\n\r\n\r\n## Potential Changes\r\n### Brewing\r\n- Glass Bottle. Uses `glass` as condition. Not sure if it is a good idea to change this to the ore dictionary entry for `glass panes`.\r\n- Golden Carrot. Uses `gold_nugget` as condition. Might consider using `nuggetGold`. But to be honest, I do not know any mod that lets you craft the carrot with other gold ingots except vanilla ones. \r\n### Decorations\r\n- Glass Pane. Uses `glass`. Changing the condition to use the ore dictionary entry might be a good idea (`blockGlass`). This would trigger the advancement if the player mines/finds colored glass too.\r\n### Misc\r\n- Beacon. Uses `nether_star`. The nether star has an ore dictionary entry called `netherStar`. Maybe use this one...?\r\n- Book. Uses `paper`. Paper has an ore dictionary named `paper`. Not sure if other mods allow book crafting with custom paper but I think this change would be good. \r\n### Redstone\r\n- Wooden Door. Is this the default oak wood door? Not sure though. The metadata looks to be zero though.\r\n\r\n\r\nIf you want an entry change for the above items listed under the potential changes category, just make annotation in the corresponding source file that I pushed to the branch. I'll update them accordingly. \r\nIf I missed an advancement, let me know. I'll add it to the repo then."},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/354182523","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4628#issuecomment-354182523","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4628","id":354182523,"user":{"login":"SirWindfield","id":5113257,"avatar_url":"https://avatars1.githubusercontent.com/u/5113257?v=4","gravatar_id":"","url":"https://api.github.com/users/SirWindfield","html_url":"https://github.com/SirWindfield","followers_url":"https://api.github.com/users/SirWindfield/followers","following_url":"https://api.github.com/users/SirWindfield/following{/other_user}","gists_url":"https://api.github.com/users/SirWindfield/gists{/gist_id}","starred_url":"https://api.github.com/users/SirWindfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirWindfield/subscriptions","organizations_url":"https://api.github.com/users/SirWindfield/orgs","repos_url":"https://api.github.com/users/SirWindfield/repos","events_url":"https://api.github.com/users/SirWindfield/events{/privacy}","received_events_url":"https://api.github.com/users/SirWindfield/received_events","type":"User","site_admin":false},"created_at":"2017-12-27T21:47:50Z","updated_at":"2017-12-27T21:47:50Z","author_association":"NONE","body":"@liach Are there already hooks for that? Or would I need to aptch files accordingly?"}}
{"actor":{"display_login":"SirWindfield"}}