{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/widgets/pulls/comments/130397690","pull_request_review_id":53268340,"id":130397690,"diff_hunk":"@@ -109,10 +109,13 @@ export default class Slider extends SliderBase<SliderProperties> {\n \t\t\tvertical = false,\n \t\t\tverticalHeight = '200px'\n \t\t} = this.properties;\n-\t\tconst {\n+\t\tlet {\n \t\t\tvalue = min\n \t\t} = this.properties;\n \n+\t\tvalue = value > max ? max : value;\n+\t\tvalue = value < min ? min : value;","path":"src/slider/Slider.ts","position":10,"original_position":10,"commit_id":"d223e322ac6fec7c5bed40ba5a29002117d8bc18","original_commit_id":"7644459ff4df0da96d82d8ab5ea958860de7c94a","user":{"login":"smhigley","id":3819570,"avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"body":"cool :)","created_at":"2017-07-31T16:13:50Z","updated_at":"2017-07-31T16:13:50Z","html_url":"https://github.com/dojo/widgets/pull/262#discussion_r130397690","pull_request_url":"https://api.github.com/repos/dojo/widgets/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments/130397690"},"html":{"href":"https://github.com/dojo/widgets/pull/262#discussion_r130397690"},"pull_request":{"href":"https://api.github.com/repos/dojo/widgets/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/262","id":131844223,"html_url":"https://github.com/dojo/widgets/pull/262","diff_url":"https://github.com/dojo/widgets/pull/262.diff","patch_url":"https://github.com/dojo/widgets/pull/262.patch","issue_url":"https://api.github.com/repos/dojo/widgets/issues/262","number":262,"state":"closed","locked":false,"title":"Slider: min / max value fix","user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars1.githubusercontent.com/u/334586?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"body":"**Type:** bug\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [x] There is a related issue\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [x] Unit or Functional tests are included in the PR\r\n\r\n**Description:**\r\n\r\nThis PR updates the Slider component so it never renders a value higher than its `max` or lower than its `min`.\r\n\r\nResolves #259 \r\n","created_at":"2017-07-21T19:37:37Z","updated_at":"2017-07-31T16:13:50Z","closed_at":"2017-07-31T14:14:57Z","merged_at":"2017-07-31T14:14:56Z","merge_commit_sha":"c1d56aaf46854a55f6efbfeaa42abf712e1defc7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/dojo/widgets/milestones/8","html_url":"https://github.com/dojo/widgets/milestone/8","labels_url":"https://api.github.com/repos/dojo/widgets/milestones/8/labels","id":2565748,"number":8,"title":"2017.07","description":"","creator":{"login":"eheasley","id":7253801,"avatar_url":"https://avatars2.githubusercontent.com/u/7253801?v=4","gravatar_id":"","url":"https://api.github.com/users/eheasley","html_url":"https://github.com/eheasley","followers_url":"https://api.github.com/users/eheasley/followers","following_url":"https://api.github.com/users/eheasley/following{/other_user}","gists_url":"https://api.github.com/users/eheasley/gists{/gist_id}","starred_url":"https://api.github.com/users/eheasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eheasley/subscriptions","organizations_url":"https://api.github.com/users/eheasley/orgs","repos_url":"https://api.github.com/users/eheasley/repos","events_url":"https://api.github.com/users/eheasley/events{/privacy}","received_events_url":"https://api.github.com/users/eheasley/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":8,"state":"open","created_at":"2017-06-06T17:35:21Z","updated_at":"2017-07-31T14:14:57Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dojo/widgets/pulls/262/commits","review_comments_url":"https://api.github.com/repos/dojo/widgets/pulls/262/comments","review_comment_url":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/262/comments","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/d223e322ac6fec7c5bed40ba5a29002117d8bc18","head":{"label":"bitpshr:slider-min-max","ref":"slider-min-max","sha":"d223e322ac6fec7c5bed40ba5a29002117d8bc18","user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars1.githubusercontent.com/u/334586?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"repo":{"id":79915374,"name":"widgets","full_name":"bitpshr/widgets","owner":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars1.githubusercontent.com/u/334586?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitpshr/widgets","description":"🚀 UI components for dojo2.","fork":true,"url":"https://api.github.com/repos/bitpshr/widgets","forks_url":"https://api.github.com/repos/bitpshr/widgets/forks","keys_url":"https://api.github.com/repos/bitpshr/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpshr/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpshr/widgets/teams","hooks_url":"https://api.github.com/repos/bitpshr/widgets/hooks","issue_events_url":"https://api.github.com/repos/bitpshr/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/bitpshr/widgets/events","assignees_url":"https://api.github.com/repos/bitpshr/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/bitpshr/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/bitpshr/widgets/tags","blobs_url":"https://api.github.com/repos/bitpshr/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpshr/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpshr/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpshr/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpshr/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpshr/widgets/languages","stargazers_url":"https://api.github.com/repos/bitpshr/widgets/stargazers","contributors_url":"https://api.github.com/repos/bitpshr/widgets/contributors","subscribers_url":"https://api.github.com/repos/bitpshr/widgets/subscribers","subscription_url":"https://api.github.com/repos/bitpshr/widgets/subscription","commits_url":"https://api.github.com/repos/bitpshr/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpshr/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpshr/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpshr/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitpshr/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/bitpshr/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpshr/widgets/merges","archive_url":"https://api.github.com/repos/bitpshr/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpshr/widgets/downloads","issues_url":"https://api.github.com/repos/bitpshr/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/bitpshr/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpshr/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpshr/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpshr/widgets/labels{/name}","releases_url":"https://api.github.com/repos/bitpshr/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/bitpshr/widgets/deployments","created_at":"2017-01-24T13:47:18Z","updated_at":"2017-03-26T16:29:24Z","pushed_at":"2017-07-31T16:12:07Z","git_url":"git://github.com/bitpshr/widgets.git","ssh_url":"git@github.com:bitpshr/widgets.git","clone_url":"https://github.com/bitpshr/widgets.git","svn_url":"https://github.com/bitpshr/widgets","homepage":"","size":501,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"551a3fd4d7999308cb5063dcad0400a584a045cb","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":79911519,"name":"widgets","full_name":"dojo/widgets","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/widgets","description":":rocket: Dojo 2 - UI components.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2017-01-24T12:55:57Z","updated_at":"2017-07-19T13:43:52Z","pushed_at":"2017-07-31T16:12:05Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"http://dojo.io","size":434,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":62,"forks":16,"open_issues":62,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/262"},"html":{"href":"https://github.com/dojo/widgets/pull/262"},"issue":{"href":"https://api.github.com/repos/dojo/widgets/issues/262"},"comments":{"href":"https://api.github.com/repos/dojo/widgets/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/widgets/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/widgets/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/widgets/statuses/d223e322ac6fec7c5bed40ba5a29002117d8bc18"}}}}
{"actor":{"display_login":"smhigley"}}