{"action":"created","issue":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001","repository_url":"https://api.github.com/repos/Minecolonies/minecolonies","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001/labels{/name}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001/comments","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001/events","html_url":"https://github.com/Minecolonies/minecolonies/pull/1001","id":228815009,"number":1001,"title":"The request System. Or as it is commonly known the DMan 2.0","user":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"labels":[{"id":424306405,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/discussion","name":"discussion","color":"aa9900","default":false},{"id":424242649,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":424279215,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/in%20progress","name":"in progress","color":"fbca04","default":false},{"id":452814636,"url":"https://api.github.com/repos/Minecolonies/minecolonies/labels/not%20ready","name":"not ready","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"assignees":[{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-05-15T19:14:51Z","updated_at":"2017-06-22T21:36:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001","html_url":"https://github.com/Minecolonies/minecolonies/pull/1001","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1001.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1001.patch"},"body":"This is a discussion PR.\r\n\r\nIst main goal is to get Input on the design of the new System.\r\nAs you all can see it is heavily Interface and factory based.\r\n\r\nThe principle follows an Inversion of Control pattern that makes the IRequestManager the heart of the System. Outside of him no IRequests are known, just Tokens and These Tokens are passed around.\r\n\r\nIf you request a IRequest from the Manager you will get a defensive copy to make sure that you cannot tamper with its state directly.\r\n\r\nRequestResolvers are the workers in this System. A resolver basicly tells the Handler what to do. And how to proceed.\r\n\r\nPlease feel free to ask me anything regarding the new System.\r\n"},"comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments/310509524","html_url":"https://github.com/Minecolonies/minecolonies/pull/1001#issuecomment-310509524","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001","id":310509524,"user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T21:36:01Z","updated_at":"2017-06-22T21:36:01Z","body":"\n![Codacy](https://www.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nIssues\n======\n+ Solved 6\n- Added 314\n           \n\nComplexity increasing per file\n==============================\n- src/main/java/com/minecolonies/coremod/colony/ColonyView.java  11\n- src/main/java/com/minecolonies/coremod/colony/CitizenDataView.java  3\n- src/main/java/com/minecolonies/coremod/proxy/CommonProxy.java  1\n- src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java  36\n         \n\nComplexity decreasing per file\n==============================\n+ src/main/java/com/minecolonies/coremod/colony/buildings/BuildingWareHouse.java  -1\n+ src/main/java/com/minecolonies/coremod/client/render/RenderBipedCitizen.java  -1\n+ src/main/java/com/minecolonies/coremod/colony/permissions/Permissions.java  -5\n+ src/main/java/com/minecolonies/coremod/permissions/ColonyPermissionEventHandler.java  -1\n+ src/main/java/com/minecolonies/coremod/colony/CitizenData.java  -2\n+ src/main/java/com/minecolonies/coremod/util/EntityUtils.java  -1\n         \n```\n\n\nSee the complete overview on [Codacy](https://www.codacy.com/app/Minecolonies/minecolonies/pullRequest?prid=662390&bid=4609854)\n        "}}
{"actor":{"display_login":"codacy-bot"}}