{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11043","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11043/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11043/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11043/events","html_url":"https://github.com/bitcoin/bitcoin/pull/11043","id":250052271,"number":11043,"title":"Use std::unique_ptr (C++11) where possible","user":{"login":"practicalswift","id":7826565,"avatar_url":"https://avatars3.githubusercontent.com/u/7826565?v=4","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"labels":[{"id":135961,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-14T14:42:23Z","updated_at":"2017-08-15T07:56:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11043","html_url":"https://github.com/bitcoin/bitcoin/pull/11043","diff_url":"https://github.com/bitcoin/bitcoin/pull/11043.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11043.patch"},"body":"Use `std::unique_ptr` (C++11) where possible.\r\n\r\nRationale:\r\n1. Avoid resource leaks (specifically: forgetting to `delete` an object created using `new`)\r\n2. Avoid undefined behaviour (specifically: double `delete`:s)\r\n\r\n**Note to reviewers:** Please let me know if I've missed any obvious `std::unique_ptr` candidates. Hopefully this PR should cover all the trivial cases.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/322402435","html_url":"https://github.com/bitcoin/bitcoin/pull/11043#issuecomment-322402435","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11043","id":322402435,"user":{"login":"bytting","id":1276717,"avatar_url":"https://avatars3.githubusercontent.com/u/1276717?v=4","gravatar_id":"","url":"https://api.github.com/users/bytting","html_url":"https://github.com/bytting","followers_url":"https://api.github.com/users/bytting/followers","following_url":"https://api.github.com/users/bytting/following{/other_user}","gists_url":"https://api.github.com/users/bytting/gists{/gist_id}","starred_url":"https://api.github.com/users/bytting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytting/subscriptions","organizations_url":"https://api.github.com/users/bytting/orgs","repos_url":"https://api.github.com/users/bytting/repos","events_url":"https://api.github.com/users/bytting/events{/privacy}","received_events_url":"https://api.github.com/users/bytting/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T07:56:41Z","updated_at":"2017-08-15T07:56:41Z","body":"@ryanovsky Didn't you declare MakeUnique somewhere else already?\r\n\r\nI like this patch, and encourage anyone who wants more meat on the bone to read Sutter's Mill articles about smart pointers\r\n\r\nhttps://herbsutter.com/gotw/\r\n"}}
{"actor":{"display_login":"bytting"}}