{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/133679877","pull_request_review_id":56887557,"id":133679877,"diff_hunk":"@@ -595,10 +595,10 @@ void ReplicatedBackend::op_applied(\n   if (op->waiting_for_applied.empty()) {\n     op->on_applied->complete(0);\n     op->on_applied = 0;\n-  }\n-  if (op->done()) {\n-    assert(!op->on_commit && !op->on_applied);\n-    in_progress_ops.erase(op->tid);\n+    if (op->waiting_for_commit.empty()) {","path":"src/osd/ReplicatedBackend.cc","position":8,"original_position":8,"commit_id":"b8e70c4761be3775fddb3f745707ccc6a655816f","original_commit_id":"b8e70c4761be3775fddb3f745707ccc6a655816f","user":{"login":"amitkumar50","id":23084104,"avatar_url":"https://avatars0.githubusercontent.com/u/23084104?v=4","gravatar_id":"","url":"https://api.github.com/users/amitkumar50","html_url":"https://github.com/amitkumar50","followers_url":"https://api.github.com/users/amitkumar50/followers","following_url":"https://api.github.com/users/amitkumar50/following{/other_user}","gists_url":"https://api.github.com/users/amitkumar50/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkumar50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkumar50/subscriptions","organizations_url":"https://api.github.com/users/amitkumar50/orgs","repos_url":"https://api.github.com/users/amitkumar50/repos","events_url":"https://api.github.com/users/amitkumar50/events{/privacy}","received_events_url":"https://api.github.com/users/amitkumar50/received_events","type":"User","site_admin":false},"body":"@majianpeng tabs left","created_at":"2017-08-17T10:46:55Z","updated_at":"2017-08-17T10:47:01Z","html_url":"https://github.com/ceph/ceph/pull/13989#discussion_r133679877","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/13989","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/133679877"},"html":{"href":"https://github.com/ceph/ceph/pull/13989#discussion_r133679877"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13989"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/13989","id":110984076,"html_url":"https://github.com/ceph/ceph/pull/13989","diff_url":"https://github.com/ceph/ceph/pull/13989.diff","patch_url":"https://github.com/ceph/ceph/pull/13989.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/13989","number":13989,"state":"open","locked":false,"title":"ASAP call oncommit callback function to make OSDOpReply firstly reply.","user":{"login":"majianpeng","id":1230551,"avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"body":"Make op_commit->complete ASAP be called because callback of op_commit send reply to client.","created_at":"2017-03-16T02:57:00Z","updated_at":"2017-08-17T10:47:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f45b6e37695740e900050ebd8f373dd054bcdd0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/13989/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/13989/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/13989/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/b8e70c4761be3775fddb3f745707ccc6a655816f","head":{"label":"majianpeng:op-commit-first-call","ref":"op-commit-first-call","sha":"b8e70c4761be3775fddb3f745707ccc6a655816f","user":{"login":"majianpeng","id":1230551,"avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"repo":{"id":22190447,"name":"ceph","full_name":"majianpeng/ceph","owner":{"login":"majianpeng","id":1230551,"avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majianpeng/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/majianpeng/ceph","forks_url":"https://api.github.com/repos/majianpeng/ceph/forks","keys_url":"https://api.github.com/repos/majianpeng/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majianpeng/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majianpeng/ceph/teams","hooks_url":"https://api.github.com/repos/majianpeng/ceph/hooks","issue_events_url":"https://api.github.com/repos/majianpeng/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/majianpeng/ceph/events","assignees_url":"https://api.github.com/repos/majianpeng/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/majianpeng/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/majianpeng/ceph/tags","blobs_url":"https://api.github.com/repos/majianpeng/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majianpeng/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majianpeng/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/majianpeng/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majianpeng/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/majianpeng/ceph/languages","stargazers_url":"https://api.github.com/repos/majianpeng/ceph/stargazers","contributors_url":"https://api.github.com/repos/majianpeng/ceph/contributors","subscribers_url":"https://api.github.com/repos/majianpeng/ceph/subscribers","subscription_url":"https://api.github.com/repos/majianpeng/ceph/subscription","commits_url":"https://api.github.com/repos/majianpeng/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/majianpeng/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/majianpeng/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/majianpeng/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/majianpeng/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/majianpeng/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majianpeng/ceph/merges","archive_url":"https://api.github.com/repos/majianpeng/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majianpeng/ceph/downloads","issues_url":"https://api.github.com/repos/majianpeng/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/majianpeng/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/majianpeng/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/majianpeng/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majianpeng/ceph/labels{/name}","releases_url":"https://api.github.com/repos/majianpeng/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/majianpeng/ceph/deployments","created_at":"2014-07-24T01:10:00Z","updated_at":"2016-01-20T02:28:28Z","pushed_at":"2017-08-15T13:13:45Z","git_url":"git://github.com/majianpeng/ceph.git","ssh_url":"git@github.com:majianpeng/ceph.git","clone_url":"https://github.com/majianpeng/ceph.git","svn_url":"https://github.com/majianpeng/ceph","homepage":"http://ceph.com","size":222212,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"84d57eb007ff34b235ad6fccc3e1893abad4f6e0","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-08-17T04:03:37Z","pushed_at":"2017-08-17T10:17:16Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":236604,"stargazers_count":3517,"watchers_count":3517,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2046,"mirror_url":null,"open_issues_count":524,"forks":2046,"open_issues":524,"watchers":3517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13989"},"html":{"href":"https://github.com/ceph/ceph/pull/13989"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/13989"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/13989/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13989/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13989/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/b8e70c4761be3775fddb3f745707ccc6a655816f"}}}}
{"actor":{"display_login":"amitkumar50"}}