{"action":"created","comment":{"url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/comments/130123683","pull_request_review_id":52968769,"id":130123683,"diff_hunk":"@@ -107,6 +107,30 @@ To benchmark the current code against a git hash, branch, ...\n npm run benchmark:compare 53fa9a62214e816cf8b5b4fa291c38f1d63677b9\n ```\n \n+### Gotchas\n+\n+#### Spread arguments\n+\n+We check for `function.lenght` to get upfront the expected number of arguments in order to use","path":"README.md","position":8,"original_position":8,"commit_id":"20388df44dda3f9b74dcb4a9b381b283ed375830","original_commit_id":"20388df44dda3f9b74dcb4a9b381b283ed375830","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":"Typo: `length`","created_at":"2017-07-28T15:51:50Z","updated_at":"2017-07-28T15:52:45Z","html_url":"https://github.com/caiogondim/fast-memoize.js/pull/61#discussion_r130123683","pull_request_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/comments/130123683"},"html":{"href":"https://github.com/caiogondim/fast-memoize.js/pull/61#discussion_r130123683"},"pull_request":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61","id":132997236,"html_url":"https://github.com/caiogondim/fast-memoize.js/pull/61","diff_url":"https://github.com/caiogondim/fast-memoize.js/pull/61.diff","patch_url":"https://github.com/caiogondim/fast-memoize.js/pull/61.patch","issue_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/61","number":61,"state":"open","locked":false,"title":"Spread arguments fix","user":{"login":"caiogondim","id":33044,"avatar_url":"https://avatars2.githubusercontent.com/u/33044?v=4","gravatar_id":"","url":"https://api.github.com/users/caiogondim","html_url":"https://github.com/caiogondim","followers_url":"https://api.github.com/users/caiogondim/followers","following_url":"https://api.github.com/users/caiogondim/following{/other_user}","gists_url":"https://api.github.com/users/caiogondim/gists{/gist_id}","starred_url":"https://api.github.com/users/caiogondim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiogondim/subscriptions","organizations_url":"https://api.github.com/users/caiogondim/orgs","repos_url":"https://api.github.com/users/caiogondim/repos","events_url":"https://api.github.com/users/caiogondim/events{/privacy}","received_events_url":"https://api.github.com/users/caiogondim/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-28T15:43:42Z","updated_at":"2017-07-28T15:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f02b76acd77f29feb8563551fbb4b4a980a61f37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61/commits","review_comments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61/comments","review_comment_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/61/comments","statuses_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/statuses/20388df44dda3f9b74dcb4a9b381b283ed375830","head":{"label":"caiogondim:spread-arguments-fix","ref":"spread-arguments-fix","sha":"20388df44dda3f9b74dcb4a9b381b283ed375830","user":{"login":"caiogondim","id":33044,"avatar_url":"https://avatars2.githubusercontent.com/u/33044?v=4","gravatar_id":"","url":"https://api.github.com/users/caiogondim","html_url":"https://github.com/caiogondim","followers_url":"https://api.github.com/users/caiogondim/followers","following_url":"https://api.github.com/users/caiogondim/following{/other_user}","gists_url":"https://api.github.com/users/caiogondim/gists{/gist_id}","starred_url":"https://api.github.com/users/caiogondim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiogondim/subscriptions","organizations_url":"https://api.github.com/users/caiogondim/orgs","repos_url":"https://api.github.com/users/caiogondim/repos","events_url":"https://api.github.com/users/caiogondim/events{/privacy}","received_events_url":"https://api.github.com/users/caiogondim/received_events","type":"User","site_admin":false},"repo":{"id":49277709,"name":"fast-memoize.js","full_name":"caiogondim/fast-memoize.js","owner":{"login":"caiogondim","id":33044,"avatar_url":"https://avatars2.githubusercontent.com/u/33044?v=4","gravatar_id":"","url":"https://api.github.com/users/caiogondim","html_url":"https://github.com/caiogondim","followers_url":"https://api.github.com/users/caiogondim/followers","following_url":"https://api.github.com/users/caiogondim/following{/other_user}","gists_url":"https://api.github.com/users/caiogondim/gists{/gist_id}","starred_url":"https://api.github.com/users/caiogondim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiogondim/subscriptions","organizations_url":"https://api.github.com/users/caiogondim/orgs","repos_url":"https://api.github.com/users/caiogondim/repos","events_url":"https://api.github.com/users/caiogondim/events{/privacy}","received_events_url":"https://api.github.com/users/caiogondim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caiogondim/fast-memoize.js","description":":rabbit2: Fastest possible memoization library","fork":false,"url":"https://api.github.com/repos/caiogondim/fast-memoize.js","forks_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/forks","keys_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/teams","hooks_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/hooks","issue_events_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/events{/number}","events_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/events","assignees_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/assignees{/user}","branches_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/branches{/branch}","tags_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/tags","blobs_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/statuses/{sha}","languages_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/languages","stargazers_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/stargazers","contributors_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/contributors","subscribers_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/subscribers","subscription_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/subscription","commits_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/contents/{+path}","compare_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/merges","archive_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/downloads","issues_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues{/number}","pulls_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls{/number}","milestones_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/milestones{/number}","notifications_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/labels{/name}","releases_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/releases{/id}","deployments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/deployments","created_at":"2016-01-08T14:52:05Z","updated_at":"2017-07-27T23:05:54Z","pushed_at":"2017-07-28T15:45:27Z","git_url":"git://github.com/caiogondim/fast-memoize.js.git","ssh_url":"git@github.com:caiogondim/fast-memoize.js.git","clone_url":"https://github.com/caiogondim/fast-memoize.js.git","svn_url":"https://github.com/caiogondim/fast-memoize.js","homepage":"","size":1188,"stargazers_count":1429,"watchers_count":1429,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":18,"forks":51,"open_issues":18,"watchers":1429,"default_branch":"master"}},"base":{"label":"caiogondim:master","ref":"master","sha":"9aa0304d2ba7e69248712915b86aeda95015d313","user":{"login":"caiogondim","id":33044,"avatar_url":"https://avatars2.githubusercontent.com/u/33044?v=4","gravatar_id":"","url":"https://api.github.com/users/caiogondim","html_url":"https://github.com/caiogondim","followers_url":"https://api.github.com/users/caiogondim/followers","following_url":"https://api.github.com/users/caiogondim/following{/other_user}","gists_url":"https://api.github.com/users/caiogondim/gists{/gist_id}","starred_url":"https://api.github.com/users/caiogondim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiogondim/subscriptions","organizations_url":"https://api.github.com/users/caiogondim/orgs","repos_url":"https://api.github.com/users/caiogondim/repos","events_url":"https://api.github.com/users/caiogondim/events{/privacy}","received_events_url":"https://api.github.com/users/caiogondim/received_events","type":"User","site_admin":false},"repo":{"id":49277709,"name":"fast-memoize.js","full_name":"caiogondim/fast-memoize.js","owner":{"login":"caiogondim","id":33044,"avatar_url":"https://avatars2.githubusercontent.com/u/33044?v=4","gravatar_id":"","url":"https://api.github.com/users/caiogondim","html_url":"https://github.com/caiogondim","followers_url":"https://api.github.com/users/caiogondim/followers","following_url":"https://api.github.com/users/caiogondim/following{/other_user}","gists_url":"https://api.github.com/users/caiogondim/gists{/gist_id}","starred_url":"https://api.github.com/users/caiogondim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiogondim/subscriptions","organizations_url":"https://api.github.com/users/caiogondim/orgs","repos_url":"https://api.github.com/users/caiogondim/repos","events_url":"https://api.github.com/users/caiogondim/events{/privacy}","received_events_url":"https://api.github.com/users/caiogondim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caiogondim/fast-memoize.js","description":":rabbit2: Fastest possible memoization library","fork":false,"url":"https://api.github.com/repos/caiogondim/fast-memoize.js","forks_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/forks","keys_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/teams","hooks_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/hooks","issue_events_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/events{/number}","events_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/events","assignees_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/assignees{/user}","branches_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/branches{/branch}","tags_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/tags","blobs_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/statuses/{sha}","languages_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/languages","stargazers_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/stargazers","contributors_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/contributors","subscribers_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/subscribers","subscription_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/subscription","commits_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/contents/{+path}","compare_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/merges","archive_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/downloads","issues_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues{/number}","pulls_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls{/number}","milestones_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/milestones{/number}","notifications_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/labels{/name}","releases_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/releases{/id}","deployments_url":"https://api.github.com/repos/caiogondim/fast-memoize.js/deployments","created_at":"2016-01-08T14:52:05Z","updated_at":"2017-07-27T23:05:54Z","pushed_at":"2017-07-28T15:45:27Z","git_url":"git://github.com/caiogondim/fast-memoize.js.git","ssh_url":"git@github.com:caiogondim/fast-memoize.js.git","clone_url":"https://github.com/caiogondim/fast-memoize.js.git","svn_url":"https://github.com/caiogondim/fast-memoize.js","homepage":"","size":1188,"stargazers_count":1429,"watchers_count":1429,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":18,"forks":51,"open_issues":18,"watchers":1429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61"},"html":{"href":"https://github.com/caiogondim/fast-memoize.js/pull/61"},"issue":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/61"},"comments":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/caiogondim/fast-memoize.js/statuses/20388df44dda3f9b74dcb4a9b381b283ed375830"}}}}
{"actor":{"display_login":"aduth"}}