{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9956","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9956/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9956/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9956/events","html_url":"https://github.com/bitcoin/bitcoin/pull/9956","id":212884346,"number":9956,"title":"Reorganise qa directory","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars0.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[{"id":62963516,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"theuni","id":417043,"avatar_url":"https://avatars2.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"assignees":[{"login":"theuni","id":417043,"avatar_url":"https://avatars2.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2017-03-08T23:03:52Z","updated_at":"2017-03-15T15:20:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9956","html_url":"https://github.com/bitcoin/bitcoin/pull/9956","diff_url":"https://github.com/bitcoin/bitcoin/pull/9956.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/9956.patch"},"body":"Initially proposed by @jonasschnelli here: https://botbot.me/freenode/bitcoin-core-dev/2017-02-16/?msg=81095853&page=5\r\n\r\nThis re-organises the `qa` test directory to meet the following requirements:\r\n\r\n- qa directory should be renamed to come after /src alpabetically, so that git diffs and github PRs show changes to qa tests beneath changes to product code.\r\n- rpc-tests should be renamed to something, since they test more than the RPC interface\r\n- pull-tester should be renamed to something, since it's run locally as well as on PRs\r\n- bitcoin-util-test should be moved to the qa test directory, since it's a functional test rather than a unit test.\r\n\r\nThis PR has the following commits:\r\n\r\n- commit 1 renames qa to test\r\n- commit 2 renames the rpc-tests directory to qa\r\n- commit 3 renames test/pull-tester/rpc-tests.py to test/runner/runner.py\r\n- commit 4 renames the --enable-extended-rpc-tests configure option to --enable-extended-qa-tests\r\n- commit 5 moves the bitcoin-util-test.py test into test/util\r\n\r\nThe new directory structure is:\r\n\r\n```\r\n|--src\r\n|   |--<source files etc>\r\n|   |--test\r\n|       |---<unit tests>\r\n|\r\n|--test\r\n   |---qa\r\n   |   |---<tests (were previously in /qa/rpc-tests)>\r\n   |  \r\n   |---README.md\r\n   |\r\n   |---runner\r\n   |   |---runner.py (was previously qa/pull-tester/rpc-tests.py)\r\n   |   |---test_config.ini\r\n   |\r\n   |---util\r\n   |   |---bitcoin-util-test.py (was previously in src/test)\r\n   |   |---etc\r\n```\r\n\r\nThe actual structure within the new directories is unchanged to minimize changes.\r\n\r\nI've tested this at each commit by rebuilding and running the test cases. Reviewers note that you'll need to ./autogen.sh and ./configure to test this.\r\n\r\nAny feedback on names or structure welcomed."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/286775636","html_url":"https://github.com/bitcoin/bitcoin/pull/9956#issuecomment-286775636","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9956","id":286775636,"user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars0.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"created_at":"2017-03-15T15:20:48Z","updated_at":"2017-03-15T15:20:48Z","body":"@theuni thanks for your help on this. I've rebased and squashed, so assuming travis passes, this is now ready for review. The two parts which I'm a little unsure of and I'd especially like reviewers to look at are:\r\n\r\n- changes to /contrib/rpm/bitcoin.spec. I actually think we can remove the line:\r\n```srcdir=. test/bitcoin-util-test.py```\r\nentirely, since bitcoin-util-test.py is run as part of make check, but I've left it in for now. Let me know if you think we can remove it.\r\n- changes to Makefile.am, configure.ac and src/test/Makefile.test.include in the final commit (Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py)"}}
{"actor":{"display_login":"jnewbery"}}