{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/123720396","pull_request_review_id":45952666,"id":123720396,"diff_hunk":"@@ -444,9 +420,8 @@ def calc_bounds():\n                                   'These are being disregarded.',\n                                   UserWarning, stacklevel=2)\n                     orography_pts = nd_points_by_key['orography']\n-                    orography_pts_shape = list(orography_pts.shape)\n-                    orography = orography_pts.reshape(\n-                        orography_pts_shape.append(1))\n+                    bds_shape = list(orography_pts.shape) + [1]\n+                    orography = orography_pts.reshape(bds_shape)","path":"lib/iris/aux_factory.py","position":66,"original_position":66,"commit_id":"a709b589db0967cbfa6662ee33068947f79d7eaa","original_commit_id":"a709b589db0967cbfa6662ee33068947f79d7eaa","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars2.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"body":"Personally I never liked all these called-only-once functions at all.\r\nSo given your prompt I've just removed them all -- hope that suits!","created_at":"2017-06-23T10:39:29Z","updated_at":"2017-06-23T10:39:29Z","html_url":"https://github.com/SciTools/iris/pull/2604#discussion_r123720396","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/2604","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/123720396"},"html":{"href":"https://github.com/SciTools/iris/pull/2604#discussion_r123720396"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2604"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/2604","id":125596756,"html_url":"https://github.com/SciTools/iris/pull/2604","diff_url":"https://github.com/SciTools/iris/pull/2604.diff","patch_url":"https://github.com/SciTools/iris/pull/2604.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/2604","number":2604,"state":"open","locked":false,"title":"Calculation of derived coords points and bounds is always lazy.","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars2.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"body":"Addresses #2586","created_at":"2017-06-14T13:34:06Z","updated_at":"2017-06-23T10:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81fca01d2d096e2ca74ec70036d5a9769b2f69da","assignee":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars1.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"assignees":[{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars1.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/2604/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/2604/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/2604/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/a709b589db0967cbfa6662ee33068947f79d7eaa","head":{"label":"pp-mo:derived_coords_lazycalc","ref":"derived_coords_lazycalc","sha":"a709b589db0967cbfa6662ee33068947f79d7eaa","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars2.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"repo":{"id":5701421,"name":"iris","full_name":"pp-mo/iris","owner":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars2.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pp-mo/iris","description":null,"fork":true,"url":"https://api.github.com/repos/pp-mo/iris","forks_url":"https://api.github.com/repos/pp-mo/iris/forks","keys_url":"https://api.github.com/repos/pp-mo/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pp-mo/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pp-mo/iris/teams","hooks_url":"https://api.github.com/repos/pp-mo/iris/hooks","issue_events_url":"https://api.github.com/repos/pp-mo/iris/issues/events{/number}","events_url":"https://api.github.com/repos/pp-mo/iris/events","assignees_url":"https://api.github.com/repos/pp-mo/iris/assignees{/user}","branches_url":"https://api.github.com/repos/pp-mo/iris/branches{/branch}","tags_url":"https://api.github.com/repos/pp-mo/iris/tags","blobs_url":"https://api.github.com/repos/pp-mo/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pp-mo/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pp-mo/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/pp-mo/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pp-mo/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/pp-mo/iris/languages","stargazers_url":"https://api.github.com/repos/pp-mo/iris/stargazers","contributors_url":"https://api.github.com/repos/pp-mo/iris/contributors","subscribers_url":"https://api.github.com/repos/pp-mo/iris/subscribers","subscription_url":"https://api.github.com/repos/pp-mo/iris/subscription","commits_url":"https://api.github.com/repos/pp-mo/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/pp-mo/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/pp-mo/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/pp-mo/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/pp-mo/iris/contents/{+path}","compare_url":"https://api.github.com/repos/pp-mo/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pp-mo/iris/merges","archive_url":"https://api.github.com/repos/pp-mo/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pp-mo/iris/downloads","issues_url":"https://api.github.com/repos/pp-mo/iris/issues{/number}","pulls_url":"https://api.github.com/repos/pp-mo/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/pp-mo/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/pp-mo/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pp-mo/iris/labels{/name}","releases_url":"https://api.github.com/repos/pp-mo/iris/releases{/id}","deployments_url":"https://api.github.com/repos/pp-mo/iris/deployments","created_at":"2012-09-06T11:45:58Z","updated_at":"2015-04-25T22:15:43Z","pushed_at":"2017-06-22T11:45:12Z","git_url":"git://github.com/pp-mo/iris.git","ssh_url":"git@github.com:pp-mo/iris.git","clone_url":"https://github.com/pp-mo/iris.git","svn_url":"https://github.com/pp-mo/iris","homepage":"http://scitools.github.com/iris","size":105235,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"ea4bd66fafe5e3a29f778a4e78cdfbe6b2fe6ecc","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars0.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars0.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2017-06-19T15:29:53Z","pushed_at":"2017-06-22T12:20:33Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":104105,"stargazers_count":170,"watchers_count":170,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":363,"forks":121,"open_issues":363,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2604"},"html":{"href":"https://github.com/SciTools/iris/pull/2604"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/2604"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/2604/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2604/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2604/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/a709b589db0967cbfa6662ee33068947f79d7eaa"}}}}
{"actor":{"display_login":"pp-mo"}}