{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/95869956","pull_request_review_id":16439912,"id":95869956,"diff_hunk":"@@ -35,6 +43,62 @@ func detachMounted(path string) error {\n \treturn nil\n }\n \n+func (daemon *Daemon) setupSecretDir(c *container.Container) (setupErr error) {\n+\tif len(c.SecretReferences) == 0 {\n+\t\treturn nil\n+\t}\n+\n+\tlocalMountPath := c.SecretMountPath()\n+\tlogrus.Debugf(\"secrets: setting up secret dir: %s\", localMountPath)\n+\n+\tdefer func() {\n+\t\tif setupErr != nil {\n+\t\t\tif err := os.RemoveAll(localMountPath); err != nil {\n+\t\t\t\tlog.Errorf(\"error cleaning up secret mount: %s\", err)\n+\t\t\t}\n+\t\t}\n+\t}()\n+\n+\t// create secrets root\n+\tsystem.MkdirAll(localMountPath, 0)","path":"daemon/container_operations_windows.go","position":38,"original_position":38,"commit_id":"9a6bcd4f73953af05c57c265c03ec4632b7f1c73","original_commit_id":"9a6bcd4f73953af05c57c265c03ec4632b7f1c73","user":{"login":"johnstep","id":3768125,"avatar_url":"https://avatars.githubusercontent.com/u/3768125?v=3","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"body":"I will add an error check. @jhowardmsft No, and I would actually prefer to use a different directory, one that does not collide with the daemon directory.","created_at":"2017-01-12T19:46:34Z","updated_at":"2017-01-12T19:46:34Z","html_url":"https://github.com/docker/docker/pull/29738#discussion_r95869956","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/29738","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/95869956"},"html":{"href":"https://github.com/docker/docker/pull/29738#discussion_r95869956"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/29738"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/29738","id":99495988,"html_url":"https://github.com/docker/docker/pull/29738","diff_url":"https://github.com/docker/docker/pull/29738.diff","patch_url":"https://github.com/docker/docker/pull/29738.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/29738","number":29738,"state":"open","locked":false,"title":"Add Windows secrets support.","user":{"login":"johnstep","id":3768125,"avatar_url":"https://avatars.githubusercontent.com/u/3768125?v=3","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"body":"Signed-off-by: John Stephens <johnstep@docker.com>\r\n\r\n@jhowardmsft @PatrickLang\r\n\r\nPlease add comments to this PR instead of 9c1e60161d4956ae8b5cd5c48b41e41eac1a9d60. Thanks!","created_at":"2016-12-28T00:26:32Z","updated_at":"2017-01-12T19:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844c11cba133abb4aef8b970fc4f58316c24a68d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/29738/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/29738/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/29738/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/9a6bcd4f73953af05c57c265c03ec4632b7f1c73","head":{"label":"johnstep:windows-secrets","ref":"windows-secrets","sha":"9a6bcd4f73953af05c57c265c03ec4632b7f1c73","user":{"login":"johnstep","id":3768125,"avatar_url":"https://avatars.githubusercontent.com/u/3768125?v=3","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"repo":{"id":70111097,"name":"docker-docker","full_name":"johnstep/docker-docker","owner":{"login":"johnstep","id":3768125,"avatar_url":"https://avatars.githubusercontent.com/u/3768125?v=3","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnstep/docker-docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/johnstep/docker-docker","forks_url":"https://api.github.com/repos/johnstep/docker-docker/forks","keys_url":"https://api.github.com/repos/johnstep/docker-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnstep/docker-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnstep/docker-docker/teams","hooks_url":"https://api.github.com/repos/johnstep/docker-docker/hooks","issue_events_url":"https://api.github.com/repos/johnstep/docker-docker/issues/events{/number}","events_url":"https://api.github.com/repos/johnstep/docker-docker/events","assignees_url":"https://api.github.com/repos/johnstep/docker-docker/assignees{/user}","branches_url":"https://api.github.com/repos/johnstep/docker-docker/branches{/branch}","tags_url":"https://api.github.com/repos/johnstep/docker-docker/tags","blobs_url":"https://api.github.com/repos/johnstep/docker-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnstep/docker-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnstep/docker-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnstep/docker-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnstep/docker-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/johnstep/docker-docker/languages","stargazers_url":"https://api.github.com/repos/johnstep/docker-docker/stargazers","contributors_url":"https://api.github.com/repos/johnstep/docker-docker/contributors","subscribers_url":"https://api.github.com/repos/johnstep/docker-docker/subscribers","subscription_url":"https://api.github.com/repos/johnstep/docker-docker/subscription","commits_url":"https://api.github.com/repos/johnstep/docker-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnstep/docker-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnstep/docker-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnstep/docker-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnstep/docker-docker/contents/{+path}","compare_url":"https://api.github.com/repos/johnstep/docker-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnstep/docker-docker/merges","archive_url":"https://api.github.com/repos/johnstep/docker-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnstep/docker-docker/downloads","issues_url":"https://api.github.com/repos/johnstep/docker-docker/issues{/number}","pulls_url":"https://api.github.com/repos/johnstep/docker-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/johnstep/docker-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/johnstep/docker-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnstep/docker-docker/labels{/name}","releases_url":"https://api.github.com/repos/johnstep/docker-docker/releases{/id}","deployments_url":"https://api.github.com/repos/johnstep/docker-docker/deployments","created_at":"2016-10-06T00:43:51Z","updated_at":"2016-10-25T00:08:01Z","pushed_at":"2016-12-27T19:32:00Z","git_url":"git://github.com/johnstep/docker-docker.git","ssh_url":"git@github.com:johnstep/docker-docker.git","clone_url":"https://github.com/johnstep/docker-docker.git","svn_url":"https://github.com/johnstep/docker-docker","homepage":"http://www.docker.com","size":118399,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"bf6eb855391e166a65db284567686fafbe4a9a0a","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2017-01-12T19:37:22Z","pushed_at":"2017-01-12T19:36:52Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":120703,"stargazers_count":38649,"watchers_count":38649,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11524,"mirror_url":null,"open_issues_count":2121,"forks":11524,"open_issues":2121,"watchers":38649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/29738"},"html":{"href":"https://github.com/docker/docker/pull/29738"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/29738"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/29738/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/29738/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/29738/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/9a6bcd4f73953af05c57c265c03ec4632b7f1c73"}}}}
{"actor":{"display_login":"johnstep"}}