{"action":"created","issue":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/758","repository_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit","labels_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/758/labels{/name}","comments_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/758/comments","events_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/758/events","html_url":"https://github.com/ProcedureKit/ProcedureKit/issues/758","id":243254983,"number":758,"title":"v5 API cleanup","user":{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars5.githubusercontent.com/u/18540905?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false},"labels":[{"id":535293719,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/labels/breaking%20changes","name":"breaking changes","color":"b60205","default":false},{"id":270847264,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/labels/in%20progress","name":"in progress","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars5.githubusercontent.com/u/18540905?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false},"assignees":[{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars5.githubusercontent.com/u/18540905?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/milestones/50","html_url":"https://github.com/ProcedureKit/ProcedureKit/milestone/50","labels_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/milestones/50/labels","id":2620960,"number":50,"title":"5.0.0","description":"","creator":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars7.githubusercontent.com/u/309420?v=4","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2017-07-04T12:08:58Z","updated_at":"2017-07-16T17:53:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-07-16T17:53:10Z","updated_at":"2017-07-17T15:47:04Z","closed_at":null,"body":"> **Work-In-Progress**\r\n\r\n### Visibility:\r\n\r\nProcedure\r\n- [ ] `willEnqueue(on:)` (should probably be `internal` - should only be called from ProcedureQueue and the tests)\r\n- [ ] `pendingQueueStart()` (should probably be `internal` - should only be called from ProcedureQueue and the tests)\r\n\r\n### Unavailable (renamed):\r\n\r\nRepeatProcedure\r\n- [ ] `replaceConfigureBlock(block:)` (replacement named `replace(configureBlock:)` already exists)\r\n- [ ] `appendConfigureBlock(block:)` (replacement named `append(configureBlock:)` already exists)"},"comment":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/comments/315794195","html_url":"https://github.com/ProcedureKit/ProcedureKit/issues/758#issuecomment-315794195","issue_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/758","id":315794195,"user":{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars5.githubusercontent.com/u/18540905?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T15:47:04Z","updated_at":"2017-07-17T15:47:04Z","body":"@danthorpe: I suppose it could also result in changing:\r\n\r\n```swift\r\nif let timeout = resilience.requestTimeout {\r\n    appendConfigureBlock { $0.add(observer: TimeoutObserver(by: timeout)) }\r\n}\r\n```\r\n\r\nto:\r\n\r\n```swift\r\nif let timeout = resilience.requestTimeout {\r\n    append(configureBlock: { $0.add(observer: TimeoutObserver(by: timeout)) })\r\n}\r\n```\r\n\r\nI'm not wedded to one way or the other. Just noticed the duplicates in a partial audit."}}
{"actor":{"display_login":"swiftlyfalling"}}