{"action":"created","comment":{"url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/comments/99397416","pull_request_review_id":20075491,"id":99397416,"diff_hunk":"@@ -0,0 +1,5 @@\n+var chai = require('chai');\n+\n+chai.use(require('chai-passport-strategy'));\n+\n+global.expect = chai.expect;","path":"test/bootstrap/node.js","position":5,"original_position":5,"commit_id":"f4cfd53a95f7d37f285b70f4057eadc497ce0a7d","original_commit_id":"f4cfd53a95f7d37f285b70f4057eadc497ce0a7d","user":{"login":"drtoast","id":197871,"avatar_url":"https://avatars.githubusercontent.com/u/197871?v=3","gravatar_id":"","url":"https://api.github.com/users/drtoast","html_url":"https://github.com/drtoast","followers_url":"https://api.github.com/users/drtoast/followers","following_url":"https://api.github.com/users/drtoast/following{/other_user}","gists_url":"https://api.github.com/users/drtoast/gists{/gist_id}","starred_url":"https://api.github.com/users/drtoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drtoast/subscriptions","organizations_url":"https://api.github.com/users/drtoast/orgs","repos_url":"https://api.github.com/users/drtoast/repos","events_url":"https://api.github.com/users/drtoast/events{/privacy}","received_events_url":"https://api.github.com/users/drtoast/received_events","type":"User","site_admin":false},"body":"I prefer adding `var expect = chai.expect` at the top of each test to avoid adding things to the global namespace, which then need to be added to the ignored list for linters. Same with `describe` and `it`. It adds a bit more boilerplate to the test but makes very clear where dependencies are coming from.","created_at":"2017-02-03T18:45:26Z","updated_at":"2017-02-03T19:00:28Z","html_url":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1#discussion_r99397416","pull_request_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/comments/99397416"},"html":{"href":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1#discussion_r99397416"},"pull_request":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1","id":104450377,"html_url":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1","diff_url":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1.diff","patch_url":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1.patch","issue_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/1","number":1,"state":"open","locked":false,"title":"OAuth with mancala","user":{"login":"kasima","id":146363,"avatar_url":"https://avatars.githubusercontent.com/u/146363?v=3","gravatar_id":"","url":"https://api.github.com/users/kasima","html_url":"https://github.com/kasima","followers_url":"https://api.github.com/users/kasima/followers","following_url":"https://api.github.com/users/kasima/following{/other_user}","gists_url":"https://api.github.com/users/kasima/gists{/gist_id}","starred_url":"https://api.github.com/users/kasima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasima/subscriptions","organizations_url":"https://api.github.com/users/kasima/orgs","repos_url":"https://api.github.com/users/kasima/repos","events_url":"https://api.github.com/users/kasima/events{/privacy}","received_events_url":"https://api.github.com/users/kasima/received_events","type":"User","site_admin":false},"body":"Cobbled together from other passport strategies.","created_at":"2017-02-02T23:57:35Z","updated_at":"2017-02-03T19:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e9663a9c89839ebaac97c65b28127493dfcccc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1/commits","review_comments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1/comments","review_comment_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/1/comments","statuses_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/statuses/f4cfd53a95f7d37f285b70f4057eadc497ce0a7d","head":{"label":"steveandkate:feature/auth-with-mancala","ref":"feature/auth-with-mancala","sha":"f4cfd53a95f7d37f285b70f4057eadc497ce0a7d","user":{"login":"steveandkate","id":1217858,"avatar_url":"https://avatars.githubusercontent.com/u/1217858?v=3","gravatar_id":"","url":"https://api.github.com/users/steveandkate","html_url":"https://github.com/steveandkate","followers_url":"https://api.github.com/users/steveandkate/followers","following_url":"https://api.github.com/users/steveandkate/following{/other_user}","gists_url":"https://api.github.com/users/steveandkate/gists{/gist_id}","starred_url":"https://api.github.com/users/steveandkate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveandkate/subscriptions","organizations_url":"https://api.github.com/users/steveandkate/orgs","repos_url":"https://api.github.com/users/steveandkate/repos","events_url":"https://api.github.com/users/steveandkate/events{/privacy}","received_events_url":"https://api.github.com/users/steveandkate/received_events","type":"Organization","site_admin":false},"repo":{"id":80553176,"name":"passport-steveandkate-oauth2","full_name":"steveandkate/passport-steveandkate-oauth2","owner":{"login":"steveandkate","id":1217858,"avatar_url":"https://avatars.githubusercontent.com/u/1217858?v=3","gravatar_id":"","url":"https://api.github.com/users/steveandkate","html_url":"https://github.com/steveandkate","followers_url":"https://api.github.com/users/steveandkate/followers","following_url":"https://api.github.com/users/steveandkate/following{/other_user}","gists_url":"https://api.github.com/users/steveandkate/gists{/gist_id}","starred_url":"https://api.github.com/users/steveandkate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveandkate/subscriptions","organizations_url":"https://api.github.com/users/steveandkate/orgs","repos_url":"https://api.github.com/users/steveandkate/repos","events_url":"https://api.github.com/users/steveandkate/events{/privacy}","received_events_url":"https://api.github.com/users/steveandkate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/steveandkate/passport-steveandkate-oauth2","description":"Passport strategy for OAuth'ing against mancala accounts","fork":false,"url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2","forks_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/forks","keys_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/teams","hooks_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/hooks","issue_events_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/events","assignees_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/tags","blobs_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/languages","stargazers_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/stargazers","contributors_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/contributors","subscribers_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/subscribers","subscription_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/subscription","commits_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/merges","archive_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/downloads","issues_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/deployments","created_at":"2017-01-31T19:19:32Z","updated_at":"2017-02-03T00:05:44Z","pushed_at":"2017-02-03T00:06:51Z","git_url":"git://github.com/steveandkate/passport-steveandkate-oauth2.git","ssh_url":"git@github.com:steveandkate/passport-steveandkate-oauth2.git","clone_url":"https://github.com/steveandkate/passport-steveandkate-oauth2.git","svn_url":"https://github.com/steveandkate/passport-steveandkate-oauth2","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"steveandkate:master","ref":"master","sha":"04a67e630cd00cb23d260e0e2fa3c988a8be2d8f","user":{"login":"steveandkate","id":1217858,"avatar_url":"https://avatars.githubusercontent.com/u/1217858?v=3","gravatar_id":"","url":"https://api.github.com/users/steveandkate","html_url":"https://github.com/steveandkate","followers_url":"https://api.github.com/users/steveandkate/followers","following_url":"https://api.github.com/users/steveandkate/following{/other_user}","gists_url":"https://api.github.com/users/steveandkate/gists{/gist_id}","starred_url":"https://api.github.com/users/steveandkate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveandkate/subscriptions","organizations_url":"https://api.github.com/users/steveandkate/orgs","repos_url":"https://api.github.com/users/steveandkate/repos","events_url":"https://api.github.com/users/steveandkate/events{/privacy}","received_events_url":"https://api.github.com/users/steveandkate/received_events","type":"Organization","site_admin":false},"repo":{"id":80553176,"name":"passport-steveandkate-oauth2","full_name":"steveandkate/passport-steveandkate-oauth2","owner":{"login":"steveandkate","id":1217858,"avatar_url":"https://avatars.githubusercontent.com/u/1217858?v=3","gravatar_id":"","url":"https://api.github.com/users/steveandkate","html_url":"https://github.com/steveandkate","followers_url":"https://api.github.com/users/steveandkate/followers","following_url":"https://api.github.com/users/steveandkate/following{/other_user}","gists_url":"https://api.github.com/users/steveandkate/gists{/gist_id}","starred_url":"https://api.github.com/users/steveandkate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveandkate/subscriptions","organizations_url":"https://api.github.com/users/steveandkate/orgs","repos_url":"https://api.github.com/users/steveandkate/repos","events_url":"https://api.github.com/users/steveandkate/events{/privacy}","received_events_url":"https://api.github.com/users/steveandkate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/steveandkate/passport-steveandkate-oauth2","description":"Passport strategy for OAuth'ing against mancala accounts","fork":false,"url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2","forks_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/forks","keys_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/teams","hooks_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/hooks","issue_events_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/events","assignees_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/tags","blobs_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/languages","stargazers_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/stargazers","contributors_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/contributors","subscribers_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/subscribers","subscription_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/subscription","commits_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/merges","archive_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/downloads","issues_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/deployments","created_at":"2017-01-31T19:19:32Z","updated_at":"2017-02-03T00:05:44Z","pushed_at":"2017-02-03T00:06:51Z","git_url":"git://github.com/steveandkate/passport-steveandkate-oauth2.git","ssh_url":"git@github.com:steveandkate/passport-steveandkate-oauth2.git","clone_url":"https://github.com/steveandkate/passport-steveandkate-oauth2.git","svn_url":"https://github.com/steveandkate/passport-steveandkate-oauth2","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1"},"html":{"href":"https://github.com/steveandkate/passport-steveandkate-oauth2/pull/1"},"issue":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/1"},"comments":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/steveandkate/passport-steveandkate-oauth2/statuses/f4cfd53a95f7d37f285b70f4057eadc497ce0a7d"}}}}
{"actor":{"display_login":"drtoast"}}