{"push_id":1659585816,"size":345,"distinct_size":37,"ref":"refs/heads/master","head":"4d8baa9bbb7b75c74080661aa1eadf22349d199c","before":"538a61b205b9b07ce49721d3b248031316b7c41e","commits":[{"sha":"8c2480f7401ea3e7073e5fe787f8e3ab861f5679","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Push to error queue in |EVP_PKEY_CTX_ctrl| for wrong keytype.\n\nChange-Id: I81a94be94103d3c763cd6b2c1b8196300808c6fe\nReviewed-on: https://boringssl-review.googlesource.com/13386\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/8c2480f7401ea3e7073e5fe787f8e3ab861f5679"},{"sha":"3f38d80b2ffc7979b26d4bf8b750dd7088b5cc04","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Add CFI information to the x86-64 X25519 asm.\n\nThis change serves to check that all our consumers can process assembly\nwith CFI directives in it.\n\nFor the first change I picked a file that's not perlasm to keep things\nslightly simplier, but that might have been a mistake:\n\nDJB's tooling always aligns the stack to 32 bytes and it's not possible\nto express this in DWARF format (without using a register to store the\nold stack pointer).\n\nSince none of the functions here appear to care about that alignment, I\nremoved it from each of them. I also trimmed the set of saved registers\nwhere possible and used the redzone for functions that didn't need much\nstack.\n\nOverall, this appears to have slightly improved the performance (by\nabout 0.7%):\n\nBefore:\n\nDid 46000 Curve25519 base-point multiplication operations in 3023288us (15215.2 ops/sec)\nDid 46000 Curve25519 arbitrary point multiplication operations in 3017315us (15245.3 ops/sec)\nDid 46000 Curve25519 base-point multiplication operations in 3015346us (15255.3 ops/sec)\nDid 46000 Curve25519 arbitrary point multiplication operations in 3018609us (15238.8 ops/sec)\nDid 46000 Curve25519 base-point multiplication operations in 3019004us (15236.8 ops/sec)\nDid 46000 Curve25519 arbitrary point multiplication operations in 3013135us (15266.5 ops/sec)\n\nAfter:\n\nDid 46000 Curve25519 base-point multiplication operations in 3007659us (15294.3 ops/sec)\nDid 47000 Curve25519 arbitrary point multiplication operations in 3054202us (15388.6 ops/sec)\nDid 46000 Curve25519 base-point multiplication operations in 3008714us (15288.9 ops/sec)\nDid 46000 Curve25519 arbitrary point multiplication operations in 3004740us (15309.1 ops/sec)\nDid 46000 Curve25519 base-point multiplication operations in 3009140us (15286.8 ops/sec)\nDid 47000 Curve25519 arbitrary point multiplication operations in 3057518us (15371.9 ops/sec)\n\nChange-Id: I31df11c45b2ea0bf44dde861d52c27f848331691\nReviewed-on: https://boringssl-review.googlesource.com/13200\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>\nReviewed-by: David Benjamin <davidben@google.com>\nReviewed-by: Adam Langley <agl@google.com>\nCommit-Queue: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/3f38d80b2ffc7979b26d4bf8b750dd7088b5cc04"},{"sha":"7cd0a978cc3cbfe771b6fdecdcb83ceaf09cf4a6","author":{"name":"Nick Harper","email":"b03ac9bbcc41dda3b038a90fd9875dcfffef6789@chromium.org"},"message":"Bogo: Send and receive 0.5-RTT data.\n\nChange-Id: I44202457841f06a899e140f78ae8afa7ac720283\nReviewed-on: https://boringssl-review.googlesource.com/12600\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/7cd0a978cc3cbfe771b6fdecdcb83ceaf09cf4a6"},{"sha":"e1e78130f51288d65be0b43eebbe13385068980f","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Keep a reference to |X509|s appended to a chain.\n\nThe recent CRYPTO_BUFFER changes meant that |X509| objects passed to\nSSL_CTX_add_extra_chain_cert would be |free|ed immediately. However,\nsome third-party code (at least serf and curl) continue to use the\n|X509| even after handing over ownership.\n\nIn order to unblock things, keep the past |X509| around for a while to\npaper over the issues with those libraries while we try and upstream\nchanges.\n\nChange-Id: I832b458af9b265749fed964658c5c34c84d518df\nReviewed-on: https://boringssl-review.googlesource.com/13480\nReviewed-by: Adam Langley <agl@google.com>\nCommit-Queue: Adam Langley <agl@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/e1e78130f51288d65be0b43eebbe13385068980f"},{"sha":"c26692cfdd9b0c86f2573ad03461416c9702bd39","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Push the use of X509 upwards, out of |ssl_set_cert|.\n\nThis change moves the interface between |X509| and |CRYPTO_BUFFER| a\nlittle further out, towards the API.\n\nChange-Id: I1c014d20f12ad83427575843ca0b3bb22de1a694\nReviewed-on: https://boringssl-review.googlesource.com/13365\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/c26692cfdd9b0c86f2573ad03461416c9702bd39"},{"sha":"b5c58db9ffd8571ce8f0b48f78354ec8cfcd0e4c","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"TLS 1.3 sessions should not be added to the server session cache.\n\nFix this and add a test. Otherwise enabling TLS 1.3 will cause a server\nto blow through its session cache.\n\nChange-Id: I67edbc468faedfd94a6c30cf842af085a6543b50\nReviewed-on: https://boringssl-review.googlesource.com/13501\nReviewed-by: Steven Valdez <svaldez@google.com>\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/b5c58db9ffd8571ce8f0b48f78354ec8cfcd0e4c"},{"sha":"e79fe70be9b2fa2fdab00456c48f04783236fbe5","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Bit-pack SSL_AEAD_CTX's various toggles.\n\nChange-Id: Ibb479a0a739a44d0568e37cdfdb30b30e5410c02\nReviewed-on: https://boringssl-review.googlesource.com/13520\nCommit-Queue: David Benjamin <davidben@google.com>\nCommit-Queue: Adam Langley <agl@google.com>\nReviewed-by: Adam Langley <agl@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/e79fe70be9b2fa2fdab00456c48f04783236fbe5"},{"sha":"0efa7592e3fb2ae647518a82ab19679b7c933d99","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"dispatch_alert is not an incidental write.\n\nIt is impossible to have to call dispatch_alert when writing application\ndata. Now that we don't send warning alerts through ssl3_send_alert, all\nalerts are closure alerts, which means attempts to write will fail.\n\nThis prunes a lot of dead code, avoiding the re-entrancy in the write\npath. With that gone, tracking alert_dispatch is much more\nstraightforward.\n\nBUG=146\n\nChange-Id: Ie5fe677daee71e463d79562f3d2cea822a92581d\nReviewed-on: https://boringssl-review.googlesource.com/13500\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>\nReviewed-by: Steven Valdez <svaldez@google.com>\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/0efa7592e3fb2ae647518a82ab19679b7c933d99"},{"sha":"0b1bb12ce806e69a99ff48e01dd7d1069ca0b173","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Push the SSL_CTX session_timeout zero logic up.\n\nThis special-case is almost unexposed (the timeout is initialized to the\ndefault) except if the caller calls SSL_CTX_set_timeout(0). Preserve\nthat behavior by mapping 0 to SSL_DEFAULT_SESSION_TIMEOUT in\nSSL_CTX_set_timeout but simplify the internal state.\n\nChange-Id: Ice03a519c25284b925f1e0cf485f2d8c54dc5038\nReviewed-on: https://boringssl-review.googlesource.com/13502\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/0b1bb12ce806e69a99ff48e01dd7d1069ca0b173"},{"sha":"17b30833737b32ecab1f12c105e1b5cae6d49458","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Use a separate timeout scheme for TLS 1.3.\n\nIn TLS 1.2, resumption's benefits are more-or-less subsumed by False\nStart. TLS 1.2 resumption lifetime is bounded by how much traffic we are\nwilling to encrypt without fresh key material, so the lifetime is short.\nRenewal uses the same key, so we do not allow it to increase lifetimes.\n\nIn TLS 1.3, resumption unlocks 0-RTT. We do not implement psk_ke, so\nresumption incorporates fresh key material into both encrypted traffic\n(except for early data) and renewed tickets. Thus we are both more\nwilling to and more interested in longer lifetimes for tickets. Renewal\nis also not useless. Thus in TLS 1.3, lifetime is bound separately by\nthe lifetime of a given secret as a psk_dhe_ke authenticator and the\nlifetime of the online signature which authenticated the initial\nhandshake.\n\nThis change maintains two lifetimes on an SSL_SESSION: timeout which is\nthe renewable lifetime of this ticket, and auth_timeout which is the\nnon-renewable cliff. It also separates the TLS 1.2 and TLS 1.3 timeouts.\nThe old session timeout defaults and configuration apply to TLS 1.3, and\nwe define new ones for TLS 1.3.\n\nFinally, this makes us honor the NewSessionTicket timeout in TLS 1.3.\nIt's no longer a \"hint\" in 1.3 and there's probably value in avoiding\nknown-useless 0-RTT offers.\n\nBUG=120\n\nChange-Id: Iac46d56e5a6a377d8b88b8fa31f492d534cb1b85\nReviewed-on: https://boringssl-review.googlesource.com/13503\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/17b30833737b32ecab1f12c105e1b5cae6d49458"},{"sha":"5c9d411e145d97698cdd12419edf581dfd9cd050","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Fix some compact unwind errors.\n\nThe Mac ld gets unhappy about \"weird\" unwind directives:\n\nIn chacha20_poly1305_x86_64.pl, $keyp is being pushed on the stack\n(according to the comment) because it gets clobbered in the computation\nsomewhere. $keyp is %r9 which is not callee-saved (it's an argument\nregister), so we don't need to tag it with .cfi_offset.\n\nIn x25519-asm-x86_64.S, x25519_x86_64_mul saves %rdi on the stack.\nHowever it too is not callee-saved (it's an argument register) and\nshould not have a .cfi_offset. %rdi also does not appear to be written\nto anywhere in the function, so there's no need to save it at all.\n\n(This does not resolve the \"r15 is saved too far from return address\"\nerrors. Just the non-standard register ones.)\n\nBUG=176\n\nChange-Id: I53f3f7db3d1745384fb47cb52cd6536aabb5065e\nReviewed-on: https://boringssl-review.googlesource.com/13560\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/5c9d411e145d97698cdd12419edf581dfd9cd050"},{"sha":"6342111c2e7131d49e3066c33690763c53be2521","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Remove BIO puts hooks.\n\nThese are unused. BIO_puts is implemented genericly.\n\nChange-Id: Iecf1b6736291de8c48ce1adbb7401963a120d122\nReviewed-on: https://boringssl-review.googlesource.com/13366\nReviewed-by: Steven Valdez <svaldez@google.com>\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/6342111c2e7131d49e3066c33690763c53be2521"},{"sha":"8671c47bd80a890116cbc760397a616eb2126388","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Fold ssl3_write_bytes into ssl3_write_app_data.\n\nIt has no other callers, now that the handshake is written elsewhere.\n\nChange-Id: Ib04bbdc4a54fc7d01405d9b3f765fa9f186244de\nReviewed-on: https://boringssl-review.googlesource.com/13540\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/8671c47bd80a890116cbc760397a616eb2126388"},{"sha":"772a5bed7d5065b301c3979c325248689d36b92c","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Reorder the X25519 ladderstep stack frame on x86-64.\n\nThe current X25519 assembly has a 352-byte stack frame and saves the\nregsiters at the bottom. This means that the CFI information cannot be\nrepresented in the “compact” form that MacOS seems to want to use (see\nlinked bug).\n\nThe stack frame looked like:\n\n 360 CFA\n 352 return address\n ⋮\n 56  (296 bytes of scratch space)\n 48  saved RBP\n 40  saved RBX\n 32  saved R15\n 24  saved R14\n 16  saved R13\n 8   saved R12\n 0   (hole left from 3f38d80b dropping the superfluous saving of R11)\n\nNow it looks like:\n\n 352 CFA\n 344 return address\n 336 saved RBP\n 328 saved RBX\n 320 saved R15\n 312 saved R14\n 304 saved R13\n 296 saved R12\n ⋮\n 0   (296 bytes of scratch space)\n\nThe bulk of the changes involve subtracting 56 from all the offsets to\nRSP when working in the scratch space. This was done in Vim with:\n  '<,'>s/\\([1-9][0-9]*\\)(%rsp)/\\=submatch(1)-56.\"(%rsp)\"/\n\nBUG=176\n\nChange-Id: I022830e8f896fe2d877015fa3ecfa1d073207679\nReviewed-on: https://boringssl-review.googlesource.com/13580\nCommit-Queue: Adam Langley <agl@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/772a5bed7d5065b301c3979c325248689d36b92c"},{"sha":"5fa2cdf1ed4069be359038107e144cd7c7506dca","author":{"name":"Adam Langley","email":"a7393369fe0624cd7115411c16630fffeae33df8@gmail.com"},"message":"Test SSE4.1 before using ChaCha20-Poly1305 asm.\n\nThis change guards the ChaCha20-Poly1305 asm on having SSE4.1. The\npinsrb instruction that it uses requires this, which I didn't notice,\nand so this would fail on Core 2 and older chips.\n\nBUG=chromium:688384\n\nChange-Id: I177e3492782a1a9974b6df29d26fc4809009ad48\nReviewed-on: https://boringssl-review.googlesource.com/13586\nReviewed-by: Adam Langley <alangley@gmail.com>\nCommit-Queue: Adam Langley <alangley@gmail.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/5fa2cdf1ed4069be359038107e144cd7c7506dca"},{"sha":"3c0e0377561a4301036354cef6cbab0b0abf383d","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Don't reach into SSL in BIO_f_ssl.\n\nWe can implement this with the SSL stack's public API fine.\n\nChange-Id: Ia95c9174d7b850b7fed89046d3c351c970855cf3\nReviewed-on: https://boringssl-review.googlesource.com/13565\nCommit-Queue: David Benjamin <davidben@google.com>\nCommit-Queue: Adam Langley <agl@google.com>\nReviewed-by: Adam Langley <agl@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/3c0e0377561a4301036354cef6cbab0b0abf383d"},{"sha":"e212f27a3e29872542dec2a28896abf4ff5addd9","author":{"name":"Adam Langley","email":"a7393369fe0624cd7115411c16630fffeae33df8@gmail.com"},"message":"Support running tests under Intel SDE.\n\nIntel SDE is a tool that can simulate many different Intel chips. This\nlets us test whether our CPUID-guarding is correct and would have\ncaught, for example, this morning's ChaCha20-Poly1305 problem.\n\nChange-Id: I39de2bedb1c29b48b02ba30c51fdce57a5cbe640\nReviewed-on: https://boringssl-review.googlesource.com/13587\nCommit-Queue: Adam Langley <alangley@gmail.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/e212f27a3e29872542dec2a28896abf4ff5addd9"},{"sha":"e5dfb52c3bda2c55a79d3177b893607c5aa24e30","author":{"name":"Adam Langley","email":"08468c871f61cba23535d0fd87e3931d4984a3f8@google.com"},"message":"Add -root-certs options to bssl client.\n\nThis option allows a file containing PEM root certificates to be given.\nIt causes the server's certificate to be verified against those roots.\n\nChange-Id: Iaa92581d5834e436bcedf9d4088f7204abc6b95b\nReviewed-on: https://boringssl-review.googlesource.com/13588\nReviewed-by: David Benjamin <davidben@google.com>\nCommit-Queue: David Benjamin <davidben@google.com>\nCQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/e5dfb52c3bda2c55a79d3177b893607c5aa24e30"},{"sha":"42bfeb362338857321ef146e8eb743463b3e8ccb","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Remove an unnecessary TLS 1.2 ClientHello state.\n\nThe version negotiation logic was a little bizarrely wedged in the\nmiddle of the state machine. (We don't support server renegotiation, so\nhave_version is always false here.)\n\nBUG=128\n\nChange-Id: I9448dce374004b92e8bd5172c36a4e0eea51619c\nReviewed-on: https://boringssl-review.googlesource.com/13561\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/42bfeb362338857321ef146e8eb743463b3e8ccb"},{"sha":"daa05392768cce91f9c8bd2541c6d9445586f34b","author":{"name":"David Benjamin","email":"732e9177229740f757cac883f1aea417a06f67bd@google.com"},"message":"Remove an unnecessary TLS 1.3 ClientHello state.\n\nThe TLS 1.2 and 1.3 state machines do the exact same thing at the\nbeginning. Let them process the ClientHello extensions, etc., and\nfinalize the certificate in common code. Once we start picking\nparameters, we begin to diverge. Everything before this point is\narguably part of setting up the configuration, which is\nversion-agnostic.\n\nBUG=128\n\nChange-Id: I293ea3087ecbc3267bd8cdaa011c98d26a699789\nReviewed-on: https://boringssl-review.googlesource.com/13562\nCommit-Queue: David Benjamin <davidben@google.com>\nReviewed-by: Adam Langley <agl@google.com>","distinct":false,"url":"https://api.github.com/repos/ranweiler/ring/commits/daa05392768cce91f9c8bd2541c6d9445586f34b"}]}
{"actor":{"display_login":"ranweiler"}}