{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51985","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51985/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51985/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51985/events","html_url":"https://github.com/kubernetes/kubernetes/pull/51985","id":255426678,"number":51985,"title":"Fix volume remount on reboot","user":{"login":"chakri-nelluri","id":9920367,"avatar_url":"https://avatars2.githubusercontent.com/u/9920367?v=4","gravatar_id":"","url":"https://api.github.com/users/chakri-nelluri","html_url":"https://github.com/chakri-nelluri","followers_url":"https://api.github.com/users/chakri-nelluri/followers","following_url":"https://api.github.com/users/chakri-nelluri/following{/other_user}","gists_url":"https://api.github.com/users/chakri-nelluri/gists{/gist_id}","starred_url":"https://api.github.com/users/chakri-nelluri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakri-nelluri/subscriptions","organizations_url":"https://api.github.com/users/chakri-nelluri/orgs","repos_url":"https://api.github.com/users/chakri-nelluri/repos","events_url":"https://api.github.com/users/chakri-nelluri/events{/privacy}","received_events_url":"https://api.github.com/users/chakri-nelluri/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"ededed","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars2.githubusercontent.com/u/7740897?v=4","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"assignees":[{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars2.githubusercontent.com/u/7740897?v=4","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2017-09-05T22:25:32Z","updated_at":"2017-09-14T19:02:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51985","html_url":"https://github.com/kubernetes/kubernetes/pull/51985","diff_url":"https://github.com/kubernetes/kubernetes/pull/51985.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/51985.patch"},"body":"**What this PR does / why we need it**:\r\nCheck the mount is actually attached & mounted before marking actual state of world of Kubelet reconciler.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51982  \r\n\r\n**Special notes for your reviewer**:\r\nAdded explicit check to make sure volumes are attached and are mounted before marking the state in actual state of world.\r\n\r\n**Release note**:\r\nNONE\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/329578431","html_url":"https://github.com/kubernetes/kubernetes/pull/51985#issuecomment-329578431","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51985","id":329578431,"user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T19:02:03Z","updated_at":"2017-09-14T19:02:03Z","author_association":"CONTRIBUTOR","body":"After checking the code again, I think this fix still has an issue.\r\n\r\nFor flexvolume, iscsi, or fc, currently the ConstructVolumeSpec function use fake information to fill in the the spec. So when attacher uses GetDeviceMountPath, it will construct the wrong path. So this check mount point will always fail. The result is that the volume will not be updated into the actual state no matter what. So the mount points will never be cleaned up in the situation that kubelet restarts and pod is deleted around the same time."}}
{"actor":{"display_login":"jingxu97"}}