{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/14963","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/14963/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/14963/comments","events_url":"https://api.github.com/repos/apache/spark/issues/14963/events","html_url":"https://github.com/apache/spark/pull/14963","id":175099674,"number":14963,"title":"[SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in lint-python","user":{"login":"Stibbons","id":133498,"avatar_url":"https://avatars.githubusercontent.com/u/133498?v=3","gravatar_id":"","url":"https://api.github.com/users/Stibbons","html_url":"https://github.com/Stibbons","followers_url":"https://api.github.com/users/Stibbons/followers","following_url":"https://api.github.com/users/Stibbons/following{/other_user}","gists_url":"https://api.github.com/users/Stibbons/gists{/gist_id}","starred_url":"https://api.github.com/users/Stibbons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stibbons/subscriptions","organizations_url":"https://api.github.com/users/Stibbons/orgs","repos_url":"https://api.github.com/users/Stibbons/repos","events_url":"https://api.github.com/users/Stibbons/events{/privacy}","received_events_url":"https://api.github.com/users/Stibbons/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":57,"created_at":"2016-09-05T16:08:50Z","updated_at":"2017-01-09T10:17:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14963","html_url":"https://github.com/apache/spark/pull/14963","diff_url":"https://github.com/apache/spark/pull/14963.diff","patch_url":"https://github.com/apache/spark/pull/14963.patch"},"body":"Use a virtualenv for isolation and easy installation of `pep8` and `pylint` by the `lint-python` linter script.\n\nThis involves 2 changes in this script:\n- it creates a virtualenv if we are not in one. This way, we can use pip to install development environment's dependencies (which are different from the \"prod\" environment, for instance we don't want to install pep or pylint on prod)\n- dependencies are described in `requirements.txt`. This will \"freeze\" the version of the tools used. We don't want the HEAD starting breaking because a new version of pylint has been posted on pypi which add new checks. sphinx version is also \"frozen\".\n\nThis basically reverts 85a50a6352b72c4619d010e29e3a76774dbc0c71\n\nMight have been a solution to SPARK-9385 (see #7704)\n\nLot of new tests introduced by the newer version of pylint have been disabled. I propose to fix issues in various pull requests (obviously most 'import' order errors should be fixed by my other pull requests such as #14830 for documentation examples, which is part of the effort on code style described in #14567). Each subsequent pull request will fix one or more error and reenable the according pylint check.\n\nList of new disabled tests:\n- bad-super-call\n- consider-iterating-dictionary\n- consider-using-enumerate\n- eval-used\n- exec-used\n- invalid-length-returned\n- misplaced-comparison-constant\n- raising-bad-type\n- redefined-variable-type\n- trailing-newlines\n- trailing-whitespace\n- ungrouped-imports\n- unnecessary-pass\n- unneeded-not\n- wrong-import-order\n- wrong-import-position\n## How was this patch tested?\n\nManual execution of `lint-python` on my machine.\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/271249639","html_url":"https://github.com/apache/spark/pull/14963#issuecomment-271249639","issue_url":"https://api.github.com/repos/apache/spark/issues/14963","id":271249639,"user":{"login":"Stibbons","id":133498,"avatar_url":"https://avatars.githubusercontent.com/u/133498?v=3","gravatar_id":"","url":"https://api.github.com/users/Stibbons","html_url":"https://github.com/Stibbons","followers_url":"https://api.github.com/users/Stibbons/followers","following_url":"https://api.github.com/users/Stibbons/following{/other_user}","gists_url":"https://api.github.com/users/Stibbons/gists{/gist_id}","starred_url":"https://api.github.com/users/Stibbons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stibbons/subscriptions","organizations_url":"https://api.github.com/users/Stibbons/orgs","repos_url":"https://api.github.com/users/Stibbons/repos","events_url":"https://api.github.com/users/Stibbons/events{/privacy}","received_events_url":"https://api.github.com/users/Stibbons/received_events","type":"User","site_admin":false},"created_at":"2017-01-09T10:17:10Z","updated_at":"2017-01-09T10:17:10Z","body":"Any hope this patch might be integrated ?"}}
{"actor":{"display_login":"Stibbons"}}