{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/4733","repository_url":"https://api.github.com/repos/bbatsov/rubocop","labels_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4733/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4733/comments","events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4733/events","html_url":"https://github.com/bbatsov/rubocop/pull/4733","id":257921559,"number":4733,"title":"Enforce rubocop-rspec for project","user":{"login":"backus","id":2085622,"avatar_url":"https://avatars3.githubusercontent.com/u/2085622?v=4","gravatar_id":"","url":"https://api.github.com/users/backus","html_url":"https://github.com/backus","followers_url":"https://api.github.com/users/backus/followers","following_url":"https://api.github.com/users/backus/following{/other_user}","gists_url":"https://api.github.com/users/backus/gists{/gist_id}","starred_url":"https://api.github.com/users/backus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backus/subscriptions","organizations_url":"https://api.github.com/users/backus/orgs","repos_url":"https://api.github.com/users/backus/repos","events_url":"https://api.github.com/users/backus/events{/privacy}","received_events_url":"https://api.github.com/users/backus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-15T04:02:35Z","updated_at":"2017-09-18T06:43:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/4733","html_url":"https://github.com/bbatsov/rubocop/pull/4733","diff_url":"https://github.com/bbatsov/rubocop/pull/4733.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/4733.patch"},"body":"20% snark PR responding to @Drenmi's comment on https://github.com/bbatsov/rubocop/issues/4653. 80% serious\r\n\r\nThis PR **does not** ship rubocop-rspec with RuboCop. All it does is enforce rubocop-rspec's cops for the rubocop project itself.\r\n\r\nI've applied each autocorrect in a separate commit so people can pick and chose what they want to keep. Harder to update stuff is in .rubocop_todo.yml. I've also updated some stuff in past PRs for fun.\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [ ] Squashed related commits together.\r\n* [ ] All tests(`rake spec`) are passing.\r\n* [x] The new code doesn't generate RuboCop offenses that are checked by `rake internal_investigation`.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/\r\n"},"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/330139421","html_url":"https://github.com/bbatsov/rubocop/pull/4733#issuecomment-330139421","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4733","id":330139421,"user":{"login":"backus","id":2085622,"avatar_url":"https://avatars3.githubusercontent.com/u/2085622?v=4","gravatar_id":"","url":"https://api.github.com/users/backus","html_url":"https://github.com/backus","followers_url":"https://api.github.com/users/backus/followers","following_url":"https://api.github.com/users/backus/following{/other_user}","gists_url":"https://api.github.com/users/backus/gists{/gist_id}","starred_url":"https://api.github.com/users/backus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backus/subscriptions","organizations_url":"https://api.github.com/users/backus/orgs","repos_url":"https://api.github.com/users/backus/repos","events_url":"https://api.github.com/users/backus/events{/privacy}","received_events_url":"https://api.github.com/users/backus/received_events","type":"User","site_admin":false},"created_at":"2017-09-18T06:43:43Z","updated_at":"2017-09-18T06:43:43Z","author_association":"CONTRIBUTOR","body":"> Out of curiosity - why 2.1 and not say 2.2. I'm just wondering if it was because of some language feature or dependency or because you wanted to supported only supported Rubies\r\n\r\nI removed both and people whined about 2.2 being dropped so I added it back: https://github.com/backus/rubocop-rspec/pull/131\r\n\r\nActually a pretty effective way to make the decision lol.\r\n\r\n"}}
{"actor":{"display_login":"backus"}}