{"action":"created","comment":{"url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/comments/119865184","pull_request_review_id":41785402,"id":119865184,"diff_hunk":"@@ -39,6 +39,11 @@\n # logging.basicConfig(level=logging.DEBUG, stream=sys.stdout)\n # logger.setLevel(logging.DEBUG)\n \n+def test_download(url):","path":"src/commoncode/fetch.py","position":4,"original_position":4,"commit_id":"a798ce5bd455a1727bec6f168595c9c8687660a3","original_commit_id":"a798ce5bd455a1727bec6f168595c9c8687660a3","user":{"login":"pombredanne","id":675997,"avatar_url":"https://avatars1.githubusercontent.com/u/675997?v=3","gravatar_id":"","url":"https://api.github.com/users/pombredanne","html_url":"https://github.com/pombredanne","followers_url":"https://api.github.com/users/pombredanne/followers","following_url":"https://api.github.com/users/pombredanne/following{/other_user}","gists_url":"https://api.github.com/users/pombredanne/gists{/gist_id}","starred_url":"https://api.github.com/users/pombredanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pombredanne/subscriptions","organizations_url":"https://api.github.com/users/pombredanne/orgs","repos_url":"https://api.github.com/users/pombredanne/repos","events_url":"https://api.github.com/users/pombredanne/events{/privacy}","received_events_url":"https://api.github.com/users/pombredanne/received_events","type":"User","site_admin":false},"body":"Would you mind call this check_download? Also what's the value to download and discard?","created_at":"2017-06-02T14:08:48Z","updated_at":"2017-06-02T14:10:31Z","html_url":"https://github.com/nexB/scancode-toolkit/pull/590#discussion_r119865184","pull_request_url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590","_links":{"self":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/comments/119865184"},"html":{"href":"https://github.com/nexB/scancode-toolkit/pull/590#discussion_r119865184"},"pull_request":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590"}}},"pull_request":{"url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590","id":115356677,"html_url":"https://github.com/nexB/scancode-toolkit/pull/590","diff_url":"https://github.com/nexB/scancode-toolkit/pull/590.diff","patch_url":"https://github.com/nexB/scancode-toolkit/pull/590.patch","issue_url":"https://api.github.com/repos/nexB/scancode-toolkit/issues/590","number":590,"state":"open","locked":false,"title":"URL unreachable if not 200 HTTP status","user":{"login":"marcreyesph","id":8190567,"avatar_url":"https://avatars2.githubusercontent.com/u/8190567?v=3","gravatar_id":"","url":"https://api.github.com/users/marcreyesph","html_url":"https://github.com/marcreyesph","followers_url":"https://api.github.com/users/marcreyesph/followers","following_url":"https://api.github.com/users/marcreyesph/following{/other_user}","gists_url":"https://api.github.com/users/marcreyesph/gists{/gist_id}","starred_url":"https://api.github.com/users/marcreyesph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcreyesph/subscriptions","organizations_url":"https://api.github.com/users/marcreyesph/orgs","repos_url":"https://api.github.com/users/marcreyesph/repos","events_url":"https://api.github.com/users/marcreyesph/events{/privacy}","received_events_url":"https://api.github.com/users/marcreyesph/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Marc Reyes <marcreyesmedia@gmail.com>\r\n\r\n@pombredanne, I added something to fetch.py (which is stated as TO DO in the said file) where the URL to be fetched is in 200 HTTP status or not. Returns True if the HTTP status is 200 and False if not. ","created_at":"2017-04-11T16:02:26Z","updated_at":"2017-06-02T14:10:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"317f360cbecbc5b52815e54104266af0eb6b7d13","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590/commits","review_comments_url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590/comments","review_comment_url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nexB/scancode-toolkit/issues/590/comments","statuses_url":"https://api.github.com/repos/nexB/scancode-toolkit/statuses/a798ce5bd455a1727bec6f168595c9c8687660a3","head":{"label":"marcreyesph:develop","ref":"develop","sha":"a798ce5bd455a1727bec6f168595c9c8687660a3","user":{"login":"marcreyesph","id":8190567,"avatar_url":"https://avatars2.githubusercontent.com/u/8190567?v=3","gravatar_id":"","url":"https://api.github.com/users/marcreyesph","html_url":"https://github.com/marcreyesph","followers_url":"https://api.github.com/users/marcreyesph/followers","following_url":"https://api.github.com/users/marcreyesph/following{/other_user}","gists_url":"https://api.github.com/users/marcreyesph/gists{/gist_id}","starred_url":"https://api.github.com/users/marcreyesph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcreyesph/subscriptions","organizations_url":"https://api.github.com/users/marcreyesph/orgs","repos_url":"https://api.github.com/users/marcreyesph/repos","events_url":"https://api.github.com/users/marcreyesph/events{/privacy}","received_events_url":"https://api.github.com/users/marcreyesph/received_events","type":"User","site_admin":false},"repo":{"id":87443459,"name":"scancode-toolkit","full_name":"marcreyesph/scancode-toolkit","owner":{"login":"marcreyesph","id":8190567,"avatar_url":"https://avatars2.githubusercontent.com/u/8190567?v=3","gravatar_id":"","url":"https://api.github.com/users/marcreyesph","html_url":"https://github.com/marcreyesph","followers_url":"https://api.github.com/users/marcreyesph/followers","following_url":"https://api.github.com/users/marcreyesph/following{/other_user}","gists_url":"https://api.github.com/users/marcreyesph/gists{/gist_id}","starred_url":"https://api.github.com/users/marcreyesph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcreyesph/subscriptions","organizations_url":"https://api.github.com/users/marcreyesph/orgs","repos_url":"https://api.github.com/users/marcreyesph/repos","events_url":"https://api.github.com/users/marcreyesph/events{/privacy}","received_events_url":"https://api.github.com/users/marcreyesph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcreyesph/scancode-toolkit","description":"ScanCode is a tool to scan code and detect licenses, copyrights, packages metadata & dependencies and more... to find, discover, inventory open source and third-party components used in your code.","fork":true,"url":"https://api.github.com/repos/marcreyesph/scancode-toolkit","forks_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/forks","keys_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/teams","hooks_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/hooks","issue_events_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/events","assignees_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/tags","blobs_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/languages","stargazers_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/stargazers","contributors_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/contributors","subscribers_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/subscribers","subscription_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/subscription","commits_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/merges","archive_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/downloads","issues_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/marcreyesph/scancode-toolkit/deployments","created_at":"2017-04-06T15:12:26Z","updated_at":"2017-04-06T15:12:48Z","pushed_at":"2017-04-19T19:00:03Z","git_url":"git://github.com/marcreyesph/scancode-toolkit.git","ssh_url":"git@github.com:marcreyesph/scancode-toolkit.git","clone_url":"https://github.com/marcreyesph/scancode-toolkit.git","svn_url":"https://github.com/marcreyesph/scancode-toolkit","homepage":"https://github.com/nexB/scancode-toolkit/releases/latest","size":152394,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"nexB:develop","ref":"develop","sha":"bd6ae3a170ccd1a2c55489b652b48b2fe5485381","user":{"login":"nexB","id":10789967,"avatar_url":"https://avatars0.githubusercontent.com/u/10789967?v=3","gravatar_id":"","url":"https://api.github.com/users/nexB","html_url":"https://github.com/nexB","followers_url":"https://api.github.com/users/nexB/followers","following_url":"https://api.github.com/users/nexB/following{/other_user}","gists_url":"https://api.github.com/users/nexB/gists{/gist_id}","starred_url":"https://api.github.com/users/nexB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexB/subscriptions","organizations_url":"https://api.github.com/users/nexB/orgs","repos_url":"https://api.github.com/users/nexB/repos","events_url":"https://api.github.com/users/nexB/events{/privacy}","received_events_url":"https://api.github.com/users/nexB/received_events","type":"Organization","site_admin":false},"repo":{"id":38373338,"name":"scancode-toolkit","full_name":"nexB/scancode-toolkit","owner":{"login":"nexB","id":10789967,"avatar_url":"https://avatars0.githubusercontent.com/u/10789967?v=3","gravatar_id":"","url":"https://api.github.com/users/nexB","html_url":"https://github.com/nexB","followers_url":"https://api.github.com/users/nexB/followers","following_url":"https://api.github.com/users/nexB/following{/other_user}","gists_url":"https://api.github.com/users/nexB/gists{/gist_id}","starred_url":"https://api.github.com/users/nexB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexB/subscriptions","organizations_url":"https://api.github.com/users/nexB/orgs","repos_url":"https://api.github.com/users/nexB/repos","events_url":"https://api.github.com/users/nexB/events{/privacy}","received_events_url":"https://api.github.com/users/nexB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nexB/scancode-toolkit","description":"ScanCode is a tool to scan code and detect licenses, copyrights, packages metadata & dependencies and more... to find, discover, inventory open source and third-party components used in your code.","fork":false,"url":"https://api.github.com/repos/nexB/scancode-toolkit","forks_url":"https://api.github.com/repos/nexB/scancode-toolkit/forks","keys_url":"https://api.github.com/repos/nexB/scancode-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nexB/scancode-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nexB/scancode-toolkit/teams","hooks_url":"https://api.github.com/repos/nexB/scancode-toolkit/hooks","issue_events_url":"https://api.github.com/repos/nexB/scancode-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/nexB/scancode-toolkit/events","assignees_url":"https://api.github.com/repos/nexB/scancode-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/nexB/scancode-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/nexB/scancode-toolkit/tags","blobs_url":"https://api.github.com/repos/nexB/scancode-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nexB/scancode-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nexB/scancode-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nexB/scancode-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nexB/scancode-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/nexB/scancode-toolkit/languages","stargazers_url":"https://api.github.com/repos/nexB/scancode-toolkit/stargazers","contributors_url":"https://api.github.com/repos/nexB/scancode-toolkit/contributors","subscribers_url":"https://api.github.com/repos/nexB/scancode-toolkit/subscribers","subscription_url":"https://api.github.com/repos/nexB/scancode-toolkit/subscription","commits_url":"https://api.github.com/repos/nexB/scancode-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nexB/scancode-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nexB/scancode-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nexB/scancode-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nexB/scancode-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/nexB/scancode-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nexB/scancode-toolkit/merges","archive_url":"https://api.github.com/repos/nexB/scancode-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nexB/scancode-toolkit/downloads","issues_url":"https://api.github.com/repos/nexB/scancode-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/nexB/scancode-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/nexB/scancode-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/nexB/scancode-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nexB/scancode-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/nexB/scancode-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/nexB/scancode-toolkit/deployments","created_at":"2015-07-01T13:43:06Z","updated_at":"2017-05-30T12:35:40Z","pushed_at":"2017-06-02T13:53:14Z","git_url":"git://github.com/nexB/scancode-toolkit.git","ssh_url":"git@github.com:nexB/scancode-toolkit.git","clone_url":"https://github.com/nexB/scancode-toolkit.git","svn_url":"https://github.com/nexB/scancode-toolkit","homepage":"https://github.com/nexB/scancode-toolkit/releases/latest","size":155306,"stargazers_count":194,"watchers_count":194,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":172,"forks":65,"open_issues":172,"watchers":194,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590"},"html":{"href":"https://github.com/nexB/scancode-toolkit/pull/590"},"issue":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/issues/590"},"comments":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/nexB/scancode-toolkit/statuses/a798ce5bd455a1727bec6f168595c9c8687660a3"}}}}
{"actor":{"display_login":"pombredanne"}}