{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9591","repository_url":"https://api.github.com/repos/hazelcast/hazelcast","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9591/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9591/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9591/events","html_url":"https://github.com/hazelcast/hazelcast/pull/9591","id":198978644,"number":9591,"title":"Introduces test for Map merge after split brain","user":{"login":"vbekiaris","id":1212378,"avatar_url":"https://avatars.githubusercontent.com/u/1212378?v=3","gravatar_id":"","url":"https://api.github.com/users/vbekiaris","html_url":"https://github.com/vbekiaris","followers_url":"https://api.github.com/users/vbekiaris/followers","following_url":"https://api.github.com/users/vbekiaris/following{/other_user}","gists_url":"https://api.github.com/users/vbekiaris/gists{/gist_id}","starred_url":"https://api.github.com/users/vbekiaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbekiaris/subscriptions","organizations_url":"https://api.github.com/users/vbekiaris/orgs","repos_url":"https://api.github.com/users/vbekiaris/repos","events_url":"https://api.github.com/users/vbekiaris/events{/privacy}","received_events_url":"https://api.github.com/users/vbekiaris/received_events","type":"User","site_admin":false},"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740692,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76","html_url":"https://github.com/hazelcast/hazelcast/milestone/76","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76/labels","id":1774122,"number":76,"title":"3.8","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":625,"state":"open","created_at":"2016-05-18T14:13:56Z","updated_at":"2017-01-09T07:21:30Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-01-05T15:13:41Z","updated_at":"2017-01-09T07:54:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9591","html_url":"https://github.com/hazelcast/hazelcast/pull/9591","diff_url":"https://github.com/hazelcast/hazelcast/pull/9591.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/9591.patch"},"body":"Adds a test to verify that `MapMergePolicy.merge` is invoked for all entries being merged after split-brain is healed (related to #9358)."},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/271226588","html_url":"https://github.com/hazelcast/hazelcast/pull/9591#issuecomment-271226588","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9591","id":271226588,"user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"created_at":"2017-01-09T07:54:32Z","updated_at":"2017-01-09T07:54:32Z","body":"the test is checking a merge policy was invoked. However there is no check the value returned by the policy was actually applied -> It's still possible to have a broken merge policy and this test would pass.\r\n\r\nI'd suggest to add a test checking effects of the merge policy instead of checking whether it was invoked. \r\n\r\nI can imagine this:\r\n1. have `AddingMergePolicy`\r\n2. the first brain add entries with keys `0...1999` and value `1`\r\n3. the 2nd brain add entries with keys `1000.2999` andwith value `2`\r\n3. heal the split-brain\r\n4. assert\r\n- keys `0...999` have value `1`\r\n- keys `1000...1999` have values `3`\r\n- keys `2000....2999` have value `2`\r\n\r\nOr something along those lines."}}
{"actor":{"display_login":"jerrinot"}}