{"action":"closed","number":959,"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959","id":132962387,"html_url":"https://github.com/wso2/carbon-identity-framework/pull/959","diff_url":"https://github.com/wso2/carbon-identity-framework/pull/959.diff","patch_url":"https://github.com/wso2/carbon-identity-framework/pull/959.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/959","number":959,"state":"closed","locked":false,"title":"IDENTITY-4127 setting scim password provisioning by default","user":{"login":"madumalt","id":4003149,"avatar_url":"https://avatars1.githubusercontent.com/u/4003149?v=4","gravatar_id":"","url":"https://api.github.com/users/madumalt","html_url":"https://github.com/madumalt","followers_url":"https://api.github.com/users/madumalt/followers","following_url":"https://api.github.com/users/madumalt/following{/other_user}","gists_url":"https://api.github.com/users/madumalt/gists{/gist_id}","starred_url":"https://api.github.com/users/madumalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madumalt/subscriptions","organizations_url":"https://api.github.com/users/madumalt/orgs","repos_url":"https://api.github.com/users/madumalt/repos","events_url":"https://api.github.com/users/madumalt/events{/privacy}","received_events_url":"https://api.github.com/users/madumalt/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\n- bug fix\r\n- https://wso2.org/jira/browse/IDENTITY-4127\r\n\r\n### When should this PR be merged\r\n\r\n- before 5.4.0 release \r\n\r\n### Follow up actions\r\n\r\n- None\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [x] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [x] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [x] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [x] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [x] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [x] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [x] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2017-07-28T12:53:28Z","updated_at":"2017-08-01T05:29:37Z","closed_at":"2017-08-01T05:29:37Z","merged_at":"2017-08-01T05:29:37Z","merge_commit_sha":"ec712b73dcf201d345ea261981f65dbba5a75171","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/959/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/52f9abb7e8a4cbb68037a671c1a5319f555ac10e","head":{"label":"madumalt:IDENTITY-4127","ref":"IDENTITY-4127","sha":"52f9abb7e8a4cbb68037a671c1a5319f555ac10e","user":{"login":"madumalt","id":4003149,"avatar_url":"https://avatars1.githubusercontent.com/u/4003149?v=4","gravatar_id":"","url":"https://api.github.com/users/madumalt","html_url":"https://github.com/madumalt","followers_url":"https://api.github.com/users/madumalt/followers","following_url":"https://api.github.com/users/madumalt/following{/other_user}","gists_url":"https://api.github.com/users/madumalt/gists{/gist_id}","starred_url":"https://api.github.com/users/madumalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madumalt/subscriptions","organizations_url":"https://api.github.com/users/madumalt/orgs","repos_url":"https://api.github.com/users/madumalt/repos","events_url":"https://api.github.com/users/madumalt/events{/privacy}","received_events_url":"https://api.github.com/users/madumalt/received_events","type":"User","site_admin":false},"repo":{"id":94981326,"name":"carbon-identity-framework","full_name":"madumalt/carbon-identity-framework","owner":{"login":"madumalt","id":4003149,"avatar_url":"https://avatars1.githubusercontent.com/u/4003149?v=4","gravatar_id":"","url":"https://api.github.com/users/madumalt","html_url":"https://github.com/madumalt","followers_url":"https://api.github.com/users/madumalt/followers","following_url":"https://api.github.com/users/madumalt/following{/other_user}","gists_url":"https://api.github.com/users/madumalt/gists{/gist_id}","starred_url":"https://api.github.com/users/madumalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madumalt/subscriptions","organizations_url":"https://api.github.com/users/madumalt/orgs","repos_url":"https://api.github.com/users/madumalt/repos","events_url":"https://api.github.com/users/madumalt/events{/privacy}","received_events_url":"https://api.github.com/users/madumalt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madumalt/carbon-identity-framework","description":null,"fork":true,"url":"https://api.github.com/repos/madumalt/carbon-identity-framework","forks_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/madumalt/carbon-identity-framework/deployments","created_at":"2017-06-21T08:28:14Z","updated_at":"2017-06-21T08:28:22Z","pushed_at":"2017-08-01T05:18:04Z","git_url":"git://github.com/madumalt/carbon-identity-framework.git","ssh_url":"git@github.com:madumalt/carbon-identity-framework.git","clone_url":"https://github.com/madumalt/carbon-identity-framework.git","svn_url":"https://github.com/madumalt/carbon-identity-framework","homepage":null,"size":59347,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"33e4cc987a141021f32fc861b20a76d903b623de","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":52329722,"name":"carbon-identity-framework","full_name":"wso2/carbon-identity-framework","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity-framework","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity-framework","forks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/deployments","created_at":"2016-02-23T04:20:26Z","updated_at":"2017-05-18T10:58:57Z","pushed_at":"2017-08-01T05:29:37Z","git_url":"git://github.com/wso2/carbon-identity-framework.git","ssh_url":"git@github.com:wso2/carbon-identity-framework.git","clone_url":"https://github.com/wso2/carbon-identity-framework.git","svn_url":"https://github.com/wso2/carbon-identity-framework","homepage":null,"size":59809,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":27,"forks":115,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/959"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/959"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/959/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/959/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/52f9abb7e8a4cbb68037a671c1a5319f555ac10e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rushmin","id":1607954,"avatar_url":"https://avatars1.githubusercontent.com/u/1607954?v=4","gravatar_id":"","url":"https://api.github.com/users/rushmin","html_url":"https://github.com/rushmin","followers_url":"https://api.github.com/users/rushmin/followers","following_url":"https://api.github.com/users/rushmin/following{/other_user}","gists_url":"https://api.github.com/users/rushmin/gists{/gist_id}","starred_url":"https://api.github.com/users/rushmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushmin/subscriptions","organizations_url":"https://api.github.com/users/rushmin/orgs","repos_url":"https://api.github.com/users/rushmin/repos","events_url":"https://api.github.com/users/rushmin/events{/privacy}","received_events_url":"https://api.github.com/users/rushmin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"rushmin"}}