{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/platform/issues/6129","repository_url":"https://api.github.com/repos/mattermost/platform","labels_url":"https://api.github.com/repos/mattermost/platform/issues/6129/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/platform/issues/6129/comments","events_url":"https://api.github.com/repos/mattermost/platform/issues/6129/events","html_url":"https://github.com/mattermost/platform/pull/6129","id":222035340,"number":6129,"title":"[GH-5915] Clicking on @mention of a user in a post shows the profile popover","user":{"login":"saturninoabril","id":5334504,"avatar_url":"https://avatars1.githubusercontent.com/u/5334504?v=3","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"labels":[{"id":297541710,"url":"https://api.github.com/repos/mattermost/platform/labels/1:%20PM%20Review","name":"1: PM Review","color":"006b75","default":false},{"id":308747687,"url":"https://api.github.com/repos/mattermost/platform/labels/Setup%20Test%20Server","name":"Setup Test Server","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"jasonblais","id":13119842,"avatar_url":"https://avatars2.githubusercontent.com/u/13119842?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonblais","html_url":"https://github.com/jasonblais","followers_url":"https://api.github.com/users/jasonblais/followers","following_url":"https://api.github.com/users/jasonblais/following{/other_user}","gists_url":"https://api.github.com/users/jasonblais/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonblais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonblais/subscriptions","organizations_url":"https://api.github.com/users/jasonblais/orgs","repos_url":"https://api.github.com/users/jasonblais/repos","events_url":"https://api.github.com/users/jasonblais/events{/privacy}","received_events_url":"https://api.github.com/users/jasonblais/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasonblais","id":13119842,"avatar_url":"https://avatars2.githubusercontent.com/u/13119842?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonblais","html_url":"https://github.com/jasonblais","followers_url":"https://api.github.com/users/jasonblais/followers","following_url":"https://api.github.com/users/jasonblais/following{/other_user}","gists_url":"https://api.github.com/users/jasonblais/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonblais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonblais/subscriptions","organizations_url":"https://api.github.com/users/jasonblais/orgs","repos_url":"https://api.github.com/users/jasonblais/repos","events_url":"https://api.github.com/users/jasonblais/events{/privacy}","received_events_url":"https://api.github.com/users/jasonblais/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2017-04-16T21:46:23Z","updated_at":"2017-04-20T22:19:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mattermost/platform/pulls/6129","html_url":"https://github.com/mattermost/platform/pull/6129","diff_url":"https://github.com/mattermost/platform/pull/6129.diff","patch_url":"https://github.com/mattermost/platform/pull/6129.patch"},"body":"#### Summary\r\nClicking on @mention of a user in a post shows the profile popover.\r\n\r\nThis is an experimental PR which introduced third-party library [\"html-to-react\": \"1.2.7\"](https://github.com/aknuds1/html-to-react).\r\n\r\nChanges include:\r\n- renaming of profile popover components,\r\n- reorganization of profile popover components into its folder `components\\profile_popover`,\r\n- converting post message html into react components and get rid off `dangerouslySetInnerHTML` at `post_view/components/post_message_view.jsx`,\r\n\r\n#### Ticket Link\r\nGitHub issue: #5915\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Has UI changes\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/platform/issues/comments/295941288","html_url":"https://github.com/mattermost/platform/pull/6129#issuecomment-295941288","issue_url":"https://api.github.com/repos/mattermost/platform/issues/6129","id":295941288,"user":{"login":"jasonblais","id":13119842,"avatar_url":"https://avatars2.githubusercontent.com/u/13119842?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonblais","html_url":"https://github.com/jasonblais","followers_url":"https://api.github.com/users/jasonblais/followers","following_url":"https://api.github.com/users/jasonblais/following{/other_user}","gists_url":"https://api.github.com/users/jasonblais/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonblais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonblais/subscriptions","organizations_url":"https://api.github.com/users/jasonblais/orgs","repos_url":"https://api.github.com/users/jasonblais/repos","events_url":"https://api.github.com/users/jasonblais/events{/privacy}","received_events_url":"https://api.github.com/users/jasonblais/received_events","type":"User","site_admin":false},"created_at":"2017-04-20T22:19:43Z","updated_at":"2017-04-20T22:19:43Z","body":"Tested the same steps, all works great.\r\n\r\nJust one other minor nit: when `username `doesn't exist, `@username` shouldn't be clickable.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13119842/25254876/ec3f3e5a-25f5-11e7-86af-48226c6146b6.png)\r\n\r\n\r\nI think the issue arises due to this PR, which autolinks anything that looks like an at mention https://github.com/mattermost/platform/pull/4416\r\n\r\nThere is a separate ticket scheduled for 3.9, which has the server store at mentions including the user's ID. Wondering if that will fix the issue? https://mattermost.atlassian.net/browse/PLT-4457"}}
{"actor":{"display_login":"jasonblais"}}