{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/comments/120936475","pull_request_review_id":42943865,"id":120936475,"diff_hunk":"@@ -84,9 +84,9 @@ def _main():\n             sys.exit(1)\n \n         logging.debug('Deploying app!')\n-        version, deploy_url = deploy_app.deploy_app(args.image, args.directory)\n+        version = deploy_app.deploy_app(args.image, args.directory)\n \n-    application_url = args.url or deploy_url\n+    application_url = args.url or test_util.retrieve_url_for_version(version)","path":"integration_tests/testsuite/driver.py","position":null,"original_position":24,"commit_id":"c279a717b7d337672edf69f0621399e085ee8390","original_commit_id":"c279a717b7d337672edf69f0621399e085ee8390","user":{"login":"dlorenc","id":1714486,"avatar_url":"https://avatars2.githubusercontent.com/u/1714486?v=3","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false},"body":"This sort of makes me wonder if we should drop the deploy flag, and just treat a test run that gets passed an args.url as the same as no deploy. WDYT?\r\n\r\nBasically if someone doesn't give us a URL, we deploy. If they do, we don't deploy.","created_at":"2017-06-08T16:30:03Z","updated_at":"2017-06-08T16:30:05Z","html_url":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187#discussion_r120936475","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/comments/120936475"},"html":{"href":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187#discussion_r120936475"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187","id":124069723,"html_url":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187","diff_url":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187.diff","patch_url":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/187","number":187,"state":"open","locked":false,"title":"Deploy app with version to avoid collisions, and don't stop previous version","user":{"login":"nkubala","id":5531168,"avatar_url":"https://avatars1.githubusercontent.com/u/5531168?v=3","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"body":"This will allow us to run multiple integration test runs simultaneously.\r\n\r\n@sharifelgamal @dlorenc ","created_at":"2017-06-05T21:57:58Z","updated_at":"2017-06-08T16:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"658edbbc75159b6dc967c05a19bb447b2a3f4858","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/187/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/statuses/c279a717b7d337672edf69f0621399e085ee8390","head":{"label":"nkubala:deploy_version","ref":"deploy_version","sha":"c279a717b7d337672edf69f0621399e085ee8390","user":{"login":"nkubala","id":5531168,"avatar_url":"https://avatars1.githubusercontent.com/u/5531168?v=3","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"repo":{"id":70737492,"name":"runtimes-common","full_name":"nkubala/runtimes-common","owner":{"login":"nkubala","id":5531168,"avatar_url":"https://avatars1.githubusercontent.com/u/5531168?v=3","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkubala/runtimes-common","description":null,"fork":true,"url":"https://api.github.com/repos/nkubala/runtimes-common","forks_url":"https://api.github.com/repos/nkubala/runtimes-common/forks","keys_url":"https://api.github.com/repos/nkubala/runtimes-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkubala/runtimes-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkubala/runtimes-common/teams","hooks_url":"https://api.github.com/repos/nkubala/runtimes-common/hooks","issue_events_url":"https://api.github.com/repos/nkubala/runtimes-common/issues/events{/number}","events_url":"https://api.github.com/repos/nkubala/runtimes-common/events","assignees_url":"https://api.github.com/repos/nkubala/runtimes-common/assignees{/user}","branches_url":"https://api.github.com/repos/nkubala/runtimes-common/branches{/branch}","tags_url":"https://api.github.com/repos/nkubala/runtimes-common/tags","blobs_url":"https://api.github.com/repos/nkubala/runtimes-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkubala/runtimes-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkubala/runtimes-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkubala/runtimes-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkubala/runtimes-common/statuses/{sha}","languages_url":"https://api.github.com/repos/nkubala/runtimes-common/languages","stargazers_url":"https://api.github.com/repos/nkubala/runtimes-common/stargazers","contributors_url":"https://api.github.com/repos/nkubala/runtimes-common/contributors","subscribers_url":"https://api.github.com/repos/nkubala/runtimes-common/subscribers","subscription_url":"https://api.github.com/repos/nkubala/runtimes-common/subscription","commits_url":"https://api.github.com/repos/nkubala/runtimes-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkubala/runtimes-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkubala/runtimes-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkubala/runtimes-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkubala/runtimes-common/contents/{+path}","compare_url":"https://api.github.com/repos/nkubala/runtimes-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkubala/runtimes-common/merges","archive_url":"https://api.github.com/repos/nkubala/runtimes-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkubala/runtimes-common/downloads","issues_url":"https://api.github.com/repos/nkubala/runtimes-common/issues{/number}","pulls_url":"https://api.github.com/repos/nkubala/runtimes-common/pulls{/number}","milestones_url":"https://api.github.com/repos/nkubala/runtimes-common/milestones{/number}","notifications_url":"https://api.github.com/repos/nkubala/runtimes-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkubala/runtimes-common/labels{/name}","releases_url":"https://api.github.com/repos/nkubala/runtimes-common/releases{/id}","deployments_url":"https://api.github.com/repos/nkubala/runtimes-common/deployments","created_at":"2016-10-12T20:12:35Z","updated_at":"2016-10-13T19:13:25Z","pushed_at":"2017-06-07T21:56:35Z","git_url":"git://github.com/nkubala/runtimes-common.git","ssh_url":"git@github.com:nkubala/runtimes-common.git","clone_url":"https://github.com/nkubala/runtimes-common.git","svn_url":"https://github.com/nkubala/runtimes-common","homepage":null,"size":1657,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"2eff2b835fe4a042c06b92844c9fa5c92cbeb3ea","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":67721213,"name":"runtimes-common","full_name":"GoogleCloudPlatform/runtimes-common","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/runtimes-common","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/deployments","created_at":"2016-09-08T16:33:38Z","updated_at":"2017-05-09T19:12:17Z","pushed_at":"2017-06-07T21:56:37Z","git_url":"git://github.com/GoogleCloudPlatform/runtimes-common.git","ssh_url":"git@github.com:GoogleCloudPlatform/runtimes-common.git","clone_url":"https://github.com/GoogleCloudPlatform/runtimes-common.git","svn_url":"https://github.com/GoogleCloudPlatform/runtimes-common","homepage":null,"size":1580,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187"},"html":{"href":"https://github.com/GoogleCloudPlatform/runtimes-common/pull/187"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/187"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/runtimes-common/statuses/c279a717b7d337672edf69f0621399e085ee8390"}}}}
{"actor":{"display_login":"dlorenc"}}