{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4449","repository_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4449/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4449/comments","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4449/events","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4449","id":221070802,"number":4449,"title":"Added support for editable association fields from type choice in Lis…","user":{"login":"christingruber","id":1124818,"avatar_url":"https://avatars1.githubusercontent.com/u/1124818?v=3","gravatar_id":"","url":"https://api.github.com/users/christingruber","html_url":"https://github.com/christingruber","followers_url":"https://api.github.com/users/christingruber/followers","following_url":"https://api.github.com/users/christingruber/following{/other_user}","gists_url":"https://api.github.com/users/christingruber/gists{/gist_id}","starred_url":"https://api.github.com/users/christingruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christingruber/subscriptions","organizations_url":"https://api.github.com/users/christingruber/orgs","repos_url":"https://api.github.com/users/christingruber/repos","events_url":"https://api.github.com/users/christingruber/events{/privacy}","received_events_url":"https://api.github.com/users/christingruber/received_events","type":"User","site_admin":false},"labels":[{"id":356102365,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/minor","name":"minor","color":"009800","default":false},{"id":25780218,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/review%20required","name":"review required","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-11T20:27:23Z","updated_at":"2017-05-03T12:55:40Z","closed_at":"2017-04-24T20:11:41Z","pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4449","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4449","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4449.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4449.patch"},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataAdminBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because this is new feature with BC.\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Added\r\n- Added editable support for association fields from type choice in `ListMapper`\r\n- Added also new `class` option for field description\r\n```\r\n\r\n## To do\r\n\r\n<!--\r\n    If this is a work in progress, COMPLETE and ADD needed tasks.\r\n    You can add as many tasks as you want.\r\n    If some are not relevant, just REMOVE them.\r\n-->\r\n\r\n- [x] Update the tests\r\n- [x] Update the documentation\r\n\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\n\r\nAdded support for **editable association fields** from type choice in ListMapper, also **added new field description option class**. As example:\r\n\r\n```php\r\n    protected function configureListFields(ListMapper $listMapper)\r\n    {\r\n        $listMapper\r\n            ->add('status', 'choice', array(\r\n                'editable' => true,\r\n                'class' => 'Vendor\\ExampleBundle\\Entity\\PageStatus',\r\n                'choices' => array(\r\n                    1 => 'Active',\r\n                    2 => 'Inactive',\r\n                    3 => 'Draft',\r\n                ),\r\n            ));\r\n    }\r\n```"},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments/298902574","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4449#issuecomment-298902574","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4449","id":298902574,"user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars2.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T12:55:40Z","updated_at":"2017-05-03T12:55:40Z","body":"> how is this BC break compatible with semver\r\n\r\nIt clearly isn't, I just wasn't aware that was part of a public API. Would you kindly make a PR that would restore the array, but keep the status code? Also, we should deprecate this key, but I'm can't see how to achieve that with JSON."}}
{"actor":{"display_login":"greg0ire"}}