{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/136121684","pull_request_review_id":59616873,"id":136121684,"diff_hunk":"@@ -635,3 +635,21 @@ def _configure_security_policy_storage_params(cmd):\n                options_list=('--end-ip-address',),\n                help='The end IP address of the firewall rule. Must be IPv4 format. Use value'\n                ' \\'0.0.0.0\\' to represent all Azure-internal IP addresses.')\n+\n+\n+#####\n+#           sql server vnet-rule\n+#####\n+\n+\n+with ParametersContext(command='sql server vnet-rule') as c:\n+    # Help text needs to be specified because 'sql server firewall-rule update' is a custom\n+    # command.\n+    c.argument('server_name',\n+               options_list=('--server', '-s'))\n+\n+    c.argument('virtual_network_rule_name',\n+               options_list=('--name', '-n'))\n+\n+    c.argument('virtual_network_subnet_id',\n+               options_list=('--vnet-subnet-id', '-v'))","path":"src/command_modules/azure-cli-sql/azure/cli/command_modules/sql/params.py","position":21,"original_position":21,"commit_id":"2a0ceb322c6128cd8b11d3733b1b423c9fd2bcba","original_commit_id":"a40b50a43461b5bad8cce60f092b612709c6ba00","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars2.githubusercontent.com/u/5723682?v=4","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"This is about consistency with the entire CLI--the storage commands were just an easy example since they are related to the same feature. NICs, load balancers... anywhere in the CLI that a subnet ID is required by the service or SDK, the CLI exposes this as `--subnet NAME_OR_ID --vnet-name NAME`.","created_at":"2017-08-30T16:32:24Z","updated_at":"2017-08-30T16:32:24Z","html_url":"https://github.com/Azure/azure-cli/pull/4343#discussion_r136121684","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/4343","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/136121684"},"html":{"href":"https://github.com/Azure/azure-cli/pull/4343#discussion_r136121684"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4343"}},"in_reply_to_id":135940383},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/4343","id":138303162,"html_url":"https://github.com/Azure/azure-cli/pull/4343","diff_url":"https://github.com/Azure/azure-cli/pull/4343.diff","patch_url":"https://github.com/Azure/azure-cli/pull/4343.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/4343","number":4343,"state":"open","locked":false,"title":"Adding functionality for Virtual Network Rules (Vnet)","user":{"login":"dnayantara","id":5552364,"avatar_url":"https://avatars3.githubusercontent.com/u/5552364?v=4","gravatar_id":"","url":"https://api.github.com/users/dnayantara","html_url":"https://github.com/dnayantara","followers_url":"https://api.github.com/users/dnayantara/followers","following_url":"https://api.github.com/users/dnayantara/following{/other_user}","gists_url":"https://api.github.com/users/dnayantara/gists{/gist_id}","starred_url":"https://api.github.com/users/dnayantara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnayantara/subscriptions","organizations_url":"https://api.github.com/users/dnayantara/orgs","repos_url":"https://api.github.com/users/dnayantara/repos","events_url":"https://api.github.com/users/dnayantara/events{/privacy}","received_events_url":"https://api.github.com/users/dnayantara/received_events","type":"User","site_admin":false},"body":"This change adds functionality for the feature - Virtual Network Rules.\r\naz sql server vnet-rule commands are -\r\n\r\n    create: Creates or updates an existing virtual network rule.\r\n    delete: Deletes the virtual network rule with the given name.\r\n    list  : Gets a list of virtual network rules in a server.\r\n    show  : Gets a virtual network rule.\r\n    update: Updates a virtual network rule.\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n### General Guidelines\r\n\r\n- [x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n### Command Guidelines\r\n\r\n- [x] Each command and parameter has a meaningful description.\r\n- [x] Each new command has a test.\r\n\r\n(see [Authoring Command Modules](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules))\r\n","created_at":"2017-08-29T23:01:05Z","updated_at":"2017-08-30T16:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"741c310c39f1db121ada0586dd09cbe0bea29058","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Azure/azure-cli/milestones/24","html_url":"https://github.com/Azure/azure-cli/milestone/24","labels_url":"https://api.github.com/repos/Azure/azure-cli/milestones/24/labels","id":2579249,"number":24,"title":"Sprint 22 - Ignite Preview","description":"","creator":{"login":"JasonRShaver","id":10146011,"avatar_url":"https://avatars3.githubusercontent.com/u/10146011?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonRShaver","html_url":"https://github.com/JasonRShaver","followers_url":"https://api.github.com/users/JasonRShaver/followers","following_url":"https://api.github.com/users/JasonRShaver/following{/other_user}","gists_url":"https://api.github.com/users/JasonRShaver/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonRShaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonRShaver/subscriptions","organizations_url":"https://api.github.com/users/JasonRShaver/orgs","repos_url":"https://api.github.com/users/JasonRShaver/repos","events_url":"https://api.github.com/users/JasonRShaver/events{/privacy}","received_events_url":"https://api.github.com/users/JasonRShaver/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2017-06-13T01:16:47Z","updated_at":"2017-08-30T16:20:26Z","due_on":"2017-09-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/4343/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/4343/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/4343/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/2a0ceb322c6128cd8b11d3733b1b423c9fd2bcba","head":{"label":"dnayantara:master","ref":"master","sha":"2a0ceb322c6128cd8b11d3733b1b423c9fd2bcba","user":{"login":"dnayantara","id":5552364,"avatar_url":"https://avatars3.githubusercontent.com/u/5552364?v=4","gravatar_id":"","url":"https://api.github.com/users/dnayantara","html_url":"https://github.com/dnayantara","followers_url":"https://api.github.com/users/dnayantara/followers","following_url":"https://api.github.com/users/dnayantara/following{/other_user}","gists_url":"https://api.github.com/users/dnayantara/gists{/gist_id}","starred_url":"https://api.github.com/users/dnayantara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnayantara/subscriptions","organizations_url":"https://api.github.com/users/dnayantara/orgs","repos_url":"https://api.github.com/users/dnayantara/repos","events_url":"https://api.github.com/users/dnayantara/events{/privacy}","received_events_url":"https://api.github.com/users/dnayantara/received_events","type":"User","site_admin":false},"repo":{"id":99844060,"name":"azure-cli","full_name":"dnayantara/azure-cli","owner":{"login":"dnayantara","id":5552364,"avatar_url":"https://avatars3.githubusercontent.com/u/5552364?v=4","gravatar_id":"","url":"https://api.github.com/users/dnayantara","html_url":"https://github.com/dnayantara","followers_url":"https://api.github.com/users/dnayantara/followers","following_url":"https://api.github.com/users/dnayantara/following{/other_user}","gists_url":"https://api.github.com/users/dnayantara/gists{/gist_id}","starred_url":"https://api.github.com/users/dnayantara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnayantara/subscriptions","organizations_url":"https://api.github.com/users/dnayantara/orgs","repos_url":"https://api.github.com/users/dnayantara/repos","events_url":"https://api.github.com/users/dnayantara/events{/privacy}","received_events_url":"https://api.github.com/users/dnayantara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnayantara/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/dnayantara/azure-cli","forks_url":"https://api.github.com/repos/dnayantara/azure-cli/forks","keys_url":"https://api.github.com/repos/dnayantara/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnayantara/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnayantara/azure-cli/teams","hooks_url":"https://api.github.com/repos/dnayantara/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/dnayantara/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/dnayantara/azure-cli/events","assignees_url":"https://api.github.com/repos/dnayantara/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/dnayantara/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/dnayantara/azure-cli/tags","blobs_url":"https://api.github.com/repos/dnayantara/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnayantara/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnayantara/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnayantara/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnayantara/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dnayantara/azure-cli/languages","stargazers_url":"https://api.github.com/repos/dnayantara/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/dnayantara/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/dnayantara/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/dnayantara/azure-cli/subscription","commits_url":"https://api.github.com/repos/dnayantara/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnayantara/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnayantara/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnayantara/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnayantara/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/dnayantara/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnayantara/azure-cli/merges","archive_url":"https://api.github.com/repos/dnayantara/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnayantara/azure-cli/downloads","issues_url":"https://api.github.com/repos/dnayantara/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/dnayantara/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dnayantara/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dnayantara/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnayantara/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/dnayantara/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/dnayantara/azure-cli/deployments","created_at":"2017-08-09T19:09:21Z","updated_at":"2017-08-09T19:09:28Z","pushed_at":"2017-08-30T00:01:43Z","git_url":"git://github.com/dnayantara/azure-cli.git","ssh_url":"git@github.com:dnayantara/azure-cli.git","clone_url":"https://github.com/dnayantara/azure-cli.git","svn_url":"https://github.com/dnayantara/azure-cli","homepage":null,"size":25854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"04a74dc39e2b5fddc605a4fb1cf1990aa9e2dbe7","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2017-08-30T04:16:35Z","pushed_at":"2017-08-30T16:15:39Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":25901,"stargazers_count":499,"watchers_count":499,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":580,"forks":258,"open_issues":580,"watchers":499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4343"},"html":{"href":"https://github.com/Azure/azure-cli/pull/4343"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/4343"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/4343/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4343/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4343/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/2a0ceb322c6128cd8b11d3733b1b423c9fd2bcba"}},"author_association":"NONE"}}
{"actor":{"display_login":"tjprescott"}}