{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/122556403","pull_request_review_id":44688487,"id":122556403,"diff_hunk":"@@ -1,4 +1,5 @@\n-import * as settings from 'electron-settings';\n+import settings = require('electron-settings');\n+import Observer = require('electron-settings/lib/observer');","path":"types/electron-settings/v2/electron-settings-tests.ts","position":3,"original_position":3,"commit_id":"be0f70fbf2a9f9fcfd5f889bae408c7c408dbea6","original_commit_id":"be0f70fbf2a9f9fcfd5f889bae408c7c408dbea6","user":{"login":"minestarks","id":16928427,"avatar_url":"https://avatars2.githubusercontent.com/u/16928427?v=3","gravatar_id":"","url":"https://api.github.com/users/minestarks","html_url":"https://github.com/minestarks","followers_url":"https://api.github.com/users/minestarks/followers","following_url":"https://api.github.com/users/minestarks/following{/other_user}","gists_url":"https://api.github.com/users/minestarks/gists{/gist_id}","starred_url":"https://api.github.com/users/minestarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minestarks/subscriptions","organizations_url":"https://api.github.com/users/minestarks/orgs","repos_url":"https://api.github.com/users/minestarks/repos","events_url":"https://api.github.com/users/minestarks/events{/privacy}","received_events_url":"https://api.github.com/users/minestarks/received_events","type":"User","site_admin":false},"body":"I don't understand. Why expose this? It seems to be an implementation module and not part of the API.","created_at":"2017-06-17T00:50:40Z","updated_at":"2017-06-17T00:50:54Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222#discussion_r122556403","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/122556403"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222#discussion_r122556403"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222","id":125861164,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17222","number":17222,"state":"open","locked":false,"title":"[electron-settings/v2] Expose types","user":{"login":"leonard-thieu","id":5265970,"avatar_url":"https://avatars2.githubusercontent.com/u/5265970?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard-thieu","html_url":"https://github.com/leonard-thieu","followers_url":"https://api.github.com/users/leonard-thieu/followers","following_url":"https://api.github.com/users/leonard-thieu/following{/other_user}","gists_url":"https://api.github.com/users/leonard-thieu/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard-thieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard-thieu/subscriptions","organizations_url":"https://api.github.com/users/leonard-thieu/orgs","repos_url":"https://api.github.com/users/leonard-thieu/repos","events_url":"https://api.github.com/users/leonard-thieu/events{/privacy}","received_events_url":"https://api.github.com/users/leonard-thieu/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- ~~Provide a URL to documentation or source code which provides context for the suggested changes:~~\r\n- ~~Increase the version number in the header if appropriate.~~\r\n- ~~If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.~~","created_at":"2017-06-15T16:23:28Z","updated_at":"2017-06-17T00:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3fc81b7f10a06b26e207736bb515b5a3a2a2fd6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17222/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/be0f70fbf2a9f9fcfd5f889bae408c7c408dbea6","head":{"label":"leonard-thieu:electron-settings","ref":"electron-settings","sha":"be0f70fbf2a9f9fcfd5f889bae408c7c408dbea6","user":{"login":"leonard-thieu","id":5265970,"avatar_url":"https://avatars2.githubusercontent.com/u/5265970?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard-thieu","html_url":"https://github.com/leonard-thieu","followers_url":"https://api.github.com/users/leonard-thieu/followers","following_url":"https://api.github.com/users/leonard-thieu/following{/other_user}","gists_url":"https://api.github.com/users/leonard-thieu/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard-thieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard-thieu/subscriptions","organizations_url":"https://api.github.com/users/leonard-thieu/orgs","repos_url":"https://api.github.com/users/leonard-thieu/repos","events_url":"https://api.github.com/users/leonard-thieu/events{/privacy}","received_events_url":"https://api.github.com/users/leonard-thieu/received_events","type":"User","site_admin":false},"repo":{"id":86841397,"name":"DefinitelyTyped","full_name":"leonard-thieu/DefinitelyTyped","owner":{"login":"leonard-thieu","id":5265970,"avatar_url":"https://avatars2.githubusercontent.com/u/5265970?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard-thieu","html_url":"https://github.com/leonard-thieu","followers_url":"https://api.github.com/users/leonard-thieu/followers","following_url":"https://api.github.com/users/leonard-thieu/following{/other_user}","gists_url":"https://api.github.com/users/leonard-thieu/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard-thieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard-thieu/subscriptions","organizations_url":"https://api.github.com/users/leonard-thieu/orgs","repos_url":"https://api.github.com/users/leonard-thieu/repos","events_url":"https://api.github.com/users/leonard-thieu/events{/privacy}","received_events_url":"https://api.github.com/users/leonard-thieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leonard-thieu/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped","forks_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/leonard-thieu/DefinitelyTyped/deployments","created_at":"2017-03-31T16:52:22Z","updated_at":"2017-03-31T16:52:35Z","pushed_at":"2017-06-16T20:47:35Z","git_url":"git://github.com/leonard-thieu/DefinitelyTyped.git","ssh_url":"git@github.com:leonard-thieu/DefinitelyTyped.git","clone_url":"https://github.com/leonard-thieu/DefinitelyTyped.git","svn_url":"https://github.com/leonard-thieu/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":209602,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"0680af119d17264b589fff3122e5444a7e9f3924","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars2.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars2.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-06-16T23:55:24Z","pushed_at":"2017-06-17T00:33:14Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":210071,"stargazers_count":11097,"watchers_count":11097,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9125,"mirror_url":null,"open_issues_count":1454,"forks":9125,"open_issues":1454,"watchers":11097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17222"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17222"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17222/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17222/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/be0f70fbf2a9f9fcfd5f889bae408c7c408dbea6"}}}}
{"actor":{"display_login":"minestarks"}}