{"push_id":1521178923,"size":1,"distinct_size":1,"ref":"refs/heads/sc/script-generator-windows-x86","head":"aec8663e3b47386c44774461fdcfc606d49c4238","before":"9e9fe7c66a5f7e9f12c384407b262c23ff8c0b54","commits":[{"sha":"aec8663e3b47386c44774461fdcfc606d49c4238","author":{"name":"Scott Christopherson","email":"ddf64ea5989e94a2f54e4e755560f084d9f8c1bd@scott-christopherson.com"},"message":"Don’t hardcode Windows platform version and arch in ScriptGenerator\n\n`ScriptGenerator` was written at a time when we only built a single package\nfor both 32 and 64-bit Windows and as a result it had an Omnitruck url to\nfetch package metadata where the platform architecture was hardcoded to\n64-bit. This would cause consumers (such as `test-kitchen`) of\n`ScriptGenerator`'s generated install script on 32-bit Windows to always\ntry to download and install a 64-bit Chef package. This commit removes the\nhardcoded URL but a proper fix should probably be to deprecate\n`Mixlib::Install::ScriptGenerator.new` in favor of only using\n`Mixlib::Install.new`.\n\nSigned-off-by: Scott Christopherson <scott@chef.io>","distinct":true,"url":"https://api.github.com/repos/chef/mixlib-install/commits/aec8663e3b47386c44774461fdcfc606d49c4238"}]}
{"actor":{"display_login":"scottopherson"}}