{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/comments/98424735","pull_request_review_id":19063479,"id":98424735,"diff_hunk":"@@ -45,6 +46,9 @@\n     private static final String PROPERTY_NAME_DATABASE_URL = \"db.url\";\n     private static final String PROPERTY_NAME_DATABASE_USERNAME = \"db.username\";\n \n+    private static final String PROPERTY_NAME_DATABASE_MAX_POOL_SIZE = \"db.max_pool_size\";\n+    private static final String PROPERTY_NAME_DATABASE_AUTO_COMMIT = \"db.auto_commit\";","path":"osgp-adapter-ws-smartmetering/src/main/java/com/alliander/osgp/adapter/ws/smartmetering/application/config/PersistenceConfig.java","position":22,"original_position":22,"commit_id":"1be4a658d61fbd500bfaf7bb083c776ff610c75b","original_commit_id":"1be4a658d61fbd500bfaf7bb083c776ff610c75b","user":{"login":"rlemmers","id":11977743,"avatar_url":"https://avatars.githubusercontent.com/u/11977743?v=3","gravatar_id":"","url":"https://api.github.com/users/rlemmers","html_url":"https://github.com/rlemmers","followers_url":"https://api.github.com/users/rlemmers/followers","following_url":"https://api.github.com/users/rlemmers/following{/other_user}","gists_url":"https://api.github.com/users/rlemmers/gists{/gist_id}","starred_url":"https://api.github.com/users/rlemmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlemmers/subscriptions","organizations_url":"https://api.github.com/users/rlemmers/orgs","repos_url":"https://api.github.com/users/rlemmers/repos","events_url":"https://api.github.com/users/rlemmers/events{/privacy}","received_events_url":"https://api.github.com/users/rlemmers/received_events","type":"User","site_admin":false},"body":"Don't we need these additional settings in the property file as well?","created_at":"2017-01-30T11:45:07Z","updated_at":"2017-01-30T11:45:07Z","html_url":"https://github.com/OSGP/Platform/pull/554#discussion_r98424735","pull_request_url":"https://api.github.com/repos/OSGP/Platform/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments/98424735"},"html":{"href":"https://github.com/OSGP/Platform/pull/554#discussion_r98424735"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/554","id":103717032,"html_url":"https://github.com/OSGP/Platform/pull/554","diff_url":"https://github.com/OSGP/Platform/pull/554.diff","patch_url":"https://github.com/OSGP/Platform/pull/554.patch","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/554","number":554,"state":"open","locked":false,"title":"Updated Single connection DataSource to HikariCP.","user":{"login":"ElkanRoelen","id":12937350,"avatar_url":"https://avatars.githubusercontent.com/u/12937350?v=3","gravatar_id":"","url":"https://api.github.com/users/ElkanRoelen","html_url":"https://github.com/ElkanRoelen","followers_url":"https://api.github.com/users/ElkanRoelen/followers","following_url":"https://api.github.com/users/ElkanRoelen/following{/other_user}","gists_url":"https://api.github.com/users/ElkanRoelen/gists{/gist_id}","starred_url":"https://api.github.com/users/ElkanRoelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElkanRoelen/subscriptions","organizations_url":"https://api.github.com/users/ElkanRoelen/orgs","repos_url":"https://api.github.com/users/ElkanRoelen/repos","events_url":"https://api.github.com/users/ElkanRoelen/events{/privacy}","received_events_url":"https://api.github.com/users/ElkanRoelen/received_events","type":"User","site_admin":false},"body":" This prevents database warnings 'No transaction in progress'.\r\n\r\nCode is already tested.","created_at":"2017-01-30T11:19:20Z","updated_at":"2017-01-30T11:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6bb07e5fed41f9d34c48cf9f9cc27676030434e","assignee":{"login":"robindenadel","id":15684772,"avatar_url":"https://avatars.githubusercontent.com/u/15684772?v=3","gravatar_id":"","url":"https://api.github.com/users/robindenadel","html_url":"https://github.com/robindenadel","followers_url":"https://api.github.com/users/robindenadel/followers","following_url":"https://api.github.com/users/robindenadel/following{/other_user}","gists_url":"https://api.github.com/users/robindenadel/gists{/gist_id}","starred_url":"https://api.github.com/users/robindenadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindenadel/subscriptions","organizations_url":"https://api.github.com/users/robindenadel/orgs","repos_url":"https://api.github.com/users/robindenadel/repos","events_url":"https://api.github.com/users/robindenadel/events{/privacy}","received_events_url":"https://api.github.com/users/robindenadel/received_events","type":"User","site_admin":false},"assignees":[{"login":"robindenadel","id":15684772,"avatar_url":"https://avatars.githubusercontent.com/u/15684772?v=3","gravatar_id":"","url":"https://api.github.com/users/robindenadel","html_url":"https://github.com/robindenadel","followers_url":"https://api.github.com/users/robindenadel/followers","following_url":"https://api.github.com/users/robindenadel/following{/other_user}","gists_url":"https://api.github.com/users/robindenadel/gists{/gist_id}","starred_url":"https://api.github.com/users/robindenadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindenadel/subscriptions","organizations_url":"https://api.github.com/users/robindenadel/orgs","repos_url":"https://api.github.com/users/robindenadel/repos","events_url":"https://api.github.com/users/robindenadel/events{/privacy}","received_events_url":"https://api.github.com/users/robindenadel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Platform/pulls/554/commits","review_comments_url":"https://api.github.com/repos/OSGP/Platform/pulls/554/comments","review_comment_url":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/554/comments","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/1be4a658d61fbd500bfaf7bb083c776ff610c75b","head":{"label":"OSGP:UpdateSingleConnectionDataSourceToHikariCP","ref":"UpdateSingleConnectionDataSourceToHikariCP","sha":"1be4a658d61fbd500bfaf7bb083c776ff610c75b","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2017-01-05T04:33:12Z","pushed_at":"2017-01-30T11:19:21Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":28559,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":16,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"bc42f07262d14be62e78472d06f85838b8b88dcb","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2017-01-05T04:33:12Z","pushed_at":"2017-01-30T11:19:21Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":28559,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":16,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/554"},"html":{"href":"https://github.com/OSGP/Platform/pull/554"},"issue":{"href":"https://api.github.com/repos/OSGP/Platform/issues/554"},"comments":{"href":"https://api.github.com/repos/OSGP/Platform/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Platform/statuses/1be4a658d61fbd500bfaf7bb083c776ff610c75b"}}}}
{"actor":{"display_login":"rlemmers"}}