{"action":"created","issue":{"url":"https://api.github.com/repos/gentoo/sci/issues/709","repository_url":"https://api.github.com/repos/gentoo/sci","labels_url":"https://api.github.com/repos/gentoo/sci/issues/709/labels{/name}","comments_url":"https://api.github.com/repos/gentoo/sci/issues/709/comments","events_url":"https://api.github.com/repos/gentoo/sci/issues/709/events","html_url":"https://github.com/gentoo/sci/issues/709","id":194807229,"number":709,"title":"shouldn't .pc files generated by the numeric eclass use ${include,lib}dir?","user":{"login":"kiwifb","id":151475,"avatar_url":"https://avatars0.githubusercontent.com/u/151475?v=3","gravatar_id":"","url":"https://api.github.com/users/kiwifb","html_url":"https://github.com/kiwifb","followers_url":"https://api.github.com/users/kiwifb/followers","following_url":"https://api.github.com/users/kiwifb/following{/other_user}","gists_url":"https://api.github.com/users/kiwifb/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwifb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwifb/subscriptions","organizations_url":"https://api.github.com/users/kiwifb/orgs","repos_url":"https://api.github.com/users/kiwifb/repos","events_url":"https://api.github.com/users/kiwifb/events{/privacy}","received_events_url":"https://api.github.com/users/kiwifb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-11T02:06:11Z","updated_at":"2017-06-06T03:09:07Z","closed_at":null,"body":"I was looking at .pc files generate by `create_pkgconfig` of the numeric eclass and I was a bit surprised to find\r\n```\r\nprefix=\"/usr\"\r\nexec_prefix=\"/usr\"\r\nlibdir=\"/usr/lib64\"\r\nincludedir=\"/usr/include\"\r\n\r\nName: atlas-blas\r\nDescription: atlas atlas-blas\r\nVersion: 3.11.38\r\nURL: http://math-atlas.sourceforge.net/\r\nRequires: \r\nRequires.private: \r\nConflicts: \r\nLibs: -L\"/usr/lib64\" -L${libdir} -lf77blas \r\nLibs.private: -L${libdir} -latlas -lm -lpthread\r\nCflags: -I\"/usr/include\" -I${includedir}/atlas\r\n```\r\nWhat I was expecting was\r\n```\r\nprefix=\"/usr\"\r\nexec_prefix=\"/usr\"\r\nlibdir=\"/usr/lib64\"\r\nincludedir=\"/usr/include\"\r\n\r\nName: atlas-blas\r\nDescription: atlas atlas-blas\r\nVersion: 3.11.38\r\nURL: http://math-atlas.sourceforge.net/\r\nRequires: \r\nRequires.private: \r\nConflicts: \r\nLibs: -L${libdir} -lf77blas \r\nLibs.private: -L${libdir} -latlas -lm -lpthread\r\nCflags: -I${includedir} -I${includedir}/atlas\r\n```\r\nThere are two issues really:\r\n* when calling `create_pkgconfig` the `libs` argument often contains `\\${libdir}` when it shouldn't, there is a `libdir` argument for that. Atlas, openblas and gsl but not reference are guilty of this misuse at least.\r\n* `create_pkgconfig` sets `libdir` and `includedir` at the top and then doesn't use the variables, it uses their values directly inside the .pc file which nullify the point of defining them. "},"comment":{"url":"https://api.github.com/repos/gentoo/sci/issues/comments/306369299","html_url":"https://github.com/gentoo/sci/issues/709#issuecomment-306369299","issue_url":"https://api.github.com/repos/gentoo/sci/issues/709","id":306369299,"user":{"login":"heroxbd","id":303360,"avatar_url":"https://avatars0.githubusercontent.com/u/303360?v=3","gravatar_id":"","url":"https://api.github.com/users/heroxbd","html_url":"https://github.com/heroxbd","followers_url":"https://api.github.com/users/heroxbd/followers","following_url":"https://api.github.com/users/heroxbd/following{/other_user}","gists_url":"https://api.github.com/users/heroxbd/gists{/gist_id}","starred_url":"https://api.github.com/users/heroxbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroxbd/subscriptions","organizations_url":"https://api.github.com/users/heroxbd/orgs","repos_url":"https://api.github.com/users/heroxbd/repos","events_url":"https://api.github.com/users/heroxbd/events{/privacy}","received_events_url":"https://api.github.com/users/heroxbd/received_events","type":"User","site_admin":false},"created_at":"2017-06-06T03:09:07Z","updated_at":"2017-06-06T03:09:07Z","body":"Yes, indeed. Thanks a lot for your input."}}
{"actor":{"display_login":"heroxbd"}}