{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments/142321041","pull_request_review_id":66662847,"id":142321041,"diff_hunk":"@@ -192,10 +192,11 @@ public static GLTFRoot Deserialize(TextReader textReader)\n \t\t\treturn root;\n \t\t}\n \n-\t\tpublic void Serialize(TextWriter textWriter)\n-\t\t{\n-\t\t\tJsonWriter jsonWriter = new JsonTextWriter(textWriter);\n-\t\t\tjsonWriter.WriteStartObject();\n+        public void Serialize(TextWriter textWriter)","path":"GLTFSerialization/GLTFSerialization/Schema/GLTFRoot.cs","position":8,"original_position":8,"commit_id":"7804d1a214e3ae2b3f050ffbaeabcdd801429e96","original_commit_id":"7804d1a214e3ae2b3f050ffbaeabcdd801429e96","user":{"login":"robertlong","id":1753624,"avatar_url":"https://avatars3.githubusercontent.com/u/1753624?v=4","gravatar_id":"","url":"https://api.github.com/users/robertlong","html_url":"https://github.com/robertlong","followers_url":"https://api.github.com/users/robertlong/followers","following_url":"https://api.github.com/users/robertlong/following{/other_user}","gists_url":"https://api.github.com/users/robertlong/gists{/gist_id}","starred_url":"https://api.github.com/users/robertlong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertlong/subscriptions","organizations_url":"https://api.github.com/users/robertlong/orgs","repos_url":"https://api.github.com/users/robertlong/repos","events_url":"https://api.github.com/users/robertlong/events{/privacy}","received_events_url":"https://api.github.com/users/robertlong/received_events","type":"User","site_admin":false},"body":"Convert spaces to tabs.","created_at":"2017-10-03T06:26:46Z","updated_at":"2017-10-03T06:35:26Z","html_url":"https://github.com/KhronosGroup/UnityGLTF/pull/70#discussion_r142321041","pull_request_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments/142321041"},"html":{"href":"https://github.com/KhronosGroup/UnityGLTF/pull/70#discussion_r142321041"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70","id":143758990,"html_url":"https://github.com/KhronosGroup/UnityGLTF/pull/70","diff_url":"https://github.com/KhronosGroup/UnityGLTF/pull/70.diff","patch_url":"https://github.com/KhronosGroup/UnityGLTF/pull/70.patch","issue_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/70","number":70,"state":"open","locked":false,"title":"Various bug fixes and implementations for extras serialization with f…","user":{"login":"MSblgross","id":31107383,"avatar_url":"https://avatars3.githubusercontent.com/u/31107383?v=4","gravatar_id":"","url":"https://api.github.com/users/MSblgross","html_url":"https://github.com/MSblgross","followers_url":"https://api.github.com/users/MSblgross/followers","following_url":"https://api.github.com/users/MSblgross/following{/other_user}","gists_url":"https://api.github.com/users/MSblgross/gists{/gist_id}","starred_url":"https://api.github.com/users/MSblgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSblgross/subscriptions","organizations_url":"https://api.github.com/users/MSblgross/orgs","repos_url":"https://api.github.com/users/MSblgross/repos","events_url":"https://api.github.com/users/MSblgross/events{/privacy}","received_events_url":"https://api.github.com/users/MSblgross/received_events","type":"User","site_admin":false},"body":"…ixes for extensions\r\n\r\n- Fixed bug where min and max serialization was required instead of optional\r\n- Added default handler for extensions so that they are not lost on reserialization\r\n- Added extras serialization and changed extras to JToken\r\n- Change extensions deserialization/serialization logic to be JToken based\r\n- Updated unit test for extras and extensions\r\n","created_at":"2017-09-28T21:21:20Z","updated_at":"2017-10-03T06:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ceae6009aa894db980694a58d99c2b42298313","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/70/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/7804d1a214e3ae2b3f050ffbaeabcdd801429e96","head":{"label":"MSblgross:feature/extensions_and_extras","ref":"feature/extensions_and_extras","sha":"7804d1a214e3ae2b3f050ffbaeabcdd801429e96","user":{"login":"MSblgross","id":31107383,"avatar_url":"https://avatars3.githubusercontent.com/u/31107383?v=4","gravatar_id":"","url":"https://api.github.com/users/MSblgross","html_url":"https://github.com/MSblgross","followers_url":"https://api.github.com/users/MSblgross/followers","following_url":"https://api.github.com/users/MSblgross/following{/other_user}","gists_url":"https://api.github.com/users/MSblgross/gists{/gist_id}","starred_url":"https://api.github.com/users/MSblgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSblgross/subscriptions","organizations_url":"https://api.github.com/users/MSblgross/orgs","repos_url":"https://api.github.com/users/MSblgross/repos","events_url":"https://api.github.com/users/MSblgross/events{/privacy}","received_events_url":"https://api.github.com/users/MSblgross/received_events","type":"User","site_admin":false},"repo":{"id":100627411,"name":"UnityGLTF","full_name":"MSblgross/UnityGLTF","owner":{"login":"MSblgross","id":31107383,"avatar_url":"https://avatars3.githubusercontent.com/u/31107383?v=4","gravatar_id":"","url":"https://api.github.com/users/MSblgross","html_url":"https://github.com/MSblgross","followers_url":"https://api.github.com/users/MSblgross/followers","following_url":"https://api.github.com/users/MSblgross/following{/other_user}","gists_url":"https://api.github.com/users/MSblgross/gists{/gist_id}","starred_url":"https://api.github.com/users/MSblgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSblgross/subscriptions","organizations_url":"https://api.github.com/users/MSblgross/orgs","repos_url":"https://api.github.com/users/MSblgross/repos","events_url":"https://api.github.com/users/MSblgross/events{/privacy}","received_events_url":"https://api.github.com/users/MSblgross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MSblgross/UnityGLTF","description":"Runtime GLTF Loader for Unity3D","fork":true,"url":"https://api.github.com/repos/MSblgross/UnityGLTF","forks_url":"https://api.github.com/repos/MSblgross/UnityGLTF/forks","keys_url":"https://api.github.com/repos/MSblgross/UnityGLTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSblgross/UnityGLTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSblgross/UnityGLTF/teams","hooks_url":"https://api.github.com/repos/MSblgross/UnityGLTF/hooks","issue_events_url":"https://api.github.com/repos/MSblgross/UnityGLTF/issues/events{/number}","events_url":"https://api.github.com/repos/MSblgross/UnityGLTF/events","assignees_url":"https://api.github.com/repos/MSblgross/UnityGLTF/assignees{/user}","branches_url":"https://api.github.com/repos/MSblgross/UnityGLTF/branches{/branch}","tags_url":"https://api.github.com/repos/MSblgross/UnityGLTF/tags","blobs_url":"https://api.github.com/repos/MSblgross/UnityGLTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSblgross/UnityGLTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSblgross/UnityGLTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSblgross/UnityGLTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSblgross/UnityGLTF/statuses/{sha}","languages_url":"https://api.github.com/repos/MSblgross/UnityGLTF/languages","stargazers_url":"https://api.github.com/repos/MSblgross/UnityGLTF/stargazers","contributors_url":"https://api.github.com/repos/MSblgross/UnityGLTF/contributors","subscribers_url":"https://api.github.com/repos/MSblgross/UnityGLTF/subscribers","subscription_url":"https://api.github.com/repos/MSblgross/UnityGLTF/subscription","commits_url":"https://api.github.com/repos/MSblgross/UnityGLTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSblgross/UnityGLTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSblgross/UnityGLTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSblgross/UnityGLTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSblgross/UnityGLTF/contents/{+path}","compare_url":"https://api.github.com/repos/MSblgross/UnityGLTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSblgross/UnityGLTF/merges","archive_url":"https://api.github.com/repos/MSblgross/UnityGLTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSblgross/UnityGLTF/downloads","issues_url":"https://api.github.com/repos/MSblgross/UnityGLTF/issues{/number}","pulls_url":"https://api.github.com/repos/MSblgross/UnityGLTF/pulls{/number}","milestones_url":"https://api.github.com/repos/MSblgross/UnityGLTF/milestones{/number}","notifications_url":"https://api.github.com/repos/MSblgross/UnityGLTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSblgross/UnityGLTF/labels{/name}","releases_url":"https://api.github.com/repos/MSblgross/UnityGLTF/releases{/id}","deployments_url":"https://api.github.com/repos/MSblgross/UnityGLTF/deployments","created_at":"2017-08-17T17:11:12Z","updated_at":"2017-08-17T17:20:07Z","pushed_at":"2017-10-03T00:33:13Z","git_url":"git://github.com/MSblgross/UnityGLTF.git","ssh_url":"git@github.com:MSblgross/UnityGLTF.git","clone_url":"https://github.com/MSblgross/UnityGLTF.git","svn_url":"https://github.com/MSblgross/UnityGLTF","homepage":null,"size":176495,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"4a2016603c47e769c0ebe75477164d7eee8a6fa0","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":84389723,"name":"UnityGLTF","full_name":"KhronosGroup/UnityGLTF","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/UnityGLTF","description":"Runtime GLTF Loader for Unity3D","fork":false,"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF","forks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/forks","keys_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/events","assignees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/merges","archive_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/deployments","created_at":"2017-03-09T02:40:28Z","updated_at":"2017-10-03T00:49:56Z","pushed_at":"2017-10-02T17:27:02Z","git_url":"git://github.com/KhronosGroup/UnityGLTF.git","ssh_url":"git@github.com:KhronosGroup/UnityGLTF.git","clone_url":"https://github.com/KhronosGroup/UnityGLTF.git","svn_url":"https://github.com/KhronosGroup/UnityGLTF","homepage":null,"size":175694,"stargazers_count":66,"watchers_count":66,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":35,"forks":30,"open_issues":35,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70"},"html":{"href":"https://github.com/KhronosGroup/UnityGLTF/pull/70"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/70"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/7804d1a214e3ae2b3f050ffbaeabcdd801429e96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertlong"}}