{"action":"opened","number":1725,"pull_request":{"url":"https://api.github.com/repos/obspy/obspy/pulls/1725","id":111541039,"html_url":"https://github.com/obspy/obspy/pull/1725","diff_url":"https://github.com/obspy/obspy/pull/1725.diff","patch_url":"https://github.com/obspy/obspy/pull/1725.patch","issue_url":"https://api.github.com/repos/obspy/obspy/issues/1725","number":1725,"state":"open","locked":false,"title":"more verbose TypeErrors in trace.__add__","user":{"login":"ThomasLecocq","id":916937,"avatar_url":"https://avatars3.githubusercontent.com/u/916937?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasLecocq","html_url":"https://github.com/ThomasLecocq","followers_url":"https://api.github.com/users/ThomasLecocq/followers","following_url":"https://api.github.com/users/ThomasLecocq/following{/other_user}","gists_url":"https://api.github.com/users/ThomasLecocq/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasLecocq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasLecocq/subscriptions","organizations_url":"https://api.github.com/users/ThomasLecocq/orgs","repos_url":"https://api.github.com/users/ThomasLecocq/repos","events_url":"https://api.github.com/users/ThomasLecocq/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasLecocq/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nJust adds some verbosity in the sanity checks done in the __add__ method of traces.\r\n\r\n### Why was it initiated?  Any relevant Issues?\r\nIt's soooooo frustrating to debug \r\n```TypeError(\"Data type differs\") ```\r\n\r\n### PR Checklist\r\n- [ ] All tests still pass.\r\n- [X] Significant changes have been added to `CHANGELOG.txt`  (is this significant? don't think so)\r\n\r\n","created_at":"2017-03-20T12:25:04Z","updated_at":"2017-03-20T12:25:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/obspy/obspy/pulls/1725/commits","review_comments_url":"https://api.github.com/repos/obspy/obspy/pulls/1725/comments","review_comment_url":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/1725/comments","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/abdcda17fa30bd92deb6e1bd3ab368fb340030ed","head":{"label":"ThomasLecocq:verbose_trace_add","ref":"verbose_trace_add","sha":"abdcda17fa30bd92deb6e1bd3ab368fb340030ed","user":{"login":"ThomasLecocq","id":916937,"avatar_url":"https://avatars3.githubusercontent.com/u/916937?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasLecocq","html_url":"https://github.com/ThomasLecocq","followers_url":"https://api.github.com/users/ThomasLecocq/followers","following_url":"https://api.github.com/users/ThomasLecocq/following{/other_user}","gists_url":"https://api.github.com/users/ThomasLecocq/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasLecocq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasLecocq/subscriptions","organizations_url":"https://api.github.com/users/ThomasLecocq/orgs","repos_url":"https://api.github.com/users/ThomasLecocq/repos","events_url":"https://api.github.com/users/ThomasLecocq/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasLecocq/received_events","type":"User","site_admin":false},"repo":{"id":70467991,"name":"obspy","full_name":"ThomasLecocq/obspy","owner":{"login":"ThomasLecocq","id":916937,"avatar_url":"https://avatars3.githubusercontent.com/u/916937?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasLecocq","html_url":"https://github.com/ThomasLecocq","followers_url":"https://api.github.com/users/ThomasLecocq/followers","following_url":"https://api.github.com/users/ThomasLecocq/following{/other_user}","gists_url":"https://api.github.com/users/ThomasLecocq/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasLecocq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasLecocq/subscriptions","organizations_url":"https://api.github.com/users/ThomasLecocq/orgs","repos_url":"https://api.github.com/users/ThomasLecocq/repos","events_url":"https://api.github.com/users/ThomasLecocq/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasLecocq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasLecocq/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":true,"url":"https://api.github.com/repos/ThomasLecocq/obspy","forks_url":"https://api.github.com/repos/ThomasLecocq/obspy/forks","keys_url":"https://api.github.com/repos/ThomasLecocq/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasLecocq/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasLecocq/obspy/teams","hooks_url":"https://api.github.com/repos/ThomasLecocq/obspy/hooks","issue_events_url":"https://api.github.com/repos/ThomasLecocq/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasLecocq/obspy/events","assignees_url":"https://api.github.com/repos/ThomasLecocq/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasLecocq/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasLecocq/obspy/tags","blobs_url":"https://api.github.com/repos/ThomasLecocq/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasLecocq/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasLecocq/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasLecocq/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasLecocq/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasLecocq/obspy/languages","stargazers_url":"https://api.github.com/repos/ThomasLecocq/obspy/stargazers","contributors_url":"https://api.github.com/repos/ThomasLecocq/obspy/contributors","subscribers_url":"https://api.github.com/repos/ThomasLecocq/obspy/subscribers","subscription_url":"https://api.github.com/repos/ThomasLecocq/obspy/subscription","commits_url":"https://api.github.com/repos/ThomasLecocq/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasLecocq/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasLecocq/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasLecocq/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasLecocq/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasLecocq/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasLecocq/obspy/merges","archive_url":"https://api.github.com/repos/ThomasLecocq/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasLecocq/obspy/downloads","issues_url":"https://api.github.com/repos/ThomasLecocq/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasLecocq/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasLecocq/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasLecocq/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasLecocq/obspy/labels{/name}","releases_url":"https://api.github.com/repos/ThomasLecocq/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasLecocq/obspy/deployments","created_at":"2016-10-10T08:33:18Z","updated_at":"2016-10-10T08:33:26Z","pushed_at":"2017-03-20T12:22:47Z","git_url":"git://github.com/ThomasLecocq/obspy.git","ssh_url":"git@github.com:ThomasLecocq/obspy.git","clone_url":"https://github.com/ThomasLecocq/obspy.git","svn_url":"https://github.com/ThomasLecocq/obspy","homepage":"https://www.obspy.org","size":81883,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"obspy:master","ref":"master","sha":"727d0599f237657e387a8008416e72e6797cf293","user":{"login":"obspy","id":1701221,"avatar_url":"https://avatars1.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"repo":{"id":5731348,"name":"obspy","full_name":"obspy/obspy","owner":{"login":"obspy","id":1701221,"avatar_url":"https://avatars1.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obspy/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":false,"url":"https://api.github.com/repos/obspy/obspy","forks_url":"https://api.github.com/repos/obspy/obspy/forks","keys_url":"https://api.github.com/repos/obspy/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obspy/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obspy/obspy/teams","hooks_url":"https://api.github.com/repos/obspy/obspy/hooks","issue_events_url":"https://api.github.com/repos/obspy/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/obspy/obspy/events","assignees_url":"https://api.github.com/repos/obspy/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/obspy/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/obspy/obspy/tags","blobs_url":"https://api.github.com/repos/obspy/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obspy/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obspy/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/obspy/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/obspy/obspy/languages","stargazers_url":"https://api.github.com/repos/obspy/obspy/stargazers","contributors_url":"https://api.github.com/repos/obspy/obspy/contributors","subscribers_url":"https://api.github.com/repos/obspy/obspy/subscribers","subscription_url":"https://api.github.com/repos/obspy/obspy/subscription","commits_url":"https://api.github.com/repos/obspy/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/obspy/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/obspy/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/obspy/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/obspy/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/obspy/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obspy/obspy/merges","archive_url":"https://api.github.com/repos/obspy/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obspy/obspy/downloads","issues_url":"https://api.github.com/repos/obspy/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/obspy/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/obspy/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/obspy/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obspy/obspy/labels{/name}","releases_url":"https://api.github.com/repos/obspy/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/obspy/obspy/deployments","created_at":"2012-09-08T19:17:46Z","updated_at":"2017-03-18T17:48:08Z","pushed_at":"2017-03-20T11:40:07Z","git_url":"git://github.com/obspy/obspy.git","ssh_url":"git@github.com:obspy/obspy.git","clone_url":"https://github.com/obspy/obspy.git","svn_url":"https://github.com/obspy/obspy","homepage":"https://www.obspy.org","size":92497,"stargazers_count":273,"watchers_count":273,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":211,"forks":194,"open_issues":211,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1725"},"html":{"href":"https://github.com/obspy/obspy/pull/1725"},"issue":{"href":"https://api.github.com/repos/obspy/obspy/issues/1725"},"comments":{"href":"https://api.github.com/repos/obspy/obspy/issues/1725/comments"},"review_comments":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1725/comments"},"review_comment":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1725/commits"},"statuses":{"href":"https://api.github.com/repos/obspy/obspy/statuses/abdcda17fa30bd92deb6e1bd3ab368fb340030ed"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":9,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"ThomasLecocq"}}