{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments/139350563","pull_request_review_id":63269328,"id":139350563,"diff_hunk":"@@ -22,8 +25,33 @@ const vector<Tag> XMPFileFormat::ReadTags() {\n   return XMPHelper::GetInstance().GetTags(mFile);\n }\n \n-void XMPFileFormat::Commit(shared_ptr<IStream> file, string& /*newExtension*/) {\n-  throw std::runtime_error(\"not implemented\");\n+void XMPFileFormat::Commit(shared_ptr<IStream> file, string& newExtension) {","path":"sdk/file_sdk/XMPFileFormat/xmp_file_format.cpp","position":16,"original_position":16,"commit_id":"c3676134a6fede159cea651042385cbf16be7c6c","original_commit_id":"c3676134a6fede159cea651042385cbf16be7c6c","user":{"login":"vakuras","id":22167695,"avatar_url":"https://avatars1.githubusercontent.com/u/22167695?v=4","gravatar_id":"","url":"https://api.github.com/users/vakuras","html_url":"https://github.com/vakuras","followers_url":"https://api.github.com/users/vakuras/followers","following_url":"https://api.github.com/users/vakuras/following{/other_user}","gists_url":"https://api.github.com/users/vakuras/gists{/gist_id}","starred_url":"https://api.github.com/users/vakuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakuras/subscriptions","organizations_url":"https://api.github.com/users/vakuras/orgs","repos_url":"https://api.github.com/users/vakuras/repos","events_url":"https://api.github.com/users/vakuras/events{/privacy}","received_events_url":"https://api.github.com/users/vakuras/received_events","type":"User","site_admin":false},"body":"incorrect parameter names","created_at":"2017-09-18T07:30:30Z","updated_at":"2017-09-18T07:30:30Z","html_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156#discussion_r139350563","pull_request_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments/139350563"},"html":{"href":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156#discussion_r139350563"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156","id":141475855,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156","diff_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156.diff","patch_url":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156.patch","issue_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/156","number":156,"state":"open","locked":false,"title":"Task #1450265: Implement SetTags function","user":{"login":"shenhavba","id":3798137,"avatar_url":"https://avatars3.githubusercontent.com/u/3798137?v=4","gravatar_id":"","url":"https://api.github.com/users/shenhavba","html_url":"https://github.com/shenhavba","followers_url":"https://api.github.com/users/shenhavba/followers","following_url":"https://api.github.com/users/shenhavba/following{/other_user}","gists_url":"https://api.github.com/users/shenhavba/gists{/gist_id}","starred_url":"https://api.github.com/users/shenhavba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenhavba/subscriptions","organizations_url":"https://api.github.com/users/shenhavba/orgs","repos_url":"https://api.github.com/users/shenhavba/repos","events_url":"https://api.github.com/users/shenhavba/events{/privacy}","received_events_url":"https://api.github.com/users/shenhavba/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-17T07:14:30Z","updated_at":"2017-09-18T07:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"shenhavba","id":3798137,"avatar_url":"https://avatars3.githubusercontent.com/u/3798137?v=4","gravatar_id":"","url":"https://api.github.com/users/shenhavba","html_url":"https://github.com/shenhavba","followers_url":"https://api.github.com/users/shenhavba/followers","following_url":"https://api.github.com/users/shenhavba/following{/other_user}","gists_url":"https://api.github.com/users/shenhavba/gists{/gist_id}","starred_url":"https://api.github.com/users/shenhavba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenhavba/subscriptions","organizations_url":"https://api.github.com/users/shenhavba/orgs","repos_url":"https://api.github.com/users/shenhavba/repos","events_url":"https://api.github.com/users/shenhavba/events{/privacy}","received_events_url":"https://api.github.com/users/shenhavba/received_events","type":"User","site_admin":false},"assignees":[{"login":"shenhavba","id":3798137,"avatar_url":"https://avatars3.githubusercontent.com/u/3798137?v=4","gravatar_id":"","url":"https://api.github.com/users/shenhavba","html_url":"https://github.com/shenhavba","followers_url":"https://api.github.com/users/shenhavba/followers","following_url":"https://api.github.com/users/shenhavba/following{/other_user}","gists_url":"https://api.github.com/users/shenhavba/gists{/gist_id}","starred_url":"https://api.github.com/users/shenhavba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenhavba/subscriptions","organizations_url":"https://api.github.com/users/shenhavba/orgs","repos_url":"https://api.github.com/users/shenhavba/repos","events_url":"https://api.github.com/users/shenhavba/events{/privacy}","received_events_url":"https://api.github.com/users/shenhavba/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Norfolc","id":5813774,"avatar_url":"https://avatars3.githubusercontent.com/u/5813774?v=4","gravatar_id":"","url":"https://api.github.com/users/Norfolc","html_url":"https://github.com/Norfolc","followers_url":"https://api.github.com/users/Norfolc/followers","following_url":"https://api.github.com/users/Norfolc/following{/other_user}","gists_url":"https://api.github.com/users/Norfolc/gists{/gist_id}","starred_url":"https://api.github.com/users/Norfolc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Norfolc/subscriptions","organizations_url":"https://api.github.com/users/Norfolc/orgs","repos_url":"https://api.github.com/users/Norfolc/repos","events_url":"https://api.github.com/users/Norfolc/events{/privacy}","received_events_url":"https://api.github.com/users/Norfolc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156/commits","review_comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156/comments","review_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/156/comments","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/c3676134a6fede159cea651042385cbf16be7c6c","head":{"label":"AzureAD:private/shenhav/setTags","ref":"private/shenhav/setTags","sha":"c3676134a6fede159cea651042385cbf16be7c6c","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":37728349,"name":"rms-sdk-for-cpp","full_name":"AzureAD/rms-sdk-for-cpp","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp","description":"RMS SDK for C++","fork":false,"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp","forks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/forks","keys_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/teams","hooks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/events","assignees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/tags","blobs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/languages","stargazers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscription","commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/merges","archive_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/downloads","issues_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/deployments","created_at":"2015-06-19T15:04:00Z","updated_at":"2017-09-06T17:43:26Z","pushed_at":"2017-09-18T07:28:07Z","git_url":"git://github.com/AzureAD/rms-sdk-for-cpp.git","ssh_url":"git@github.com:AzureAD/rms-sdk-for-cpp.git","clone_url":"https://github.com/AzureAD/rms-sdk-for-cpp.git","svn_url":"https://github.com/AzureAD/rms-sdk-for-cpp","homepage":null,"size":143035,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":19,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"6882e72487b8a4c602d9836a0e6d9c9674a22e5a","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":37728349,"name":"rms-sdk-for-cpp","full_name":"AzureAD/rms-sdk-for-cpp","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/rms-sdk-for-cpp","description":"RMS SDK for C++","fork":false,"url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp","forks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/forks","keys_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/teams","hooks_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/events","assignees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/tags","blobs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/languages","stargazers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/subscription","commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/merges","archive_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/downloads","issues_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/deployments","created_at":"2015-06-19T15:04:00Z","updated_at":"2017-09-06T17:43:26Z","pushed_at":"2017-09-18T07:28:07Z","git_url":"git://github.com/AzureAD/rms-sdk-for-cpp.git","ssh_url":"git@github.com:AzureAD/rms-sdk-for-cpp.git","clone_url":"https://github.com/AzureAD/rms-sdk-for-cpp.git","svn_url":"https://github.com/AzureAD/rms-sdk-for-cpp","homepage":null,"size":143035,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156"},"html":{"href":"https://github.com/AzureAD/rms-sdk-for-cpp/pull/156"},"issue":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/156"},"comments":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/rms-sdk-for-cpp/statuses/c3676134a6fede159cea651042385cbf16be7c6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vakuras"}}