{"action":"created","issue":{"url":"https://api.github.com/repos/python/typing/issues/439","repository_url":"https://api.github.com/repos/python/typing","labels_url":"https://api.github.com/repos/python/typing/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/python/typing/issues/439/comments","events_url":"https://api.github.com/repos/python/typing/issues/439/events","html_url":"https://github.com/python/typing/pull/439","id":235069017,"number":439,"title":"[WIP] Speed improvements for typing","user":{"login":"ilevkivskyi","id":12005495,"avatar_url":"https://avatars2.githubusercontent.com/u/12005495?v=3","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"labels":[{"id":465632491,"url":"https://api.github.com/repos/python/typing/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-11T14:26:15Z","updated_at":"2017-06-12T13:14:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/python/typing/pulls/439","html_url":"https://github.com/python/typing/pull/439","diff_url":"https://github.com/python/typing/pull/439.diff","patch_url":"https://github.com/python/typing/pull/439.patch"},"body":"This PR contains two performance improvements based on profiling and inspired by #432:\r\n* Inline ``_gorg`` and ``_geqv``\r\n* Remove (IMO unnecessary) \"duplicates\" from MRO.\r\n\r\nThis gives roughly 5% speed-up for ``mypy mypy``. @JukkaL I will be grateful if you could do more benchmarking with some real-life large codebases."},"comment":{"url":"https://api.github.com/repos/python/typing/issues/comments/307785435","html_url":"https://github.com/python/typing/pull/439#issuecomment-307785435","issue_url":"https://api.github.com/repos/python/typing/issues/439","id":307785435,"user":{"login":"ilevkivskyi","id":12005495,"avatar_url":"https://avatars2.githubusercontent.com/u/12005495?v=3","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"created_at":"2017-06-12T13:14:15Z","updated_at":"2017-06-12T13:14:15Z","body":"I am marking this as WIP until I figure out what is going on with Python 2.\r\n\r\n@gvanrossum \r\n> PS. I'm not sure how we would test this speedup with real code. Did you ask for us to have this patched into the Python version we use to run mypy and then run mypy over our large codebase? That makes sense except the time there is pretty variable (since it runs so long that all sorts of other activities on the same machine affect the timing).\r\n\r\nYes, even if it is not super-stable it would be great to have few more data points."}}
{"actor":{"display_login":"ilevkivskyi"}}