{"action":"created","comment":{"url":"https://api.github.com/repos/project8/dragonfly/pulls/comments/118069750","pull_request_review_id":39828715,"id":118069750,"diff_hunk":"@@ -332,4 +338,324 @@ def save_trace(self, trace, comment):\n             logger.debug(\"things are about to be dumped in file\")\n             json.dump(result_meta, outfile, indent=4)\n             logger.debug(\"things have been dumped in file\")\n-        logger.info(\"saving {}: successful\".format(path))\n+            logger.info(\"saving {}: successful\".format(path))\n+\n+\n+\n+__all__.append('ROACH1ChAcquisitionInterface')\n+class ROACH1ChAcquisitionInterface(DAQProvider):\n+    '''\n+    A DAQProvider for interacting with ROACH-Psyllid DAQ\n+    '''\n+    def __init__(self,\n+                 psyllid_interface='psyllid_interface',\n+                 daq_target = 'roach2_interface',\n+                 channel = 'a',\n+                 filename_prefix = 'psyllid',","path":"dragonfly/implementations/daq_run_interface.py","position":47,"original_position":47,"commit_id":"3cd1fd4f80b0c2842514bbac03a0eb279ef36896","original_commit_id":"3cd1fd4f80b0c2842514bbac03a0eb279ef36896","user":{"login":"wcpettus","id":10961789,"avatar_url":"https://avatars0.githubusercontent.com/u/10961789?v=3","gravatar_id":"","url":"https://api.github.com/users/wcpettus","html_url":"https://github.com/wcpettus","followers_url":"https://api.github.com/users/wcpettus/followers","following_url":"https://api.github.com/users/wcpettus/following{/other_user}","gists_url":"https://api.github.com/users/wcpettus/gists{/gist_id}","starred_url":"https://api.github.com/users/wcpettus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcpettus/subscriptions","organizations_url":"https://api.github.com/users/wcpettus/orgs","repos_url":"https://api.github.com/users/wcpettus/repos","events_url":"https://api.github.com/users/wcpettus/events{/privacy}","received_events_url":"https://api.github.com/users/wcpettus/received_events","type":"User","site_admin":false},"body":"remove `filename_prefix`, as it is a defined variable in DAQProvider (unless you really want to overwrite the default value)","created_at":"2017-05-23T18:26:48Z","updated_at":"2017-05-23T18:26:48Z","html_url":"https://github.com/project8/dragonfly/pull/101#discussion_r118069750","pull_request_url":"https://api.github.com/repos/project8/dragonfly/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/comments/118069750"},"html":{"href":"https://github.com/project8/dragonfly/pull/101#discussion_r118069750"},"pull_request":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/project8/dragonfly/pulls/101","id":120163910,"html_url":"https://github.com/project8/dragonfly/pull/101","diff_url":"https://github.com/project8/dragonfly/pull/101.diff","patch_url":"https://github.com/project8/dragonfly/pull/101.patch","issue_url":"https://api.github.com/repos/project8/dragonfly/issues/101","number":101,"state":"open","locked":false,"title":"Feature/roachinterface","user":{"login":"guiguem","id":16764756,"avatar_url":"https://avatars3.githubusercontent.com/u/16764756?v=3","gravatar_id":"","url":"https://api.github.com/users/guiguem","html_url":"https://github.com/guiguem","followers_url":"https://api.github.com/users/guiguem/followers","following_url":"https://api.github.com/users/guiguem/following{/other_user}","gists_url":"https://api.github.com/users/guiguem/gists{/gist_id}","starred_url":"https://api.github.com/users/guiguem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guiguem/subscriptions","organizations_url":"https://api.github.com/users/guiguem/orgs","repos_url":"https://api.github.com/users/guiguem/repos","events_url":"https://api.github.com/users/guiguem/events{/privacy}","received_events_url":"https://api.github.com/users/guiguem/received_events","type":"User","site_admin":false},"body":"Feature/roachinterface contains r2daq, roach2interface, PsyllidProvider and new classes in daq_run_interface. \r\nThe classes MultiPsyllidProvider and ROACH1ChAcquisitionInterface are ready for streaming data acquisition with single psyllid streams.","created_at":"2017-05-11T17:46:57Z","updated_at":"2017-05-23T18:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba6669b3dfbd4446a8b5c921fa0949faa6539554","assignee":{"login":"cclaessens","id":16554883,"avatar_url":"https://avatars0.githubusercontent.com/u/16554883?v=3","gravatar_id":"","url":"https://api.github.com/users/cclaessens","html_url":"https://github.com/cclaessens","followers_url":"https://api.github.com/users/cclaessens/followers","following_url":"https://api.github.com/users/cclaessens/following{/other_user}","gists_url":"https://api.github.com/users/cclaessens/gists{/gist_id}","starred_url":"https://api.github.com/users/cclaessens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclaessens/subscriptions","organizations_url":"https://api.github.com/users/cclaessens/orgs","repos_url":"https://api.github.com/users/cclaessens/repos","events_url":"https://api.github.com/users/cclaessens/events{/privacy}","received_events_url":"https://api.github.com/users/cclaessens/received_events","type":"User","site_admin":false},"assignees":[{"login":"cclaessens","id":16554883,"avatar_url":"https://avatars0.githubusercontent.com/u/16554883?v=3","gravatar_id":"","url":"https://api.github.com/users/cclaessens","html_url":"https://github.com/cclaessens","followers_url":"https://api.github.com/users/cclaessens/followers","following_url":"https://api.github.com/users/cclaessens/following{/other_user}","gists_url":"https://api.github.com/users/cclaessens/gists{/gist_id}","starred_url":"https://api.github.com/users/cclaessens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclaessens/subscriptions","organizations_url":"https://api.github.com/users/cclaessens/orgs","repos_url":"https://api.github.com/users/cclaessens/repos","events_url":"https://api.github.com/users/cclaessens/events{/privacy}","received_events_url":"https://api.github.com/users/cclaessens/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nsoblath","id":829991,"avatar_url":"https://avatars2.githubusercontent.com/u/829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nsoblath","html_url":"https://github.com/nsoblath","followers_url":"https://api.github.com/users/nsoblath/followers","following_url":"https://api.github.com/users/nsoblath/following{/other_user}","gists_url":"https://api.github.com/users/nsoblath/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoblath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoblath/subscriptions","organizations_url":"https://api.github.com/users/nsoblath/orgs","repos_url":"https://api.github.com/users/nsoblath/repos","events_url":"https://api.github.com/users/nsoblath/events{/privacy}","received_events_url":"https://api.github.com/users/nsoblath/received_events","type":"User","site_admin":false},{"login":"cclaessens","id":16554883,"avatar_url":"https://avatars0.githubusercontent.com/u/16554883?v=3","gravatar_id":"","url":"https://api.github.com/users/cclaessens","html_url":"https://github.com/cclaessens","followers_url":"https://api.github.com/users/cclaessens/followers","following_url":"https://api.github.com/users/cclaessens/following{/other_user}","gists_url":"https://api.github.com/users/cclaessens/gists{/gist_id}","starred_url":"https://api.github.com/users/cclaessens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclaessens/subscriptions","organizations_url":"https://api.github.com/users/cclaessens/orgs","repos_url":"https://api.github.com/users/cclaessens/repos","events_url":"https://api.github.com/users/cclaessens/events{/privacy}","received_events_url":"https://api.github.com/users/cclaessens/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/project8/dragonfly/pulls/101/commits","review_comments_url":"https://api.github.com/repos/project8/dragonfly/pulls/101/comments","review_comment_url":"https://api.github.com/repos/project8/dragonfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project8/dragonfly/issues/101/comments","statuses_url":"https://api.github.com/repos/project8/dragonfly/statuses/3cd1fd4f80b0c2842514bbac03a0eb279ef36896","head":{"label":"project8:feature/roachinterface","ref":"feature/roachinterface","sha":"3cd1fd4f80b0c2842514bbac03a0eb279ef36896","user":{"login":"project8","id":664678,"avatar_url":"https://avatars0.githubusercontent.com/u/664678?v=3","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"repo":{"id":44192629,"name":"dragonfly","full_name":"project8/dragonfly","owner":{"login":"project8","id":664678,"avatar_url":"https://avatars0.githubusercontent.com/u/664678?v=3","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project8/dragonfly","description":"a dripline-based slow-control implementation","fork":false,"url":"https://api.github.com/repos/project8/dragonfly","forks_url":"https://api.github.com/repos/project8/dragonfly/forks","keys_url":"https://api.github.com/repos/project8/dragonfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project8/dragonfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project8/dragonfly/teams","hooks_url":"https://api.github.com/repos/project8/dragonfly/hooks","issue_events_url":"https://api.github.com/repos/project8/dragonfly/issues/events{/number}","events_url":"https://api.github.com/repos/project8/dragonfly/events","assignees_url":"https://api.github.com/repos/project8/dragonfly/assignees{/user}","branches_url":"https://api.github.com/repos/project8/dragonfly/branches{/branch}","tags_url":"https://api.github.com/repos/project8/dragonfly/tags","blobs_url":"https://api.github.com/repos/project8/dragonfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project8/dragonfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project8/dragonfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/project8/dragonfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project8/dragonfly/statuses/{sha}","languages_url":"https://api.github.com/repos/project8/dragonfly/languages","stargazers_url":"https://api.github.com/repos/project8/dragonfly/stargazers","contributors_url":"https://api.github.com/repos/project8/dragonfly/contributors","subscribers_url":"https://api.github.com/repos/project8/dragonfly/subscribers","subscription_url":"https://api.github.com/repos/project8/dragonfly/subscription","commits_url":"https://api.github.com/repos/project8/dragonfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/project8/dragonfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/project8/dragonfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/project8/dragonfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/project8/dragonfly/contents/{+path}","compare_url":"https://api.github.com/repos/project8/dragonfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project8/dragonfly/merges","archive_url":"https://api.github.com/repos/project8/dragonfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project8/dragonfly/downloads","issues_url":"https://api.github.com/repos/project8/dragonfly/issues{/number}","pulls_url":"https://api.github.com/repos/project8/dragonfly/pulls{/number}","milestones_url":"https://api.github.com/repos/project8/dragonfly/milestones{/number}","notifications_url":"https://api.github.com/repos/project8/dragonfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project8/dragonfly/labels{/name}","releases_url":"https://api.github.com/repos/project8/dragonfly/releases{/id}","deployments_url":"https://api.github.com/repos/project8/dragonfly/deployments","created_at":"2015-10-13T17:19:22Z","updated_at":"2016-01-21T00:35:08Z","pushed_at":"2017-05-23T18:21:46Z","git_url":"git://github.com/project8/dragonfly.git","ssh_url":"git@github.com:project8/dragonfly.git","clone_url":"https://github.com/project8/dragonfly.git","svn_url":"https://github.com/project8/dragonfly","homepage":null,"size":1868,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"project8:develop","ref":"develop","sha":"1f15ac19ca2cb4aa77b400342cfa6eda49e7da4a","user":{"login":"project8","id":664678,"avatar_url":"https://avatars0.githubusercontent.com/u/664678?v=3","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"repo":{"id":44192629,"name":"dragonfly","full_name":"project8/dragonfly","owner":{"login":"project8","id":664678,"avatar_url":"https://avatars0.githubusercontent.com/u/664678?v=3","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project8/dragonfly","description":"a dripline-based slow-control implementation","fork":false,"url":"https://api.github.com/repos/project8/dragonfly","forks_url":"https://api.github.com/repos/project8/dragonfly/forks","keys_url":"https://api.github.com/repos/project8/dragonfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project8/dragonfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project8/dragonfly/teams","hooks_url":"https://api.github.com/repos/project8/dragonfly/hooks","issue_events_url":"https://api.github.com/repos/project8/dragonfly/issues/events{/number}","events_url":"https://api.github.com/repos/project8/dragonfly/events","assignees_url":"https://api.github.com/repos/project8/dragonfly/assignees{/user}","branches_url":"https://api.github.com/repos/project8/dragonfly/branches{/branch}","tags_url":"https://api.github.com/repos/project8/dragonfly/tags","blobs_url":"https://api.github.com/repos/project8/dragonfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project8/dragonfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project8/dragonfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/project8/dragonfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project8/dragonfly/statuses/{sha}","languages_url":"https://api.github.com/repos/project8/dragonfly/languages","stargazers_url":"https://api.github.com/repos/project8/dragonfly/stargazers","contributors_url":"https://api.github.com/repos/project8/dragonfly/contributors","subscribers_url":"https://api.github.com/repos/project8/dragonfly/subscribers","subscription_url":"https://api.github.com/repos/project8/dragonfly/subscription","commits_url":"https://api.github.com/repos/project8/dragonfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/project8/dragonfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/project8/dragonfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/project8/dragonfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/project8/dragonfly/contents/{+path}","compare_url":"https://api.github.com/repos/project8/dragonfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project8/dragonfly/merges","archive_url":"https://api.github.com/repos/project8/dragonfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project8/dragonfly/downloads","issues_url":"https://api.github.com/repos/project8/dragonfly/issues{/number}","pulls_url":"https://api.github.com/repos/project8/dragonfly/pulls{/number}","milestones_url":"https://api.github.com/repos/project8/dragonfly/milestones{/number}","notifications_url":"https://api.github.com/repos/project8/dragonfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project8/dragonfly/labels{/name}","releases_url":"https://api.github.com/repos/project8/dragonfly/releases{/id}","deployments_url":"https://api.github.com/repos/project8/dragonfly/deployments","created_at":"2015-10-13T17:19:22Z","updated_at":"2016-01-21T00:35:08Z","pushed_at":"2017-05-23T18:21:46Z","git_url":"git://github.com/project8/dragonfly.git","ssh_url":"git@github.com:project8/dragonfly.git","clone_url":"https://github.com/project8/dragonfly.git","svn_url":"https://github.com/project8/dragonfly","homepage":null,"size":1868,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/101"},"html":{"href":"https://github.com/project8/dragonfly/pull/101"},"issue":{"href":"https://api.github.com/repos/project8/dragonfly/issues/101"},"comments":{"href":"https://api.github.com/repos/project8/dragonfly/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project8/dragonfly/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/project8/dragonfly/statuses/3cd1fd4f80b0c2842514bbac03a0eb279ef36896"}}}}
{"actor":{"display_login":"wcpettus"}}