{"action":"created","comment":{"url":"https://api.github.com/repos/embox/embox/pulls/comments/109135370","pull_request_review_id":30217839,"id":109135370,"diff_hunk":"@@ -0,0 +1,67 @@\n+/**\n+ * @file\n+ * @brief\n+ *\n+ * @author  Alex Kalmuk\n+ * @date    27.03.2017\n+ */\n+\n+.text\n+.thumb\n+.syntax unified\n+.global interrupt_handle_enter\n+interrupt_handle_enter:\n+\n+    mov    r0, sp\n+    sub    sp, #58","path":"src/drivers/interrupt/cortexm_irq_handle.S","position":16,"original_position":16,"commit_id":"7bf75ec85e3886f731517aa3d2ca6e425d488ed1","original_commit_id":"7bf75ec85e3886f731517aa3d2ca6e425d488ed1","user":{"login":"alexkalmuk","id":10322525,"avatar_url":"https://avatars0.githubusercontent.com/u/10322525?v=3","gravatar_id":"","url":"https://api.github.com/users/alexkalmuk","html_url":"https://github.com/alexkalmuk","followers_url":"https://api.github.com/users/alexkalmuk/followers","following_url":"https://api.github.com/users/alexkalmuk/following{/other_user}","gists_url":"https://api.github.com/users/alexkalmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkalmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkalmuk/subscriptions","organizations_url":"https://api.github.com/users/alexkalmuk/orgs","repos_url":"https://api.github.com/users/alexkalmuk/repos","events_url":"https://api.github.com/users/alexkalmuk/events{/privacy}","received_events_url":"https://api.github.com/users/alexkalmuk/received_events","type":"User","site_admin":false},"body":"Yes, I forgot about this.","created_at":"2017-03-31T10:51:16Z","updated_at":"2017-03-31T10:51:16Z","html_url":"https://github.com/embox/embox/pull/1061#discussion_r109135370","pull_request_url":"https://api.github.com/repos/embox/embox/pulls/1061","_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/comments/109135370"},"html":{"href":"https://github.com/embox/embox/pull/1061#discussion_r109135370"},"pull_request":{"href":"https://api.github.com/repos/embox/embox/pulls/1061"}}},"pull_request":{"url":"https://api.github.com/repos/embox/embox/pulls/1061","id":113034187,"html_url":"https://github.com/embox/embox/pull/1061","diff_url":"https://github.com/embox/embox/pull/1061.diff","patch_url":"https://github.com/embox/embox/pull/1061.patch","issue_url":"https://api.github.com/repos/embox/embox/issues/1061","number":1061,"state":"open","locked":false,"title":"Fix cortexm irq handling","user":{"login":"alexkalmuk","id":10322525,"avatar_url":"https://avatars0.githubusercontent.com/u/10322525?v=3","gravatar_id":"","url":"https://api.github.com/users/alexkalmuk","html_url":"https://github.com/alexkalmuk","followers_url":"https://api.github.com/users/alexkalmuk/followers","following_url":"https://api.github.com/users/alexkalmuk/following{/other_user}","gists_url":"https://api.github.com/users/alexkalmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkalmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkalmuk/subscriptions","organizations_url":"https://api.github.com/users/alexkalmuk/orgs","repos_url":"https://api.github.com/users/alexkalmuk/repos","events_url":"https://api.github.com/users/alexkalmuk/events{/privacy}","received_events_url":"https://api.github.com/users/alexkalmuk/received_events","type":"User","site_admin":false},"body":"There is a problem with interrupts handling on cortex-m. When we are inside an interrupt handler, another interrupts of the same priority (including the current one) are locked. The only way to enable it is to exit interrupt handle. One can check the issue using the test proposed in this PR and see that without this changes thread2 started only after thread1 finished.\r\n\r\nThis PR was tested on stm32f4-discovery with httpd and telnetd also","created_at":"2017-03-28T18:17:57Z","updated_at":"2017-03-31T10:51:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a00895c33a0df9b837515d9ee2a43d545937f694","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/embox/embox/pulls/1061/commits","review_comments_url":"https://api.github.com/repos/embox/embox/pulls/1061/comments","review_comment_url":"https://api.github.com/repos/embox/embox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embox/embox/issues/1061/comments","statuses_url":"https://api.github.com/repos/embox/embox/statuses/7bf75ec85e3886f731517aa3d2ca6e425d488ed1","head":{"label":"embox:fix-cortexm-irq-handling","ref":"fix-cortexm-irq-handling","sha":"7bf75ec85e3886f731517aa3d2ca6e425d488ed1","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars1.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars1.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"Modular and configurable OS kernel for embedded applications","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","deployments_url":"https://api.github.com/repos/embox/embox/deployments","created_at":"2015-03-29T15:27:48Z","updated_at":"2017-03-16T14:02:13Z","pushed_at":"2017-03-31T09:45:07Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":24085,"stargazers_count":123,"watchers_count":123,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":72,"forks":41,"open_issues":72,"watchers":123,"default_branch":"master"}},"base":{"label":"embox:master","ref":"master","sha":"821ec24c0c2c97391fc1ddda97415912e893f751","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars1.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars1.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"Modular and configurable OS kernel for embedded applications","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","deployments_url":"https://api.github.com/repos/embox/embox/deployments","created_at":"2015-03-29T15:27:48Z","updated_at":"2017-03-16T14:02:13Z","pushed_at":"2017-03-31T09:45:07Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":24085,"stargazers_count":123,"watchers_count":123,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":72,"forks":41,"open_issues":72,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/1061"},"html":{"href":"https://github.com/embox/embox/pull/1061"},"issue":{"href":"https://api.github.com/repos/embox/embox/issues/1061"},"comments":{"href":"https://api.github.com/repos/embox/embox/issues/1061/comments"},"review_comments":{"href":"https://api.github.com/repos/embox/embox/pulls/1061/comments"},"review_comment":{"href":"https://api.github.com/repos/embox/embox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embox/embox/pulls/1061/commits"},"statuses":{"href":"https://api.github.com/repos/embox/embox/statuses/7bf75ec85e3886f731517aa3d2ca6e425d488ed1"}}}}
{"actor":{"display_login":"alexkalmuk"}}