{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/7397","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/7397/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/7397/comments","events_url":"https://api.github.com/repos/angular/material2/issues/7397/events","html_url":"https://github.com/angular/material2/pull/7397","id":261459735,"number":7397,"title":"style(ripple): start fade out on mouseup","user":{"login":"willshowell","id":6475576,"avatar_url":"https://avatars0.githubusercontent.com/u/6475576?v=4","gravatar_id":"","url":"https://api.github.com/users/willshowell","html_url":"https://github.com/willshowell","followers_url":"https://api.github.com/users/willshowell/followers","following_url":"https://api.github.com/users/willshowell/following{/other_user}","gists_url":"https://api.github.com/users/willshowell/gists{/gist_id}","starred_url":"https://api.github.com/users/willshowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willshowell/subscriptions","organizations_url":"https://api.github.com/users/willshowell/orgs","repos_url":"https://api.github.com/users/willshowell/repos","events_url":"https://api.github.com/users/willshowell/events{/privacy}","received_events_url":"https://api.github.com/users/willshowell/received_events","type":"User","site_admin":false},"labels":[{"id":308798701,"url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":433951675,"url":"https://api.github.com/repos/angular/material2/labels/discussion","name":"discussion","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-28T21:00:57Z","updated_at":"2017-10-19T15:56:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/7397","html_url":"https://github.com/angular/material2/pull/7397","diff_url":"https://github.com/angular/material2/pull/7397.diff","patch_url":"https://github.com/angular/material2/pull/7397.patch"},"body":"**Purpose**\r\n\r\nThe goal of this is to start the ripple fade out immediately after mouseup rather than having to wait until the ripple animation has completed. My intention was to match the behavior seen in md1 which feels snappier and cleaner.\r\n\r\n**Background**\r\n\r\nThe change to make sure a ripple had completed its animation before hiding was made in #3400. It looks like the intention was to solve the problem of ripples not being added to the active ripple set until _after_ it was completed, as pointed out in #3398. However, it appears #3400 fixed that problem [anyway](https://github.com/angular/material2/pull/3400/files#diff-9bf3861c94a2bdcf0beae13a7f4b4c0eR104) by adding it to the active ripple set as soon as animation begins. Therefore, the additional check of making sure a ripple had completed its animation is not necessary.\r\n\r\n**Before**\r\n\r\n![ripple-b](https://user-images.githubusercontent.com/6475576/30990175-44da347e-a46e-11e7-8cae-130024351491.gif)\r\n\r\n\r\n**After**\r\n\r\n![ripple - a](https://user-images.githubusercontent.com/6475576/30990179-47665d30-a46e-11e7-9ab5-52b746cb7ceb.gif)\r\n\r\n\r\nThis is one that's been a nit of mine for a while, but I couldn't tell if the change a while back was intentional or accidental. @DevVersion, thoughts? If this ok, I'll add tests."},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/337953676","html_url":"https://github.com/angular/material2/pull/7397#issuecomment-337953676","issue_url":"https://api.github.com/repos/angular/material2/issues/7397","id":337953676,"user":{"login":"willshowell","id":6475576,"avatar_url":"https://avatars0.githubusercontent.com/u/6475576?v=4","gravatar_id":"","url":"https://api.github.com/users/willshowell","html_url":"https://github.com/willshowell","followers_url":"https://api.github.com/users/willshowell/followers","following_url":"https://api.github.com/users/willshowell/following{/other_user}","gists_url":"https://api.github.com/users/willshowell/gists{/gist_id}","starred_url":"https://api.github.com/users/willshowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willshowell/subscriptions","organizations_url":"https://api.github.com/users/willshowell/orgs","repos_url":"https://api.github.com/users/willshowell/repos","events_url":"https://api.github.com/users/willshowell/events{/privacy}","received_events_url":"https://api.github.com/users/willshowell/received_events","type":"User","site_admin":false},"created_at":"2017-10-19T15:56:55Z","updated_at":"2017-10-19T15:56:55Z","author_association":"CONTRIBUTOR","body":"I see Google's calendar refresh uses buttons in line with the existing behavior. Maybe I'm behind on the times 😄.\r\n\r\nI still want to play with this further and see if there's some tweaking left to do... maybe using radial-gradients in the ripple? or a different easing curve for opacity so there's not such a sharp distinction in the two transitions. Will report back.\r\n"}}
{"actor":{"display_login":"willshowell"}}