{"action":"closed","issue":{"url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1941","repository_url":"https://api.github.com/repos/inverse-inc/packetfence","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1941/labels{/name}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1941/comments","events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1941/events","html_url":"https://github.com/inverse-inc/packetfence/issues/1941","id":198556645,"number":1941,"title":"EAP-TLS unit tests (and maybe the source in general) is broken","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"labels":[{"id":586476,"url":"https://api.github.com/repos/inverse-inc/packetfence/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/20","html_url":"https://github.com/inverse-inc/packetfence/milestone/20","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/20/labels","id":1869064,"number":20,"title":"+1 (patch release)","description":"DO NOT DELETE / CLOSE\r\nMETA milestone used to track what should go in the next \"patch\" release (X.X.Y) (in this case, Y is the \"patch\" release)\r\nCan be used to decide whether or not to do a \"patch\" release.\r\n","creator":{"login":"dwlfrth","id":633234,"avatar_url":"https://avatars.githubusercontent.com/u/633234?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlfrth","html_url":"https://github.com/dwlfrth","followers_url":"https://api.github.com/users/dwlfrth/followers","following_url":"https://api.github.com/users/dwlfrth/following{/other_user}","gists_url":"https://api.github.com/users/dwlfrth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlfrth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlfrth/subscriptions","organizations_url":"https://api.github.com/users/dwlfrth/orgs","repos_url":"https://api.github.com/users/dwlfrth/repos","events_url":"https://api.github.com/users/dwlfrth/events{/privacy}","received_events_url":"https://api.github.com/users/dwlfrth/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":57,"state":"open","created_at":"2016-07-07T02:51:35Z","updated_at":"2017-01-04T14:52:04Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-01-03T20:03:48Z","updated_at":"2017-01-04T14:52:04Z","closed_at":"2017-01-04T14:52:04Z","body":"When running t/unittest/authentication.t, some eap-tls source tests are failing:\r\n```\r\nnot ok 15 - match tls source rule all conditions\r\n#   Failed test 'match tls source rule all conditions'\r\n#   at t/unittest/authentication.t line 123.\r\n#     Structures begin differing at:\r\n#          $got = undef\r\n#     $expected = ARRAY(0x76852e0)\r\nnot ok 16 - Source id ref is found\r\n#   Failed test 'Source id ref is found'\r\n#   at t/unittest/authentication.t line 142.\r\n#          got: undef\r\n#     expected: 'tls_all'\r\nnot ok 17 - match tls_any source rule any conditions\r\n#   Failed test 'match tls_any source rule any conditions'\r\n#   at t/unittest/authentication.t line 146.\r\n#     Structures begin differing at:\r\n#          $got = undef\r\n#     $expected = ARRAY(0x79f9a80)\r\nnot ok 18 - Source id ref is found\r\n#   Failed test 'Source id ref is found'\r\n#   at t/unittest/authentication.t line 165.\r\n#          got: undef\r\n#     expected: 'tls_any'\r\nnot ok 19 - match tls_any source rule any conditions\r\n#   Failed test 'match tls_any source rule any conditions'\r\n#   at t/unittest/authentication.t line 169.\r\n#     Structures begin differing at:\r\n#          $got = undef\r\n#     $expected = ARRAY(0x79b37b8)\r\nnot ok 20 - Source id ref is found\r\n#   Failed test 'Source id ref is found'\r\n#   at t/unittest/authentication.t line 188.\r\n#          got: undef\r\n#     expected: 'tls_any'\r\n```\r\n\r\nReverting d601a8d9c005c89a2995fed255cc73b8249f088e against the latest devel makes all these tests pass.\r\n\r\nTrying to figure out whether the tests were faulty at the beginning or if fix broke EAP-TLS matching as a whole\r\n\r\nNOTE: d601a8d9c005c89a2995fed255cc73b8249f088e was cherry-picked to the maintenance. If it proves to be the issue, it needs to be reverted or a corrective commit needs to be added to all maintenance branches where this was applied"}}
{"actor":{"display_login":"julsemaan"}}