{"action":"created","issue":{"url":"https://api.github.com/repos/Dizeeee/tipbot/issues/3","repository_url":"https://api.github.com/repos/Dizeeee/tipbot","labels_url":"https://api.github.com/repos/Dizeeee/tipbot/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/Dizeeee/tipbot/issues/3/comments","events_url":"https://api.github.com/repos/Dizeeee/tipbot/issues/3/events","html_url":"https://github.com/Dizeeee/tipbot/issues/3","id":250125175,"number":3,"title":"Suggestions","user":{"login":"Aareon","id":9089510,"avatar_url":"https://avatars3.githubusercontent.com/u/9089510?v=4","gravatar_id":"","url":"https://api.github.com/users/Aareon","html_url":"https://github.com/Aareon","followers_url":"https://api.github.com/users/Aareon/followers","following_url":"https://api.github.com/users/Aareon/following{/other_user}","gists_url":"https://api.github.com/users/Aareon/gists{/gist_id}","starred_url":"https://api.github.com/users/Aareon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aareon/subscriptions","organizations_url":"https://api.github.com/users/Aareon/orgs","repos_url":"https://api.github.com/users/Aareon/repos","events_url":"https://api.github.com/users/Aareon/events{/privacy}","received_events_url":"https://api.github.com/users/Aareon/received_events","type":"User","site_admin":false},"labels":[{"id":595215886,"url":"https://api.github.com/repos/Dizeeee/tipbot/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"Dizeeee","id":17105387,"avatar_url":"https://avatars2.githubusercontent.com/u/17105387?v=4","gravatar_id":"","url":"https://api.github.com/users/Dizeeee","html_url":"https://github.com/Dizeeee","followers_url":"https://api.github.com/users/Dizeeee/followers","following_url":"https://api.github.com/users/Dizeeee/following{/other_user}","gists_url":"https://api.github.com/users/Dizeeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dizeeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dizeeee/subscriptions","organizations_url":"https://api.github.com/users/Dizeeee/orgs","repos_url":"https://api.github.com/users/Dizeeee/repos","events_url":"https://api.github.com/users/Dizeeee/events{/privacy}","received_events_url":"https://api.github.com/users/Dizeeee/received_events","type":"User","site_admin":false},"assignees":[{"login":"Dizeeee","id":17105387,"avatar_url":"https://avatars2.githubusercontent.com/u/17105387?v=4","gravatar_id":"","url":"https://api.github.com/users/Dizeeee","html_url":"https://github.com/Dizeeee","followers_url":"https://api.github.com/users/Dizeeee/followers","following_url":"https://api.github.com/users/Dizeeee/following{/other_user}","gists_url":"https://api.github.com/users/Dizeeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dizeeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dizeeee/subscriptions","organizations_url":"https://api.github.com/users/Dizeeee/orgs","repos_url":"https://api.github.com/users/Dizeeee/repos","events_url":"https://api.github.com/users/Dizeeee/events{/privacy}","received_events_url":"https://api.github.com/users/Dizeeee/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-08-14T19:11:26Z","updated_at":"2017-11-15T23:25:05Z","closed_at":null,"author_association":"NONE","body":"1. bot.py\r\n- Use discord.py's cog features rather than putting all command inside just one module\r\n- Choose a version of Python and place a shebang line in the script itself at line 1 like so; `#!python3.5`. More on this at [PEP 397](http://www.python.org/dev/peps/pep-0397/)\r\n- In most instances, your single quote docstrings are a bit redundant. I see no reason for most, if not all of these, being here.\r\n- Please use some sort of configuration file for storing of bot settings, like tokens. You have many options, including; JSON, YAML, or storing in a database. I do not suggest the latter, however.\r\n- In regards to this function;\r\n```py\r\n@bot.command()\r\nasync def tip(user, currency, amount):\r\n    await bot.say('''tip''' + user + currency +amount)\r\n```\r\n   You cannot add `user`, which is more than likely a `discord.Member` object, to a string, and then a string to a float/int. I think I see what you were trying to do, but the proper concatenation would be\r\n`await bot.say(\"Tip {1} {2} {3}\".format(user, amount, currency))`. If you choose to use Python3.6, consider using [f-strings](https://www.python.org/dev/peps/pep-0498/).\r\n- You withdraw function will not work as is if you are not grabbing a Message object. I'm sure you're aware of this already.\r\n- Just to touch on this one more time, there is nearly no reason to use single quote docstrings anywhere within this script with your current usage in mind.\r\n\r\n2. Database suggestions\r\n- I'm not entirely sure how you planned to use a database in this case, as everyone has different outlooks on how this sort of thing could be done. However, with a Discord tipbot in mind, I would suggest a relational database such as MariaDB for quick comparisons. I would also suggest [SQLAlchemy](https://www.sqlalchemy.org/) if you decide to go this route.\r\n\r\nI hope this giant wall of text helps you if you decide to continue this project. Good luck!"},"comment":{"url":"https://api.github.com/repos/Dizeeee/tipbot/issues/comments/344763236","html_url":"https://github.com/Dizeeee/tipbot/issues/3#issuecomment-344763236","issue_url":"https://api.github.com/repos/Dizeeee/tipbot/issues/3","id":344763236,"user":{"login":"atiwiex","id":26222884,"avatar_url":"https://avatars0.githubusercontent.com/u/26222884?v=4","gravatar_id":"","url":"https://api.github.com/users/atiwiex","html_url":"https://github.com/atiwiex","followers_url":"https://api.github.com/users/atiwiex/followers","following_url":"https://api.github.com/users/atiwiex/following{/other_user}","gists_url":"https://api.github.com/users/atiwiex/gists{/gist_id}","starred_url":"https://api.github.com/users/atiwiex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atiwiex/subscriptions","organizations_url":"https://api.github.com/users/atiwiex/orgs","repos_url":"https://api.github.com/users/atiwiex/repos","events_url":"https://api.github.com/users/atiwiex/events{/privacy}","received_events_url":"https://api.github.com/users/atiwiex/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T23:25:05Z","updated_at":"2017-11-15T23:25:05Z","author_association":"NONE","body":"I suggest rethinkdb"}}
{"actor":{"display_login":"atiwiex"}}