{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/107573813","pull_request_review_id":28554269,"id":107573813,"diff_hunk":"@@ -34,34 +34,43 @@ mappings, events, and a Touch controller model.\n | triggerup            | Trigger released.              |\n | triggertouchstart    | Trigger touched.               |\n | triggertouchend      | Trigger no longer touched.     |\n+| triggerchanged       | Trigger changed.               |\n | thumbstickdown       | Thumbstick pressed.            |\n | thumbstickup         | Thumbstick released.           |\n | thumbsticktouchstart | Thumbstick touched.            |\n | thumbsticktouchend   | Thumbstick no longer touched.  |\n+| thumbstickchanged    | Thumbstick changed.            |\n | gripdown             | Grip button pressed.           |\n | gripup               | Grip button released.          |\n | griptouchstart       | Grip button touched.           |\n | griptouchend         | Grip button no longer touched. |\n+| gripchanged          | Grip button changed.           |\n | Adown                | A button pressed.              |\n | Aup                  | A button released.             |\n | Atouchstart          | A button touched.              |\n | Atouchend            | A button no longer touched.    |\n+| Achanged             | A button changed.              |","path":"docs/components/oculus-touch-controls.md","position":19,"original_position":19,"commit_id":"d606450573f5a85609061f2367c30f3b7c71ef4c","original_commit_id":"d606450573f5a85609061f2367c30f3b7c71ef4c","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars0.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"body":"can we make all the event names lower case?","created_at":"2017-03-23T01:58:56Z","updated_at":"2017-03-23T01:58:56Z","html_url":"https://github.com/aframevr/aframe/pull/2513#discussion_r107573813","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/2513","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/107573813"},"html":{"href":"https://github.com/aframevr/aframe/pull/2513#discussion_r107573813"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2513"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/2513","id":111925088,"html_url":"https://github.com/aframevr/aframe/pull/2513","diff_url":"https://github.com/aframevr/aframe/pull/2513.diff","patch_url":"https://github.com/aframevr/aframe/pull/2513.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/2513","number":2513,"state":"open","locked":false,"title":"Axismove for touch and vive","user":{"login":"machenmusik","id":2080738,"avatar_url":"https://avatars0.githubusercontent.com/u/2080738?v=3","gravatar_id":"","url":"https://api.github.com/users/machenmusik","html_url":"https://github.com/machenmusik","followers_url":"https://api.github.com/users/machenmusik/followers","following_url":"https://api.github.com/users/machenmusik/following{/other_user}","gists_url":"https://api.github.com/users/machenmusik/gists{/gist_id}","starred_url":"https://api.github.com/users/machenmusik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machenmusik/subscriptions","organizations_url":"https://api.github.com/users/machenmusik/orgs","repos_url":"https://api.github.com/users/machenmusik/repos","events_url":"https://api.github.com/users/machenmusik/events{/privacy}","received_events_url":"https://api.github.com/users/machenmusik/received_events","type":"User","site_admin":false},"body":"Per discussion on #2423, this PR separates the axismove changes and omits the emulated property.\r\n\r\nThis PR extends #2413 / #2415 to oculus-touch-controls as thumbstickmoved, and also addresses spurious axismove events discussed in #2423.","created_at":"2017-03-22T03:23:41Z","updated_at":"2017-03-23T01:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"565d87f826fbee9a962d545d0a39b6437ba8ee2d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/2513/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/2513/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2513/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/d606450573f5a85609061f2367c30f3b7c71ef4c","head":{"label":"chenzlabs:axismove-for-touch-and-vive","ref":"axismove-for-touch-and-vive","sha":"d606450573f5a85609061f2367c30f3b7c71ef4c","user":{"login":"chenzlabs","id":11540216,"avatar_url":"https://avatars0.githubusercontent.com/u/11540216?v=3","gravatar_id":"","url":"https://api.github.com/users/chenzlabs","html_url":"https://github.com/chenzlabs","followers_url":"https://api.github.com/users/chenzlabs/followers","following_url":"https://api.github.com/users/chenzlabs/following{/other_user}","gists_url":"https://api.github.com/users/chenzlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/chenzlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenzlabs/subscriptions","organizations_url":"https://api.github.com/users/chenzlabs/orgs","repos_url":"https://api.github.com/users/chenzlabs/repos","events_url":"https://api.github.com/users/chenzlabs/events{/privacy}","received_events_url":"https://api.github.com/users/chenzlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":74418613,"name":"aframe","full_name":"chenzlabs/aframe","owner":{"login":"chenzlabs","id":11540216,"avatar_url":"https://avatars0.githubusercontent.com/u/11540216?v=3","gravatar_id":"","url":"https://api.github.com/users/chenzlabs","html_url":"https://github.com/chenzlabs","followers_url":"https://api.github.com/users/chenzlabs/followers","following_url":"https://api.github.com/users/chenzlabs/following{/other_user}","gists_url":"https://api.github.com/users/chenzlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/chenzlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenzlabs/subscriptions","organizations_url":"https://api.github.com/users/chenzlabs/orgs","repos_url":"https://api.github.com/users/chenzlabs/repos","events_url":"https://api.github.com/users/chenzlabs/events{/privacy}","received_events_url":"https://api.github.com/users/chenzlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chenzlabs/aframe","description":"A web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/chenzlabs/aframe","forks_url":"https://api.github.com/repos/chenzlabs/aframe/forks","keys_url":"https://api.github.com/repos/chenzlabs/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenzlabs/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenzlabs/aframe/teams","hooks_url":"https://api.github.com/repos/chenzlabs/aframe/hooks","issue_events_url":"https://api.github.com/repos/chenzlabs/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/chenzlabs/aframe/events","assignees_url":"https://api.github.com/repos/chenzlabs/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/chenzlabs/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/chenzlabs/aframe/tags","blobs_url":"https://api.github.com/repos/chenzlabs/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenzlabs/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenzlabs/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenzlabs/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenzlabs/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/chenzlabs/aframe/languages","stargazers_url":"https://api.github.com/repos/chenzlabs/aframe/stargazers","contributors_url":"https://api.github.com/repos/chenzlabs/aframe/contributors","subscribers_url":"https://api.github.com/repos/chenzlabs/aframe/subscribers","subscription_url":"https://api.github.com/repos/chenzlabs/aframe/subscription","commits_url":"https://api.github.com/repos/chenzlabs/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenzlabs/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenzlabs/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenzlabs/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenzlabs/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/chenzlabs/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenzlabs/aframe/merges","archive_url":"https://api.github.com/repos/chenzlabs/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenzlabs/aframe/downloads","issues_url":"https://api.github.com/repos/chenzlabs/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/chenzlabs/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/chenzlabs/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/chenzlabs/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenzlabs/aframe/labels{/name}","releases_url":"https://api.github.com/repos/chenzlabs/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/chenzlabs/aframe/deployments","created_at":"2016-11-22T00:35:28Z","updated_at":"2017-01-27T22:04:26Z","pushed_at":"2017-03-22T04:00:51Z","git_url":"git://github.com/chenzlabs/aframe.git","ssh_url":"git@github.com:chenzlabs/aframe.git","clone_url":"https://github.com/chenzlabs/aframe.git","svn_url":"https://github.com/chenzlabs/aframe","homepage":"https://aframe.io/","size":168803,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"f88e9222383e39cb9de41b4e540210841aee79d5","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars3.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars3.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"A web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2017-03-23T01:44:01Z","pushed_at":"2017-03-22T22:01:07Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":161172,"stargazers_count":5026,"watchers_count":5026,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1036,"mirror_url":null,"open_issues_count":273,"forks":1036,"open_issues":273,"watchers":5026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2513"},"html":{"href":"https://github.com/aframevr/aframe/pull/2513"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2513"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2513/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2513/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2513/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/d606450573f5a85609061f2367c30f3b7c71ef4c"}}}}
{"actor":{"display_login":"dmarcos"}}