{"action":"created","issue":{"url":"https://api.github.com/repos/vuejs/vue/issues/6885","repository_url":"https://api.github.com/repos/vuejs/vue","labels_url":"https://api.github.com/repos/vuejs/vue/issues/6885/labels{/name}","comments_url":"https://api.github.com/repos/vuejs/vue/issues/6885/comments","events_url":"https://api.github.com/repos/vuejs/vue/issues/6885/events","html_url":"https://github.com/vuejs/vue/pull/6885","id":267657024,"number":6885,"title":"fix #6864: don't set ignoredElements' attributes to their default values","user":{"login":"imyzf","id":8298849,"avatar_url":"https://avatars1.githubusercontent.com/u/8298849?v=4","gravatar_id":"","url":"https://api.github.com/users/imyzf","html_url":"https://github.com/imyzf","followers_url":"https://api.github.com/users/imyzf/followers","following_url":"https://api.github.com/users/imyzf/following{/other_user}","gists_url":"https://api.github.com/users/imyzf/gists{/gist_id}","starred_url":"https://api.github.com/users/imyzf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyzf/subscriptions","organizations_url":"https://api.github.com/users/imyzf/orgs","repos_url":"https://api.github.com/users/imyzf/repos","events_url":"https://api.github.com/users/imyzf/events{/privacy}","received_events_url":"https://api.github.com/users/imyzf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-23T12:55:41Z","updated_at":"2017-10-24T02:13:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vuejs/vue/pulls/6885","html_url":"https://github.com/vuejs/vue/pull/6885","diff_url":"https://github.com/vuejs/vue/pull/6885.diff","patch_url":"https://github.com/vuejs/vue/pull/6885.patch"},"body":"Fix #6864\r\n\r\n<!--\r\nPlease make sure to read the Pull Request Guidelines:\r\nhttps://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines\r\n-->\r\n\r\n<!-- PULL REQUEST TEMPLATE -->\r\n<!-- (Update \"[ ]\" to \"[x]\" to check a box) -->\r\n\r\n**What kind of change does this PR introduce?** (check at least one)\r\n\r\n- [x] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update\r\n- [ ] Refactor\r\n- [ ] Build-related changes\r\n- [ ] Other, please describe:\r\n\r\n**Does this PR introduce a breaking change?** (check one)\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\nIf yes, please describe the impact and migration path for existing applications:\r\n\r\n**The PR fulfills these requirements:**\r\n\r\n- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch\r\n- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where \"xxx\" is the issue number)\r\n- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup\r\n- [ ] New/updated tests are included\r\n\r\nIf adding a **new feature**, the PR's description includes:\r\n- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)\r\n\r\n**Other information:**\r\n"},"comment":{"url":"https://api.github.com/repos/vuejs/vue/issues/comments/338850785","html_url":"https://github.com/vuejs/vue/pull/6885#issuecomment-338850785","issue_url":"https://api.github.com/repos/vuejs/vue/issues/6885","id":338850785,"user":{"login":"imyzf","id":8298849,"avatar_url":"https://avatars1.githubusercontent.com/u/8298849?v=4","gravatar_id":"","url":"https://api.github.com/users/imyzf","html_url":"https://github.com/imyzf","followers_url":"https://api.github.com/users/imyzf/followers","following_url":"https://api.github.com/users/imyzf/following{/other_user}","gists_url":"https://api.github.com/users/imyzf/gists{/gist_id}","starred_url":"https://api.github.com/users/imyzf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyzf/subscriptions","organizations_url":"https://api.github.com/users/imyzf/orgs","repos_url":"https://api.github.com/users/imyzf/repos","events_url":"https://api.github.com/users/imyzf/events{/privacy}","received_events_url":"https://api.github.com/users/imyzf/received_events","type":"User","site_admin":false},"created_at":"2017-10-24T02:13:10Z","updated_at":"2017-10-24T02:13:10Z","author_association":"CONTRIBUTOR","body":"@yyx990803 Thanks for your suggestions. I have a new idea:\r\n\r\n1. Add a flag `isIgnoredElement` to `VNode`\r\n2. Judge and set `isIgnoredElement` in [createElm](https://github.com/vuejs/vue/blob/v2.5.2/src/core/vdom/patch.js#L107)\r\n3. In `setAttr`,  strip the default attribution process if `isIgnoredElement` is `true`\r\n\r\nWould this be better?"}}
{"actor":{"display_login":"imyzf"}}