{"action":"closed","number":18522,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/18522","id":141354077,"html_url":"https://github.com/servo/servo/pull/18522","diff_url":"https://github.com/servo/servo/pull/18522.diff","patch_url":"https://github.com/servo/servo/pull/18522.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/18522","number":18522,"state":"closed","locked":false,"title":"Upgraded to serde v1.0.14.","user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nUpgrade to serde 1.0.14, needed to get serde to support NonZero.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes do not require tests because upgrading dependency\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/18522)\n<!-- Reviewable:end -->\n","created_at":"2017-09-15T16:42:37Z","updated_at":"2017-09-15T17:02:37Z","closed_at":"2017-09-15T17:02:37Z","merged_at":null,"merge_commit_sha":"250de758f3581eb140322c91d147423ffe2e3be4","assignee":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars0.githubusercontent.com/u/157897?v=4","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"assignees":[{"login":"pcwalton","id":157897,"avatar_url":"https://avatars0.githubusercontent.com/u/157897?v=4","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/18522/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/18522/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/18522/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/29003114ecb02dee0efda89e918e2f7ff6177679","head":{"label":"asajeffrey:serdeup","ref":"serdeup","sha":"29003114ecb02dee0efda89e918e2f7ff6177679","user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"repo":{"id":44559130,"name":"servo","full_name":"asajeffrey/servo","owner":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asajeffrey/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/asajeffrey/servo","forks_url":"https://api.github.com/repos/asajeffrey/servo/forks","keys_url":"https://api.github.com/repos/asajeffrey/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asajeffrey/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asajeffrey/servo/teams","hooks_url":"https://api.github.com/repos/asajeffrey/servo/hooks","issue_events_url":"https://api.github.com/repos/asajeffrey/servo/issues/events{/number}","events_url":"https://api.github.com/repos/asajeffrey/servo/events","assignees_url":"https://api.github.com/repos/asajeffrey/servo/assignees{/user}","branches_url":"https://api.github.com/repos/asajeffrey/servo/branches{/branch}","tags_url":"https://api.github.com/repos/asajeffrey/servo/tags","blobs_url":"https://api.github.com/repos/asajeffrey/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asajeffrey/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asajeffrey/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/asajeffrey/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asajeffrey/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/asajeffrey/servo/languages","stargazers_url":"https://api.github.com/repos/asajeffrey/servo/stargazers","contributors_url":"https://api.github.com/repos/asajeffrey/servo/contributors","subscribers_url":"https://api.github.com/repos/asajeffrey/servo/subscribers","subscription_url":"https://api.github.com/repos/asajeffrey/servo/subscription","commits_url":"https://api.github.com/repos/asajeffrey/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/asajeffrey/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/asajeffrey/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/asajeffrey/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/asajeffrey/servo/contents/{+path}","compare_url":"https://api.github.com/repos/asajeffrey/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asajeffrey/servo/merges","archive_url":"https://api.github.com/repos/asajeffrey/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asajeffrey/servo/downloads","issues_url":"https://api.github.com/repos/asajeffrey/servo/issues{/number}","pulls_url":"https://api.github.com/repos/asajeffrey/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/asajeffrey/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/asajeffrey/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asajeffrey/servo/labels{/name}","releases_url":"https://api.github.com/repos/asajeffrey/servo/releases{/id}","deployments_url":"https://api.github.com/repos/asajeffrey/servo/deployments","created_at":"2015-10-19T19:40:43Z","updated_at":"2016-01-18T23:24:06Z","pushed_at":"2017-09-15T16:58:53Z","git_url":"git://github.com/asajeffrey/servo.git","ssh_url":"git@github.com:asajeffrey/servo.git","clone_url":"https://github.com/asajeffrey/servo.git","svn_url":"https://github.com/asajeffrey/servo","homepage":"","size":288190,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"f1da967ef707bbc77f023daf28093201e96e19c5","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2017-09-15T16:06:33Z","pushed_at":"2017-09-15T17:00:19Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":365778,"stargazers_count":10006,"watchers_count":10006,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1718,"mirror_url":null,"open_issues_count":2325,"forks":1718,"open_issues":2325,"watchers":10006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/18522"},"html":{"href":"https://github.com/servo/servo/pull/18522"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/18522"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/18522/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/18522/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/18522/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/29003114ecb02dee0efda89e918e2f7ff6177679"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":40,"deletions":40,"changed_files":1}}
{"actor":{"display_login":"asajeffrey"}}