{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/147234333","pull_request_review_id":72302827,"id":147234333,"diff_hunk":"@@ -85,7 +85,7 @@ export function main() {\n       driver = new Driver(scope, scope, new CacheDatabase(scope, scope));\n \n       scope.clients.add('default');\n-      scope.clients.getMock('default') !.queue.subscribe(msg => { reg.sendMessage(msg); });","path":"packages/service-worker/test/integration_spec.ts","position":4,"original_position":4,"commit_id":"6b65867abfa32c78038e0ca9cb155454783ca6ca","original_commit_id":"6b65867abfa32c78038e0ca9cb155454783ca6ca","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"I think you can remove `reg` and `MockServiceWorkerRegistration` from this file. It is not really used any more.","created_at":"2017-10-26T18:51:15Z","updated_at":"2017-10-26T18:59:22Z","html_url":"https://github.com/angular/angular/pull/19954#discussion_r147234333","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/19954","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/147234333"},"html":{"href":"https://github.com/angular/angular/pull/19954#discussion_r147234333"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/19954"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/19954","id":148998718,"html_url":"https://github.com/angular/angular/pull/19954","diff_url":"https://github.com/angular/angular/pull/19954.diff","patch_url":"https://github.com/angular/angular/pull/19954.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/19954","number":19954,"state":"open","locked":false,"title":"fix(service-worker): listen for messages on the right event source","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"body":"Currently, the SwUpdate service doesn't receive messages from the SW.\r\nThis is because it attempts to subscribe to the 'message' event on\r\nServiceWorkerRegistration, when really messages are emitted by the\r\nServiceWorkerContainer.\r\n\r\nThis change moves to listening on ServiceWorkerContainer and changes\r\nthe mocks to reflect the way the browser actually works.","created_at":"2017-10-26T17:33:53Z","updated_at":"2017-10-26T18:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f514dedd41d0744f7673310b314f1bc9c2d0900","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/19954/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/19954/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/19954/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/6b65867abfa32c78038e0ca9cb155454783ca6ca","head":{"label":"alxhub:fix-sw-comms","ref":"fix-sw-comms","sha":"6b65867abfa32c78038e0ca9cb155454783ca6ca","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"repo":{"id":35444156,"name":"angular","full_name":"alxhub/angular","owner":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alxhub/angular","description":null,"fork":true,"url":"https://api.github.com/repos/alxhub/angular","forks_url":"https://api.github.com/repos/alxhub/angular/forks","keys_url":"https://api.github.com/repos/alxhub/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alxhub/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alxhub/angular/teams","hooks_url":"https://api.github.com/repos/alxhub/angular/hooks","issue_events_url":"https://api.github.com/repos/alxhub/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alxhub/angular/events","assignees_url":"https://api.github.com/repos/alxhub/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alxhub/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alxhub/angular/tags","blobs_url":"https://api.github.com/repos/alxhub/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alxhub/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alxhub/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alxhub/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alxhub/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alxhub/angular/languages","stargazers_url":"https://api.github.com/repos/alxhub/angular/stargazers","contributors_url":"https://api.github.com/repos/alxhub/angular/contributors","subscribers_url":"https://api.github.com/repos/alxhub/angular/subscribers","subscription_url":"https://api.github.com/repos/alxhub/angular/subscription","commits_url":"https://api.github.com/repos/alxhub/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alxhub/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alxhub/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alxhub/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alxhub/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alxhub/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alxhub/angular/merges","archive_url":"https://api.github.com/repos/alxhub/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alxhub/angular/downloads","issues_url":"https://api.github.com/repos/alxhub/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alxhub/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alxhub/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alxhub/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alxhub/angular/labels{/name}","releases_url":"https://api.github.com/repos/alxhub/angular/releases{/id}","deployments_url":"https://api.github.com/repos/alxhub/angular/deployments","created_at":"2015-05-11T19:08:26Z","updated_at":"2016-01-25T22:09:11Z","pushed_at":"2017-10-26T17:45:03Z","git_url":"git://github.com/alxhub/angular.git","ssh_url":"git@github.com:alxhub/angular.git","clone_url":"https://github.com/alxhub/angular.git","svn_url":"https://github.com/alxhub/angular","homepage":null,"size":66744,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"703fcda5901b9c87be298a1b1dc7a66c04910928","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-10-26T18:40:55Z","pushed_at":"2017-10-26T18:33:32Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":68090,"stargazers_count":29184,"watchers_count":29184,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7279,"mirror_url":null,"archived":false,"open_issues_count":2192,"forks":7279,"open_issues":2192,"watchers":29184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/19954"},"html":{"href":"https://github.com/angular/angular/pull/19954"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/19954"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/19954/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/19954/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/19954/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/6b65867abfa32c78038e0ca9cb155454783ca6ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gkalpak"}}