{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/95480879","pull_request_review_id":16037233,"id":95480879,"diff_hunk":"@@ -5307,6 +5310,8 @@ assert(refCountedStore.isInitialized)).\n     RefCounted!int b;\n     b = a; //This should not assert either\n     assert(b == 5);\n+\n+    RefCounted!(int*) c;","path":"std/typecons.d","position":126,"original_position":126,"commit_id":"a9e7c9b29a72e703f77f54548e57649f2b948e41","original_commit_id":"a9e7c9b29a72e703f77f54548e57649f2b948e41","user":{"login":"nordlow","id":829407,"avatar_url":"https://avatars.githubusercontent.com/u/829407?v=3","gravatar_id":"","url":"https://api.github.com/users/nordlow","html_url":"https://github.com/nordlow","followers_url":"https://api.github.com/users/nordlow/followers","following_url":"https://api.github.com/users/nordlow/following{/other_user}","gists_url":"https://api.github.com/users/nordlow/gists{/gist_id}","starred_url":"https://api.github.com/users/nordlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordlow/subscriptions","organizations_url":"https://api.github.com/users/nordlow/orgs","repos_url":"https://api.github.com/users/nordlow/repos","events_url":"https://api.github.com/users/nordlow/events{/privacy}","received_events_url":"https://api.github.com/users/nordlow/received_events","type":"User","site_admin":false},"body":"This makes line 5003 covered.","created_at":"2017-01-10T23:22:04Z","updated_at":"2017-01-10T23:22:51Z","html_url":"https://github.com/dlang/phobos/pull/4832#discussion_r95480879","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/4832","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/95480879"},"html":{"href":"https://github.com/dlang/phobos/pull/4832#discussion_r95480879"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4832"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4832","id":87648249,"html_url":"https://github.com/dlang/phobos/pull/4832","diff_url":"https://github.com/dlang/phobos/pull/4832.diff","patch_url":"https://github.com/dlang/phobos/pull/4832.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4832","number":4832,"state":"open","locked":false,"title":"std.typecons: Make RefCounted pure nothrow @nogc when possible","user":{"login":"nordlow","id":829407,"avatar_url":"https://avatars.githubusercontent.com/u/829407?v=3","gravatar_id":"","url":"https://api.github.com/users/nordlow","html_url":"https://github.com/nordlow","followers_url":"https://api.github.com/users/nordlow/followers","following_url":"https://api.github.com/users/nordlow/following{/other_user}","gists_url":"https://api.github.com/users/nordlow/gists{/gist_id}","starred_url":"https://api.github.com/users/nordlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordlow/subscriptions","organizations_url":"https://api.github.com/users/nordlow/orgs","repos_url":"https://api.github.com/users/nordlow/repos","events_url":"https://api.github.com/users/nordlow/events{/privacy}","received_events_url":"https://api.github.com/users/nordlow/received_events","type":"User","site_admin":false},"body":"This makes `RefCounted!T` `pure` when `T` has no indirections (and its instances doesn't need to be tracked by the GC), that is `hasIndirections!T` is `false`.\n\nWhy is `GC.addRange` not `pure` aswell? In this case, I see no reason why it shouldn't.\n\nCan we pleease fix this? It's currently very very annoying to have to unpure all my algorithms when I switch from builtin arrays and AAs to my own containers combined with std.typecons.RefCounted.\n","created_at":"2016-10-02T22:01:10Z","updated_at":"2017-01-10T23:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8229095eee263168c6aded7ed101b155a971e02d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4832/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4832/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4832/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/a9e7c9b29a72e703f77f54548e57649f2b948e41","head":{"label":"nordlow:pure-refcounted","ref":"pure-refcounted","sha":"a9e7c9b29a72e703f77f54548e57649f2b948e41","user":{"login":"nordlow","id":829407,"avatar_url":"https://avatars.githubusercontent.com/u/829407?v=3","gravatar_id":"","url":"https://api.github.com/users/nordlow","html_url":"https://github.com/nordlow","followers_url":"https://api.github.com/users/nordlow/followers","following_url":"https://api.github.com/users/nordlow/following{/other_user}","gists_url":"https://api.github.com/users/nordlow/gists{/gist_id}","starred_url":"https://api.github.com/users/nordlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordlow/subscriptions","organizations_url":"https://api.github.com/users/nordlow/orgs","repos_url":"https://api.github.com/users/nordlow/repos","events_url":"https://api.github.com/users/nordlow/events{/privacy}","received_events_url":"https://api.github.com/users/nordlow/received_events","type":"User","site_admin":false},"repo":{"id":17300435,"name":"phobos","full_name":"nordlow/phobos","owner":{"login":"nordlow","id":829407,"avatar_url":"https://avatars.githubusercontent.com/u/829407?v=3","gravatar_id":"","url":"https://api.github.com/users/nordlow","html_url":"https://github.com/nordlow","followers_url":"https://api.github.com/users/nordlow/followers","following_url":"https://api.github.com/users/nordlow/following{/other_user}","gists_url":"https://api.github.com/users/nordlow/gists{/gist_id}","starred_url":"https://api.github.com/users/nordlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordlow/subscriptions","organizations_url":"https://api.github.com/users/nordlow/orgs","repos_url":"https://api.github.com/users/nordlow/repos","events_url":"https://api.github.com/users/nordlow/events{/privacy}","received_events_url":"https://api.github.com/users/nordlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nordlow/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/nordlow/phobos","forks_url":"https://api.github.com/repos/nordlow/phobos/forks","keys_url":"https://api.github.com/repos/nordlow/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nordlow/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nordlow/phobos/teams","hooks_url":"https://api.github.com/repos/nordlow/phobos/hooks","issue_events_url":"https://api.github.com/repos/nordlow/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/nordlow/phobos/events","assignees_url":"https://api.github.com/repos/nordlow/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/nordlow/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/nordlow/phobos/tags","blobs_url":"https://api.github.com/repos/nordlow/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nordlow/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nordlow/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/nordlow/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nordlow/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/nordlow/phobos/languages","stargazers_url":"https://api.github.com/repos/nordlow/phobos/stargazers","contributors_url":"https://api.github.com/repos/nordlow/phobos/contributors","subscribers_url":"https://api.github.com/repos/nordlow/phobos/subscribers","subscription_url":"https://api.github.com/repos/nordlow/phobos/subscription","commits_url":"https://api.github.com/repos/nordlow/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/nordlow/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/nordlow/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/nordlow/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/nordlow/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/nordlow/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nordlow/phobos/merges","archive_url":"https://api.github.com/repos/nordlow/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nordlow/phobos/downloads","issues_url":"https://api.github.com/repos/nordlow/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/nordlow/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/nordlow/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/nordlow/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nordlow/phobos/labels{/name}","releases_url":"https://api.github.com/repos/nordlow/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/nordlow/phobos/deployments","created_at":"2014-02-28T21:33:26Z","updated_at":"2016-10-13T11:27:09Z","pushed_at":"2017-01-10T12:00:24Z","git_url":"git://github.com/nordlow/phobos.git","ssh_url":"git@github.com:nordlow/phobos.git","clone_url":"https://github.com/nordlow/phobos.git","svn_url":"https://github.com/nordlow/phobos","homepage":"dlang.org/phobos","size":48530,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"de51b31bf6b0ef39d1250795ccef33a6ad22b4a5","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2017-01-09T10:50:30Z","pushed_at":"2017-01-10T22:56:45Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":48655,"stargazers_count":769,"watchers_count":769,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":92,"forks":531,"open_issues":92,"watchers":769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4832"},"html":{"href":"https://github.com/dlang/phobos/pull/4832"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4832"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4832/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4832/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4832/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/a9e7c9b29a72e703f77f54548e57649f2b948e41"}}}}
{"actor":{"display_login":"nordlow"}}