{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/130527908","pull_request_review_id":53411080,"id":130527908,"diff_hunk":"@@ -792,6 +793,15 @@ def _save_exploration(committer_id, exploration, commit_message, change_list):\n                 'which is too old. Please reload the page and try again.'\n                 % (exploration_model.version, exploration.version))\n \n+    if feconf.ENABLE_STRING_CLASSIFIER:","path":"core/domain/exp_services.py","position":12,"original_position":12,"commit_id":"630d185f5f9a7bc63dbefe7cb470ce7902308370","original_commit_id":"b97e61c33580412623e6c8fc833196960d3e1742","user":{"login":"pranavsid98","id":15828797,"avatar_url":"https://avatars0.githubusercontent.com/u/15828797?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavsid98","html_url":"https://github.com/pranavsid98","followers_url":"https://api.github.com/users/pranavsid98/followers","following_url":"https://api.github.com/users/pranavsid98/following{/other_user}","gists_url":"https://api.github.com/users/pranavsid98/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavsid98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavsid98/subscriptions","organizations_url":"https://api.github.com/users/pranavsid98/orgs","repos_url":"https://api.github.com/users/pranavsid98/repos","events_url":"https://api.github.com/users/pranavsid98/events{/privacy}","received_events_url":"https://api.github.com/users/pranavsid98/received_events","type":"User","site_admin":false},"body":"Sorry again. I'll make sure to do that from next time. I've made the changes.","created_at":"2017-08-01T06:26:51Z","updated_at":"2017-08-01T06:26:51Z","html_url":"https://github.com/oppia/oppia/pull/3650#discussion_r130527908","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3650","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/130527908"},"html":{"href":"https://github.com/oppia/oppia/pull/3650#discussion_r130527908"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3650"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3650","id":130788550,"html_url":"https://github.com/oppia/oppia/pull/3650","diff_url":"https://github.com/oppia/oppia/pull/3650.diff","patch_url":"https://github.com/oppia/oppia/pull/3650.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3650","number":3650,"state":"open","locked":false,"title":"Fix #3467: Introduce re-training and add_to_training_queue methods","user":{"login":"pranavsid98","id":15828797,"avatar_url":"https://avatars0.githubusercontent.com/u/15828797?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavsid98","html_url":"https://github.com/pranavsid98","followers_url":"https://api.github.com/users/pranavsid98/followers","following_url":"https://api.github.com/users/pranavsid98/following{/other_user}","gists_url":"https://api.github.com/users/pranavsid98/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavsid98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavsid98/subscriptions","organizations_url":"https://api.github.com/users/pranavsid98/orgs","repos_url":"https://api.github.com/users/pranavsid98/repos","events_url":"https://api.github.com/users/pranavsid98/events{/privacy}","received_events_url":"https://api.github.com/users/pranavsid98/received_events","type":"User","site_admin":false},"body":"#3467 \r\n\r\nThis PR implements two methods.\r\n- add_to_training_queue() method takes an exploration domain object and iterates through all the states in an exploration. It checks for states that can undergo training and then checks if a classifier is present for that state already. If there is a classifier, it checks if re-training is required and creates a job model accordingly . If there is no classifier, it creates a job model. This method will be called within _save_exploration() method whenever there is an update for the exploration.\r\n\r\n- check_re_training_conditions() method takes a state domain object and compares the new training data obtained from the state with the old training data obtained from the job. If re-training conditions are satisfied, it returns True. Otherwise, its returns False.\r\n\r\nI've also tested both methods adequately covering all cases.\r\n\r\nNote: There is a small case that I'm working on - how to handle cases where one answer group is added and another is removed. So, if we get that case working, this PR will be complete.\r\n\r\n@seanlip @anmolshkl @prasanna08 PTAL.","created_at":"2017-07-17T05:59:55Z","updated_at":"2017-08-01T06:26:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1d4bd3c676b028434d8d75efdf7e2a85f39dff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3650/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3650/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3650/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/630d185f5f9a7bc63dbefe7cb470ce7902308370","head":{"label":"pranavsid98:re_training","ref":"re_training","sha":"630d185f5f9a7bc63dbefe7cb470ce7902308370","user":{"login":"pranavsid98","id":15828797,"avatar_url":"https://avatars0.githubusercontent.com/u/15828797?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavsid98","html_url":"https://github.com/pranavsid98","followers_url":"https://api.github.com/users/pranavsid98/followers","following_url":"https://api.github.com/users/pranavsid98/following{/other_user}","gists_url":"https://api.github.com/users/pranavsid98/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavsid98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavsid98/subscriptions","organizations_url":"https://api.github.com/users/pranavsid98/orgs","repos_url":"https://api.github.com/users/pranavsid98/repos","events_url":"https://api.github.com/users/pranavsid98/events{/privacy}","received_events_url":"https://api.github.com/users/pranavsid98/received_events","type":"User","site_admin":false},"repo":{"id":86517373,"name":"oppia","full_name":"pranavsid98/oppia","owner":{"login":"pranavsid98","id":15828797,"avatar_url":"https://avatars0.githubusercontent.com/u/15828797?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavsid98","html_url":"https://github.com/pranavsid98","followers_url":"https://api.github.com/users/pranavsid98/followers","following_url":"https://api.github.com/users/pranavsid98/following{/other_user}","gists_url":"https://api.github.com/users/pranavsid98/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavsid98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavsid98/subscriptions","organizations_url":"https://api.github.com/users/pranavsid98/orgs","repos_url":"https://api.github.com/users/pranavsid98/repos","events_url":"https://api.github.com/users/pranavsid98/events{/privacy}","received_events_url":"https://api.github.com/users/pranavsid98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pranavsid98/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/pranavsid98/oppia","forks_url":"https://api.github.com/repos/pranavsid98/oppia/forks","keys_url":"https://api.github.com/repos/pranavsid98/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pranavsid98/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pranavsid98/oppia/teams","hooks_url":"https://api.github.com/repos/pranavsid98/oppia/hooks","issue_events_url":"https://api.github.com/repos/pranavsid98/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/pranavsid98/oppia/events","assignees_url":"https://api.github.com/repos/pranavsid98/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/pranavsid98/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/pranavsid98/oppia/tags","blobs_url":"https://api.github.com/repos/pranavsid98/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pranavsid98/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pranavsid98/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pranavsid98/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pranavsid98/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/pranavsid98/oppia/languages","stargazers_url":"https://api.github.com/repos/pranavsid98/oppia/stargazers","contributors_url":"https://api.github.com/repos/pranavsid98/oppia/contributors","subscribers_url":"https://api.github.com/repos/pranavsid98/oppia/subscribers","subscription_url":"https://api.github.com/repos/pranavsid98/oppia/subscription","commits_url":"https://api.github.com/repos/pranavsid98/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pranavsid98/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pranavsid98/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pranavsid98/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pranavsid98/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/pranavsid98/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pranavsid98/oppia/merges","archive_url":"https://api.github.com/repos/pranavsid98/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pranavsid98/oppia/downloads","issues_url":"https://api.github.com/repos/pranavsid98/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/pranavsid98/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/pranavsid98/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/pranavsid98/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pranavsid98/oppia/labels{/name}","releases_url":"https://api.github.com/repos/pranavsid98/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/pranavsid98/oppia/deployments","created_at":"2017-03-28T23:28:50Z","updated_at":"2017-03-28T23:28:55Z","pushed_at":"2017-08-01T04:46:12Z","git_url":"git://github.com/pranavsid98/oppia.git","ssh_url":"git@github.com:pranavsid98/oppia.git","clone_url":"https://github.com/pranavsid98/oppia.git","svn_url":"https://github.com/pranavsid98/oppia","homepage":"https://www.oppia.org","size":59764,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"c149bc0c666a0eedb2e13a318bbe4f4b04bb77e2","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-07-31T19:09:06Z","pushed_at":"2017-08-01T04:46:13Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":66928,"stargazers_count":337,"watchers_count":337,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"open_issues_count":346,"forks":439,"open_issues":346,"watchers":337,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3650"},"html":{"href":"https://github.com/oppia/oppia/pull/3650"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3650"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3650/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3650/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3650/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/630d185f5f9a7bc63dbefe7cb470ce7902308370"}}}}
{"actor":{"display_login":"pranavsid98"}}