{"action":"created","issue":{"url":"https://api.github.com/repos/canjs/canjs/issues/3319","repository_url":"https://api.github.com/repos/canjs/canjs","labels_url":"https://api.github.com/repos/canjs/canjs/issues/3319/labels{/name}","comments_url":"https://api.github.com/repos/canjs/canjs/issues/3319/comments","events_url":"https://api.github.com/repos/canjs/canjs/issues/3319/events","html_url":"https://github.com/canjs/canjs/pull/3319","id":237052095,"number":3319,"title":"Add ReactViewModel","user":{"login":"christopherjbaker","id":980338,"avatar_url":"https://avatars0.githubusercontent.com/u/980338?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherjbaker","html_url":"https://github.com/christopherjbaker","followers_url":"https://api.github.com/users/christopherjbaker/followers","following_url":"https://api.github.com/users/christopherjbaker/following{/other_user}","gists_url":"https://api.github.com/users/christopherjbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherjbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherjbaker/subscriptions","organizations_url":"https://api.github.com/users/christopherjbaker/orgs","repos_url":"https://api.github.com/users/christopherjbaker/repos","events_url":"https://api.github.com/users/christopherjbaker/events{/privacy}","received_events_url":"https://api.github.com/users/christopherjbaker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"matthewp","id":361671,"avatar_url":"https://avatars1.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewp","id":361671,"avatar_url":"https://avatars1.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},{"login":"m-mujica","id":724877,"avatar_url":"https://avatars2.githubusercontent.com/u/724877?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mujica","html_url":"https://github.com/m-mujica","followers_url":"https://api.github.com/users/m-mujica/followers","following_url":"https://api.github.com/users/m-mujica/following{/other_user}","gists_url":"https://api.github.com/users/m-mujica/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mujica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mujica/subscriptions","organizations_url":"https://api.github.com/users/m-mujica/orgs","repos_url":"https://api.github.com/users/m-mujica/repos","events_url":"https://api.github.com/users/m-mujica/events{/privacy}","received_events_url":"https://api.github.com/users/m-mujica/received_events","type":"User","site_admin":false},{"login":"christopherjbaker","id":980338,"avatar_url":"https://avatars0.githubusercontent.com/u/980338?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherjbaker","html_url":"https://github.com/christopherjbaker","followers_url":"https://api.github.com/users/christopherjbaker/followers","following_url":"https://api.github.com/users/christopherjbaker/following{/other_user}","gists_url":"https://api.github.com/users/christopherjbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherjbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherjbaker/subscriptions","organizations_url":"https://api.github.com/users/christopherjbaker/orgs","repos_url":"https://api.github.com/users/christopherjbaker/repos","events_url":"https://api.github.com/users/christopherjbaker/events{/privacy}","received_events_url":"https://api.github.com/users/christopherjbaker/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-06-19T23:31:17Z","updated_at":"2017-07-05T13:27:45Z","closed_at":"2017-07-05T12:47:57Z","pull_request":{"url":"https://api.github.com/repos/canjs/canjs/pulls/3319","html_url":"https://github.com/canjs/canjs/pull/3319","diff_url":"https://github.com/canjs/canjs/pull/3319.diff","patch_url":"https://github.com/canjs/canjs/pull/3319.patch"},"body":"I added the shrinkwrapped dependencies, modified the docs glob, and incorporated the tests."},"comment":{"url":"https://api.github.com/repos/canjs/canjs/issues/comments/313102650","html_url":"https://github.com/canjs/canjs/pull/3319#issuecomment-313102650","issue_url":"https://api.github.com/repos/canjs/canjs/issues/3319","id":313102650,"user":{"login":"justinbmeyer","id":78602,"avatar_url":"https://avatars3.githubusercontent.com/u/78602?v=3","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false},"created_at":"2017-07-05T13:27:45Z","updated_at":"2017-07-05T13:27:45Z","body":"Yeah, we should do it like kefir and jQuery ... not include them in the build, while allowing the build to work without them (at least the modules that don't depend on them).\n\nI know for jQuery, we do this conditionally a few places. We test that the jQuery module actually provided a value. \n\nSent from my iPhone\n\n> On Jul 5, 2017, at 7:13 AM, Matthew Phillips <notifications@github.com> wrote:\n> \n> So I think we need to either include react and all of its dependencies into the build or exclude it, and react-view-model and can-react-component. For now I'm not to exclude those.\n> \n> —\n> You are receiving this because your review was requested.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"justinbmeyer"}}