{"push_id":1610339334,"size":23,"distinct_size":1,"ref":"refs/heads/service_registration5_activity","head":"395929dcee6db34e1b2a455b2b432582c095249c","before":"8aa5740b921e4e0384c095824f7e37f83b20a4f2","commits":[{"sha":"d65970f058c9d0249c2987d7ed04ab2b0ce693e3","author":{"name":"Kevin Howald","email":"d7ca0f00fd38e388ba11d4da4bd2fca64d14af30@users.noreply.github.com"},"message":"Amp-Video Bind Integration Test (#7727)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/d65970f058c9d0249c2987d7ed04ab2b0ce693e3"},{"sha":"1792a0f72df40cc808089f70c3563fde0e229b73","author":{"name":"Malte Ubl","email":"1f3c93f45a3f4c99e591c749f18b1443c4c6575b@users.noreply.github.com"},"message":"Removing step to add a label (#8039)\n\nExternal contributors unfortunately cannot do this, because GitHub doesn't allow granting this permission to everyone.","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/1792a0f72df40cc808089f70c3563fde0e229b73"},{"sha":"ed8c2c40f5a87c4bdb3e38ac8f1789230bbdd59e","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"amp-bind: Remove BindValidator.canBind (#8033)\n\n* remove BindValidator.canBind\r\n\r\n* lint fix\r\n\r\n* remove amp-source-origin check from bind-validator, fix array workaround for rewriteAttributeValue\r\n\r\n* fix other tests","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/ed8c2c40f5a87c4bdb3e38ac8f1789230bbdd59e"},{"sha":"ac4adb800ca05f0f3330f332f3d4894e1bb84241","author":{"name":"Martin","email":"a1073b906400dfa2eae57f3dec494361184605cd@googlemail.com"},"message":"Nexxtv player extension (#7816)\n\n* initial setup for extension nexxtv-player\r\n\r\n* added nexxtv player logic\r\n\r\n* nexxtv player bugfixes, cleanup, tests, docs\r\n\r\n* added video interface, changed attribute start to seek-to\r\n\r\n* reworked video interface for nexxtv-player\r\n\r\n* added message handler for nexxtv player and tests\r\n\r\n* nexxtv player minor fixes & cleanup\r\n\r\n* nexxtv player changed indents from 4 spaces to 2\r\n\r\n* added unlayoutCallback for nexxtv player\r\n\r\n* initial setup for extension nexxtv-player\r\n\r\n* added nexxtv player logic\r\n\r\n* nexxtv player bugfixes, cleanup, tests, docs\r\n\r\n* added video interface, changed attribute start to seek-to\r\n\r\n* reworked video interface for nexxtv-player\r\n\r\n* added message handler for nexxtv player and tests\r\n\r\n* nexxtv player minor fixes & cleanup\r\n\r\n* nexxtv player changed indents from 4 spaces to 2\r\n\r\n* added unlayoutCallback for nexxtv player\r\n\r\n* fixed linting issues (#7673)\r\n\r\n* initial setup for extension nexxtv-player\r\n\r\n* added nexxtv player logic\r\n\r\n* nexxtv player bugfixes, cleanup, tests, docs\r\n\r\n* added video interface, changed attribute start to seek-to\r\n\r\n* reworked video interface for nexxtv-player\r\n\r\n* added message handler for nexxtv player and tests\r\n\r\n* nexxtv player minor fixes & cleanup\r\n\r\n* nexxtv player changed indents from 4 spaces to 2\r\n\r\n* added unlayoutCallback for nexxtv player\r\n\r\n* initial setup for extension nexxtv-player\r\n\r\n* added nexxtv player logic\r\n\r\n* nexxtv player bugfixes, cleanup, tests, docs\r\n\r\n* added video interface, changed attribute start to seek-to\r\n\r\n* reworked video interface for nexxtv-player\r\n\r\n* added message handler for nexxtv player and tests\r\n\r\n* nexxtv player minor fixes & cleanup\r\n\r\n* fixed linting issues (#7673)\r\n\r\n* nexxtv player review fixes (#7816)\r\n\r\n* nexxtv player: updated validation rules (#7816)\r\n\r\n* nexxtv player validator ordered alphabetical, changed spec_url\r\n\r\n* fire amp-dom-update event on insert and replace (#7819)\r\n\r\n* temp\r\n\r\n* trigger `amp-dom-update` event on insert and replace\r\n\r\n* switch -amp-form to i-amp-form\r\n\r\n* Validator Rollup (#7844)\r\n\r\n* Revision bump.\r\n\r\n* Revision bump for amp-playbuzz changes in #7450\r\n\r\n* Revision bump.\r\n\r\n* Allow filtering by HtmlFormat (AMP, AMP4ADS) in the code generator.\r\n\r\n* Revision bump.\r\n\r\n* Revision bump due to Github pull.\r\n\r\n* Code generation now driven by a variable LIGHT, which is broader than the previous GENERATE_DETAILED_ERRORS distinction. LIGHT implies filtered for specific format (AMP or AMP4ADS, and only amp.validator.validateSaxEvents, and no detailed errors.\r\n\r\n* Generate ValidatorRules.directAttrLists and globalAttrs and ampLayoutAttrs, reducing overhead by indirection.\r\n\r\n* Implement parallax effect extension (#7794)\r\n\r\n* Do not set hidden attribute on hide/collapse (#7879)\r\n\r\n* amp-bind: Support `Math` functions (#7797)\r\n\r\n* initial commit for Math in amp-bind\r\n\r\n* fix lint\r\n\r\n* ali's comment\r\n\r\n* avoid scope conflicts with built-in functions\r\n\r\n* remove Math functions from documentation\r\n\r\n* Measure 3P ad latency (#7902)\r\n\r\n* Update spec URLs from github to ampproject. (#7901)\r\n\r\n* Update github urls to ampproject urls\r\n\r\n* test .out updated\r\n\r\n* Too many slashes.\r\n\r\n* Moved Developing.md and Design_Principles.md (#7908)\r\n\r\n* Rename DEVELOPING.md to contributing/DEVELOPING.md\r\n\r\n* Move files to new folder\r\n\r\n* Renaming toggle to toggleVisibility because it was conflicting with sidebar and breaking it (#7855)\r\n\r\n* disable scrollRestoration auto for embed case (#7899)\r\n\r\n* Disable Fast Fetch for all ads when remote.html is used. (#7906)\r\n\r\n* Fix DoubleClick Fast Fetch bugs around categoryExclusions and tagForChildDirectedTreatment (#7843)\r\n\r\n* Fix incorrect parameter name for `tagForChildDirectedTreatment` in DoubleClick.\r\n\r\n* Added unit test for tagForChildDirectedTreatment.\r\n\r\n* Fixed the categoryExclusions bug in Fast Fetch DoubleClick.\r\n\r\n* Removed parens in arrow functions to satisfy linter\r\n\r\n* Adds two new experiment IDs (#7850)\r\n\r\n* Adds two new experiment IDs to distinguish \"any externally triggered\" experiment from \"any internally triggered\".\r\n\r\nAlso updates tests to remove a number of assumptions that only a single eid will be populated.\r\n\r\n* Use return val to detect \"externally selected\"; test updates.\r\n\r\n* Updated network implementation guide. (#7862)\r\n\r\n* Updated network impl guide.\r\n\r\n* Changed 'validation' to 'verification'\r\n\r\n* Cid timeout error should not be dev error (#7911)\r\n\r\n* Fix amp-ad test (#7918)\r\n\r\n* Update amp-install-serviceworker.md (#7932)\r\n\r\nFully escape javascript regex.\r\n\r\n* Update amp-cache-modifications.md (#7933)\r\n\r\nAdd `data-no-service-worker-fallback-shell-url` as a URL to be rewritten as absolute.\r\n\r\n* amp-fx-parallax Don't use global (#7942)\r\n\r\n* Viewer integration: rewrite error message to indicate request name (#7923)\r\n\r\n* rewrite error message\r\n\r\n* update\r\n\r\n* ticks\r\n\r\n* Fix up links in DEVELOPING.md (#7944)\r\n\r\nWe moved DEVELOPING.md to the contributing folder but didn't update many of the relative links accordingly.\r\n\r\n* Popin ad extension document updated. (#7674)\r\n\r\n* Add popin ad extension.\r\n\r\n* register popin.\r\n\r\n* Add resizeable attribute.\r\n\r\n* Remove resizable.\r\n\r\n* Implemented the render-start and no-content APIs.\r\n\r\n* Fixed lint.\r\n\r\n* Remove quatation.\r\n\r\n* Use tei@popin.cc\r\n\r\n* Rebase old commit .\r\n\r\n* Fixed document because tag was not closed.\r\n\r\n* I replaced the removed double quotes.\r\n\r\n* Add double quotes.\r\n\r\n* Support for bind expressions in mustache templates (#7602)\r\n\r\n* first pass at adding/removing subtrees\r\n\r\n* tests passing\r\n\r\n* Add ability to add and remove bindings in the subtree rooted at a specific node\r\n\r\n* lint fixes\r\n\r\n* merge conflict\r\n\r\n* ci issues\r\n\r\n* some cleanup\r\n\r\n* pr comments\r\n\r\n* pr comments, new method of removing bindings for node and its children\r\n\r\n* fix some lint warnings\r\n\r\n* test and lint fixes\r\n\r\n* mutation observer\r\n\r\n* update comments\r\n\r\n* add observer\r\n\r\n* naive implementation\r\n\r\n* cleanup\r\n\r\n* clean\r\n\r\n* cleanup bind impl\r\n\r\n* very simple example of bind in a template\r\n\r\n* pr comments\r\n\r\n* lint errors\r\n\r\n* pr comments\r\n\r\n* cleanup\r\n\r\n* lint errors\r\n\r\n* pr comments\r\n\r\n* pr comments and lint warnings\r\n\r\n* typo\r\n\r\n* comments\r\n\r\n* more lint warnings\r\n\r\n* pr comment\r\n\r\n* change README\r\n\r\n* cleanup\r\n\r\n* pr comments\r\n\r\n* pr comments 2\r\n\r\n* lint warnings\r\n\r\n* don't use foreach on Nodelist\r\n\r\n* casting\r\n\r\n* more ci warnings\r\n\r\n* even more ci warnings\r\n\r\n* even more ci warnings\r\n\r\n* even more ci issues\r\n\r\n* even more ci comments\r\n\r\n* even more ci issues\r\n\r\n* pr comments\r\n\r\n* more pr comments\r\n\r\n* fix refactoring oversight\r\n\r\n* pr comments\r\n\r\n* pr comments\r\n\r\n* merge\r\n\r\n* pr comments\r\n\r\n* ci issues\r\n\r\n* pr comments\r\n\r\n* assertElement\r\n\r\n* pr comments\r\n\r\n* typo\r\n\r\n* updating sanitizer\r\n\r\n* fixing up sanitizer test\r\n\r\n* pr comments\r\n\r\n* pr comments\r\n\r\n* expanded on amp-mustache tests\r\n\r\n* pr comments\r\n\r\n* remove class from whitelist\r\n\r\n* restore whole sandbox\r\n\r\n* update mustache validator test and output\r\n\r\n* pr comments\r\n\r\n* nexxtv player gulp check-types fixes (#7816)\r\n\r\n* nexxtv player fix error gulp presumbit with postmessage (#7816)\r\n\r\n* added dependency check for nexxtv player (#7816)\r\n\r\n* nexxtv player minor fix in validator (#7816)\r\n\r\n* nexxtv player fixed validator (#7816)\r\n\r\n* fixed validator (#7816)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/ac4adb800ca05f0f3330f332f3d4894e1bb84241"},{"sha":"6107d2df5c08f975d023d99b845efbae236f95da","author":{"name":"Carlos Vializ","email":"c5ad3171f2710d42c48b67bd62502462827c5cd3@users.noreply.github.com"},"message":"Cleanup 'link-url-replace' experiment (#7969)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/6107d2df5c08f975d023d99b845efbae236f95da"},{"sha":"d38001335030ebdbb323008011ae9a230d638729","author":{"name":"Kevin Howald","email":"d7ca0f00fd38e388ba11d4da4bd2fca64d14af30@users.noreply.github.com"},"message":"Service Registration: Cid (#7859)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/d38001335030ebdbb323008011ae9a230d638729"},{"sha":"8d2979c947ddc6917b2c25841bb6eeec57cb1b7a","author":{"name":"Kevin Howald","email":"d7ca0f00fd38e388ba11d4da4bd2fca64d14af30@users.noreply.github.com"},"message":"Service Registration: Instrumentation (#7870)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/8d2979c947ddc6917b2c25841bb6eeec57cb1b7a"},{"sha":"424179729f74e9ccf9db99ea74b756ff2121de95","author":{"name":"Derek Lewis","email":"e7c2e53756c2e4363b2157aae1604b033e6d06bf@gmail.com"},"message":"Add empty amp-sortable-table component (#8029)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/424179729f74e9ccf9db99ea74b756ff2121de95"},{"sha":"943b9622c1b56bc646987fc28bff32718bcec671","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"fix build breakages (#8049)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/943b9622c1b56bc646987fc28bff32718bcec671"},{"sha":"f2659a3babe437a4d2ff2fb579652856ba0d0a05","author":{"name":"Hongfei Ding","email":"385e24b2043fd63635b63363f2bdc9ed5a2701b7@users.noreply.github.com"},"message":"Improve the iframe resize example page. (#8041)\n\n* Improve the iframe resize example page.\r\n\r\n* address comments","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/f2659a3babe437a4d2ff2fb579652856ba0d0a05"},{"sha":"703342df38c7b542e60ca1780a501521e98249dc","author":{"name":"Hongfei Ding","email":"385e24b2043fd63635b63363f2bdc9ed5a2701b7@users.noreply.github.com"},"message":"Remove unhandled code \"setFlushParams\". (#7817)\n\n* Remove unhandled code \"setFlushParams\".\r\n\r\n* fix lint\r\n\r\n* fix tests","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/703342df38c7b542e60ca1780a501521e98249dc"},{"sha":"9bbee9915541972a36209c50c6173fe00564463d","author":{"name":"Alan Orozco","email":"74b876137959c066637ecc3032f9a2ab2597253f@users.noreply.github.com"},"message":"Assert valid URL (#8043)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/9bbee9915541972a36209c50c6173fe00564463d"},{"sha":"a0b39f21eee33e6b45338f3e36bf48717117da77","author":{"name":"Vamsee Jasti","email":"760335e56cb91e85e114a5c402b89fce3d0e65ed@google.com"},"message":"Updating support for Adwords Conversion tracking (#8047)\n\n* Updating support for Adwords Conversion tracking\r\n\r\nDoc update\r\n\r\n* Fix typos","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/a0b39f21eee33e6b45338f3e36bf48717117da77"},{"sha":"29048802ac4417eb0c2032e7459d1f7df1baf7b5","author":{"name":"Yvo Schaap","email":"eb4a5908f6aab1e20f07e66ed7ed94ada91e3b5f@gmail.com"},"message":"Extension amp-facebook-comments (#7629)\n\n* Introduction of `amp-facebook-comments`\r\n\r\n* Typo in the word extension\r\n\r\n* Default values that matches docs\r\n\r\nhttps://developers.facebook.com/docs/plugins/comments/\r\n\r\n* Added comments to existing Facebook example\r\n\r\n* Linter issue fixed\r\n\r\n* Support colorscheme, fix compiler issue add comments\r\n\r\n* Remove unused function\r\n\r\n* Documentation and test files\r\n\r\n* Updated to right import reference\r\n\r\n* Comment out test validation\r\n\r\n* Mock iframe.context.tagName in test\r\n\r\n* Mock iframe.context.tagName in test (2)\r\n\r\n* Mock iframe.context.tagName in test (3)\r\n\r\n* As commented by @Gregable in PR\r\n\r\n* As commented by @Gregable in PR\r\n\r\nRemoved AMP4ADS support.\r\n\r\n* Removed validator\r\n\r\n* Removed validator (2)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/29048802ac4417eb0c2032e7459d1f7df1baf7b5"},{"sha":"bec6ecbd2987363c77c574db9dff959fca56b3a0","author":{"name":"Greg Grothaus","email":"3d07c94da9f4ddd63ae501564fe9ae3f18733ad1@gmail.com"},"message":"Add validation rules for amp-facebook-comments extension. (#8045)\n\n* Add validation rules for amp-facebook-comments extension.\r\n\r\n* Fix custom-element attribute value in test case.","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/bec6ecbd2987363c77c574db9dff959fca56b3a0"},{"sha":"431b45f161e16ddc2fcc03a9c4fce2058cb0d5fd","author":{"name":"Justin Ridgewell","email":"eed2bcb50b307b84ffae47fb7f0b80508b902de9@ridgewell.name"},"message":"Fix JSE error variable (#8058)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/431b45f161e16ddc2fcc03a9c4fce2058cb0d5fd"},{"sha":"309a5029903f70ef57fabc43193b1ff1fbc4751b","author":{"name":"Kevin Howald","email":"d7ca0f00fd38e388ba11d4da4bd2fca64d14af30@users.noreply.github.com"},"message":"Service Registration: XHR (#7875)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/309a5029903f70ef57fabc43193b1ff1fbc4751b"},{"sha":"2137a20711123ecc3923b4346ba58e471a4e39f8","author":{"name":"Tom P","email":"a4a9f6269b00fb839db06dc4fb2b8dd6e055c813@wix.com"},"message":"defer amp-image-lightbox build (#5601) (#7699)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/2137a20711123ecc3923b4346ba58e471a4e39f8"},{"sha":"bab40a6cfe2e3659c301ee9e264db6c567f2d96d","author":{"name":"Lillian","email":"045e09751d0fd2e7292dc873b631a21f54d00067@gmail.com"},"message":"Updated the Annotate Function declarations using lowercase 'function' instead of 'Function' (#7747)","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/bab40a6cfe2e3659c301ee9e264db6c567f2d96d"},{"sha":"2095608110a94fdb4b9ca7b25fcf2628e41c9ed9","author":{"name":"Joey Rozier","email":"7afb63c46ab43b0a2eb5864ef40a88e3050a0f45@users.noreply.github.com"},"message":"Move the title to the top (#8053)\n\nThe table of contents on top was bugging me...","distinct":false,"url":"https://api.github.com/repos/kmh287/amphtml/commits/2095608110a94fdb4b9ca7b25fcf2628e41c9ed9"}]}
{"actor":{"display_login":"kmh287"}}