{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/comments/143182032","pull_request_review_id":67658152,"id":143182032,"diff_hunk":"@@ -0,0 +1,50 @@\n+############################################################################\n+# This file is part of the Symfony CMF package.                            #\n+#                                                                          #\n+# (c) 2011-2017 Symfony CMF                                                #\n+#                                                                          #\n+# For the full copyright and license information, please view the LICENSE  #\n+# file that was distributed with this source code.                         #\n+############################################################################\n+\n+CONSOLE=vendor/symfony-cmf/testing/bin/console\n+\n+list:\n+\t@echo 'test:                  will run all tests'\n+\t@echo 'test_unit:             will run unit tests only'\n+\t@echo 'test_integration_phpcr:  will run integration tests on PHPCR'\n+\t@echo 'test_integration_orm:  will run integration tests on ORM'\n+\n+test_integration_phpcr:\n+\t@echo\n+\t@echo '+++ create PHPCR +++'\n+\t${CONSOLE} doctrine:phpcr:init:dbal --drop --force\n+\t${CONSOLE} doctrine:phpcr:repository:init\n+\t@echo '+++ run PHPCR integratin tests +++'\n+\tvendor/bin/simple-phpunit --testsuite \"phpcr\"\n+\t${CONSOLE} doctrine:database:drop --force\n+\n+test_integration_orm:\n+\t@echo\n+\t@echo '+++ Create ORM database +++'\n+\t${CONSOLE} doctrine:schema:drop --env=orm --force\n+\t${CONSOLE} doctrine:database:create --env=orm\n+\t${CONSOLE} doctrine:schema:create --env=orm\n+\t@echo '+++ run PHPCR integratin tests +++'\n+\tvendor/bin/simple-phpunit --testsuite \"orm\"\n+\t${CONSOLE} doctrine:database:drop --force\n+\n+\n+test_unit:\n+\t@echo\n+\t@echo '+++ run unit tests +++'\n+\tvendor/bin/simple-phpunit --testsuite \"unit tests\"\n+\n+test_installation:","path":"Makefile","position":43,"original_position":43,"commit_id":"d36cdd1941427cd30fbc2d392755aa99717ddf94","original_commit_id":"07964df7187cd2605e44535264756d9bdf93a948","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars1.githubusercontent.com/u/2905834?v=4","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"Sure. But i can do one step after each only. So:\n\n1. Getting this working in complete\n2. Move tasks to scripts in `testing`\n3. Serve Makefile and .travis.yaml from a dev-kit, calling scripts in `testing` to all of our bundles?\n4. Fix broken stuff\n5. Happy\n\nI would even move the `testing-install` stuff into `testing` later. Currently it is the easiest way to get an overview an serve changes. ","created_at":"2017-10-06T12:54:00Z","updated_at":"2017-10-06T12:54:00Z","html_url":"https://github.com/symfony-cmf/seo-bundle/pull/336#discussion_r143182032","pull_request_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/comments/143182032"},"html":{"href":"https://github.com/symfony-cmf/seo-bundle/pull/336#discussion_r143182032"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336"}},"in_reply_to_id":142770947},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336","id":139990778,"html_url":"https://github.com/symfony-cmf/seo-bundle/pull/336","diff_url":"https://github.com/symfony-cmf/seo-bundle/pull/336.diff","patch_url":"https://github.com/symfony-cmf/seo-bundle/pull/336.patch","issue_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/336","number":336,"state":"open","locked":false,"title":"[POC] use make file","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars1.githubusercontent.com/u/2905834?v=4","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"This would be my first try to use make files and instantiate database there instead of using the `DatabaseListener`.\r\nWhat do you think?\r\n\r\nfix #334 ","created_at":"2017-09-08T09:19:28Z","updated_at":"2017-10-06T12:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40ae69ed096a5cf66896f0e7bcacbf34a6b5a5ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wouterj","id":749025,"avatar_url":"https://avatars2.githubusercontent.com/u/749025?v=4","gravatar_id":"","url":"https://api.github.com/users/wouterj","html_url":"https://github.com/wouterj","followers_url":"https://api.github.com/users/wouterj/followers","following_url":"https://api.github.com/users/wouterj/following{/other_user}","gists_url":"https://api.github.com/users/wouterj/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterj/subscriptions","organizations_url":"https://api.github.com/users/wouterj/orgs","repos_url":"https://api.github.com/users/wouterj/repos","events_url":"https://api.github.com/users/wouterj/events{/privacy}","received_events_url":"https://api.github.com/users/wouterj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/336/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/statuses/d36cdd1941427cd30fbc2d392755aa99717ddf94","head":{"label":"symfony-cmf:make_file","ref":"make_file","sha":"d36cdd1941427cd30fbc2d392755aa99717ddf94","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars3.githubusercontent.com/u/342045?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"seo-bundle","full_name":"symfony-cmf/seo-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars3.githubusercontent.com/u/342045?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/seo-bundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/seo-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/deployments","created_at":"2014-01-30T09:17:14Z","updated_at":"2017-06-21T14:59:38Z","pushed_at":"2017-10-06T07:01:02Z","git_url":"git://github.com/symfony-cmf/seo-bundle.git","ssh_url":"git@github.com:symfony-cmf/seo-bundle.git","clone_url":"https://github.com/symfony-cmf/seo-bundle.git","svn_url":"https://github.com/symfony-cmf/seo-bundle","homepage":"","size":1004,"stargazers_count":29,"watchers_count":29,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":22,"forks":23,"open_issues":22,"watchers":29,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"502066115708196d5221abd5abc471563f277350","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars3.githubusercontent.com/u/342045?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"seo-bundle","full_name":"symfony-cmf/seo-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars3.githubusercontent.com/u/342045?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/seo-bundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/seo-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/seo-bundle/deployments","created_at":"2014-01-30T09:17:14Z","updated_at":"2017-06-21T14:59:38Z","pushed_at":"2017-10-06T07:01:02Z","git_url":"git://github.com/symfony-cmf/seo-bundle.git","ssh_url":"git@github.com:symfony-cmf/seo-bundle.git","clone_url":"https://github.com/symfony-cmf/seo-bundle.git","svn_url":"https://github.com/symfony-cmf/seo-bundle","homepage":"","size":1004,"stargazers_count":29,"watchers_count":29,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":22,"forks":23,"open_issues":22,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336"},"html":{"href":"https://github.com/symfony-cmf/seo-bundle/pull/336"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/336"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/seo-bundle/statuses/d36cdd1941427cd30fbc2d392755aa99717ddf94"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ElectricMaxxx"}}