{"action":"closed","number":7290,"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/7290","id":125765034,"html_url":"https://github.com/nvaccess/nvda/pull/7290","diff_url":"https://github.com/nvaccess/nvda/pull/7290.diff","patch_url":"https://github.com/nvaccess/nvda/pull/7290.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/7290","number":7290,"state":"closed","locked":false,"title":"Include application, dialog elements and audio and video tags for embedded object navigation in browse mode","user":{"login":"leonardder","id":3049216,"avatar_url":"https://avatars1.githubusercontent.com/u/3049216?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardder","html_url":"https://github.com/leonardder","followers_url":"https://api.github.com/users/leonardder/followers","following_url":"https://api.github.com/users/leonardder/following{/other_user}","gists_url":"https://api.github.com/users/leonardder/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardder/subscriptions","organizations_url":"https://api.github.com/users/leonardder/orgs","repos_url":"https://api.github.com/users/leonardder/repos","events_url":"https://api.github.com/users/leonardder/events{/privacy}","received_events_url":"https://api.github.com/users/leonardder/received_events","type":"User","site_admin":false},"body":"### Link to issue number:\r\nfixes #7239\r\n\r\n### Summary of the issue:\r\nEmbedded objects based on the html object tag are getting more rare these days, while we see increasing occurrence of applications, dialogs and audio and video tags inside web pages.\r\n\r\n### Description of how this pull request fixes the issue:\r\nThis adds applications and dialogs as well as audio/video tags for Internet Explorer, Firefox and Chrome. For Edge, I was unable to cover audio/video tags (see below)\r\n\r\n### Testing performed:\r\nI tried navigating http://www.mediaelementjs.com/ with o using all the browsers above. I also created a test html document with alertdialog, dialog and application roles, which also navigated fine.\r\n\r\n### Known issues with pull request:\r\nIn Edge, audio and video tags are regarded to as embedded object. Technically, they have the group UIA control type. In NVDAObjects.uia.edge.EdgeTextInfo._getControlFieldForObject, groupings are made to report as embedded object in certain situations, but I have not yet found a reliable way to throw the required information to do this reliably in a UIA Multi Property Condition.\r\n\r\n### Change log entry:\r\n* Changes\r\n    + In browse mode, the quick navigation command for embedded objects (o and shift+o) now includes audio and video elements as well as elements with the aria roles application and dialog (#7239","created_at":"2017-06-15T08:13:20Z","updated_at":"2017-09-05T00:26:10Z","closed_at":"2017-09-05T00:26:10Z","merged_at":"2017-09-05T00:26:10Z","merge_commit_sha":"b55db1e9b56857064a6829f35bd3195fbd7e07d5","assignee":{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars0.githubusercontent.com/u/14154141?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars0.githubusercontent.com/u/14154141?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/7290/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/7290/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/7290/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/37add828db425a9ce45f3dc24c88417ccffcd88f","head":{"label":"BabbageCom:i7239","ref":"i7239","sha":"37add828db425a9ce45f3dc24c88417ccffcd88f","user":{"login":"BabbageCom","id":20060371,"avatar_url":"https://avatars0.githubusercontent.com/u/20060371?v=4","gravatar_id":"","url":"https://api.github.com/users/BabbageCom","html_url":"https://github.com/BabbageCom","followers_url":"https://api.github.com/users/BabbageCom/followers","following_url":"https://api.github.com/users/BabbageCom/following{/other_user}","gists_url":"https://api.github.com/users/BabbageCom/gists{/gist_id}","starred_url":"https://api.github.com/users/BabbageCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabbageCom/subscriptions","organizations_url":"https://api.github.com/users/BabbageCom/orgs","repos_url":"https://api.github.com/users/BabbageCom/repos","events_url":"https://api.github.com/users/BabbageCom/events{/privacy}","received_events_url":"https://api.github.com/users/BabbageCom/received_events","type":"Organization","site_admin":false},"repo":{"id":61607768,"name":"nvda","full_name":"BabbageCom/nvda","owner":{"login":"BabbageCom","id":20060371,"avatar_url":"https://avatars0.githubusercontent.com/u/20060371?v=4","gravatar_id":"","url":"https://api.github.com/users/BabbageCom","html_url":"https://github.com/BabbageCom","followers_url":"https://api.github.com/users/BabbageCom/followers","following_url":"https://api.github.com/users/BabbageCom/following{/other_user}","gists_url":"https://api.github.com/users/BabbageCom/gists{/gist_id}","starred_url":"https://api.github.com/users/BabbageCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabbageCom/subscriptions","organizations_url":"https://api.github.com/users/BabbageCom/orgs","repos_url":"https://api.github.com/users/BabbageCom/repos","events_url":"https://api.github.com/users/BabbageCom/events{/privacy}","received_events_url":"https://api.github.com/users/BabbageCom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BabbageCom/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":true,"url":"https://api.github.com/repos/BabbageCom/nvda","forks_url":"https://api.github.com/repos/BabbageCom/nvda/forks","keys_url":"https://api.github.com/repos/BabbageCom/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabbageCom/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabbageCom/nvda/teams","hooks_url":"https://api.github.com/repos/BabbageCom/nvda/hooks","issue_events_url":"https://api.github.com/repos/BabbageCom/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/BabbageCom/nvda/events","assignees_url":"https://api.github.com/repos/BabbageCom/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/BabbageCom/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/BabbageCom/nvda/tags","blobs_url":"https://api.github.com/repos/BabbageCom/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabbageCom/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabbageCom/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabbageCom/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabbageCom/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/BabbageCom/nvda/languages","stargazers_url":"https://api.github.com/repos/BabbageCom/nvda/stargazers","contributors_url":"https://api.github.com/repos/BabbageCom/nvda/contributors","subscribers_url":"https://api.github.com/repos/BabbageCom/nvda/subscribers","subscription_url":"https://api.github.com/repos/BabbageCom/nvda/subscription","commits_url":"https://api.github.com/repos/BabbageCom/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabbageCom/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabbageCom/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabbageCom/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabbageCom/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/BabbageCom/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabbageCom/nvda/merges","archive_url":"https://api.github.com/repos/BabbageCom/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabbageCom/nvda/downloads","issues_url":"https://api.github.com/repos/BabbageCom/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/BabbageCom/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/BabbageCom/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/BabbageCom/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabbageCom/nvda/labels{/name}","releases_url":"https://api.github.com/repos/BabbageCom/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/BabbageCom/nvda/deployments","created_at":"2016-06-21T06:24:23Z","updated_at":"2016-06-21T06:24:33Z","pushed_at":"2017-09-04T12:52:07Z","git_url":"git://github.com/BabbageCom/nvda.git","ssh_url":"git@github.com:BabbageCom/nvda.git","clone_url":"https://github.com/BabbageCom/nvda.git","svn_url":"https://github.com/BabbageCom/nvda","homepage":null,"size":116587,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"17dfc68eb3394e2997afec19568943cb6fc04573","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2017-09-02T14:47:52Z","pushed_at":"2017-09-05T00:26:10Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":117243,"stargazers_count":345,"watchers_count":345,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":2027,"forks":152,"open_issues":2027,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7290"},"html":{"href":"https://github.com/nvaccess/nvda/pull/7290"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/7290"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/7290/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7290/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/7290/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/37add828db425a9ce45f3dc24c88417ccffcd88f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars0.githubusercontent.com/u/14154141?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":18,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"michaelDCurran"}}