{"push_id":1878584652,"size":103,"distinct_size":45,"ref":"refs/heads/whitelist","head":"27d1228118463de74bc04b63f75abaaba362db84","before":"cf69c4816cd6ab9a2d78d6944c1c0d23ae8b6144","commits":[{"sha":"0d4546c9655f871f1cecd3fb8ce7dc9c6598cc24","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"server: Return error on address lookup fails.\n\nThis corrects an issue introduced by commit\ne8f63bc29550705268b533032ccc2ea24f8c86ba where a failure to lookup a\nhostname could lead to a panic in certain circumstances.  An error is\nnow returned in that case as expected.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/0d4546c9655f871f1cecd3fb8ce7dc9c6598cc24"},{"sha":"7cc630b3358b7dcd19d8e1d2d9f57e4959ee7c0d","author":{"name":"Steven Roose","email":"b97977a9a9f0498cce708bd3bbb74cecebf6cbb7@gmail.com"},"message":"docs: Change error in heading","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/7cc630b3358b7dcd19d8e1d2d9f57e4959ee7c0d"},{"sha":"d9a674e1b7bc09d0830d6986c71cf5f535d753c3","author":{"name":"David Hill","email":"a58b4ea2976fe33680463d1f4994442b22754bb1@mindcry.org"},"message":"btcjson: add ErrRPCClientNodeNotAdded","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/d9a674e1b7bc09d0830d6986c71cf5f535d753c3"},{"sha":"807d344fe97072efdf38ac3df053e07f26187a4f","author":{"name":"David Hill","email":"a58b4ea2976fe33680463d1f4994442b22754bb1@mindcry.org"},"message":"Unassign some TODO's","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/807d344fe97072efdf38ac3df053e07f26187a4f"},{"sha":"187355448a21cb3c644091a716892888c54845c7","author":{"name":"David Hill","email":"a58b4ea2976fe33680463d1f4994442b22754bb1@mindcry.org"},"message":"wire: reduce allocs in BlockHash()","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/187355448a21cb3c644091a716892888c54845c7"},{"sha":"b134beb3b7809de6370a93cc5f6a684d6942e2e8","author":{"name":"David Hill","email":"a58b4ea2976fe33680463d1f4994442b22754bb1@mindcry.org"},"message":"txscript: reduce allocs in calcSignatureHash","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/b134beb3b7809de6370a93cc5f6a684d6942e2e8"},{"sha":"7f237aa5e5698c8d9516305881315306a5e3d4ac","author":{"name":"Javed Khan","email":"65fad3bd693d61d64f11abb6c8275007618883bd@gmail.com"},"message":"peer: disconnected peer - return non-nil LocalAddr","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/7f237aa5e5698c8d9516305881315306a5e3d4ac"},{"sha":"e1b2ceca8071dc391a471e9f69154fe1e8c17032","author":{"name":"dskloet","email":"547cabeb8b0783543bd235e1ac6aa87d971eca7a@gmail.com"},"message":"addrmgr: Remove unused param from GetAddress()\n\naddrmgr.GetAddress() had a parameter `class string` originally intended\r\nto support looking up addresses according to some type of filter such as\r\nIPv4, IPv6, and only those which support specific wire.ServiceFlags\r\n(full nodes, nodes that support bloom filters, nodes that support\r\nsegwit, etc). But currently the parameter is unused and also has an\r\ninappropriate type `string`.\r\n\r\nIf it would ever be used, it's easy to add back and should then get an\r\nappropriate type such as something that allows bitflags to be set so\r\nthat the caller could request combinations such as peers that support\r\nIPv6, are full nodes, and support bloom filters.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/e1b2ceca8071dc391a471e9f69154fe1e8c17032"},{"sha":"34b9721494b88f917b4e85e9262a1eb3ec3a7b85","author":{"name":"David de Kloet","email":"547cabeb8b0783543bd235e1ac6aa87d971eca7a@google.com"},"message":"docs: Clarify model commit message summary\n\nAdd a paragraph about prefixing commit message summaries with the\npackage/subsystem that they're changing to\ncode_contribution_guidelines.md.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/34b9721494b88f917b4e85e9262a1eb3ec3a7b85"},{"sha":"afec1bd1245a4a19e6dfe1306974b733e7cbb9b8","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"build: Give linters longer and cleanup goclean.sh.\n\nThis modifies the goclean.sh script to expand the deadline for the\nlinters to run to 4 minutes and ensures the comments match reality.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/afec1bd1245a4a19e6dfe1306974b733e7cbb9b8"},{"sha":"95e6de00b896298de77b8743cde9d7aac8c01bf5","author":{"name":"Steven Roose","email":"b97977a9a9f0498cce708bd3bbb74cecebf6cbb7@gmail.com"},"message":"btcd: fix error in mempool response inv counting","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/95e6de00b896298de77b8743cde9d7aac8c01bf5"},{"sha":"c440584efc6e18ef3ba4a224977b13a4ac1b8f8e","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"Implement infrastructure for BIP0009.\n\nThis commit adds all of the infrastructure needed to support BIP0009\nsoft forks.\n\nThe following is an overview of the changes:\n\n- Add new configuration options to the chaincfg package which allows the\n  rule deployments to be defined per chain\n- Implement code to calculate the threshold state as required by BIP0009\n  - Use threshold state caches that are stored to the database in order\n    to accelerate startup time\n  - Remove caches that are invalid due to definition changes in the\n    params including additions, deletions, and changes to existing\n    entries\n- Detect and warn when a new unknown rule is about to activate or has\n  been activated in the block connection code\n- Detect and warn when 50% of the last 100 blocks have unexpected\n  versions.\n- Remove the latest block version from wire since it no longer applies\n- Add a version parameter to the wire.NewBlockHeader function since the\n  default is no longer available\n- Update the miner block template generation code to use the calculated\n  block version based on the currently defined rule deployments and\n  their threshold states as of the previous block\n- Add tests for new error type\n- Add tests for threshold state cache","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/c440584efc6e18ef3ba4a224977b13a4ac1b8f8e"},{"sha":"25520b40ad29c351a5aa4a37e3ab6b1c72b67408","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"rpctest: Update for removal of wire.BlockVersion\n\nThis adds constant for the block version to the rpctest package since it\nis no longer available via the wire package due to the new BIP0009 code.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/25520b40ad29c351a5aa4a37e3ab6b1c72b67408"},{"sha":"bfbaff9fae51cbb99933cabd30c05ae4dae1c29f","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"integration: Add BIP9 mining tests.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/bfbaff9fae51cbb99933cabd30c05ae4dae1c29f"},{"sha":"9cdc1b8afdda8b6ea7c83575f35cc0b344908386","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"blockchain: Remove isMajorityVersion code.\n\nNow that all softforking is done via BIP0009 versionbits, replace the\nold isMajorityVersion deployment mechanism with hard coded historical\nblock heights at which they became active.\n\nSince the activation heights vary per network, this adds new parameters\nto the chaincfg.Params struct for them and sets the correct heights at\nwhich each softfork became active on each chain.\n\nIt should be noted that this is a technically hard fork since the\nbehavior of alternate chain history is different with these hard-coded\nactivation heights as opposed to the old isMajorityVersion code.  In\nparticular, an alternate chain history could activate one of the soft\nforks earlier than these hard-coded heights which means the old code\nwould reject blocks which violate the new soft fork rules whereas this\nnew code would not.\n\nHowever, all of the soft forks this refers to were activated so far in\nthe chain history there is there is no way a reorg that long could\nhappen and checkpoints reject alternate chains before the most recent\ncheckpoint anyways.  Furthermore, the same change was made in Bitcoin\nCore so this needs to be changed to be consistent anyways.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/9cdc1b8afdda8b6ea7c83575f35cc0b344908386"},{"sha":"2e93ea6ca64157b9d8f0dc2f8d67e0382b62b228","author":{"name":"David Hill","email":"a58b4ea2976fe33680463d1f4994442b22754bb1@mindcry.org"},"message":"btcjson: Add versionHex to getblock[header] results\nrpcserver:  Set versionHex in responses.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/2e93ea6ca64157b9d8f0dc2f8d67e0382b62b228"},{"sha":"318c4760c02d494542d0b7ea9b636351a99fe458","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"blockchain: Only enforce BIP0030 prior to BIP0034.\n\nThis modifies the code to only enforce the fairly expensive BIP0030\n(duplicate transcactions) checks when the chain has not yet reached the\nBIP0034 activation height (and is not one of the 2 special historical\nblocks that break the rule and prompted BIP0034 to being with) since\nthat BIP made it impossible to create duplicate coinbases and thus\nremoved the possibility of creating transactions that overwrite older\nones.\n\nThis is a rather large optimization because the check is expensive due\nto involving a ton of cache misses in the utxoset.  For example, the\nfollowing are times it took to perform the BIP0030 check on blocks\n425490 - 425502 and a system with a relatively old Hitachi spinner HDD:\n\nblock 425490: 674.5857ms\nblock 425491: 726.5923ms\nblock 425492: 827.6051ms\nblock 425493: 680.0863ms\nblock 425494: 722.0917ms\nblock 425495: 700.0889ms\nblock 425496: 647.5823ms\nblock 425497: 445.0565ms\nblock 425498: 602.5765ms\nblock 425499: 375.0476ms\nblock 425500: 771.0979ms\nblock 425501: 461.5586ms\nblock 425502: 603.0766ms\n\nAs can be seen from these numbers, this reduces the block validation\ntime by an average of just over half a second for the given\nrepresentative data set and hardware.\n\nSigned-off-by: Dave Collins <davec@conformal.com>","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/318c4760c02d494542d0b7ea9b636351a99fe458"},{"sha":"bc576b13b4d3abd1df98f35fc7d30e9500048b7b","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"txscript: Only do CSV txver check if enabled.\n\nThe CSV consensus rules dictate that the opcode fails when the\ntransaction version is not at least version 2, however that only applies\nif the disable flag is not set in the sequence.\n\nThis is not an issue at the current time because we do not yet enforce\nCSV at a consensus level, however, I noticed this discrepancy when doing\na thorough audit of the CSV paths due to the ongoing work to add full\nconsensus-enforced CSV support.\n\nAs a result, this must be merged prior to enabling consensus enforcement\nfor CSV or it would open up the potential for a hard fork.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/bc576b13b4d3abd1df98f35fc7d30e9500048b7b"},{"sha":"712399c0db4441b2e4d159461a92fc90e8ad5fa6","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"blockchain: Correct startup threshold state warns.\n\nThe thresholdState and deploymentState functions expect the block node\nfor the block prior to which the threshold state is calculated, however\nthe startup code which checked the threshold states was using the\ncurrent best node instead of its parent.\n\nWhile here, also update the comments and rename a couple of variables to\nhelp make this fact more clear.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/712399c0db4441b2e4d159461a92fc90e8ad5fa6"},{"sha":"c5751b75a9dadf4e5bc780fa812eb4ee9d161936","author":{"name":"David de Kloet","email":"547cabeb8b0783543bd235e1ac6aa87d971eca7a@google.com"},"message":"wire: Treat NetAddress more like immutable\n\nReplace assignments to individual fields of wire.NetAddress with\ncreating the entire object at once, as one would do if the type was\nimmutable.\n\nIn some places this replaces the creation of a NetAddress with a\nhigh-precision timestamp with a call to a 'constructor' that converts\nthe timestamp to single second precision. For consistency, the tests\nhave also been changed to use single-precision timestamps.\n\nLastly, the number of allocations in readNetAddress have been reduced by\nreading the services directly into the NetAddress instead of first into\na temporary variable.","distinct":false,"url":"https://api.github.com/repos/dajohi/btcd/commits/c5751b75a9dadf4e5bc780fa812eb4ee9d161936"}]}
{"actor":{"display_login":"dajohi"}}