{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3","id":141149945,"html_url":"https://github.com/MITLibraries/wp-pending-posts/pull/3","diff_url":"https://github.com/MITLibraries/wp-pending-posts/pull/3.diff","patch_url":"https://github.com/MITLibraries/wp-pending-posts/pull/3.patch","issue_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/3","number":3,"state":"closed","locked":false,"title":"Update tooling","user":{"login":"matt-bernhardt","id":1403248,"avatar_url":"https://avatars0.githubusercontent.com/u/1403248?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-bernhardt","html_url":"https://github.com/matt-bernhardt","followers_url":"https://api.github.com/users/matt-bernhardt/followers","following_url":"https://api.github.com/users/matt-bernhardt/following{/other_user}","gists_url":"https://api.github.com/users/matt-bernhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-bernhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-bernhardt/subscriptions","organizations_url":"https://api.github.com/users/matt-bernhardt/orgs","repos_url":"https://api.github.com/users/matt-bernhardt/repos","events_url":"https://api.github.com/users/matt-bernhardt/events{/privacy}","received_events_url":"https://api.github.com/users/matt-bernhardt/received_events","type":"User","site_admin":false},"body":"## Status\r\n_Use labels (`review needed`, `in progress`, or `paused`) to declare status_\r\n\r\n#### What does this PR do?\r\nThis work does two things:\r\n- [x] Applies the usual tooling updates that we've been doing for all other WordPress code the last week or so\r\n- [x] Refactors the plugin to make use of current best practices, and to make its codebase similar to related plugins like MITLibraries/wp-home-page-news.\r\n\r\n#### Helpful background context (if appropriate)\r\nIf the structure of this new code needs context, look at the wp-home-page-news plugin, and the reference dashboard widget example at https://codex.wordpress.org/Example_Dashboard_Widget\r\n\r\n#### How can a reviewer manually see the effects of these changes?\r\nThe tooling updates will only be visible on GitHub, in that the linters should all pass. In the case of this particular branch, we don't even add anything to the whitelist - the refactor addresses all code violations.\r\n\r\nThe refactor itself slightly changes the widget interface, in that field labels change. Also, we re-introduce the lost feature of highlighting urgent posts in red.\r\n\r\n#### What are the relevant tickets?\r\n- https://mitlibraries.atlassian.net/browse/NTI-158\r\n\r\n#### Screenshots (if appropriate)\r\nBefore:\r\n![image](https://user-images.githubusercontent.com/1403248/30500475-763594d8-9a2c-11e7-9926-aa1f3d03d983.png)\r\n\r\nAfter:\r\n![image](https://user-images.githubusercontent.com/1403248/30500480-7aca6168-9a2c-11e7-9ab8-24914b7ce985.png)\r\n\r\n#### Todo:\r\n- [x] Stakeholder approval\r\n\r\n#### Requires new or updated plugins, themes, or libraries?\r\nNO\r\n\r\n#### Requires change to deploy process?\r\nNO\r\n","created_at":"2017-09-14T18:49:11Z","updated_at":"2017-10-03T15:05:01Z","closed_at":"2017-10-03T15:05:01Z","merged_at":"2017-10-03T15:05:01Z","merge_commit_sha":"316f13abdc847a68f8fbc6c0a9754d944707e3a8","assignee":{"login":"matt-bernhardt","id":1403248,"avatar_url":"https://avatars0.githubusercontent.com/u/1403248?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-bernhardt","html_url":"https://github.com/matt-bernhardt","followers_url":"https://api.github.com/users/matt-bernhardt/followers","following_url":"https://api.github.com/users/matt-bernhardt/following{/other_user}","gists_url":"https://api.github.com/users/matt-bernhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-bernhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-bernhardt/subscriptions","organizations_url":"https://api.github.com/users/matt-bernhardt/orgs","repos_url":"https://api.github.com/users/matt-bernhardt/repos","events_url":"https://api.github.com/users/matt-bernhardt/events{/privacy}","received_events_url":"https://api.github.com/users/matt-bernhardt/received_events","type":"User","site_admin":false},"assignees":[{"login":"matt-bernhardt","id":1403248,"avatar_url":"https://avatars0.githubusercontent.com/u/1403248?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-bernhardt","html_url":"https://github.com/matt-bernhardt","followers_url":"https://api.github.com/users/matt-bernhardt/followers","following_url":"https://api.github.com/users/matt-bernhardt/following{/other_user}","gists_url":"https://api.github.com/users/matt-bernhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-bernhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-bernhardt/subscriptions","organizations_url":"https://api.github.com/users/matt-bernhardt/orgs","repos_url":"https://api.github.com/users/matt-bernhardt/repos","events_url":"https://api.github.com/users/matt-bernhardt/events{/privacy}","received_events_url":"https://api.github.com/users/matt-bernhardt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3/commits","review_comments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3/comments","review_comment_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/3/comments","statuses_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/statuses/7e65489c1ed0470bdeac635259380cb52e96a2e4","head":{"label":"MITLibraries:update-tooling","ref":"update-tooling","sha":"7e65489c1ed0470bdeac635259380cb52e96a2e4","user":{"login":"MITLibraries","id":2176469,"avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":40367974,"name":"wp-pending-posts","full_name":"MITLibraries/wp-pending-posts","owner":{"login":"MITLibraries","id":2176469,"avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MITLibraries/wp-pending-posts","description":"A WordPress plugin that displays a list of pending posts, in a dashboard widget, for admin-level users.","fork":false,"url":"https://api.github.com/repos/MITLibraries/wp-pending-posts","forks_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/forks","keys_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/teams","hooks_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/hooks","issue_events_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/events{/number}","events_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/events","assignees_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/assignees{/user}","branches_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/branches{/branch}","tags_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/tags","blobs_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/refs{/sha}","trees_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/statuses/{sha}","languages_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/languages","stargazers_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/stargazers","contributors_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/contributors","subscribers_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/subscribers","subscription_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/subscription","commits_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/commits{/sha}","git_commits_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/commits{/sha}","comments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/comments{/number}","issue_comment_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/comments{/number}","contents_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/contents/{+path}","compare_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/merges","archive_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/downloads","issues_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues{/number}","pulls_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls{/number}","milestones_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/milestones{/number}","notifications_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/labels{/name}","releases_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/releases{/id}","deployments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/deployments","created_at":"2015-08-07T15:43:24Z","updated_at":"2017-09-18T13:56:43Z","pushed_at":"2017-10-03T15:05:01Z","git_url":"git://github.com/MITLibraries/wp-pending-posts.git","ssh_url":"git@github.com:MITLibraries/wp-pending-posts.git","clone_url":"https://github.com/MITLibraries/wp-pending-posts.git","svn_url":"https://github.com/MITLibraries/wp-pending-posts","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MITLibraries:master","ref":"master","sha":"f9cbffd7df4b5c22a934e0a0e93b920c33efed4e","user":{"login":"MITLibraries","id":2176469,"avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":40367974,"name":"wp-pending-posts","full_name":"MITLibraries/wp-pending-posts","owner":{"login":"MITLibraries","id":2176469,"avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MITLibraries/wp-pending-posts","description":"A WordPress plugin that displays a list of pending posts, in a dashboard widget, for admin-level users.","fork":false,"url":"https://api.github.com/repos/MITLibraries/wp-pending-posts","forks_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/forks","keys_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/teams","hooks_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/hooks","issue_events_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/events{/number}","events_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/events","assignees_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/assignees{/user}","branches_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/branches{/branch}","tags_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/tags","blobs_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/refs{/sha}","trees_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/statuses/{sha}","languages_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/languages","stargazers_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/stargazers","contributors_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/contributors","subscribers_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/subscribers","subscription_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/subscription","commits_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/commits{/sha}","git_commits_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/git/commits{/sha}","comments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/comments{/number}","issue_comment_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/comments{/number}","contents_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/contents/{+path}","compare_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/merges","archive_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/downloads","issues_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues{/number}","pulls_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls{/number}","milestones_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/milestones{/number}","notifications_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/labels{/name}","releases_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/releases{/id}","deployments_url":"https://api.github.com/repos/MITLibraries/wp-pending-posts/deployments","created_at":"2015-08-07T15:43:24Z","updated_at":"2017-09-18T13:56:43Z","pushed_at":"2017-10-03T15:05:01Z","git_url":"git://github.com/MITLibraries/wp-pending-posts.git","ssh_url":"git@github.com:MITLibraries/wp-pending-posts.git","clone_url":"https://github.com/MITLibraries/wp-pending-posts.git","svn_url":"https://github.com/MITLibraries/wp-pending-posts","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3"},"html":{"href":"https://github.com/MITLibraries/wp-pending-posts/pull/3"},"issue":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/3"},"comments":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/MITLibraries/wp-pending-posts/statuses/7e65489c1ed0470bdeac635259380cb52e96a2e4"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"matt-bernhardt","id":1403248,"avatar_url":"https://avatars0.githubusercontent.com/u/1403248?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-bernhardt","html_url":"https://github.com/matt-bernhardt","followers_url":"https://api.github.com/users/matt-bernhardt/followers","following_url":"https://api.github.com/users/matt-bernhardt/following{/other_user}","gists_url":"https://api.github.com/users/matt-bernhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-bernhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-bernhardt/subscriptions","organizations_url":"https://api.github.com/users/matt-bernhardt/orgs","repos_url":"https://api.github.com/users/matt-bernhardt/repos","events_url":"https://api.github.com/users/matt-bernhardt/events{/privacy}","received_events_url":"https://api.github.com/users/matt-bernhardt/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":375,"deletions":95,"changed_files":10}}
{"actor":{"display_login":"matt-bernhardt"}}