{"action":"closed","issue":{"url":"https://api.github.com/repos/ASOS/SimpleEventStore/issues/20","repository_url":"https://api.github.com/repos/ASOS/SimpleEventStore","labels_url":"https://api.github.com/repos/ASOS/SimpleEventStore/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/ASOS/SimpleEventStore/issues/20/comments","events_url":"https://api.github.com/repos/ASOS/SimpleEventStore/issues/20/events","html_url":"https://github.com/ASOS/SimpleEventStore/issues/20","id":259419484,"number":20,"title":"Nuget package dependencies incorrectly versioned producing build warnings in consumers","user":{"login":"DaveAurionix","id":7437530,"avatar_url":"https://avatars3.githubusercontent.com/u/7437530?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveAurionix","html_url":"https://github.com/DaveAurionix","followers_url":"https://api.github.com/users/DaveAurionix/followers","following_url":"https://api.github.com/users/DaveAurionix/following{/other_user}","gists_url":"https://api.github.com/users/DaveAurionix/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveAurionix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveAurionix/subscriptions","organizations_url":"https://api.github.com/users/DaveAurionix/orgs","repos_url":"https://api.github.com/users/DaveAurionix/repos","events_url":"https://api.github.com/users/DaveAurionix/events{/privacy}","received_events_url":"https://api.github.com/users/DaveAurionix/received_events","type":"User","site_admin":false},"labels":[{"id":525463538,"url":"https://api.github.com/repos/ASOS/SimpleEventStore/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-21T08:43:01Z","updated_at":"2017-09-21T15:34:18Z","closed_at":"2017-09-21T15:34:18Z","author_association":"NONE","body":"Apologies for the issue with no PR - mostly logging till have time to address it...\r\n\r\nThe Asos.SimpleEventStore.DocumentDb nuget package published by the build process contains a hard reference to a Asos.SimpleEventStore package with version 1.0.0 despite the actual build taking place against a later (non-backwards-compatible) package version (e.g. 2.X.X).  This produces the following example warning in consumers using VS2017.3.4 or later:\r\n\r\n\"Asos.SimpleEventStore.AzureDocumentDb 2.0.31 depends on Asos.SimpleEventStore (>=1.0.0) but Asos.SimpleEventStore 1.0.0 was not found.  An approximate best match of Asos.SimpleEventStore 2.0.30 was resolved\".\r\n\r\nThis might stop \"warnings as errors\" being enabled for builds.\r\n\r\nA temporary hack might be to simple change the Version property in the csproj files to match the version of any currently published package, but although that will remove the warning, I worry that this will simply mask the issue and might result in consumers who use \"minimum matching package\" dependency behaviour rarely picking up new dependent package versions (i.e. those that reference SES.DocDb will not update to latest versions of SES itself).\r\n\r\nA better approach might be to use \"$\" build variables in the csproj files Version elements in order to create correctly-versioned references when msbuild is spidering project references to generate the package manifest."}}
{"actor":{"display_login":"asosMikeGore"}}