{"action":"created","issue":{"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/141","repository_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts","labels_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/141/comments","events_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/141/events","html_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/141","id":267096505,"number":141,"title":"New Feature: ChipID added to TTree, readBackCheck now checks ChipID & vt1bump ","user":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"labels":[{"id":490990136,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Priority:%20Medium","name":"Priority: Medium","color":"f7d358","default":false},{"id":490990132,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Status:%20Review%20Needed","name":"Status: Review Needed","color":"ff8000","default":false},{"id":374344294,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-10-20T08:13:38Z","updated_at":"2017-10-20T12:34:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/141","html_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/141","diff_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/141.diff","patch_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/141.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nAddresses: https://github.com/cms-gem-daq-project/vfatqc-python-scripts/issues/138\r\n\r\nRequires: https://github.com/cms-gem-daq-project/gem-plotting-tools/pull/51\r\n\r\nAdditionally when `confChamber.py` calls `readBackCheck(...)` it will now check the ChipID of the VFATs being configured against what is supplied in the input config files.\r\n\r\nNote that as a result new configuration files (e.g. `vfatConfig.txt` and `chConfig.txt`) would need to be generated which have a `ChipID` column (shown in integer representation).\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [X] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue(s) here. -->\r\nAs we move forward eventually we will be configuring with the information that will be stored in the database.  We should be able to cross-check that the info stored for a given VFAT in the database matches the VFAT that is being configured on the hardware.  The best way to do this is to compare the supplied `vfatID` with the `ChipID1` register on the VFAT since they should be identical.\r\n\r\nAdditionally in our calibration data there is no way to know which VFATs were used for a given run.  Now all produced TTree's by our calibration scans will include the `vfatID` branch which stores the value of the `ChipID1` register. \r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nTook new measurements, analyzed them, and configured from the produced config files as shown:\r\n\r\nhttp://cmsonline.cern.ch/cms-elog/1016357\r\nhttp://cmsonline.cern.ch/cms-elog/1016594\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n\r\n<!--- Template thanks to https://www.talater.com/open-source-templates/#/page/99 -->\r\n"},"comment":{"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/comments/338193775","html_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/141#issuecomment-338193775","issue_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/141","id":338193775,"user":{"login":"jsturdy","id":5197820,"avatar_url":"https://avatars1.githubusercontent.com/u/5197820?v=4","gravatar_id":"","url":"https://api.github.com/users/jsturdy","html_url":"https://github.com/jsturdy","followers_url":"https://api.github.com/users/jsturdy/followers","following_url":"https://api.github.com/users/jsturdy/following{/other_user}","gists_url":"https://api.github.com/users/jsturdy/gists{/gist_id}","starred_url":"https://api.github.com/users/jsturdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsturdy/subscriptions","organizations_url":"https://api.github.com/users/jsturdy/orgs","repos_url":"https://api.github.com/users/jsturdy/repos","events_url":"https://api.github.com/users/jsturdy/events{/privacy}","received_events_url":"https://api.github.com/users/jsturdy/received_events","type":"User","site_admin":false},"created_at":"2017-10-20T12:34:02Z","updated_at":"2017-10-20T12:34:02Z","author_association":"COLLABORATOR","body":"Any reason to not use the full chipID in both writing and checking?\r\nDon't know if we are certain of uniqueness of only one set of the 8 bits in any given chamber"}}
{"actor":{"display_login":"jsturdy"}}