{"action":"created","issue":{"url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/252","repository_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb","labels_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/252/comments","events_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/252/events","html_url":"https://github.com/NeurodataWithoutBorders/pynwb/pull/252","id":273295227,"number":252,"title":"Update requirements-doc.txt","user":{"login":"nicain","id":113055,"avatar_url":"https://avatars2.githubusercontent.com/u/113055?v=4","gravatar_id":"","url":"https://api.github.com/users/nicain","html_url":"https://github.com/nicain","followers_url":"https://api.github.com/users/nicain/followers","following_url":"https://api.github.com/users/nicain/following{/other_user}","gists_url":"https://api.github.com/users/nicain/gists{/gist_id}","starred_url":"https://api.github.com/users/nicain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicain/subscriptions","organizations_url":"https://api.github.com/users/nicain/orgs","repos_url":"https://api.github.com/users/nicain/repos","events_url":"https://api.github.com/users/nicain/events{/privacy}","received_events_url":"https://api.github.com/users/nicain/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-13T02:49:46Z","updated_at":"2017-11-13T14:44:17Z","closed_at":"2017-11-13T04:05:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/pulls/252","html_url":"https://github.com/NeurodataWithoutBorders/pynwb/pull/252","diff_url":"https://github.com/NeurodataWithoutBorders/pynwb/pull/252.diff","patch_url":"https://github.com/NeurodataWithoutBorders/pynwb/pull/252.patch"},"body":"## Motivation\r\n\r\nWhat was the reasoning behind this change? Please explain the changes briefly.\r\n\r\n@choldgraf mentions here that allensdk is a dependency for that notebook that I checked in.  @jcfr will adding this to the requirements file totally screw up how our dependencies run?  Please reject this PR it this is a bad idea...\r\nhttps://twitter.com/choldgraf/status/929846273825562627\r\n\r\n## Checklist\r\n\r\n- [x] Have you checked our [Contributing](https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/docs/CONTRIBUTING.rst) document?\r\n- [x] Have you ensured the PR description clearly describes problem and the solution?\r\n- [x] Is your contribution compliant with our coding style ? This can be checked running `flake8` from the source directory.\r\n- [x] Have you checked to ensure that there aren't other open [Pull Requests](https://github.com/NeurodataWithoutBorders/pynwb/pulls) for the same change?\r\n- [x] Have you included the relevant issue number using `#XXX` notation where `XXX` is the issue number ?\r\n"},"comment":{"url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/comments/343940012","html_url":"https://github.com/NeurodataWithoutBorders/pynwb/pull/252#issuecomment-343940012","issue_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/252","id":343940012,"user":{"login":"choldgraf","id":1839645,"avatar_url":"https://avatars1.githubusercontent.com/u/1839645?v=4","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T14:44:17Z","updated_at":"2017-11-13T14:44:17Z","author_association":"NONE","body":"FWIW, adding a dependency install in a notebook is not very good practice IMO. It blurs the line between the computational environment needed to run code, and the code itself. There's a reason these things are separated out into requirements files! \r\n\r\nE.g., what happens if a dependency changes? You'd need to go into each notebook and change the first cell. Also, if people run into errors when pip-installing allensdk (as I did), it'll be even more confusing if the output is in a cell at the top of a jupyter notebook. This is especially true if the SDK depends on non-standard things, like matplotlib < 2.0.\r\n\r\nJust my 2 cents!"}}
{"actor":{"display_login":"choldgraf"}}