{"action":"created","comment":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments/103778601","pull_request_review_id":24578347,"id":103778601,"diff_hunk":"@@ -117,6 +117,7 @@ class Meta:\n         'member.Address',\n         verbose_name=_('address'),\n         null=True,\n+        on_delete=models.CASCADE","path":"src/member/models.py","position":4,"original_position":4,"commit_id":"a91788f278300f7ea83df6bdc24b8d0fe5b352fa","original_commit_id":"a91788f278300f7ea83df6bdc24b8d0fe5b352fa","user":{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars2.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false},"body":"I think we might use models.SET_NULL. Deleting an address doesn't necessarily remove the member. How do you think?","created_at":"2017-03-01T20:15:27Z","updated_at":"2017-03-01T20:15:27Z","html_url":"https://github.com/savoirfairelinux/sous-chef/pull/678#discussion_r103778601","pull_request_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678","_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments/103778601"},"html":{"href":"https://github.com/savoirfairelinux/sous-chef/pull/678#discussion_r103778601"},"pull_request":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678"}}},"pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678","id":108208843,"html_url":"https://github.com/savoirfairelinux/sous-chef/pull/678","diff_url":"https://github.com/savoirfairelinux/sous-chef/pull/678.diff","patch_url":"https://github.com/savoirfairelinux/sous-chef/pull/678.patch","issue_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/678","number":678,"state":"open","locked":false,"title":"Fixed #636: Removed django warning for 2.0","user":{"login":"aaboffill","id":2370639,"avatar_url":"https://avatars2.githubusercontent.com/u/2370639?v=3","gravatar_id":"","url":"https://api.github.com/users/aaboffill","html_url":"https://github.com/aaboffill","followers_url":"https://api.github.com/users/aaboffill/followers","following_url":"https://api.github.com/users/aaboffill/following{/other_user}","gists_url":"https://api.github.com/users/aaboffill/gists{/gist_id}","starred_url":"https://api.github.com/users/aaboffill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaboffill/subscriptions","organizations_url":"https://api.github.com/users/aaboffill/orgs","repos_url":"https://api.github.com/users/aaboffill/repos","events_url":"https://api.github.com/users/aaboffill/events{/privacy}","received_events_url":"https://api.github.com/users/aaboffill/received_events","type":"User","site_admin":false},"body":"## Fixes # by aaboffill\r\n\r\n### Changes proposed in this pull request:\r\n\r\nRemoved all `RemovedInDjango20Warning` from sous-chef's code. \r\n* Replaced [`django.core.urlresolvers` by `django.urls`](https://docs.djangoproject.com/en/1.10/ref/urlresolvers/#module-django.urls).\r\n* Added [`app_name` to `urls.py`](https://github.com/django/django/blob/master/django/conf/urls/__init__.py#L17-L48)\r\n* Added  [`on_delete` argument to the `ForeignKey`](https://docs.djangoproject.com/en/1.10/ref/models/fields/#django.db.models.ForeignKey.on_delete)\r\n* Replaced [`MIDDLEWARE_CLASSES` by `MIDDLEWARE`](https://docs.djangoproject.com/en/1.10/topics/http/middleware/#middleware)\r\n\r\n### Status\r\n\r\n- [X] READY\r\n- [ ] HOLD\r\n- [ ] WIP (Work-In-Progress)\r\n\r\n### How to verify this change\r\n\r\n* During your own development, use env variable PYTHONWARNINGS=once to show them.\r\n\r\n### Additional notes\r\n\r\nWe have still the following warnings:\r\n* `RemovedInDjango20Warning`: '**site-packages/avatar/models.py:75**'. This is an external library, the latest version keep the warning, we need to wait.\r\n* `RemovedInDjango20Warning`: '**site-packages/formtools/wizard/views.py:5**'. This is an external library, the latest version keep the warning, we need to wait.\r\n* `RemovedInDjango20Warning`: **site-packages/rules/templatetags/rules.py:10**'. This is an external library, the latest version keep the warning, we need to wait.\r\n* `DeprecationWarning`: '**site-packages/rules/predicates.py:70**'. This warning is not related with `Django`.\r\n* `RemovedInLocalflavor20Warning`: '**site-packages/localflavor/generic/forms.py:144**'. This warning is not related with `Django`.\r\n* `PendingDeprecationWarning`: '**dist-packages/reportlab/__init__.py:8**'. This warning is not related with `Django`.\r\n","created_at":"2017-02-27T21:49:03Z","updated_at":"2017-03-01T20:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2da3761bbc0901978ffcadfc449e3e32eb41ac11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678/commits","review_comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678/comments","review_comment_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/678/comments","statuses_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/a91788f278300f7ea83df6bdc24b8d0fe5b352fa","head":{"label":"aaboffill:dev_636","ref":"dev_636","sha":"a91788f278300f7ea83df6bdc24b8d0fe5b352fa","user":{"login":"aaboffill","id":2370639,"avatar_url":"https://avatars2.githubusercontent.com/u/2370639?v=3","gravatar_id":"","url":"https://api.github.com/users/aaboffill","html_url":"https://github.com/aaboffill","followers_url":"https://api.github.com/users/aaboffill/followers","following_url":"https://api.github.com/users/aaboffill/following{/other_user}","gists_url":"https://api.github.com/users/aaboffill/gists{/gist_id}","starred_url":"https://api.github.com/users/aaboffill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaboffill/subscriptions","organizations_url":"https://api.github.com/users/aaboffill/orgs","repos_url":"https://api.github.com/users/aaboffill/repos","events_url":"https://api.github.com/users/aaboffill/events{/privacy}","received_events_url":"https://api.github.com/users/aaboffill/received_events","type":"User","site_admin":false},"repo":{"id":79138308,"name":"sous-chef","full_name":"aaboffill/sous-chef","owner":{"login":"aaboffill","id":2370639,"avatar_url":"https://avatars2.githubusercontent.com/u/2370639?v=3","gravatar_id":"","url":"https://api.github.com/users/aaboffill","html_url":"https://github.com/aaboffill","followers_url":"https://api.github.com/users/aaboffill/followers","following_url":"https://api.github.com/users/aaboffill/following{/other_user}","gists_url":"https://api.github.com/users/aaboffill/gists{/gist_id}","starred_url":"https://api.github.com/users/aaboffill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaboffill/subscriptions","organizations_url":"https://api.github.com/users/aaboffill/orgs","repos_url":"https://api.github.com/users/aaboffill/repos","events_url":"https://api.github.com/users/aaboffill/events{/privacy}","received_events_url":"https://api.github.com/users/aaboffill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaboffill/sous-chef","description":"Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.","fork":true,"url":"https://api.github.com/repos/aaboffill/sous-chef","forks_url":"https://api.github.com/repos/aaboffill/sous-chef/forks","keys_url":"https://api.github.com/repos/aaboffill/sous-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaboffill/sous-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaboffill/sous-chef/teams","hooks_url":"https://api.github.com/repos/aaboffill/sous-chef/hooks","issue_events_url":"https://api.github.com/repos/aaboffill/sous-chef/issues/events{/number}","events_url":"https://api.github.com/repos/aaboffill/sous-chef/events","assignees_url":"https://api.github.com/repos/aaboffill/sous-chef/assignees{/user}","branches_url":"https://api.github.com/repos/aaboffill/sous-chef/branches{/branch}","tags_url":"https://api.github.com/repos/aaboffill/sous-chef/tags","blobs_url":"https://api.github.com/repos/aaboffill/sous-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaboffill/sous-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaboffill/sous-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaboffill/sous-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaboffill/sous-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/aaboffill/sous-chef/languages","stargazers_url":"https://api.github.com/repos/aaboffill/sous-chef/stargazers","contributors_url":"https://api.github.com/repos/aaboffill/sous-chef/contributors","subscribers_url":"https://api.github.com/repos/aaboffill/sous-chef/subscribers","subscription_url":"https://api.github.com/repos/aaboffill/sous-chef/subscription","commits_url":"https://api.github.com/repos/aaboffill/sous-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaboffill/sous-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaboffill/sous-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaboffill/sous-chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaboffill/sous-chef/contents/{+path}","compare_url":"https://api.github.com/repos/aaboffill/sous-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaboffill/sous-chef/merges","archive_url":"https://api.github.com/repos/aaboffill/sous-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaboffill/sous-chef/downloads","issues_url":"https://api.github.com/repos/aaboffill/sous-chef/issues{/number}","pulls_url":"https://api.github.com/repos/aaboffill/sous-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/aaboffill/sous-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/aaboffill/sous-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaboffill/sous-chef/labels{/name}","releases_url":"https://api.github.com/repos/aaboffill/sous-chef/releases{/id}","deployments_url":"https://api.github.com/repos/aaboffill/sous-chef/deployments","created_at":"2017-01-16T16:44:07Z","updated_at":"2017-01-16T16:44:10Z","pushed_at":"2017-03-01T19:11:55Z","git_url":"git://github.com/aaboffill/sous-chef.git","ssh_url":"git@github.com:aaboffill/sous-chef.git","clone_url":"https://github.com/aaboffill/sous-chef.git","svn_url":"https://github.com/aaboffill/sous-chef","homepage":"","size":9056,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"savoirfairelinux:dev","ref":"dev","sha":"a5de6e2873d4437e1033885b90e2991f7a8a8bc5","user":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars0.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"repo":{"id":50676845,"name":"sous-chef","full_name":"savoirfairelinux/sous-chef","owner":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars0.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/savoirfairelinux/sous-chef","description":"Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.","fork":false,"url":"https://api.github.com/repos/savoirfairelinux/sous-chef","forks_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/forks","keys_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/teams","hooks_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/hooks","issue_events_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/events{/number}","events_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/events","assignees_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/assignees{/user}","branches_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/branches{/branch}","tags_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/tags","blobs_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/languages","stargazers_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/stargazers","contributors_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/contributors","subscribers_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/subscribers","subscription_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/subscription","commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/contents/{+path}","compare_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/merges","archive_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/downloads","issues_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues{/number}","pulls_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/labels{/name}","releases_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/releases{/id}","deployments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/deployments","created_at":"2016-01-29T16:56:04Z","updated_at":"2017-02-25T15:51:50Z","pushed_at":"2017-03-01T19:25:27Z","git_url":"git://github.com/savoirfairelinux/sous-chef.git","ssh_url":"git@github.com:savoirfairelinux/sous-chef.git","clone_url":"https://github.com/savoirfairelinux/sous-chef.git","svn_url":"https://github.com/savoirfairelinux/sous-chef","homepage":"","size":9014,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":27,"forks":39,"open_issues":27,"watchers":27,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678"},"html":{"href":"https://github.com/savoirfairelinux/sous-chef/pull/678"},"issue":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/678"},"comments":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/678/comments"},"review_comments":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678/comments"},"review_comment":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/678/commits"},"statuses":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/a91788f278300f7ea83df6bdc24b8d0fe5b352fa"}}}}
{"actor":{"display_login":"lingxiaoyang"}}