{"action":"opened","number":121,"pull_request":{"url":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121","id":138291363,"html_url":"https://github.com/purescript-web/purescript-dom/pull/121","diff_url":"https://github.com/purescript-web/purescript-dom/pull/121.diff","patch_url":"https://github.com/purescript-web/purescript-dom/pull/121.patch","issue_url":"https://api.github.com/repos/purescript-web/purescript-dom/issues/121","number":121,"state":"open","locked":false,"title":"Fix type of setHref, returns Unit not String","user":{"login":"houli","id":143868,"avatar_url":"https://avatars1.githubusercontent.com/u/143868?v=4","gravatar_id":"","url":"https://api.github.com/users/houli","html_url":"https://github.com/houli","followers_url":"https://api.github.com/users/houli/followers","following_url":"https://api.github.com/users/houli/following{/other_user}","gists_url":"https://api.github.com/users/houli/gists{/gist_id}","starred_url":"https://api.github.com/users/houli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houli/subscriptions","organizations_url":"https://api.github.com/users/houli/orgs","repos_url":"https://api.github.com/users/houli/repos","events_url":"https://api.github.com/users/houli/events{/privacy}","received_events_url":"https://api.github.com/users/houli/received_events","type":"User","site_admin":false},"body":"https://github.com/houli/purescript-dom/blob/fix-setHref-type/src/DOM/HTML/Location.js#L60\r\n`setHref` in the foreign module does not return anything. I saw on @paf31's TryPureScript stream he had to use void with this function here https://github.com/purescript/trypurescript/blob/gh-pages/src/Main.purs#L355","created_at":"2017-08-29T21:44:46Z","updated_at":"2017-08-29T21:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121/commits","review_comments_url":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121/comments","review_comment_url":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript-web/purescript-dom/issues/121/comments","statuses_url":"https://api.github.com/repos/purescript-web/purescript-dom/statuses/687d42fe507db0afcb911a270f0486ba9341e9f4","head":{"label":"houli:fix-setHref-type","ref":"fix-setHref-type","sha":"687d42fe507db0afcb911a270f0486ba9341e9f4","user":{"login":"houli","id":143868,"avatar_url":"https://avatars1.githubusercontent.com/u/143868?v=4","gravatar_id":"","url":"https://api.github.com/users/houli","html_url":"https://github.com/houli","followers_url":"https://api.github.com/users/houli/followers","following_url":"https://api.github.com/users/houli/following{/other_user}","gists_url":"https://api.github.com/users/houli/gists{/gist_id}","starred_url":"https://api.github.com/users/houli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houli/subscriptions","organizations_url":"https://api.github.com/users/houli/orgs","repos_url":"https://api.github.com/users/houli/repos","events_url":"https://api.github.com/users/houli/events{/privacy}","received_events_url":"https://api.github.com/users/houli/received_events","type":"User","site_admin":false},"repo":{"id":101808757,"name":"purescript-dom","full_name":"houli/purescript-dom","owner":{"login":"houli","id":143868,"avatar_url":"https://avatars1.githubusercontent.com/u/143868?v=4","gravatar_id":"","url":"https://api.github.com/users/houli","html_url":"https://github.com/houli","followers_url":"https://api.github.com/users/houli/followers","following_url":"https://api.github.com/users/houli/following{/other_user}","gists_url":"https://api.github.com/users/houli/gists{/gist_id}","starred_url":"https://api.github.com/users/houli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houli/subscriptions","organizations_url":"https://api.github.com/users/houli/orgs","repos_url":"https://api.github.com/users/houli/repos","events_url":"https://api.github.com/users/houli/events{/privacy}","received_events_url":"https://api.github.com/users/houli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/houli/purescript-dom","description":"Type definitions and standard effect for interacting with the DOM","fork":true,"url":"https://api.github.com/repos/houli/purescript-dom","forks_url":"https://api.github.com/repos/houli/purescript-dom/forks","keys_url":"https://api.github.com/repos/houli/purescript-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houli/purescript-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houli/purescript-dom/teams","hooks_url":"https://api.github.com/repos/houli/purescript-dom/hooks","issue_events_url":"https://api.github.com/repos/houli/purescript-dom/issues/events{/number}","events_url":"https://api.github.com/repos/houli/purescript-dom/events","assignees_url":"https://api.github.com/repos/houli/purescript-dom/assignees{/user}","branches_url":"https://api.github.com/repos/houli/purescript-dom/branches{/branch}","tags_url":"https://api.github.com/repos/houli/purescript-dom/tags","blobs_url":"https://api.github.com/repos/houli/purescript-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houli/purescript-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houli/purescript-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/houli/purescript-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houli/purescript-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/houli/purescript-dom/languages","stargazers_url":"https://api.github.com/repos/houli/purescript-dom/stargazers","contributors_url":"https://api.github.com/repos/houli/purescript-dom/contributors","subscribers_url":"https://api.github.com/repos/houli/purescript-dom/subscribers","subscription_url":"https://api.github.com/repos/houli/purescript-dom/subscription","commits_url":"https://api.github.com/repos/houli/purescript-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/houli/purescript-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/houli/purescript-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/houli/purescript-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/houli/purescript-dom/contents/{+path}","compare_url":"https://api.github.com/repos/houli/purescript-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houli/purescript-dom/merges","archive_url":"https://api.github.com/repos/houli/purescript-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houli/purescript-dom/downloads","issues_url":"https://api.github.com/repos/houli/purescript-dom/issues{/number}","pulls_url":"https://api.github.com/repos/houli/purescript-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/houli/purescript-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/houli/purescript-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houli/purescript-dom/labels{/name}","releases_url":"https://api.github.com/repos/houli/purescript-dom/releases{/id}","deployments_url":"https://api.github.com/repos/houli/purescript-dom/deployments","created_at":"2017-08-29T21:33:51Z","updated_at":"2017-08-29T21:33:53Z","pushed_at":"2017-08-29T21:41:55Z","git_url":"git://github.com/houli/purescript-dom.git","ssh_url":"git@github.com:houli/purescript-dom.git","clone_url":"https://github.com/houli/purescript-dom.git","svn_url":"https://github.com/houli/purescript-dom","homepage":"","size":253,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript-web:master","ref":"master","sha":"095b3a01e9971078037f587a5e8855c7d2b6e738","user":{"login":"purescript-web","id":28567727,"avatar_url":"https://avatars0.githubusercontent.com/u/28567727?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript-web","html_url":"https://github.com/purescript-web","followers_url":"https://api.github.com/users/purescript-web/followers","following_url":"https://api.github.com/users/purescript-web/following{/other_user}","gists_url":"https://api.github.com/users/purescript-web/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript-web/subscriptions","organizations_url":"https://api.github.com/users/purescript-web/orgs","repos_url":"https://api.github.com/users/purescript-web/repos","events_url":"https://api.github.com/users/purescript-web/events{/privacy}","received_events_url":"https://api.github.com/users/purescript-web/received_events","type":"Organization","site_admin":false},"repo":{"id":21155262,"name":"purescript-dom","full_name":"purescript-web/purescript-dom","owner":{"login":"purescript-web","id":28567727,"avatar_url":"https://avatars0.githubusercontent.com/u/28567727?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript-web","html_url":"https://github.com/purescript-web","followers_url":"https://api.github.com/users/purescript-web/followers","following_url":"https://api.github.com/users/purescript-web/following{/other_user}","gists_url":"https://api.github.com/users/purescript-web/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript-web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript-web/subscriptions","organizations_url":"https://api.github.com/users/purescript-web/orgs","repos_url":"https://api.github.com/users/purescript-web/repos","events_url":"https://api.github.com/users/purescript-web/events{/privacy}","received_events_url":"https://api.github.com/users/purescript-web/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript-web/purescript-dom","description":"Type definitions and standard effect for interacting with the DOM","fork":false,"url":"https://api.github.com/repos/purescript-web/purescript-dom","forks_url":"https://api.github.com/repos/purescript-web/purescript-dom/forks","keys_url":"https://api.github.com/repos/purescript-web/purescript-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript-web/purescript-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript-web/purescript-dom/teams","hooks_url":"https://api.github.com/repos/purescript-web/purescript-dom/hooks","issue_events_url":"https://api.github.com/repos/purescript-web/purescript-dom/issues/events{/number}","events_url":"https://api.github.com/repos/purescript-web/purescript-dom/events","assignees_url":"https://api.github.com/repos/purescript-web/purescript-dom/assignees{/user}","branches_url":"https://api.github.com/repos/purescript-web/purescript-dom/branches{/branch}","tags_url":"https://api.github.com/repos/purescript-web/purescript-dom/tags","blobs_url":"https://api.github.com/repos/purescript-web/purescript-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript-web/purescript-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript-web/purescript-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript-web/purescript-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript-web/purescript-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript-web/purescript-dom/languages","stargazers_url":"https://api.github.com/repos/purescript-web/purescript-dom/stargazers","contributors_url":"https://api.github.com/repos/purescript-web/purescript-dom/contributors","subscribers_url":"https://api.github.com/repos/purescript-web/purescript-dom/subscribers","subscription_url":"https://api.github.com/repos/purescript-web/purescript-dom/subscription","commits_url":"https://api.github.com/repos/purescript-web/purescript-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript-web/purescript-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript-web/purescript-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript-web/purescript-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript-web/purescript-dom/contents/{+path}","compare_url":"https://api.github.com/repos/purescript-web/purescript-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript-web/purescript-dom/merges","archive_url":"https://api.github.com/repos/purescript-web/purescript-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript-web/purescript-dom/downloads","issues_url":"https://api.github.com/repos/purescript-web/purescript-dom/issues{/number}","pulls_url":"https://api.github.com/repos/purescript-web/purescript-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript-web/purescript-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript-web/purescript-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript-web/purescript-dom/labels{/name}","releases_url":"https://api.github.com/repos/purescript-web/purescript-dom/releases{/id}","deployments_url":"https://api.github.com/repos/purescript-web/purescript-dom/deployments","created_at":"2014-06-24T07:00:49Z","updated_at":"2017-06-26T11:19:31Z","pushed_at":"2017-08-29T14:05:46Z","git_url":"git://github.com/purescript-web/purescript-dom.git","ssh_url":"git@github.com:purescript-web/purescript-dom.git","clone_url":"https://github.com/purescript-web/purescript-dom.git","svn_url":"https://github.com/purescript-web/purescript-dom","homepage":"","size":253,"stargazers_count":27,"watchers_count":27,"language":"PureScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":14,"forks":52,"open_issues":14,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121"},"html":{"href":"https://github.com/purescript-web/purescript-dom/pull/121"},"issue":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/issues/121"},"comments":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/purescript-web/purescript-dom/statuses/687d42fe507db0afcb911a270f0486ba9341e9f4"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"houli"}}