{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/100195251","pull_request_review_id":20894720,"id":100195251,"diff_hunk":"@@ -25,6 +25,7 @@\n         <dependency id=\"Microsoft.Build.Framework\" version=\"[$version$]\" />\n         <dependency id=\"Microsoft.Build.Tasks.Core\" version=\"[$version$]\" />\n         <dependency id=\"Microsoft.Build.Utilities.Core\" version=\"[$version$]\" />\n+        <dependency id=\"Microsoft.VisualStudio.Setup.Configuration.Interop\" version=\"1.2.304-preview5\" />","path":"build/NuGetPackages/Microsoft.Build.Runtime.nuspec","position":4,"original_position":4,"commit_id":"a3886c4e200a1af0e2ff9581b85eb57e72b33d44","original_commit_id":"a3886c4e200a1af0e2ff9581b85eb57e72b33d44","user":{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"body":"Isn't this not a runtime dependency because it gets compiled into our assembly?","created_at":"2017-02-08T23:11:30Z","updated_at":"2017-02-08T23:11:47Z","html_url":"https://github.com/Microsoft/msbuild/pull/1682#discussion_r100195251","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/100195251"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1682#discussion_r100195251"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682","id":105321150,"html_url":"https://github.com/Microsoft/msbuild/pull/1682","diff_url":"https://github.com/Microsoft/msbuild/pull/1682.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/1682.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1682","number":1682,"state":"open","locked":false,"title":"Add net46 dependencies to msbuild nuspecs","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"body":"This enables users to publish their msbuild depending app for net46 and get the closure of dependencies needed for msbuild.\r\n\r\nI just copied over the net46 only dependencies from the project.json files over to the nuspec files.\r\n\r\nThis change should affect neither VS (which depends on msbuild via the vsix) nor CLI (who only publishes msbuild packages for .net core, not full framework).\r\n\r\nResolves #1681","created_at":"2017-02-08T22:36:42Z","updated_at":"2017-02-08T23:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3ef11835adbd5e087905f3d39e870680c8f7137","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1682/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/a3886c4e200a1af0e2ff9581b85eb57e72b33d44","head":{"label":"cdmihai:net46Dependencies","ref":"net46Dependencies","sha":"a3886c4e200a1af0e2ff9581b85eb57e72b33d44","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"repo":{"id":43783196,"name":"msbuild","full_name":"cdmihai/msbuild","owner":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdmihai/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/cdmihai/msbuild","forks_url":"https://api.github.com/repos/cdmihai/msbuild/forks","keys_url":"https://api.github.com/repos/cdmihai/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdmihai/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdmihai/msbuild/teams","hooks_url":"https://api.github.com/repos/cdmihai/msbuild/hooks","issue_events_url":"https://api.github.com/repos/cdmihai/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/cdmihai/msbuild/events","assignees_url":"https://api.github.com/repos/cdmihai/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/cdmihai/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/cdmihai/msbuild/tags","blobs_url":"https://api.github.com/repos/cdmihai/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdmihai/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdmihai/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdmihai/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdmihai/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/cdmihai/msbuild/languages","stargazers_url":"https://api.github.com/repos/cdmihai/msbuild/stargazers","contributors_url":"https://api.github.com/repos/cdmihai/msbuild/contributors","subscribers_url":"https://api.github.com/repos/cdmihai/msbuild/subscribers","subscription_url":"https://api.github.com/repos/cdmihai/msbuild/subscription","commits_url":"https://api.github.com/repos/cdmihai/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdmihai/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdmihai/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdmihai/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdmihai/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/cdmihai/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdmihai/msbuild/merges","archive_url":"https://api.github.com/repos/cdmihai/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdmihai/msbuild/downloads","issues_url":"https://api.github.com/repos/cdmihai/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/cdmihai/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/cdmihai/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/cdmihai/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdmihai/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/cdmihai/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/cdmihai/msbuild/deployments","created_at":"2015-10-06T22:47:50Z","updated_at":"2016-01-27T00:00:17Z","pushed_at":"2017-02-08T22:33:58Z","git_url":"git://github.com/cdmihai/msbuild.git","ssh_url":"git@github.com:cdmihai/msbuild.git","clone_url":"https://github.com/cdmihai/msbuild.git","svn_url":"https://github.com/cdmihai/msbuild","homepage":null,"size":17071,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:vs15-rtw","ref":"vs15-rtw","sha":"7636893361ea61cf35e0e7b8d30c8d478729c89e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2017-02-08T02:34:19Z","pushed_at":"2017-02-08T22:55:07Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":17035,"stargazers_count":2874,"watchers_count":2874,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":610,"mirror_url":null,"open_issues_count":415,"forks":610,"open_issues":415,"watchers":2874,"default_branch":"xplat"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1682"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1682"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/a3886c4e200a1af0e2ff9581b85eb57e72b33d44"}}}}
{"actor":{"display_login":"rainersigwald"}}