{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/comments/135820003","pull_request_review_id":59275521,"id":135820003,"diff_hunk":"@@ -0,0 +1,23 @@\n+.PHONY: build release install uninstall clean test doc reindent","path":"Makefile","position":1,"original_position":1,"commit_id":"87c710b0ccf536a2bc41503c807bc25c1634918a","original_commit_id":"4c9a1092aeeac928fe5b72d9c94a564f087776bb","user":{"login":"gaborigloi","id":10549240,"avatar_url":"https://avatars3.githubusercontent.com/u/10549240?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborigloi","html_url":"https://github.com/gaborigloi","followers_url":"https://api.github.com/users/gaborigloi/followers","following_url":"https://api.github.com/users/gaborigloi/following{/other_user}","gists_url":"https://api.github.com/users/gaborigloi/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborigloi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborigloi/subscriptions","organizations_url":"https://api.github.com/users/gaborigloi/orgs","repos_url":"https://api.github.com/users/gaborigloi/repos","events_url":"https://api.github.com/users/gaborigloi/events{/privacy}","received_events_url":"https://api.github.com/users/gaborigloi/received_events","type":"User","site_admin":false},"body":"There is no `doc` target but if listing it here does no harm we can leave it, since this is just a customized version of our standard jbuilder `Makefile`.","created_at":"2017-08-29T15:09:49Z","updated_at":"2017-08-29T15:39:27Z","html_url":"https://github.com/xapi-project/wsproxy/pull/10#discussion_r135820003","pull_request_url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/comments/135820003"},"html":{"href":"https://github.com/xapi-project/wsproxy/pull/10#discussion_r135820003"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10","id":137715563,"html_url":"https://github.com/xapi-project/wsproxy/pull/10","diff_url":"https://github.com/xapi-project/wsproxy/pull/10.diff","patch_url":"https://github.com/xapi-project/wsproxy/pull/10.patch","issue_url":"https://api.github.com/repos/xapi-project/wsproxy/issues/10","number":10,"state":"open","locked":false,"title":"CP-24262: wsproxy cli code refactoring","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"The current version does no longer leak fds but seems not to work properly. Do not merge but please comment.","created_at":"2017-08-25T16:54:41Z","updated_at":"2017-08-29T15:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec7d60baf220fc771e264196cc8c7db3a7393477","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jonludlam","id":210963,"avatar_url":"https://avatars3.githubusercontent.com/u/210963?v=4","gravatar_id":"","url":"https://api.github.com/users/jonludlam","html_url":"https://github.com/jonludlam","followers_url":"https://api.github.com/users/jonludlam/followers","following_url":"https://api.github.com/users/jonludlam/following{/other_user}","gists_url":"https://api.github.com/users/jonludlam/gists{/gist_id}","starred_url":"https://api.github.com/users/jonludlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonludlam/subscriptions","organizations_url":"https://api.github.com/users/jonludlam/orgs","repos_url":"https://api.github.com/users/jonludlam/repos","events_url":"https://api.github.com/users/jonludlam/events{/privacy}","received_events_url":"https://api.github.com/users/jonludlam/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10/commits","review_comments_url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10/comments","review_comment_url":"https://api.github.com/repos/xapi-project/wsproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/wsproxy/issues/10/comments","statuses_url":"https://api.github.com/repos/xapi-project/wsproxy/statuses/87c710b0ccf536a2bc41503c807bc25c1634918a","head":{"label":"mseri:master","ref":"master","sha":"87c710b0ccf536a2bc41503c807bc25c1634918a","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"repo":{"id":84930082,"name":"wsproxy","full_name":"mseri/wsproxy","owner":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mseri/wsproxy","description":"Ocaml websockets proxy for use with XCP","fork":true,"url":"https://api.github.com/repos/mseri/wsproxy","forks_url":"https://api.github.com/repos/mseri/wsproxy/forks","keys_url":"https://api.github.com/repos/mseri/wsproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mseri/wsproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mseri/wsproxy/teams","hooks_url":"https://api.github.com/repos/mseri/wsproxy/hooks","issue_events_url":"https://api.github.com/repos/mseri/wsproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mseri/wsproxy/events","assignees_url":"https://api.github.com/repos/mseri/wsproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mseri/wsproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mseri/wsproxy/tags","blobs_url":"https://api.github.com/repos/mseri/wsproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mseri/wsproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mseri/wsproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mseri/wsproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mseri/wsproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mseri/wsproxy/languages","stargazers_url":"https://api.github.com/repos/mseri/wsproxy/stargazers","contributors_url":"https://api.github.com/repos/mseri/wsproxy/contributors","subscribers_url":"https://api.github.com/repos/mseri/wsproxy/subscribers","subscription_url":"https://api.github.com/repos/mseri/wsproxy/subscription","commits_url":"https://api.github.com/repos/mseri/wsproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mseri/wsproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mseri/wsproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mseri/wsproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mseri/wsproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mseri/wsproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mseri/wsproxy/merges","archive_url":"https://api.github.com/repos/mseri/wsproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mseri/wsproxy/downloads","issues_url":"https://api.github.com/repos/mseri/wsproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mseri/wsproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mseri/wsproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mseri/wsproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mseri/wsproxy/labels{/name}","releases_url":"https://api.github.com/repos/mseri/wsproxy/releases{/id}","deployments_url":"https://api.github.com/repos/mseri/wsproxy/deployments","created_at":"2017-03-14T09:26:29Z","updated_at":"2017-03-14T09:26:31Z","pushed_at":"2017-08-29T15:23:59Z","git_url":"git://github.com/mseri/wsproxy.git","ssh_url":"git@github.com:mseri/wsproxy.git","clone_url":"https://github.com/mseri/wsproxy.git","svn_url":"https://github.com/mseri/wsproxy","homepage":"","size":132,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"43b685cb9d230a267cbe4be7579a561d18e74e63","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":8725997,"name":"wsproxy","full_name":"xapi-project/wsproxy","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/wsproxy","description":"Ocaml websockets proxy for use with XCP","fork":false,"url":"https://api.github.com/repos/xapi-project/wsproxy","forks_url":"https://api.github.com/repos/xapi-project/wsproxy/forks","keys_url":"https://api.github.com/repos/xapi-project/wsproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/wsproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/wsproxy/teams","hooks_url":"https://api.github.com/repos/xapi-project/wsproxy/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/wsproxy/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/wsproxy/events","assignees_url":"https://api.github.com/repos/xapi-project/wsproxy/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/wsproxy/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/wsproxy/tags","blobs_url":"https://api.github.com/repos/xapi-project/wsproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/wsproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/wsproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/wsproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/wsproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/wsproxy/languages","stargazers_url":"https://api.github.com/repos/xapi-project/wsproxy/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/wsproxy/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/wsproxy/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/wsproxy/subscription","commits_url":"https://api.github.com/repos/xapi-project/wsproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/wsproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/wsproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/wsproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/wsproxy/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/wsproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/wsproxy/merges","archive_url":"https://api.github.com/repos/xapi-project/wsproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/wsproxy/downloads","issues_url":"https://api.github.com/repos/xapi-project/wsproxy/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/wsproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/wsproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/wsproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/wsproxy/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/wsproxy/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/wsproxy/deployments","created_at":"2013-03-12T11:10:05Z","updated_at":"2016-11-07T12:17:01Z","pushed_at":"2017-08-29T15:24:00Z","git_url":"git://github.com/xapi-project/wsproxy.git","ssh_url":"git@github.com:xapi-project/wsproxy.git","clone_url":"https://github.com/xapi-project/wsproxy.git","svn_url":"https://github.com/xapi-project/wsproxy","homepage":"","size":113,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10"},"html":{"href":"https://github.com/xapi-project/wsproxy/pull/10"},"issue":{"href":"https://api.github.com/repos/xapi-project/wsproxy/issues/10"},"comments":{"href":"https://api.github.com/repos/xapi-project/wsproxy/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/wsproxy/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/wsproxy/statuses/87c710b0ccf536a2bc41503c807bc25c1634918a"}}}}
{"actor":{"display_login":"gaborigloi"}}