{"action":"closed","number":1639,"pull_request":{"url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639","id":106639306,"html_url":"https://github.com/Icenium/icenium-cli/pull/1639","diff_url":"https://github.com/Icenium/icenium-cli/pull/1639.diff","patch_url":"https://github.com/Icenium/icenium-cli/pull/1639.patch","issue_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1639","number":1639,"state":"closed","locked":false,"title":"Fix check if package has `@types`","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"During migration from fibers to promises, we've lost one `!` in the check if npm package has typings in `@types` repo.\r\nThis led to incorrect behavior:\r\n - typings of packages, which are available in `@types`, are not installed (for example `lodash`).\r\n - trying to install plugin, which does not have typing in `@types` leads to error (something like `Error while installing dependency: Command npm.cmd failed with exit code 4294963238.`).\r\n\r\nFix the check (add the missing `!`) which will fix the incorrect behavior.","created_at":"2017-02-16T23:42:20Z","updated_at":"2017-02-17T16:05:28Z","closed_at":"2017-02-17T16:05:28Z","merged_at":"2017-02-17T16:05:28Z","merge_commit_sha":"566dd84af7222228fba495530c15e6fd73de2988","assignee":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"assignees":[{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/26","html_url":"https://github.com/Icenium/icenium-cli/milestone/26","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/26/labels","id":2249965,"number":26,"title":"3.7.0","description":"","creator":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2017-01-13T14:24:23Z","updated_at":"2017-02-17T16:05:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1639/comments","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/83e7aeb5386086ab765fde7994be22fec9891701","head":{"label":"Icenium:vladimirov/fix-npm-types","ref":"vladimirov/fix-npm-types","sha":"83e7aeb5386086ab765fde7994be22fec9891701","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Icenium/icenium-cli/deployments","created_at":"2013-11-14T15:27:18Z","updated_at":"2017-01-04T12:18:39Z","pushed_at":"2017-02-17T16:05:28Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":28437,"stargazers_count":31,"watchers_count":31,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":31,"default_branch":"master"}},"base":{"label":"Icenium:release","ref":"release","sha":"2817531a0c97b83adea957fcbe4e794b9d4034d0","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Icenium/icenium-cli/deployments","created_at":"2013-11-14T15:27:18Z","updated_at":"2017-01-04T12:18:39Z","pushed_at":"2017-02-17T16:05:28Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":28437,"stargazers_count":31,"watchers_count":31,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639"},"html":{"href":"https://github.com/Icenium/icenium-cli/pull/1639"},"issue":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1639"},"comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/Icenium/icenium-cli/statuses/83e7aeb5386086ab765fde7994be22fec9891701"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":5,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"TsvetanMilanov"}}