{"action":"created","issue":{"url":"https://api.github.com/repos/studentinsights/studentinsights/issues/975","repository_url":"https://api.github.com/repos/studentinsights/studentinsights","labels_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/975/labels{/name}","comments_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/975/comments","events_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/975/events","html_url":"https://github.com/studentinsights/studentinsights/pull/975","id":251998329,"number":975,"title":"Improve specs fake data generator specs, move methods around for readability","user":{"login":"Jngai","id":1547934,"avatar_url":"https://avatars3.githubusercontent.com/u/1547934?v=4","gravatar_id":"","url":"https://api.github.com/users/Jngai","html_url":"https://github.com/Jngai","followers_url":"https://api.github.com/users/Jngai/followers","following_url":"https://api.github.com/users/Jngai/following{/other_user}","gists_url":"https://api.github.com/users/Jngai/gists{/gist_id}","starred_url":"https://api.github.com/users/Jngai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jngai/subscriptions","organizations_url":"https://api.github.com/users/Jngai/orgs","repos_url":"https://api.github.com/users/Jngai/repos","events_url":"https://api.github.com/users/Jngai/events{/privacy}","received_events_url":"https://api.github.com/users/Jngai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-22T15:30:57Z","updated_at":"2017-08-23T15:26:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/studentinsights/studentinsights/pulls/975","html_url":"https://github.com/studentinsights/studentinsights/pull/975","diff_url":"https://github.com/studentinsights/studentinsights/pull/975.diff","patch_url":"https://github.com/studentinsights/studentinsights/pull/975.patch"},"body":"I was working on facestudent.rb and then noticed that the spec isn't well tested. I added a couple of more tests to the spec. I moved some methods around to be defined earlier before its actually called. I noticed that `add_services` and `add_events` in fakestudent.rb actually isn't saving for each student but only some of them. There is also a duplicate line at line 230. "},"comment":{"url":"https://api.github.com/repos/studentinsights/studentinsights/issues/comments/324371790","html_url":"https://github.com/studentinsights/studentinsights/pull/975#issuecomment-324371790","issue_url":"https://api.github.com/repos/studentinsights/studentinsights/issues/975","id":324371790,"user":{"login":"Jngai","id":1547934,"avatar_url":"https://avatars3.githubusercontent.com/u/1547934?v=4","gravatar_id":"","url":"https://api.github.com/users/Jngai","html_url":"https://github.com/Jngai","followers_url":"https://api.github.com/users/Jngai/followers","following_url":"https://api.github.com/users/Jngai/following{/other_user}","gists_url":"https://api.github.com/users/Jngai/gists{/gist_id}","starred_url":"https://api.github.com/users/Jngai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jngai/subscriptions","organizations_url":"https://api.github.com/users/Jngai/orgs","repos_url":"https://api.github.com/users/Jngai/repos","events_url":"https://api.github.com/users/Jngai/events{/privacy}","received_events_url":"https://api.github.com/users/Jngai/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T15:26:25Z","updated_at":"2017-08-23T15:26:25Z","body":"I think we commented on the same time and you posted earlier. "}}
{"actor":{"display_login":"Jngai"}}