{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/98037092","pull_request_review_id":18667031,"id":98037092,"diff_hunk":"@@ -2968,6 +2968,37 @@ def test_list_software(self):\n         self.assertTrue(re.search('^\\s+\\* GCC v4.6.3: dummy', txt, re.M))\n         self.assertFalse(re.search('gzip', txt, re.M))\n \n+    def test_parse_optarch(self):\n+        \"\"\"Test correct parsing of optarch option.\"\"\"\n+        \n+        options = EasyBuildOptions()\n+\n+        # Check for EasyBuildErrors\n+        error_msg = \"The optarch option has an incorrect syntax\"\n+        options.options.optarch = 'Intel:something;GCC'\n+        self.assertErrorRegex(EasyBuildError, error_msg, options.postprocess)\n+\n+        error_msg = \"The optarch option contains duplicated entries for compiler\"\n+        options.options.optarch = 'Intel:something;GCC:somethingelse;Intel:anothersomething'\n+        self.assertErrorRegex(EasyBuildError, error_msg, options.postprocess)\n+\n+        # Check the parsing itself\n+        test_cases = [\n+                ('',''),\n+                ('xHost','xHost'),\n+                ('GENERIC','GENERIC'),\n+                ('Intel:xHost', {'Intel': 'xHost'}),\n+                ('Intel:GENERIC', {'Intel': 'GENERIC'}),\n+                ('Intel:xHost;GCC:march=x86-64 -mtune=generic', {'Intel': 'xHost', 'GCC': 'march=x86-64 -mtune=generic'}),\n+                ('Intel:;GCC:march=x86-64 -mtune=generic', {'Intel': '', 'GCC': 'march=x86-64 -mtune=generic'}),\n+                ]\n+\n+        for optarch_string, optarch_parsed in test_cases:\n+            options.options.optarch = optarch_string\n+            options.postprocess()\n+            self.assertTrue(options.options.optarch == optarch_parsed, \"Parsing of optarch: True means %s == %s\" % ","path":"test/framework/options.py","position":null,"original_position":32,"commit_id":"9baa7509d06515a427a70bf18b77ef1ee301bf1b","original_commit_id":"9ec1fb875ff686ee6952fb67795ddb06c69c91ea","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"Using `assertTrue` with `==` is a bit weird, so we should change that (but also in a separate PR).","created_at":"2017-01-26T16:49:06Z","updated_at":"2017-01-26T16:49:07Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/2071#discussion_r98037092","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/98037092"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/2071#discussion_r98037092"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071","id":99676204,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/2071","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/2071.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/2071.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2071","number":2071,"state":"open","locked":false,"title":"optarch can now be specified on a toolchain basis","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"body":"This PR enables EB to accept a more powerful `--optarch` syntax. Valid options are:\r\n\r\n`--optarch=someflag` -> Same as now\r\n`--optarch=GENERIC` -> Same as now\r\n`--optarch=Intel:xCORE-AVX512,GCC:GENERIC` -> Tells Intel based toolchains to use `-xCORE-AVX512` as a flag, and GCC based toolchains to use a generic set of flags (as specified in the toolchain definition)\r\n`--optarch=Intel:,GCC:someflag` -> Tells Intel based toolchains to have the default behaviour (currently `-xHost`), and GCC based toolchains to use `-someflag`\r\n`--optarch=Intel,GCC:someflag` -> Same as the previous case\r\n`--optarch=Intel:xCORE-AVX512,GCC:GENERIC,Intel:xHost` -> Tells Intel based toolchains to use `-xCORE-AVX512`. The second case is ignored.\r\n\r\nThis allows to install packages on multiple toolchains using the correct `--optarch` option in a single command, or to have a single definition of `EASYBUILD_OPTARCH` that is correct regardless of the toolchain used.\r\n\r\nA test is pending.","created_at":"2016-12-29T16:53:20Z","updated_at":"2017-01-26T16:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6c254a29860b1405bc707ed6cbf8d4cab287390","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/40","html_url":"https://github.com/hpcugent/easybuild-framework/milestone/40","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/40/labels","id":2121283,"number":40,"title":"3.1.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":35,"state":"open","created_at":"2016-11-08T08:53:58Z","updated_at":"2017-01-25T18:44:16Z","due_on":"2017-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2071/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/9baa7509d06515a427a70bf18b77ef1ee301bf1b","head":{"label":"damianam:optarch","ref":"optarch","sha":"9baa7509d06515a427a70bf18b77ef1ee301bf1b","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"repo":{"id":47122542,"name":"easybuild-framework","full_name":"damianam/easybuild-framework","owner":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damianam/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/damianam/easybuild-framework","forks_url":"https://api.github.com/repos/damianam/easybuild-framework/forks","keys_url":"https://api.github.com/repos/damianam/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damianam/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damianam/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/damianam/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/damianam/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/damianam/easybuild-framework/events","assignees_url":"https://api.github.com/repos/damianam/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/damianam/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/damianam/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/damianam/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damianam/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damianam/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/damianam/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damianam/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/damianam/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/damianam/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/damianam/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/damianam/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/damianam/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/damianam/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/damianam/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/damianam/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/damianam/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/damianam/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/damianam/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damianam/easybuild-framework/merges","archive_url":"https://api.github.com/repos/damianam/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damianam/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/damianam/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/damianam/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/damianam/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/damianam/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damianam/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/damianam/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/damianam/easybuild-framework/deployments","created_at":"2015-11-30T14:07:05Z","updated_at":"2016-12-26T16:01:38Z","pushed_at":"2017-01-26T15:00:24Z","git_url":"git://github.com/damianam/easybuild-framework.git","ssh_url":"git@github.com:damianam/easybuild-framework.git","clone_url":"https://github.com/damianam/easybuild-framework.git","svn_url":"https://github.com/damianam/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":14266,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"1d75e61f82be264f67fb09eaba393d2c6be1f31f","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/deployments","created_at":"2012-03-08T17:07:43Z","updated_at":"2016-12-23T11:21:02Z","pushed_at":"2017-01-26T15:00:26Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":14331,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":354,"forks":101,"open_issues":354,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/2071"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2071"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2071/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2071/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/9baa7509d06515a427a70bf18b77ef1ee301bf1b"}}}}
{"actor":{"display_login":"boegel"}}