{"action":"opened","number":2508,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/2508","id":127844702,"html_url":"https://github.com/facebook/rocksdb/pull/2508","diff_url":"https://github.com/facebook/rocksdb/pull/2508.diff","patch_url":"https://github.com/facebook/rocksdb/pull/2508.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/2508","number":2508,"state":"open","locked":false,"title":"Make \"make analyze\" happy","user":{"login":"siying","id":5334567,"avatar_url":"https://avatars0.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"body":"Summary: \"make analyze\" is reporting some errors. It's complicated to look but it seems to me that they are all false positive. Anyway, I think cleaning them up is a good idea. Some of the changes are hacky but I don't know a better way.\r\n\r\nTest Plan: Run \"make analyze\"","created_at":"2017-06-28T05:28:00Z","updated_at":"2017-06-28T05:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"IslamAbdelRahman","id":1676006,"avatar_url":"https://avatars1.githubusercontent.com/u/1676006?v=3","gravatar_id":"","url":"https://api.github.com/users/IslamAbdelRahman","html_url":"https://github.com/IslamAbdelRahman","followers_url":"https://api.github.com/users/IslamAbdelRahman/followers","following_url":"https://api.github.com/users/IslamAbdelRahman/following{/other_user}","gists_url":"https://api.github.com/users/IslamAbdelRahman/gists{/gist_id}","starred_url":"https://api.github.com/users/IslamAbdelRahman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IslamAbdelRahman/subscriptions","organizations_url":"https://api.github.com/users/IslamAbdelRahman/orgs","repos_url":"https://api.github.com/users/IslamAbdelRahman/repos","events_url":"https://api.github.com/users/IslamAbdelRahman/events{/privacy}","received_events_url":"https://api.github.com/users/IslamAbdelRahman/received_events","type":"User","site_admin":false},{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars0.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},{"login":"ajkr","id":4780362,"avatar_url":"https://avatars3.githubusercontent.com/u/4780362?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2508/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2508/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/2508/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/0364d1472f19a8a7d5ca3fc71e6ca05f0ff2f439","head":{"label":"siying:clang_analyze","ref":"clang_analyze","sha":"0364d1472f19a8a7d5ca3fc71e6ca05f0ff2f439","user":{"login":"siying","id":5334567,"avatar_url":"https://avatars0.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"repo":{"id":48715206,"name":"rocksdb","full_name":"siying/rocksdb","owner":{"login":"siying","id":5334567,"avatar_url":"https://avatars0.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siying/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/siying/rocksdb","forks_url":"https://api.github.com/repos/siying/rocksdb/forks","keys_url":"https://api.github.com/repos/siying/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siying/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siying/rocksdb/teams","hooks_url":"https://api.github.com/repos/siying/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/siying/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/siying/rocksdb/events","assignees_url":"https://api.github.com/repos/siying/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/siying/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/siying/rocksdb/tags","blobs_url":"https://api.github.com/repos/siying/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siying/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siying/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/siying/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siying/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/siying/rocksdb/languages","stargazers_url":"https://api.github.com/repos/siying/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/siying/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/siying/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/siying/rocksdb/subscription","commits_url":"https://api.github.com/repos/siying/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/siying/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/siying/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/siying/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/siying/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/siying/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siying/rocksdb/merges","archive_url":"https://api.github.com/repos/siying/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siying/rocksdb/downloads","issues_url":"https://api.github.com/repos/siying/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/siying/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/siying/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/siying/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siying/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/siying/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/siying/rocksdb/deployments","created_at":"2015-12-28T22:25:13Z","updated_at":"2016-10-25T17:46:09Z","pushed_at":"2017-06-28T05:26:10Z","git_url":"git://github.com/siying/rocksdb.git","ssh_url":"git@github.com:siying/rocksdb.git","clone_url":"https://github.com/siying/rocksdb.git","svn_url":"https://github.com/siying/rocksdb","homepage":"http://rocksdb.org","size":90632,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1cd45cd1b3ce3886f2c4c024e864d0d0cb19fc26","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2017-06-28T02:57:04Z","pushed_at":"2017-06-28T02:41:38Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":102823,"stargazers_count":7938,"watchers_count":7938,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1713,"mirror_url":null,"open_issues_count":466,"forks":1713,"open_issues":466,"watchers":7938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2508"},"html":{"href":"https://github.com/facebook/rocksdb/pull/2508"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2508"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2508/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2508/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2508/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/0364d1472f19a8a7d5ca3fc71e6ca05f0ff2f439"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"siying"}}