{"action":"created","issue":{"url":"https://api.github.com/repos/Clever/workflow-manager/issues/62","repository_url":"https://api.github.com/repos/Clever/workflow-manager","labels_url":"https://api.github.com/repos/Clever/workflow-manager/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/Clever/workflow-manager/issues/62/comments","events_url":"https://api.github.com/repos/Clever/workflow-manager/issues/62/events","html_url":"https://github.com/Clever/workflow-manager/pull/62","id":263700129,"number":62,"title":"add StateResourceStatus","user":{"login":"mohit","id":244154,"avatar_url":"https://avatars3.githubusercontent.com/u/244154?v=4","gravatar_id":"","url":"https://api.github.com/users/mohit","html_url":"https://github.com/mohit","followers_url":"https://api.github.com/users/mohit/followers","following_url":"https://api.github.com/users/mohit/following{/other_user}","gists_url":"https://api.github.com/users/mohit/gists{/gist_id}","starred_url":"https://api.github.com/users/mohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohit/subscriptions","organizations_url":"https://api.github.com/users/mohit/orgs","repos_url":"https://api.github.com/users/mohit/repos","events_url":"https://api.github.com/users/mohit/events{/privacy}","received_events_url":"https://api.github.com/users/mohit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kofi-clever","id":16216084,"avatar_url":"https://avatars0.githubusercontent.com/u/16216084?v=4","gravatar_id":"","url":"https://api.github.com/users/kofi-clever","html_url":"https://github.com/kofi-clever","followers_url":"https://api.github.com/users/kofi-clever/followers","following_url":"https://api.github.com/users/kofi-clever/following{/other_user}","gists_url":"https://api.github.com/users/kofi-clever/gists{/gist_id}","starred_url":"https://api.github.com/users/kofi-clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofi-clever/subscriptions","organizations_url":"https://api.github.com/users/kofi-clever/orgs","repos_url":"https://api.github.com/users/kofi-clever/repos","events_url":"https://api.github.com/users/kofi-clever/events{/privacy}","received_events_url":"https://api.github.com/users/kofi-clever/received_events","type":"User","site_admin":false},"assignees":[{"login":"kofi-clever","id":16216084,"avatar_url":"https://avatars0.githubusercontent.com/u/16216084?v=4","gravatar_id":"","url":"https://api.github.com/users/kofi-clever","html_url":"https://github.com/kofi-clever","followers_url":"https://api.github.com/users/kofi-clever/followers","following_url":"https://api.github.com/users/kofi-clever/following{/other_user}","gists_url":"https://api.github.com/users/kofi-clever/gists{/gist_id}","starred_url":"https://api.github.com/users/kofi-clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofi-clever/subscriptions","organizations_url":"https://api.github.com/users/kofi-clever/orgs","repos_url":"https://api.github.com/users/kofi-clever/repos","events_url":"https://api.github.com/users/kofi-clever/events{/privacy}","received_events_url":"https://api.github.com/users/kofi-clever/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-10-08T07:45:22Z","updated_at":"2017-10-11T23:26:45Z","closed_at":"2017-10-11T23:26:45Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/Clever/workflow-manager/pulls/62","html_url":"https://github.com/Clever/workflow-manager/pull/62","diff_url":"https://github.com/Clever/workflow-manager/pull/62.diff","patch_url":"https://github.com/Clever/workflow-manager/pull/62.patch"},"body":"# Why\r\n\r\nThis would allow us to expose `queued` and `running` activities in a specific `namespace` while continuing to provide an API that allows us to change internal specifics relating to how we interact with step-functions and/or Batch (however there is no current plan to implement this functionality for Batch).\r\n\r\n# Implementation Plan\r\n\r\nWe currently don't store StateResources for `SFNWorkflowManager` and for now we can continue to ignore that. Not implemented for AWS Batch. \r\n\r\n* Add StateResourceStatus to the StateResource model.\r\n\r\n* Add a new endpoint `GET /state-resources/<namespace>?workflowDefinitionName=<workflowName>`\r\n\r\n **Open to suggestions here?** ^\r\n\r\nThis will respond with a `[]models.StateResource` that contain the latest `Queued` and `Running` stats from Cloudwatch for SFN.\r\n\r\n## TODO\r\n\r\n* [x] test the api and make sure the cloud watch metrics show up within 2 minutes\r\n\r\n## Next Steps\r\n\r\n* We should store the state-resources and state-resource-status to the dynamodb so that we don't have to hit Cloudwatch metrics every time we get a request. Hoping to use the `lastUpdated` timestamp to only query at max once a minute.\r\n\r\n---------------\r\n\r\n- [x] Update swagger.yml version\r\n- [x] Run \"make generate\"\r\n- [ ] After merging, add a github tag to your merge commit"},"comment":{"url":"https://api.github.com/repos/Clever/workflow-manager/issues/comments/335976794","html_url":"https://github.com/Clever/workflow-manager/pull/62#issuecomment-335976794","issue_url":"https://api.github.com/repos/Clever/workflow-manager/issues/62","id":335976794,"user":{"login":"mohit","id":244154,"avatar_url":"https://avatars3.githubusercontent.com/u/244154?v=4","gravatar_id":"","url":"https://api.github.com/users/mohit","html_url":"https://github.com/mohit","followers_url":"https://api.github.com/users/mohit/followers","following_url":"https://api.github.com/users/mohit/following{/other_user}","gists_url":"https://api.github.com/users/mohit/gists{/gist_id}","starred_url":"https://api.github.com/users/mohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohit/subscriptions","organizations_url":"https://api.github.com/users/mohit/orgs","repos_url":"https://api.github.com/users/mohit/repos","events_url":"https://api.github.com/users/mohit/events{/privacy}","received_events_url":"https://api.github.com/users/mohit/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T23:26:45Z","updated_at":"2017-10-11T23:26:45Z","author_association":"OWNER","body":"ahem. Closing this for now since it does not seem like the right way forward. I'm in favor of adding the StateResourceStatus and the API here, but if it does not have the right data - what's the point. "}}
{"actor":{"display_login":"mohit"}}