{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/158580473","pull_request_review_id":85421127,"id":158580473,"diff_hunk":"@@ -381,6 +381,50 @@ class CApplication : public CXBApplicationEx, public IPlayerCallback, public IMs\n   */\n   void UnlockFrameMoveGuard();\n \n+  /*!\n+  \\brief Returns true if Application is currently playing an ISO stack\n+  */\n+  bool IsPlayingISOStack() const { return m_itemCurrentFile->IsStack() && m_currentStack->Size() > 0 && m_currentStackIsDiscImageStack; }","path":"xbmc/Application.h","position":7,"original_position":7,"commit_id":"7267d3ebd800e2aeddce38c818f4e39a4555e7bd","original_commit_id":"7267d3ebd800e2aeddce38c818f4e39a4555e7bd","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars0.githubusercontent.com/u/576009?v=4","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"> but it's really tightly intertwined with CApplication private members\r\n\r\nI think we should take the chance and try to resolve this.","created_at":"2017-12-23T10:36:39Z","updated_at":"2017-12-23T10:36:39Z","html_url":"https://github.com/xbmc/xbmc/pull/13235#discussion_r158580473","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13235","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/158580473"},"html":{"href":"https://github.com/xbmc/xbmc/pull/13235#discussion_r158580473"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13235"}},"in_reply_to_id":158579185},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/13235","id":159930547,"html_url":"https://github.com/xbmc/xbmc/pull/13235","diff_url":"https://github.com/xbmc/xbmc/pull/13235.diff","patch_url":"https://github.com/xbmc/xbmc/pull/13235.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/13235","number":13235,"state":"open","locked":false,"title":"Stacks - some refactoring and bug fixes","user":{"login":"Voyager1","id":549958,"avatar_url":"https://avatars1.githubusercontent.com/u/549958?v=4","gravatar_id":"","url":"https://api.github.com/users/Voyager1","html_url":"https://github.com/Voyager1","followers_url":"https://api.github.com/users/Voyager1/followers","following_url":"https://api.github.com/users/Voyager1/following{/other_user}","gists_url":"https://api.github.com/users/Voyager1/gists{/gist_id}","starred_url":"https://api.github.com/users/Voyager1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Voyager1/subscriptions","organizations_url":"https://api.github.com/users/Voyager1/orgs","repos_url":"https://api.github.com/users/Voyager1/repos","events_url":"https://api.github.com/users/Voyager1/events{/privacy}","received_events_url":"https://api.github.com/users/Voyager1/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your change in the Title above -->\r\nsee title.\r\n\r\n## Description\r\n<!--- Describe your change in detail -->\r\nSome cleanup of stacking mess by factoring out ugly array and pointer manipulation.\r\nSome bugfixes related to stacking that was broken since a long time.\r\nHarmonization (to an extent) between ISO stacking and Regular stacking code.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\nThis change is required to fix some long standing issues with stacking (it simply didn't work anymore).\r\nThe change is also required to make auto-resume work for #13138\r\nFinally, general code cleanup, making it more readable.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\nExtensively tested using ISO stacks (e.g. multi-part DVD box or double-sided DVD) and Regular stacks (e.g. video that has multiple parts to make 1 seamless movie, e.g. movie.cd1.avi, movie.cd2.avi...)\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n","created_at":"2017-12-22T20:37:55Z","updated_at":"2017-12-23T10:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f6e83e206f6f955002bb1f5a6eff856a3558350","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13235/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13235/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/13235/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/7267d3ebd800e2aeddce38c818f4e39a4555e7bd","head":{"label":"Voyager1:stack-refactor-fixes","ref":"stack-refactor-fixes","sha":"7267d3ebd800e2aeddce38c818f4e39a4555e7bd","user":{"login":"Voyager1","id":549958,"avatar_url":"https://avatars1.githubusercontent.com/u/549958?v=4","gravatar_id":"","url":"https://api.github.com/users/Voyager1","html_url":"https://github.com/Voyager1","followers_url":"https://api.github.com/users/Voyager1/followers","following_url":"https://api.github.com/users/Voyager1/following{/other_user}","gists_url":"https://api.github.com/users/Voyager1/gists{/gist_id}","starred_url":"https://api.github.com/users/Voyager1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Voyager1/subscriptions","organizations_url":"https://api.github.com/users/Voyager1/orgs","repos_url":"https://api.github.com/users/Voyager1/repos","events_url":"https://api.github.com/users/Voyager1/events{/privacy}","received_events_url":"https://api.github.com/users/Voyager1/received_events","type":"User","site_admin":false},"repo":{"id":1225868,"name":"xbmc","full_name":"Voyager1/xbmc","owner":{"login":"Voyager1","id":549958,"avatar_url":"https://avatars1.githubusercontent.com/u/549958?v=4","gravatar_id":"","url":"https://api.github.com/users/Voyager1","html_url":"https://github.com/Voyager1","followers_url":"https://api.github.com/users/Voyager1/followers","following_url":"https://api.github.com/users/Voyager1/following{/other_user}","gists_url":"https://api.github.com/users/Voyager1/gists{/gist_id}","starred_url":"https://api.github.com/users/Voyager1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Voyager1/subscriptions","organizations_url":"https://api.github.com/users/Voyager1/orgs","repos_url":"https://api.github.com/users/Voyager1/repos","events_url":"https://api.github.com/users/Voyager1/events{/privacy}","received_events_url":"https://api.github.com/users/Voyager1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Voyager1/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Voyager1/xbmc","forks_url":"https://api.github.com/repos/Voyager1/xbmc/forks","keys_url":"https://api.github.com/repos/Voyager1/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Voyager1/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Voyager1/xbmc/teams","hooks_url":"https://api.github.com/repos/Voyager1/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Voyager1/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Voyager1/xbmc/events","assignees_url":"https://api.github.com/repos/Voyager1/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Voyager1/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Voyager1/xbmc/tags","blobs_url":"https://api.github.com/repos/Voyager1/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Voyager1/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Voyager1/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Voyager1/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Voyager1/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Voyager1/xbmc/languages","stargazers_url":"https://api.github.com/repos/Voyager1/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Voyager1/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Voyager1/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Voyager1/xbmc/subscription","commits_url":"https://api.github.com/repos/Voyager1/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Voyager1/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Voyager1/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Voyager1/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Voyager1/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Voyager1/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Voyager1/xbmc/merges","archive_url":"https://api.github.com/repos/Voyager1/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Voyager1/xbmc/downloads","issues_url":"https://api.github.com/repos/Voyager1/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Voyager1/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Voyager1/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Voyager1/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Voyager1/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Voyager1/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/Voyager1/xbmc/deployments","created_at":"2011-01-06T09:21:21Z","updated_at":"2014-11-23T19:49:58Z","pushed_at":"2017-12-22T20:25:38Z","git_url":"git://github.com/Voyager1/xbmc.git","ssh_url":"git@github.com:Voyager1/xbmc.git","clone_url":"https://github.com/Voyager1/xbmc.git","svn_url":"https://github.com/Voyager1/xbmc","homepage":"http://xbmc.org","size":587935,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"fb8cfe1310ab8b9f0998f819af3ed7c801470d88","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2017-12-23T08:43:35Z","pushed_at":"2017-12-23T09:44:03Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1438107,"stargazers_count":6561,"watchers_count":6561,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4441,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4441,"open_issues":149,"watchers":6561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13235"},"html":{"href":"https://github.com/xbmc/xbmc/pull/13235"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/13235"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/13235/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13235/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13235/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/7267d3ebd800e2aeddce38c818f4e39a4555e7bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"FernetMenta"}}