{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9659","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9659/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9659/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9659/events","html_url":"https://github.com/nodejs/node/pull/9659","id":190013408,"number":9659,"title":"cluster: fixing debug port logic for forking workers","user":{"login":"mutantcornholio","id":588262,"avatar_url":"https://avatars1.githubusercontent.com/u/588262?v=3","gravatar_id":"","url":"https://api.github.com/users/mutantcornholio","html_url":"https://github.com/mutantcornholio","followers_url":"https://api.github.com/users/mutantcornholio/followers","following_url":"https://api.github.com/users/mutantcornholio/following{/other_user}","gists_url":"https://api.github.com/users/mutantcornholio/gists{/gist_id}","starred_url":"https://api.github.com/users/mutantcornholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mutantcornholio/subscriptions","organizations_url":"https://api.github.com/users/mutantcornholio/orgs","repos_url":"https://api.github.com/users/mutantcornholio/repos","events_url":"https://api.github.com/users/mutantcornholio/events{/privacy}","received_events_url":"https://api.github.com/users/mutantcornholio/received_events","type":"User","site_admin":false},"labels":[{"id":155267477,"url":"https://api.github.com/repos/nodejs/node/labels/cluster","name":"cluster","color":"f7c6c7","default":false},{"id":463619724,"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v6.x","name":"lts-watch-v6.x","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":57,"created_at":"2016-11-17T11:00:27Z","updated_at":"2017-03-03T20:08:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9659","html_url":"https://github.com/nodejs/node/pull/9659","diff_url":"https://github.com/nodejs/node/pull/9659.diff","patch_url":"https://github.com/nodejs/node/pull/9659.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n* cluster\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nAn attempt to fix #8495 and #9435\r\n\r\nYou can set debug ports for workers in cluster with `cluster.settings.execArgv` hacking once again!\r\n\r\nThe problem is, at current version, debug port for workers calculated from master's `process.debugPort`, but a lot of software uses `cluster.settings` which is being ignored.\r\n\r\nAfter this changes, if you set a port in `cluster.settings.execArgv` and not starting master with debug, port offset would be added to port in `cluster.settings.execArgv`.\r\n\r\nDebug port autoincrement logic seems to be preserved.\r\n\r\nThe other issue is, debug argument format evolved and current regex does not cover all the cases that node accepts. Parsing it with one regex is too hard now, so I had to write some js to do it.\r\n\r\nAlso, current logic changes every debug argument, while changing only last one is sufficient."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/284057436","html_url":"https://github.com/nodejs/node/pull/9659#issuecomment-284057436","issue_url":"https://api.github.com/repos/nodejs/node/issues/9659","id":284057436,"user":{"login":"gibfahn","id":15943089,"avatar_url":"https://avatars3.githubusercontent.com/u/15943089?v=3","gravatar_id":"","url":"https://api.github.com/users/gibfahn","html_url":"https://github.com/gibfahn","followers_url":"https://api.github.com/users/gibfahn/followers","following_url":"https://api.github.com/users/gibfahn/following{/other_user}","gists_url":"https://api.github.com/users/gibfahn/gists{/gist_id}","starred_url":"https://api.github.com/users/gibfahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibfahn/subscriptions","organizations_url":"https://api.github.com/users/gibfahn/orgs","repos_url":"https://api.github.com/users/gibfahn/repos","events_url":"https://api.github.com/users/gibfahn/events{/privacy}","received_events_url":"https://api.github.com/users/gibfahn/received_events","type":"User","site_admin":false},"created_at":"2017-03-03T20:08:19Z","updated_at":"2017-03-03T20:08:19Z","body":"CI is green! Thanks for sticking with this @mutantcornholio "}}
{"actor":{"display_login":"gibfahn"}}