{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/143030752","pull_request_review_id":67482635,"id":143030752,"diff_hunk":"@@ -89,6 +91,13 @@ func (meta *DefaultAddOnMeta) GetValue(key string) string {\n \treturn meta.headers[key].(string)\n }\n \n+func (meta *DefaultAddOnMeta) OpenShiftVersion() string {\n+\tif val, contains := meta.headers[RequiredOpenShiftVersion].(string); contains {\n+\t\treturn val\n+\t}\n+\treturn \"\"","path":"pkg/minishift/addon/addon_meta.go","position":30,"original_position":30,"commit_id":"993416e84e2ffef6189f994817ae5379111bf354","original_commit_id":"993416e84e2ffef6189f994817ae5379111bf354","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"Should we allow empty sting to mean all? What if I just left it out by accident? Empty should maybe fail? Or ...\r\n\r\nDefault is all now?","created_at":"2017-10-05T19:11:23Z","updated_at":"2017-10-05T19:11:23Z","html_url":"https://github.com/minishift/minishift/pull/1487#discussion_r143030752","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/1487","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/143030752"},"html":{"href":"https://github.com/minishift/minishift/pull/1487#discussion_r143030752"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1487"}},"in_reply_to_id":142911702},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/1487","id":144635930,"html_url":"https://github.com/minishift/minishift/pull/1487","diff_url":"https://github.com/minishift/minishift/pull/1487.diff","patch_url":"https://github.com/minishift/minishift/pull/1487.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/1487","number":1487,"state":"open","locked":false,"title":"Issue #1134 Add a minimum Openshift version for executing add-ons","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-04T10:43:52Z","updated_at":"2017-10-05T19:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eed986a6998c074e28fa7ce2445aa5048fe7bf88","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/1487/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/1487/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/1487/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/993416e84e2ffef6189f994817ae5379111bf354","head":{"label":"praveenkumar:issue_1134","ref":"issue_1134","sha":"993416e84e2ffef6189f994817ae5379111bf354","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"repo":{"id":74443040,"name":"minishift","full_name":"praveenkumar/minishift","owner":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praveenkumar/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/praveenkumar/minishift","forks_url":"https://api.github.com/repos/praveenkumar/minishift/forks","keys_url":"https://api.github.com/repos/praveenkumar/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveenkumar/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveenkumar/minishift/teams","hooks_url":"https://api.github.com/repos/praveenkumar/minishift/hooks","issue_events_url":"https://api.github.com/repos/praveenkumar/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/praveenkumar/minishift/events","assignees_url":"https://api.github.com/repos/praveenkumar/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/praveenkumar/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/praveenkumar/minishift/tags","blobs_url":"https://api.github.com/repos/praveenkumar/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveenkumar/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveenkumar/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveenkumar/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveenkumar/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/praveenkumar/minishift/languages","stargazers_url":"https://api.github.com/repos/praveenkumar/minishift/stargazers","contributors_url":"https://api.github.com/repos/praveenkumar/minishift/contributors","subscribers_url":"https://api.github.com/repos/praveenkumar/minishift/subscribers","subscription_url":"https://api.github.com/repos/praveenkumar/minishift/subscription","commits_url":"https://api.github.com/repos/praveenkumar/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveenkumar/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveenkumar/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveenkumar/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveenkumar/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/praveenkumar/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveenkumar/minishift/merges","archive_url":"https://api.github.com/repos/praveenkumar/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveenkumar/minishift/downloads","issues_url":"https://api.github.com/repos/praveenkumar/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/praveenkumar/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/praveenkumar/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/praveenkumar/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveenkumar/minishift/labels{/name}","releases_url":"https://api.github.com/repos/praveenkumar/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/praveenkumar/minishift/deployments","created_at":"2016-11-22T06:46:12Z","updated_at":"2016-11-22T06:46:15Z","pushed_at":"2017-10-04T10:46:45Z","git_url":"git://github.com/praveenkumar/minishift.git","ssh_url":"git@github.com:praveenkumar/minishift.git","clone_url":"https://github.com/praveenkumar/minishift.git","svn_url":"https://github.com/praveenkumar/minishift","homepage":null,"size":157385,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"2b005fb7ad8a16b00d91b5174a66e8e041c26145","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-10-05T14:41:13Z","pushed_at":"2017-10-05T18:03:18Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":157342,"stargazers_count":657,"watchers_count":657,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":148,"mirror_url":null,"open_issues_count":202,"forks":148,"open_issues":202,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1487"},"html":{"href":"https://github.com/minishift/minishift/pull/1487"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/1487"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/1487/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1487/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1487/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/993416e84e2ffef6189f994817ae5379111bf354"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gbraad"}}