{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/desktop/issues/609","repository_url":"https://api.github.com/repos/mattermost/desktop","labels_url":"https://api.github.com/repos/mattermost/desktop/issues/609/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/desktop/issues/609/comments","events_url":"https://api.github.com/repos/mattermost/desktop/issues/609/events","html_url":"https://github.com/mattermost/desktop/pull/609","id":262832774,"number":609,"title":"WIP: Permission request handler","user":{"login":"yuya-oc","id":1412057,"avatar_url":"https://avatars0.githubusercontent.com/u/1412057?v=4","gravatar_id":"","url":"https://api.github.com/users/yuya-oc","html_url":"https://github.com/yuya-oc","followers_url":"https://api.github.com/users/yuya-oc/followers","following_url":"https://api.github.com/users/yuya-oc/following{/other_user}","gists_url":"https://api.github.com/users/yuya-oc/gists{/gist_id}","starred_url":"https://api.github.com/users/yuya-oc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuya-oc/subscriptions","organizations_url":"https://api.github.com/users/yuya-oc/orgs","repos_url":"https://api.github.com/users/yuya-oc/repos","events_url":"https://api.github.com/users/yuya-oc/events{/privacy}","received_events_url":"https://api.github.com/users/yuya-oc/received_events","type":"User","site_admin":false},"labels":[{"id":357466498,"url":"https://api.github.com/repos/mattermost/desktop/labels/All%20Platforms","name":"All Platforms","color":"006b75","default":false},{"id":412495992,"url":"https://api.github.com/repos/mattermost/desktop/labels/Windows%20(looking%20for%20testers)","name":"Windows (looking for testers)","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mattermost/desktop/milestones/7","html_url":"https://github.com/mattermost/desktop/milestone/7","labels_url":"https://api.github.com/repos/mattermost/desktop/milestones/7/labels","id":2404553,"number":7,"title":"v3.8.0","description":"","creator":{"login":"jasonblais","id":13119842,"avatar_url":"https://avatars1.githubusercontent.com/u/13119842?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonblais","html_url":"https://github.com/jasonblais","followers_url":"https://api.github.com/users/jasonblais/followers","following_url":"https://api.github.com/users/jasonblais/following{/other_user}","gists_url":"https://api.github.com/users/jasonblais/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonblais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonblais/subscriptions","organizations_url":"https://api.github.com/users/jasonblais/orgs","repos_url":"https://api.github.com/users/jasonblais/repos","events_url":"https://api.github.com/users/jasonblais/events{/privacy}","received_events_url":"https://api.github.com/users/jasonblais/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":59,"state":"open","created_at":"2017-03-22T15:57:18Z","updated_at":"2017-10-31T17:43:21Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2017-10-04T15:33:49Z","updated_at":"2017-11-01T16:19:31Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mattermost/desktop/pulls/609","html_url":"https://github.com/mattermost/desktop/pull/609","diff_url":"https://github.com/mattermost/desktop/pull/609.diff","patch_url":"https://github.com/mattermost/desktop/pull/609.patch"},"body":"Before submitting, please confirm you've\r\n - [x] read and understood our [Contributing Guidelines](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md)\r\n - [x] completed [Mattermost Contributor Agreement](http://www.mattermost.org/mattermost-contributor-agreement/)\r\n - [x] executed `npm run lint:js` for proper code formatting\r\n\r\nPlease provide the following information:\r\n\r\n**Summary**\r\nUse `session.setPermissionRequestHandler()` to confirm permissions when they're requested.\r\n\r\nResults of the dialog are saved to `AppData\\Roaming\\Mattermost\\permissions.json`.\r\nThis implementation is naive. The dialog pause the application until selecting a choice.\r\n\r\n**Issue link**\r\nhttps://mattermost.atlassian.net/browse/PLT-7458\r\n\r\n**Test Cases**\r\n1. Receive any messages in a channel.\r\n2. A dialog should appear to confirm Allow/Deny/Skip the 'notifications' permission.\r\n3. A desktop notification should appear after clicking 'Allow'.\r\n\r\n**Additional Notes**\r\nhttps://circleci.com/gh/yuya-oc/desktop/411#artifacts"},"comment":{"url":"https://api.github.com/repos/mattermost/desktop/issues/comments/341156697","html_url":"https://github.com/mattermost/desktop/pull/609#issuecomment-341156697","issue_url":"https://api.github.com/repos/mattermost/desktop/issues/609","id":341156697,"user":{"login":"yuya-oc","id":1412057,"avatar_url":"https://avatars0.githubusercontent.com/u/1412057?v=4","gravatar_id":"","url":"https://api.github.com/users/yuya-oc","html_url":"https://github.com/yuya-oc","followers_url":"https://api.github.com/users/yuya-oc/followers","following_url":"https://api.github.com/users/yuya-oc/following{/other_user}","gists_url":"https://api.github.com/users/yuya-oc/gists{/gist_id}","starred_url":"https://api.github.com/users/yuya-oc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuya-oc/subscriptions","organizations_url":"https://api.github.com/users/yuya-oc/orgs","repos_url":"https://api.github.com/users/yuya-oc/repos","events_url":"https://api.github.com/users/yuya-oc/events{/privacy}","received_events_url":"https://api.github.com/users/yuya-oc/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T16:19:31Z","updated_at":"2017-11-01T16:19:31Z","author_association":"COLLABORATOR","body":"I feel it's difficult to describe enough in sentences... It's surely complex because two asynchronous things work together, so I need to manage the state in each processes. But the flow is almost similar in both cases.\r\n\r\nHowever, I need to implement the dialog itself in addition to logical flow."}}
{"actor":{"display_login":"yuya-oc"}}