{"action":"created","comment":{"url":"https://api.github.com/repos/web3j/web3j/pulls/comments/100454504","pull_request_review_id":21162704,"id":100454504,"diff_hunk":"@@ -0,0 +1,127 @@\n+package org.web3j.tx;\n+\n+import org.web3j.crypto.Credentials;\n+import org.web3j.protocol.Web3j;\n+import org.web3j.protocol.core.DefaultBlockParameterName;\n+import org.web3j.protocol.core.methods.request.RawTransaction;\n+import org.web3j.protocol.core.methods.response.EthBlock;\n+import org.web3j.protocol.core.methods.response.EthSendTransaction;\n+import org.web3j.protocol.core.methods.response.TransactionReceipt;\n+import rx.Subscription;\n+\n+import java.io.IOException;\n+import java.math.BigInteger;\n+import java.util.HashMap;\n+import java.util.concurrent.ExecutionException;\n+\n+/**\n+ * High Throughput transaction manager.\n+ */\n+\n+public class HighThroughputTransactionManager extends RawTransactionManager {","path":"src/main/java/org/web3j/tx/HighThroughputTransactionManager.java","position":21,"original_position":21,"commit_id":"eeb354e5ee176bb6cbb828144f3907448f5dcdd5","original_commit_id":"eeb354e5ee176bb6cbb828144f3907448f5dcdd5","user":{"login":"conor10","id":2148266,"avatar_url":"https://avatars.githubusercontent.com/u/2148266?v=3","gravatar_id":"","url":"https://api.github.com/users/conor10","html_url":"https://github.com/conor10","followers_url":"https://api.github.com/users/conor10/followers","following_url":"https://api.github.com/users/conor10/following{/other_user}","gists_url":"https://api.github.com/users/conor10/gists{/gist_id}","starred_url":"https://api.github.com/users/conor10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conor10/subscriptions","organizations_url":"https://api.github.com/users/conor10/orgs","repos_url":"https://api.github.com/users/conor10/repos","events_url":"https://api.github.com/users/conor10/events{/privacy}","received_events_url":"https://api.github.com/users/conor10/received_events","type":"User","site_admin":false},"body":"Please could you include an integration tests that demonstrates how to use this class - I'm still not completely clear on the advantages of this approach. An integration test will help clarify.\r\n\r\nSee https://github.com/web3j/web3j/blob/master/src/integration-test/java/org/web3j/protocol/scenarios/FastRawTransactionManagerIT.java for an example.","created_at":"2017-02-10T01:25:10Z","updated_at":"2017-02-10T01:36:54Z","html_url":"https://github.com/web3j/web3j/pull/56#discussion_r100454504","pull_request_url":"https://api.github.com/repos/web3j/web3j/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/web3j/web3j/pulls/comments/100454504"},"html":{"href":"https://github.com/web3j/web3j/pull/56#discussion_r100454504"},"pull_request":{"href":"https://api.github.com/repos/web3j/web3j/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/web3j/web3j/pulls/56","id":105527718,"html_url":"https://github.com/web3j/web3j/pull/56","diff_url":"https://github.com/web3j/web3j/pull/56.diff","patch_url":"https://github.com/web3j/web3j/pull/56.patch","issue_url":"https://api.github.com/repos/web3j/web3j/issues/56","number":56,"state":"open","locked":false,"title":"High throughput ","user":{"login":"ferOnti","id":1680171,"avatar_url":"https://avatars.githubusercontent.com/u/1680171?v=3","gravatar_id":"","url":"https://api.github.com/users/ferOnti","html_url":"https://github.com/ferOnti","followers_url":"https://api.github.com/users/ferOnti/followers","following_url":"https://api.github.com/users/ferOnti/following{/other_user}","gists_url":"https://api.github.com/users/ferOnti/gists{/gist_id}","starred_url":"https://api.github.com/users/ferOnti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferOnti/subscriptions","organizations_url":"https://api.github.com/users/ferOnti/orgs","repos_url":"https://api.github.com/users/ferOnti/repos","events_url":"https://api.github.com/users/ferOnti/events{/privacy}","received_events_url":"https://api.github.com/users/ferOnti/received_events","type":"User","site_admin":false},"body":"this is the second commit with changes for the HQTransactionManager.\r\n\r\nExample:\r\n\r\n\t\t//create an instance of your smart contract wrapper\r\n\t\tMySmartContract contract;\r\n\r\n            //use the loadHT function instead the load \r\n\t\tcontract = MyContract.loadHT(contractAddress, web3, credentials, gasPrice, gasLimit);\r\n\t       \r\n             //call the transaction  \r\n         \tFuture<TransactionReceipt> futureReceipt = contract.myfunction(param1, param2);\r\n\r\n            //get the TransactionHash from the TransactionReceipt\r\n\t\tTransactionReceipt tr = futureReceipt.get();\r\n\t\ttransactionHash = tr.getTransactionHash();\r\n    \r\n             //the function futureReceipt.get is returning an incomplete receipt with only the transaction hash\r\n            // Clients should take care of this transaction hash\r\n            //  because the polling is disabled for  HQTransactionManager\r\n\t\t","created_at":"2017-02-09T22:30:57Z","updated_at":"2017-02-10T01:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a7a987fd7825525fa9790c8b0864f94d3da68cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/web3j/web3j/pulls/56/commits","review_comments_url":"https://api.github.com/repos/web3j/web3j/pulls/56/comments","review_comment_url":"https://api.github.com/repos/web3j/web3j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/web3j/web3j/issues/56/comments","statuses_url":"https://api.github.com/repos/web3j/web3j/statuses/eeb354e5ee176bb6cbb828144f3907448f5dcdd5","head":{"label":"ferOnti:HighThroughput","ref":"HighThroughput","sha":"eeb354e5ee176bb6cbb828144f3907448f5dcdd5","user":{"login":"ferOnti","id":1680171,"avatar_url":"https://avatars.githubusercontent.com/u/1680171?v=3","gravatar_id":"","url":"https://api.github.com/users/ferOnti","html_url":"https://github.com/ferOnti","followers_url":"https://api.github.com/users/ferOnti/followers","following_url":"https://api.github.com/users/ferOnti/following{/other_user}","gists_url":"https://api.github.com/users/ferOnti/gists{/gist_id}","starred_url":"https://api.github.com/users/ferOnti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferOnti/subscriptions","organizations_url":"https://api.github.com/users/ferOnti/orgs","repos_url":"https://api.github.com/users/ferOnti/repos","events_url":"https://api.github.com/users/ferOnti/events{/privacy}","received_events_url":"https://api.github.com/users/ferOnti/received_events","type":"User","site_admin":false},"repo":{"id":80449739,"name":"web3j","full_name":"ferOnti/web3j","owner":{"login":"ferOnti","id":1680171,"avatar_url":"https://avatars.githubusercontent.com/u/1680171?v=3","gravatar_id":"","url":"https://api.github.com/users/ferOnti","html_url":"https://github.com/ferOnti","followers_url":"https://api.github.com/users/ferOnti/followers","following_url":"https://api.github.com/users/ferOnti/following{/other_user}","gists_url":"https://api.github.com/users/ferOnti/gists{/gist_id}","starred_url":"https://api.github.com/users/ferOnti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferOnti/subscriptions","organizations_url":"https://api.github.com/users/ferOnti/orgs","repos_url":"https://api.github.com/users/ferOnti/repos","events_url":"https://api.github.com/users/ferOnti/events{/privacy}","received_events_url":"https://api.github.com/users/ferOnti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferOnti/web3j","description":"Lightweight Java library for integration with Ethereum clients","fork":true,"url":"https://api.github.com/repos/ferOnti/web3j","forks_url":"https://api.github.com/repos/ferOnti/web3j/forks","keys_url":"https://api.github.com/repos/ferOnti/web3j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferOnti/web3j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferOnti/web3j/teams","hooks_url":"https://api.github.com/repos/ferOnti/web3j/hooks","issue_events_url":"https://api.github.com/repos/ferOnti/web3j/issues/events{/number}","events_url":"https://api.github.com/repos/ferOnti/web3j/events","assignees_url":"https://api.github.com/repos/ferOnti/web3j/assignees{/user}","branches_url":"https://api.github.com/repos/ferOnti/web3j/branches{/branch}","tags_url":"https://api.github.com/repos/ferOnti/web3j/tags","blobs_url":"https://api.github.com/repos/ferOnti/web3j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferOnti/web3j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferOnti/web3j/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferOnti/web3j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferOnti/web3j/statuses/{sha}","languages_url":"https://api.github.com/repos/ferOnti/web3j/languages","stargazers_url":"https://api.github.com/repos/ferOnti/web3j/stargazers","contributors_url":"https://api.github.com/repos/ferOnti/web3j/contributors","subscribers_url":"https://api.github.com/repos/ferOnti/web3j/subscribers","subscription_url":"https://api.github.com/repos/ferOnti/web3j/subscription","commits_url":"https://api.github.com/repos/ferOnti/web3j/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferOnti/web3j/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferOnti/web3j/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferOnti/web3j/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferOnti/web3j/contents/{+path}","compare_url":"https://api.github.com/repos/ferOnti/web3j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferOnti/web3j/merges","archive_url":"https://api.github.com/repos/ferOnti/web3j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferOnti/web3j/downloads","issues_url":"https://api.github.com/repos/ferOnti/web3j/issues{/number}","pulls_url":"https://api.github.com/repos/ferOnti/web3j/pulls{/number}","milestones_url":"https://api.github.com/repos/ferOnti/web3j/milestones{/number}","notifications_url":"https://api.github.com/repos/ferOnti/web3j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferOnti/web3j/labels{/name}","releases_url":"https://api.github.com/repos/ferOnti/web3j/releases{/id}","deployments_url":"https://api.github.com/repos/ferOnti/web3j/deployments","created_at":"2017-01-30T18:24:19Z","updated_at":"2017-01-30T18:24:22Z","pushed_at":"2017-02-09T22:53:03Z","git_url":"git://github.com/ferOnti/web3j.git","ssh_url":"git@github.com:ferOnti/web3j.git","clone_url":"https://github.com/ferOnti/web3j.git","svn_url":"https://github.com/ferOnti/web3j","homepage":"http://docs.web3j.io/","size":2962,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"web3j:master","ref":"master","sha":"6046938af824b632446f70284c128cf990d34a83","user":{"login":"web3j","id":22208471,"avatar_url":"https://avatars.githubusercontent.com/u/22208471?v=3","gravatar_id":"","url":"https://api.github.com/users/web3j","html_url":"https://github.com/web3j","followers_url":"https://api.github.com/users/web3j/followers","following_url":"https://api.github.com/users/web3j/following{/other_user}","gists_url":"https://api.github.com/users/web3j/gists{/gist_id}","starred_url":"https://api.github.com/users/web3j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web3j/subscriptions","organizations_url":"https://api.github.com/users/web3j/orgs","repos_url":"https://api.github.com/users/web3j/repos","events_url":"https://api.github.com/users/web3j/events{/privacy}","received_events_url":"https://api.github.com/users/web3j/received_events","type":"Organization","site_admin":false},"repo":{"id":67328052,"name":"web3j","full_name":"web3j/web3j","owner":{"login":"web3j","id":22208471,"avatar_url":"https://avatars.githubusercontent.com/u/22208471?v=3","gravatar_id":"","url":"https://api.github.com/users/web3j","html_url":"https://github.com/web3j","followers_url":"https://api.github.com/users/web3j/followers","following_url":"https://api.github.com/users/web3j/following{/other_user}","gists_url":"https://api.github.com/users/web3j/gists{/gist_id}","starred_url":"https://api.github.com/users/web3j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web3j/subscriptions","organizations_url":"https://api.github.com/users/web3j/orgs","repos_url":"https://api.github.com/users/web3j/repos","events_url":"https://api.github.com/users/web3j/events{/privacy}","received_events_url":"https://api.github.com/users/web3j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/web3j/web3j","description":"Lightweight Java library for integration with Ethereum clients","fork":false,"url":"https://api.github.com/repos/web3j/web3j","forks_url":"https://api.github.com/repos/web3j/web3j/forks","keys_url":"https://api.github.com/repos/web3j/web3j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web3j/web3j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web3j/web3j/teams","hooks_url":"https://api.github.com/repos/web3j/web3j/hooks","issue_events_url":"https://api.github.com/repos/web3j/web3j/issues/events{/number}","events_url":"https://api.github.com/repos/web3j/web3j/events","assignees_url":"https://api.github.com/repos/web3j/web3j/assignees{/user}","branches_url":"https://api.github.com/repos/web3j/web3j/branches{/branch}","tags_url":"https://api.github.com/repos/web3j/web3j/tags","blobs_url":"https://api.github.com/repos/web3j/web3j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web3j/web3j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web3j/web3j/git/refs{/sha}","trees_url":"https://api.github.com/repos/web3j/web3j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web3j/web3j/statuses/{sha}","languages_url":"https://api.github.com/repos/web3j/web3j/languages","stargazers_url":"https://api.github.com/repos/web3j/web3j/stargazers","contributors_url":"https://api.github.com/repos/web3j/web3j/contributors","subscribers_url":"https://api.github.com/repos/web3j/web3j/subscribers","subscription_url":"https://api.github.com/repos/web3j/web3j/subscription","commits_url":"https://api.github.com/repos/web3j/web3j/commits{/sha}","git_commits_url":"https://api.github.com/repos/web3j/web3j/git/commits{/sha}","comments_url":"https://api.github.com/repos/web3j/web3j/comments{/number}","issue_comment_url":"https://api.github.com/repos/web3j/web3j/issues/comments{/number}","contents_url":"https://api.github.com/repos/web3j/web3j/contents/{+path}","compare_url":"https://api.github.com/repos/web3j/web3j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web3j/web3j/merges","archive_url":"https://api.github.com/repos/web3j/web3j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web3j/web3j/downloads","issues_url":"https://api.github.com/repos/web3j/web3j/issues{/number}","pulls_url":"https://api.github.com/repos/web3j/web3j/pulls{/number}","milestones_url":"https://api.github.com/repos/web3j/web3j/milestones{/number}","notifications_url":"https://api.github.com/repos/web3j/web3j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web3j/web3j/labels{/name}","releases_url":"https://api.github.com/repos/web3j/web3j/releases{/id}","deployments_url":"https://api.github.com/repos/web3j/web3j/deployments","created_at":"2016-09-04T05:48:49Z","updated_at":"2017-02-08T01:05:07Z","pushed_at":"2017-02-09T22:54:15Z","git_url":"git://github.com/web3j/web3j.git","ssh_url":"git@github.com:web3j/web3j.git","clone_url":"https://github.com/web3j/web3j.git","svn_url":"https://github.com/web3j/web3j","homepage":"http://www.web3j.io/","size":2972,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":6,"forks":32,"open_issues":6,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/web3j/web3j/pulls/56"},"html":{"href":"https://github.com/web3j/web3j/pull/56"},"issue":{"href":"https://api.github.com/repos/web3j/web3j/issues/56"},"comments":{"href":"https://api.github.com/repos/web3j/web3j/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/web3j/web3j/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/web3j/web3j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/web3j/web3j/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/web3j/web3j/statuses/eeb354e5ee176bb6cbb828144f3907448f5dcdd5"}}}}
{"actor":{"display_login":"conor10"}}