{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/client/issues/542","repository_url":"https://api.github.com/repos/hypothesis/client","labels_url":"https://api.github.com/repos/hypothesis/client/issues/542/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/client/issues/542/comments","events_url":"https://api.github.com/repos/hypothesis/client/issues/542/events","html_url":"https://github.com/hypothesis/client/pull/542","id":257184038,"number":542,"title":"Remove cookie auth related code","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"labels":[{"id":665736439,"url":"https://api.github.com/repos/hypothesis/client/labels/Project:%20OAuth","name":"Project: OAuth","color":"d4c5f9","default":false},{"id":400865234,"url":"https://api.github.com/repos/hypothesis/client/labels/WIP","name":"WIP","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-12T21:11:44Z","updated_at":"2017-09-12T21:39:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hypothesis/client/pulls/542","html_url":"https://github.com/hypothesis/client/pull/542","diff_url":"https://github.com/hypothesis/client/pull/542.diff","patch_url":"https://github.com/hypothesis/client/pull/542.patch"},"body":"**Not for merge until OAuth ships 🛳**\r\n\r\nThis PR removes all the code from the client that supported cookie-based authentication and the inline login forms. This includes:\r\n\r\n- The \"auth\" service which handled cookie-based auth\r\n- The code in the \"session\" service which handled login & logout actions via the inline forms\r\n- The login form UI component\r\n- References to CSRF tokens which are no longer used\r\n- Login in the startup code to switch between the cookie auth and OAuth auth services\r\n- angular-resource and angular-jwt dependencies which are unused after the removal of the above code\r\n\r\nI'm happy to split batches of commits out into smaller PRs if the reviewer prefers, although I think it is useful to be able to test everything together."},"comment":{"url":"https://api.github.com/repos/hypothesis/client/issues/comments/328992207","html_url":"https://github.com/hypothesis/client/pull/542#issuecomment-328992207","issue_url":"https://api.github.com/repos/hypothesis/client/issues/542","id":328992207,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-09-12T21:39:48Z","updated_at":"2017-09-12T21:39:48Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=h1) Report\n> Merging [#542](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=desc) into [master](https://codecov.io/gh/hypothesis/client/commit/7ad423709174f00616a995908665b8e652681e54?src=pr&el=desc) will **decrease** coverage by `0.18%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/hypothesis/client/pull/542/graphs/tree.svg?token=vmxENZg3T1&width=650&height=150&src=pr)](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #542      +/-   ##\n==========================================\n- Coverage   90.93%   90.74%   -0.19%     \n==========================================\n  Files         136      134       -2     \n  Lines        5428     5317     -111     \n  Branches      946      927      -19     \n==========================================\n- Hits         4936     4825     -111     \n  Misses        492      492\n```\n\n\n| [Impacted Files](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/sidebar/reducers/session.js](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree#diff-c3JjL3NpZGViYXIvcmVkdWNlcnMvc2Vzc2lvbi5qcw==) | `100% <ø> (ø)` | :arrow_up: |\n| [src/sidebar/session.js](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree#diff-c3JjL3NpZGViYXIvc2Vzc2lvbi5qcw==) | `90.9% <100%> (-6.03%)` | :arrow_down: |\n| [src/sidebar/components/hypothesis-app.js](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree#diff-c3JjL3NpZGViYXIvY29tcG9uZW50cy9oeXBvdGhlc2lzLWFwcC5qcw==) | `90.24% <100%> (-2.07%)` | :arrow_down: |\n| [src/sidebar/oauth-auth.js](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=tree#diff-c3JjL3NpZGViYXIvb2F1dGgtYXV0aC5qcw==) | `98.42% <100%> (-0.03%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=footer). Last update [7ad4237...e622e4e](https://codecov.io/gh/hypothesis/client/pull/542?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}