{"push_id":1923263590,"size":11,"distinct_size":4,"ref":"refs/heads/master","head":"3b5c2baa2ef8d01706c92524e5132774c4994df4","before":"f4d376d7af6878a3ca90c68d52fda9934b11d0c1","commits":[{"sha":"05bdf3b7410616ff7859f8476892a7e5e000fe53","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"mempool: Remove potential negative locktime check.\n\nThis removes the standardness check to reject transactions with a lock\ntime greater than a maxint32 because the old bitcoind nodes which it was\ndesigned to protect against are no longer valid for other reasons and\nthus there are no longer any of them on the network to worry about.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/05bdf3b7410616ff7859f8476892a7e5e000fe53"},{"sha":"bc36cf51c6aec42ddbfc4585107a87ca26ba9815","author":{"name":"Jim Posen","email":"78b9638846a13071a1cababb7f8af279aa766f88@gmail.com"},"message":"peer: Don't send unsupported reject to old peers.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/bc36cf51c6aec42ddbfc4585107a87ca26ba9815"},{"sha":"19b42c3c9b8f0b14c9e2b1638a39bda1a64fb46e","author":{"name":"Jim Posen","email":"8f65197955cd845267558e09f2097486a99c7145@coinbase.com"},"message":"Allow multiple subscribers to blockchain notifications.\n\nThe BlockChain struct emits notifications for various events, but\nit is only possible to register one listener. This changes the\ninterface and implementations to allow multiple listeners.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/19b42c3c9b8f0b14c9e2b1638a39bda1a64fb46e"},{"sha":"22de1f6d080bd5eda656f3b5993ce121c899d69e","author":{"name":"Jim Posen","email":"8f65197955cd845267558e09f2097486a99c7145@coinbase.com"},"message":"Create blockmanager with reference to txMemPool.\n\nThe objective is to remove the reference from blockManager to\nserver. Since the blockManager is responsible for keeping the mempool\nin sync, it should have a direct reference to it.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/22de1f6d080bd5eda656f3b5993ce121c899d69e"},{"sha":"49949d4c96159b0b8dc6f8928c50d4a03921cf95","author":{"name":"Jim Posen","email":"8f65197955cd845267558e09f2097486a99c7145@coinbase.com"},"message":"Remove references from blockManager to rpcServer.\n\nInstead of having the block manager notify the RPC server about\naccepted, connected, and disconnected blocks, the RPC server will\ndirectly listen for notifications from the blockchain.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/49949d4c96159b0b8dc6f8928c50d4a03921cf95"},{"sha":"b71d6c30103ce9ad04c4c610f288eb0ad1c2afb7","author":{"name":"Jim Posen","email":"8f65197955cd845267558e09f2097486a99c7145@coinbase.com"},"message":"Create blockManagerConfig struct passed to newBlockManager.\n\nThe config struct accepts an instance of server as an implementation\nof the new PeerNotifier wrapping interface.","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/b71d6c30103ce9ad04c4c610f288eb0ad1c2afb7"},{"sha":"ca9baf77ec548f65f2fee6070251dbefa37abdf3","author":{"name":"Jim Posen","email":"78b9638846a13071a1cababb7f8af279aa766f88@gmail.com"},"message":"blockchain: Fix race condition in notifications_test","distinct":false,"url":"https://api.github.com/repos/jimpo/btcd/commits/ca9baf77ec548f65f2fee6070251dbefa37abdf3"},{"sha":"a7a10294455540b8f68a632feda6de6312aec858","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"rpcserver: Decouple from server.\n\nThis decouples the RPC server from the internal btcd server to move\ncloser to being able to split it out into a separate package.\n\nIn order to accomplish this, it introduces an rpcserverConfig type and\nseveral new interfaces, named rpcserverPeer, rpcserverConnManager, and\nrpcserverBlockManager, which are necessary to break the direct\ndependencies on the main server and block manager instances.\n\nIt also adds concrete implementations of the new interfaces and uses\nthem to configure the RPC server.\n\nUltimately, the RPC server should ideally be decoupled even more such\nthat all of the types in the configuration struct use interfaces instead\nof the concrete types.  Doing this would make the RPC server much easier\nto internally test since it would allow creating lightweight stubs for\nthe various pieces.","distinct":true,"url":"https://api.github.com/repos/jimpo/btcd/commits/a7a10294455540b8f68a632feda6de6312aec858"},{"sha":"ff700325acd7fe502f74bb4d9d4b957afbe0aec0","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"rpcserver: Don't use activeNetParams.\n\nThis modifies all of the RPC code to use the chain parameters that are\nassociated with the RPC server instead of the global activeNetParams and\nthus moves one step closer to being able to split the RPC server out\ninto a separate package.","distinct":true,"url":"https://api.github.com/repos/jimpo/btcd/commits/ff700325acd7fe502f74bb4d9d4b957afbe0aec0"},{"sha":"c5c46376ba4f36842dbb6def625456a3aba27f2a","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"rpcserver: Refactor listener logic to server.\n\nThis refactors the RPC server to accept and take ownership of already\nconfigured listeners and refactors the logic to setup those listeners to\nthe server.  This mirrors the logic used by the connection manager and\nis desirable since it is another step closer to being able to split the\nRPC server code out into a separate package and will make it much easier\nto internally test since it allows creating mock listeners.","distinct":true,"url":"https://api.github.com/repos/jimpo/btcd/commits/c5c46376ba4f36842dbb6def625456a3aba27f2a"},{"sha":"3b5c2baa2ef8d01706c92524e5132774c4994df4","author":{"name":"Dave Collins","email":"4b5cc8591e1af5b3606cf32bb53d8e0bf0bb626a@conformal.com"},"message":"blockchain: Consistency pass on subscribe code.\n\nThis takes care of a few minor nits on the recently merged subscribe\ncode.  In particular:\n\n- Avoid extra unnecessary allocation on notifications slice\n- Avoid defer overhead on notification mutex in sendNotifications\n- Make test function comment start with the name of the function per\n  Effective Go guidelines\n- Use constant for number of subscribers in test\n- Don't exceed column 80 in test print","distinct":true,"url":"https://api.github.com/repos/jimpo/btcd/commits/3b5c2baa2ef8d01706c92524e5132774c4994df4"}]}
{"actor":{"display_login":"jimpo"}}