{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/110299671","pull_request_review_id":31463551,"id":110299671,"diff_hunk":"@@ -39,7 +39,7 @@ declare module 'react-router' {\n \n \n   interface PromptProps {\n-    message: string | ((location: H.Location) => void);\n+    message: string | ((location: H.LocationDescriptor) => void);\n     when?: boolean;","path":"types/react-router/index.d.ts","position":22,"original_position":28,"commit_id":"f9828c05f29eb08b3bf466585cbe9ec91310ea05","original_commit_id":"fbfc7228de60807e0034de48ed0bf953b9a56ed2","user":{"login":"huy-nguyen","id":7352279,"avatar_url":"https://avatars2.githubusercontent.com/u/7352279?v=3","gravatar_id":"","url":"https://api.github.com/users/huy-nguyen","html_url":"https://github.com/huy-nguyen","followers_url":"https://api.github.com/users/huy-nguyen/followers","following_url":"https://api.github.com/users/huy-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/huy-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/huy-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huy-nguyen/subscriptions","organizations_url":"https://api.github.com/users/huy-nguyen/orgs","repos_url":"https://api.github.com/users/huy-nguyen/repos","events_url":"https://api.github.com/users/huy-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/huy-nguyen/received_events","type":"User","site_admin":false},"body":"This change is probably also not correct because according to the [documentation](https://reacttraining.com/react-router/core/api/Prompt/message-func), if `message` is a function, it \r\n\r\n> Will be called with the next location and action the user is attempting to navigate to. Return a string to show a prompt to the user or true to allow the transition.\r\n\r\nBecause of the library's internal consistency, most likely the `location` passed to `message` will be a complete `H.Location` object instead of `H.LocationDescriptor`.","created_at":"2017-04-07T01:07:09Z","updated_at":"2017-04-07T01:27:35Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680#discussion_r110299671","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/110299671"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680#discussion_r110299671"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680","id":114548426,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/15680","number":15680,"state":"open","locked":false,"title":"fix(react-router): change Location to LocationDescriptor","user":{"login":"elmariofredo","id":82104,"avatar_url":"https://avatars0.githubusercontent.com/u/82104?v=3","gravatar_id":"","url":"https://api.github.com/users/elmariofredo","html_url":"https://github.com/elmariofredo","followers_url":"https://api.github.com/users/elmariofredo/followers","following_url":"https://api.github.com/users/elmariofredo/following{/other_user}","gists_url":"https://api.github.com/users/elmariofredo/gists{/gist_id}","starred_url":"https://api.github.com/users/elmariofredo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmariofredo/subscriptions","organizations_url":"https://api.github.com/users/elmariofredo/orgs","repos_url":"https://api.github.com/users/elmariofredo/repos","events_url":"https://api.github.com/users/elmariofredo/events{/privacy}","received_events_url":"https://api.github.com/users/elmariofredo/received_events","type":"User","site_admin":false},"body":"Currently we can't put Path(string) nor partial Location. \r\nLocationDescriptor instead of Location should do the job.\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/history/index.d.ts#L43\r\n- [x] Increase the version number in the header if appropriate.\r\n","created_at":"2017-04-06T08:40:28Z","updated_at":"2017-04-07T01:27:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6815521027abf86519e44b537ce8857056809c3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/15680/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f9828c05f29eb08b3bf466585cbe9ec91310ea05","head":{"label":"elmariofredo:patch-1","ref":"patch-1","sha":"f9828c05f29eb08b3bf466585cbe9ec91310ea05","user":{"login":"elmariofredo","id":82104,"avatar_url":"https://avatars0.githubusercontent.com/u/82104?v=3","gravatar_id":"","url":"https://api.github.com/users/elmariofredo","html_url":"https://github.com/elmariofredo","followers_url":"https://api.github.com/users/elmariofredo/followers","following_url":"https://api.github.com/users/elmariofredo/following{/other_user}","gists_url":"https://api.github.com/users/elmariofredo/gists{/gist_id}","starred_url":"https://api.github.com/users/elmariofredo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmariofredo/subscriptions","organizations_url":"https://api.github.com/users/elmariofredo/orgs","repos_url":"https://api.github.com/users/elmariofredo/repos","events_url":"https://api.github.com/users/elmariofredo/events{/privacy}","received_events_url":"https://api.github.com/users/elmariofredo/received_events","type":"User","site_admin":false},"repo":{"id":87404359,"name":"DefinitelyTyped","full_name":"elmariofredo/DefinitelyTyped","owner":{"login":"elmariofredo","id":82104,"avatar_url":"https://avatars0.githubusercontent.com/u/82104?v=3","gravatar_id":"","url":"https://api.github.com/users/elmariofredo","html_url":"https://github.com/elmariofredo","followers_url":"https://api.github.com/users/elmariofredo/followers","following_url":"https://api.github.com/users/elmariofredo/following{/other_user}","gists_url":"https://api.github.com/users/elmariofredo/gists{/gist_id}","starred_url":"https://api.github.com/users/elmariofredo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmariofredo/subscriptions","organizations_url":"https://api.github.com/users/elmariofredo/orgs","repos_url":"https://api.github.com/users/elmariofredo/repos","events_url":"https://api.github.com/users/elmariofredo/events{/privacy}","received_events_url":"https://api.github.com/users/elmariofredo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmariofredo/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped","forks_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/elmariofredo/DefinitelyTyped/deployments","created_at":"2017-04-06T08:18:10Z","updated_at":"2017-04-06T08:18:25Z","pushed_at":"2017-04-07T01:02:48Z","git_url":"git://github.com/elmariofredo/DefinitelyTyped.git","ssh_url":"git@github.com:elmariofredo/DefinitelyTyped.git","clone_url":"https://github.com/elmariofredo/DefinitelyTyped.git","svn_url":"https://github.com/elmariofredo/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":194392,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"e2f264c1b3439adf9d3cba7b5538588b002bbb2a","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars2.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars2.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-04-07T00:55:59Z","pushed_at":"2017-04-07T01:02:51Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":194671,"stargazers_count":10259,"watchers_count":10259,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8405,"mirror_url":null,"open_issues_count":1410,"forks":8405,"open_issues":1410,"watchers":10259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15680"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/15680"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/15680/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/15680/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f9828c05f29eb08b3bf466585cbe9ec91310ea05"}}}}
{"actor":{"display_login":"huy-nguyen"}}