{"action":"closed","number":406,"pull_request":{"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406","id":109328502,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/406","diff_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/406.diff","patch_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/406.patch","issue_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/406","number":406,"state":"closed","locked":false,"title":"SWARM-1164 - -D properties pass on CLI not actually passing.","user":{"login":"bobmcwhirter","id":15951,"avatar_url":"https://avatars2.githubusercontent.com/u/15951?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmcwhirter","html_url":"https://github.com/bobmcwhirter","followers_url":"https://api.github.com/users/bobmcwhirter/followers","following_url":"https://api.github.com/users/bobmcwhirter/following{/other_user}","gists_url":"https://api.github.com/users/bobmcwhirter/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmcwhirter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmcwhirter/subscriptions","organizations_url":"https://api.github.com/users/bobmcwhirter/orgs","repos_url":"https://api.github.com/users/bobmcwhirter/repos","events_url":"https://api.github.com/users/bobmcwhirter/events{/privacy}","received_events_url":"https://api.github.com/users/bobmcwhirter/received_events","type":"User","site_admin":false},"body":"Motivation\r\n----------\r\n\r\nWhile the JVM would typically take -Dfoo=bar before the -jar argument,\r\nour own CommandLine should part out properties given as ARGV arguments.\r\n\r\nThis wasn't working.\r\n\r\nModifications\r\n-------------\r\n\r\nInstead of relying purely on System properties, and eagerly converting\r\nthem to configuration items before parsing the CLI ARGV, we now do two\r\nthings:\r\n\r\n- The ARGV, as parsed, passes properties to (new) Swarm.withProperty()\r\n  which progressively affects the properties bound to config-values.\r\n\r\n- When the CommandLine applies properties, it no longer directly sets\r\n  them via System.setProperty(), because this makes testing more tricky,\r\n  and the ConfigView sets properties (on the System or isolated Properties\r\n  instance) at a later resolved phase anyhow.\r\n\r\nResult\r\n------\r\n\r\n`java -jar myapp-swarm.jar -Dfoo=bar` once again functions as documented.\r\n\r\n- [X] Have you followed the guidelines in our [Contributing](http://wildfly-swarm.io/community/contributing/) document?\r\n- [X] Have you created a [JIRA](https://issues.jboss.org/browse/SWARM) and used it in the commit message?\r\n- [X] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/wildfly-swarm/wildfly-swarm/pulls) for the same issue?\r\n- [X] Have you built the project locally prior to submission with `mvn clean install`?\r\n\r\n-----\r\n","created_at":"2017-03-06T19:18:43Z","updated_at":"2017-03-07T14:12:34Z","closed_at":"2017-03-07T14:12:34Z","merged_at":"2017-03-07T14:12:34Z","merge_commit_sha":"21233565654880b45c06bfc407738e52a9657a0e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406/commits","review_comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406/comments","review_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/406/comments","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/ab8da2a6c4062b89f6ead28fe934ce8319c05789","head":{"label":"bobmcwhirter:SWARM-1164","ref":"SWARM-1164","sha":"ab8da2a6c4062b89f6ead28fe934ce8319c05789","user":{"login":"bobmcwhirter","id":15951,"avatar_url":"https://avatars2.githubusercontent.com/u/15951?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmcwhirter","html_url":"https://github.com/bobmcwhirter","followers_url":"https://api.github.com/users/bobmcwhirter/followers","following_url":"https://api.github.com/users/bobmcwhirter/following{/other_user}","gists_url":"https://api.github.com/users/bobmcwhirter/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmcwhirter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmcwhirter/subscriptions","organizations_url":"https://api.github.com/users/bobmcwhirter/orgs","repos_url":"https://api.github.com/users/bobmcwhirter/repos","events_url":"https://api.github.com/users/bobmcwhirter/events{/privacy}","received_events_url":"https://api.github.com/users/bobmcwhirter/received_events","type":"User","site_admin":false},"repo":{"id":65492662,"name":"wildfly-swarm","full_name":"bobmcwhirter/wildfly-swarm","owner":{"login":"bobmcwhirter","id":15951,"avatar_url":"https://avatars2.githubusercontent.com/u/15951?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmcwhirter","html_url":"https://github.com/bobmcwhirter","followers_url":"https://api.github.com/users/bobmcwhirter/followers","following_url":"https://api.github.com/users/bobmcwhirter/following{/other_user}","gists_url":"https://api.github.com/users/bobmcwhirter/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmcwhirter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmcwhirter/subscriptions","organizations_url":"https://api.github.com/users/bobmcwhirter/orgs","repos_url":"https://api.github.com/users/bobmcwhirter/repos","events_url":"https://api.github.com/users/bobmcwhirter/events{/privacy}","received_events_url":"https://api.github.com/users/bobmcwhirter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobmcwhirter/wildfly-swarm","description":"Source code for the WildFly Swarm project","fork":true,"url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm","forks_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/forks","keys_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/teams","hooks_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/hooks","issue_events_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/events","assignees_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/tags","blobs_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/languages","stargazers_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/stargazers","contributors_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/contributors","subscribers_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/subscribers","subscription_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/subscription","commits_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/merges","archive_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/downloads","issues_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/labels{/name}","releases_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/bobmcwhirter/wildfly-swarm/deployments","created_at":"2016-08-11T18:33:24Z","updated_at":"2016-08-11T18:33:27Z","pushed_at":"2017-03-06T21:04:23Z","git_url":"git://github.com/bobmcwhirter/wildfly-swarm.git","ssh_url":"git@github.com:bobmcwhirter/wildfly-swarm.git","clone_url":"https://github.com/bobmcwhirter/wildfly-swarm.git","svn_url":"https://github.com/bobmcwhirter/wildfly-swarm","homepage":"http://wildfly-swarm.io/","size":11003,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-swarm:master","ref":"master","sha":"377faef29e277ce6bb1ffd192e27fdabe714bea7","user":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars3.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"repo":{"id":52040340,"name":"wildfly-swarm","full_name":"wildfly-swarm/wildfly-swarm","owner":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars3.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm","description":"Source code for the WildFly Swarm project","fork":false,"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm","forks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/forks","keys_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/teams","hooks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/hooks","issue_events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/events","assignees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/tags","blobs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/languages","stargazers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/stargazers","contributors_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/contributors","subscribers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/subscribers","subscription_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/subscription","commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/merges","archive_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/downloads","issues_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/deployments","created_at":"2016-02-18T21:32:47Z","updated_at":"2017-03-06T21:26:24Z","pushed_at":"2017-03-07T14:12:34Z","git_url":"git://github.com/wildfly-swarm/wildfly-swarm.git","ssh_url":"git@github.com:wildfly-swarm/wildfly-swarm.git","clone_url":"https://github.com/wildfly-swarm/wildfly-swarm.git","svn_url":"https://github.com/wildfly-swarm/wildfly-swarm","homepage":"http://wildfly-swarm.io/","size":10998,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":4,"forks":95,"open_issues":4,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406"},"html":{"href":"https://github.com/wildfly-swarm/wildfly-swarm/pull/406"},"issue":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/406"},"comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/ab8da2a6c4062b89f6ead28fe934ce8319c05789"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kenfinnigan","id":441240,"avatar_url":"https://avatars3.githubusercontent.com/u/441240?v=3","gravatar_id":"","url":"https://api.github.com/users/kenfinnigan","html_url":"https://github.com/kenfinnigan","followers_url":"https://api.github.com/users/kenfinnigan/followers","following_url":"https://api.github.com/users/kenfinnigan/following{/other_user}","gists_url":"https://api.github.com/users/kenfinnigan/gists{/gist_id}","starred_url":"https://api.github.com/users/kenfinnigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenfinnigan/subscriptions","organizations_url":"https://api.github.com/users/kenfinnigan/orgs","repos_url":"https://api.github.com/users/kenfinnigan/repos","events_url":"https://api.github.com/users/kenfinnigan/events{/privacy}","received_events_url":"https://api.github.com/users/kenfinnigan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":43,"deletions":7,"changed_files":6}}
{"actor":{"display_login":"kenfinnigan"}}