{"action":"created","comment":{"url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments/158123967","pull_request_review_id":84883059,"id":158123967,"diff_hunk":"@@ -430,15 +439,24 @@ namespace OpenDDS\n                    i < sample.content_filter_entries_.length();\n                    i++)\n                 {\n+                  // Get Entry Value\n                   const GUID_t &filter = sample.content_filter_entries_[i];\n                   DCPS::GuidConverter converter(filter);\n                   std::stringstream strm;\n-                  strm << \"filter [\" << i << \"] = \" << converter << std::ends;\n+                  std::string guid = strm.str();","path":"tools/dissector/packet-opendds.cpp","position":70,"original_position":70,"commit_id":"91c04503070708cba1b553f1fe785f5135fdcd1a","original_commit_id":"91c04503070708cba1b553f1fe785f5135fdcd1a","user":{"login":"mitza-oci","id":10078698,"avatar_url":"https://avatars0.githubusercontent.com/u/10078698?v=4","gravatar_id":"","url":"https://api.github.com/users/mitza-oci","html_url":"https://github.com/mitza-oci","followers_url":"https://api.github.com/users/mitza-oci/followers","following_url":"https://api.github.com/users/mitza-oci/following{/other_user}","gists_url":"https://api.github.com/users/mitza-oci/gists{/gist_id}","starred_url":"https://api.github.com/users/mitza-oci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitza-oci/subscriptions","organizations_url":"https://api.github.com/users/mitza-oci/orgs","repos_url":"https://api.github.com/users/mitza-oci/repos","events_url":"https://api.github.com/users/mitza-oci/events{/privacy}","received_events_url":"https://api.github.com/users/mitza-oci/received_events","type":"User","site_admin":false},"body":"This doesn't look right -- `guid` will always be an empty string and the stringstream is unsued","created_at":"2017-12-20T20:09:12Z","updated_at":"2017-12-20T20:18:44Z","html_url":"https://github.com/objectcomputing/OpenDDS/pull/777#discussion_r158123967","pull_request_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments/158123967"},"html":{"href":"https://github.com/objectcomputing/OpenDDS/pull/777#discussion_r158123967"},"pull_request":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777","id":158158494,"html_url":"https://github.com/objectcomputing/OpenDDS/pull/777","diff_url":"https://github.com/objectcomputing/OpenDDS/pull/777.diff","patch_url":"https://github.com/objectcomputing/OpenDDS/pull/777.patch","issue_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/777","number":777,"state":"open","locked":false,"title":"Wireshark2","user":{"login":"iguessthislldo","id":5941194,"avatar_url":"https://avatars1.githubusercontent.com/u/5941194?v=4","gravatar_id":"","url":"https://api.github.com/users/iguessthislldo","html_url":"https://github.com/iguessthislldo","followers_url":"https://api.github.com/users/iguessthislldo/followers","following_url":"https://api.github.com/users/iguessthislldo/following{/other_user}","gists_url":"https://api.github.com/users/iguessthislldo/gists{/gist_id}","starred_url":"https://api.github.com/users/iguessthislldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iguessthislldo/subscriptions","organizations_url":"https://api.github.com/users/iguessthislldo/orgs","repos_url":"https://api.github.com/users/iguessthislldo/repos","events_url":"https://api.github.com/users/iguessthislldo/events{/privacy}","received_events_url":"https://api.github.com/users/iguessthislldo/received_events","type":"User","site_admin":false},"body":"- Dissector Compatibility with Wireshark 2.x while keeping compatibility with at least 1.12.\r\n- Filtering by sample payload content.\r\n- Small change to the IDL compiler for ITL files to help in sample dissection.\r\n- Using OpenDDS::DCPS::Serializer in sample dissection.\r\n- Using Wireshark's \"expert\" functionality to mark some problems with packets in the GUI as well as printing the problem like before.\r\n","created_at":"2017-12-13T17:37:00Z","updated_at":"2017-12-20T20:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7629d95fc71291449ec7a81cdbd1b8971cb99c1b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777/commits","review_comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777/comments","review_comment_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/777/comments","statuses_url":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/91c04503070708cba1b553f1fe785f5135fdcd1a","head":{"label":"iguessthislldo:wireshark2","ref":"wireshark2","sha":"91c04503070708cba1b553f1fe785f5135fdcd1a","user":{"login":"iguessthislldo","id":5941194,"avatar_url":"https://avatars1.githubusercontent.com/u/5941194?v=4","gravatar_id":"","url":"https://api.github.com/users/iguessthislldo","html_url":"https://github.com/iguessthislldo","followers_url":"https://api.github.com/users/iguessthislldo/followers","following_url":"https://api.github.com/users/iguessthislldo/following{/other_user}","gists_url":"https://api.github.com/users/iguessthislldo/gists{/gist_id}","starred_url":"https://api.github.com/users/iguessthislldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iguessthislldo/subscriptions","organizations_url":"https://api.github.com/users/iguessthislldo/orgs","repos_url":"https://api.github.com/users/iguessthislldo/repos","events_url":"https://api.github.com/users/iguessthislldo/events{/privacy}","received_events_url":"https://api.github.com/users/iguessthislldo/received_events","type":"User","site_admin":false},"repo":{"id":105304869,"name":"OpenDDS","full_name":"iguessthislldo/OpenDDS","owner":{"login":"iguessthislldo","id":5941194,"avatar_url":"https://avatars1.githubusercontent.com/u/5941194?v=4","gravatar_id":"","url":"https://api.github.com/users/iguessthislldo","html_url":"https://github.com/iguessthislldo","followers_url":"https://api.github.com/users/iguessthislldo/followers","following_url":"https://api.github.com/users/iguessthislldo/following{/other_user}","gists_url":"https://api.github.com/users/iguessthislldo/gists{/gist_id}","starred_url":"https://api.github.com/users/iguessthislldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iguessthislldo/subscriptions","organizations_url":"https://api.github.com/users/iguessthislldo/orgs","repos_url":"https://api.github.com/users/iguessthislldo/repos","events_url":"https://api.github.com/users/iguessthislldo/events{/privacy}","received_events_url":"https://api.github.com/users/iguessthislldo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iguessthislldo/OpenDDS","description":"OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.","fork":true,"url":"https://api.github.com/repos/iguessthislldo/OpenDDS","forks_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/forks","keys_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/teams","hooks_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/hooks","issue_events_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/issues/events{/number}","events_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/events","assignees_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/assignees{/user}","branches_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/branches{/branch}","tags_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/tags","blobs_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/statuses/{sha}","languages_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/languages","stargazers_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/stargazers","contributors_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/contributors","subscribers_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/subscribers","subscription_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/subscription","commits_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/contents/{+path}","compare_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/merges","archive_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/downloads","issues_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/issues{/number}","pulls_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/pulls{/number}","milestones_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/milestones{/number}","notifications_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/labels{/name}","releases_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/releases{/id}","deployments_url":"https://api.github.com/repos/iguessthislldo/OpenDDS/deployments","created_at":"2017-09-29T18:30:17Z","updated_at":"2017-09-29T18:30:25Z","pushed_at":"2017-12-20T00:21:40Z","git_url":"git://github.com/iguessthislldo/OpenDDS.git","ssh_url":"git@github.com:iguessthislldo/OpenDDS.git","clone_url":"https://github.com/iguessthislldo/OpenDDS.git","svn_url":"https://github.com/iguessthislldo/OpenDDS","homepage":"http://www.opendds.org","size":58110,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"objectcomputing:master","ref":"master","sha":"1d7dbe173a7be4cc7117be6fc8f00b8afc897115","user":{"login":"objectcomputing","id":3903550,"avatar_url":"https://avatars3.githubusercontent.com/u/3903550?v=4","gravatar_id":"","url":"https://api.github.com/users/objectcomputing","html_url":"https://github.com/objectcomputing","followers_url":"https://api.github.com/users/objectcomputing/followers","following_url":"https://api.github.com/users/objectcomputing/following{/other_user}","gists_url":"https://api.github.com/users/objectcomputing/gists{/gist_id}","starred_url":"https://api.github.com/users/objectcomputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectcomputing/subscriptions","organizations_url":"https://api.github.com/users/objectcomputing/orgs","repos_url":"https://api.github.com/users/objectcomputing/repos","events_url":"https://api.github.com/users/objectcomputing/events{/privacy}","received_events_url":"https://api.github.com/users/objectcomputing/received_events","type":"Organization","site_admin":false},"repo":{"id":30720952,"name":"OpenDDS","full_name":"objectcomputing/OpenDDS","owner":{"login":"objectcomputing","id":3903550,"avatar_url":"https://avatars3.githubusercontent.com/u/3903550?v=4","gravatar_id":"","url":"https://api.github.com/users/objectcomputing","html_url":"https://github.com/objectcomputing","followers_url":"https://api.github.com/users/objectcomputing/followers","following_url":"https://api.github.com/users/objectcomputing/following{/other_user}","gists_url":"https://api.github.com/users/objectcomputing/gists{/gist_id}","starred_url":"https://api.github.com/users/objectcomputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectcomputing/subscriptions","organizations_url":"https://api.github.com/users/objectcomputing/orgs","repos_url":"https://api.github.com/users/objectcomputing/repos","events_url":"https://api.github.com/users/objectcomputing/events{/privacy}","received_events_url":"https://api.github.com/users/objectcomputing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/objectcomputing/OpenDDS","description":"OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.","fork":false,"url":"https://api.github.com/repos/objectcomputing/OpenDDS","forks_url":"https://api.github.com/repos/objectcomputing/OpenDDS/forks","keys_url":"https://api.github.com/repos/objectcomputing/OpenDDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectcomputing/OpenDDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectcomputing/OpenDDS/teams","hooks_url":"https://api.github.com/repos/objectcomputing/OpenDDS/hooks","issue_events_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/events{/number}","events_url":"https://api.github.com/repos/objectcomputing/OpenDDS/events","assignees_url":"https://api.github.com/repos/objectcomputing/OpenDDS/assignees{/user}","branches_url":"https://api.github.com/repos/objectcomputing/OpenDDS/branches{/branch}","tags_url":"https://api.github.com/repos/objectcomputing/OpenDDS/tags","blobs_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/{sha}","languages_url":"https://api.github.com/repos/objectcomputing/OpenDDS/languages","stargazers_url":"https://api.github.com/repos/objectcomputing/OpenDDS/stargazers","contributors_url":"https://api.github.com/repos/objectcomputing/OpenDDS/contributors","subscribers_url":"https://api.github.com/repos/objectcomputing/OpenDDS/subscribers","subscription_url":"https://api.github.com/repos/objectcomputing/OpenDDS/subscription","commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectcomputing/OpenDDS/contents/{+path}","compare_url":"https://api.github.com/repos/objectcomputing/OpenDDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectcomputing/OpenDDS/merges","archive_url":"https://api.github.com/repos/objectcomputing/OpenDDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectcomputing/OpenDDS/downloads","issues_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues{/number}","pulls_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls{/number}","milestones_url":"https://api.github.com/repos/objectcomputing/OpenDDS/milestones{/number}","notifications_url":"https://api.github.com/repos/objectcomputing/OpenDDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectcomputing/OpenDDS/labels{/name}","releases_url":"https://api.github.com/repos/objectcomputing/OpenDDS/releases{/id}","deployments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/deployments","created_at":"2015-02-12T20:01:26Z","updated_at":"2017-12-20T04:02:44Z","pushed_at":"2017-12-20T00:21:42Z","git_url":"git://github.com/objectcomputing/OpenDDS.git","ssh_url":"git@github.com:objectcomputing/OpenDDS.git","clone_url":"https://github.com/objectcomputing/OpenDDS.git","svn_url":"https://github.com/objectcomputing/OpenDDS","homepage":"http://www.opendds.org","size":58048,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":96,"open_issues":55,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777"},"html":{"href":"https://github.com/objectcomputing/OpenDDS/pull/777"},"issue":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/777"},"comments":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/91c04503070708cba1b553f1fe785f5135fdcd1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mitza-oci"}}