{"action":"opened","number":312,"pull_request":{"url":"https://api.github.com/repos/navit-gps/navit/pulls/312","id":140201485,"html_url":"https://github.com/navit-gps/navit/pull/312","diff_url":"https://github.com/navit-gps/navit/pull/312.diff","patch_url":"https://github.com/navit-gps/navit/pull/312.patch","issue_url":"https://api.github.com/repos/navit-gps/navit/issues/312","number":312,"state":"open","locked":false,"title":"Solve problem when building with building with -Werror=format-security","user":{"login":"trldp","id":12382262,"avatar_url":"https://avatars0.githubusercontent.com/u/12382262?v=4","gravatar_id":"","url":"https://api.github.com/users/trldp","html_url":"https://github.com/trldp","followers_url":"https://api.github.com/users/trldp/followers","following_url":"https://api.github.com/users/trldp/following{/other_user}","gists_url":"https://api.github.com/users/trldp/gists{/gist_id}","starred_url":"https://api.github.com/users/trldp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trldp/subscriptions","organizations_url":"https://api.github.com/users/trldp/orgs","repos_url":"https://api.github.com/users/trldp/repos","events_url":"https://api.github.com/users/trldp/events{/privacy}","received_events_url":"https://api.github.com/users/trldp/received_events","type":"User","site_admin":false},"body":"Using fprintf with a string variable instead of a string literal causes an error when building with -Werror=format-security (which is for example commonly used while building debian / ubuntu packages). It is also a bad idea in general, since someone might accidentally call exit_with_error with a string containing a printf format specifier, like exit_with_error(\"Some error with a %s\").","created_at":"2017-09-10T09:17:02Z","updated_at":"2017-09-10T09:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/navit-gps/navit/pulls/312/commits","review_comments_url":"https://api.github.com/repos/navit-gps/navit/pulls/312/comments","review_comment_url":"https://api.github.com/repos/navit-gps/navit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/navit-gps/navit/issues/312/comments","statuses_url":"https://api.github.com/repos/navit-gps/navit/statuses/cf09a55392ee874d54b7b3ff9b7f9164c1f44c95","head":{"label":"trldp:trunk","ref":"trunk","sha":"cf09a55392ee874d54b7b3ff9b7f9164c1f44c95","user":{"login":"trldp","id":12382262,"avatar_url":"https://avatars0.githubusercontent.com/u/12382262?v=4","gravatar_id":"","url":"https://api.github.com/users/trldp","html_url":"https://github.com/trldp","followers_url":"https://api.github.com/users/trldp/followers","following_url":"https://api.github.com/users/trldp/following{/other_user}","gists_url":"https://api.github.com/users/trldp/gists{/gist_id}","starred_url":"https://api.github.com/users/trldp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trldp/subscriptions","organizations_url":"https://api.github.com/users/trldp/orgs","repos_url":"https://api.github.com/users/trldp/repos","events_url":"https://api.github.com/users/trldp/events{/privacy}","received_events_url":"https://api.github.com/users/trldp/received_events","type":"User","site_admin":false},"repo":{"id":103016072,"name":"navit","full_name":"trldp/navit","owner":{"login":"trldp","id":12382262,"avatar_url":"https://avatars0.githubusercontent.com/u/12382262?v=4","gravatar_id":"","url":"https://api.github.com/users/trldp","html_url":"https://github.com/trldp","followers_url":"https://api.github.com/users/trldp/followers","following_url":"https://api.github.com/users/trldp/following{/other_user}","gists_url":"https://api.github.com/users/trldp/gists{/gist_id}","starred_url":"https://api.github.com/users/trldp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trldp/subscriptions","organizations_url":"https://api.github.com/users/trldp/orgs","repos_url":"https://api.github.com/users/trldp/repos","events_url":"https://api.github.com/users/trldp/events{/privacy}","received_events_url":"https://api.github.com/users/trldp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trldp/navit","description":"The open source (GPL) turn-by-turn navigation software for many OS","fork":true,"url":"https://api.github.com/repos/trldp/navit","forks_url":"https://api.github.com/repos/trldp/navit/forks","keys_url":"https://api.github.com/repos/trldp/navit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trldp/navit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trldp/navit/teams","hooks_url":"https://api.github.com/repos/trldp/navit/hooks","issue_events_url":"https://api.github.com/repos/trldp/navit/issues/events{/number}","events_url":"https://api.github.com/repos/trldp/navit/events","assignees_url":"https://api.github.com/repos/trldp/navit/assignees{/user}","branches_url":"https://api.github.com/repos/trldp/navit/branches{/branch}","tags_url":"https://api.github.com/repos/trldp/navit/tags","blobs_url":"https://api.github.com/repos/trldp/navit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trldp/navit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trldp/navit/git/refs{/sha}","trees_url":"https://api.github.com/repos/trldp/navit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trldp/navit/statuses/{sha}","languages_url":"https://api.github.com/repos/trldp/navit/languages","stargazers_url":"https://api.github.com/repos/trldp/navit/stargazers","contributors_url":"https://api.github.com/repos/trldp/navit/contributors","subscribers_url":"https://api.github.com/repos/trldp/navit/subscribers","subscription_url":"https://api.github.com/repos/trldp/navit/subscription","commits_url":"https://api.github.com/repos/trldp/navit/commits{/sha}","git_commits_url":"https://api.github.com/repos/trldp/navit/git/commits{/sha}","comments_url":"https://api.github.com/repos/trldp/navit/comments{/number}","issue_comment_url":"https://api.github.com/repos/trldp/navit/issues/comments{/number}","contents_url":"https://api.github.com/repos/trldp/navit/contents/{+path}","compare_url":"https://api.github.com/repos/trldp/navit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trldp/navit/merges","archive_url":"https://api.github.com/repos/trldp/navit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trldp/navit/downloads","issues_url":"https://api.github.com/repos/trldp/navit/issues{/number}","pulls_url":"https://api.github.com/repos/trldp/navit/pulls{/number}","milestones_url":"https://api.github.com/repos/trldp/navit/milestones{/number}","notifications_url":"https://api.github.com/repos/trldp/navit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trldp/navit/labels{/name}","releases_url":"https://api.github.com/repos/trldp/navit/releases{/id}","deployments_url":"https://api.github.com/repos/trldp/navit/deployments","created_at":"2017-09-10T08:56:12Z","updated_at":"2017-09-10T08:56:18Z","pushed_at":"2017-09-10T09:04:42Z","git_url":"git://github.com/trldp/navit.git","ssh_url":"git@github.com:trldp/navit.git","clone_url":"https://github.com/trldp/navit.git","svn_url":"https://github.com/trldp/navit","homepage":"http://www.navit-project.org","size":32109,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"navit-gps:trunk","ref":"trunk","sha":"b0a8ef218ce94e47e863692757364cac7ceb6070","user":{"login":"navit-gps","id":10889833,"avatar_url":"https://avatars1.githubusercontent.com/u/10889833?v=4","gravatar_id":"","url":"https://api.github.com/users/navit-gps","html_url":"https://github.com/navit-gps","followers_url":"https://api.github.com/users/navit-gps/followers","following_url":"https://api.github.com/users/navit-gps/following{/other_user}","gists_url":"https://api.github.com/users/navit-gps/gists{/gist_id}","starred_url":"https://api.github.com/users/navit-gps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navit-gps/subscriptions","organizations_url":"https://api.github.com/users/navit-gps/orgs","repos_url":"https://api.github.com/users/navit-gps/repos","events_url":"https://api.github.com/users/navit-gps/events{/privacy}","received_events_url":"https://api.github.com/users/navit-gps/received_events","type":"Organization","site_admin":false},"repo":{"id":30791823,"name":"navit","full_name":"navit-gps/navit","owner":{"login":"navit-gps","id":10889833,"avatar_url":"https://avatars1.githubusercontent.com/u/10889833?v=4","gravatar_id":"","url":"https://api.github.com/users/navit-gps","html_url":"https://github.com/navit-gps","followers_url":"https://api.github.com/users/navit-gps/followers","following_url":"https://api.github.com/users/navit-gps/following{/other_user}","gists_url":"https://api.github.com/users/navit-gps/gists{/gist_id}","starred_url":"https://api.github.com/users/navit-gps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navit-gps/subscriptions","organizations_url":"https://api.github.com/users/navit-gps/orgs","repos_url":"https://api.github.com/users/navit-gps/repos","events_url":"https://api.github.com/users/navit-gps/events{/privacy}","received_events_url":"https://api.github.com/users/navit-gps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/navit-gps/navit","description":"The open source (GPL) turn-by-turn navigation software for many OS","fork":false,"url":"https://api.github.com/repos/navit-gps/navit","forks_url":"https://api.github.com/repos/navit-gps/navit/forks","keys_url":"https://api.github.com/repos/navit-gps/navit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navit-gps/navit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navit-gps/navit/teams","hooks_url":"https://api.github.com/repos/navit-gps/navit/hooks","issue_events_url":"https://api.github.com/repos/navit-gps/navit/issues/events{/number}","events_url":"https://api.github.com/repos/navit-gps/navit/events","assignees_url":"https://api.github.com/repos/navit-gps/navit/assignees{/user}","branches_url":"https://api.github.com/repos/navit-gps/navit/branches{/branch}","tags_url":"https://api.github.com/repos/navit-gps/navit/tags","blobs_url":"https://api.github.com/repos/navit-gps/navit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navit-gps/navit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navit-gps/navit/git/refs{/sha}","trees_url":"https://api.github.com/repos/navit-gps/navit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navit-gps/navit/statuses/{sha}","languages_url":"https://api.github.com/repos/navit-gps/navit/languages","stargazers_url":"https://api.github.com/repos/navit-gps/navit/stargazers","contributors_url":"https://api.github.com/repos/navit-gps/navit/contributors","subscribers_url":"https://api.github.com/repos/navit-gps/navit/subscribers","subscription_url":"https://api.github.com/repos/navit-gps/navit/subscription","commits_url":"https://api.github.com/repos/navit-gps/navit/commits{/sha}","git_commits_url":"https://api.github.com/repos/navit-gps/navit/git/commits{/sha}","comments_url":"https://api.github.com/repos/navit-gps/navit/comments{/number}","issue_comment_url":"https://api.github.com/repos/navit-gps/navit/issues/comments{/number}","contents_url":"https://api.github.com/repos/navit-gps/navit/contents/{+path}","compare_url":"https://api.github.com/repos/navit-gps/navit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navit-gps/navit/merges","archive_url":"https://api.github.com/repos/navit-gps/navit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navit-gps/navit/downloads","issues_url":"https://api.github.com/repos/navit-gps/navit/issues{/number}","pulls_url":"https://api.github.com/repos/navit-gps/navit/pulls{/number}","milestones_url":"https://api.github.com/repos/navit-gps/navit/milestones{/number}","notifications_url":"https://api.github.com/repos/navit-gps/navit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navit-gps/navit/labels{/name}","releases_url":"https://api.github.com/repos/navit-gps/navit/releases{/id}","deployments_url":"https://api.github.com/repos/navit-gps/navit/deployments","created_at":"2015-02-14T08:54:42Z","updated_at":"2017-08-29T17:40:16Z","pushed_at":"2017-09-06T22:58:28Z","git_url":"git://github.com/navit-gps/navit.git","ssh_url":"git@github.com:navit-gps/navit.git","clone_url":"https://github.com/navit-gps/navit.git","svn_url":"https://github.com/navit-gps/navit","homepage":"http://www.navit-project.org","size":32109,"stargazers_count":126,"watchers_count":126,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":9,"forks":58,"open_issues":9,"watchers":126,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/navit-gps/navit/pulls/312"},"html":{"href":"https://github.com/navit-gps/navit/pull/312"},"issue":{"href":"https://api.github.com/repos/navit-gps/navit/issues/312"},"comments":{"href":"https://api.github.com/repos/navit-gps/navit/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/navit-gps/navit/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/navit-gps/navit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/navit-gps/navit/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/navit-gps/navit/statuses/cf09a55392ee874d54b7b3ff9b7f9164c1f44c95"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"trldp"}}