{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/96883854","pull_request_review_id":17480354,"id":96883854,"diff_hunk":"@@ -98,25 +98,25 @@ case \"$command\" in\n     cpp)\n         mode=cpp\n         ;;\n-    cc|c89|c99|gcc|clang|icc|pgcc|xlc)\n+    cc|c89|c99|gcc|clang|icc|pgcc|xlc|xlc_r)","path":"lib/spack/env/cc","position":5,"original_position":5,"commit_id":"24c261fe255023c94e973a3935f2866208e8dabe","original_commit_id":"24c261fe255023c94e973a3935f2866208e8dabe","user":{"login":"serbanmaerean","id":20232116,"avatar_url":"https://avatars.githubusercontent.com/u/20232116?v=3","gravatar_id":"","url":"https://api.github.com/users/serbanmaerean","html_url":"https://github.com/serbanmaerean","followers_url":"https://api.github.com/users/serbanmaerean/followers","following_url":"https://api.github.com/users/serbanmaerean/following{/other_user}","gists_url":"https://api.github.com/users/serbanmaerean/gists{/gist_id}","starred_url":"https://api.github.com/users/serbanmaerean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbanmaerean/subscriptions","organizations_url":"https://api.github.com/users/serbanmaerean/orgs","repos_url":"https://api.github.com/users/serbanmaerean/repos","events_url":"https://api.github.com/users/serbanmaerean/events{/privacy}","received_events_url":"https://api.github.com/users/serbanmaerean/received_events","type":"User","site_admin":false},"body":"I have the following changes that list the fflags in the flags section:\r\ndiff --git a/lib/spack/spack/compilers/__init__.py b/lib/spack/spack/compilers/__init__.py\r\nindex 6e65f50..7e530f0 100644\r\n--- a/lib/spack/spack/compilers/__init__.py\r\n+++ b/lib/spack/spack/compilers/__init__.py\r\n@@ -40,6 +40,7 @@ from spack.util.naming import mod_to_class\r\n \r\n _imported_compilers_module = 'spack.compilers'\r\n _path_instance_vars = ['cc', 'cxx', 'f77', 'fc']\r\n+_flags_instance_vars = ['cflags', 'cxxflags', 'fflags']\r\n _other_instance_vars = ['modules', 'operating_system', 'environment',\r\n                         'extra_rpaths']\r\n _cache_config_file = []\r\n@@ -60,6 +61,8 @@ def _to_dict(compiler):\r\n     d['paths'] = dict((attr, getattr(compiler, attr, None))\r\n                       for attr in _path_instance_vars)\r\n     d['flags'] = dict((fname, fvals) for fname, fvals in compiler.flags)\r\n+    d['flags'].update(dict((attr, getattr(compiler, attr, None))\r\n+                      for attr in _flags_instance_vars if hasattr(compiler, attr)))\r\n     d['operating_system'] = str(compiler.operating_system)\r\n     d['target'] = str(compiler.target)\r\n     d['modules'] = compiler.modules if compiler.modules else []\r\n\r\nWith these small change, the compilers.yaml file looks as follows:\r\n\r\n- compiler:\r\n    environment: {}\r\n    extra_rpaths: []\r\n    flags:\r\n      fflags: -qzerosize -qfixed\r\n    modules: []\r\n    operating_system: rhel7\r\n    paths:\r\n      cc: /usr/bin/xlc\r\n      cxx: /usr/bin/xlc++\r\n      f77: /usr/bin/xlf\r\n      fc: /usr/bin/xlf2003\r\n    spec: xl@13.1\r\n    target: ppc64le\r\n- compiler:\r\n    environment: {}\r\n    extra_rpaths: []\r\n    flags:\r\n      fflags: -qzerosize -qfixed\r\n    modules: []\r\n    operating_system: rhel7\r\n    paths:\r\n      cc: /usr/bin/xlc_r\r\n      cxx: /usr/bin/xlc++_r\r\n      f77: /usr/bin/xlf_r\r\n      fc: /usr/bin/xlf2003_r\r\n    spec: xl_r@13.1\r\n    target: ppc64le\r\n\r\nWithe the fflags showing under flags.  What is not clear to me is what are the other flags that should go under there?  The compiler classes define other flags, like openmp_flag, pic_flag, cxx11_flag.  They are not listed at all.","created_at":"2017-01-19T15:29:28Z","updated_at":"2017-01-19T15:29:28Z","html_url":"https://github.com/LLNL/spack/pull/2861#discussion_r96883854","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2861","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/96883854"},"html":{"href":"https://github.com/LLNL/spack/pull/2861#discussion_r96883854"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2861","id":102083723,"html_url":"https://github.com/LLNL/spack/pull/2861","diff_url":"https://github.com/LLNL/spack/pull/2861.diff","patch_url":"https://github.com/LLNL/spack/pull/2861.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2861","number":2861,"state":"open","locked":false,"title":"IBM xl_r  compiler build for Trilinos, ","user":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"body":"We have successfully compiled the following packages with xl_r\r\n\r\nnetlib-lapack\r\nnetlib-scalapack\r\nfftw\r\nmatio\r\nboost\r\nhdf5\r\nmetis\r\nparmetis\r\nnetcdf\r\ncuite-sparse\r\nsuperlu-dist\r\nmumps\r\nhypre\r\ntrilinos\r\npetsc\r\nmagma\r\n","created_at":"2017-01-18T15:09:29Z","updated_at":"2017-01-19T15:29:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2861/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2861/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2861/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/24c261fe255023c94e973a3935f2866208e8dabe","head":{"label":"eklee15:develop","ref":"develop","sha":"24c261fe255023c94e973a3935f2866208e8dabe","user":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"repo":{"id":77692113,"name":"spack","full_name":"eklee15/spack","owner":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eklee15/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/eklee15/spack","forks_url":"https://api.github.com/repos/eklee15/spack/forks","keys_url":"https://api.github.com/repos/eklee15/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eklee15/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eklee15/spack/teams","hooks_url":"https://api.github.com/repos/eklee15/spack/hooks","issue_events_url":"https://api.github.com/repos/eklee15/spack/issues/events{/number}","events_url":"https://api.github.com/repos/eklee15/spack/events","assignees_url":"https://api.github.com/repos/eklee15/spack/assignees{/user}","branches_url":"https://api.github.com/repos/eklee15/spack/branches{/branch}","tags_url":"https://api.github.com/repos/eklee15/spack/tags","blobs_url":"https://api.github.com/repos/eklee15/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eklee15/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eklee15/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/eklee15/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eklee15/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/eklee15/spack/languages","stargazers_url":"https://api.github.com/repos/eklee15/spack/stargazers","contributors_url":"https://api.github.com/repos/eklee15/spack/contributors","subscribers_url":"https://api.github.com/repos/eklee15/spack/subscribers","subscription_url":"https://api.github.com/repos/eklee15/spack/subscription","commits_url":"https://api.github.com/repos/eklee15/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/eklee15/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/eklee15/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/eklee15/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/eklee15/spack/contents/{+path}","compare_url":"https://api.github.com/repos/eklee15/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eklee15/spack/merges","archive_url":"https://api.github.com/repos/eklee15/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eklee15/spack/downloads","issues_url":"https://api.github.com/repos/eklee15/spack/issues{/number}","pulls_url":"https://api.github.com/repos/eklee15/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/eklee15/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/eklee15/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eklee15/spack/labels{/name}","releases_url":"https://api.github.com/repos/eklee15/spack/releases{/id}","deployments_url":"https://api.github.com/repos/eklee15/spack/deployments","created_at":"2016-12-30T14:50:08Z","updated_at":"2016-12-30T14:50:13Z","pushed_at":"2017-01-16T20:29:42Z","git_url":"git://github.com/eklee15/spack.git","ssh_url":"git@github.com:eklee15/spack.git","clone_url":"https://github.com/eklee15/spack.git","svn_url":"https://github.com/eklee15/spack","homepage":"http://llnl.github.io/spack","size":19116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"f0f230d480004161c8f052d2ccf334a4f5ce25f8","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-01-18T14:05:56Z","pushed_at":"2017-01-19T15:11:17Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://spack.io","size":19708,"stargazers_count":200,"watchers_count":200,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"open_issues_count":471,"forks":177,"open_issues":471,"watchers":200,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861"},"html":{"href":"https://github.com/LLNL/spack/pull/2861"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2861"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2861/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/24c261fe255023c94e973a3935f2866208e8dabe"}}}}
{"actor":{"display_login":"serbanmaerean"}}