{"action":"closed","number":768,"pull_request":{"url":"https://api.github.com/repos/baldurk/renderdoc/pulls/768","id":145390203,"html_url":"https://github.com/baldurk/renderdoc/pull/768","diff_url":"https://github.com/baldurk/renderdoc/pull/768.diff","patch_url":"https://github.com/baldurk/renderdoc/pull/768.patch","issue_url":"https://api.github.com/repos/baldurk/renderdoc/issues/768","number":768,"state":"closed","locked":false,"title":"Improve save file handling","user":{"login":"cgmb","id":4886803,"avatar_url":"https://avatars1.githubusercontent.com/u/4886803?v=4","gravatar_id":"","url":"https://api.github.com/users/cgmb","html_url":"https://github.com/cgmb","followers_url":"https://api.github.com/users/cgmb/followers","following_url":"https://api.github.com/users/cgmb/following{/other_user}","gists_url":"https://api.github.com/users/cgmb/gists{/gist_id}","starred_url":"https://api.github.com/users/cgmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgmb/subscriptions","organizations_url":"https://api.github.com/users/cgmb/orgs","repos_url":"https://api.github.com/users/cgmb/repos","events_url":"https://api.github.com/users/cgmb/events{/privacy}","received_events_url":"https://api.github.com/users/cgmb/received_events","type":"User","site_admin":false},"body":"I was a little confused when I saved my capture settings and then couldn't find them again. After realizing that the file was getting filtered out because I didn't write out the extension, I figured I would just add a bit of code to automatically append the file extension if necessary.\r\n\r\nWhen I started doing that, I realized that other files had the same problem. I made extension appending a generic feature in getSaveFileName and updated saving for all the other file types I could identify that required a particular extension.\r\n\r\nThen I noticed that there was a recent list for capture files. I wanted to be sure the extension appending wouldn't screw that up, so I tried playing around with it a bit. The recent files menu turned out to have a few bugs, so I fixed them. It now updates as expected and \"Clear History\" works.\r\n\r\nI tried to match your style, though it feels a little weird. I also created the branch [cgmb/fix-save-file-handling-2](https://github.com/cgmb/renderdoc/compare/950c27719bd149c2195748e6d592fd6ea1d8453c...fix-save-file-handling-2) with an implementation that feels a slightly cleaner to me, but doesn't match your style as closely. If you prefer that version, I can force-push it over this branch to update the PR. If not, then merge away... or code review, or whatever.","created_at":"2017-10-09T07:48:26Z","updated_at":"2017-10-11T10:26:18Z","closed_at":"2017-10-11T10:26:18Z","merged_at":"2017-10-11T10:26:18Z","merge_commit_sha":"89865963502203251af9d3f8e01c25ce0a25e146","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/768/commits","review_comments_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/768/comments","review_comment_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baldurk/renderdoc/issues/768/comments","statuses_url":"https://api.github.com/repos/baldurk/renderdoc/statuses/1ecbab85a9b6293e63bb09d6b44abc23daf9ef0f","head":{"label":"cgmb:fix-save-file-handling","ref":"fix-save-file-handling","sha":"1ecbab85a9b6293e63bb09d6b44abc23daf9ef0f","user":{"login":"cgmb","id":4886803,"avatar_url":"https://avatars1.githubusercontent.com/u/4886803?v=4","gravatar_id":"","url":"https://api.github.com/users/cgmb","html_url":"https://github.com/cgmb","followers_url":"https://api.github.com/users/cgmb/followers","following_url":"https://api.github.com/users/cgmb/following{/other_user}","gists_url":"https://api.github.com/users/cgmb/gists{/gist_id}","starred_url":"https://api.github.com/users/cgmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgmb/subscriptions","organizations_url":"https://api.github.com/users/cgmb/orgs","repos_url":"https://api.github.com/users/cgmb/repos","events_url":"https://api.github.com/users/cgmb/events{/privacy}","received_events_url":"https://api.github.com/users/cgmb/received_events","type":"User","site_admin":false},"repo":{"id":54242084,"name":"renderdoc","full_name":"cgmb/renderdoc","owner":{"login":"cgmb","id":4886803,"avatar_url":"https://avatars1.githubusercontent.com/u/4886803?v=4","gravatar_id":"","url":"https://api.github.com/users/cgmb","html_url":"https://github.com/cgmb","followers_url":"https://api.github.com/users/cgmb/followers","following_url":"https://api.github.com/users/cgmb/following{/other_user}","gists_url":"https://api.github.com/users/cgmb/gists{/gist_id}","starred_url":"https://api.github.com/users/cgmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgmb/subscriptions","organizations_url":"https://api.github.com/users/cgmb/orgs","repos_url":"https://api.github.com/users/cgmb/repos","events_url":"https://api.github.com/users/cgmb/events{/privacy}","received_events_url":"https://api.github.com/users/cgmb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgmb/renderdoc","description":"RenderDoc is a stand-alone graphics debugging tool.","fork":true,"url":"https://api.github.com/repos/cgmb/renderdoc","forks_url":"https://api.github.com/repos/cgmb/renderdoc/forks","keys_url":"https://api.github.com/repos/cgmb/renderdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgmb/renderdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgmb/renderdoc/teams","hooks_url":"https://api.github.com/repos/cgmb/renderdoc/hooks","issue_events_url":"https://api.github.com/repos/cgmb/renderdoc/issues/events{/number}","events_url":"https://api.github.com/repos/cgmb/renderdoc/events","assignees_url":"https://api.github.com/repos/cgmb/renderdoc/assignees{/user}","branches_url":"https://api.github.com/repos/cgmb/renderdoc/branches{/branch}","tags_url":"https://api.github.com/repos/cgmb/renderdoc/tags","blobs_url":"https://api.github.com/repos/cgmb/renderdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgmb/renderdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgmb/renderdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgmb/renderdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgmb/renderdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/cgmb/renderdoc/languages","stargazers_url":"https://api.github.com/repos/cgmb/renderdoc/stargazers","contributors_url":"https://api.github.com/repos/cgmb/renderdoc/contributors","subscribers_url":"https://api.github.com/repos/cgmb/renderdoc/subscribers","subscription_url":"https://api.github.com/repos/cgmb/renderdoc/subscription","commits_url":"https://api.github.com/repos/cgmb/renderdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgmb/renderdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgmb/renderdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgmb/renderdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgmb/renderdoc/contents/{+path}","compare_url":"https://api.github.com/repos/cgmb/renderdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgmb/renderdoc/merges","archive_url":"https://api.github.com/repos/cgmb/renderdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgmb/renderdoc/downloads","issues_url":"https://api.github.com/repos/cgmb/renderdoc/issues{/number}","pulls_url":"https://api.github.com/repos/cgmb/renderdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/cgmb/renderdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/cgmb/renderdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgmb/renderdoc/labels{/name}","releases_url":"https://api.github.com/repos/cgmb/renderdoc/releases{/id}","deployments_url":"https://api.github.com/repos/cgmb/renderdoc/deployments","created_at":"2016-03-19T01:54:50Z","updated_at":"2016-03-19T01:54:53Z","pushed_at":"2017-10-10T00:45:33Z","git_url":"git://github.com/cgmb/renderdoc.git","ssh_url":"git@github.com:cgmb/renderdoc.git","clone_url":"https://github.com/cgmb/renderdoc.git","svn_url":"https://github.com/cgmb/renderdoc","homepage":"https://renderdoc.org/builds","size":37923,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baldurk:v1.x","ref":"v1.x","sha":"43d6d6e197da78006ee51f9872554ef2aa15cffd","user":{"login":"baldurk","id":661798,"avatar_url":"https://avatars3.githubusercontent.com/u/661798?v=4","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"repo":{"id":17253131,"name":"renderdoc","full_name":"baldurk/renderdoc","owner":{"login":"baldurk","id":661798,"avatar_url":"https://avatars3.githubusercontent.com/u/661798?v=4","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baldurk/renderdoc","description":"RenderDoc is a stand-alone graphics debugging tool.","fork":false,"url":"https://api.github.com/repos/baldurk/renderdoc","forks_url":"https://api.github.com/repos/baldurk/renderdoc/forks","keys_url":"https://api.github.com/repos/baldurk/renderdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baldurk/renderdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baldurk/renderdoc/teams","hooks_url":"https://api.github.com/repos/baldurk/renderdoc/hooks","issue_events_url":"https://api.github.com/repos/baldurk/renderdoc/issues/events{/number}","events_url":"https://api.github.com/repos/baldurk/renderdoc/events","assignees_url":"https://api.github.com/repos/baldurk/renderdoc/assignees{/user}","branches_url":"https://api.github.com/repos/baldurk/renderdoc/branches{/branch}","tags_url":"https://api.github.com/repos/baldurk/renderdoc/tags","blobs_url":"https://api.github.com/repos/baldurk/renderdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baldurk/renderdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baldurk/renderdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/baldurk/renderdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baldurk/renderdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/baldurk/renderdoc/languages","stargazers_url":"https://api.github.com/repos/baldurk/renderdoc/stargazers","contributors_url":"https://api.github.com/repos/baldurk/renderdoc/contributors","subscribers_url":"https://api.github.com/repos/baldurk/renderdoc/subscribers","subscription_url":"https://api.github.com/repos/baldurk/renderdoc/subscription","commits_url":"https://api.github.com/repos/baldurk/renderdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/baldurk/renderdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/baldurk/renderdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/baldurk/renderdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/baldurk/renderdoc/contents/{+path}","compare_url":"https://api.github.com/repos/baldurk/renderdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baldurk/renderdoc/merges","archive_url":"https://api.github.com/repos/baldurk/renderdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baldurk/renderdoc/downloads","issues_url":"https://api.github.com/repos/baldurk/renderdoc/issues{/number}","pulls_url":"https://api.github.com/repos/baldurk/renderdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/baldurk/renderdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/baldurk/renderdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baldurk/renderdoc/labels{/name}","releases_url":"https://api.github.com/repos/baldurk/renderdoc/releases{/id}","deployments_url":"https://api.github.com/repos/baldurk/renderdoc/deployments","created_at":"2014-02-27T15:16:30Z","updated_at":"2017-10-11T06:26:46Z","pushed_at":"2017-10-11T10:26:18Z","git_url":"git://github.com/baldurk/renderdoc.git","ssh_url":"git@github.com:baldurk/renderdoc.git","clone_url":"https://github.com/baldurk/renderdoc.git","svn_url":"https://github.com/baldurk/renderdoc","homepage":"https://renderdoc.org","size":38076,"stargazers_count":2004,"watchers_count":2004,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":58,"forks":294,"open_issues":58,"watchers":2004,"default_branch":"v0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/768"},"html":{"href":"https://github.com/baldurk/renderdoc/pull/768"},"issue":{"href":"https://api.github.com/repos/baldurk/renderdoc/issues/768"},"comments":{"href":"https://api.github.com/repos/baldurk/renderdoc/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/baldurk/renderdoc/statuses/1ecbab85a9b6293e63bb09d6b44abc23daf9ef0f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"baldurk","id":661798,"avatar_url":"https://avatars3.githubusercontent.com/u/661798?v=4","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":46,"deletions":21,"changed_files":10}}
{"actor":{"display_login":"baldurk"}}