{"action":"created","issue":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/9166","repository_url":"https://api.github.com/repos/EFForg/https-everywhere","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/9166/labels{/name}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/9166/comments","events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/9166/events","html_url":"https://github.com/EFForg/https-everywhere/issues/9166","id":215689320,"number":9166,"title":"Clean up duplicate-whitelist.txt","user":{"login":"Bisaloo","id":10783929,"avatar_url":"https://avatars3.githubusercontent.com/u/10783929?v=3","gravatar_id":"","url":"https://api.github.com/users/Bisaloo","html_url":"https://github.com/Bisaloo","followers_url":"https://api.github.com/users/Bisaloo/followers","following_url":"https://api.github.com/users/Bisaloo/following{/other_user}","gists_url":"https://api.github.com/users/Bisaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisaloo/subscriptions","organizations_url":"https://api.github.com/users/Bisaloo/orgs","repos_url":"https://api.github.com/users/Bisaloo/repos","events_url":"https://api.github.com/users/Bisaloo/events{/privacy}","received_events_url":"https://api.github.com/users/Bisaloo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-21T10:23:21Z","updated_at":"2017-03-21T15:00:18Z","closed_at":null,"body":"The file [`duplicate-whitelist.txt`](https://github.com/EFForg/https-everywhere/blob/master/utils/duplicate-whitelist.txt) has outdated entries. \r\n\r\nFor example, [`elementaryos.org`](https://github.com/EFForg/https-everywhere/blob/master/utils/duplicate-whitelist.txt#L79) doesn't seem to be an issue anymore ([proof](https://www.eff.org/https-everywhere/atlas/?elementaryos.org)).\r\n\r\nI think it's difficult to ask contributors to know about this file and to think about checking it each time they submit a PR.\r\n\r\nThe best solution in my opinion would be to have an automated way to update this file. Two options come to mind:\r\n- a script that run on a regular basis and remove outdated entries\r\n- a small addition to travis checks to ask the contributor to remove an entry if it is in the whitelist but that's not needed after their changes."},"comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments/288106019","html_url":"https://github.com/EFForg/https-everywhere/issues/9166#issuecomment-288106019","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/9166","id":288106019,"user":{"login":"jeremyn","id":299895,"avatar_url":"https://avatars2.githubusercontent.com/u/299895?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyn","html_url":"https://github.com/jeremyn","followers_url":"https://api.github.com/users/jeremyn/followers","following_url":"https://api.github.com/users/jeremyn/following{/other_user}","gists_url":"https://api.github.com/users/jeremyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyn/subscriptions","organizations_url":"https://api.github.com/users/jeremyn/orgs","repos_url":"https://api.github.com/users/jeremyn/repos","events_url":"https://api.github.com/users/jeremyn/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyn/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T15:00:18Z","updated_at":"2017-03-21T15:00:18Z","body":"We have a script that removes whitelist entries, [`utils/ruleset-coverage-whitelist-cleanup.sh`](https://github.com/EFForg/https-everywhere/blob/83d2966432c03a9e0df2f21acfa60e5754cf850f/utils/ruleset-coverage-whitelist-cleanup.sh). The normal process it that someone runs it every now and then, which you can see looking through [past issues and pull requests](https://github.com/EFForg/https-everywhere/search?q=whitelist&type=Issues&utf8=%E2%9C%93).\r\n\r\nIt's not really urgent to clean up the file. We should not confuse contributors by asking them to modify that file for each pull request."}}
{"actor":{"display_login":"jeremyn"}}