{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-form/pulls/comments/95906896","pull_request_review_id":16478563,"id":95906896,"diff_hunk":"@@ -502,13 +502,16 @@ Now, let's create a zend-mvc controller action:\n      $form = new CreateProduct();\n      $product = new Product();\n      $form->bind($product);\n-\n      $request = $this->getRequest();\n+     $form->setAttribute('action',$request->getRequestUri());","path":"doc/book/collections.md","position":42,"original_position":42,"commit_id":"81e344d41877fb2f7f049d1c049adafcd425cac2","original_commit_id":"81e344d41877fb2f7f049d1c049adafcd425cac2","user":{"login":"froschdesign","id":103362,"avatar_url":"https://avatars.githubusercontent.com/u/103362?v=3","gravatar_id":"","url":"https://api.github.com/users/froschdesign","html_url":"https://github.com/froschdesign","followers_url":"https://api.github.com/users/froschdesign/followers","following_url":"https://api.github.com/users/froschdesign/following{/other_user}","gists_url":"https://api.github.com/users/froschdesign/gists{/gist_id}","starred_url":"https://api.github.com/users/froschdesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froschdesign/subscriptions","organizations_url":"https://api.github.com/users/froschdesign/orgs","repos_url":"https://api.github.com/users/froschdesign/repos","events_url":"https://api.github.com/users/froschdesign/events{/privacy}","received_events_url":"https://api.github.com/users/froschdesign/received_events","type":"User","site_admin":false},"body":"Please remove this. The `url`-helper was good in the view script. The helper used in some more examples.","created_at":"2017-01-12T23:12:08Z","updated_at":"2017-01-12T23:20:06Z","html_url":"https://github.com/zendframework/zend-form/pull/133#discussion_r95906896","pull_request_url":"https://api.github.com/repos/zendframework/zend-form/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/comments/95906896"},"html":{"href":"https://github.com/zendframework/zend-form/pull/133#discussion_r95906896"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-form/pulls/133","id":101321564,"html_url":"https://github.com/zendframework/zend-form/pull/133","diff_url":"https://github.com/zendframework/zend-form/pull/133.diff","patch_url":"https://github.com/zendframework/zend-form/pull/133.patch","issue_url":"https://api.github.com/repos/zendframework/zend-form/issues/133","number":133,"state":"open","locked":false,"title":"fix mistakes, suggest improvements in collections.md","user":{"login":"davidmintz","id":9851159,"avatar_url":"https://avatars.githubusercontent.com/u/9851159?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmintz","html_url":"https://github.com/davidmintz","followers_url":"https://api.github.com/users/davidmintz/followers","following_url":"https://api.github.com/users/davidmintz/following{/other_user}","gists_url":"https://api.github.com/users/davidmintz/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmintz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmintz/subscriptions","organizations_url":"https://api.github.com/users/davidmintz/orgs","repos_url":"https://api.github.com/users/davidmintz/repos","events_url":"https://api.github.com/users/davidmintz/events{/privacy}","received_events_url":"https://api.github.com/users/davidmintz/received_events","type":"User","site_admin":false},"body":"specifically,  I have:\r\n\r\n- fixed references to  Zend\\Stdlib\\Hydrator\\ClassMethods\r\n- fixed a typo allws -> allows\r\n- suggested a line in the controller to set the form's action attribute to submit to itself rather setting it to the 'home'  route in the viewscript\r\n- in the controller, wrapped the var_dump() in <pre> tags for legibility\r\n- fixed a syntax error in the ProductFieldset getInputerFilterSpecification() (an array was opened with the old syntax but closed with the new)\r\n- removed a line from the viewscript that gratuitously re-renders $this->formRow($product->get('name'));\r\n\r\nAs a side note, I was going to propose a revision to the part about not being able to submit the form with a Collection having fewer elements than it began with. I am not sure that's the case. The 'allow_remove' option seems to be just for that. But I haven't been able to prove it because at the moment I am struggling with my Doctrine and can't get it to remove entities from the N side of my 1:N.\r\n\r\nHope this helps :-)","created_at":"2017-01-12T19:13:18Z","updated_at":"2017-01-12T23:20:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f696900c577302eb817ccdd556c3755ddc574b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-form/pulls/133/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-form/pulls/133/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-form/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-form/issues/133/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-form/statuses/81e344d41877fb2f7f049d1c049adafcd425cac2","head":{"label":"davidmintz:davidmintz-patch-1","ref":"davidmintz-patch-1","sha":"81e344d41877fb2f7f049d1c049adafcd425cac2","user":{"login":"davidmintz","id":9851159,"avatar_url":"https://avatars.githubusercontent.com/u/9851159?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmintz","html_url":"https://github.com/davidmintz","followers_url":"https://api.github.com/users/davidmintz/followers","following_url":"https://api.github.com/users/davidmintz/following{/other_user}","gists_url":"https://api.github.com/users/davidmintz/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmintz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmintz/subscriptions","organizations_url":"https://api.github.com/users/davidmintz/orgs","repos_url":"https://api.github.com/users/davidmintz/repos","events_url":"https://api.github.com/users/davidmintz/events{/privacy}","received_events_url":"https://api.github.com/users/davidmintz/received_events","type":"User","site_admin":false},"repo":{"id":78756804,"name":"zend-form","full_name":"davidmintz/zend-form","owner":{"login":"davidmintz","id":9851159,"avatar_url":"https://avatars.githubusercontent.com/u/9851159?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmintz","html_url":"https://github.com/davidmintz","followers_url":"https://api.github.com/users/davidmintz/followers","following_url":"https://api.github.com/users/davidmintz/following{/other_user}","gists_url":"https://api.github.com/users/davidmintz/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmintz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmintz/subscriptions","organizations_url":"https://api.github.com/users/davidmintz/orgs","repos_url":"https://api.github.com/users/davidmintz/repos","events_url":"https://api.github.com/users/davidmintz/events{/privacy}","received_events_url":"https://api.github.com/users/davidmintz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidmintz/zend-form","description":"Form component from Zend Framework","fork":true,"url":"https://api.github.com/repos/davidmintz/zend-form","forks_url":"https://api.github.com/repos/davidmintz/zend-form/forks","keys_url":"https://api.github.com/repos/davidmintz/zend-form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidmintz/zend-form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidmintz/zend-form/teams","hooks_url":"https://api.github.com/repos/davidmintz/zend-form/hooks","issue_events_url":"https://api.github.com/repos/davidmintz/zend-form/issues/events{/number}","events_url":"https://api.github.com/repos/davidmintz/zend-form/events","assignees_url":"https://api.github.com/repos/davidmintz/zend-form/assignees{/user}","branches_url":"https://api.github.com/repos/davidmintz/zend-form/branches{/branch}","tags_url":"https://api.github.com/repos/davidmintz/zend-form/tags","blobs_url":"https://api.github.com/repos/davidmintz/zend-form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidmintz/zend-form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidmintz/zend-form/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidmintz/zend-form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidmintz/zend-form/statuses/{sha}","languages_url":"https://api.github.com/repos/davidmintz/zend-form/languages","stargazers_url":"https://api.github.com/repos/davidmintz/zend-form/stargazers","contributors_url":"https://api.github.com/repos/davidmintz/zend-form/contributors","subscribers_url":"https://api.github.com/repos/davidmintz/zend-form/subscribers","subscription_url":"https://api.github.com/repos/davidmintz/zend-form/subscription","commits_url":"https://api.github.com/repos/davidmintz/zend-form/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidmintz/zend-form/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidmintz/zend-form/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidmintz/zend-form/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidmintz/zend-form/contents/{+path}","compare_url":"https://api.github.com/repos/davidmintz/zend-form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidmintz/zend-form/merges","archive_url":"https://api.github.com/repos/davidmintz/zend-form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidmintz/zend-form/downloads","issues_url":"https://api.github.com/repos/davidmintz/zend-form/issues{/number}","pulls_url":"https://api.github.com/repos/davidmintz/zend-form/pulls{/number}","milestones_url":"https://api.github.com/repos/davidmintz/zend-form/milestones{/number}","notifications_url":"https://api.github.com/repos/davidmintz/zend-form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidmintz/zend-form/labels{/name}","releases_url":"https://api.github.com/repos/davidmintz/zend-form/releases{/id}","deployments_url":"https://api.github.com/repos/davidmintz/zend-form/deployments","created_at":"2017-01-12T15:03:17Z","updated_at":"2017-01-12T15:03:20Z","pushed_at":"2017-01-12T19:09:17Z","git_url":"git://github.com/davidmintz/zend-form.git","ssh_url":"git@github.com:davidmintz/zend-form.git","clone_url":"https://github.com/davidmintz/zend-form.git","svn_url":"https://github.com/davidmintz/zend-form","homepage":"https://zendframework.github.io/zend-form/","size":6191,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"3a5eb983ffe3fd99570f9241cc09443c433d22e1","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280804,"name":"zend-form","full_name":"zendframework/zend-form","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-form","description":"Form component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-form","forks_url":"https://api.github.com/repos/zendframework/zend-form/forks","keys_url":"https://api.github.com/repos/zendframework/zend-form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-form/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-form/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-form/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-form/events","assignees_url":"https://api.github.com/repos/zendframework/zend-form/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-form/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-form/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-form/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-form/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-form/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-form/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-form/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-form/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-form/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-form/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-form/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-form/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-form/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-form/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-form/merges","archive_url":"https://api.github.com/repos/zendframework/zend-form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-form/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-form/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-form/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-form/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-form/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-form/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-form/deployments","created_at":"2015-05-08T13:27:59Z","updated_at":"2016-11-17T08:35:22Z","pushed_at":"2017-01-12T19:13:19Z","git_url":"git://github.com/zendframework/zend-form.git","ssh_url":"git@github.com:zendframework/zend-form.git","clone_url":"https://github.com/zendframework/zend-form.git","svn_url":"https://github.com/zendframework/zend-form","homepage":"https://zendframework.github.io/zend-form/","size":6189,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":51,"forks":58,"open_issues":51,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/133"},"html":{"href":"https://github.com/zendframework/zend-form/pull/133"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-form/issues/133"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-form/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-form/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-form/statuses/81e344d41877fb2f7f049d1c049adafcd425cac2"}}}}
{"actor":{"display_login":"froschdesign"}}