{"push_id":1538083718,"size":4,"distinct_size":1,"ref":"refs/heads/master","head":"f1d6ff63bd2c4d7b550ff7468edc15cb932394ac","before":"8b30c7c066ee268830e3480656aa684789758145","commits":[{"sha":"5f77f3f154df58994e57f54c13b11fe0c7fb1c86","author":{"name":"Jonathan Riddell","email":"d0fc5210db18cabefebb572fe08d19873ff09f9f@jriddell.org"},"message":"Update version number for 5.9.0\nGIT_SILENT","distinct":false,"url":"https://api.github.com/repos/KDE/ksshaskpass/commits/5f77f3f154df58994e57f54c13b11fe0c7fb1c86"},{"sha":"9dbabcb38862c1590503169be3ae7806e6673dba","author":{"name":"Mikhail Yakshin","email":"2109891f1099cb58c484f2d20f51b082fb40615b@gmail.com"},"message":"Fix several problems in algorithm of deriving key filename from a prompt message supplied by ssh-add\n\nFix an algorithm of deriving key filename from a prompt message\nsupplied by ssh-add: should fix problems with spaces in key file\nnames, using `-c` option of `ssh-add` and fix extra space in KWallet\nkey name.\n\nObviously, it's a bad thing to do (especially given that nobody\nguarantees that ssh-add won't use another set of messages someday or\nit will be i18ned), but (1) there seem to be no workaround for it as\nof now, (2) current version of ksshaskpass relies on it anyway, (3)\nthe algorithm is very broken.\n\nCurrent algorithm relies on splitting a prompt string by spaces and\nextracting certain nth fragment, counting from the end of\nsequence. There are several major issues with it:\n\n* When using `ssh-add -c`, the message would be `Enter passphrase for\n  /home/user/path/to/key (will confirm each use): `, thus current\n  algorithm will extract `use) ` as a key file name, which is\n  obviously wrong. It's a hideous bug that goes unnoticed for the\n  majority of the people who either (a) do not use `-c` option, or (b)\n  do not use more than 1 ssh key.\n* Splitting by spaces obviously breaks on key filename that contain\n  spaces. Again, it mostly goes unnoticed by vast majority of the\n  users.\n* It generates extra space at the end of key filename, i.e. it\n  generates `/home/user/.ssh/id_rsa ` instead of\n  `/home/user/.ssh/id_rsa`. Not critical, but undermines efforts to\n  get key passphrase by filename in KWallet.\n\nProposed algorithm is clearly extracted in a distinct function and\nclearly analyses 3 cases by rigid regexp patterns. In case if regexps\nwould fail, it issues a warning (seems like a good idea, so at least\nit won't go completely unnoticed if it will break in future).\n\nTested it with all inputs that seem to be generated by ssh-add:\n\n    Enter passphrase for /home/user with space/.ssh/id_dsa (will confirm each use):\n    Bad passphrase, try again for /home/user with space/.ssh/id_dsa (will confirm each use):\n    Enter passphrase for /home/user with space/.ssh/id_dsa:\n    Bad passphrase, try again for /home/user with space/.ssh/id_dsa:\n\nREVIEW: 127569","distinct":false,"url":"https://api.github.com/repos/KDE/ksshaskpass/commits/9dbabcb38862c1590503169be3ae7806e6673dba"},{"sha":"bac379cde0e12b2fbe409959fd23f44913f9d3bb","author":{"name":"Mikhail Yakshin","email":"2109891f1099cb58c484f2d20f51b082fb40615b@gmail.com"},"message":"Workaround for keys stored with an extra space at the end","distinct":false,"url":"https://api.github.com/repos/KDE/ksshaskpass/commits/bac379cde0e12b2fbe409959fd23f44913f9d3bb"},{"sha":"f1d6ff63bd2c4d7b550ff7468edc15cb932394ac","author":{"name":"Albert Astals Cid","email":"ddf42c60aabe61764ce6fd4e5e27820dcb5f6f51@kde.org"},"message":"Merge remote-tracking branch 'origin/Plasma/5.9'","distinct":true,"url":"https://api.github.com/repos/KDE/ksshaskpass/commits/f1d6ff63bd2c4d7b550ff7468edc15cb932394ac"}]}
{"actor":{"display_login":"kdesysadmin"}}