{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10","id":121110697,"html_url":"https://github.com/swcraig/chess-stembolt/pull/10","diff_url":"https://github.com/swcraig/chess-stembolt/pull/10.diff","patch_url":"https://github.com/swcraig/chess-stembolt/pull/10.patch","issue_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/10","number":10,"state":"closed","locked":false,"title":"Rook move","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"body":"Similar to the implementation on `Pawn`, `possible_moves` iterates all possible moves.  The future `Move` class will pass the `side_length` parameter to the `Rook` so that we don't iterate forever.\r\n\r\nI also added an exclude to Rubocop cop for now.  It is upset about the method length of `possible_moves`.  Most likely `possible_moves` will be refactored in the future, and it only over the length limit by one line.  If you see an obvious quick-fix please let me know!","created_at":"2017-05-17T17:23:09Z","updated_at":"2017-05-17T20:46:39Z","closed_at":"2017-05-17T20:46:38Z","merged_at":"2017-05-17T20:46:38Z","merge_commit_sha":"4bdae5e6685ff256d9ba7dc74e919133eaa7e0e2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10/commits","review_comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10/comments","review_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/10/comments","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/20a8238af312720ff3be2e0bf96217115eb6a691","head":{"label":"swcraig:rook-move","ref":"rook-move","sha":"20a8238af312720ff3be2e0bf96217115eb6a691","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"repo":{"id":90405359,"name":"chess-stembolt","full_name":"swcraig/chess-stembolt","owner":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swcraig/chess-stembolt","description":":white_square_button: ","fork":false,"url":"https://api.github.com/repos/swcraig/chess-stembolt","forks_url":"https://api.github.com/repos/swcraig/chess-stembolt/forks","keys_url":"https://api.github.com/repos/swcraig/chess-stembolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcraig/chess-stembolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcraig/chess-stembolt/teams","hooks_url":"https://api.github.com/repos/swcraig/chess-stembolt/hooks","issue_events_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/events{/number}","events_url":"https://api.github.com/repos/swcraig/chess-stembolt/events","assignees_url":"https://api.github.com/repos/swcraig/chess-stembolt/assignees{/user}","branches_url":"https://api.github.com/repos/swcraig/chess-stembolt/branches{/branch}","tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/tags","blobs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/{sha}","languages_url":"https://api.github.com/repos/swcraig/chess-stembolt/languages","stargazers_url":"https://api.github.com/repos/swcraig/chess-stembolt/stargazers","contributors_url":"https://api.github.com/repos/swcraig/chess-stembolt/contributors","subscribers_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscribers","subscription_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscription","commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcraig/chess-stembolt/contents/{+path}","compare_url":"https://api.github.com/repos/swcraig/chess-stembolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcraig/chess-stembolt/merges","archive_url":"https://api.github.com/repos/swcraig/chess-stembolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcraig/chess-stembolt/downloads","issues_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues{/number}","pulls_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls{/number}","milestones_url":"https://api.github.com/repos/swcraig/chess-stembolt/milestones{/number}","notifications_url":"https://api.github.com/repos/swcraig/chess-stembolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcraig/chess-stembolt/labels{/name}","releases_url":"https://api.github.com/repos/swcraig/chess-stembolt/releases{/id}","deployments_url":"https://api.github.com/repos/swcraig/chess-stembolt/deployments","created_at":"2017-05-05T18:28:41Z","updated_at":"2017-05-15T18:04:00Z","pushed_at":"2017-05-17T20:46:38Z","git_url":"git://github.com/swcraig/chess-stembolt.git","ssh_url":"git@github.com:swcraig/chess-stembolt.git","clone_url":"https://github.com/swcraig/chess-stembolt.git","svn_url":"https://github.com/swcraig/chess-stembolt","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"swcraig:dev","ref":"dev","sha":"934101630370f69615a9901d990889fce0a72d6f","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"repo":{"id":90405359,"name":"chess-stembolt","full_name":"swcraig/chess-stembolt","owner":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swcraig/chess-stembolt","description":":white_square_button: ","fork":false,"url":"https://api.github.com/repos/swcraig/chess-stembolt","forks_url":"https://api.github.com/repos/swcraig/chess-stembolt/forks","keys_url":"https://api.github.com/repos/swcraig/chess-stembolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcraig/chess-stembolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcraig/chess-stembolt/teams","hooks_url":"https://api.github.com/repos/swcraig/chess-stembolt/hooks","issue_events_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/events{/number}","events_url":"https://api.github.com/repos/swcraig/chess-stembolt/events","assignees_url":"https://api.github.com/repos/swcraig/chess-stembolt/assignees{/user}","branches_url":"https://api.github.com/repos/swcraig/chess-stembolt/branches{/branch}","tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/tags","blobs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/{sha}","languages_url":"https://api.github.com/repos/swcraig/chess-stembolt/languages","stargazers_url":"https://api.github.com/repos/swcraig/chess-stembolt/stargazers","contributors_url":"https://api.github.com/repos/swcraig/chess-stembolt/contributors","subscribers_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscribers","subscription_url":"https://api.github.com/repos/swcraig/chess-stembolt/subscription","commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcraig/chess-stembolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcraig/chess-stembolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcraig/chess-stembolt/contents/{+path}","compare_url":"https://api.github.com/repos/swcraig/chess-stembolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcraig/chess-stembolt/merges","archive_url":"https://api.github.com/repos/swcraig/chess-stembolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcraig/chess-stembolt/downloads","issues_url":"https://api.github.com/repos/swcraig/chess-stembolt/issues{/number}","pulls_url":"https://api.github.com/repos/swcraig/chess-stembolt/pulls{/number}","milestones_url":"https://api.github.com/repos/swcraig/chess-stembolt/milestones{/number}","notifications_url":"https://api.github.com/repos/swcraig/chess-stembolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcraig/chess-stembolt/labels{/name}","releases_url":"https://api.github.com/repos/swcraig/chess-stembolt/releases{/id}","deployments_url":"https://api.github.com/repos/swcraig/chess-stembolt/deployments","created_at":"2017-05-05T18:28:41Z","updated_at":"2017-05-15T18:04:00Z","pushed_at":"2017-05-17T20:46:38Z","git_url":"git://github.com/swcraig/chess-stembolt.git","ssh_url":"git@github.com:swcraig/chess-stembolt.git","clone_url":"https://github.com/swcraig/chess-stembolt.git","svn_url":"https://github.com/swcraig/chess-stembolt","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10"},"html":{"href":"https://github.com/swcraig/chess-stembolt/pull/10"},"issue":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/issues/10"},"comments":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/swcraig/chess-stembolt/statuses/20a8238af312720ff3be2e0bf96217115eb6a691"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars0.githubusercontent.com/u/11495200?v=3","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":43,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"swcraig"}}