{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/payment-request/pulls/comments/135436699","pull_request_review_id":58847547,"id":135436699,"diff_hunk":"@@ -2400,13 +2405,59 @@\n           <h2>\n             <dfn data-lt=\"updateWith(detailsPromise)\">updateWith()</dfn> method\n           </h2>\n-          <p class=\"note\">\n-            If a developer wants to update the payment request, then they need\n-            to call <a>updateWith()</a> and provide a\n-            <a>PaymentDetailsUpdate</a> dictionary, or a promise for one,\n-            containing changed values that the <a>user agent</a> presents to\n-            the user.\n-          </p>\n+          <aside class=\"note\">\n+            <p>\n+              If a developer wants to update the payment request, then they\n+              need to call <a>updateWith()</a> and provide a\n+              <a>PaymentDetailsUpdate</a> dictionary, or a promise for one,\n+              containing changed values that the <a>user agent</a> presents to\n+              the user.\n+            </p>\n+            <p>\n+              To prevent the user interface from blocking (and to reflect\n+              changes made by the end-user through the UI), developers need to\n+              immediately call <a>updateWith()</a>. If they don't,\n+              <a>[[\\didUpdate]]</a> becomes true and <a>updateWith()</a>\n+              will throw.\n+            </p>\n+            <pre class=\"example\" title=\"how to use `updateWith()` correctly.\">\n+              // ❌ Bad - this won't work!\n+              request.onshippingaddresschange = async ev =&gt; {\n+                // `await` goes to next tick, so [[didUpdate]] is now true.","path":"index.html","position":80,"original_position":80,"commit_id":"8c51a4d5cf552ba9c5db1503b0408a58e9202b94","original_commit_id":"8c51a4d5cf552ba9c5db1503b0408a58e9202b94","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"I know... \"didUpdate\" is not a great name... I wanted something that denoted \"consumed\" or \"expired\" or \"this can't be used again\". I'm open to suggestions. ","created_at":"2017-08-28T03:36:11Z","updated_at":"2017-08-28T03:36:11Z","html_url":"https://github.com/w3c/payment-request/pull/591#discussion_r135436699","pull_request_url":"https://api.github.com/repos/w3c/payment-request/pulls/591","_links":{"self":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/comments/135436699"},"html":{"href":"https://github.com/w3c/payment-request/pull/591#discussion_r135436699"},"pull_request":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/591"}},"in_reply_to_id":135351268},"pull_request":{"url":"https://api.github.com/repos/w3c/payment-request/pulls/591","id":136905927,"html_url":"https://github.com/w3c/payment-request/pull/591","diff_url":"https://github.com/w3c/payment-request/pull/591.diff","patch_url":"https://github.com/w3c/payment-request/pull/591.patch","issue_url":"https://api.github.com/repos/w3c/payment-request/issues/591","number":591,"state":"open","locked":false,"title":"Dont block UI if .updateWith() not called (closes #589)","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n[Preview](https://s3.amazonaws.com/pr-preview/w3c/payment-request/cancel_flag.html) | [Diff](https://s3.amazonaws.com/pr-preview/w3c/payment-request/d81183e...8c51a4d.html)","created_at":"2017-08-22T07:08:06Z","updated_at":"2017-08-28T03:36:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"973a2103f507706cf72a16213c3a3c3fc149d9b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/payment-request/pulls/591/commits","review_comments_url":"https://api.github.com/repos/w3c/payment-request/pulls/591/comments","review_comment_url":"https://api.github.com/repos/w3c/payment-request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/payment-request/issues/591/comments","statuses_url":"https://api.github.com/repos/w3c/payment-request/statuses/8c51a4d5cf552ba9c5db1503b0408a58e9202b94","head":{"label":"w3c:cancel_flag","ref":"cancel_flag","sha":"8c51a4d5cf552ba9c5db1503b0408a58e9202b94","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":52568788,"name":"payment-request","full_name":"w3c/payment-request","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/payment-request","description":"W3C Web Payments Browser API","fork":false,"url":"https://api.github.com/repos/w3c/payment-request","forks_url":"https://api.github.com/repos/w3c/payment-request/forks","keys_url":"https://api.github.com/repos/w3c/payment-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/payment-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/payment-request/teams","hooks_url":"https://api.github.com/repos/w3c/payment-request/hooks","issue_events_url":"https://api.github.com/repos/w3c/payment-request/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/payment-request/events","assignees_url":"https://api.github.com/repos/w3c/payment-request/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/payment-request/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/payment-request/tags","blobs_url":"https://api.github.com/repos/w3c/payment-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/payment-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/payment-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/payment-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/payment-request/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/payment-request/languages","stargazers_url":"https://api.github.com/repos/w3c/payment-request/stargazers","contributors_url":"https://api.github.com/repos/w3c/payment-request/contributors","subscribers_url":"https://api.github.com/repos/w3c/payment-request/subscribers","subscription_url":"https://api.github.com/repos/w3c/payment-request/subscription","commits_url":"https://api.github.com/repos/w3c/payment-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/payment-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/payment-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/payment-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/payment-request/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/payment-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/payment-request/merges","archive_url":"https://api.github.com/repos/w3c/payment-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/payment-request/downloads","issues_url":"https://api.github.com/repos/w3c/payment-request/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/payment-request/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/payment-request/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/payment-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/payment-request/labels{/name}","releases_url":"https://api.github.com/repos/w3c/payment-request/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/payment-request/deployments","created_at":"2016-02-26T01:12:49Z","updated_at":"2017-08-23T07:36:10Z","pushed_at":"2017-08-25T06:48:31Z","git_url":"git://github.com/w3c/payment-request.git","ssh_url":"git@github.com:w3c/payment-request.git","clone_url":"https://github.com/w3c/payment-request.git","svn_url":"https://github.com/w3c/payment-request","homepage":"https://www.w3.org/TR/payment-request/","size":994,"stargazers_count":166,"watchers_count":166,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":45,"forks":45,"open_issues":45,"watchers":166,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"d81183ea174efc333e39264452c791891c13b4a6","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":52568788,"name":"payment-request","full_name":"w3c/payment-request","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/payment-request","description":"W3C Web Payments Browser API","fork":false,"url":"https://api.github.com/repos/w3c/payment-request","forks_url":"https://api.github.com/repos/w3c/payment-request/forks","keys_url":"https://api.github.com/repos/w3c/payment-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/payment-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/payment-request/teams","hooks_url":"https://api.github.com/repos/w3c/payment-request/hooks","issue_events_url":"https://api.github.com/repos/w3c/payment-request/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/payment-request/events","assignees_url":"https://api.github.com/repos/w3c/payment-request/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/payment-request/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/payment-request/tags","blobs_url":"https://api.github.com/repos/w3c/payment-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/payment-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/payment-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/payment-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/payment-request/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/payment-request/languages","stargazers_url":"https://api.github.com/repos/w3c/payment-request/stargazers","contributors_url":"https://api.github.com/repos/w3c/payment-request/contributors","subscribers_url":"https://api.github.com/repos/w3c/payment-request/subscribers","subscription_url":"https://api.github.com/repos/w3c/payment-request/subscription","commits_url":"https://api.github.com/repos/w3c/payment-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/payment-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/payment-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/payment-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/payment-request/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/payment-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/payment-request/merges","archive_url":"https://api.github.com/repos/w3c/payment-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/payment-request/downloads","issues_url":"https://api.github.com/repos/w3c/payment-request/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/payment-request/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/payment-request/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/payment-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/payment-request/labels{/name}","releases_url":"https://api.github.com/repos/w3c/payment-request/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/payment-request/deployments","created_at":"2016-02-26T01:12:49Z","updated_at":"2017-08-23T07:36:10Z","pushed_at":"2017-08-25T06:48:31Z","git_url":"git://github.com/w3c/payment-request.git","ssh_url":"git@github.com:w3c/payment-request.git","clone_url":"https://github.com/w3c/payment-request.git","svn_url":"https://github.com/w3c/payment-request","homepage":"https://www.w3.org/TR/payment-request/","size":994,"stargazers_count":166,"watchers_count":166,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":45,"forks":45,"open_issues":45,"watchers":166,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/591"},"html":{"href":"https://github.com/w3c/payment-request/pull/591"},"issue":{"href":"https://api.github.com/repos/w3c/payment-request/issues/591"},"comments":{"href":"https://api.github.com/repos/w3c/payment-request/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/payment-request/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/payment-request/statuses/8c51a4d5cf552ba9c5db1503b0408a58e9202b94"}}}}
{"actor":{"display_login":"marcoscaceres"}}