{"action":"created","comment":{"url":"https://api.github.com/repos/rsl/stringex/pulls/comments/128020886","pull_request_review_id":50661340,"id":128020886,"diff_hunk":"@@ -177,6 +177,22 @@ def test_should_only_create_unique_urls_for_multiple_scopes_if_both_attributes_a\n     assert_not_equal @doc.url, @other_doc.url\n   end\n \n+  def test_should_create_uniuque_urls_for_nil_scope_values\n+    Document.class_eval do\n+      acts_as_url :title, scope: %i[other, another]","path":"test/unit/acts_as_url_integration_test.rb","position":6,"original_position":6,"commit_id":"e43290f39f37cd0939869fdeda9fa430e0b8a40d","original_commit_id":"e43290f39f37cd0939869fdeda9fa430e0b8a40d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Within %i/%I, ':' and ',' are unnecessary and may be unwanted in the resulting symbols.","created_at":"2017-07-18T16:05:19Z","updated_at":"2017-07-18T16:05:19Z","html_url":"https://github.com/rsl/stringex/pull/198#discussion_r128020886","pull_request_url":"https://api.github.com/repos/rsl/stringex/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/rsl/stringex/pulls/comments/128020886"},"html":{"href":"https://github.com/rsl/stringex/pull/198#discussion_r128020886"},"pull_request":{"href":"https://api.github.com/repos/rsl/stringex/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/rsl/stringex/pulls/198","id":131124959,"html_url":"https://github.com/rsl/stringex/pull/198","diff_url":"https://github.com/rsl/stringex/pull/198.diff","patch_url":"https://github.com/rsl/stringex/pull/198.patch","issue_url":"https://api.github.com/repos/rsl/stringex/issues/198","number":198,"state":"open","locked":false,"title":"Add support for nil scope values (such as deleted_at), with unit test","user":{"login":"masonhale","id":69448,"avatar_url":"https://avatars3.githubusercontent.com/u/69448?v=4","gravatar_id":"","url":"https://api.github.com/users/masonhale","html_url":"https://github.com/masonhale","followers_url":"https://api.github.com/users/masonhale/followers","following_url":"https://api.github.com/users/masonhale/following{/other_user}","gists_url":"https://api.github.com/users/masonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/masonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masonhale/subscriptions","organizations_url":"https://api.github.com/users/masonhale/orgs","repos_url":"https://api.github.com/users/masonhale/repos","events_url":"https://api.github.com/users/masonhale/events{/privacy}","received_events_url":"https://api.github.com/users/masonhale/received_events","type":"User","site_admin":false},"body":"Current scope implementation fails if one or more of the scope attribute values is nil.\r\n\r\nOne may want to use nullable values as scope parameters when using stringex/acts_as_url in combination with a 'soft-delete' solution such as https://github.com/JackDanger/permanent_records\r\n\r\nIn this case, 'live' records will have a nil value for the deleted_at column, but deleted records will have a specific value. By including the deleted_at column in the acts_as_url scope, one can ensure that url slugs for live records will be unique, while also avoiding having 'deleted' records polluting the available URL space.\r\n","created_at":"2017-07-18T15:57:22Z","updated_at":"2017-07-18T16:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5fa52a36ef6ebadf98fec82161cf36ad194588","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsl/stringex/pulls/198/commits","review_comments_url":"https://api.github.com/repos/rsl/stringex/pulls/198/comments","review_comment_url":"https://api.github.com/repos/rsl/stringex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsl/stringex/issues/198/comments","statuses_url":"https://api.github.com/repos/rsl/stringex/statuses/e43290f39f37cd0939869fdeda9fa430e0b8a40d","head":{"label":"masonhale:unique-url-with-nil-scope-val","ref":"unique-url-with-nil-scope-val","sha":"e43290f39f37cd0939869fdeda9fa430e0b8a40d","user":{"login":"masonhale","id":69448,"avatar_url":"https://avatars3.githubusercontent.com/u/69448?v=4","gravatar_id":"","url":"https://api.github.com/users/masonhale","html_url":"https://github.com/masonhale","followers_url":"https://api.github.com/users/masonhale/followers","following_url":"https://api.github.com/users/masonhale/following{/other_user}","gists_url":"https://api.github.com/users/masonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/masonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masonhale/subscriptions","organizations_url":"https://api.github.com/users/masonhale/orgs","repos_url":"https://api.github.com/users/masonhale/repos","events_url":"https://api.github.com/users/masonhale/events{/privacy}","received_events_url":"https://api.github.com/users/masonhale/received_events","type":"User","site_admin":false},"repo":{"id":97617232,"name":"stringex","full_name":"masonhale/stringex","owner":{"login":"masonhale","id":69448,"avatar_url":"https://avatars3.githubusercontent.com/u/69448?v=4","gravatar_id":"","url":"https://api.github.com/users/masonhale","html_url":"https://github.com/masonhale","followers_url":"https://api.github.com/users/masonhale/followers","following_url":"https://api.github.com/users/masonhale/following{/other_user}","gists_url":"https://api.github.com/users/masonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/masonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masonhale/subscriptions","organizations_url":"https://api.github.com/users/masonhale/orgs","repos_url":"https://api.github.com/users/masonhale/repos","events_url":"https://api.github.com/users/masonhale/events{/privacy}","received_events_url":"https://api.github.com/users/masonhale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masonhale/stringex","description":"Some [hopefully] useful extensions to Ruby’s String class. It is made up of three libraries: ActsAsUrl [permalink solution with better character translation], Unidecoder [Unicode to Ascii transliteration], and StringExtensions [miscellaneous helper methods for the String class].","fork":true,"url":"https://api.github.com/repos/masonhale/stringex","forks_url":"https://api.github.com/repos/masonhale/stringex/forks","keys_url":"https://api.github.com/repos/masonhale/stringex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masonhale/stringex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masonhale/stringex/teams","hooks_url":"https://api.github.com/repos/masonhale/stringex/hooks","issue_events_url":"https://api.github.com/repos/masonhale/stringex/issues/events{/number}","events_url":"https://api.github.com/repos/masonhale/stringex/events","assignees_url":"https://api.github.com/repos/masonhale/stringex/assignees{/user}","branches_url":"https://api.github.com/repos/masonhale/stringex/branches{/branch}","tags_url":"https://api.github.com/repos/masonhale/stringex/tags","blobs_url":"https://api.github.com/repos/masonhale/stringex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masonhale/stringex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masonhale/stringex/git/refs{/sha}","trees_url":"https://api.github.com/repos/masonhale/stringex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masonhale/stringex/statuses/{sha}","languages_url":"https://api.github.com/repos/masonhale/stringex/languages","stargazers_url":"https://api.github.com/repos/masonhale/stringex/stargazers","contributors_url":"https://api.github.com/repos/masonhale/stringex/contributors","subscribers_url":"https://api.github.com/repos/masonhale/stringex/subscribers","subscription_url":"https://api.github.com/repos/masonhale/stringex/subscription","commits_url":"https://api.github.com/repos/masonhale/stringex/commits{/sha}","git_commits_url":"https://api.github.com/repos/masonhale/stringex/git/commits{/sha}","comments_url":"https://api.github.com/repos/masonhale/stringex/comments{/number}","issue_comment_url":"https://api.github.com/repos/masonhale/stringex/issues/comments{/number}","contents_url":"https://api.github.com/repos/masonhale/stringex/contents/{+path}","compare_url":"https://api.github.com/repos/masonhale/stringex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masonhale/stringex/merges","archive_url":"https://api.github.com/repos/masonhale/stringex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masonhale/stringex/downloads","issues_url":"https://api.github.com/repos/masonhale/stringex/issues{/number}","pulls_url":"https://api.github.com/repos/masonhale/stringex/pulls{/number}","milestones_url":"https://api.github.com/repos/masonhale/stringex/milestones{/number}","notifications_url":"https://api.github.com/repos/masonhale/stringex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masonhale/stringex/labels{/name}","releases_url":"https://api.github.com/repos/masonhale/stringex/releases{/id}","deployments_url":"https://api.github.com/repos/masonhale/stringex/deployments","created_at":"2017-07-18T15:49:28Z","updated_at":"2017-07-18T15:49:29Z","pushed_at":"2017-07-18T16:05:08Z","git_url":"git://github.com/masonhale/stringex.git","ssh_url":"git@github.com:masonhale/stringex.git","clone_url":"https://github.com/masonhale/stringex.git","svn_url":"https://github.com/masonhale/stringex","homepage":"","size":636,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rsl:master","ref":"master","sha":"d2bd2db1264e55b771f790bc6764d7da311b38f6","user":{"login":"rsl","id":92,"avatar_url":"https://avatars0.githubusercontent.com/u/92?v=4","gravatar_id":"","url":"https://api.github.com/users/rsl","html_url":"https://github.com/rsl","followers_url":"https://api.github.com/users/rsl/followers","following_url":"https://api.github.com/users/rsl/following{/other_user}","gists_url":"https://api.github.com/users/rsl/gists{/gist_id}","starred_url":"https://api.github.com/users/rsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsl/subscriptions","organizations_url":"https://api.github.com/users/rsl/orgs","repos_url":"https://api.github.com/users/rsl/repos","events_url":"https://api.github.com/users/rsl/events{/privacy}","received_events_url":"https://api.github.com/users/rsl/received_events","type":"User","site_admin":false},"repo":{"id":765,"name":"stringex","full_name":"rsl/stringex","owner":{"login":"rsl","id":92,"avatar_url":"https://avatars0.githubusercontent.com/u/92?v=4","gravatar_id":"","url":"https://api.github.com/users/rsl","html_url":"https://github.com/rsl","followers_url":"https://api.github.com/users/rsl/followers","following_url":"https://api.github.com/users/rsl/following{/other_user}","gists_url":"https://api.github.com/users/rsl/gists{/gist_id}","starred_url":"https://api.github.com/users/rsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsl/subscriptions","organizations_url":"https://api.github.com/users/rsl/orgs","repos_url":"https://api.github.com/users/rsl/repos","events_url":"https://api.github.com/users/rsl/events{/privacy}","received_events_url":"https://api.github.com/users/rsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsl/stringex","description":"Some [hopefully] useful extensions to Ruby’s String class. It is made up of three libraries: ActsAsUrl [permalink solution with better character translation], Unidecoder [Unicode to Ascii transliteration], and StringExtensions [miscellaneous helper methods for the String class].","fork":false,"url":"https://api.github.com/repos/rsl/stringex","forks_url":"https://api.github.com/repos/rsl/stringex/forks","keys_url":"https://api.github.com/repos/rsl/stringex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsl/stringex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsl/stringex/teams","hooks_url":"https://api.github.com/repos/rsl/stringex/hooks","issue_events_url":"https://api.github.com/repos/rsl/stringex/issues/events{/number}","events_url":"https://api.github.com/repos/rsl/stringex/events","assignees_url":"https://api.github.com/repos/rsl/stringex/assignees{/user}","branches_url":"https://api.github.com/repos/rsl/stringex/branches{/branch}","tags_url":"https://api.github.com/repos/rsl/stringex/tags","blobs_url":"https://api.github.com/repos/rsl/stringex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsl/stringex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsl/stringex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsl/stringex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsl/stringex/statuses/{sha}","languages_url":"https://api.github.com/repos/rsl/stringex/languages","stargazers_url":"https://api.github.com/repos/rsl/stringex/stargazers","contributors_url":"https://api.github.com/repos/rsl/stringex/contributors","subscribers_url":"https://api.github.com/repos/rsl/stringex/subscribers","subscription_url":"https://api.github.com/repos/rsl/stringex/subscription","commits_url":"https://api.github.com/repos/rsl/stringex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsl/stringex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsl/stringex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsl/stringex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsl/stringex/contents/{+path}","compare_url":"https://api.github.com/repos/rsl/stringex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsl/stringex/merges","archive_url":"https://api.github.com/repos/rsl/stringex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsl/stringex/downloads","issues_url":"https://api.github.com/repos/rsl/stringex/issues{/number}","pulls_url":"https://api.github.com/repos/rsl/stringex/pulls{/number}","milestones_url":"https://api.github.com/repos/rsl/stringex/milestones{/number}","notifications_url":"https://api.github.com/repos/rsl/stringex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsl/stringex/labels{/name}","releases_url":"https://api.github.com/repos/rsl/stringex/releases{/id}","deployments_url":"https://api.github.com/repos/rsl/stringex/deployments","created_at":"2008-02-19T15:31:07Z","updated_at":"2017-07-16T06:50:35Z","pushed_at":"2017-07-18T16:05:10Z","git_url":"git://github.com/rsl/stringex.git","ssh_url":"git@github.com:rsl/stringex.git","clone_url":"https://github.com/rsl/stringex.git","svn_url":"https://github.com/rsl/stringex","homepage":"","size":636,"stargazers_count":966,"watchers_count":966,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":13,"forks":141,"open_issues":13,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsl/stringex/pulls/198"},"html":{"href":"https://github.com/rsl/stringex/pull/198"},"issue":{"href":"https://api.github.com/repos/rsl/stringex/issues/198"},"comments":{"href":"https://api.github.com/repos/rsl/stringex/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/rsl/stringex/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/rsl/stringex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsl/stringex/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/rsl/stringex/statuses/e43290f39f37cd0939869fdeda9fa430e0b8a40d"}}}}
{"actor":{"display_login":"houndci-bot"}}