{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/98336757","pull_request_review_id":18978421,"id":98336757,"diff_hunk":"@@ -36,18 +36,16 @@ using namespace epee;\n namespace tools\n {\n \n-void NodeRPCProxy::init(const std::string &daemon_address)\n-{\n-  m_daemon_address = daemon_address;\n-\n-  m_height = 0;\n-  m_height_time = 0;\n-  for (auto &slot: m_earliest_height)\n-    slot = 0;\n-  m_dynamic_per_kb_fee_estimate = 0;\n-  m_dynamic_per_kb_fee_estimate_cached_height = 0;\n-  m_dynamic_per_kb_fee_estimate_grace_blocks = 0;\n-}\n+NodeRPCProxy::NodeRPCProxy(epee::net_utils::http::http_simple_client &http_client, boost::mutex &mutex)\n+  : m_http_client(http_client)\n+  , m_daemon_rpc_mutex(mutex)\n+  , m_height(0)\n+  , m_height_time(0)\n+  , m_earliest_height()","path":"src/wallet/node_rpc_proxy.cpp","position":21,"original_position":21,"commit_id":"c02e1cb943903d34becfaf1c6d9cd71e4424d748","original_commit_id":"c02e1cb943903d34becfaf1c6d9cd71e4424d748","user":{"login":"moneromooo-monero","id":8851073,"avatar_url":"https://avatars.githubusercontent.com/u/8851073?v=3","gravatar_id":"","url":"https://api.github.com/users/moneromooo-monero","html_url":"https://github.com/moneromooo-monero","followers_url":"https://api.github.com/users/moneromooo-monero/followers","following_url":"https://api.github.com/users/moneromooo-monero/following{/other_user}","gists_url":"https://api.github.com/users/moneromooo-monero/gists{/gist_id}","starred_url":"https://api.github.com/users/moneromooo-monero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneromooo-monero/subscriptions","organizations_url":"https://api.github.com/users/moneromooo-monero/orgs","repos_url":"https://api.github.com/users/moneromooo-monero/repos","events_url":"https://api.github.com/users/moneromooo-monero/events{/privacy}","received_events_url":"https://api.github.com/users/moneromooo-monero/received_events","type":"User","site_admin":false},"body":"Does this init the 256 slots of the array to 0 ?","created_at":"2017-01-28T18:40:30Z","updated_at":"2017-01-28T18:43:51Z","html_url":"https://github.com/monero-project/monero/pull/1629#discussion_r98336757","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/1629","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/98336757"},"html":{"href":"https://github.com/monero-project/monero/pull/1629#discussion_r98336757"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1629"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/1629","id":103058846,"html_url":"https://github.com/monero-project/monero/pull/1629","diff_url":"https://github.com/monero-project/monero/pull/1629.diff","patch_url":"https://github.com/monero-project/monero/pull/1629.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/1629","number":1629,"state":"open","locked":false,"title":"Updates to epee HTTP client code","user":{"login":"vtnerd","id":6564514,"avatar_url":"https://avatars.githubusercontent.com/u/6564514?v=3","gravatar_id":"","url":"https://api.github.com/users/vtnerd","html_url":"https://github.com/vtnerd","followers_url":"https://api.github.com/users/vtnerd/followers","following_url":"https://api.github.com/users/vtnerd/following{/other_user}","gists_url":"https://api.github.com/users/vtnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/vtnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtnerd/subscriptions","organizations_url":"https://api.github.com/users/vtnerd/orgs","repos_url":"https://api.github.com/users/vtnerd/repos","events_url":"https://api.github.com/users/vtnerd/events{/privacy}","received_events_url":"https://api.github.com/users/vtnerd/received_events","type":"User","site_admin":false},"body":"  - http_simple_client now uses std::chrono for timeouts\r\n  - http_simple_client accepts timeouts per connect / invoke call\r\n  - shortened names of epee http invoke functions\r\n  - invoke command functions only take relative path, connection\r\n    is not automatically performed\r\n\r\nThis makes adding HTTP client authentication easier. Even if it gets quickly blown away by ZeroMQ, I think this a worthwhile standalone cleanup. I have tested the various clients - wallet and monerod command executor mode. I have not profiled, but this should definitely be a win performance wise because it cuts down on lots of string manipulation being done for every remote function call.\r\n\r\n@moneromooo-monero, @Jaqueeee, and @mbg033 (if still around) might want to peak at this.","created_at":"2017-01-25T05:40:06Z","updated_at":"2017-01-28T18:43:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c32c2466a7d3c34201c80be4c05c10dc7ae29708","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/1629/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/1629/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/1629/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/c02e1cb943903d34becfaf1c6d9cd71e4424d748","head":{"label":"vtnerd:feature/http_client","ref":"feature/http_client","sha":"c02e1cb943903d34becfaf1c6d9cd71e4424d748","user":{"login":"vtnerd","id":6564514,"avatar_url":"https://avatars.githubusercontent.com/u/6564514?v=3","gravatar_id":"","url":"https://api.github.com/users/vtnerd","html_url":"https://github.com/vtnerd","followers_url":"https://api.github.com/users/vtnerd/followers","following_url":"https://api.github.com/users/vtnerd/following{/other_user}","gists_url":"https://api.github.com/users/vtnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/vtnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtnerd/subscriptions","organizations_url":"https://api.github.com/users/vtnerd/orgs","repos_url":"https://api.github.com/users/vtnerd/repos","events_url":"https://api.github.com/users/vtnerd/events{/privacy}","received_events_url":"https://api.github.com/users/vtnerd/received_events","type":"User","site_admin":false},"repo":{"id":72460633,"name":"monero","full_name":"vtnerd/monero","owner":{"login":"vtnerd","id":6564514,"avatar_url":"https://avatars.githubusercontent.com/u/6564514?v=3","gravatar_id":"","url":"https://api.github.com/users/vtnerd","html_url":"https://github.com/vtnerd","followers_url":"https://api.github.com/users/vtnerd/followers","following_url":"https://api.github.com/users/vtnerd/following{/other_user}","gists_url":"https://api.github.com/users/vtnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/vtnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtnerd/subscriptions","organizations_url":"https://api.github.com/users/vtnerd/orgs","repos_url":"https://api.github.com/users/vtnerd/repos","events_url":"https://api.github.com/users/vtnerd/events{/privacy}","received_events_url":"https://api.github.com/users/vtnerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vtnerd/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/vtnerd/monero","forks_url":"https://api.github.com/repos/vtnerd/monero/forks","keys_url":"https://api.github.com/repos/vtnerd/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vtnerd/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vtnerd/monero/teams","hooks_url":"https://api.github.com/repos/vtnerd/monero/hooks","issue_events_url":"https://api.github.com/repos/vtnerd/monero/issues/events{/number}","events_url":"https://api.github.com/repos/vtnerd/monero/events","assignees_url":"https://api.github.com/repos/vtnerd/monero/assignees{/user}","branches_url":"https://api.github.com/repos/vtnerd/monero/branches{/branch}","tags_url":"https://api.github.com/repos/vtnerd/monero/tags","blobs_url":"https://api.github.com/repos/vtnerd/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vtnerd/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vtnerd/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/vtnerd/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vtnerd/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/vtnerd/monero/languages","stargazers_url":"https://api.github.com/repos/vtnerd/monero/stargazers","contributors_url":"https://api.github.com/repos/vtnerd/monero/contributors","subscribers_url":"https://api.github.com/repos/vtnerd/monero/subscribers","subscription_url":"https://api.github.com/repos/vtnerd/monero/subscription","commits_url":"https://api.github.com/repos/vtnerd/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/vtnerd/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/vtnerd/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/vtnerd/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/vtnerd/monero/contents/{+path}","compare_url":"https://api.github.com/repos/vtnerd/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vtnerd/monero/merges","archive_url":"https://api.github.com/repos/vtnerd/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vtnerd/monero/downloads","issues_url":"https://api.github.com/repos/vtnerd/monero/issues{/number}","pulls_url":"https://api.github.com/repos/vtnerd/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/vtnerd/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/vtnerd/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vtnerd/monero/labels{/name}","releases_url":"https://api.github.com/repos/vtnerd/monero/releases{/id}","deployments_url":"https://api.github.com/repos/vtnerd/monero/deployments","created_at":"2016-10-31T17:27:13Z","updated_at":"2016-10-31T17:27:18Z","pushed_at":"2017-01-25T20:44:41Z","git_url":"git://github.com/vtnerd/monero.git","ssh_url":"git@github.com:vtnerd/monero.git","clone_url":"https://github.com/vtnerd/monero.git","svn_url":"https://github.com/vtnerd/monero","homepage":"https://getmonero.org","size":85031,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"ad91ffe7e5e52c4b769c12616f6350396306dceb","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"name":"monero","full_name":"monero-project/monero","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2017-01-28T18:40:39Z","pushed_at":"2017-01-28T15:10:01Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":84836,"stargazers_count":429,"watchers_count":429,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":163,"forks":262,"open_issues":163,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1629"},"html":{"href":"https://github.com/monero-project/monero/pull/1629"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/1629"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/1629/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1629/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1629/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/c02e1cb943903d34becfaf1c6d9cd71e4424d748"}}}}
{"actor":{"display_login":"moneromooo-monero"}}