{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/129967127","pull_request_review_id":52795314,"id":129967127,"diff_hunk":"@@ -28,5 +29,5 @@\n  * benefit from using per-table configuration using {@link Property#TABLE_ARBITRARY_PROP_PREFIX}.\n  */\n public interface VolumeChooser {\n-  String choose(VolumeChooserEnvironment env, String[] options);\n+  String choose(VolumeChooserEnvironment env, String[] options) throws AccumuloException;","path":"server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java","position":13,"original_position":13,"commit_id":"f9fe0f1f80e79a87e169b2e77b76d7b2a98f1587","original_commit_id":"f9fe0f1f80e79a87e169b2e77b76d7b2a98f1587","user":{"login":"ivakegg","id":347158,"avatar_url":"https://avatars3.githubusercontent.com/u/347158?v=4","gravatar_id":"","url":"https://api.github.com/users/ivakegg","html_url":"https://github.com/ivakegg","followers_url":"https://api.github.com/users/ivakegg/followers","following_url":"https://api.github.com/users/ivakegg/following{/other_user}","gists_url":"https://api.github.com/users/ivakegg/gists{/gist_id}","starred_url":"https://api.github.com/users/ivakegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivakegg/subscriptions","organizations_url":"https://api.github.com/users/ivakegg/orgs","repos_url":"https://api.github.com/users/ivakegg/repos","events_url":"https://api.github.com/users/ivakegg/events{/privacy}","received_events_url":"https://api.github.com/users/ivakegg/received_events","type":"User","site_admin":false},"body":"I could, but I think allowing one to throw accumulo exceptions is reasonable   Implementers do not need to include a throws clause.","created_at":"2017-07-27T21:43:40Z","updated_at":"2017-07-27T21:43:41Z","html_url":"https://github.com/apache/accumulo/pull/253#discussion_r129967127","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/129967127"},"html":{"href":"https://github.com/apache/accumulo/pull/253#discussion_r129967127"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/253","id":117057001,"html_url":"https://github.com/apache/accumulo/pull/253","diff_url":"https://github.com/apache/accumulo/pull/253.diff","patch_url":"https://github.com/apache/accumulo/pull/253.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/253","number":253,"state":"open","locked":false,"title":"ACCUMULO-4086 Improve volume chooser fallback","user":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"body":"Implement a better fallback mechanism when the user's selected\r\nVolumeChooser implementation cannot be loaded or is not specified.\r\nHandles all such cases, including non-table scopes (logger), and\r\nper-table scopes.\r\n\r\n****\r\n\r\nNote: this isn't quite ready for merging, but since I'm trying to proxy code written by somebody else, I think it'd be helpful to have it inspected/reviewed by more eyes. I tried to run the tests, but they hung (in Eclipse, at least). Keep in mind that this has been rebase'd from an older version of Accumulo, and probably needs a bit more work.\r\n\r\nThe goal of this is described in [ACCUMULO-4086][1] and its parent task, but all I have is the implementation, and it's not entirely clear what the best design is, in order to make sure this particular implementation matches that design.\r\n\r\nAny and all feedback/assistance is helpful. However, I'm already aware documentation is significantly lacking.... will address that once the design and implementation is hammered out... and that's a bit fuzzy to me right now. For example, I see that the patch modifies the default configs, and it's not clear to me what design goal that achieves.\r\n\r\n[1]: https://issues.apache.org/jira/browse/ACCUMULO-4086","created_at":"2017-04-21T20:02:29Z","updated_at":"2017-07-27T21:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f153b87539a5af6c8b9d818349adfd53fab8b1ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/253/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/253/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/253/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/f9fe0f1f80e79a87e169b2e77b76d7b2a98f1587","head":{"label":"ctubbsii:ACCUMULO-4086-volume-chooser-fallback","ref":"ACCUMULO-4086-volume-chooser-fallback","sha":"f9fe0f1f80e79a87e169b2e77b76d7b2a98f1587","user":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"repo":{"id":9703694,"name":"accumulo","full_name":"ctubbsii/accumulo","owner":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctubbsii/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/ctubbsii/accumulo","forks_url":"https://api.github.com/repos/ctubbsii/accumulo/forks","keys_url":"https://api.github.com/repos/ctubbsii/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctubbsii/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctubbsii/accumulo/teams","hooks_url":"https://api.github.com/repos/ctubbsii/accumulo/hooks","issue_events_url":"https://api.github.com/repos/ctubbsii/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/ctubbsii/accumulo/events","assignees_url":"https://api.github.com/repos/ctubbsii/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/ctubbsii/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/ctubbsii/accumulo/tags","blobs_url":"https://api.github.com/repos/ctubbsii/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctubbsii/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctubbsii/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctubbsii/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctubbsii/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/ctubbsii/accumulo/languages","stargazers_url":"https://api.github.com/repos/ctubbsii/accumulo/stargazers","contributors_url":"https://api.github.com/repos/ctubbsii/accumulo/contributors","subscribers_url":"https://api.github.com/repos/ctubbsii/accumulo/subscribers","subscription_url":"https://api.github.com/repos/ctubbsii/accumulo/subscription","commits_url":"https://api.github.com/repos/ctubbsii/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctubbsii/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctubbsii/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctubbsii/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctubbsii/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/ctubbsii/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctubbsii/accumulo/merges","archive_url":"https://api.github.com/repos/ctubbsii/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctubbsii/accumulo/downloads","issues_url":"https://api.github.com/repos/ctubbsii/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/ctubbsii/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/ctubbsii/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/ctubbsii/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctubbsii/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/ctubbsii/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/ctubbsii/accumulo/deployments","created_at":"2013-04-26T20:31:50Z","updated_at":"2017-07-11T19:04:13Z","pushed_at":"2017-07-27T04:38:33Z","git_url":"git://github.com/ctubbsii/accumulo.git","ssh_url":"git@github.com:ctubbsii/accumulo.git","clone_url":"https://github.com/ctubbsii/accumulo.git","svn_url":"https://github.com/ctubbsii/accumulo","homepage":"https://accumulo.apache.org","size":53473,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3fcc76f8b8b618bc0a873a0145836babde729ece","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Mirror of Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2017-07-26T18:01:37Z","pushed_at":"2017-07-27T04:38:35Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"","size":56247,"stargazers_count":310,"watchers_count":310,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":"git://git.apache.org/accumulo.git","open_issues_count":9,"forks":168,"open_issues":9,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/253"},"html":{"href":"https://github.com/apache/accumulo/pull/253"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/253"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/f9fe0f1f80e79a87e169b2e77b76d7b2a98f1587"}}}}
{"actor":{"display_login":"ivakegg"}}