{"action":"created","comment":{"url":"https://api.github.com/repos/Statoil/libecl/pulls/comments/120801784","pull_request_review_id":42793931,"id":120801784,"diff_hunk":"@@ -488,6 +488,17 @@ void fortio_data_fseek(fortio_type* fortio, offset_type data_offset, size_t data\n     }\n }\n \n+int fortio_fclean(fortio_type * fortio) {\n+  long current_pos = ftell(fortio->stream);\n+  if(current_pos == -1)\n+    return -1;\n+\n+  int flush_status = fflush(fortio->stream);\n+  if(flush_status != 0)","path":"lib/ecl/fortio.c","position":10,"original_position":10,"commit_id":"184a983d1636f0ca8d93d22a6a4db50573ca266e","original_commit_id":"df1e28548c1b1ce0816348a380b03bfd125b13eb","user":{"login":"markusdregi","id":1557864,"avatar_url":"https://avatars0.githubusercontent.com/u/1557864?v=3","gravatar_id":"","url":"https://api.github.com/users/markusdregi","html_url":"https://github.com/markusdregi","followers_url":"https://api.github.com/users/markusdregi/followers","following_url":"https://api.github.com/users/markusdregi/following{/other_user}","gists_url":"https://api.github.com/users/markusdregi/gists{/gist_id}","starred_url":"https://api.github.com/users/markusdregi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusdregi/subscriptions","organizations_url":"https://api.github.com/users/markusdregi/orgs","repos_url":"https://api.github.com/users/markusdregi/repos","events_url":"https://api.github.com/users/markusdregi/events{/privacy}","received_events_url":"https://api.github.com/users/markusdregi/received_events","type":"User","site_admin":false},"body":"Yes, because the position in the stream after a flush is undefined. And in particular, it results in funky behaviour with clang on OS X..","created_at":"2017-06-08T05:21:34Z","updated_at":"2017-06-08T05:21:34Z","html_url":"https://github.com/Statoil/libecl/pull/103#discussion_r120801784","pull_request_url":"https://api.github.com/repos/Statoil/libecl/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/comments/120801784"},"html":{"href":"https://github.com/Statoil/libecl/pull/103#discussion_r120801784"},"pull_request":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/Statoil/libecl/pulls/103","id":124176690,"html_url":"https://github.com/Statoil/libecl/pull/103","diff_url":"https://github.com/Statoil/libecl/pull/103.diff","patch_url":"https://github.com/Statoil/libecl/pull/103.patch","issue_url":"https://api.github.com/repos/Statoil/libecl/issues/103","number":103,"state":"open","locked":false,"title":"WIP: Writing keywords with ecl_file on OS X fails","user":{"login":"markusdregi","id":1557864,"avatar_url":"https://avatars0.githubusercontent.com/u/1557864?v=3","gravatar_id":"","url":"https://api.github.com/users/markusdregi","html_url":"https://github.com/markusdregi","followers_url":"https://api.github.com/users/markusdregi/followers","following_url":"https://api.github.com/users/markusdregi/following{/other_user}","gists_url":"https://api.github.com/users/markusdregi/gists{/gist_id}","starred_url":"https://api.github.com/users/markusdregi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusdregi/subscriptions","organizations_url":"https://api.github.com/users/markusdregi/orgs","repos_url":"https://api.github.com/users/markusdregi/repos","events_url":"https://api.github.com/users/markusdregi/events{/privacy}","received_events_url":"https://api.github.com/users/markusdregi/received_events","type":"User","site_admin":false},"body":"#### Task\r\n_The EclKW test fails on OS X._\r\n\r\n#### Approach\r\n_It turned out to be an problem with ecl_file/fortio in C. The problem occurred in ecl_file_save_kw and the solution was to flush the fortio stream after skipping the header, but before writing the data._\r\n\r\n**Pre un-WIP checklist**\r\n- [x] Statoil tests pass locally\r\n- [ ] Have completed graphical integration test steps\r\n","created_at":"2017-06-06T12:18:11Z","updated_at":"2017-06-08T05:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"915d217e35a4b0a47a51126dae5213730438258f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Statoil/libecl/pulls/103/commits","review_comments_url":"https://api.github.com/repos/Statoil/libecl/pulls/103/comments","review_comment_url":"https://api.github.com/repos/Statoil/libecl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Statoil/libecl/issues/103/comments","statuses_url":"https://api.github.com/repos/Statoil/libecl/statuses/184a983d1636f0ca8d93d22a6a4db50573ca266e","head":{"label":"markusdregi:osx_kwtest","ref":"osx_kwtest","sha":"184a983d1636f0ca8d93d22a6a4db50573ca266e","user":{"login":"markusdregi","id":1557864,"avatar_url":"https://avatars0.githubusercontent.com/u/1557864?v=3","gravatar_id":"","url":"https://api.github.com/users/markusdregi","html_url":"https://github.com/markusdregi","followers_url":"https://api.github.com/users/markusdregi/followers","following_url":"https://api.github.com/users/markusdregi/following{/other_user}","gists_url":"https://api.github.com/users/markusdregi/gists{/gist_id}","starred_url":"https://api.github.com/users/markusdregi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusdregi/subscriptions","organizations_url":"https://api.github.com/users/markusdregi/orgs","repos_url":"https://api.github.com/users/markusdregi/repos","events_url":"https://api.github.com/users/markusdregi/events{/privacy}","received_events_url":"https://api.github.com/users/markusdregi/received_events","type":"User","site_admin":false},"repo":{"id":88951789,"name":"libecl","full_name":"markusdregi/libecl","owner":{"login":"markusdregi","id":1557864,"avatar_url":"https://avatars0.githubusercontent.com/u/1557864?v=3","gravatar_id":"","url":"https://api.github.com/users/markusdregi","html_url":"https://github.com/markusdregi","followers_url":"https://api.github.com/users/markusdregi/followers","following_url":"https://api.github.com/users/markusdregi/following{/other_user}","gists_url":"https://api.github.com/users/markusdregi/gists{/gist_id}","starred_url":"https://api.github.com/users/markusdregi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusdregi/subscriptions","organizations_url":"https://api.github.com/users/markusdregi/orgs","repos_url":"https://api.github.com/users/markusdregi/repos","events_url":"https://api.github.com/users/markusdregi/events{/privacy}","received_events_url":"https://api.github.com/users/markusdregi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markusdregi/libecl","description":null,"fork":true,"url":"https://api.github.com/repos/markusdregi/libecl","forks_url":"https://api.github.com/repos/markusdregi/libecl/forks","keys_url":"https://api.github.com/repos/markusdregi/libecl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusdregi/libecl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusdregi/libecl/teams","hooks_url":"https://api.github.com/repos/markusdregi/libecl/hooks","issue_events_url":"https://api.github.com/repos/markusdregi/libecl/issues/events{/number}","events_url":"https://api.github.com/repos/markusdregi/libecl/events","assignees_url":"https://api.github.com/repos/markusdregi/libecl/assignees{/user}","branches_url":"https://api.github.com/repos/markusdregi/libecl/branches{/branch}","tags_url":"https://api.github.com/repos/markusdregi/libecl/tags","blobs_url":"https://api.github.com/repos/markusdregi/libecl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusdregi/libecl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusdregi/libecl/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusdregi/libecl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusdregi/libecl/statuses/{sha}","languages_url":"https://api.github.com/repos/markusdregi/libecl/languages","stargazers_url":"https://api.github.com/repos/markusdregi/libecl/stargazers","contributors_url":"https://api.github.com/repos/markusdregi/libecl/contributors","subscribers_url":"https://api.github.com/repos/markusdregi/libecl/subscribers","subscription_url":"https://api.github.com/repos/markusdregi/libecl/subscription","commits_url":"https://api.github.com/repos/markusdregi/libecl/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusdregi/libecl/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusdregi/libecl/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusdregi/libecl/issues/comments{/number}","contents_url":"https://api.github.com/repos/markusdregi/libecl/contents/{+path}","compare_url":"https://api.github.com/repos/markusdregi/libecl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusdregi/libecl/merges","archive_url":"https://api.github.com/repos/markusdregi/libecl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusdregi/libecl/downloads","issues_url":"https://api.github.com/repos/markusdregi/libecl/issues{/number}","pulls_url":"https://api.github.com/repos/markusdregi/libecl/pulls{/number}","milestones_url":"https://api.github.com/repos/markusdregi/libecl/milestones{/number}","notifications_url":"https://api.github.com/repos/markusdregi/libecl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusdregi/libecl/labels{/name}","releases_url":"https://api.github.com/repos/markusdregi/libecl/releases{/id}","deployments_url":"https://api.github.com/repos/markusdregi/libecl/deployments","created_at":"2017-04-21T06:50:49Z","updated_at":"2017-04-21T06:50:52Z","pushed_at":"2017-06-08T05:06:29Z","git_url":"git://github.com/markusdregi/libecl.git","ssh_url":"git@github.com:markusdregi/libecl.git","clone_url":"https://github.com/markusdregi/libecl.git","svn_url":"https://github.com/markusdregi/libecl","homepage":null,"size":18954,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Statoil:master","ref":"master","sha":"4c3143c3291b301dde54784bb5ef61f0a8ba6607","user":{"login":"Statoil","id":525862,"avatar_url":"https://avatars0.githubusercontent.com/u/525862?v=3","gravatar_id":"","url":"https://api.github.com/users/Statoil","html_url":"https://github.com/Statoil","followers_url":"https://api.github.com/users/Statoil/followers","following_url":"https://api.github.com/users/Statoil/following{/other_user}","gists_url":"https://api.github.com/users/Statoil/gists{/gist_id}","starred_url":"https://api.github.com/users/Statoil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Statoil/subscriptions","organizations_url":"https://api.github.com/users/Statoil/orgs","repos_url":"https://api.github.com/users/Statoil/repos","events_url":"https://api.github.com/users/Statoil/events{/privacy}","received_events_url":"https://api.github.com/users/Statoil/received_events","type":"Organization","site_admin":false},"repo":{"id":85172345,"name":"libecl","full_name":"Statoil/libecl","owner":{"login":"Statoil","id":525862,"avatar_url":"https://avatars0.githubusercontent.com/u/525862?v=3","gravatar_id":"","url":"https://api.github.com/users/Statoil","html_url":"https://github.com/Statoil","followers_url":"https://api.github.com/users/Statoil/followers","following_url":"https://api.github.com/users/Statoil/following{/other_user}","gists_url":"https://api.github.com/users/Statoil/gists{/gist_id}","starred_url":"https://api.github.com/users/Statoil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Statoil/subscriptions","organizations_url":"https://api.github.com/users/Statoil/orgs","repos_url":"https://api.github.com/users/Statoil/repos","events_url":"https://api.github.com/users/Statoil/events{/privacy}","received_events_url":"https://api.github.com/users/Statoil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Statoil/libecl","description":null,"fork":false,"url":"https://api.github.com/repos/Statoil/libecl","forks_url":"https://api.github.com/repos/Statoil/libecl/forks","keys_url":"https://api.github.com/repos/Statoil/libecl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Statoil/libecl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Statoil/libecl/teams","hooks_url":"https://api.github.com/repos/Statoil/libecl/hooks","issue_events_url":"https://api.github.com/repos/Statoil/libecl/issues/events{/number}","events_url":"https://api.github.com/repos/Statoil/libecl/events","assignees_url":"https://api.github.com/repos/Statoil/libecl/assignees{/user}","branches_url":"https://api.github.com/repos/Statoil/libecl/branches{/branch}","tags_url":"https://api.github.com/repos/Statoil/libecl/tags","blobs_url":"https://api.github.com/repos/Statoil/libecl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Statoil/libecl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Statoil/libecl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Statoil/libecl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Statoil/libecl/statuses/{sha}","languages_url":"https://api.github.com/repos/Statoil/libecl/languages","stargazers_url":"https://api.github.com/repos/Statoil/libecl/stargazers","contributors_url":"https://api.github.com/repos/Statoil/libecl/contributors","subscribers_url":"https://api.github.com/repos/Statoil/libecl/subscribers","subscription_url":"https://api.github.com/repos/Statoil/libecl/subscription","commits_url":"https://api.github.com/repos/Statoil/libecl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Statoil/libecl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Statoil/libecl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Statoil/libecl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Statoil/libecl/contents/{+path}","compare_url":"https://api.github.com/repos/Statoil/libecl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Statoil/libecl/merges","archive_url":"https://api.github.com/repos/Statoil/libecl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Statoil/libecl/downloads","issues_url":"https://api.github.com/repos/Statoil/libecl/issues{/number}","pulls_url":"https://api.github.com/repos/Statoil/libecl/pulls{/number}","milestones_url":"https://api.github.com/repos/Statoil/libecl/milestones{/number}","notifications_url":"https://api.github.com/repos/Statoil/libecl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Statoil/libecl/labels{/name}","releases_url":"https://api.github.com/repos/Statoil/libecl/releases{/id}","deployments_url":"https://api.github.com/repos/Statoil/libecl/deployments","created_at":"2017-03-16T08:39:13Z","updated_at":"2017-05-24T21:02:42Z","pushed_at":"2017-06-08T05:06:31Z","git_url":"git://github.com/Statoil/libecl.git","ssh_url":"git@github.com:Statoil/libecl.git","clone_url":"https://github.com/Statoil/libecl.git","svn_url":"https://github.com/Statoil/libecl","homepage":null,"size":18947,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":14,"forks":18,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/103"},"html":{"href":"https://github.com/Statoil/libecl/pull/103"},"issue":{"href":"https://api.github.com/repos/Statoil/libecl/issues/103"},"comments":{"href":"https://api.github.com/repos/Statoil/libecl/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Statoil/libecl/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/Statoil/libecl/statuses/184a983d1636f0ca8d93d22a6a4db50573ca266e"}}}}
{"actor":{"display_login":"markusdregi"}}