{"action":"closed","number":4882,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/4882","id":148369510,"html_url":"https://github.com/pingcap/tidb/pull/4882","diff_url":"https://github.com/pingcap/tidb/pull/4882.diff","patch_url":"https://github.com/pingcap/tidb/pull/4882.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/4882","number":4882,"state":"closed","locked":false,"title":" plan: join's default value length should be changed when do column pruning.","user":{"login":"winoros","id":7846227,"avatar_url":"https://avatars1.githubusercontent.com/u/7846227?v=4","gravatar_id":"","url":"https://api.github.com/users/winoros","html_url":"https://github.com/winoros","followers_url":"https://api.github.com/users/winoros/followers","following_url":"https://api.github.com/users/winoros/following{/other_user}","gists_url":"https://api.github.com/users/winoros/gists{/gist_id}","starred_url":"https://api.github.com/users/winoros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winoros/subscriptions","organizations_url":"https://api.github.com/users/winoros/orgs","repos_url":"https://api.github.com/users/winoros/repos","events_url":"https://api.github.com/users/winoros/events{/privacy}","received_events_url":"https://api.github.com/users/winoros/received_events","type":"User","site_admin":false},"body":"After column pruning, the `LogicalJoin.DefaultValues` may not be expected, and cause bug when do merge join","created_at":"2017-10-24T11:29:37Z","updated_at":"2017-10-25T07:44:04Z","closed_at":"2017-10-25T07:44:04Z","merged_at":"2017-10-25T07:44:04Z","merge_commit_sha":"3d7167273bbb45ddcf483656a1af807ae96f3523","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pingcap/tidb/milestones/10","html_url":"https://github.com/pingcap/tidb/milestone/10","labels_url":"https://api.github.com/repos/pingcap/tidb/milestones/10/labels","id":2839370,"number":10,"title":"1.1","description":"","creator":{"login":"shenli","id":1192573,"avatar_url":"https://avatars0.githubusercontent.com/u/1192573?v=4","gravatar_id":"","url":"https://api.github.com/users/shenli","html_url":"https://github.com/shenli","followers_url":"https://api.github.com/users/shenli/followers","following_url":"https://api.github.com/users/shenli/following{/other_user}","gists_url":"https://api.github.com/users/shenli/gists{/gist_id}","starred_url":"https://api.github.com/users/shenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenli/subscriptions","organizations_url":"https://api.github.com/users/shenli/orgs","repos_url":"https://api.github.com/users/shenli/repos","events_url":"https://api.github.com/users/shenli/events{/privacy}","received_events_url":"https://api.github.com/users/shenli/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":13,"state":"open","created_at":"2017-10-16T08:41:02Z","updated_at":"2017-10-25T07:44:04Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/4882/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/4882/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/4882/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/be1153fa1b24b603a67ee709e87a9aa72c367909","head":{"label":"winoros:join-default-values","ref":"join-default-values","sha":"be1153fa1b24b603a67ee709e87a9aa72c367909","user":{"login":"winoros","id":7846227,"avatar_url":"https://avatars1.githubusercontent.com/u/7846227?v=4","gravatar_id":"","url":"https://api.github.com/users/winoros","html_url":"https://github.com/winoros","followers_url":"https://api.github.com/users/winoros/followers","following_url":"https://api.github.com/users/winoros/following{/other_user}","gists_url":"https://api.github.com/users/winoros/gists{/gist_id}","starred_url":"https://api.github.com/users/winoros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winoros/subscriptions","organizations_url":"https://api.github.com/users/winoros/orgs","repos_url":"https://api.github.com/users/winoros/repos","events_url":"https://api.github.com/users/winoros/events{/privacy}","received_events_url":"https://api.github.com/users/winoros/received_events","type":"User","site_admin":false},"repo":{"id":107362799,"name":"tidb","full_name":"winoros/tidb","owner":{"login":"winoros","id":7846227,"avatar_url":"https://avatars1.githubusercontent.com/u/7846227?v=4","gravatar_id":"","url":"https://api.github.com/users/winoros","html_url":"https://github.com/winoros","followers_url":"https://api.github.com/users/winoros/followers","following_url":"https://api.github.com/users/winoros/following{/other_user}","gists_url":"https://api.github.com/users/winoros/gists{/gist_id}","starred_url":"https://api.github.com/users/winoros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winoros/subscriptions","organizations_url":"https://api.github.com/users/winoros/orgs","repos_url":"https://api.github.com/users/winoros/repos","events_url":"https://api.github.com/users/winoros/events{/privacy}","received_events_url":"https://api.github.com/users/winoros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/winoros/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/winoros/tidb","forks_url":"https://api.github.com/repos/winoros/tidb/forks","keys_url":"https://api.github.com/repos/winoros/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winoros/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winoros/tidb/teams","hooks_url":"https://api.github.com/repos/winoros/tidb/hooks","issue_events_url":"https://api.github.com/repos/winoros/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/winoros/tidb/events","assignees_url":"https://api.github.com/repos/winoros/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/winoros/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/winoros/tidb/tags","blobs_url":"https://api.github.com/repos/winoros/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winoros/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winoros/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/winoros/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winoros/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/winoros/tidb/languages","stargazers_url":"https://api.github.com/repos/winoros/tidb/stargazers","contributors_url":"https://api.github.com/repos/winoros/tidb/contributors","subscribers_url":"https://api.github.com/repos/winoros/tidb/subscribers","subscription_url":"https://api.github.com/repos/winoros/tidb/subscription","commits_url":"https://api.github.com/repos/winoros/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/winoros/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/winoros/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/winoros/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/winoros/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/winoros/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winoros/tidb/merges","archive_url":"https://api.github.com/repos/winoros/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winoros/tidb/downloads","issues_url":"https://api.github.com/repos/winoros/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/winoros/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/winoros/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/winoros/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winoros/tidb/labels{/name}","releases_url":"https://api.github.com/repos/winoros/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/winoros/tidb/deployments","created_at":"2017-10-18T05:29:31Z","updated_at":"2017-10-18T05:29:36Z","pushed_at":"2017-10-25T07:16:59Z","git_url":"git://github.com/winoros/tidb.git","ssh_url":"git@github.com:winoros/tidb.git","clone_url":"https://github.com/winoros/tidb.git","svn_url":"https://github.com/winoros/tidb","homepage":"https://pingcap.com","size":33725,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"1f4fc3532077771cf78c52d496cb5296cb3c7ba0","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-10-25T07:34:05Z","pushed_at":"2017-10-25T07:44:04Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":34969,"stargazers_count":10309,"watchers_count":10309,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1385,"mirror_url":null,"archived":false,"open_issues_count":349,"forks":1385,"open_issues":349,"watchers":10309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4882"},"html":{"href":"https://github.com/pingcap/tidb/pull/4882"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4882"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4882/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4882/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4882/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/be1153fa1b24b603a67ee709e87a9aa72c367909"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hanfei1991","id":20884546,"avatar_url":"https://avatars0.githubusercontent.com/u/20884546?v=4","gravatar_id":"","url":"https://api.github.com/users/hanfei1991","html_url":"https://github.com/hanfei1991","followers_url":"https://api.github.com/users/hanfei1991/followers","following_url":"https://api.github.com/users/hanfei1991/following{/other_user}","gists_url":"https://api.github.com/users/hanfei1991/gists{/gist_id}","starred_url":"https://api.github.com/users/hanfei1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanfei1991/subscriptions","organizations_url":"https://api.github.com/users/hanfei1991/orgs","repos_url":"https://api.github.com/users/hanfei1991/repos","events_url":"https://api.github.com/users/hanfei1991/events{/privacy}","received_events_url":"https://api.github.com/users/hanfei1991/received_events","type":"User","site_admin":false},"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":12,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"hanfei1991"}}