{"action":"closed","number":178,"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/178","id":137441341,"html_url":"https://github.com/newsuk/times-components/pull/178","diff_url":"https://github.com/newsuk/times-components/pull/178.diff","patch_url":"https://github.com/newsuk/times-components/pull/178.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/178","number":178,"state":"closed","locked":false,"title":"twitter username link proposal","user":{"login":"trevorah","id":298742,"avatar_url":"https://avatars0.githubusercontent.com/u/298742?v=4","gravatar_id":"","url":"https://api.github.com/users/trevorah","html_url":"https://github.com/trevorah","followers_url":"https://api.github.com/users/trevorah/followers","following_url":"https://api.github.com/users/trevorah/following{/other_user}","gists_url":"https://api.github.com/users/trevorah/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorah/subscriptions","organizations_url":"https://api.github.com/users/trevorah/orgs","repos_url":"https://api.github.com/users/trevorah/repos","events_url":"https://api.github.com/users/trevorah/events{/privacy}","received_events_url":"https://api.github.com/users/trevorah/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE\r\n\r\nI've done this as a bit of a discussion piece. Web, Android and iOS all have their different navigation styles, so I figured it would be up to something outside of the component to figure out how to navigate to a given uri.\r\n\r\nHere's a proposal in the form of an example for author profile twitter username links. Check out and try the storybook.\r\n\r\ntalking points:\r\n- **buttons vs links:** on web, these \"links\" feel like buttons. this may help us feel more appy, but it means that people cant open the twitter profiles in new tabs. 👎 \r\n- **prop passing:** It may just be the author profile components, but passing a function through 3 components seems a bit much. fix the nesting or use context hackery?\r\n- **required functions:** buttons that look enabled but are unresponsive are poo poo. I say make them required.\r\n- **fancy links:** article link navigation would be so much easier if ids (not just urls) get passed around. Should we have a catchall function or specialist ones (e.g `onLinkPress` vs `onArticleLinkPress` and`onAuthorLinkPress` etc)\r\n\r\n@craigbilner @fampinheiro @nehasri89 @JGAntunes thoughts?","created_at":"2017-08-24T12:24:25Z","updated_at":"2017-08-29T08:43:37Z","closed_at":"2017-08-29T08:43:37Z","merged_at":null,"merge_commit_sha":"27d2df7f9c00440aedf075e7d9bc7edc04adc23e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/178/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/178/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/178/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/29c69df1e51971b92cf6e13b35050ee0df21f84a","head":{"label":"newsuk:tweet-tweet-its-twitter-links","ref":"tweet-tweet-its-twitter-links","sha":"29c69df1e51971b92cf6e13b35050ee0df21f84a","user":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2017-08-22T08:59:59Z","pushed_at":"2017-08-28T15:21:58Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"https://newsuk.github.io/times-components","size":25832,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":18,"forks":3,"open_issues":18,"watchers":6,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"f37949e26b4354bfedc82df794137c4ab39199a0","user":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2017-08-22T08:59:59Z","pushed_at":"2017-08-28T15:21:58Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"https://newsuk.github.io/times-components","size":25832,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":18,"forks":3,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/178"},"html":{"href":"https://github.com/newsuk/times-components/pull/178"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/178"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/29c69df1e51971b92cf6e13b35050ee0df21f84a"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":9,"changed_files":5}}
{"actor":{"display_login":"trevorah"}}