{"action":"created","comment":{"url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/comments/126690438","pull_request_review_id":49197428,"id":126690438,"diff_hunk":"@@ -0,0 +1,63 @@\n+'use strict';\n+\n+var expect = require('chai').expect;\n+var isPrimitive = require('../src/is-primitive').isPrimitive;\n+\n+describe('isPrimitive', function () {\n+  describe('should be primitive', function () {\n+    it('boolean', function () {\n+      expect(isPrimitive(true)).to.be.true;\n+    });\n+\n+    it('number', function () {\n+      expect(isPrimitive(1)).to.be.true;\n+    });\n+\n+    it('string', function () {\n+      expect(isPrimitive('a string')).to.be.true;\n+    });\n+\n+    it('null', function () {\n+      expect(isPrimitive(null)).to.be.true;\n+    });\n+\n+    it('undefined', function () {\n+      expect(isPrimitive(undefined)).to.be.true;\n+    });\n+\n+    it('NaN', function () {\n+      expect(isPrimitive(NaN)).to.be.true;\n+    });\n+\n+    it('Infinite', function () {\n+      expect(isPrimitive(Infinity)).to.be.true;","path":"test/is-primitive.spec.js","position":33,"original_position":33,"commit_id":"f3390ab78e512bcd9e477824728af9818732d78e","original_commit_id":"f3390ab78e512bcd9e477824728af9818732d78e","user":{"login":"pgoldrbx","id":4885634,"avatar_url":"https://avatars2.githubusercontent.com/u/4885634?v=3","gravatar_id":"","url":"https://api.github.com/users/pgoldrbx","html_url":"https://github.com/pgoldrbx","followers_url":"https://api.github.com/users/pgoldrbx/followers","following_url":"https://api.github.com/users/pgoldrbx/following{/other_user}","gists_url":"https://api.github.com/users/pgoldrbx/gists{/gist_id}","starred_url":"https://api.github.com/users/pgoldrbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgoldrbx/subscriptions","organizations_url":"https://api.github.com/users/pgoldrbx/orgs","repos_url":"https://api.github.com/users/pgoldrbx/repos","events_url":"https://api.github.com/users/pgoldrbx/events{/privacy}","received_events_url":"https://api.github.com/users/pgoldrbx/received_events","type":"User","site_admin":false},"body":"I'm not actually sure if `NaN` and `Infinity` are considered primitive.\r\nI think what you want:\r\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures","created_at":"2017-07-11T13:39:36Z","updated_at":"2017-07-11T13:39:36Z","html_url":"https://github.com/fesebuv/is-primitive/pull/1#discussion_r126690438","pull_request_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/comments/126690438"},"html":{"href":"https://github.com/fesebuv/is-primitive/pull/1#discussion_r126690438"},"pull_request":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1","id":129899095,"html_url":"https://github.com/fesebuv/is-primitive/pull/1","diff_url":"https://github.com/fesebuv/is-primitive/pull/1.diff","patch_url":"https://github.com/fesebuv/is-primitive/pull/1.patch","issue_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/1","number":1,"state":"open","locked":false,"title":"check if primitive value","user":{"login":"fesebuv","id":2856169,"avatar_url":"https://avatars1.githubusercontent.com/u/2856169?v=3","gravatar_id":"","url":"https://api.github.com/users/fesebuv","html_url":"https://github.com/fesebuv","followers_url":"https://api.github.com/users/fesebuv/followers","following_url":"https://api.github.com/users/fesebuv/following{/other_user}","gists_url":"https://api.github.com/users/fesebuv/gists{/gist_id}","starred_url":"https://api.github.com/users/fesebuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fesebuv/subscriptions","organizations_url":"https://api.github.com/users/fesebuv/orgs","repos_url":"https://api.github.com/users/fesebuv/repos","events_url":"https://api.github.com/users/fesebuv/events{/privacy}","received_events_url":"https://api.github.com/users/fesebuv/received_events","type":"User","site_admin":false},"body":"* Initial Commit\n* Includes tests and setup","created_at":"2017-07-11T12:49:32Z","updated_at":"2017-07-11T13:39:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeb5a2f4c57ac67bfda06fb969cfc57f54bcafcf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1/commits","review_comments_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1/comments","review_comment_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/1/comments","statuses_url":"https://api.github.com/repos/fesebuv/is-primitive/statuses/f3390ab78e512bcd9e477824728af9818732d78e","head":{"label":"fesebuv:feature/isprimitive","ref":"feature/isprimitive","sha":"f3390ab78e512bcd9e477824728af9818732d78e","user":{"login":"fesebuv","id":2856169,"avatar_url":"https://avatars1.githubusercontent.com/u/2856169?v=3","gravatar_id":"","url":"https://api.github.com/users/fesebuv","html_url":"https://github.com/fesebuv","followers_url":"https://api.github.com/users/fesebuv/followers","following_url":"https://api.github.com/users/fesebuv/following{/other_user}","gists_url":"https://api.github.com/users/fesebuv/gists{/gist_id}","starred_url":"https://api.github.com/users/fesebuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fesebuv/subscriptions","organizations_url":"https://api.github.com/users/fesebuv/orgs","repos_url":"https://api.github.com/users/fesebuv/repos","events_url":"https://api.github.com/users/fesebuv/events{/privacy}","received_events_url":"https://api.github.com/users/fesebuv/received_events","type":"User","site_admin":false},"repo":{"id":96814212,"name":"is-primitive","full_name":"fesebuv/is-primitive","owner":{"login":"fesebuv","id":2856169,"avatar_url":"https://avatars1.githubusercontent.com/u/2856169?v=3","gravatar_id":"","url":"https://api.github.com/users/fesebuv","html_url":"https://github.com/fesebuv","followers_url":"https://api.github.com/users/fesebuv/followers","following_url":"https://api.github.com/users/fesebuv/following{/other_user}","gists_url":"https://api.github.com/users/fesebuv/gists{/gist_id}","starred_url":"https://api.github.com/users/fesebuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fesebuv/subscriptions","organizations_url":"https://api.github.com/users/fesebuv/orgs","repos_url":"https://api.github.com/users/fesebuv/repos","events_url":"https://api.github.com/users/fesebuv/events{/privacy}","received_events_url":"https://api.github.com/users/fesebuv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fesebuv/is-primitive","description":"is-primitive","fork":false,"url":"https://api.github.com/repos/fesebuv/is-primitive","forks_url":"https://api.github.com/repos/fesebuv/is-primitive/forks","keys_url":"https://api.github.com/repos/fesebuv/is-primitive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fesebuv/is-primitive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fesebuv/is-primitive/teams","hooks_url":"https://api.github.com/repos/fesebuv/is-primitive/hooks","issue_events_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/events{/number}","events_url":"https://api.github.com/repos/fesebuv/is-primitive/events","assignees_url":"https://api.github.com/repos/fesebuv/is-primitive/assignees{/user}","branches_url":"https://api.github.com/repos/fesebuv/is-primitive/branches{/branch}","tags_url":"https://api.github.com/repos/fesebuv/is-primitive/tags","blobs_url":"https://api.github.com/repos/fesebuv/is-primitive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fesebuv/is-primitive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fesebuv/is-primitive/git/refs{/sha}","trees_url":"https://api.github.com/repos/fesebuv/is-primitive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fesebuv/is-primitive/statuses/{sha}","languages_url":"https://api.github.com/repos/fesebuv/is-primitive/languages","stargazers_url":"https://api.github.com/repos/fesebuv/is-primitive/stargazers","contributors_url":"https://api.github.com/repos/fesebuv/is-primitive/contributors","subscribers_url":"https://api.github.com/repos/fesebuv/is-primitive/subscribers","subscription_url":"https://api.github.com/repos/fesebuv/is-primitive/subscription","commits_url":"https://api.github.com/repos/fesebuv/is-primitive/commits{/sha}","git_commits_url":"https://api.github.com/repos/fesebuv/is-primitive/git/commits{/sha}","comments_url":"https://api.github.com/repos/fesebuv/is-primitive/comments{/number}","issue_comment_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/comments{/number}","contents_url":"https://api.github.com/repos/fesebuv/is-primitive/contents/{+path}","compare_url":"https://api.github.com/repos/fesebuv/is-primitive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fesebuv/is-primitive/merges","archive_url":"https://api.github.com/repos/fesebuv/is-primitive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fesebuv/is-primitive/downloads","issues_url":"https://api.github.com/repos/fesebuv/is-primitive/issues{/number}","pulls_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls{/number}","milestones_url":"https://api.github.com/repos/fesebuv/is-primitive/milestones{/number}","notifications_url":"https://api.github.com/repos/fesebuv/is-primitive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fesebuv/is-primitive/labels{/name}","releases_url":"https://api.github.com/repos/fesebuv/is-primitive/releases{/id}","deployments_url":"https://api.github.com/repos/fesebuv/is-primitive/deployments","created_at":"2017-07-10T19:34:18Z","updated_at":"2017-07-10T19:34:18Z","pushed_at":"2017-07-11T13:30:30Z","git_url":"git://github.com/fesebuv/is-primitive.git","ssh_url":"git@github.com:fesebuv/is-primitive.git","clone_url":"https://github.com/fesebuv/is-primitive.git","svn_url":"https://github.com/fesebuv/is-primitive","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fesebuv:master","ref":"master","sha":"00d2afa9525817c5ab914785b89e6a905300bf9f","user":{"login":"fesebuv","id":2856169,"avatar_url":"https://avatars1.githubusercontent.com/u/2856169?v=3","gravatar_id":"","url":"https://api.github.com/users/fesebuv","html_url":"https://github.com/fesebuv","followers_url":"https://api.github.com/users/fesebuv/followers","following_url":"https://api.github.com/users/fesebuv/following{/other_user}","gists_url":"https://api.github.com/users/fesebuv/gists{/gist_id}","starred_url":"https://api.github.com/users/fesebuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fesebuv/subscriptions","organizations_url":"https://api.github.com/users/fesebuv/orgs","repos_url":"https://api.github.com/users/fesebuv/repos","events_url":"https://api.github.com/users/fesebuv/events{/privacy}","received_events_url":"https://api.github.com/users/fesebuv/received_events","type":"User","site_admin":false},"repo":{"id":96814212,"name":"is-primitive","full_name":"fesebuv/is-primitive","owner":{"login":"fesebuv","id":2856169,"avatar_url":"https://avatars1.githubusercontent.com/u/2856169?v=3","gravatar_id":"","url":"https://api.github.com/users/fesebuv","html_url":"https://github.com/fesebuv","followers_url":"https://api.github.com/users/fesebuv/followers","following_url":"https://api.github.com/users/fesebuv/following{/other_user}","gists_url":"https://api.github.com/users/fesebuv/gists{/gist_id}","starred_url":"https://api.github.com/users/fesebuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fesebuv/subscriptions","organizations_url":"https://api.github.com/users/fesebuv/orgs","repos_url":"https://api.github.com/users/fesebuv/repos","events_url":"https://api.github.com/users/fesebuv/events{/privacy}","received_events_url":"https://api.github.com/users/fesebuv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fesebuv/is-primitive","description":"is-primitive","fork":false,"url":"https://api.github.com/repos/fesebuv/is-primitive","forks_url":"https://api.github.com/repos/fesebuv/is-primitive/forks","keys_url":"https://api.github.com/repos/fesebuv/is-primitive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fesebuv/is-primitive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fesebuv/is-primitive/teams","hooks_url":"https://api.github.com/repos/fesebuv/is-primitive/hooks","issue_events_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/events{/number}","events_url":"https://api.github.com/repos/fesebuv/is-primitive/events","assignees_url":"https://api.github.com/repos/fesebuv/is-primitive/assignees{/user}","branches_url":"https://api.github.com/repos/fesebuv/is-primitive/branches{/branch}","tags_url":"https://api.github.com/repos/fesebuv/is-primitive/tags","blobs_url":"https://api.github.com/repos/fesebuv/is-primitive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fesebuv/is-primitive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fesebuv/is-primitive/git/refs{/sha}","trees_url":"https://api.github.com/repos/fesebuv/is-primitive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fesebuv/is-primitive/statuses/{sha}","languages_url":"https://api.github.com/repos/fesebuv/is-primitive/languages","stargazers_url":"https://api.github.com/repos/fesebuv/is-primitive/stargazers","contributors_url":"https://api.github.com/repos/fesebuv/is-primitive/contributors","subscribers_url":"https://api.github.com/repos/fesebuv/is-primitive/subscribers","subscription_url":"https://api.github.com/repos/fesebuv/is-primitive/subscription","commits_url":"https://api.github.com/repos/fesebuv/is-primitive/commits{/sha}","git_commits_url":"https://api.github.com/repos/fesebuv/is-primitive/git/commits{/sha}","comments_url":"https://api.github.com/repos/fesebuv/is-primitive/comments{/number}","issue_comment_url":"https://api.github.com/repos/fesebuv/is-primitive/issues/comments{/number}","contents_url":"https://api.github.com/repos/fesebuv/is-primitive/contents/{+path}","compare_url":"https://api.github.com/repos/fesebuv/is-primitive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fesebuv/is-primitive/merges","archive_url":"https://api.github.com/repos/fesebuv/is-primitive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fesebuv/is-primitive/downloads","issues_url":"https://api.github.com/repos/fesebuv/is-primitive/issues{/number}","pulls_url":"https://api.github.com/repos/fesebuv/is-primitive/pulls{/number}","milestones_url":"https://api.github.com/repos/fesebuv/is-primitive/milestones{/number}","notifications_url":"https://api.github.com/repos/fesebuv/is-primitive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fesebuv/is-primitive/labels{/name}","releases_url":"https://api.github.com/repos/fesebuv/is-primitive/releases{/id}","deployments_url":"https://api.github.com/repos/fesebuv/is-primitive/deployments","created_at":"2017-07-10T19:34:18Z","updated_at":"2017-07-10T19:34:18Z","pushed_at":"2017-07-11T13:30:30Z","git_url":"git://github.com/fesebuv/is-primitive.git","ssh_url":"git@github.com:fesebuv/is-primitive.git","clone_url":"https://github.com/fesebuv/is-primitive.git","svn_url":"https://github.com/fesebuv/is-primitive","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1"},"html":{"href":"https://github.com/fesebuv/is-primitive/pull/1"},"issue":{"href":"https://api.github.com/repos/fesebuv/is-primitive/issues/1"},"comments":{"href":"https://api.github.com/repos/fesebuv/is-primitive/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fesebuv/is-primitive/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/fesebuv/is-primitive/statuses/f3390ab78e512bcd9e477824728af9818732d78e"}}}}
{"actor":{"display_login":"pgoldrbx"}}