{"action":"created","comment":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/152702568","pull_request_review_id":78604582,"id":152702568,"diff_hunk":"@@ -94,3 +94,46 @@ a { -moz-border-radius-topright: 40px; }\n ```css\n a { height: 100vmin; }\n ```\n+\n+### `ignoreMediaFeatureNames: { unit: [\"property\", \"/regex/\"] }`\n+\n+Ignore units for specific feature names.\n+\n+For example, with `[\"px\", \"dpi\"]`.\n+\n+Given:\n+\n+```js\n+{\n+  \"px\": [ \"min-width\", \"/height$/\" ],\n+  \"dpi\": [ \"resolution\" ]  \n+}\n+```\n+\n+The following patterns are *not* considered violations:\n+\n+```css\n+@media (min-width: 960px) { }","path":"lib/rules/unit-blacklist/README.md","position":23,"original_position":23,"commit_id":"b6effdf739a8803eaa023507ce127e79b949a285","original_commit_id":"b6effdf739a8803eaa023507ce127e79b949a285","user":{"login":"jeddy3","id":808227,"avatar_url":"https://avatars0.githubusercontent.com/u/808227?v=4","gravatar_id":"","url":"https://api.github.com/users/jeddy3","html_url":"https://github.com/jeddy3","followers_url":"https://api.github.com/users/jeddy3/followers","following_url":"https://api.github.com/users/jeddy3/following{/other_user}","gists_url":"https://api.github.com/users/jeddy3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeddy3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeddy3/subscriptions","organizations_url":"https://api.github.com/users/jeddy3/orgs","repos_url":"https://api.github.com/users/jeddy3/repos","events_url":"https://api.github.com/users/jeddy3/events{/privacy}","received_events_url":"https://api.github.com/users/jeddy3/received_events","type":"User","site_admin":false},"body":"Can you please change the examples to use empty braces i.e. `{}` as per [the guidelines](https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#example-patterns).","created_at":"2017-11-22T23:46:18Z","updated_at":"2017-11-22T23:48:46Z","html_url":"https://github.com/stylelint/stylelint/pull/3027#discussion_r152702568","pull_request_url":"https://api.github.com/repos/stylelint/stylelint/pulls/3027","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/152702568"},"html":{"href":"https://github.com/stylelint/stylelint/pull/3027#discussion_r152702568"},"pull_request":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/3027"}}},"pull_request":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/3027","id":153422372,"html_url":"https://github.com/stylelint/stylelint/pull/3027","diff_url":"https://github.com/stylelint/stylelint/pull/3027.diff","patch_url":"https://github.com/stylelint/stylelint/pull/3027.patch","issue_url":"https://api.github.com/repos/stylelint/stylelint/issues/3027","number":3027,"state":"open","locked":false,"title":"Add ignoreMediaFeatureNames for unit-blacklist","user":{"login":"lucmerceron","id":8736724,"avatar_url":"https://avatars0.githubusercontent.com/u/8736724?v=4","gravatar_id":"","url":"https://api.github.com/users/lucmerceron","html_url":"https://github.com/lucmerceron","followers_url":"https://api.github.com/users/lucmerceron/followers","following_url":"https://api.github.com/users/lucmerceron/following{/other_user}","gists_url":"https://api.github.com/users/lucmerceron/gists{/gist_id}","starred_url":"https://api.github.com/users/lucmerceron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucmerceron/subscriptions","organizations_url":"https://api.github.com/users/lucmerceron/orgs","repos_url":"https://api.github.com/users/lucmerceron/repos","events_url":"https://api.github.com/users/lucmerceron/events{/privacy}","received_events_url":"https://api.github.com/users/lucmerceron/received_events","type":"User","site_admin":false},"body":"<!---\r\nPlease read the following. Pull requests that do not adhere to these guidelines will be closed.\r\n\r\nEach pull request must, with the exception of minor documentation fixes, be associated with an open issue. If a corresponding issue does not exist please stop. Instead, create an issue so we can discuss the change first.\r\n\r\nIf there is an associated open issue, then the next step is to make sure you've read the relevant developer guide:\r\n\r\n- Creating a new rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#creating-a-new-rule\r\n\r\n- Adding an option to an existing rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#adding-an-option-to-an-existing-rule\r\n\r\n- Fixing a bug in an existing rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#fixing-a-bug-in-an-existing-rule\r\n\r\nOnce you've done that, then please continue by answering these two questions:  -->\r\n\r\n> Which issue, if any, is this issue related to?\r\n\r\n#3006 \r\n\r\n> Is there anything in the PR that needs further explanation?\r\n\r\nThe PR is easy to understand.\r\n\r\nNB:\r\nI am not sure this solution is the most optimized since I have one loop for the value `valueParser` inside the one for the media `mediaParser` but it feels safer than doing matches only on the returned `mediaFeatureNode` and having to add `column` size for error handling.\r\n\r\nSince this is my first PR for stylelint, this is widely open to discussion. I may have missed a util or anything else that could be used.\r\n","created_at":"2017-11-18T00:24:17Z","updated_at":"2017-11-22T23:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99fac19b01aade56f6ce481bda026e483d43bcf9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stylelint/stylelint/pulls/3027/commits","review_comments_url":"https://api.github.com/repos/stylelint/stylelint/pulls/3027/comments","review_comment_url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stylelint/stylelint/issues/3027/comments","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/b6effdf739a8803eaa023507ce127e79b949a285","head":{"label":"lucmerceron:feature/unit-blacklist-ignore-feature-names","ref":"feature/unit-blacklist-ignore-feature-names","sha":"b6effdf739a8803eaa023507ce127e79b949a285","user":{"login":"lucmerceron","id":8736724,"avatar_url":"https://avatars0.githubusercontent.com/u/8736724?v=4","gravatar_id":"","url":"https://api.github.com/users/lucmerceron","html_url":"https://github.com/lucmerceron","followers_url":"https://api.github.com/users/lucmerceron/followers","following_url":"https://api.github.com/users/lucmerceron/following{/other_user}","gists_url":"https://api.github.com/users/lucmerceron/gists{/gist_id}","starred_url":"https://api.github.com/users/lucmerceron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucmerceron/subscriptions","organizations_url":"https://api.github.com/users/lucmerceron/orgs","repos_url":"https://api.github.com/users/lucmerceron/repos","events_url":"https://api.github.com/users/lucmerceron/events{/privacy}","received_events_url":"https://api.github.com/users/lucmerceron/received_events","type":"User","site_admin":false},"repo":{"id":110989581,"name":"stylelint","full_name":"lucmerceron/stylelint","owner":{"login":"lucmerceron","id":8736724,"avatar_url":"https://avatars0.githubusercontent.com/u/8736724?v=4","gravatar_id":"","url":"https://api.github.com/users/lucmerceron","html_url":"https://github.com/lucmerceron","followers_url":"https://api.github.com/users/lucmerceron/followers","following_url":"https://api.github.com/users/lucmerceron/following{/other_user}","gists_url":"https://api.github.com/users/lucmerceron/gists{/gist_id}","starred_url":"https://api.github.com/users/lucmerceron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucmerceron/subscriptions","organizations_url":"https://api.github.com/users/lucmerceron/orgs","repos_url":"https://api.github.com/users/lucmerceron/repos","events_url":"https://api.github.com/users/lucmerceron/events{/privacy}","received_events_url":"https://api.github.com/users/lucmerceron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucmerceron/stylelint","description":"A mighty, modern CSS linter","fork":true,"url":"https://api.github.com/repos/lucmerceron/stylelint","forks_url":"https://api.github.com/repos/lucmerceron/stylelint/forks","keys_url":"https://api.github.com/repos/lucmerceron/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucmerceron/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucmerceron/stylelint/teams","hooks_url":"https://api.github.com/repos/lucmerceron/stylelint/hooks","issue_events_url":"https://api.github.com/repos/lucmerceron/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/lucmerceron/stylelint/events","assignees_url":"https://api.github.com/repos/lucmerceron/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/lucmerceron/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/lucmerceron/stylelint/tags","blobs_url":"https://api.github.com/repos/lucmerceron/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucmerceron/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucmerceron/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucmerceron/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucmerceron/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/lucmerceron/stylelint/languages","stargazers_url":"https://api.github.com/repos/lucmerceron/stylelint/stargazers","contributors_url":"https://api.github.com/repos/lucmerceron/stylelint/contributors","subscribers_url":"https://api.github.com/repos/lucmerceron/stylelint/subscribers","subscription_url":"https://api.github.com/repos/lucmerceron/stylelint/subscription","commits_url":"https://api.github.com/repos/lucmerceron/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucmerceron/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucmerceron/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucmerceron/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucmerceron/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/lucmerceron/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucmerceron/stylelint/merges","archive_url":"https://api.github.com/repos/lucmerceron/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucmerceron/stylelint/downloads","issues_url":"https://api.github.com/repos/lucmerceron/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/lucmerceron/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/lucmerceron/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/lucmerceron/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucmerceron/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/lucmerceron/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/lucmerceron/stylelint/deployments","created_at":"2017-11-16T15:38:36Z","updated_at":"2017-11-16T15:38:40Z","pushed_at":"2017-11-19T13:00:27Z","git_url":"git://github.com/lucmerceron/stylelint.git","ssh_url":"git@github.com:lucmerceron/stylelint.git","clone_url":"https://github.com/lucmerceron/stylelint.git","svn_url":"https://github.com/lucmerceron/stylelint","homepage":"http://stylelint.io/","size":7797,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stylelint:master","ref":"master","sha":"ded86c81d055b3916ef3242a390fd7dad00ca8a7","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars0.githubusercontent.com/u/10076935?v=4","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars0.githubusercontent.com/u/10076935?v=4","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2017-11-22T23:35:33Z","pushed_at":"2017-11-22T08:58:38Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":7794,"stargazers_count":4113,"watchers_count":4113,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":363,"mirror_url":null,"archived":false,"open_issues_count":84,"forks":363,"open_issues":84,"watchers":4113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/3027"},"html":{"href":"https://github.com/stylelint/stylelint/pull/3027"},"issue":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/3027"},"comments":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/3027/comments"},"review_comments":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/3027/comments"},"review_comment":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/3027/commits"},"statuses":{"href":"https://api.github.com/repos/stylelint/stylelint/statuses/b6effdf739a8803eaa023507ce127e79b949a285"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeddy3"}}