{"action":"created","comment":{"url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/comments/136688607","pull_request_review_id":60267993,"id":136688607,"diff_hunk":"@@ -1,13 +1,22 @@\n private func stringAttribute(_ key: String) -> AttributeKey<String> {\n-  return .init(key, apply: { .text($0) })\n+  return AttributeKey(key, apply: { .text($0) })\n }\n \n private func numberAttribute(_ key: String) -> AttributeKey<Int> {\n-  return .init(key, apply: { .text(String($0)) })\n+  return AttributeKey(key, apply: { .text(String($0)) })\n }\n \n-private func CSSAttribute(_ key: String) -> AttributeKey<[String: String]> {\n-  return .init(key, apply: { .text($0.map({ \"\\($0): \\($1);\" }).joined(separator: \" \")) })\n+private func CSSAttribute(_ key: String) -> AttributeKey<[String: String?]> {","path":"Sources/HaCTML/Attributes.swift","position":13,"original_position":13,"commit_id":"7fb3c90761417475334ea1ff8ded4845d5001720","original_commit_id":"7fb3c90761417475334ea1ff8ded4845d5001720","user":{"login":"Pinpickle","id":3238878,"avatar_url":"https://avatars1.githubusercontent.com/u/3238878?v=4","gravatar_id":"","url":"https://api.github.com/users/Pinpickle","html_url":"https://github.com/Pinpickle","followers_url":"https://api.github.com/users/Pinpickle/followers","following_url":"https://api.github.com/users/Pinpickle/following{/other_user}","gists_url":"https://api.github.com/users/Pinpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/Pinpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pinpickle/subscriptions","organizations_url":"https://api.github.com/users/Pinpickle/orgs","repos_url":"https://api.github.com/users/Pinpickle/repos","events_url":"https://api.github.com/users/Pinpickle/events{/privacy}","received_events_url":"https://api.github.com/users/Pinpickle/received_events","type":"User","site_admin":false},"body":"I share your sentiment. This should be a concern if an optional value can sneak its way in there unintentionally. Maybe we can come up with a friendly way to say \"yeah this is optional but I'm doing it on purpose\", so the behaviour is explicit?","created_at":"2017-09-02T03:55:18Z","updated_at":"2017-09-02T03:55:18Z","html_url":"https://github.com/hackersatcambridge/hac-website/pull/46#discussion_r136688607","pull_request_url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/comments/136688607"},"html":{"href":"https://github.com/hackersatcambridge/hac-website/pull/46#discussion_r136688607"},"pull_request":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46"}},"in_reply_to_id":136688405},"pull_request":{"url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46","id":138998400,"html_url":"https://github.com/hackersatcambridge/hac-website/pull/46","diff_url":"https://github.com/hackersatcambridge/hac-website/pull/46.diff","patch_url":"https://github.com/hackersatcambridge/hac-website/pull/46.patch","issue_url":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/46","number":46,"state":"open","locked":false,"title":"Landing Page Controller + Update Feed styling","user":{"login":"jaredkhan","id":3105017,"avatar_url":"https://avatars1.githubusercontent.com/u/3105017?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredkhan","html_url":"https://github.com/jaredkhan","followers_url":"https://api.github.com/users/jaredkhan/followers","following_url":"https://api.github.com/users/jaredkhan/following{/other_user}","gists_url":"https://api.github.com/users/jaredkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredkhan/subscriptions","organizations_url":"https://api.github.com/users/jaredkhan/orgs","repos_url":"https://api.github.com/users/jaredkhan/repos","events_url":"https://api.github.com/users/jaredkhan/events{/privacy}","received_events_url":"https://api.github.com/users/jaredkhan/received_events","type":"User","site_admin":false},"body":"Sorry for tangling these together. Will take care to not do this in future.\r\n\r\nHere, we define a controller that manages the data for the landing page and sends it to view models. \r\nWe also style the updates feed based on discussion in #32 \r\n\r\nI think this is a pretty nice set up. I like the idea of having view models that match up with BEM blocks though I haven't gone fully that way yet. \r\n\r\nI really like the way we can separate out our components here. It could be useful to make some sandbox route in the dev environment e.g. `/sandbox/PostCard` that allows us to see components in isolation ","created_at":"2017-09-02T03:38:29Z","updated_at":"2017-09-02T03:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5dbe3c6351982ca9d1a5c17a213f76418d00b28","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Pinpickle","id":3238878,"avatar_url":"https://avatars1.githubusercontent.com/u/3238878?v=4","gravatar_id":"","url":"https://api.github.com/users/Pinpickle","html_url":"https://github.com/Pinpickle","followers_url":"https://api.github.com/users/Pinpickle/followers","following_url":"https://api.github.com/users/Pinpickle/following{/other_user}","gists_url":"https://api.github.com/users/Pinpickle/gists{/gist_id}","starred_url":"https://api.github.com/users/Pinpickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pinpickle/subscriptions","organizations_url":"https://api.github.com/users/Pinpickle/orgs","repos_url":"https://api.github.com/users/Pinpickle/repos","events_url":"https://api.github.com/users/Pinpickle/events{/privacy}","received_events_url":"https://api.github.com/users/Pinpickle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46/commits","review_comments_url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46/comments","review_comment_url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/46/comments","statuses_url":"https://api.github.com/repos/hackersatcambridge/hac-website/statuses/7fb3c90761417475334ea1ff8ded4845d5001720","head":{"label":"jaredkhan:landing-page-controller","ref":"landing-page-controller","sha":"7fb3c90761417475334ea1ff8ded4845d5001720","user":{"login":"jaredkhan","id":3105017,"avatar_url":"https://avatars1.githubusercontent.com/u/3105017?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredkhan","html_url":"https://github.com/jaredkhan","followers_url":"https://api.github.com/users/jaredkhan/followers","following_url":"https://api.github.com/users/jaredkhan/following{/other_user}","gists_url":"https://api.github.com/users/jaredkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredkhan/subscriptions","organizations_url":"https://api.github.com/users/jaredkhan/orgs","repos_url":"https://api.github.com/users/jaredkhan/repos","events_url":"https://api.github.com/users/jaredkhan/events{/privacy}","received_events_url":"https://api.github.com/users/jaredkhan/received_events","type":"User","site_admin":false},"repo":{"id":84611605,"name":"hac-website","full_name":"jaredkhan/hac-website","owner":{"login":"jaredkhan","id":3105017,"avatar_url":"https://avatars1.githubusercontent.com/u/3105017?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredkhan","html_url":"https://github.com/jaredkhan","followers_url":"https://api.github.com/users/jaredkhan/followers","following_url":"https://api.github.com/users/jaredkhan/following{/other_user}","gists_url":"https://api.github.com/users/jaredkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredkhan/subscriptions","organizations_url":"https://api.github.com/users/jaredkhan/orgs","repos_url":"https://api.github.com/users/jaredkhan/repos","events_url":"https://api.github.com/users/jaredkhan/events{/privacy}","received_events_url":"https://api.github.com/users/jaredkhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaredkhan/hac-website","description":"The Hackers at Cambridge Website Repo","fork":true,"url":"https://api.github.com/repos/jaredkhan/hac-website","forks_url":"https://api.github.com/repos/jaredkhan/hac-website/forks","keys_url":"https://api.github.com/repos/jaredkhan/hac-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaredkhan/hac-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaredkhan/hac-website/teams","hooks_url":"https://api.github.com/repos/jaredkhan/hac-website/hooks","issue_events_url":"https://api.github.com/repos/jaredkhan/hac-website/issues/events{/number}","events_url":"https://api.github.com/repos/jaredkhan/hac-website/events","assignees_url":"https://api.github.com/repos/jaredkhan/hac-website/assignees{/user}","branches_url":"https://api.github.com/repos/jaredkhan/hac-website/branches{/branch}","tags_url":"https://api.github.com/repos/jaredkhan/hac-website/tags","blobs_url":"https://api.github.com/repos/jaredkhan/hac-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaredkhan/hac-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaredkhan/hac-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaredkhan/hac-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaredkhan/hac-website/statuses/{sha}","languages_url":"https://api.github.com/repos/jaredkhan/hac-website/languages","stargazers_url":"https://api.github.com/repos/jaredkhan/hac-website/stargazers","contributors_url":"https://api.github.com/repos/jaredkhan/hac-website/contributors","subscribers_url":"https://api.github.com/repos/jaredkhan/hac-website/subscribers","subscription_url":"https://api.github.com/repos/jaredkhan/hac-website/subscription","commits_url":"https://api.github.com/repos/jaredkhan/hac-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaredkhan/hac-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaredkhan/hac-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaredkhan/hac-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaredkhan/hac-website/contents/{+path}","compare_url":"https://api.github.com/repos/jaredkhan/hac-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaredkhan/hac-website/merges","archive_url":"https://api.github.com/repos/jaredkhan/hac-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaredkhan/hac-website/downloads","issues_url":"https://api.github.com/repos/jaredkhan/hac-website/issues{/number}","pulls_url":"https://api.github.com/repos/jaredkhan/hac-website/pulls{/number}","milestones_url":"https://api.github.com/repos/jaredkhan/hac-website/milestones{/number}","notifications_url":"https://api.github.com/repos/jaredkhan/hac-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaredkhan/hac-website/labels{/name}","releases_url":"https://api.github.com/repos/jaredkhan/hac-website/releases{/id}","deployments_url":"https://api.github.com/repos/jaredkhan/hac-website/deployments","created_at":"2017-03-11T00:18:03Z","updated_at":"2017-03-11T00:18:39Z","pushed_at":"2017-09-02T03:30:39Z","git_url":"git://github.com/jaredkhan/hac-website.git","ssh_url":"git@github.com:jaredkhan/hac-website.git","clone_url":"https://github.com/jaredkhan/hac-website.git","svn_url":"https://github.com/jaredkhan/hac-website","homepage":null,"size":2473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hackersatcambridge:add-styles","ref":"add-styles","sha":"fc88b5a9847063b7e15ae6caba8a840bd56101a1","user":{"login":"hackersatcambridge","id":15255484,"avatar_url":"https://avatars1.githubusercontent.com/u/15255484?v=4","gravatar_id":"","url":"https://api.github.com/users/hackersatcambridge","html_url":"https://github.com/hackersatcambridge","followers_url":"https://api.github.com/users/hackersatcambridge/followers","following_url":"https://api.github.com/users/hackersatcambridge/following{/other_user}","gists_url":"https://api.github.com/users/hackersatcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/hackersatcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackersatcambridge/subscriptions","organizations_url":"https://api.github.com/users/hackersatcambridge/orgs","repos_url":"https://api.github.com/users/hackersatcambridge/repos","events_url":"https://api.github.com/users/hackersatcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/hackersatcambridge/received_events","type":"Organization","site_admin":false},"repo":{"id":81341682,"name":"hac-website","full_name":"hackersatcambridge/hac-website","owner":{"login":"hackersatcambridge","id":15255484,"avatar_url":"https://avatars1.githubusercontent.com/u/15255484?v=4","gravatar_id":"","url":"https://api.github.com/users/hackersatcambridge","html_url":"https://github.com/hackersatcambridge","followers_url":"https://api.github.com/users/hackersatcambridge/followers","following_url":"https://api.github.com/users/hackersatcambridge/following{/other_user}","gists_url":"https://api.github.com/users/hackersatcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/hackersatcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackersatcambridge/subscriptions","organizations_url":"https://api.github.com/users/hackersatcambridge/orgs","repos_url":"https://api.github.com/users/hackersatcambridge/repos","events_url":"https://api.github.com/users/hackersatcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/hackersatcambridge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hackersatcambridge/hac-website","description":"The Hackers at Cambridge Website Repo","fork":false,"url":"https://api.github.com/repos/hackersatcambridge/hac-website","forks_url":"https://api.github.com/repos/hackersatcambridge/hac-website/forks","keys_url":"https://api.github.com/repos/hackersatcambridge/hac-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackersatcambridge/hac-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackersatcambridge/hac-website/teams","hooks_url":"https://api.github.com/repos/hackersatcambridge/hac-website/hooks","issue_events_url":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/events{/number}","events_url":"https://api.github.com/repos/hackersatcambridge/hac-website/events","assignees_url":"https://api.github.com/repos/hackersatcambridge/hac-website/assignees{/user}","branches_url":"https://api.github.com/repos/hackersatcambridge/hac-website/branches{/branch}","tags_url":"https://api.github.com/repos/hackersatcambridge/hac-website/tags","blobs_url":"https://api.github.com/repos/hackersatcambridge/hac-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackersatcambridge/hac-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackersatcambridge/hac-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackersatcambridge/hac-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackersatcambridge/hac-website/statuses/{sha}","languages_url":"https://api.github.com/repos/hackersatcambridge/hac-website/languages","stargazers_url":"https://api.github.com/repos/hackersatcambridge/hac-website/stargazers","contributors_url":"https://api.github.com/repos/hackersatcambridge/hac-website/contributors","subscribers_url":"https://api.github.com/repos/hackersatcambridge/hac-website/subscribers","subscription_url":"https://api.github.com/repos/hackersatcambridge/hac-website/subscription","commits_url":"https://api.github.com/repos/hackersatcambridge/hac-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackersatcambridge/hac-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackersatcambridge/hac-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/hackersatcambridge/hac-website/contents/{+path}","compare_url":"https://api.github.com/repos/hackersatcambridge/hac-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackersatcambridge/hac-website/merges","archive_url":"https://api.github.com/repos/hackersatcambridge/hac-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackersatcambridge/hac-website/downloads","issues_url":"https://api.github.com/repos/hackersatcambridge/hac-website/issues{/number}","pulls_url":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls{/number}","milestones_url":"https://api.github.com/repos/hackersatcambridge/hac-website/milestones{/number}","notifications_url":"https://api.github.com/repos/hackersatcambridge/hac-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackersatcambridge/hac-website/labels{/name}","releases_url":"https://api.github.com/repos/hackersatcambridge/hac-website/releases{/id}","deployments_url":"https://api.github.com/repos/hackersatcambridge/hac-website/deployments","created_at":"2017-02-08T15:04:23Z","updated_at":"2017-09-01T07:54:47Z","pushed_at":"2017-09-02T03:38:30Z","git_url":"git://github.com/hackersatcambridge/hac-website.git","ssh_url":"git@github.com:hackersatcambridge/hac-website.git","clone_url":"https://github.com/hackersatcambridge/hac-website.git","svn_url":"https://github.com/hackersatcambridge/hac-website","homepage":null,"size":109,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":19,"forks":3,"open_issues":19,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46"},"html":{"href":"https://github.com/hackersatcambridge/hac-website/pull/46"},"issue":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/46"},"comments":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/hackersatcambridge/hac-website/statuses/7fb3c90761417475334ea1ff8ded4845d5001720"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Pinpickle"}}