{"action":"closed","number":2732,"pull_request":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732","id":130766351,"html_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2732","diff_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2732.diff","patch_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2732.patch","issue_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2732","number":2732,"state":"closed","locked":false,"title":"Simplify explicit super() calls.","user":{"login":"AndyMender","id":15969405,"avatar_url":"https://avatars1.githubusercontent.com/u/15969405?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyMender","html_url":"https://github.com/AndyMender","followers_url":"https://api.github.com/users/AndyMender/followers","following_url":"https://api.github.com/users/AndyMender/following{/other_user}","gists_url":"https://api.github.com/users/AndyMender/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyMender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyMender/subscriptions","organizations_url":"https://api.github.com/users/AndyMender/orgs","repos_url":"https://api.github.com/users/AndyMender/repos","events_url":"https://api.github.com/users/AndyMender/events{/privacy}","received_events_url":"https://api.github.com/users/AndyMender/received_events","type":"User","site_admin":false},"body":"This is an attempt to reduce the explicit calls `super(ChildClass, self).superclass_method()` to `super().superclass_method()`, as per changes in Python3 the `superclass_method` is bound to the instance of `ChildClass` by default. This does not touch cases when the `superclass_method` is bound to another object like in `super(ChildClass, cls).superclass_method()`.\r\n\r\nIn the midst of my analysis I noticed cases when a base class calls `super()` on itself as in:\r\n```python \r\nclass A:\r\n     def __init__(self, x, y):\r\n         super().__init__()\r\n         self.x = x\r\n         self.y = y\r\n```\r\nThe Python interpreter claims it's wrong and at first glance may lead to infinite loops regardless. These cases were labeled with a TODO comment.","created_at":"2017-07-16T21:09:10Z","updated_at":"2017-09-16T13:55:26Z","closed_at":"2017-09-16T13:55:26Z","merged_at":"2017-09-16T13:55:26Z","merge_commit_sha":"1e3e6153764b05f6f5a4e2b7266751c95ee9d23b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"squiddy","id":50333,"avatar_url":"https://avatars2.githubusercontent.com/u/50333?v=4","gravatar_id":"","url":"https://api.github.com/users/squiddy","html_url":"https://github.com/squiddy","followers_url":"https://api.github.com/users/squiddy/followers","following_url":"https://api.github.com/users/squiddy/following{/other_user}","gists_url":"https://api.github.com/users/squiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/squiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squiddy/subscriptions","organizations_url":"https://api.github.com/users/squiddy/orgs","repos_url":"https://api.github.com/users/squiddy/repos","events_url":"https://api.github.com/users/squiddy/events{/privacy}","received_events_url":"https://api.github.com/users/squiddy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732/commits","review_comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732/comments","review_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2732/comments","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/086e23b5f29841726830f08090674346b5c50513","head":{"label":"unknown-horizons:simplify-super-calls","ref":"simplify-super-calls","sha":"086e23b5f29841726830f08090674346b5c50513","user":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars2.githubusercontent.com/u/372796?v=4","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"repo":{"id":856193,"name":"unknown-horizons","full_name":"unknown-horizons/unknown-horizons","owner":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars2.githubusercontent.com/u/372796?v=4","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unknown-horizons/unknown-horizons","description":"Unknown Horizons official code repository","fork":false,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","forks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/forks","keys_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/events","assignees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/merges","archive_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/deployments","created_at":"2010-08-23T08:48:29Z","updated_at":"2017-09-13T05:50:00Z","pushed_at":"2017-09-16T13:55:26Z","git_url":"git://github.com/unknown-horizons/unknown-horizons.git","ssh_url":"git@github.com:unknown-horizons/unknown-horizons.git","clone_url":"https://github.com/unknown-horizons/unknown-horizons.git","svn_url":"https://github.com/unknown-horizons/unknown-horizons","homepage":"http://unknown-horizons.org","size":492175,"stargazers_count":611,"watchers_count":611,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":227,"forks":159,"open_issues":227,"watchers":611,"default_branch":"master"}},"base":{"label":"unknown-horizons:master","ref":"master","sha":"eb3ac788b3e91200426d6b1a3f8c4c687bc16591","user":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars2.githubusercontent.com/u/372796?v=4","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"repo":{"id":856193,"name":"unknown-horizons","full_name":"unknown-horizons/unknown-horizons","owner":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars2.githubusercontent.com/u/372796?v=4","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unknown-horizons/unknown-horizons","description":"Unknown Horizons official code repository","fork":false,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","forks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/forks","keys_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/events","assignees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/merges","archive_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/deployments","created_at":"2010-08-23T08:48:29Z","updated_at":"2017-09-13T05:50:00Z","pushed_at":"2017-09-16T13:55:26Z","git_url":"git://github.com/unknown-horizons/unknown-horizons.git","ssh_url":"git@github.com:unknown-horizons/unknown-horizons.git","clone_url":"https://github.com/unknown-horizons/unknown-horizons.git","svn_url":"https://github.com/unknown-horizons/unknown-horizons","homepage":"http://unknown-horizons.org","size":492175,"stargazers_count":611,"watchers_count":611,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":227,"forks":159,"open_issues":227,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732"},"html":{"href":"https://github.com/unknown-horizons/unknown-horizons/pull/2732"},"issue":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2732"},"comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2732/comments"},"review_comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732/comments"},"review_comment":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2732/commits"},"statuses":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/086e23b5f29841726830f08090674346b5c50513"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AndyMender","id":15969405,"avatar_url":"https://avatars1.githubusercontent.com/u/15969405?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyMender","html_url":"https://github.com/AndyMender","followers_url":"https://api.github.com/users/AndyMender/followers","following_url":"https://api.github.com/users/AndyMender/following{/other_user}","gists_url":"https://api.github.com/users/AndyMender/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyMender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyMender/subscriptions","organizations_url":"https://api.github.com/users/AndyMender/orgs","repos_url":"https://api.github.com/users/AndyMender/repos","events_url":"https://api.github.com/users/AndyMender/events{/privacy}","received_events_url":"https://api.github.com/users/AndyMender/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":18,"additions":718,"deletions":715,"changed_files":213}}
{"actor":{"display_login":"AndyMender"}}