{"action":"created","comment":{"url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments/129872221","pull_request_review_id":52690772,"id":129872221,"diff_hunk":"@@ -0,0 +1,96 @@\n+/*\n+ * Copyright (c) 2017, Uber Technologies, Inc\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+\n+package com.uber.jaeger.baggage;\n+\n+import com.uber.jaeger.Span;\n+import com.uber.jaeger.SpanContext;\n+import com.uber.jaeger.metrics.Metrics;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import lombok.Value;\n+\n+/**\n+ * BaggageSetter is a class that sets baggage and the logs associated\n+ * with the baggage on a given {@link Span}.\n+ */\n+@Value(staticConstructor = \"of\")\n+public class BaggageSetter {\n+  final boolean valid;\n+  final int maxValueLength;\n+  final Metrics metrics;","path":"jaeger-core/src/main/java/com/uber/jaeger/baggage/BaggageSetter.java","position":42,"original_position":42,"commit_id":"72c1b849a2e54cb2370abccdb70de572c69adfd8","original_commit_id":"72c1b849a2e54cb2370abccdb70de572c69adfd8","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":" * to make fields visible to subclasses, they should be `protected`. Did you also need package visibility?\r\n * given that these fields are final, there should be a constructor setting them. If they are only set by subclasses, then the constructor can be protected (but then this class should be abstract).\r\n * the concept of `valid` is not clear, please document","created_at":"2017-07-27T15:18:42Z","updated_at":"2017-07-27T15:18:42Z","html_url":"https://github.com/uber/jaeger-client-java/pull/217#discussion_r129872221","pull_request_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments/129872221"},"html":{"href":"https://github.com/uber/jaeger-client-java/pull/217#discussion_r129872221"},"pull_request":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217","id":132083691,"html_url":"https://github.com/uber/jaeger-client-java/pull/217","diff_url":"https://github.com/uber/jaeger-client-java/pull/217.diff","patch_url":"https://github.com/uber/jaeger-client-java/pull/217.patch","issue_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/217","number":217,"state":"open","locked":false,"title":"Add BaggageRestrictionManager","user":{"login":"black-adder","id":791791,"avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},"body":"Subset of this: https://github.com/uber/jaeger-client-java/pull/210/files. Only adding the BaggageRestrictionManager abstract class and the DefaultBaggageRestrictionManager.\r\n\r\n- [x] Tests\r\n","created_at":"2017-07-24T15:51:50Z","updated_at":"2017-07-27T15:18:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e0330a6b9c4c9de4bfac31313e42cb7ced55594","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217/commits","review_comments_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217/comments","review_comment_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/217/comments","statuses_url":"https://api.github.com/repos/uber/jaeger-client-java/statuses/72c1b849a2e54cb2370abccdb70de572c69adfd8","head":{"label":"black-adder:Add_BaggageRestrictionManager","ref":"Add_BaggageRestrictionManager","sha":"72c1b849a2e54cb2370abccdb70de572c69adfd8","user":{"login":"black-adder","id":791791,"avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},"repo":{"id":98193933,"name":"jaeger-client-java","full_name":"black-adder/jaeger-client-java","owner":{"login":"black-adder","id":791791,"avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/black-adder/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":true,"url":"https://api.github.com/repos/black-adder/jaeger-client-java","forks_url":"https://api.github.com/repos/black-adder/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/black-adder/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/black-adder/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/black-adder/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/black-adder/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/black-adder/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/black-adder/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/black-adder/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/black-adder/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/black-adder/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/black-adder/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/black-adder/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/black-adder/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/black-adder/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/black-adder/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/black-adder/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/black-adder/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/black-adder/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/black-adder/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/black-adder/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/black-adder/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/black-adder/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/black-adder/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/black-adder/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/black-adder/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/black-adder/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/black-adder/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/black-adder/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/black-adder/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/black-adder/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/black-adder/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/black-adder/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/black-adder/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/black-adder/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/black-adder/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/black-adder/jaeger-client-java/deployments","created_at":"2017-07-24T13:30:52Z","updated_at":"2017-07-24T13:30:54Z","pushed_at":"2017-07-26T18:28:38Z","git_url":"git://github.com/black-adder/jaeger-client-java.git","ssh_url":"git@github.com:black-adder/jaeger-client-java.git","clone_url":"https://github.com/black-adder/jaeger-client-java.git","svn_url":"https://github.com/black-adder/jaeger-client-java","homepage":"http://uber.github.io/jaeger/","size":1005,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"3e8e32bdbdc69603b7cce15af666ccc2db6fd870","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56551000,"name":"jaeger-client-java","full_name":"uber/jaeger-client-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-java","forks_url":"https://api.github.com/repos/uber/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-java/deployments","created_at":"2016-04-19T00:10:02Z","updated_at":"2017-07-26T14:00:14Z","pushed_at":"2017-07-27T14:23:55Z","git_url":"git://github.com/uber/jaeger-client-java.git","ssh_url":"git@github.com:uber/jaeger-client-java.git","clone_url":"https://github.com/uber/jaeger-client-java.git","svn_url":"https://github.com/uber/jaeger-client-java","homepage":"http://uber.github.io/jaeger/","size":979,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":25,"forks":32,"open_issues":25,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217"},"html":{"href":"https://github.com/uber/jaeger-client-java/pull/217"},"issue":{"href":"https://api.github.com/repos/uber/jaeger-client-java/issues/217"},"comments":{"href":"https://api.github.com/repos/uber/jaeger-client-java/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/uber/jaeger-client-java/statuses/72c1b849a2e54cb2370abccdb70de572c69adfd8"}}}}
{"actor":{"display_login":"yurishkuro"}}