{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/40837","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/40837/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/40837/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/40837/events","html_url":"https://github.com/saltstack/salt/pull/40837","id":223607168,"number":40837,"title":"Upgrade apache-libcloud package dependency for 2.0","user":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars2.githubusercontent.com/u/1532417?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2017-04-23T02:21:41Z","updated_at":"2017-05-05T17:15:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/40837","html_url":"https://github.com/saltstack/salt/pull/40837","diff_url":"https://github.com/saltstack/salt/pull/40837.diff","patch_url":"https://github.com/saltstack/salt/pull/40837.patch"},"body":"### What does this PR do?\r\n\r\nThis package updates the apache-libcloud dependency for salt-cloud to the 2.0 version, from 0.14. \r\n\r\n0.14 is a _very_ old version of libcloud and there have been performance improvements, stability changes and security fixes in the past 2 years that salt-cloud could take advantage of. Most of the salt-cloud modules that use libcloud e.g. GCP and Dimension Data require a newer version anyway, so the user just has to upgrade. \r\n\r\nThe 2.0 release also no longer uses httplib, now uses the `requests` package, which is already a dependency of salt and doesn't require SSL cert configuration for the CA store. The implications are \r\nhttp://libcloud.readthedocs.io/en/latest/other/changes_in_2_0.html\r\n2.0 supports Python 3.6, drops 2.5 and 3.2. Python 2.6 support is still included.\r\n\r\nThis is an open PR for discussion, look at the downstream dependencies and their impact. Also, part of a conversation with @techhat \r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nI've left a comment over the 2.0 build as only rc2 is on PyPi at the moment but the full release comes out this week."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/299522982","html_url":"https://github.com/saltstack/salt/pull/40837#issuecomment-299522982","issue_url":"https://api.github.com/repos/saltstack/salt/issues/40837","id":299522982,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars0.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T17:15:30Z","updated_at":"2017-05-05T17:15:30Z","body":"@toanju Would you mind filing that stacktrace as another issue? My feeling here is that even if we do upgrade libcloud, we need to adjust those calls that are producing stacktraces to be more defensive anyhow."}}
{"actor":{"display_login":"cachedout"}}