{"action":"closed","number":10095,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095","id":112733862,"html_url":"https://github.com/bitcoin/bitcoin/pull/10095","diff_url":"https://github.com/bitcoin/bitcoin/pull/10095.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10095.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10095","number":10095,"state":"closed","locked":false,"title":"refactor: Move GetDifficulty out of `rpc/server.h`","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars3.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"`GetDifficulty` has no business in `rpcserver.h`. Define it in the interface header of the implementation unit `rpcblockchain` where it is defined.\r\n\r\nAlso modernize the signature to:\r\n\r\n    double GetDifficulty(const CBlockIndex* blockindex = nullptr);\r\n\r\n(remove `extern`, replace `NULL` with `nullptr`)","created_at":"2017-03-27T12:31:55Z","updated_at":"2017-03-31T10:58:09Z","closed_at":"2017-03-31T10:58:09Z","merged_at":"2017-03-31T10:58:09Z","merge_commit_sha":"f885b670290d39e697995fd2d35dc36edc104011","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10095/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f885b670290d39e697995fd2d35dc36edc104011","head":{"label":"laanwj:2017_03_getdifficulty_header","ref":"2017_03_getdifficulty_header","sha":"f885b670290d39e697995fd2d35dc36edc104011","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars3.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"repo":{"id":1750308,"name":"bitcoin","full_name":"laanwj/bitcoin","owner":{"login":"laanwj","id":126646,"avatar_url":"https://avatars3.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laanwj/bitcoin","description":"Laanwj's Bitcoin Core fork - see README.md on master branch","fork":true,"url":"https://api.github.com/repos/laanwj/bitcoin","forks_url":"https://api.github.com/repos/laanwj/bitcoin/forks","keys_url":"https://api.github.com/repos/laanwj/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laanwj/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laanwj/bitcoin/teams","hooks_url":"https://api.github.com/repos/laanwj/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/laanwj/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/laanwj/bitcoin/events","assignees_url":"https://api.github.com/repos/laanwj/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/laanwj/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/laanwj/bitcoin/tags","blobs_url":"https://api.github.com/repos/laanwj/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laanwj/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laanwj/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/laanwj/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laanwj/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/laanwj/bitcoin/languages","stargazers_url":"https://api.github.com/repos/laanwj/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/laanwj/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/laanwj/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/laanwj/bitcoin/subscription","commits_url":"https://api.github.com/repos/laanwj/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/laanwj/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/laanwj/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/laanwj/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/laanwj/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/laanwj/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laanwj/bitcoin/merges","archive_url":"https://api.github.com/repos/laanwj/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laanwj/bitcoin/downloads","issues_url":"https://api.github.com/repos/laanwj/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/laanwj/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/laanwj/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/laanwj/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laanwj/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/laanwj/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/laanwj/bitcoin/deployments","created_at":"2011-05-15T07:09:54Z","updated_at":"2017-01-24T08:53:19Z","pushed_at":"2017-03-30T07:47:52Z","git_url":"git://github.com/laanwj/bitcoin.git","ssh_url":"git@github.com:laanwj/bitcoin.git","clone_url":"https://github.com/laanwj/bitcoin.git","svn_url":"https://github.com/laanwj/bitcoin","homepage":"","size":73871,"stargazers_count":12,"watchers_count":12,"language":null,"has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":12,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"4bd0e9b90a39c5c6a016b83882ae44cb4d28f1f8","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-03-31T09:44:15Z","pushed_at":"2017-03-31T10:57:41Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":80325,"stargazers_count":11974,"watchers_count":11974,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7757,"mirror_url":null,"open_issues_count":655,"forks":7757,"open_issues":655,"watchers":11974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10095"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10095"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10095/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10095/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f885b670290d39e697995fd2d35dc36edc104011"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"laanwj","id":126646,"avatar_url":"https://avatars3.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":52,"deletions":17,"changed_files":8}}
{"actor":{"display_login":"laanwj"}}