{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/157355486","pull_request_review_id":83987488,"id":157355486,"diff_hunk":"@@ -944,9 +975,10 @@ than the index of the last item.\n This is consistent with core libraries that do the same thing.\n \n {:.good-style}\n+<?code-excerpt \"misc/test/effective_dart_test.dart (param-range)\" replace=\"/expect\\(//g; /, \\/\\*\\*\\//  \\/\\//g; /\\);//g\"?>\n {% prettify dart %}\n-[0, 1, 2, 3].sublist(1, 3) // [1, 2].\n-'abcd'.substring(1, 3)     // \"bc\".\n+[0, 1, 2, 3].sublist(1, 3)  // [1, 2]","path":"src/_guides/language/effective-dart/design.md","position":358,"original_position":358,"commit_id":"3ca1f9ac38b4d7d897f900ab4efe08b5d558ee46","original_commit_id":"3ca1f9ac38b4d7d897f900ab4efe08b5d558ee46","user":{"login":"lrhn","id":4865287,"avatar_url":"https://avatars3.githubusercontent.com/u/4865287?v=4","gravatar_id":"","url":"https://api.github.com/users/lrhn","html_url":"https://github.com/lrhn","followers_url":"https://api.github.com/users/lrhn/followers","following_url":"https://api.github.com/users/lrhn/following{/other_user}","gists_url":"https://api.github.com/users/lrhn/gists{/gist_id}","starred_url":"https://api.github.com/users/lrhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrhn/subscriptions","organizations_url":"https://api.github.com/users/lrhn/orgs","repos_url":"https://api.github.com/users/lrhn/repos","events_url":"https://api.github.com/users/lrhn/events{/privacy}","received_events_url":"https://api.github.com/users/lrhn/received_events","type":"User","site_admin":false},"body":"The formatter leaves only one space between the end-of-line and the `//`,  so you shouldn't need to insert an extra space here.","created_at":"2017-12-17T01:19:49Z","updated_at":"2017-12-17T01:41:14Z","html_url":"https://github.com/dart-lang/site-www/pull/480#discussion_r157355486","pull_request_url":"https://api.github.com/repos/dart-lang/site-www/pulls/480","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/157355486"},"html":{"href":"https://github.com/dart-lang/site-www/pull/480#discussion_r157355486"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/480"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/480","id":158652245,"html_url":"https://github.com/dart-lang/site-www/pull/480","diff_url":"https://github.com/dart-lang/site-www/pull/480.diff","patch_url":"https://github.com/dart-lang/site-www/pull/480.patch","issue_url":"https://api.github.com/repos/dart-lang/site-www/issues/480","number":480,"state":"open","locked":false,"title":"Tests and code-excerpts for Effective Dart Design","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"Contributes to #407, covering Effective Dart Desgin.\r\n\r\n- Staged at https://dartlang-org-staging-0.firebaseapp.com/guides/language/effective-dart/design\r\n- Current https://www.dartlang.org/guides/language/effective-dart/design","created_at":"2017-12-15T17:16:49Z","updated_at":"2017-12-17T01:41:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885da0cd5527299b56c78ee2ef3dba2500b2e4cc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kwalrath","id":2164483,"avatar_url":"https://avatars2.githubusercontent.com/u/2164483?v=4","gravatar_id":"","url":"https://api.github.com/users/kwalrath","html_url":"https://github.com/kwalrath","followers_url":"https://api.github.com/users/kwalrath/followers","following_url":"https://api.github.com/users/kwalrath/following{/other_user}","gists_url":"https://api.github.com/users/kwalrath/gists{/gist_id}","starred_url":"https://api.github.com/users/kwalrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwalrath/subscriptions","organizations_url":"https://api.github.com/users/kwalrath/orgs","repos_url":"https://api.github.com/users/kwalrath/repos","events_url":"https://api.github.com/users/kwalrath/events{/privacy}","received_events_url":"https://api.github.com/users/kwalrath/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dart-lang/site-www/milestones/4","html_url":"https://github.com/dart-lang/site-www/milestone/4","labels_url":"https://api.github.com/repos/dart-lang/site-www/milestones/4/labels","id":2901189,"number":4,"title":"1.24","description":"","creator":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":13,"state":"open","created_at":"2017-11-09T16:26:48Z","updated_at":"2017-12-15T17:16:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dart-lang/site-www/pulls/480/commits","review_comments_url":"https://api.github.com/repos/dart-lang/site-www/pulls/480/comments","review_comment_url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/site-www/issues/480/comments","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/3ca1f9ac38b4d7d897f900ab4efe08b5d558ee46","head":{"label":"dart-lang:chalin-effective-dart-design-1215","ref":"chalin-effective-dart-design-1215","sha":"3ca1f9ac38b4d7d897f900ab4efe08b5d558ee46","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2017-12-13T14:11:08Z","pushed_at":"2017-12-16T14:31:50Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":10903,"stargazers_count":28,"watchers_count":28,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":118,"watchers":28,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"f4c0e24cb7433437dcc5150426f08f5dbecb65c0","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2017-12-13T14:11:08Z","pushed_at":"2017-12-16T14:31:50Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":10903,"stargazers_count":28,"watchers_count":28,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":118,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/480"},"html":{"href":"https://github.com/dart-lang/site-www/pull/480"},"issue":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/480"},"comments":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/site-www/statuses/3ca1f9ac38b4d7d897f900ab4efe08b5d558ee46"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lrhn"}}