{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69","id":152373338,"html_url":"https://github.com/compucorp/org.civicrm.shoreditch/pull/69","diff_url":"https://github.com/compucorp/org.civicrm.shoreditch/pull/69.diff","patch_url":"https://github.com/compucorp/org.civicrm.shoreditch/pull/69.patch","issue_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/69","number":69,"state":"closed","locked":false,"title":"PCHR-2918: Hide labels qhen quicksearch opens on IE11 too","user":{"login":"AkA84","id":6400898,"avatar_url":"https://avatars0.githubusercontent.com/u/6400898?v=4","gravatar_id":"","url":"https://api.github.com/users/AkA84","html_url":"https://github.com/AkA84","followers_url":"https://api.github.com/users/AkA84/followers","following_url":"https://api.github.com/users/AkA84/following{/other_user}","gists_url":"https://api.github.com/users/AkA84/gists{/gist_id}","starred_url":"https://api.github.com/users/AkA84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkA84/subscriptions","organizations_url":"https://api.github.com/users/AkA84/orgs","repos_url":"https://api.github.com/users/AkA84/repos","events_url":"https://api.github.com/users/AkA84/events{/privacy}","received_events_url":"https://api.github.com/users/AkA84/received_events","type":"User","site_admin":false},"body":"## Problem\r\nThe labels would not get hidden on IE11 when the quickform field is open\r\n![before](https://user-images.githubusercontent.com/6400898/32754426-eabcab98-c8d0-11e7-8e4a-fc62f8d0571b.gif)\r\n\r\n\r\n## Solution\r\nThe JS workaround to wrap the menu item labels in a `<span class=\"menumain-label\">` element used the `parentElement` property of the menu item HTML node, which does not exist in IE. Using the `parentNode` property instead fixes the issue\r\n\r\n![after](https://user-images.githubusercontent.com/6400898/32754425-ea9fa390-c8d0-11e7-8eca-6734ade35b65.gif)\r\n","created_at":"2017-11-13T23:14:48Z","updated_at":"2017-11-14T08:56:17Z","closed_at":"2017-11-14T08:56:17Z","merged_at":"2017-11-14T08:56:17Z","merge_commit_sha":"0690b35d17bfa335937deb52706e63dfc28370a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69/commits","review_comments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69/comments","review_comment_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/69/comments","statuses_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/statuses/54a02f758587613106f9fa7f95f772cd4f4049f0","head":{"label":"compucorp:PCHR-2918-fix-labels-on-IE11","ref":"PCHR-2918-fix-labels-on-IE11","sha":"54a02f758587613106f9fa7f95f772cd4f4049f0","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":86069967,"name":"org.civicrm.shoreditch","full_name":"compucorp/org.civicrm.shoreditch","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/org.civicrm.shoreditch","description":null,"fork":true,"url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch","forks_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/forks","keys_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/teams","hooks_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/hooks","issue_events_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/events","assignees_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/tags","blobs_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/languages","stargazers_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/stargazers","contributors_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/contributors","subscribers_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/subscribers","subscription_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/subscription","commits_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/merges","archive_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/downloads","issues_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/deployments","created_at":"2017-03-24T13:17:34Z","updated_at":"2017-04-08T00:50:51Z","pushed_at":"2017-11-14T08:56:17Z","git_url":"git://github.com/compucorp/org.civicrm.shoreditch.git","ssh_url":"git@github.com:compucorp/org.civicrm.shoreditch.git","clone_url":"https://github.com/compucorp/org.civicrm.shoreditch.git","svn_url":"https://github.com/compucorp/org.civicrm.shoreditch","homepage":null,"size":9539,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"staging"}},"base":{"label":"compucorp:PCHR-2578-menu-updates","ref":"PCHR-2578-menu-updates","sha":"2774ff8422cb67600d1a811c5856f88b0f67f14d","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":86069967,"name":"org.civicrm.shoreditch","full_name":"compucorp/org.civicrm.shoreditch","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/org.civicrm.shoreditch","description":null,"fork":true,"url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch","forks_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/forks","keys_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/teams","hooks_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/hooks","issue_events_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/events","assignees_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/tags","blobs_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/languages","stargazers_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/stargazers","contributors_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/contributors","subscribers_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/subscribers","subscription_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/subscription","commits_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/merges","archive_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/downloads","issues_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/deployments","created_at":"2017-03-24T13:17:34Z","updated_at":"2017-04-08T00:50:51Z","pushed_at":"2017-11-14T08:56:17Z","git_url":"git://github.com/compucorp/org.civicrm.shoreditch.git","ssh_url":"git@github.com:compucorp/org.civicrm.shoreditch.git","clone_url":"https://github.com/compucorp/org.civicrm.shoreditch.git","svn_url":"https://github.com/compucorp/org.civicrm.shoreditch","homepage":null,"size":9539,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69"},"html":{"href":"https://github.com/compucorp/org.civicrm.shoreditch/pull/69"},"issue":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/69"},"comments":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/org.civicrm.shoreditch/statuses/54a02f758587613106f9fa7f95f772cd4f4049f0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AkA84","id":6400898,"avatar_url":"https://avatars0.githubusercontent.com/u/6400898?v=4","gravatar_id":"","url":"https://api.github.com/users/AkA84","html_url":"https://github.com/AkA84","followers_url":"https://api.github.com/users/AkA84/followers","following_url":"https://api.github.com/users/AkA84/following{/other_user}","gists_url":"https://api.github.com/users/AkA84/gists{/gist_id}","starred_url":"https://api.github.com/users/AkA84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkA84/subscriptions","organizations_url":"https://api.github.com/users/AkA84/orgs","repos_url":"https://api.github.com/users/AkA84/repos","events_url":"https://api.github.com/users/AkA84/events{/privacy}","received_events_url":"https://api.github.com/users/AkA84/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"AkA84"}}