{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/158734627","pull_request_review_id":85584273,"id":158734627,"diff_hunk":"@@ -64,7 +64,9 @@ case \"$PACKAGE_ARCH\" in\n \t\t;;\n \t*)\n \t\tDOCKERFILE=\"Dockerfile.$PACKAGE_ARCH\"\n-\t\tTEST_IMAGE_NAMESPACE=\"$PACKAGE_ARCH\"\n+\t\tif [ \"$PACKAGE_ARCH\" != \"aarch64\" ]; then\n+\t\t\tTEST_IMAGE_NAMESPACE=\"$PACKAGE_ARCH\"\n+\t\tfi","path":"hack/make/.detect-daemon-osarch","position":7,"original_position":7,"commit_id":"0af5db511ed1ed5beab0feb09a2a96347a263410","original_commit_id":"0af5db511ed1ed5beab0feb09a2a96347a263410","user":{"login":"tianon","id":161631,"avatar_url":"https://avatars1.githubusercontent.com/u/161631?v=4","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},"body":"The idea here is that eventually we can remove this per-arch block entirely, right? (and possibly even use the same `Dockerfile` verbatim across arches?)\r\n\r\n(Forgot to add this comment to my \"review\" hahaha :innocent:)","created_at":"2017-12-26T19:35:12Z","updated_at":"2017-12-26T19:35:12Z","html_url":"https://github.com/moby/moby/pull/35772#discussion_r158734627","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/35772","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/158734627"},"html":{"href":"https://github.com/moby/moby/pull/35772#discussion_r158734627"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/35772"}}},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/35772","id":157752583,"html_url":"https://github.com/moby/moby/pull/35772","diff_url":"https://github.com/moby/moby/pull/35772.diff","patch_url":"https://github.com/moby/moby/pull/35772.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/35772","number":35772,"state":"open","locked":false,"title":"Download support of images with multi-arch manifest","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"body":"Currently we only support 'application/vnd.docker.distribution.manifest.v2+json'\r\nmanifest images download, with more multi-arch images used, we need to support\r\ndownload images with 'application/vnd.docker.distribution.manifest.list.v2+json'\r\nformat(aka \"fat manifest\"), else we will fail to download those multi-arch images.\r\n\r\nThis PR adds 'application/vnd.docker.distribution.manifest.list.v2+json' manifest\r\nsupport, thus we can download both multi-arch and legacy images.\r\n\r\nFix: #35841\r\n\r\nSigned-off-by: Dennis Chen <dennis.chen@arm.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nAdd 'application/vnd.docker.distribution.manifest.list.v2+json' manifest images download support. \r\n**- How I did it**\r\nGet the first level manifest, if it's a 'fat manifest', then get the 2nd level manifest which can match the run time arch.\r\n**- How to verify it**\r\nAfter apply the patch, `make binary` & `make  test-integration` upon both legacy and multi-arch docker images, on both arm64 and amd64 platforms.\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![summit](https://user-images.githubusercontent.com/29669302/33869898-47b2b762-df46-11e7-99ef-bc1e21734d27.jpg)\r\n\r\n","created_at":"2017-12-12T07:13:26Z","updated_at":"2017-12-26T19:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5666879b9937e1298702f8b8e0bd8a999cbcf9d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dnephin","id":442180,"avatar_url":"https://avatars1.githubusercontent.com/u/442180?v=4","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/35772/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/35772/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/35772/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/0af5db511ed1ed5beab0feb09a2a96347a263410","head":{"label":"arm64b:multi-arch-manifest-support","ref":"multi-arch-manifest-support","sha":"0af5db511ed1ed5beab0feb09a2a96347a263410","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"repo":{"id":111627875,"name":"moby","full_name":"arm64b/moby","owner":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arm64b/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/arm64b/moby","forks_url":"https://api.github.com/repos/arm64b/moby/forks","keys_url":"https://api.github.com/repos/arm64b/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arm64b/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arm64b/moby/teams","hooks_url":"https://api.github.com/repos/arm64b/moby/hooks","issue_events_url":"https://api.github.com/repos/arm64b/moby/issues/events{/number}","events_url":"https://api.github.com/repos/arm64b/moby/events","assignees_url":"https://api.github.com/repos/arm64b/moby/assignees{/user}","branches_url":"https://api.github.com/repos/arm64b/moby/branches{/branch}","tags_url":"https://api.github.com/repos/arm64b/moby/tags","blobs_url":"https://api.github.com/repos/arm64b/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arm64b/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arm64b/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/arm64b/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arm64b/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/arm64b/moby/languages","stargazers_url":"https://api.github.com/repos/arm64b/moby/stargazers","contributors_url":"https://api.github.com/repos/arm64b/moby/contributors","subscribers_url":"https://api.github.com/repos/arm64b/moby/subscribers","subscription_url":"https://api.github.com/repos/arm64b/moby/subscription","commits_url":"https://api.github.com/repos/arm64b/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/arm64b/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/arm64b/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/arm64b/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/arm64b/moby/contents/{+path}","compare_url":"https://api.github.com/repos/arm64b/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arm64b/moby/merges","archive_url":"https://api.github.com/repos/arm64b/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arm64b/moby/downloads","issues_url":"https://api.github.com/repos/arm64b/moby/issues{/number}","pulls_url":"https://api.github.com/repos/arm64b/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/arm64b/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/arm64b/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arm64b/moby/labels{/name}","releases_url":"https://api.github.com/repos/arm64b/moby/releases{/id}","deployments_url":"https://api.github.com/repos/arm64b/moby/deployments","created_at":"2017-11-22T02:43:58Z","updated_at":"2017-11-22T02:44:11Z","pushed_at":"2017-12-14T05:38:19Z","git_url":"git://github.com/arm64b/moby.git","ssh_url":"git@github.com:arm64b/moby.git","clone_url":"https://github.com/arm64b/moby.git","svn_url":"https://github.com/arm64b/moby","homepage":"https://mobyproject.org/","size":137961,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"1cea9d3bdb427bbdd7f14c6b11a3f6cef332bd34","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2017-12-26T17:41:41Z","pushed_at":"2017-12-26T06:17:27Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":138075,"stargazers_count":46966,"watchers_count":46966,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13898,"mirror_url":null,"archived":false,"open_issues_count":3061,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13898,"open_issues":3061,"watchers":46966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/35772"},"html":{"href":"https://github.com/moby/moby/pull/35772"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/35772"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/35772/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/35772/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/35772/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/0af5db511ed1ed5beab0feb09a2a96347a263410"}},"author_association":"NONE"}}
{"actor":{"display_login":"tianon"}}