{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/1470","repository_url":"https://api.github.com/repos/OpenMW/openmw","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470/events","html_url":"https://github.com/OpenMW/openmw/pull/1470","id":259241928,"number":1470,"title":"ESS-Importer: Convert magic projectiles","user":{"login":"MiroslavR","id":7346770,"avatar_url":"https://avatars2.githubusercontent.com/u/7346770?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroslavR","html_url":"https://github.com/MiroslavR","followers_url":"https://api.github.com/users/MiroslavR/followers","following_url":"https://api.github.com/users/MiroslavR/following{/other_user}","gists_url":"https://api.github.com/users/MiroslavR/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroslavR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroslavR/subscriptions","organizations_url":"https://api.github.com/users/MiroslavR/orgs","repos_url":"https://api.github.com/users/MiroslavR/repos","events_url":"https://api.github.com/users/MiroslavR/events{/privacy}","received_events_url":"https://api.github.com/users/MiroslavR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-20T17:28:28Z","updated_at":"2017-09-20T23:49:42Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1470","html_url":"https://github.com/OpenMW/openmw/pull/1470","diff_url":"https://github.com/OpenMW/openmw/pull/1470.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1470.patch"},"body":"Implements: https://bugs.openmw.org/issues/2320\r\n\r\nThis PR imports and converts magic projectiles, and partially imports active spells (SPLM record). To make this conversion possible, OpenMW save format was slightly changed. Particularly, these redundant MPRJ fields were removed:\r\n* sourceName (can be determined from spellId)\r\n* effects (can be determined from spellId)\r\n* stack (was always false)\r\n* sound (was unused)\r\n\r\nThe interface for launching magic projectiles was also refactored to remove redundancy.\r\n\r\nStrange things noticed during development:\r\n* `ESMStore::find(const std::string &id)` does not seem to work for spell records,\r\n* Magic projectile speed stored by vanilla is 1000 times greater than OpenMW, e.g. `1250` vs `1.25` for spell \"fireball\" (content file defines `1.25` speed for \"Fire Damage\" effect). I'm not sure where that factor comes from.\r\n"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/331011924","html_url":"https://github.com/OpenMW/openmw/pull/1470#issuecomment-331011924","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1470","id":331011924,"user":{"login":"MiroslavR","id":7346770,"avatar_url":"https://avatars2.githubusercontent.com/u/7346770?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroslavR","html_url":"https://github.com/MiroslavR","followers_url":"https://api.github.com/users/MiroslavR/followers","following_url":"https://api.github.com/users/MiroslavR/following{/other_user}","gists_url":"https://api.github.com/users/MiroslavR/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroslavR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroslavR/subscriptions","organizations_url":"https://api.github.com/users/MiroslavR/orgs","repos_url":"https://api.github.com/users/MiroslavR/repos","events_url":"https://api.github.com/users/MiroslavR/events{/privacy}","received_events_url":"https://api.github.com/users/MiroslavR/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T23:49:42Z","updated_at":"2017-09-20T23:49:42Z","author_association":"COLLABORATOR","body":"Well, I'm stumped. I thought we didn't even guarantee _backwards_ compatibility until 1.0 is released (but we just did that out of the kindness of our hearts). And now I'm hearing about maintaining forwards compabitility as well... Ugh, that sounds like a massive PITA. Is it worth it to inconvenience developers / possibly hurt development for satisfying a few version hoppers (I wonder if there even are any such people)? If you want to enforce that, it should at least be mentioned somewhere (other than in some random PR).\r\n\r\nIn any case, I don't know what to do with this PR then. It kinda relies on these changes in the save format."}}
{"actor":{"display_login":"MiroslavR"}}