{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments/114442927","pull_request_review_id":35909735,"id":114442927,"diff_hunk":"@@ -105,6 +105,10 @@\n       is: 'my-app',\n \n       properties: {\n+        rootPattern: {\n+          type: String,\n+          computed: '_computeRootPattern(rootPath)',\n+        },","path":"src/my-app.html","position":29,"original_position":29,"commit_id":"9d5535ef336524de8c6475c90ea39951658b9152","original_commit_id":"9d5535ef336524de8c6475c90ea39951658b9152","user":{"login":"abdonrd","id":1007051,"avatar_url":"https://avatars2.githubusercontent.com/u/1007051?v=3","gravatar_id":"","url":"https://api.github.com/users/abdonrd","html_url":"https://github.com/abdonrd","followers_url":"https://api.github.com/users/abdonrd/followers","following_url":"https://api.github.com/users/abdonrd/following{/other_user}","gists_url":"https://api.github.com/users/abdonrd/gists{/gist_id}","starred_url":"https://api.github.com/users/abdonrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdonrd/subscriptions","organizations_url":"https://api.github.com/users/abdonrd/orgs","repos_url":"https://api.github.com/users/abdonrd/repos","events_url":"https://api.github.com/users/abdonrd/events{/privacy}","received_events_url":"https://api.github.com/users/abdonrd/received_events","type":"User","site_admin":false},"body":"Nit: One line break please.","created_at":"2017-05-02T22:46:20Z","updated_at":"2017-05-02T22:46:39Z","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008#discussion_r114442927","pull_request_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments/114442927"},"html":{"href":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008#discussion_r114442927"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008","id":117399476,"html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008","diff_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008.diff","patch_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008.patch","issue_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1008","number":1008,"state":"open","locked":false,"title":"Use relative paths with Polymer v1 Starter Kit","user":{"login":"jsilvermist","id":10246291,"avatar_url":"https://avatars3.githubusercontent.com/u/10246291?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilvermist","html_url":"https://github.com/jsilvermist","followers_url":"https://api.github.com/users/jsilvermist/followers","following_url":"https://api.github.com/users/jsilvermist/following{/other_user}","gists_url":"https://api.github.com/users/jsilvermist/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilvermist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilvermist/subscriptions","organizations_url":"https://api.github.com/users/jsilvermist/orgs","repos_url":"https://api.github.com/users/jsilvermist/repos","events_url":"https://api.github.com/users/jsilvermist/events{/privacy}","received_events_url":"https://api.github.com/users/jsilvermist/received_events","type":"User","site_admin":false},"body":"#### Polymer v1 / PSK 2.0 version of #995, basically the same with a few differences for Polymer v1 support.\r\n1. Since `created` is called too early, and `ready` too late, ~~uses an observer to set `rootPattern`.~~ **Now uses a computed property**\r\n1. Since Polymer v1 rewrites paths based on import path it requires `rootPath` bindings for `view` links. (Also works in Polymer 2, but not necessary.)\r\n1. ~~Update Polymer dependency to `1.9.0` for `rootPath` support.~~ **Already done on master**\r\n\r\nDue to the differences in rewriting of paths I'm not sure where this fits in continuity between PSK 2.0 and PSK 3.0, ease of use for new users, and ease of use when deploying to a subdirectory.\r\n\r\n(I'm not sure if it would be better to merge this, or just direct users looking for this functionality to the Polymer 2 starter kit.)\r\n\r\n#### Live Demos\r\n[Simple Build](https://silverlinkz.net/_test/polymer/relative-starter-kit/)\r\n[Bundled & Minified Build](https://silverlinkz.net/_test/polymer/relative-starter-kit-bundled/)\r\n","created_at":"2017-04-25T03:46:10Z","updated_at":"2017-05-02T22:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b04a0d5bae46800ba0742223330911dd63e1281c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1008/comments","statuses_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/9d5535ef336524de8c6475c90ea39951658b9152","head":{"label":"jsilvermist:polymer-1-relative-paths","ref":"polymer-1-relative-paths","sha":"9d5535ef336524de8c6475c90ea39951658b9152","user":{"login":"jsilvermist","id":10246291,"avatar_url":"https://avatars3.githubusercontent.com/u/10246291?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilvermist","html_url":"https://github.com/jsilvermist","followers_url":"https://api.github.com/users/jsilvermist/followers","following_url":"https://api.github.com/users/jsilvermist/following{/other_user}","gists_url":"https://api.github.com/users/jsilvermist/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilvermist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilvermist/subscriptions","organizations_url":"https://api.github.com/users/jsilvermist/orgs","repos_url":"https://api.github.com/users/jsilvermist/repos","events_url":"https://api.github.com/users/jsilvermist/events{/privacy}","received_events_url":"https://api.github.com/users/jsilvermist/received_events","type":"User","site_admin":false},"repo":{"id":84497340,"name":"polymer-starter-kit","full_name":"jsilvermist/polymer-starter-kit","owner":{"login":"jsilvermist","id":10246291,"avatar_url":"https://avatars3.githubusercontent.com/u/10246291?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilvermist","html_url":"https://github.com/jsilvermist","followers_url":"https://api.github.com/users/jsilvermist/followers","following_url":"https://api.github.com/users/jsilvermist/following{/other_user}","gists_url":"https://api.github.com/users/jsilvermist/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilvermist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilvermist/subscriptions","organizations_url":"https://api.github.com/users/jsilvermist/orgs","repos_url":"https://api.github.com/users/jsilvermist/repos","events_url":"https://api.github.com/users/jsilvermist/events{/privacy}","received_events_url":"https://api.github.com/users/jsilvermist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsilvermist/polymer-starter-kit","description":"A starting point for Polymer 1.0 apps","fork":true,"url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit","forks_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/forks","keys_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/teams","hooks_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/events","assignees_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/tags","blobs_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/languages","stargazers_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/subscription","commits_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/merges","archive_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/downloads","issues_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/jsilvermist/polymer-starter-kit/deployments","created_at":"2017-03-09T23:10:53Z","updated_at":"2017-03-09T23:10:55Z","pushed_at":"2017-05-01T19:14:42Z","git_url":"git://github.com/jsilvermist/polymer-starter-kit.git","ssh_url":"git@github.com:jsilvermist/polymer-starter-kit.git","clone_url":"https://github.com/jsilvermist/polymer-starter-kit.git","svn_url":"https://github.com/jsilvermist/polymer-starter-kit","homepage":"https://www.polymer-project.org/1.0/start/toolbox/set-up","size":10922,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"7bdbf38facb705e81f7ed478d5aa9854e432a655","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34105868,"name":"polymer-starter-kit","full_name":"PolymerElements/polymer-starter-kit","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/polymer-starter-kit","description":"A starting point for Polymer 1.0 apps","fork":false,"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit","forks_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/forks","keys_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/teams","hooks_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/events","assignees_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/tags","blobs_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/subscription","commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/merges","archive_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/downloads","issues_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/deployments","created_at":"2015-04-17T08:41:44Z","updated_at":"2017-05-02T02:20:36Z","pushed_at":"2017-05-01T19:14:44Z","git_url":"git://github.com/PolymerElements/polymer-starter-kit.git","ssh_url":"git@github.com:PolymerElements/polymer-starter-kit.git","clone_url":"https://github.com/PolymerElements/polymer-starter-kit.git","svn_url":"https://github.com/PolymerElements/polymer-starter-kit","homepage":"https://www.polymer-project.org/1.0/start/toolbox/set-up","size":10920,"stargazers_count":2377,"watchers_count":2377,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":684,"mirror_url":null,"open_issues_count":29,"forks":684,"open_issues":29,"watchers":2377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008"},"html":{"href":"https://github.com/PolymerElements/polymer-starter-kit/pull/1008"},"issue":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1008"},"comments":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1008/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1008/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/9d5535ef336524de8c6475c90ea39951658b9152"}}}}
{"actor":{"display_login":"abdonrd"}}