{"action":"created","issue":{"url":"https://api.github.com/repos/rsyslog/rsyslog/issues/2109","repository_url":"https://api.github.com/repos/rsyslog/rsyslog","labels_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/2109/labels{/name}","comments_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/2109/comments","events_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/2109/events","html_url":"https://github.com/rsyslog/rsyslog/pull/2109","id":276743786,"number":2109,"title":"error during config processing: omfile: creating parent directories for file  'File exists'","user":{"login":"nipakoo","id":3278353,"avatar_url":"https://avatars1.githubusercontent.com/u/3278353?v=4","gravatar_id":"","url":"https://api.github.com/users/nipakoo","html_url":"https://github.com/nipakoo","followers_url":"https://api.github.com/users/nipakoo/followers","following_url":"https://api.github.com/users/nipakoo/following{/other_user}","gists_url":"https://api.github.com/users/nipakoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nipakoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipakoo/subscriptions","organizations_url":"https://api.github.com/users/nipakoo/orgs","repos_url":"https://api.github.com/users/nipakoo/repos","events_url":"https://api.github.com/users/nipakoo/events{/privacy}","received_events_url":"https://api.github.com/users/nipakoo/received_events","type":"User","site_admin":false},"labels":[{"id":42065809,"url":"https://api.github.com/repos/rsyslog/rsyslog/labels/bug","name":"bug","color":"fc2929","default":true},{"id":281058072,"url":"https://api.github.com/repos/rsyslog/rsyslog/labels/in-depth%20review%20required","name":"in-depth review required","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rsyslog/rsyslog/milestones/23","html_url":"https://github.com/rsyslog/rsyslog/milestone/23","labels_url":"https://api.github.com/repos/rsyslog/rsyslog/milestones/23/labels","id":2842433,"number":23,"title":"v8.32","description":"","creator":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars3.githubusercontent.com/u/1482123?v=4","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":0,"state":"open","created_at":"2017-10-17T07:53:51Z","updated_at":"2017-11-25T11:30:47Z","due_on":"2018-01-05T08:00:00Z","closed_at":null},"comments":1,"created_at":"2017-11-25T11:19:10Z","updated_at":"2017-11-25T14:47:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/2109","html_url":"https://github.com/rsyslog/rsyslog/pull/2109","diff_url":"https://github.com/rsyslog/rsyslog/pull/2109.diff","patch_url":"https://github.com/rsyslog/rsyslog/pull/2109.patch"},"body":"Add mutex for attempting to create parent directories of a log file. https://github.com/rsyslog/rsyslog/issues/2107"},"comment":{"url":"https://api.github.com/repos/rsyslog/rsyslog/issues/comments/346944764","html_url":"https://github.com/rsyslog/rsyslog/pull/2109#issuecomment-346944764","issue_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/2109","id":346944764,"user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars3.githubusercontent.com/u/1482123?v=4","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"created_at":"2017-11-25T14:47:10Z","updated_at":"2017-11-25T14:47:10Z","author_association":"OWNER","body":"I thought a bit about my concern: it is mostly invalid, the proposed cure is the right thing to do. There is just a border case during shutdown which could lead to a hang condition. That happens if the omfile thread needs to be cancelled by rsyslog core because it does not terminate within the timeout period. This is extremely unlikely to happen, though (a bit more likely with NFS I admit). So we need to have a cancel cleanup handler which unlocks the mutex under these circumstances.\r\n\r\nHaving said that, the newly introduced potential hang is less likely than what this PR fixes. So I think we are good to merge and can clean up the other one afterwards."}}
{"actor":{"display_login":"rgerhards"}}