{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/701","repository_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios","labels_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/701/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/701/comments","events_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/701/events","html_url":"https://github.com/Shopify/mobile-buy-sdk-ios/issues/701","id":245108970,"number":701,"title":"Expose Supported Pay Payment Networks / Capabilities","user":{"login":"cocoahero","id":318265,"avatar_url":"https://avatars2.githubusercontent.com/u/318265?v=4","gravatar_id":"","url":"https://api.github.com/users/cocoahero","html_url":"https://github.com/cocoahero","followers_url":"https://api.github.com/users/cocoahero/followers","following_url":"https://api.github.com/users/cocoahero/following{/other_user}","gists_url":"https://api.github.com/users/cocoahero/gists{/gist_id}","starred_url":"https://api.github.com/users/cocoahero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocoahero/subscriptions","organizations_url":"https://api.github.com/users/cocoahero/orgs","repos_url":"https://api.github.com/users/cocoahero/repos","events_url":"https://api.github.com/users/cocoahero/events{/privacy}","received_events_url":"https://api.github.com/users/cocoahero/received_events","type":"User","site_admin":false},"labels":[{"id":625838317,"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/labels/3.x","name":"3.x","color":"bfdadc","default":false},{"id":216972315,"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/labels/enhancement","name":"enhancement","color":"c2e0c6","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-24T14:59:46Z","updated_at":"2017-08-10T17:20:00Z","closed_at":"2017-08-10T16:25:12Z","body":"It would be nice if this framework exposed a public property that dictated the supported `PKPaymentNetwork` and `PKMerchantCapability`. As this is really dictated by the Shopify Payments gateway, it makes sense that Shopify has the responsibility in keeping these values up to date through SDK releases.\r\n\r\nIt appears that they are currently hardcoded here: https://github.com/Shopify/mobile-buy-sdk-ios/blob/a63dca5a7a5206f5066d2fa91fdffefdcdd0f67c/Pay/PaySession.swift#L165\r\n\r\nThis information would be useful in deciding whether or not to show an Pay checkout button in our apps. For example:\r\n\r\n```swift\r\nif PKPaymentAuthorizationViewController.canMakePayments() {\r\n  if PKPaymentAuthorizationViewController.canMakePayments(usingNetworks: [.visa, .masterCard, .amex], capabilities: [.capability3DS]) {\r\n    return PKPaymentButton(type: .buy, style: .black)\r\n  }\r\n  else {\r\n    return PKPaymentButton(type: .setUp, style: .black)\r\n  }\r\n}\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/comments/321617281","html_url":"https://github.com/Shopify/mobile-buy-sdk-ios/issues/701#issuecomment-321617281","issue_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/701","id":321617281,"user":{"login":"davidmuzi","id":1058176,"avatar_url":"https://avatars1.githubusercontent.com/u/1058176?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmuzi","html_url":"https://github.com/davidmuzi","followers_url":"https://api.github.com/users/davidmuzi/followers","following_url":"https://api.github.com/users/davidmuzi/following{/other_user}","gists_url":"https://api.github.com/users/davidmuzi/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmuzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmuzi/subscriptions","organizations_url":"https://api.github.com/users/davidmuzi/orgs","repos_url":"https://api.github.com/users/davidmuzi/repos","events_url":"https://api.github.com/users/davidmuzi/events{/privacy}","received_events_url":"https://api.github.com/users/davidmuzi/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T17:20:00Z","updated_at":"2017-08-10T17:20:00Z","body":"Im not sure the exposed paymentSetting for `supportedDigitalWallets` is sufficient.  Even though your shop has a payment gateway that supports Apple Pay, that does not mean it has been _enabled_.\r\n\r\nFor instance, my dev shop returns APPLE_PAY as a supported digital wallet, but its not enabled in the Mobile Channel."}}
{"actor":{"display_login":"davidmuzi"}}