{"action":"created","issue":{"url":"https://api.github.com/repos/tpope/vim-dispatch/issues/193","repository_url":"https://api.github.com/repos/tpope/vim-dispatch","labels_url":"https://api.github.com/repos/tpope/vim-dispatch/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/tpope/vim-dispatch/issues/193/comments","events_url":"https://api.github.com/repos/tpope/vim-dispatch/issues/193/events","html_url":"https://github.com/tpope/vim-dispatch/pull/193","id":184881962,"number":193,"title":"Add initial vim jobs strategy","user":{"login":"edkolev","id":1532071,"avatar_url":"https://avatars3.githubusercontent.com/u/1532071?v=4","gravatar_id":"","url":"https://api.github.com/users/edkolev","html_url":"https://github.com/edkolev","followers_url":"https://api.github.com/users/edkolev/followers","following_url":"https://api.github.com/users/edkolev/following{/other_user}","gists_url":"https://api.github.com/users/edkolev/gists{/gist_id}","starred_url":"https://api.github.com/users/edkolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edkolev/subscriptions","organizations_url":"https://api.github.com/users/edkolev/orgs","repos_url":"https://api.github.com/users/edkolev/repos","events_url":"https://api.github.com/users/edkolev/events{/privacy}","received_events_url":"https://api.github.com/users/edkolev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-10-24T15:57:05Z","updated_at":"2017-09-06T08:29:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tpope/vim-dispatch/pulls/193","html_url":"https://github.com/tpope/vim-dispatch/pull/193","diff_url":"https://github.com/tpope/vim-dispatch/pull/193.diff","patch_url":"https://github.com/tpope/vim-dispatch/pull/193.patch"},"body":"This is an initial version of a strategy based on vim 8's jobs. I saw the discussion in #188, hence this PR.\n\nI don't think it's ready yet (I haven't even tested it on files with whitespace in them).\n\nThis strategy works only for 'make' actions, but maybe it should also have a check if 'background' is true.\n\nAny feedback is appreciated.\n\nEdit: I haven't thought about windows support at all - the strategy uses dispatch#prepare_make() as well as &shell and &shellcmdflag\n"},"comment":{"url":"https://api.github.com/repos/tpope/vim-dispatch/issues/comments/327413636","html_url":"https://github.com/tpope/vim-dispatch/pull/193#issuecomment-327413636","issue_url":"https://api.github.com/repos/tpope/vim-dispatch/issues/193","id":327413636,"user":{"login":"gauteh","id":56827,"avatar_url":"https://avatars2.githubusercontent.com/u/56827?v=4","gravatar_id":"","url":"https://api.github.com/users/gauteh","html_url":"https://github.com/gauteh","followers_url":"https://api.github.com/users/gauteh/followers","following_url":"https://api.github.com/users/gauteh/following{/other_user}","gists_url":"https://api.github.com/users/gauteh/gists{/gist_id}","starred_url":"https://api.github.com/users/gauteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauteh/subscriptions","organizations_url":"https://api.github.com/users/gauteh/orgs","repos_url":"https://api.github.com/users/gauteh/repos","events_url":"https://api.github.com/users/gauteh/events{/privacy}","received_events_url":"https://api.github.com/users/gauteh/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T08:29:30Z","updated_at":"2017-09-06T08:29:30Z","author_association":"NONE","body":"Tim Pope writes on september 5, 2017 23:44:\n> Took a quick look at this. The `:Abort` command essentially just calls `kill -HUP <pid>`, and it seems to be correctly doing that on the job branch as well. However, unlike other adapters, that use a wrapper script, jobs are invoked with a simple `bash -c 'your command'`, and bash is smart enough to change this `exec your command`, which means `your command` receives the `HUP` directly. Some commands may ignore `HUP`, causing the abort to appear to fail.\n> \n> This is annoying. We could add a postfix like `; exit $?`, but now we have to worry about alternate shells like `fish` and `cmd.exe`.\n\nWould it be possible to do:\n\n`:Abort -9` to send the KILL signal in stead? I assume this will also be \npropagated to the underlying process. \n\nAlternatively, for this particular adapter `:Abort` could use: \n`job_stop(job)` or `job_stop(job, \"kill\")`. That would be the \nmost vimsy way.\n\n"}}
{"actor":{"display_login":"gauteh"}}