{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments/117108147","pull_request_review_id":38784696,"id":117108147,"diff_hunk":"@@ -183,13 +183,16 @@ If a `cgroupsPath` value is specified, the runtime MUST consistently attach to t\n Implementations of the Spec can choose to name cgroups in any manner.\n The Spec does not include naming schema for cgroups.\n The Spec does not support per-controller paths for the reasons discussed in the [cgroupv2 documentation][cgroup-v2].\n-The cgroups will be created if they don't exist.\n \n-You can configure a container's cgroups via the `resources` field of the Linux configuration.\n-Do not specify `resources` unless limits have to be updated.\n+The runtime MUST create the cgroups specified by the `cgroupsPath` if they don't exist.\n+If `cgroupsPath` is empty, then the behavior is runtime implementation specific.\n+\n+The runtime MUST ensure that the container process is attached to the cgroups specified by `cgroupsPath`.\n+If any property is set under `resources` then the runtime MUST set it for the container.\n+Check individual properties for any specific handling.\n+\n For example, to run a new process in an existing container without updating limits, `resources` need not be specified.\n \n-Runtimes MAY attach the container process to additional cgroup controllers beyond those necessary to fulfill the `resources` settings.","path":"config-linux.md","position":17,"original_position":17,"commit_id":"81c9f3116f3f646a87d0cbb8e682811ed3770693","original_commit_id":"81c9f3116f3f646a87d0cbb8e682811ed3770693","user":{"login":"wking","id":209920,"avatar_url":"https://avatars2.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"I don't think we want to drop this line.  I think the additional attaching is surprising, so if we don't forbid runtimes from doing it (which I don't think we can with runC), I'd like to keep mentioning this as an runtime prerogative.","created_at":"2017-05-17T20:57:28Z","updated_at":"2017-05-17T20:57:31Z","html_url":"https://github.com/opencontainers/runtime-spec/pull/834#discussion_r117108147","pull_request_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments/117108147"},"html":{"href":"https://github.com/opencontainers/runtime-spec/pull/834#discussion_r117108147"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834","id":121147509,"html_url":"https://github.com/opencontainers/runtime-spec/pull/834","diff_url":"https://github.com/opencontainers/runtime-spec/pull/834.diff","patch_url":"https://github.com/opencontainers/runtime-spec/pull/834.patch","issue_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/834","number":834,"state":"open","locked":false,"title":"Clarify cgroups path handling behavior","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars2.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Mrunal Patel <mrunalp@gmail.com>","created_at":"2017-05-17T20:40:40Z","updated_at":"2017-05-17T20:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7295932753fbab34ad906ba88f5a47ff300ba9d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/834/comments","statuses_url":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/81c9f3116f3f646a87d0cbb8e682811ed3770693","head":{"label":"mrunalp:cgroups_path","ref":"cgroups_path","sha":"81c9f3116f3f646a87d0cbb8e682811ed3770693","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars2.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"repo":{"id":38027472,"name":"specs","full_name":"mrunalp/specs","owner":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars2.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrunalp/specs","description":"Open Container Specifications","fork":true,"url":"https://api.github.com/repos/mrunalp/specs","forks_url":"https://api.github.com/repos/mrunalp/specs/forks","keys_url":"https://api.github.com/repos/mrunalp/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrunalp/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrunalp/specs/teams","hooks_url":"https://api.github.com/repos/mrunalp/specs/hooks","issue_events_url":"https://api.github.com/repos/mrunalp/specs/issues/events{/number}","events_url":"https://api.github.com/repos/mrunalp/specs/events","assignees_url":"https://api.github.com/repos/mrunalp/specs/assignees{/user}","branches_url":"https://api.github.com/repos/mrunalp/specs/branches{/branch}","tags_url":"https://api.github.com/repos/mrunalp/specs/tags","blobs_url":"https://api.github.com/repos/mrunalp/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrunalp/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrunalp/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrunalp/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrunalp/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/mrunalp/specs/languages","stargazers_url":"https://api.github.com/repos/mrunalp/specs/stargazers","contributors_url":"https://api.github.com/repos/mrunalp/specs/contributors","subscribers_url":"https://api.github.com/repos/mrunalp/specs/subscribers","subscription_url":"https://api.github.com/repos/mrunalp/specs/subscription","commits_url":"https://api.github.com/repos/mrunalp/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrunalp/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrunalp/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrunalp/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrunalp/specs/contents/{+path}","compare_url":"https://api.github.com/repos/mrunalp/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrunalp/specs/merges","archive_url":"https://api.github.com/repos/mrunalp/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrunalp/specs/downloads","issues_url":"https://api.github.com/repos/mrunalp/specs/issues{/number}","pulls_url":"https://api.github.com/repos/mrunalp/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/mrunalp/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/mrunalp/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrunalp/specs/labels{/name}","releases_url":"https://api.github.com/repos/mrunalp/specs/releases{/id}","deployments_url":"https://api.github.com/repos/mrunalp/specs/deployments","created_at":"2015-06-25T04:18:30Z","updated_at":"2015-06-25T03:30:37Z","pushed_at":"2017-05-17T20:40:00Z","git_url":"git://github.com/mrunalp/specs.git","ssh_url":"git@github.com:mrunalp/specs.git","clone_url":"https://github.com/mrunalp/specs.git","svn_url":"https://github.com/mrunalp/specs","homepage":"http://www.opencontainers.org","size":848,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"30362737548149b000128dbc059d7e2b13d1032e","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960293,"name":"runtime-spec","full_name":"opencontainers/runtime-spec","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runtime-spec","description":"OCI Runtime Specification","fork":false,"url":"https://api.github.com/repos/opencontainers/runtime-spec","forks_url":"https://api.github.com/repos/opencontainers/runtime-spec/forks","keys_url":"https://api.github.com/repos/opencontainers/runtime-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runtime-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runtime-spec/teams","hooks_url":"https://api.github.com/repos/opencontainers/runtime-spec/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runtime-spec/events","assignees_url":"https://api.github.com/repos/opencontainers/runtime-spec/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runtime-spec/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runtime-spec/tags","blobs_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runtime-spec/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runtime-spec/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runtime-spec/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runtime-spec/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runtime-spec/subscription","commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runtime-spec/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runtime-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runtime-spec/merges","archive_url":"https://api.github.com/repos/opencontainers/runtime-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runtime-spec/downloads","issues_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runtime-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runtime-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runtime-spec/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runtime-spec/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runtime-spec/deployments","created_at":"2015-06-05T23:30:10Z","updated_at":"2017-05-17T06:22:07Z","pushed_at":"2017-05-17T20:40:40Z","git_url":"git://github.com/opencontainers/runtime-spec.git","ssh_url":"git@github.com:opencontainers/runtime-spec.git","clone_url":"https://github.com/opencontainers/runtime-spec.git","svn_url":"https://github.com/opencontainers/runtime-spec","homepage":"http://www.opencontainers.org","size":1033,"stargazers_count":894,"watchers_count":894,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":42,"forks":184,"open_issues":42,"watchers":894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834"},"html":{"href":"https://github.com/opencontainers/runtime-spec/pull/834"},"issue":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/issues/834"},"comments":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/81c9f3116f3f646a87d0cbb8e682811ed3770693"}}}}
{"actor":{"display_login":"wking"}}