{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/365","repository_url":"https://api.github.com/repos/alphagov/govuk-frontend","labels_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/365/comments","events_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/365/events","html_url":"https://github.com/alphagov/govuk-frontend/pull/365","id":278456997,"number":365,"title":"NEEDS DISCUSSION - Fix visual regression of button component","user":{"login":"dashouse","id":23356842,"avatar_url":"https://avatars0.githubusercontent.com/u/23356842?v=4","gravatar_id":"","url":"https://api.github.com/users/dashouse","html_url":"https://github.com/dashouse","followers_url":"https://api.github.com/users/dashouse/followers","following_url":"https://api.github.com/users/dashouse/following{/other_user}","gists_url":"https://api.github.com/users/dashouse/gists{/gist_id}","starred_url":"https://api.github.com/users/dashouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashouse/subscriptions","organizations_url":"https://api.github.com/users/dashouse/orgs","repos_url":"https://api.github.com/users/dashouse/repos","events_url":"https://api.github.com/users/dashouse/events{/privacy}","received_events_url":"https://api.github.com/users/dashouse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-01T12:50:42Z","updated_at":"2017-12-01T13:01:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/pulls/365","html_url":"https://github.com/alphagov/govuk-frontend/pull/365","diff_url":"https://github.com/alphagov/govuk-frontend/pull/365.diff","patch_url":"https://github.com/alphagov/govuk-frontend/pull/365.patch"},"body":"This PR does fix the visual regression of the button component, however *there are a significant number of issues with the code*.\r\n\r\nPreviously the padding / general spacing was set on the class `govuk-c-button` - however all of the button types were rendering different sizes.\r\n\r\nThis is because a button as a link `a`, an `input` and `<button>` all treat `box-sizing: border-box;` differently. Therefore each button type needs to have individual paddings defined to keep them visually aligned.\r\n\r\nWe will, therefore be unable to use the spacing scale for internal paddings of buttons as on many occasions we will need to compensate for the 2px border (albeit invisible) and create the required total height of the button (40px on normal buttons, 44px on Start buttons).\r\n\r\nThe linter has also stopped me adding `line-height: 1;` underneath the font mixin, so I have needed to add `!important`\r\n\r\nI have removed the border bottom and reverted to box-shadow to avoid the bevelled effect on the border bottom.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/comments/348489149","html_url":"https://github.com/alphagov/govuk-frontend/pull/365#issuecomment-348489149","issue_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/365","id":348489149,"user":{"login":"nickcolley","id":2445413,"avatar_url":"https://avatars2.githubusercontent.com/u/2445413?v=4","gravatar_id":"","url":"https://api.github.com/users/nickcolley","html_url":"https://github.com/nickcolley","followers_url":"https://api.github.com/users/nickcolley/followers","following_url":"https://api.github.com/users/nickcolley/following{/other_user}","gists_url":"https://api.github.com/users/nickcolley/gists{/gist_id}","starred_url":"https://api.github.com/users/nickcolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickcolley/subscriptions","organizations_url":"https://api.github.com/users/nickcolley/orgs","repos_url":"https://api.github.com/users/nickcolley/repos","events_url":"https://api.github.com/users/nickcolley/events{/privacy}","received_events_url":"https://api.github.com/users/nickcolley/received_events","type":"User","site_admin":false},"created_at":"2017-12-01T13:01:43Z","updated_at":"2017-12-01T13:01:43Z","author_association":"CONTRIBUTOR","body":"When disabling linting rules normally there's a way to do it with comments, looks like this might work for your use case. https://github.com/sasstools/sass-lint#disabling-linters-via-source"}}
{"actor":{"display_login":"nickcolley"}}