{"action":"created","comment":{"url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/comments/96910434","pull_request_review_id":17508024,"id":96910434,"diff_hunk":"@@ -92,15 +88,41 @@ protected override void Validate()\n         {\n             base.Validate();\n \n+            if (string.IsNullOrEmpty(this.TwitterSiteUsername))\n+            {\n+                throw new ArgumentNullException(nameof(this.TwitterSiteUsername));\n+            }\n+\n             if (this.Image == null)\n             {\n                 throw new ArgumentNullException(nameof(this.Image));\n             }\n \n+            if (string.IsNullOrEmpty(this.Title))","path":"Source/MVC6/Boilerplate.AspNetCore.TagHelpers/Twitter/Cards/TwitterCardPlayer.cs","position":108,"original_position":108,"commit_id":"81b4affa5afea4bd43b5c874075998471f07c75d","original_commit_id":"81b4affa5afea4bd43b5c874075998471f07c75d","user":{"login":"RehanSaeed","id":2270364,"avatar_url":"https://avatars.githubusercontent.com/u/2270364?v=3","gravatar_id":"","url":"https://api.github.com/users/RehanSaeed","html_url":"https://github.com/RehanSaeed","followers_url":"https://api.github.com/users/RehanSaeed/followers","following_url":"https://api.github.com/users/RehanSaeed/following{/other_user}","gists_url":"https://api.github.com/users/RehanSaeed/gists{/gist_id}","starred_url":"https://api.github.com/users/RehanSaeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RehanSaeed/subscriptions","organizations_url":"https://api.github.com/users/RehanSaeed/orgs","repos_url":"https://api.github.com/users/RehanSaeed/repos","events_url":"https://api.github.com/users/RehanSaeed/events{/privacy}","received_events_url":"https://api.github.com/users/RehanSaeed/received_events","type":"User","site_admin":false},"body":"Are we sure these are **all** require properties?","created_at":"2017-01-19T17:18:44Z","updated_at":"2017-01-19T17:43:39Z","html_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11#discussion_r96910434","pull_request_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/comments/96910434"},"html":{"href":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11#discussion_r96910434"},"pull_request":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11","id":100431363,"html_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11","diff_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11.diff","patch_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11.patch","issue_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/11","number":11,"state":"open","locked":false,"title":"Expanded the Twitter Cards to address additional properties & Test Kits","user":{"login":"VeXHarbinger","id":830407,"avatar_url":"https://avatars.githubusercontent.com/u/830407?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXHarbinger","html_url":"https://github.com/VeXHarbinger","followers_url":"https://api.github.com/users/VeXHarbinger/followers","following_url":"https://api.github.com/users/VeXHarbinger/following{/other_user}","gists_url":"https://api.github.com/users/VeXHarbinger/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXHarbinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXHarbinger/subscriptions","organizations_url":"https://api.github.com/users/VeXHarbinger/orgs","repos_url":"https://api.github.com/users/VeXHarbinger/repos","events_url":"https://api.github.com/users/VeXHarbinger/events{/privacy}","received_events_url":"https://api.github.com/users/VeXHarbinger/received_events","type":"User","site_admin":false},"body":"Extended the Twitter Card Properties & Validation rules.   \r\nI thought I deleted the lines 84-86 in Framework.sln to remove the CodeALike reference, but they appear to still be there.\r\nRemembering the issues in the last merge, I thought it best to leave them for you to reject in the pull rather than have the multiple check-in issue again.","created_at":"2017-01-06T09:23:45Z","updated_at":"2017-01-19T17:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acfa2357d33aa940423d75470e49052663d849f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/11/comments","statuses_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/statuses/81b4affa5afea4bd43b5c874075998471f07c75d","head":{"label":"VeXHarbinger:ExpandedTwitterUserTags","ref":"ExpandedTwitterUserTags","sha":"81b4affa5afea4bd43b5c874075998471f07c75d","user":{"login":"VeXHarbinger","id":830407,"avatar_url":"https://avatars.githubusercontent.com/u/830407?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXHarbinger","html_url":"https://github.com/VeXHarbinger","followers_url":"https://api.github.com/users/VeXHarbinger/followers","following_url":"https://api.github.com/users/VeXHarbinger/following{/other_user}","gists_url":"https://api.github.com/users/VeXHarbinger/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXHarbinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXHarbinger/subscriptions","organizations_url":"https://api.github.com/users/VeXHarbinger/orgs","repos_url":"https://api.github.com/users/VeXHarbinger/repos","events_url":"https://api.github.com/users/VeXHarbinger/events{/privacy}","received_events_url":"https://api.github.com/users/VeXHarbinger/received_events","type":"User","site_admin":false},"repo":{"id":71291104,"name":"Framework","full_name":"VeXHarbinger/Framework","owner":{"login":"VeXHarbinger","id":830407,"avatar_url":"https://avatars.githubusercontent.com/u/830407?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXHarbinger","html_url":"https://github.com/VeXHarbinger","followers_url":"https://api.github.com/users/VeXHarbinger/followers","following_url":"https://api.github.com/users/VeXHarbinger/following{/other_user}","gists_url":"https://api.github.com/users/VeXHarbinger/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXHarbinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXHarbinger/subscriptions","organizations_url":"https://api.github.com/users/VeXHarbinger/orgs","repos_url":"https://api.github.com/users/VeXHarbinger/repos","events_url":"https://api.github.com/users/VeXHarbinger/events{/privacy}","received_events_url":"https://api.github.com/users/VeXHarbinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VeXHarbinger/Framework","description":"ASP.NET MVC Extensions and Helper NuGet packages","fork":true,"url":"https://api.github.com/repos/VeXHarbinger/Framework","forks_url":"https://api.github.com/repos/VeXHarbinger/Framework/forks","keys_url":"https://api.github.com/repos/VeXHarbinger/Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VeXHarbinger/Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VeXHarbinger/Framework/teams","hooks_url":"https://api.github.com/repos/VeXHarbinger/Framework/hooks","issue_events_url":"https://api.github.com/repos/VeXHarbinger/Framework/issues/events{/number}","events_url":"https://api.github.com/repos/VeXHarbinger/Framework/events","assignees_url":"https://api.github.com/repos/VeXHarbinger/Framework/assignees{/user}","branches_url":"https://api.github.com/repos/VeXHarbinger/Framework/branches{/branch}","tags_url":"https://api.github.com/repos/VeXHarbinger/Framework/tags","blobs_url":"https://api.github.com/repos/VeXHarbinger/Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VeXHarbinger/Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VeXHarbinger/Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/VeXHarbinger/Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VeXHarbinger/Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/VeXHarbinger/Framework/languages","stargazers_url":"https://api.github.com/repos/VeXHarbinger/Framework/stargazers","contributors_url":"https://api.github.com/repos/VeXHarbinger/Framework/contributors","subscribers_url":"https://api.github.com/repos/VeXHarbinger/Framework/subscribers","subscription_url":"https://api.github.com/repos/VeXHarbinger/Framework/subscription","commits_url":"https://api.github.com/repos/VeXHarbinger/Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/VeXHarbinger/Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/VeXHarbinger/Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/VeXHarbinger/Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/VeXHarbinger/Framework/contents/{+path}","compare_url":"https://api.github.com/repos/VeXHarbinger/Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VeXHarbinger/Framework/merges","archive_url":"https://api.github.com/repos/VeXHarbinger/Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VeXHarbinger/Framework/downloads","issues_url":"https://api.github.com/repos/VeXHarbinger/Framework/issues{/number}","pulls_url":"https://api.github.com/repos/VeXHarbinger/Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/VeXHarbinger/Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/VeXHarbinger/Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VeXHarbinger/Framework/labels{/name}","releases_url":"https://api.github.com/repos/VeXHarbinger/Framework/releases{/id}","deployments_url":"https://api.github.com/repos/VeXHarbinger/Framework/deployments","created_at":"2016-10-18T21:03:19Z","updated_at":"2016-10-18T21:03:21Z","pushed_at":"2017-01-06T22:28:02Z","git_url":"git://github.com/VeXHarbinger/Framework.git","ssh_url":"git@github.com:VeXHarbinger/Framework.git","clone_url":"https://github.com/VeXHarbinger/Framework.git","svn_url":"https://github.com/VeXHarbinger/Framework","homepage":null,"size":297,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ASP-NET-MVC-Boilerplate:master","ref":"master","sha":"938215ed5c1c3a73fc5a617bc307e5ea8ecfbfb1","user":{"login":"ASP-NET-MVC-Boilerplate","id":22211766,"avatar_url":"https://avatars.githubusercontent.com/u/22211766?v=3","gravatar_id":"","url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate","html_url":"https://github.com/ASP-NET-MVC-Boilerplate","followers_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/followers","following_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/following{/other_user}","gists_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/gists{/gist_id}","starred_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/subscriptions","organizations_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/orgs","repos_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/repos","events_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/events{/privacy}","received_events_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/received_events","type":"Organization","site_admin":false},"repo":{"id":68275048,"name":"Framework","full_name":"ASP-NET-MVC-Boilerplate/Framework","owner":{"login":"ASP-NET-MVC-Boilerplate","id":22211766,"avatar_url":"https://avatars.githubusercontent.com/u/22211766?v=3","gravatar_id":"","url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate","html_url":"https://github.com/ASP-NET-MVC-Boilerplate","followers_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/followers","following_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/following{/other_user}","gists_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/gists{/gist_id}","starred_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/subscriptions","organizations_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/orgs","repos_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/repos","events_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/events{/privacy}","received_events_url":"https://api.github.com/users/ASP-NET-MVC-Boilerplate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework","description":"ASP.NET MVC Extensions and Helper NuGet packages","fork":false,"url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework","forks_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/forks","keys_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/teams","hooks_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/hooks","issue_events_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/events{/number}","events_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/events","assignees_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/assignees{/user}","branches_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/branches{/branch}","tags_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/tags","blobs_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/languages","stargazers_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/stargazers","contributors_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/contributors","subscribers_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/subscribers","subscription_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/subscription","commits_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/contents/{+path}","compare_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/merges","archive_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/downloads","issues_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues{/number}","pulls_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/labels{/name}","releases_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/releases{/id}","deployments_url":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/deployments","created_at":"2016-09-15T07:34:12Z","updated_at":"2017-01-17T00:00:13Z","pushed_at":"2017-01-06T22:28:03Z","git_url":"git://github.com/ASP-NET-MVC-Boilerplate/Framework.git","ssh_url":"git@github.com:ASP-NET-MVC-Boilerplate/Framework.git","clone_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework.git","svn_url":"https://github.com/ASP-NET-MVC-Boilerplate/Framework","homepage":null,"size":278,"stargazers_count":22,"watchers_count":22,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11"},"html":{"href":"https://github.com/ASP-NET-MVC-Boilerplate/Framework/pull/11"},"issue":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/11"},"comments":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ASP-NET-MVC-Boilerplate/Framework/statuses/81b4affa5afea4bd43b5c874075998471f07c75d"}}}}
{"actor":{"display_login":"RehanSaeed"}}