{"action":"created","issue":{"url":"https://api.github.com/repos/convox/rack/issues/1535","repository_url":"https://api.github.com/repos/convox/rack","labels_url":"https://api.github.com/repos/convox/rack/issues/1535/labels{/name}","comments_url":"https://api.github.com/repos/convox/rack/issues/1535/comments","events_url":"https://api.github.com/repos/convox/rack/issues/1535/events","html_url":"https://github.com/convox/rack/pull/1535","id":199930722,"number":1535,"title":"UDP support + Disable ELB creation","user":{"login":"spencerhakim","id":606857,"avatar_url":"https://avatars0.githubusercontent.com/u/606857?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerhakim","html_url":"https://github.com/spencerhakim","followers_url":"https://api.github.com/users/spencerhakim/followers","following_url":"https://api.github.com/users/spencerhakim/following{/other_user}","gists_url":"https://api.github.com/users/spencerhakim/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerhakim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerhakim/subscriptions","organizations_url":"https://api.github.com/users/spencerhakim/orgs","repos_url":"https://api.github.com/users/spencerhakim/repos","events_url":"https://api.github.com/users/spencerhakim/events{/privacy}","received_events_url":"https://api.github.com/users/spencerhakim/received_events","type":"User","site_admin":false},"labels":[{"id":511811420,"url":"https://api.github.com/repos/convox/rack/labels/kind/feature","name":"kind/feature","color":"0052cc","default":false},{"id":511988652,"url":"https://api.github.com/repos/convox/rack/labels/status/6-merge","name":"status/6-merge","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/convox/rack/milestones/90","html_url":"https://github.com/convox/rack/milestone/90","labels_url":"https://api.github.com/repos/convox/rack/milestones/90/labels","id":2286947,"number":90,"title":"20170130-2","description":"","creator":{"login":"MiguelMoll","id":643960,"avatar_url":"https://avatars2.githubusercontent.com/u/643960?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelMoll","html_url":"https://github.com/MiguelMoll","followers_url":"https://api.github.com/users/MiguelMoll/followers","following_url":"https://api.github.com/users/MiguelMoll/following{/other_user}","gists_url":"https://api.github.com/users/MiguelMoll/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelMoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelMoll/subscriptions","organizations_url":"https://api.github.com/users/MiguelMoll/orgs","repos_url":"https://api.github.com/users/MiguelMoll/repos","events_url":"https://api.github.com/users/MiguelMoll/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelMoll/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"closed","created_at":"2017-01-30T16:36:45Z","updated_at":"2017-01-31T14:42:59Z","due_on":null,"closed_at":"2017-01-31T14:42:59Z"},"comments":32,"created_at":"2017-01-10T20:53:11Z","updated_at":"2017-04-19T20:53:29Z","closed_at":"2017-01-31T14:42:31Z","pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/1535","html_url":"https://github.com/convox/rack/pull/1535","diff_url":"https://github.com/convox/rack/pull/1535.diff","patch_url":"https://github.com/convox/rack/pull/1535.patch"},"body":"First attempt at #665 + #492, I'd love to get some feedback as I go. I haven't tested any of it yet, but hopefully there won't be too many problems.\r\n\r\nEDIT: OK, some notes. Since ELBs only support TCP, I treat ports as having one of 3 possible states: Public/External TCP, Internal TCP, or UDP. I also did my best to update any code that used something like `len(s.Ports) > 0` to determine if an ELB should be created to instead use `s.HasBalancer()`, and in general to add protocol checks to code that assumed ports would always be TCP. The regex I used for parsing the ports from the yaml file is forgiving and backwards compatible, while the regex used for parsing ports from the ECSTaskDefinition is not; if that was a mistake, I can easily correct it.\r\n\r\nAs a side-effect of adding UDP support, I was able to easily add in a check for `convox.elb=false` to disable ELB creation entirely, even when TCP ports are defined. Feel free to suggest a better name for this label.\r\n\r\nI still need to add my own tests, but I've fixed the existing tests to match."},"comment":{"url":"https://api.github.com/repos/convox/rack/issues/comments/295437365","html_url":"https://github.com/convox/rack/pull/1535#issuecomment-295437365","issue_url":"https://api.github.com/repos/convox/rack/issues/1535","id":295437365,"user":{"login":"ddollar","id":3308,"avatar_url":"https://avatars1.githubusercontent.com/u/3308?v=3","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"created_at":"2017-04-19T20:53:29Z","updated_at":"2017-04-19T20:53:29Z","body":"Stay tuned, we have some good stuff in the works for you folks.\r\n\r\nNow that we have host-based routing in ALB we can easily do one-ALB-per-Rack and route the internal hostnames correctly. The team is hard at work getting a completely revamped approach centered around this ready. We're hoping to have something for you all to try in the next few weeks."}}
{"actor":{"display_login":"ddollar"}}