{"action":"created","issue":{"url":"https://api.github.com/repos/svgdotjs/svg.js/issues/631","repository_url":"https://api.github.com/repos/svgdotjs/svg.js","labels_url":"https://api.github.com/repos/svgdotjs/svg.js/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/svgdotjs/svg.js/issues/631/comments","events_url":"https://api.github.com/repos/svgdotjs/svg.js/issues/631/events","html_url":"https://github.com/svgdotjs/svg.js/issues/631","id":212939050,"number":631,"title":"Typescript definitions edits: element.stop, container.polyline(), select(): Set, animation.scale()","user":{"login":"showdep","id":853226,"avatar_url":"https://avatars2.githubusercontent.com/u/853226?v=3","gravatar_id":"","url":"https://api.github.com/users/showdep","html_url":"https://github.com/showdep","followers_url":"https://api.github.com/users/showdep/followers","following_url":"https://api.github.com/users/showdep/following{/other_user}","gists_url":"https://api.github.com/users/showdep/gists{/gist_id}","starred_url":"https://api.github.com/users/showdep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showdep/subscriptions","organizations_url":"https://api.github.com/users/showdep/orgs","repos_url":"https://api.github.com/users/showdep/repos","events_url":"https://api.github.com/users/showdep/events{/privacy}","received_events_url":"https://api.github.com/users/showdep/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-09T05:29:26Z","updated_at":"2017-03-20T06:02:18Z","closed_at":"2017-03-20T06:02:17Z","body":"I would suggest a few changes to the TS definition file. My TS code compiles properly against svg.js 2.4.0 after I have made these. All changes are self explanatory (I hope). The scale() thing is discussed in #630.\r\n\r\n\r\n```\r\ninterface Element {\r\n  ...\r\n+  stop(jumpToEnd:boolean,clearQueue:boolean):void;\r\n}\r\n\r\ninterface Container {\r\n-  polyLine(points: string): PolyLine;\r\n-  polyLine(points: ArrayPoint[]): PolyLine;\r\n+  polyline(points: string): PolyLine;\r\n+  polyline(points: ArrayPoint[]): PolyLine;\r\n}\r\n\r\ninterface Library {\r\n  ...\r\n-  select(query: string, parent: HTMLElement): Element;\r\n+  select(query: string, parent: HTMLElement): Set;\r\n}\r\n\r\ninterface Parent {\r\n-  select(query: string): Element;\r\n+  select(query: string): Set;\r\n}\r\n\r\nexport interface Animation {\r\n  ...\r\n+  scale(w: number, h: number, cx: number, cy:number): Animation;\r\n  ...\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/svgdotjs/svg.js/issues/comments/287683587","html_url":"https://github.com/svgdotjs/svg.js/issues/631#issuecomment-287683587","issue_url":"https://api.github.com/repos/svgdotjs/svg.js/issues/631","id":287683587,"user":{"login":"showdep","id":853226,"avatar_url":"https://avatars2.githubusercontent.com/u/853226?v=3","gravatar_id":"","url":"https://api.github.com/users/showdep","html_url":"https://github.com/showdep","followers_url":"https://api.github.com/users/showdep/followers","following_url":"https://api.github.com/users/showdep/following{/other_user}","gists_url":"https://api.github.com/users/showdep/gists{/gist_id}","starred_url":"https://api.github.com/users/showdep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showdep/subscriptions","organizations_url":"https://api.github.com/users/showdep/orgs","repos_url":"https://api.github.com/users/showdep/repos","events_url":"https://api.github.com/users/showdep/events{/privacy}","received_events_url":"https://api.github.com/users/showdep/received_events","type":"User","site_admin":false},"created_at":"2017-03-20T06:02:17Z","updated_at":"2017-03-20T06:02:17Z","body":"Fine with me for now.\r\n"}}
{"actor":{"display_login":"showdep"}}