{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/780","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/780/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/780/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/780/events","html_url":"https://github.com/palantir/blueprint/issues/780","id":211996380,"number":780,"title":"Test compilation errors do not fail karma tasks","user":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars2.githubusercontent.com/u/723999?v=3","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"labels":[{"id":478396745,"url":"https://api.github.com/repos/palantir/blueprint/labels/Domain:%20testing","name":"Domain: testing","color":"d4792f","default":false},{"id":468856293,"url":"https://api.github.com/repos/palantir/blueprint/labels/Domain:%20tooling","name":"Domain: tooling","color":"d11b59","default":false},{"id":478396842,"url":"https://api.github.com/repos/palantir/blueprint/labels/P1","name":"P1","color":"d4792f","default":false},{"id":468827752,"url":"https://api.github.com/repos/palantir/blueprint/labels/Type:%20bug","name":"Type: bug","color":"de4343","default":false}],"state":"open","locked":false,"assignee":{"login":"giladgray","id":464822,"avatar_url":"https://avatars2.githubusercontent.com/u/464822?v=3","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"assignees":[{"login":"giladgray","id":464822,"avatar_url":"https://avatars2.githubusercontent.com/u/464822?v=3","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-05T23:58:02Z","updated_at":"2017-03-06T00:04:36Z","closed_at":null,"body":"Discovered in https://github.com/palantir/blueprint/pull/775#issuecomment-284160519\r\n\r\nCurrent compilation failures are fixed in https://github.com/palantir/blueprint/pull/779, but we need to fix the build system to fail on `tsc` errors. I tried to get this working using solutions from https://github.com/TypeStrong/ts-loader/issues/108 but did not succeed. A quick and dirty fix would be to run `tsc -p packages/<name>/test` commands in the verify script or in `gulp check`. Or we could try upgrading to webpack 2 (shouldn't be too hard; I just did it on another project)."},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/284274927","html_url":"https://github.com/palantir/blueprint/issues/780#issuecomment-284274927","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/780","id":284274927,"user":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars2.githubusercontent.com/u/723999?v=3","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"created_at":"2017-03-06T00:04:36Z","updated_at":"2017-03-06T00:04:36Z","body":"Same goes for tsc errors in examples via `npm run build:gulp`\r\n\r\n```\r\nERROR in ./packages/table/examples/tableFormatsExample.tsx\r\n(13,10): error TS6133: 'TruncatedPopoverMode' is declared but never used.\r\n```"}}
{"actor":{"display_login":"adidahiya"}}