{"action":"closed","number":290,"pull_request":{"url":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290","id":105546366,"html_url":"https://github.com/thriftrw/thriftrw-go/pull/290","diff_url":"https://github.com/thriftrw/thriftrw-go/pull/290.diff","patch_url":"https://github.com/thriftrw/thriftrw-go/pull/290.patch","issue_url":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/290","number":290,"state":"closed","locked":false,"title":"Handle the nil case in generated String() methods","user":{"login":"dmcaulay","id":899731,"avatar_url":"https://avatars.githubusercontent.com/u/899731?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcaulay","html_url":"https://github.com/dmcaulay","followers_url":"https://api.github.com/users/dmcaulay/followers","following_url":"https://api.github.com/users/dmcaulay/following{/other_user}","gists_url":"https://api.github.com/users/dmcaulay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcaulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcaulay/subscriptions","organizations_url":"https://api.github.com/users/dmcaulay/orgs","repos_url":"https://api.github.com/users/dmcaulay/repos","events_url":"https://api.github.com/users/dmcaulay/events{/privacy}","received_events_url":"https://api.github.com/users/dmcaulay/received_events","type":"User","site_admin":false},"body":"I was seeing panics when I tried to log nil values with [zap](https://github.com/uber-go/zap). I'll add a `nil` check there to make sure other libraries don't introduce panics, but this seemed like a good safeguard to have in the generated structs.\r\n\r\nHere's a [link](https://play.golang.org/p/zcXKrbDSwn) to some code that demonstrates the issue.","created_at":"2017-02-10T00:54:37Z","updated_at":"2017-02-10T17:56:57Z","closed_at":"2017-02-10T17:56:57Z","merged_at":"2017-02-10T17:56:57Z","merge_commit_sha":"0ce610addaa2bc495314496bf238e227b318c42d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290/commits","review_comments_url":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290/comments","review_comment_url":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/290/comments","statuses_url":"https://api.github.com/repos/thriftrw/thriftrw-go/statuses/f35d7a73d76e0bf202de156650f979a3325aa775","head":{"label":"dmcaulay:stringer","ref":"stringer","sha":"f35d7a73d76e0bf202de156650f979a3325aa775","user":{"login":"dmcaulay","id":899731,"avatar_url":"https://avatars.githubusercontent.com/u/899731?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcaulay","html_url":"https://github.com/dmcaulay","followers_url":"https://api.github.com/users/dmcaulay/followers","following_url":"https://api.github.com/users/dmcaulay/following{/other_user}","gists_url":"https://api.github.com/users/dmcaulay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcaulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcaulay/subscriptions","organizations_url":"https://api.github.com/users/dmcaulay/orgs","repos_url":"https://api.github.com/users/dmcaulay/repos","events_url":"https://api.github.com/users/dmcaulay/events{/privacy}","received_events_url":"https://api.github.com/users/dmcaulay/received_events","type":"User","site_admin":false},"repo":{"id":81510067,"name":"thriftrw-go","full_name":"dmcaulay/thriftrw-go","owner":{"login":"dmcaulay","id":899731,"avatar_url":"https://avatars.githubusercontent.com/u/899731?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcaulay","html_url":"https://github.com/dmcaulay","followers_url":"https://api.github.com/users/dmcaulay/followers","following_url":"https://api.github.com/users/dmcaulay/following{/other_user}","gists_url":"https://api.github.com/users/dmcaulay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcaulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcaulay/subscriptions","organizations_url":"https://api.github.com/users/dmcaulay/orgs","repos_url":"https://api.github.com/users/dmcaulay/repos","events_url":"https://api.github.com/users/dmcaulay/events{/privacy}","received_events_url":"https://api.github.com/users/dmcaulay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmcaulay/thriftrw-go","description":"A Thrift encoding code generator and library for Go","fork":true,"url":"https://api.github.com/repos/dmcaulay/thriftrw-go","forks_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/forks","keys_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/teams","hooks_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/hooks","issue_events_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/issues/events{/number}","events_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/events","assignees_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/assignees{/user}","branches_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/branches{/branch}","tags_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/tags","blobs_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/languages","stargazers_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/stargazers","contributors_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/contributors","subscribers_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/subscribers","subscription_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/subscription","commits_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/contents/{+path}","compare_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/merges","archive_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/downloads","issues_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/issues{/number}","pulls_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/labels{/name}","releases_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/releases{/id}","deployments_url":"https://api.github.com/repos/dmcaulay/thriftrw-go/deployments","created_at":"2017-02-10T00:47:04Z","updated_at":"2017-02-10T00:47:06Z","pushed_at":"2017-02-10T06:01:40Z","git_url":"git://github.com/dmcaulay/thriftrw-go.git","ssh_url":"git@github.com:dmcaulay/thriftrw-go.git","clone_url":"https://github.com/dmcaulay/thriftrw-go.git","svn_url":"https://github.com/dmcaulay/thriftrw-go","homepage":"","size":998,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"thriftrw:dev","ref":"dev","sha":"33e4d0018e61314d222862c8b1dd40e869a54be5","user":{"login":"thriftrw","id":16569516,"avatar_url":"https://avatars.githubusercontent.com/u/16569516?v=3","gravatar_id":"","url":"https://api.github.com/users/thriftrw","html_url":"https://github.com/thriftrw","followers_url":"https://api.github.com/users/thriftrw/followers","following_url":"https://api.github.com/users/thriftrw/following{/other_user}","gists_url":"https://api.github.com/users/thriftrw/gists{/gist_id}","starred_url":"https://api.github.com/users/thriftrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thriftrw/subscriptions","organizations_url":"https://api.github.com/users/thriftrw/orgs","repos_url":"https://api.github.com/users/thriftrw/repos","events_url":"https://api.github.com/users/thriftrw/events{/privacy}","received_events_url":"https://api.github.com/users/thriftrw/received_events","type":"Organization","site_admin":false},"repo":{"id":45574831,"name":"thriftrw-go","full_name":"thriftrw/thriftrw-go","owner":{"login":"thriftrw","id":16569516,"avatar_url":"https://avatars.githubusercontent.com/u/16569516?v=3","gravatar_id":"","url":"https://api.github.com/users/thriftrw","html_url":"https://github.com/thriftrw","followers_url":"https://api.github.com/users/thriftrw/followers","following_url":"https://api.github.com/users/thriftrw/following{/other_user}","gists_url":"https://api.github.com/users/thriftrw/gists{/gist_id}","starred_url":"https://api.github.com/users/thriftrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thriftrw/subscriptions","organizations_url":"https://api.github.com/users/thriftrw/orgs","repos_url":"https://api.github.com/users/thriftrw/repos","events_url":"https://api.github.com/users/thriftrw/events{/privacy}","received_events_url":"https://api.github.com/users/thriftrw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thriftrw/thriftrw-go","description":"A Thrift encoding code generator and library for Go","fork":false,"url":"https://api.github.com/repos/thriftrw/thriftrw-go","forks_url":"https://api.github.com/repos/thriftrw/thriftrw-go/forks","keys_url":"https://api.github.com/repos/thriftrw/thriftrw-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thriftrw/thriftrw-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thriftrw/thriftrw-go/teams","hooks_url":"https://api.github.com/repos/thriftrw/thriftrw-go/hooks","issue_events_url":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/events{/number}","events_url":"https://api.github.com/repos/thriftrw/thriftrw-go/events","assignees_url":"https://api.github.com/repos/thriftrw/thriftrw-go/assignees{/user}","branches_url":"https://api.github.com/repos/thriftrw/thriftrw-go/branches{/branch}","tags_url":"https://api.github.com/repos/thriftrw/thriftrw-go/tags","blobs_url":"https://api.github.com/repos/thriftrw/thriftrw-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thriftrw/thriftrw-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thriftrw/thriftrw-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/thriftrw/thriftrw-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thriftrw/thriftrw-go/statuses/{sha}","languages_url":"https://api.github.com/repos/thriftrw/thriftrw-go/languages","stargazers_url":"https://api.github.com/repos/thriftrw/thriftrw-go/stargazers","contributors_url":"https://api.github.com/repos/thriftrw/thriftrw-go/contributors","subscribers_url":"https://api.github.com/repos/thriftrw/thriftrw-go/subscribers","subscription_url":"https://api.github.com/repos/thriftrw/thriftrw-go/subscription","commits_url":"https://api.github.com/repos/thriftrw/thriftrw-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/thriftrw/thriftrw-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/thriftrw/thriftrw-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/thriftrw/thriftrw-go/contents/{+path}","compare_url":"https://api.github.com/repos/thriftrw/thriftrw-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thriftrw/thriftrw-go/merges","archive_url":"https://api.github.com/repos/thriftrw/thriftrw-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thriftrw/thriftrw-go/downloads","issues_url":"https://api.github.com/repos/thriftrw/thriftrw-go/issues{/number}","pulls_url":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls{/number}","milestones_url":"https://api.github.com/repos/thriftrw/thriftrw-go/milestones{/number}","notifications_url":"https://api.github.com/repos/thriftrw/thriftrw-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thriftrw/thriftrw-go/labels{/name}","releases_url":"https://api.github.com/repos/thriftrw/thriftrw-go/releases{/id}","deployments_url":"https://api.github.com/repos/thriftrw/thriftrw-go/deployments","created_at":"2015-11-04T23:43:00Z","updated_at":"2017-02-08T07:37:45Z","pushed_at":"2017-02-10T17:56:57Z","git_url":"git://github.com/thriftrw/thriftrw-go.git","ssh_url":"git@github.com:thriftrw/thriftrw-go.git","clone_url":"https://github.com/thriftrw/thriftrw-go.git","svn_url":"https://github.com/thriftrw/thriftrw-go","homepage":"","size":995,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":19,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290"},"html":{"href":"https://github.com/thriftrw/thriftrw-go/pull/290"},"issue":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/290"},"comments":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/thriftrw/thriftrw-go/statuses/f35d7a73d76e0bf202de156650f979a3325aa775"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":168,"deletions":2,"changed_files":21}}
{"actor":{"display_login":"abhinav"}}