{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/photon-ml/pulls/comments/96037145","pull_request_review_id":16613391,"id":96037145,"diff_hunk":"@@ -73,12 +73,16 @@ class LogisticRegressionModel(override val coefficients: Coefficients)\n }\n \n object LogisticRegressionModel {\n+\n   /**\n    * Create a new logistic regression model with the provided coefficients (means) and variances\n    *\n    * @param coefficients The feature coefficient means and variances for the model\n    * @return A logistic regression model\n    */\n-  def create(coefficients: Coefficients): LogisticRegressionModel =\n+  def create(coefficients: Coefficients): GeneralizedLinearModel =\n+    new LogisticRegressionModel(coefficients)\n+\n+  def apply(coefficients: Coefficients): GeneralizedLinearModel =","path":"photon-ml/src/main/scala/com/linkedin/photon/ml/supervised/classification/LogisticRegressionModel.scala","position":15,"original_position":15,"commit_id":"543df6523cedc0010f0771cacd326ad90cd99a95","original_commit_id":"543df6523cedc0010f0771cacd326ad90cd99a95","user":{"login":"ferd36","id":5238339,"avatar_url":"https://avatars.githubusercontent.com/u/5238339?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd36","html_url":"https://github.com/ferd36","followers_url":"https://api.github.com/users/ferd36/followers","following_url":"https://api.github.com/users/ferd36/following{/other_user}","gists_url":"https://api.github.com/users/ferd36/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd36/subscriptions","organizations_url":"https://api.github.com/users/ferd36/orgs","repos_url":"https://api.github.com/users/ferd36/repos","events_url":"https://api.github.com/users/ferd36/events{/privacy}","received_events_url":"https://api.github.com/users/ferd36/received_events","type":"User","site_admin":false},"body":"I would love to retire the \"create\" since \"apply\" is shorter, and apparently more Scala. ","created_at":"2017-01-13T17:38:33Z","updated_at":"2017-01-13T17:38:33Z","html_url":"https://github.com/linkedin/photon-ml/pull/209#discussion_r96037145","pull_request_url":"https://api.github.com/repos/linkedin/photon-ml/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/comments/96037145"},"html":{"href":"https://github.com/linkedin/photon-ml/pull/209#discussion_r96037145"},"pull_request":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/photon-ml/pulls/209","id":101316486,"html_url":"https://github.com/linkedin/photon-ml/pull/209","diff_url":"https://github.com/linkedin/photon-ml/pull/209.diff","patch_url":"https://github.com/linkedin/photon-ml/pull/209.patch","issue_url":"https://api.github.com/repos/linkedin/photon-ml/issues/209","number":209,"state":"open","locked":false,"title":"Tracking model type in GameModel.","user":{"login":"ferd36","id":5238339,"avatar_url":"https://avatars.githubusercontent.com/u/5238339?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd36","html_url":"https://github.com/ferd36","followers_url":"https://api.github.com/users/ferd36/followers","following_url":"https://api.github.com/users/ferd36/following{/other_user}","gists_url":"https://api.github.com/users/ferd36/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd36/subscriptions","organizations_url":"https://api.github.com/users/ferd36/orgs","repos_url":"https://api.github.com/users/ferd36/repos","events_url":"https://api.github.com/users/ferd36/events{/privacy}","received_events_url":"https://api.github.com/users/ferd36/received_events","type":"User","site_admin":false},"body":"This is required for Game clients, such as model converters (that convert Game model format to another system's model format). ","created_at":"2017-01-12T18:42:20Z","updated_at":"2017-01-13T17:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec70987b1279964aad610a3ef521061355600c32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/photon-ml/pulls/209/commits","review_comments_url":"https://api.github.com/repos/linkedin/photon-ml/pulls/209/comments","review_comment_url":"https://api.github.com/repos/linkedin/photon-ml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/photon-ml/issues/209/comments","statuses_url":"https://api.github.com/repos/linkedin/photon-ml/statuses/543df6523cedc0010f0771cacd326ad90cd99a95","head":{"label":"ferd36:master","ref":"master","sha":"543df6523cedc0010f0771cacd326ad90cd99a95","user":{"login":"ferd36","id":5238339,"avatar_url":"https://avatars.githubusercontent.com/u/5238339?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd36","html_url":"https://github.com/ferd36","followers_url":"https://api.github.com/users/ferd36/followers","following_url":"https://api.github.com/users/ferd36/following{/other_user}","gists_url":"https://api.github.com/users/ferd36/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd36/subscriptions","organizations_url":"https://api.github.com/users/ferd36/orgs","repos_url":"https://api.github.com/users/ferd36/repos","events_url":"https://api.github.com/users/ferd36/events{/privacy}","received_events_url":"https://api.github.com/users/ferd36/received_events","type":"User","site_admin":false},"repo":{"id":71810686,"name":"photon-ml","full_name":"ferd36/photon-ml","owner":{"login":"ferd36","id":5238339,"avatar_url":"https://avatars.githubusercontent.com/u/5238339?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd36","html_url":"https://github.com/ferd36","followers_url":"https://api.github.com/users/ferd36/followers","following_url":"https://api.github.com/users/ferd36/following{/other_user}","gists_url":"https://api.github.com/users/ferd36/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd36/subscriptions","organizations_url":"https://api.github.com/users/ferd36/orgs","repos_url":"https://api.github.com/users/ferd36/repos","events_url":"https://api.github.com/users/ferd36/events{/privacy}","received_events_url":"https://api.github.com/users/ferd36/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferd36/photon-ml","description":"A scalable machine learning library on Apache Spark","fork":true,"url":"https://api.github.com/repos/ferd36/photon-ml","forks_url":"https://api.github.com/repos/ferd36/photon-ml/forks","keys_url":"https://api.github.com/repos/ferd36/photon-ml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferd36/photon-ml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferd36/photon-ml/teams","hooks_url":"https://api.github.com/repos/ferd36/photon-ml/hooks","issue_events_url":"https://api.github.com/repos/ferd36/photon-ml/issues/events{/number}","events_url":"https://api.github.com/repos/ferd36/photon-ml/events","assignees_url":"https://api.github.com/repos/ferd36/photon-ml/assignees{/user}","branches_url":"https://api.github.com/repos/ferd36/photon-ml/branches{/branch}","tags_url":"https://api.github.com/repos/ferd36/photon-ml/tags","blobs_url":"https://api.github.com/repos/ferd36/photon-ml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferd36/photon-ml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferd36/photon-ml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferd36/photon-ml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferd36/photon-ml/statuses/{sha}","languages_url":"https://api.github.com/repos/ferd36/photon-ml/languages","stargazers_url":"https://api.github.com/repos/ferd36/photon-ml/stargazers","contributors_url":"https://api.github.com/repos/ferd36/photon-ml/contributors","subscribers_url":"https://api.github.com/repos/ferd36/photon-ml/subscribers","subscription_url":"https://api.github.com/repos/ferd36/photon-ml/subscription","commits_url":"https://api.github.com/repos/ferd36/photon-ml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferd36/photon-ml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferd36/photon-ml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferd36/photon-ml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferd36/photon-ml/contents/{+path}","compare_url":"https://api.github.com/repos/ferd36/photon-ml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferd36/photon-ml/merges","archive_url":"https://api.github.com/repos/ferd36/photon-ml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferd36/photon-ml/downloads","issues_url":"https://api.github.com/repos/ferd36/photon-ml/issues{/number}","pulls_url":"https://api.github.com/repos/ferd36/photon-ml/pulls{/number}","milestones_url":"https://api.github.com/repos/ferd36/photon-ml/milestones{/number}","notifications_url":"https://api.github.com/repos/ferd36/photon-ml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferd36/photon-ml/labels{/name}","releases_url":"https://api.github.com/repos/ferd36/photon-ml/releases{/id}","deployments_url":"https://api.github.com/repos/ferd36/photon-ml/deployments","created_at":"2016-10-24T16:49:48Z","updated_at":"2016-10-24T16:49:50Z","pushed_at":"2017-01-12T22:46:39Z","git_url":"git://github.com/ferd36/photon-ml.git","ssh_url":"git@github.com:ferd36/photon-ml.git","clone_url":"https://github.com/ferd36/photon-ml.git","svn_url":"https://github.com/ferd36/photon-ml","homepage":"","size":47267,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"29eac7a6870a57362342f9f3bfee52939858f3e3","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":50964104,"name":"photon-ml","full_name":"linkedin/photon-ml","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/photon-ml","description":"A scalable machine learning library on Apache Spark","fork":false,"url":"https://api.github.com/repos/linkedin/photon-ml","forks_url":"https://api.github.com/repos/linkedin/photon-ml/forks","keys_url":"https://api.github.com/repos/linkedin/photon-ml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/photon-ml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/photon-ml/teams","hooks_url":"https://api.github.com/repos/linkedin/photon-ml/hooks","issue_events_url":"https://api.github.com/repos/linkedin/photon-ml/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/photon-ml/events","assignees_url":"https://api.github.com/repos/linkedin/photon-ml/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/photon-ml/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/photon-ml/tags","blobs_url":"https://api.github.com/repos/linkedin/photon-ml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/photon-ml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/photon-ml/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/photon-ml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/photon-ml/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/photon-ml/languages","stargazers_url":"https://api.github.com/repos/linkedin/photon-ml/stargazers","contributors_url":"https://api.github.com/repos/linkedin/photon-ml/contributors","subscribers_url":"https://api.github.com/repos/linkedin/photon-ml/subscribers","subscription_url":"https://api.github.com/repos/linkedin/photon-ml/subscription","commits_url":"https://api.github.com/repos/linkedin/photon-ml/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/photon-ml/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/photon-ml/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/photon-ml/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/photon-ml/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/photon-ml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/photon-ml/merges","archive_url":"https://api.github.com/repos/linkedin/photon-ml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/photon-ml/downloads","issues_url":"https://api.github.com/repos/linkedin/photon-ml/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/photon-ml/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/photon-ml/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/photon-ml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/photon-ml/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/photon-ml/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/photon-ml/deployments","created_at":"2016-02-03T01:12:07Z","updated_at":"2017-01-12T13:43:48Z","pushed_at":"2017-01-12T22:46:40Z","git_url":"git://github.com/linkedin/photon-ml.git","ssh_url":"git@github.com:linkedin/photon-ml.git","clone_url":"https://github.com/linkedin/photon-ml.git","svn_url":"https://github.com/linkedin/photon-ml","homepage":"","size":47303,"stargazers_count":384,"watchers_count":384,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":32,"forks":87,"open_issues":32,"watchers":384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/209"},"html":{"href":"https://github.com/linkedin/photon-ml/pull/209"},"issue":{"href":"https://api.github.com/repos/linkedin/photon-ml/issues/209"},"comments":{"href":"https://api.github.com/repos/linkedin/photon-ml/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/photon-ml/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/photon-ml/statuses/543df6523cedc0010f0771cacd326ad90cd99a95"}}}}
{"actor":{"display_login":"ferd36"}}