{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/103488148","pull_request_review_id":24275902,"id":103488148,"diff_hunk":"@@ -691,9 +657,7 @@ void QgsImageOperation::GaussianBlurOperation::operator()( QgsImageOperation::Im\n       sourceRef = sourceFirstLine;\n       destRef = reinterpret_cast< QRgb * >( outputLineRef );\n       for ( int x = 0; x < width; ++x, ++destRef, sourceRef += 4 )\n-      {\n-        *destRef = gaussianBlurVertical( y, sourceRef, sourceBpl, height );\n-      }\n+        * destRef = gaussianBlurVertical( y, sourceRef, sourceBpl, height );","path":"src/core/effects/qgsimageoperation.cpp","position":366,"original_position":146,"commit_id":"6d7a5945057dbef8d07e728b1b0863003a8a3980","original_commit_id":"6d7a5945057dbef8d07e728b1b0863003a8a3980","user":{"login":"m-kuhn","id":588407,"avatar_url":"https://avatars.githubusercontent.com/u/588407?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"body":"Hmmm... the asterisk is used to dereference in this situation, according to my preference it should be variable-aligned here.\r\n\r\nNot sure if astyle is able to properly disambiguate.","created_at":"2017-02-28T16:03:39Z","updated_at":"2017-02-28T16:03:39Z","html_url":"https://github.com/qgis/QGIS/pull/4202#discussion_r103488148","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/4202","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/103488148"},"html":{"href":"https://github.com/qgis/QGIS/pull/4202#discussion_r103488148"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4202"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/4202","id":108336084,"html_url":"https://github.com/qgis/QGIS/pull/4202","diff_url":"https://github.com/qgis/QGIS/pull/4202.diff","patch_url":"https://github.com/qgis/QGIS/pull/4202.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/4202","number":4202,"state":"open","locked":false,"title":"Update astyle to 2.06","user":{"login":"3nids","id":127259,"avatar_url":"https://avatars.githubusercontent.com/u/127259?v=3","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"body":"Following discussion in #3463 this updates astyle to 2.06.\r\nI gave it a run on src/core, and changes seems quite reasonable.\r\nThere is a bit of noise with all the multi-line initializer lists shifted to the left by 2.\r\n\r\nIf we agree on updating, I left some options commented and some shall be discussed (maybe afterwards)\r\n\r\n* [x] position of pointer\r\n* [x] position of reference\r\n* [x] remove brackets for one-line ifs\r\n* [x] padding of parenthesis\r\n\r\nAs Matthias pointed out this makes the beautifying compatible with c++11 syntax.\r\n\r\n","created_at":"2017-02-28T14:04:00Z","updated_at":"2017-02-28T16:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c6b09ac3aa664320efd2f83af331f91b87edc47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/4202/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/4202/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/4202/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/6d7a5945057dbef8d07e728b1b0863003a8a3980","head":{"label":"3nids:astyle","ref":"astyle","sha":"6d7a5945057dbef8d07e728b1b0863003a8a3980","user":{"login":"3nids","id":127259,"avatar_url":"https://avatars.githubusercontent.com/u/127259?v=3","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"repo":{"id":7640359,"name":"QGIS","full_name":"3nids/QGIS","owner":{"login":"3nids","id":127259,"avatar_url":"https://avatars.githubusercontent.com/u/127259?v=3","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3nids/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/3nids/QGIS","forks_url":"https://api.github.com/repos/3nids/QGIS/forks","keys_url":"https://api.github.com/repos/3nids/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3nids/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3nids/QGIS/teams","hooks_url":"https://api.github.com/repos/3nids/QGIS/hooks","issue_events_url":"https://api.github.com/repos/3nids/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/3nids/QGIS/events","assignees_url":"https://api.github.com/repos/3nids/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/3nids/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/3nids/QGIS/tags","blobs_url":"https://api.github.com/repos/3nids/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3nids/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3nids/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/3nids/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3nids/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/3nids/QGIS/languages","stargazers_url":"https://api.github.com/repos/3nids/QGIS/stargazers","contributors_url":"https://api.github.com/repos/3nids/QGIS/contributors","subscribers_url":"https://api.github.com/repos/3nids/QGIS/subscribers","subscription_url":"https://api.github.com/repos/3nids/QGIS/subscription","commits_url":"https://api.github.com/repos/3nids/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/3nids/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/3nids/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/3nids/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/3nids/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/3nids/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3nids/QGIS/merges","archive_url":"https://api.github.com/repos/3nids/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3nids/QGIS/downloads","issues_url":"https://api.github.com/repos/3nids/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/3nids/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/3nids/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/3nids/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3nids/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/3nids/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/3nids/QGIS/deployments","created_at":"2013-01-16T06:16:23Z","updated_at":"2016-09-20T08:12:39Z","pushed_at":"2017-02-28T15:19:11Z","git_url":"git://github.com/3nids/QGIS.git","ssh_url":"git@github.com:3nids/QGIS.git","clone_url":"https://github.com/3nids/QGIS.git","svn_url":"https://github.com/3nids/QGIS","homepage":"http://qgis.org","size":1124587,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"79580be502595b697925de81b7fe67a178b1ee64","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2017-02-28T07:47:41Z","pushed_at":"2017-02-28T15:36:53Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1265137,"stargazers_count":1273,"watchers_count":1273,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":989,"mirror_url":null,"open_issues_count":71,"forks":989,"open_issues":71,"watchers":1273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4202"},"html":{"href":"https://github.com/qgis/QGIS/pull/4202"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/4202"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/4202/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4202/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/4202/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/6d7a5945057dbef8d07e728b1b0863003a8a3980"}}}}
{"actor":{"display_login":"m-kuhn"}}