{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/150614977","pull_request_review_id":76191022,"id":150614977,"diff_hunk":"@@ -137,12 +137,13 @@ class StorageSystemModule(OneViewModuleBase):\n                                    \"(credentials.ip_hostname if API version lower than 500 ).\"\n     MSG_CREDENTIALS_MANDATORY = \"The attribute 'credentials' is mandatory for Storage System creation.\"\n \n+    argument_spec = dict(\n+        state=dict(type='str', default='present', choices=['present', 'absent']),","path":"lib/ansible/modules/remote_management/oneview/oneview_storage_system.py","position":null,"original_position":5,"commit_id":"c72c8c15d2610e042e7700f0f1f8717f8998b1ed","original_commit_id":"c72c8c15d2610e042e7700f0f1f8717f8998b1ed","user":{"login":"fgbulsoni","id":6110785,"avatar_url":"https://avatars2.githubusercontent.com/u/6110785?v=4","gravatar_id":"","url":"https://api.github.com/users/fgbulsoni","html_url":"https://github.com/fgbulsoni","followers_url":"https://api.github.com/users/fgbulsoni/followers","following_url":"https://api.github.com/users/fgbulsoni/following{/other_user}","gists_url":"https://api.github.com/users/fgbulsoni/gists{/gist_id}","starred_url":"https://api.github.com/users/fgbulsoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgbulsoni/subscriptions","organizations_url":"https://api.github.com/users/fgbulsoni/orgs","repos_url":"https://api.github.com/users/fgbulsoni/repos","events_url":"https://api.github.com/users/fgbulsoni/events{/privacy}","received_events_url":"https://api.github.com/users/fgbulsoni/received_events","type":"User","site_admin":false},"body":"choices=['absent', 'present']","created_at":"2017-11-13T17:51:27Z","updated_at":"2017-11-13T17:51:27Z","html_url":"https://github.com/ansible/ansible/pull/32801#discussion_r150614977","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/32801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/150614977"},"html":{"href":"https://github.com/ansible/ansible/pull/32801#discussion_r150614977"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/32801"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/32801","id":151958514,"html_url":"https://github.com/ansible/ansible/pull/32801","diff_url":"https://github.com/ansible/ansible/pull/32801.diff","patch_url":"https://github.com/ansible/ansible/pull/32801.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/32801","number":32801,"state":"open","locked":false,"title":"StorageSystemModule for HPE OneView","user":{"login":"ricardogpsf","id":1815812,"avatar_url":"https://avatars2.githubusercontent.com/u/1815812?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardogpsf","html_url":"https://github.com/ricardogpsf","followers_url":"https://api.github.com/users/ricardogpsf/followers","following_url":"https://api.github.com/users/ricardogpsf/following{/other_user}","gists_url":"https://api.github.com/users/ricardogpsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardogpsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardogpsf/subscriptions","organizations_url":"https://api.github.com/users/ricardogpsf/orgs","repos_url":"https://api.github.com/users/ricardogpsf/repos","events_url":"https://api.github.com/users/ricardogpsf/events{/privacy}","received_events_url":"https://api.github.com/users/ricardogpsf/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nAdded new oneview_storage_system module for managing [HPE OneView Storage Systems](http://h17007.www1.hpe.com/docs/enterprise/servers/oneview3.1/cic-api/en/api-docs/current/index.html#rest/storage-systems) resource and unit tests.\r\n\r\nRelated issue for more information: [HPE OneView support](https://github.com/ansible/ansible/issues/28354)\r\n\r\n##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\n`oneview_storage_system`\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible --version\r\nansible 2.5.0\r\n  config file = None\r\n  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible-2.5.0-py2.7.egg/ansible\r\n  executable location = /usr/local/bin/ansible\r\n  python version = 2.7.14 (default, Oct 10 2017, 02:49:49) [GCC 4.9.2]\r\n```\r\n\r\n##### ADDITIONAL INFORMATION\r\nNote: to run the example you need an Oneview Appliance.\r\nExample of usage:\r\n```yaml\r\n- name: Add a Storage System with one managed pool (before API500)\r\n  oneview_storage_system:\r\n    hostname: 172.16.101.48\r\n    username: administrator\r\n    password: my_password\r\n    api_version: 300\r\n    state: present\r\n    data:\r\n        credentials:\r\n            ip_hostname: 172.18.11.12\r\n            username: username\r\n            password: password\r\n        managedDomain: TestDomain\r\n        managedPools:\r\n          - domain: TestDomain\r\n            type: StoragePoolV2\r\n            name: CPG_FC-AO\r\n            deviceType: FC\r\n\r\n  no_log: true\r\n  delegate_to: localhost\r\n\r\n- name: Add a StoreServ Storage System with one managed pool (API500 onwards)\r\n  oneview_storage_system:\r\n    hostname: 172.16.101.48\r\n    username: administrator\r\n    password: my_password\r\n    api_version: 500\r\n    state: present\r\n    data:\r\n      credentials:\r\n          username: username\r\n          password: password\r\n      hostname: 172.18.11.12\r\n      family: StoreServ\r\n      deviceSpecificAttributes:\r\n          managedDomain: TestDomain\r\n          managedPools:\r\n              - domain: TestDomain\r\n                name: CPG_FC-AO\r\n                deviceType: FC\r\n\r\n  no_log: true\r\n  delegate_to: localhost\r\n\r\n- name: Remove the storage system by its IP (before API500)\r\n  oneview_storage_system:\r\n    hostname: 172.16.101.48\r\n    username: administrator\r\n    password: my_password\r\n    api_version: 300\r\n    state: absent\r\n    data:\r\n        credentials:\r\n            ip_hostname: 172.18.11.12\r\n\r\n  no_log: true\r\n  delegate_to: localhost\r\n\r\n- name: Remove the storage system by its IP (API500 onwards)\r\n  oneview_storage_system:\r\n    hostname: 172.16.101.48\r\n    username: administrator\r\n    password: my_password\r\n    api_version: 500\r\n    state: absent\r\n    data:\r\n        credentials:\r\n            hostname: 172.18.11.12\r\n\r\n  no_log: true\r\n  delegate_to: localhost\r\n```\r\n","created_at":"2017-11-10T17:08:56Z","updated_at":"2017-11-13T17:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb999d2739fb0d306f786ccc0d7929d8d05cb0f0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/32801/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/32801/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/32801/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/c72c8c15d2610e042e7700f0f1f8717f8998b1ed","head":{"label":"ricardogpsf:hpe-oneview/storage-system-module","ref":"hpe-oneview/storage-system-module","sha":"c72c8c15d2610e042e7700f0f1f8717f8998b1ed","user":{"login":"ricardogpsf","id":1815812,"avatar_url":"https://avatars2.githubusercontent.com/u/1815812?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardogpsf","html_url":"https://github.com/ricardogpsf","followers_url":"https://api.github.com/users/ricardogpsf/followers","following_url":"https://api.github.com/users/ricardogpsf/following{/other_user}","gists_url":"https://api.github.com/users/ricardogpsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardogpsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardogpsf/subscriptions","organizations_url":"https://api.github.com/users/ricardogpsf/orgs","repos_url":"https://api.github.com/users/ricardogpsf/repos","events_url":"https://api.github.com/users/ricardogpsf/events{/privacy}","received_events_url":"https://api.github.com/users/ricardogpsf/received_events","type":"User","site_admin":false},"repo":{"id":108267750,"name":"ansible","full_name":"ricardogpsf/ansible","owner":{"login":"ricardogpsf","id":1815812,"avatar_url":"https://avatars2.githubusercontent.com/u/1815812?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardogpsf","html_url":"https://github.com/ricardogpsf","followers_url":"https://api.github.com/users/ricardogpsf/followers","following_url":"https://api.github.com/users/ricardogpsf/following{/other_user}","gists_url":"https://api.github.com/users/ricardogpsf/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardogpsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardogpsf/subscriptions","organizations_url":"https://api.github.com/users/ricardogpsf/orgs","repos_url":"https://api.github.com/users/ricardogpsf/repos","events_url":"https://api.github.com/users/ricardogpsf/events{/privacy}","received_events_url":"https://api.github.com/users/ricardogpsf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricardogpsf/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/ricardogpsf/ansible","forks_url":"https://api.github.com/repos/ricardogpsf/ansible/forks","keys_url":"https://api.github.com/repos/ricardogpsf/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricardogpsf/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricardogpsf/ansible/teams","hooks_url":"https://api.github.com/repos/ricardogpsf/ansible/hooks","issue_events_url":"https://api.github.com/repos/ricardogpsf/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ricardogpsf/ansible/events","assignees_url":"https://api.github.com/repos/ricardogpsf/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ricardogpsf/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ricardogpsf/ansible/tags","blobs_url":"https://api.github.com/repos/ricardogpsf/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricardogpsf/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricardogpsf/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricardogpsf/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricardogpsf/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ricardogpsf/ansible/languages","stargazers_url":"https://api.github.com/repos/ricardogpsf/ansible/stargazers","contributors_url":"https://api.github.com/repos/ricardogpsf/ansible/contributors","subscribers_url":"https://api.github.com/repos/ricardogpsf/ansible/subscribers","subscription_url":"https://api.github.com/repos/ricardogpsf/ansible/subscription","commits_url":"https://api.github.com/repos/ricardogpsf/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricardogpsf/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricardogpsf/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricardogpsf/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricardogpsf/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ricardogpsf/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricardogpsf/ansible/merges","archive_url":"https://api.github.com/repos/ricardogpsf/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricardogpsf/ansible/downloads","issues_url":"https://api.github.com/repos/ricardogpsf/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ricardogpsf/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ricardogpsf/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ricardogpsf/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricardogpsf/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ricardogpsf/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ricardogpsf/ansible/deployments","created_at":"2017-10-25T12:36:05Z","updated_at":"2017-11-08T13:06:01Z","pushed_at":"2017-11-13T17:45:29Z","git_url":"git://github.com/ricardogpsf/ansible.git","ssh_url":"git@github.com:ricardogpsf/ansible.git","clone_url":"https://github.com/ricardogpsf/ansible.git","svn_url":"https://github.com/ricardogpsf/ansible","homepage":"https://www.ansible.com/","size":90038,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"b0e7c71716a3ea4434c139530fbbfcc73489fc16","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-11-13T17:25:41Z","pushed_at":"2017-11-13T17:49:55Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":100122,"stargazers_count":26645,"watchers_count":26645,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9461,"mirror_url":null,"archived":false,"open_issues_count":4694,"forks":9461,"open_issues":4694,"watchers":26645,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/32801"},"html":{"href":"https://github.com/ansible/ansible/pull/32801"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/32801"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/32801/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/32801/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/32801/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/c72c8c15d2610e042e7700f0f1f8717f8998b1ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"fgbulsoni"}}