{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/email-alert-service/issues/80","repository_url":"https://api.github.com/repos/alphagov/email-alert-service","labels_url":"https://api.github.com/repos/alphagov/email-alert-service/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/email-alert-service/issues/80/comments","events_url":"https://api.github.com/repos/alphagov/email-alert-service/issues/80/events","html_url":"https://github.com/alphagov/email-alert-service/pull/80","id":258896718,"number":80,"title":"Allow rabbitmq config to be passed in as env var","user":{"login":"surminus","id":5610276,"avatar_url":"https://avatars0.githubusercontent.com/u/5610276?v=4","gravatar_id":"","url":"https://api.github.com/users/surminus","html_url":"https://github.com/surminus","followers_url":"https://api.github.com/users/surminus/followers","following_url":"https://api.github.com/users/surminus/following{/other_user}","gists_url":"https://api.github.com/users/surminus/gists{/gist_id}","starred_url":"https://api.github.com/users/surminus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surminus/subscriptions","organizations_url":"https://api.github.com/users/surminus/orgs","repos_url":"https://api.github.com/users/surminus/repos","events_url":"https://api.github.com/users/surminus/events{/privacy}","received_events_url":"https://api.github.com/users/surminus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-19T17:10:53Z","updated_at":"2017-09-20T07:44:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alphagov/email-alert-service/pulls/80","html_url":"https://github.com/alphagov/email-alert-service/pull/80","diff_url":"https://github.com/alphagov/email-alert-service/pull/80.diff","patch_url":"https://github.com/alphagov/email-alert-service/pull/80.patch"},"body":"The rabbitmq hostnames are hardcoded in our deployment scripts, and this means this application won't be able to work properly with rabbitmq when running in Amazon (where we use different hostnames).\r\n\r\nAllow the config file to be read in as ERB so we can set a conditional based upon environment variables.\r\n\r\nhttps://trello.com/c/fenlgsMp/745-make-icinga-in-aws-green"},"comment":{"url":"https://api.github.com/repos/alphagov/email-alert-service/issues/comments/330772073","html_url":"https://github.com/alphagov/email-alert-service/pull/80#issuecomment-330772073","issue_url":"https://api.github.com/repos/alphagov/email-alert-service/issues/80","id":330772073,"user":{"login":"dwhenry","id":63736,"avatar_url":"https://avatars3.githubusercontent.com/u/63736?v=4","gravatar_id":"","url":"https://api.github.com/users/dwhenry","html_url":"https://github.com/dwhenry","followers_url":"https://api.github.com/users/dwhenry/followers","following_url":"https://api.github.com/users/dwhenry/following{/other_user}","gists_url":"https://api.github.com/users/dwhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhenry/subscriptions","organizations_url":"https://api.github.com/users/dwhenry/orgs","repos_url":"https://api.github.com/users/dwhenry/repos","events_url":"https://api.github.com/users/dwhenry/events{/privacy}","received_events_url":"https://api.github.com/users/dwhenry/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T07:44:09Z","updated_at":"2017-09-20T07:44:09Z","author_association":"CONTRIBUTOR","body":"I would have expected this PR to include the change to rabbit.yml file to use the environment variables even though they are not set anywhere yet."}}
{"actor":{"display_login":"dwhenry"}}