{"action":"created","comment":{"url":"https://api.github.com/repos/qgrid/ng/pulls/comments/107546546","pull_request_review_id":28525832,"id":107546546,"diff_hunk":"@@ -1,22 +1,147 @@\n+class Dom {\n+\tcolumn() {\n+\t\treturn {cells: []};\n+\t}\n+\n+\trow() {\n+\t\treturn {cells: []};\n+\t}\n+\n+\tcell() {\n+\t\treturn null;\n+\t}\n+}\n+class TableDom extends Dom {\n+\tconstructor(element) {\n+\t\tsuper();\n+\t\tthis.element = element;\n+\t}\n+\n+\tstatic get empty() {\n+\t\treturn new Dom();\n+\t}\n+\n+\tcolumn(index) {\n+\t\treturn new ColumnDom(this.element, index);\n+\t}\n+\n+\trow(index) {\n+\t\treturn new RowDom(this.element, index);\n+\t}\n+\n+\tcell(row, column) {\n+\t\treturn new CellDom(this.element, row, column);\n+\t}\n+}\n+class CellDom extends Dom {\n+\tconstructor(element, row, column) {\n+\t\tsuper(element);\n+\t\tthis.element = element;\n+\t\tthis.row = row;\n+\t\tthis.column = column;\n+\t}\n+\n+\tget view() {\n+\t\tconst element = this.element;","path":"src/ng/services/table.js","position":45,"original_position":45,"commit_id":"cf6e2ad2158481968dac5d169df5cbcdf4ff14c4","original_commit_id":"cf6e2ad2158481968dac5d169df5cbcdf4ff14c4","user":{"login":"klumba12","id":6254382,"avatar_url":"https://avatars3.githubusercontent.com/u/6254382?v=3","gravatar_id":"","url":"https://api.github.com/users/klumba12","html_url":"https://github.com/klumba12","followers_url":"https://api.github.com/users/klumba12/followers","following_url":"https://api.github.com/users/klumba12/following{/other_user}","gists_url":"https://api.github.com/users/klumba12/gists{/gist_id}","starred_url":"https://api.github.com/users/klumba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klumba12/subscriptions","organizations_url":"https://api.github.com/users/klumba12/orgs","repos_url":"https://api.github.com/users/klumba12/repos","events_url":"https://api.github.com/users/klumba12/events{/privacy}","received_events_url":"https://api.github.com/users/klumba12/received_events","type":"User","site_admin":false},"body":"why not return just element?","created_at":"2017-03-22T22:12:39Z","updated_at":"2017-03-22T22:14:14Z","html_url":"https://github.com/qgrid/ng/pull/177#discussion_r107546546","pull_request_url":"https://api.github.com/repos/qgrid/ng/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/qgrid/ng/pulls/comments/107546546"},"html":{"href":"https://github.com/qgrid/ng/pull/177#discussion_r107546546"},"pull_request":{"href":"https://api.github.com/repos/qgrid/ng/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/qgrid/ng/pulls/177","id":111541294,"html_url":"https://github.com/qgrid/ng/pull/177","diff_url":"https://github.com/qgrid/ng/pull/177.diff","patch_url":"https://github.com/qgrid/ng/pull/177.patch","issue_url":"https://api.github.com/repos/qgrid/ng/issues/177","number":177,"state":"open","locked":false,"title":"Table","user":{"login":"etokareva","id":9286878,"avatar_url":"https://avatars1.githubusercontent.com/u/9286878?v=3","gravatar_id":"","url":"https://api.github.com/users/etokareva","html_url":"https://github.com/etokareva","followers_url":"https://api.github.com/users/etokareva/followers","following_url":"https://api.github.com/users/etokareva/following{/other_user}","gists_url":"https://api.github.com/users/etokareva/gists{/gist_id}","starred_url":"https://api.github.com/users/etokareva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etokareva/subscriptions","organizations_url":"https://api.github.com/users/etokareva/orgs","repos_url":"https://api.github.com/users/etokareva/repos","events_url":"https://api.github.com/users/etokareva/events{/privacy}","received_events_url":"https://api.github.com/users/etokareva/received_events","type":"User","site_admin":false},"body":"replace of markup (except highlight.view)","created_at":"2017-03-20T12:26:37Z","updated_at":"2017-03-22T22:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed2e9b5571aa2bcb13cf1020adfa48f37e5a501c","assignee":{"login":"etokareva","id":9286878,"avatar_url":"https://avatars1.githubusercontent.com/u/9286878?v=3","gravatar_id":"","url":"https://api.github.com/users/etokareva","html_url":"https://github.com/etokareva","followers_url":"https://api.github.com/users/etokareva/followers","following_url":"https://api.github.com/users/etokareva/following{/other_user}","gists_url":"https://api.github.com/users/etokareva/gists{/gist_id}","starred_url":"https://api.github.com/users/etokareva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etokareva/subscriptions","organizations_url":"https://api.github.com/users/etokareva/orgs","repos_url":"https://api.github.com/users/etokareva/repos","events_url":"https://api.github.com/users/etokareva/events{/privacy}","received_events_url":"https://api.github.com/users/etokareva/received_events","type":"User","site_admin":false},"assignees":[{"login":"etokareva","id":9286878,"avatar_url":"https://avatars1.githubusercontent.com/u/9286878?v=3","gravatar_id":"","url":"https://api.github.com/users/etokareva","html_url":"https://github.com/etokareva","followers_url":"https://api.github.com/users/etokareva/followers","following_url":"https://api.github.com/users/etokareva/following{/other_user}","gists_url":"https://api.github.com/users/etokareva/gists{/gist_id}","starred_url":"https://api.github.com/users/etokareva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etokareva/subscriptions","organizations_url":"https://api.github.com/users/etokareva/orgs","repos_url":"https://api.github.com/users/etokareva/repos","events_url":"https://api.github.com/users/etokareva/events{/privacy}","received_events_url":"https://api.github.com/users/etokareva/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qgrid/ng/pulls/177/commits","review_comments_url":"https://api.github.com/repos/qgrid/ng/pulls/177/comments","review_comment_url":"https://api.github.com/repos/qgrid/ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgrid/ng/issues/177/comments","statuses_url":"https://api.github.com/repos/qgrid/ng/statuses/cf6e2ad2158481968dac5d169df5cbcdf4ff14c4","head":{"label":"qgrid:table","ref":"table","sha":"cf6e2ad2158481968dac5d169df5cbcdf4ff14c4","user":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"repo":{"id":77054728,"name":"ng","full_name":"qgrid/ng","owner":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qgrid/ng","description":"Angular grid","fork":false,"url":"https://api.github.com/repos/qgrid/ng","forks_url":"https://api.github.com/repos/qgrid/ng/forks","keys_url":"https://api.github.com/repos/qgrid/ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgrid/ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgrid/ng/teams","hooks_url":"https://api.github.com/repos/qgrid/ng/hooks","issue_events_url":"https://api.github.com/repos/qgrid/ng/issues/events{/number}","events_url":"https://api.github.com/repos/qgrid/ng/events","assignees_url":"https://api.github.com/repos/qgrid/ng/assignees{/user}","branches_url":"https://api.github.com/repos/qgrid/ng/branches{/branch}","tags_url":"https://api.github.com/repos/qgrid/ng/tags","blobs_url":"https://api.github.com/repos/qgrid/ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgrid/ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgrid/ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgrid/ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgrid/ng/statuses/{sha}","languages_url":"https://api.github.com/repos/qgrid/ng/languages","stargazers_url":"https://api.github.com/repos/qgrid/ng/stargazers","contributors_url":"https://api.github.com/repos/qgrid/ng/contributors","subscribers_url":"https://api.github.com/repos/qgrid/ng/subscribers","subscription_url":"https://api.github.com/repos/qgrid/ng/subscription","commits_url":"https://api.github.com/repos/qgrid/ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgrid/ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgrid/ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgrid/ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgrid/ng/contents/{+path}","compare_url":"https://api.github.com/repos/qgrid/ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgrid/ng/merges","archive_url":"https://api.github.com/repos/qgrid/ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgrid/ng/downloads","issues_url":"https://api.github.com/repos/qgrid/ng/issues{/number}","pulls_url":"https://api.github.com/repos/qgrid/ng/pulls{/number}","milestones_url":"https://api.github.com/repos/qgrid/ng/milestones{/number}","notifications_url":"https://api.github.com/repos/qgrid/ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgrid/ng/labels{/name}","releases_url":"https://api.github.com/repos/qgrid/ng/releases{/id}","deployments_url":"https://api.github.com/repos/qgrid/ng/deployments","created_at":"2016-12-21T13:39:53Z","updated_at":"2017-02-27T13:17:16Z","pushed_at":"2017-03-22T19:49:00Z","git_url":"git://github.com/qgrid/ng.git","ssh_url":"git@github.com:qgrid/ng.git","clone_url":"https://github.com/qgrid/ng.git","svn_url":"https://github.com/qgrid/ng","homepage":null,"size":17183,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"qgrid:master","ref":"master","sha":"3022a6dc7680159993b6210fa6e96c03991a5205","user":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"repo":{"id":77054728,"name":"ng","full_name":"qgrid/ng","owner":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qgrid/ng","description":"Angular grid","fork":false,"url":"https://api.github.com/repos/qgrid/ng","forks_url":"https://api.github.com/repos/qgrid/ng/forks","keys_url":"https://api.github.com/repos/qgrid/ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgrid/ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgrid/ng/teams","hooks_url":"https://api.github.com/repos/qgrid/ng/hooks","issue_events_url":"https://api.github.com/repos/qgrid/ng/issues/events{/number}","events_url":"https://api.github.com/repos/qgrid/ng/events","assignees_url":"https://api.github.com/repos/qgrid/ng/assignees{/user}","branches_url":"https://api.github.com/repos/qgrid/ng/branches{/branch}","tags_url":"https://api.github.com/repos/qgrid/ng/tags","blobs_url":"https://api.github.com/repos/qgrid/ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgrid/ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgrid/ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgrid/ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgrid/ng/statuses/{sha}","languages_url":"https://api.github.com/repos/qgrid/ng/languages","stargazers_url":"https://api.github.com/repos/qgrid/ng/stargazers","contributors_url":"https://api.github.com/repos/qgrid/ng/contributors","subscribers_url":"https://api.github.com/repos/qgrid/ng/subscribers","subscription_url":"https://api.github.com/repos/qgrid/ng/subscription","commits_url":"https://api.github.com/repos/qgrid/ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgrid/ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgrid/ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgrid/ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgrid/ng/contents/{+path}","compare_url":"https://api.github.com/repos/qgrid/ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgrid/ng/merges","archive_url":"https://api.github.com/repos/qgrid/ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgrid/ng/downloads","issues_url":"https://api.github.com/repos/qgrid/ng/issues{/number}","pulls_url":"https://api.github.com/repos/qgrid/ng/pulls{/number}","milestones_url":"https://api.github.com/repos/qgrid/ng/milestones{/number}","notifications_url":"https://api.github.com/repos/qgrid/ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgrid/ng/labels{/name}","releases_url":"https://api.github.com/repos/qgrid/ng/releases{/id}","deployments_url":"https://api.github.com/repos/qgrid/ng/deployments","created_at":"2016-12-21T13:39:53Z","updated_at":"2017-02-27T13:17:16Z","pushed_at":"2017-03-22T19:49:00Z","git_url":"git://github.com/qgrid/ng.git","ssh_url":"git@github.com:qgrid/ng.git","clone_url":"https://github.com/qgrid/ng.git","svn_url":"https://github.com/qgrid/ng","homepage":null,"size":17183,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgrid/ng/pulls/177"},"html":{"href":"https://github.com/qgrid/ng/pull/177"},"issue":{"href":"https://api.github.com/repos/qgrid/ng/issues/177"},"comments":{"href":"https://api.github.com/repos/qgrid/ng/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/qgrid/ng/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/qgrid/ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgrid/ng/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/qgrid/ng/statuses/cf6e2ad2158481968dac5d169df5cbcdf4ff14c4"}}}}
{"actor":{"display_login":"klumba12"}}