{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/133358489","pull_request_review_id":56528960,"id":133358489,"diff_hunk":"@@ -993,6 +994,7 @@ const styles = StyleSheet.create({\n   braveryPanel__body__advanced__control: {\n     display: 'grid',\n     gridColumnGap: '1rem',\n+    gridTemplateColumns: 'max-content max-content',","path":"app/renderer/components/main/braveryPanel.js","position":28,"original_position":28,"commit_id":"2b9646649e1f7c0f839551eccc2403878624708b","original_commit_id":"2b9646649e1f7c0f839551eccc2403878624708b","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"body":"This prevents the strings inside the dropdowns and the labels from wrapping, without forcing the same width for each column.","created_at":"2017-08-16T04:48:51Z","updated_at":"2017-08-16T04:48:51Z","html_url":"https://github.com/brave/browser-laptop/pull/10489#discussion_r133358489","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10489","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/133358489"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10489#discussion_r133358489"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10489"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/10489","id":135750377,"html_url":"https://github.com/brave/browser-laptop/pull/10489","diff_url":"https://github.com/brave/browser-laptop/pull/10489.diff","patch_url":"https://github.com/brave/browser-laptop/pull/10489.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/10489","number":10489,"state":"open","locked":false,"title":"Polish bravery panel","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"body":"Closes #5726\r\nFollow-up to #10181\r\n\r\n- Remove fixed width; now that we have the compact bravery panel, we would not have to take the possibility into consideration that the panel would cover the UI.\r\n- Increase padding-right from 1.5em to 2em on the dropdown to add 1em space between the option and the down arrow (See `Block 3rd Party Fingerprinting` option below).\r\n- Decrease the margin-bottom of the dropdown and Increase margin between switches\r\n\r\nFrom:\r\n\r\n<img width=\"236\" alt=\"screenshot 2017-08-15 16 29 57\" src=\"https://user-images.githubusercontent.com/3362943/29306431-9c28ca28-81d8-11e7-80cf-4f1ee781bc1e.png\">\r\n\r\nTo:\r\n\r\n<img width=\"234\" alt=\"screenshot 2017-08-15 16 30 47\" src=\"https://user-images.githubusercontent.com/3362943/29306430-9c0805ea-81d8-11e7-9d7a-7299d9d63f66.png\">\r\n\r\nHere is an extreme example (which would not happen in reality, unless the font rendering is quite poor + screen resolution is very low).\r\n\r\n<img width=\"1195\" alt=\"screenshot 2017-08-15 16 43 10\" src=\"https://user-images.githubusercontent.com/3362943/29306486-ddf8799e-81d8-11e7-912e-bb3559a6c6ed.png\">\r\n\r\nThat panel can be scrolled horizontally.\r\n\r\nAuditors:\r\n\r\nTest Plan:\r\n1. Change lang setting\r\n2. Restart the browser\r\n3. Open Bravery panel on an external site\r\n4. Make sure the strings are not wrapped\r\n\r\nSubmitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n\r\n\r\nReviewer Checklist:\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2017-08-15T07:46:16Z","updated_at":"2017-08-16T04:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dce04ab0aeec6d40b3eecdef6fa6bed44dc25de9","assignee":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"assignees":[{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bradleyrichter","id":13509546,"avatar_url":"https://avatars0.githubusercontent.com/u/13509546?v=4","gravatar_id":"","url":"https://api.github.com/users/bradleyrichter","html_url":"https://github.com/bradleyrichter","followers_url":"https://api.github.com/users/bradleyrichter/followers","following_url":"https://api.github.com/users/bradleyrichter/following{/other_user}","gists_url":"https://api.github.com/users/bradleyrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleyrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleyrichter/subscriptions","organizations_url":"https://api.github.com/users/bradleyrichter/orgs","repos_url":"https://api.github.com/users/bradleyrichter/repos","events_url":"https://api.github.com/users/bradleyrichter/events{/privacy}","received_events_url":"https://api.github.com/users/bradleyrichter/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/78","html_url":"https://github.com/brave/browser-laptop/milestone/78","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/78/labels","id":2639972,"number":78,"title":"0.21.x (Nightly Channel)","description":"Open for landing","creator":{"login":"alexwykoff","id":1434040,"avatar_url":"https://avatars0.githubusercontent.com/u/1434040?v=4","gravatar_id":"","url":"https://api.github.com/users/alexwykoff","html_url":"https://github.com/alexwykoff","followers_url":"https://api.github.com/users/alexwykoff/followers","following_url":"https://api.github.com/users/alexwykoff/following{/other_user}","gists_url":"https://api.github.com/users/alexwykoff/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwykoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwykoff/subscriptions","organizations_url":"https://api.github.com/users/alexwykoff/orgs","repos_url":"https://api.github.com/users/alexwykoff/repos","events_url":"https://api.github.com/users/alexwykoff/events{/privacy}","received_events_url":"https://api.github.com/users/alexwykoff/received_events","type":"User","site_admin":false},"open_issues":85,"closed_issues":88,"state":"open","created_at":"2017-07-13T18:49:47Z","updated_at":"2017-08-16T04:33:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10489/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10489/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/10489/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/2b9646649e1f7c0f839551eccc2403878624708b","head":{"label":"luixxiul:polish-braveryPanel","ref":"polish-braveryPanel","sha":"2b9646649e1f7c0f839551eccc2403878624708b","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"repo":{"id":59339519,"name":"browser-laptop","full_name":"luixxiul/browser-laptop","owner":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luixxiul/browser-laptop","description":"Forked repo","fork":true,"url":"https://api.github.com/repos/luixxiul/browser-laptop","forks_url":"https://api.github.com/repos/luixxiul/browser-laptop/forks","keys_url":"https://api.github.com/repos/luixxiul/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luixxiul/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luixxiul/browser-laptop/teams","hooks_url":"https://api.github.com/repos/luixxiul/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/luixxiul/browser-laptop/events","assignees_url":"https://api.github.com/repos/luixxiul/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/luixxiul/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/tags","blobs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luixxiul/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/luixxiul/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/luixxiul/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/luixxiul/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscription","commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/luixxiul/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/luixxiul/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/luixxiul/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luixxiul/browser-laptop/merges","archive_url":"https://api.github.com/repos/luixxiul/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luixxiul/browser-laptop/downloads","issues_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/luixxiul/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/luixxiul/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/luixxiul/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luixxiul/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/luixxiul/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/luixxiul/browser-laptop/deployments","created_at":"2016-05-21T03:21:58Z","updated_at":"2017-05-01T10:25:07Z","pushed_at":"2017-08-15T11:02:23Z","git_url":"git://github.com/luixxiul/browser-laptop.git","ssh_url":"git@github.com:luixxiul/browser-laptop.git","clone_url":"https://github.com/luixxiul/browser-laptop.git","svn_url":"https://github.com/luixxiul/browser-laptop","homepage":"","size":48887,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"f87e29eb2504db8bb8b16834500939bd745b8d7f","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2017-08-16T00:50:35Z","pushed_at":"2017-08-16T04:36:07Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":52284,"stargazers_count":5530,"watchers_count":5530,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":664,"mirror_url":null,"open_issues_count":2417,"forks":664,"open_issues":2417,"watchers":5530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10489"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10489"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10489"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10489/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10489/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10489/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/2b9646649e1f7c0f839551eccc2403878624708b"}}}}
{"actor":{"display_login":"luixxiul"}}