{"action":"created","comment":{"url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments/135943165","pull_request_review_id":59416251,"id":135943165,"diff_hunk":"@@ -14,8 +14,7 @@\n \r\n #include <string>\r\n \r\n-struct RomSettings;\r\n-\r\n+class RomSettings;\r","path":"src/games/Roms.hpp","position":6,"original_position":6,"commit_id":"3678de88ad8323d1041891426d433742bbf7fa3d","original_commit_id":"3678de88ad8323d1041891426d433742bbf7fa3d","user":{"login":"mcmachado","id":8333434,"avatar_url":"https://avatars2.githubusercontent.com/u/8333434?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmachado","html_url":"https://github.com/mcmachado","followers_url":"https://api.github.com/users/mcmachado/followers","following_url":"https://api.github.com/users/mcmachado/following{/other_user}","gists_url":"https://api.github.com/users/mcmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmachado/subscriptions","organizations_url":"https://api.github.com/users/mcmachado/orgs","repos_url":"https://api.github.com/users/mcmachado/repos","events_url":"https://api.github.com/users/mcmachado/events{/privacy}","received_events_url":"https://api.github.com/users/mcmachado/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2017-08-30T00:10:08Z","updated_at":"2017-08-30T00:10:08Z","html_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214#discussion_r135943165","pull_request_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments/135943165"},"html":{"href":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214#discussion_r135943165"},"pull_request":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214"}},"in_reply_to_id":135728191},"pull_request":{"url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214","id":138086031,"html_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214","diff_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214.diff","patch_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214.patch","issue_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/214","number":214,"state":"open","locked":false,"title":"Main bulk of mode and difficulty switch","user":{"login":"mcmachado","id":8333434,"avatar_url":"https://avatars2.githubusercontent.com/u/8333434?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmachado","html_url":"https://github.com/mcmachado","followers_url":"https://api.github.com/users/mcmachado/followers","following_url":"https://api.github.com/users/mcmachado/following{/other_user}","gists_url":"https://api.github.com/users/mcmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmachado/subscriptions","organizations_url":"https://api.github.com/users/mcmachado/orgs","repos_url":"https://api.github.com/users/mcmachado/repos","events_url":"https://api.github.com/users/mcmachado/events{/privacy}","received_events_url":"https://api.github.com/users/mcmachado/received_events","type":"User","site_admin":false},"body":"@mgbellemare, this is the actual implementation of the mode and difficulty switch. I implemented these features in just one game for now (Freeway) to show how they should look like. As soon as we merge this PR I'll start working on the games.\r\n\r\n**Important comment:**\r\nThere is a circular dependency between RomSettings and StellaEnvironment. I know this is far from ideal. However, I couldn't really find a way to solve it. We want to define the methods in RomSettings to force all Roms to implement them. However, RomSettings do not have the required data so we can implement everything on it.\r\n\r\nMy dilemma is the following: if I put all the information inside StellaEnvironment, it is not going to be in the super class of each game. And I'd always have to pass the environment as a parameter to each function (which in fact wouldn't solve the circular dependency). I can't put everything inside RomSettings because I need to call several functions implemented in StellaEnvironment.\r\n\r\nMy opinion about this is the following: if you have a suggestion on how to do it in a more principled way, I can try to spend 1 or 2 hours doing so. However, in case a major refactoring is required, I'd suggest we merge this, finalize the PR, and create an issue to make the code nicer in the future. What do you say?","created_at":"2017-08-29T04:02:11Z","updated_at":"2017-08-30T00:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da6e315c61869142b13b794b1c3a2ab6d1d82820","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214/commits","review_comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214/comments","review_comment_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/214/comments","statuses_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/3678de88ad8323d1041891426d433742bbf7fa3d","head":{"label":"mcmachado:up-to-date-ALE","ref":"up-to-date-ALE","sha":"3678de88ad8323d1041891426d433742bbf7fa3d","user":{"login":"mcmachado","id":8333434,"avatar_url":"https://avatars2.githubusercontent.com/u/8333434?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmachado","html_url":"https://github.com/mcmachado","followers_url":"https://api.github.com/users/mcmachado/followers","following_url":"https://api.github.com/users/mcmachado/following{/other_user}","gists_url":"https://api.github.com/users/mcmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmachado/subscriptions","organizations_url":"https://api.github.com/users/mcmachado/orgs","repos_url":"https://api.github.com/users/mcmachado/repos","events_url":"https://api.github.com/users/mcmachado/events{/privacy}","received_events_url":"https://api.github.com/users/mcmachado/received_events","type":"User","site_admin":false},"repo":{"id":36095968,"name":"Arcade-Learning-Environment","full_name":"mcmachado/Arcade-Learning-Environment","owner":{"login":"mcmachado","id":8333434,"avatar_url":"https://avatars2.githubusercontent.com/u/8333434?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmachado","html_url":"https://github.com/mcmachado","followers_url":"https://api.github.com/users/mcmachado/followers","following_url":"https://api.github.com/users/mcmachado/following{/other_user}","gists_url":"https://api.github.com/users/mcmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmachado/subscriptions","organizations_url":"https://api.github.com/users/mcmachado/orgs","repos_url":"https://api.github.com/users/mcmachado/repos","events_url":"https://api.github.com/users/mcmachado/events{/privacy}","received_events_url":"https://api.github.com/users/mcmachado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcmachado/Arcade-Learning-Environment","description":"The Arcade Learning Environment (ALE) -- a platform for AI research.","fork":true,"url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment","forks_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/forks","keys_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/teams","hooks_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/hooks","issue_events_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/issues/events{/number}","events_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/events","assignees_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/assignees{/user}","branches_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/branches{/branch}","tags_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/tags","blobs_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/statuses/{sha}","languages_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/languages","stargazers_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/stargazers","contributors_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/contributors","subscribers_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/subscribers","subscription_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/subscription","commits_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/contents/{+path}","compare_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/merges","archive_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/downloads","issues_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/issues{/number}","pulls_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/pulls{/number}","milestones_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/milestones{/number}","notifications_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/labels{/name}","releases_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/releases{/id}","deployments_url":"https://api.github.com/repos/mcmachado/Arcade-Learning-Environment/deployments","created_at":"2015-05-22T21:25:44Z","updated_at":"2015-05-22T21:25:45Z","pushed_at":"2017-08-29T03:43:51Z","git_url":"git://github.com/mcmachado/Arcade-Learning-Environment.git","ssh_url":"git@github.com:mcmachado/Arcade-Learning-Environment.git","clone_url":"https://github.com/mcmachado/Arcade-Learning-Environment.git","svn_url":"https://github.com/mcmachado/Arcade-Learning-Environment","homepage":null,"size":6259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgbellemare:dev","ref":"dev","sha":"83c45d05839827d533f9d43a4b02b1149dca5062","user":{"login":"mgbellemare","id":2350286,"avatar_url":"https://avatars2.githubusercontent.com/u/2350286?v=4","gravatar_id":"","url":"https://api.github.com/users/mgbellemare","html_url":"https://github.com/mgbellemare","followers_url":"https://api.github.com/users/mgbellemare/followers","following_url":"https://api.github.com/users/mgbellemare/following{/other_user}","gists_url":"https://api.github.com/users/mgbellemare/gists{/gist_id}","starred_url":"https://api.github.com/users/mgbellemare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgbellemare/subscriptions","organizations_url":"https://api.github.com/users/mgbellemare/orgs","repos_url":"https://api.github.com/users/mgbellemare/repos","events_url":"https://api.github.com/users/mgbellemare/events{/privacy}","received_events_url":"https://api.github.com/users/mgbellemare/received_events","type":"User","site_admin":false},"repo":{"id":5816654,"name":"Arcade-Learning-Environment","full_name":"mgbellemare/Arcade-Learning-Environment","owner":{"login":"mgbellemare","id":2350286,"avatar_url":"https://avatars2.githubusercontent.com/u/2350286?v=4","gravatar_id":"","url":"https://api.github.com/users/mgbellemare","html_url":"https://github.com/mgbellemare","followers_url":"https://api.github.com/users/mgbellemare/followers","following_url":"https://api.github.com/users/mgbellemare/following{/other_user}","gists_url":"https://api.github.com/users/mgbellemare/gists{/gist_id}","starred_url":"https://api.github.com/users/mgbellemare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgbellemare/subscriptions","organizations_url":"https://api.github.com/users/mgbellemare/orgs","repos_url":"https://api.github.com/users/mgbellemare/repos","events_url":"https://api.github.com/users/mgbellemare/events{/privacy}","received_events_url":"https://api.github.com/users/mgbellemare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgbellemare/Arcade-Learning-Environment","description":"The Arcade Learning Environment (ALE) -- a platform for AI research.","fork":false,"url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment","forks_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/forks","keys_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/teams","hooks_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/hooks","issue_events_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/events{/number}","events_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/events","assignees_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/assignees{/user}","branches_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/branches{/branch}","tags_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/tags","blobs_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/{sha}","languages_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/languages","stargazers_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/stargazers","contributors_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/contributors","subscribers_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/subscribers","subscription_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/subscription","commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/contents/{+path}","compare_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/merges","archive_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/downloads","issues_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues{/number}","pulls_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls{/number}","milestones_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/milestones{/number}","notifications_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/labels{/name}","releases_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/releases{/id}","deployments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/deployments","created_at":"2012-09-15T01:42:13Z","updated_at":"2017-08-28T03:06:19Z","pushed_at":"2017-08-29T04:02:11Z","git_url":"git://github.com/mgbellemare/Arcade-Learning-Environment.git","ssh_url":"git@github.com:mgbellemare/Arcade-Learning-Environment.git","clone_url":"https://github.com/mgbellemare/Arcade-Learning-Environment.git","svn_url":"https://github.com/mgbellemare/Arcade-Learning-Environment","homepage":null,"size":5861,"stargazers_count":535,"watchers_count":535,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":34,"forks":162,"open_issues":34,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214"},"html":{"href":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/214"},"issue":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/214"},"comments":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/3678de88ad8323d1041891426d433742bbf7fa3d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mcmachado"}}