{"action":"closed","number":8499,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/8499","id":113972769,"html_url":"https://github.com/apple/swift/pull/8499","diff_url":"https://github.com/apple/swift/pull/8499.diff","patch_url":"https://github.com/apple/swift/pull/8499.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/8499","number":8499,"state":"closed","locked":false,"title":"[ome] Change the eliminator to be a module pass instead of a function pass.","user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars2.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"body":"[ome] Change the eliminator to be a module pass instead of a function pass.\r\n\r\nThis ensures that the pass manager runs the eliminator on all functions once\r\nbefore running any further passes. Otherwise, due to the way the pass manager\r\nruns functions, sometimes a function with unqualified ownership is visible from\r\na function with qualified ownership. This makes it impossible to have an\r\ninvariant that a pass either sees an entire qualified or unqualified world. This\r\nis a useful feature that I would like to keep if I can.\r\n\r\nrdar://29870610","created_at":"2017-04-03T16:38:40Z","updated_at":"2017-04-03T18:09:57Z","closed_at":"2017-04-03T18:09:57Z","merged_at":"2017-04-03T18:09:57Z","merge_commit_sha":"97db3931f2c5a21ea87ad6e71cdecbec325bff91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/8499/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/8499/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/8499/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/85688b87bba45358b94980e41dba3fd266f6d34c","head":{"label":"gottesmm:ome_module_pass","ref":"ome_module_pass","sha":"85688b87bba45358b94980e41dba3fd266f6d34c","user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars2.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"repo":{"id":47728072,"name":"swift","full_name":"gottesmm/swift","owner":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars2.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gottesmm/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/gottesmm/swift","forks_url":"https://api.github.com/repos/gottesmm/swift/forks","keys_url":"https://api.github.com/repos/gottesmm/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gottesmm/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gottesmm/swift/teams","hooks_url":"https://api.github.com/repos/gottesmm/swift/hooks","issue_events_url":"https://api.github.com/repos/gottesmm/swift/issues/events{/number}","events_url":"https://api.github.com/repos/gottesmm/swift/events","assignees_url":"https://api.github.com/repos/gottesmm/swift/assignees{/user}","branches_url":"https://api.github.com/repos/gottesmm/swift/branches{/branch}","tags_url":"https://api.github.com/repos/gottesmm/swift/tags","blobs_url":"https://api.github.com/repos/gottesmm/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gottesmm/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gottesmm/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/gottesmm/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gottesmm/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/gottesmm/swift/languages","stargazers_url":"https://api.github.com/repos/gottesmm/swift/stargazers","contributors_url":"https://api.github.com/repos/gottesmm/swift/contributors","subscribers_url":"https://api.github.com/repos/gottesmm/swift/subscribers","subscription_url":"https://api.github.com/repos/gottesmm/swift/subscription","commits_url":"https://api.github.com/repos/gottesmm/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/gottesmm/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/gottesmm/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/gottesmm/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/gottesmm/swift/contents/{+path}","compare_url":"https://api.github.com/repos/gottesmm/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gottesmm/swift/merges","archive_url":"https://api.github.com/repos/gottesmm/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gottesmm/swift/downloads","issues_url":"https://api.github.com/repos/gottesmm/swift/issues{/number}","pulls_url":"https://api.github.com/repos/gottesmm/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/gottesmm/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/gottesmm/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gottesmm/swift/labels{/name}","releases_url":"https://api.github.com/repos/gottesmm/swift/releases{/id}","deployments_url":"https://api.github.com/repos/gottesmm/swift/deployments","created_at":"2015-12-10T00:36:58Z","updated_at":"2016-12-07T08:17:10Z","pushed_at":"2017-04-03T16:43:50Z","git_url":"git://github.com/gottesmm/swift.git","ssh_url":"git@github.com:gottesmm/swift.git","clone_url":"https://github.com/gottesmm/swift.git","svn_url":"https://github.com/gottesmm/swift","homepage":"","size":174969,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d28e13a2307af4b5a46203eccf7f0ba82cfc4e7a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-04-03T17:07:34Z","pushed_at":"2017-04-03T18:09:57Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":181591,"stargazers_count":37717,"watchers_count":37717,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5582,"mirror_url":null,"open_issues_count":158,"forks":5582,"open_issues":158,"watchers":37717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/8499"},"html":{"href":"https://github.com/apple/swift/pull/8499"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/8499"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/8499/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/8499/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/8499/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/85688b87bba45358b94980e41dba3fd266f6d34c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"swift-ci","id":15467072,"avatar_url":"https://avatars3.githubusercontent.com/u/15467072?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-ci","html_url":"https://github.com/swift-ci","followers_url":"https://api.github.com/users/swift-ci/followers","following_url":"https://api.github.com/users/swift-ci/following{/other_user}","gists_url":"https://api.github.com/users/swift-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-ci/subscriptions","organizations_url":"https://api.github.com/users/swift-ci/orgs","repos_url":"https://api.github.com/users/swift-ci/repos","events_url":"https://api.github.com/users/swift-ci/events{/privacy}","received_events_url":"https://api.github.com/users/swift-ci/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":22,"changed_files":1}}
{"actor":{"display_login":"swift-ci"}}