{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/134551983","pull_request_review_id":57856671,"id":134551983,"diff_hunk":"@@ -0,0 +1,263 @@\n+#ifndef RecoSV_DeepFlavour_c_pf_features_converter_h\n+#define RecoSV_DeepFlavour_c_pf_features_converter_h\n+\n+#include \"RecoBTag/DeepFlavour/interface/deep_helpers.h\"\n+#include \"DataFormats/PatCandidates/interface/PackedCandidate.h\"\n+\n+namespace deep {\n+\n+  // conversion map from quality flags used in PV association and miniAOD one\n+  constexpr int qualityMap[8]  = {1,0,1,1,4,4,5,6};\n+\n+  enum qualityFlagsShiftsAndMasks {","path":"RecoBTag/DeepFlavour/interface/c_pf_features_converter.h","position":12,"original_position":12,"commit_id":"29fae164fd6070b0e67a33059a5fb39919cbcf31","original_commit_id":"29fae164fd6070b0e67a33059a5fb39919cbcf31","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"enum class maybe?","created_at":"2017-08-22T17:41:14Z","updated_at":"2017-08-22T17:41:14Z","html_url":"https://github.com/cms-sw/cmssw/pull/19893#discussion_r134551983","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/134551983"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/19893#discussion_r134551983"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893","id":132162315,"html_url":"https://github.com/cms-sw/cmssw/pull/19893","diff_url":"https://github.com/cms-sw/cmssw/pull/19893.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/19893.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19893","number":19893,"state":"open","locked":false,"title":"Tensorflow-based integration of new DeepFlavour tagger","user":{"login":"pablodecm","id":6707437,"avatar_url":"https://avatars1.githubusercontent.com/u/6707437?v=4","gravatar_id":"","url":"https://api.github.com/users/pablodecm","html_url":"https://github.com/pablodecm","followers_url":"https://api.github.com/users/pablodecm/followers","following_url":"https://api.github.com/users/pablodecm/following{/other_user}","gists_url":"https://api.github.com/users/pablodecm/gists{/gist_id}","starred_url":"https://api.github.com/users/pablodecm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablodecm/subscriptions","organizations_url":"https://api.github.com/users/pablodecm/orgs","repos_url":"https://api.github.com/users/pablodecm/repos","events_url":"https://api.github.com/users/pablodecm/events{/privacy}","received_events_url":"https://api.github.com/users/pablodecm/received_events","type":"User","site_admin":false},"body":"This pull request integrates the new DeepFlavour tagger, using the library CMSSW-DNN by @riga (the required part is also included) and adds it to the standard sequences. You can find an overview of the reason and design behind this PR in [this BTV WG presentation](https://indico.cern.ch/event/654562/contributions/2665694/attachments/1495582/2326838/DeepFlavour_BTV_meeting_19072017.pdf).\r\n\r\n### PAT vs reference training framework (latest version)\r\nHere are some checks of compatibility of CMSSW pat-based discriminators computed using the producers develop for this PR with the output from the training framework (DeepJet) as 2D histograms for 1000 of a ttbar RelVal sample\r\n![cmssw_pat_vs_deepjet_prob_isb](https://user-images.githubusercontent.com/6707437/29188279-f19ab9ae-7e12-11e7-8e6e-0298bcc9444b.png)\r\n![cmssw_pat_vs_deepjet_prob_isc](https://user-images.githubusercontent.com/6707437/29188294-ff863642-7e12-11e7-9c30-00c8da5ec747.png)\r\n\r\nYou can find the results for the rest of the flavour labels [here](https://www.dropbox.com/sh/vtchq59vdt7fxy7/AADeha_G0y4Ibrf3AivJyQqqa?dl=0). The agreement is of the order of float precision level.\r\n\r\n### PAT vs RECO comparisons (latest version)\r\n![cmssw_pat_vs_reco_prob_isb](https://user-images.githubusercontent.com/6707437/29188417-4a241610-7e13-11e7-93de-532746ac0bb2.png)\r\n\r\nMINIAOD/RECO comparisons (features can be potentially different and the model is trained with MINIAOD), early investigations showed worrying disagreement, especially given that this sequence will run on RECO by default. Latest changes reduce the disagreement.\r\n\r\n","created_at":"2017-07-24T22:51:28Z","updated_at":"2017-08-22T17:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"015d429e6927e55dbcb21a341c7aee4d5412256a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69","html_url":"https://github.com/cms-sw/cmssw/milestone/69","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69/labels","id":2604328,"number":69,"title":"CMSSW_9_3_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":523,"state":"open","created_at":"2017-06-26T12:15:20Z","updated_at":"2017-08-22T17:02:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19893/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/29fae164fd6070b0e67a33059a5fb39919cbcf31","head":{"label":"pablodecm:deep_flavour_tf_rebased_20_07","ref":"deep_flavour_tf_rebased_20_07","sha":"29fae164fd6070b0e67a33059a5fb39919cbcf31","user":{"login":"pablodecm","id":6707437,"avatar_url":"https://avatars1.githubusercontent.com/u/6707437?v=4","gravatar_id":"","url":"https://api.github.com/users/pablodecm","html_url":"https://github.com/pablodecm","followers_url":"https://api.github.com/users/pablodecm/followers","following_url":"https://api.github.com/users/pablodecm/following{/other_user}","gists_url":"https://api.github.com/users/pablodecm/gists{/gist_id}","starred_url":"https://api.github.com/users/pablodecm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablodecm/subscriptions","organizations_url":"https://api.github.com/users/pablodecm/orgs","repos_url":"https://api.github.com/users/pablodecm/repos","events_url":"https://api.github.com/users/pablodecm/events{/privacy}","received_events_url":"https://api.github.com/users/pablodecm/received_events","type":"User","site_admin":false},"repo":{"id":29854185,"name":"cmssw","full_name":"pablodecm/cmssw","owner":{"login":"pablodecm","id":6707437,"avatar_url":"https://avatars1.githubusercontent.com/u/6707437?v=4","gravatar_id":"","url":"https://api.github.com/users/pablodecm","html_url":"https://github.com/pablodecm","followers_url":"https://api.github.com/users/pablodecm/followers","following_url":"https://api.github.com/users/pablodecm/following{/other_user}","gists_url":"https://api.github.com/users/pablodecm/gists{/gist_id}","starred_url":"https://api.github.com/users/pablodecm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablodecm/subscriptions","organizations_url":"https://api.github.com/users/pablodecm/orgs","repos_url":"https://api.github.com/users/pablodecm/repos","events_url":"https://api.github.com/users/pablodecm/events{/privacy}","received_events_url":"https://api.github.com/users/pablodecm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pablodecm/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/pablodecm/cmssw","forks_url":"https://api.github.com/repos/pablodecm/cmssw/forks","keys_url":"https://api.github.com/repos/pablodecm/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pablodecm/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pablodecm/cmssw/teams","hooks_url":"https://api.github.com/repos/pablodecm/cmssw/hooks","issue_events_url":"https://api.github.com/repos/pablodecm/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/pablodecm/cmssw/events","assignees_url":"https://api.github.com/repos/pablodecm/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/pablodecm/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/pablodecm/cmssw/tags","blobs_url":"https://api.github.com/repos/pablodecm/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pablodecm/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pablodecm/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/pablodecm/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pablodecm/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/pablodecm/cmssw/languages","stargazers_url":"https://api.github.com/repos/pablodecm/cmssw/stargazers","contributors_url":"https://api.github.com/repos/pablodecm/cmssw/contributors","subscribers_url":"https://api.github.com/repos/pablodecm/cmssw/subscribers","subscription_url":"https://api.github.com/repos/pablodecm/cmssw/subscription","commits_url":"https://api.github.com/repos/pablodecm/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/pablodecm/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/pablodecm/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/pablodecm/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/pablodecm/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/pablodecm/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pablodecm/cmssw/merges","archive_url":"https://api.github.com/repos/pablodecm/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pablodecm/cmssw/downloads","issues_url":"https://api.github.com/repos/pablodecm/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/pablodecm/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/pablodecm/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/pablodecm/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pablodecm/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/pablodecm/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/pablodecm/cmssw/deployments","created_at":"2015-01-26T09:32:08Z","updated_at":"2015-01-26T09:35:02Z","pushed_at":"2017-08-20T10:02:40Z","git_url":"git://github.com/pablodecm/cmssw.git","ssh_url":"git@github.com:pablodecm/cmssw.git","clone_url":"https://github.com/pablodecm/cmssw.git","svn_url":"https://github.com/pablodecm/cmssw","homepage":"http://cms-sw.github.io/","size":940536,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_4_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"85d393cd2d9cfd370db35c3733d69b610018b88d","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-08-22T14:29:42Z","pushed_at":"2017-08-22T17:01:45Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":964728,"stargazers_count":435,"watchers_count":435,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2294,"mirror_url":null,"open_issues_count":438,"forks":2294,"open_issues":438,"watchers":435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/19893"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/19893"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/19893/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19893/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/29fae164fd6070b0e67a33059a5fb39919cbcf31"}}}}
{"actor":{"display_login":"slava77"}}