{"action":"created","comment":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments/104915934","pull_request_review_id":25768709,"id":104915934,"diff_hunk":"@@ -30,384 +34,213 @@ class swc_record {\n         custom\n     };\n \n+    kind type = kind::undefined; // record type","path":"src/swcio.hpp","position":22,"original_position":22,"commit_id":"091af9fde91555c36094c33bcf0645ea7757b86d","original_commit_id":"091af9fde91555c36094c33bcf0645ea7757b86d","user":{"login":"bcumming","id":384605,"avatar_url":"https://avatars3.githubusercontent.com/u/384605?v=3","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"body":"You have changed from member variables with trailing underscore to no underscore.","created_at":"2017-03-08T13:29:08Z","updated_at":"2017-03-08T13:30:11Z","html_url":"https://github.com/eth-cscs/nestmc-proto/pull/176#discussion_r104915934","pull_request_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments/104915934"},"html":{"href":"https://github.com/eth-cscs/nestmc-proto/pull/176#discussion_r104915934"},"pull_request":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176","id":109676664,"html_url":"https://github.com/eth-cscs/nestmc-proto/pull/176","diff_url":"https://github.com/eth-cscs/nestmc-proto/pull/176.diff","patch_url":"https://github.com/eth-cscs/nestmc-proto/pull/176.patch","issue_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/176","number":176,"state":"open","locked":false,"title":"Add flat morphology representation to `nestmc` lib.","user":{"login":"halfflat","id":556816,"avatar_url":"https://avatars2.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"This PR is a prelude to closer integration of the random morphology generation with the miniapp, with the first step being support for recipes that create cells from morphologies generated off-line. It aims to use `nest::mc::morphology` as the flat morphology-only representation that can be used to construct `nest::mc::cell` objects and which can exist as a target for SWC conversion and random morphology generation.\r\n\r\n* Simplify swc io implementation:\r\n   * Avoid throwing exceptions in `istream` parsing and `swc_record` constructors — only throw when explicitly checking consistency, or when parsing a full sequence of records.\r\n   * Allow direct access to record members.\r\n   * Separate parsing considerations from canonicalization (renumbering, sorting) of a sequence of records.\r\n* Move lmorpho morphology classes into src/\r\n* Add invariant check procedure for morphology.\r\n* Make cells via swc -> morphology -> cell building, rather than direct swc -> cell.\r\n* Allow option to use 'natural' discretization in morphology to determine number of compartments in built cell.\r\n* Update `test_swcio.cpp` to accommodate new API.","created_at":"2017-03-08T11:24:28Z","updated_at":"2017-03-08T13:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25ce040c3fc842800d452e75e742417e77ecfbf2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176/commits","review_comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176/comments","review_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/176/comments","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/091af9fde91555c36094c33bcf0645ea7757b86d","head":{"label":"halfflat:feature/flat-morphology-representation","ref":"feature/flat-morphology-representation","sha":"091af9fde91555c36094c33bcf0645ea7757b86d","user":{"login":"halfflat","id":556816,"avatar_url":"https://avatars2.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"repo":{"id":70549033,"name":"nestmc-proto","full_name":"halfflat/nestmc-proto","owner":{"login":"halfflat","id":556816,"avatar_url":"https://avatars2.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halfflat/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":true,"url":"https://api.github.com/repos/halfflat/nestmc-proto","forks_url":"https://api.github.com/repos/halfflat/nestmc-proto/forks","keys_url":"https://api.github.com/repos/halfflat/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halfflat/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halfflat/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/halfflat/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/halfflat/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/halfflat/nestmc-proto/events","assignees_url":"https://api.github.com/repos/halfflat/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/halfflat/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/halfflat/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/halfflat/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halfflat/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halfflat/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/halfflat/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halfflat/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/halfflat/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/halfflat/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/halfflat/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/halfflat/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/halfflat/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/halfflat/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/halfflat/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/halfflat/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/halfflat/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/halfflat/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/halfflat/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halfflat/nestmc-proto/merges","archive_url":"https://api.github.com/repos/halfflat/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halfflat/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/halfflat/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/halfflat/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/halfflat/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/halfflat/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halfflat/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/halfflat/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/halfflat/nestmc-proto/deployments","created_at":"2016-10-11T02:43:08Z","updated_at":"2016-10-11T02:43:10Z","pushed_at":"2017-03-08T11:18:52Z","git_url":"git://github.com/halfflat/nestmc-proto.git","ssh_url":"git@github.com:halfflat/nestmc-proto.git","clone_url":"https://github.com/halfflat/nestmc-proto.git","svn_url":"https://github.com/halfflat/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":2126,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eth-cscs:master","ref":"master","sha":"d9839df01899456e8b2a09dd313aa66e4b9ab2ed","user":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars3.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"name":"nestmc-proto","full_name":"eth-cscs/nestmc-proto","owner":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars3.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eth-cscs/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":false,"url":"https://api.github.com/repos/eth-cscs/nestmc-proto","forks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/forks","keys_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/events","assignees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/merges","archive_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2016-12-13T10:22:41Z","pushed_at":"2017-03-08T11:24:29Z","git_url":"git://github.com/eth-cscs/nestmc-proto.git","ssh_url":"git@github.com:eth-cscs/nestmc-proto.git","clone_url":"https://github.com/eth-cscs/nestmc-proto.git","svn_url":"https://github.com/eth-cscs/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":2005,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":58,"forks":8,"open_issues":58,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176"},"html":{"href":"https://github.com/eth-cscs/nestmc-proto/pull/176"},"issue":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/176"},"comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/091af9fde91555c36094c33bcf0645ea7757b86d"}}}}
{"actor":{"display_login":"bcumming"}}