{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/server/pulls/comments/154865502","pull_request_review_id":81090458,"id":154865502,"diff_hunk":"@@ -62,7 +62,7 @@\n \t<div>\n \t\t<label>\n \t\t\t<span><?php p($l->t('Color')) ?></span>\n-\t\t\t<input id=\"theming-color\" type=\"text\" class=\"jscolor\" maxlength=\"6\" value=\"<?php p($_['color']) ?>\" />\n+\t\t\t<input id=\"theming-color\" type=\"text\" class=\"jscolor {hash:true}\" maxlength=\"7\" value=\"<?php p($_['color']) ?>\" />","path":"apps/theming/templates/settings-admin.php","position":5,"original_position":5,"commit_id":"ab79fe0a2c87bd04faeaf99d328e3b24aa9d8468","original_commit_id":"ab79fe0a2c87bd04faeaf99d328e3b24aa9d8468","user":{"login":"juliushaertl","id":3404133,"avatar_url":"https://avatars0.githubusercontent.com/u/3404133?v=4","gravatar_id":"","url":"https://api.github.com/users/juliushaertl","html_url":"https://github.com/juliushaertl","followers_url":"https://api.github.com/users/juliushaertl/followers","following_url":"https://api.github.com/users/juliushaertl/following{/other_user}","gists_url":"https://api.github.com/users/juliushaertl/gists{/gist_id}","starred_url":"https://api.github.com/users/juliushaertl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliushaertl/subscriptions","organizations_url":"https://api.github.com/users/juliushaertl/orgs","repos_url":"https://api.github.com/users/juliushaertl/repos","events_url":"https://api.github.com/users/juliushaertl/events{/privacy}","received_events_url":"https://api.github.com/users/juliushaertl/received_events","type":"User","site_admin":false},"body":"I'd prefer using the data-jscolor attribute here.","created_at":"2017-12-05T07:38:41Z","updated_at":"2017-12-05T07:41:23Z","html_url":"https://github.com/nextcloud/server/pull/7371#discussion_r154865502","pull_request_url":"https://api.github.com/repos/nextcloud/server/pulls/7371","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments/154865502"},"html":{"href":"https://github.com/nextcloud/server/pull/7371#discussion_r154865502"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/server/pulls/7371"}}},"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/7371","id":156059904,"html_url":"https://github.com/nextcloud/server/pull/7371","diff_url":"https://github.com/nextcloud/server/pull/7371.diff","patch_url":"https://github.com/nextcloud/server/pull/7371.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/7371","number":7371,"state":"open","locked":false,"title":"Fixes #7158 - Allows adding of hex color to the theme-color","user":{"login":"Abijeet","id":1685517,"avatar_url":"https://avatars2.githubusercontent.com/u/1685517?v=4","gravatar_id":"","url":"https://api.github.com/users/Abijeet","html_url":"https://github.com/Abijeet","followers_url":"https://api.github.com/users/Abijeet/followers","following_url":"https://api.github.com/users/Abijeet/following{/other_user}","gists_url":"https://api.github.com/users/Abijeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Abijeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abijeet/subscriptions","organizations_url":"https://api.github.com/users/Abijeet/orgs","repos_url":"https://api.github.com/users/Abijeet/repos","events_url":"https://api.github.com/users/Abijeet/events{/privacy}","received_events_url":"https://api.github.com/users/Abijeet/received_events","type":"User","site_admin":false},"body":"Greetings,\r\n\r\nPlease find the merge request that fixes #7158\r\n\r\nI've done the following,\r\n\r\n1. Increased max length to allow for 7 characters.\r\n2. Checking and adding # if not already present on the `change` event.\r\n3. Added `jscolor {hash:true}` class so that user does not enter a 7 character colour by mistake.\r\n\r\n---\r\nAbijeet\r\n\r\nPS : Sorry for the extra commits, the code indentation setting on Netbeans was a little different for me.","created_at":"2017-12-03T13:11:17Z","updated_at":"2017-12-05T07:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad2d6eb8f386419f0e2fb04a370d7188542badc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/7371/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/7371/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/7371/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/ab79fe0a2c87bd04faeaf99d328e3b24aa9d8468","head":{"label":"Abijeet:master","ref":"master","sha":"ab79fe0a2c87bd04faeaf99d328e3b24aa9d8468","user":{"login":"Abijeet","id":1685517,"avatar_url":"https://avatars2.githubusercontent.com/u/1685517?v=4","gravatar_id":"","url":"https://api.github.com/users/Abijeet","html_url":"https://github.com/Abijeet","followers_url":"https://api.github.com/users/Abijeet/followers","following_url":"https://api.github.com/users/Abijeet/following{/other_user}","gists_url":"https://api.github.com/users/Abijeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Abijeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abijeet/subscriptions","organizations_url":"https://api.github.com/users/Abijeet/orgs","repos_url":"https://api.github.com/users/Abijeet/repos","events_url":"https://api.github.com/users/Abijeet/events{/privacy}","received_events_url":"https://api.github.com/users/Abijeet/received_events","type":"User","site_admin":false},"repo":{"id":112928102,"name":"server","full_name":"Abijeet/server","owner":{"login":"Abijeet","id":1685517,"avatar_url":"https://avatars2.githubusercontent.com/u/1685517?v=4","gravatar_id":"","url":"https://api.github.com/users/Abijeet","html_url":"https://github.com/Abijeet","followers_url":"https://api.github.com/users/Abijeet/followers","following_url":"https://api.github.com/users/Abijeet/following{/other_user}","gists_url":"https://api.github.com/users/Abijeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Abijeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abijeet/subscriptions","organizations_url":"https://api.github.com/users/Abijeet/orgs","repos_url":"https://api.github.com/users/Abijeet/repos","events_url":"https://api.github.com/users/Abijeet/events{/privacy}","received_events_url":"https://api.github.com/users/Abijeet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Abijeet/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":true,"url":"https://api.github.com/repos/Abijeet/server","forks_url":"https://api.github.com/repos/Abijeet/server/forks","keys_url":"https://api.github.com/repos/Abijeet/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Abijeet/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Abijeet/server/teams","hooks_url":"https://api.github.com/repos/Abijeet/server/hooks","issue_events_url":"https://api.github.com/repos/Abijeet/server/issues/events{/number}","events_url":"https://api.github.com/repos/Abijeet/server/events","assignees_url":"https://api.github.com/repos/Abijeet/server/assignees{/user}","branches_url":"https://api.github.com/repos/Abijeet/server/branches{/branch}","tags_url":"https://api.github.com/repos/Abijeet/server/tags","blobs_url":"https://api.github.com/repos/Abijeet/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Abijeet/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Abijeet/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Abijeet/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Abijeet/server/statuses/{sha}","languages_url":"https://api.github.com/repos/Abijeet/server/languages","stargazers_url":"https://api.github.com/repos/Abijeet/server/stargazers","contributors_url":"https://api.github.com/repos/Abijeet/server/contributors","subscribers_url":"https://api.github.com/repos/Abijeet/server/subscribers","subscription_url":"https://api.github.com/repos/Abijeet/server/subscription","commits_url":"https://api.github.com/repos/Abijeet/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Abijeet/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Abijeet/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Abijeet/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Abijeet/server/contents/{+path}","compare_url":"https://api.github.com/repos/Abijeet/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Abijeet/server/merges","archive_url":"https://api.github.com/repos/Abijeet/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Abijeet/server/downloads","issues_url":"https://api.github.com/repos/Abijeet/server/issues{/number}","pulls_url":"https://api.github.com/repos/Abijeet/server/pulls{/number}","milestones_url":"https://api.github.com/repos/Abijeet/server/milestones{/number}","notifications_url":"https://api.github.com/repos/Abijeet/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Abijeet/server/labels{/name}","releases_url":"https://api.github.com/repos/Abijeet/server/releases{/id}","deployments_url":"https://api.github.com/repos/Abijeet/server/deployments","created_at":"2017-12-03T12:59:08Z","updated_at":"2017-12-03T12:59:27Z","pushed_at":"2017-12-03T16:47:24Z","git_url":"git://github.com/Abijeet/server.git","ssh_url":"git@github.com:Abijeet/server.git","clone_url":"https://github.com/Abijeet/server.git","svn_url":"https://github.com/Abijeet/server","homepage":"https://nextcloud.com","size":260727,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"bd1e357eefee5ddfbb3b3567b0eae4f49bc22b75","user":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"name":"server","full_name":"nextcloud/server","owner":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2017-12-05T06:37:13Z","pushed_at":"2017-12-05T06:29:34Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":261599,"stargazers_count":3264,"watchers_count":3264,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":563,"mirror_url":null,"archived":false,"open_issues_count":1091,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":563,"open_issues":1091,"watchers":3264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/7371"},"html":{"href":"https://github.com/nextcloud/server/pull/7371"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/7371"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/7371/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/7371/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/7371/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/ab79fe0a2c87bd04faeaf99d328e3b24aa9d8468"}},"author_association":"NONE"}}
{"actor":{"display_login":"juliushaertl"}}