{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/153148057","pull_request_review_id":79110580,"id":153148057,"diff_hunk":"@@ -183,7 +183,7 @@ assert.doesNotThrow(makeBlock(a.deepEqual, a1, a2));\n \n // having an identical prototype property\n const nbRoot = {\n-  toString: function() { return `${this.first} ${this.last}`; }\n+  toString: () => { return `${this.first} ${this.last}`; }","path":"test/parallel/test-assert.js","position":14,"original_position":14,"commit_id":"79d1fbca201de498b2deb5488bd1d80610fbc103","original_commit_id":"79d1fbca201de498b2deb5488bd1d80610fbc103","user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars1.githubusercontent.com/u/10393198?v=4","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"body":"The same.","created_at":"2017-11-27T09:51:26Z","updated_at":"2017-11-27T09:51:27Z","html_url":"https://github.com/nodejs/node/pull/17345#discussion_r153148057","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/17345","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/153148057"},"html":{"href":"https://github.com/nodejs/node/pull/17345#discussion_r153148057"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/17345"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17345","id":154753872,"html_url":"https://github.com/nodejs/node/pull/17345","diff_url":"https://github.com/nodejs/node/pull/17345.diff","patch_url":"https://github.com/nodejs/node/pull/17345.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/17345","number":17345,"state":"open","locked":false,"title":"test: replace function with arrow function","user":{"login":"Leko","id":1424963,"avatar_url":"https://avatars3.githubusercontent.com/u/1424963?v=4","gravatar_id":"","url":"https://api.github.com/users/Leko","html_url":"https://github.com/Leko","followers_url":"https://api.github.com/users/Leko/followers","following_url":"https://api.github.com/users/Leko/following{/other_user}","gists_url":"https://api.github.com/users/Leko/gists{/gist_id}","starred_url":"https://api.github.com/users/Leko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leko/subscriptions","organizations_url":"https://api.github.com/users/Leko/orgs","repos_url":"https://api.github.com/users/Leko/repos","events_url":"https://api.github.com/users/Leko/events{/privacy}","received_events_url":"https://api.github.com/users/Leko/received_events","type":"User","site_admin":false},"body":"This is part of Nodefest's Code and Learn nodejs/code-and-learn#72\r\n\r\nAmong the list of [Code and Learn](https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395), I solved the unfinished task of replacing function with arrow function\r\n\r\n- test/parallel/test-assert.js\r\n- test/parallel/test-domain-top-level-error-handler-clears-stack.js\r\n- test/parallel/test-querystring.js\r\n- test/parallel/test-whatwg-url-searchparams-getall.js\r\n- test/parallel/test-writeint.js\r\n- test/parallel/test-zerolengthbufferbug.js\r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ntest","created_at":"2017-11-27T08:57:14Z","updated_at":"2017-11-27T09:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a6b6c61d540e553647970f171f04cae30c2a102","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/17345/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/17345/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17345/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/79d1fbca201de498b2deb5488bd1d80610fbc103","head":{"label":"Leko:replace_function_with_arrow_function","ref":"replace_function_with_arrow_function","sha":"79d1fbca201de498b2deb5488bd1d80610fbc103","user":{"login":"Leko","id":1424963,"avatar_url":"https://avatars3.githubusercontent.com/u/1424963?v=4","gravatar_id":"","url":"https://api.github.com/users/Leko","html_url":"https://github.com/Leko","followers_url":"https://api.github.com/users/Leko/followers","following_url":"https://api.github.com/users/Leko/following{/other_user}","gists_url":"https://api.github.com/users/Leko/gists{/gist_id}","starred_url":"https://api.github.com/users/Leko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leko/subscriptions","organizations_url":"https://api.github.com/users/Leko/orgs","repos_url":"https://api.github.com/users/Leko/repos","events_url":"https://api.github.com/users/Leko/events{/privacy}","received_events_url":"https://api.github.com/users/Leko/received_events","type":"User","site_admin":false},"repo":{"id":112064667,"name":"node","full_name":"Leko/node","owner":{"login":"Leko","id":1424963,"avatar_url":"https://avatars3.githubusercontent.com/u/1424963?v=4","gravatar_id":"","url":"https://api.github.com/users/Leko","html_url":"https://github.com/Leko","followers_url":"https://api.github.com/users/Leko/followers","following_url":"https://api.github.com/users/Leko/following{/other_user}","gists_url":"https://api.github.com/users/Leko/gists{/gist_id}","starred_url":"https://api.github.com/users/Leko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leko/subscriptions","organizations_url":"https://api.github.com/users/Leko/orgs","repos_url":"https://api.github.com/users/Leko/repos","events_url":"https://api.github.com/users/Leko/events{/privacy}","received_events_url":"https://api.github.com/users/Leko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Leko/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/Leko/node","forks_url":"https://api.github.com/repos/Leko/node/forks","keys_url":"https://api.github.com/repos/Leko/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leko/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leko/node/teams","hooks_url":"https://api.github.com/repos/Leko/node/hooks","issue_events_url":"https://api.github.com/repos/Leko/node/issues/events{/number}","events_url":"https://api.github.com/repos/Leko/node/events","assignees_url":"https://api.github.com/repos/Leko/node/assignees{/user}","branches_url":"https://api.github.com/repos/Leko/node/branches{/branch}","tags_url":"https://api.github.com/repos/Leko/node/tags","blobs_url":"https://api.github.com/repos/Leko/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leko/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leko/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leko/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leko/node/statuses/{sha}","languages_url":"https://api.github.com/repos/Leko/node/languages","stargazers_url":"https://api.github.com/repos/Leko/node/stargazers","contributors_url":"https://api.github.com/repos/Leko/node/contributors","subscribers_url":"https://api.github.com/repos/Leko/node/subscribers","subscription_url":"https://api.github.com/repos/Leko/node/subscription","commits_url":"https://api.github.com/repos/Leko/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leko/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leko/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leko/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leko/node/contents/{+path}","compare_url":"https://api.github.com/repos/Leko/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leko/node/merges","archive_url":"https://api.github.com/repos/Leko/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leko/node/downloads","issues_url":"https://api.github.com/repos/Leko/node/issues{/number}","pulls_url":"https://api.github.com/repos/Leko/node/pulls{/number}","milestones_url":"https://api.github.com/repos/Leko/node/milestones{/number}","notifications_url":"https://api.github.com/repos/Leko/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leko/node/labels{/name}","releases_url":"https://api.github.com/repos/Leko/node/releases{/id}","deployments_url":"https://api.github.com/repos/Leko/node/deployments","created_at":"2017-11-26T07:38:51Z","updated_at":"2017-11-26T07:39:14Z","pushed_at":"2017-11-27T08:53:31Z","git_url":"git://github.com/Leko/node.git","ssh_url":"git@github.com:Leko/node.git","clone_url":"https://github.com/Leko/node.git","svn_url":"https://github.com/Leko/node","homepage":"https://nodejs.org","size":333051,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4ca4db0d4cd5eb3e7eb0dafdfef9ee3e9d091e0d","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-11-27T09:14:46Z","pushed_at":"2017-11-27T08:57:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":333050,"stargazers_count":42796,"watchers_count":42796,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8958,"mirror_url":null,"archived":false,"open_issues_count":800,"forks":8958,"open_issues":800,"watchers":42796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/17345"},"html":{"href":"https://github.com/nodejs/node/pull/17345"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/17345"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/17345/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/17345/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/17345/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/79d1fbca201de498b2deb5488bd1d80610fbc103"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vsemozhetbyt"}}