{"action":"created","comment":{"url":"https://api.github.com/repos/sbt/zinc/pulls/comments/148176962","pull_request_review_id":73378447,"id":148176962,"diff_hunk":"@@ -114,8 +114,9 @@ final class Dependency(val global: CallbackGlobal) extends LocateClassFile with\n             // The dependency comes from a JAR\n             for {\n               zip <- zipEntry.underlyingSource\n-              classFile <- Option(zip.file)\n-            } binaryDependency(classFile, binaryClassName)\n+              jarFile <- Option(zip.file)\n+              if !jarFile.isDirectory // workaround for JDK9 and Scala 2.10/2.11, see https://github.com/sbt/sbt/pull/3701\n+            } binaryDependency(jarFile, binaryClassName)","path":"internal/compiler-bridge/src/main/scala/xsbt/Dependency.scala","position":8,"original_position":8,"commit_id":"6302a194d53ba9018aa24898e76f9a1195e2f40f","original_commit_id":"6302a194d53ba9018aa24898e76f9a1195e2f40f","user":{"login":"retronym","id":65551,"avatar_url":"https://avatars0.githubusercontent.com/u/65551?v=4","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"body":"This is the only change that fixes an observable bug. I didn't figure out why the bug in SBT 0.13 fixed by `-Dscala.ext.dirs` was not necessary here.","created_at":"2017-11-01T03:42:50Z","updated_at":"2017-11-01T03:42:50Z","html_url":"https://github.com/sbt/zinc/pull/450#discussion_r148176962","pull_request_url":"https://api.github.com/repos/sbt/zinc/pulls/450","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments/148176962"},"html":{"href":"https://github.com/sbt/zinc/pull/450#discussion_r148176962"},"pull_request":{"href":"https://api.github.com/repos/sbt/zinc/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/sbt/zinc/pulls/450","id":149955938,"html_url":"https://github.com/sbt/zinc/pull/450","diff_url":"https://github.com/sbt/zinc/pull/450.diff","patch_url":"https://github.com/sbt/zinc/pull/450.patch","issue_url":"https://api.github.com/repos/sbt/zinc/issues/450","number":450,"state":"open","locked":false,"title":"Forward port sbt/sbt#3701, JDK9/Scala 2.{10,11} overcompilation","user":{"login":"retronym","id":65551,"avatar_url":"https://avatars0.githubusercontent.com/u/65551?v=4","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-01T03:41:27Z","updated_at":"2017-11-01T03:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85dbb881127e65ea3b0a083544d47e4532fa3b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sbt/zinc/pulls/450/commits","review_comments_url":"https://api.github.com/repos/sbt/zinc/pulls/450/comments","review_comment_url":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/zinc/issues/450/comments","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/6302a194d53ba9018aa24898e76f9a1195e2f40f","head":{"label":"retronym:ticket/dirDependency","ref":"ticket/dirDependency","sha":"6302a194d53ba9018aa24898e76f9a1195e2f40f","user":{"login":"retronym","id":65551,"avatar_url":"https://avatars0.githubusercontent.com/u/65551?v=4","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"repo":{"id":109083453,"name":"zinc","full_name":"retronym/zinc","owner":{"login":"retronym","id":65551,"avatar_url":"https://avatars0.githubusercontent.com/u/65551?v=4","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/retronym/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":true,"url":"https://api.github.com/repos/retronym/zinc","forks_url":"https://api.github.com/repos/retronym/zinc/forks","keys_url":"https://api.github.com/repos/retronym/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/retronym/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/retronym/zinc/teams","hooks_url":"https://api.github.com/repos/retronym/zinc/hooks","issue_events_url":"https://api.github.com/repos/retronym/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/retronym/zinc/events","assignees_url":"https://api.github.com/repos/retronym/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/retronym/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/retronym/zinc/tags","blobs_url":"https://api.github.com/repos/retronym/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/retronym/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/retronym/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/retronym/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/retronym/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/retronym/zinc/languages","stargazers_url":"https://api.github.com/repos/retronym/zinc/stargazers","contributors_url":"https://api.github.com/repos/retronym/zinc/contributors","subscribers_url":"https://api.github.com/repos/retronym/zinc/subscribers","subscription_url":"https://api.github.com/repos/retronym/zinc/subscription","commits_url":"https://api.github.com/repos/retronym/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/retronym/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/retronym/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/retronym/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/retronym/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/retronym/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/retronym/zinc/merges","archive_url":"https://api.github.com/repos/retronym/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/retronym/zinc/downloads","issues_url":"https://api.github.com/repos/retronym/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/retronym/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/retronym/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/retronym/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/retronym/zinc/labels{/name}","releases_url":"https://api.github.com/repos/retronym/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/retronym/zinc/deployments","created_at":"2017-11-01T03:40:52Z","updated_at":"2017-11-01T03:40:54Z","pushed_at":"2017-11-01T03:41:04Z","git_url":"git://github.com/retronym/zinc.git","ssh_url":"git@github.com:retronym/zinc.git","clone_url":"https://github.com/retronym/zinc.git","svn_url":"https://github.com/retronym/zinc","homepage":"","size":10919,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"sbt:1.x","ref":"1.x","sha":"8c42c1f27040be2d1f91746d8bd8d03d9bcbc183","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"zinc","full_name":"sbt/zinc","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":false,"url":"https://api.github.com/repos/sbt/zinc","forks_url":"https://api.github.com/repos/sbt/zinc/forks","keys_url":"https://api.github.com/repos/sbt/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/zinc/teams","hooks_url":"https://api.github.com/repos/sbt/zinc/hooks","issue_events_url":"https://api.github.com/repos/sbt/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/zinc/events","assignees_url":"https://api.github.com/repos/sbt/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/zinc/tags","blobs_url":"https://api.github.com/repos/sbt/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/zinc/languages","stargazers_url":"https://api.github.com/repos/sbt/zinc/stargazers","contributors_url":"https://api.github.com/repos/sbt/zinc/contributors","subscribers_url":"https://api.github.com/repos/sbt/zinc/subscribers","subscription_url":"https://api.github.com/repos/sbt/zinc/subscription","commits_url":"https://api.github.com/repos/sbt/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/zinc/merges","archive_url":"https://api.github.com/repos/sbt/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/zinc/downloads","issues_url":"https://api.github.com/repos/sbt/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/zinc/labels{/name}","releases_url":"https://api.github.com/repos/sbt/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/sbt/zinc/deployments","created_at":"2015-08-04T21:32:58Z","updated_at":"2017-10-30T18:12:08Z","pushed_at":"2017-11-01T03:41:28Z","git_url":"git://github.com/sbt/zinc.git","ssh_url":"git@github.com:sbt/zinc.git","clone_url":"https://github.com/sbt/zinc.git","svn_url":"https://github.com/sbt/zinc","homepage":"","size":10919,"stargazers_count":104,"watchers_count":104,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":81,"forks":52,"open_issues":81,"watchers":104,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/450"},"html":{"href":"https://github.com/sbt/zinc/pull/450"},"issue":{"href":"https://api.github.com/repos/sbt/zinc/issues/450"},"comments":{"href":"https://api.github.com/repos/sbt/zinc/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/zinc/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/zinc/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/zinc/statuses/6302a194d53ba9018aa24898e76f9a1195e2f40f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"retronym"}}