{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3001","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3001/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3001/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3001/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/3001","id":282045180,"number":3001,"title":"Code cleanup ideas","user":{"login":"kholia","id":79528,"avatar_url":"https://avatars1.githubusercontent.com/u/79528?v=4","gravatar_id":"","url":"https://api.github.com/users/kholia","html_url":"https://github.com/kholia","followers_url":"https://api.github.com/users/kholia/followers","following_url":"https://api.github.com/users/kholia/following{/other_user}","gists_url":"https://api.github.com/users/kholia/gists{/gist_id}","starred_url":"https://api.github.com/users/kholia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholia/subscriptions","organizations_url":"https://api.github.com/users/kholia/orgs","repos_url":"https://api.github.com/users/kholia/repos","events_url":"https://api.github.com/users/kholia/events{/privacy}","received_events_url":"https://api.github.com/users/kholia/received_events","type":"User","site_admin":false},"labels":[{"id":110083271,"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/Maintenance/cleanup","name":"Maintenance/cleanup","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-12-14T10:07:44Z","updated_at":"2017-12-17T15:09:12Z","closed_at":null,"author_association":"COLLABORATOR","body":"Here are a couple of ideas regarding code cleanup,\r\n\r\n* Lot of formats include `assert.h`, `errno`, and `ctype.h` headers. I don't think that these headers are required in a large majority of the formats.\r\n\r\n* Use @solardiz's approach to using OpenMP properly. Use `tacacs_plus_fmt_plug.c` as a template for other formats.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/352262276","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/3001#issuecomment-352262276","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3001","id":352262276,"user":{"login":"kholia","id":79528,"avatar_url":"https://avatars1.githubusercontent.com/u/79528?v=4","gravatar_id":"","url":"https://api.github.com/users/kholia","html_url":"https://github.com/kholia","followers_url":"https://api.github.com/users/kholia/followers","following_url":"https://api.github.com/users/kholia/following{/other_user}","gists_url":"https://api.github.com/users/kholia/gists{/gist_id}","starred_url":"https://api.github.com/users/kholia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholia/subscriptions","organizations_url":"https://api.github.com/users/kholia/orgs","repos_url":"https://api.github.com/users/kholia/repos","events_url":"https://api.github.com/users/kholia/events{/privacy}","received_events_url":"https://api.github.com/users/kholia/received_events","type":"User","site_admin":false},"created_at":"2017-12-17T15:09:12Z","updated_at":"2017-12-17T15:09:12Z","author_association":"COLLABORATOR","body":"Regarding the incorrect OpenMP usage,\r\n\r\n```\r\n$ grep -Rin \"pragma omp parallel\" -A 1 | tee ~/log.txt | grep -v \"endif\"\r\n...\r\n<lot here>\r\neigrp_fmt_plug.c:276:#pragma omp parallel for\r\neigrp_fmt_plug.c-277-\tfor (index = 0; index < count; index++)\r\n...\r\nskein_fmt_plug.c:208:#pragma omp parallel for\r\nskein_fmt_plug.c-209-\tfor (index = 0; index < count; index++)\r\n```\r\n\r\nI could use a better grep hack ;)\r\n\r\nNote: We want to find code patterns which deviate from the following standard construction,\r\n\r\n```\r\n#ifdef _OPENMP\r\n#pragma omp parallel for\r\n#endif\r\n```\r\n\r\nHopefully, my understanding regarding the correct OpenMP constructions is OK. It has been a while."}}
{"actor":{"display_login":"kholia"}}