{"action":"created","comment":{"url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/comments/109826535","pull_request_review_id":30952739,"id":109826535,"diff_hunk":"@@ -312,127 +315,23 @@ protected ModelRepresentation createNewModel(String name, String description, In\n     return new ModelRepresentation(newModel);\n   }\n \n-  @RequestMapping(value = \"/rest/model/exportForDeploy/{modelId}\")\n+  @RequestMapping(value = \"/rest/models/{modelId}/exportForDeploy\")\n   @ResponseBody\n   public ResponseEntity<Map<String, String>> exportForDeploy(@PathVariable(\"modelId\") String modelId)\n-          throws JsonProcessingException, IOException\n   {\n-\n-    Model modelData = modelService.getModel(modelId);\n-    JsonNode modelNode = objectMapper.readTree(modelData.getModelEditorJson());\n-    byte[] bpmnBytes = null;\n+    Model model = modelService.getModel(modelId);\n     \n-    Map<String, String> formMap = new HashMap<String, String>();\n-    Map<String, String> decisionTableMap = new HashMap<String, String>();\n-\n-    List<Model> referencedModels = modelRepository.findByParentModelId(modelId);\n-          for (Model childModel : referencedModels) {\n-              if (Model.MODEL_TYPE_FORM_RDS == childModel.getModelType()) {\n-        formMap.put(childModel.getId(), childModel.getKey());\n-\n-              } else if (Model.MODEL_TYPE_DECISION_TABLE == childModel.getModelType()) {\n-        decisionTableMap.put(childModel.getId(), childModel.getKey());\n-      }\n-    }\n-          \n-    BpmnModel model = new RDSBpmnJsonConverter().convertToBpmnModel(modelNode, formMap, decisionTableMap);\n-    formsAsExtension(model);","path":"modules/flowable-ui-modeler/flowable-ui-modeler-rest/src/main/java/org/flowable/app/rest/editor/ModelResource.java","position":102,"original_position":61,"commit_id":"40241cf09aab31bb682c52dc48d587815dfa1100","original_commit_id":"ddfb4703a402dc9d29641ced7f8b33cb1dc71d45","user":{"login":"simon998yang","id":18102688,"avatar_url":"https://avatars0.githubusercontent.com/u/18102688?v=3","gravatar_id":"","url":"https://api.github.com/users/simon998yang","html_url":"https://github.com/simon998yang","followers_url":"https://api.github.com/users/simon998yang/followers","following_url":"https://api.github.com/users/simon998yang/following{/other_user}","gists_url":"https://api.github.com/users/simon998yang/gists{/gist_id}","starred_url":"https://api.github.com/users/simon998yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon998yang/subscriptions","organizations_url":"https://api.github.com/users/simon998yang/orgs","repos_url":"https://api.github.com/users/simon998yang/repos","events_url":"https://api.github.com/users/simon998yang/events{/privacy}","received_events_url":"https://api.github.com/users/simon998yang/received_events","type":"User","site_admin":false},"body":"nope. I added this code in earlier PR, now it's been refactored into ModelServiceImpl.java","created_at":"2017-04-05T04:01:48Z","updated_at":"2017-04-05T04:01:49Z","html_url":"https://github.com/relational-data-systems/flowable-engine/pull/3#discussion_r109826535","pull_request_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/comments/109826535"},"html":{"href":"https://github.com/relational-data-systems/flowable-engine/pull/3#discussion_r109826535"},"pull_request":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3","id":114068918,"html_url":"https://github.com/relational-data-systems/flowable-engine/pull/3","diff_url":"https://github.com/relational-data-systems/flowable-engine/pull/3.diff","patch_url":"https://github.com/relational-data-systems/flowable-engine/pull/3.patch","issue_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/3","number":3,"state":"open","locked":false,"title":"Upgrade/rsb 634","user":{"login":"simon998yang","id":18102688,"avatar_url":"https://avatars0.githubusercontent.com/u/18102688?v=3","gravatar_id":"","url":"https://api.github.com/users/simon998yang","html_url":"https://github.com/simon998yang","followers_url":"https://api.github.com/users/simon998yang/followers","following_url":"https://api.github.com/users/simon998yang/following{/other_user}","gists_url":"https://api.github.com/users/simon998yang/gists{/gist_id}","starred_url":"https://api.github.com/users/simon998yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon998yang/subscriptions","organizations_url":"https://api.github.com/users/simon998yang/orgs","repos_url":"https://api.github.com/users/simon998yang/repos","events_url":"https://api.github.com/users/simon998yang/events{/privacy}","received_events_url":"https://api.github.com/users/simon998yang/received_events","type":"User","site_admin":false},"body":"RSB-632\r\nRSB-633\r\nRSB-634\r\nRSB-635\r\nRSB-636\r\nRSB-638\r\nRSB-639","created_at":"2017-04-04T04:37:08Z","updated_at":"2017-04-05T04:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2013bb076509b362e69c0906de4fdd68a34211df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3/commits","review_comments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3/comments","review_comment_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/3/comments","statuses_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/statuses/40241cf09aab31bb682c52dc48d587815dfa1100","head":{"label":"relational-data-systems:upgrade/RSB-634","ref":"upgrade/RSB-634","sha":"40241cf09aab31bb682c52dc48d587815dfa1100","user":{"login":"relational-data-systems","id":21193522,"avatar_url":"https://avatars2.githubusercontent.com/u/21193522?v=3","gravatar_id":"","url":"https://api.github.com/users/relational-data-systems","html_url":"https://github.com/relational-data-systems","followers_url":"https://api.github.com/users/relational-data-systems/followers","following_url":"https://api.github.com/users/relational-data-systems/following{/other_user}","gists_url":"https://api.github.com/users/relational-data-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/relational-data-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relational-data-systems/subscriptions","organizations_url":"https://api.github.com/users/relational-data-systems/orgs","repos_url":"https://api.github.com/users/relational-data-systems/repos","events_url":"https://api.github.com/users/relational-data-systems/events{/privacy}","received_events_url":"https://api.github.com/users/relational-data-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":85639360,"name":"flowable-engine","full_name":"relational-data-systems/flowable-engine","owner":{"login":"relational-data-systems","id":21193522,"avatar_url":"https://avatars2.githubusercontent.com/u/21193522?v=3","gravatar_id":"","url":"https://api.github.com/users/relational-data-systems","html_url":"https://github.com/relational-data-systems","followers_url":"https://api.github.com/users/relational-data-systems/followers","following_url":"https://api.github.com/users/relational-data-systems/following{/other_user}","gists_url":"https://api.github.com/users/relational-data-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/relational-data-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relational-data-systems/subscriptions","organizations_url":"https://api.github.com/users/relational-data-systems/orgs","repos_url":"https://api.github.com/users/relational-data-systems/repos","events_url":"https://api.github.com/users/relational-data-systems/events{/privacy}","received_events_url":"https://api.github.com/users/relational-data-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/relational-data-systems/flowable-engine","description":"A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.","fork":true,"url":"https://api.github.com/repos/relational-data-systems/flowable-engine","forks_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/forks","keys_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/teams","hooks_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/hooks","issue_events_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/events","assignees_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/tags","blobs_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/languages","stargazers_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/stargazers","contributors_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/contributors","subscribers_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/subscribers","subscription_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/subscription","commits_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/merges","archive_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/downloads","issues_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/labels{/name}","releases_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/deployments","created_at":"2017-03-21T00:00:03Z","updated_at":"2017-03-21T00:00:27Z","pushed_at":"2017-04-05T03:52:10Z","git_url":"git://github.com/relational-data-systems/flowable-engine.git","ssh_url":"git@github.com:relational-data-systems/flowable-engine.git","clone_url":"https://github.com/relational-data-systems/flowable-engine.git","svn_url":"https://github.com/relational-data-systems/flowable-engine","homepage":"http://www.flowable.org","size":103061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"relational-data-systems:feature/RSB-629","ref":"feature/RSB-629","sha":"d7bfda21b96a1de8319adcadbea390250d61022b","user":{"login":"relational-data-systems","id":21193522,"avatar_url":"https://avatars2.githubusercontent.com/u/21193522?v=3","gravatar_id":"","url":"https://api.github.com/users/relational-data-systems","html_url":"https://github.com/relational-data-systems","followers_url":"https://api.github.com/users/relational-data-systems/followers","following_url":"https://api.github.com/users/relational-data-systems/following{/other_user}","gists_url":"https://api.github.com/users/relational-data-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/relational-data-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relational-data-systems/subscriptions","organizations_url":"https://api.github.com/users/relational-data-systems/orgs","repos_url":"https://api.github.com/users/relational-data-systems/repos","events_url":"https://api.github.com/users/relational-data-systems/events{/privacy}","received_events_url":"https://api.github.com/users/relational-data-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":85639360,"name":"flowable-engine","full_name":"relational-data-systems/flowable-engine","owner":{"login":"relational-data-systems","id":21193522,"avatar_url":"https://avatars2.githubusercontent.com/u/21193522?v=3","gravatar_id":"","url":"https://api.github.com/users/relational-data-systems","html_url":"https://github.com/relational-data-systems","followers_url":"https://api.github.com/users/relational-data-systems/followers","following_url":"https://api.github.com/users/relational-data-systems/following{/other_user}","gists_url":"https://api.github.com/users/relational-data-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/relational-data-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relational-data-systems/subscriptions","organizations_url":"https://api.github.com/users/relational-data-systems/orgs","repos_url":"https://api.github.com/users/relational-data-systems/repos","events_url":"https://api.github.com/users/relational-data-systems/events{/privacy}","received_events_url":"https://api.github.com/users/relational-data-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/relational-data-systems/flowable-engine","description":"A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.","fork":true,"url":"https://api.github.com/repos/relational-data-systems/flowable-engine","forks_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/forks","keys_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/teams","hooks_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/hooks","issue_events_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/events","assignees_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/tags","blobs_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/languages","stargazers_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/stargazers","contributors_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/contributors","subscribers_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/subscribers","subscription_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/subscription","commits_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/merges","archive_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/downloads","issues_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/labels{/name}","releases_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/relational-data-systems/flowable-engine/deployments","created_at":"2017-03-21T00:00:03Z","updated_at":"2017-03-21T00:00:27Z","pushed_at":"2017-04-05T03:52:10Z","git_url":"git://github.com/relational-data-systems/flowable-engine.git","ssh_url":"git@github.com:relational-data-systems/flowable-engine.git","clone_url":"https://github.com/relational-data-systems/flowable-engine.git","svn_url":"https://github.com/relational-data-systems/flowable-engine","homepage":"http://www.flowable.org","size":103061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3"},"html":{"href":"https://github.com/relational-data-systems/flowable-engine/pull/3"},"issue":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/3"},"comments":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/relational-data-systems/flowable-engine/statuses/40241cf09aab31bb682c52dc48d587815dfa1100"}}}}
{"actor":{"display_login":"simon998yang"}}