{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/121288740","pull_request_review_id":43326421,"id":121288740,"diff_hunk":"@@ -27,11 +29,14 @@ HLTBTagHarvestingAnalyzer::dqmEndJob(DQMStore::IBooker & ibooker, DQMStore::IGet\n \t{\n \t\tdqmFolder_hist = Form(\"HLT/BTag/Discriminator/%s\",hltPathNames_[ind].c_str());\n \t\tstd::string effDir = Form(\"HLT/BTag/Discriminator/%s/efficiency\",hltPathNames_[ind].c_str());\n+\t\tstd::string relationsDir = Form(\"HLT/BTag/Discriminator/%s/HEP17_HEM17\",hltPathNames_[ind].c_str());\n \t\tibooker.setCurrentFolder(effDir);\n \t\tTH1 *den =NULL;\n \t\tTH1 *num =NULL; \n \t\tstd::map<TString,TH1F> effics;\n \t\tstd::map<TString,bool> efficsOK;\n+\t\tstd::map<TString,std::map<std::string,TH1F> > efficsmod;","path":"HLTriggerOffline/Btag/src/HLTBTagHarvestingAnalyzer.cc","position":19,"original_position":19,"commit_id":"315b77d12e6136cff9799f36e5cc3beada734806","original_commit_id":"315b77d12e6136cff9799f36e5cc3beada734806","user":{"login":"fwyzard","id":4069793,"avatar_url":"https://avatars1.githubusercontent.com/u/4069793?v=3","gravatar_id":"","url":"https://api.github.com/users/fwyzard","html_url":"https://github.com/fwyzard","followers_url":"https://api.github.com/users/fwyzard/followers","following_url":"https://api.github.com/users/fwyzard/following{/other_user}","gists_url":"https://api.github.com/users/fwyzard/gists{/gist_id}","starred_url":"https://api.github.com/users/fwyzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwyzard/subscriptions","organizations_url":"https://api.github.com/users/fwyzard/orgs","repos_url":"https://api.github.com/users/fwyzard/repos","events_url":"https://api.github.com/users/fwyzard/events{/privacy}","received_events_url":"https://api.github.com/users/fwyzard/received_events","type":"User","site_admin":false},"body":"fine by me, but please do prepare a follow up PR for that.","created_at":"2017-06-11T18:56:40Z","updated_at":"2017-06-11T18:56:40Z","html_url":"https://github.com/cms-sw/cmssw/pull/18986#discussion_r121288740","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/121288740"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/18986#discussion_r121288740"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986","id":122797281,"html_url":"https://github.com/cms-sw/cmssw/pull/18986","diff_url":"https://github.com/cms-sw/cmssw/pull/18986.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/18986.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18986","number":18986,"state":"open","locked":false,"title":"Adding plots for the hltbtag HEP17 validation","user":{"login":"natalia-korneeva","id":27738343,"avatar_url":"https://avatars1.githubusercontent.com/u/27738343?v=3","gravatar_id":"","url":"https://api.github.com/users/natalia-korneeva","html_url":"https://github.com/natalia-korneeva","followers_url":"https://api.github.com/users/natalia-korneeva/followers","following_url":"https://api.github.com/users/natalia-korneeva/following{/other_user}","gists_url":"https://api.github.com/users/natalia-korneeva/gists{/gist_id}","starred_url":"https://api.github.com/users/natalia-korneeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natalia-korneeva/subscriptions","organizations_url":"https://api.github.com/users/natalia-korneeva/orgs","repos_url":"https://api.github.com/users/natalia-korneeva/repos","events_url":"https://api.github.com/users/natalia-korneeva/events{/privacy}","received_events_url":"https://api.github.com/users/natalia-korneeva/received_events","type":"User","site_admin":false},"body":"Adding the usual validation plots for specific modules (HEP17, HEM17, HEP18).\r\nAdding the HEP17/HEM17 relation plots.\r\nAn example of relation plots are here:\r\nhttps://twiki.cern.ch/twiki/bin/view/Sandbox/NataliaTsirovaSandbox#Relations_HEP17_HEM17","created_at":"2017-05-28T14:27:45Z","updated_at":"2017-06-11T18:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f7a6ab96730660a0863803a0fce3f40297d0633","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":88,"closed_issues":434,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-06-11T15:50:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18986/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/315b77d12e6136cff9799f36e5cc3beada734806","head":{"label":"natalia-korneeva:HEP17-btaghlt-validation","ref":"HEP17-btaghlt-validation","sha":"315b77d12e6136cff9799f36e5cc3beada734806","user":{"login":"natalia-korneeva","id":27738343,"avatar_url":"https://avatars1.githubusercontent.com/u/27738343?v=3","gravatar_id":"","url":"https://api.github.com/users/natalia-korneeva","html_url":"https://github.com/natalia-korneeva","followers_url":"https://api.github.com/users/natalia-korneeva/followers","following_url":"https://api.github.com/users/natalia-korneeva/following{/other_user}","gists_url":"https://api.github.com/users/natalia-korneeva/gists{/gist_id}","starred_url":"https://api.github.com/users/natalia-korneeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natalia-korneeva/subscriptions","organizations_url":"https://api.github.com/users/natalia-korneeva/orgs","repos_url":"https://api.github.com/users/natalia-korneeva/repos","events_url":"https://api.github.com/users/natalia-korneeva/events{/privacy}","received_events_url":"https://api.github.com/users/natalia-korneeva/received_events","type":"User","site_admin":false},"repo":{"id":88674997,"name":"cmssw","full_name":"natalia-korneeva/cmssw","owner":{"login":"natalia-korneeva","id":27738343,"avatar_url":"https://avatars1.githubusercontent.com/u/27738343?v=3","gravatar_id":"","url":"https://api.github.com/users/natalia-korneeva","html_url":"https://github.com/natalia-korneeva","followers_url":"https://api.github.com/users/natalia-korneeva/followers","following_url":"https://api.github.com/users/natalia-korneeva/following{/other_user}","gists_url":"https://api.github.com/users/natalia-korneeva/gists{/gist_id}","starred_url":"https://api.github.com/users/natalia-korneeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natalia-korneeva/subscriptions","organizations_url":"https://api.github.com/users/natalia-korneeva/orgs","repos_url":"https://api.github.com/users/natalia-korneeva/repos","events_url":"https://api.github.com/users/natalia-korneeva/events{/privacy}","received_events_url":"https://api.github.com/users/natalia-korneeva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natalia-korneeva/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/natalia-korneeva/cmssw","forks_url":"https://api.github.com/repos/natalia-korneeva/cmssw/forks","keys_url":"https://api.github.com/repos/natalia-korneeva/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natalia-korneeva/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natalia-korneeva/cmssw/teams","hooks_url":"https://api.github.com/repos/natalia-korneeva/cmssw/hooks","issue_events_url":"https://api.github.com/repos/natalia-korneeva/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/natalia-korneeva/cmssw/events","assignees_url":"https://api.github.com/repos/natalia-korneeva/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/natalia-korneeva/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/natalia-korneeva/cmssw/tags","blobs_url":"https://api.github.com/repos/natalia-korneeva/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natalia-korneeva/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natalia-korneeva/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/natalia-korneeva/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natalia-korneeva/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/natalia-korneeva/cmssw/languages","stargazers_url":"https://api.github.com/repos/natalia-korneeva/cmssw/stargazers","contributors_url":"https://api.github.com/repos/natalia-korneeva/cmssw/contributors","subscribers_url":"https://api.github.com/repos/natalia-korneeva/cmssw/subscribers","subscription_url":"https://api.github.com/repos/natalia-korneeva/cmssw/subscription","commits_url":"https://api.github.com/repos/natalia-korneeva/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/natalia-korneeva/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/natalia-korneeva/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/natalia-korneeva/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/natalia-korneeva/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/natalia-korneeva/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natalia-korneeva/cmssw/merges","archive_url":"https://api.github.com/repos/natalia-korneeva/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natalia-korneeva/cmssw/downloads","issues_url":"https://api.github.com/repos/natalia-korneeva/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/natalia-korneeva/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/natalia-korneeva/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/natalia-korneeva/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natalia-korneeva/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/natalia-korneeva/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/natalia-korneeva/cmssw/deployments","created_at":"2017-04-18T22:11:50Z","updated_at":"2017-04-18T22:14:50Z","pushed_at":"2017-06-06T21:52:15Z","git_url":"git://github.com/natalia-korneeva/cmssw.git","ssh_url":"git@github.com:natalia-korneeva/cmssw.git","clone_url":"https://github.com/natalia-korneeva/cmssw.git","svn_url":"https://github.com/natalia-korneeva/cmssw","homepage":"http://cms-sw.github.io/","size":948778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"298e2fbf7cac6264065305e6bdc530aeb77b78cf","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-06-09T00:02:18Z","pushed_at":"2017-06-11T17:16:18Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":952743,"stargazers_count":421,"watchers_count":421,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2219,"mirror_url":null,"open_issues_count":360,"forks":2219,"open_issues":360,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/18986"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18986"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18986/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18986/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/315b77d12e6136cff9799f36e5cc3beada734806"}}}}
{"actor":{"display_login":"fwyzard"}}