{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/94944475","pull_request_review_id":15485404,"id":94944475,"diff_hunk":"@@ -38,6 +38,9 @@ MaterialData::release()\n void\n MaterialData::size(unsigned int n_qpoints)\n {\n+  if (n_qpoints == _n_qpoints)","path":"framework/src/materials/MaterialData.C","position":4,"original_position":4,"commit_id":"c36c14473ebacc9bc9b314d8c29efb02eafb74dd","original_commit_id":"c36c14473ebacc9bc9b314d8c29efb02eafb74dd","user":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=3","gravatar_id":"","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"body":"This is good.","created_at":"2017-01-06T13:22:46Z","updated_at":"2017-01-06T13:34:30Z","html_url":"https://github.com/idaholab/moose/pull/8278#discussion_r94944475","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/8278","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/94944475"},"html":{"href":"https://github.com/idaholab/moose/pull/8278#discussion_r94944475"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8278"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/8278","id":100382417,"html_url":"https://github.com/idaholab/moose/pull/8278","diff_url":"https://github.com/idaholab/moose/pull/8278.diff","patch_url":"https://github.com/idaholab/moose/pull/8278.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/8278","number":8278,"state":"open","locked":false,"title":"make declareProperty[Old/Older] optional and other material property housekeeping","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"body":"This makes ``getMaterialProperty[Old/Older]`` implicitly cause a property to become stateful.  Other tweaks include:\r\n\r\n* improve doc comments in MaterialData and other material classes\r\n* have MaterialData::size function do its own check for change in n_qpoints - eliminating need for paired checks in several places.\r\n* Eliminate redundancy in MaterialData::[get/declare]Property functions.\r\n* Eliminate redundancy in MaterialPropertyStorage functions w.r.t. initializing hashmaps.\r\n* remove always false error checking for retrieving non-existing material types.\r\n\r\nfixes #8031, #7867\r\n\r\nBecause of ``initStatefulQpProperties``, I haven't been able to come up with a satisfactory way to deprecate ``declareProperty[Old/Older]``.  If a material doesn't retrieve the (writable) references using the declare functions (get functions return const refs), then it can't initialize the values in initStatefulQpProperties.  I looked into creating a new ``Material::initQpStatefulProperty(std::string& prop_name, T& old, T& older)`` function called by MaterialData whenever a property *becomes* stateful via a getMaterialProperty[Old/Older] call, but this doesn't work because the property initialization that happens later in MaterialPropertyStorage would clobber that.  And calling such a templated function would not work from MaterialPropertyStorage because it doesn't know the templated types of each property.  There may be a good solution lurking, but I haven't found it yet.","created_at":"2017-01-05T23:13:59Z","updated_at":"2017-01-06T13:34:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84764e35203366975fdae0906be72dd580095499","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/8278/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/8278/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/8278/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/c36c14473ebacc9bc9b314d8c29efb02eafb74dd","head":{"label":"rwcarlsen:mat-props","ref":"mat-props","sha":"c36c14473ebacc9bc9b314d8c29efb02eafb74dd","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"repo":{"id":68224891,"name":"moose","full_name":"rwcarlsen/moose","owner":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwcarlsen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/rwcarlsen/moose","forks_url":"https://api.github.com/repos/rwcarlsen/moose/forks","keys_url":"https://api.github.com/repos/rwcarlsen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwcarlsen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwcarlsen/moose/teams","hooks_url":"https://api.github.com/repos/rwcarlsen/moose/hooks","issue_events_url":"https://api.github.com/repos/rwcarlsen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/rwcarlsen/moose/events","assignees_url":"https://api.github.com/repos/rwcarlsen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/rwcarlsen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/rwcarlsen/moose/tags","blobs_url":"https://api.github.com/repos/rwcarlsen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwcarlsen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwcarlsen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwcarlsen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwcarlsen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/rwcarlsen/moose/languages","stargazers_url":"https://api.github.com/repos/rwcarlsen/moose/stargazers","contributors_url":"https://api.github.com/repos/rwcarlsen/moose/contributors","subscribers_url":"https://api.github.com/repos/rwcarlsen/moose/subscribers","subscription_url":"https://api.github.com/repos/rwcarlsen/moose/subscription","commits_url":"https://api.github.com/repos/rwcarlsen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwcarlsen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwcarlsen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwcarlsen/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwcarlsen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/rwcarlsen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwcarlsen/moose/merges","archive_url":"https://api.github.com/repos/rwcarlsen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwcarlsen/moose/downloads","issues_url":"https://api.github.com/repos/rwcarlsen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/rwcarlsen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/rwcarlsen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/rwcarlsen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwcarlsen/moose/labels{/name}","releases_url":"https://api.github.com/repos/rwcarlsen/moose/releases{/id}","deployments_url":"https://api.github.com/repos/rwcarlsen/moose/deployments","created_at":"2016-09-14T16:48:53Z","updated_at":"2016-09-14T16:49:08Z","pushed_at":"2017-01-05T23:57:03Z","git_url":"git://github.com/rwcarlsen/moose.git","ssh_url":"git@github.com:rwcarlsen/moose.git","clone_url":"https://github.com/rwcarlsen/moose.git","svn_url":"https://github.com/rwcarlsen/moose","homepage":"http://www.mooseframework.org","size":157371,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"b615c46ccb8566a53d502786f4ddadc1a1e76112","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2017-01-03T10:02:41Z","pushed_at":"2017-01-06T03:56:47Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":156871,"stargazers_count":183,"watchers_count":183,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":724,"forks":316,"open_issues":724,"watchers":183,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8278"},"html":{"href":"https://github.com/idaholab/moose/pull/8278"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/8278"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/8278/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8278/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8278/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/c36c14473ebacc9bc9b314d8c29efb02eafb74dd"}}}}
{"actor":{"display_login":"friedmud"}}