{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/104791577","pull_request_review_id":25643947,"id":104791577,"diff_hunk":"@@ -56,13 +56,15 @@ var/datum/subsystem/ticker/ticker\n \n \tvar/news_report\n \n+\tvar/list/prioritized_jobs = list()","path":"code/controllers/subsystem/ticker.dm","position":4,"original_position":4,"commit_id":"16b1f3c8b8100aba4da3f0796468f54e51f55cb8","original_commit_id":"16b1f3c8b8100aba4da3f0796468f54e51f55cb8","user":{"login":"optimumtact","id":2544323,"avatar_url":"https://avatars1.githubusercontent.com/u/2544323?v=3","gravatar_id":"","url":"https://api.github.com/users/optimumtact","html_url":"https://github.com/optimumtact","followers_url":"https://api.github.com/users/optimumtact/followers","following_url":"https://api.github.com/users/optimumtact/following{/other_user}","gists_url":"https://api.github.com/users/optimumtact/gists{/gist_id}","starred_url":"https://api.github.com/users/optimumtact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimumtact/subscriptions","organizations_url":"https://api.github.com/users/optimumtact/orgs","repos_url":"https://api.github.com/users/optimumtact/repos","events_url":"https://api.github.com/users/optimumtact/events{/privacy}","received_events_url":"https://api.github.com/users/optimumtact/received_events","type":"User","site_admin":false},"body":"This isn't rocket science, define the var on the controller datum, you can then access it globally via SSJob.varname\r\n\r\nplease do this ","created_at":"2017-03-07T22:03:31Z","updated_at":"2017-03-07T22:03:31Z","html_url":"https://github.com/tgstation/tgstation/pull/24495#discussion_r104791577","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/24495","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/104791577"},"html":{"href":"https://github.com/tgstation/tgstation/pull/24495#discussion_r104791577"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/24495"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/24495","id":108055846,"html_url":"https://github.com/tgstation/tgstation/pull/24495","diff_url":"https://github.com/tgstation/tgstation/pull/24495.diff","patch_url":"https://github.com/tgstation/tgstation/pull/24495.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/24495","number":24495,"state":"open","locked":false,"title":"Ports a system for the HoP to prioritize certain roles for latejoiners.","user":{"login":"bgobandit","id":6813002,"avatar_url":"https://avatars3.githubusercontent.com/u/6813002?v=3","gravatar_id":"","url":"https://api.github.com/users/bgobandit","html_url":"https://github.com/bgobandit","followers_url":"https://api.github.com/users/bgobandit/followers","following_url":"https://api.github.com/users/bgobandit/following{/other_user}","gists_url":"https://api.github.com/users/bgobandit/gists{/gist_id}","starred_url":"https://api.github.com/users/bgobandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgobandit/subscriptions","organizations_url":"https://api.github.com/users/bgobandit/orgs","repos_url":"https://api.github.com/users/bgobandit/repos","events_url":"https://api.github.com/users/bgobandit/events{/privacy}","received_events_url":"https://api.github.com/users/bgobandit/received_events","type":"User","site_admin":false},"body":":cl: bgobandit\r\nadd: To crack down on bad hiring practices, the HoP is encouraged to prioritize jobs via the Job Management section of the ID console.\r\n/:cl:\r\n\r\nPorted with modifications from Yogstation: https://github.com/yogstation13/yogstation/pull/1875\r\n\r\nThis PR adds the ability for HoPs to specify certain jobs as prioritized via the Job Management section of the ID console. Up to five jobs can be prioritized at a time.\r\n\r\n![Management screen](http://i.imgur.com/x0zlRdN.png)\r\n\r\nIf any prioritized jobs exist, they will be shown to players in the Join Game screen. \r\n\r\n![Lobby](http://i.imgur.com/QhDQtKD.png)\r\n\r\nObvious questions:\r\n\r\n- *WHY IS THIS WORTH ADDING*: Especially on lowpop, you end up with huge amounts of non-covered jobs. Some of them are more useful or wanted than others. It gives players a better idea of what would be considered most helpful, which theoretically will improve rounds.\r\n\r\n- *THIS ENCOURAGES METAGAMING*: I'm just going to copy-paste super's reasoning: \"My general thought is that if a player doesn't want to join the round because they've pieced together it's going to be THAT sorta round type then what does it matter? They're going to join, hear the round type over the radio, and then commit suicide. At least in this sense it keeps them off of important jobs. And who's to say they still won't join and suicide?\"\r\n\r\n- *THIS ENCOURAGES ASSISTANTS TO \"PRIORITIZE\" A BUNCH OF USELESS SHIT*: Like everything else in Job Management this is locked behind ID access. If someone has ID console access the round has bigger issues.\r\n\r\n- *WHY ISN'T THIS A FULL PORT*: Yog allows the HoP to also set a message but I think this would be too easily abused and too much work on admins, given our playerbase. (Something like the station charter requires admins to sign off on it and can only be used once.) They also make the jobs a different color on the join screen, but someone on their PR said it'd just be confusing for new players and I agree.\r\n\r\nalso I fixed some typos","created_at":"2017-02-27T06:46:24Z","updated_at":"2017-03-07T22:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94d698f37990a4d4b995f643e7cfad6df901a160","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/24495/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/24495/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/24495/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/16b1f3c8b8100aba4da3f0796468f54e51f55cb8","head":{"label":"bgobandit:hopyog","ref":"hopyog","sha":"16b1f3c8b8100aba4da3f0796468f54e51f55cb8","user":{"login":"bgobandit","id":6813002,"avatar_url":"https://avatars3.githubusercontent.com/u/6813002?v=3","gravatar_id":"","url":"https://api.github.com/users/bgobandit","html_url":"https://github.com/bgobandit","followers_url":"https://api.github.com/users/bgobandit/followers","following_url":"https://api.github.com/users/bgobandit/following{/other_user}","gists_url":"https://api.github.com/users/bgobandit/gists{/gist_id}","starred_url":"https://api.github.com/users/bgobandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgobandit/subscriptions","organizations_url":"https://api.github.com/users/bgobandit/orgs","repos_url":"https://api.github.com/users/bgobandit/repos","events_url":"https://api.github.com/users/bgobandit/events{/privacy}","received_events_url":"https://api.github.com/users/bgobandit/received_events","type":"User","site_admin":false},"repo":{"id":39504951,"name":"-tg-station","full_name":"bgobandit/-tg-station","owner":{"login":"bgobandit","id":6813002,"avatar_url":"https://avatars3.githubusercontent.com/u/6813002?v=3","gravatar_id":"","url":"https://api.github.com/users/bgobandit","html_url":"https://github.com/bgobandit","followers_url":"https://api.github.com/users/bgobandit/followers","following_url":"https://api.github.com/users/bgobandit/following{/other_user}","gists_url":"https://api.github.com/users/bgobandit/gists{/gist_id}","starred_url":"https://api.github.com/users/bgobandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgobandit/subscriptions","organizations_url":"https://api.github.com/users/bgobandit/orgs","repos_url":"https://api.github.com/users/bgobandit/repos","events_url":"https://api.github.com/users/bgobandit/events{/privacy}","received_events_url":"https://api.github.com/users/bgobandit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgobandit/-tg-station","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/bgobandit/-tg-station","forks_url":"https://api.github.com/repos/bgobandit/-tg-station/forks","keys_url":"https://api.github.com/repos/bgobandit/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgobandit/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgobandit/-tg-station/teams","hooks_url":"https://api.github.com/repos/bgobandit/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/bgobandit/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/bgobandit/-tg-station/events","assignees_url":"https://api.github.com/repos/bgobandit/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/bgobandit/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/bgobandit/-tg-station/tags","blobs_url":"https://api.github.com/repos/bgobandit/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgobandit/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgobandit/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgobandit/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgobandit/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/bgobandit/-tg-station/languages","stargazers_url":"https://api.github.com/repos/bgobandit/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/bgobandit/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/bgobandit/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/bgobandit/-tg-station/subscription","commits_url":"https://api.github.com/repos/bgobandit/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgobandit/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgobandit/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgobandit/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgobandit/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/bgobandit/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgobandit/-tg-station/merges","archive_url":"https://api.github.com/repos/bgobandit/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgobandit/-tg-station/downloads","issues_url":"https://api.github.com/repos/bgobandit/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/bgobandit/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/bgobandit/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/bgobandit/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgobandit/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/bgobandit/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/bgobandit/-tg-station/deployments","created_at":"2015-07-22T12:32:51Z","updated_at":"2016-05-07T05:29:56Z","pushed_at":"2017-03-04T18:48:04Z","git_url":"git://github.com/bgobandit/-tg-station.git","ssh_url":"git@github.com:bgobandit/-tg-station.git","clone_url":"https://github.com/bgobandit/-tg-station.git","svn_url":"https://github.com/bgobandit/-tg-station","homepage":"http://www.tgstation13.org/","size":778480,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"e55b7e55c33aa766414e4b42dcebcd24fdfa479b","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2017-03-06T14:23:05Z","pushed_at":"2017-03-07T21:27:54Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":783055,"stargazers_count":363,"watchers_count":363,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1311,"mirror_url":null,"open_issues_count":826,"forks":1311,"open_issues":826,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/24495"},"html":{"href":"https://github.com/tgstation/tgstation/pull/24495"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/24495"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/24495/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/24495/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/24495/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/16b1f3c8b8100aba4da3f0796468f54e51f55cb8"}}}}
{"actor":{"display_login":"optimumtact"}}