{"action":"created","comment":{"url":"https://api.github.com/repos/istio/api/pulls/comments/156456580","pull_request_review_id":82936430,"id":156456580,"diff_hunk":"@@ -131,6 +133,13 @@ message RouteRule {\n \n   // A list of routes for TCP traffic.\n   repeated TCPRoute tcp = 4;\n+\n+  // Extensions contain sidecar implementation specific configuration, that\n+  // cannot be easily expressed through the routing rule feature\n+  // set. Custom sidecar implementations could have enhancements such as\n+  // caching, dynamic scripting, etc. The configuration for such features\n+  // could be provided through the extensions mechanism.\n+  repeated google.protobuf.Any extensions = 5;","path":"routing/v1alpha2/route_rule.proto","position":19,"original_position":19,"commit_id":"daaf437d712ce10382ebea799c29a5db725df1ff","original_commit_id":"daaf437d712ce10382ebea799c29a5db725df1ff","user":{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},"body":"So something like:\r\n\r\n```proto\r\nmessage Extension {\r\n  FieldMask mask = 1;\r\n  google.protobuf.Any body = 2;\r\n}\r\nrepeated Extension extensions = 5;\r\n```","created_at":"2017-12-12T18:36:49Z","updated_at":"2017-12-12T18:36:49Z","html_url":"https://github.com/istio/api/pull/272#discussion_r156456580","pull_request_url":"https://api.github.com/repos/istio/api/pulls/272","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/comments/156456580"},"html":{"href":"https://github.com/istio/api/pull/272#discussion_r156456580"},"pull_request":{"href":"https://api.github.com/repos/istio/api/pulls/272"}},"in_reply_to_id":156456256},"pull_request":{"url":"https://api.github.com/repos/istio/api/pulls/272","id":157732986,"html_url":"https://github.com/istio/api/pull/272","diff_url":"https://github.com/istio/api/pull/272.diff","patch_url":"https://github.com/istio/api/pull/272.patch","issue_url":"https://api.github.com/repos/istio/api/issues/272","number":272,"state":"open","locked":false,"title":"filter extensions for Envoy","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"Allow extending the proxy configuration with proxy-specific extensions through route rules.","created_at":"2017-12-12T04:12:44Z","updated_at":"2017-12-12T18:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea9a5abaada4b302be63f37d7f0d69112333ffbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars2.githubusercontent.com/u/9046588?v=4","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/api/pulls/272/commits","review_comments_url":"https://api.github.com/repos/istio/api/pulls/272/comments","review_comment_url":"https://api.github.com/repos/istio/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/api/issues/272/comments","statuses_url":"https://api.github.com/repos/istio/api/statuses/daaf437d712ce10382ebea799c29a5db725df1ff","head":{"label":"istio:filters","ref":"filters","sha":"daaf437d712ce10382ebea799c29a5db725df1ff","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config definitions and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2017-12-08T02:58:07Z","pushed_at":"2017-12-12T17:50:10Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":773,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":49,"open_issues":26,"watchers":32,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"7eada3328902f774d1bb27c01ded291ce544aeeb","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config definitions and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2017-12-08T02:58:07Z","pushed_at":"2017-12-12T17:50:10Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":773,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":49,"open_issues":26,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/272"},"html":{"href":"https://github.com/istio/api/pull/272"},"issue":{"href":"https://api.github.com/repos/istio/api/issues/272"},"comments":{"href":"https://api.github.com/repos/istio/api/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/api/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/api/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/istio/api/statuses/daaf437d712ce10382ebea799c29a5db725df1ff"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ZackButcher"}}