{"action":"closed","number":125,"pull_request":{"url":"https://api.github.com/repos/neo-project/neo/pulls/125","id":157468168,"html_url":"https://github.com/neo-project/neo/pull/125","diff_url":"https://github.com/neo-project/neo/pull/125.diff","patch_url":"https://github.com/neo-project/neo/pull/125.patch","issue_url":"https://api.github.com/repos/neo-project/neo/issues/125","number":125,"state":"closed","locked":false,"title":"Use RNGCryptoServiceProvider for nonce","user":{"login":"ambethia","id":298,"avatar_url":"https://avatars0.githubusercontent.com/u/298?v=4","gravatar_id":"","url":"https://api.github.com/users/ambethia","html_url":"https://github.com/ambethia","followers_url":"https://api.github.com/users/ambethia/followers","following_url":"https://api.github.com/users/ambethia/following{/other_user}","gists_url":"https://api.github.com/users/ambethia/gists{/gist_id}","starred_url":"https://api.github.com/users/ambethia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambethia/subscriptions","organizations_url":"https://api.github.com/users/ambethia/orgs","repos_url":"https://api.github.com/users/ambethia/repos","events_url":"https://api.github.com/users/ambethia/events{/privacy}","received_events_url":"https://api.github.com/users/ambethia/received_events","type":"User","site_admin":false},"body":"... to provide a stronger nonce for blocks.\r\n\r\nI'm not sure if we're using just `System.Random` for performance reasons, but it seems prudent to use a cryptographically secure RNG here.\r\n","created_at":"2017-12-11T02:46:20Z","updated_at":"2017-12-13T03:38:18Z","closed_at":"2017-12-13T03:38:18Z","merged_at":null,"merge_commit_sha":"105cecc2dd7ee5fea8067e7416a262ef4c4d07ee","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo-project/neo/pulls/125/commits","review_comments_url":"https://api.github.com/repos/neo-project/neo/pulls/125/comments","review_comment_url":"https://api.github.com/repos/neo-project/neo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo-project/neo/issues/125/comments","statuses_url":"https://api.github.com/repos/neo-project/neo/statuses/4444996e7f10320fd299b8ae86c5879a8c5656f3","head":{"label":"ambethia:secure-random","ref":"secure-random","sha":"4444996e7f10320fd299b8ae86c5879a8c5656f3","user":{"login":"ambethia","id":298,"avatar_url":"https://avatars0.githubusercontent.com/u/298?v=4","gravatar_id":"","url":"https://api.github.com/users/ambethia","html_url":"https://github.com/ambethia","followers_url":"https://api.github.com/users/ambethia/followers","following_url":"https://api.github.com/users/ambethia/following{/other_user}","gists_url":"https://api.github.com/users/ambethia/gists{/gist_id}","starred_url":"https://api.github.com/users/ambethia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambethia/subscriptions","organizations_url":"https://api.github.com/users/ambethia/orgs","repos_url":"https://api.github.com/users/ambethia/repos","events_url":"https://api.github.com/users/ambethia/events{/privacy}","received_events_url":"https://api.github.com/users/ambethia/received_events","type":"User","site_admin":false},"repo":{"id":113803766,"name":"neo","full_name":"ambethia/neo","owner":{"login":"ambethia","id":298,"avatar_url":"https://avatars0.githubusercontent.com/u/298?v=4","gravatar_id":"","url":"https://api.github.com/users/ambethia","html_url":"https://github.com/ambethia","followers_url":"https://api.github.com/users/ambethia/followers","following_url":"https://api.github.com/users/ambethia/following{/other_user}","gists_url":"https://api.github.com/users/ambethia/gists{/gist_id}","starred_url":"https://api.github.com/users/ambethia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambethia/subscriptions","organizations_url":"https://api.github.com/users/ambethia/orgs","repos_url":"https://api.github.com/users/ambethia/repos","events_url":"https://api.github.com/users/ambethia/events{/privacy}","received_events_url":"https://api.github.com/users/ambethia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ambethia/neo","description":"NEO Smart Economy","fork":true,"url":"https://api.github.com/repos/ambethia/neo","forks_url":"https://api.github.com/repos/ambethia/neo/forks","keys_url":"https://api.github.com/repos/ambethia/neo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambethia/neo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambethia/neo/teams","hooks_url":"https://api.github.com/repos/ambethia/neo/hooks","issue_events_url":"https://api.github.com/repos/ambethia/neo/issues/events{/number}","events_url":"https://api.github.com/repos/ambethia/neo/events","assignees_url":"https://api.github.com/repos/ambethia/neo/assignees{/user}","branches_url":"https://api.github.com/repos/ambethia/neo/branches{/branch}","tags_url":"https://api.github.com/repos/ambethia/neo/tags","blobs_url":"https://api.github.com/repos/ambethia/neo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambethia/neo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambethia/neo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambethia/neo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambethia/neo/statuses/{sha}","languages_url":"https://api.github.com/repos/ambethia/neo/languages","stargazers_url":"https://api.github.com/repos/ambethia/neo/stargazers","contributors_url":"https://api.github.com/repos/ambethia/neo/contributors","subscribers_url":"https://api.github.com/repos/ambethia/neo/subscribers","subscription_url":"https://api.github.com/repos/ambethia/neo/subscription","commits_url":"https://api.github.com/repos/ambethia/neo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambethia/neo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambethia/neo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambethia/neo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambethia/neo/contents/{+path}","compare_url":"https://api.github.com/repos/ambethia/neo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambethia/neo/merges","archive_url":"https://api.github.com/repos/ambethia/neo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambethia/neo/downloads","issues_url":"https://api.github.com/repos/ambethia/neo/issues{/number}","pulls_url":"https://api.github.com/repos/ambethia/neo/pulls{/number}","milestones_url":"https://api.github.com/repos/ambethia/neo/milestones{/number}","notifications_url":"https://api.github.com/repos/ambethia/neo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambethia/neo/labels{/name}","releases_url":"https://api.github.com/repos/ambethia/neo/releases{/id}","deployments_url":"https://api.github.com/repos/ambethia/neo/deployments","created_at":"2017-12-11T02:40:03Z","updated_at":"2017-12-11T02:40:05Z","pushed_at":"2017-12-11T02:41:56Z","git_url":"git://github.com/ambethia/neo.git","ssh_url":"git@github.com:ambethia/neo.git","clone_url":"https://github.com/ambethia/neo.git","svn_url":"https://github.com/ambethia/neo","homepage":"","size":2466,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo-project:master","ref":"master","sha":"b3b195e76c36b1a27318161cff2e53dcb9685ece","user":{"login":"neo-project","id":12685221,"avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36613036,"name":"neo","full_name":"neo-project/neo","owner":{"login":"neo-project","id":12685221,"avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo-project/neo","description":"NEO Smart Economy","fork":false,"url":"https://api.github.com/repos/neo-project/neo","forks_url":"https://api.github.com/repos/neo-project/neo/forks","keys_url":"https://api.github.com/repos/neo-project/neo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo-project/neo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo-project/neo/teams","hooks_url":"https://api.github.com/repos/neo-project/neo/hooks","issue_events_url":"https://api.github.com/repos/neo-project/neo/issues/events{/number}","events_url":"https://api.github.com/repos/neo-project/neo/events","assignees_url":"https://api.github.com/repos/neo-project/neo/assignees{/user}","branches_url":"https://api.github.com/repos/neo-project/neo/branches{/branch}","tags_url":"https://api.github.com/repos/neo-project/neo/tags","blobs_url":"https://api.github.com/repos/neo-project/neo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo-project/neo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo-project/neo/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo-project/neo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo-project/neo/statuses/{sha}","languages_url":"https://api.github.com/repos/neo-project/neo/languages","stargazers_url":"https://api.github.com/repos/neo-project/neo/stargazers","contributors_url":"https://api.github.com/repos/neo-project/neo/contributors","subscribers_url":"https://api.github.com/repos/neo-project/neo/subscribers","subscription_url":"https://api.github.com/repos/neo-project/neo/subscription","commits_url":"https://api.github.com/repos/neo-project/neo/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo-project/neo/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo-project/neo/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo-project/neo/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo-project/neo/contents/{+path}","compare_url":"https://api.github.com/repos/neo-project/neo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo-project/neo/merges","archive_url":"https://api.github.com/repos/neo-project/neo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo-project/neo/downloads","issues_url":"https://api.github.com/repos/neo-project/neo/issues{/number}","pulls_url":"https://api.github.com/repos/neo-project/neo/pulls{/number}","milestones_url":"https://api.github.com/repos/neo-project/neo/milestones{/number}","notifications_url":"https://api.github.com/repos/neo-project/neo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo-project/neo/labels{/name}","releases_url":"https://api.github.com/repos/neo-project/neo/releases{/id}","deployments_url":"https://api.github.com/repos/neo-project/neo/deployments","created_at":"2015-05-31T17:02:33Z","updated_at":"2017-12-13T03:08:20Z","pushed_at":"2017-12-12T12:46:58Z","git_url":"git://github.com/neo-project/neo.git","ssh_url":"git@github.com:neo-project/neo.git","clone_url":"https://github.com/neo-project/neo.git","svn_url":"https://github.com/neo-project/neo","homepage":"","size":2442,"stargazers_count":1235,"watchers_count":1235,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":401,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":401,"open_issues":13,"watchers":1235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo-project/neo/pulls/125"},"html":{"href":"https://github.com/neo-project/neo/pull/125"},"issue":{"href":"https://api.github.com/repos/neo-project/neo/issues/125"},"comments":{"href":"https://api.github.com/repos/neo-project/neo/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/neo-project/neo/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/neo-project/neo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo-project/neo/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/neo-project/neo/statuses/4444996e7f10320fd299b8ae86c5879a8c5656f3"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"erikzhang"}}