{"action":"created","issue":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/726","repository_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service","labels_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/726/comments","events_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/726/events","html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/726","id":215317610,"number":726,"title":"[WIP] Transition over to dotnet cli Fsproj","user":{"login":"baronfel","id":573979,"avatar_url":"https://avatars0.githubusercontent.com/u/573979?v=3","gravatar_id":"","url":"https://api.github.com/users/baronfel","html_url":"https://github.com/baronfel","followers_url":"https://api.github.com/users/baronfel/followers","following_url":"https://api.github.com/users/baronfel/following{/other_user}","gists_url":"https://api.github.com/users/baronfel/gists{/gist_id}","starred_url":"https://api.github.com/users/baronfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baronfel/subscriptions","organizations_url":"https://api.github.com/users/baronfel/orgs","repos_url":"https://api.github.com/users/baronfel/repos","events_url":"https://api.github.com/users/baronfel/events{/privacy}","received_events_url":"https://api.github.com/users/baronfel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2017-03-20T02:24:44Z","updated_at":"2017-03-28T02:03:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/726","html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/726","diff_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/726.diff","patch_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/726.patch"},"body":"This PR begins to address #700 by migrating existing project.json projects to the new fsproj.  It explicitly does not attempt to merge the full-framework and dotnetcore build yet, in the interested of smaller, more manageable changes.  It also doesn't attempt to unify nuget usage under Paket due to an outstanding bug with Paket and the `pack` command.\r\n\r\nI took the approach of duplicating folders with the new fsproj files in them because the dotnet cli commands didn't always allow for choosing a specific project file with each command.  eg `restore` and `pack` work with a specific project file, but not `fssrgen`.\r\n\r\nThis PR is currently not complete because FSharp.Compiler.Service.netcore isn't building.  the log is very long but at the moment seems to revolve around the resource accessor for `FSComp` not being compiled correctly somehow.  I thought that embedding the resource would generate the matching strongly-typed accessor classes, but no such luck."},"comment":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/comments/289640300","html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/726#issuecomment-289640300","issue_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/726","id":289640300,"user":{"login":"baronfel","id":573979,"avatar_url":"https://avatars0.githubusercontent.com/u/573979?v=3","gravatar_id":"","url":"https://api.github.com/users/baronfel","html_url":"https://github.com/baronfel","followers_url":"https://api.github.com/users/baronfel/followers","following_url":"https://api.github.com/users/baronfel/following{/other_user}","gists_url":"https://api.github.com/users/baronfel/gists{/gist_id}","starred_url":"https://api.github.com/users/baronfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baronfel/subscriptions","organizations_url":"https://api.github.com/users/baronfel/orgs","repos_url":"https://api.github.com/users/baronfel/repos","events_url":"https://api.github.com/users/baronfel/events{/privacy}","received_events_url":"https://api.github.com/users/baronfel/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T02:03:31Z","updated_at":"2017-03-28T02:03:31Z","body":"@enricosada any idea on `dotnet-mergenupkg`? I've not use that command before: \r\n```\r\nStarting Target: Nuget.AddNetCore (==> All.NetCore, NuGet.NetFx)\r\nsrc/fsharp/FSharp.Compiler.Service/dotnet mergenupkg --source ../../../bin/FSharp.Compiler.Service.11.0.8.nupkg --other bin/Release/FSharp.Compiler.Service.11.0.8.nupkg --framework netstandard1.6\r\nUnhandled Exception: System.InvalidOperationException: Specify which project file to use because this 'C:\\projects\\fsharp-compiler-service\\src\\fsharp\\FSharp.Compiler.Service' contains more than one project file.\r\n   at Microsoft.DotNet.Cli.Utils.ProjectFactory.GetMSBuildProjPath(String projectDirectory)\r\n   at Microsoft.DotNet.Cli.Utils.ProjectFactory.GetMSBuildProj(String projectDirectory, NuGetFramework framework, String configuration, String outputPath)\r\n   at Microsoft.DotNet.Cli.Utils.ProjectToolsCommandResolver.ResolveFromProjectTools(CommandResolverArguments commandResolverArguments)\r\n   at Microsoft.DotNet.Cli.Utils.ProjectToolsCommandResolver.Resolve(CommandResolverArguments commandResolverArguments)\r\n   at Microsoft.DotNet.Cli.Utils.CompositeCommandResolver.Resolve(CommandResolverArguments commandResolverArguments)\r\n   at Microsoft.DotNet.Cli.Utils.CommandResolver.TryResolveCommandSpec(ICommandResolverPolicy commandResolverPolicy, String commandName, IEnumerable`1 args, NuGetFramework framework, String configuration, String outputPath, String applicationName)\r\n   at Microsoft.DotNet.Cli.Utils.Command.Create(ICommandResolverPolicy commandResolverPolicy, String commandName, IEnumerable`1 args, NuGetFramework framework, String configuration, String outputPath, String applicationName)\r\n   at Microsoft.DotNet.Cli.Utils.Command.Create(String commandName, IEnumerable`1 args, NuGetFramework framework, String configuration, String outputPath, String applicationName)\r\n   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient)\r\n   at Microsoft.DotNet.Cli.Program.Main(String[] args)\r\n```"}}
{"actor":{"display_login":"baronfel"}}