{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments/157204014","pull_request_review_id":83812129,"id":157204014,"diff_hunk":"@@ -1340,12 +1340,11 @@ namespace Opm {\n                 // Volume factors, densities and viscosities need to be recalculated with the updated rs and rv values.\n                 if (ebosSimulator_.episodeIndex() < 0 && vapour_active && liquid_active ) {\n \n-                    typedef Opm::CompositionalFluidState<Scalar, FluidSystem> ScalarFluidState;\n-                    const ScalarFluidState& fs_updated = ebosSimulator().problem().initialFluidState(cellIdx);\n+                    const auto& fs_updated = ebosSimulator().problem().initialFluidState(cellIdx);\n \n                     // use initial rs and rv values\n-                    Rv[cellIdx] = Opm::BlackOil::getRv_<FluidSystem, Scalar, ScalarFluidState>(fs_updated,  intQuants.pvtRegionIndex());","path":"opm/autodiff/BlackoilModelEbos.hpp","position":9,"original_position":9,"commit_id":"7567748f2d71c01044ec4d2cd901770d8cf101ac","original_commit_id":"7567748f2d71c01044ec4d2cd901770d8cf101ac","user":{"login":"andlaus","id":1837735,"avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"I agree and I intend to merge as soon as Jenkins is happy. without this change, this PR does not need to wait for the eWoms one anymore, though...","created_at":"2017-12-15T13:47:01Z","updated_at":"2017-12-15T13:47:01Z","html_url":"https://github.com/OPM/opm-simulators/pull/1373#discussion_r157204014","pull_request_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments/157204014"},"html":{"href":"https://github.com/OPM/opm-simulators/pull/1373#discussion_r157204014"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373"}},"in_reply_to_id":157201744},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373","id":158592507,"html_url":"https://github.com/OPM/opm-simulators/pull/1373","diff_url":"https://github.com/OPM/opm-simulators/pull/1373.diff","patch_url":"https://github.com/OPM/opm-simulators/pull/1373.patch","issue_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1373","number":1373,"state":"open","locked":false,"title":"Adapt to changed initial FluidState type in ebos","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars1.githubusercontent.com/u/3223024?v=4","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"body":"Merged together with OPM/ewoms#253","created_at":"2017-12-15T12:29:01Z","updated_at":"2017-12-15T13:47:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ed2de4113cdbef14f0bf0d23cd5c130cb78293a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1373/comments","statuses_url":"https://api.github.com/repos/OPM/opm-simulators/statuses/7567748f2d71c01044ec4d2cd901770d8cf101ac","head":{"label":"totto82:useBlackoilFluidState","ref":"useBlackoilFluidState","sha":"7567748f2d71c01044ec4d2cd901770d8cf101ac","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars1.githubusercontent.com/u/3223024?v=4","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"repo":{"id":10097626,"name":"opm-simulators","full_name":"totto82/opm-simulators","owner":{"login":"totto82","id":3223024,"avatar_url":"https://avatars1.githubusercontent.com/u/3223024?v=4","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/totto82/opm-simulators","description":"Utilities for automatic differentiation and simulators based on AD.","fork":true,"url":"https://api.github.com/repos/totto82/opm-simulators","forks_url":"https://api.github.com/repos/totto82/opm-simulators/forks","keys_url":"https://api.github.com/repos/totto82/opm-simulators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/totto82/opm-simulators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/totto82/opm-simulators/teams","hooks_url":"https://api.github.com/repos/totto82/opm-simulators/hooks","issue_events_url":"https://api.github.com/repos/totto82/opm-simulators/issues/events{/number}","events_url":"https://api.github.com/repos/totto82/opm-simulators/events","assignees_url":"https://api.github.com/repos/totto82/opm-simulators/assignees{/user}","branches_url":"https://api.github.com/repos/totto82/opm-simulators/branches{/branch}","tags_url":"https://api.github.com/repos/totto82/opm-simulators/tags","blobs_url":"https://api.github.com/repos/totto82/opm-simulators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/totto82/opm-simulators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/totto82/opm-simulators/git/refs{/sha}","trees_url":"https://api.github.com/repos/totto82/opm-simulators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/totto82/opm-simulators/statuses/{sha}","languages_url":"https://api.github.com/repos/totto82/opm-simulators/languages","stargazers_url":"https://api.github.com/repos/totto82/opm-simulators/stargazers","contributors_url":"https://api.github.com/repos/totto82/opm-simulators/contributors","subscribers_url":"https://api.github.com/repos/totto82/opm-simulators/subscribers","subscription_url":"https://api.github.com/repos/totto82/opm-simulators/subscription","commits_url":"https://api.github.com/repos/totto82/opm-simulators/commits{/sha}","git_commits_url":"https://api.github.com/repos/totto82/opm-simulators/git/commits{/sha}","comments_url":"https://api.github.com/repos/totto82/opm-simulators/comments{/number}","issue_comment_url":"https://api.github.com/repos/totto82/opm-simulators/issues/comments{/number}","contents_url":"https://api.github.com/repos/totto82/opm-simulators/contents/{+path}","compare_url":"https://api.github.com/repos/totto82/opm-simulators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/totto82/opm-simulators/merges","archive_url":"https://api.github.com/repos/totto82/opm-simulators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/totto82/opm-simulators/downloads","issues_url":"https://api.github.com/repos/totto82/opm-simulators/issues{/number}","pulls_url":"https://api.github.com/repos/totto82/opm-simulators/pulls{/number}","milestones_url":"https://api.github.com/repos/totto82/opm-simulators/milestones{/number}","notifications_url":"https://api.github.com/repos/totto82/opm-simulators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/totto82/opm-simulators/labels{/name}","releases_url":"https://api.github.com/repos/totto82/opm-simulators/releases{/id}","deployments_url":"https://api.github.com/repos/totto82/opm-simulators/deployments","created_at":"2013-05-16T09:04:45Z","updated_at":"2016-10-24T12:24:00Z","pushed_at":"2017-12-15T07:21:33Z","git_url":"git://github.com/totto82/opm-simulators.git","ssh_url":"git@github.com:totto82/opm-simulators.git","clone_url":"https://github.com/totto82/opm-simulators.git","svn_url":"https://github.com/totto82/opm-simulators","homepage":null,"size":9963,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"0b6ac6c87b121d3647101d66cc0ef454743947cb","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":10097543,"name":"opm-simulators","full_name":"OPM/opm-simulators","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-simulators","description":"Simulator programs and utilities for automatic differentiation.","fork":false,"url":"https://api.github.com/repos/OPM/opm-simulators","forks_url":"https://api.github.com/repos/OPM/opm-simulators/forks","keys_url":"https://api.github.com/repos/OPM/opm-simulators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-simulators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-simulators/teams","hooks_url":"https://api.github.com/repos/OPM/opm-simulators/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-simulators/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-simulators/events","assignees_url":"https://api.github.com/repos/OPM/opm-simulators/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-simulators/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-simulators/tags","blobs_url":"https://api.github.com/repos/OPM/opm-simulators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-simulators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-simulators/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-simulators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-simulators/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-simulators/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-simulators/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-simulators/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-simulators/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-simulators/subscription","commits_url":"https://api.github.com/repos/OPM/opm-simulators/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-simulators/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-simulators/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-simulators/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-simulators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-simulators/merges","archive_url":"https://api.github.com/repos/OPM/opm-simulators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-simulators/downloads","issues_url":"https://api.github.com/repos/OPM/opm-simulators/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-simulators/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-simulators/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-simulators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-simulators/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-simulators/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/opm-simulators/deployments","created_at":"2013-05-16T08:59:22Z","updated_at":"2017-12-14T16:02:23Z","pushed_at":"2017-12-15T12:42:44Z","git_url":"git://github.com/OPM/opm-simulators.git","ssh_url":"git@github.com:OPM/opm-simulators.git","clone_url":"https://github.com/OPM/opm-simulators.git","svn_url":"https://github.com/OPM/opm-simulators","homepage":"http://www.opm-project.org","size":9887,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":59,"license":null,"forks":47,"open_issues":59,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373"},"html":{"href":"https://github.com/OPM/opm-simulators/pull/1373"},"issue":{"href":"https://api.github.com/repos/OPM/opm-simulators/issues/1373"},"comments":{"href":"https://api.github.com/repos/OPM/opm-simulators/issues/1373/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/1373/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-simulators/statuses/7567748f2d71c01044ec4d2cd901770d8cf101ac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andlaus"}}