{"action":"created","issue":{"url":"https://api.github.com/repos/adzialocha/osc-js/issues/4","repository_url":"https://api.github.com/repos/adzialocha/osc-js","labels_url":"https://api.github.com/repos/adzialocha/osc-js/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/adzialocha/osc-js/issues/4/comments","events_url":"https://api.github.com/repos/adzialocha/osc-js/issues/4/events","html_url":"https://github.com/adzialocha/osc-js/issues/4","id":213181369,"number":4,"title":"Can't send message with value of 0","user":{"login":"maxjoehnk","id":1153569,"avatar_url":"https://avatars1.githubusercontent.com/u/1153569?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjoehnk","html_url":"https://github.com/maxjoehnk","followers_url":"https://api.github.com/users/maxjoehnk/followers","following_url":"https://api.github.com/users/maxjoehnk/following{/other_user}","gists_url":"https://api.github.com/users/maxjoehnk/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjoehnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjoehnk/subscriptions","organizations_url":"https://api.github.com/users/maxjoehnk/orgs","repos_url":"https://api.github.com/users/maxjoehnk/repos","events_url":"https://api.github.com/users/maxjoehnk/events{/privacy}","received_events_url":"https://api.github.com/users/maxjoehnk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-09T22:10:37Z","updated_at":"2017-03-09T22:24:43Z","closed_at":null,"body":"```\r\n    if (!this.value) {\r\n      throw new Error('OSC Atomic cant\\'t be encoded with empty value')\r\n    }\r\n```\r\n\r\nThis check throws when there are falsy values (like 0).\r\nThis should either check for null or undefined values which would also allow empty strings or maybe use a separate function like `isEmpty(value): boolean` which can be overridden.\r\n\r\nWhat do you think? I can create a pull request with a fix if you want."},"comment":{"url":"https://api.github.com/repos/adzialocha/osc-js/issues/comments/285503235","html_url":"https://github.com/adzialocha/osc-js/issues/4#issuecomment-285503235","issue_url":"https://api.github.com/repos/adzialocha/osc-js/issues/4","id":285503235,"user":{"login":"adzialocha","id":1822473,"avatar_url":"https://avatars0.githubusercontent.com/u/1822473?v=3","gravatar_id":"","url":"https://api.github.com/users/adzialocha","html_url":"https://github.com/adzialocha","followers_url":"https://api.github.com/users/adzialocha/followers","following_url":"https://api.github.com/users/adzialocha/following{/other_user}","gists_url":"https://api.github.com/users/adzialocha/gists{/gist_id}","starred_url":"https://api.github.com/users/adzialocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adzialocha/subscriptions","organizations_url":"https://api.github.com/users/adzialocha/orgs","repos_url":"https://api.github.com/users/adzialocha/repos","events_url":"https://api.github.com/users/adzialocha/events{/privacy}","received_events_url":"https://api.github.com/users/adzialocha/received_events","type":"User","site_admin":false},"created_at":"2017-03-09T22:24:43Z","updated_at":"2017-03-09T22:24:43Z","body":"@maxjoehnk thank you for spotting this! I added a test to check against these cases and fixed the problem with an own helper method as you suggested."}}
{"actor":{"display_login":"adzialocha"}}