{"action":"created","comment":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/131531535","pull_request_review_id":54524568,"id":131531535,"diff_hunk":"@@ -90,38 +84,36 @@ class TestGroResidWrapping(object):\n     lengths = [19, 24, 19, 19, 19, 19, 7]\n     parser = mda.topology.GROParser.GROParser\n \n+    @pytest.mark.parametrize('parser, resids', (\n+        (GRO_residwrap, [1, 99999, 100000, 100001, 199999, 200000, 200001]),\n+        (GRO_residwrap_0base, [0, 99999, 100000, 100001, 199999, 200000,\n+                               200001])\n \n-    def test_wrapping_resids(self):\n-        parser = mda.topology.GROParser.GROParser\n-        with self.parser(GRO_residwrap) as p:\n+    ))\n+    def test_wrapping_resids(self, parser, resids):\n+        with self.parser(parser) as p:\n             top = p.parse()\n \n-        resids = [1, 99999, 100000, 100001, 199999, 200000, 200001]\n-\n-        assert_(top.tt.size == (126, 7, 1))\n+        assert top.tt.size == (126, 7, 1)\n         for i, (r, n, l) in enumerate(zip(resids, self.names, self.lengths)):\n-            assert_(top.resids.values[i] == r)\n-            assert_(top.resnames.values[i] == n)\n-            assert_(len(top.tt.residues2atoms_1d([i])) == l)\n+            assert top.resids.values[i] == r\n+            assert top.resnames.values[i] == n\n+            assert len(top.tt.residues2atoms_1d([i])) == l\n \n-    def test_wrapping_resids_0base(self):\n-        with self.parser(GRO_residwrap_0base) as p:\n-            top = p.parse()\n-\n-        resids = [0, 99999, 100000, 100001, 199999, 200000, 200001]\n \n-        assert_(top.tt.size == (126, 7, 1))\n-        for i, (r, n, l) in enumerate(zip(resids, self.names, self.lengths)):\n-            assert_(top.resids.values[i] == r)\n-            assert_(top.resnames.values[i] == n)\n-            assert_(len(top.tt.residues2atoms_1d([i])) == l)\n+RESIDS = [9, 9]\n+RESNAMES = ['GLN', 'POPC']\n \n-def test_sameresid_diffresname():\n+@pytest.mark.parametrize(","path":"testsuite/MDAnalysisTests/topology/test_gro.py","position":89,"original_position":89,"commit_id":"d4705e824484da79d89545e6bc598336f06bc80c","original_commit_id":"d4705e824484da79d89545e6bc598336f06bc80c","user":{"login":"richardjgowers","id":9249543,"avatar_url":"https://avatars1.githubusercontent.com/u/9249543?v=4","gravatar_id":"","url":"https://api.github.com/users/richardjgowers","html_url":"https://github.com/richardjgowers","followers_url":"https://api.github.com/users/richardjgowers/followers","following_url":"https://api.github.com/users/richardjgowers/following{/other_user}","gists_url":"https://api.github.com/users/richardjgowers/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjgowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjgowers/subscriptions","organizations_url":"https://api.github.com/users/richardjgowers/orgs","repos_url":"https://api.github.com/users/richardjgowers/repos","events_url":"https://api.github.com/users/richardjgowers/events{/privacy}","received_events_url":"https://api.github.com/users/richardjgowers/received_events","type":"User","site_admin":false},"body":"this doesn't really need to be parametrized, it all tests the same thing, rather than different cases of something","created_at":"2017-08-05T23:31:03Z","updated_at":"2017-08-05T23:31:03Z","html_url":"https://github.com/MDAnalysis/mdanalysis/pull/1590#discussion_r131531535","pull_request_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590","_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/131531535"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/1590#discussion_r131531535"},"pull_request":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590"}}},"pull_request":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590","id":134289386,"html_url":"https://github.com/MDAnalysis/mdanalysis/pull/1590","diff_url":"https://github.com/MDAnalysis/mdanalysis/pull/1590.diff","patch_url":"https://github.com/MDAnalysis/mdanalysis/pull/1590.patch","issue_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1590","number":1590,"state":"open","locked":false,"title":"[Review Needed]Pytest Style topology/test_gro.py","user":{"login":"utkbansal","id":8345336,"avatar_url":"https://avatars2.githubusercontent.com/u/8345336?v=4","gravatar_id":"","url":"https://api.github.com/users/utkbansal","html_url":"https://github.com/utkbansal","followers_url":"https://api.github.com/users/utkbansal/followers","following_url":"https://api.github.com/users/utkbansal/following{/other_user}","gists_url":"https://api.github.com/users/utkbansal/gists{/gist_id}","starred_url":"https://api.github.com/users/utkbansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utkbansal/subscriptions","organizations_url":"https://api.github.com/users/utkbansal/orgs","repos_url":"https://api.github.com/users/utkbansal/repos","events_url":"https://api.github.com/users/utkbansal/events{/privacy}","received_events_url":"https://api.github.com/users/utkbansal/received_events","type":"User","site_admin":false},"body":"Fixes #\r\n\r\nChanges made in this Pull Request:\r\n - \r\n\r\n\r\nPR Checklist\r\n------------\r\n - [ ] Tests?\r\n - [ ] Docs?\r\n - [ ] CHANGELOG updated?\r\n - [ ] Issue raised/referenced?\r\n","created_at":"2017-08-05T11:42:41Z","updated_at":"2017-08-05T23:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"043b52509edaab3039f4a3cfbc08eeff760acd90","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590/commits","review_comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590/comments","review_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1590/comments","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/d4705e824484da79d89545e6bc598336f06bc80c","head":{"label":"utkbansal:topology-gro","ref":"topology-gro","sha":"d4705e824484da79d89545e6bc598336f06bc80c","user":{"login":"utkbansal","id":8345336,"avatar_url":"https://avatars2.githubusercontent.com/u/8345336?v=4","gravatar_id":"","url":"https://api.github.com/users/utkbansal","html_url":"https://github.com/utkbansal","followers_url":"https://api.github.com/users/utkbansal/followers","following_url":"https://api.github.com/users/utkbansal/following{/other_user}","gists_url":"https://api.github.com/users/utkbansal/gists{/gist_id}","starred_url":"https://api.github.com/users/utkbansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utkbansal/subscriptions","organizations_url":"https://api.github.com/users/utkbansal/orgs","repos_url":"https://api.github.com/users/utkbansal/repos","events_url":"https://api.github.com/users/utkbansal/events{/privacy}","received_events_url":"https://api.github.com/users/utkbansal/received_events","type":"User","site_admin":false},"repo":{"id":79150836,"name":"mdanalysis","full_name":"utkbansal/mdanalysis","owner":{"login":"utkbansal","id":8345336,"avatar_url":"https://avatars2.githubusercontent.com/u/8345336?v=4","gravatar_id":"","url":"https://api.github.com/users/utkbansal","html_url":"https://github.com/utkbansal","followers_url":"https://api.github.com/users/utkbansal/followers","following_url":"https://api.github.com/users/utkbansal/following{/other_user}","gists_url":"https://api.github.com/users/utkbansal/gists{/gist_id}","starred_url":"https://api.github.com/users/utkbansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utkbansal/subscriptions","organizations_url":"https://api.github.com/users/utkbansal/orgs","repos_url":"https://api.github.com/users/utkbansal/repos","events_url":"https://api.github.com/users/utkbansal/events{/privacy}","received_events_url":"https://api.github.com/users/utkbansal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/utkbansal/mdanalysis","description":"MDAnalysis is a Python library to analyze molecular dynamics trajectories.","fork":true,"url":"https://api.github.com/repos/utkbansal/mdanalysis","forks_url":"https://api.github.com/repos/utkbansal/mdanalysis/forks","keys_url":"https://api.github.com/repos/utkbansal/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utkbansal/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utkbansal/mdanalysis/teams","hooks_url":"https://api.github.com/repos/utkbansal/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/utkbansal/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/utkbansal/mdanalysis/events","assignees_url":"https://api.github.com/repos/utkbansal/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/utkbansal/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/utkbansal/mdanalysis/tags","blobs_url":"https://api.github.com/repos/utkbansal/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utkbansal/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utkbansal/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/utkbansal/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utkbansal/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/utkbansal/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/utkbansal/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/utkbansal/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/utkbansal/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/utkbansal/mdanalysis/subscription","commits_url":"https://api.github.com/repos/utkbansal/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/utkbansal/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/utkbansal/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/utkbansal/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/utkbansal/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/utkbansal/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utkbansal/mdanalysis/merges","archive_url":"https://api.github.com/repos/utkbansal/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utkbansal/mdanalysis/downloads","issues_url":"https://api.github.com/repos/utkbansal/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/utkbansal/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/utkbansal/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/utkbansal/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utkbansal/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/utkbansal/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/utkbansal/mdanalysis/deployments","created_at":"2017-01-16T19:15:36Z","updated_at":"2017-01-16T19:15:44Z","pushed_at":"2017-08-05T17:13:14Z","git_url":"git://github.com/utkbansal/mdanalysis.git","ssh_url":"git@github.com:utkbansal/mdanalysis.git","clone_url":"https://github.com/utkbansal/mdanalysis.git","svn_url":"https://github.com/utkbansal/mdanalysis","homepage":"http://www.mdanalysis.org","size":376450,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MDAnalysis:develop","ref":"develop","sha":"60d013bb8f7226e7a4273337ecd63db6807f0e79","user":{"login":"MDAnalysis","id":11445951,"avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":33389183,"name":"mdanalysis","full_name":"MDAnalysis/mdanalysis","owner":{"login":"MDAnalysis","id":11445951,"avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MDAnalysis/mdanalysis","description":"MDAnalysis is a Python library to analyze molecular dynamics trajectories.","fork":false,"url":"https://api.github.com/repos/MDAnalysis/mdanalysis","forks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/forks","keys_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/teams","hooks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/events","assignees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/tags","blobs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscription","commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/merges","archive_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/downloads","issues_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/deployments","created_at":"2015-04-04T00:39:41Z","updated_at":"2017-08-05T19:50:32Z","pushed_at":"2017-08-05T22:21:28Z","git_url":"git://github.com/MDAnalysis/mdanalysis.git","ssh_url":"git@github.com:MDAnalysis/mdanalysis.git","clone_url":"https://github.com/MDAnalysis/mdanalysis.git","svn_url":"https://github.com/MDAnalysis/mdanalysis","homepage":"http://mdanalysis.org","size":424042,"stargazers_count":138,"watchers_count":138,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":144,"forks":92,"open_issues":144,"watchers":138,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/1590"},"issue":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1590"},"comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/1590/comments"},"review_comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590/comments"},"review_comment":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/1590/commits"},"statuses":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/d4705e824484da79d89545e6bc598336f06bc80c"}}}}
{"actor":{"display_login":"richardjgowers"}}