{"action":"closed","number":390,"pull_request":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390","id":129231323,"html_url":"https://github.com/jhedstrom/drupalextension/pull/390","diff_url":"https://github.com/jhedstrom/drupalextension/pull/390.diff","patch_url":"https://github.com/jhedstrom/drupalextension/pull/390.patch","issue_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/390","number":390,"state":"closed","locked":false,"title":"DriverListener should react to ExampleTested events","user":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"body":"I discovered a big ol' bug today!\r\n\r\nDuring the environment isolation process, Behat's ContextEnvironmentHandler class will, in its isolateEnvironment() method, convert UninitializedContextEnvironment to InitializedContextEnvironment, which is necessary in order for any Drupal Extension subcontext's getContext() method to work.\r\n\r\nUnfortunately, during scenario outline tests, Drupal Extension does not pick up the new environment, so any calls to getContext() in scenario examples results in a fatal error (call to undefined getContexts() method in UninitializedContextEnvironment). This is because the OutlineTested::BEFORE event is fired *before* Behat isolates the environment.\r\n\r\nThe fix, I discovered, is for Drupal Extension's DriverListener to react to the ExampleTested::BEFORE event instead of OutlineTested::BEFORE, because ExampleTested::BEFORE is fired *after* the environment is isolated. It also is more in line with ScenarioTested::BEFORE in terms of its scope, so it's probably the more \"correct\" event to react to.","created_at":"2017-07-06T16:43:51Z","updated_at":"2017-07-06T17:24:52Z","closed_at":"2017-07-06T17:24:52Z","merged_at":"2017-07-06T17:24:52Z","merge_commit_sha":"8b9e54853698f02033d187b528693d5fac8d90ea","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/milestones/6","html_url":"https://github.com/jhedstrom/drupalextension/milestone/6","labels_url":"https://api.github.com/repos/jhedstrom/drupalextension/milestones/6/labels","id":2625778,"number":6,"title":"3.3.1 Release","description":"","creator":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars2.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2017-07-06T16:45:22Z","updated_at":"2017-07-06T17:24:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390/commits","review_comments_url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390/comments","review_comment_url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/390/comments","statuses_url":"https://api.github.com/repos/jhedstrom/drupalextension/statuses/6207246c49583441ea0baefa08d5388d826675c2","head":{"label":"phenaproxima:master","ref":"master","sha":"6207246c49583441ea0baefa08d5388d826675c2","user":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"repo":{"id":96451079,"name":"drupalextension","full_name":"phenaproxima/drupalextension","owner":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phenaproxima/drupalextension","description":"An integration layer between Behat, Mink Extension, and Drupal.","fork":true,"url":"https://api.github.com/repos/phenaproxima/drupalextension","forks_url":"https://api.github.com/repos/phenaproxima/drupalextension/forks","keys_url":"https://api.github.com/repos/phenaproxima/drupalextension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenaproxima/drupalextension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenaproxima/drupalextension/teams","hooks_url":"https://api.github.com/repos/phenaproxima/drupalextension/hooks","issue_events_url":"https://api.github.com/repos/phenaproxima/drupalextension/issues/events{/number}","events_url":"https://api.github.com/repos/phenaproxima/drupalextension/events","assignees_url":"https://api.github.com/repos/phenaproxima/drupalextension/assignees{/user}","branches_url":"https://api.github.com/repos/phenaproxima/drupalextension/branches{/branch}","tags_url":"https://api.github.com/repos/phenaproxima/drupalextension/tags","blobs_url":"https://api.github.com/repos/phenaproxima/drupalextension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenaproxima/drupalextension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenaproxima/drupalextension/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenaproxima/drupalextension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenaproxima/drupalextension/statuses/{sha}","languages_url":"https://api.github.com/repos/phenaproxima/drupalextension/languages","stargazers_url":"https://api.github.com/repos/phenaproxima/drupalextension/stargazers","contributors_url":"https://api.github.com/repos/phenaproxima/drupalextension/contributors","subscribers_url":"https://api.github.com/repos/phenaproxima/drupalextension/subscribers","subscription_url":"https://api.github.com/repos/phenaproxima/drupalextension/subscription","commits_url":"https://api.github.com/repos/phenaproxima/drupalextension/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenaproxima/drupalextension/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenaproxima/drupalextension/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenaproxima/drupalextension/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenaproxima/drupalextension/contents/{+path}","compare_url":"https://api.github.com/repos/phenaproxima/drupalextension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenaproxima/drupalextension/merges","archive_url":"https://api.github.com/repos/phenaproxima/drupalextension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenaproxima/drupalextension/downloads","issues_url":"https://api.github.com/repos/phenaproxima/drupalextension/issues{/number}","pulls_url":"https://api.github.com/repos/phenaproxima/drupalextension/pulls{/number}","milestones_url":"https://api.github.com/repos/phenaproxima/drupalextension/milestones{/number}","notifications_url":"https://api.github.com/repos/phenaproxima/drupalextension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenaproxima/drupalextension/labels{/name}","releases_url":"https://api.github.com/repos/phenaproxima/drupalextension/releases{/id}","deployments_url":"https://api.github.com/repos/phenaproxima/drupalextension/deployments","created_at":"2017-07-06T16:35:54Z","updated_at":"2017-07-06T16:35:56Z","pushed_at":"2017-07-06T17:04:20Z","git_url":"git://github.com/phenaproxima/drupalextension.git","ssh_url":"git@github.com:phenaproxima/drupalextension.git","clone_url":"https://github.com/phenaproxima/drupalextension.git","svn_url":"https://github.com/phenaproxima/drupalextension","homepage":"","size":3590,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhedstrom:master","ref":"master","sha":"197c10a8a504022b796134cd3dbbb468e6940abd","user":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars2.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"repo":{"id":6621776,"name":"drupalextension","full_name":"jhedstrom/drupalextension","owner":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars2.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhedstrom/drupalextension","description":"An integration layer between Behat, Mink Extension, and Drupal.","fork":false,"url":"https://api.github.com/repos/jhedstrom/drupalextension","forks_url":"https://api.github.com/repos/jhedstrom/drupalextension/forks","keys_url":"https://api.github.com/repos/jhedstrom/drupalextension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhedstrom/drupalextension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhedstrom/drupalextension/teams","hooks_url":"https://api.github.com/repos/jhedstrom/drupalextension/hooks","issue_events_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/events{/number}","events_url":"https://api.github.com/repos/jhedstrom/drupalextension/events","assignees_url":"https://api.github.com/repos/jhedstrom/drupalextension/assignees{/user}","branches_url":"https://api.github.com/repos/jhedstrom/drupalextension/branches{/branch}","tags_url":"https://api.github.com/repos/jhedstrom/drupalextension/tags","blobs_url":"https://api.github.com/repos/jhedstrom/drupalextension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhedstrom/drupalextension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhedstrom/drupalextension/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhedstrom/drupalextension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhedstrom/drupalextension/statuses/{sha}","languages_url":"https://api.github.com/repos/jhedstrom/drupalextension/languages","stargazers_url":"https://api.github.com/repos/jhedstrom/drupalextension/stargazers","contributors_url":"https://api.github.com/repos/jhedstrom/drupalextension/contributors","subscribers_url":"https://api.github.com/repos/jhedstrom/drupalextension/subscribers","subscription_url":"https://api.github.com/repos/jhedstrom/drupalextension/subscription","commits_url":"https://api.github.com/repos/jhedstrom/drupalextension/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhedstrom/drupalextension/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhedstrom/drupalextension/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhedstrom/drupalextension/contents/{+path}","compare_url":"https://api.github.com/repos/jhedstrom/drupalextension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhedstrom/drupalextension/merges","archive_url":"https://api.github.com/repos/jhedstrom/drupalextension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhedstrom/drupalextension/downloads","issues_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues{/number}","pulls_url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls{/number}","milestones_url":"https://api.github.com/repos/jhedstrom/drupalextension/milestones{/number}","notifications_url":"https://api.github.com/repos/jhedstrom/drupalextension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhedstrom/drupalextension/labels{/name}","releases_url":"https://api.github.com/repos/jhedstrom/drupalextension/releases{/id}","deployments_url":"https://api.github.com/repos/jhedstrom/drupalextension/deployments","created_at":"2012-11-09T22:54:07Z","updated_at":"2017-06-20T16:08:07Z","pushed_at":"2017-07-06T17:24:52Z","git_url":"git://github.com/jhedstrom/drupalextension.git","ssh_url":"git@github.com:jhedstrom/drupalextension.git","clone_url":"https://github.com/jhedstrom/drupalextension.git","svn_url":"https://github.com/jhedstrom/drupalextension","homepage":"","size":3590,"stargazers_count":136,"watchers_count":136,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":94,"forks":145,"open_issues":94,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390"},"html":{"href":"https://github.com/jhedstrom/drupalextension/pull/390"},"issue":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/issues/390"},"comments":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/jhedstrom/drupalextension/statuses/6207246c49583441ea0baefa08d5388d826675c2"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars2.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"jhedstrom"}}