{"action":"created","comment":{"url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/comments/134103349","pull_request_review_id":57360806,"id":134103349,"diff_hunk":"@@ -0,0 +1,100 @@\n+# This file was generated by the `rspec --init` command. Conventionally, all\n+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.\n+# The generated `.rspec` file contains `--require spec_helper` which will cause\n+# this file to always be loaded, without a need to explicitly require it in any\n+# files.\n+#\n+# Given that it is always loaded, you are encouraged to keep this file as\n+# light-weight as possible. Requiring heavyweight dependencies from this file\n+# will add to the boot time of your test suite on EVERY test run, even for an\n+# individual file that may not need all of that loaded. Instead, consider making\n+# a separate helper file that requires the additional dependencies and performs\n+# the additional setup, and require it from the spec files that actually need\n+# it.\n+#\n+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration\n+RSpec.configure do |config|\n+  # rspec-expectations config goes here. You can use an alternate\n+  # assertion/expectation library such as wrong or the stdlib/minitest\n+  # assertions if you prefer.\n+  config.expect_with :rspec do |expectations|\n+    # This option will default to `true` in RSpec 4. It makes the `description`\n+    # and `failure_message` of custom matchers include text for helper methods\n+    # defined using `chain`, e.g.:\n+    #     be_bigger_than(2).and_smaller_than(4).description\n+    #     # => \"be bigger than 2 and smaller than 4\"\n+    # ...rather than:\n+    #     # => \"be bigger than 2\"\n+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true\n+  end\n+\n+  # rspec-mocks config goes here. You can use an alternate test double\n+  # library (such as bogus or mocha) by changing the `mock_with` option here.\n+  config.mock_with :rspec do |mocks|\n+    # Prevents you from mocking or stubbing a method that does not exist on\n+    # a real object. This is generally recommended, and will default to\n+    # `true` in RSpec 4.\n+    mocks.verify_partial_doubles = true\n+  end\n+\n+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will\n+  # have no way to turn it off -- the option exists only for backwards\n+  # compatibility in RSpec 3). It causes shared context metadata to be\n+  # inherited by the metadata hash of host groups and examples, rather than\n+  # triggering implicit auto-inclusion in groups with matching metadata.\n+  config.shared_context_metadata_behavior = :apply_to_host_groups\n+\n+# The settings below are suggested to provide a good initial experience\n+# with RSpec, but feel free to customize to your heart's content.\n+=begin","path":"spec/spec_helper.rb","position":49,"original_position":49,"commit_id":"8f951f8737e1d0444e9c8510b374424e6aa3b93d","original_commit_id":"8f951f8737e1d0444e9c8510b374424e6aa3b93d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Do not use block comments.","created_at":"2017-08-20T00:06:54Z","updated_at":"2017-08-20T00:06:55Z","html_url":"https://github.com/blazeeboy/rubrowser/pull/4#discussion_r134103349","pull_request_url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/comments/134103349"},"html":{"href":"https://github.com/blazeeboy/rubrowser/pull/4#discussion_r134103349"},"pull_request":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4","id":136625659,"html_url":"https://github.com/blazeeboy/rubrowser/pull/4","diff_url":"https://github.com/blazeeboy/rubrowser/pull/4.diff","patch_url":"https://github.com/blazeeboy/rubrowser/pull/4.patch","issue_url":"https://api.github.com/repos/blazeeboy/rubrowser/issues/4","number":4,"state":"open","locked":false,"title":"Circular dependencies ","user":{"login":"steven-solomon","id":808389,"avatar_url":"https://avatars3.githubusercontent.com/u/808389?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-solomon","html_url":"https://github.com/steven-solomon","followers_url":"https://api.github.com/users/steven-solomon/followers","following_url":"https://api.github.com/users/steven-solomon/following{/other_user}","gists_url":"https://api.github.com/users/steven-solomon/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-solomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-solomon/subscriptions","organizations_url":"https://api.github.com/users/steven-solomon/orgs","repos_url":"https://api.github.com/users/steven-solomon/repos","events_url":"https://api.github.com/users/steven-solomon/events{/privacy}","received_events_url":"https://api.github.com/users/steven-solomon/received_events","type":"User","site_admin":false},"body":"In this branch I have done the following:\r\n1) Added basic test coverage through the Data class using RSpec\r\n2) Implemented the feature\r\n3) Added example file in lib to test behavior.\r\n\r\nI am happy to discuss switching to another testing framework if you prefer, I simply chose what I am most comfortable with. Also, I am hoping for a better way to test the app then pollute it with the test classes.\r\nFixes #3\r\n","created_at":"2017-08-20T00:06:41Z","updated_at":"2017-08-20T00:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab90c1361f9e017023244fece258b8f0409d984c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4/commits","review_comments_url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4/comments","review_comment_url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blazeeboy/rubrowser/issues/4/comments","statuses_url":"https://api.github.com/repos/blazeeboy/rubrowser/statuses/8f951f8737e1d0444e9c8510b374424e6aa3b93d","head":{"label":"steven-solomon:master","ref":"master","sha":"8f951f8737e1d0444e9c8510b374424e6aa3b93d","user":{"login":"steven-solomon","id":808389,"avatar_url":"https://avatars3.githubusercontent.com/u/808389?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-solomon","html_url":"https://github.com/steven-solomon","followers_url":"https://api.github.com/users/steven-solomon/followers","following_url":"https://api.github.com/users/steven-solomon/following{/other_user}","gists_url":"https://api.github.com/users/steven-solomon/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-solomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-solomon/subscriptions","organizations_url":"https://api.github.com/users/steven-solomon/orgs","repos_url":"https://api.github.com/users/steven-solomon/repos","events_url":"https://api.github.com/users/steven-solomon/events{/privacy}","received_events_url":"https://api.github.com/users/steven-solomon/received_events","type":"User","site_admin":false},"repo":{"id":100796041,"name":"rubrowser","full_name":"steven-solomon/rubrowser","owner":{"login":"steven-solomon","id":808389,"avatar_url":"https://avatars3.githubusercontent.com/u/808389?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-solomon","html_url":"https://github.com/steven-solomon","followers_url":"https://api.github.com/users/steven-solomon/followers","following_url":"https://api.github.com/users/steven-solomon/following{/other_user}","gists_url":"https://api.github.com/users/steven-solomon/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-solomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-solomon/subscriptions","organizations_url":"https://api.github.com/users/steven-solomon/orgs","repos_url":"https://api.github.com/users/steven-solomon/repos","events_url":"https://api.github.com/users/steven-solomon/events{/privacy}","received_events_url":"https://api.github.com/users/steven-solomon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steven-solomon/rubrowser","description":"a ruby code dependency graph interactive visualizer","fork":true,"url":"https://api.github.com/repos/steven-solomon/rubrowser","forks_url":"https://api.github.com/repos/steven-solomon/rubrowser/forks","keys_url":"https://api.github.com/repos/steven-solomon/rubrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steven-solomon/rubrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steven-solomon/rubrowser/teams","hooks_url":"https://api.github.com/repos/steven-solomon/rubrowser/hooks","issue_events_url":"https://api.github.com/repos/steven-solomon/rubrowser/issues/events{/number}","events_url":"https://api.github.com/repos/steven-solomon/rubrowser/events","assignees_url":"https://api.github.com/repos/steven-solomon/rubrowser/assignees{/user}","branches_url":"https://api.github.com/repos/steven-solomon/rubrowser/branches{/branch}","tags_url":"https://api.github.com/repos/steven-solomon/rubrowser/tags","blobs_url":"https://api.github.com/repos/steven-solomon/rubrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steven-solomon/rubrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steven-solomon/rubrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/steven-solomon/rubrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steven-solomon/rubrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/steven-solomon/rubrowser/languages","stargazers_url":"https://api.github.com/repos/steven-solomon/rubrowser/stargazers","contributors_url":"https://api.github.com/repos/steven-solomon/rubrowser/contributors","subscribers_url":"https://api.github.com/repos/steven-solomon/rubrowser/subscribers","subscription_url":"https://api.github.com/repos/steven-solomon/rubrowser/subscription","commits_url":"https://api.github.com/repos/steven-solomon/rubrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/steven-solomon/rubrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/steven-solomon/rubrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/steven-solomon/rubrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/steven-solomon/rubrowser/contents/{+path}","compare_url":"https://api.github.com/repos/steven-solomon/rubrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steven-solomon/rubrowser/merges","archive_url":"https://api.github.com/repos/steven-solomon/rubrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steven-solomon/rubrowser/downloads","issues_url":"https://api.github.com/repos/steven-solomon/rubrowser/issues{/number}","pulls_url":"https://api.github.com/repos/steven-solomon/rubrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/steven-solomon/rubrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/steven-solomon/rubrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steven-solomon/rubrowser/labels{/name}","releases_url":"https://api.github.com/repos/steven-solomon/rubrowser/releases{/id}","deployments_url":"https://api.github.com/repos/steven-solomon/rubrowser/deployments","created_at":"2017-08-19T13:27:53Z","updated_at":"2017-08-19T13:27:55Z","pushed_at":"2017-08-19T23:58:48Z","git_url":"git://github.com/steven-solomon/rubrowser.git","ssh_url":"git@github.com:steven-solomon/rubrowser.git","clone_url":"https://github.com/steven-solomon/rubrowser.git","svn_url":"https://github.com/steven-solomon/rubrowser","homepage":"http://www.blazeboy.me/rubrowser","size":354,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blazeeboy:master","ref":"master","sha":"f1c83c873070836d652e5056743ca94936dc7bb1","user":{"login":"blazeeboy","id":54403,"avatar_url":"https://avatars0.githubusercontent.com/u/54403?v=4","gravatar_id":"","url":"https://api.github.com/users/blazeeboy","html_url":"https://github.com/blazeeboy","followers_url":"https://api.github.com/users/blazeeboy/followers","following_url":"https://api.github.com/users/blazeeboy/following{/other_user}","gists_url":"https://api.github.com/users/blazeeboy/gists{/gist_id}","starred_url":"https://api.github.com/users/blazeeboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blazeeboy/subscriptions","organizations_url":"https://api.github.com/users/blazeeboy/orgs","repos_url":"https://api.github.com/users/blazeeboy/repos","events_url":"https://api.github.com/users/blazeeboy/events{/privacy}","received_events_url":"https://api.github.com/users/blazeeboy/received_events","type":"User","site_admin":false},"repo":{"id":66382841,"name":"rubrowser","full_name":"blazeeboy/rubrowser","owner":{"login":"blazeeboy","id":54403,"avatar_url":"https://avatars0.githubusercontent.com/u/54403?v=4","gravatar_id":"","url":"https://api.github.com/users/blazeeboy","html_url":"https://github.com/blazeeboy","followers_url":"https://api.github.com/users/blazeeboy/followers","following_url":"https://api.github.com/users/blazeeboy/following{/other_user}","gists_url":"https://api.github.com/users/blazeeboy/gists{/gist_id}","starred_url":"https://api.github.com/users/blazeeboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blazeeboy/subscriptions","organizations_url":"https://api.github.com/users/blazeeboy/orgs","repos_url":"https://api.github.com/users/blazeeboy/repos","events_url":"https://api.github.com/users/blazeeboy/events{/privacy}","received_events_url":"https://api.github.com/users/blazeeboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blazeeboy/rubrowser","description":"a ruby code dependency graph interactive visualizer","fork":false,"url":"https://api.github.com/repos/blazeeboy/rubrowser","forks_url":"https://api.github.com/repos/blazeeboy/rubrowser/forks","keys_url":"https://api.github.com/repos/blazeeboy/rubrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blazeeboy/rubrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blazeeboy/rubrowser/teams","hooks_url":"https://api.github.com/repos/blazeeboy/rubrowser/hooks","issue_events_url":"https://api.github.com/repos/blazeeboy/rubrowser/issues/events{/number}","events_url":"https://api.github.com/repos/blazeeboy/rubrowser/events","assignees_url":"https://api.github.com/repos/blazeeboy/rubrowser/assignees{/user}","branches_url":"https://api.github.com/repos/blazeeboy/rubrowser/branches{/branch}","tags_url":"https://api.github.com/repos/blazeeboy/rubrowser/tags","blobs_url":"https://api.github.com/repos/blazeeboy/rubrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blazeeboy/rubrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blazeeboy/rubrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/blazeeboy/rubrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blazeeboy/rubrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/blazeeboy/rubrowser/languages","stargazers_url":"https://api.github.com/repos/blazeeboy/rubrowser/stargazers","contributors_url":"https://api.github.com/repos/blazeeboy/rubrowser/contributors","subscribers_url":"https://api.github.com/repos/blazeeboy/rubrowser/subscribers","subscription_url":"https://api.github.com/repos/blazeeboy/rubrowser/subscription","commits_url":"https://api.github.com/repos/blazeeboy/rubrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/blazeeboy/rubrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/blazeeboy/rubrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/blazeeboy/rubrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/blazeeboy/rubrowser/contents/{+path}","compare_url":"https://api.github.com/repos/blazeeboy/rubrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blazeeboy/rubrowser/merges","archive_url":"https://api.github.com/repos/blazeeboy/rubrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blazeeboy/rubrowser/downloads","issues_url":"https://api.github.com/repos/blazeeboy/rubrowser/issues{/number}","pulls_url":"https://api.github.com/repos/blazeeboy/rubrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/blazeeboy/rubrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/blazeeboy/rubrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blazeeboy/rubrowser/labels{/name}","releases_url":"https://api.github.com/repos/blazeeboy/rubrowser/releases{/id}","deployments_url":"https://api.github.com/repos/blazeeboy/rubrowser/deployments","created_at":"2016-08-23T16:11:54Z","updated_at":"2017-08-18T13:06:36Z","pushed_at":"2017-08-20T00:06:43Z","git_url":"git://github.com/blazeeboy/rubrowser.git","ssh_url":"git@github.com:blazeeboy/rubrowser.git","clone_url":"https://github.com/blazeeboy/rubrowser.git","svn_url":"https://github.com/blazeeboy/rubrowser","homepage":"http://www.blazeboy.me/rubrowser","size":348,"stargazers_count":163,"watchers_count":163,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4"},"html":{"href":"https://github.com/blazeeboy/rubrowser/pull/4"},"issue":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/issues/4"},"comments":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/blazeeboy/rubrowser/statuses/8f951f8737e1d0444e9c8510b374424e6aa3b93d"}}}}
{"actor":{"display_login":"houndci-bot"}}