{"action":"created","comment":{"url":"https://api.github.com/repos/michel-kraemer/actson/pulls/comments/101010154","pull_request_review_id":21726747,"id":101010154,"diff_hunk":"@@ -24,6 +24,7 @@ tasks.withType(JavaCompile) {\n }\n \n dependencies {\n+    testCompile 'com.fasterxml.jackson.core:jackson-core:2.8.4'","path":"build.gradle","position":4,"original_position":4,"commit_id":"36401a46f248ffb09f28fbad4bc08376f8482a46","original_commit_id":"36401a46f248ffb09f28fbad4bc08376f8482a46","user":{"login":"PetrGlad","id":124476,"avatar_url":"https://avatars.githubusercontent.com/u/124476?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrGlad","html_url":"https://github.com/PetrGlad","followers_url":"https://api.github.com/users/PetrGlad/followers","following_url":"https://api.github.com/users/PetrGlad/following{/other_user}","gists_url":"https://api.github.com/users/PetrGlad/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrGlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrGlad/subscriptions","organizations_url":"https://api.github.com/users/PetrGlad/orgs","repos_url":"https://api.github.com/users/PetrGlad/repos","events_url":"https://api.github.com/users/PetrGlad/events{/privacy}","received_events_url":"https://api.github.com/users/PetrGlad/received_events","type":"User","site_admin":false},"body":"But that dependency is not explicit it just so happened that this library is in class path.\r\nThis now declares that we do directly require o.f.j.core functions in the code.","created_at":"2017-02-14T11:07:32Z","updated_at":"2017-02-14T11:07:32Z","html_url":"https://github.com/michel-kraemer/actson/pull/5#discussion_r101010154","pull_request_url":"https://api.github.com/repos/michel-kraemer/actson/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/comments/101010154"},"html":{"href":"https://github.com/michel-kraemer/actson/pull/5#discussion_r101010154"},"pull_request":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/michel-kraemer/actson/pulls/5","id":103653799,"html_url":"https://github.com/michel-kraemer/actson/pull/5","diff_url":"https://github.com/michel-kraemer/actson/pull/5.diff","patch_url":"https://github.com/michel-kraemer/actson/pull/5.patch","issue_url":"https://api.github.com/repos/michel-kraemer/actson/issues/5","number":5,"state":"open","locked":false,"title":"Support string escapes parsing","user":{"login":"PetrGlad","id":124476,"avatar_url":"https://avatars.githubusercontent.com/u/124476?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrGlad","html_url":"https://github.com/PetrGlad","followers_url":"https://api.github.com/users/PetrGlad/followers","following_url":"https://api.github.com/users/PetrGlad/following{/other_user}","gists_url":"https://api.github.com/users/PetrGlad/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrGlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrGlad/subscriptions","organizations_url":"https://api.github.com/users/PetrGlad/orgs","repos_url":"https://api.github.com/users/PetrGlad/repos","events_url":"https://api.github.com/users/PetrGlad/events{/privacy}","received_events_url":"https://api.github.com/users/PetrGlad/received_events","type":"User","site_admin":false},"body":"Implementation of code point parser and single-char escapes, fixes #4 . Add code to handle \"escape\" events which previously just changed state. \r\n\r\nUse Jackson for pretty-printing JSON generation. To correctly render escaped sequences existing pretty printer should have been fixed but I decided not to fix it and use Jackson instead.\r\n\r\nExtract common example/test code into separate class. Also I extracted feeding/event reading loop into separate class (`de.undercouch.actson.JsonHelper`). \r\n\r\nUse named constants for escape actions. To keep formatting of transition table since now actions take 3 positions. I'd use named constants for other actions but that probably should be in separate PR.\r\n\r\nResults of tests https://github.com/nst/JSONTestSuite do not seem to be changed compared to master.","created_at":"2017-01-29T17:55:43Z","updated_at":"2017-02-14T11:07:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0a06e80b06cbe80f804ec8d7157e8e1c4e10b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/michel-kraemer/actson/pulls/5/commits","review_comments_url":"https://api.github.com/repos/michel-kraemer/actson/pulls/5/comments","review_comment_url":"https://api.github.com/repos/michel-kraemer/actson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/michel-kraemer/actson/issues/5/comments","statuses_url":"https://api.github.com/repos/michel-kraemer/actson/statuses/36401a46f248ffb09f28fbad4bc08376f8482a46","head":{"label":"PetrGlad:parse-utf8","ref":"parse-utf8","sha":"36401a46f248ffb09f28fbad4bc08376f8482a46","user":{"login":"PetrGlad","id":124476,"avatar_url":"https://avatars.githubusercontent.com/u/124476?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrGlad","html_url":"https://github.com/PetrGlad","followers_url":"https://api.github.com/users/PetrGlad/followers","following_url":"https://api.github.com/users/PetrGlad/following{/other_user}","gists_url":"https://api.github.com/users/PetrGlad/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrGlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrGlad/subscriptions","organizations_url":"https://api.github.com/users/PetrGlad/orgs","repos_url":"https://api.github.com/users/PetrGlad/repos","events_url":"https://api.github.com/users/PetrGlad/events{/privacy}","received_events_url":"https://api.github.com/users/PetrGlad/received_events","type":"User","site_admin":false},"repo":{"id":79050995,"name":"actson","full_name":"PetrGlad/actson","owner":{"login":"PetrGlad","id":124476,"avatar_url":"https://avatars.githubusercontent.com/u/124476?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrGlad","html_url":"https://github.com/PetrGlad","followers_url":"https://api.github.com/users/PetrGlad/followers","following_url":"https://api.github.com/users/PetrGlad/following{/other_user}","gists_url":"https://api.github.com/users/PetrGlad/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrGlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrGlad/subscriptions","organizations_url":"https://api.github.com/users/PetrGlad/orgs","repos_url":"https://api.github.com/users/PetrGlad/repos","events_url":"https://api.github.com/users/PetrGlad/events{/privacy}","received_events_url":"https://api.github.com/users/PetrGlad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PetrGlad/actson","description":"A reactive (or non-blocking, or asynchronous) JSON parser","fork":true,"url":"https://api.github.com/repos/PetrGlad/actson","forks_url":"https://api.github.com/repos/PetrGlad/actson/forks","keys_url":"https://api.github.com/repos/PetrGlad/actson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PetrGlad/actson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PetrGlad/actson/teams","hooks_url":"https://api.github.com/repos/PetrGlad/actson/hooks","issue_events_url":"https://api.github.com/repos/PetrGlad/actson/issues/events{/number}","events_url":"https://api.github.com/repos/PetrGlad/actson/events","assignees_url":"https://api.github.com/repos/PetrGlad/actson/assignees{/user}","branches_url":"https://api.github.com/repos/PetrGlad/actson/branches{/branch}","tags_url":"https://api.github.com/repos/PetrGlad/actson/tags","blobs_url":"https://api.github.com/repos/PetrGlad/actson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PetrGlad/actson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PetrGlad/actson/git/refs{/sha}","trees_url":"https://api.github.com/repos/PetrGlad/actson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PetrGlad/actson/statuses/{sha}","languages_url":"https://api.github.com/repos/PetrGlad/actson/languages","stargazers_url":"https://api.github.com/repos/PetrGlad/actson/stargazers","contributors_url":"https://api.github.com/repos/PetrGlad/actson/contributors","subscribers_url":"https://api.github.com/repos/PetrGlad/actson/subscribers","subscription_url":"https://api.github.com/repos/PetrGlad/actson/subscription","commits_url":"https://api.github.com/repos/PetrGlad/actson/commits{/sha}","git_commits_url":"https://api.github.com/repos/PetrGlad/actson/git/commits{/sha}","comments_url":"https://api.github.com/repos/PetrGlad/actson/comments{/number}","issue_comment_url":"https://api.github.com/repos/PetrGlad/actson/issues/comments{/number}","contents_url":"https://api.github.com/repos/PetrGlad/actson/contents/{+path}","compare_url":"https://api.github.com/repos/PetrGlad/actson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PetrGlad/actson/merges","archive_url":"https://api.github.com/repos/PetrGlad/actson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PetrGlad/actson/downloads","issues_url":"https://api.github.com/repos/PetrGlad/actson/issues{/number}","pulls_url":"https://api.github.com/repos/PetrGlad/actson/pulls{/number}","milestones_url":"https://api.github.com/repos/PetrGlad/actson/milestones{/number}","notifications_url":"https://api.github.com/repos/PetrGlad/actson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PetrGlad/actson/labels{/name}","releases_url":"https://api.github.com/repos/PetrGlad/actson/releases{/id}","deployments_url":"https://api.github.com/repos/PetrGlad/actson/deployments","created_at":"2017-01-15T18:27:40Z","updated_at":"2017-01-15T18:27:42Z","pushed_at":"2017-01-29T18:03:02Z","git_url":"git://github.com/PetrGlad/actson.git","ssh_url":"git@github.com:PetrGlad/actson.git","clone_url":"https://github.com/PetrGlad/actson.git","svn_url":"https://github.com/PetrGlad/actson","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"michel-kraemer:master","ref":"master","sha":"7141eff6b509cf839b27ce795cede798dc2feaae","user":{"login":"michel-kraemer","id":295407,"avatar_url":"https://avatars.githubusercontent.com/u/295407?v=3","gravatar_id":"","url":"https://api.github.com/users/michel-kraemer","html_url":"https://github.com/michel-kraemer","followers_url":"https://api.github.com/users/michel-kraemer/followers","following_url":"https://api.github.com/users/michel-kraemer/following{/other_user}","gists_url":"https://api.github.com/users/michel-kraemer/gists{/gist_id}","starred_url":"https://api.github.com/users/michel-kraemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michel-kraemer/subscriptions","organizations_url":"https://api.github.com/users/michel-kraemer/orgs","repos_url":"https://api.github.com/users/michel-kraemer/repos","events_url":"https://api.github.com/users/michel-kraemer/events{/privacy}","received_events_url":"https://api.github.com/users/michel-kraemer/received_events","type":"User","site_admin":false},"repo":{"id":65848877,"name":"actson","full_name":"michel-kraemer/actson","owner":{"login":"michel-kraemer","id":295407,"avatar_url":"https://avatars.githubusercontent.com/u/295407?v=3","gravatar_id":"","url":"https://api.github.com/users/michel-kraemer","html_url":"https://github.com/michel-kraemer","followers_url":"https://api.github.com/users/michel-kraemer/followers","following_url":"https://api.github.com/users/michel-kraemer/following{/other_user}","gists_url":"https://api.github.com/users/michel-kraemer/gists{/gist_id}","starred_url":"https://api.github.com/users/michel-kraemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michel-kraemer/subscriptions","organizations_url":"https://api.github.com/users/michel-kraemer/orgs","repos_url":"https://api.github.com/users/michel-kraemer/repos","events_url":"https://api.github.com/users/michel-kraemer/events{/privacy}","received_events_url":"https://api.github.com/users/michel-kraemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michel-kraemer/actson","description":"A reactive (or non-blocking, or asynchronous) JSON parser","fork":false,"url":"https://api.github.com/repos/michel-kraemer/actson","forks_url":"https://api.github.com/repos/michel-kraemer/actson/forks","keys_url":"https://api.github.com/repos/michel-kraemer/actson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michel-kraemer/actson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michel-kraemer/actson/teams","hooks_url":"https://api.github.com/repos/michel-kraemer/actson/hooks","issue_events_url":"https://api.github.com/repos/michel-kraemer/actson/issues/events{/number}","events_url":"https://api.github.com/repos/michel-kraemer/actson/events","assignees_url":"https://api.github.com/repos/michel-kraemer/actson/assignees{/user}","branches_url":"https://api.github.com/repos/michel-kraemer/actson/branches{/branch}","tags_url":"https://api.github.com/repos/michel-kraemer/actson/tags","blobs_url":"https://api.github.com/repos/michel-kraemer/actson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michel-kraemer/actson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michel-kraemer/actson/git/refs{/sha}","trees_url":"https://api.github.com/repos/michel-kraemer/actson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michel-kraemer/actson/statuses/{sha}","languages_url":"https://api.github.com/repos/michel-kraemer/actson/languages","stargazers_url":"https://api.github.com/repos/michel-kraemer/actson/stargazers","contributors_url":"https://api.github.com/repos/michel-kraemer/actson/contributors","subscribers_url":"https://api.github.com/repos/michel-kraemer/actson/subscribers","subscription_url":"https://api.github.com/repos/michel-kraemer/actson/subscription","commits_url":"https://api.github.com/repos/michel-kraemer/actson/commits{/sha}","git_commits_url":"https://api.github.com/repos/michel-kraemer/actson/git/commits{/sha}","comments_url":"https://api.github.com/repos/michel-kraemer/actson/comments{/number}","issue_comment_url":"https://api.github.com/repos/michel-kraemer/actson/issues/comments{/number}","contents_url":"https://api.github.com/repos/michel-kraemer/actson/contents/{+path}","compare_url":"https://api.github.com/repos/michel-kraemer/actson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michel-kraemer/actson/merges","archive_url":"https://api.github.com/repos/michel-kraemer/actson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michel-kraemer/actson/downloads","issues_url":"https://api.github.com/repos/michel-kraemer/actson/issues{/number}","pulls_url":"https://api.github.com/repos/michel-kraemer/actson/pulls{/number}","milestones_url":"https://api.github.com/repos/michel-kraemer/actson/milestones{/number}","notifications_url":"https://api.github.com/repos/michel-kraemer/actson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michel-kraemer/actson/labels{/name}","releases_url":"https://api.github.com/repos/michel-kraemer/actson/releases{/id}","deployments_url":"https://api.github.com/repos/michel-kraemer/actson/deployments","created_at":"2016-08-16T19:48:24Z","updated_at":"2017-02-12T10:08:26Z","pushed_at":"2017-01-29T18:03:03Z","git_url":"git://github.com/michel-kraemer/actson.git","ssh_url":"git@github.com:michel-kraemer/actson.git","clone_url":"https://github.com/michel-kraemer/actson.git","svn_url":"https://github.com/michel-kraemer/actson","homepage":null,"size":182,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/5"},"html":{"href":"https://github.com/michel-kraemer/actson/pull/5"},"issue":{"href":"https://api.github.com/repos/michel-kraemer/actson/issues/5"},"comments":{"href":"https://api.github.com/repos/michel-kraemer/actson/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/michel-kraemer/actson/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/michel-kraemer/actson/statuses/36401a46f248ffb09f28fbad4bc08376f8482a46"}}}}
{"actor":{"display_login":"PetrGlad"}}