{"action":"created","issue":{"url":"https://api.github.com/repos/Khan/KaTeX/issues/871","repository_url":"https://api.github.com/repos/Khan/KaTeX","labels_url":"https://api.github.com/repos/Khan/KaTeX/issues/871/labels{/name}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/871/comments","events_url":"https://api.github.com/repos/Khan/KaTeX/issues/871/events","html_url":"https://github.com/Khan/KaTeX/pull/871","id":256579652,"number":871,"title":"Migrate genfrac, lap, smash, op, mod, and katex into their own files in src/functions","user":{"login":"kevinbarabash","id":1044413,"avatar_url":"https://avatars3.githubusercontent.com/u/1044413?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false},"labels":[{"id":255328091,"url":"https://api.github.com/repos/Khan/KaTeX/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-09-11T04:36:40Z","updated_at":"2017-10-25T02:50:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/871","html_url":"https://github.com/Khan/KaTeX/pull/871","diff_url":"https://github.com/Khan/KaTeX/pull/871.diff","patch_url":"https://github.com/Khan/KaTeX/pull/871.patch"},"body":"Fixes #869"},"comment":{"url":"https://api.github.com/repos/Khan/KaTeX/issues/comments/339197867","html_url":"https://github.com/Khan/KaTeX/pull/871#issuecomment-339197867","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/871","id":339197867,"user":{"login":"marcianx","id":370338,"avatar_url":"https://avatars3.githubusercontent.com/u/370338?v=4","gravatar_id":"","url":"https://api.github.com/users/marcianx","html_url":"https://github.com/marcianx","followers_url":"https://api.github.com/users/marcianx/followers","following_url":"https://api.github.com/users/marcianx/following{/other_user}","gists_url":"https://api.github.com/users/marcianx/gists{/gist_id}","starred_url":"https://api.github.com/users/marcianx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcianx/subscriptions","organizations_url":"https://api.github.com/users/marcianx/orgs","repos_url":"https://api.github.com/users/marcianx/repos","events_url":"https://api.github.com/users/marcianx/events{/privacy}","received_events_url":"https://api.github.com/users/marcianx/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T02:50:47Z","updated_at":"2017-10-25T02:50:47Z","author_association":"COLLABORATOR","body":"Nice! For posterity, this is how I reviewed. I went per file as in the checklist above and wanted to open all the diffs for a given file in the same meld session. So I temporarily added the `-n` parameter to my `.gitconfig` to open all diffs in the same session:\r\n\r\n    [difftool \"meld\"]\r\n        cmd = meld -n \\\"$LOCAL\\\" \\\"$REMOTE\\\" --label \\\"DIFF (ORIGINAL MY)\\\"\r\n\r\nand per file, I did the for loop per @edemaine's suggestion modified to open all diffs at once (e.g. for `smash.js`):\r\n\r\n    for a in buildHTML.js buildMathML.js functions.js; do\r\n      git difftool HEAD~:src/$a src/functions/smash.js &\r\n    done\r\n\r\nand did some easy manual modifications to get clean diffs. It was all pretty fast for this cut-and-paste-and-indent PR."}}
{"actor":{"display_login":"marcianx"}}