{"action":"created","issue":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1698","repository_url":"https://api.github.com/repos/pi-hole/pi-hole","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1698/labels{/name}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1698/comments","events_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1698/events","html_url":"https://github.com/pi-hole/pi-hole/pull/1698","id":258884335,"number":1698,"title":"Remove hardcoded/unnecessary local-ttl/cache-size values in dnsmasq.conf","user":{"login":"celly","id":514749,"avatar_url":"https://avatars3.githubusercontent.com/u/514749?v=4","gravatar_id":"","url":"https://api.github.com/users/celly","html_url":"https://github.com/celly","followers_url":"https://api.github.com/users/celly/followers","following_url":"https://api.github.com/users/celly/following{/other_user}","gists_url":"https://api.github.com/users/celly/gists{/gist_id}","starred_url":"https://api.github.com/users/celly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celly/subscriptions","organizations_url":"https://api.github.com/users/celly/orgs","repos_url":"https://api.github.com/users/celly/repos","events_url":"https://api.github.com/users/celly/events{/privacy}","received_events_url":"https://api.github.com/users/celly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-19T16:28:39Z","updated_at":"2017-09-20T19:43:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1698","html_url":"https://github.com/pi-hole/pi-hole/pull/1698","diff_url":"https://github.com/pi-hole/pi-hole/pull/1698.diff","patch_url":"https://github.com/pi-hole/pi-hole/pull/1698.patch"},"body":"**By submitting this pull request, I confirm the following (please check boxes, eg [X]) _Failure to fill the template will close your PR_:**\r\n\r\n***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***\r\n\r\n- [✔️] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).\r\n- [✔️] I have checked that [another pull request](https://github.com/pi-hole/pi-hole/pulls) for this purpose does not exist.\r\n- [✔️] I have considered, and confirmed that this submission will be valuable to others.\r\n- [✔️] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.\r\n- [✔️] I give this submission freely, and claim no ownership to its content.\r\n\r\n**How familiar are you with the codebase?:**\r\n\r\n_3.2_\r\n\r\n---\r\n\r\nMost users do not need these values set, and they seem to be an artifact of the original code base. By having them hard coded in this file, it makes it so you cannot permanently overwrite them since they will be overwritten every time this the config file is written. You can also not add them to a custom config, since they will be error as dupe.\r\n\r\n\r\n_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._\r\n"},"comment":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/comments/330959526","html_url":"https://github.com/pi-hole/pi-hole/pull/1698#issuecomment-330959526","issue_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1698","id":330959526,"user":{"login":"celly","id":514749,"avatar_url":"https://avatars3.githubusercontent.com/u/514749?v=4","gravatar_id":"","url":"https://api.github.com/users/celly","html_url":"https://github.com/celly","followers_url":"https://api.github.com/users/celly/followers","following_url":"https://api.github.com/users/celly/following{/other_user}","gists_url":"https://api.github.com/users/celly/gists{/gist_id}","starred_url":"https://api.github.com/users/celly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celly/subscriptions","organizations_url":"https://api.github.com/users/celly/orgs","repos_url":"https://api.github.com/users/celly/repos","events_url":"https://api.github.com/users/celly/events{/privacy}","received_events_url":"https://api.github.com/users/celly/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T19:43:06Z","updated_at":"2017-09-20T19:43:06Z","author_association":"NONE","body":"@mibere In a world of 300s ttl's and client side caching I don't think the cache is being used as much as you think. In additions, since your client and pi-hole will have matching ttl's follow up requests from the same client will be misses. So, the only cache hits you get are for common duplicate requests across clients. So a large cache here just burns memory. \r\n\r\nIf you want details on the performance of pi-hole dns cache: \r\n\r\n```sh\r\n$ sudo pkill -USR1 dnsmasq\r\n$ cat /var/log/pihole.log | grep \"cache size\"\r\n```\r\n\r\nWait a bit, and do it again, and you'll get a good idea of effectiveness.\r\n\r\n```\r\nSep 20 19:15:02 dnsmasq[14028]: cache size 150, 7541/125481 cache insertions re-used unexpired cache entries.\r\nSep 20 19:36:44 dnsmasq[3193]: cache size 150, 0/801 cache insertions re-used unexpired cache entries.\r\n```"}}
{"actor":{"display_login":"celly"}}