{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vstest/pulls/comments/138575821","pull_request_review_id":62386691,"id":138575821,"diff_hunk":"@@ -0,0 +1,194 @@\n+// Copyright (c) Microsoft Corporation. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+namespace Microsoft.VisualStudio.TestPlatform.CommandLine\n+{\n+    using System;\n+    using System.Collections.Generic;\n+    using System.Linq;\n+    using Microsoft.VisualStudio.TestPlatform.Common.Filtering;\n+    using Microsoft.VisualStudio.TestPlatform.ObjectModel;\n+    \n+    /// <summary>\n+    /// Unit test filtering\n+    /// </summary>\n+    public class TestCaseFilter : ITestCaseFilter\n+    {\n+        public TestCaseFilter()\n+        {\n+            \n+        }\n+\n+        public void Initialize(string filterString)\n+        {\n+            ValidateFilter(filterString);\n+        }\n+\n+        /// <summary>\n+        /// Filter tests\n+        /// </summary>\n+        public IEnumerable<TestCase> FilterTests(IEnumerable<TestCase> testCases)\n+        {\n+            EqtTrace.Verbose(\"TestCaseFilter.FilterTests : Test Filtering invoked.\");\n+\n+            List<TestCase> filteredList;\n+\n+            try\n+            {\n+                filteredList = GetFilteredTestCases(testCases);\n+            }\n+            catch (Exception ex)\n+            {\n+                EqtTrace.Error(\"TestCaseFilter.FilterTests : Exception during filtering : {0}\", ex.ToString());\n+                throw;\n+            }\n+\n+            return filteredList;\n+        }\n+\n+        private void ValidateFilter(string filterString)\n+        {\n+            if (string.IsNullOrEmpty(filterString))\n+            {\n+                _filterExpression = null;","path":"src/vstest.console/CommandLine/TestCaseFilter.cs","position":53,"original_position":53,"commit_id":"cd77e0570e3c15606b269433b88519e09e04231c","original_commit_id":"cd77e0570e3c15606b269433b88519e09e04231c","user":{"login":"prawalagarwal","id":13520100,"avatar_url":"https://avatars0.githubusercontent.com/u/13520100?v=4","gravatar_id":"","url":"https://api.github.com/users/prawalagarwal","html_url":"https://github.com/prawalagarwal","followers_url":"https://api.github.com/users/prawalagarwal/followers","following_url":"https://api.github.com/users/prawalagarwal/following{/other_user}","gists_url":"https://api.github.com/users/prawalagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/prawalagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawalagarwal/subscriptions","organizations_url":"https://api.github.com/users/prawalagarwal/orgs","repos_url":"https://api.github.com/users/prawalagarwal/repos","events_url":"https://api.github.com/users/prawalagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/prawalagarwal/received_events","type":"User","site_admin":false},"body":"Removed '_'. filterExpression is a static type. Cannot access it with an instance (which is this in our case)","created_at":"2017-09-13T09:59:31Z","updated_at":"2017-09-13T09:59:31Z","html_url":"https://github.com/Microsoft/vstest/pull/1075#discussion_r138575821","pull_request_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1075","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/comments/138575821"},"html":{"href":"https://github.com/Microsoft/vstest/pull/1075#discussion_r138575821"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1075"}},"in_reply_to_id":138567227},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vstest/pulls/1075","id":140599298,"html_url":"https://github.com/Microsoft/vstest/pull/1075","diff_url":"https://github.com/Microsoft/vstest/pull/1075.diff","patch_url":"https://github.com/Microsoft/vstest/pull/1075.patch","issue_url":"https://api.github.com/repos/Microsoft/vstest/issues/1075","number":1075,"state":"open","locked":false,"title":"Adding support for listing fully qualified test cases","user":{"login":"prawalagarwal","id":13520100,"avatar_url":"https://avatars0.githubusercontent.com/u/13520100?v=4","gravatar_id":"","url":"https://api.github.com/users/prawalagarwal","html_url":"https://github.com/prawalagarwal","followers_url":"https://api.github.com/users/prawalagarwal/followers","following_url":"https://api.github.com/users/prawalagarwal/following{/other_user}","gists_url":"https://api.github.com/users/prawalagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/prawalagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawalagarwal/subscriptions","organizations_url":"https://api.github.com/users/prawalagarwal/orgs","repos_url":"https://api.github.com/users/prawalagarwal/repos","events_url":"https://api.github.com/users/prawalagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/prawalagarwal/received_events","type":"User","site_admin":false},"body":"Description: The flag /ListFullyQualifiedTests existing in TPV1 which listed the fully qualified tests along with filtering support for MSTestV1/V2 bases tests. This PR ports these changes to TPV2.","created_at":"2017-09-12T14:43:48Z","updated_at":"2017-09-13T09:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b0974b905addee54142904b21b835fa9babda82","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1075/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1075/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vstest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vstest/issues/1075/comments","statuses_url":"https://api.github.com/repos/Microsoft/vstest/statuses/cd77e0570e3c15606b269433b88519e09e04231c","head":{"label":"prawalagarwal:master","ref":"master","sha":"cd77e0570e3c15606b269433b88519e09e04231c","user":{"login":"prawalagarwal","id":13520100,"avatar_url":"https://avatars0.githubusercontent.com/u/13520100?v=4","gravatar_id":"","url":"https://api.github.com/users/prawalagarwal","html_url":"https://github.com/prawalagarwal","followers_url":"https://api.github.com/users/prawalagarwal/followers","following_url":"https://api.github.com/users/prawalagarwal/following{/other_user}","gists_url":"https://api.github.com/users/prawalagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/prawalagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawalagarwal/subscriptions","organizations_url":"https://api.github.com/users/prawalagarwal/orgs","repos_url":"https://api.github.com/users/prawalagarwal/repos","events_url":"https://api.github.com/users/prawalagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/prawalagarwal/received_events","type":"User","site_admin":false},"repo":{"id":98971256,"name":"vstest","full_name":"prawalagarwal/vstest","owner":{"login":"prawalagarwal","id":13520100,"avatar_url":"https://avatars0.githubusercontent.com/u/13520100?v=4","gravatar_id":"","url":"https://api.github.com/users/prawalagarwal","html_url":"https://github.com/prawalagarwal","followers_url":"https://api.github.com/users/prawalagarwal/followers","following_url":"https://api.github.com/users/prawalagarwal/following{/other_user}","gists_url":"https://api.github.com/users/prawalagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/prawalagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prawalagarwal/subscriptions","organizations_url":"https://api.github.com/users/prawalagarwal/orgs","repos_url":"https://api.github.com/users/prawalagarwal/repos","events_url":"https://api.github.com/users/prawalagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/prawalagarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prawalagarwal/vstest","description":"Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.","fork":true,"url":"https://api.github.com/repos/prawalagarwal/vstest","forks_url":"https://api.github.com/repos/prawalagarwal/vstest/forks","keys_url":"https://api.github.com/repos/prawalagarwal/vstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prawalagarwal/vstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prawalagarwal/vstest/teams","hooks_url":"https://api.github.com/repos/prawalagarwal/vstest/hooks","issue_events_url":"https://api.github.com/repos/prawalagarwal/vstest/issues/events{/number}","events_url":"https://api.github.com/repos/prawalagarwal/vstest/events","assignees_url":"https://api.github.com/repos/prawalagarwal/vstest/assignees{/user}","branches_url":"https://api.github.com/repos/prawalagarwal/vstest/branches{/branch}","tags_url":"https://api.github.com/repos/prawalagarwal/vstest/tags","blobs_url":"https://api.github.com/repos/prawalagarwal/vstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prawalagarwal/vstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prawalagarwal/vstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/prawalagarwal/vstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prawalagarwal/vstest/statuses/{sha}","languages_url":"https://api.github.com/repos/prawalagarwal/vstest/languages","stargazers_url":"https://api.github.com/repos/prawalagarwal/vstest/stargazers","contributors_url":"https://api.github.com/repos/prawalagarwal/vstest/contributors","subscribers_url":"https://api.github.com/repos/prawalagarwal/vstest/subscribers","subscription_url":"https://api.github.com/repos/prawalagarwal/vstest/subscription","commits_url":"https://api.github.com/repos/prawalagarwal/vstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/prawalagarwal/vstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/prawalagarwal/vstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/prawalagarwal/vstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/prawalagarwal/vstest/contents/{+path}","compare_url":"https://api.github.com/repos/prawalagarwal/vstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prawalagarwal/vstest/merges","archive_url":"https://api.github.com/repos/prawalagarwal/vstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prawalagarwal/vstest/downloads","issues_url":"https://api.github.com/repos/prawalagarwal/vstest/issues{/number}","pulls_url":"https://api.github.com/repos/prawalagarwal/vstest/pulls{/number}","milestones_url":"https://api.github.com/repos/prawalagarwal/vstest/milestones{/number}","notifications_url":"https://api.github.com/repos/prawalagarwal/vstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prawalagarwal/vstest/labels{/name}","releases_url":"https://api.github.com/repos/prawalagarwal/vstest/releases{/id}","deployments_url":"https://api.github.com/repos/prawalagarwal/vstest/deployments","created_at":"2017-08-01T07:12:09Z","updated_at":"2017-08-01T07:12:14Z","pushed_at":"2017-09-13T05:05:26Z","git_url":"git://github.com/prawalagarwal/vstest.git","ssh_url":"git@github.com:prawalagarwal/vstest.git","clone_url":"https://github.com/prawalagarwal/vstest.git","svn_url":"https://github.com/prawalagarwal/vstest","homepage":"","size":6305,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5592f66c60da7eeaab9a7dad97e73d1e2869eb68","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":62774726,"name":"vstest","full_name":"Microsoft/vstest","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vstest","description":"Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.","fork":false,"url":"https://api.github.com/repos/Microsoft/vstest","forks_url":"https://api.github.com/repos/Microsoft/vstest/forks","keys_url":"https://api.github.com/repos/Microsoft/vstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vstest/teams","hooks_url":"https://api.github.com/repos/Microsoft/vstest/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vstest/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vstest/events","assignees_url":"https://api.github.com/repos/Microsoft/vstest/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vstest/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vstest/tags","blobs_url":"https://api.github.com/repos/Microsoft/vstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vstest/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vstest/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vstest/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vstest/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vstest/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vstest/subscription","commits_url":"https://api.github.com/repos/Microsoft/vstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vstest/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vstest/merges","archive_url":"https://api.github.com/repos/Microsoft/vstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vstest/downloads","issues_url":"https://api.github.com/repos/Microsoft/vstest/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vstest/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vstest/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vstest/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vstest/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vstest/deployments","created_at":"2016-07-07T04:18:58Z","updated_at":"2017-09-06T14:53:00Z","pushed_at":"2017-09-13T09:56:30Z","git_url":"git://github.com/Microsoft/vstest.git","ssh_url":"git@github.com:Microsoft/vstest.git","clone_url":"https://github.com/Microsoft/vstest.git","svn_url":"https://github.com/Microsoft/vstest","homepage":"","size":6216,"stargazers_count":316,"watchers_count":316,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":160,"forks":64,"open_issues":160,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1075"},"html":{"href":"https://github.com/Microsoft/vstest/pull/1075"},"issue":{"href":"https://api.github.com/repos/Microsoft/vstest/issues/1075"},"comments":{"href":"https://api.github.com/repos/Microsoft/vstest/issues/1075/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1075/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1075/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vstest/statuses/cd77e0570e3c15606b269433b88519e09e04231c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"prawalagarwal"}}