{"action":"created","comment":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/108511984","pull_request_review_id":29547541,"id":108511984,"diff_hunk":"@@ -150,11 +150,15 @@ public function commitTransaction() {\n      */\n     protected function newPDO($Dsn, $User, $Password) {\n         try {\n+            if (strpos($Dsn, 'charset=') === false) {","path":"library/database/class.database.php","position":4,"original_position":4,"commit_id":"617e3ef8d9c1f7b327a0e3c1ac58e20b16684f98","original_commit_id":"617e3ef8d9c1f7b327a0e3c1ac58e20b16684f98","user":{"login":"tburry","id":97432,"avatar_url":"https://avatars2.githubusercontent.com/u/97432?v=3","gravatar_id":"","url":"https://api.github.com/users/tburry","html_url":"https://github.com/tburry","followers_url":"https://api.github.com/users/tburry/followers","following_url":"https://api.github.com/users/tburry/following{/other_user}","gists_url":"https://api.github.com/users/tburry/gists{/gist_id}","starred_url":"https://api.github.com/users/tburry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tburry/subscriptions","organizations_url":"https://api.github.com/users/tburry/orgs","repos_url":"https://api.github.com/users/tburry/repos","events_url":"https://api.github.com/users/tburry/events{/privacy}","received_events_url":"https://api.github.com/users/tburry/received_events","type":"User","site_admin":false},"body":"I don't think this is the right place for this code. You should be adding the `charset` when the DSN is being constructed.","created_at":"2017-03-28T19:12:19Z","updated_at":"2017-03-28T19:12:26Z","html_url":"https://github.com/vanilla/vanilla/pull/5376#discussion_r108511984","pull_request_url":"https://api.github.com/repos/vanilla/vanilla/pulls/5376","_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/108511984"},"html":{"href":"https://github.com/vanilla/vanilla/pull/5376#discussion_r108511984"},"pull_request":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/5376"}}},"pull_request":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/5376","id":112991137,"html_url":"https://github.com/vanilla/vanilla/pull/5376","diff_url":"https://github.com/vanilla/vanilla/pull/5376.diff","patch_url":"https://github.com/vanilla/vanilla/pull/5376.patch","issue_url":"https://api.github.com/repos/vanilla/vanilla/issues/5376","number":5376,"state":"open","locked":false,"title":"Set charset through PDO's dsn string","user":{"login":"DaazKu","id":2412909,"avatar_url":"https://avatars3.githubusercontent.com/u/2412909?v=3","gravatar_id":"","url":"https://api.github.com/users/DaazKu","html_url":"https://github.com/DaazKu","followers_url":"https://api.github.com/users/DaazKu/followers","following_url":"https://api.github.com/users/DaazKu/following{/other_user}","gists_url":"https://api.github.com/users/DaazKu/gists{/gist_id}","starred_url":"https://api.github.com/users/DaazKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaazKu/subscriptions","organizations_url":"https://api.github.com/users/DaazKu/orgs","repos_url":"https://api.github.com/users/DaazKu/repos","events_url":"https://api.github.com/users/DaazKu/events{/privacy}","received_events_url":"https://api.github.com/users/DaazKu/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/vanilla/vanilla/issues/5312","created_at":"2017-03-28T14:56:27Z","updated_at":"2017-03-28T19:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8bb80f14adbec68223bfff68c4bc7d2c334f96","assignee":{"login":"initvector","id":1390241,"avatar_url":"https://avatars3.githubusercontent.com/u/1390241?v=3","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},"assignees":[{"login":"initvector","id":1390241,"avatar_url":"https://avatars3.githubusercontent.com/u/1390241?v=3","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vanilla/vanilla/milestones/51","html_url":"https://github.com/vanilla/vanilla/milestone/51","labels_url":"https://api.github.com/repos/vanilla/vanilla/milestones/51/labels","id":2171237,"number":51,"title":"2017-Q2-1","description":"","creator":{"login":"linc","id":117672,"avatar_url":"https://avatars2.githubusercontent.com/u/117672?v=3","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":12,"state":"open","created_at":"2016-12-02T14:20:45Z","updated_at":"2017-03-28T18:40:26Z","due_on":"2017-04-08T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vanilla/vanilla/pulls/5376/commits","review_comments_url":"https://api.github.com/repos/vanilla/vanilla/pulls/5376/comments","review_comment_url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanilla/vanilla/issues/5376/comments","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/617e3ef8d9c1f7b327a0e3c1ac58e20b16684f98","head":{"label":"vanilla:refactor/dbcharset","ref":"refactor/dbcharset","sha":"617e3ef8d9c1f7b327a0e3c1ac58e20b16684f98","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars2.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars2.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2017-03-27T18:52:09Z","pushed_at":"2017-03-28T18:40:07Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"https://open.vanillaforums.com","size":51220,"stargazers_count":1633,"watchers_count":1633,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":607,"mirror_url":null,"open_issues_count":432,"forks":607,"open_issues":432,"watchers":1633,"default_branch":"master"}},"base":{"label":"vanilla:master","ref":"master","sha":"62299cafa76fb1960ef871c410952298adf6835b","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars2.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars2.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2017-03-27T18:52:09Z","pushed_at":"2017-03-28T18:40:07Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"https://open.vanillaforums.com","size":51220,"stargazers_count":1633,"watchers_count":1633,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":607,"mirror_url":null,"open_issues_count":432,"forks":607,"open_issues":432,"watchers":1633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/5376"},"html":{"href":"https://github.com/vanilla/vanilla/pull/5376"},"issue":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/5376"},"comments":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/5376/comments"},"review_comments":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/5376/comments"},"review_comment":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/5376/commits"},"statuses":{"href":"https://api.github.com/repos/vanilla/vanilla/statuses/617e3ef8d9c1f7b327a0e3c1ac58e20b16684f98"}}}}
{"actor":{"display_login":"tburry"}}