{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/154634204","pull_request_review_id":80712059,"id":154634204,"diff_hunk":"@@ -555,14 +555,24 @@ def test_reduction_to_one_component():\n     assert(np.all(np.isfinite(X_embedded)))\n \n \n-def test_no_sparse_on_barnes_hut():\n+def test_sparse_on_barnes_hut_high_perplexity():\n+    # No sparse matrices allowed on Barnes-Hut.\n+    random_state = check_random_state(0)\n+    X = random_state.randn(100, 100)\n+    X[(np.random.randint(0, 100, 50), np.random.randint(0, 100, 50))] = 0.0\n+    X_csr = sp.csr_matrix(X)\n+    tsne = TSNE(n_iter=300, method='barnes_hut')","path":"sklearn/manifold/tests/test_t_sne.py","position":11,"original_position":11,"commit_id":"c51e60ffc0800aac5437b0cc48a2d32024a85cf1","original_commit_id":"c51e60ffc0800aac5437b0cc48a2d32024a85cf1","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"please set `random_state` to an int or to `random_state`","created_at":"2017-12-04T12:27:37Z","updated_at":"2017-12-04T12:28:10Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10206#discussion_r154634204","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/154634204"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10206#discussion_r154634204"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206","id":154681241,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/10206","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10206.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10206.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10206","number":10206,"state":"open","locked":false,"title":"[WIP] Modifies T-SNE for sparse matrix","user":{"login":"thechargedneutron","id":25536866,"avatar_url":"https://avatars1.githubusercontent.com/u/25536866?v=4","gravatar_id":"","url":"https://api.github.com/users/thechargedneutron","html_url":"https://github.com/thechargedneutron","followers_url":"https://api.github.com/users/thechargedneutron/followers","following_url":"https://api.github.com/users/thechargedneutron/following{/other_user}","gists_url":"https://api.github.com/users/thechargedneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/thechargedneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechargedneutron/subscriptions","organizations_url":"https://api.github.com/users/thechargedneutron/orgs","repos_url":"https://api.github.com/users/thechargedneutron/repos","events_url":"https://api.github.com/users/thechargedneutron/events{/privacy}","received_events_url":"https://api.github.com/users/thechargedneutron/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\nFixes #9691 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nModifies sklearn/neighbors/base.py \r\n\r\n#### Any other comments?\r\nNot sure about the complexity of the modification.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2017-11-26T14:26:29Z","updated_at":"2017-12-04T12:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3023af781fb2501f09ccbe9ffa9d1903b4a19ee","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10206/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c51e60ffc0800aac5437b0cc48a2d32024a85cf1","head":{"label":"thechargedneutron:tsne_csr","ref":"tsne_csr","sha":"c51e60ffc0800aac5437b0cc48a2d32024a85cf1","user":{"login":"thechargedneutron","id":25536866,"avatar_url":"https://avatars1.githubusercontent.com/u/25536866?v=4","gravatar_id":"","url":"https://api.github.com/users/thechargedneutron","html_url":"https://github.com/thechargedneutron","followers_url":"https://api.github.com/users/thechargedneutron/followers","following_url":"https://api.github.com/users/thechargedneutron/following{/other_user}","gists_url":"https://api.github.com/users/thechargedneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/thechargedneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechargedneutron/subscriptions","organizations_url":"https://api.github.com/users/thechargedneutron/orgs","repos_url":"https://api.github.com/users/thechargedneutron/repos","events_url":"https://api.github.com/users/thechargedneutron/events{/privacy}","received_events_url":"https://api.github.com/users/thechargedneutron/received_events","type":"User","site_admin":false},"repo":{"id":95851438,"name":"scikit-learn","full_name":"thechargedneutron/scikit-learn","owner":{"login":"thechargedneutron","id":25536866,"avatar_url":"https://avatars1.githubusercontent.com/u/25536866?v=4","gravatar_id":"","url":"https://api.github.com/users/thechargedneutron","html_url":"https://github.com/thechargedneutron","followers_url":"https://api.github.com/users/thechargedneutron/followers","following_url":"https://api.github.com/users/thechargedneutron/following{/other_user}","gists_url":"https://api.github.com/users/thechargedneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/thechargedneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechargedneutron/subscriptions","organizations_url":"https://api.github.com/users/thechargedneutron/orgs","repos_url":"https://api.github.com/users/thechargedneutron/repos","events_url":"https://api.github.com/users/thechargedneutron/events{/privacy}","received_events_url":"https://api.github.com/users/thechargedneutron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thechargedneutron/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/thechargedneutron/scikit-learn","forks_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/forks","keys_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/teams","hooks_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/events","assignees_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/tags","blobs_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/subscription","commits_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/merges","archive_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/downloads","issues_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/thechargedneutron/scikit-learn/deployments","created_at":"2017-06-30T05:20:22Z","updated_at":"2017-06-30T05:20:34Z","pushed_at":"2017-12-01T10:54:10Z","git_url":"git://github.com/thechargedneutron/scikit-learn.git","ssh_url":"git@github.com:thechargedneutron/scikit-learn.git","clone_url":"https://github.com/thechargedneutron/scikit-learn.git","svn_url":"https://github.com/thechargedneutron/scikit-learn","homepage":"http://scikit-learn.org","size":86135,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"5be2ec7777ce771fdb4f79112a0131ba61861c90","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2017-12-04T10:22:30Z","pushed_at":"2017-12-04T07:11:58Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":87290,"stargazers_count":23396,"watchers_count":23396,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12293,"mirror_url":null,"archived":false,"open_issues_count":1502,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":12293,"open_issues":1502,"watchers":23396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10206"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10206"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10206/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10206/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c51e60ffc0800aac5437b0cc48a2d32024a85cf1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jnothman"}}