{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/5","repository_url":"https://api.github.com/repos/redhat-openstack/easyfix","labels_url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/5/comments","events_url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/5/events","html_url":"https://github.com/redhat-openstack/easyfix/issues/5","id":242417321,"number":5,"title":"Replace rm -rf requirements.txt step with proper rpm macro","user":{"login":"chkumar246","id":7964197,"avatar_url":"https://avatars6.githubusercontent.com/u/7964197?v=4","gravatar_id":"","url":"https://api.github.com/users/chkumar246","html_url":"https://github.com/chkumar246","followers_url":"https://api.github.com/users/chkumar246/followers","following_url":"https://api.github.com/users/chkumar246/following{/other_user}","gists_url":"https://api.github.com/users/chkumar246/gists{/gist_id}","starred_url":"https://api.github.com/users/chkumar246/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chkumar246/subscriptions","organizations_url":"https://api.github.com/users/chkumar246/orgs","repos_url":"https://api.github.com/users/chkumar246/repos","events_url":"https://api.github.com/users/chkumar246/events{/privacy}","received_events_url":"https://api.github.com/users/chkumar246/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-12T15:16:32Z","updated_at":"2017-07-14T15:12:56Z","closed_at":null,"body":"In RDO packaging, we use **rm -rf requirements.txt/test-requirements.txt** in order to\r\navoid python package installation from pip during rpm package building process.\r\nSince from Pike release, we have to replace this step with rpm macro **%py_req_cleanup**.\r\n\r\n## How to reproduce:\r\n1. Clone openstack-nova spec file git clone https://github.com/rdo-packages/nova-distgit\r\n2. Go to nova-distgit and open openstack-nova.spec in editor.\r\n3. You can find **rm -rf {test-,}requirements.txt tools/{pip,test}-requires** under %prep section\r\n   in spec file.\r\n\r\n## How to fix:\r\n1. Replace ** rm -rf {test-,}requirements.txt tools/{pip,test}-requires ** with **%py_req_cleanup**\r\n2. Add **BuildRequires: openstack-macros** just below description section of main package.\r\n3. Add the changes file, commit it and send a Gerrit review. \r\n\r\n## Below is the list of packages which need same fixes:\r\n\r\n- [ ] [openstack-nova](https://github.com/rdo-packages/nova-distgit)\r\n- [ ] [openstack-glance](https://github.com/rdo-packages/glance-distgit)\r\n- [ ] [openstack-cinder](https://github.com/rdo-packages/cinder-distgit)\r\n- [ ] [openstack-swift](https://github.com/rdo-packages/swift-distgit)\r\n- [ ] [openstack-neutron](https://github.com/rdo-packages/neutron-distgit)\r\n- [ ] [openstack-keystone](https://github.com/rdo-packages/keystone-distgit)  \r\n\r\nMentor: chandankumar\r\nNote: Pick one of the package and comment in the comment box with review link.\r\n"},"comment":{"url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/comments/315385208","html_url":"https://github.com/redhat-openstack/easyfix/issues/5#issuecomment-315385208","issue_url":"https://api.github.com/repos/redhat-openstack/easyfix/issues/5","id":315385208,"user":{"login":"OGtrilliams","id":6244924,"avatar_url":"https://avatars7.githubusercontent.com/u/6244924?v=4","gravatar_id":"","url":"https://api.github.com/users/OGtrilliams","html_url":"https://github.com/OGtrilliams","followers_url":"https://api.github.com/users/OGtrilliams/followers","following_url":"https://api.github.com/users/OGtrilliams/following{/other_user}","gists_url":"https://api.github.com/users/OGtrilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/OGtrilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OGtrilliams/subscriptions","organizations_url":"https://api.github.com/users/OGtrilliams/orgs","repos_url":"https://api.github.com/users/OGtrilliams/repos","events_url":"https://api.github.com/users/OGtrilliams/events{/privacy}","received_events_url":"https://api.github.com/users/OGtrilliams/received_events","type":"User","site_admin":false},"created_at":"2017-07-14T15:12:56Z","updated_at":"2017-07-14T15:12:56Z","body":"Did glance, too https://review.rdoproject.org/r/#/c/7685/"}}
{"actor":{"display_login":"OGtrilliams"}}