{"action":"closed","number":2464,"pull_request":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/2464","id":113786511,"html_url":"https://github.com/stylelint/stylelint/pull/2464","diff_url":"https://github.com/stylelint/stylelint/pull/2464.diff","patch_url":"https://github.com/stylelint/stylelint/pull/2464.patch","issue_url":"https://api.github.com/repos/stylelint/stylelint/issues/2464","number":2464,"state":"closed","locked":false,"title":"Ignoring improvements","user":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars1.githubusercontent.com/u/628431?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"body":"The aim is to close #2399, close #2236 , and replace PR #2382.\r\n\r\n- As part of this, I've decided to remove the `allowEmptyInput`. I think that the opinion has come up before that we could just silently not lint any files, if no files match. This is what ESLint does, and I'm happy to stick with that. The reason I'm doing it here is that remove that option removes some complexity we would otherwise face with the new ignoring system.\r\n- Changes syntax of `.stylelintignore` from strict `.gitignore` globs to `node-glob` globs. I *think* this won't bother anybody, because it seems like [the `.gitignore` patterns](https://git-scm.com/docs/gitignore#_pattern_format) are a subset of the `node-glob` patterns — and I preserved the ability to add comments.\r\n\r\nThere's more work to be done, especially in finding code to delete and tests to clarify.","created_at":"2017-04-01T17:04:21Z","updated_at":"2017-04-22T17:22:43Z","closed_at":"2017-04-22T17:22:43Z","merged_at":"2017-04-22T17:22:43Z","merge_commit_sha":"ea33c176d99c62e1ebaa0abc048b1a00f0952948","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stylelint/stylelint/pulls/2464/commits","review_comments_url":"https://api.github.com/repos/stylelint/stylelint/pulls/2464/comments","review_comment_url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stylelint/stylelint/issues/2464/comments","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/32cfedd8c53346bb96ffe409eacc291a0bcaf54e","head":{"label":"stylelint:improve-ignore","ref":"improve-ignore","sha":"32cfedd8c53346bb96ffe409eacc291a0bcaf54e","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars3.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars3.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2017-04-22T06:47:48Z","pushed_at":"2017-04-22T17:22:43Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":6752,"stargazers_count":3151,"watchers_count":3151,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":61,"forks":258,"open_issues":61,"watchers":3151,"default_branch":"master"}},"base":{"label":"stylelint:v8","ref":"v8","sha":"07269622eb033f84ed00f7b8102f42f45e32b8b3","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars3.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars3.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2017-04-22T06:47:48Z","pushed_at":"2017-04-22T17:22:43Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":6752,"stargazers_count":3151,"watchers_count":3151,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":61,"forks":258,"open_issues":61,"watchers":3151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/2464"},"html":{"href":"https://github.com/stylelint/stylelint/pull/2464"},"issue":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/2464"},"comments":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/2464/comments"},"review_comments":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/2464/comments"},"review_comment":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/2464/commits"},"statuses":{"href":"https://api.github.com/repos/stylelint/stylelint/statuses/32cfedd8c53346bb96ffe409eacc291a0bcaf54e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars1.githubusercontent.com/u/628431?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":97,"deletions":288,"changed_files":15}}
{"actor":{"display_login":"davidtheclark"}}