{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/122775318","pull_request_review_id":44920164,"id":122775318,"diff_hunk":"@@ -216,33 +239,33 @@ public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain)\n \t\t\t\t\t\t\tvalue = value.substring(0, value.length() - 1);\n \t\t\t\t\t\t}\n \t\t\t\t\t\tquery.append(\"+\").append(structure.getVelocityVarName()).append(\".\").append(fieldMatches.get(counter)).append(\":\")\n-\t\t\t\t\t\t\t\t.append(value).append(\" \");\n+\t\t\t\t\t\t.append(value).append(\" \");\n \t\t\t\t\t\tcounter++;\n \t\t\t\t\t}\n-\t\t\t\t\t\n+\n \t\t\t\t\ttry {\n-\t\t\t\t\t    long sessionLang=WebAPILocator.getLanguageWebAPI().getLanguage(request).getId();\n-\t\t\t\t\t    long defaultLang=APILocator.getLanguageAPI().getDefaultLanguage().getId();\n-\t\t\t\t\t    boolean checkIndex=false;\n-\t\t\t\t\t  \n-                        if(request.getParameter(\"language_id\")==null && Config.getBooleanProperty(\"DEFAULT_CONTENT_TO_DEFAULT_LANGUAGE\",false)) {\n-                            // consider default language. respecting language_id in parameters\n-                            query.append(\" +(languageId:\").append(defaultLang).append(\" languageId:\").append(sessionLang).append(\") \");\n-                            checkIndex=true;\n-                        }else if(request.getParameter(\"language_id\")!=null){\n-                        \tquery.append(\" +languageId:\").append(languageId).append(\" \");\n-                        }else {\n-                            // respect session language\n-                            query.append(\" +languageId:\").append(sessionLang).append(\" \");\n-                        }\n-\t\t\t\t\t    \n+\t\t\t\t\t\tlong sessionLang=WebAPILocator.getLanguageWebAPI().getLanguage(request).getId();","path":"dotCMS/src/main/java/com/dotmarketing/cms/urlmap/filters/URLMapFilter.java","position":168,"original_position":168,"commit_id":"4e3d6b2ed2c2969752987e528ea8034e9fdb8e22","original_commit_id":"4e3d6b2ed2c2969752987e528ea8034e9fdb8e22","user":{"login":"oswaldogallango","id":1569280,"avatar_url":"https://avatars1.githubusercontent.com/u/1569280?v=3","gravatar_id":"","url":"https://api.github.com/users/oswaldogallango","html_url":"https://github.com/oswaldogallango","followers_url":"https://api.github.com/users/oswaldogallango/followers","following_url":"https://api.github.com/users/oswaldogallango/following{/other_user}","gists_url":"https://api.github.com/users/oswaldogallango/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldogallango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldogallango/subscriptions","organizations_url":"https://api.github.com/users/oswaldogallango/orgs","repos_url":"https://api.github.com/users/oswaldogallango/repos","events_url":"https://api.github.com/users/oswaldogallango/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldogallango/received_events","type":"User","site_admin":false},"body":"that code is old. ","created_at":"2017-06-19T17:43:35Z","updated_at":"2017-06-19T17:43:35Z","html_url":"https://github.com/dotCMS/core/pull/11907#discussion_r122775318","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/11907","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/122775318"},"html":{"href":"https://github.com/dotCMS/core/pull/11907#discussion_r122775318"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/11907"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/11907","id":125872229,"html_url":"https://github.com/dotCMS/core/pull/11907","diff_url":"https://github.com/dotCMS/core/pull/11907.diff","patch_url":"https://github.com/dotCMS/core/pull/11907.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/11907","number":11907,"state":"closed","locked":false,"title":"Issue 11825 replace vanity url resolver to use content","user":{"login":"oswaldogallango","id":1569280,"avatar_url":"https://avatars1.githubusercontent.com/u/1569280?v=3","gravatar_id":"","url":"https://api.github.com/users/oswaldogallango","html_url":"https://github.com/oswaldogallango","followers_url":"https://api.github.com/users/oswaldogallango/followers","following_url":"https://api.github.com/users/oswaldogallango/following{/other_user}","gists_url":"https://api.github.com/users/oswaldogallango/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldogallango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldogallango/subscriptions","organizations_url":"https://api.github.com/users/oswaldogallango/orgs","repos_url":"https://api.github.com/users/oswaldogallango/repos","events_url":"https://api.github.com/users/oswaldogallango/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldogallango/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-15T17:24:23Z","updated_at":"2017-06-19T17:43:35Z","closed_at":"2017-06-15T17:32:09Z","merged_at":"2017-06-15T17:32:09Z","merge_commit_sha":"84abce2b5b95afeff69c71def4f14e930c19babd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/11907/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/11907/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/11907/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/4e3d6b2ed2c2969752987e528ea8034e9fdb8e22","head":{"label":"dotCMS:issue-11825-replace-vanity-url-resolver-to-use-content","ref":"issue-11825-replace-vanity-url-resolver-to-use-content","sha":"4e3d6b2ed2c2969752987e528ea8034e9fdb8e22","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-06-14T03:05:55Z","pushed_at":"2017-06-19T16:24:14Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283055,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":1577,"forks":285,"open_issues":1577,"watchers":310,"default_branch":"master"}},"base":{"label":"dotCMS:issue-11627-create-vanity-url-basetype","ref":"issue-11627-create-vanity-url-basetype","sha":"262821d21a60e1fbd2463ee9c9450a75d966291f","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-06-14T03:05:55Z","pushed_at":"2017-06-19T16:24:14Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283055,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":1577,"forks":285,"open_issues":1577,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/11907"},"html":{"href":"https://github.com/dotCMS/core/pull/11907"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/11907"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/11907/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/11907/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/11907/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/4e3d6b2ed2c2969752987e528ea8034e9fdb8e22"}}}}
{"actor":{"display_login":"oswaldogallango"}}