{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/17891","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/17891/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/17891/comments","events_url":"https://api.github.com/repos/servo/servo/issues/17891/events","html_url":"https://github.com/servo/servo/pull/17891","id":246100148,"number":17891,"title":"Improved WebGL architecture","user":{"login":"MortimerGoro","id":1070794,"avatar_url":"https://avatars0.githubusercontent.com/u/1070794?v=4","gravatar_id":"","url":"https://api.github.com/users/MortimerGoro","html_url":"https://github.com/MortimerGoro","followers_url":"https://api.github.com/users/MortimerGoro/followers","following_url":"https://api.github.com/users/MortimerGoro/following{/other_user}","gists_url":"https://api.github.com/users/MortimerGoro/gists{/gist_id}","starred_url":"https://api.github.com/users/MortimerGoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MortimerGoro/subscriptions","organizations_url":"https://api.github.com/users/MortimerGoro/orgs","repos_url":"https://api.github.com/users/MortimerGoro/repos","events_url":"https://api.github.com/users/MortimerGoro/events{/privacy}","received_events_url":"https://api.github.com/users/MortimerGoro/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"glennw","id":2350882,"avatar_url":"https://avatars0.githubusercontent.com/u/2350882?v=4","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"assignees":[{"login":"glennw","id":2350882,"avatar_url":"https://avatars0.githubusercontent.com/u/2350882?v=4","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":53,"created_at":"2017-07-27T16:37:34Z","updated_at":"2017-08-15T21:00:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/17891","html_url":"https://github.com/servo/servo/pull/17891","diff_url":"https://github.com/servo/servo/pull/17891.diff","patch_url":"https://github.com/servo/servo/pull/17891.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nInfo about the big picture and the goals of the WebGL refactor in this thread: https://groups.google.com/forum/#!topic/mozilla.dev.servo/0WMGz60kKzQ\r\n\r\nI tried to reduce this PR as much as possible as requested in the thread. I'll do separate PRs for other features (e.g.: Batch messages or use shared memory to improve frame times) or fixes.\r\n\r\nSome tips to ease the review process:  \r\n- Most changes in DOM objects follow the same pattern (remove CanvasMsg wrapper and use the new sender method). \r\n- WebGLCommands are the same ones as before (moved from webrender_api). So those lines are already reviewed.\r\n- See WebGL traits in [components/canvas_traits/webgl.rs](https://github.com/servo/servo/pull/17891/files#diff-8701045d01505418701d0631d4d45562)\r\n- See WebGLThread and WR External Image bridge in [components/canvas/webgl_thread.rs](https://github.com/servo/servo/pull/17891/files#diff-281554879f39a2a041f7a69d442a5d2e)\r\n- The implementation submitted in this PR creates a single `WebGLThread` for all ScriptThread/Pipelines. See that in [components/canvas/webgl_mode/inprocess.rs](https://github.com/servo/servo/pull/17891/files#diff-250070c6c5a38c7f9fa0f5b3c101f68b)\r\n\r\nThe conformance tests will help to guarantee that we don't miss anything.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/17891)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/322587444","html_url":"https://github.com/servo/servo/pull/17891#issuecomment-322587444","issue_url":"https://api.github.com/repos/servo/servo/issues/17891","id":322587444,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars1.githubusercontent.com/u/4368172?v=4","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T21:00:07Z","updated_at":"2017-08-15T21:00:07Z","body":":pushpin: Commit 703962f has been approved by `glennw,emilio`\n\n<!-- @bors-servo r=glennw,emilio 703962fe61d673536eb982b45795ae13748f0f6a -->"}}
{"actor":{"display_login":"bors-servo"}}