{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/comments/118902985","pull_request_review_id":40737698,"id":118902985,"diff_hunk":"@@ -658,70 +658,26 @@ write_files:\n   permissions: 0544\n   content: |\n       #!/bin/bash\n-      while ! curl --output /dev/null --silent --head --fail --cacert /etc/kubernetes/ssl/apiserver-ca.pem --cert /etc/kubernetes/ssl/apiserver-crt.pem --key /etc/kubernetes/ssl/apiserver-key.pem \"https://{{.Cluster.Kubernetes.API.Domain}}:443\"; do sleep 1 && echo 'Waiting for master'; done\n-      curl -o /opt/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.6.1/bin/linux/amd64/kubectl \n+      # get kubectl\n+      curl -o /opt/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.6.1/bin/linux/amd64/kubectl","path":"templates.go","position":7,"original_position":7,"commit_id":"3d1209167e3918f5758841a94b90cbbe0f7ce432","original_commit_id":"3d1209167e3918f5758841a94b90cbbe0f7ce432","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars0.githubusercontent.com/u/552769?v=3","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"This should actually be configured via the clustertpr. See https://github.com/giantswarm/kubernetesd/blob/a8528d72f2a2ff7b37c5d6674684a03c543830c1/kubernetes/configmap.yaml#L90. I realize now that this is not specific to KVM so the config should be moved in kubernetesd. Anyway, at the moment here the URL should be replaced by something like this. \r\n\r\n```\r\ncurl -o /opt/bin/kubectl {{ .Cluster.KVM.Kubectl.GoogleAPI.URL }}\r\n```\r\n\r\nLets please create an issue for this and address it in the next steps. ","created_at":"2017-05-29T09:44:30Z","updated_at":"2017-05-29T09:45:16Z","html_url":"https://github.com/giantswarm/k8scloudconfig/pull/135#discussion_r118902985","pull_request_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/comments/118902985"},"html":{"href":"https://github.com/giantswarm/k8scloudconfig/pull/135#discussion_r118902985"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135","id":122860488,"html_url":"https://github.com/giantswarm/k8scloudconfig/pull/135","diff_url":"https://github.com/giantswarm/k8scloudconfig/pull/135.diff","patch_url":"https://github.com/giantswarm/k8scloudconfig/pull/135.patch","issue_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/135","number":135,"state":"open","locked":false,"title":"k8s addons v2","user":{"login":"calvix","id":7136358,"avatar_url":"https://avatars0.githubusercontent.com/u/7136358?v=3","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"body":"redesign of k8s-addons script\r\n\r\n* moving to `kubectl`\r\n* doing retries when `apply` fails\r\n* moving files to array so we don't have to repeat same shit hundred times\r\nping @giantswarm/team-positive ","created_at":"2017-05-29T09:38:40Z","updated_at":"2017-05-29T09:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f23b942d34b92c6e7c776eeaf1c168aa38cc4c62","assignee":{"login":"calvix","id":7136358,"avatar_url":"https://avatars0.githubusercontent.com/u/7136358?v=3","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvix","id":7136358,"avatar_url":"https://avatars0.githubusercontent.com/u/7136358?v=3","gravatar_id":"","url":"https://api.github.com/users/calvix","html_url":"https://github.com/calvix","followers_url":"https://api.github.com/users/calvix/followers","following_url":"https://api.github.com/users/calvix/following{/other_user}","gists_url":"https://api.github.com/users/calvix/gists{/gist_id}","starred_url":"https://api.github.com/users/calvix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvix/subscriptions","organizations_url":"https://api.github.com/users/calvix/orgs","repos_url":"https://api.github.com/users/calvix/repos","events_url":"https://api.github.com/users/calvix/events{/privacy}","received_events_url":"https://api.github.com/users/calvix/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"puja108","id":5468872,"avatar_url":"https://avatars0.githubusercontent.com/u/5468872?v=3","gravatar_id":"","url":"https://api.github.com/users/puja108","html_url":"https://github.com/puja108","followers_url":"https://api.github.com/users/puja108/followers","following_url":"https://api.github.com/users/puja108/following{/other_user}","gists_url":"https://api.github.com/users/puja108/gists{/gist_id}","starred_url":"https://api.github.com/users/puja108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puja108/subscriptions","organizations_url":"https://api.github.com/users/puja108/orgs","repos_url":"https://api.github.com/users/puja108/repos","events_url":"https://api.github.com/users/puja108/events{/privacy}","received_events_url":"https://api.github.com/users/puja108/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135/commits","review_comments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135/comments","review_comment_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/135/comments","statuses_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/statuses/3d1209167e3918f5758841a94b90cbbe0f7ce432","head":{"label":"giantswarm:k8s-addons-v2","ref":"k8s-addons-v2","sha":"3d1209167e3918f5758841a94b90cbbe0f7ce432","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":83027219,"name":"k8scloudconfig","full_name":"giantswarm/k8scloudconfig","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/k8scloudconfig","description":"Cloud-init configuration for setting up Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/giantswarm/k8scloudconfig","forks_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/forks","keys_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/teams","hooks_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/events","assignees_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/tags","blobs_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/languages","stargazers_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/subscription","commits_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/merges","archive_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/downloads","issues_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/deployments","created_at":"2017-02-24T09:54:14Z","updated_at":"2017-05-16T14:10:15Z","pushed_at":"2017-05-29T09:38:41Z","git_url":"git://github.com/giantswarm/k8scloudconfig.git","ssh_url":"git@github.com:giantswarm/k8scloudconfig.git","clone_url":"https://github.com/giantswarm/k8scloudconfig.git","svn_url":"https://github.com/giantswarm/k8scloudconfig","homepage":null,"size":2514,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"598dcd84ccf3dd184f135e48e06e260456e141f5","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":83027219,"name":"k8scloudconfig","full_name":"giantswarm/k8scloudconfig","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/k8scloudconfig","description":"Cloud-init configuration for setting up Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/giantswarm/k8scloudconfig","forks_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/forks","keys_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/teams","hooks_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/events","assignees_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/tags","blobs_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/languages","stargazers_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/subscription","commits_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/merges","archive_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/downloads","issues_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/k8scloudconfig/deployments","created_at":"2017-02-24T09:54:14Z","updated_at":"2017-05-16T14:10:15Z","pushed_at":"2017-05-29T09:38:41Z","git_url":"git://github.com/giantswarm/k8scloudconfig.git","ssh_url":"git@github.com:giantswarm/k8scloudconfig.git","clone_url":"https://github.com/giantswarm/k8scloudconfig.git","svn_url":"https://github.com/giantswarm/k8scloudconfig","homepage":null,"size":2514,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135"},"html":{"href":"https://github.com/giantswarm/k8scloudconfig/pull/135"},"issue":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/135"},"comments":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/k8scloudconfig/statuses/3d1209167e3918f5758841a94b90cbbe0f7ce432"}}}}
{"actor":{"display_login":"xh3b4sd"}}