{"action":"created","comment":{"url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/comments/137685771","pull_request_review_id":61386612,"id":137685771,"diff_hunk":"@@ -27,13 +27,11 @@ main() {\n   done\n \n   echo 'Running shellcheck'\n-  git grep -l '^#!/usr/bin/env bash' | xargs shellcheck\n-  # Temporarily disable shellcheck checks for SC2154 (undefined variable) on /bin/bash files\n-  git grep -l '^#!/bin/bash' | xargs shellcheck -e SC2154\n+  # Note: shellcheck checks for SC2154 (undefined variable) are disabled by '-e SC2154' below\n+  git grep -El '^#!/.+\\b(bash|sh)\\b' | xargs shellcheck -e SC2154","path":"runtests","position":8,"original_position":8,"commit_id":"07d6d69d077ef1d02bb2471438cb2af19e9998b8","original_commit_id":"07d6d69d077ef1d02bb2471438cb2af19e9998b8","user":{"login":"meatballhat","id":45143,"avatar_url":"https://avatars0.githubusercontent.com/u/45143?v=4","gravatar_id":"","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User","site_admin":false},"body":"I want to make sure we still check for undefined variables most of the time.  It's not documented here, but this was my original intent with using different shebangs (yes, a not great decision...).  I would prefer all files to manage individual shellcheck rules locally via comments.","created_at":"2017-09-08T00:17:56Z","updated_at":"2017-09-08T00:18:14Z","html_url":"https://github.com/travis-infrastructure/terraform-config/pull/210#discussion_r137685771","pull_request_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/comments/137685771"},"html":{"href":"https://github.com/travis-infrastructure/terraform-config/pull/210#discussion_r137685771"},"pull_request":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210","id":137253368,"html_url":"https://github.com/travis-infrastructure/terraform-config/pull/210","diff_url":"https://github.com/travis-infrastructure/terraform-config/pull/210.diff","patch_url":"https://github.com/travis-infrastructure/terraform-config/pull/210.patch","issue_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/210","number":210,"state":"open","locked":false,"title":"Identify shell files more classily","user":{"login":"soulshake","id":1585815,"avatar_url":"https://avatars1.githubusercontent.com/u/1585815?v=4","gravatar_id":"","url":"https://api.github.com/users/soulshake","html_url":"https://github.com/soulshake","followers_url":"https://api.github.com/users/soulshake/followers","following_url":"https://api.github.com/users/soulshake/following{/other_user}","gists_url":"https://api.github.com/users/soulshake/gists{/gist_id}","starred_url":"https://api.github.com/users/soulshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulshake/subscriptions","organizations_url":"https://api.github.com/users/soulshake/orgs","repos_url":"https://api.github.com/users/soulshake/repos","events_url":"https://api.github.com/users/soulshake/events{/privacy}","received_events_url":"https://api.github.com/users/soulshake/received_events","type":"User","site_admin":false},"body":"Please make sure you cover the following points:\r\n\r\n1. What is the problem that this PR is trying to fix?\r\n\r\nResolves #185 \r\n\r\n2. What approach did you choose and why?\r\n\r\nUse extended regex to check for shell files (as suggested by @edmorley)\r\n\r\n3. How can you test this?\r\n\r\nRun `./runtests` or `git grep -El '^#!/.+\\b(bash|sh)\\b'` in the repo root to view files identified as bash.\r\n\r\n(4. What feedback would you like?)\r\n","created_at":"2017-08-23T15:46:24Z","updated_at":"2017-09-08T00:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d79f7c69739f89ca9e001f77c47847a7ad78b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210/commits","review_comments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210/comments","review_comment_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/210/comments","statuses_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/statuses/07d6d69d077ef1d02bb2471438cb2af19e9998b8","head":{"label":"travis-infrastructure:shfmt","ref":"shfmt","sha":"07d6d69d077ef1d02bb2471438cb2af19e9998b8","user":{"login":"travis-infrastructure","id":10242389,"avatar_url":"https://avatars2.githubusercontent.com/u/10242389?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-infrastructure","html_url":"https://github.com/travis-infrastructure","followers_url":"https://api.github.com/users/travis-infrastructure/followers","following_url":"https://api.github.com/users/travis-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/travis-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/travis-infrastructure/orgs","repos_url":"https://api.github.com/users/travis-infrastructure/repos","events_url":"https://api.github.com/users/travis-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/travis-infrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":57980877,"name":"terraform-config","full_name":"travis-infrastructure/terraform-config","owner":{"login":"travis-infrastructure","id":10242389,"avatar_url":"https://avatars2.githubusercontent.com/u/10242389?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-infrastructure","html_url":"https://github.com/travis-infrastructure","followers_url":"https://api.github.com/users/travis-infrastructure/followers","following_url":"https://api.github.com/users/travis-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/travis-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/travis-infrastructure/orgs","repos_url":"https://api.github.com/users/travis-infrastructure/repos","events_url":"https://api.github.com/users/travis-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/travis-infrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-infrastructure/terraform-config","description":"Terraform bits","fork":false,"url":"https://api.github.com/repos/travis-infrastructure/terraform-config","forks_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/forks","keys_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/teams","hooks_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/hooks","issue_events_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/events{/number}","events_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/events","assignees_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/assignees{/user}","branches_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/branches{/branch}","tags_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/tags","blobs_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/languages","stargazers_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/stargazers","contributors_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/contributors","subscribers_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/subscribers","subscription_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/subscription","commits_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/contents/{+path}","compare_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/merges","archive_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/downloads","issues_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues{/number}","pulls_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/labels{/name}","releases_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/releases{/id}","deployments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/deployments","created_at":"2016-05-03T15:40:41Z","updated_at":"2017-08-09T10:17:01Z","pushed_at":"2017-09-08T00:16:36Z","git_url":"git://github.com/travis-infrastructure/terraform-config.git","ssh_url":"git@github.com:travis-infrastructure/terraform-config.git","clone_url":"https://github.com/travis-infrastructure/terraform-config.git","svn_url":"https://github.com/travis-infrastructure/terraform-config","homepage":"","size":679,"stargazers_count":26,"watchers_count":26,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":26,"default_branch":"master"}},"base":{"label":"travis-infrastructure:master","ref":"master","sha":"b5c06115492177d6ac4eacd2d2838a4bae59cb8e","user":{"login":"travis-infrastructure","id":10242389,"avatar_url":"https://avatars2.githubusercontent.com/u/10242389?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-infrastructure","html_url":"https://github.com/travis-infrastructure","followers_url":"https://api.github.com/users/travis-infrastructure/followers","following_url":"https://api.github.com/users/travis-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/travis-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/travis-infrastructure/orgs","repos_url":"https://api.github.com/users/travis-infrastructure/repos","events_url":"https://api.github.com/users/travis-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/travis-infrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":57980877,"name":"terraform-config","full_name":"travis-infrastructure/terraform-config","owner":{"login":"travis-infrastructure","id":10242389,"avatar_url":"https://avatars2.githubusercontent.com/u/10242389?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-infrastructure","html_url":"https://github.com/travis-infrastructure","followers_url":"https://api.github.com/users/travis-infrastructure/followers","following_url":"https://api.github.com/users/travis-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/travis-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/travis-infrastructure/orgs","repos_url":"https://api.github.com/users/travis-infrastructure/repos","events_url":"https://api.github.com/users/travis-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/travis-infrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-infrastructure/terraform-config","description":"Terraform bits","fork":false,"url":"https://api.github.com/repos/travis-infrastructure/terraform-config","forks_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/forks","keys_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/teams","hooks_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/hooks","issue_events_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/events{/number}","events_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/events","assignees_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/assignees{/user}","branches_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/branches{/branch}","tags_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/tags","blobs_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/languages","stargazers_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/stargazers","contributors_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/contributors","subscribers_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/subscribers","subscription_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/subscription","commits_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/contents/{+path}","compare_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/merges","archive_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/downloads","issues_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues{/number}","pulls_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/labels{/name}","releases_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/releases{/id}","deployments_url":"https://api.github.com/repos/travis-infrastructure/terraform-config/deployments","created_at":"2016-05-03T15:40:41Z","updated_at":"2017-08-09T10:17:01Z","pushed_at":"2017-09-08T00:16:36Z","git_url":"git://github.com/travis-infrastructure/terraform-config.git","ssh_url":"git@github.com:travis-infrastructure/terraform-config.git","clone_url":"https://github.com/travis-infrastructure/terraform-config.git","svn_url":"https://github.com/travis-infrastructure/terraform-config","homepage":"","size":679,"stargazers_count":26,"watchers_count":26,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210"},"html":{"href":"https://github.com/travis-infrastructure/terraform-config/pull/210"},"issue":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/210"},"comments":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/travis-infrastructure/terraform-config/statuses/07d6d69d077ef1d02bb2471438cb2af19e9998b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"meatballhat"}}