{"action":"created","comment":{"url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/comments/156022312","pull_request_review_id":82430396,"id":156022312,"diff_hunk":"@@ -578,14 +578,16 @@ void tbtadm::Controller::approveAll(const fs::path& dir)\n // TODO: move to tbtadm-helper\n void tbtadm::Controller::approve(const fs::path& dir) try\n {\n+    bool already_authorized = false;\n+\n     chdir(dir);\n     m_out << \"Authorizing \" << dir << '\\n';\n \n     File authorized(authorizedFilename, File::Mode::Read);","path":"tbtadm/controller.cpp","position":9,"original_position":9,"commit_id":"d8661ddfe4ca5e476ebffc629c8f0f5a9ca576b3","original_commit_id":"d8661ddfe4ca5e476ebffc629c8f0f5a9ca576b3","user":{"login":"ybernat","id":11313010,"avatar_url":"https://avatars1.githubusercontent.com/u/11313010?v=4","gravatar_id":"","url":"https://api.github.com/users/ybernat","html_url":"https://github.com/ybernat","followers_url":"https://api.github.com/users/ybernat/followers","following_url":"https://api.github.com/users/ybernat/following{/other_user}","gists_url":"https://api.github.com/users/ybernat/gists{/gist_id}","starred_url":"https://api.github.com/users/ybernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybernat/subscriptions","organizations_url":"https://api.github.com/users/ybernat/orgs","repos_url":"https://api.github.com/users/ybernat/repos","events_url":"https://api.github.com/users/ybernat/events{/privacy}","received_events_url":"https://api.github.com/users/ybernat/received_events","type":"User","site_admin":false},"body":"The check can be moved to after the adding to ACL, if the addition is done anyway.","created_at":"2017-12-11T09:42:39Z","updated_at":"2017-12-11T09:45:29Z","html_url":"https://github.com/01org/thunderbolt-software-user-space/pull/36#discussion_r156022312","pull_request_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/comments/156022312"},"html":{"href":"https://github.com/01org/thunderbolt-software-user-space/pull/36#discussion_r156022312"},"pull_request":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36","id":157500464,"html_url":"https://github.com/01org/thunderbolt-software-user-space/pull/36","diff_url":"https://github.com/01org/thunderbolt-software-user-space/pull/36.diff","patch_url":"https://github.com/01org/thunderbolt-software-user-space/pull/36.patch","issue_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/36","number":36,"state":"open","locked":false,"title":"RFC: continue with ACL if device already authorized","user":{"login":"finikorg","id":3072104,"avatar_url":"https://avatars2.githubusercontent.com/u/3072104?v=4","gravatar_id":"","url":"https://api.github.com/users/finikorg","html_url":"https://github.com/finikorg","followers_url":"https://api.github.com/users/finikorg/followers","following_url":"https://api.github.com/users/finikorg/following{/other_user}","gists_url":"https://api.github.com/users/finikorg/gists{/gist_id}","starred_url":"https://api.github.com/users/finikorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finikorg/subscriptions","organizations_url":"https://api.github.com/users/finikorg/orgs","repos_url":"https://api.github.com/users/finikorg/repos","events_url":"https://api.github.com/users/finikorg/events{/privacy}","received_events_url":"https://api.github.com/users/finikorg/received_events","type":"User","site_admin":false},"body":"In a case device is authorized during boot time approve should just\r\nadd device to ACL.\r\n\r\nFixes: #34","created_at":"2017-12-11T08:13:20Z","updated_at":"2017-12-11T09:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2f35c2f9fc7dedd98e5cdd02c6ea4e832ef6884","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36/commits","review_comments_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36/comments","review_comment_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/36/comments","statuses_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/statuses/d8661ddfe4ca5e476ebffc629c8f0f5a9ca576b3","head":{"label":"finikorg:tbtadm","ref":"tbtadm","sha":"d8661ddfe4ca5e476ebffc629c8f0f5a9ca576b3","user":{"login":"finikorg","id":3072104,"avatar_url":"https://avatars2.githubusercontent.com/u/3072104?v=4","gravatar_id":"","url":"https://api.github.com/users/finikorg","html_url":"https://github.com/finikorg","followers_url":"https://api.github.com/users/finikorg/followers","following_url":"https://api.github.com/users/finikorg/following{/other_user}","gists_url":"https://api.github.com/users/finikorg/gists{/gist_id}","starred_url":"https://api.github.com/users/finikorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finikorg/subscriptions","organizations_url":"https://api.github.com/users/finikorg/orgs","repos_url":"https://api.github.com/users/finikorg/repos","events_url":"https://api.github.com/users/finikorg/events{/privacy}","received_events_url":"https://api.github.com/users/finikorg/received_events","type":"User","site_admin":false},"repo":{"id":112590123,"name":"thunderbolt-software-user-space","full_name":"finikorg/thunderbolt-software-user-space","owner":{"login":"finikorg","id":3072104,"avatar_url":"https://avatars2.githubusercontent.com/u/3072104?v=4","gravatar_id":"","url":"https://api.github.com/users/finikorg","html_url":"https://github.com/finikorg","followers_url":"https://api.github.com/users/finikorg/followers","following_url":"https://api.github.com/users/finikorg/following{/other_user}","gists_url":"https://api.github.com/users/finikorg/gists{/gist_id}","starred_url":"https://api.github.com/users/finikorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finikorg/subscriptions","organizations_url":"https://api.github.com/users/finikorg/orgs","repos_url":"https://api.github.com/users/finikorg/repos","events_url":"https://api.github.com/users/finikorg/events{/privacy}","received_events_url":"https://api.github.com/users/finikorg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/finikorg/thunderbolt-software-user-space","description":null,"fork":true,"url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space","forks_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/forks","keys_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/teams","hooks_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/hooks","issue_events_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/issues/events{/number}","events_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/events","assignees_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/assignees{/user}","branches_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/branches{/branch}","tags_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/tags","blobs_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/statuses/{sha}","languages_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/languages","stargazers_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/stargazers","contributors_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/contributors","subscribers_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/subscribers","subscription_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/subscription","commits_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/contents/{+path}","compare_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/merges","archive_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/downloads","issues_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/issues{/number}","pulls_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/pulls{/number}","milestones_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/milestones{/number}","notifications_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/labels{/name}","releases_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/releases{/id}","deployments_url":"https://api.github.com/repos/finikorg/thunderbolt-software-user-space/deployments","created_at":"2017-11-30T09:10:27Z","updated_at":"2017-11-30T09:10:29Z","pushed_at":"2017-12-11T09:27:18Z","git_url":"git://github.com/finikorg/thunderbolt-software-user-space.git","ssh_url":"git@github.com:finikorg/thunderbolt-software-user-space.git","clone_url":"https://github.com/finikorg/thunderbolt-software-user-space.git","svn_url":"https://github.com/finikorg/thunderbolt-software-user-space","homepage":null,"size":4792,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"695ba9ec24d35cd261b3b03a096c536966e1ecb0","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":30654586,"name":"thunderbolt-software-user-space","full_name":"01org/thunderbolt-software-user-space","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/thunderbolt-software-user-space","description":null,"fork":false,"url":"https://api.github.com/repos/01org/thunderbolt-software-user-space","forks_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/forks","keys_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/teams","hooks_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/hooks","issue_events_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/events{/number}","events_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/events","assignees_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/assignees{/user}","branches_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/branches{/branch}","tags_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/tags","blobs_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/languages","stargazers_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/stargazers","contributors_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/contributors","subscribers_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/subscribers","subscription_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/subscription","commits_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/contents/{+path}","compare_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/merges","archive_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/downloads","issues_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues{/number}","pulls_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/labels{/name}","releases_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/releases{/id}","deployments_url":"https://api.github.com/repos/01org/thunderbolt-software-user-space/deployments","created_at":"2015-02-11T15:35:05Z","updated_at":"2017-12-08T08:05:43Z","pushed_at":"2017-12-11T09:24:15Z","git_url":"git://github.com/01org/thunderbolt-software-user-space.git","ssh_url":"git@github.com:01org/thunderbolt-software-user-space.git","clone_url":"https://github.com/01org/thunderbolt-software-user-space.git","svn_url":"https://github.com/01org/thunderbolt-software-user-space","homepage":null,"size":4790,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":16,"open_issues":5,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36"},"html":{"href":"https://github.com/01org/thunderbolt-software-user-space/pull/36"},"issue":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/36"},"comments":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/01org/thunderbolt-software-user-space/statuses/d8661ddfe4ca5e476ebffc629c8f0f5a9ca576b3"}},"author_association":"NONE"}}
{"actor":{"display_login":"ybernat"}}