{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/101097598","pull_request_review_id":21817420,"id":101097598,"diff_hunk":"@@ -66,6 +66,59 @@ DOMCanvasFactory.prototype = {\n   }\n };\n \n+var DOMCMapReaderFactory = (function DOMCMapReaderFactoryClosure() {\n+  function DOMCMapReaderFactory(params) {\n+    this.baseUrl = params.baseUrl || null;\n+    this.binary = params.binary || false;\n+  }\n+\n+  DOMCMapReaderFactory.prototype = {\n+    fetch: function(params) {\n+      if (!params.name) {\n+        return Promise.reject(new Error('CMap name must be specified.'));\n+      }\n+      return new Promise(function (resolve, reject) {\n+        var url = this.baseUrl + params.name;\n+\n+        var request = new XMLHttpRequest();\n+        if (this.binary) {\n+          url += '.bcmap';\n+          request.responseType = 'arraybuffer';\n+        }\n+        request.onreadystatechange = function () {\n+          if (request.readyState === XMLHttpRequest.DONE &&\n+              (request.status === 200 || request.status === 0)) {\n+            var data;\n+            if (this.binary && request.response) {\n+              data = new Uint8Array(request.response);\n+            } else if (!this.binary && request.responseText) {\n+              var arr = Array.prototype.map.call(request.responseText,","path":"src/display/dom_utils.js","position":null,"original_position":30,"commit_id":"238ab383403646ff8f694360b35337fa3afd2f63","original_commit_id":"699e2900a168a102fc3af5bc797562d723fa9187","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Good point, fixed now.","created_at":"2017-02-14T17:49:12Z","updated_at":"2017-02-14T17:49:12Z","html_url":"https://github.com/mozilla/pdf.js/pull/8064#discussion_r101097598","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/101097598"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/8064#discussion_r101097598"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064","id":105797696,"html_url":"https://github.com/mozilla/pdf.js/pull/8064","diff_url":"https://github.com/mozilla/pdf.js/pull/8064.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/8064.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/8064","number":8064,"state":"open","locked":false,"title":"[api-minor] Refactor fetching of built-in CMaps to utilize a factory on the `display` side instead, to allow users of the API to provide a custom CMap loading factory (e.g. for use with Node.js)","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Currently the built-in CMap files are loaded in `src/core/cmap.js` using `XMLHttpRequest` directly. For some environments that might be a problem, hence this patch refactors that to instead use a factory to load built-in CMaps on the main thread and message the data to the worker thread.\r\n\r\nThis is inspired by other recent work, e.g. the addition of the `CanvasFactory`, and to a large extent on the IRC discussion starting at http://logs.glob.uno/?c=mozilla%23pdfjs&s=12+Oct+2016&e=12+Oct+2016#c53010.\r\n\r\n*Please note:* While it certainly may be possible to improve the patch, it does work just fine locally as-is, i.e. the viewer still works and all unit/font/reference tests pass.\r\n\r\n@yurydelendik Since this PR attempts to implement your idea from http://logs.glob.uno/?c=mozilla%23pdfjs&s=12+Oct+2016&e=12+Oct+2016#c53018, I'd appreciate if you could provide feedback on the implementation when you've got time.\r\n\r\n***Edit:*** Based on this PR, we should e.g. be able to get the CMap unit-tests running on Travis, by providing a custom Node.js factory for the unit-test.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mozilla/pdf.js/8064)\n<!-- Reviewable:end -->\n","created_at":"2017-02-12T16:57:36Z","updated_at":"2017-02-14T17:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2eafd0338ccfdda0c86d930361bd4e7a54cc373","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/8064/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/238ab383403646ff8f694360b35337fa3afd2f63","head":{"label":"Snuffleupagus:fetchBuiltInCMap","ref":"fetchBuiltInCMap","sha":"238ab383403646ff8f694360b35337fa3afd2f63","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"repo":{"id":7120249,"name":"pdf.js","full_name":"Snuffleupagus/pdf.js","owner":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Snuffleupagus/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js","forks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/forks","keys_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/teams","hooks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/events","assignees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/tags","blobs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/languages","stargazers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscription","commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/merges","archive_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/downloads","issues_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/deployments","created_at":"2012-12-11T22:06:46Z","updated_at":"2015-05-08T20:06:28Z","pushed_at":"2017-02-14T17:45:53Z","git_url":"git://github.com/Snuffleupagus/pdf.js.git","ssh_url":"git@github.com:Snuffleupagus/pdf.js.git","clone_url":"https://github.com/Snuffleupagus/pdf.js.git","svn_url":"https://github.com/Snuffleupagus/pdf.js","homepage":"","size":60950,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"b509a3f83cf7c8d93f5ed34167f29218078ef1f8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2017-02-14T15:59:24Z","pushed_at":"2017-02-14T17:46:06Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":62725,"stargazers_count":16935,"watchers_count":16935,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4065,"mirror_url":null,"open_issues_count":596,"forks":4065,"open_issues":596,"watchers":16935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/8064"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/8064"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/8064/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/8064/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/238ab383403646ff8f694360b35337fa3afd2f63"}}}}
{"actor":{"display_login":"Snuffleupagus"}}