{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/18192","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/18192/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/18192/comments","events_url":"https://api.github.com/repos/apache/spark/issues/18192/events","html_url":"https://github.com/apache/spark/pull/18192","id":233372235,"number":18192,"title":"[SPARK-20944][SHUFFLE] Move shouldBypassMergeSort from SortShuffleWriter to SortShuffleManager","user":{"login":"zhengcanbin","id":26545140,"avatar_url":"https://avatars2.githubusercontent.com/u/26545140?v=4","gravatar_id":"","url":"https://api.github.com/users/zhengcanbin","html_url":"https://github.com/zhengcanbin","followers_url":"https://api.github.com/users/zhengcanbin/followers","following_url":"https://api.github.com/users/zhengcanbin/following{/other_user}","gists_url":"https://api.github.com/users/zhengcanbin/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengcanbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengcanbin/subscriptions","organizations_url":"https://api.github.com/users/zhengcanbin/orgs","repos_url":"https://api.github.com/users/zhengcanbin/repos","events_url":"https://api.github.com/users/zhengcanbin/events{/privacy}","received_events_url":"https://api.github.com/users/zhengcanbin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-06-03T14:19:41Z","updated_at":"2017-07-31T00:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18192","html_url":"https://github.com/apache/spark/pull/18192","diff_url":"https://github.com/apache/spark/pull/18192.diff","patch_url":"https://github.com/apache/spark/pull/18192.patch"},"body":"## What changes were proposed in this pull request?\r\n There exists three `ShuffleWriter ` implementations, we first use the helper method `SortShuffleWriter#shouldBypassMergeSort` to determine whether a shuffle should use `BypassMergeSort` path，and then use another helper method `SortShuffleManager#canUseSerializedShuffle` for deciding `UnsafeShuffleWriter` path. From view of code structure consistency，method `shouldBypassMergeSort` should not belong to `SortShuffleWriter`，it should be included in `BypassMergeSortShuffleWriter` or `SortShuffleManager`, and better for the later one to put the two helper methods together. \r\n\r\n## How was this patch tested?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/318940638","html_url":"https://github.com/apache/spark/pull/18192#issuecomment-318940638","issue_url":"https://api.github.com/repos/apache/spark/issues/18192","id":318940638,"user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars0.githubusercontent.com/u/6477701?v=4","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T00:21:49Z","updated_at":"2017-07-31T00:21:49Z","body":"Okay, I won't go merging it without an explicit +1. @zhengcanbin, would you mind closing this PR/JIRA, and watching PRs and suggesting this fix latter?"}}
{"actor":{"display_login":"HyukjinKwon"}}