{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1917","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1917/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1917/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1917/events","html_url":"https://github.com/Microsoft/ChakraCore/issues/1917","id":187254966,"number":1917,"title":"JSRT: Inconsistent Callback behavior ","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars1.githubusercontent.com/u/4390745?v=4","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"labels":[{"id":507522376,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/APIs","name":"APIs","color":"009075","default":false},{"id":307793022,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/Bug","name":"Bug","color":"fc2929","default":false},{"id":307793007,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/Discussion","name":"Discussion","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones/4","html_url":"https://github.com/Microsoft/ChakraCore/milestone/4","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones/4/labels","id":1952537,"number":4,"title":"Backlog","description":"Issues which don't yet fit into the roadmap for any particular release yet. Issues may be completed at any time. These fixes should *usually* target `master`, but if the change is not risky, `release/*` branches are fine before the release is published. Please confirm with project maintainers before targeting a `release/*` branch.","creator":{"login":"dilijev","id":494055,"avatar_url":"https://avatars3.githubusercontent.com/u/494055?v=4","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"open_issues":104,"closed_issues":40,"state":"open","created_at":"2016-08-19T23:47:27Z","updated_at":"2017-09-12T03:39:50Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-11-04T05:09:33Z","updated_at":"2017-09-13T21:41:50Z","closed_at":null,"author_association":"MEMBER","body":"Only few of our callbacks can execute JSRT API calls. i.e. new `JsSerializedLoadScriptCallback` is one of them. https://github.com/Microsoft/ChakraCore/blob/master/lib/Jsrt/JsrtSourceHolder.cpp#L246-L252 \r\n\r\nIs there any particular callback we shouldn't allow JSRT API calls ? or best if we make them all capable of doing this?\r\n\r\n/cc @agarwal-sandeep @liminzhu "},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/329305292","html_url":"https://github.com/Microsoft/ChakraCore/issues/1917#issuecomment-329305292","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1917","id":329305292,"user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars3.githubusercontent.com/u/12059066?v=4","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T21:41:50Z","updated_at":"2017-09-13T21:41:50Z","author_association":"CONTRIBUTOR","body":"My concern was related to thorough reentrancy test coverage. I feel we don't have good test coverage which can test this. +1 for allowing callbacks to call JsRT API."}}
{"actor":{"display_login":"agarwal-sandeep"}}