{"action":"created","comment":{"url":"https://api.github.com/repos/uber-go/zap/pulls/comments/97603237","pull_request_review_id":18217912,"id":97603237,"diff_hunk":"@@ -74,7 +74,14 @@ func Desugar(s *SugaredLogger) Logger {\n // continues. Passing an odd number of arguments triggers similar behavior:\n // panics in development and errors in production.\n func (s *SugaredLogger) With(args ...interface{}) *SugaredLogger {\n-\treturn &SugaredLogger{core: s.core.With(s.sweetenFields(args)...)}\n+\treturn s.WithFields(s.sweetenFields(args)...)\n+}\n+\n+// WithFields adds structured fields to the logging context, much like the\n+// base Logger. It allows the sugared logger to use more specialized\n+// fields (like Stack).\n+func (s *SugaredLogger) WithFields(fs ...zapcore.Field) *SugaredLogger {","path":"sugar.go","position":11,"original_position":11,"commit_id":"c4fe039ad70064724738dfb2f97951326e470e95","original_commit_id":"c4fe039ad70064724738dfb2f97951326e470e95","user":{"login":"jcorbin","id":49715,"avatar_url":"https://avatars.githubusercontent.com/u/49715?v=3","gravatar_id":"","url":"https://api.github.com/users/jcorbin","html_url":"https://github.com/jcorbin","followers_url":"https://api.github.com/users/jcorbin/followers","following_url":"https://api.github.com/users/jcorbin/following{/other_user}","gists_url":"https://api.github.com/users/jcorbin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcorbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcorbin/subscriptions","organizations_url":"https://api.github.com/users/jcorbin/orgs","repos_url":"https://api.github.com/users/jcorbin/repos","events_url":"https://api.github.com/users/jcorbin/events{/privacy}","received_events_url":"https://api.github.com/users/jcorbin/received_events","type":"User","site_admin":false},"body":"Did you mean to just slip this one into this PR? It seems like a whole different thing; also it's attached to a larger ball of wax:\r\n- if we're going to cede that it's useful toe have a `FooFields` for `Foo=With`...\r\n- ...why not also for `Foo` in `{Debug,Info,Warn,Error,DPanic,Panic,Fatal}`?\r\n- At that point, why don't we just collapse `SugaredLogger` into `Logger`, and dispense with all the wrapping?\r\n- The user story would then become something like: \"most people use Foof / Foow, perf-conscious users use FooFields\"; maybe even something like:\r\n  - \"Don't care about logging? Use Foow\"\r\n  - \"Want structured logs? Use Foof\"\r\n  - \"Really care about logs? Library author? Use FooFields\"","created_at":"2017-01-24T17:27:55Z","updated_at":"2017-01-24T17:27:55Z","html_url":"https://github.com/uber-go/zap/pull/250#discussion_r97603237","pull_request_url":"https://api.github.com/repos/uber-go/zap/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/uber-go/zap/pulls/comments/97603237"},"html":{"href":"https://github.com/uber-go/zap/pull/250#discussion_r97603237"},"pull_request":{"href":"https://api.github.com/repos/uber-go/zap/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/uber-go/zap/pulls/250","id":102347509,"html_url":"https://github.com/uber-go/zap/pull/250","diff_url":"https://github.com/uber-go/zap/pull/250.diff","patch_url":"https://github.com/uber-go/zap/pull/250.patch","issue_url":"https://api.github.com/repos/uber-go/zap/issues/250","number":250,"state":"closed","locked":false,"title":"Add support for named loggers","user":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"body":"This resolves #130.","created_at":"2017-01-19T21:00:12Z","updated_at":"2017-01-24T17:27:55Z","closed_at":"2017-01-24T17:22:34Z","merged_at":"2017-01-24T17:22:34Z","merge_commit_sha":"7389bce893a0a1e4b5c9fb11b866f8a14ea66a64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-go/zap/pulls/250/commits","review_comments_url":"https://api.github.com/repos/uber-go/zap/pulls/250/comments","review_comment_url":"https://api.github.com/repos/uber-go/zap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-go/zap/issues/250/comments","statuses_url":"https://api.github.com/repos/uber-go/zap/statuses/c4fe039ad70064724738dfb2f97951326e470e95","head":{"label":"uber-go:ajs-names","ref":"ajs-names","sha":"c4fe039ad70064724738dfb2f97951326e470e95","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":52034309,"name":"zap","full_name":"uber-go/zap","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/zap","description":"Fast, structured, leveled logging in Go.","fork":false,"url":"https://api.github.com/repos/uber-go/zap","forks_url":"https://api.github.com/repos/uber-go/zap/forks","keys_url":"https://api.github.com/repos/uber-go/zap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/zap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/zap/teams","hooks_url":"https://api.github.com/repos/uber-go/zap/hooks","issue_events_url":"https://api.github.com/repos/uber-go/zap/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/zap/events","assignees_url":"https://api.github.com/repos/uber-go/zap/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/zap/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/zap/tags","blobs_url":"https://api.github.com/repos/uber-go/zap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/zap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/zap/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/zap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/zap/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/zap/languages","stargazers_url":"https://api.github.com/repos/uber-go/zap/stargazers","contributors_url":"https://api.github.com/repos/uber-go/zap/contributors","subscribers_url":"https://api.github.com/repos/uber-go/zap/subscribers","subscription_url":"https://api.github.com/repos/uber-go/zap/subscription","commits_url":"https://api.github.com/repos/uber-go/zap/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/zap/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/zap/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/zap/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/zap/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/zap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/zap/merges","archive_url":"https://api.github.com/repos/uber-go/zap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/zap/downloads","issues_url":"https://api.github.com/repos/uber-go/zap/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/zap/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/zap/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/zap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/zap/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/zap/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/zap/deployments","created_at":"2016-02-18T19:52:56Z","updated_at":"2017-01-24T17:14:04Z","pushed_at":"2017-01-24T17:25:10Z","git_url":"git://github.com/uber-go/zap.git","ssh_url":"git@github.com:uber-go/zap.git","clone_url":"https://github.com/uber-go/zap.git","svn_url":"https://github.com/uber-go/zap","homepage":"https://godoc.org/github.com/uber-go/zap","size":657,"stargazers_count":1845,"watchers_count":1845,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":24,"forks":100,"open_issues":24,"watchers":1845,"default_branch":"master"}},"base":{"label":"uber-go:dev","ref":"dev","sha":"64245ad20f34374f5fd8984221ac68468e9ec6a0","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":52034309,"name":"zap","full_name":"uber-go/zap","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/zap","description":"Fast, structured, leveled logging in Go.","fork":false,"url":"https://api.github.com/repos/uber-go/zap","forks_url":"https://api.github.com/repos/uber-go/zap/forks","keys_url":"https://api.github.com/repos/uber-go/zap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/zap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/zap/teams","hooks_url":"https://api.github.com/repos/uber-go/zap/hooks","issue_events_url":"https://api.github.com/repos/uber-go/zap/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/zap/events","assignees_url":"https://api.github.com/repos/uber-go/zap/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/zap/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/zap/tags","blobs_url":"https://api.github.com/repos/uber-go/zap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/zap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/zap/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/zap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/zap/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/zap/languages","stargazers_url":"https://api.github.com/repos/uber-go/zap/stargazers","contributors_url":"https://api.github.com/repos/uber-go/zap/contributors","subscribers_url":"https://api.github.com/repos/uber-go/zap/subscribers","subscription_url":"https://api.github.com/repos/uber-go/zap/subscription","commits_url":"https://api.github.com/repos/uber-go/zap/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/zap/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/zap/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/zap/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/zap/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/zap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/zap/merges","archive_url":"https://api.github.com/repos/uber-go/zap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/zap/downloads","issues_url":"https://api.github.com/repos/uber-go/zap/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/zap/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/zap/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/zap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/zap/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/zap/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/zap/deployments","created_at":"2016-02-18T19:52:56Z","updated_at":"2017-01-24T17:14:04Z","pushed_at":"2017-01-24T17:25:10Z","git_url":"git://github.com/uber-go/zap.git","ssh_url":"git@github.com:uber-go/zap.git","clone_url":"https://github.com/uber-go/zap.git","svn_url":"https://github.com/uber-go/zap","homepage":"https://godoc.org/github.com/uber-go/zap","size":657,"stargazers_count":1845,"watchers_count":1845,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":24,"forks":100,"open_issues":24,"watchers":1845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-go/zap/pulls/250"},"html":{"href":"https://github.com/uber-go/zap/pull/250"},"issue":{"href":"https://api.github.com/repos/uber-go/zap/issues/250"},"comments":{"href":"https://api.github.com/repos/uber-go/zap/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-go/zap/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-go/zap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-go/zap/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/uber-go/zap/statuses/c4fe039ad70064724738dfb2f97951326e470e95"}}}}
{"actor":{"display_login":"jcorbin"}}