{"action":"created","comment":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/comments/120022569","pull_request_review_id":41952505,"id":120022569,"diff_hunk":"@@ -390,6 +400,39 @@ def legacy_cleanup():\n             self.do_cache = os.path.isdir(archive_path)\n             self.chunks = create_master_idx(self.chunks)\n \n+    def check_cache_compatibility(self):\n+        my_features = Manifest.SUPPORTED_REPO_FEATURES\n+        if self.ignored_features & my_features:\n+            return False","path":"borg/cache.py","position":56,"original_position":56,"commit_id":"206b0675069fa89f4fd6602f68f804378ac43600","original_commit_id":"206b0675069fa89f4fd6602f68f804378ac43600","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars3.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"body":"would be cool if the hard to understand stuff ends up in some helpful comments in the src. :)","created_at":"2017-06-04T22:24:59Z","updated_at":"2017-06-04T22:24:59Z","html_url":"https://github.com/borgbackup/borg/pull/2134#discussion_r120022569","pull_request_url":"https://api.github.com/repos/borgbackup/borg/pulls/2134","_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments/120022569"},"html":{"href":"https://github.com/borgbackup/borg/pull/2134#discussion_r120022569"},"pull_request":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2134"}}},"pull_request":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/2134","id":104897687,"html_url":"https://github.com/borgbackup/borg/pull/2134","diff_url":"https://github.com/borgbackup/borg/pull/2134.diff","patch_url":"https://github.com/borgbackup/borg/pull/2134.patch","issue_url":"https://api.github.com/repos/borgbackup/borg/issues/2134","number":2134,"state":"open","locked":false,"title":"Add minimal version of in repository mandatory feature flags.","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars2.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"body":"This should allow us to make sure older borg versions can be cleanly\r\nprevented from doing operations that are no longer safe because of\r\nrepository format evolution. This allows more fine grained control than\r\njust incrementing the manifest version. So for example a change that\r\nstill allows new archives to be created but would corrupt the repository\r\nwhen an old version tries to delete an archive or check the repository\r\nwould add the new feature to the check and delete set but leave it out\r\nof the write set.\r\n\r\nThis is somewhat inspired by ext{2,3,4} which uses sets for\r\ncompat (everything except fsck), ro-compat (may only be accessed\r\nread-only by older versions) and features (refuse all access).\r\n\r\nThis implements #1806\r\n\r\nOpen questions:\r\n\r\n- [ ] What granularity is right? I currently use \"write\" for create, \"delete\" for delete and prune and \"check\" for everything else.\r\n- [x] Changes that make delete unsafe likely have consequences for the cache. Should this be handled or should we just wait until the first feature that need this and think about it then?\r\n- [x] Should this also add support for manifest version 2 (just manifest version 1 plus respects the mandatory feature flags), so we have a way to lockout 1.0.x borg versions for changes where this patch already makes it safe with borg 1.1.x?","created_at":"2017-02-06T22:35:57Z","updated_at":"2017-06-04T22:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1783c43724962195c94b9499e36ac9a9665ade5","assignee":{"login":"textshell","id":6579711,"avatar_url":"https://avatars2.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"assignees":[{"login":"textshell","id":6579711,"avatar_url":"https://avatars2.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/borgbackup/borg/milestones/43","html_url":"https://github.com/borgbackup/borg/milestone/43","labels_url":"https://api.github.com/repos/borgbackup/borg/milestones/43/labels","id":2559091,"number":43,"title":"1.1.0b7","description":"","creator":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars3.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":0,"state":"open","created_at":"2017-06-02T19:31:48Z","updated_at":"2017-06-04T22:23:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/borgbackup/borg/pulls/2134/commits","review_comments_url":"https://api.github.com/repos/borgbackup/borg/pulls/2134/comments","review_comment_url":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/2134/comments","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/206b0675069fa89f4fd6602f68f804378ac43600","head":{"label":"textshell:feature/mandatory-features","ref":"feature/mandatory-features","sha":"206b0675069fa89f4fd6602f68f804378ac43600","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars2.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"repo":{"id":64159641,"name":"borg","full_name":"textshell/borg","owner":{"login":"textshell","id":6579711,"avatar_url":"https://avatars2.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/textshell/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":true,"url":"https://api.github.com/repos/textshell/borg","forks_url":"https://api.github.com/repos/textshell/borg/forks","keys_url":"https://api.github.com/repos/textshell/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textshell/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textshell/borg/teams","hooks_url":"https://api.github.com/repos/textshell/borg/hooks","issue_events_url":"https://api.github.com/repos/textshell/borg/issues/events{/number}","events_url":"https://api.github.com/repos/textshell/borg/events","assignees_url":"https://api.github.com/repos/textshell/borg/assignees{/user}","branches_url":"https://api.github.com/repos/textshell/borg/branches{/branch}","tags_url":"https://api.github.com/repos/textshell/borg/tags","blobs_url":"https://api.github.com/repos/textshell/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textshell/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textshell/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/textshell/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textshell/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/textshell/borg/languages","stargazers_url":"https://api.github.com/repos/textshell/borg/stargazers","contributors_url":"https://api.github.com/repos/textshell/borg/contributors","subscribers_url":"https://api.github.com/repos/textshell/borg/subscribers","subscription_url":"https://api.github.com/repos/textshell/borg/subscription","commits_url":"https://api.github.com/repos/textshell/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/textshell/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/textshell/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/textshell/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/textshell/borg/contents/{+path}","compare_url":"https://api.github.com/repos/textshell/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textshell/borg/merges","archive_url":"https://api.github.com/repos/textshell/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textshell/borg/downloads","issues_url":"https://api.github.com/repos/textshell/borg/issues{/number}","pulls_url":"https://api.github.com/repos/textshell/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/textshell/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/textshell/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textshell/borg/labels{/name}","releases_url":"https://api.github.com/repos/textshell/borg/releases{/id}","deployments_url":"https://api.github.com/repos/textshell/borg/deployments","created_at":"2016-07-25T18:46:52Z","updated_at":"2016-07-25T18:46:53Z","pushed_at":"2017-05-29T20:22:59Z","git_url":"git://github.com/textshell/borg.git","ssh_url":"git@github.com:textshell/borg.git","clone_url":"https://github.com/textshell/borg.git","svn_url":"https://github.com/textshell/borg","homepage":"https://borgbackup.readthedocs.io/","size":7128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borgbackup:1.0-maint","ref":"1.0-maint","sha":"3a5ae844a1c371df2e9af29e5186636b0551e293","user":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars0.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"repo":{"id":35517126,"name":"borg","full_name":"borgbackup/borg","owner":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars0.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borgbackup/borg","description":"Deduplicating archiver with compression and authenticated encryption.","fork":false,"url":"https://api.github.com/repos/borgbackup/borg","forks_url":"https://api.github.com/repos/borgbackup/borg/forks","keys_url":"https://api.github.com/repos/borgbackup/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borgbackup/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borgbackup/borg/teams","hooks_url":"https://api.github.com/repos/borgbackup/borg/hooks","issue_events_url":"https://api.github.com/repos/borgbackup/borg/issues/events{/number}","events_url":"https://api.github.com/repos/borgbackup/borg/events","assignees_url":"https://api.github.com/repos/borgbackup/borg/assignees{/user}","branches_url":"https://api.github.com/repos/borgbackup/borg/branches{/branch}","tags_url":"https://api.github.com/repos/borgbackup/borg/tags","blobs_url":"https://api.github.com/repos/borgbackup/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borgbackup/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borgbackup/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/borgbackup/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/borgbackup/borg/languages","stargazers_url":"https://api.github.com/repos/borgbackup/borg/stargazers","contributors_url":"https://api.github.com/repos/borgbackup/borg/contributors","subscribers_url":"https://api.github.com/repos/borgbackup/borg/subscribers","subscription_url":"https://api.github.com/repos/borgbackup/borg/subscription","commits_url":"https://api.github.com/repos/borgbackup/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/borgbackup/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/borgbackup/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/borgbackup/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/borgbackup/borg/contents/{+path}","compare_url":"https://api.github.com/repos/borgbackup/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borgbackup/borg/merges","archive_url":"https://api.github.com/repos/borgbackup/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borgbackup/borg/downloads","issues_url":"https://api.github.com/repos/borgbackup/borg/issues{/number}","pulls_url":"https://api.github.com/repos/borgbackup/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/borgbackup/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/borgbackup/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borgbackup/borg/labels{/name}","releases_url":"https://api.github.com/repos/borgbackup/borg/releases{/id}","deployments_url":"https://api.github.com/repos/borgbackup/borg/deployments","created_at":"2015-05-12T23:10:47Z","updated_at":"2017-06-04T11:53:17Z","pushed_at":"2017-06-04T22:22:10Z","git_url":"git://github.com/borgbackup/borg.git","ssh_url":"git@github.com:borgbackup/borg.git","clone_url":"https://github.com/borgbackup/borg.git","svn_url":"https://github.com/borgbackup/borg","homepage":"https://borgbackup.readthedocs.io/","size":10921,"stargazers_count":2351,"watchers_count":2351,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":283,"forks":213,"open_issues":283,"watchers":2351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2134"},"html":{"href":"https://github.com/borgbackup/borg/pull/2134"},"issue":{"href":"https://api.github.com/repos/borgbackup/borg/issues/2134"},"comments":{"href":"https://api.github.com/repos/borgbackup/borg/issues/2134/comments"},"review_comments":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2134/comments"},"review_comment":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2134/commits"},"statuses":{"href":"https://api.github.com/repos/borgbackup/borg/statuses/206b0675069fa89f4fd6602f68f804378ac43600"}}}}
{"actor":{"display_login":"ThomasWaldmann"}}