{"action":"closed","number":1011,"pull_request":{"url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011","id":146265423,"html_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1011","diff_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1011.diff","patch_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1011.patch","issue_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/1011","number":1011,"state":"closed","locked":false,"title":"Add support for A4 page size for printing","user":{"login":"caseycesari","id":1042475,"avatar_url":"https://avatars1.githubusercontent.com/u/1042475?v=4","gravatar_id":"","url":"https://api.github.com/users/caseycesari","html_url":"https://github.com/caseycesari","followers_url":"https://api.github.com/users/caseycesari/followers","following_url":"https://api.github.com/users/caseycesari/following{/other_user}","gists_url":"https://api.github.com/users/caseycesari/gists{/gist_id}","starred_url":"https://api.github.com/users/caseycesari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseycesari/subscriptions","organizations_url":"https://api.github.com/users/caseycesari/orgs","repos_url":"https://api.github.com/users/caseycesari/repos","events_url":"https://api.github.com/users/caseycesari/events{/privacy}","received_events_url":"https://api.github.com/users/caseycesari/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nAdds stylesheets for A4 page size (both landscape and portrait orientations) as well as an option to the framework print dialog that allows users to select their page size. The A4 stylesheets were based of the letter size stylesheets, but with difference in dimensions between A4 and letter added/subtracted.\r\n\r\nThe existing page orientation stylesheets were renamed to reflect that they are for letter size.\r\n\r\nPlugins can utilize the page size and orientation stylesheets either by adding them to the page directly when printing, or getting user feedback in the plugin print dialog (to be added in #1009) and adding the appropriate stylesheets.\r\n\r\nConnects to #985\r\n\r\n## Testing Instructions\r\n \r\n- Initiate the create map option and verify that the correct stylesheet is added for each set of size and orientation options. These stylesheets are added after the print button is selected to the bottom of the `head` element. You can see them being added by viewing the bottom of the `head` element in the developer console.\r\n- Verify the map and legend elements are sized appropriately for each selected page and orientation option. This is a little tricky to see because the differences are subtle.\r\n    - The best way I found to test this was to open the app in two tabs in Chrome and setup the maps in each tab identically (same extent, same layers added etc).\r\n    - Initiate the create map option, and select the same orientation in each tab, but a different page size.\r\n    - Click print.\r\n    - In the Chrome print preview dialog, select the **same** page size for each map (it's a little easier to see this with A4 selected in portrait orientation).\r\n    - One of the maps will now have the incorrect page size selected (compared to the initial option selected within the app).\r\n    - Now note how the map elements are sized more appropriately for the map that has the correct page size selected (for example, in A4 portrait mode, the map will be a little larger for the tab with the A4 page size selected).","created_at":"2017-10-12T17:12:32Z","updated_at":"2017-10-13T15:27:35Z","closed_at":"2017-10-13T15:27:35Z","merged_at":"2017-10-13T15:27:35Z","merge_commit_sha":"925e9873422855ad4d43a022cb366413960569ed","assignee":{"login":"caseycesari","id":1042475,"avatar_url":"https://avatars1.githubusercontent.com/u/1042475?v=4","gravatar_id":"","url":"https://api.github.com/users/caseycesari","html_url":"https://github.com/caseycesari","followers_url":"https://api.github.com/users/caseycesari/followers","following_url":"https://api.github.com/users/caseycesari/following{/other_user}","gists_url":"https://api.github.com/users/caseycesari/gists{/gist_id}","starred_url":"https://api.github.com/users/caseycesari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseycesari/subscriptions","organizations_url":"https://api.github.com/users/caseycesari/orgs","repos_url":"https://api.github.com/users/caseycesari/repos","events_url":"https://api.github.com/users/caseycesari/events{/privacy}","received_events_url":"https://api.github.com/users/caseycesari/received_events","type":"User","site_admin":false},"assignees":[{"login":"caseycesari","id":1042475,"avatar_url":"https://avatars1.githubusercontent.com/u/1042475?v=4","gravatar_id":"","url":"https://api.github.com/users/caseycesari","html_url":"https://github.com/caseycesari","followers_url":"https://api.github.com/users/caseycesari/followers","following_url":"https://api.github.com/users/caseycesari/following{/other_user}","gists_url":"https://api.github.com/users/caseycesari/gists{/gist_id}","starred_url":"https://api.github.com/users/caseycesari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseycesari/subscriptions","organizations_url":"https://api.github.com/users/caseycesari/orgs","repos_url":"https://api.github.com/users/caseycesari/repos","events_url":"https://api.github.com/users/caseycesari/events{/privacy}","received_events_url":"https://api.github.com/users/caseycesari/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011/commits","review_comments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011/comments","review_comment_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/1011/comments","statuses_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/statuses/3be99f1ccb68cc009ffbeb703875b99770af2db2","head":{"label":"CoastalResilienceNetwork:cpc/add-a4","ref":"cpc/add-a4","sha":"3be99f1ccb68cc009ffbeb703875b99770af2db2","user":{"login":"CoastalResilienceNetwork","id":5659174,"avatar_url":"https://avatars2.githubusercontent.com/u/5659174?v=4","gravatar_id":"","url":"https://api.github.com/users/CoastalResilienceNetwork","html_url":"https://github.com/CoastalResilienceNetwork","followers_url":"https://api.github.com/users/CoastalResilienceNetwork/followers","following_url":"https://api.github.com/users/CoastalResilienceNetwork/following{/other_user}","gists_url":"https://api.github.com/users/CoastalResilienceNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/CoastalResilienceNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoastalResilienceNetwork/subscriptions","organizations_url":"https://api.github.com/users/CoastalResilienceNetwork/orgs","repos_url":"https://api.github.com/users/CoastalResilienceNetwork/repos","events_url":"https://api.github.com/users/CoastalResilienceNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/CoastalResilienceNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":7753400,"name":"GeositeFramework","full_name":"CoastalResilienceNetwork/GeositeFramework","owner":{"login":"CoastalResilienceNetwork","id":5659174,"avatar_url":"https://avatars2.githubusercontent.com/u/5659174?v=4","gravatar_id":"","url":"https://api.github.com/users/CoastalResilienceNetwork","html_url":"https://github.com/CoastalResilienceNetwork","followers_url":"https://api.github.com/users/CoastalResilienceNetwork/followers","following_url":"https://api.github.com/users/CoastalResilienceNetwork/following{/other_user}","gists_url":"https://api.github.com/users/CoastalResilienceNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/CoastalResilienceNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoastalResilienceNetwork/subscriptions","organizations_url":"https://api.github.com/users/CoastalResilienceNetwork/orgs","repos_url":"https://api.github.com/users/CoastalResilienceNetwork/repos","events_url":"https://api.github.com/users/CoastalResilienceNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/CoastalResilienceNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework","description":"Mapping Framework powering TNC Coastal Resilience programs","fork":false,"url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework","forks_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/forks","keys_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/teams","hooks_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/hooks","issue_events_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/events{/number}","events_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/events","assignees_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/assignees{/user}","branches_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/branches{/branch}","tags_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/tags","blobs_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/languages","stargazers_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/stargazers","contributors_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/contributors","subscribers_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/subscribers","subscription_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/subscription","commits_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/contents/{+path}","compare_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/merges","archive_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/downloads","issues_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues{/number}","pulls_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/labels{/name}","releases_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/releases{/id}","deployments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/deployments","created_at":"2013-01-22T14:07:50Z","updated_at":"2017-02-10T18:22:23Z","pushed_at":"2017-10-13T15:27:35Z","git_url":"git://github.com/CoastalResilienceNetwork/GeositeFramework.git","ssh_url":"git@github.com:CoastalResilienceNetwork/GeositeFramework.git","clone_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework.git","svn_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework","homepage":"http://maps.coastalresilience.org/network/","size":9933,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":58,"forks":8,"open_issues":58,"watchers":8,"default_branch":"master"}},"base":{"label":"CoastalResilienceNetwork:develop","ref":"develop","sha":"f362bc3cfb11b0082ff7892b591b35b9961e99f0","user":{"login":"CoastalResilienceNetwork","id":5659174,"avatar_url":"https://avatars2.githubusercontent.com/u/5659174?v=4","gravatar_id":"","url":"https://api.github.com/users/CoastalResilienceNetwork","html_url":"https://github.com/CoastalResilienceNetwork","followers_url":"https://api.github.com/users/CoastalResilienceNetwork/followers","following_url":"https://api.github.com/users/CoastalResilienceNetwork/following{/other_user}","gists_url":"https://api.github.com/users/CoastalResilienceNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/CoastalResilienceNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoastalResilienceNetwork/subscriptions","organizations_url":"https://api.github.com/users/CoastalResilienceNetwork/orgs","repos_url":"https://api.github.com/users/CoastalResilienceNetwork/repos","events_url":"https://api.github.com/users/CoastalResilienceNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/CoastalResilienceNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":7753400,"name":"GeositeFramework","full_name":"CoastalResilienceNetwork/GeositeFramework","owner":{"login":"CoastalResilienceNetwork","id":5659174,"avatar_url":"https://avatars2.githubusercontent.com/u/5659174?v=4","gravatar_id":"","url":"https://api.github.com/users/CoastalResilienceNetwork","html_url":"https://github.com/CoastalResilienceNetwork","followers_url":"https://api.github.com/users/CoastalResilienceNetwork/followers","following_url":"https://api.github.com/users/CoastalResilienceNetwork/following{/other_user}","gists_url":"https://api.github.com/users/CoastalResilienceNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/CoastalResilienceNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoastalResilienceNetwork/subscriptions","organizations_url":"https://api.github.com/users/CoastalResilienceNetwork/orgs","repos_url":"https://api.github.com/users/CoastalResilienceNetwork/repos","events_url":"https://api.github.com/users/CoastalResilienceNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/CoastalResilienceNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework","description":"Mapping Framework powering TNC Coastal Resilience programs","fork":false,"url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework","forks_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/forks","keys_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/teams","hooks_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/hooks","issue_events_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/events{/number}","events_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/events","assignees_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/assignees{/user}","branches_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/branches{/branch}","tags_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/tags","blobs_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/languages","stargazers_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/stargazers","contributors_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/contributors","subscribers_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/subscribers","subscription_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/subscription","commits_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/contents/{+path}","compare_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/merges","archive_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/downloads","issues_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues{/number}","pulls_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/labels{/name}","releases_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/releases{/id}","deployments_url":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/deployments","created_at":"2013-01-22T14:07:50Z","updated_at":"2017-02-10T18:22:23Z","pushed_at":"2017-10-13T15:27:35Z","git_url":"git://github.com/CoastalResilienceNetwork/GeositeFramework.git","ssh_url":"git@github.com:CoastalResilienceNetwork/GeositeFramework.git","clone_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework.git","svn_url":"https://github.com/CoastalResilienceNetwork/GeositeFramework","homepage":"http://maps.coastalresilience.org/network/","size":9933,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":58,"forks":8,"open_issues":58,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011"},"html":{"href":"https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1011"},"issue":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/1011"},"comments":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/issues/1011/comments"},"review_comments":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011/comments"},"review_comment":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/pulls/1011/commits"},"statuses":{"href":"https://api.github.com/repos/CoastalResilienceNetwork/GeositeFramework/statuses/3be99f1ccb68cc009ffbeb703875b99770af2db2"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"caseycesari","id":1042475,"avatar_url":"https://avatars1.githubusercontent.com/u/1042475?v=4","gravatar_id":"","url":"https://api.github.com/users/caseycesari","html_url":"https://github.com/caseycesari","followers_url":"https://api.github.com/users/caseycesari/followers","following_url":"https://api.github.com/users/caseycesari/following{/other_user}","gists_url":"https://api.github.com/users/caseycesari/gists{/gist_id}","starred_url":"https://api.github.com/users/caseycesari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseycesari/subscriptions","organizations_url":"https://api.github.com/users/caseycesari/orgs","repos_url":"https://api.github.com/users/caseycesari/repos","events_url":"https://api.github.com/users/caseycesari/events{/privacy}","received_events_url":"https://api.github.com/users/caseycesari/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":126,"deletions":13,"changed_files":7}}
{"actor":{"display_login":"caseycesari"}}