{"action":"created","issue":{"url":"https://api.github.com/repos/atenashad/jan-version/issues/1","repository_url":"https://api.github.com/repos/atenashad/jan-version","labels_url":"https://api.github.com/repos/atenashad/jan-version/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/atenashad/jan-version/issues/1/comments","events_url":"https://api.github.com/repos/atenashad/jan-version/issues/1/events","html_url":"https://github.com/atenashad/jan-version/issues/1","id":230036833,"number":1,"title":"MySQL can handle lowercase","user":{"login":"R-K-H","id":1007667,"avatar_url":"https://avatars2.githubusercontent.com/u/1007667?v=3","gravatar_id":"","url":"https://api.github.com/users/R-K-H","html_url":"https://github.com/R-K-H","followers_url":"https://api.github.com/users/R-K-H/followers","following_url":"https://api.github.com/users/R-K-H/following{/other_user}","gists_url":"https://api.github.com/users/R-K-H/gists{/gist_id}","starred_url":"https://api.github.com/users/R-K-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R-K-H/subscriptions","organizations_url":"https://api.github.com/users/R-K-H/orgs","repos_url":"https://api.github.com/users/R-K-H/repos","events_url":"https://api.github.com/users/R-K-H/events{/privacy}","received_events_url":"https://api.github.com/users/R-K-H/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-19T17:18:49Z","updated_at":"2017-05-23T09:51:44Z","closed_at":null,"body":"https://github.com/atenashad/jan-version/blob/master/api-db.php#L8\r\n\r\nYou don't really need this as long as the sort order is an actual sort order, maybe consider if I passed the $order_way a string like \"; DROP TABLE;\" or something simple like \"WOOHOOO\" your program would fail as the MySQL query is invalid. You want to make sure your logic fails rather than the MySQL query. You can do this with a simple test (in you switch statement even) to make sure it's one or the other, if not fail. In the case of the DROP TABLE you'll have SQL injection which can be a big issue.\r\n\r\n:) 👍 "},"comment":{"url":"https://api.github.com/repos/atenashad/jan-version/issues/comments/303349138","html_url":"https://github.com/atenashad/jan-version/issues/1#issuecomment-303349138","issue_url":"https://api.github.com/repos/atenashad/jan-version/issues/1","id":303349138,"user":{"login":"atenashad","id":15844541,"avatar_url":"https://avatars1.githubusercontent.com/u/15844541?v=3","gravatar_id":"","url":"https://api.github.com/users/atenashad","html_url":"https://github.com/atenashad","followers_url":"https://api.github.com/users/atenashad/followers","following_url":"https://api.github.com/users/atenashad/following{/other_user}","gists_url":"https://api.github.com/users/atenashad/gists{/gist_id}","starred_url":"https://api.github.com/users/atenashad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atenashad/subscriptions","organizations_url":"https://api.github.com/users/atenashad/orgs","repos_url":"https://api.github.com/users/atenashad/repos","events_url":"https://api.github.com/users/atenashad/events{/privacy}","received_events_url":"https://api.github.com/users/atenashad/received_events","type":"User","site_admin":false},"created_at":"2017-05-23T09:51:44Z","updated_at":"2017-05-23T09:51:44Z","body":"can you explain what you mean a bit more? \r\nFrom what I understand atm, the concern arrives because there would be a possibility for user data being put into the SQL, but this gets handled because of the default so that even if anything else is passed it would default back to either ASC or DESC - no? "}}
{"actor":{"display_login":"atenashad"}}