{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/comments/149227014","pull_request_review_id":74589182,"id":149227014,"diff_hunk":"@@ -1207,8 +1207,8 @@\n     /**\n      * The maximum size, in bytes, of a given stream mark operation.\n      */\n-    // Note if BlobConstants.MAX_SINGLE_UPLOAD_BLOB_SIZE_IN_BYTES is updated then this needs to be as well.\n-    public static final int MAX_MARK_LENGTH = 256 * MB;\n+    //This actually acquire the buffer into memory until file gets copied\n+    public static final int MAX_MARK_LENGTH = 8 * MB;","path":"microsoft-azure-storage/src/com/microsoft/azure/storage/Constants.java","position":7,"original_position":7,"commit_id":"c176feb622d797464599591f683f8b01ba266d6e","original_commit_id":"c176feb622d797464599591f683f8b01ba266d6e","user":{"login":"jofriedm-msft","id":14795675,"avatar_url":"https://avatars1.githubusercontent.com/u/14795675?v=4","gravatar_id":"","url":"https://api.github.com/users/jofriedm-msft","html_url":"https://github.com/jofriedm-msft","followers_url":"https://api.github.com/users/jofriedm-msft/followers","following_url":"https://api.github.com/users/jofriedm-msft/following{/other_user}","gists_url":"https://api.github.com/users/jofriedm-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/jofriedm-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofriedm-msft/subscriptions","organizations_url":"https://api.github.com/users/jofriedm-msft/orgs","repos_url":"https://api.github.com/users/jofriedm-msft/repos","events_url":"https://api.github.com/users/jofriedm-msft/events{/privacy}","received_events_url":"https://api.github.com/users/jofriedm-msft/received_events","type":"User","site_admin":false},"body":"Why did you change this and MAX_SINGLE_UPLOAD_SIZE? Can you leave these values and just modify the blob request options?","created_at":"2017-11-06T22:46:43Z","updated_at":"2017-11-06T22:46:43Z","html_url":"https://github.com/Azure/azure-storage-java/pull/230#discussion_r149227014","pull_request_url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/comments/149227014"},"html":{"href":"https://github.com/Azure/azure-storage-java/pull/230#discussion_r149227014"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230","id":150839145,"html_url":"https://github.com/Azure/azure-storage-java/pull/230","diff_url":"https://github.com/Azure/azure-storage-java/pull/230.diff","patch_url":"https://github.com/Azure/azure-storage-java/pull/230.patch","issue_url":"https://api.github.com/repos/Azure/azure-storage-java/issues/230","number":230,"state":"open","locked":false,"title":"Out of memory issue for big file ","user":{"login":"ashokmor","id":10349577,"avatar_url":"https://avatars0.githubusercontent.com/u/10349577?v=4","gravatar_id":"","url":"https://api.github.com/users/ashokmor","html_url":"https://github.com/ashokmor","followers_url":"https://api.github.com/users/ashokmor/followers","following_url":"https://api.github.com/users/ashokmor/following{/other_user}","gists_url":"https://api.github.com/users/ashokmor/gists{/gist_id}","starred_url":"https://api.github.com/users/ashokmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashokmor/subscriptions","organizations_url":"https://api.github.com/users/ashokmor/orgs","repos_url":"https://api.github.com/users/ashokmor/repos","events_url":"https://api.github.com/users/ashokmor/events{/privacy}","received_events_url":"https://api.github.com/users/ashokmor/received_events","type":"User","site_admin":false},"body":"Were facing out of memory issue while concurrently copying big files (600+mb) to Azure.\r\nRefer following test case to replicate the behaviour: testBigFileUploadWithSingleThread and testConcurrentBigFileUploads of CloudBlockBlobTests.java\r\nBefore executing UTs we need to replace the dummy file \"bigFile.mp4\" with the real big file.\r\nAdded more inline comments to code and details to GIT commit","created_at":"2017-11-06T12:21:01Z","updated_at":"2017-11-06T22:46:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"142ac46eee3357dbb2a0ef98573a0b70cc53c745","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-storage-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-storage-java/issues/230/comments","statuses_url":"https://api.github.com/repos/Azure/azure-storage-java/statuses/c176feb622d797464599591f683f8b01ba266d6e","head":{"label":"ashokmor:master","ref":"master","sha":"c176feb622d797464599591f683f8b01ba266d6e","user":{"login":"ashokmor","id":10349577,"avatar_url":"https://avatars0.githubusercontent.com/u/10349577?v=4","gravatar_id":"","url":"https://api.github.com/users/ashokmor","html_url":"https://github.com/ashokmor","followers_url":"https://api.github.com/users/ashokmor/followers","following_url":"https://api.github.com/users/ashokmor/following{/other_user}","gists_url":"https://api.github.com/users/ashokmor/gists{/gist_id}","starred_url":"https://api.github.com/users/ashokmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashokmor/subscriptions","organizations_url":"https://api.github.com/users/ashokmor/orgs","repos_url":"https://api.github.com/users/ashokmor/repos","events_url":"https://api.github.com/users/ashokmor/events{/privacy}","received_events_url":"https://api.github.com/users/ashokmor/received_events","type":"User","site_admin":false},"repo":{"id":109688717,"name":"azure-storage-java","full_name":"ashokmor/azure-storage-java","owner":{"login":"ashokmor","id":10349577,"avatar_url":"https://avatars0.githubusercontent.com/u/10349577?v=4","gravatar_id":"","url":"https://api.github.com/users/ashokmor","html_url":"https://github.com/ashokmor","followers_url":"https://api.github.com/users/ashokmor/followers","following_url":"https://api.github.com/users/ashokmor/following{/other_user}","gists_url":"https://api.github.com/users/ashokmor/gists{/gist_id}","starred_url":"https://api.github.com/users/ashokmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashokmor/subscriptions","organizations_url":"https://api.github.com/users/ashokmor/orgs","repos_url":"https://api.github.com/users/ashokmor/repos","events_url":"https://api.github.com/users/ashokmor/events{/privacy}","received_events_url":"https://api.github.com/users/ashokmor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashokmor/azure-storage-java","description":"Microsoft Azure Storage Library for Java","fork":true,"url":"https://api.github.com/repos/ashokmor/azure-storage-java","forks_url":"https://api.github.com/repos/ashokmor/azure-storage-java/forks","keys_url":"https://api.github.com/repos/ashokmor/azure-storage-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashokmor/azure-storage-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashokmor/azure-storage-java/teams","hooks_url":"https://api.github.com/repos/ashokmor/azure-storage-java/hooks","issue_events_url":"https://api.github.com/repos/ashokmor/azure-storage-java/issues/events{/number}","events_url":"https://api.github.com/repos/ashokmor/azure-storage-java/events","assignees_url":"https://api.github.com/repos/ashokmor/azure-storage-java/assignees{/user}","branches_url":"https://api.github.com/repos/ashokmor/azure-storage-java/branches{/branch}","tags_url":"https://api.github.com/repos/ashokmor/azure-storage-java/tags","blobs_url":"https://api.github.com/repos/ashokmor/azure-storage-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashokmor/azure-storage-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashokmor/azure-storage-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashokmor/azure-storage-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashokmor/azure-storage-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ashokmor/azure-storage-java/languages","stargazers_url":"https://api.github.com/repos/ashokmor/azure-storage-java/stargazers","contributors_url":"https://api.github.com/repos/ashokmor/azure-storage-java/contributors","subscribers_url":"https://api.github.com/repos/ashokmor/azure-storage-java/subscribers","subscription_url":"https://api.github.com/repos/ashokmor/azure-storage-java/subscription","commits_url":"https://api.github.com/repos/ashokmor/azure-storage-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashokmor/azure-storage-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashokmor/azure-storage-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashokmor/azure-storage-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashokmor/azure-storage-java/contents/{+path}","compare_url":"https://api.github.com/repos/ashokmor/azure-storage-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashokmor/azure-storage-java/merges","archive_url":"https://api.github.com/repos/ashokmor/azure-storage-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashokmor/azure-storage-java/downloads","issues_url":"https://api.github.com/repos/ashokmor/azure-storage-java/issues{/number}","pulls_url":"https://api.github.com/repos/ashokmor/azure-storage-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ashokmor/azure-storage-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ashokmor/azure-storage-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashokmor/azure-storage-java/labels{/name}","releases_url":"https://api.github.com/repos/ashokmor/azure-storage-java/releases{/id}","deployments_url":"https://api.github.com/repos/ashokmor/azure-storage-java/deployments","created_at":"2017-11-06T11:50:00Z","updated_at":"2017-11-06T11:50:02Z","pushed_at":"2017-11-06T13:11:10Z","git_url":"git://github.com/ashokmor/azure-storage-java.git","ssh_url":"git@github.com:ashokmor/azure-storage-java.git","clone_url":"https://github.com/ashokmor/azure-storage-java.git","svn_url":"https://github.com/ashokmor/azure-storage-java","homepage":"","size":6916,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"43a0619ed33855c27368c03b7e4e2176d7de176e","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":13809004,"name":"azure-storage-java","full_name":"Azure/azure-storage-java","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-storage-java","description":"Microsoft Azure Storage Library for Java","fork":false,"url":"https://api.github.com/repos/Azure/azure-storage-java","forks_url":"https://api.github.com/repos/Azure/azure-storage-java/forks","keys_url":"https://api.github.com/repos/Azure/azure-storage-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-storage-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-storage-java/teams","hooks_url":"https://api.github.com/repos/Azure/azure-storage-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-storage-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-storage-java/events","assignees_url":"https://api.github.com/repos/Azure/azure-storage-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-storage-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-storage-java/tags","blobs_url":"https://api.github.com/repos/Azure/azure-storage-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-storage-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-storage-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-storage-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-storage-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-storage-java/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-storage-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-storage-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-storage-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-storage-java/subscription","commits_url":"https://api.github.com/repos/Azure/azure-storage-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-storage-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-storage-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-storage-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-storage-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-storage-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-storage-java/merges","archive_url":"https://api.github.com/repos/Azure/azure-storage-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-storage-java/downloads","issues_url":"https://api.github.com/repos/Azure/azure-storage-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-storage-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-storage-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-storage-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-storage-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-storage-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-storage-java/deployments","created_at":"2013-10-23T17:02:16Z","updated_at":"2017-11-01T06:13:20Z","pushed_at":"2017-11-06T13:11:11Z","git_url":"git://github.com/Azure/azure-storage-java.git","ssh_url":"git@github.com:Azure/azure-storage-java.git","clone_url":"https://github.com/Azure/azure-storage-java.git","svn_url":"https://github.com/Azure/azure-storage-java","homepage":"","size":6905,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":24,"forks":97,"open_issues":24,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230"},"html":{"href":"https://github.com/Azure/azure-storage-java/pull/230"},"issue":{"href":"https://api.github.com/repos/Azure/azure-storage-java/issues/230"},"comments":{"href":"https://api.github.com/repos/Azure/azure-storage-java/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-storage-java/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-storage-java/statuses/c176feb622d797464599591f683f8b01ba266d6e"}},"author_association":"NONE"}}
{"actor":{"display_login":"jofriedm-msft"}}