{"action":"opened","number":1372,"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1372","id":107376448,"html_url":"https://github.com/maidsafe/routing/pull/1372","diff_url":"https://github.com/maidsafe/routing/pull/1372.diff","patch_url":"https://github.com/maidsafe/routing/pull/1372.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1372","number":1372,"state":"open","locked":false,"title":"chore/base: simply error handling in Base::send_message","user":{"login":"dhardy","id":134893,"avatar_url":"https://avatars.githubusercontent.com/u/134893?v=3","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"body":"Don't return an error from send_message if serialisation fails; just log an\r\nerror and drop the message.\r\n\r\n(This is the first of several refactors I have.)","created_at":"2017-02-22T10:27:26Z","updated_at":"2017-02-22T10:27:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1372/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1372/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1372/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/1912d2a6800cabd5459e5d46deff5a56f0cf1b6d","head":{"label":"dhardy:master","ref":"master","sha":"1912d2a6800cabd5459e5d46deff5a56f0cf1b6d","user":{"login":"dhardy","id":134893,"avatar_url":"https://avatars.githubusercontent.com/u/134893?v=3","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"repo":{"id":70716691,"name":"routing","full_name":"dhardy/routing","owner":{"login":"dhardy","id":134893,"avatar_url":"https://avatars.githubusercontent.com/u/134893?v=3","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhardy/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/dhardy/routing","forks_url":"https://api.github.com/repos/dhardy/routing/forks","keys_url":"https://api.github.com/repos/dhardy/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhardy/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhardy/routing/teams","hooks_url":"https://api.github.com/repos/dhardy/routing/hooks","issue_events_url":"https://api.github.com/repos/dhardy/routing/issues/events{/number}","events_url":"https://api.github.com/repos/dhardy/routing/events","assignees_url":"https://api.github.com/repos/dhardy/routing/assignees{/user}","branches_url":"https://api.github.com/repos/dhardy/routing/branches{/branch}","tags_url":"https://api.github.com/repos/dhardy/routing/tags","blobs_url":"https://api.github.com/repos/dhardy/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhardy/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhardy/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhardy/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhardy/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/dhardy/routing/languages","stargazers_url":"https://api.github.com/repos/dhardy/routing/stargazers","contributors_url":"https://api.github.com/repos/dhardy/routing/contributors","subscribers_url":"https://api.github.com/repos/dhardy/routing/subscribers","subscription_url":"https://api.github.com/repos/dhardy/routing/subscription","commits_url":"https://api.github.com/repos/dhardy/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhardy/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhardy/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhardy/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhardy/routing/contents/{+path}","compare_url":"https://api.github.com/repos/dhardy/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhardy/routing/merges","archive_url":"https://api.github.com/repos/dhardy/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhardy/routing/downloads","issues_url":"https://api.github.com/repos/dhardy/routing/issues{/number}","pulls_url":"https://api.github.com/repos/dhardy/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/dhardy/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/dhardy/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhardy/routing/labels{/name}","releases_url":"https://api.github.com/repos/dhardy/routing/releases{/id}","deployments_url":"https://api.github.com/repos/dhardy/routing/deployments","created_at":"2016-10-12T16:00:30Z","updated_at":"2016-10-12T16:00:32Z","pushed_at":"2017-02-21T18:27:47Z","git_url":"git://github.com/dhardy/routing.git","ssh_url":"git@github.com:dhardy/routing.git","clone_url":"https://github.com/dhardy/routing.git","svn_url":"https://github.com/dhardy/routing","homepage":null,"size":9791,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"3652b2212fa536b63212cd0d3af78bb163f29918","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2017-02-18T23:45:13Z","pushed_at":"2017-02-22T09:28:11Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":109756,"stargazers_count":125,"watchers_count":125,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":9,"forks":43,"open_issues":9,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1372"},"html":{"href":"https://github.com/maidsafe/routing/pull/1372"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1372"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1372/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1372/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1372/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/1912d2a6800cabd5459e5d46deff5a56f0cf1b6d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":72,"deletions":117,"changed_files":3}}
{"actor":{"display_login":"dhardy"}}