{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/10862","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/10862/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/10862/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/10862/events","html_url":"https://github.com/ampproject/amphtml/issues/10862","id":249180571,"number":10862,"title":"trigger visibility of a fixed element based on scroll position (potentially scroll position of other elements)","user":{"login":"ericlindley-g","id":16807766,"avatar_url":"https://avatars2.githubusercontent.com/u/16807766?v=4","gravatar_id":"","url":"https://api.github.com/users/ericlindley-g","html_url":"https://github.com/ericlindley-g","followers_url":"https://api.github.com/users/ericlindley-g/followers","following_url":"https://api.github.com/users/ericlindley-g/following{/other_user}","gists_url":"https://api.github.com/users/ericlindley-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlindley-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlindley-g/subscriptions","organizations_url":"https://api.github.com/users/ericlindley-g/orgs","repos_url":"https://api.github.com/users/ericlindley-g/repos","events_url":"https://api.github.com/users/ericlindley-g/events{/privacy}","received_events_url":"https://api.github.com/users/ericlindley-g/received_events","type":"User","site_admin":false},"labels":[{"id":530198214,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Presentation","name":"Category: Presentation","color":"1d76db","default":false},{"id":284525535,"url":"https://api.github.com/repos/ampproject/amphtml/labels/P3:%20When%20Possible","name":"P3: When Possible","color":"e99695","default":false},{"id":284529946,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Feature%20Request","name":"Type: Feature Request","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"ericlindley-g","id":16807766,"avatar_url":"https://avatars2.githubusercontent.com/u/16807766?v=4","gravatar_id":"","url":"https://api.github.com/users/ericlindley-g","html_url":"https://github.com/ericlindley-g","followers_url":"https://api.github.com/users/ericlindley-g/followers","following_url":"https://api.github.com/users/ericlindley-g/following{/other_user}","gists_url":"https://api.github.com/users/ericlindley-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlindley-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlindley-g/subscriptions","organizations_url":"https://api.github.com/users/ericlindley-g/orgs","repos_url":"https://api.github.com/users/ericlindley-g/repos","events_url":"https://api.github.com/users/ericlindley-g/events{/privacy}","received_events_url":"https://api.github.com/users/ericlindley-g/received_events","type":"User","site_admin":false},"assignees":[{"login":"ericlindley-g","id":16807766,"avatar_url":"https://avatars2.githubusercontent.com/u/16807766?v=4","gravatar_id":"","url":"https://api.github.com/users/ericlindley-g","html_url":"https://github.com/ericlindley-g","followers_url":"https://api.github.com/users/ericlindley-g/followers","following_url":"https://api.github.com/users/ericlindley-g/following{/other_user}","gists_url":"https://api.github.com/users/ericlindley-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlindley-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlindley-g/subscriptions","organizations_url":"https://api.github.com/users/ericlindley-g/orgs","repos_url":"https://api.github.com/users/ericlindley-g/repos","events_url":"https://api.github.com/users/ericlindley-g/events{/privacy}","received_events_url":"https://api.github.com/users/ericlindley-g/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/23","html_url":"https://github.com/ampproject/amphtml/milestone/23","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/23/labels","id":2293339,"number":23,"title":"New FRs","description":"These are new feature requests opened, that are still at discussion level or need to be verified on whether they can be prioritized or not. ","creator":{"login":"adelinamart","id":24213793,"avatar_url":"https://avatars2.githubusercontent.com/u/24213793?v=4","gravatar_id":"","url":"https://api.github.com/users/adelinamart","html_url":"https://github.com/adelinamart","followers_url":"https://api.github.com/users/adelinamart/followers","following_url":"https://api.github.com/users/adelinamart/following{/other_user}","gists_url":"https://api.github.com/users/adelinamart/gists{/gist_id}","starred_url":"https://api.github.com/users/adelinamart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelinamart/subscriptions","organizations_url":"https://api.github.com/users/adelinamart/orgs","repos_url":"https://api.github.com/users/adelinamart/repos","events_url":"https://api.github.com/users/adelinamart/events{/privacy}","received_events_url":"https://api.github.com/users/adelinamart/received_events","type":"User","site_admin":false},"open_issues":187,"closed_issues":105,"state":"open","created_at":"2017-02-01T19:32:04Z","updated_at":"2017-08-09T22:28:50Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-08-09T22:28:21Z","updated_at":"2017-08-10T17:41:58Z","closed_at":null,"body":"Extracting https://github.com/ampproject/amphtml/issues/2911 into separate issues for tracking\r\n\r\nUse cases include\r\n- A footer bar that appear after you pass the end of the article text\r\n- A footer with an ad unit that only appear once you scroll down the page. (yes I know this would be a fixed ad unit, a policy change).\r\n- Other elements that appear in side margins to select next/prev article after the user has scrolled the initial article.\r\n\r\n/cc @aghassemi , I think some of these would already be supported by scrollbound amp-animation, but are they all?"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/321622946","html_url":"https://github.com/ampproject/amphtml/issues/10862#issuecomment-321622946","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/10862","id":321622946,"user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T17:41:58Z","updated_at":"2017-08-10T17:41:58Z","body":"@ericlindley-g With the new redesign and thanks to @choumx's TrustLevel framework, pretty much anything we allow with LowTrust user actions can be tied to visibility.\r\n\r\nNow, we probably don't want `show(), hide()` actions to be LowTrust in all cases but we can special case and allow it if target is `positioned fixed` (Runtime has mechanisms for detecting fixed elements).\r\n\r\nFrom your perspective, is it okay to allow display of any `fixed` element to be LowTrust? It's true that it won't cause content shift but can still obstruct content. It is essentially same as opening a `amp-lightbox` or `sidebar`.\r\n\r\nWe can be smarted too, we can only allow it of the fixed element's size is < X (e.g. maybe only allow if area if fixed element is < 50% of viewport area.. or similar)"}}
{"actor":{"display_login":"aghassemi"}}