{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/124076636","pull_request_review_id":46335210,"id":124076636,"diff_hunk":"@@ -30,11 +30,35 @@ help = { *:help $args | more } ;\n man = { help $args } ;\n log:list = { log:get ALL } ;\n service:get = { $.context getService ($.context getServiceReference $args) };\n+\n+env = { shell:set $args }\n+edit = { shell:nano $args }","path":"distribution/ddf-common/src/main/resources/etc/shell.init.script","position":6,"original_position":6,"commit_id":"988a81be3e43cc40bcf97a295176f72c4d24f270","original_commit_id":"5647c3b70e9cfef99c7fd502020da10ca48f7e84","user":{"login":"emmberk","id":8041246,"avatar_url":"https://avatars0.githubusercontent.com/u/8041246?v=3","gravatar_id":"","url":"https://api.github.com/users/emmberk","html_url":"https://github.com/emmberk","followers_url":"https://api.github.com/users/emmberk/followers","following_url":"https://api.github.com/users/emmberk/following{/other_user}","gists_url":"https://api.github.com/users/emmberk/gists{/gist_id}","starred_url":"https://api.github.com/users/emmberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmberk/subscriptions","organizations_url":"https://api.github.com/users/emmberk/orgs","repos_url":"https://api.github.com/users/emmberk/repos","events_url":"https://api.github.com/users/emmberk/events{/privacy}","received_events_url":"https://api.github.com/users/emmberk/received_events","type":"User","site_admin":false},"body":"Removed","created_at":"2017-06-26T17:56:41Z","updated_at":"2017-06-26T17:56:41Z","html_url":"https://github.com/codice/ddf/pull/2061#discussion_r124076636","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/2061","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/124076636"},"html":{"href":"https://github.com/codice/ddf/pull/2061#discussion_r124076636"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/2061"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/2061","id":125481924,"html_url":"https://github.com/codice/ddf/pull/2061","diff_url":"https://github.com/codice/ddf/pull/2061.diff","patch_url":"https://github.com/codice/ddf/pull/2061.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/2061","number":2061,"state":"open","locked":false,"title":"DDF-2132 Upgraded Karaf to 4.1.1","user":{"login":"emmberk","id":8041246,"avatar_url":"https://avatars0.githubusercontent.com/u/8041246?v=3","gravatar_id":"","url":"https://api.github.com/users/emmberk","html_url":"https://github.com/emmberk","followers_url":"https://api.github.com/users/emmberk/followers","following_url":"https://api.github.com/users/emmberk/following{/other_user}","gists_url":"https://api.github.com/users/emmberk/gists{/gist_id}","starred_url":"https://api.github.com/users/emmberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmberk/subscriptions","organizations_url":"https://api.github.com/users/emmberk/orgs","repos_url":"https://api.github.com/users/emmberk/repos","events_url":"https://api.github.com/users/emmberk/events{/privacy}","received_events_url":"https://api.github.com/users/emmberk/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThis PR upgrades DDF to Karaf 4.1.1.\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?\r\n@clockard @vinamartin @brjeter @Lambeaux @brendan-hofmann @paouelle @ryeats @tbatie @harrison-tarr \r\n\r\n#### Select at least one member from relevant component team(s) from below (at least one component team member needs to approve the PR).\r\n[Build](https://github.com/orgs/codice/teams/build) @pklinef \r\n[Docs](https://github.com/orgs/codice/teams/docs) @ricklarsen \r\n[Security](https://github.com/orgs/codice/teams/security) @stustison \r\n[Test](https://github.com/orgs/codice/teams/test) @lessarderic \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@clockard\r\n@coyotesqrl\r\n@kcwire\r\n@figliold\r\n@lessarderic\r\n@pklinef\r\n@stustison\r\n#### How should this be tested? (List steps with links to updated documentation)\r\n\r\n- Test that a full build succeeds.\r\n- Drop `.cfg` and `.config` files in the `/etc` directory, and confirm that the configurations are installed successfully.\r\n- Manually test basic functionality of DDF.\r\n- Confirm that the `./bin` scripts work as expected.\r\n- Walkthrough the Hardening Guide.\r\n- Confirm that the `waitForReady` command still works.\r\n- Confirm that the `migration:export` command and exporting configurations from the Admin Console still work.\r\n- Confirm that installing the `profile-development` works.\r\n- Confirm that logging still works and is still configurable from `org.ops4j.pax.logging.cfg` and from the Karaf console. Also, try switching the logging configuration to the xml-style configuration (see comment in `org.ops4j.pax.logging.cfg`, and confirm that logging still works and is configurable from `log4j2.config.xml` and from the Karaf console.\r\n- Test that `profile`/`app` console commands still work.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-2132](https://codice.atlassian.net/browse/DDF-2132)\r\n[DDF-2898](https://codice.atlassian.net/browse/DDF-2898)\r\n\r\nGenerated tickets:\r\n- [DDF-3039 NPE when location information is included in console logging pattern](https://codice.atlassian.net/browse/DDF-3039)\r\n- [DDF-3072 Investigate configuration of featuresBoot using a staged installation](https://codice.atlassian.net/browse/DDF-3072)\r\n- [DDF-3073 Implement a fallback auditing option if log4j fails to write the audit log for some reason](https://codice.atlassian.net/browse/DDF-3073)\r\n- [DDF-3075 Re-evaluate the need for the ConfigurationFilesPoller](https://codice.atlassian.net/browse/DDF-3075)\r\n- [DDF-3076 Re-evaluate the implementation of the ApplicationService](https://codice.atlassian.net/browse/DDF-3076)\r\n- [DDF-3077 Fix unstable cometd itests in TestFederation](https://codice.atlassian.net/browse/DDF-3077)\r\n- [KARAF-5211 NPE in StoredWiringResolver if BundleEvent.UNRESOLVED handled before BundleEvent.RESOLVED event](https://issues.apache.org/jira/browse/KARAF-5211)\r\n\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [x] Documentation Updated\r\n- [ ] Change Log Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2017-06-13T23:18:20Z","updated_at":"2017-06-26T17:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"159ff73b318a182ae3645fdb1295a085cb632edd","assignee":{"login":"clockard","id":5248090,"avatar_url":"https://avatars2.githubusercontent.com/u/5248090?v=3","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},"assignees":[{"login":"clockard","id":5248090,"avatar_url":"https://avatars2.githubusercontent.com/u/5248090?v=3","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/2061/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/2061/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/2061/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/988a81be3e43cc40bcf97a295176f72c4d24f270","head":{"label":"emmberk:DDF-2132","ref":"DDF-2132","sha":"988a81be3e43cc40bcf97a295176f72c4d24f270","user":{"login":"emmberk","id":8041246,"avatar_url":"https://avatars0.githubusercontent.com/u/8041246?v=3","gravatar_id":"","url":"https://api.github.com/users/emmberk","html_url":"https://github.com/emmberk","followers_url":"https://api.github.com/users/emmberk/followers","following_url":"https://api.github.com/users/emmberk/following{/other_user}","gists_url":"https://api.github.com/users/emmberk/gists{/gist_id}","starred_url":"https://api.github.com/users/emmberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmberk/subscriptions","organizations_url":"https://api.github.com/users/emmberk/orgs","repos_url":"https://api.github.com/users/emmberk/repos","events_url":"https://api.github.com/users/emmberk/events{/privacy}","received_events_url":"https://api.github.com/users/emmberk/received_events","type":"User","site_admin":false},"repo":{"id":60542616,"name":"ddf","full_name":"emmberk/ddf","owner":{"login":"emmberk","id":8041246,"avatar_url":"https://avatars0.githubusercontent.com/u/8041246?v=3","gravatar_id":"","url":"https://api.github.com/users/emmberk","html_url":"https://github.com/emmberk","followers_url":"https://api.github.com/users/emmberk/followers","following_url":"https://api.github.com/users/emmberk/following{/other_user}","gists_url":"https://api.github.com/users/emmberk/gists{/gist_id}","starred_url":"https://api.github.com/users/emmberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmberk/subscriptions","organizations_url":"https://api.github.com/users/emmberk/orgs","repos_url":"https://api.github.com/users/emmberk/repos","events_url":"https://api.github.com/users/emmberk/events{/privacy}","received_events_url":"https://api.github.com/users/emmberk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emmberk/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/emmberk/ddf","forks_url":"https://api.github.com/repos/emmberk/ddf/forks","keys_url":"https://api.github.com/repos/emmberk/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmberk/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmberk/ddf/teams","hooks_url":"https://api.github.com/repos/emmberk/ddf/hooks","issue_events_url":"https://api.github.com/repos/emmberk/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/emmberk/ddf/events","assignees_url":"https://api.github.com/repos/emmberk/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/emmberk/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/emmberk/ddf/tags","blobs_url":"https://api.github.com/repos/emmberk/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmberk/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmberk/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmberk/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmberk/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/emmberk/ddf/languages","stargazers_url":"https://api.github.com/repos/emmberk/ddf/stargazers","contributors_url":"https://api.github.com/repos/emmberk/ddf/contributors","subscribers_url":"https://api.github.com/repos/emmberk/ddf/subscribers","subscription_url":"https://api.github.com/repos/emmberk/ddf/subscription","commits_url":"https://api.github.com/repos/emmberk/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmberk/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmberk/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmberk/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/emmberk/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/emmberk/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmberk/ddf/merges","archive_url":"https://api.github.com/repos/emmberk/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmberk/ddf/downloads","issues_url":"https://api.github.com/repos/emmberk/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/emmberk/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/emmberk/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/emmberk/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmberk/ddf/labels{/name}","releases_url":"https://api.github.com/repos/emmberk/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/emmberk/ddf/deployments","created_at":"2016-06-06T16:18:42Z","updated_at":"2016-06-06T16:18:54Z","pushed_at":"2017-06-23T16:02:56Z","git_url":"git://github.com/emmberk/ddf.git","ssh_url":"git@github.com:emmberk/ddf.git","clone_url":"https://github.com/emmberk/ddf.git","svn_url":"https://github.com/emmberk/ddf","homepage":"http://ddf.codice.org","size":164286,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"07f3c8b489d43b5e1cb8f636c83e593b13a81c9f","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2017-06-22T10:09:52Z","pushed_at":"2017-06-26T17:39:08Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":322653,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":33,"forks":113,"open_issues":33,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/2061"},"html":{"href":"https://github.com/codice/ddf/pull/2061"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/2061"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/2061/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/2061/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/2061/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/988a81be3e43cc40bcf97a295176f72c4d24f270"}}}}
{"actor":{"display_login":"emmberk"}}