{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8626","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8626/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8626/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8626/events","html_url":"https://github.com/rapid7/metasploit-framework/issues/8626","id":238993789,"number":8626,"title":"Do we need the binary encoding segment in our .rb files?","user":{"login":"sempervictus","id":1331084,"avatar_url":"https://avatars2.githubusercontent.com/u/1331084?v=4","gravatar_id":"","url":"https://api.github.com/users/sempervictus","html_url":"https://github.com/sempervictus","followers_url":"https://api.github.com/users/sempervictus/followers","following_url":"https://api.github.com/users/sempervictus/following{/other_user}","gists_url":"https://api.github.com/users/sempervictus/gists{/gist_id}","starred_url":"https://api.github.com/users/sempervictus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempervictus/subscriptions","organizations_url":"https://api.github.com/users/sempervictus/orgs","repos_url":"https://api.github.com/users/sempervictus/repos","events_url":"https://api.github.com/users/sempervictus/events{/privacy}","received_events_url":"https://api.github.com/users/sempervictus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-06-27T21:51:24Z","updated_at":"2017-08-29T01:58:06Z","closed_at":"2017-08-29T01:58:06Z","body":"In trying to make Metasploit run GIL-free with the fun aspects of RBX (JIT, partial pre-compilation, channels, etc) i ran into an awesome problem described in [this RBX issue](https://github.com/rubinius/rubinius/issues/3749).\r\n\r\nIt makes me wonder, do we, in MRI 2.3+, still need to use this approach introduced when we were fighting the new Ruby 1.9 encoding madness? Any Ruby experts in dev or community who could weigh in on this? Anyone who knows the history behind this please speak up (@hdm, @egypt) as IIRC there were some unpleasant and deep issues which came up from this, and i'm afraid spec might miss them resulting in another Starship Troopers movie hunting those bugs later.\r\n\r\n----\r\nFor those of you who remember this descent into madness from last time (~5y?), just think of this as a form of tenacity as opposed to marine bull-headedness ;-). The GIL must fall!"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/325532033","html_url":"https://github.com/rapid7/metasploit-framework/issues/8626#issuecomment-325532033","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8626","id":325532033,"user":{"login":"busterb","id":4108654,"avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T01:58:06Z","updated_at":"2017-08-29T01:58:06Z","body":"I'm going to close this, I think the question was answered."}}
{"actor":{"display_login":"busterb"}}