{"action":"opened","number":1466,"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/1466","id":158959035,"html_url":"https://github.com/stellar/stellar-core/pull/1466","diff_url":"https://github.com/stellar/stellar-core/pull/1466.diff","patch_url":"https://github.com/stellar/stellar-core/pull/1466.patch","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/1466","number":1466,"state":"open","locked":false,"title":"Upgrade improvements part 1: database driven upgrades","user":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars3.githubusercontent.com/u/4213763?v=4","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"body":"This PR addresses the first part of #1453 \r\n\r\nIt changes the way network settings are done:\r\n1. It replaces the config driven upgrade mechanism by a \"single shot\" mechanism that gets cleared when the desired upgrade is seen from SCP\r\n2. requires node operators to specify that they want an upgrade (as opposed to guessing based on config values). This makes voting for upgrades by accident much less likely.\r\n\r\nThe next round of changes will address the remainder of #1453 by changing the way values are validated (ie: this PR doesn't change the \"strictness\" requirement on the upgrade values).\r\n","created_at":"2017-12-18T16:29:28Z","updated_at":"2017-12-18T16:29:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1466/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1466/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/1466/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/c09fa7566194c43f60fd5925e1c7bbc9375e33ab","head":{"label":"MonsieurNicolas:upgradeImprovementsSingleShot","ref":"upgradeImprovementsSingleShot","sha":"c09fa7566194c43f60fd5925e1c7bbc9375e33ab","user":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars3.githubusercontent.com/u/4213763?v=4","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"repo":{"id":29325989,"name":"stellar-core","full_name":"MonsieurNicolas/stellar-core","owner":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars3.githubusercontent.com/u/4213763?v=4","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MonsieurNicolas/stellar-core","description":null,"fork":true,"url":"https://api.github.com/repos/MonsieurNicolas/stellar-core","forks_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/forks","keys_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/teams","hooks_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/events","assignees_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/tags","blobs_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/languages","stargazers_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/subscription","commits_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/merges","archive_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/downloads","issues_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/MonsieurNicolas/stellar-core/deployments","created_at":"2015-01-16T00:58:46Z","updated_at":"2017-09-23T08:25:40Z","pushed_at":"2017-12-18T16:24:26Z","git_url":"git://github.com/MonsieurNicolas/stellar-core.git","ssh_url":"git@github.com:MonsieurNicolas/stellar-core.git","clone_url":"https://github.com/MonsieurNicolas/stellar-core.git","svn_url":"https://github.com/MonsieurNicolas/stellar-core","homepage":null,"size":13464,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"59482f9d18afca67bdf935fec5c30a88d2332e68","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":27085821,"name":"stellar-core","full_name":"stellar/stellar-core","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-core","forks_url":"https://api.github.com/repos/stellar/stellar-core/forks","keys_url":"https://api.github.com/repos/stellar/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-core/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-core/events","assignees_url":"https://api.github.com/repos/stellar/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-core/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-core/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-core/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-core/merges","archive_url":"https://api.github.com/repos/stellar/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-core/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-core/deployments","created_at":"2014-11-24T17:11:12Z","updated_at":"2017-12-18T13:56:58Z","pushed_at":"2017-12-16T00:14:19Z","git_url":"git://github.com/stellar/stellar-core.git","ssh_url":"git@github.com:stellar/stellar-core.git","clone_url":"https://github.com/stellar/stellar-core.git","svn_url":"https://github.com/stellar/stellar-core","homepage":"","size":13322,"stargazers_count":693,"watchers_count":693,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":209,"open_issues":137,"watchers":693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1466"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1466"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1466"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1466/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1466/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1466/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-core/statuses/c09fa7566194c43f60fd5925e1c7bbc9375e33ab"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":8,"additions":543,"deletions":219,"changed_files":25}}
{"actor":{"display_login":"MonsieurNicolas"}}