{"action":"created","issue":{"url":"https://api.github.com/repos/eclipsesource/J2V8/issues/280","repository_url":"https://api.github.com/repos/eclipsesource/J2V8","labels_url":"https://api.github.com/repos/eclipsesource/J2V8/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/eclipsesource/J2V8/issues/280/comments","events_url":"https://api.github.com/repos/eclipsesource/J2V8/issues/280/events","html_url":"https://github.com/eclipsesource/J2V8/pull/280","id":236224755,"number":280,"title":"cross-platform, cross-compile build toolchain","user":{"login":"drywolf","id":394294,"avatar_url":"https://avatars3.githubusercontent.com/u/394294?v=3","gravatar_id":"","url":"https://api.github.com/users/drywolf","html_url":"https://github.com/drywolf","followers_url":"https://api.github.com/users/drywolf/followers","following_url":"https://api.github.com/users/drywolf/following{/other_user}","gists_url":"https://api.github.com/users/drywolf/gists{/gist_id}","starred_url":"https://api.github.com/users/drywolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drywolf/subscriptions","organizations_url":"https://api.github.com/users/drywolf/orgs","repos_url":"https://api.github.com/users/drywolf/repos","events_url":"https://api.github.com/users/drywolf/events{/privacy}","received_events_url":"https://api.github.com/users/drywolf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-06-15T15:13:39Z","updated_at":"2017-06-22T22:10:11Z","closed_at":"2017-06-22T21:43:15Z","pull_request":{"url":"https://api.github.com/repos/eclipsesource/J2V8/pulls/280","html_url":"https://github.com/eclipsesource/J2V8/pull/280","diff_url":"https://github.com/eclipsesource/J2V8/pull/280.diff","patch_url":"https://github.com/eclipsesource/J2V8/pull/280.patch"},"body":"This adds an easy-to-use, automated build toolchain that should replace the previous shell scripts and manual labor that is necessary to produce a working & tested build for all of the platforms & architectures that J2V8 should support.\r\n\r\nsee #232 and #261\r\n\r\n**Note:** I left most of the existing shell scripts and Dockerfiles in place, but once this PR is merged we should go ahead and clean up everything that is deprecated by this PR.\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/eclipsesource/J2V8/issues/comments/310516578","html_url":"https://github.com/eclipsesource/J2V8/pull/280#issuecomment-310516578","issue_url":"https://api.github.com/repos/eclipsesource/J2V8/issues/280","id":310516578,"user":{"login":"drywolf","id":394294,"avatar_url":"https://avatars3.githubusercontent.com/u/394294?v=3","gravatar_id":"","url":"https://api.github.com/users/drywolf","html_url":"https://github.com/drywolf","followers_url":"https://api.github.com/users/drywolf/followers","following_url":"https://api.github.com/users/drywolf/following{/other_user}","gists_url":"https://api.github.com/users/drywolf/gists{/gist_id}","starred_url":"https://api.github.com/users/drywolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drywolf/subscriptions","organizations_url":"https://api.github.com/users/drywolf/orgs","repos_url":"https://api.github.com/users/drywolf/repos","events_url":"https://api.github.com/users/drywolf/events{/privacy}","received_events_url":"https://api.github.com/users/drywolf/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T22:10:11Z","updated_at":"2017-06-22T22:10:11Z","body":"Thanks @irbull for the review & merge. I will have a look at the detailed comments tomorrow.\r\n\r\n> To make this practical, we need a way to use / reuse a pre-built node.js. I saw that this will use one if it exists from a previous run of the the build, but on a build server with a fresh workspace, a prebuilt version won't be there. It can take up to 1 hour to build node.js, and travis-ci will timeout long before that. If we provide a prebuilt node.js, the build script can D/L that. For people who want to build everything from scratch, we can support that too.\r\n\r\nThe built / prebuilt node binaries are expected to be located in `./cmake.out/{platform}.{arch}/`\r\nI have integrated a mechanism that the build script will automatically reuse binaries if they were previously built. This should be also potentially cover the need to pre-building and shipping node binaries for a CI build. I have not tested it under this circumstances yet, but in theory it should already be able to do the trick.\r\n\r\n> We should add some overview to each of the .py scripts, especially the ones at the root. I'm not sure what each one does, or if users are expected to execute them.\r\n\r\nAgreed. I will start work on this tomorrow.\r\n\r\n> There appears to be lots of commented out code in some of the scripts, especially the build_all.py. We should remove commented out code.\r\n\r\nI like your emphasis on that :smile: I'm usually pretty nitpicky when it comes to commented code too. I hope I did not forget to remove too much of dead code. For the `build_all.py` I left it there because this file was just for experimenting / developing / testing and it's what I thought could become an entry point for a full build of all platform if we really need that.\r\n"}}
{"actor":{"display_login":"drywolf"}}