{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/106786695","pull_request_review_id":27729940,"id":106786695,"diff_hunk":"@@ -20,6 +20,7 @@ in\n       { NIXPKGS_CONFIG = \"/etc/nix/nixpkgs-config.nix\";\n         PAGER = mkDefault \"less -R\";\n         EDITOR = mkDefault \"nano\";\n+        XCURSOR_PATH = \"$HOME/.icons\";","path":"nixos/modules/programs/environment.nix","position":4,"original_position":4,"commit_id":"f80eeb5d854cc5b0ae6f66616c1f29aabf0e0279","original_commit_id":"f80eeb5d854cc5b0ae6f66616c1f29aabf0e0279","user":{"login":"copumpkin","id":2623,"avatar_url":"https://avatars2.githubusercontent.com/u/2623?v=3","gravatar_id":"","url":"https://api.github.com/users/copumpkin","html_url":"https://github.com/copumpkin","followers_url":"https://api.github.com/users/copumpkin/followers","following_url":"https://api.github.com/users/copumpkin/following{/other_user}","gists_url":"https://api.github.com/users/copumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/copumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copumpkin/subscriptions","organizations_url":"https://api.github.com/users/copumpkin/orgs","repos_url":"https://api.github.com/users/copumpkin/repos","events_url":"https://api.github.com/users/copumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/copumpkin/received_events","type":"User","site_admin":false},"body":"This seems a little out of place at the very top level. Many of us don't even use a graphical system. All my NixOS boxes are headless EC2 instances. This doesn't really hurt anything, but it probably belongs in a different module?","created_at":"2017-03-18T17:49:43Z","updated_at":"2017-03-18T17:49:43Z","html_url":"https://github.com/NixOS/nixpkgs/pull/24005#discussion_r106786695","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/106786695"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/24005#discussion_r106786695"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005","id":111406432,"html_url":"https://github.com/NixOS/nixpkgs/pull/24005","diff_url":"https://github.com/NixOS/nixpkgs/pull/24005.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/24005.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24005","number":24005,"state":"open","locked":false,"title":"nixos: Define XCURSOR_PATH environment variable.","user":{"login":"ambrop72","id":2626481,"avatar_url":"https://avatars1.githubusercontent.com/u/2626481?v=3","gravatar_id":"","url":"https://api.github.com/users/ambrop72","html_url":"https://github.com/ambrop72","followers_url":"https://api.github.com/users/ambrop72/followers","following_url":"https://api.github.com/users/ambrop72/following{/other_user}","gists_url":"https://api.github.com/users/ambrop72/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrop72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrop72/subscriptions","organizations_url":"https://api.github.com/users/ambrop72/orgs","repos_url":"https://api.github.com/users/ambrop72/repos","events_url":"https://api.github.com/users/ambrop72/events{/privacy}","received_events_url":"https://api.github.com/users/ambrop72/received_events","type":"User","site_admin":false},"body":"In the absence of XCURSOR_PATH, the function XcursorLibraryPath\r\nin libXcursor will return a hardcoded value unsuitable for NixOS.\r\nSome desktops as well as display managers in NixOS currently do\r\nset XCURSOR_PATH, but there are combinations where neither does\r\n(e.g. SDDM+XFCE), resulting in no cursor themes being available.\r\n\r\nThe new definition if XCURSOR_PATH is effectively the same as what\r\nKDE's startkde currently does. The pre-existing definitions of (which can\r\nbe found by grepping nixpkgs for XCURSOR_PATH) can probably be\r\nremoved then.\r\n\r\nFixes issue #21442.\r\n\r\nNote this is applicable for 16.09 and 17.03 as well.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-03-18T11:03:51Z","updated_at":"2017-03-18T17:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca58b67f2dda9b2d5e89e214bad0ea26d11722d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24005/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f80eeb5d854cc5b0ae6f66616c1f29aabf0e0279","head":{"label":"ambrop72:xcursor-path","ref":"xcursor-path","sha":"f80eeb5d854cc5b0ae6f66616c1f29aabf0e0279","user":{"login":"ambrop72","id":2626481,"avatar_url":"https://avatars1.githubusercontent.com/u/2626481?v=3","gravatar_id":"","url":"https://api.github.com/users/ambrop72","html_url":"https://github.com/ambrop72","followers_url":"https://api.github.com/users/ambrop72/followers","following_url":"https://api.github.com/users/ambrop72/following{/other_user}","gists_url":"https://api.github.com/users/ambrop72/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrop72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrop72/subscriptions","organizations_url":"https://api.github.com/users/ambrop72/orgs","repos_url":"https://api.github.com/users/ambrop72/repos","events_url":"https://api.github.com/users/ambrop72/events{/privacy}","received_events_url":"https://api.github.com/users/ambrop72/received_events","type":"User","site_admin":false},"repo":{"id":17639503,"name":"nixpkgs","full_name":"ambrop72/nixpkgs","owner":{"login":"ambrop72","id":2626481,"avatar_url":"https://avatars1.githubusercontent.com/u/2626481?v=3","gravatar_id":"","url":"https://api.github.com/users/ambrop72","html_url":"https://github.com/ambrop72","followers_url":"https://api.github.com/users/ambrop72/followers","following_url":"https://api.github.com/users/ambrop72/following{/other_user}","gists_url":"https://api.github.com/users/ambrop72/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrop72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrop72/subscriptions","organizations_url":"https://api.github.com/users/ambrop72/orgs","repos_url":"https://api.github.com/users/ambrop72/repos","events_url":"https://api.github.com/users/ambrop72/events{/privacy}","received_events_url":"https://api.github.com/users/ambrop72/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ambrop72/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/ambrop72/nixpkgs","forks_url":"https://api.github.com/repos/ambrop72/nixpkgs/forks","keys_url":"https://api.github.com/repos/ambrop72/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambrop72/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambrop72/nixpkgs/teams","hooks_url":"https://api.github.com/repos/ambrop72/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/ambrop72/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/ambrop72/nixpkgs/events","assignees_url":"https://api.github.com/repos/ambrop72/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/ambrop72/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/ambrop72/nixpkgs/tags","blobs_url":"https://api.github.com/repos/ambrop72/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambrop72/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambrop72/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambrop72/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambrop72/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/ambrop72/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/ambrop72/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/ambrop72/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/ambrop72/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/ambrop72/nixpkgs/subscription","commits_url":"https://api.github.com/repos/ambrop72/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambrop72/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambrop72/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambrop72/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambrop72/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/ambrop72/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambrop72/nixpkgs/merges","archive_url":"https://api.github.com/repos/ambrop72/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambrop72/nixpkgs/downloads","issues_url":"https://api.github.com/repos/ambrop72/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/ambrop72/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/ambrop72/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/ambrop72/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambrop72/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/ambrop72/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/ambrop72/nixpkgs/deployments","created_at":"2014-03-11T17:26:01Z","updated_at":"2016-05-08T12:28:25Z","pushed_at":"2017-03-18T11:05:35Z","git_url":"git://github.com/ambrop72/nixpkgs.git","ssh_url":"git@github.com:ambrop72/nixpkgs.git","clone_url":"https://github.com/ambrop72/nixpkgs.git","svn_url":"https://github.com/ambrop72/nixpkgs","homepage":null,"size":448397,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"54aff5c3a72578c99ba767ecc6ff35ecdaa0e0e2","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-03-18T15:03:09Z","pushed_at":"2017-03-18T17:47:14Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":423622,"stargazers_count":1565,"watchers_count":1565,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1937,"mirror_url":null,"open_issues_count":1878,"forks":1937,"open_issues":1878,"watchers":1565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/24005"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/24005"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/24005/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24005/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f80eeb5d854cc5b0ae6f66616c1f29aabf0e0279"}}}}
{"actor":{"display_login":"copumpkin"}}