{"action":"created","issue":{"url":"https://api.github.com/repos/openaps/oref0/issues/480","repository_url":"https://api.github.com/repos/openaps/oref0","labels_url":"https://api.github.com/repos/openaps/oref0/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/openaps/oref0/issues/480/comments","events_url":"https://api.github.com/repos/openaps/oref0/issues/480/events","html_url":"https://github.com/openaps/oref0/issues/480","id":231218228,"number":480,"title":"Some oref1 users have null/0 CSF reported; bonks autotune report despite valid calculations","user":{"login":"danamlewis","id":7468165,"avatar_url":"https://avatars3.githubusercontent.com/u/7468165?v=3","gravatar_id":"","url":"https://api.github.com/users/danamlewis","html_url":"https://github.com/danamlewis","followers_url":"https://api.github.com/users/danamlewis/followers","following_url":"https://api.github.com/users/danamlewis/following{/other_user}","gists_url":"https://api.github.com/users/danamlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/danamlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danamlewis/subscriptions","organizations_url":"https://api.github.com/users/danamlewis/orgs","repos_url":"https://api.github.com/users/danamlewis/repos","events_url":"https://api.github.com/users/danamlewis/events{/privacy}","received_events_url":"https://api.github.com/users/danamlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-05-25T01:50:01Z","updated_at":"2017-05-30T20:54:56Z","closed_at":null,"body":"2+ oref1 users are seeing autotune reports that don't show the tuned results, because somehow CSF is getting translated as 0. It complains about  https://github.com/openaps/oref0/blob/master/bin/oref0-autotune-recommends-report.sh#L72 by erroring \"/usr/local/bin/oref0-autotune-recommends-report: line 72: printf: null: invalid number\" in the logs\r\n\r\n```\r\nAutotune pump profile recommendations:\r\n---------------------------------------------------------\r\nRecommendations Log File: /root/johnopenaps/autotune/autotune_recommendations.log\r\n\r\n/usr/local/bin/oref0-autotune-recommends-report: line 72: printf: null: invalid number\r\nParameter      | Current  | Autotune \r\n-------------------------------------\r\nISF            | 30.000   | 30.000   \r\nCSF            | n/a      | 0.000    \r\nCarb Ratio     | 10.000   | 10.000   \r\n  00:00        | 1.750    | 1.750    \r\n  03:30        | 1.650    | 1.650    \r\n  06:00        | 1.650    | 1.650    \r\n  08:30        | 1.650    | 1.650    \r\n  11:30        | 2.000    | 2.000    \r\n  13:00        | 2.150    | 2.150    \r\n  15:30        | 1.900    | 1.900    \r\n  19:00        | 3.000    | 3.000    \r\n  22:00        | 3.000    | 3.000\r\n```\r\n\r\nbut actually does do the calculations, shown in the logs above that, i.e.:\r\n```\r\n  { i: 21, start: '21:00:00', rate: 3, minutes: 1260 },\r\n  { i: 22, start: '22:00:00', rate: 3, minutes: 1320 },\r\n  { i: 23, start: '23:00:00', rate: 3, minutes: 1380 } ]\r\np50deviation: -1.59 p50BGI -2.8600000000000003 p50ratios: 1.682 Old ISF: 30 fullNewISF: 50.46 adjustedISF: 40.230000000000004 newISF: 31.023\r\ntotalMealCarbs: 58 totalDeviations: 481.73999999999984 fullNewCSF: 8.31 newCSF: 3.531\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/openaps/oref0/issues/comments/305005307","html_url":"https://github.com/openaps/oref0/issues/480#issuecomment-305005307","issue_url":"https://api.github.com/repos/openaps/oref0/issues/480","id":305005307,"user":{"login":"davidkeddydb","id":10411709,"avatar_url":"https://avatars0.githubusercontent.com/u/10411709?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkeddydb","html_url":"https://github.com/davidkeddydb","followers_url":"https://api.github.com/users/davidkeddydb/followers","following_url":"https://api.github.com/users/davidkeddydb/following{/other_user}","gists_url":"https://api.github.com/users/davidkeddydb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkeddydb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkeddydb/subscriptions","organizations_url":"https://api.github.com/users/davidkeddydb/orgs","repos_url":"https://api.github.com/users/davidkeddydb/repos","events_url":"https://api.github.com/users/davidkeddydb/events{/privacy}","received_events_url":"https://api.github.com/users/davidkeddydb/received_events","type":"User","site_admin":false},"created_at":"2017-05-30T20:54:56Z","updated_at":"2017-05-30T20:54:56Z","body":"Dana,\n\nNot sure if I respond back by email if you get it or not, but here it goes.\n\nI should be able to try the prescribed fix on my rig at home later this evening.  Will update once complete.\n\n\nDavid Eddy\nPresident\nNEFCO Fire Investigations\nwww.nefco.net\n(800) 675-8500\n\nSubmit an assignment<http://extranet.nefco.net/client.php>\n\nFrom: Dana Lewis <notifications@github.com<mailto:notifications@github.com>>\nReply-To: openaps/oref0 <reply@reply.github.com<mailto:reply@reply.github.com>>\nDate: Tuesday, May 30, 2017 at 2:07 PM\nTo: openaps/oref0 <oref0@noreply.github.com<mailto:oref0@noreply.github.com>>\nCc: David Eddy <deddy@nefco.net<mailto:deddy@nefco.net>>, Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>>\nSubject: Re: [openaps/oref0] Some oref1 users have null/0 CSF reported; bonks autotune report despite valid calculations (#480)\n\n\n@ceben80<https://github.com/ceben80> @davidkeddydb<https://github.com/davidkeddydb> can one or both of you try #484 (comment)<https://github.com/openaps/oref0/pull/484#issuecomment-304707629>, and if that fixes it, please comment on the PR so we can merge it in to dev?\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub<https://github.com/openaps/oref0/issues/480#issuecomment-304961110>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJ7evQuzscT09jrNsu5r9Z0MILC0mrgOks5r_FrwgaJpZM4Nl3d5>.\n"}}
{"actor":{"display_login":"davidkeddydb"}}