{"action":"created","issue":{"url":"https://api.github.com/repos/styled-components/styled-components/issues/640","repository_url":"https://api.github.com/repos/styled-components/styled-components","labels_url":"https://api.github.com/repos/styled-components/styled-components/issues/640/labels{/name}","comments_url":"https://api.github.com/repos/styled-components/styled-components/issues/640/comments","events_url":"https://api.github.com/repos/styled-components/styled-components/issues/640/events","html_url":"https://github.com/styled-components/styled-components/pull/640","id":218778183,"number":640,"title":"Add `no-parser` entry to the Rollup build","user":{"login":"YasserKaddour","id":7279640,"avatar_url":"https://avatars0.githubusercontent.com/u/7279640?v=3","gravatar_id":"","url":"https://api.github.com/users/YasserKaddour","html_url":"https://github.com/YasserKaddour","followers_url":"https://api.github.com/users/YasserKaddour/followers","following_url":"https://api.github.com/users/YasserKaddour/following{/other_user}","gists_url":"https://api.github.com/users/YasserKaddour/gists{/gist_id}","starred_url":"https://api.github.com/users/YasserKaddour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YasserKaddour/subscriptions","organizations_url":"https://api.github.com/users/YasserKaddour/orgs","repos_url":"https://api.github.com/users/YasserKaddour/repos","events_url":"https://api.github.com/users/YasserKaddour/events{/privacy}","received_events_url":"https://api.github.com/users/YasserKaddour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-02T17:10:06Z","updated_at":"2017-04-03T11:33:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/styled-components/styled-components/pulls/640","html_url":"https://github.com/styled-components/styled-components/pull/640","diff_url":"https://github.com/styled-components/styled-components/pull/640.diff","patch_url":"https://github.com/styled-components/styled-components/pull/640.patch"},"body":"This is my attempt to make @philpl valiant effort on the prepossessing feature benefit the Rollup goodness.\r\nThe parsed size shrinked from `32.6kB` to `23.9kB`, and the gziped size from `15.2kB` to `8.4kB` :tada:\r\n\r\nHowever, I have no idea how to make `webpack` aware of the es module, since the `module` field in `package.json` is only for the main entry. I tried finding some online resource with no success, this my first time dealing with npm packages, any guidance on this will be appreciated. \r\nTo make it work I changed `module.exports = require('./lib/no-parser')` to `module.exports = require('./dist/no-parser')` in `/no-parser.js`, but this is not what we want.\r\n\r\nThank you all, for this awesome library."},"comment":{"url":"https://api.github.com/repos/styled-components/styled-components/issues/comments/291117659","html_url":"https://github.com/styled-components/styled-components/pull/640#issuecomment-291117659","issue_url":"https://api.github.com/repos/styled-components/styled-components/issues/640","id":291117659,"user":{"login":"YasserKaddour","id":7279640,"avatar_url":"https://avatars0.githubusercontent.com/u/7279640?v=3","gravatar_id":"","url":"https://api.github.com/users/YasserKaddour","html_url":"https://github.com/YasserKaddour","followers_url":"https://api.github.com/users/YasserKaddour/followers","following_url":"https://api.github.com/users/YasserKaddour/following{/other_user}","gists_url":"https://api.github.com/users/YasserKaddour/gists{/gist_id}","starred_url":"https://api.github.com/users/YasserKaddour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YasserKaddour/subscriptions","organizations_url":"https://api.github.com/users/YasserKaddour/orgs","repos_url":"https://api.github.com/users/YasserKaddour/repos","events_url":"https://api.github.com/users/YasserKaddour/events{/privacy}","received_events_url":"https://api.github.com/users/YasserKaddour/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T11:33:27Z","updated_at":"2017-04-03T11:33:27Z","body":"@Rich-Harris Thank you, I hope they will decide on this soon.\r\n\r\nIn the meanwhile I come up with a little hacky solution by adding a `module` flag on the babel plugin that changes `require('styled-components/no-parser')` to `require('styled-components/dist/no-parser.es')` \r\n\r\nThis doesn't solve @philpl problem, but work fine if you don't use plugins. WDYT?"}}
{"actor":{"display_login":"YasserKaddour"}}