{"action":"created","issue":{"url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1308","repository_url":"https://api.github.com/repos/hibernate/hibernate-search","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1308/labels{/name}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1308/comments","events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1308/events","html_url":"https://github.com/hibernate/hibernate-search/pull/1308","id":205957119,"number":1308,"title":"HSEARCH-2418 (+HSEARCH-2577) Introduce *AnalyzerDefinitionProvider SPIs","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"labels":[{"id":120285237,"url":"https://api.github.com/repos/hibernate/hibernate-search/labels/Ready%20for%20review","name":"Ready for review","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"assignees":[{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-02-07T17:20:14Z","updated_at":"2017-02-15T14:58:29Z","closed_at":"2017-02-15T14:56:00Z","pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1308","html_url":"https://github.com/hibernate/hibernate-search/pull/1308","diff_url":"https://github.com/hibernate/hibernate-search/pull/1308.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1308.patch"},"body":"Relevant JIRA tickets:\r\n\r\n * https://hibernate.atlassian.net/browse/HSEARCH-2418\r\n * https://hibernate.atlassian.net/browse/HSEARCH-2577\r\n\r\nAs mentioned in the ticket description for HSEARCH-2577, it may not be 100% required to separate the Lucene/ES namespaces in order to fix HSEARCH-2418, but it definitely makes things easier, and it's probably easier on users too. Also, I happened to have already implemented this change for another ticket (which is still in standby), so we may as well merge it.\r\n\r\nAbout the PR itself:\r\n\r\n * I introduced two `*AnalyzerDefinitionProvider` SPIs, one for Lucene and one for Elasticsearch\r\n * Both definition providers take a builder as a parameter, and simply push their definitions through this builder\r\n * The SPIs are undocumented for now. Do we want to advertise those to users? I think they could be useful, but on the other hand they are still rather primitive (no support for multiple providers, for index-scoped providers, etc.)\r\n * In order to integrate the SPI cleanly in ES, I had to move the definition translation sooner, when building the analyzer references, instead of when starting the index managers. It shouldn't have any practical impact on users, though. Maybe a slight slowdown when using the `NONE` index management strategy?\r\n * Once again, I think it's better to review one commit at a time."},"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments/280033049","html_url":"https://github.com/hibernate/hibernate-search/pull/1308#issuecomment-280033049","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1308","id":280033049,"user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"created_at":"2017-02-15T14:58:29Z","updated_at":"2017-02-15T14:58:29Z","body":"great! merged.\r\n\r\nI did two last changes:\r\n - marked the new DSL as experimental, so we can change it in the next minor with more flexibility.\r\n - changed the JIRA description as the text implied we'd introduce a `Service` (literally) but it's not one."}}
{"actor":{"display_login":"Sanne"}}