{"action":"closed","number":14844,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/14844","id":108623932,"html_url":"https://github.com/angular/angular/pull/14844","diff_url":"https://github.com/angular/angular/pull/14844.diff","patch_url":"https://github.com/angular/angular/pull/14844.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/14844","number":14844,"state":"closed","locked":false,"title":"fix(router): terminal route in custom matcher","user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars2.githubusercontent.com/u/1913805?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\n- [x] Tests for the changes have been added (for bug fixes / features)\n- [ ] Docs have been added / updated (for bug fixes / features)\n\n\n**What kind of change does this PR introduce?** (check one with \"x\")\n```\n[x] Bugfix\n[ ] Feature\n[ ] Code style update (formatting, local variables)\n[ ] Refactoring (no functional changes, no api changes)\n[ ] Build related changes\n[ ] CI related changes\n[ ] Other... Please describe:\n```\n\n**What is the current behavior?** (You can also link to an open issue here)\nhttps://github.com/angular/angular/issues/14833\n\n**What is the new behavior?**\nThat you can use a custom matcher to match terminal routes.\n\n```js\nconst routes = [\n  {\n    matcher: (url: UrlSegment[]) => {\n      return url.length === 0 ? ({consumed: url}) : null;\n    },\n    component: FooComponent\n  }\n];\n```\n\n\n**Does this PR introduce a breaking change?** (check one with \"x\")\n```\n[ ] Yes\n[x] No\n```\n\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\n\n\n**Other information**:","created_at":"2017-03-01T20:40:50Z","updated_at":"2017-07-18T17:25:19Z","closed_at":"2017-07-18T17:25:19Z","merged_at":"2017-07-18T17:25:19Z","merge_commit_sha":"b399cb26d95cf5ea20f92c459bb678c8f13cffdc","assignee":{"login":"jasonaden","id":516168,"avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasonaden","id":516168,"avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/14844/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/14844/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/14844/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/982b53f8cdf004b26def3c0eaa7cef31512d803d","head":{"label":"SamVerschueren:iss14833","ref":"iss14833","sha":"982b53f8cdf004b26def3c0eaa7cef31512d803d","user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars2.githubusercontent.com/u/1913805?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"repo":{"id":83596619,"name":"angular","full_name":"SamVerschueren/angular","owner":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars2.githubusercontent.com/u/1913805?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamVerschueren/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/SamVerschueren/angular","forks_url":"https://api.github.com/repos/SamVerschueren/angular/forks","keys_url":"https://api.github.com/repos/SamVerschueren/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamVerschueren/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamVerschueren/angular/teams","hooks_url":"https://api.github.com/repos/SamVerschueren/angular/hooks","issue_events_url":"https://api.github.com/repos/SamVerschueren/angular/issues/events{/number}","events_url":"https://api.github.com/repos/SamVerschueren/angular/events","assignees_url":"https://api.github.com/repos/SamVerschueren/angular/assignees{/user}","branches_url":"https://api.github.com/repos/SamVerschueren/angular/branches{/branch}","tags_url":"https://api.github.com/repos/SamVerschueren/angular/tags","blobs_url":"https://api.github.com/repos/SamVerschueren/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamVerschueren/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamVerschueren/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamVerschueren/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamVerschueren/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/SamVerschueren/angular/languages","stargazers_url":"https://api.github.com/repos/SamVerschueren/angular/stargazers","contributors_url":"https://api.github.com/repos/SamVerschueren/angular/contributors","subscribers_url":"https://api.github.com/repos/SamVerschueren/angular/subscribers","subscription_url":"https://api.github.com/repos/SamVerschueren/angular/subscription","commits_url":"https://api.github.com/repos/SamVerschueren/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamVerschueren/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamVerschueren/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamVerschueren/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamVerschueren/angular/contents/{+path}","compare_url":"https://api.github.com/repos/SamVerschueren/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamVerschueren/angular/merges","archive_url":"https://api.github.com/repos/SamVerschueren/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamVerschueren/angular/downloads","issues_url":"https://api.github.com/repos/SamVerschueren/angular/issues{/number}","pulls_url":"https://api.github.com/repos/SamVerschueren/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/SamVerschueren/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/SamVerschueren/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamVerschueren/angular/labels{/name}","releases_url":"https://api.github.com/repos/SamVerschueren/angular/releases{/id}","deployments_url":"https://api.github.com/repos/SamVerschueren/angular/deployments","created_at":"2017-03-01T20:09:27Z","updated_at":"2017-03-01T20:09:51Z","pushed_at":"2017-07-15T11:16:33Z","git_url":"git://github.com/SamVerschueren/angular.git","ssh_url":"git@github.com:SamVerschueren/angular.git","clone_url":"https://github.com/SamVerschueren/angular.git","svn_url":"https://github.com/SamVerschueren/angular","homepage":"https://angular.io","size":60644,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"0bf0c35bca71550dc750029100a750585c0634df","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-07-18T17:22:57Z","pushed_at":"2017-07-18T17:25:19Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":62317,"stargazers_count":25950,"watchers_count":25950,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6604,"mirror_url":null,"open_issues_count":1785,"forks":6604,"open_issues":1785,"watchers":25950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/14844"},"html":{"href":"https://github.com/angular/angular/pull/14844"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/14844"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/14844/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/14844/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/14844/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/982b53f8cdf004b26def3c0eaa7cef31512d803d"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"alxhub"}}