{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/comments/98557599","pull_request_review_id":19203358,"id":98557599,"diff_hunk":"@@ -268,6 +265,9 @@ sudo rm -f $ONIE_INSTALLER_PAYLOAD $FILESYSTEM_SQUASHFS\n sudo du -hs $FILESYSTEM_ROOT\n sudo mksquashfs $FILESYSTEM_ROOT $FILESYSTEM_SQUASHFS -e boot -e var/lib/docker\n \n+## Compress docker files\n+pushd $FILESYSTEM_ROOT && sudo tar czf $OLDPWD/$FILESYSTEM_DOCKERFS var/lib/docker; popd\n+\n ## Compress together with /boot and /var/lib/docker as an installer payload zip file\n-pushd $FILESYSTEM_ROOT && sudo zip $OLDPWD/$ONIE_INSTALLER_PAYLOAD -r boot/ -r var/lib/docker; popd","path":"build_debian.sh","position":55,"original_position":55,"commit_id":"97ed6375b5b6059980565f72343b3de3e71a1762","original_commit_id":"97ed6375b5b6059980565f72343b3de3e71a1762","user":{"login":"qiluo-msft","id":11406616,"avatar_url":"https://avatars.githubusercontent.com/u/11406616?v=3","gravatar_id":"","url":"https://api.github.com/users/qiluo-msft","html_url":"https://github.com/qiluo-msft","followers_url":"https://api.github.com/users/qiluo-msft/followers","following_url":"https://api.github.com/users/qiluo-msft/following{/other_user}","gists_url":"https://api.github.com/users/qiluo-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/qiluo-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiluo-msft/subscriptions","organizations_url":"https://api.github.com/users/qiluo-msft/orgs","repos_url":"https://api.github.com/users/qiluo-msft/repos","events_url":"https://api.github.com/users/qiluo-msft/events{/privacy}","received_events_url":"https://api.github.com/users/qiluo-msft/received_events","type":"User","site_admin":false},"body":">-r var/lib/docker; [](start = 76, length = 18)\r\n\r\nWhy remove this excluding path?","created_at":"2017-01-30T22:29:29Z","updated_at":"2017-01-30T22:29:29Z","html_url":"https://github.com/Azure/sonic-buildimage/pull/215#discussion_r98557599","pull_request_url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/comments/98557599"},"html":{"href":"https://github.com/Azure/sonic-buildimage/pull/215#discussion_r98557599"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215","id":103194072,"html_url":"https://github.com/Azure/sonic-buildimage/pull/215","diff_url":"https://github.com/Azure/sonic-buildimage/pull/215.diff","patch_url":"https://github.com/Azure/sonic-buildimage/pull/215.patch","issue_url":"https://api.github.com/repos/Azure/sonic-buildimage/issues/215","number":215,"state":"closed","locked":false,"title":"Single image implementation","user":{"login":"oleksandrivantsiv","id":17766225,"avatar_url":"https://avatars.githubusercontent.com/u/17766225?v=3","gravatar_id":"","url":"https://api.github.com/users/oleksandrivantsiv","html_url":"https://github.com/oleksandrivantsiv","followers_url":"https://api.github.com/users/oleksandrivantsiv/followers","following_url":"https://api.github.com/users/oleksandrivantsiv/following{/other_user}","gists_url":"https://api.github.com/users/oleksandrivantsiv/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksandrivantsiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksandrivantsiv/subscriptions","organizations_url":"https://api.github.com/users/oleksandrivantsiv/orgs","repos_url":"https://api.github.com/users/oleksandrivantsiv/repos","events_url":"https://api.github.com/users/oleksandrivantsiv/events{/privacy}","received_events_url":"https://api.github.com/users/oleksandrivantsiv/received_events","type":"User","site_admin":false},"body":"- generic image is fully backward compatible.\r\n- generic platform for now is default platform (make configure is not required for this platform).\r\n- add infrastructure required to build single image.\r\n- add single image for Mellanox platform only. \"sonic-mellanox.bin\" is default target.\r\n- add all required config files to single image.\r\n- add configuration files templates and generation of config file during startup.\r\n","created_at":"2017-01-25T20:08:39Z","updated_at":"2017-01-30T22:29:29Z","closed_at":"2017-01-29T19:33:34Z","merged_at":"2017-01-29T19:33:34Z","merge_commit_sha":"34ea91349c3d0172ac27b3d8525c46361d184c8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-buildimage/issues/215/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-buildimage/statuses/97ed6375b5b6059980565f72343b3de3e71a1762","head":{"label":"oleksandrivantsiv:master","ref":"master","sha":"97ed6375b5b6059980565f72343b3de3e71a1762","user":{"login":"oleksandrivantsiv","id":17766225,"avatar_url":"https://avatars.githubusercontent.com/u/17766225?v=3","gravatar_id":"","url":"https://api.github.com/users/oleksandrivantsiv","html_url":"https://github.com/oleksandrivantsiv","followers_url":"https://api.github.com/users/oleksandrivantsiv/followers","following_url":"https://api.github.com/users/oleksandrivantsiv/following{/other_user}","gists_url":"https://api.github.com/users/oleksandrivantsiv/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksandrivantsiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksandrivantsiv/subscriptions","organizations_url":"https://api.github.com/users/oleksandrivantsiv/orgs","repos_url":"https://api.github.com/users/oleksandrivantsiv/repos","events_url":"https://api.github.com/users/oleksandrivantsiv/events{/privacy}","received_events_url":"https://api.github.com/users/oleksandrivantsiv/received_events","type":"User","site_admin":false},"repo":{"id":77524331,"name":"sonic-buildimage","full_name":"oleksandrivantsiv/sonic-buildimage","owner":{"login":"oleksandrivantsiv","id":17766225,"avatar_url":"https://avatars.githubusercontent.com/u/17766225?v=3","gravatar_id":"","url":"https://api.github.com/users/oleksandrivantsiv","html_url":"https://github.com/oleksandrivantsiv","followers_url":"https://api.github.com/users/oleksandrivantsiv/followers","following_url":"https://api.github.com/users/oleksandrivantsiv/following{/other_user}","gists_url":"https://api.github.com/users/oleksandrivantsiv/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksandrivantsiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksandrivantsiv/subscriptions","organizations_url":"https://api.github.com/users/oleksandrivantsiv/orgs","repos_url":"https://api.github.com/users/oleksandrivantsiv/repos","events_url":"https://api.github.com/users/oleksandrivantsiv/events{/privacy}","received_events_url":"https://api.github.com/users/oleksandrivantsiv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oleksandrivantsiv/sonic-buildimage","description":"Scripts which perform an installable binary image build for SONiC","fork":true,"url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage","forks_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/forks","keys_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/teams","hooks_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/hooks","issue_events_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/issues/events{/number}","events_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/events","assignees_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/assignees{/user}","branches_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/branches{/branch}","tags_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/tags","blobs_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/statuses/{sha}","languages_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/languages","stargazers_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/stargazers","contributors_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/contributors","subscribers_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/subscribers","subscription_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/subscription","commits_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/contents/{+path}","compare_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/merges","archive_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/downloads","issues_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/issues{/number}","pulls_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/pulls{/number}","milestones_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/milestones{/number}","notifications_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/labels{/name}","releases_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/releases{/id}","deployments_url":"https://api.github.com/repos/oleksandrivantsiv/sonic-buildimage/deployments","created_at":"2016-12-28T10:21:46Z","updated_at":"2016-12-28T10:21:48Z","pushed_at":"2017-01-30T21:18:46Z","git_url":"git://github.com/oleksandrivantsiv/sonic-buildimage.git","ssh_url":"git@github.com:oleksandrivantsiv/sonic-buildimage.git","clone_url":"https://github.com/oleksandrivantsiv/sonic-buildimage.git","svn_url":"https://github.com/oleksandrivantsiv/sonic-buildimage","homepage":null,"size":375,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"c18b65bc167764fe182605f1f73e8cb482716fb5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53432472,"name":"sonic-buildimage","full_name":"Azure/sonic-buildimage","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/sonic-buildimage","description":"Scripts which perform an installable binary image build for SONiC","fork":false,"url":"https://api.github.com/repos/Azure/sonic-buildimage","forks_url":"https://api.github.com/repos/Azure/sonic-buildimage/forks","keys_url":"https://api.github.com/repos/Azure/sonic-buildimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-buildimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-buildimage/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-buildimage/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-buildimage/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-buildimage/events","assignees_url":"https://api.github.com/repos/Azure/sonic-buildimage/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-buildimage/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-buildimage/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-buildimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-buildimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-buildimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-buildimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-buildimage/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-buildimage/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-buildimage/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-buildimage/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-buildimage/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-buildimage/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-buildimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-buildimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-buildimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-buildimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-buildimage/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-buildimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-buildimage/merges","archive_url":"https://api.github.com/repos/Azure/sonic-buildimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-buildimage/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-buildimage/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-buildimage/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-buildimage/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-buildimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-buildimage/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-buildimage/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-buildimage/deployments","created_at":"2016-03-08T17:42:37Z","updated_at":"2016-10-22T07:56:52Z","pushed_at":"2017-01-30T21:18:47Z","git_url":"git://github.com/Azure/sonic-buildimage.git","ssh_url":"git@github.com:Azure/sonic-buildimage.git","clone_url":"https://github.com/Azure/sonic-buildimage.git","svn_url":"https://github.com/Azure/sonic-buildimage","homepage":null,"size":365,"stargazers_count":12,"watchers_count":12,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215"},"html":{"href":"https://github.com/Azure/sonic-buildimage/pull/215"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/issues/215"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-buildimage/statuses/97ed6375b5b6059980565f72343b3de3e71a1762"}}}}
{"actor":{"display_login":"qiluo-msft"}}