{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments/153304091","pull_request_review_id":79290761,"id":153304091,"diff_hunk":"@@ -4,6 +4,7 @@\n #\n include_recipe 'bach_repository::directory'\n include_recipe 'bach_repository::tools'\n+repo_dir =  node[:bach][:repository][:repo_directory]","path":"cookbooks/bach_repository/recipes/gems.rb","position":4,"original_position":4,"commit_id":"a6d3f5afe72eea8d9f32f7f705ff32102ef3b075","original_commit_id":"a6d3f5afe72eea8d9f32f7f705ff32102ef3b075","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars2.githubusercontent.com/u/4192761?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"body":"This should use quoted strings like the lines below and per food-critic.","created_at":"2017-11-27T19:52:11Z","updated_at":"2017-11-27T19:52:11Z","html_url":"https://github.com/bloomberg/chef-bach/pull/1009#discussion_r153304091","pull_request_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments/153304091"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/1009#discussion_r153304091"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009","id":144893321,"html_url":"https://github.com/bloomberg/chef-bach/pull/1009","diff_url":"https://github.com/bloomberg/chef-bach/pull/1009.diff","patch_url":"https://github.com/bloomberg/chef-bach/pull/1009.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/1009","number":1009,"state":"open","locked":false,"title":"Reduce reliance on node search","user":{"login":"pu239ppy","id":4019043,"avatar_url":"https://avatars3.githubusercontent.com/u/4019043?v=4","gravatar_id":"","url":"https://api.github.com/users/pu239ppy","html_url":"https://github.com/pu239ppy","followers_url":"https://api.github.com/users/pu239ppy/followers","following_url":"https://api.github.com/users/pu239ppy/following{/other_user}","gists_url":"https://api.github.com/users/pu239ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/pu239ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pu239ppy/subscriptions","organizations_url":"https://api.github.com/users/pu239ppy/orgs","repos_url":"https://api.github.com/users/pu239ppy/repos","events_url":"https://api.github.com/users/pu239ppy/events{/privacy}","received_events_url":"https://api.github.com/users/pu239ppy/received_events","type":"User","site_admin":false},"body":"Where ever possible remove node search and replace with a custom search that does lookups against cluster.txt\r\n\r\n# Changes\r\n- cluster.txt is the source of node information\r\n- Node ID predefined in cluster.txt\r\n- bcpc_8bit_node_number just refers to data from cluster.txt\r\n- rewrote large parts of functionality that depended on node search output","created_at":"2017-10-05T11:43:07Z","updated_at":"2017-11-27T19:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f71d4c9afc7aa05f0b06267b399d05ab17cdea6f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"http-418","id":1435487,"avatar_url":"https://avatars2.githubusercontent.com/u/1435487?v=4","gravatar_id":"","url":"https://api.github.com/users/http-418","html_url":"https://github.com/http-418","followers_url":"https://api.github.com/users/http-418/followers","following_url":"https://api.github.com/users/http-418/following{/other_user}","gists_url":"https://api.github.com/users/http-418/gists{/gist_id}","starred_url":"https://api.github.com/users/http-418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-418/subscriptions","organizations_url":"https://api.github.com/users/http-418/orgs","repos_url":"https://api.github.com/users/http-418/repos","events_url":"https://api.github.com/users/http-418/events{/privacy}","received_events_url":"https://api.github.com/users/http-418/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/bloomberg/chef-bach/milestones/18","html_url":"https://github.com/bloomberg/chef-bach/milestone/18","labels_url":"https://api.github.com/repos/bloomberg/chef-bach/milestones/18/labels","id":2661090,"number":18,"title":"Release 3.1","description":"","creator":{"login":"vt0r","id":2738646,"avatar_url":"https://avatars3.githubusercontent.com/u/2738646?v=4","gravatar_id":"","url":"https://api.github.com/users/vt0r","html_url":"https://github.com/vt0r","followers_url":"https://api.github.com/users/vt0r/followers","following_url":"https://api.github.com/users/vt0r/following{/other_user}","gists_url":"https://api.github.com/users/vt0r/gists{/gist_id}","starred_url":"https://api.github.com/users/vt0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vt0r/subscriptions","organizations_url":"https://api.github.com/users/vt0r/orgs","repos_url":"https://api.github.com/users/vt0r/repos","events_url":"https://api.github.com/users/vt0r/events{/privacy}","received_events_url":"https://api.github.com/users/vt0r/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":45,"state":"open","created_at":"2017-07-25T15:52:08Z","updated_at":"2017-11-10T16:32:57Z","due_on":"2017-09-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/1009/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/a6d3f5afe72eea8d9f32f7f705ff32102ef3b075","head":{"label":"pu239ppy:squash_node_search","ref":"squash_node_search","sha":"a6d3f5afe72eea8d9f32f7f705ff32102ef3b075","user":{"login":"pu239ppy","id":4019043,"avatar_url":"https://avatars3.githubusercontent.com/u/4019043?v=4","gravatar_id":"","url":"https://api.github.com/users/pu239ppy","html_url":"https://github.com/pu239ppy","followers_url":"https://api.github.com/users/pu239ppy/followers","following_url":"https://api.github.com/users/pu239ppy/following{/other_user}","gists_url":"https://api.github.com/users/pu239ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/pu239ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pu239ppy/subscriptions","organizations_url":"https://api.github.com/users/pu239ppy/orgs","repos_url":"https://api.github.com/users/pu239ppy/repos","events_url":"https://api.github.com/users/pu239ppy/events{/privacy}","received_events_url":"https://api.github.com/users/pu239ppy/received_events","type":"User","site_admin":false},"repo":{"id":36989576,"name":"chef-bach","full_name":"pu239ppy/chef-bach","owner":{"login":"pu239ppy","id":4019043,"avatar_url":"https://avatars3.githubusercontent.com/u/4019043?v=4","gravatar_id":"","url":"https://api.github.com/users/pu239ppy","html_url":"https://github.com/pu239ppy","followers_url":"https://api.github.com/users/pu239ppy/followers","following_url":"https://api.github.com/users/pu239ppy/following{/other_user}","gists_url":"https://api.github.com/users/pu239ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/pu239ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pu239ppy/subscriptions","organizations_url":"https://api.github.com/users/pu239ppy/orgs","repos_url":"https://api.github.com/users/pu239ppy/repos","events_url":"https://api.github.com/users/pu239ppy/events{/privacy}","received_events_url":"https://api.github.com/users/pu239ppy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pu239ppy/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":true,"url":"https://api.github.com/repos/pu239ppy/chef-bach","forks_url":"https://api.github.com/repos/pu239ppy/chef-bach/forks","keys_url":"https://api.github.com/repos/pu239ppy/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pu239ppy/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pu239ppy/chef-bach/teams","hooks_url":"https://api.github.com/repos/pu239ppy/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/pu239ppy/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/pu239ppy/chef-bach/events","assignees_url":"https://api.github.com/repos/pu239ppy/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/pu239ppy/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/pu239ppy/chef-bach/tags","blobs_url":"https://api.github.com/repos/pu239ppy/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pu239ppy/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pu239ppy/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/pu239ppy/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pu239ppy/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/pu239ppy/chef-bach/languages","stargazers_url":"https://api.github.com/repos/pu239ppy/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/pu239ppy/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/pu239ppy/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/pu239ppy/chef-bach/subscription","commits_url":"https://api.github.com/repos/pu239ppy/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/pu239ppy/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/pu239ppy/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/pu239ppy/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/pu239ppy/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/pu239ppy/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pu239ppy/chef-bach/merges","archive_url":"https://api.github.com/repos/pu239ppy/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pu239ppy/chef-bach/downloads","issues_url":"https://api.github.com/repos/pu239ppy/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/pu239ppy/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/pu239ppy/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/pu239ppy/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pu239ppy/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/pu239ppy/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/pu239ppy/chef-bach/deployments","created_at":"2015-06-06T17:52:02Z","updated_at":"2016-12-01T19:20:42Z","pushed_at":"2017-11-24T16:51:07Z","git_url":"git://github.com/pu239ppy/chef-bach.git","ssh_url":"git@github.com:pu239ppy/chef-bach.git","clone_url":"https://github.com/pu239ppy/chef-bach.git","svn_url":"https://github.com/pu239ppy/chef-bach","homepage":null,"size":4775,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"0308bd2f71918c0d5db682ab999b2f7bc729a0eb","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24933148,"name":"chef-bach","full_name":"bloomberg/chef-bach","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bach","forks_url":"https://api.github.com/repos/bloomberg/chef-bach/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bach/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bach/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bach/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bach/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bach/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bach/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bach/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/chef-bach/deployments","created_at":"2014-10-08T09:16:26Z","updated_at":"2017-11-10T19:02:31Z","pushed_at":"2017-11-24T16:53:46Z","git_url":"git://github.com/bloomberg/chef-bach.git","ssh_url":"git@github.com:bloomberg/chef-bach.git","clone_url":"https://github.com/bloomberg/chef-bach.git","svn_url":"https://github.com/bloomberg/chef-bach","homepage":null,"size":5803,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":154,"forks":49,"open_issues":154,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/1009"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/1009"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bach/statuses/a6d3f5afe72eea8d9f32f7f705ff32102ef3b075"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cbaenziger"}}