{"action":"created","issue":{"url":"https://api.github.com/repos/bundler/bundler/issues/5499","repository_url":"https://api.github.com/repos/bundler/bundler","labels_url":"https://api.github.com/repos/bundler/bundler/issues/5499/labels{/name}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/5499/comments","events_url":"https://api.github.com/repos/bundler/bundler/issues/5499/events","html_url":"https://github.com/bundler/bundler/pull/5499","id":211894957,"number":5499,"title":"Lint `newgem` templates","user":{"login":"zachahn","id":93058,"avatar_url":"https://avatars3.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-03-04T17:50:31Z","updated_at":"2017-05-26T20:17:33Z","closed_at":"2017-03-06T18:41:02Z","pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/5499","html_url":"https://github.com/bundler/bundler/pull/5499","diff_url":"https://github.com/bundler/bundler/pull/5499.diff","patch_url":"https://github.com/bundler/bundler/pull/5499.patch"},"body":"When creating a new gem, one of the first things that I do afterwards is install rubocop and swap the single quotes to double quotes.\r\n\r\nI noticed that your `.rubocop.yml` also prefers double quotes, so I was hoping this would be a non-controversial (lol), very slight improvement. I also linted some of the code in ERB tags, but that wasn't my focus.\r\n\r\nSome questions I had were\r\n\r\n- Should I change the `%q{TODO: ...}` in the gemspec to double quotes as well?\r\n- Should I freeze the `VERSION` constant?\r\n- Does this warrant an entry in the changelog?\r\n\r\nLet me know if I should undo anything, or if I should do anything else while I'm here! Thanks 😄 "},"comment":{"url":"https://api.github.com/repos/bundler/bundler/issues/comments/304378906","html_url":"https://github.com/bundler/bundler/pull/5499#issuecomment-304378906","issue_url":"https://api.github.com/repos/bundler/bundler/issues/5499","id":304378906,"user":{"login":"teeparham","id":54017,"avatar_url":"https://avatars1.githubusercontent.com/u/54017?v=3","gravatar_id":"","url":"https://api.github.com/users/teeparham","html_url":"https://github.com/teeparham","followers_url":"https://api.github.com/users/teeparham/followers","following_url":"https://api.github.com/users/teeparham/following{/other_user}","gists_url":"https://api.github.com/users/teeparham/gists{/gist_id}","starred_url":"https://api.github.com/users/teeparham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teeparham/subscriptions","organizations_url":"https://api.github.com/users/teeparham/orgs","repos_url":"https://api.github.com/users/teeparham/repos","events_url":"https://api.github.com/users/teeparham/events{/privacy}","received_events_url":"https://api.github.com/users/teeparham/received_events","type":"User","site_admin":false},"created_at":"2017-05-26T20:17:33Z","updated_at":"2017-05-26T20:17:33Z","body":"I just created a new gem & this made my day! 🥇 "}}
{"actor":{"display_login":"teeparham"}}