{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10642","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10642/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10642/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10642/events","html_url":"https://github.com/civicrm/civicrm-core/pull/10642","id":242109666,"number":10642,"title":"Revert \"CRM-20321, CRM-20652 : Changing membership type should change related contribution and generalise changeFeeSelection function to be used for any entity\"","user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars0.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-11T16:33:33Z","updated_at":"2017-07-11T17:34:17Z","closed_at":"2017-07-11T17:01:48Z","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10642","html_url":"https://github.com/civicrm/civicrm-core/pull/10642","diff_url":"https://github.com/civicrm/civicrm-core/pull/10642.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/10642.patch"},"body":"Reverts civicrm/civicrm-core#10370\n\n---\n\n * [CRM-20321: Changing membership type should change related contribution](https://issues.civicrm.org/jira/browse/CRM-20321)\n * [CRM-20652: Generalise changeFeeSelection function to be used for any entity other](https://issues.civicrm.org/jira/browse/CRM-20652)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/314517204","html_url":"https://github.com/civicrm/civicrm-core/pull/10642#issuecomment-314517204","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10642","id":314517204,"user":{"login":"JoeMurray","id":300943,"avatar_url":"https://avatars2.githubusercontent.com/u/300943?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeMurray","html_url":"https://github.com/JoeMurray","followers_url":"https://api.github.com/users/JoeMurray/followers","following_url":"https://api.github.com/users/JoeMurray/following{/other_user}","gists_url":"https://api.github.com/users/JoeMurray/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeMurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeMurray/subscriptions","organizations_url":"https://api.github.com/users/JoeMurray/orgs","repos_url":"https://api.github.com/users/JoeMurray/repos","events_url":"https://api.github.com/users/JoeMurray/events{/privacy}","received_events_url":"https://api.github.com/users/JoeMurray/received_events","type":"User","site_admin":false},"created_at":"2017-07-11T17:34:16Z","updated_at":"2017-07-11T17:34:16Z","body":"@colemanw 1. the process up to now has been to allow merges if another senior dev not from same org indicates they are passing the PR as ready to merge. That happened in this case, with @seamuslee001 approving the merge. Or has there been a change in policy on this?\r\n\r\nI'm happy to have you do more QA, but concerned that we need clarity on process. Generally, we have been trading reviews with folks in order to get stuff merged with @eileenmcnaughton @jitendrapurohit and in last week or so we are trying to broaden our list of collaborators to help out more folks with getting their stuff reviewed."}}
{"actor":{"display_login":"JoeMurray"}}