{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/comments/145981722","pull_request_review_id":70864343,"id":145981722,"diff_hunk":"@@ -143,13 +143,26 @@ def test_create(self, mock_aws_create_role):\n \n         self.assertEqual(self.superuser.auth0_id, response.data['created_by'])\n \n+    @patch('control_panel_api.models.App.aws_create_role')","path":"control_panel_api/tests/test_views.py","position":4,"original_position":4,"commit_id":"982a0736b808cce2616ce5f28d283341fed4afca","original_commit_id":"982a0736b808cce2616ce5f28d283341fed4afca","user":{"login":"andyhd","id":35194,"avatar_url":"https://avatars3.githubusercontent.com/u/35194?v=4","gravatar_id":"","url":"https://api.github.com/users/andyhd","html_url":"https://github.com/andyhd","followers_url":"https://api.github.com/users/andyhd/followers","following_url":"https://api.github.com/users/andyhd/following{/other_user}","gists_url":"https://api.github.com/users/andyhd/gists{/gist_id}","starred_url":"https://api.github.com/users/andyhd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyhd/subscriptions","organizations_url":"https://api.github.com/users/andyhd/orgs","repos_url":"https://api.github.com/users/andyhd/repos","events_url":"https://api.github.com/users/andyhd/events{/privacy}","received_events_url":"https://api.github.com/users/andyhd/received_events","type":"User","site_admin":false},"body":"ugh, I missed something :(","created_at":"2017-10-20T14:42:19Z","updated_at":"2017-10-20T14:42:19Z","html_url":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44#discussion_r145981722","pull_request_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/comments/145981722"},"html":{"href":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44#discussion_r145981722"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44"}},"in_reply_to_id":145977294},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44","id":147783778,"html_url":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44","diff_url":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44.diff","patch_url":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44.patch","issue_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/44","number":44,"state":"closed","locked":false,"title":"Normalise App.repo_url to not have the trailing '.git'","user":{"login":"xoen","id":238563,"avatar_url":"https://avatars0.githubusercontent.com/u/238563?v=4","gravatar_id":"","url":"https://api.github.com/users/xoen","html_url":"https://github.com/xoen","followers_url":"https://api.github.com/users/xoen/followers","following_url":"https://api.github.com/users/xoen/following{/other_user}","gists_url":"https://api.github.com/users/xoen/gists{/gist_id}","starred_url":"https://api.github.com/users/xoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoen/subscriptions","organizations_url":"https://api.github.com/users/xoen/orgs","repos_url":"https://api.github.com/users/xoen/repos","events_url":"https://api.github.com/users/xoen/events{/privacy}","received_events_url":"https://api.github.com/users/xoen/received_events","type":"User","site_admin":false},"body":"### What\r\nTo avoid ambiguity we're ensuring that the App repo URL will always have\r\nthe same format. This will enable us to simplify the Jenkins job to deploy\r\na webapp.\r\n\r\nThis gets the app details by filtering apps by repo_url but currently has\r\nto perform two separate HTTP requests (in the worst-case scenario) to\r\ntry both versions of the repo URL.\r\n\r\nThis will mean we can just filter by the `repo_url` without the trailing\r\n\".git\".\r\n\r\n### Part of ticket\r\nhttps://trello.com/c/yfUlKPdb/428-cp-api-jenkins-normalise-repourl-and-avoid-possible-second-request\r\n","created_at":"2017-10-20T12:03:27Z","updated_at":"2017-10-20T14:42:19Z","closed_at":"2017-10-20T13:50:04Z","merged_at":"2017-10-20T13:50:04Z","merge_commit_sha":"de3107ad380407d430f111857fc828921e2f2cb7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/44/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/statuses/982a0736b808cce2616ce5f28d283341fed4afca","head":{"label":"ministryofjustice:ag--normalise-app-repo-url","ref":"ag--normalise-app-repo-url","sha":"982a0736b808cce2616ce5f28d283341fed4afca","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":97129318,"name":"analytics-platform-control-panel","full_name":"ministryofjustice/analytics-platform-control-panel","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/analytics-platform-control-panel","description":"Control panel contains admin functions like creating users and granting access to apps","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/deployments","created_at":"2017-07-13T14:05:47Z","updated_at":"2017-10-15T07:15:28Z","pushed_at":"2017-10-20T13:51:05Z","git_url":"git://github.com/ministryofjustice/analytics-platform-control-panel.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-control-panel.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-control-panel.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-control-panel","homepage":null,"size":196,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"api"}},"base":{"label":"ministryofjustice:api","ref":"api","sha":"04f41a51971679b192e1237fe08045b1acb31959","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":97129318,"name":"analytics-platform-control-panel","full_name":"ministryofjustice/analytics-platform-control-panel","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/analytics-platform-control-panel","description":"Control panel contains admin functions like creating users and granting access to apps","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/deployments","created_at":"2017-07-13T14:05:47Z","updated_at":"2017-10-15T07:15:28Z","pushed_at":"2017-10-20T13:51:05Z","git_url":"git://github.com/ministryofjustice/analytics-platform-control-panel.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-control-panel.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-control-panel.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-control-panel","homepage":null,"size":196,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"api"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44"},"html":{"href":"https://github.com/ministryofjustice/analytics-platform-control-panel/pull/44"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/44"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-control-panel/statuses/982a0736b808cce2616ce5f28d283341fed4afca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andyhd"}}