{"action":"created","comment":{"url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/comments/118001713","pull_request_review_id":39753405,"id":118001713,"diff_hunk":"@@ -168,7 +168,7 @@ if (!PP) {\n                 $('#change_password_successful').show();\n                 $(\"#change_password_successful\").text(data.success);\n             },\n-            error: function (xhr, msg) {\n+            error: function (data, msg) {","path":"static/assets/js/phenopolis.js","position":14,"original_position":14,"commit_id":"1ee3633dbdc9d38e7c4766fb1a931965b9014572","original_commit_id":"1ee3633dbdc9d38e7c4766fb1a931965b9014572","user":{"login":"Withington","id":23736063,"avatar_url":"https://avatars3.githubusercontent.com/u/23736063?v=3","gravatar_id":"","url":"https://api.github.com/users/Withington","html_url":"https://github.com/Withington","followers_url":"https://api.github.com/users/Withington/followers","following_url":"https://api.github.com/users/Withington/following{/other_user}","gists_url":"https://api.github.com/users/Withington/gists{/gist_id}","starred_url":"https://api.github.com/users/Withington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Withington/subscriptions","organizations_url":"https://api.github.com/users/Withington/orgs","repos_url":"https://api.github.com/users/Withington/repos","events_url":"https://api.github.com/users/Withington/events{/privacy}","received_events_url":"https://api.github.com/users/Withington/received_events","type":"User","site_admin":false},"body":"I tried a few different things with xhr but couldn't get it to display messages such as \"You do not have permission to change the password for username 'demo'.\". What do you suggest?","created_at":"2017-05-23T14:08:37Z","updated_at":"2017-05-23T14:08:37Z","html_url":"https://github.com/phenopolis/phenopolis/pull/147#discussion_r118001713","pull_request_url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/comments/118001713"},"html":{"href":"https://github.com/phenopolis/phenopolis/pull/147#discussion_r118001713"},"pull_request":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147","id":121669293,"html_url":"https://github.com/phenopolis/phenopolis/pull/147","diff_url":"https://github.com/phenopolis/phenopolis/pull/147.diff","patch_url":"https://github.com/phenopolis/phenopolis/pull/147.patch","issue_url":"https://api.github.com/repos/phenopolis/phenopolis/issues/147","number":147,"state":"closed","locked":false,"title":"Jquery validation","user":{"login":"Withington","id":23736063,"avatar_url":"https://avatars3.githubusercontent.com/u/23736063?v=3","gravatar_id":"","url":"https://api.github.com/users/Withington","html_url":"https://github.com/Withington","followers_url":"https://api.github.com/users/Withington/followers","following_url":"https://api.github.com/users/Withington/following{/other_user}","gists_url":"https://api.github.com/users/Withington/gists{/gist_id}","starred_url":"https://api.github.com/users/Withington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Withington/subscriptions","organizations_url":"https://api.github.com/users/Withington/orgs","repos_url":"https://api.github.com/users/Withington/repos","events_url":"https://api.github.com/users/Withington/events{/privacy}","received_events_url":"https://api.github.com/users/Withington/received_events","type":"User","site_admin":false},"body":"Change password modal now passes username to change_password().\r\n\r\nI’ve tested and reviewed the code concerning login, change password and logout. The only problem I have found is that you can’t always navigate to “Change Password” and you can’t enter a url for it either (needed when we want to tell a user their new password and to go to www.url.com to change password). E.g. go to TTLL5 page, hit “Phenopolis”, go to user menu -> “Change Password” and you get nothing.","created_at":"2017-05-21T17:39:41Z","updated_at":"2017-05-23T14:08:37Z","closed_at":"2017-05-23T11:14:54Z","merged_at":"2017-05-23T11:14:54Z","merge_commit_sha":"28d4d69b8e8b28c47c71ffc98f95486fecfc22d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147/commits","review_comments_url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147/comments","review_comment_url":"https://api.github.com/repos/phenopolis/phenopolis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phenopolis/phenopolis/issues/147/comments","statuses_url":"https://api.github.com/repos/phenopolis/phenopolis/statuses/1ee3633dbdc9d38e7c4766fb1a931965b9014572","head":{"label":"Withington:jquery_validation","ref":"jquery_validation","sha":"1ee3633dbdc9d38e7c4766fb1a931965b9014572","user":{"login":"Withington","id":23736063,"avatar_url":"https://avatars3.githubusercontent.com/u/23736063?v=3","gravatar_id":"","url":"https://api.github.com/users/Withington","html_url":"https://github.com/Withington","followers_url":"https://api.github.com/users/Withington/followers","following_url":"https://api.github.com/users/Withington/following{/other_user}","gists_url":"https://api.github.com/users/Withington/gists{/gist_id}","starred_url":"https://api.github.com/users/Withington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Withington/subscriptions","organizations_url":"https://api.github.com/users/Withington/orgs","repos_url":"https://api.github.com/users/Withington/repos","events_url":"https://api.github.com/users/Withington/events{/privacy}","received_events_url":"https://api.github.com/users/Withington/received_events","type":"User","site_admin":false},"repo":{"id":78634013,"name":"phenopolis","full_name":"Withington/phenopolis","owner":{"login":"Withington","id":23736063,"avatar_url":"https://avatars3.githubusercontent.com/u/23736063?v=3","gravatar_id":"","url":"https://api.github.com/users/Withington","html_url":"https://github.com/Withington","followers_url":"https://api.github.com/users/Withington/followers","following_url":"https://api.github.com/users/Withington/following{/other_user}","gists_url":"https://api.github.com/users/Withington/gists{/gist_id}","starred_url":"https://api.github.com/users/Withington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Withington/subscriptions","organizations_url":"https://api.github.com/users/Withington/orgs","repos_url":"https://api.github.com/users/Withington/repos","events_url":"https://api.github.com/users/Withington/events{/privacy}","received_events_url":"https://api.github.com/users/Withington/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Withington/phenopolis","description":null,"fork":true,"url":"https://api.github.com/repos/Withington/phenopolis","forks_url":"https://api.github.com/repos/Withington/phenopolis/forks","keys_url":"https://api.github.com/repos/Withington/phenopolis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Withington/phenopolis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Withington/phenopolis/teams","hooks_url":"https://api.github.com/repos/Withington/phenopolis/hooks","issue_events_url":"https://api.github.com/repos/Withington/phenopolis/issues/events{/number}","events_url":"https://api.github.com/repos/Withington/phenopolis/events","assignees_url":"https://api.github.com/repos/Withington/phenopolis/assignees{/user}","branches_url":"https://api.github.com/repos/Withington/phenopolis/branches{/branch}","tags_url":"https://api.github.com/repos/Withington/phenopolis/tags","blobs_url":"https://api.github.com/repos/Withington/phenopolis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Withington/phenopolis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Withington/phenopolis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Withington/phenopolis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Withington/phenopolis/statuses/{sha}","languages_url":"https://api.github.com/repos/Withington/phenopolis/languages","stargazers_url":"https://api.github.com/repos/Withington/phenopolis/stargazers","contributors_url":"https://api.github.com/repos/Withington/phenopolis/contributors","subscribers_url":"https://api.github.com/repos/Withington/phenopolis/subscribers","subscription_url":"https://api.github.com/repos/Withington/phenopolis/subscription","commits_url":"https://api.github.com/repos/Withington/phenopolis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Withington/phenopolis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Withington/phenopolis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Withington/phenopolis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Withington/phenopolis/contents/{+path}","compare_url":"https://api.github.com/repos/Withington/phenopolis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Withington/phenopolis/merges","archive_url":"https://api.github.com/repos/Withington/phenopolis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Withington/phenopolis/downloads","issues_url":"https://api.github.com/repos/Withington/phenopolis/issues{/number}","pulls_url":"https://api.github.com/repos/Withington/phenopolis/pulls{/number}","milestones_url":"https://api.github.com/repos/Withington/phenopolis/milestones{/number}","notifications_url":"https://api.github.com/repos/Withington/phenopolis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Withington/phenopolis/labels{/name}","releases_url":"https://api.github.com/repos/Withington/phenopolis/releases{/id}","deployments_url":"https://api.github.com/repos/Withington/phenopolis/deployments","created_at":"2017-01-11T11:49:00Z","updated_at":"2017-01-11T11:49:03Z","pushed_at":"2017-05-21T17:30:40Z","git_url":"git://github.com/Withington/phenopolis.git","ssh_url":"git@github.com:Withington/phenopolis.git","clone_url":"https://github.com/Withington/phenopolis.git","svn_url":"https://github.com/Withington/phenopolis","homepage":"https://phenopolis.github.io","size":29229,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phenopolis:jquery_validation","ref":"jquery_validation","sha":"996e83e576a38d47f216651bb9632e5b3dfc6820","user":{"login":"phenopolis","id":20042742,"avatar_url":"https://avatars1.githubusercontent.com/u/20042742?v=3","gravatar_id":"","url":"https://api.github.com/users/phenopolis","html_url":"https://github.com/phenopolis","followers_url":"https://api.github.com/users/phenopolis/followers","following_url":"https://api.github.com/users/phenopolis/following{/other_user}","gists_url":"https://api.github.com/users/phenopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/phenopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenopolis/subscriptions","organizations_url":"https://api.github.com/users/phenopolis/orgs","repos_url":"https://api.github.com/users/phenopolis/repos","events_url":"https://api.github.com/users/phenopolis/events{/privacy}","received_events_url":"https://api.github.com/users/phenopolis/received_events","type":"Organization","site_admin":false},"repo":{"id":60914340,"name":"phenopolis","full_name":"phenopolis/phenopolis","owner":{"login":"phenopolis","id":20042742,"avatar_url":"https://avatars1.githubusercontent.com/u/20042742?v=3","gravatar_id":"","url":"https://api.github.com/users/phenopolis","html_url":"https://github.com/phenopolis","followers_url":"https://api.github.com/users/phenopolis/followers","following_url":"https://api.github.com/users/phenopolis/following{/other_user}","gists_url":"https://api.github.com/users/phenopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/phenopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenopolis/subscriptions","organizations_url":"https://api.github.com/users/phenopolis/orgs","repos_url":"https://api.github.com/users/phenopolis/repos","events_url":"https://api.github.com/users/phenopolis/events{/privacy}","received_events_url":"https://api.github.com/users/phenopolis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phenopolis/phenopolis","description":null,"fork":false,"url":"https://api.github.com/repos/phenopolis/phenopolis","forks_url":"https://api.github.com/repos/phenopolis/phenopolis/forks","keys_url":"https://api.github.com/repos/phenopolis/phenopolis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenopolis/phenopolis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenopolis/phenopolis/teams","hooks_url":"https://api.github.com/repos/phenopolis/phenopolis/hooks","issue_events_url":"https://api.github.com/repos/phenopolis/phenopolis/issues/events{/number}","events_url":"https://api.github.com/repos/phenopolis/phenopolis/events","assignees_url":"https://api.github.com/repos/phenopolis/phenopolis/assignees{/user}","branches_url":"https://api.github.com/repos/phenopolis/phenopolis/branches{/branch}","tags_url":"https://api.github.com/repos/phenopolis/phenopolis/tags","blobs_url":"https://api.github.com/repos/phenopolis/phenopolis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenopolis/phenopolis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenopolis/phenopolis/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenopolis/phenopolis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenopolis/phenopolis/statuses/{sha}","languages_url":"https://api.github.com/repos/phenopolis/phenopolis/languages","stargazers_url":"https://api.github.com/repos/phenopolis/phenopolis/stargazers","contributors_url":"https://api.github.com/repos/phenopolis/phenopolis/contributors","subscribers_url":"https://api.github.com/repos/phenopolis/phenopolis/subscribers","subscription_url":"https://api.github.com/repos/phenopolis/phenopolis/subscription","commits_url":"https://api.github.com/repos/phenopolis/phenopolis/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenopolis/phenopolis/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenopolis/phenopolis/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenopolis/phenopolis/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenopolis/phenopolis/contents/{+path}","compare_url":"https://api.github.com/repos/phenopolis/phenopolis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenopolis/phenopolis/merges","archive_url":"https://api.github.com/repos/phenopolis/phenopolis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenopolis/phenopolis/downloads","issues_url":"https://api.github.com/repos/phenopolis/phenopolis/issues{/number}","pulls_url":"https://api.github.com/repos/phenopolis/phenopolis/pulls{/number}","milestones_url":"https://api.github.com/repos/phenopolis/phenopolis/milestones{/number}","notifications_url":"https://api.github.com/repos/phenopolis/phenopolis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenopolis/phenopolis/labels{/name}","releases_url":"https://api.github.com/repos/phenopolis/phenopolis/releases{/id}","deployments_url":"https://api.github.com/repos/phenopolis/phenopolis/deployments","created_at":"2016-06-11T15:41:27Z","updated_at":"2017-03-24T21:34:26Z","pushed_at":"2017-05-23T13:16:59Z","git_url":"git://github.com/phenopolis/phenopolis.git","ssh_url":"git@github.com:phenopolis/phenopolis.git","clone_url":"https://github.com/phenopolis/phenopolis.git","svn_url":"https://github.com/phenopolis/phenopolis","homepage":"https://phenopolis.github.io","size":29329,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":43,"forks":2,"open_issues":43,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147"},"html":{"href":"https://github.com/phenopolis/phenopolis/pull/147"},"issue":{"href":"https://api.github.com/repos/phenopolis/phenopolis/issues/147"},"comments":{"href":"https://api.github.com/repos/phenopolis/phenopolis/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phenopolis/phenopolis/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/phenopolis/phenopolis/statuses/1ee3633dbdc9d38e7c4766fb1a931965b9014572"}}}}
{"actor":{"display_login":"Withington"}}