{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/44","repository_url":"https://api.github.com/repos/ros2/turtlebot2_demo","labels_url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/44/comments","events_url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/44/events","html_url":"https://github.com/ros2/turtlebot2_demo/pull/44","id":238218969,"number":44,"title":"Add amcl demo","user":{"login":"dhood","id":5618076,"avatar_url":"https://avatars3.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"labels":[{"id":582563113,"url":"https://api.github.com/repos/ros2/turtlebot2_demo/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"dhood","id":5618076,"avatar_url":"https://avatars3.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhood","id":5618076,"avatar_url":"https://avatars3.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2017-06-23T18:25:39Z","updated_at":"2017-06-29T21:04:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros2/turtlebot2_demo/pulls/44","html_url":"https://github.com/ros2/turtlebot2_demo/pull/44","diff_url":"https://github.com/ros2/turtlebot2_demo/pull/44.diff","patch_url":"https://github.com/ros2/turtlebot2_demo/pull/44.patch"},"body":"Requires ros2/turtlebot2_demo#38 and connected PRs\r\n\r\nThis adds a launch file to bring up the appropriate nodes for the ROS 2 AMCL demo on the turtlebot2.\r\n\r\nMain question that I am looking for help with (we don't seem to have many examples of using `launch`):\r\n\r\nHow can I pass arguments through to the launch file? I would like to pass the map path through, [so I added an argument parser](https://github.com/ros2/turtlebot2_demo/compare/add_amcl_demo?expand=1#diff-b43222f51127654b8934a03ba8b9a6d6R25). However, `launch` is catching the arguments before they can get through to the launchfile.\r\n```\r\nubuntu@pine64:~/tb2_demo_ws_dhood$ launch install_isolated/turtlebot2_localization/share/turtlebot2_localization/launch/turtlebot_amcl.py --map ~/maps/osrf_map.yaml\r\nusage: launch [-h] launch_file [launch_file ...]\r\nlaunch: error: unrecognized arguments: --map /home/ubuntu/maps/osrf_map.yaml\r\n```\r\n\r\nAt the moment I'm depending on turtlebot2_drivers and have copy-pasted the \"common\" turtlebot nodes in the launch file. These will be replaced by a call to launch the common nodes when the launch file exists (there's some refactoring planned from what I understand)."},"comment":{"url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/comments/312108258","html_url":"https://github.com/ros2/turtlebot2_demo/pull/44#issuecomment-312108258","issue_url":"https://api.github.com/repos/ros2/turtlebot2_demo/issues/44","id":312108258,"user":{"login":"mikaelarguedas","id":6644208,"avatar_url":"https://avatars2.githubusercontent.com/u/6644208?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelarguedas","html_url":"https://github.com/mikaelarguedas","followers_url":"https://api.github.com/users/mikaelarguedas/followers","following_url":"https://api.github.com/users/mikaelarguedas/following{/other_user}","gists_url":"https://api.github.com/users/mikaelarguedas/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelarguedas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelarguedas/subscriptions","organizations_url":"https://api.github.com/users/mikaelarguedas/orgs","repos_url":"https://api.github.com/users/mikaelarguedas/repos","events_url":"https://api.github.com/users/mikaelarguedas/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelarguedas/received_events","type":"User","site_admin":false},"created_at":"2017-06-29T21:04:39Z","updated_at":"2017-06-29T21:04:39Z","body":"I leave it to @dhood discretion to run CI or not on this before merging"}}
{"actor":{"display_login":"mikaelarguedas"}}