{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2235","repository_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2235/labels{/name}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2235/comments","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2235/events","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2235","id":249481402,"number":2235,"title":"[WIP] Introduce product rhel7-container","user":{"login":"yuumasato","id":7460169,"avatar_url":"https://avatars0.githubusercontent.com/u/7460169?v=4","gravatar_id":"","url":"https://api.github.com/users/yuumasato","html_url":"https://github.com/yuumasato","followers_url":"https://api.github.com/users/yuumasato/followers","following_url":"https://api.github.com/users/yuumasato/following{/other_user}","gists_url":"https://api.github.com/users/yuumasato/gists{/gist_id}","starred_url":"https://api.github.com/users/yuumasato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuumasato/subscriptions","organizations_url":"https://api.github.com/users/yuumasato/orgs","repos_url":"https://api.github.com/users/yuumasato/repos","events_url":"https://api.github.com/users/yuumasato/events{/privacy}","received_events_url":"https://api.github.com/users/yuumasato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-10T21:26:16Z","updated_at":"2017-08-10T21:26:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2235","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2235","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2235.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2235.patch"},"body":"This is a protoype of build system to generate a separate datastream for container variant of products.\r\n\r\nInstead of using CPEs to separate Rules that apply only to containers or machines, define a new product called rhel7-container. This will mean a separate source datastream for container and we will be able to just mark Rules applicable for containers with `prodtype=\"rhel7-container\"`.\r\n\r\nThis will avoid the problem of binding a Rule that can be applied for both machines and containers to only one of CPE.\r\nA scenario easy to grasp is Rule `service_sshd_enabled`.\r\nA Profile with such rule is okay to apply on VM or bare metal. Containers on the other hand don't need ssh, and it is also not recommended, but they can run it if really wanted.\r\nWe would like to, by default, not apply `service_sshd_enabled` to containers, but still allow users to tailor the Profile and add it.\r\nBy adding CPEs to Rules it is not possible. CPEs cannot be tailored.\r\n\r\nWtih a separate datastream and Profiles for containers user can tailor it and add rules to be applied to containers."},"comment":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments/321677975","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2235#issuecomment-321677975","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2235","id":321677975,"user":{"login":"pep8speaks","id":24736507,"avatar_url":"https://avatars1.githubusercontent.com/u/24736507?v=4","gravatar_id":"","url":"https://api.github.com/users/pep8speaks","html_url":"https://github.com/pep8speaks","followers_url":"https://api.github.com/users/pep8speaks/followers","following_url":"https://api.github.com/users/pep8speaks/following{/other_user}","gists_url":"https://api.github.com/users/pep8speaks/gists{/gist_id}","starred_url":"https://api.github.com/users/pep8speaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pep8speaks/subscriptions","organizations_url":"https://api.github.com/users/pep8speaks/orgs","repos_url":"https://api.github.com/users/pep8speaks/repos","events_url":"https://api.github.com/users/pep8speaks/events{/privacy}","received_events_url":"https://api.github.com/users/pep8speaks/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T21:26:18Z","updated_at":"2017-08-10T21:26:18Z","body":"Hello @yuumasato! Thanks for submitting the PR.\n\n - In the file [`shared/utils/cpe-generate.py`](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py), following are the PEP8 issues :\n\n> [Line 16:1](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L16): [E402](https://duckduckgo.com/?q=pep8%20E402) module level import not at top of file\n> [Line 78:14](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L78): [E211](https://duckduckgo.com/?q=pep8%20E211) whitespace before '('\n> [Line 168:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L168): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (81 > 79 characters)\n> [Line 170:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L170): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (84 > 79 characters)\n> [Line 180:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L180): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (86 > 79 characters)\n> [Line 182:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L182): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (88 > 79 characters)\n> [Line 184:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L184): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (81 > 79 characters)\n> [Line 187:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L187): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (81 > 79 characters)\n> [Line 197:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L197): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (88 > 79 characters)\n> [Line 216:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L216): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (86 > 79 characters)\n> [Line 218:80](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L218): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (80 > 79 characters)\n> [Line 222:1](https://github.com/OpenSCAP/scap-security-guide/blob/a2ad3a7856a413bab5d1bc4554e0bc768ca68ce4/shared/utils/cpe-generate.py#L222): [E305](https://duckduckgo.com/?q=pep8%20E305) expected 2 blank lines after class or function definition, found 1\n\n"}}
{"actor":{"display_login":"pep8speaks"}}