{"action":"created","issue":{"url":"https://api.github.com/repos/mirumee/django-payments/issues/149","repository_url":"https://api.github.com/repos/mirumee/django-payments","labels_url":"https://api.github.com/repos/mirumee/django-payments/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/mirumee/django-payments/issues/149/comments","events_url":"https://api.github.com/repos/mirumee/django-payments/issues/149/events","html_url":"https://github.com/mirumee/django-payments/pull/149","id":263575800,"number":149,"title":"Split logic from Model, split address into billing, shipping, use functions instead prefixed fields","user":{"login":"devkral","id":658768,"avatar_url":"https://avatars0.githubusercontent.com/u/658768?v=4","gravatar_id":"","url":"https://api.github.com/users/devkral","html_url":"https://github.com/devkral","followers_url":"https://api.github.com/users/devkral/followers","following_url":"https://api.github.com/users/devkral/following{/other_user}","gists_url":"https://api.github.com/users/devkral/gists{/gist_id}","starred_url":"https://api.github.com/users/devkral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devkral/subscriptions","organizations_url":"https://api.github.com/users/devkral/orgs","repos_url":"https://api.github.com/users/devkral/repos","events_url":"https://api.github.com/users/devkral/events{/privacy}","received_events_url":"https://api.github.com/users/devkral/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-06T21:24:11Z","updated_at":"2017-10-06T21:31:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mirumee/django-payments/pulls/149","html_url":"https://github.com/mirumee/django-payments/pull/149","diff_url":"https://github.com/mirumee/django-payments/pull/149.diff","patch_url":"https://github.com/mirumee/django-payments/pull/149.patch"},"body":"Instead of using prefixed address fields in Model, use functions to retrieve the data.\r\nThis way different data sources can be used and a fallback can be provided (BasePaymentWithAddress) in case only one address is available.\r\nBasePayment is split in Logic and Model. This allows better tests with less rendundancy.\r\nThe resulting testmock is in testcommon (test_common would be executed)"},"comment":{"url":"https://api.github.com/repos/mirumee/django-payments/issues/comments/334875190","html_url":"https://github.com/mirumee/django-payments/pull/149#issuecomment-334875190","issue_url":"https://api.github.com/repos/mirumee/django-payments/issues/149","id":334875190,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-10-06T21:31:35Z","updated_at":"2017-10-06T21:31:35Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=h1) Report\n> Merging [#149](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=desc) into [master](https://codecov.io/gh/mirumee/django-payments/commit/49c93aa8d0dc4bba74a14a048a8ad5a011297998?src=pr&el=desc) will **increase** coverage by `1.66%`.\n> The diff coverage is `89.14%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mirumee/django-payments/pull/149/graphs/tree.svg?height=150&width=650&src=pr&token=bKw83UHd7e)](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master    #149      +/-   ##\n=========================================\n+ Coverage   79.13%   80.8%   +1.66%     \n=========================================\n  Files          27      28       +1     \n  Lines        1649    1756     +107     \n  Branches      190     194       +4     \n=========================================\n+ Hits         1305    1419     +114     \n+ Misses        245     237       -8     \n- Partials       99     100       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [payments/sofort/\\_\\_init\\_\\_.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvc29mb3J0L19faW5pdF9fLnB5) | `87.71% <ø> (-1.17%)` | :arrow_down: |\n| [payments/braintree/forms.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvYnJhaW50cmVlL2Zvcm1zLnB5) | `93.1% <100%> (+0.51%)` | :arrow_up: |\n| [payments/cybersource/\\_\\_init\\_\\_.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvY3liZXJzb3VyY2UvX19pbml0X18ucHk=) | `66.56% <100%> (+0.1%)` | :arrow_up: |\n| [payments/stripe/forms.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvc3RyaXBlL2Zvcm1zLnB5) | `96.92% <100%> (+0.09%)` | :arrow_up: |\n| [payments/testcommon.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvdGVzdGNvbW1vbi5weQ==) | `100% <100%> (ø)` | |\n| [payments/authorizenet/\\_\\_init\\_\\_.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvYXV0aG9yaXplbmV0L19faW5pdF9fLnB5) | `79.54% <100%> (ø)` | :arrow_up: |\n| [payments/sagepay/\\_\\_init\\_\\_.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvc2FnZXBheS9fX2luaXRfXy5weQ==) | `90.76% <66.66%> (+2.05%)` | :arrow_up: |\n| [payments/models.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvbW9kZWxzLnB5) | `84% <72.34%> (+9.21%)` | :arrow_up: |\n| [payments/utils.py](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree#diff-cGF5bWVudHMvdXRpbHMucHk=) | `91.66% <90%> (-8.34%)` | :arrow_down: |\n| ... and [1 more](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=footer). Last update [49c93aa...0dc734e](https://codecov.io/gh/mirumee/django-payments/pull/149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}