{"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments/153043451","pull_request_review_id":79000572,"id":153043451,"diff_hunk":"@@ -64,4 +69,50 @@ describe('Event repos', () => {\n         .to.be.calledWith(token, `${config.apiRoot}/v3/event/123`)\n     })\n   })\n+\n+  describe('#getActiveEvents', () => {\n+    context('When there is a mix of active and inactive evets', () => {\n+      context('and no current event', () => {\n+        beforeEach(async () => {\n+          this.searchStub.resolves(eventCollection)\n+          this.events = await this.repos.getActiveEvents('1234')\n+        })\n+\n+        it('should call search to get the events', () => {\n+          expect(this.searchStub).to.be.calledWith({\n+            searchEntity: 'event',\n+            requestBody: { sortby: 'name:asc' },\n+            token: '1234',\n+            limit: 100000,\n+            isAggregation: false,\n+          })\n+        })\n+\n+        it('should return only the active events', () => {\n+          expect(this.events.length).to.eq(2)\n+        })\n+      })\n+\n+      context('and a current inactive event', () => {\n+        beforeEach(async () => {\n+          this.searchStub.resolves(eventCollection)\n+          this.events = await this.repos.getActiveEvents('1234', '4aa90860-ddb8-4cc0-8d5f-e0c26567abe4')\n+        })\n+\n+        it('should call search to get the events', () => {\n+          expect(this.searchStub).to.be.calledWith({\n+            searchEntity: 'event',\n+            requestBody: { sortby: 'name:asc' },\n+            token: '1234',\n+            limit: 100000,\n+            isAggregation: false,\n+          })\n+        })\n+\n+        it('should return active events and the current inactive one', () => {\n+          expect(this.events.length).to.eq(3)","path":"test/unit/apps/events/repos.test.js","position":64,"original_position":64,"commit_id":"c86bad0860ddd9735baa9c8cc8e6abb5ec82db45","original_commit_id":"c86bad0860ddd9735baa9c8cc8e6abb5ec82db45","user":{"login":"feedmypixel","id":2305016,"avatar_url":"https://avatars0.githubusercontent.com/u/2305016?v=4","gravatar_id":"","url":"https://api.github.com/users/feedmypixel","html_url":"https://github.com/feedmypixel","followers_url":"https://api.github.com/users/feedmypixel/followers","following_url":"https://api.github.com/users/feedmypixel/following{/other_user}","gists_url":"https://api.github.com/users/feedmypixel/gists{/gist_id}","starred_url":"https://api.github.com/users/feedmypixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedmypixel/subscriptions","organizations_url":"https://api.github.com/users/feedmypixel/orgs","repos_url":"https://api.github.com/users/feedmypixel/repos","events_url":"https://api.github.com/users/feedmypixel/events{/privacy}","received_events_url":"https://api.github.com/users/feedmypixel/received_events","type":"User","site_admin":false},"body":"same can we `deep.equal` here?","created_at":"2017-11-25T10:58:52Z","updated_at":"2017-11-25T10:58:53Z","html_url":"https://github.com/uktrade/data-hub-frontend/pull/1010#discussion_r153043451","pull_request_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments/153043451"},"html":{"href":"https://github.com/uktrade/data-hub-frontend/pull/1010#discussion_r153043451"},"pull_request":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010","id":154617245,"html_url":"https://github.com/uktrade/data-hub-frontend/pull/1010","diff_url":"https://github.com/uktrade/data-hub-frontend/pull/1010.diff","patch_url":"https://github.com/uktrade/data-hub-frontend/pull/1010.patch","issue_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1010","number":1010,"state":"open","locked":false,"title":"Filter inactive events in interaction creation","user":{"login":"ztolley","id":56056,"avatar_url":"https://avatars1.githubusercontent.com/u/56056?v=4","gravatar_id":"","url":"https://api.github.com/users/ztolley","html_url":"https://github.com/ztolley","followers_url":"https://api.github.com/users/ztolley/followers","following_url":"https://api.github.com/users/ztolley/following{/other_user}","gists_url":"https://api.github.com/users/ztolley/gists{/gist_id}","starred_url":"https://api.github.com/users/ztolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztolley/subscriptions","organizations_url":"https://api.github.com/users/ztolley/orgs","repos_url":"https://api.github.com/users/ztolley/repos","events_url":"https://api.github.com/users/ztolley/events{/privacy}","received_events_url":"https://api.github.com/users/ztolley/received_events","type":"User","site_admin":false},"body":"When creating an interaction there is a drop-down to select the event associated. In production this list is 40,000 records long, whilst there are only 2,000 active events. Users are reporting that the full list is not shown in the browser.\r\n\r\nStep 1 in making the users' life a bit easier is to filter the list of events in that dropdown so that it is only 2,000 active events instead of the full 40,000 are included.\r\n\r\nI moved the code that got that events into the events repo and use a previously created filter to filter out the disabled entries.\r\n\r\nLike a previous dropdown this also allows the dev to pass a current value in so if an existing record is associated with a disabled event, that is still on the options list.","created_at":"2017-11-25T00:18:51Z","updated_at":"2017-11-25T10:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8aab427eff3cf9558cdb5515f851b11765928b4","assignee":{"login":"ztolley","id":56056,"avatar_url":"https://avatars1.githubusercontent.com/u/56056?v=4","gravatar_id":"","url":"https://api.github.com/users/ztolley","html_url":"https://github.com/ztolley","followers_url":"https://api.github.com/users/ztolley/followers","following_url":"https://api.github.com/users/ztolley/following{/other_user}","gists_url":"https://api.github.com/users/ztolley/gists{/gist_id}","starred_url":"https://api.github.com/users/ztolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztolley/subscriptions","organizations_url":"https://api.github.com/users/ztolley/orgs","repos_url":"https://api.github.com/users/ztolley/repos","events_url":"https://api.github.com/users/ztolley/events{/privacy}","received_events_url":"https://api.github.com/users/ztolley/received_events","type":"User","site_admin":false},"assignees":[{"login":"ztolley","id":56056,"avatar_url":"https://avatars1.githubusercontent.com/u/56056?v=4","gravatar_id":"","url":"https://api.github.com/users/ztolley","html_url":"https://github.com/ztolley","followers_url":"https://api.github.com/users/ztolley/followers","following_url":"https://api.github.com/users/ztolley/following{/other_user}","gists_url":"https://api.github.com/users/ztolley/gists{/gist_id}","starred_url":"https://api.github.com/users/ztolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztolley/subscriptions","organizations_url":"https://api.github.com/users/ztolley/orgs","repos_url":"https://api.github.com/users/ztolley/repos","events_url":"https://api.github.com/users/ztolley/events{/privacy}","received_events_url":"https://api.github.com/users/ztolley/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jim68000","id":161962,"avatar_url":"https://avatars3.githubusercontent.com/u/161962?v=4","gravatar_id":"","url":"https://api.github.com/users/jim68000","html_url":"https://github.com/jim68000","followers_url":"https://api.github.com/users/jim68000/followers","following_url":"https://api.github.com/users/jim68000/following{/other_user}","gists_url":"https://api.github.com/users/jim68000/gists{/gist_id}","starred_url":"https://api.github.com/users/jim68000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim68000/subscriptions","organizations_url":"https://api.github.com/users/jim68000/orgs","repos_url":"https://api.github.com/users/jim68000/repos","events_url":"https://api.github.com/users/jim68000/events{/privacy}","received_events_url":"https://api.github.com/users/jim68000/received_events","type":"User","site_admin":false},{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1010/comments","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/c86bad0860ddd9735baa9c8cc8e6abb5ec82db45","head":{"label":"uktrade:filter_inactive_events","ref":"filter_inactive_events","sha":"c86bad0860ddd9735baa9c8cc8e6abb5ec82db45","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-08-16T08:31:47Z","pushed_at":"2017-11-25T10:42:55Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":3950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":1,"open_issues":29,"watchers":0,"default_branch":"develop"}},"base":{"label":"uktrade:develop","ref":"develop","sha":"04a355bac460f108c936c6b0fa2954005d7c1441","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-08-16T08:31:47Z","pushed_at":"2017-11-25T10:42:55Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":3950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":1,"open_issues":29,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010"},"html":{"href":"https://github.com/uktrade/data-hub-frontend/pull/1010"},"issue":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1010"},"comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/c86bad0860ddd9735baa9c8cc8e6abb5ec82db45"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"feedmypixel"}}