{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/114387734","pull_request_review_id":35849485,"id":114387734,"diff_hunk":"@@ -57,6 +57,10 @@ void set_default_settings(Settings *settings)\n \tsettings->setDefault(\"curl_verify_cert\", \"true\");\n \tsettings->setDefault(\"enable_remote_media_server\", \"true\");\n \tsettings->setDefault(\"enable_client_modding\", \"false\");\n+\tsettings->setDefault(\"enable_knockback\", \"true\");\n+\tsettings->setDefault(\"knockback_default_duration\", \"0.3\");","path":"src/defaultsettings.cpp","position":5,"original_position":5,"commit_id":"44e2adb52f47891617b8418767b179362652ed64","original_commit_id":"44e2adb52f47891617b8418767b179362652ed64","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars3.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"No need for duration, horizontal or vertical parameters, knockback strength should come from a subgame's definition of hand or weapon.","created_at":"2017-05-02T18:17:18Z","updated_at":"2017-05-02T18:17:18Z","html_url":"https://github.com/minetest/minetest/pull/5679#discussion_r114387734","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/5679","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/114387734"},"html":{"href":"https://github.com/minetest/minetest/pull/5679#discussion_r114387734"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5679"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/5679","id":118288811,"html_url":"https://github.com/minetest/minetest/pull/5679","diff_url":"https://github.com/minetest/minetest/pull/5679.diff","patch_url":"https://github.com/minetest/minetest/pull/5679.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/5679","number":5679,"state":"open","locked":false,"title":"Knockback","user":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars0.githubusercontent.com/u/3883583?v=3","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"body":"Video : \r\n\r\nhttps://www.youtube.com/watch?v=8t-hVu91IXI","created_at":"2017-04-29T20:21:15Z","updated_at":"2017-05-02T18:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3d0b2989830f733ab3960adedf093d6355c0162","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/5679/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/5679/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/5679/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/44e2adb52f47891617b8418767b179362652ed64","head":{"label":"Dumbeldor:knockback","ref":"knockback","sha":"44e2adb52f47891617b8418767b179362652ed64","user":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars0.githubusercontent.com/u/3883583?v=3","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"repo":{"id":80767214,"name":"minetest","full_name":"Dumbeldor/minetest","owner":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars0.githubusercontent.com/u/3883583?v=3","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dumbeldor/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/Dumbeldor/minetest","forks_url":"https://api.github.com/repos/Dumbeldor/minetest/forks","keys_url":"https://api.github.com/repos/Dumbeldor/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dumbeldor/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dumbeldor/minetest/teams","hooks_url":"https://api.github.com/repos/Dumbeldor/minetest/hooks","issue_events_url":"https://api.github.com/repos/Dumbeldor/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/Dumbeldor/minetest/events","assignees_url":"https://api.github.com/repos/Dumbeldor/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/Dumbeldor/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/Dumbeldor/minetest/tags","blobs_url":"https://api.github.com/repos/Dumbeldor/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dumbeldor/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dumbeldor/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dumbeldor/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dumbeldor/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/Dumbeldor/minetest/languages","stargazers_url":"https://api.github.com/repos/Dumbeldor/minetest/stargazers","contributors_url":"https://api.github.com/repos/Dumbeldor/minetest/contributors","subscribers_url":"https://api.github.com/repos/Dumbeldor/minetest/subscribers","subscription_url":"https://api.github.com/repos/Dumbeldor/minetest/subscription","commits_url":"https://api.github.com/repos/Dumbeldor/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dumbeldor/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dumbeldor/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dumbeldor/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dumbeldor/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/Dumbeldor/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dumbeldor/minetest/merges","archive_url":"https://api.github.com/repos/Dumbeldor/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dumbeldor/minetest/downloads","issues_url":"https://api.github.com/repos/Dumbeldor/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/Dumbeldor/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/Dumbeldor/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/Dumbeldor/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dumbeldor/minetest/labels{/name}","releases_url":"https://api.github.com/repos/Dumbeldor/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/Dumbeldor/minetest/deployments","created_at":"2017-02-02T20:47:08Z","updated_at":"2017-02-02T20:47:13Z","pushed_at":"2017-05-01T15:29:16Z","git_url":"git://github.com/Dumbeldor/minetest.git","ssh_url":"git@github.com:Dumbeldor/minetest.git","clone_url":"https://github.com/Dumbeldor/minetest.git","svn_url":"https://github.com/Dumbeldor/minetest","homepage":"http://minetest.net/","size":47143,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"f1d7a26b7c341b468f34325cec5c3d495f175a8f","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2017-05-02T13:10:08Z","pushed_at":"2017-05-02T18:12:21Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":47077,"stargazers_count":2528,"watchers_count":2528,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":770,"mirror_url":null,"open_issues_count":1014,"forks":770,"open_issues":1014,"watchers":2528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5679"},"html":{"href":"https://github.com/minetest/minetest/pull/5679"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/5679"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/5679/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5679/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5679/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/44e2adb52f47891617b8418767b179362652ed64"}}}}
{"actor":{"display_login":"paramat"}}