{"action":"created","issue":{"url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/1796","repository_url":"https://api.github.com/repos/adaptlearning/adapt_framework","labels_url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/1796/labels{/name}","comments_url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/1796/comments","events_url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/1796/events","html_url":"https://github.com/adaptlearning/adapt_framework/issues/1796","id":257392645,"number":1796,"title":"Remove trigger of 'assessment:complete' event's dependency on Assessment _postTotalScoreToLms config","user":{"login":"brian-learningpool","id":1327471,"avatar_url":"https://avatars0.githubusercontent.com/u/1327471?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-learningpool","html_url":"https://github.com/brian-learningpool","followers_url":"https://api.github.com/users/brian-learningpool/followers","following_url":"https://api.github.com/users/brian-learningpool/following{/other_user}","gists_url":"https://api.github.com/users/brian-learningpool/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-learningpool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-learningpool/subscriptions","organizations_url":"https://api.github.com/users/brian-learningpool/orgs","repos_url":"https://api.github.com/users/brian-learningpool/repos","events_url":"https://api.github.com/users/brian-learningpool/events{/privacy}","received_events_url":"https://api.github.com/users/brian-learningpool/received_events","type":"User","site_admin":false},"labels":[{"id":60102538,"url":"https://api.github.com/repos/adaptlearning/adapt_framework/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-13T14:02:23Z","updated_at":"2017-09-22T08:47:10Z","closed_at":null,"author_association":"OWNER","body":"I've noticed that the `assessment:complete`* event only gets fired if the assessment extension's `_postTotalScoreToLms` flag is set to `true`.  This creates quite a tight coupling between the Assessment and Spoor extensions.  (If anything, Spoor should have this config and only listen for this event if it's true.)  \r\n\r\nThe Assessment should raise this event regardless of any flag.\r\n\r\n(* The event name is bit of a misnomer, but is used to indicate when _all_ assessments have been completed.)"},"comment":{"url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/comments/331389166","html_url":"https://github.com/adaptlearning/adapt_framework/issues/1796#issuecomment-331389166","issue_url":"https://api.github.com/repos/adaptlearning/adapt_framework/issues/1796","id":331389166,"user":{"login":"brian-learningpool","id":1327471,"avatar_url":"https://avatars0.githubusercontent.com/u/1327471?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-learningpool","html_url":"https://github.com/brian-learningpool","followers_url":"https://api.github.com/users/brian-learningpool/followers","following_url":"https://api.github.com/users/brian-learningpool/following{/other_user}","gists_url":"https://api.github.com/users/brian-learningpool/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-learningpool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-learningpool/subscriptions","organizations_url":"https://api.github.com/users/brian-learningpool/orgs","repos_url":"https://api.github.com/users/brian-learningpool/repos","events_url":"https://api.github.com/users/brian-learningpool/events{/privacy}","received_events_url":"https://api.github.com/users/brian-learningpool/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T08:47:10Z","updated_at":"2017-09-22T08:47:10Z","author_association":"OWNER","body":"I think we should definitely rename it.  The `assessment:complete`/`assessments:complete` thing has bugged me for some time.\r\n\r\nI'm ok with `assessment:attemptcomplete` (or `assessment:finish`)."}}
{"actor":{"display_login":"brian-learningpool"}}