{"action":"created","comment":{"url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/comments/116004510","pull_request_review_id":37592178,"id":116004510,"diff_hunk":"@@ -24,6 +24,9 @@\n           display: inline-block;\n         }\n       }\n+      span.api-key--container p {\n+        padding-right: 25px;","path":"src/wwwroot/styles/views/_settings.scss","position":null,"original_position":5,"commit_id":"35d60b0258ced1309e152f5e7bfc137b545ec1ce","original_commit_id":"db5b86f36d425ab02dc1899dad0dd947a264426d","user":{"login":"martinkeimel","id":10030005,"avatar_url":"https://avatars1.githubusercontent.com/u/10030005?v=3","gravatar_id":"","url":"https://api.github.com/users/martinkeimel","html_url":"https://github.com/martinkeimel","followers_url":"https://api.github.com/users/martinkeimel/followers","following_url":"https://api.github.com/users/martinkeimel/following{/other_user}","gists_url":"https://api.github.com/users/martinkeimel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinkeimel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinkeimel/subscriptions","organizations_url":"https://api.github.com/users/martinkeimel/orgs","repos_url":"https://api.github.com/users/martinkeimel/repos","events_url":"https://api.github.com/users/martinkeimel/events{/privacy}","received_events_url":"https://api.github.com/users/martinkeimel/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2017-05-11T14:27:57Z","updated_at":"2017-05-11T14:27:57Z","html_url":"https://github.com/DopplerRelay/relay-webapp/pull/50#discussion_r116004510","pull_request_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/comments/116004510"},"html":{"href":"https://github.com/DopplerRelay/relay-webapp/pull/50#discussion_r116004510"},"pull_request":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50","id":120115576,"html_url":"https://github.com/DopplerRelay/relay-webapp/pull/50","diff_url":"https://github.com/DopplerRelay/relay-webapp/pull/50.diff","patch_url":"https://github.com/DopplerRelay/relay-webapp/pull/50.patch","issue_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/50","number":50,"state":"open","locked":false,"title":"DR-1067 Improve copy to clipboard","user":{"login":"martinkeimel","id":10030005,"avatar_url":"https://avatars1.githubusercontent.com/u/10030005?v=3","gravatar_id":"","url":"https://api.github.com/users/martinkeimel","html_url":"https://github.com/martinkeimel","followers_url":"https://api.github.com/users/martinkeimel/followers","following_url":"https://api.github.com/users/martinkeimel/following{/other_user}","gists_url":"https://api.github.com/users/martinkeimel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinkeimel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinkeimel/subscriptions","organizations_url":"https://api.github.com/users/martinkeimel/orgs","repos_url":"https://api.github.com/users/martinkeimel/repos","events_url":"https://api.github.com/users/martinkeimel/events{/privacy}","received_events_url":"https://api.github.com/users/martinkeimel/received_events","type":"User","site_admin":false},"body":"# Background\r\nFor the latests browsers there's no need to show a popup in order to copy a text to the clipboard so we are now using clipboardjs library in order to acomplish that. We'll still keep the popup as a fallback for older browsers\r\n\r\n# Changes done\r\n- Add clipboardjs library\r\n- Create directive to handle all the copy related stuff. It's in charge of checking if the browser suppports direct copy and decide if the popup needs to be shown or not\r\n- Applied some styling improvements suggested by Mariana\r\n\r\n# Pending to be done\r\nI'm working on fixing the e2e tests but I created this PR so you can start taking a look at the changes","created_at":"2017-05-11T14:07:25Z","updated_at":"2017-05-11T14:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd75f5fecccb982a3666e22216f2d5b7cc6e4a7d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50/commits","review_comments_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50/comments","review_comment_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/50/comments","statuses_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/statuses/35d60b0258ced1309e152f5e7bfc137b545ec1ce","head":{"label":"martinkeimel:DR-1067-improve-copy-to-clipboard","ref":"DR-1067-improve-copy-to-clipboard","sha":"35d60b0258ced1309e152f5e7bfc137b545ec1ce","user":{"login":"martinkeimel","id":10030005,"avatar_url":"https://avatars1.githubusercontent.com/u/10030005?v=3","gravatar_id":"","url":"https://api.github.com/users/martinkeimel","html_url":"https://github.com/martinkeimel","followers_url":"https://api.github.com/users/martinkeimel/followers","following_url":"https://api.github.com/users/martinkeimel/following{/other_user}","gists_url":"https://api.github.com/users/martinkeimel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinkeimel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinkeimel/subscriptions","organizations_url":"https://api.github.com/users/martinkeimel/orgs","repos_url":"https://api.github.com/users/martinkeimel/repos","events_url":"https://api.github.com/users/martinkeimel/events{/privacy}","received_events_url":"https://api.github.com/users/martinkeimel/received_events","type":"User","site_admin":false},"repo":{"id":90666458,"name":"relay-webapp","full_name":"martinkeimel/relay-webapp","owner":{"login":"martinkeimel","id":10030005,"avatar_url":"https://avatars1.githubusercontent.com/u/10030005?v=3","gravatar_id":"","url":"https://api.github.com/users/martinkeimel","html_url":"https://github.com/martinkeimel","followers_url":"https://api.github.com/users/martinkeimel/followers","following_url":"https://api.github.com/users/martinkeimel/following{/other_user}","gists_url":"https://api.github.com/users/martinkeimel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinkeimel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinkeimel/subscriptions","organizations_url":"https://api.github.com/users/martinkeimel/orgs","repos_url":"https://api.github.com/users/martinkeimel/repos","events_url":"https://api.github.com/users/martinkeimel/events{/privacy}","received_events_url":"https://api.github.com/users/martinkeimel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinkeimel/relay-webapp","description":"Relay Web Application","fork":true,"url":"https://api.github.com/repos/martinkeimel/relay-webapp","forks_url":"https://api.github.com/repos/martinkeimel/relay-webapp/forks","keys_url":"https://api.github.com/repos/martinkeimel/relay-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinkeimel/relay-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinkeimel/relay-webapp/teams","hooks_url":"https://api.github.com/repos/martinkeimel/relay-webapp/hooks","issue_events_url":"https://api.github.com/repos/martinkeimel/relay-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/martinkeimel/relay-webapp/events","assignees_url":"https://api.github.com/repos/martinkeimel/relay-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/martinkeimel/relay-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/martinkeimel/relay-webapp/tags","blobs_url":"https://api.github.com/repos/martinkeimel/relay-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinkeimel/relay-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinkeimel/relay-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinkeimel/relay-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinkeimel/relay-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/martinkeimel/relay-webapp/languages","stargazers_url":"https://api.github.com/repos/martinkeimel/relay-webapp/stargazers","contributors_url":"https://api.github.com/repos/martinkeimel/relay-webapp/contributors","subscribers_url":"https://api.github.com/repos/martinkeimel/relay-webapp/subscribers","subscription_url":"https://api.github.com/repos/martinkeimel/relay-webapp/subscription","commits_url":"https://api.github.com/repos/martinkeimel/relay-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinkeimel/relay-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinkeimel/relay-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinkeimel/relay-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinkeimel/relay-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/martinkeimel/relay-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinkeimel/relay-webapp/merges","archive_url":"https://api.github.com/repos/martinkeimel/relay-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinkeimel/relay-webapp/downloads","issues_url":"https://api.github.com/repos/martinkeimel/relay-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/martinkeimel/relay-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/martinkeimel/relay-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/martinkeimel/relay-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinkeimel/relay-webapp/labels{/name}","releases_url":"https://api.github.com/repos/martinkeimel/relay-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/martinkeimel/relay-webapp/deployments","created_at":"2017-05-08T19:47:47Z","updated_at":"2017-05-08T19:47:49Z","pushed_at":"2017-05-11T14:27:34Z","git_url":"git://github.com/martinkeimel/relay-webapp.git","ssh_url":"git@github.com:martinkeimel/relay-webapp.git","clone_url":"https://github.com/martinkeimel/relay-webapp.git","svn_url":"https://github.com/martinkeimel/relay-webapp","homepage":null,"size":452,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"DopplerRelay:develop","ref":"develop","sha":"e100bb96fb5f126ffcc03bb3f73f9731781a9e13","user":{"login":"DopplerRelay","id":21225122,"avatar_url":"https://avatars0.githubusercontent.com/u/21225122?v=3","gravatar_id":"","url":"https://api.github.com/users/DopplerRelay","html_url":"https://github.com/DopplerRelay","followers_url":"https://api.github.com/users/DopplerRelay/followers","following_url":"https://api.github.com/users/DopplerRelay/following{/other_user}","gists_url":"https://api.github.com/users/DopplerRelay/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerRelay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerRelay/subscriptions","organizations_url":"https://api.github.com/users/DopplerRelay/orgs","repos_url":"https://api.github.com/users/DopplerRelay/repos","events_url":"https://api.github.com/users/DopplerRelay/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerRelay/received_events","type":"Organization","site_admin":false},"repo":{"id":82585475,"name":"relay-webapp","full_name":"DopplerRelay/relay-webapp","owner":{"login":"DopplerRelay","id":21225122,"avatar_url":"https://avatars0.githubusercontent.com/u/21225122?v=3","gravatar_id":"","url":"https://api.github.com/users/DopplerRelay","html_url":"https://github.com/DopplerRelay","followers_url":"https://api.github.com/users/DopplerRelay/followers","following_url":"https://api.github.com/users/DopplerRelay/following{/other_user}","gists_url":"https://api.github.com/users/DopplerRelay/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerRelay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerRelay/subscriptions","organizations_url":"https://api.github.com/users/DopplerRelay/orgs","repos_url":"https://api.github.com/users/DopplerRelay/repos","events_url":"https://api.github.com/users/DopplerRelay/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerRelay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DopplerRelay/relay-webapp","description":"Relay Web Application","fork":false,"url":"https://api.github.com/repos/DopplerRelay/relay-webapp","forks_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/forks","keys_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/teams","hooks_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/hooks","issue_events_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/events","assignees_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/tags","blobs_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/languages","stargazers_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/stargazers","contributors_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/contributors","subscribers_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/subscribers","subscription_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/subscription","commits_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/merges","archive_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/downloads","issues_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/labels{/name}","releases_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/DopplerRelay/relay-webapp/deployments","created_at":"2017-02-20T17:43:55Z","updated_at":"2017-02-22T20:55:09Z","pushed_at":"2017-05-11T14:27:36Z","git_url":"git://github.com/DopplerRelay/relay-webapp.git","ssh_url":"git@github.com:DopplerRelay/relay-webapp.git","clone_url":"https://github.com/DopplerRelay/relay-webapp.git","svn_url":"https://github.com/DopplerRelay/relay-webapp","homepage":null,"size":422,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50"},"html":{"href":"https://github.com/DopplerRelay/relay-webapp/pull/50"},"issue":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/50"},"comments":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/DopplerRelay/relay-webapp/statuses/35d60b0258ced1309e152f5e7bfc137b545ec1ce"}}}}
{"actor":{"display_login":"martinkeimel"}}