{"action":"created","issue":{"url":"https://api.github.com/repos/schwehr/libais/issues/163","repository_url":"https://api.github.com/repos/schwehr/libais","labels_url":"https://api.github.com/repos/schwehr/libais/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/schwehr/libais/issues/163/comments","events_url":"https://api.github.com/repos/schwehr/libais/issues/163/events","html_url":"https://github.com/schwehr/libais/pull/163","id":271532884,"number":163,"title":"spare bits in Ais6_1_5","user":{"login":"cchayden","id":84126,"avatar_url":"https://avatars3.githubusercontent.com/u/84126?v=4","gravatar_id":"","url":"https://api.github.com/users/cchayden","html_url":"https://github.com/cchayden","followers_url":"https://api.github.com/users/cchayden/followers","following_url":"https://api.github.com/users/cchayden/following{/other_user}","gists_url":"https://api.github.com/users/cchayden/gists{/gist_id}","starred_url":"https://api.github.com/users/cchayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchayden/subscriptions","organizations_url":"https://api.github.com/users/cchayden/orgs","repos_url":"https://api.github.com/users/cchayden/repos","events_url":"https://api.github.com/users/cchayden/events{/privacy}","received_events_url":"https://api.github.com/users/cchayden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-06T16:18:59Z","updated_at":"2017-11-08T18:28:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/schwehr/libais/pulls/163","html_url":"https://github.com/schwehr/libais/pull/163","diff_url":"https://github.com/schwehr/libais/pull/163.diff","patch_url":"https://github.com/schwehr/libais/pull/163.patch"},"body":"The bitset ToUnsignedInt can handle up to 32 bits at a time: its second argument cannot be larger than 32.\r\nIn processing ais6.cpp, in Ais6_1_5 ToUnsignedInt is called with a length argument greater than 32, causing a core dump.\r\n\r\nThis change breaks the reading of the spare bits into two chunks, so as not to exceed 32 bits."},"comment":{"url":"https://api.github.com/repos/schwehr/libais/issues/comments/342912632","html_url":"https://github.com/schwehr/libais/pull/163#issuecomment-342912632","issue_url":"https://api.github.com/repos/schwehr/libais/issues/163","id":342912632,"user":{"login":"jamtho","id":1054594,"avatar_url":"https://avatars1.githubusercontent.com/u/1054594?v=4","gravatar_id":"","url":"https://api.github.com/users/jamtho","html_url":"https://github.com/jamtho","followers_url":"https://api.github.com/users/jamtho/followers","following_url":"https://api.github.com/users/jamtho/following{/other_user}","gists_url":"https://api.github.com/users/jamtho/gists{/gist_id}","starred_url":"https://api.github.com/users/jamtho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamtho/subscriptions","organizations_url":"https://api.github.com/users/jamtho/orgs","repos_url":"https://api.github.com/users/jamtho/repos","events_url":"https://api.github.com/users/jamtho/events{/privacy}","received_events_url":"https://api.github.com/users/jamtho/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T18:28:52Z","updated_at":"2017-11-08T18:28:52Z","author_association":"NONE","body":"The alternative being to preserve the ABI and discard the last 17 bits, since they're officially unused, documenting the behaviour. \r\n\r\nI prefer your solution as it seems obviously the Right Thing, and I always link libais statically in deployments, so it wouldn't cause a problem in practice to me at least. Not sure about other people though."}}
{"actor":{"display_login":"jamtho"}}