{"action":"created","comment":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments/127402784","pull_request_review_id":49983589,"id":127402784,"diff_hunk":"@@ -314,6 +292,68 @@ std::istream& operator>>(std::istream& in, AABB<VEC_T>& bb)\n \treturn in;\n }\n \n+/// \\brief Test if a ray intersectes an axis-aligned box\n+/// \\tparam VEC3 the domain of the box. Has to be of dimension 3\n+template <typename VEC3, typename std::enable_if<(nb_components_traits<VEC3>::value == 3)>::type* = nullptr>\n+inline bool ray_intersect(const AABB<VEC3>& aabb, const VEC3& P, const VEC3& V)","path":"cgogn/geometry/types/aabb.h","position":78,"original_position":78,"commit_id":"04699bea898d41221d9ddd89cd2b4a19805bedf8","original_commit_id":"04699bea898d41221d9ddd89cd2b4a19805bedf8","user":{"login":"untereiner","id":6287846,"avatar_url":"https://avatars5.githubusercontent.com/u/6287846?v=4","gravatar_id":"","url":"https://api.github.com/users/untereiner","html_url":"https://github.com/untereiner","followers_url":"https://api.github.com/users/untereiner/followers","following_url":"https://api.github.com/users/untereiner/following{/other_user}","gists_url":"https://api.github.com/users/untereiner/gists{/gist_id}","starred_url":"https://api.github.com/users/untereiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untereiner/subscriptions","organizations_url":"https://api.github.com/users/untereiner/orgs","repos_url":"https://api.github.com/users/untereiner/repos","events_url":"https://api.github.com/users/untereiner/events{/privacy}","received_events_url":"https://api.github.com/users/untereiner/received_events","type":"User","site_admin":false},"body":"je ne vois pas pourquoi la garder dans la classe sachant qu'elle est spécifique à une dimension, à l'inverse du reste de la classe.","created_at":"2017-07-14T07:45:36Z","updated_at":"2017-07-14T07:45:36Z","html_url":"https://github.com/cgogn/CGoGN_2/pull/310#discussion_r127402784","pull_request_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments/127402784"},"html":{"href":"https://github.com/cgogn/CGoGN_2/pull/310#discussion_r127402784"},"pull_request":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310","id":130468443,"html_url":"https://github.com/cgogn/CGoGN_2/pull/310","diff_url":"https://github.com/cgogn/CGoGN_2/pull/310.diff","patch_url":"https://github.com/cgogn/CGoGN_2/pull/310.patch","issue_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/310","number":310,"state":"open","locked":false,"title":"New functions","user":{"login":"untereiner","id":6287846,"avatar_url":"https://avatars5.githubusercontent.com/u/6287846?v=4","gravatar_id":"","url":"https://api.github.com/users/untereiner","html_url":"https://github.com/untereiner","followers_url":"https://api.github.com/users/untereiner/followers","following_url":"https://api.github.com/users/untereiner/following{/other_user}","gists_url":"https://api.github.com/users/untereiner/gists{/gist_id}","starred_url":"https://api.github.com/users/untereiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untereiner/subscriptions","organizations_url":"https://api.github.com/users/untereiner/orgs","repos_url":"https://api.github.com/users/untereiner/repos","events_url":"https://api.github.com/users/untereiner/events{/privacy}","received_events_url":"https://api.github.com/users/untereiner/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-13T21:10:32Z","updated_at":"2017-07-14T07:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24f2ae0ff0d5fedca5dc9ebac8de1c0edc0e1b51","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310/commits","review_comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310/comments","review_comment_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/310/comments","statuses_url":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/04699bea898d41221d9ddd89cd2b4a19805bedf8","head":{"label":"untereiner:new_functions","ref":"new_functions","sha":"04699bea898d41221d9ddd89cd2b4a19805bedf8","user":{"login":"untereiner","id":6287846,"avatar_url":"https://avatars5.githubusercontent.com/u/6287846?v=4","gravatar_id":"","url":"https://api.github.com/users/untereiner","html_url":"https://github.com/untereiner","followers_url":"https://api.github.com/users/untereiner/followers","following_url":"https://api.github.com/users/untereiner/following{/other_user}","gists_url":"https://api.github.com/users/untereiner/gists{/gist_id}","starred_url":"https://api.github.com/users/untereiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untereiner/subscriptions","organizations_url":"https://api.github.com/users/untereiner/orgs","repos_url":"https://api.github.com/users/untereiner/repos","events_url":"https://api.github.com/users/untereiner/events{/privacy}","received_events_url":"https://api.github.com/users/untereiner/received_events","type":"User","site_admin":false},"repo":{"id":43888856,"name":"CGoGN_2","full_name":"untereiner/CGoGN_2","owner":{"login":"untereiner","id":6287846,"avatar_url":"https://avatars5.githubusercontent.com/u/6287846?v=4","gravatar_id":"","url":"https://api.github.com/users/untereiner","html_url":"https://github.com/untereiner","followers_url":"https://api.github.com/users/untereiner/followers","following_url":"https://api.github.com/users/untereiner/following{/other_user}","gists_url":"https://api.github.com/users/untereiner/gists{/gist_id}","starred_url":"https://api.github.com/users/untereiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untereiner/subscriptions","organizations_url":"https://api.github.com/users/untereiner/orgs","repos_url":"https://api.github.com/users/untereiner/repos","events_url":"https://api.github.com/users/untereiner/events{/privacy}","received_events_url":"https://api.github.com/users/untereiner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/untereiner/CGoGN_2","description":null,"fork":true,"url":"https://api.github.com/repos/untereiner/CGoGN_2","forks_url":"https://api.github.com/repos/untereiner/CGoGN_2/forks","keys_url":"https://api.github.com/repos/untereiner/CGoGN_2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untereiner/CGoGN_2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untereiner/CGoGN_2/teams","hooks_url":"https://api.github.com/repos/untereiner/CGoGN_2/hooks","issue_events_url":"https://api.github.com/repos/untereiner/CGoGN_2/issues/events{/number}","events_url":"https://api.github.com/repos/untereiner/CGoGN_2/events","assignees_url":"https://api.github.com/repos/untereiner/CGoGN_2/assignees{/user}","branches_url":"https://api.github.com/repos/untereiner/CGoGN_2/branches{/branch}","tags_url":"https://api.github.com/repos/untereiner/CGoGN_2/tags","blobs_url":"https://api.github.com/repos/untereiner/CGoGN_2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untereiner/CGoGN_2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untereiner/CGoGN_2/git/refs{/sha}","trees_url":"https://api.github.com/repos/untereiner/CGoGN_2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untereiner/CGoGN_2/statuses/{sha}","languages_url":"https://api.github.com/repos/untereiner/CGoGN_2/languages","stargazers_url":"https://api.github.com/repos/untereiner/CGoGN_2/stargazers","contributors_url":"https://api.github.com/repos/untereiner/CGoGN_2/contributors","subscribers_url":"https://api.github.com/repos/untereiner/CGoGN_2/subscribers","subscription_url":"https://api.github.com/repos/untereiner/CGoGN_2/subscription","commits_url":"https://api.github.com/repos/untereiner/CGoGN_2/commits{/sha}","git_commits_url":"https://api.github.com/repos/untereiner/CGoGN_2/git/commits{/sha}","comments_url":"https://api.github.com/repos/untereiner/CGoGN_2/comments{/number}","issue_comment_url":"https://api.github.com/repos/untereiner/CGoGN_2/issues/comments{/number}","contents_url":"https://api.github.com/repos/untereiner/CGoGN_2/contents/{+path}","compare_url":"https://api.github.com/repos/untereiner/CGoGN_2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untereiner/CGoGN_2/merges","archive_url":"https://api.github.com/repos/untereiner/CGoGN_2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untereiner/CGoGN_2/downloads","issues_url":"https://api.github.com/repos/untereiner/CGoGN_2/issues{/number}","pulls_url":"https://api.github.com/repos/untereiner/CGoGN_2/pulls{/number}","milestones_url":"https://api.github.com/repos/untereiner/CGoGN_2/milestones{/number}","notifications_url":"https://api.github.com/repos/untereiner/CGoGN_2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untereiner/CGoGN_2/labels{/name}","releases_url":"https://api.github.com/repos/untereiner/CGoGN_2/releases{/id}","deployments_url":"https://api.github.com/repos/untereiner/CGoGN_2/deployments","created_at":"2015-10-08T13:06:36Z","updated_at":"2016-02-10T16:06:50Z","pushed_at":"2017-07-13T21:34:33Z","git_url":"git://github.com/untereiner/CGoGN_2.git","ssh_url":"git@github.com:untereiner/CGoGN_2.git","clone_url":"https://github.com/untereiner/CGoGN_2.git","svn_url":"https://github.com/untereiner/CGoGN_2","homepage":null,"size":25607,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cgogn:develop","ref":"develop","sha":"7243a1057ebaa7701af9e2a131b920a72e90202d","user":{"login":"cgogn","id":1519802,"avatar_url":"https://avatars7.githubusercontent.com/u/1519802?v=3","gravatar_id":"","url":"https://api.github.com/users/cgogn","html_url":"https://github.com/cgogn","followers_url":"https://api.github.com/users/cgogn/followers","following_url":"https://api.github.com/users/cgogn/following{/other_user}","gists_url":"https://api.github.com/users/cgogn/gists{/gist_id}","starred_url":"https://api.github.com/users/cgogn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgogn/subscriptions","organizations_url":"https://api.github.com/users/cgogn/orgs","repos_url":"https://api.github.com/users/cgogn/repos","events_url":"https://api.github.com/users/cgogn/events{/privacy}","received_events_url":"https://api.github.com/users/cgogn/received_events","type":"Organization","site_admin":false},"repo":{"id":43506722,"name":"CGoGN_2","full_name":"cgogn/CGoGN_2","owner":{"login":"cgogn","id":1519802,"avatar_url":"https://avatars7.githubusercontent.com/u/1519802?v=3","gravatar_id":"","url":"https://api.github.com/users/cgogn","html_url":"https://github.com/cgogn","followers_url":"https://api.github.com/users/cgogn/followers","following_url":"https://api.github.com/users/cgogn/following{/other_user}","gists_url":"https://api.github.com/users/cgogn/gists{/gist_id}","starred_url":"https://api.github.com/users/cgogn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgogn/subscriptions","organizations_url":"https://api.github.com/users/cgogn/orgs","repos_url":"https://api.github.com/users/cgogn/repos","events_url":"https://api.github.com/users/cgogn/events{/privacy}","received_events_url":"https://api.github.com/users/cgogn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cgogn/CGoGN_2","description":"n-dimensional Meshes with Combinatorial Maps","fork":false,"url":"https://api.github.com/repos/cgogn/CGoGN_2","forks_url":"https://api.github.com/repos/cgogn/CGoGN_2/forks","keys_url":"https://api.github.com/repos/cgogn/CGoGN_2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgogn/CGoGN_2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgogn/CGoGN_2/teams","hooks_url":"https://api.github.com/repos/cgogn/CGoGN_2/hooks","issue_events_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/events{/number}","events_url":"https://api.github.com/repos/cgogn/CGoGN_2/events","assignees_url":"https://api.github.com/repos/cgogn/CGoGN_2/assignees{/user}","branches_url":"https://api.github.com/repos/cgogn/CGoGN_2/branches{/branch}","tags_url":"https://api.github.com/repos/cgogn/CGoGN_2/tags","blobs_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/{sha}","languages_url":"https://api.github.com/repos/cgogn/CGoGN_2/languages","stargazers_url":"https://api.github.com/repos/cgogn/CGoGN_2/stargazers","contributors_url":"https://api.github.com/repos/cgogn/CGoGN_2/contributors","subscribers_url":"https://api.github.com/repos/cgogn/CGoGN_2/subscribers","subscription_url":"https://api.github.com/repos/cgogn/CGoGN_2/subscription","commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgogn/CGoGN_2/contents/{+path}","compare_url":"https://api.github.com/repos/cgogn/CGoGN_2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgogn/CGoGN_2/merges","archive_url":"https://api.github.com/repos/cgogn/CGoGN_2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgogn/CGoGN_2/downloads","issues_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues{/number}","pulls_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls{/number}","milestones_url":"https://api.github.com/repos/cgogn/CGoGN_2/milestones{/number}","notifications_url":"https://api.github.com/repos/cgogn/CGoGN_2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgogn/CGoGN_2/labels{/name}","releases_url":"https://api.github.com/repos/cgogn/CGoGN_2/releases{/id}","deployments_url":"https://api.github.com/repos/cgogn/CGoGN_2/deployments","created_at":"2015-10-01T16:11:58Z","updated_at":"2017-06-27T12:00:22Z","pushed_at":"2017-07-13T21:34:34Z","git_url":"git://github.com/cgogn/CGoGN_2.git","ssh_url":"git@github.com:cgogn/CGoGN_2.git","clone_url":"https://github.com/cgogn/CGoGN_2.git","svn_url":"https://github.com/cgogn/CGoGN_2","homepage":"","size":25573,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310"},"html":{"href":"https://github.com/cgogn/CGoGN_2/pull/310"},"issue":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/issues/310"},"comments":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/04699bea898d41221d9ddd89cd2b4a19805bedf8"}}}}
{"actor":{"display_login":"untereiner"}}