{"action":"created","issue":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/479","repository_url":"https://api.github.com/repos/gramps-project/gramps","labels_url":"https://api.github.com/repos/gramps-project/gramps/issues/479/labels{/name}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/479/comments","events_url":"https://api.github.com/repos/gramps-project/gramps/issues/479/events","html_url":"https://github.com/gramps-project/gramps/pull/479","id":265416591,"number":479,"title":"Dbapi: Fix for broken 'backlinks' after a delete.","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars2.githubusercontent.com/u/18122203?v=4","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"labels":[{"id":163706671,"url":"https://api.github.com/repos/gramps-project/gramps/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-13T20:56:08Z","updated_at":"2017-10-13T21:09:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/479","html_url":"https://github.com/gramps-project/gramps/pull/479","diff_url":"https://github.com/gramps-project/gramps/pull/479.diff","patch_url":"https://github.com/gramps-project/gramps/pull/479.patch"},"body":"Fixes #10221\r\n\r\nThe dbapi was missing a way to update the references table (backlinks) when object are deleted.  Actually the forward references by the deleted object were not removed, but the issue showed up as bad backlinks.\r\n\r\nThis PR deals with that specific issue.   I looked into refactoring the entire 'delete' code, but decided to make that a separate PR (if I do it at all).\r\n\r\nYou can test that this works by deleting an object with forward references (contains a Note, Media etc.).  And then run the updated Check & Repair from #475 while on a Dbapi db like Sqlite.  Prior to this fix Check and repair will show an error, after the fix, the same test procedure should not."},"comment":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/comments/336568030","html_url":"https://github.com/gramps-project/gramps/pull/479#issuecomment-336568030","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/479","id":336568030,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T21:09:15Z","updated_at":"2017-10-13T21:09:15Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=h1) Report\n> Merging [#479](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=desc) into [maintenance/gramps50](https://codecov.io/gh/gramps-project/gramps/commit/94a6495a069457f789b9ba9cb4c496ac304061c3?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gramps-project/gramps/pull/479/graphs/tree.svg?token=jiyPSK12Bt&height=150&src=pr&width=650)](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=tree)\n\n```diff\n@@                   Coverage Diff                    @@\n##           maintenance/gramps50     #479      +/-   ##\n========================================================\n+ Coverage                 41.91%   41.92%   +<.01%     \n========================================================\n  Files                      1060     1060              \n  Lines                    141120   141131      +11     \n========================================================\n+ Hits                      59154    59164      +10     \n- Misses                    81966    81967       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [gramps/plugins/db/dbapi/dbapi.py](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=tree#diff-Z3JhbXBzL3BsdWdpbnMvZGIvZGJhcGkvZGJhcGkucHk=) | `92.14% <100%> (+0.2%)` | :arrow_up: |\n| [gramps/gen/merge/mergefamilyquery.py](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=tree#diff-Z3JhbXBzL2dlbi9tZXJnZS9tZXJnZWZhbWlseXF1ZXJ5LnB5) | `91.42% <0%> (-0.96%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=footer). Last update [94a6495...9aac1b8](https://codecov.io/gh/gramps-project/gramps/pull/479?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}