{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/142295300","pull_request_review_id":66635659,"id":142295300,"diff_hunk":"@@ -183,96 +152,100 @@ class KafkaCheckpointManager(\n       checkpoints.put(taskName, checkpoint) // replacing any existing, older checkpoints as we go\n     }\n \n-    readLog(CHECKPOINT_LOG4J_ENTRY, shouldHandleEntry, handleCheckpoint)\n+    readLog(shouldHandleEntry, handleCheckpoint)\n     checkpoints.toMap /* of the immutable kind */\n   }\n \n+  private def getEarliestOffset(topic: String, partition: Partition): SystemStreamPartitionMetadata = {\n+    val systemAdmin = getSystemAdmin()\n+    val metaDataMap: java.util.Map[String, SystemStreamMetadata] = systemAdmin.getSystemStreamMetadata(Collections.singleton(topic))\n+    val checkpointMetadata: SystemStreamMetadata = metaDataMap.get(topic)\n+    if(checkpointMetadata == null)\n+      throw new SamzaException(\"Cannot get metadata for system=%s, topic=%s\" format (systemName, topic))","path":"samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala","position":146,"original_position":146,"commit_id":"9cb1d1a448c10669fe255b857b4448d71c366cd9","original_commit_id":"3ca7db4d77c1249d053833ad59dae87cd8c127c0","user":{"login":"sborya","id":959768,"avatar_url":"https://avatars3.githubusercontent.com/u/959768?v=4","gravatar_id":"","url":"https://api.github.com/users/sborya","html_url":"https://github.com/sborya","followers_url":"https://api.github.com/users/sborya/followers","following_url":"https://api.github.com/users/sborya/following{/other_user}","gists_url":"https://api.github.com/users/sborya/gists{/gist_id}","starred_url":"https://api.github.com/users/sborya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sborya/subscriptions","organizations_url":"https://api.github.com/users/sborya/orgs","repos_url":"https://api.github.com/users/sborya/repos","events_url":"https://api.github.com/users/sborya/events{/privacy}","received_events_url":"https://api.github.com/users/sborya/received_events","type":"User","site_admin":false},"body":"you are better then checkStyle! Done.","created_at":"2017-10-03T01:27:11Z","updated_at":"2017-10-03T01:27:11Z","html_url":"https://github.com/apache/samza/pull/299#discussion_r142295300","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/299","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/142295300"},"html":{"href":"https://github.com/apache/samza/pull/299#discussion_r142295300"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/299"}},"in_reply_to_id":141766795},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/299","id":142406140,"html_url":"https://github.com/apache/samza/pull/299","diff_url":"https://github.com/apache/samza/pull/299.diff","patch_url":"https://github.com/apache/samza/pull/299.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/299","number":299,"state":"open","locked":false,"title":"SAMZA-1427: use systemFactory in checkpoint manager.","user":{"login":"sborya","id":959768,"avatar_url":"https://avatars3.githubusercontent.com/u/959768?v=4","gravatar_id":"","url":"https://api.github.com/users/sborya","html_url":"https://github.com/sborya","followers_url":"https://api.github.com/users/sborya/followers","following_url":"https://api.github.com/users/sborya/following{/other_user}","gists_url":"https://api.github.com/users/sborya/gists{/gist_id}","starred_url":"https://api.github.com/users/sborya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sborya/subscriptions","organizations_url":"https://api.github.com/users/sborya/orgs","repos_url":"https://api.github.com/users/sborya/repos","events_url":"https://api.github.com/users/sborya/events{/privacy}","received_events_url":"https://api.github.com/users/sborya/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-21T17:52:43Z","updated_at":"2017-10-03T01:27:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8d94276b6fe27b3a91d6afda6cb4b5cd3975028","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/299/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/299/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/299/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/9cb1d1a448c10669fe255b857b4448d71c366cd9","head":{"label":"sborya:LiKafkaClient","ref":"LiKafkaClient","sha":"9cb1d1a448c10669fe255b857b4448d71c366cd9","user":{"login":"sborya","id":959768,"avatar_url":"https://avatars3.githubusercontent.com/u/959768?v=4","gravatar_id":"","url":"https://api.github.com/users/sborya","html_url":"https://github.com/sborya","followers_url":"https://api.github.com/users/sborya/followers","following_url":"https://api.github.com/users/sborya/following{/other_user}","gists_url":"https://api.github.com/users/sborya/gists{/gist_id}","starred_url":"https://api.github.com/users/sborya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sborya/subscriptions","organizations_url":"https://api.github.com/users/sborya/orgs","repos_url":"https://api.github.com/users/sborya/repos","events_url":"https://api.github.com/users/sborya/events{/privacy}","received_events_url":"https://api.github.com/users/sborya/received_events","type":"User","site_admin":false},"repo":{"id":78160153,"name":"samza","full_name":"sborya/samza","owner":{"login":"sborya","id":959768,"avatar_url":"https://avatars3.githubusercontent.com/u/959768?v=4","gravatar_id":"","url":"https://api.github.com/users/sborya","html_url":"https://github.com/sborya","followers_url":"https://api.github.com/users/sborya/followers","following_url":"https://api.github.com/users/sborya/following{/other_user}","gists_url":"https://api.github.com/users/sborya/gists{/gist_id}","starred_url":"https://api.github.com/users/sborya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sborya/subscriptions","organizations_url":"https://api.github.com/users/sborya/orgs","repos_url":"https://api.github.com/users/sborya/repos","events_url":"https://api.github.com/users/sborya/events{/privacy}","received_events_url":"https://api.github.com/users/sborya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sborya/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/sborya/samza","forks_url":"https://api.github.com/repos/sborya/samza/forks","keys_url":"https://api.github.com/repos/sborya/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sborya/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sborya/samza/teams","hooks_url":"https://api.github.com/repos/sborya/samza/hooks","issue_events_url":"https://api.github.com/repos/sborya/samza/issues/events{/number}","events_url":"https://api.github.com/repos/sborya/samza/events","assignees_url":"https://api.github.com/repos/sborya/samza/assignees{/user}","branches_url":"https://api.github.com/repos/sborya/samza/branches{/branch}","tags_url":"https://api.github.com/repos/sborya/samza/tags","blobs_url":"https://api.github.com/repos/sborya/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sborya/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sborya/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/sborya/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sborya/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/sborya/samza/languages","stargazers_url":"https://api.github.com/repos/sborya/samza/stargazers","contributors_url":"https://api.github.com/repos/sborya/samza/contributors","subscribers_url":"https://api.github.com/repos/sborya/samza/subscribers","subscription_url":"https://api.github.com/repos/sborya/samza/subscription","commits_url":"https://api.github.com/repos/sborya/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/sborya/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/sborya/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/sborya/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/sborya/samza/contents/{+path}","compare_url":"https://api.github.com/repos/sborya/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sborya/samza/merges","archive_url":"https://api.github.com/repos/sborya/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sborya/samza/downloads","issues_url":"https://api.github.com/repos/sborya/samza/issues{/number}","pulls_url":"https://api.github.com/repos/sborya/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/sborya/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/sborya/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sborya/samza/labels{/name}","releases_url":"https://api.github.com/repos/sborya/samza/releases{/id}","deployments_url":"https://api.github.com/repos/sborya/samza/deployments","created_at":"2017-01-06T00:42:48Z","updated_at":"2017-01-06T00:42:52Z","pushed_at":"2017-10-03T00:59:09Z","git_url":"git://github.com/sborya/samza.git","ssh_url":"git@github.com:sborya/samza.git","clone_url":"https://github.com/sborya/samza.git","svn_url":"https://github.com/sborya/samza","homepage":null,"size":17543,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"92894e5e283d605e6243177cc5ed11c3139aa7bc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2017-10-02T04:04:41Z","pushed_at":"2017-10-03T01:21:36Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":17575,"stargazers_count":363,"watchers_count":363,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":"git://git.apache.org/samza.git","open_issues_count":31,"forks":166,"open_issues":31,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/299"},"html":{"href":"https://github.com/apache/samza/pull/299"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/299"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/9cb1d1a448c10669fe255b857b4448d71c366cd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sborya"}}