{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/dns/issues/48","repository_url":"https://api.github.com/repos/kubernetes/dns","labels_url":"https://api.github.com/repos/kubernetes/dns/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/dns/issues/48/comments","events_url":"https://api.github.com/repos/kubernetes/dns/issues/48/events","html_url":"https://github.com/kubernetes/dns/issues/48","id":204925593,"number":48,"title":"build/dep.sh and Godeps does not properly import some dependencies","user":{"login":"cmluciano","id":4790487,"avatar_url":"https://avatars2.githubusercontent.com/u/4790487?v=3","gravatar_id":"","url":"https://api.github.com/users/cmluciano","html_url":"https://github.com/cmluciano","followers_url":"https://api.github.com/users/cmluciano/followers","following_url":"https://api.github.com/users/cmluciano/following{/other_user}","gists_url":"https://api.github.com/users/cmluciano/gists{/gist_id}","starred_url":"https://api.github.com/users/cmluciano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmluciano/subscriptions","organizations_url":"https://api.github.com/users/cmluciano/orgs","repos_url":"https://api.github.com/users/cmluciano/repos","events_url":"https://api.github.com/users/cmluciano/events{/privacy}","received_events_url":"https://api.github.com/users/cmluciano/received_events","type":"User","site_admin":false},"labels":[{"id":501633777,"url":"https://api.github.com/repos/kubernetes/dns/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-02-02T16:32:11Z","updated_at":"2017-07-07T21:16:25Z","closed_at":"2017-07-07T21:16:25Z","body":"There are 3 dependencies that are not pulled in properly with Godep. I can only get a successful build by adding the dependent libraries to [build/dep.sh required packages](https://github.com/kubernetes/dns/blob/master/build/dep.sh#L21).\r\n\r\n```\r\nREQUIRED_PKGS=\"cloud.google.com/go/internal/... golang.org/x/text/internal/... ./pkg/... ./cmd/...\"\r\n```\r\n\r\nPackages not pulled in:\r\ngithub.com/googleapis/gax-go\r\ngolang.org/x/text/internal\r\n\r\nSteps to reproduce:\r\n1. Enter container ``./build/dep.sh enter -u``\r\n2. Pull latest of a given DEP. \r\n3. Remove the Godep and vendor folders\r\n4. Run ./build/dep.sh save\r\n5. Exit container assuming no complaints from Godep\r\n6. ``make build``\r\n\r\n```\r\nroot@ubuntu-xenial:/vagrant# make build\r\nbuilding : bin/amd64/e2e\r\nvendor/cloud.google.com/go/internal/retry.go:21:2: cannot find package \"github.com/googleapis/gax-go\" in any of:\r\n\t/go/src/k8s.io/dns/vendor/github.com/googleapis/gax-go (vendor tree)\r\n\t/usr/local/go/src/github.com/googleapis/gax-go (from $GOROOT)\r\n\t/go/src/github.com/googleapis/gax-go (from $GOPATH)\r\ntest/e2e/kubedns/kubedns.go:23:2: cannot find package \"github.com/onsi/ginkgo\" in any of:\r\n\t/go/src/k8s.io/dns/vendor/github.com/onsi/ginkgo (vendor tree)\r\n\t/usr/local/go/src/github.com/onsi/ginkgo (from $GOROOT)\r\n\t/go/src/github.com/onsi/ginkgo (from $GOPATH)\r\nvendor/golang.org/x/text/cases/map.go:16:2: cannot find package \"golang.org/x/text/internal\" in any of:\r\n\t/go/src/k8s.io/dns/vendor/golang.org/x/text/internal (vendor tree)\r\n\t/usr/local/go/src/golang.org/x/text/internal (from $GOROOT)\r\n\t/go/src/golang.org/x/text/internal (from $GOPATH)\r\n```"}}
{"actor":{"display_login":"k8s-ci-robot"}}