{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50","id":111469643,"html_url":"https://github.com/Shopify/shopify.github.com/pull/50","diff_url":"https://github.com/Shopify/shopify.github.com/pull/50.diff","patch_url":"https://github.com/Shopify/shopify.github.com/pull/50.patch","issue_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/50","number":50,"state":"closed","locked":false,"title":"use favicon from marketing assets","user":{"login":"NathanPJF","id":6284114,"avatar_url":"https://avatars1.githubusercontent.com/u/6284114?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanPJF","html_url":"https://github.com/NathanPJF","followers_url":"https://api.github.com/users/NathanPJF/followers","following_url":"https://api.github.com/users/NathanPJF/following{/other_user}","gists_url":"https://api.github.com/users/NathanPJF/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanPJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanPJF/subscriptions","organizations_url":"https://api.github.com/users/NathanPJF/orgs","repos_url":"https://api.github.com/users/NathanPJF/repos","events_url":"https://api.github.com/users/NathanPJF/events{/privacy}","received_events_url":"https://api.github.com/users/NathanPJF/received_events","type":"User","site_admin":false},"body":"**Issue**: Site is using the old favicon.\r\n\r\nI've switched it to use the one from marketing_assets.  Same approach as in the JS Buy SDK. https://shopify.github.io/js-buy-sdk/\r\n\r\nCurrent: https://cdn.shopify.com/assets/favicon.ico\r\nNew: https://cdn.shopify.com/shopify-marketing_assets/static/shopify-favicon.png\r\n\r\n![](http://take.ms/i0H9L)\r\n\r\n---\r\n\r\nNote: I'm using `RBENV`, so I added it to the list of ignores.","created_at":"2017-03-19T21:47:38Z","updated_at":"2017-03-21T01:13:47Z","closed_at":"2017-03-21T01:13:47Z","merged_at":"2017-03-21T01:13:47Z","merge_commit_sha":"cd7fc5727bd42138ba61709ee5acb4005ff8b513","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50/commits","review_comments_url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50/comments","review_comment_url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/50/comments","statuses_url":"https://api.github.com/repos/Shopify/shopify.github.com/statuses/2520065c316013a6da0f07be880938235b58ae16","head":{"label":"Shopify:update-favicon","ref":"update-favicon","sha":"2520065c316013a6da0f07be880938235b58ae16","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":5264825,"name":"shopify.github.com","full_name":"Shopify/shopify.github.com","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify.github.com","description":"A collection of the open source projects by Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/shopify.github.com","forks_url":"https://api.github.com/repos/Shopify/shopify.github.com/forks","keys_url":"https://api.github.com/repos/Shopify/shopify.github.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify.github.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify.github.com/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify.github.com/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify.github.com/events","assignees_url":"https://api.github.com/repos/Shopify/shopify.github.com/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify.github.com/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify.github.com/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify.github.com/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify.github.com/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify.github.com/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify.github.com/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify.github.com/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify.github.com/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify.github.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify.github.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify.github.com/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify.github.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify.github.com/merges","archive_url":"https://api.github.com/repos/Shopify/shopify.github.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify.github.com/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify.github.com/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify.github.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify.github.com/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify.github.com/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify.github.com/deployments","created_at":"2012-08-01T21:11:39Z","updated_at":"2017-03-19T16:30:55Z","pushed_at":"2017-03-21T01:13:47Z","git_url":"git://github.com/Shopify/shopify.github.com.git","ssh_url":"git@github.com:Shopify/shopify.github.com.git","clone_url":"https://github.com/Shopify/shopify.github.com.git","svn_url":"https://github.com/Shopify/shopify.github.com","homepage":"http://shopify.github.io","size":599,"stargazers_count":131,"watchers_count":131,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":1,"forks":69,"open_issues":1,"watchers":131,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"b923ca64dc63f8ae02c328bc13b496b6a69b59bf","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":5264825,"name":"shopify.github.com","full_name":"Shopify/shopify.github.com","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify.github.com","description":"A collection of the open source projects by Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/shopify.github.com","forks_url":"https://api.github.com/repos/Shopify/shopify.github.com/forks","keys_url":"https://api.github.com/repos/Shopify/shopify.github.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify.github.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify.github.com/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify.github.com/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify.github.com/events","assignees_url":"https://api.github.com/repos/Shopify/shopify.github.com/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify.github.com/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify.github.com/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify.github.com/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify.github.com/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify.github.com/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify.github.com/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify.github.com/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify.github.com/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify.github.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify.github.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify.github.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify.github.com/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify.github.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify.github.com/merges","archive_url":"https://api.github.com/repos/Shopify/shopify.github.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify.github.com/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify.github.com/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify.github.com/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify.github.com/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify.github.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify.github.com/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify.github.com/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify.github.com/deployments","created_at":"2012-08-01T21:11:39Z","updated_at":"2017-03-19T16:30:55Z","pushed_at":"2017-03-21T01:13:47Z","git_url":"git://github.com/Shopify/shopify.github.com.git","ssh_url":"git@github.com:Shopify/shopify.github.com.git","clone_url":"https://github.com/Shopify/shopify.github.com.git","svn_url":"https://github.com/Shopify/shopify.github.com","homepage":"http://shopify.github.io","size":599,"stargazers_count":131,"watchers_count":131,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":1,"forks":69,"open_issues":1,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50"},"html":{"href":"https://github.com/Shopify/shopify.github.com/pull/50"},"issue":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/issues/50"},"comments":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shopify.github.com/statuses/2520065c316013a6da0f07be880938235b58ae16"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"NathanPJF","id":6284114,"avatar_url":"https://avatars1.githubusercontent.com/u/6284114?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanPJF","html_url":"https://github.com/NathanPJF","followers_url":"https://api.github.com/users/NathanPJF/followers","following_url":"https://api.github.com/users/NathanPJF/following{/other_user}","gists_url":"https://api.github.com/users/NathanPJF/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanPJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanPJF/subscriptions","organizations_url":"https://api.github.com/users/NathanPJF/orgs","repos_url":"https://api.github.com/users/NathanPJF/repos","events_url":"https://api.github.com/users/NathanPJF/events{/privacy}","received_events_url":"https://api.github.com/users/NathanPJF/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"NathanPJF"}}