{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/100613937","pull_request_review_id":21331037,"id":100613937,"diff_hunk":"@@ -38,5 +39,11 @@ public class PolicyAssignmentProperties\n         /// </summary>\n         [JsonProperty(Required = Required.Always)]\n         public string PolicyDefinitionId { get; set; }\n+\n+        /// <summary>\n+        /// The parameter values.\n+        /// </summary>\n+        [JsonProperty(Required = Required.Default)]\n+        public JObject Parameters { get; set; }","path":"src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Entities/Policy/PolicyAssignmentProperties.cs","position":null,"original_position":17,"commit_id":"0b2b101ab6d3a98cfaa03148d7ee4ce3b5dd2d5a","original_commit_id":"81f9384ccba3d50ce86c0ea49253fcfb88108fe5","user":{"login":"luanshixia","id":4253867,"avatar_url":"https://avatars.githubusercontent.com/u/4253867?v=3","gravatar_id":"","url":"https://api.github.com/users/luanshixia","html_url":"https://github.com/luanshixia","followers_url":"https://api.github.com/users/luanshixia/followers","following_url":"https://api.github.com/users/luanshixia/following{/other_user}","gists_url":"https://api.github.com/users/luanshixia/gists{/gist_id}","starred_url":"https://api.github.com/users/luanshixia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luanshixia/subscriptions","organizations_url":"https://api.github.com/users/luanshixia/orgs","repos_url":"https://api.github.com/users/luanshixia/repos","events_url":"https://api.github.com/users/luanshixia/events{/privacy}","received_events_url":"https://api.github.com/users/luanshixia/received_events","type":"User","site_admin":false},"body":"Unfortunately this property cannot be renamed because that should match the REST API. (I also only realized this when I caught an error after trying to keep consistency). Of course we can match names using JsonProperty attribute, but no need.","created_at":"2017-02-10T20:06:05Z","updated_at":"2017-02-10T20:06:05Z","html_url":"https://github.com/Azure/azure-powershell/pull/3476#discussion_r100613937","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/100613937"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/3476#discussion_r100613937"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476","id":105111712,"html_url":"https://github.com/Azure/azure-powershell/pull/3476","diff_url":"https://github.com/Azure/azure-powershell/pull/3476.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/3476.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/3476","number":3476,"state":"open","locked":false,"title":"Policy parameters support in New-AzureRmPolicyDefinition and New-AzureRmPolicyAssignment","user":{"login":"luanshixia","id":4253867,"avatar_url":"https://avatars.githubusercontent.com/u/4253867?v=3","gravatar_id":"","url":"https://api.github.com/users/luanshixia","html_url":"https://github.com/luanshixia","followers_url":"https://api.github.com/users/luanshixia/followers","following_url":"https://api.github.com/users/luanshixia/following{/other_user}","gists_url":"https://api.github.com/users/luanshixia/gists{/gist_id}","starred_url":"https://api.github.com/users/luanshixia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luanshixia/subscriptions","organizations_url":"https://api.github.com/users/luanshixia/orgs","repos_url":"https://api.github.com/users/luanshixia/repos","events_url":"https://api.github.com/users/luanshixia/events{/privacy}","received_events_url":"https://api.github.com/users/luanshixia/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\nAdded support for policy parameters to the 2 cmdlets to use the feature provided by API version 2016-12-01.\r\n\r\n<!--\r\nPlease add an informative description that covers the changes made by the pull request.\r\n\r\nIf applicable, reference the bug/issue that this pull request fixes here.\r\n-->\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).\r\n\r\n- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md).**\r\n- [x] **If changes were made to any cmdlet, the XML help was regenerated using the [platyPSHelp module](https://github.com/Azure/azure-powershell/blob/dev/documentation/platyPSHelp-documentation.md).**\r\n- [x] **If any large changes are made to a service, they are reflected in the respective [change log](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#updating-the-change-log).**\r\n\r\n### [General Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#general-guidelines)\r\n- [x] Title of the pull request is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n- [x] The pull request does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes.md) (unless a major version change occurs in the assembly and module).\r\n\r\n### [Testing Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#testing-guidelines)\r\n- [x] Pull request includes test coverage for the included changes.\r\n- [x] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.\r\n\r\n### [Cmdlet Signature Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-signature-guidelines)\r\n- [x] New cmdlets that make changes or have side effects should implement `ShouldProcess` and have `SupportShouldProcess=true` specified in the cmdlet attribute. You can find more information on `ShouldProcess` [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change).\r\n- [x] Cmdlet specifies `OutputType` attribute if any output is produced - if the cmdlet produces no output, it should implement a `PassThru` parameter.\r\n\r\n### [Cmdlet Parameter Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-parameter-guidelines)\r\n- [x] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.\r\n- [x] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.\r\n- [x] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.\r\n","created_at":"2017-02-07T22:49:16Z","updated_at":"2017-02-10T20:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf47e8064bac07ba11d14c44101f33dcd5d1ae7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/3476/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/0b2b101ab6d3a98cfaa03148d7ee4ce3b5dd2d5a","head":{"label":"luanshixia:dev","ref":"dev","sha":"0b2b101ab6d3a98cfaa03148d7ee4ce3b5dd2d5a","user":{"login":"luanshixia","id":4253867,"avatar_url":"https://avatars.githubusercontent.com/u/4253867?v=3","gravatar_id":"","url":"https://api.github.com/users/luanshixia","html_url":"https://github.com/luanshixia","followers_url":"https://api.github.com/users/luanshixia/followers","following_url":"https://api.github.com/users/luanshixia/following{/other_user}","gists_url":"https://api.github.com/users/luanshixia/gists{/gist_id}","starred_url":"https://api.github.com/users/luanshixia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luanshixia/subscriptions","organizations_url":"https://api.github.com/users/luanshixia/orgs","repos_url":"https://api.github.com/users/luanshixia/repos","events_url":"https://api.github.com/users/luanshixia/events{/privacy}","received_events_url":"https://api.github.com/users/luanshixia/received_events","type":"User","site_admin":false},"repo":{"id":80683558,"name":"azure-powershell","full_name":"luanshixia/azure-powershell","owner":{"login":"luanshixia","id":4253867,"avatar_url":"https://avatars.githubusercontent.com/u/4253867?v=3","gravatar_id":"","url":"https://api.github.com/users/luanshixia","html_url":"https://github.com/luanshixia","followers_url":"https://api.github.com/users/luanshixia/followers","following_url":"https://api.github.com/users/luanshixia/following{/other_user}","gists_url":"https://api.github.com/users/luanshixia/gists{/gist_id}","starred_url":"https://api.github.com/users/luanshixia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luanshixia/subscriptions","organizations_url":"https://api.github.com/users/luanshixia/orgs","repos_url":"https://api.github.com/users/luanshixia/repos","events_url":"https://api.github.com/users/luanshixia/events{/privacy}","received_events_url":"https://api.github.com/users/luanshixia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luanshixia/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/luanshixia/azure-powershell","forks_url":"https://api.github.com/repos/luanshixia/azure-powershell/forks","keys_url":"https://api.github.com/repos/luanshixia/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luanshixia/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luanshixia/azure-powershell/teams","hooks_url":"https://api.github.com/repos/luanshixia/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/luanshixia/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/luanshixia/azure-powershell/events","assignees_url":"https://api.github.com/repos/luanshixia/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/luanshixia/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/luanshixia/azure-powershell/tags","blobs_url":"https://api.github.com/repos/luanshixia/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luanshixia/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luanshixia/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/luanshixia/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luanshixia/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/luanshixia/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/luanshixia/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/luanshixia/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/luanshixia/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/luanshixia/azure-powershell/subscription","commits_url":"https://api.github.com/repos/luanshixia/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/luanshixia/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/luanshixia/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/luanshixia/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/luanshixia/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/luanshixia/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luanshixia/azure-powershell/merges","archive_url":"https://api.github.com/repos/luanshixia/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luanshixia/azure-powershell/downloads","issues_url":"https://api.github.com/repos/luanshixia/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/luanshixia/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/luanshixia/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/luanshixia/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luanshixia/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/luanshixia/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/luanshixia/azure-powershell/deployments","created_at":"2017-02-02T01:44:00Z","updated_at":"2017-02-02T01:44:34Z","pushed_at":"2017-02-10T01:59:10Z","git_url":"git://github.com/luanshixia/azure-powershell.git","ssh_url":"git@github.com:luanshixia/azure-powershell.git","clone_url":"https://github.com/luanshixia/azure-powershell.git","svn_url":"https://github.com/luanshixia/azure-powershell","homepage":null,"size":231674,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"e5b96d7f3ff8e0f920600ef259eab88169d4fd98","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2017-02-09T15:18:58Z","pushed_at":"2017-02-10T18:57:35Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":232725,"stargazers_count":633,"watchers_count":633,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":608,"mirror_url":null,"open_issues_count":521,"forks":608,"open_issues":521,"watchers":633,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/3476"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/3476"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/3476/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3476/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/0b2b101ab6d3a98cfaa03148d7ee4ce3b5dd2d5a"}}}}
{"actor":{"display_login":"luanshixia"}}