{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/comments/134095931","pull_request_review_id":57354160,"id":134095931,"diff_hunk":"@@ -23,6 +23,12 @@\n  */\n class AssertTrue {\n \n+\t///CLOVER:OFF\n+\tprivate AssertTrue() {\n+\t\t/* no-op */\n+\t}\n+\t///CLOVER:ON\n+","path":"junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertTrue.java","position":null,"original_position":9,"commit_id":"dbbd7f13a9015a1536064fb2e94a4183ab03545f","original_commit_id":"c7d3df9aa25c9616ac863695e1d7067bf364b392","user":{"login":"jbduncan","id":2482228,"avatar_url":"https://avatars2.githubusercontent.com/u/2482228?v=4","gravatar_id":"","url":"https://api.github.com/users/jbduncan","html_url":"https://github.com/jbduncan","followers_url":"https://api.github.com/users/jbduncan/followers","following_url":"https://api.github.com/users/jbduncan/following{/other_user}","gists_url":"https://api.github.com/users/jbduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/jbduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbduncan/subscriptions","organizations_url":"https://api.github.com/users/jbduncan/orgs","repos_url":"https://api.github.com/users/jbduncan/repos","events_url":"https://api.github.com/users/jbduncan/events{/privacy}","received_events_url":"https://api.github.com/users/jbduncan/received_events","type":"User","site_admin":false},"body":"Certainly. Should be done and ready for merging over at #1027.","created_at":"2017-08-19T16:58:32Z","updated_at":"2017-08-19T16:58:32Z","html_url":"https://github.com/junit-team/junit5/pull/961#discussion_r134095931","pull_request_url":"https://api.github.com/repos/junit-team/junit5/pulls/961","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/comments/134095931"},"html":{"href":"https://github.com/junit-team/junit5/pull/961#discussion_r134095931"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/961"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/961","id":131109575,"html_url":"https://github.com/junit-team/junit5/pull/961","diff_url":"https://github.com/junit-team/junit5/pull/961.diff","patch_url":"https://github.com/junit-team/junit5/pull/961.patch","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/961","number":961,"state":"open","locked":false,"title":"Enable error-prone static analysis checks","user":{"login":"jbduncan","id":2482228,"avatar_url":"https://avatars2.githubusercontent.com/u/2482228?v=4","gravatar_id":"","url":"https://api.github.com/users/jbduncan","html_url":"https://github.com/jbduncan","followers_url":"https://api.github.com/users/jbduncan/followers","following_url":"https://api.github.com/users/jbduncan/following{/other_user}","gists_url":"https://api.github.com/users/jbduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/jbduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbduncan/subscriptions","organizations_url":"https://api.github.com/users/jbduncan/orgs","repos_url":"https://api.github.com/users/jbduncan/repos","events_url":"https://api.github.com/users/jbduncan/events{/privacy}","received_events_url":"https://api.github.com/users/jbduncan/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nFollowing issue #955, this is a work-in-progress PR to introduce error-prone checks to JUnit 5.\r\n\r\nFeedback is welcome!\r\n\r\n---\r\n\r\nI hereby agree to the terms of the JUnit Contributor License Agreement.\r\n\r\n---\r\n\r\n### Definition of Done\r\n\r\n- [ ] There are no TODOs left in the code\r\n- [ ] Method [preconditions](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/util/Preconditions.html) are checked and documented in the method's Javadoc\r\n- [x] [Coding conventions](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#coding-conventions) (e.g. for logging) have been followed\r\n- [ ] Change is covered by [automated tests](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#tests)\r\n- [ ] Public API has [Javadoc](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#javadoc) and [`@API` annotations](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/meta/API.html)\r\n- [ ] Change is documented in the [User Guide](http://junit.org/junit5/docs/snapshot/user-guide/) and [Release Notes](http://junit.org/junit5/docs/snapshot/user-guide/#release-notes)\r\n- [x] All [continuous integration builds](https://github.com/junit-team/junit5#continuous-integration-builds) pass\r\n","created_at":"2017-07-18T14:55:51Z","updated_at":"2017-08-19T16:58:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e34124b8ee083da5bbbe785b2e31d33dac9271","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit5/pulls/961/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit5/pulls/961/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/961/comments","statuses_url":"https://api.github.com/repos/junit-team/junit5/statuses/dbbd7f13a9015a1536064fb2e94a4183ab03545f","head":{"label":"jbduncan:error-prone","ref":"error-prone","sha":"dbbd7f13a9015a1536064fb2e94a4183ab03545f","user":{"login":"jbduncan","id":2482228,"avatar_url":"https://avatars2.githubusercontent.com/u/2482228?v=4","gravatar_id":"","url":"https://api.github.com/users/jbduncan","html_url":"https://github.com/jbduncan","followers_url":"https://api.github.com/users/jbduncan/followers","following_url":"https://api.github.com/users/jbduncan/following{/other_user}","gists_url":"https://api.github.com/users/jbduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/jbduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbduncan/subscriptions","organizations_url":"https://api.github.com/users/jbduncan/orgs","repos_url":"https://api.github.com/users/jbduncan/repos","events_url":"https://api.github.com/users/jbduncan/events{/privacy}","received_events_url":"https://api.github.com/users/jbduncan/received_events","type":"User","site_admin":false},"repo":{"id":60414723,"name":"junit5","full_name":"jbduncan/junit5","owner":{"login":"jbduncan","id":2482228,"avatar_url":"https://avatars2.githubusercontent.com/u/2482228?v=4","gravatar_id":"","url":"https://api.github.com/users/jbduncan","html_url":"https://github.com/jbduncan","followers_url":"https://api.github.com/users/jbduncan/followers","following_url":"https://api.github.com/users/jbduncan/following{/other_user}","gists_url":"https://api.github.com/users/jbduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/jbduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbduncan/subscriptions","organizations_url":"https://api.github.com/users/jbduncan/orgs","repos_url":"https://api.github.com/users/jbduncan/repos","events_url":"https://api.github.com/users/jbduncan/events{/privacy}","received_events_url":"https://api.github.com/users/jbduncan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbduncan/junit5","description":"The next generation of JUnit.","fork":true,"url":"https://api.github.com/repos/jbduncan/junit5","forks_url":"https://api.github.com/repos/jbduncan/junit5/forks","keys_url":"https://api.github.com/repos/jbduncan/junit5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbduncan/junit5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbduncan/junit5/teams","hooks_url":"https://api.github.com/repos/jbduncan/junit5/hooks","issue_events_url":"https://api.github.com/repos/jbduncan/junit5/issues/events{/number}","events_url":"https://api.github.com/repos/jbduncan/junit5/events","assignees_url":"https://api.github.com/repos/jbduncan/junit5/assignees{/user}","branches_url":"https://api.github.com/repos/jbduncan/junit5/branches{/branch}","tags_url":"https://api.github.com/repos/jbduncan/junit5/tags","blobs_url":"https://api.github.com/repos/jbduncan/junit5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbduncan/junit5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbduncan/junit5/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbduncan/junit5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbduncan/junit5/statuses/{sha}","languages_url":"https://api.github.com/repos/jbduncan/junit5/languages","stargazers_url":"https://api.github.com/repos/jbduncan/junit5/stargazers","contributors_url":"https://api.github.com/repos/jbduncan/junit5/contributors","subscribers_url":"https://api.github.com/repos/jbduncan/junit5/subscribers","subscription_url":"https://api.github.com/repos/jbduncan/junit5/subscription","commits_url":"https://api.github.com/repos/jbduncan/junit5/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbduncan/junit5/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbduncan/junit5/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbduncan/junit5/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbduncan/junit5/contents/{+path}","compare_url":"https://api.github.com/repos/jbduncan/junit5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbduncan/junit5/merges","archive_url":"https://api.github.com/repos/jbduncan/junit5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbduncan/junit5/downloads","issues_url":"https://api.github.com/repos/jbduncan/junit5/issues{/number}","pulls_url":"https://api.github.com/repos/jbduncan/junit5/pulls{/number}","milestones_url":"https://api.github.com/repos/jbduncan/junit5/milestones{/number}","notifications_url":"https://api.github.com/repos/jbduncan/junit5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbduncan/junit5/labels{/name}","releases_url":"https://api.github.com/repos/jbduncan/junit5/releases{/id}","deployments_url":"https://api.github.com/repos/jbduncan/junit5/deployments","created_at":"2016-06-04T14:41:29Z","updated_at":"2016-06-04T14:41:31Z","pushed_at":"2017-08-19T16:57:20Z","git_url":"git://github.com/jbduncan/junit5.git","ssh_url":"git@github.com:jbduncan/junit5.git","clone_url":"https://github.com/jbduncan/junit5.git","svn_url":"https://github.com/jbduncan/junit5","homepage":"http://junit.org/junit5/","size":10431,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"0d38b150b0a6aa21a8bef9577688d2fedb91006e","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":29102367,"name":"junit5","full_name":"junit-team/junit5","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit5","description":"The next generation of JUnit.","fork":false,"url":"https://api.github.com/repos/junit-team/junit5","forks_url":"https://api.github.com/repos/junit-team/junit5/forks","keys_url":"https://api.github.com/repos/junit-team/junit5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit5/teams","hooks_url":"https://api.github.com/repos/junit-team/junit5/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit5/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit5/events","assignees_url":"https://api.github.com/repos/junit-team/junit5/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit5/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit5/tags","blobs_url":"https://api.github.com/repos/junit-team/junit5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit5/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit5/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit5/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit5/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit5/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit5/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit5/subscription","commits_url":"https://api.github.com/repos/junit-team/junit5/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit5/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit5/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit5/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit5/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit5/merges","archive_url":"https://api.github.com/repos/junit-team/junit5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit5/downloads","issues_url":"https://api.github.com/repos/junit-team/junit5/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit5/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit5/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit5/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit5/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit5/deployments","created_at":"2015-01-11T19:06:10Z","updated_at":"2017-08-18T17:26:20Z","pushed_at":"2017-08-19T16:57:21Z","git_url":"git://github.com/junit-team/junit5.git","ssh_url":"git@github.com:junit-team/junit5.git","clone_url":"https://github.com/junit-team/junit5.git","svn_url":"https://github.com/junit-team/junit5","homepage":"http://junit.org/junit5/","size":241874,"stargazers_count":1215,"watchers_count":1215,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":311,"mirror_url":null,"open_issues_count":145,"forks":311,"open_issues":145,"watchers":1215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/961"},"html":{"href":"https://github.com/junit-team/junit5/pull/961"},"issue":{"href":"https://api.github.com/repos/junit-team/junit5/issues/961"},"comments":{"href":"https://api.github.com/repos/junit-team/junit5/issues/961/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/961/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit5/pulls/961/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit5/statuses/dbbd7f13a9015a1536064fb2e94a4183ab03545f"}}}}
{"actor":{"display_login":"jbduncan"}}