{"action":"closed","issue":{"url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/issues/622","repository_url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit","labels_url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/issues/622/labels{/name}","comments_url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/issues/622/comments","events_url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/issues/622/events","html_url":"https://github.com/ButchersBoy/MaterialDesignInXamlToolkit/issues/622","id":207833936,"number":622,"title":"ComboBoxPopup can cause memory leak","user":{"login":"spdjudd","id":5413449,"avatar_url":"https://avatars.githubusercontent.com/u/5413449?v=3","gravatar_id":"","url":"https://api.github.com/users/spdjudd","html_url":"https://github.com/spdjudd","followers_url":"https://api.github.com/users/spdjudd/followers","following_url":"https://api.github.com/users/spdjudd/following{/other_user}","gists_url":"https://api.github.com/users/spdjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/spdjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdjudd/subscriptions","organizations_url":"https://api.github.com/users/spdjudd/orgs","repos_url":"https://api.github.com/users/spdjudd/repos","events_url":"https://api.github.com/users/spdjudd/events{/privacy}","received_events_url":"https://api.github.com/users/spdjudd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/milestones/16","html_url":"https://github.com/ButchersBoy/MaterialDesignInXamlToolkit/milestone/16","labels_url":"https://api.github.com/repos/ButchersBoy/MaterialDesignInXamlToolkit/milestones/16/labels","id":2121741,"number":16,"title":"Version 2.3.0","description":"","creator":{"login":"ButchersBoy","id":658107,"avatar_url":"https://avatars.githubusercontent.com/u/658107?v=3","gravatar_id":"","url":"https://api.github.com/users/ButchersBoy","html_url":"https://github.com/ButchersBoy","followers_url":"https://api.github.com/users/ButchersBoy/followers","following_url":"https://api.github.com/users/ButchersBoy/following{/other_user}","gists_url":"https://api.github.com/users/ButchersBoy/gists{/gist_id}","starred_url":"https://api.github.com/users/ButchersBoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ButchersBoy/subscriptions","organizations_url":"https://api.github.com/users/ButchersBoy/orgs","repos_url":"https://api.github.com/users/ButchersBoy/repos","events_url":"https://api.github.com/users/ButchersBoy/events{/privacy}","received_events_url":"https://api.github.com/users/ButchersBoy/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":19,"state":"open","created_at":"2016-11-08T13:03:56Z","updated_at":"2017-02-16T08:46:17Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-02-15T15:21:28Z","updated_at":"2017-02-16T08:46:17Z","closed_at":"2017-02-16T08:46:17Z","body":"Hi James,\r\n\r\nFirstly, thanks very much for MDXT (and Dragablz) - they're great projects and much appreciated.\r\n\r\nThe issue I'm seeing is that using a ComboBox causes a memory leak, as the ComboBoxPopup constructor calls AddValueChanged() on a dependency property and never calls RemoveValueChanged().  In my case this prevents views and datatemplates that have comboboxes being collected. \r\n\r\nI've posted a test repo here: https://github.com/spdjudd/MdxtComboBoxLeak along with instructions - the app is trivial but to see the leak and the GC roots needs a few windbag steps.\r\n\r\nI've also forked and made a change to ComboBoxPopup.cs that fixes the issue here: https://github.com/spdjudd/MaterialDesignInXamlToolkit/blob/master/MaterialDesignThemes.Wpf/ComboBoxPopup.cs\r\n\r\nHappy to submit a pull request if you'd like,\r\n\r\nSimon.\r\n\r\n"}}
{"actor":{"display_login":"ButchersBoy"}}