{"action":"opened","issue":{"url":"https://api.github.com/repos/criteo/zipkin4net/issues/91","repository_url":"https://api.github.com/repos/criteo/zipkin4net","labels_url":"https://api.github.com/repos/criteo/zipkin4net/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/criteo/zipkin4net/issues/91/comments","events_url":"https://api.github.com/repos/criteo/zipkin4net/issues/91/events","html_url":"https://github.com/criteo/zipkin4net/issues/91","id":244005077,"number":91,"title":"SpanState.GetHashCode should include ParentSpanId","user":{"login":"crntn","id":29379804,"avatar_url":"https://avatars0.githubusercontent.com/u/29379804?v=4","gravatar_id":"","url":"https://api.github.com/users/crntn","html_url":"https://github.com/crntn","followers_url":"https://api.github.com/users/crntn/followers","following_url":"https://api.github.com/users/crntn/following{/other_user}","gists_url":"https://api.github.com/users/crntn/gists{/gist_id}","starred_url":"https://api.github.com/users/crntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crntn/subscriptions","organizations_url":"https://api.github.com/users/crntn/orgs","repos_url":"https://api.github.com/users/crntn/repos","events_url":"https://api.github.com/users/crntn/events{/privacy}","received_events_url":"https://api.github.com/users/crntn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-19T11:12:04Z","updated_at":"2017-07-19T11:12:04Z","closed_at":null,"body":"This is a small change but GetHashCode should include parentSpanId to be more consistent with Equals.\r\n`\r\n        public bool Equals(SpanState other)\r\n        {\r\n            if (ReferenceEquals(null, other)) return false;\r\n            if (ReferenceEquals(this, other)) return true;\r\n            return TraceId == other.TraceId && ParentSpanId == other.ParentSpanId && SpanId == other.SpanId;\r\n        }\r\n\r\n        public override int GetHashCode()\r\n        {\r\n            unchecked\r\n            {\r\n                var hashCode = TraceId.GetHashCode();\r\n                hashCode = (hashCode * 397) ^ SpanId.GetHashCode();\r\n                return hashCode;\r\n            }\r\n        }\r\n`"}}
{"actor":{"display_login":"crntn"}}