{"action":"created","issue":{"url":"https://api.github.com/repos/simh/simh/issues/470","repository_url":"https://api.github.com/repos/simh/simh","labels_url":"https://api.github.com/repos/simh/simh/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/simh/simh/issues/470/comments","events_url":"https://api.github.com/repos/simh/simh/issues/470/events","html_url":"https://github.com/simh/simh/issues/470","id":234884654,"number":470,"title":"I1620: Enhancement: \"IO in progress\" message includes instruction","user":{"login":"DaveWise2","id":20525311,"avatar_url":"https://avatars2.githubusercontent.com/u/20525311?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveWise2","html_url":"https://github.com/DaveWise2","followers_url":"https://api.github.com/users/DaveWise2/followers","following_url":"https://api.github.com/users/DaveWise2/following{/other_user}","gists_url":"https://api.github.com/users/DaveWise2/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWise2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWise2/subscriptions","organizations_url":"https://api.github.com/users/DaveWise2/orgs","repos_url":"https://api.github.com/users/DaveWise2/repos","events_url":"https://api.github.com/users/DaveWise2/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWise2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-09T16:56:38Z","updated_at":"2017-06-13T16:13:32Z","closed_at":null,"body":"<!--- If you find problems or have suggestions relating to any simulator or the simh package as a whole, this is the right place to describe the problem you're having or the suggestion you wish to make: -->\r\n<!--- NOTE: Anything between the comment delimiters that start and end this line are merely instructions to you.  They will not be visible when the issue is created.  You may remove these comments as you enter information here -->\r\n\r\n<!--- Note that the text you enter into this comment box will be interpreted as 'markdown' text.  To best leverage this you may want to tag system output and some other text as 'code' (you can click on the \"styling with Markdown\" link below this text box for details about markdown).  Click on the Preview tab to see how the markdown message will be displayed.-->\r\n\r\nIt would be nice if the message printed when you interrupt deferred IO contained the instruction, like other SIMH halts.\r\n\r\n<!--- Please provide the following details: -->\r\n<!--- Provide a general summary of the issue in the Title above -->\r\n- #### Context\r\n<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug or why the suggested change or enhancement would be useful -->\r\n\r\nI think I have it working.  Here are code snippets, with a little bit of context.\r\n\r\ni1620_defs.h\r\n~~~\r\n#define STOP_FPDVZ      39                              /* divide by zero */\r\n#define STOP_IOINP      40                              /* **NEW** IO in progress */\r\n~~~\r\ni1620_sys.c\r\n~~~\r\nconst char *sim_stop_messages[] = {\r\n    \"Unknown error\",\r\n   ...   /* more messages */\r\n    \"Floating point divide by zero\",\r\n    \"IO in progress\",                                   /* **NEW**, corresponds to STOP_IOINP */\r\n    };\r\n~~~\r\ni1620_cpu.c\r\n~~~\r\nif (cpuio_inp != 0)                                     /* flag IO in progress */\r\n    {                                                   /* **NEW BLOCK**, replaces sim_printf() */\r\n    saved_PC = ADDR_S(saved_PC, INST_LEN);              /* back up to IO instr */\r\n    run_cmd_message(NULL, STOP_IOINP);\r\n    saved_PC = ADDR_A(saved_PC, INST_LEN);              /* restore */\r\n    }\r\n~~~\r\n\r\n- #### the output of \"sim> SHOW VERSION\" while running the simulator which is having the issue\r\n\r\nIBM 1620 simulator V4.0-0 Beta        git commit id: c389573c\r\nsim> show ver\r\nIBM 1620 simulator V4.0-0 Beta\r\n    Simulator Framework Capabilities:\r\n        32b data\r\n        32b addresses\r\n        no Ethernet\r\n        Idle/Throttling support is available\r\n        Virtual Hard Disk (VHD) support\r\n        RAW disk and CD/DVD ROM support\r\n        FrontPanel API Version 4\r\n    Host Platform:\r\n        Compiler: Microsoft Visual C++ 18.00.40629.00\r\n        Simulator Compiled as C arch: x86 (Debug Build) on Jun  7 2017 at 09:30:\r\n16\r\n        Memory Access: Little Endian\r\n        Memory Pointer Size: 32 bits\r\n        Large File (>2GB) support\r\n        SDL Video support: No Video Support\r\n        PCRE RegEx support for EXPECT commands\r\n        OS clock resolution: 1ms\r\n        Time taken by msleep(1): 1ms\r\n        OS: Microsoft Windows [Version 6.1.7601]\r\n        Architecture: x86 on AMD64, Processors: 36\r\n        Processor Id: Intel64 Family 6 Model 63 Stepping 2, GenuineIntel, Level:\r\n 6, Revision: 3f02\r\n        git commit id: c389573c\r\nsim>\r\n- #### how you built the simulator or that you're using prebuilt binaries\r\n<!--- This should include the output produced by while building just the simulator that is exhibiting the problem  -->\r\n\r\nLocal build, using Microsoft Visual Studio 2013.\r\n\r\n- #### the simulator configuration file (or commands) which were used when the problem occurred.\r\n<!--- The simulator configuration file, and any other relatively small files can be attached to this issue now or after it is created -->\r\n\r\n- #### the expected behavior and the actual behavior\r\n<!--- Please provide the output the simulator produced when you experienced the problem -->\r\n\r\nCurrent (stock) behavior:\r\n~~~\r\nsim> d 0 dnty 0\r\nsim> set throttle 50/10\r\nsim> g 0\r\n35000000010048000000000000000000000000000000000000000000000000000000000000000000\r\n0000000000000000\r\n/* ^E pressed */\r\nIO in progress\r\nSimulation stopped, PC: 12 (H   )\r\nsim>\r\n~~~\r\n\r\nDesired behavior (what I get with the modifications above):\r\n~~~\r\nsim> d 0 dnty 0\r\nsim> set throttle 50/10\r\nsim> g 0\r\n35000000010048000000000000000000000000000000000000000000000000000000000000000000\r\n0000000000000000000000000000000010\r\n/* ^E pressed */\r\nIO in progress, PC: 0 (DNTY 00000)\r\nSimulation stopped, PC: 12 (H   )\r\nsim>\r\n~~~\r\n\r\n- #### you may also need to provide specific pointers to data files that may be necessary to demonstrate the problem\r\n\r\n<!--- If you haven't already, please be sure that your full name is visible in your Github profile (no email address is needed) -->\r\n"},"comment":{"url":"https://api.github.com/repos/simh/simh/issues/comments/308168905","html_url":"https://github.com/simh/simh/issues/470#issuecomment-308168905","issue_url":"https://api.github.com/repos/simh/simh/issues/470","id":308168905,"user":{"login":"DaveWise2","id":20525311,"avatar_url":"https://avatars2.githubusercontent.com/u/20525311?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveWise2","html_url":"https://github.com/DaveWise2","followers_url":"https://api.github.com/users/DaveWise2/followers","following_url":"https://api.github.com/users/DaveWise2/following{/other_user}","gists_url":"https://api.github.com/users/DaveWise2/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWise2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWise2/subscriptions","organizations_url":"https://api.github.com/users/DaveWise2/orgs","repos_url":"https://api.github.com/users/DaveWise2/repos","events_url":"https://api.github.com/users/DaveWise2/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWise2/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T16:13:31Z","updated_at":"2017-06-13T16:13:31Z","body":"How about fprint_stopped?"}}
{"actor":{"display_login":"DaveWise2"}}