{"action":"created","issue":{"url":"https://api.github.com/repos/lxde/qtermwidget/issues/143","repository_url":"https://api.github.com/repos/lxde/qtermwidget","labels_url":"https://api.github.com/repos/lxde/qtermwidget/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/lxde/qtermwidget/issues/143/comments","events_url":"https://api.github.com/repos/lxde/qtermwidget/issues/143/events","html_url":"https://github.com/lxde/qtermwidget/pull/143","id":268097396,"number":143,"title":"Check if utempter.h header exists (mainly for FreeBSD)","user":{"login":"OlivierDuchateau","id":22723119,"avatar_url":"https://avatars2.githubusercontent.com/u/22723119?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierDuchateau","html_url":"https://github.com/OlivierDuchateau","followers_url":"https://api.github.com/users/OlivierDuchateau/followers","following_url":"https://api.github.com/users/OlivierDuchateau/following{/other_user}","gists_url":"https://api.github.com/users/OlivierDuchateau/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierDuchateau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierDuchateau/subscriptions","organizations_url":"https://api.github.com/users/OlivierDuchateau/orgs","repos_url":"https://api.github.com/users/OlivierDuchateau/repos","events_url":"https://api.github.com/users/OlivierDuchateau/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierDuchateau/received_events","type":"User","site_admin":false},"labels":[{"id":590957286,"url":"https://api.github.com/repos/lxde/qtermwidget/labels/konsole-need-fix-too","name":"konsole-need-fix-too","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-24T16:20:17Z","updated_at":"2017-10-25T18:53:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lxde/qtermwidget/pulls/143","html_url":"https://github.com/lxde/qtermwidget/pull/143","diff_url":"https://github.com/lxde/qtermwidget/pull/143.diff","patch_url":"https://github.com/lxde/qtermwidget/pull/143.patch"},"body":"Check utempter.h header in CMakeLists.txt (it's only for FreeBSD users, others BSD do not have this file). There is already conditionnal test in [lib/kpty.cpp](https://github.com/lxde/qtermwidget/blob/master/lib/kpty.cpp#L82), but not in CMakeList.txt.\r\n\r\nIt avoid to use CFLAGS (for compilation stage). I used CheckIncludeFile macro, because if I test a function (e.g., addToUtmp which is present in this header) test fails."},"comment":{"url":"https://api.github.com/repos/lxde/qtermwidget/issues/comments/339433770","html_url":"https://github.com/lxde/qtermwidget/pull/143#issuecomment-339433770","issue_url":"https://api.github.com/repos/lxde/qtermwidget/issues/143","id":339433770,"user":{"login":"OlivierDuchateau","id":22723119,"avatar_url":"https://avatars2.githubusercontent.com/u/22723119?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierDuchateau","html_url":"https://github.com/OlivierDuchateau","followers_url":"https://api.github.com/users/OlivierDuchateau/followers","following_url":"https://api.github.com/users/OlivierDuchateau/following{/other_user}","gists_url":"https://api.github.com/users/OlivierDuchateau/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierDuchateau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierDuchateau/subscriptions","organizations_url":"https://api.github.com/users/OlivierDuchateau/orgs","repos_url":"https://api.github.com/users/OlivierDuchateau/repos","events_url":"https://api.github.com/users/OlivierDuchateau/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierDuchateau/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T18:53:13Z","updated_at":"2017-10-25T18:53:13Z","author_association":"NONE","body":"On FreeBSD it's libulog (-lulog) see the [man page](https://www.freebsd.org/cgi/man.cgi?query=addToUtmp&manpath=FreeBSD+11.1-RELEASE+and+Ports)"}}
{"actor":{"display_login":"OlivierDuchateau"}}