{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress/issues/146","repository_url":"https://api.github.com/repos/kubernetes/ingress","labels_url":"https://api.github.com/repos/kubernetes/ingress/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress/issues/146/comments","events_url":"https://api.github.com/repos/kubernetes/ingress/issues/146/events","html_url":"https://github.com/kubernetes/ingress/pull/146","id":202054131,"number":146,"title":"Add health checking from NGINX to individual endpoints.","user":{"login":"chrismoos","id":175192,"avatar_url":"https://avatars4.githubusercontent.com/u/175192?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismoos","html_url":"https://github.com/chrismoos","followers_url":"https://api.github.com/users/chrismoos/followers","following_url":"https://api.github.com/users/chrismoos/following{/other_user}","gists_url":"https://api.github.com/users/chrismoos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismoos/subscriptions","organizations_url":"https://api.github.com/users/chrismoos/orgs","repos_url":"https://api.github.com/users/chrismoos/repos","events_url":"https://api.github.com/users/chrismoos/events{/privacy}","received_events_url":"https://api.github.com/users/chrismoos/received_events","type":"User","site_admin":false},"labels":[{"id":486873161,"url":"https://api.github.com/repos/kubernetes/ingress/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"aledbf","id":161571,"avatar_url":"https://avatars6.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"assignees":[{"login":"aledbf","id":161571,"avatar_url":"https://avatars6.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars6.githubusercontent.com/u/10927820?v=4","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-01-20T05:26:34Z","updated_at":"2017-07-16T20:28:55Z","closed_at":"2017-07-16T20:28:55Z","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress/pulls/146","html_url":"https://github.com/kubernetes/ingress/pull/146","diff_url":"https://github.com/kubernetes/ingress/pull/146.diff","patch_url":"https://github.com/kubernetes/ingress/pull/146.patch"},"body":"## Overview\r\n\r\nThis change adds support for the [nginx_upstream_check_module](https://github.com/yaoweibin/nginx_upstream_check_module) and configures upstreams with health checks based on the readinessProbe in the service's pod(s).\r\n\r\nIt is configurable with ConfigMap (default disabled):\r\n\r\n`use-upstream-health-checks`\r\n\r\nIf the upstream health checking is enabled there is also an additional endpoint at /upstream_status.\r\n\r\n## Notes\r\n\r\nThis was originally proposed in the old NGINX ingress controller @ https://github.com/kubernetes/contrib/pull/2072\r\n\r\nThis change depends on a new `nginx-slim` image that would target version **0.13**. The PR for that is https://github.com/kubernetes/contrib/pull/2329\r\n\r\nA request for this was also raised in #140."},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress/issues/comments/315634884","html_url":"https://github.com/kubernetes/ingress/pull/146#issuecomment-315634884","issue_url":"https://api.github.com/repos/kubernetes/ingress/issues/146","id":315634884,"user":{"login":"chrismoos","id":175192,"avatar_url":"https://avatars4.githubusercontent.com/u/175192?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismoos","html_url":"https://github.com/chrismoos","followers_url":"https://api.github.com/users/chrismoos/followers","following_url":"https://api.github.com/users/chrismoos/following{/other_user}","gists_url":"https://api.github.com/users/chrismoos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismoos/subscriptions","organizations_url":"https://api.github.com/users/chrismoos/orgs","repos_url":"https://api.github.com/users/chrismoos/repos","events_url":"https://api.github.com/users/chrismoos/events{/privacy}","received_events_url":"https://api.github.com/users/chrismoos/received_events","type":"User","site_admin":false},"created_at":"2017-07-16T20:28:55Z","updated_at":"2017-07-16T20:28:55Z","body":"See #981, this is probably preferable to this as unfortunately this duplicates the `readinessProbe` checking already built into Kubernetes."}}
{"actor":{"display_login":"chrismoos"}}