{"action":"created","issue":{"url":"https://api.github.com/repos/go-ldap/ldap/issues/104","repository_url":"https://api.github.com/repos/go-ldap/ldap","labels_url":"https://api.github.com/repos/go-ldap/ldap/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/go-ldap/ldap/issues/104/comments","events_url":"https://api.github.com/repos/go-ldap/ldap/issues/104/events","html_url":"https://github.com/go-ldap/ldap/pull/104","id":206391793,"number":104,"title":"Add `String()` methods to `DN` and its subtypes","user":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-02-09T03:10:58Z","updated_at":"2017-02-13T19:59:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/go-ldap/ldap/pulls/104","html_url":"https://github.com/go-ldap/ldap/pull/104","diff_url":"https://github.com/go-ldap/ldap/pull/104.diff","patch_url":"https://github.com/go-ldap/ldap/pull/104.patch"},"body":"This patch adds `String() string` methods to each of the following types:\r\n\r\n- DN\r\n- RelativeDN\r\n- AttributeTypeAndValue\r\n\r\nSo that a `*DN` implements the `fmt.Stringer` interface. These methods also\r\nproduce normalized strings: Attribute Type and Value are lowercased and joined\r\nwith a \"=\" character while multiple attributes of a Relative DN are sorted\r\nlexicographically before being joined witha \"+\" character.\r\n\r\nThis allows one to use the string representation of a DN as a map key and\r\nensure that two DNs which `Equal()` eachother would have the same `String()`\r\nvalue."},"comment":{"url":"https://api.github.com/repos/go-ldap/ldap/issues/comments/279504913","html_url":"https://github.com/go-ldap/ldap/pull/104#issuecomment-279504913","issue_url":"https://api.github.com/repos/go-ldap/ldap/issues/104","id":279504913,"user":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T19:59:27Z","updated_at":"2017-02-13T19:59:27Z","body":"I'm also not sure if the existing `(*AttributeTypeAndValue) Equal(other *AttributeTypeAndValue) bool` method is correct since it always considers the value to be case-sensitive. I guess, strictly, it depends on the attribute type and whether the schema description for that type specifies that the value is case sensitive. DNs are typically always case insensitive though aren't they?"}}
{"actor":{"display_login":"jlhawn"}}