{"action":"created","comment":{"url":"https://api.github.com/repos/zmap/zlint/pulls/comments/134542915","pull_request_review_id":57846664,"id":134542915,"diff_hunk":"@@ -28,11 +29,12 @@ func (l *subCaIssuerUrl) CheckApplies(c *x509.Certificate) bool {\n }\n \n func (l *subCaIssuerUrl) RunTest(c *x509.Certificate) (ResultStruct, error) {\n-\tif c.IssuingCertificateURL != nil {\n-\t\treturn ResultStruct{Result: Pass}, nil\n-\t} else {\n-\t\treturn ResultStruct{Result: Warn}, nil\n+\tfor _, url := range c.IssuingCertificateURL {\n+\t\tif strings.Contains(url, \"http://\") {","path":"lints/lint_sub_ca_aia_does_not_contain_issuing_ca_url.go","position":17,"original_position":17,"commit_id":"a9b1959cd9bf6bdeecf64de72f63ecaf05f06820","original_commit_id":"a9b1959cd9bf6bdeecf64de72f63ecaf05f06820","user":{"login":"titanous","id":13026,"avatar_url":"https://avatars1.githubusercontent.com/u/13026?v=4","gravatar_id":"","url":"https://api.github.com/users/titanous","html_url":"https://github.com/titanous","followers_url":"https://api.github.com/users/titanous/followers","following_url":"https://api.github.com/users/titanous/following{/other_user}","gists_url":"https://api.github.com/users/titanous/gists{/gist_id}","starred_url":"https://api.github.com/users/titanous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titanous/subscriptions","organizations_url":"https://api.github.com/users/titanous/orgs","repos_url":"https://api.github.com/users/titanous/repos","events_url":"https://api.github.com/users/titanous/events{/privacy}","received_events_url":"https://api.github.com/users/titanous/received_events","type":"User","site_admin":false},"body":"This and the rest should be `strings.HasPrefix`.","created_at":"2017-08-22T17:06:50Z","updated_at":"2017-08-22T17:07:08Z","html_url":"https://github.com/zmap/zlint/pull/96#discussion_r134542915","pull_request_url":"https://api.github.com/repos/zmap/zlint/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/zmap/zlint/pulls/comments/134542915"},"html":{"href":"https://github.com/zmap/zlint/pull/96#discussion_r134542915"},"pull_request":{"href":"https://api.github.com/repos/zmap/zlint/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/zmap/zlint/pulls/96","id":137032412,"html_url":"https://github.com/zmap/zlint/pull/96","diff_url":"https://github.com/zmap/zlint/pull/96.diff","patch_url":"https://github.com/zmap/zlint/pull/96.patch","issue_url":"https://api.github.com/repos/zmap/zlint/issues/96","number":96,"state":"open","locked":false,"title":"Check if HTTP URL is inside AIA/CRL URLs.","user":{"login":"kumarde","id":3020845,"avatar_url":"https://avatars1.githubusercontent.com/u/3020845?v=4","gravatar_id":"","url":"https://api.github.com/users/kumarde","html_url":"https://github.com/kumarde","followers_url":"https://api.github.com/users/kumarde/followers","following_url":"https://api.github.com/users/kumarde/following{/other_user}","gists_url":"https://api.github.com/users/kumarde/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarde/subscriptions","organizations_url":"https://api.github.com/users/kumarde/orgs","repos_url":"https://api.github.com/users/kumarde/repos","events_url":"https://api.github.com/users/kumarde/events{/privacy}","received_events_url":"https://api.github.com/users/kumarde/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-22T17:06:07Z","updated_at":"2017-08-22T17:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e73d0f53b8a415f143586d4a2380001300fc28a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zmap/zlint/pulls/96/commits","review_comments_url":"https://api.github.com/repos/zmap/zlint/pulls/96/comments","review_comment_url":"https://api.github.com/repos/zmap/zlint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zmap/zlint/issues/96/comments","statuses_url":"https://api.github.com/repos/zmap/zlint/statuses/a9b1959cd9bf6bdeecf64de72f63ecaf05f06820","head":{"label":"zmap:kumarde/update_http_bug","ref":"kumarde/update_http_bug","sha":"a9b1959cd9bf6bdeecf64de72f63ecaf05f06820","user":{"login":"zmap","id":3345672,"avatar_url":"https://avatars3.githubusercontent.com/u/3345672?v=4","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"repo":{"id":75216133,"name":"zlint","full_name":"zmap/zlint","owner":{"login":"zmap","id":3345672,"avatar_url":"https://avatars3.githubusercontent.com/u/3345672?v=4","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zmap/zlint","description":"Certificate Lints","fork":false,"url":"https://api.github.com/repos/zmap/zlint","forks_url":"https://api.github.com/repos/zmap/zlint/forks","keys_url":"https://api.github.com/repos/zmap/zlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmap/zlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmap/zlint/teams","hooks_url":"https://api.github.com/repos/zmap/zlint/hooks","issue_events_url":"https://api.github.com/repos/zmap/zlint/issues/events{/number}","events_url":"https://api.github.com/repos/zmap/zlint/events","assignees_url":"https://api.github.com/repos/zmap/zlint/assignees{/user}","branches_url":"https://api.github.com/repos/zmap/zlint/branches{/branch}","tags_url":"https://api.github.com/repos/zmap/zlint/tags","blobs_url":"https://api.github.com/repos/zmap/zlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmap/zlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmap/zlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmap/zlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmap/zlint/statuses/{sha}","languages_url":"https://api.github.com/repos/zmap/zlint/languages","stargazers_url":"https://api.github.com/repos/zmap/zlint/stargazers","contributors_url":"https://api.github.com/repos/zmap/zlint/contributors","subscribers_url":"https://api.github.com/repos/zmap/zlint/subscribers","subscription_url":"https://api.github.com/repos/zmap/zlint/subscription","commits_url":"https://api.github.com/repos/zmap/zlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmap/zlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmap/zlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmap/zlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmap/zlint/contents/{+path}","compare_url":"https://api.github.com/repos/zmap/zlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmap/zlint/merges","archive_url":"https://api.github.com/repos/zmap/zlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmap/zlint/downloads","issues_url":"https://api.github.com/repos/zmap/zlint/issues{/number}","pulls_url":"https://api.github.com/repos/zmap/zlint/pulls{/number}","milestones_url":"https://api.github.com/repos/zmap/zlint/milestones{/number}","notifications_url":"https://api.github.com/repos/zmap/zlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmap/zlint/labels{/name}","releases_url":"https://api.github.com/repos/zmap/zlint/releases{/id}","deployments_url":"https://api.github.com/repos/zmap/zlint/deployments","created_at":"2016-11-30T18:42:16Z","updated_at":"2017-08-22T08:09:14Z","pushed_at":"2017-08-22T17:06:08Z","git_url":"git://github.com/zmap/zlint.git","ssh_url":"git@github.com:zmap/zlint.git","clone_url":"https://github.com/zmap/zlint.git","svn_url":"https://github.com/zmap/zlint","homepage":"","size":2061,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":6,"default_branch":"master"}},"base":{"label":"zmap:master","ref":"master","sha":"b60d4bfd02b0347ba710bd59a46290153cf42473","user":{"login":"zmap","id":3345672,"avatar_url":"https://avatars3.githubusercontent.com/u/3345672?v=4","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"repo":{"id":75216133,"name":"zlint","full_name":"zmap/zlint","owner":{"login":"zmap","id":3345672,"avatar_url":"https://avatars3.githubusercontent.com/u/3345672?v=4","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zmap/zlint","description":"Certificate Lints","fork":false,"url":"https://api.github.com/repos/zmap/zlint","forks_url":"https://api.github.com/repos/zmap/zlint/forks","keys_url":"https://api.github.com/repos/zmap/zlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmap/zlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmap/zlint/teams","hooks_url":"https://api.github.com/repos/zmap/zlint/hooks","issue_events_url":"https://api.github.com/repos/zmap/zlint/issues/events{/number}","events_url":"https://api.github.com/repos/zmap/zlint/events","assignees_url":"https://api.github.com/repos/zmap/zlint/assignees{/user}","branches_url":"https://api.github.com/repos/zmap/zlint/branches{/branch}","tags_url":"https://api.github.com/repos/zmap/zlint/tags","blobs_url":"https://api.github.com/repos/zmap/zlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmap/zlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmap/zlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmap/zlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmap/zlint/statuses/{sha}","languages_url":"https://api.github.com/repos/zmap/zlint/languages","stargazers_url":"https://api.github.com/repos/zmap/zlint/stargazers","contributors_url":"https://api.github.com/repos/zmap/zlint/contributors","subscribers_url":"https://api.github.com/repos/zmap/zlint/subscribers","subscription_url":"https://api.github.com/repos/zmap/zlint/subscription","commits_url":"https://api.github.com/repos/zmap/zlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmap/zlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmap/zlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmap/zlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmap/zlint/contents/{+path}","compare_url":"https://api.github.com/repos/zmap/zlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmap/zlint/merges","archive_url":"https://api.github.com/repos/zmap/zlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmap/zlint/downloads","issues_url":"https://api.github.com/repos/zmap/zlint/issues{/number}","pulls_url":"https://api.github.com/repos/zmap/zlint/pulls{/number}","milestones_url":"https://api.github.com/repos/zmap/zlint/milestones{/number}","notifications_url":"https://api.github.com/repos/zmap/zlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmap/zlint/labels{/name}","releases_url":"https://api.github.com/repos/zmap/zlint/releases{/id}","deployments_url":"https://api.github.com/repos/zmap/zlint/deployments","created_at":"2016-11-30T18:42:16Z","updated_at":"2017-08-22T08:09:14Z","pushed_at":"2017-08-22T17:06:08Z","git_url":"git://github.com/zmap/zlint.git","ssh_url":"git@github.com:zmap/zlint.git","clone_url":"https://github.com/zmap/zlint.git","svn_url":"https://github.com/zmap/zlint","homepage":"","size":2061,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zmap/zlint/pulls/96"},"html":{"href":"https://github.com/zmap/zlint/pull/96"},"issue":{"href":"https://api.github.com/repos/zmap/zlint/issues/96"},"comments":{"href":"https://api.github.com/repos/zmap/zlint/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/zmap/zlint/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/zmap/zlint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zmap/zlint/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/zmap/zlint/statuses/a9b1959cd9bf6bdeecf64de72f63ecaf05f06820"}}}}
{"actor":{"display_login":"titanous"}}