{"action":"created","comment":{"url":"https://api.github.com/repos/Igalia/chromium/pulls/comments/111131728","pull_request_review_id":32353910,"id":111131728,"diff_hunk":"@@ -76,11 +76,15 @@ void PlatformDisplayDefault::Init(PlatformDisplayDelegate* delegate) {\n   NOTREACHED() << \"Unsupported platform\";\n #endif\n \n-  platform_window_->Show();\n   if (image_cursors_) {\n     image_cursors_->SetDisplay(delegate_->GetDisplay(),\n                                metrics_.device_scale_factor);\n   }\n+  // Show() must be called only after |image_cursors_| has created a\n+  // a cursor loader after display is sent to it. Otherwise, Show()\n+  // triggers a delegate call to OnBoundsChanged(), which end up to\n+  // changing cursor location for not existing cursor loader.\n+  platform_window_->Show();","path":"services/ui/ws/platform_display_default.cc","position":13,"original_position":13,"commit_id":"eff58bf25e333021a356b8722075e4a9c281f663","original_commit_id":"eff58bf25e333021a356b8722075e4a9c281f663","user":{"login":"msisov","id":5306904,"avatar_url":"https://avatars1.githubusercontent.com/u/5306904?v=3","gravatar_id":"","url":"https://api.github.com/users/msisov","html_url":"https://github.com/msisov","followers_url":"https://api.github.com/users/msisov/followers","following_url":"https://api.github.com/users/msisov/following{/other_user}","gists_url":"https://api.github.com/users/msisov/gists{/gist_id}","starred_url":"https://api.github.com/users/msisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msisov/subscriptions","organizations_url":"https://api.github.com/users/msisov/orgs","repos_url":"https://api.github.com/users/msisov/repos","events_url":"https://api.github.com/users/msisov/events{/privacy}","received_events_url":"https://api.github.com/users/msisov/received_events","type":"User","site_admin":false},"body":"It shouldn't as long as according to your backtrace there is some another problem with ui::OSExchangeData::SetString(). In my case, it was that image_cursors_ tried to access its cursor_loader_, which is created only after SetDisplay is called.","created_at":"2017-04-12T12:09:32Z","updated_at":"2017-04-12T12:09:32Z","html_url":"https://github.com/Igalia/chromium/pull/44#discussion_r111131728","pull_request_url":"https://api.github.com/repos/Igalia/chromium/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/comments/111131728"},"html":{"href":"https://github.com/Igalia/chromium/pull/44#discussion_r111131728"},"pull_request":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/Igalia/chromium/pulls/44","id":115517901,"html_url":"https://github.com/Igalia/chromium/pull/44","diff_url":"https://github.com/Igalia/chromium/pull/44.diff","patch_url":"https://github.com/Igalia/chromium/pull/44.patch","issue_url":"https://api.github.com/repos/Igalia/chromium/issues/44","number":44,"state":"open","locked":false,"title":"Fix menu windows placement, when root window (main chrome window) is moved or resized.","user":{"login":"msisov","id":5306904,"avatar_url":"https://avatars1.githubusercontent.com/u/5306904?v=3","gravatar_id":"","url":"https://api.github.com/users/msisov","html_url":"https://github.com/msisov","followers_url":"https://api.github.com/users/msisov/followers","following_url":"https://api.github.com/users/msisov/following{/other_user}","gists_url":"https://api.github.com/users/msisov/gists{/gist_id}","starred_url":"https://api.github.com/users/msisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msisov/subscriptions","organizations_url":"https://api.github.com/users/msisov/orgs","repos_url":"https://api.github.com/users/msisov/repos","events_url":"https://api.github.com/users/msisov/events{/privacy}","received_events_url":"https://api.github.com/users/msisov/received_events","type":"User","site_admin":false},"body":"More or less, this commit is mostly about proper handling of changed\r\nbounds sent from window manager. Additional methods were implemented in\r\norder to make it possible to send bounds to StubWindow, which is used by\r\nother windows as a reference for their bounds. But, the main point here\r\nis that server_window, which is root_ in ui::ws::Display, must not\r\nchange its origin as long as its origin is relative to the\r\nX11WindowOzone rather than to a real screen.","created_at":"2017-04-12T11:12:03Z","updated_at":"2017-04-12T12:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28f750087eb0d65794865cd2a10c67feb9e338b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Igalia/chromium/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Igalia/chromium/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Igalia/chromium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Igalia/chromium/issues/44/comments","statuses_url":"https://api.github.com/repos/Igalia/chromium/statuses/eff58bf25e333021a356b8722075e4a9c281f663","head":{"label":"msisov:ozone-wayland-dev","ref":"ozone-wayland-dev","sha":"eff58bf25e333021a356b8722075e4a9c281f663","user":{"login":"msisov","id":5306904,"avatar_url":"https://avatars1.githubusercontent.com/u/5306904?v=3","gravatar_id":"","url":"https://api.github.com/users/msisov","html_url":"https://github.com/msisov","followers_url":"https://api.github.com/users/msisov/followers","following_url":"https://api.github.com/users/msisov/following{/other_user}","gists_url":"https://api.github.com/users/msisov/gists{/gist_id}","starred_url":"https://api.github.com/users/msisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msisov/subscriptions","organizations_url":"https://api.github.com/users/msisov/orgs","repos_url":"https://api.github.com/users/msisov/repos","events_url":"https://api.github.com/users/msisov/events{/privacy}","received_events_url":"https://api.github.com/users/msisov/received_events","type":"User","site_admin":false},"repo":{"id":85793876,"name":"chromium","full_name":"msisov/chromium","owner":{"login":"msisov","id":5306904,"avatar_url":"https://avatars1.githubusercontent.com/u/5306904?v=3","gravatar_id":"","url":"https://api.github.com/users/msisov","html_url":"https://github.com/msisov","followers_url":"https://api.github.com/users/msisov/followers","following_url":"https://api.github.com/users/msisov/following{/other_user}","gists_url":"https://api.github.com/users/msisov/gists{/gist_id}","starred_url":"https://api.github.com/users/msisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msisov/subscriptions","organizations_url":"https://api.github.com/users/msisov/orgs","repos_url":"https://api.github.com/users/msisov/repos","events_url":"https://api.github.com/users/msisov/events{/privacy}","received_events_url":"https://api.github.com/users/msisov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msisov/chromium","description":"Chromium mirror","fork":true,"url":"https://api.github.com/repos/msisov/chromium","forks_url":"https://api.github.com/repos/msisov/chromium/forks","keys_url":"https://api.github.com/repos/msisov/chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msisov/chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msisov/chromium/teams","hooks_url":"https://api.github.com/repos/msisov/chromium/hooks","issue_events_url":"https://api.github.com/repos/msisov/chromium/issues/events{/number}","events_url":"https://api.github.com/repos/msisov/chromium/events","assignees_url":"https://api.github.com/repos/msisov/chromium/assignees{/user}","branches_url":"https://api.github.com/repos/msisov/chromium/branches{/branch}","tags_url":"https://api.github.com/repos/msisov/chromium/tags","blobs_url":"https://api.github.com/repos/msisov/chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msisov/chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msisov/chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/msisov/chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msisov/chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/msisov/chromium/languages","stargazers_url":"https://api.github.com/repos/msisov/chromium/stargazers","contributors_url":"https://api.github.com/repos/msisov/chromium/contributors","subscribers_url":"https://api.github.com/repos/msisov/chromium/subscribers","subscription_url":"https://api.github.com/repos/msisov/chromium/subscription","commits_url":"https://api.github.com/repos/msisov/chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/msisov/chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/msisov/chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/msisov/chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/msisov/chromium/contents/{+path}","compare_url":"https://api.github.com/repos/msisov/chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msisov/chromium/merges","archive_url":"https://api.github.com/repos/msisov/chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msisov/chromium/downloads","issues_url":"https://api.github.com/repos/msisov/chromium/issues{/number}","pulls_url":"https://api.github.com/repos/msisov/chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/msisov/chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/msisov/chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msisov/chromium/labels{/name}","releases_url":"https://api.github.com/repos/msisov/chromium/releases{/id}","deployments_url":"https://api.github.com/repos/msisov/chromium/deployments","created_at":"2017-03-22T06:42:41Z","updated_at":"2017-03-21T15:49:58Z","pushed_at":"2017-04-12T11:15:28Z","git_url":"git://github.com/msisov/chromium.git","ssh_url":"git@github.com:msisov/chromium.git","clone_url":"https://github.com/msisov/chromium.git","svn_url":"https://github.com/msisov/chromium","homepage":"https://chromium.googlesource.com/chromium/src.git","size":6761176,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Igalia:ozone-wayland-dev","ref":"ozone-wayland-dev","sha":"ee2b87252f65d1572cf8f9697ee4305a0fd99cc4","user":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars0.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":85595633,"name":"chromium","full_name":"Igalia/chromium","owner":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars0.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Igalia/chromium","description":"Development branch of Chromium for Wayland","fork":true,"url":"https://api.github.com/repos/Igalia/chromium","forks_url":"https://api.github.com/repos/Igalia/chromium/forks","keys_url":"https://api.github.com/repos/Igalia/chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/chromium/teams","hooks_url":"https://api.github.com/repos/Igalia/chromium/hooks","issue_events_url":"https://api.github.com/repos/Igalia/chromium/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/chromium/events","assignees_url":"https://api.github.com/repos/Igalia/chromium/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/chromium/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/chromium/tags","blobs_url":"https://api.github.com/repos/Igalia/chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/chromium/languages","stargazers_url":"https://api.github.com/repos/Igalia/chromium/stargazers","contributors_url":"https://api.github.com/repos/Igalia/chromium/contributors","subscribers_url":"https://api.github.com/repos/Igalia/chromium/subscribers","subscription_url":"https://api.github.com/repos/Igalia/chromium/subscription","commits_url":"https://api.github.com/repos/Igalia/chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/chromium/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/chromium/merges","archive_url":"https://api.github.com/repos/Igalia/chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/chromium/downloads","issues_url":"https://api.github.com/repos/Igalia/chromium/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/chromium/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/chromium/releases{/id}","deployments_url":"https://api.github.com/repos/Igalia/chromium/deployments","created_at":"2017-03-20T15:45:36Z","updated_at":"2017-04-08T14:59:23Z","pushed_at":"2017-04-12T11:15:32Z","git_url":"git://github.com/Igalia/chromium.git","ssh_url":"git@github.com:Igalia/chromium.git","clone_url":"https://github.com/Igalia/chromium.git","svn_url":"https://github.com/Igalia/chromium","homepage":"https://chromium.googlesource.com/chromium/src.git","size":6787100,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/44"},"html":{"href":"https://github.com/Igalia/chromium/pull/44"},"issue":{"href":"https://api.github.com/repos/Igalia/chromium/issues/44"},"comments":{"href":"https://api.github.com/repos/Igalia/chromium/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Igalia/chromium/statuses/eff58bf25e333021a356b8722075e4a9c281f663"}}}}
{"actor":{"display_login":"msisov"}}