{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/125501155","pull_request_review_id":47895984,"id":125501155,"diff_hunk":"@@ -309,7 +309,7 @@ class SettingsPropertyFactory {\n \n extension SettingsPropertyFactory {\n     static var shared: SettingsPropertyFactory? {\n-        guard let session = ZMUserSession.shared() else {","path":"Wire-iOS/Sources/Components/Settings/SettingsPropertyFactory.swift","position":4,"original_position":4,"commit_id":"f43a302665ef6689f3b35ab59c5c385d4bfefc55","original_commit_id":"f43a302665ef6689f3b35ab59c5c385d4bfefc55","user":{"login":"mikeger","id":715129,"avatar_url":"https://avatars0.githubusercontent.com/u/715129?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"body":"We need to refactor the settings property creation, seems like an overkill to pass in all the arguments if you just want to create a property that works with user defaults.","created_at":"2017-07-04T15:47:53Z","updated_at":"2017-07-04T15:47:53Z","html_url":"https://github.com/wireapp/wire-ios/pull/1115#discussion_r125501155","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/125501155"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/1115#discussion_r125501155"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115","id":128813095,"html_url":"https://github.com/wireapp/wire-ios/pull/1115","diff_url":"https://github.com/wireapp/wire-ios/pull/1115.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/1115.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/1115","number":1115,"state":"open","locked":false,"title":"WIP: Disk storage-free registration","user":{"login":"vytis","id":33914,"avatar_url":"https://avatars1.githubusercontent.com/u/33914?v=3","gravatar_id":"","url":"https://api.github.com/users/vytis","html_url":"https://github.com/vytis","followers_url":"https://api.github.com/users/vytis/followers","following_url":"https://api.github.com/users/vytis/following{/other_user}","gists_url":"https://api.github.com/users/vytis/gists{/gist_id}","starred_url":"https://api.github.com/users/vytis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytis/subscriptions","organizations_url":"https://api.github.com/users/vytis/orgs","repos_url":"https://api.github.com/users/vytis/repos","events_url":"https://api.github.com/users/vytis/events{/privacy}","received_events_url":"https://api.github.com/users/vytis/received_events","type":"User","site_admin":false},"body":"## Reason behind this PR\r\n\r\nTo support multiple accounts we need to refactor our registration flow to avoid reading disk storage. The SyncEngine changes are tracked in https://github.com/wireapp/wire-ios-sync-engine/pull/438\r\n\r\n## What's in this PR\r\n\r\nWe had to split the initialization flow to use `ZMUserSession` only after it gets created. Registration and login view controllers use `UnauthenticatedSession`.\r\n\r\n## Dependencies\r\n\r\n- [ ] https://github.com/wireapp/wire-ios-sync-engine/pull/438\r\n- [ ] https://github.com/wireapp/wire-ios-data-model/pull/308\r\n- [ ] https://github.com/wireapp/wire-ios-transport/pull/43\r\n","created_at":"2017-07-04T14:18:17Z","updated_at":"2017-07-04T15:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62147e403d158c313549641420ca9adccfa170e7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/1115/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/f43a302665ef6689f3b35ab59c5c385d4bfefc55","head":{"label":"wireapp:feature/unauthenticated-session","ref":"feature/unauthenticated-session","sha":"f43a302665ef6689f3b35ab59c5c385d4bfefc55","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2017-07-03T09:06:56Z","pushed_at":"2017-07-04T15:08:41Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":130383,"stargazers_count":2006,"watchers_count":2006,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":312,"mirror_url":null,"open_issues_count":83,"forks":312,"open_issues":83,"watchers":2006,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"f16ba5dc03098da99be398979b04697af2e76ec9","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2017-07-03T09:06:56Z","pushed_at":"2017-07-04T15:08:41Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":130383,"stargazers_count":2006,"watchers_count":2006,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":312,"mirror_url":null,"open_issues_count":83,"forks":312,"open_issues":83,"watchers":2006,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/1115"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/1115"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/1115/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1115/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios/statuses/f43a302665ef6689f3b35ab59c5c385d4bfefc55"}}}}
{"actor":{"display_login":"mikeger"}}