{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/comments/141988751","pull_request_review_id":66294690,"id":141988751,"diff_hunk":"@@ -1,42 +1,18 @@\n package org.opentestsystem.rdw.ingest.migrate.reporting.repository.impl;\n \n+import org.opentestsystem.rdw.ingest.common.repository.JdbcSqlListExecutionRepository;\n import org.opentestsystem.rdw.ingest.common.repository.SqlListExecutionRepository;\n-import org.springframework.beans.factory.annotation.Autowired;\n import org.springframework.beans.factory.annotation.Qualifier;\n import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;\n import org.springframework.stereotype.Repository;\n-import org.springframework.transaction.annotation.Transactional;\n-\n-import java.util.Map;\n \n /**\n  * Jdbc implementation of {@link SqlListExecutionRepository} on the reporting datamart\n  */\n @Repository\n-class JdbcReportingSqlListExecutionRepository implements SqlListExecutionRepository {\n-\n-    @Autowired\n-    @Qualifier(\"reportingJdbcTemplate\")\n-    private NamedParameterJdbcTemplate jdbcTemplate;\n-\n-    @Transactional\n-    @Override\n-    public void execute(final Iterable<String> sqls) {\n-\n-        for (final String sql : sqls) {\n-            jdbcTemplate\n-                    .getJdbcOperations()\n-                    .execute(sql);\n-        }\n-    }\n-\n-    @Transactional\n-    @Override\n-    public void execute(final Iterable<String> sqls, final Map<String, ?> parameters) {\n+class JdbcReportingSqlListExecutionRepository extends JdbcSqlListExecutionRepository {","path":"migrate-reporting/src/main/java/org/opentestsystem/rdw/ingest/migrate/reporting/repository/impl/JdbcReportingSqlListExecutionRepository.java","position":37,"original_position":37,"commit_id":"adfd206ffb8b5732ee41f6e18770c9041d48e3b0","original_commit_id":"adfd206ffb8b5732ee41f6e18770c9041d48e3b0","user":{"login":"malaffoon","id":5097710,"avatar_url":"https://avatars0.githubusercontent.com/u/5097710?v=4","gravatar_id":"","url":"https://api.github.com/users/malaffoon","html_url":"https://github.com/malaffoon","followers_url":"https://api.github.com/users/malaffoon/followers","following_url":"https://api.github.com/users/malaffoon/following{/other_user}","gists_url":"https://api.github.com/users/malaffoon/gists{/gist_id}","starred_url":"https://api.github.com/users/malaffoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malaffoon/subscriptions","organizations_url":"https://api.github.com/users/malaffoon/orgs","repos_url":"https://api.github.com/users/malaffoon/repos","events_url":"https://api.github.com/users/malaffoon/events{/privacy}","received_events_url":"https://api.github.com/users/malaffoon/received_events","type":"User","site_admin":false},"body":"`ReportingSqlListExecutionRepository`?\r\n","created_at":"2017-09-29T23:46:04Z","updated_at":"2017-09-29T23:46:04Z","html_url":"https://github.com/SmarterApp/RDW_Ingest/pull/349#discussion_r141988751","pull_request_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/comments/141988751"},"html":{"href":"https://github.com/SmarterApp/RDW_Ingest/pull/349#discussion_r141988751"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349","id":144000550,"html_url":"https://github.com/SmarterApp/RDW_Ingest/pull/349","diff_url":"https://github.com/SmarterApp/RDW_Ingest/pull/349.diff","patch_url":"https://github.com/SmarterApp/RDW_Ingest/pull/349.patch","issue_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/349","number":349,"state":"open","locked":false,"title":"Clean up JdbcSqlListExecutionRepository.","user":{"login":"agorina","id":16457484,"avatar_url":"https://avatars2.githubusercontent.com/u/16457484?v=4","gravatar_id":"","url":"https://api.github.com/users/agorina","html_url":"https://github.com/agorina","followers_url":"https://api.github.com/users/agorina/followers","following_url":"https://api.github.com/users/agorina/following{/other_user}","gists_url":"https://api.github.com/users/agorina/gists{/gist_id}","starred_url":"https://api.github.com/users/agorina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agorina/subscriptions","organizations_url":"https://api.github.com/users/agorina/orgs","repos_url":"https://api.github.com/users/agorina/repos","events_url":"https://api.github.com/users/agorina/events{/privacy}","received_events_url":"https://api.github.com/users/agorina/received_events","type":"User","site_admin":false},"body":"There were two implementations that seemed almost identical.\r\nAnd I will most likely need another one for the aggregate reports migrate. So I have decided to clean it up.","created_at":"2017-09-29T23:41:34Z","updated_at":"2017-09-29T23:46:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc20c5b4ce8808e61bcc510a4272a93f60cdd6b1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wtritch","id":617828,"avatar_url":"https://avatars3.githubusercontent.com/u/617828?v=4","gravatar_id":"","url":"https://api.github.com/users/wtritch","html_url":"https://github.com/wtritch","followers_url":"https://api.github.com/users/wtritch/followers","following_url":"https://api.github.com/users/wtritch/following{/other_user}","gists_url":"https://api.github.com/users/wtritch/gists{/gist_id}","starred_url":"https://api.github.com/users/wtritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtritch/subscriptions","organizations_url":"https://api.github.com/users/wtritch/orgs","repos_url":"https://api.github.com/users/wtritch/repos","events_url":"https://api.github.com/users/wtritch/events{/privacy}","received_events_url":"https://api.github.com/users/wtritch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/349/comments","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/statuses/adfd206ffb8b5732ee41f6e18770c9041d48e3b0","head":{"label":"SmarterApp:feature/cleanup","ref":"feature/cleanup","sha":"adfd206ffb8b5732ee41f6e18770c9041d48e3b0","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81141193,"name":"RDW_Ingest","full_name":"SmarterApp/RDW_Ingest","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Ingest","description":"RDW ingest applications","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Ingest","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/deployments","created_at":"2017-02-06T22:41:51Z","updated_at":"2017-02-08T16:02:34Z","pushed_at":"2017-09-29T23:41:34Z","git_url":"git://github.com/SmarterApp/RDW_Ingest.git","ssh_url":"git@github.com:SmarterApp/RDW_Ingest.git","clone_url":"https://github.com/SmarterApp/RDW_Ingest.git","svn_url":"https://github.com/SmarterApp/RDW_Ingest","homepage":null,"size":2435,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"2a82c76d1e0dc53f40a98c5a99d3daa6560afc5a","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81141193,"name":"RDW_Ingest","full_name":"SmarterApp/RDW_Ingest","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Ingest","description":"RDW ingest applications","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Ingest","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Ingest/deployments","created_at":"2017-02-06T22:41:51Z","updated_at":"2017-02-08T16:02:34Z","pushed_at":"2017-09-29T23:41:34Z","git_url":"git://github.com/SmarterApp/RDW_Ingest.git","ssh_url":"git@github.com:SmarterApp/RDW_Ingest.git","clone_url":"https://github.com/SmarterApp/RDW_Ingest.git","svn_url":"https://github.com/SmarterApp/RDW_Ingest","homepage":null,"size":2435,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349"},"html":{"href":"https://github.com/SmarterApp/RDW_Ingest/pull/349"},"issue":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/349"},"comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/RDW_Ingest/statuses/adfd206ffb8b5732ee41f6e18770c9041d48e3b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"malaffoon"}}