{"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28","id":118346641,"html_url":"https://github.com/jgrancher/react-native-sketch/pull/28","diff_url":"https://github.com/jgrancher/react-native-sketch/pull/28.diff","patch_url":"https://github.com/jgrancher/react-native-sketch/pull/28.patch","issue_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/28","number":28,"state":"open","locked":false,"title":"v1.0","user":{"login":"jgrancher","id":5517450,"avatar_url":"https://avatars0.githubusercontent.com/u/5517450?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrancher","html_url":"https://github.com/jgrancher","followers_url":"https://api.github.com/users/jgrancher/followers","following_url":"https://api.github.com/users/jgrancher/following{/other_user}","gists_url":"https://api.github.com/users/jgrancher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrancher/subscriptions","organizations_url":"https://api.github.com/users/jgrancher/orgs","repos_url":"https://api.github.com/users/jgrancher/repos","events_url":"https://api.github.com/users/jgrancher/events{/privacy}","received_events_url":"https://api.github.com/users/jgrancher/received_events","type":"User","site_admin":false},"body":"This PR aims to gather few changes to prepare for `react-native-sketch@1.0.0`.\r\nThis is a major bump as few of the changes listed below are breaking changes.\r\nAlso, quite few methods and properties have been renamed, but the API won't change that much anymore, hopefully. 😇\r\n\r\n**REMOVED:**\r\n- [x] The `clearButtonHidden` property and the internal `_clearButton` view have been removed. This is because the `clear` method has now to be called from an outside component (that was the goal for a long time!).\r\n- [x] The `fillColor` property has been removed to give you a transparent background by default! If you want to give the drawing a `backgroundColor` property, you can set it in the `style` object property.\r\n\r\n**CHANGED:**\r\n- [x] React Native `>= 0.40` is now compatible out of the box. This is a breaking change for people using with in an older version of React Native (https://github.com/jgrancher/react-native-sketch/pull/20).\r\n- [x] The `imageType` property to export the drawing is now `png` by default, in order to keep transparency out of the box. You can still set it to `jpg` if you want.\r\n- [x] The `strokeColor` property has been renamed to `color`.\r\n- [x] The `strokeThickness` property has been renamed to `thickness`.\r\n- [x] The `onReset` event callback has been renamed to `onClear`.\r\n- [x] The `saveImage` method has been renamed to `save` *AND* doesn't require any argument anymore. We keep the state of the drawing in the bridge for you, so that you don't need to keep a reference of the encoded representation of the image on every change. The `onChange` still exists, and is still returning the base64 representation of the drawing, but you don't *have* to save it into your component's state in order to pass it to `save` later on.\r\n- [x] The two methods `clear` and `save` are now Promises, allowing you to type:\r\n\r\n```js\r\nthis.sketch.clear().then(() => console.log('Thanks for drawing with us.'));\r\nthis.sketch.save().then(path => console.log(`Here is your drawing image: ${path}`));\r\n```\r\n\r\n- [x] Code cleanup (from https://github.com/Thinkmill/react-native-sketch/commit/5bab7f21854aca53e85a9f3d21f98e9aaea3669f).\r\n- [ ] The `README.md` has been updated with more documentation.\r\n\r\n**ADDED:**\r\n- [ ] An `examples` folder has been created.\r\n\r\nLet me know your thoughts!\r\n","created_at":"2017-05-01T05:17:55Z","updated_at":"2017-05-01T05:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28/commits","review_comments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28/comments","review_comment_url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/28/comments","statuses_url":"https://api.github.com/repos/jgrancher/react-native-sketch/statuses/8a4d3a9ca6bf25c700d9f4a56d596a7934cb4357","head":{"label":"jgrancher:v1.0","ref":"v1.0","sha":"8a4d3a9ca6bf25c700d9f4a56d596a7934cb4357","user":{"login":"jgrancher","id":5517450,"avatar_url":"https://avatars0.githubusercontent.com/u/5517450?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrancher","html_url":"https://github.com/jgrancher","followers_url":"https://api.github.com/users/jgrancher/followers","following_url":"https://api.github.com/users/jgrancher/following{/other_user}","gists_url":"https://api.github.com/users/jgrancher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrancher/subscriptions","organizations_url":"https://api.github.com/users/jgrancher/orgs","repos_url":"https://api.github.com/users/jgrancher/repos","events_url":"https://api.github.com/users/jgrancher/events{/privacy}","received_events_url":"https://api.github.com/users/jgrancher/received_events","type":"User","site_admin":false},"repo":{"id":58460331,"name":"react-native-sketch","full_name":"jgrancher/react-native-sketch","owner":{"login":"jgrancher","id":5517450,"avatar_url":"https://avatars0.githubusercontent.com/u/5517450?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrancher","html_url":"https://github.com/jgrancher","followers_url":"https://api.github.com/users/jgrancher/followers","following_url":"https://api.github.com/users/jgrancher/following{/other_user}","gists_url":"https://api.github.com/users/jgrancher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrancher/subscriptions","organizations_url":"https://api.github.com/users/jgrancher/orgs","repos_url":"https://api.github.com/users/jgrancher/repos","events_url":"https://api.github.com/users/jgrancher/events{/privacy}","received_events_url":"https://api.github.com/users/jgrancher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgrancher/react-native-sketch","description":"A React Native <Sketch /> component for touch-based drawing.","fork":false,"url":"https://api.github.com/repos/jgrancher/react-native-sketch","forks_url":"https://api.github.com/repos/jgrancher/react-native-sketch/forks","keys_url":"https://api.github.com/repos/jgrancher/react-native-sketch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgrancher/react-native-sketch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgrancher/react-native-sketch/teams","hooks_url":"https://api.github.com/repos/jgrancher/react-native-sketch/hooks","issue_events_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/events{/number}","events_url":"https://api.github.com/repos/jgrancher/react-native-sketch/events","assignees_url":"https://api.github.com/repos/jgrancher/react-native-sketch/assignees{/user}","branches_url":"https://api.github.com/repos/jgrancher/react-native-sketch/branches{/branch}","tags_url":"https://api.github.com/repos/jgrancher/react-native-sketch/tags","blobs_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgrancher/react-native-sketch/statuses/{sha}","languages_url":"https://api.github.com/repos/jgrancher/react-native-sketch/languages","stargazers_url":"https://api.github.com/repos/jgrancher/react-native-sketch/stargazers","contributors_url":"https://api.github.com/repos/jgrancher/react-native-sketch/contributors","subscribers_url":"https://api.github.com/repos/jgrancher/react-native-sketch/subscribers","subscription_url":"https://api.github.com/repos/jgrancher/react-native-sketch/subscription","commits_url":"https://api.github.com/repos/jgrancher/react-native-sketch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgrancher/react-native-sketch/contents/{+path}","compare_url":"https://api.github.com/repos/jgrancher/react-native-sketch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgrancher/react-native-sketch/merges","archive_url":"https://api.github.com/repos/jgrancher/react-native-sketch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgrancher/react-native-sketch/downloads","issues_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues{/number}","pulls_url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls{/number}","milestones_url":"https://api.github.com/repos/jgrancher/react-native-sketch/milestones{/number}","notifications_url":"https://api.github.com/repos/jgrancher/react-native-sketch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgrancher/react-native-sketch/labels{/name}","releases_url":"https://api.github.com/repos/jgrancher/react-native-sketch/releases{/id}","deployments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/deployments","created_at":"2016-05-10T12:41:43Z","updated_at":"2017-05-01T04:18:08Z","pushed_at":"2017-04-30T04:31:26Z","git_url":"git://github.com/jgrancher/react-native-sketch.git","ssh_url":"git@github.com:jgrancher/react-native-sketch.git","clone_url":"https://github.com/jgrancher/react-native-sketch.git","svn_url":"https://github.com/jgrancher/react-native-sketch","homepage":"http://npm.im/react-native-sketch","size":48,"stargazers_count":152,"watchers_count":152,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":8,"forks":31,"open_issues":8,"watchers":152,"default_branch":"master"}},"base":{"label":"jgrancher:master","ref":"master","sha":"40b2510cb14c1ee697f2d74d4057d4ca2d009431","user":{"login":"jgrancher","id":5517450,"avatar_url":"https://avatars0.githubusercontent.com/u/5517450?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrancher","html_url":"https://github.com/jgrancher","followers_url":"https://api.github.com/users/jgrancher/followers","following_url":"https://api.github.com/users/jgrancher/following{/other_user}","gists_url":"https://api.github.com/users/jgrancher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrancher/subscriptions","organizations_url":"https://api.github.com/users/jgrancher/orgs","repos_url":"https://api.github.com/users/jgrancher/repos","events_url":"https://api.github.com/users/jgrancher/events{/privacy}","received_events_url":"https://api.github.com/users/jgrancher/received_events","type":"User","site_admin":false},"repo":{"id":58460331,"name":"react-native-sketch","full_name":"jgrancher/react-native-sketch","owner":{"login":"jgrancher","id":5517450,"avatar_url":"https://avatars0.githubusercontent.com/u/5517450?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrancher","html_url":"https://github.com/jgrancher","followers_url":"https://api.github.com/users/jgrancher/followers","following_url":"https://api.github.com/users/jgrancher/following{/other_user}","gists_url":"https://api.github.com/users/jgrancher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrancher/subscriptions","organizations_url":"https://api.github.com/users/jgrancher/orgs","repos_url":"https://api.github.com/users/jgrancher/repos","events_url":"https://api.github.com/users/jgrancher/events{/privacy}","received_events_url":"https://api.github.com/users/jgrancher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgrancher/react-native-sketch","description":"A React Native <Sketch /> component for touch-based drawing.","fork":false,"url":"https://api.github.com/repos/jgrancher/react-native-sketch","forks_url":"https://api.github.com/repos/jgrancher/react-native-sketch/forks","keys_url":"https://api.github.com/repos/jgrancher/react-native-sketch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgrancher/react-native-sketch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgrancher/react-native-sketch/teams","hooks_url":"https://api.github.com/repos/jgrancher/react-native-sketch/hooks","issue_events_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/events{/number}","events_url":"https://api.github.com/repos/jgrancher/react-native-sketch/events","assignees_url":"https://api.github.com/repos/jgrancher/react-native-sketch/assignees{/user}","branches_url":"https://api.github.com/repos/jgrancher/react-native-sketch/branches{/branch}","tags_url":"https://api.github.com/repos/jgrancher/react-native-sketch/tags","blobs_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgrancher/react-native-sketch/statuses/{sha}","languages_url":"https://api.github.com/repos/jgrancher/react-native-sketch/languages","stargazers_url":"https://api.github.com/repos/jgrancher/react-native-sketch/stargazers","contributors_url":"https://api.github.com/repos/jgrancher/react-native-sketch/contributors","subscribers_url":"https://api.github.com/repos/jgrancher/react-native-sketch/subscribers","subscription_url":"https://api.github.com/repos/jgrancher/react-native-sketch/subscription","commits_url":"https://api.github.com/repos/jgrancher/react-native-sketch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgrancher/react-native-sketch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgrancher/react-native-sketch/contents/{+path}","compare_url":"https://api.github.com/repos/jgrancher/react-native-sketch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgrancher/react-native-sketch/merges","archive_url":"https://api.github.com/repos/jgrancher/react-native-sketch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgrancher/react-native-sketch/downloads","issues_url":"https://api.github.com/repos/jgrancher/react-native-sketch/issues{/number}","pulls_url":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls{/number}","milestones_url":"https://api.github.com/repos/jgrancher/react-native-sketch/milestones{/number}","notifications_url":"https://api.github.com/repos/jgrancher/react-native-sketch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgrancher/react-native-sketch/labels{/name}","releases_url":"https://api.github.com/repos/jgrancher/react-native-sketch/releases{/id}","deployments_url":"https://api.github.com/repos/jgrancher/react-native-sketch/deployments","created_at":"2016-05-10T12:41:43Z","updated_at":"2017-05-01T04:18:08Z","pushed_at":"2017-04-30T04:31:26Z","git_url":"git://github.com/jgrancher/react-native-sketch.git","ssh_url":"git@github.com:jgrancher/react-native-sketch.git","clone_url":"https://github.com/jgrancher/react-native-sketch.git","svn_url":"https://github.com/jgrancher/react-native-sketch","homepage":"http://npm.im/react-native-sketch","size":48,"stargazers_count":152,"watchers_count":152,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":8,"forks":31,"open_issues":8,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28"},"html":{"href":"https://github.com/jgrancher/react-native-sketch/pull/28"},"issue":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/28"},"comments":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/jgrancher/react-native-sketch/statuses/8a4d3a9ca6bf25c700d9f4a56d596a7934cb4357"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":117,"deletions":210,"changed_files":7}}
{"actor":{"display_login":"jgrancher"}}