{"action":"created","issue":{"url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/899","repository_url":"https://api.github.com/repos/swimlane/ngx-datatable","labels_url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/899/labels{/name}","comments_url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/899/comments","events_url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/899/events","html_url":"https://github.com/swimlane/ngx-datatable/issues/899","id":248358803,"number":899,"title":"(select) event emitter conflicts with DOM Event.","user":{"login":"QuentinFchx","id":3251963,"avatar_url":"https://avatars0.githubusercontent.com/u/3251963?v=4","gravatar_id":"","url":"https://api.github.com/users/QuentinFchx","html_url":"https://github.com/QuentinFchx","followers_url":"https://api.github.com/users/QuentinFchx/followers","following_url":"https://api.github.com/users/QuentinFchx/following{/other_user}","gists_url":"https://api.github.com/users/QuentinFchx/gists{/gist_id}","starred_url":"https://api.github.com/users/QuentinFchx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuentinFchx/subscriptions","organizations_url":"https://api.github.com/users/QuentinFchx/orgs","repos_url":"https://api.github.com/users/QuentinFchx/repos","events_url":"https://api.github.com/users/QuentinFchx/events{/privacy}","received_events_url":"https://api.github.com/users/QuentinFchx/received_events","type":"User","site_admin":false},"labels":[{"id":403504504,"url":"https://api.github.com/repos/swimlane/ngx-datatable/labels/Investigate","name":"Investigate","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-07T09:42:21Z","updated_at":"2017-08-07T15:22:22Z","closed_at":null,"body":"<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! -->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter\r\n```\r\n\r\n**Current behavior**\r\n<!-- Describe how the bug manifests. -->\r\nThis library is using EventEmitters named after the [select DOM Event](https://developer.mozilla.org/fr/docs/Web/Events/select) (see [here](https://github.com/swimlane/ngx-datatable/blob/8cf233eda6247fbab6ed0b9f4c5c19b64394d393/src/components/header/header-cell.component.ts#L75))\r\nWhen using a custom header (with a text input to filter rows for instance), it conflicts with basic DOM behavior (ie: double click to select all the text of the input).\r\n\r\n**Expected behavior**\r\n<!-- Describe what the behavior would be without the bug. -->\r\nWe should not use the same names that native DOM Events\r\n\r\n**Reproduction of the problem**\r\n<!-- If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/vtAo2zzWFn8kFOGRH88r). -->\r\nhttp://plnkr.co/edit/7zAbklltoJWoCbN1btUL?p=info\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n<!-- Describe the motivation or the concrete use case -->\r\nConflicts with native DOM Events names should be avoided.\r\n\r\n**Please tell us about your environment:**\r\n<!-- Operating system, IDE, package manager, HTTP server, ... -->\r\n\r\n* **Table version:** 9.3.1\r\n<!-- Check whether this is still an issue in the most recent table version -->\r\n\r\n* **Angular version:** 4.3.3\r\n<!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\n* **Browser:** all\r\n<!-- All browsers where this could be reproduced -->\r\n\r\n* **Language:** all\r\n\r\nEDIT: relates to #757 "},"comment":{"url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/comments/320694258","html_url":"https://github.com/swimlane/ngx-datatable/issues/899#issuecomment-320694258","issue_url":"https://api.github.com/repos/swimlane/ngx-datatable/issues/899","id":320694258,"user":{"login":"QuentinFchx","id":3251963,"avatar_url":"https://avatars0.githubusercontent.com/u/3251963?v=4","gravatar_id":"","url":"https://api.github.com/users/QuentinFchx","html_url":"https://github.com/QuentinFchx","followers_url":"https://api.github.com/users/QuentinFchx/followers","following_url":"https://api.github.com/users/QuentinFchx/following{/other_user}","gists_url":"https://api.github.com/users/QuentinFchx/gists{/gist_id}","starred_url":"https://api.github.com/users/QuentinFchx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuentinFchx/subscriptions","organizations_url":"https://api.github.com/users/QuentinFchx/orgs","repos_url":"https://api.github.com/users/QuentinFchx/repos","events_url":"https://api.github.com/users/QuentinFchx/events{/privacy}","received_events_url":"https://api.github.com/users/QuentinFchx/received_events","type":"User","site_admin":false},"created_at":"2017-08-07T15:22:22Z","updated_at":"2017-08-07T15:22:22Z","body":"I can fix my own implementation that would stop the propagation of the `select` event.\r\n\r\nI understand that the `select` keyword seems suited for that case, and I'm not sure overriding native events name is a good idea.\r\n\r\nRenaming the event will lead to a breaking-change (and we need to find a replacement name), so I guess it's a trade-off."}}
{"actor":{"display_login":"QuentinFchx"}}