{"action":"created","issue":{"url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/156","repository_url":"https://api.github.com/repos/vimeo/VimeoUpload","labels_url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/156/comments","events_url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/156/events","html_url":"https://github.com/vimeo/VimeoUpload/pull/156","id":260388886,"number":156,"title":"Added missing pound for link.","user":{"login":"nicolelehrer","id":6685590,"avatar_url":"https://avatars0.githubusercontent.com/u/6685590?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolelehrer","html_url":"https://github.com/nicolelehrer","followers_url":"https://api.github.com/users/nicolelehrer/followers","following_url":"https://api.github.com/users/nicolelehrer/following{/other_user}","gists_url":"https://api.github.com/users/nicolelehrer/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolelehrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolelehrer/subscriptions","organizations_url":"https://api.github.com/users/nicolelehrer/orgs","repos_url":"https://api.github.com/users/nicolelehrer/repos","events_url":"https://api.github.com/users/nicolelehrer/events{/privacy}","received_events_url":"https://api.github.com/users/nicolelehrer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"supperspidey","id":2098675,"avatar_url":"https://avatars2.githubusercontent.com/u/2098675?v=4","gravatar_id":"","url":"https://api.github.com/users/supperspidey","html_url":"https://github.com/supperspidey","followers_url":"https://api.github.com/users/supperspidey/followers","following_url":"https://api.github.com/users/supperspidey/following{/other_user}","gists_url":"https://api.github.com/users/supperspidey/gists{/gist_id}","starred_url":"https://api.github.com/users/supperspidey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supperspidey/subscriptions","organizations_url":"https://api.github.com/users/supperspidey/orgs","repos_url":"https://api.github.com/users/supperspidey/repos","events_url":"https://api.github.com/users/supperspidey/events{/privacy}","received_events_url":"https://api.github.com/users/supperspidey/received_events","type":"User","site_admin":false},"assignees":[{"login":"supperspidey","id":2098675,"avatar_url":"https://avatars2.githubusercontent.com/u/2098675?v=4","gravatar_id":"","url":"https://api.github.com/users/supperspidey","html_url":"https://github.com/supperspidey","followers_url":"https://api.github.com/users/supperspidey/followers","following_url":"https://api.github.com/users/supperspidey/following{/other_user}","gists_url":"https://api.github.com/users/supperspidey/gists{/gist_id}","starred_url":"https://api.github.com/users/supperspidey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supperspidey/subscriptions","organizations_url":"https://api.github.com/users/supperspidey/orgs","repos_url":"https://api.github.com/users/supperspidey/repos","events_url":"https://api.github.com/users/supperspidey/events{/privacy}","received_events_url":"https://api.github.com/users/supperspidey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-09-25T19:29:16Z","updated_at":"2017-09-25T19:35:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vimeo/VimeoUpload/pulls/156","html_url":"https://github.com/vimeo/VimeoUpload/pull/156","diff_url":"https://github.com/vimeo/VimeoUpload/pull/156.diff","patch_url":"https://github.com/vimeo/VimeoUpload/pull/156.patch"},"body":"#### Ticket\r\n\r\nNA\r\n\r\n#### Pull Request Checklist\r\n\r\n- [x] Resolved any merge conflicts\r\n- [x] No build errors or warnings are introduced\r\n- [x] New files are written in Swift\r\n- [x] New classes contain license headers\r\n- [x] New classes have Documentation\r\n- [x] New public methods have Documentation\r\n\r\n#### Issue Summary\r\n\r\nFixed broken link on Read Me.\r\n\r\n#### Implementation Summary\r\n\r\nAdded missing pound sign.\r\n\r\n#### How to Test\r\n\r\nNA\r\n"},"comment":{"url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/comments/331988464","html_url":"https://github.com/vimeo/VimeoUpload/pull/156#issuecomment-331988464","issue_url":"https://api.github.com/repos/vimeo/VimeoUpload/issues/156","id":331988464,"user":{"login":"cameo-github","id":4663198,"avatar_url":"https://avatars2.githubusercontent.com/u/4663198?v=4","gravatar_id":"","url":"https://api.github.com/users/cameo-github","html_url":"https://github.com/cameo-github","followers_url":"https://api.github.com/users/cameo-github/followers","following_url":"https://api.github.com/users/cameo-github/following{/other_user}","gists_url":"https://api.github.com/users/cameo-github/gists{/gist_id}","starred_url":"https://api.github.com/users/cameo-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameo-github/subscriptions","organizations_url":"https://api.github.com/users/cameo-github/orgs","repos_url":"https://api.github.com/users/cameo-github/repos","events_url":"https://api.github.com/users/cameo-github/events{/privacy}","received_events_url":"https://api.github.com/users/cameo-github/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T19:35:15Z","updated_at":"2017-09-25T19:35:15Z","author_association":"NONE","body":"<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          6 Warnings\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/Upload/Descriptor System/Old Upload/OldUploadDescriptor.swift#L50\">VimeoUpload/Upload/Descriptor System/Old Upload/OldUploadDescriptor.swift#L50</a></strong>: string interpolation produces a debug description for an optional value; did you mean to make this explicit?  <br /><code>\n            print(\"\\(self.currentRequest.rawValue) \\(self.identifier)\")\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/UIKit/DescriptorKVObserver.swift#L31\">VimeoUpload/UIKit/DescriptorKVObserver.swift#L31</a></strong>: extraneous duplicate parameter name; ‘descriptorType’ already has an argument label  <br /><code>\n    func descriptorStateDidChange(descriptorType descriptorType: VideoDescriptorType, descriptorState: DescriptorState, isCancelled: Bool, descriptorError: NSError?)\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/UIKit/DescriptorKVObserver.swift#L32\">VimeoUpload/UIKit/DescriptorKVObserver.swift#L32</a></strong>: extraneous duplicate parameter name; ‘descriptorType’ already has an argument label  <br /><code>\n    func descriptorProgressDidChange(descriptorType descriptorType: VideoDescriptorType, progress: Double)\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/Descriptor System/DescriptorManager.swift#L232\">VimeoUpload/Descriptor System/DescriptorManager.swift#L232</a></strong>: conditional downcast from ‘Error?’ to ‘NSError’ is a bridging conversion; did you mean to use ‘as’?  <br /><code>\n                let isConnectionError = ((task.error as? NSError)?.isConnectionError() == true || (error as? NSError)?.isConnectionError() == true)\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/Upload/Extensions/AVAsset+Extensions.swift#L32\">VimeoUpload/Upload/Extensions/AVAsset+Extensions.swift#L32</a></strong>: extraneous duplicate parameter name; ‘completion’ already has an argument label  <br /><code>\n    func approximateFileSize(completion completion: @escaping FloatBlock)\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/vimeo/VimeoUpload/blob/7dd3ef5d15d2a8576e66bd544a4bf45fc24ae527/VimeoUpload/Upload/Descriptor System/Cameo/CAMUploadDescriptor.swift#L27\">VimeoUpload/Upload/Descriptor System/Cameo/CAMUploadDescriptor.swift#L27</a></strong>: string interpolation produces a debug description for an optional value; did you mean to make this explicit?  <br /><code>\n            print(\"\\(self.currentRequest.rawValue) \\(self.identifier)\")\n</code></td>\n    </tr>\n  </tbody>\n</table>\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Message\">\n          2 Messages\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:book:</td>\n      <td data-sticky=\"false\">Executed 2 tests, with 0 failures (0 unexpected) in 0.337 (0.339) seconds</td>\n    </tr>\n    <tr>\n      <td>:book:</td>\n      <td data-sticky=\"false\">Executed 2 tests, with 0 failures (0 unexpected) in 0.335 (0.337) seconds</td>\n    </tr>\n  </tbody>\n</table>\n\nSee build details on [CircleCI](https://circleci.com/gh/vimeo/VimeoUpload/218)\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">danger</a>\n</p>\n"}}
{"actor":{"display_login":"cameo-github"}}