{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/134050233","pull_request_review_id":57306282,"id":134050233,"diff_hunk":"@@ -0,0 +1,412 @@\n+// Copyright (c) 2017 Valve Corporation\n+// Copyright (c) 2017 LunarG Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#include \"pass_fixture.h\"\n+#include \"pass_utils.h\"\n+\n+namespace {\n+\n+using namespace spvtools;\n+\n+using InlineOpaqueTest = PassTest<::testing::Test>;\n+\n+TEST_F(InlineOpaqueTest, InlineOpaqueArg) {","path":"test/opt/inline_opaque_test.cpp","position":25,"original_position":25,"commit_id":"cc8eeb54451467b1266e2277431b5512bc6def68","original_commit_id":"cc8eeb54451467b1266e2277431b5512bc6def68","user":{"login":"greg-lunarg","id":7535275,"avatar_url":"https://avatars0.githubusercontent.com/u/7535275?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-lunarg","html_url":"https://github.com/greg-lunarg","followers_url":"https://api.github.com/users/greg-lunarg/followers","following_url":"https://api.github.com/users/greg-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/greg-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-lunarg/subscriptions","organizations_url":"https://api.github.com/users/greg-lunarg/orgs","repos_url":"https://api.github.com/users/greg-lunarg/repos","events_url":"https://api.github.com/users/greg-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/greg-lunarg/received_events","type":"User","site_admin":false},"body":"OK.","created_at":"2017-08-18T20:36:22Z","updated_at":"2017-08-18T20:36:22Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767#discussion_r134050233","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/134050233"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767#discussion_r134050233"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767","id":136516665,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/767","number":767,"state":"open","locked":false,"title":"Opt: Create InlineOpaquePass","user":{"login":"greg-lunarg","id":7535275,"avatar_url":"https://avatars0.githubusercontent.com/u/7535275?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-lunarg","html_url":"https://github.com/greg-lunarg","followers_url":"https://api.github.com/users/greg-lunarg/followers","following_url":"https://api.github.com/users/greg-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/greg-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-lunarg/subscriptions","organizations_url":"https://api.github.com/users/greg-lunarg/orgs","repos_url":"https://api.github.com/users/greg-lunarg/repos","events_url":"https://api.github.com/users/greg-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/greg-lunarg/received_events","type":"User","site_admin":false},"body":"Only inline calls to functions with opaque params or return ie only inline calls needed to complete opaque propagation. This is in support of opaque propagation needed by glslang.","created_at":"2017-08-18T16:22:05Z","updated_at":"2017-08-18T20:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13426db79e15d685b42f0a49a7ca3359e8b2d3b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/767/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/cc8eeb54451467b1266e2277431b5512bc6def68","head":{"label":"greg-lunarg:mem2reg70","ref":"mem2reg70","sha":"cc8eeb54451467b1266e2277431b5512bc6def68","user":{"login":"greg-lunarg","id":7535275,"avatar_url":"https://avatars0.githubusercontent.com/u/7535275?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-lunarg","html_url":"https://github.com/greg-lunarg","followers_url":"https://api.github.com/users/greg-lunarg/followers","following_url":"https://api.github.com/users/greg-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/greg-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-lunarg/subscriptions","organizations_url":"https://api.github.com/users/greg-lunarg/orgs","repos_url":"https://api.github.com/users/greg-lunarg/repos","events_url":"https://api.github.com/users/greg-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/greg-lunarg/received_events","type":"User","site_admin":false},"repo":{"id":74627208,"name":"SPIRV-Tools","full_name":"greg-lunarg/SPIRV-Tools","owner":{"login":"greg-lunarg","id":7535275,"avatar_url":"https://avatars0.githubusercontent.com/u/7535275?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-lunarg","html_url":"https://github.com/greg-lunarg","followers_url":"https://api.github.com/users/greg-lunarg/followers","following_url":"https://api.github.com/users/greg-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/greg-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-lunarg/subscriptions","organizations_url":"https://api.github.com/users/greg-lunarg/orgs","repos_url":"https://api.github.com/users/greg-lunarg/repos","events_url":"https://api.github.com/users/greg-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/greg-lunarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg-lunarg/SPIRV-Tools","description":null,"fork":true,"url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools","forks_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/greg-lunarg/SPIRV-Tools/deployments","created_at":"2016-11-24T01:26:03Z","updated_at":"2016-11-24T01:26:04Z","pushed_at":"2017-08-18T16:19:10Z","git_url":"git://github.com/greg-lunarg/SPIRV-Tools.git","ssh_url":"git@github.com:greg-lunarg/SPIRV-Tools.git","clone_url":"https://github.com/greg-lunarg/SPIRV-Tools.git","svn_url":"https://github.com/greg-lunarg/SPIRV-Tools","homepage":null,"size":4110,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"c8c86a0d368bebaf924870d8fb49ea29798c96a6","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":null,"fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2017-08-18T04:23:13Z","pushed_at":"2017-08-18T16:22:05Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":3499,"stargazers_count":195,"watchers_count":195,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":103,"forks":76,"open_issues":103,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/767"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/767"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/767/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/767/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/cc8eeb54451467b1266e2277431b5512bc6def68"}}}}
{"actor":{"display_login":"greg-lunarg"}}