{"action":"created","issue":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4182","repository_url":"https://api.github.com/repos/pioneerspacesim/pioneer","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4182/labels{/name}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4182/comments","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4182/events","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4182","id":265250403,"number":4182,"title":"WIP - Begin removing direct libpng usage","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars0.githubusercontent.com/u/825083?v=4","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"labels":[{"id":6632503,"url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels/WIP","name":"WIP","color":"444444","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-13T10:59:14Z","updated_at":"2017-10-13T14:58:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/4182","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4182","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/4182.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/4182.patch"},"body":"<!-- Please describe new feature, possible with screenshot if needed. -->\r\nWe have a dependency on `libpng` but we also use `SDL_image`, this seems to work ok on Linux machines where there is a single global version of liubpng. \r\n\r\nHowever for the Windows (VS2015/et al) version we have different versions of libpng that are linked against and different version of the DLLs get loaded!\r\nAt time this causes screenshots to fail, along with several other uses and warnings which can interfere with development.\r\n\r\nThis is pretty nasty and given that there is a function in SDL_image to save PNG files it also seems unnecessary.\r\n\r\nSo this PR uses the `IMG_SavePNG` to save an image instead of doing all the work ourselves using libpng.\r\n<!-- Please make sure you've read documentation on contributing -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments/336477552","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4182#issuecomment-336477552","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4182","id":336477552,"user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars0.githubusercontent.com/u/825083?v=4","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T14:58:04Z","updated_at":"2017-10-13T14:58:04Z","author_association":"CONTRIBUTOR","body":"@impaktor yep just one of the benefits. Slight issue is that I believe it converts all images to 32-bit PNGs regardless so it might be a bit slower. Need to look into that actually."}}
{"actor":{"display_login":"fluffyfreak"}}