{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/114915796","pull_request_review_id":36417909,"id":114915796,"diff_hunk":"@@ -69,7 +40,11 @@ public void Dispose()\n         public abstract void Retain();\n \n         public abstract void Release();\n-\n         #endregion\n+\n+        protected static unsafe void* Add(void* pointer, int offset)","path":"src/System.Buffers.Primitives/System/Buffers/OwnedBuffer.cs","position":66,"original_position":66,"commit_id":"99216a694a214cb4377d44ce2cdc0e309e176525","original_commit_id":"99216a694a214cb4377d44ce2cdc0e309e176525","user":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars2.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"body":"Does this Add method belong here?","created_at":"2017-05-05T00:24:18Z","updated_at":"2017-05-05T00:24:18Z","html_url":"https://github.com/dotnet/corefxlab/pull/1527#discussion_r114915796","pull_request_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/114915796"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/1527#discussion_r114915796"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527","id":119012063,"html_url":"https://github.com/dotnet/corefxlab/pull/1527","diff_url":"https://github.com/dotnet/corefxlab/pull/1527.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/1527.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/1527","number":1527,"state":"open","locked":false,"title":"Simplified OwnedBuffer Pinning Support","user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars3.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"body":"- Removed TryGetPointer. Pin should now be used to get to buffer pointers. \r\n- Pin got faster. The method used to be implemented in the base class and just caledl through TryGetPointer. Now OwnedBufer subtypes have specialized logic for pinning that is often simpler/faster than the base class implementation. Compare MemoryPoolBlock.Pin after this PR to OwnedBuffer.Pin before.\r\n- Getting Span from OwnedBuffer is now done through AsSpan method. This allows to avoid slicing. See Buffer<T>.get_Span.\r\n\r\nThe perf (elapsed time and instructions retired) of E2EPipelineTests benchmark improved very slightly 0.5%, but consistently.\r\n\r\ncc: @davidfowl, @mjp41, @ahsonkhan, @shiftylogic \r\n","created_at":"2017-05-04T16:15:44Z","updated_at":"2017-05-05T00:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d16c65b488b8cb375884e5ea1d419bfd3e40abd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/1527/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/99216a694a214cb4377d44ce2cdc0e309e176525","head":{"label":"KrzysztofCwalina:PreparingToChangeOBToInterface","ref":"PreparingToChangeOBToInterface","sha":"99216a694a214cb4377d44ce2cdc0e309e176525","user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars3.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"repo":{"id":29568039,"name":"corefxlab","full_name":"KrzysztofCwalina/corefxlab","owner":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars3.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KrzysztofCwalina/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab","forks_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/forks","keys_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/teams","hooks_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/events","assignees_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/tags","blobs_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/languages","stargazers_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/subscription","commits_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/merges","archive_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/downloads","issues_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/KrzysztofCwalina/corefxlab/deployments","created_at":"2015-01-21T02:57:31Z","updated_at":"2016-10-24T16:14:40Z","pushed_at":"2017-05-04T17:01:41Z","git_url":"git://github.com/KrzysztofCwalina/corefxlab.git","ssh_url":"git@github.com:KrzysztofCwalina/corefxlab.git","clone_url":"https://github.com/KrzysztofCwalina/corefxlab.git","svn_url":"https://github.com/KrzysztofCwalina/corefxlab","homepage":"","size":32901,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c61fec0467964257992fe1a8712b32b3ec505bc7","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"name":"corefxlab","full_name":"dotnet/corefxlab","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2017-05-04T11:29:40Z","pushed_at":"2017-05-05T00:20:20Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"git@github.com:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":33025,"stargazers_count":692,"watchers_count":692,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"open_issues_count":209,"forks":195,"open_issues":209,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/1527"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/1527"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/1527/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1527/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/99216a694a214cb4377d44ce2cdc0e309e176525"}}}}
{"actor":{"display_login":"ahsonkhan"}}