{"action":"created","comment":{"url":"https://api.github.com/repos/gap-packages/kbmag/pulls/comments/158811561","pull_request_review_id":85668626,"id":158811561,"diff_hunk":"@@ -0,0 +1,29 @@\n+##  makedoc.g,  version 21/12/17\n+##  This builds the documentation of the KBMag package\n+##  Needs: GAPDoc package, latex, pdflatex, mkindex\n+##  \n+LoadPackage( \"GAPDoc\" );\n+\n+MakeGAPDocDoc( \"doc\",      # path to the directory containing the main file\n+               \"kbmag\",    # the name of the main file (without extension)\n+                           # list of (probably source code) files relative \n+                           # to path which contain pieces of documentation \n+                           # which must be included in the document\n+               [ \"../PackageInfo.g\" ], \n+               \"kbmag\",    # the name of the book used by GAP's online help\n+  GAPInfo.RootPaths[3],    # optional: relative path to the main GAP root \n+                           # directory to produce HTML files with relative \n+                           # paths to external books.\n+                           # optional: use \"MathJax\", \"Tth\" and/or \"MathML\"\n+                           # to produce additional variants of HTML files\n+               \"MathJax\"   # optional: use \"MathJax\", \"Tth\" and/or \"MathML\"\n+                           # to produce additional variants of HTML files\n+               );; ","path":"makedoc.g","position":21,"original_position":21,"commit_id":"3fc00ffd545672e81f177d8fda26d55ac5fe9968","original_commit_id":"3fc00ffd545672e81f177d8fda26d55ac5fe9968","user":{"login":"fingolfin","id":241512,"avatar_url":"https://avatars2.githubusercontent.com/u/241512?v=4","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"body":"Personally I prefer using `AutoDoc` to replace all of the above. Then it can also generate the title page, and all that duplicate data in `PackageInfo.g` can be removed.","created_at":"2017-12-27T13:12:34Z","updated_at":"2017-12-27T13:12:39Z","html_url":"https://github.com/gap-packages/kbmag/pull/13#discussion_r158811561","pull_request_url":"https://api.github.com/repos/gap-packages/kbmag/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/comments/158811561"},"html":{"href":"https://github.com/gap-packages/kbmag/pull/13#discussion_r158811561"},"pull_request":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/gap-packages/kbmag/pulls/13","id":157447102,"html_url":"https://github.com/gap-packages/kbmag/pull/13","diff_url":"https://github.com/gap-packages/kbmag/pull/13.diff","patch_url":"https://github.com/gap-packages/kbmag/pull/13.patch","issue_url":"https://api.github.com/repos/gap-packages/kbmag/issues/13","number":13,"state":"open","locked":false,"title":"GAPDoc manual - initial attempt","user":{"login":"cdwensley","id":13138201,"avatar_url":"https://avatars1.githubusercontent.com/u/13138201?v=4","gravatar_id":"","url":"https://api.github.com/users/cdwensley","html_url":"https://github.com/cdwensley","followers_url":"https://api.github.com/users/cdwensley/followers","following_url":"https://api.github.com/users/cdwensley/following{/other_user}","gists_url":"https://api.github.com/users/cdwensley/gists{/gist_id}","starred_url":"https://api.github.com/users/cdwensley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdwensley/subscriptions","organizations_url":"https://api.github.com/users/cdwensley/orgs","repos_url":"https://api.github.com/users/cdwensley/repos","events_url":"https://api.github.com/users/cdwensley/events{/privacy}","received_events_url":"https://api.github.com/users/cdwensley/received_events","type":"User","site_admin":false},"body":"This certainly needs more work and I plan a read through on Tuesday to check for typos. \r\nThe Index is not working properly, and Frank is looking into that. \r\nI've taken the liberty of introducing several chapters, but that is easily reverted if required. \r\nAny suggestions welcome. ","created_at":"2017-12-10T19:56:58Z","updated_at":"2017-12-27T13:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f156b481712814c17930fc3fcdb42e4d4e37ed6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gap-packages/kbmag/pulls/13/commits","review_comments_url":"https://api.github.com/repos/gap-packages/kbmag/pulls/13/comments","review_comment_url":"https://api.github.com/repos/gap-packages/kbmag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gap-packages/kbmag/issues/13/comments","statuses_url":"https://api.github.com/repos/gap-packages/kbmag/statuses/3fc00ffd545672e81f177d8fda26d55ac5fe9968","head":{"label":"cdwensley:manual","ref":"manual","sha":"3fc00ffd545672e81f177d8fda26d55ac5fe9968","user":{"login":"cdwensley","id":13138201,"avatar_url":"https://avatars1.githubusercontent.com/u/13138201?v=4","gravatar_id":"","url":"https://api.github.com/users/cdwensley","html_url":"https://github.com/cdwensley","followers_url":"https://api.github.com/users/cdwensley/followers","following_url":"https://api.github.com/users/cdwensley/following{/other_user}","gists_url":"https://api.github.com/users/cdwensley/gists{/gist_id}","starred_url":"https://api.github.com/users/cdwensley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdwensley/subscriptions","organizations_url":"https://api.github.com/users/cdwensley/orgs","repos_url":"https://api.github.com/users/cdwensley/repos","events_url":"https://api.github.com/users/cdwensley/events{/privacy}","received_events_url":"https://api.github.com/users/cdwensley/received_events","type":"User","site_admin":false},"repo":{"id":113200680,"name":"kbmag","full_name":"cdwensley/kbmag","owner":{"login":"cdwensley","id":13138201,"avatar_url":"https://avatars1.githubusercontent.com/u/13138201?v=4","gravatar_id":"","url":"https://api.github.com/users/cdwensley","html_url":"https://github.com/cdwensley","followers_url":"https://api.github.com/users/cdwensley/followers","following_url":"https://api.github.com/users/cdwensley/following{/other_user}","gists_url":"https://api.github.com/users/cdwensley/gists{/gist_id}","starred_url":"https://api.github.com/users/cdwensley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdwensley/subscriptions","organizations_url":"https://api.github.com/users/cdwensley/orgs","repos_url":"https://api.github.com/users/cdwensley/repos","events_url":"https://api.github.com/users/cdwensley/events{/privacy}","received_events_url":"https://api.github.com/users/cdwensley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdwensley/kbmag","description":"Knuth-Bendix on Monoids and Automatic Groups","fork":true,"url":"https://api.github.com/repos/cdwensley/kbmag","forks_url":"https://api.github.com/repos/cdwensley/kbmag/forks","keys_url":"https://api.github.com/repos/cdwensley/kbmag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdwensley/kbmag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdwensley/kbmag/teams","hooks_url":"https://api.github.com/repos/cdwensley/kbmag/hooks","issue_events_url":"https://api.github.com/repos/cdwensley/kbmag/issues/events{/number}","events_url":"https://api.github.com/repos/cdwensley/kbmag/events","assignees_url":"https://api.github.com/repos/cdwensley/kbmag/assignees{/user}","branches_url":"https://api.github.com/repos/cdwensley/kbmag/branches{/branch}","tags_url":"https://api.github.com/repos/cdwensley/kbmag/tags","blobs_url":"https://api.github.com/repos/cdwensley/kbmag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdwensley/kbmag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdwensley/kbmag/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdwensley/kbmag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdwensley/kbmag/statuses/{sha}","languages_url":"https://api.github.com/repos/cdwensley/kbmag/languages","stargazers_url":"https://api.github.com/repos/cdwensley/kbmag/stargazers","contributors_url":"https://api.github.com/repos/cdwensley/kbmag/contributors","subscribers_url":"https://api.github.com/repos/cdwensley/kbmag/subscribers","subscription_url":"https://api.github.com/repos/cdwensley/kbmag/subscription","commits_url":"https://api.github.com/repos/cdwensley/kbmag/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdwensley/kbmag/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdwensley/kbmag/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdwensley/kbmag/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdwensley/kbmag/contents/{+path}","compare_url":"https://api.github.com/repos/cdwensley/kbmag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdwensley/kbmag/merges","archive_url":"https://api.github.com/repos/cdwensley/kbmag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdwensley/kbmag/downloads","issues_url":"https://api.github.com/repos/cdwensley/kbmag/issues{/number}","pulls_url":"https://api.github.com/repos/cdwensley/kbmag/pulls{/number}","milestones_url":"https://api.github.com/repos/cdwensley/kbmag/milestones{/number}","notifications_url":"https://api.github.com/repos/cdwensley/kbmag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdwensley/kbmag/labels{/name}","releases_url":"https://api.github.com/repos/cdwensley/kbmag/releases{/id}","deployments_url":"https://api.github.com/repos/cdwensley/kbmag/deployments","created_at":"2017-12-05T15:40:00Z","updated_at":"2017-12-05T15:40:02Z","pushed_at":"2017-12-22T11:23:04Z","git_url":"git://github.com/cdwensley/kbmag.git","ssh_url":"git@github.com:cdwensley/kbmag.git","clone_url":"https://github.com/cdwensley/kbmag.git","svn_url":"https://github.com/cdwensley/kbmag","homepage":"http://gap-packages.github.io/kbmag/","size":1096,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gap-packages:master","ref":"master","sha":"90f87e8210a303ce890c298e53603af31a24bf21","user":{"login":"gap-packages","id":14360610,"avatar_url":"https://avatars3.githubusercontent.com/u/14360610?v=4","gravatar_id":"","url":"https://api.github.com/users/gap-packages","html_url":"https://github.com/gap-packages","followers_url":"https://api.github.com/users/gap-packages/followers","following_url":"https://api.github.com/users/gap-packages/following{/other_user}","gists_url":"https://api.github.com/users/gap-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-packages/subscriptions","organizations_url":"https://api.github.com/users/gap-packages/orgs","repos_url":"https://api.github.com/users/gap-packages/repos","events_url":"https://api.github.com/users/gap-packages/events{/privacy}","received_events_url":"https://api.github.com/users/gap-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":49639424,"name":"kbmag","full_name":"gap-packages/kbmag","owner":{"login":"gap-packages","id":14360610,"avatar_url":"https://avatars3.githubusercontent.com/u/14360610?v=4","gravatar_id":"","url":"https://api.github.com/users/gap-packages","html_url":"https://github.com/gap-packages","followers_url":"https://api.github.com/users/gap-packages/followers","following_url":"https://api.github.com/users/gap-packages/following{/other_user}","gists_url":"https://api.github.com/users/gap-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-packages/subscriptions","organizations_url":"https://api.github.com/users/gap-packages/orgs","repos_url":"https://api.github.com/users/gap-packages/repos","events_url":"https://api.github.com/users/gap-packages/events{/privacy}","received_events_url":"https://api.github.com/users/gap-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gap-packages/kbmag","description":"Knuth-Bendix on Monoids and Automatic Groups","fork":false,"url":"https://api.github.com/repos/gap-packages/kbmag","forks_url":"https://api.github.com/repos/gap-packages/kbmag/forks","keys_url":"https://api.github.com/repos/gap-packages/kbmag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gap-packages/kbmag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gap-packages/kbmag/teams","hooks_url":"https://api.github.com/repos/gap-packages/kbmag/hooks","issue_events_url":"https://api.github.com/repos/gap-packages/kbmag/issues/events{/number}","events_url":"https://api.github.com/repos/gap-packages/kbmag/events","assignees_url":"https://api.github.com/repos/gap-packages/kbmag/assignees{/user}","branches_url":"https://api.github.com/repos/gap-packages/kbmag/branches{/branch}","tags_url":"https://api.github.com/repos/gap-packages/kbmag/tags","blobs_url":"https://api.github.com/repos/gap-packages/kbmag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gap-packages/kbmag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gap-packages/kbmag/git/refs{/sha}","trees_url":"https://api.github.com/repos/gap-packages/kbmag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gap-packages/kbmag/statuses/{sha}","languages_url":"https://api.github.com/repos/gap-packages/kbmag/languages","stargazers_url":"https://api.github.com/repos/gap-packages/kbmag/stargazers","contributors_url":"https://api.github.com/repos/gap-packages/kbmag/contributors","subscribers_url":"https://api.github.com/repos/gap-packages/kbmag/subscribers","subscription_url":"https://api.github.com/repos/gap-packages/kbmag/subscription","commits_url":"https://api.github.com/repos/gap-packages/kbmag/commits{/sha}","git_commits_url":"https://api.github.com/repos/gap-packages/kbmag/git/commits{/sha}","comments_url":"https://api.github.com/repos/gap-packages/kbmag/comments{/number}","issue_comment_url":"https://api.github.com/repos/gap-packages/kbmag/issues/comments{/number}","contents_url":"https://api.github.com/repos/gap-packages/kbmag/contents/{+path}","compare_url":"https://api.github.com/repos/gap-packages/kbmag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gap-packages/kbmag/merges","archive_url":"https://api.github.com/repos/gap-packages/kbmag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gap-packages/kbmag/downloads","issues_url":"https://api.github.com/repos/gap-packages/kbmag/issues{/number}","pulls_url":"https://api.github.com/repos/gap-packages/kbmag/pulls{/number}","milestones_url":"https://api.github.com/repos/gap-packages/kbmag/milestones{/number}","notifications_url":"https://api.github.com/repos/gap-packages/kbmag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gap-packages/kbmag/labels{/name}","releases_url":"https://api.github.com/repos/gap-packages/kbmag/releases{/id}","deployments_url":"https://api.github.com/repos/gap-packages/kbmag/deployments","created_at":"2016-01-14T10:10:59Z","updated_at":"2017-11-03T17:31:19Z","pushed_at":"2017-12-22T11:23:05Z","git_url":"git://github.com/gap-packages/kbmag.git","ssh_url":"git@github.com:gap-packages/kbmag.git","clone_url":"https://github.com/gap-packages/kbmag.git","svn_url":"https://github.com/gap-packages/kbmag","homepage":"http://gap-packages.github.io/kbmag/","size":1055,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":3,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/13"},"html":{"href":"https://github.com/gap-packages/kbmag/pull/13"},"issue":{"href":"https://api.github.com/repos/gap-packages/kbmag/issues/13"},"comments":{"href":"https://api.github.com/repos/gap-packages/kbmag/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gap-packages/kbmag/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/gap-packages/kbmag/statuses/3fc00ffd545672e81f177d8fda26d55ac5fe9968"}},"author_association":"NONE"}}
{"actor":{"display_login":"fingolfin"}}