{"action":"created","comment":{"url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/comments/95239021","pull_request_review_id":15788046,"id":95239021,"diff_hunk":"@@ -0,0 +1,22 @@\n+--- NDK_3.9/Include/include_h/graphics/gfxmacros.h.orig\t2017-01-09 14:37:17.040582249 +0100\n++++ NDK_3.9/Include/include_h/graphics/gfxmacros.h\t2017-01-09 14:37:32.084233042 +0100\n+@@ -55,9 +55,6 @@\n+ #define SafeSetOutlinePen(w,c)\t  {if (GfxBase->LibNode.lib_Version<39) { (w)->AOlPen = c;(w)->Flags |= AREAOUTLINE;} else SetOutlinePen(w,c); }\n+ #define SafeSetWriteMask(w,m)\t{if (GfxBase->LibNode.lib_Version<39) { (w)->Mask = (m);} else SetWriteMask(w,m); }\n+ \n+-/* synonym for GetOPen for consistency with SetOutlinePen */\n+-#define GetOutlinePen(rp) GetOPen(rp)","path":"patches/NDK_3.9/Include/include_h/graphics/gfxmacros.h.diff","position":8,"original_position":8,"commit_id":"34b38891fc2865a00276737836782ec8ffd449ec","original_commit_id":"34b38891fc2865a00276737836782ec8ffd449ec","user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"body":"I understand. However removing hastily a macro can break some other software. One has to be careful with modyfing system header files.\r\n\r\nI'll accept the patch if you remove second occurence of the macro, and swap `GetOutlinePen` with `GetOPen` in the first occurence - i.e. the patch should remove 2 lines and modify 1 line.","created_at":"2017-01-09T20:28:22Z","updated_at":"2017-01-09T20:28:22Z","html_url":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74#discussion_r95239021","pull_request_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/comments/95239021"},"html":{"href":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74#discussion_r95239021"},"pull_request":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74","id":100688809,"html_url":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74","diff_url":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74.diff","patch_url":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74.patch","issue_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/74","number":74,"state":"open","locked":false,"title":"removing the GetOutlinePen() macro from graphics/gfxmacros.h","user":{"login":"jens-maus","id":5887769,"avatar_url":"https://avatars.githubusercontent.com/u/5887769?v=3","gravatar_id":"","url":"https://api.github.com/users/jens-maus","html_url":"https://github.com/jens-maus","followers_url":"https://api.github.com/users/jens-maus/followers","following_url":"https://api.github.com/users/jens-maus/following{/other_user}","gists_url":"https://api.github.com/users/jens-maus/gists{/gist_id}","starred_url":"https://api.github.com/users/jens-maus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jens-maus/subscriptions","organizations_url":"https://api.github.com/users/jens-maus/orgs","repos_url":"https://api.github.com/users/jens-maus/repos","events_url":"https://api.github.com/users/jens-maus/events{/privacy}","received_events_url":"https://api.github.com/users/jens-maus/received_events","type":"User","site_admin":false},"body":"removing the GetOutlinePen() macro from graphics/gfxmacros.h as this is causing compiler warnings due to conflicts with the graphics.h inline macros. This refs #63.","created_at":"2017-01-09T13:56:43Z","updated_at":"2017-01-09T20:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d33fb649323b194e6b013aa356cb58b7faecd46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74/commits","review_comments_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74/comments","review_comment_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/74/comments","statuses_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/statuses/34b38891fc2865a00276737836782ec8ffd449ec","head":{"label":"jens-maus:getoutlinepen-patch","ref":"getoutlinepen-patch","sha":"34b38891fc2865a00276737836782ec8ffd449ec","user":{"login":"jens-maus","id":5887769,"avatar_url":"https://avatars.githubusercontent.com/u/5887769?v=3","gravatar_id":"","url":"https://api.github.com/users/jens-maus","html_url":"https://github.com/jens-maus","followers_url":"https://api.github.com/users/jens-maus/followers","following_url":"https://api.github.com/users/jens-maus/following{/other_user}","gists_url":"https://api.github.com/users/jens-maus/gists{/gist_id}","starred_url":"https://api.github.com/users/jens-maus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jens-maus/subscriptions","organizations_url":"https://api.github.com/users/jens-maus/orgs","repos_url":"https://api.github.com/users/jens-maus/repos","events_url":"https://api.github.com/users/jens-maus/events{/privacy}","received_events_url":"https://api.github.com/users/jens-maus/received_events","type":"User","site_admin":false},"repo":{"id":78419585,"name":"amigaos-cross-toolchain","full_name":"jens-maus/amigaos-cross-toolchain","owner":{"login":"jens-maus","id":5887769,"avatar_url":"https://avatars.githubusercontent.com/u/5887769?v=3","gravatar_id":"","url":"https://api.github.com/users/jens-maus","html_url":"https://github.com/jens-maus","followers_url":"https://api.github.com/users/jens-maus/followers","following_url":"https://api.github.com/users/jens-maus/following{/other_user}","gists_url":"https://api.github.com/users/jens-maus/gists{/gist_id}","starred_url":"https://api.github.com/users/jens-maus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jens-maus/subscriptions","organizations_url":"https://api.github.com/users/jens-maus/orgs","repos_url":"https://api.github.com/users/jens-maus/repos","events_url":"https://api.github.com/users/jens-maus/events{/privacy}","received_events_url":"https://api.github.com/users/jens-maus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jens-maus/amigaos-cross-toolchain","description":"AmigaOS cross compiler for Linux / MacOSX / Windows","fork":true,"url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain","forks_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/forks","keys_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/teams","hooks_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/hooks","issue_events_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/issues/events{/number}","events_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/events","assignees_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/assignees{/user}","branches_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/branches{/branch}","tags_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/tags","blobs_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/statuses/{sha}","languages_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/languages","stargazers_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/stargazers","contributors_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/contributors","subscribers_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/subscribers","subscription_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/subscription","commits_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/contents/{+path}","compare_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/merges","archive_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/downloads","issues_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/issues{/number}","pulls_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/pulls{/number}","milestones_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/milestones{/number}","notifications_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/labels{/name}","releases_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/releases{/id}","deployments_url":"https://api.github.com/repos/jens-maus/amigaos-cross-toolchain/deployments","created_at":"2017-01-09T10:41:20Z","updated_at":"2017-01-09T14:14:38Z","pushed_at":"2017-01-09T14:14:54Z","git_url":"git://github.com/jens-maus/amigaos-cross-toolchain.git","ssh_url":"git@github.com:jens-maus/amigaos-cross-toolchain.git","clone_url":"https://github.com/jens-maus/amigaos-cross-toolchain.git","svn_url":"https://github.com/jens-maus/amigaos-cross-toolchain","homepage":"","size":1908,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cahirwpz:master","ref":"master","sha":"781dbadfd453ddc1a1a103ba8b25a442999fb76a","user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"repo":{"id":3436657,"name":"amigaos-cross-toolchain","full_name":"cahirwpz/amigaos-cross-toolchain","owner":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cahirwpz/amigaos-cross-toolchain","description":"AmigaOS cross compiler for Linux / MacOSX / Windows","fork":false,"url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain","forks_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/forks","keys_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/teams","hooks_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/hooks","issue_events_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/events{/number}","events_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/events","assignees_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/assignees{/user}","branches_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/branches{/branch}","tags_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/tags","blobs_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/statuses/{sha}","languages_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/languages","stargazers_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/stargazers","contributors_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/contributors","subscribers_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/subscribers","subscription_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/subscription","commits_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/contents/{+path}","compare_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/merges","archive_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/downloads","issues_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues{/number}","pulls_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls{/number}","milestones_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/milestones{/number}","notifications_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/labels{/name}","releases_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/releases{/id}","deployments_url":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/deployments","created_at":"2012-02-14T03:20:45Z","updated_at":"2017-01-06T19:27:45Z","pushed_at":"2017-01-09T14:17:10Z","git_url":"git://github.com/cahirwpz/amigaos-cross-toolchain.git","ssh_url":"git@github.com:cahirwpz/amigaos-cross-toolchain.git","clone_url":"https://github.com/cahirwpz/amigaos-cross-toolchain.git","svn_url":"https://github.com/cahirwpz/amigaos-cross-toolchain","homepage":"","size":1947,"stargazers_count":83,"watchers_count":83,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":20,"forks":22,"open_issues":20,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74"},"html":{"href":"https://github.com/cahirwpz/amigaos-cross-toolchain/pull/74"},"issue":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/74"},"comments":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/cahirwpz/amigaos-cross-toolchain/statuses/34b38891fc2865a00276737836782ec8ffd449ec"}}}}
{"actor":{"display_login":"cahirwpz"}}