{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/133681582","pull_request_review_id":56889569,"id":133681582,"diff_hunk":"@@ -21,8 +21,5 @@ module.exports = {\n \n     opts = bhFiscalPeriod.element(by.model('$ctrl.selectedPeriodTo'));\n     opts.element(getValue(periodTo_id)).click();\n-\n-    // click away to free the space","path":"test/end-to-end/shared/components/bhFiscalPeriodSelect.js","position":5,"original_position":5,"commit_id":"b3954656c90bbc1a03abc63a804c1a7056f1541b","original_commit_id":"3a7a071cbe843ef171a7fcac13a03fc4effcc132","user":{"login":"sfount","id":2844572,"avatar_url":"https://avatars3.githubusercontent.com/u/2844572?v=4","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"body":"l'anglais 👌 ","created_at":"2017-08-17T10:56:46Z","updated_at":"2017-08-17T10:56:46Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905#discussion_r133681582","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/133681582"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905#discussion_r133681582"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905","id":133109332,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1905","number":1905,"state":"open","locked":false,"title":"Refactor Stock distribution","user":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars2.githubusercontent.com/u/5418919?v=4","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"body":"This PR refactor the stock distribution page and closes #1854\r\n\r\nMost of the work is about addressing points listed in #1854 and some refactor in order to reduce the code.\r\nA new component ```bhStockEntryExitType``` has been introduced to remove repeated code found in ```exit.html``` and ```entry.html``` for selecting the type of entry or exit.\r\n\r\nThe main change is about stock distribution from depot to an other depot (Stock transfer)\r\nNow the stock transfer is a set of two processes which are a stock exit to depot and a stock entry from depot. Both of them are independent in other to avoid mistakes and guaranty the data integrity.\r\nEach time the stock in the depot will match the stock in the system.\r\n \r\nThank you for contributing!\r\n\r\nBefore submitting this pull request, please verify that you have:\r\n - [x] Run your code through eslint.\r\n - [x] Run integration tests.\r\n - [x] Run end-to-end tests.\r\n - [x] Accurately described the changes your are making in this pull request.\r\n\r\nFor a more detailed checklist, [see the online review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against.\r\n\r\nEnsuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!\r\n","created_at":"2017-07-29T22:55:35Z","updated_at":"2017-08-17T10:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"984cc83ec5ee18b052cea4b534f45e7e01dfaddd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sfount","id":2844572,"avatar_url":"https://avatars3.githubusercontent.com/u/2844572?v=4","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars1.githubusercontent.com/u/5445251?v=4","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1905/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/b3954656c90bbc1a03abc63a804c1a7056f1541b","head":{"label":"DedrickEnc:dedrick-stock-dist","ref":"dedrick-stock-dist","sha":"b3954656c90bbc1a03abc63a804c1a7056f1541b","user":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars2.githubusercontent.com/u/5418919?v=4","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"repo":{"id":49414970,"name":"bhima-2.X","full_name":"DedrickEnc/bhima-2.X","owner":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars2.githubusercontent.com/u/5418919?v=4","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DedrickEnc/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/DedrickEnc/bhima-2.X","forks_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/forks","keys_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/events","assignees_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/merges","archive_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/deployments","created_at":"2016-01-11T09:17:30Z","updated_at":"2016-01-11T09:17:33Z","pushed_at":"2017-08-16T07:57:04Z","git_url":"git://github.com/DedrickEnc/bhima-2.X.git","ssh_url":"git@github.com:DedrickEnc/bhima-2.X.git","clone_url":"https://github.com/DedrickEnc/bhima-2.X.git","svn_url":"https://github.com/DedrickEnc/bhima-2.X","homepage":null,"size":10850,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"f866d65e27c8081bf1e7cb84342e0f22cb37fc3f","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2017-08-16T15:58:54Z","pushed_at":"2017-08-17T10:40:32Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":"","size":10939,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":306,"forks":25,"open_issues":306,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1905"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1905"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1905/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1905/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/b3954656c90bbc1a03abc63a804c1a7056f1541b"}}}}
{"actor":{"display_login":"sfount"}}