{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6","id":142817301,"html_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript/pull/6","diff_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript/pull/6.diff","patch_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript/pull/6.patch","issue_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/6","number":6,"state":"closed","locked":false,"title":"Add validateFields to public interface, so that clients can run realt…","user":{"login":"ConsultDarryl","id":17292060,"avatar_url":"https://avatars2.githubusercontent.com/u/17292060?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsultDarryl","html_url":"https://github.com/ConsultDarryl","followers_url":"https://api.github.com/users/ConsultDarryl/followers","following_url":"https://api.github.com/users/ConsultDarryl/following{/other_user}","gists_url":"https://api.github.com/users/ConsultDarryl/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsultDarryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsultDarryl/subscriptions","organizations_url":"https://api.github.com/users/ConsultDarryl/orgs","repos_url":"https://api.github.com/users/ConsultDarryl/repos","events_url":"https://api.github.com/users/ConsultDarryl/events{/privacy}","received_events_url":"https://api.github.com/users/ConsultDarryl/received_events","type":"User","site_admin":false},"body":"I've added validateFields to the public interface so that we can run the validation before we call Encrypt. \r\n\r\nThis change lets us replicate Worldpay HPP where the customer can see errors as they are typing.\r\n\r\nAt the moment, we call \"Encrypt\" to run the validation (validateFields is the first thing Encrypt calls). But this means we are running encryption when we don't need to. We only want to encrypt when the customer submits their payments details.","created_at":"2017-09-25T08:00:21Z","updated_at":"2017-10-05T09:04:03Z","closed_at":"2017-10-05T09:04:03Z","merged_at":"2017-10-05T09:04:03Z","merge_commit_sha":"75b9a620c024f765c627511121a9db6930e870ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/6/comments","statuses_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/statuses/a7fc056d9f2abfd3f355607124f0eee55029cf51","head":{"label":"ConsultDarryl:master","ref":"master","sha":"a7fc056d9f2abfd3f355607124f0eee55029cf51","user":{"login":"ConsultDarryl","id":17292060,"avatar_url":"https://avatars2.githubusercontent.com/u/17292060?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsultDarryl","html_url":"https://github.com/ConsultDarryl","followers_url":"https://api.github.com/users/ConsultDarryl/followers","following_url":"https://api.github.com/users/ConsultDarryl/following{/other_user}","gists_url":"https://api.github.com/users/ConsultDarryl/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsultDarryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsultDarryl/subscriptions","organizations_url":"https://api.github.com/users/ConsultDarryl/orgs","repos_url":"https://api.github.com/users/ConsultDarryl/repos","events_url":"https://api.github.com/users/ConsultDarryl/events{/privacy}","received_events_url":"https://api.github.com/users/ConsultDarryl/received_events","type":"User","site_admin":false},"repo":{"id":103520271,"name":"worldpay-cse-lib-javascript","full_name":"ConsultDarryl/worldpay-cse-lib-javascript","owner":{"login":"ConsultDarryl","id":17292060,"avatar_url":"https://avatars2.githubusercontent.com/u/17292060?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsultDarryl","html_url":"https://github.com/ConsultDarryl","followers_url":"https://api.github.com/users/ConsultDarryl/followers","following_url":"https://api.github.com/users/ConsultDarryl/following{/other_user}","gists_url":"https://api.github.com/users/ConsultDarryl/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsultDarryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsultDarryl/subscriptions","organizations_url":"https://api.github.com/users/ConsultDarryl/orgs","repos_url":"https://api.github.com/users/ConsultDarryl/repos","events_url":"https://api.github.com/users/ConsultDarryl/events{/privacy}","received_events_url":"https://api.github.com/users/ConsultDarryl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ConsultDarryl/worldpay-cse-lib-javascript","description":"JavaScript Library for Worldpay CSE","fork":true,"url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript","forks_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/forks","keys_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/teams","hooks_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/hooks","issue_events_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/events","assignees_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/tags","blobs_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/languages","stargazers_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/stargazers","contributors_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/contributors","subscribers_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/subscribers","subscription_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/subscription","commits_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/merges","archive_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/downloads","issues_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/labels{/name}","releases_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/ConsultDarryl/worldpay-cse-lib-javascript/deployments","created_at":"2017-09-14T10:39:25Z","updated_at":"2017-09-14T10:39:26Z","pushed_at":"2017-09-25T07:51:01Z","git_url":"git://github.com/ConsultDarryl/worldpay-cse-lib-javascript.git","ssh_url":"git@github.com:ConsultDarryl/worldpay-cse-lib-javascript.git","clone_url":"https://github.com/ConsultDarryl/worldpay-cse-lib-javascript.git","svn_url":"https://github.com/ConsultDarryl/worldpay-cse-lib-javascript","homepage":"","size":130,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Worldpay:master","ref":"master","sha":"98791c55481be532308c46eacf698bd0f606f35f","user":{"login":"Worldpay","id":7138566,"avatar_url":"https://avatars0.githubusercontent.com/u/7138566?v=4","gravatar_id":"","url":"https://api.github.com/users/Worldpay","html_url":"https://github.com/Worldpay","followers_url":"https://api.github.com/users/Worldpay/followers","following_url":"https://api.github.com/users/Worldpay/following{/other_user}","gists_url":"https://api.github.com/users/Worldpay/gists{/gist_id}","starred_url":"https://api.github.com/users/Worldpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Worldpay/subscriptions","organizations_url":"https://api.github.com/users/Worldpay/orgs","repos_url":"https://api.github.com/users/Worldpay/repos","events_url":"https://api.github.com/users/Worldpay/events{/privacy}","received_events_url":"https://api.github.com/users/Worldpay/received_events","type":"Organization","site_admin":false},"repo":{"id":40910971,"name":"worldpay-cse-lib-javascript","full_name":"Worldpay/worldpay-cse-lib-javascript","owner":{"login":"Worldpay","id":7138566,"avatar_url":"https://avatars0.githubusercontent.com/u/7138566?v=4","gravatar_id":"","url":"https://api.github.com/users/Worldpay","html_url":"https://github.com/Worldpay","followers_url":"https://api.github.com/users/Worldpay/followers","following_url":"https://api.github.com/users/Worldpay/following{/other_user}","gists_url":"https://api.github.com/users/Worldpay/gists{/gist_id}","starred_url":"https://api.github.com/users/Worldpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Worldpay/subscriptions","organizations_url":"https://api.github.com/users/Worldpay/orgs","repos_url":"https://api.github.com/users/Worldpay/repos","events_url":"https://api.github.com/users/Worldpay/events{/privacy}","received_events_url":"https://api.github.com/users/Worldpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript","description":"JavaScript Library for Worldpay CSE","fork":false,"url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript","forks_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/forks","keys_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/teams","hooks_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/hooks","issue_events_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/events","assignees_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/tags","blobs_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/languages","stargazers_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/stargazers","contributors_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/contributors","subscribers_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/subscribers","subscription_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/subscription","commits_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/merges","archive_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/downloads","issues_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/labels{/name}","releases_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/deployments","created_at":"2015-08-17T16:37:55Z","updated_at":"2017-09-14T10:39:20Z","pushed_at":"2017-10-05T09:04:03Z","git_url":"git://github.com/Worldpay/worldpay-cse-lib-javascript.git","ssh_url":"git@github.com:Worldpay/worldpay-cse-lib-javascript.git","clone_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript.git","svn_url":"https://github.com/Worldpay/worldpay-cse-lib-javascript","homepage":"","size":130,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6"},"html":{"href":"https://github.com/Worldpay/worldpay-cse-lib-javascript/pull/6"},"issue":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/6"},"comments":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Worldpay/worldpay-cse-lib-javascript/statuses/a7fc056d9f2abfd3f355607124f0eee55029cf51"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"benwwest","id":932637,"avatar_url":"https://avatars1.githubusercontent.com/u/932637?v=4","gravatar_id":"","url":"https://api.github.com/users/benwwest","html_url":"https://github.com/benwwest","followers_url":"https://api.github.com/users/benwwest/followers","following_url":"https://api.github.com/users/benwwest/following{/other_user}","gists_url":"https://api.github.com/users/benwwest/gists{/gist_id}","starred_url":"https://api.github.com/users/benwwest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwwest/subscriptions","organizations_url":"https://api.github.com/users/benwwest/orgs","repos_url":"https://api.github.com/users/benwwest/repos","events_url":"https://api.github.com/users/benwwest/events{/privacy}","received_events_url":"https://api.github.com/users/benwwest/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"benwwest"}}