{"action":"closed","issue":{"url":"https://api.github.com/repos/KBNLresearch/omSipCreator/issues/29","repository_url":"https://api.github.com/repos/KBNLresearch/omSipCreator","labels_url":"https://api.github.com/repos/KBNLresearch/omSipCreator/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/KBNLresearch/omSipCreator/issues/29/comments","events_url":"https://api.github.com/repos/KBNLresearch/omSipCreator/issues/29/events","html_url":"https://github.com/KBNLresearch/omSipCreator/issues/29","id":218550919,"number":29,"title":"Warning + wromg output order if same carrierTypes within PPN not contiguous in batch manifest","user":{"login":"bitsgalore","id":1014449,"avatar_url":"https://avatars1.githubusercontent.com/u/1014449?v=3","gravatar_id":"","url":"https://api.github.com/users/bitsgalore","html_url":"https://github.com/bitsgalore","followers_url":"https://api.github.com/users/bitsgalore/followers","following_url":"https://api.github.com/users/bitsgalore/following{/other_user}","gists_url":"https://api.github.com/users/bitsgalore/gists{/gist_id}","starred_url":"https://api.github.com/users/bitsgalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitsgalore/subscriptions","organizations_url":"https://api.github.com/users/bitsgalore/orgs","repos_url":"https://api.github.com/users/bitsgalore/repos","events_url":"https://api.github.com/users/bitsgalore/events{/privacy}","received_events_url":"https://api.github.com/users/bitsgalore/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-31T16:19:16Z","updated_at":"2017-04-03T14:25:33Z","closed_at":"2017-04-03T14:25:33Z","body":"Following batch contains 2 audio cd's that don't appear contiguously in batch manifest:\r\n\r\n    jobID,PPN,volumeNo,carrierType,title,volumeID,success,containsAudio,containsData\r\n    d03ae636-147a-11e7-a687-00237d497a29,155658050,1,cd-audio,(Bijna) alles over bestandsformaten,,True,True,False\r\n    82c34f9a-1481-11e7-9f3c-00237d497a29,155658050,1,cd-rom,(Bijna) alles over bestandsformaten,Handbook,True,False,True\r\n    e03ae676-147a-11e7-a687-00237d497a29,155658050,2,cd-audio,(Bijna) alles over bestandsformaten,,True,True,False\r\n\r\nResult for verify:\r\n\r\n    WARNING - PPN 155658050 (cd-audio): expected '1' as lower value for 'volumeNumber', found '2'\r\n\r\nResult for write, structMap:\r\n\r\n    <mets:structMap>\r\n    <mets:div TYPE=\"physical\" LABEL=\"volumes\">\r\n      <mets:div TYPE=\"cd-audio\" ORDER=\"1\" ADMID=\"DISC_001\">\r\n        <mets:div TYPE=\"audio track\" ORDER=\"1\">\r\n          <mets:fptr FILEID=\"FILE_001\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"2\">\r\n          <mets:fptr FILEID=\"FILE_002\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"3\">\r\n          <mets:fptr FILEID=\"FILE_003\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"4\">\r\n          <mets:fptr FILEID=\"FILE_004\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"5\">\r\n          <mets:fptr FILEID=\"FILE_005\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"6\">\r\n          <mets:fptr FILEID=\"FILE_006\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"7\">\r\n          <mets:fptr FILEID=\"FILE_007\"/>\r\n        </mets:div>\r\n      </mets:div>\r\n      <mets:div TYPE=\"cd-rom\" ORDER=\"1\" ADMID=\"DISC_002\">\r\n        <mets:div TYPE=\"disk image\" ORDER=\"1\">\r\n          <mets:fptr FILEID=\"FILE_008\"/>\r\n        </mets:div>\r\n      </mets:div>\r\n      <mets:div TYPE=\"cd-audio\" ORDER=\"2\" ADMID=\"DISC_003\">\r\n        <mets:div TYPE=\"audio track\" ORDER=\"1\">\r\n          <mets:fptr FILEID=\"FILE_009\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"2\">\r\n          <mets:fptr FILEID=\"FILE_010\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"3\">\r\n          <mets:fptr FILEID=\"FILE_011\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"4\">\r\n          <mets:fptr FILEID=\"FILE_012\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"5\">\r\n          <mets:fptr FILEID=\"FILE_013\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"6\">\r\n          <mets:fptr FILEID=\"FILE_014\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"7\">\r\n          <mets:fptr FILEID=\"FILE_015\"/>\r\n        </mets:div>\r\n        <mets:div TYPE=\"audio track\" ORDER=\"8\">\r\n          <mets:fptr FILEID=\"FILE_016\"/>\r\n        </mets:div>\r\n      </mets:div>\r\n    </mets:div>\r\n    </mets:structMap>\r\n \r\nSo again audio CDs don't appear contiguously. Looks like something goes wrong before *groupby* (check for missing sort?) \r\n\r\nADDITION:\r\n\r\nLooks like what's needed is a sort on *carriers* prior to *groupby*, just as is also done with *rowsBatchManifest*.\r\n\r\nBUT:\r\n\r\n      carriers.sort(key=itemgetter(3))\r\n\r\nResults in:\r\n\r\n    AttributeError: 'itertools._grouper' object has no attribute 'sort'\r\n\r\nSo why does this work for RowsbatchManifest? Because:\r\n \r\ntype(rowsBatchManifest) = <class 'list'>, but type(carriers type) = <class 'itertools._grouper'>. So we need to figure out how to sort s grouper object.\r\n"}}
{"actor":{"display_login":"bitsgalore"}}