{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/tectonic-installer/issues/2288","repository_url":"https://api.github.com/repos/coreos/tectonic-installer","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/2288/labels{/name}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/2288/comments","events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/2288/events","html_url":"https://github.com/coreos/tectonic-installer/pull/2288","id":270481703,"number":2288,"title":"fix external etcd cluster support.","user":{"login":"coresolve","id":25213022,"avatar_url":"https://avatars3.githubusercontent.com/u/25213022?v=4","gravatar_id":"","url":"https://api.github.com/users/coresolve","html_url":"https://github.com/coresolve","followers_url":"https://api.github.com/users/coresolve/followers","following_url":"https://api.github.com/users/coresolve/following{/other_user}","gists_url":"https://api.github.com/users/coresolve/gists{/gist_id}","starred_url":"https://api.github.com/users/coresolve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coresolve/subscriptions","organizations_url":"https://api.github.com/users/coresolve/orgs","repos_url":"https://api.github.com/users/coresolve/repos","events_url":"https://api.github.com/users/coresolve/events{/privacy}","received_events_url":"https://api.github.com/users/coresolve/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-01T23:07:27Z","updated_at":"2017-11-01T23:07:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/2288","html_url":"https://github.com/coreos/tectonic-installer/pull/2288","diff_url":"https://github.com/coreos/tectonic-installer/pull/2288.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/2288.patch"},"body":"With this change:\r\nIf you set `tectonic_etcd_tls_enabled`\r\n- We will use the `https` scheme.\r\n- The default remains true\r\n\r\nIf you set `tectonic_etcd_servers`\r\n- We will assume we are not generating certs for the etcd cluster\r\n- Optionally, you can provide `tectonic_etcd_ca_cert_path` if needed.\r\n\r\n@squat @kyoto \r\n\r\nWith this change the the ui will have to set tectonic_etcd_tls_enabled appropriately based on scheme."},"comment":{"url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments/341269833","html_url":"https://github.com/coreos/tectonic-installer/pull/2288#issuecomment-341269833","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/2288","id":341269833,"user":{"login":"coreosbot","id":6148850,"avatar_url":"https://avatars3.githubusercontent.com/u/6148850?v=4","gravatar_id":"","url":"https://api.github.com/users/coreosbot","html_url":"https://github.com/coreosbot","followers_url":"https://api.github.com/users/coreosbot/followers","following_url":"https://api.github.com/users/coreosbot/following{/other_user}","gists_url":"https://api.github.com/users/coreosbot/gists{/gist_id}","starred_url":"https://api.github.com/users/coreosbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreosbot/subscriptions","organizations_url":"https://api.github.com/users/coreosbot/orgs","repos_url":"https://api.github.com/users/coreosbot/repos","events_url":"https://api.github.com/users/coreosbot/events{/privacy}","received_events_url":"https://api.github.com/users/coreosbot/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T23:07:28Z","updated_at":"2017-11-01T23:07:28Z","author_association":"COLLABORATOR","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"coreosbot"}}