{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/107070667","pull_request_review_id":28020619,"id":107070667,"diff_hunk":"@@ -61,6 +63,37 @@ abstract class SubqueryExpression(\n   }\n }\n \n+/**\n+ * This expression is used to represent any form of subquery expression namely\n+ * ListQuery, Exists and ScalarSubquery. This is only used to make sure the\n+ * expression equality works properly when LogicalPlan.sameResult is called\n+ * on plans containing SubqueryExpression(s). This is only a transient expression\n+ * that only lives in the scope of sameResult function call. In other words, analyzer,\n+ * optimizer or planner never sees this expression type during transformation of\n+ * plans.\n+ */\n+case class CanonicalizedSubqueryExpr(expr: SubqueryExpression)\n+  extends UnaryExpression with Unevaluable {\n+  override def dataType: DataType = expr.dataType\n+  override def nullable: Boolean = expr.nullable\n+  override def child: Expression = expr\n+  override def toString: String = s\"CanonicalizedSubqueryExpr(${expr.toString})\"\n+\n+  // Hashcode is generated conservatively for now i.e it does not include the\n+  // sub query plan. Doing so causes issue when we canonicalize expressions to\n+  // re-order them based on hashcode.\n+  // TODO : improve the hashcode generation by considering the plan info.\n+  override def hashCode(): Int = {\n+    val h = Objects.hashCode(expr.children)","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala","position":34,"original_position":34,"commit_id":"0c6424574282db0e865ef4ad14c5a9179fcf27ef","original_commit_id":"0c6424574282db0e865ef4ad14c5a9179fcf27ef","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars0.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"after [canonicalize](https://github.com/apache/spark/pull/17330/files#diff-203ac90583cebe29a92c1d812c07f102R392), the ordering should be deterministic, right?","created_at":"2017-03-21T04:22:44Z","updated_at":"2017-03-21T04:22:44Z","html_url":"https://github.com/apache/spark/pull/17330#discussion_r107070667","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/17330","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/107070667"},"html":{"href":"https://github.com/apache/spark/pull/17330#discussion_r107070667"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/17330"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17330","id":111224160,"html_url":"https://github.com/apache/spark/pull/17330","diff_url":"https://github.com/apache/spark/pull/17330.diff","patch_url":"https://github.com/apache/spark/pull/17330.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/17330","number":17330,"state":"open","locked":false,"title":"[SPARK-19993][SQL] Caching logical plans containing subquery expressions does not work.","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars3.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nThe sameResult() method does not work when the logical plan contains subquery expressions.\r\n\r\n**Before the fix**\r\n```SQL\r\nscala> val ds = spark.sql(\"select * from s1 where s1.c1 in (select s2.c1 from s2 where s1.c1 = s2.c1)\")\r\nds: org.apache.spark.sql.DataFrame = [c1: int]\r\n\r\nscala> ds.cache\r\nres13: ds.type = [c1: int]\r\n\r\nscala> spark.sql(\"select * from s1 where s1.c1 in (select s2.c1 from s2 where s1.c1 = s2.c1)\").explain(true)\r\n== Analyzed Logical Plan ==\r\nc1: int\r\nProject [c1#86]\r\n+- Filter c1#86 IN (list#78 [c1#86])\r\n   :  +- Project [c1#87]\r\n   :     +- Filter (outer(c1#86) = c1#87)\r\n   :        +- SubqueryAlias s2\r\n   :           +- Relation[c1#87] parquet\r\n   +- SubqueryAlias s1\r\n      +- Relation[c1#86] parquet\r\n\r\n== Optimized Logical Plan ==\r\nJoin LeftSemi, ((c1#86 = c1#87) && (c1#86 = c1#87))\r\n:- Relation[c1#86] parquet\r\n+- Relation[c1#87] parquet\r\n```\r\n**Plan after fix**\r\n```SQL\r\n== Analyzed Logical Plan ==\r\nc1: int\r\nProject [c1#22]\r\n+- Filter c1#22 IN (list#14 [c1#22])\r\n   :  +- Project [c1#23]\r\n   :     +- Filter (outer(c1#22) = c1#23)\r\n   :        +- SubqueryAlias s2\r\n   :           +- Relation[c1#23] parquet\r\n   +- SubqueryAlias s1\r\n      +- Relation[c1#22] parquet\r\n\r\n== Optimized Logical Plan ==\r\nInMemoryRelation [c1#22], true, 10000, StorageLevel(disk, memory, deserialized, 1 replicas)\r\n   +- *BroadcastHashJoin [c1#1, c1#1], [c1#2, c1#2], LeftSemi, BuildRight\r\n      :- *FileScan parquet default.s1[c1#1] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/Users/dbiswal/mygit/apache/spark/bin/spark-warehouse/s1], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c1:int>\r\n      +- BroadcastExchange HashedRelationBroadcastMode(List((shiftleft(cast(input[0, int, true] as bigint), 32) | (cast(input[0, int, true] as bigint) & 4294967295))))\r\n         +- *FileScan parquet default.s2[c1#2] Batched: true, Format: Parquet, Location: InMemoryFileIndex[file:/Users/dbiswal/mygit/apache/spark/bin/spark-warehouse/s2], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c1:int>\r\n```\r\n## How was this patch tested?\r\nNew tests are added to CachedTableSuite.\r\n","created_at":"2017-03-17T06:58:47Z","updated_at":"2017-03-21T04:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a286c083f5371ea5e7974e416649fbc3c7fb1352","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/17330/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/17330/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/17330/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0c6424574282db0e865ef4ad14c5a9179fcf27ef","head":{"label":"dilipbiswal:subquery_cache_final","ref":"subquery_cache_final","sha":"0c6424574282db0e865ef4ad14c5a9179fcf27ef","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars3.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"repo":{"id":42921897,"name":"spark","full_name":"dilipbiswal/spark","owner":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars3.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilipbiswal/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dilipbiswal/spark","forks_url":"https://api.github.com/repos/dilipbiswal/spark/forks","keys_url":"https://api.github.com/repos/dilipbiswal/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilipbiswal/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilipbiswal/spark/teams","hooks_url":"https://api.github.com/repos/dilipbiswal/spark/hooks","issue_events_url":"https://api.github.com/repos/dilipbiswal/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dilipbiswal/spark/events","assignees_url":"https://api.github.com/repos/dilipbiswal/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dilipbiswal/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dilipbiswal/spark/tags","blobs_url":"https://api.github.com/repos/dilipbiswal/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilipbiswal/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilipbiswal/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilipbiswal/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilipbiswal/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dilipbiswal/spark/languages","stargazers_url":"https://api.github.com/repos/dilipbiswal/spark/stargazers","contributors_url":"https://api.github.com/repos/dilipbiswal/spark/contributors","subscribers_url":"https://api.github.com/repos/dilipbiswal/spark/subscribers","subscription_url":"https://api.github.com/repos/dilipbiswal/spark/subscription","commits_url":"https://api.github.com/repos/dilipbiswal/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilipbiswal/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilipbiswal/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilipbiswal/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilipbiswal/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dilipbiswal/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilipbiswal/spark/merges","archive_url":"https://api.github.com/repos/dilipbiswal/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilipbiswal/spark/downloads","issues_url":"https://api.github.com/repos/dilipbiswal/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dilipbiswal/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dilipbiswal/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dilipbiswal/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilipbiswal/spark/labels{/name}","releases_url":"https://api.github.com/repos/dilipbiswal/spark/releases{/id}","deployments_url":"https://api.github.com/repos/dilipbiswal/spark/deployments","created_at":"2015-09-22T08:39:46Z","updated_at":"2016-04-06T08:56:13Z","pushed_at":"2017-03-19T07:14:58Z","git_url":"git://github.com/dilipbiswal/spark.git","ssh_url":"git@github.com:dilipbiswal/spark.git","clone_url":"https://github.com/dilipbiswal/spark.git","svn_url":"https://github.com/dilipbiswal/spark","homepage":null,"size":254113,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8537c00e0a17eff2a8c6745fbdd1d08873c0434d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-03-21T04:05:48Z","pushed_at":"2017-03-21T04:22:18Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":265641,"stargazers_count":12104,"watchers_count":12104,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11388,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":477,"forks":11388,"open_issues":477,"watchers":12104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/17330"},"html":{"href":"https://github.com/apache/spark/pull/17330"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/17330"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/17330/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/17330/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/17330/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0c6424574282db0e865ef4ad14c5a9179fcf27ef"}}}}
{"actor":{"display_login":"cloud-fan"}}