{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/146440215","pull_request_review_id":71381829,"id":146440215,"diff_hunk":"@@ -853,7 +853,7 @@ class ObjectStore {\n     /// offset of buffer as aligned to destination within object.\n     int get_data_alignment() {\n       if (!data.largest_data_len)\n-\treturn -1;\n+\treturn 0;\n       return (0 - get_data_offset()) & ~CEPH_PAGE_MASK;","path":"src/os/ObjectStore.h","position":6,"original_position":6,"commit_id":"bfdf4387900368253902c82fdd13412829aa4ae2","original_commit_id":"bfdf4387900368253902c82fdd13412829aa4ae2","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars2.githubusercontent.com/u/980577?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"body":"no, it should be ok, because (& ~CEPH_PAGE_MASK) will get a right value","created_at":"2017-10-24T02:28:52Z","updated_at":"2017-10-24T02:28:52Z","html_url":"https://github.com/ceph/ceph/pull/18475#discussion_r146440215","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/18475","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/146440215"},"html":{"href":"https://github.com/ceph/ceph/pull/18475#discussion_r146440215"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18475"}},"in_reply_to_id":146412938},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/18475","id":148072340,"html_url":"https://github.com/ceph/ceph/pull/18475","diff_url":"https://github.com/ceph/ceph/pull/18475.diff","patch_url":"https://github.com/ceph/ceph/pull/18475.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/18475","number":18475,"state":"open","locked":false,"title":"os/ObjectStore: fix get_data_alignment return -1 causing problem in msg header","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars2.githubusercontent.com/u/980577?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"body":"sizeof(data_off) in ceph_msg_header is uint16_t, so -1 will be 65535. When peer\r\nside receive MOSDRepOp message, it will allocate extra 1 byte buffer to store\r\nnonexisted buffer.\r\n\r\nSigned-off-by: Haomai Wang <haomai@xsky.com>","created_at":"2017-10-23T08:51:07Z","updated_at":"2017-10-24T02:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c12e19a672ad5bc2fdd1c69719514bd56c30d32b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/18475/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/18475/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/18475/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bfdf4387900368253902c82fdd13412829aa4ae2","head":{"label":"yuyuyu101:wip-fix-alignment","ref":"wip-fix-alignment","sha":"bfdf4387900368253902c82fdd13412829aa4ae2","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars2.githubusercontent.com/u/980577?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"repo":{"id":13030337,"name":"ceph","full_name":"yuyuyu101/ceph","owner":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars2.githubusercontent.com/u/980577?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuyuyu101/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yuyuyu101/ceph","forks_url":"https://api.github.com/repos/yuyuyu101/ceph/forks","keys_url":"https://api.github.com/repos/yuyuyu101/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuyuyu101/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuyuyu101/ceph/teams","hooks_url":"https://api.github.com/repos/yuyuyu101/ceph/hooks","issue_events_url":"https://api.github.com/repos/yuyuyu101/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yuyuyu101/ceph/events","assignees_url":"https://api.github.com/repos/yuyuyu101/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yuyuyu101/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yuyuyu101/ceph/tags","blobs_url":"https://api.github.com/repos/yuyuyu101/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuyuyu101/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuyuyu101/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuyuyu101/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuyuyu101/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yuyuyu101/ceph/languages","stargazers_url":"https://api.github.com/repos/yuyuyu101/ceph/stargazers","contributors_url":"https://api.github.com/repos/yuyuyu101/ceph/contributors","subscribers_url":"https://api.github.com/repos/yuyuyu101/ceph/subscribers","subscription_url":"https://api.github.com/repos/yuyuyu101/ceph/subscription","commits_url":"https://api.github.com/repos/yuyuyu101/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuyuyu101/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuyuyu101/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuyuyu101/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuyuyu101/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yuyuyu101/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuyuyu101/ceph/merges","archive_url":"https://api.github.com/repos/yuyuyu101/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuyuyu101/ceph/downloads","issues_url":"https://api.github.com/repos/yuyuyu101/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yuyuyu101/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yuyuyu101/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yuyuyu101/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuyuyu101/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yuyuyu101/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yuyuyu101/ceph/deployments","created_at":"2013-09-23T08:18:33Z","updated_at":"2017-03-04T15:16:24Z","pushed_at":"2017-10-23T08:55:41Z","git_url":"git://github.com/yuyuyu101/ceph.git","ssh_url":"git@github.com:yuyuyu101/ceph.git","clone_url":"https://github.com/yuyuyu101/ceph.git","svn_url":"https://github.com/yuyuyu101/ceph","homepage":"http://ceph.com","size":229522,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"2f7ae0e160e52b33b6d10dacddc00e20094857f0","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-10-24T01:54:53Z","pushed_at":"2017-10-24T02:21:42Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":250852,"stargazers_count":3737,"watchers_count":3737,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2151,"mirror_url":null,"archived":false,"open_issues_count":540,"forks":2151,"open_issues":540,"watchers":3737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18475"},"html":{"href":"https://github.com/ceph/ceph/pull/18475"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/18475"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/18475/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18475/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18475/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bfdf4387900368253902c82fdd13412829aa4ae2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yuyuyu101"}}