{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/1750","repository_url":"https://api.github.com/repos/material-components/material-components-ios","labels_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1750/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1750/comments","events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1750/events","html_url":"https://github.com/material-components/material-components-ios/issues/1750","id":248553193,"number":1750,"title":"[Button] Unexpected Title Color","user":{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false},"labels":[{"id":346532452,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/is:Needing%20research","name":"is:Needing research","color":"F29E73","default":false},{"id":360085424,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/type:Visual%20bug","name":"type:Visual bug","color":"F44336","default":false},{"id":321577458,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/where:Buttons","name":"where:Buttons","color":"2196F3","default":false}],"state":"open","locked":false,"assignee":{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false},"assignees":[{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false},{"login":"samnm","id":1251373,"avatar_url":"https://avatars2.githubusercontent.com/u/1251373?v=4","gravatar_id":"","url":"https://api.github.com/users/samnm","html_url":"https://github.com/samnm","followers_url":"https://api.github.com/users/samnm/followers","following_url":"https://api.github.com/users/samnm/following{/other_user}","gists_url":"https://api.github.com/users/samnm/gists{/gist_id}","starred_url":"https://api.github.com/users/samnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samnm/subscriptions","organizations_url":"https://api.github.com/users/samnm/orgs","repos_url":"https://api.github.com/users/samnm/repos","events_url":"https://api.github.com/users/samnm/events{/privacy}","received_events_url":"https://api.github.com/users/samnm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-08-07T22:51:31Z","updated_at":"2017-08-08T14:12:01Z","closed_at":null,"body":"#1725 introduced a change into the rendering of the button.\r\n\r\nOriginally we calculated a title color based on the background.  Now we are setting an explicit value (black).\r\n\r\nThis has lead to unexpected rendering results for some of our clients.\r\n\r\nDo we want to set sane default colors for all of our components?\r\nDo we want to calculate reasonable title colors based on the background value set?\r\n"},"comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments/320968172","html_url":"https://github.com/material-components/material-components-ios/issues/1750#issuecomment-320968172","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1750","id":320968172,"user":{"login":"romoore","id":1753199,"avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T14:12:01Z","updated_at":"2017-08-08T14:12:01Z","body":"I would suggest that all of our components should come with default colors that are compatible with one another.  In other words, if I built a UI without setting any specific colors, I should get something that is not impossible to use (but not necessarily beautiful).  That being said, aren't buttons supposed to get their title color from the tintColor?\r\n\r\n>You can specify a custom button tint using the tintColor property. This property sets the color of the button image and text. If you do not explicitly set a tint color, the button uses its superview’s tint color.\r\n&mdash; https://developer.apple.com/documentation/uikit/uibutton"}}
{"actor":{"display_login":"romoore"}}