{"action":"created","issue":{"url":"https://api.github.com/repos/libtom/libtomcrypt/issues/186","repository_url":"https://api.github.com/repos/libtom/libtomcrypt","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/186/comments","events_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/186/events","html_url":"https://github.com/libtom/libtomcrypt/pull/186","id":219083280,"number":186,"title":"Move rc4 + sober128 to src/stream/","user":{"login":"karel-m","id":1918753,"avatar_url":"https://avatars1.githubusercontent.com/u/1918753?v=3","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"karel-m","id":1918753,"avatar_url":"https://avatars1.githubusercontent.com/u/1918753?v=3","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false},"assignees":[{"login":"karel-m","id":1918753,"avatar_url":"https://avatars1.githubusercontent.com/u/1918753?v=3","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/1","html_url":"https://github.com/libtom/libtomcrypt/milestone/1","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/1/labels","id":370469,"number":1,"title":"v1.18.0","description":"","creator":{"login":"sjaeckel","id":294374,"avatar_url":"https://avatars1.githubusercontent.com/u/294374?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaeckel","html_url":"https://github.com/sjaeckel","followers_url":"https://api.github.com/users/sjaeckel/followers","following_url":"https://api.github.com/users/sjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/sjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaeckel/subscriptions","organizations_url":"https://api.github.com/users/sjaeckel/orgs","repos_url":"https://api.github.com/users/sjaeckel/repos","events_url":"https://api.github.com/users/sjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/sjaeckel/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":95,"state":"open","created_at":"2013-07-04T11:54:15Z","updated_at":"2017-04-24T08:42:49Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2017-04-03T22:46:06Z","updated_at":"2017-04-24T19:36:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/186","html_url":"https://github.com/libtom/libtomcrypt/pull/186","diff_url":"https://github.com/libtom/libtomcrypt/pull/186.diff","patch_url":"https://github.com/libtom/libtomcrypt/pull/186.patch"},"body":"The basic idea is to have `rc4` + `sober128` stream API in `src/stream` like we have with `chacha`:\r\n```\r\nint rc4_setup(rc4_state *st, const unsigned char *key, unsigned long keylen);\r\nint rc4_crypt(rc4_state *st, const unsigned char *in, unsigned long inlen, unsigned char *out);\r\nint rc4_keystream(rc4_state *st, unsigned char *out, unsigned long outlen);\r\nint rc4_done(rc4_state *st);\r\n\r\nint sober128_setup(sober128_state *st, const unsigned char *key, unsigned long keylen);\r\nint sober128_setiv(sober128_state *st, const unsigned char *iv, unsigned long ivlen);\r\nint sober128_crypt(sober128_state *st, const unsigned char *in, unsigned long inlen, unsigned char *out);\r\nint sober128_keystream(sober128_state *st, unsigned char *out, unsigned long outlen);\r\nint sober128_done(sober128_state *st);\r\n```\r\n\r\nThe idea of having stream cipher in `src/stream/` first appeared in #171\r\n\r\nThe main trouble with this PR is that quite significant (and backwards incompatible) changes need to be applied to original rc4/sober128 PRNG code.\r\n\r\nThe code in the PR is not ready for review yet but as usual any feedback welcome."},"comment":{"url":"https://api.github.com/repos/libtom/libtomcrypt/issues/comments/296799475","html_url":"https://github.com/libtom/libtomcrypt/pull/186#issuecomment-296799475","issue_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/186","id":296799475,"user":{"login":"sjaeckel","id":294374,"avatar_url":"https://avatars1.githubusercontent.com/u/294374?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaeckel","html_url":"https://github.com/sjaeckel","followers_url":"https://api.github.com/users/sjaeckel/followers","following_url":"https://api.github.com/users/sjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/sjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaeckel/subscriptions","organizations_url":"https://api.github.com/users/sjaeckel/orgs","repos_url":"https://api.github.com/users/sjaeckel/repos","events_url":"https://api.github.com/users/sjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/sjaeckel/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T19:36:41Z","updated_at":"2017-04-24T19:36:41Z","body":"> Q1: should I rename it to shorter LTC_CHACHA20?\r\n\r\nyes, `LTC_CHACHA20` and `LTC_CHACHA20_PRNG`\r\n\r\n> Q2: should I rename it too to chacha_stream_done?\r\n\r\nno\r\n\r\n> Q3: should I rename them all (chacha, rc4, sober128) to <something>_stream_<something>?\r\n\r\nI'd say only rc4 and sober128 - `{rc4,sober128}_stream_<something>` but `chacha20_<something>`\r\n\r\n"}}
{"actor":{"display_login":"sjaeckel"}}