{"action":"opened","issue":{"url":"https://api.github.com/repos/nextic/IC/issues/389","repository_url":"https://api.github.com/repos/nextic/IC","labels_url":"https://api.github.com/repos/nextic/IC/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/nextic/IC/issues/389/comments","events_url":"https://api.github.com/repos/nextic/IC/issues/389/events","html_url":"https://github.com/nextic/IC/issues/389","id":271509755,"number":389,"title":"Possible bug in voxelize_hits","user":{"login":"paolafer","id":8114436,"avatar_url":"https://avatars0.githubusercontent.com/u/8114436?v=4","gravatar_id":"","url":"https://api.github.com/users/paolafer","html_url":"https://github.com/paolafer","followers_url":"https://api.github.com/users/paolafer/followers","following_url":"https://api.github.com/users/paolafer/following{/other_user}","gists_url":"https://api.github.com/users/paolafer/gists{/gist_id}","starred_url":"https://api.github.com/users/paolafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolafer/subscriptions","organizations_url":"https://api.github.com/users/paolafer/orgs","repos_url":"https://api.github.com/users/paolafer/repos","events_url":"https://api.github.com/users/paolafer/events{/privacy}","received_events_url":"https://api.github.com/users/paolafer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-06T15:15:22Z","updated_at":"2017-11-06T15:15:22Z","closed_at":null,"author_association":"COLLABORATOR","body":"After a careful comparison of our codes and results using paolina functions, @jerenner and myself realized that, using different versions of those functions, the results change substantially.\r\nIn particular, while I'm using the current master, Josh is using a master at commit 07e9f9a21bc97bdedfd90d66a89d713a301ab99a.\r\nIn particular, the energy distribution of the blobs is very different, the selection of events being the same.\r\nAs an example, I attach one event of data, where the new master reconstructs two blobs with really small energy and the older version reconstructs two blobs with similar and quite high energy. I attach a file with the reconstructed hits and two files with the list of voxels and blobs given by the old (bug_josh) and the current (bug_new) versions of the master.\r\n[possible_bug.zip](https://github.com/nextic/IC/files/1446656/possible_bug.zip)\r\n\r\nWhether the correct result is the one with the new or with the old version, is not clear to me. The only difference is in the way we define the boundaries of the voxels, which shouldn't introduce such a big difference. If it does, we should study why the old (and incorrect, in the sense that it didn't do what we wanted) version gives better results, since it may open a window to improving the code."}}
{"actor":{"display_login":"paolafer"}}