{"action":"created","comment":{"url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/comments/128892461","pull_request_review_id":51618583,"id":128892461,"diff_hunk":"@@ -424,9 +424,13 @@ AC_SEARCH_LIBS(\n # Lastly, take care of crosstool-NG internal values\n #--------------------------------------------------------------------\n # Hey! We need the date! :-)\n-AC_SUBST(\n-    [DATE],\n-    [$(date +%Y%m%d)])\n+DATE_FMT=\"%Y%m%d\"\n+if test \"x$SOURCE_DATE_EPOCH\" = \"x\"; then\n+    DATE=$(date \"+$DATE_FMT\")\n+else\n+    DATE=\"$(date -u -d \"@$SOURCE_DATE_EPOCH\" \"+$DATE_FMT\" 2>/dev/null || date -u -r \"$SOURCE_DATE_EPOCH\" \"+$DATE_FMT\" 2>/dev/null || date -u \"+$DATE_FMT\")\"\n+fi\n+AC_SUBST([DATE])","path":"configure.ac","position":13,"original_position":13,"commit_id":"b8c5b2cf27e1933cc51d066afa83bc66529b5db6","original_commit_id":"b8c5b2cf27e1933cc51d066afa83bc66529b5db6","user":{"login":"cpackham","id":155667,"avatar_url":"https://avatars1.githubusercontent.com/u/155667?v=4","gravatar_id":"","url":"https://api.github.com/users/cpackham","html_url":"https://github.com/cpackham","followers_url":"https://api.github.com/users/cpackham/followers","following_url":"https://api.github.com/users/cpackham/following{/other_user}","gists_url":"https://api.github.com/users/cpackham/gists{/gist_id}","starred_url":"https://api.github.com/users/cpackham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpackham/subscriptions","organizations_url":"https://api.github.com/users/cpackham/orgs","repos_url":"https://api.github.com/users/cpackham/repos","events_url":"https://api.github.com/users/cpackham/events{/privacy}","received_events_url":"https://api.github.com/users/cpackham/received_events","type":"User","site_admin":false},"body":"Should be fine. According to the [autoconf manual](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Setting-Output-Variables.html#index-AC_005fSUBST-1203) this would substitute instances of `@DATE@` with the shell variable `$DATE`. The second form of `AC_SUBST([DATE], [$something])` is only needed because the variable names are different.\r\n\r\nStill should actually be tested (which I haven't done).","created_at":"2017-07-22T08:23:38Z","updated_at":"2017-07-22T08:25:56Z","html_url":"https://github.com/crosstool-ng/crosstool-ng/pull/784#discussion_r128892461","pull_request_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784","_links":{"self":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/comments/128892461"},"html":{"href":"https://github.com/crosstool-ng/crosstool-ng/pull/784#discussion_r128892461"},"pull_request":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784"}}},"pull_request":{"url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784","id":131775961,"html_url":"https://github.com/crosstool-ng/crosstool-ng/pull/784","diff_url":"https://github.com/crosstool-ng/crosstool-ng/pull/784.diff","patch_url":"https://github.com/crosstool-ng/crosstool-ng/pull/784.patch","issue_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/784","number":784,"state":"open","locked":false,"title":"Allow for reproducible builds","user":{"login":"bmwiedemann","id":637990,"avatar_url":"https://avatars3.githubusercontent.com/u/637990?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwiedemann","html_url":"https://github.com/bmwiedemann","followers_url":"https://api.github.com/users/bmwiedemann/followers","following_url":"https://api.github.com/users/bmwiedemann/following{/other_user}","gists_url":"https://api.github.com/users/bmwiedemann/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwiedemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwiedemann/subscriptions","organizations_url":"https://api.github.com/users/bmwiedemann/orgs","repos_url":"https://api.github.com/users/bmwiedemann/repos","events_url":"https://api.github.com/users/bmwiedemann/events{/privacy}","received_events_url":"https://api.github.com/users/bmwiedemann/received_events","type":"User","site_admin":false},"body":"Allow to override build date\r\nin order to make builds reproducible.\r\nSee https://reproducible-builds.org/ for why this is good\r\nand https://reproducible-builds.org/specs/source-date-epoch/\r\nfor the definition of this variable.\r\n\r\nThis date call is designed to work with both GNU date and BSD date.\r\n\r\nNote: is not properly tested yet","created_at":"2017-07-21T13:37:35Z","updated_at":"2017-07-22T08:25:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d4bb87a8b11de5bcf9617b67e3ac4ae80150dc1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784/commits","review_comments_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784/comments","review_comment_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/784/comments","statuses_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/statuses/b8c5b2cf27e1933cc51d066afa83bc66529b5db6","head":{"label":"bmwiedemann:date","ref":"date","sha":"b8c5b2cf27e1933cc51d066afa83bc66529b5db6","user":{"login":"bmwiedemann","id":637990,"avatar_url":"https://avatars3.githubusercontent.com/u/637990?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwiedemann","html_url":"https://github.com/bmwiedemann","followers_url":"https://api.github.com/users/bmwiedemann/followers","following_url":"https://api.github.com/users/bmwiedemann/following{/other_user}","gists_url":"https://api.github.com/users/bmwiedemann/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwiedemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwiedemann/subscriptions","organizations_url":"https://api.github.com/users/bmwiedemann/orgs","repos_url":"https://api.github.com/users/bmwiedemann/repos","events_url":"https://api.github.com/users/bmwiedemann/events{/privacy}","received_events_url":"https://api.github.com/users/bmwiedemann/received_events","type":"User","site_admin":false},"repo":{"id":94709159,"name":"crosstool-ng","full_name":"bmwiedemann/crosstool-ng","owner":{"login":"bmwiedemann","id":637990,"avatar_url":"https://avatars3.githubusercontent.com/u/637990?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwiedemann","html_url":"https://github.com/bmwiedemann","followers_url":"https://api.github.com/users/bmwiedemann/followers","following_url":"https://api.github.com/users/bmwiedemann/following{/other_user}","gists_url":"https://api.github.com/users/bmwiedemann/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwiedemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwiedemann/subscriptions","organizations_url":"https://api.github.com/users/bmwiedemann/orgs","repos_url":"https://api.github.com/users/bmwiedemann/repos","events_url":"https://api.github.com/users/bmwiedemann/events{/privacy}","received_events_url":"https://api.github.com/users/bmwiedemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmwiedemann/crosstool-ng","description":"A versatile (cross-)toolchain generator.","fork":true,"url":"https://api.github.com/repos/bmwiedemann/crosstool-ng","forks_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/forks","keys_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/teams","hooks_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/hooks","issue_events_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/issues/events{/number}","events_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/events","assignees_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/assignees{/user}","branches_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/branches{/branch}","tags_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/tags","blobs_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/languages","stargazers_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/stargazers","contributors_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/contributors","subscribers_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/subscribers","subscription_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/subscription","commits_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/contents/{+path}","compare_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/merges","archive_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/downloads","issues_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/issues{/number}","pulls_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/labels{/name}","releases_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/releases{/id}","deployments_url":"https://api.github.com/repos/bmwiedemann/crosstool-ng/deployments","created_at":"2017-06-18T19:43:05Z","updated_at":"2017-06-18T19:43:09Z","pushed_at":"2017-07-21T13:35:22Z","git_url":"git://github.com/bmwiedemann/crosstool-ng.git","ssh_url":"git@github.com:bmwiedemann/crosstool-ng.git","clone_url":"https://github.com/bmwiedemann/crosstool-ng.git","svn_url":"https://github.com/bmwiedemann/crosstool-ng","homepage":null,"size":12477,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosstool-ng:master","ref":"master","sha":"bcaec4d80a1099a1039520cae47f11957809e217","user":{"login":"crosstool-ng","id":10093964,"avatar_url":"https://avatars1.githubusercontent.com/u/10093964?v=4","gravatar_id":"","url":"https://api.github.com/users/crosstool-ng","html_url":"https://github.com/crosstool-ng","followers_url":"https://api.github.com/users/crosstool-ng/followers","following_url":"https://api.github.com/users/crosstool-ng/following{/other_user}","gists_url":"https://api.github.com/users/crosstool-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/crosstool-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosstool-ng/subscriptions","organizations_url":"https://api.github.com/users/crosstool-ng/orgs","repos_url":"https://api.github.com/users/crosstool-ng/repos","events_url":"https://api.github.com/users/crosstool-ng/events{/privacy}","received_events_url":"https://api.github.com/users/crosstool-ng/received_events","type":"Organization","site_admin":false},"repo":{"id":27619584,"name":"crosstool-ng","full_name":"crosstool-ng/crosstool-ng","owner":{"login":"crosstool-ng","id":10093964,"avatar_url":"https://avatars1.githubusercontent.com/u/10093964?v=4","gravatar_id":"","url":"https://api.github.com/users/crosstool-ng","html_url":"https://github.com/crosstool-ng","followers_url":"https://api.github.com/users/crosstool-ng/followers","following_url":"https://api.github.com/users/crosstool-ng/following{/other_user}","gists_url":"https://api.github.com/users/crosstool-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/crosstool-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosstool-ng/subscriptions","organizations_url":"https://api.github.com/users/crosstool-ng/orgs","repos_url":"https://api.github.com/users/crosstool-ng/repos","events_url":"https://api.github.com/users/crosstool-ng/events{/privacy}","received_events_url":"https://api.github.com/users/crosstool-ng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosstool-ng/crosstool-ng","description":"A versatile (cross-)toolchain generator.","fork":false,"url":"https://api.github.com/repos/crosstool-ng/crosstool-ng","forks_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/forks","keys_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/teams","hooks_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/hooks","issue_events_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/events{/number}","events_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/events","assignees_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/assignees{/user}","branches_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/branches{/branch}","tags_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/tags","blobs_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/languages","stargazers_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/stargazers","contributors_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/contributors","subscribers_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/subscribers","subscription_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/subscription","commits_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/contents/{+path}","compare_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/merges","archive_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/downloads","issues_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues{/number}","pulls_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/labels{/name}","releases_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/releases{/id}","deployments_url":"https://api.github.com/repos/crosstool-ng/crosstool-ng/deployments","created_at":"2014-12-06T02:40:21Z","updated_at":"2017-07-20T15:44:03Z","pushed_at":"2017-07-21T13:37:35Z","git_url":"git://github.com/crosstool-ng/crosstool-ng.git","ssh_url":"git@github.com:crosstool-ng/crosstool-ng.git","clone_url":"https://github.com/crosstool-ng/crosstool-ng.git","svn_url":"https://github.com/crosstool-ng/crosstool-ng","homepage":null,"size":12781,"stargazers_count":465,"watchers_count":465,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":44,"forks":196,"open_issues":44,"watchers":465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784"},"html":{"href":"https://github.com/crosstool-ng/crosstool-ng/pull/784"},"issue":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/784"},"comments":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/crosstool-ng/crosstool-ng/statuses/b8c5b2cf27e1933cc51d066afa83bc66529b5db6"}}}}
{"actor":{"display_login":"cpackham"}}