{"action":"created","comment":{"url":"https://api.github.com/repos/google/tie/pulls/comments/112093313","pull_request_review_id":33382000,"id":112093313,"diff_hunk":"@@ -23,9 +23,6 @@ tie.factory('FeedbackParagraphObjectFactory', [\n     var PARAGRAPH_TYPE_CODE = 'code';\n \n     var FeedbackParagraph = function(type, content) {\n-      if ([PARAGRAPH_TYPE_CODE, PARAGRAPH_TYPE_TEXT].indexOf(type) === -1) {\n-        throw Error('Could not construct feedback paragraph of type: ' + type);\n-      }","path":"client/domain/FeedbackParagraphObjectFactory.js","position":6,"original_position":6,"commit_id":"541f3d6cb9d91630cdfe0deb1e6b58e294cab22e","original_commit_id":"541f3d6cb9d91630cdfe0deb1e6b58e294cab22e","user":{"login":"alblin","id":27439263,"avatar_url":"https://avatars3.githubusercontent.com/u/27439263?v=3","gravatar_id":"","url":"https://api.github.com/users/alblin","html_url":"https://github.com/alblin","followers_url":"https://api.github.com/users/alblin/followers","following_url":"https://api.github.com/users/alblin/following{/other_user}","gists_url":"https://api.github.com/users/alblin/gists{/gist_id}","starred_url":"https://api.github.com/users/alblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alblin/subscriptions","organizations_url":"https://api.github.com/users/alblin/orgs","repos_url":"https://api.github.com/users/alblin/repos","events_url":"https://api.github.com/users/alblin/events{/privacy}","received_events_url":"https://api.github.com/users/alblin/received_events","type":"User","site_admin":false},"body":"As noted, this code cannot be hit because of the way static methods are defined in this class.","created_at":"2017-04-19T00:18:38Z","updated_at":"2017-04-19T00:18:39Z","html_url":"https://github.com/google/tie/pull/229#discussion_r112093313","pull_request_url":"https://api.github.com/repos/google/tie/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/comments/112093313"},"html":{"href":"https://github.com/google/tie/pull/229#discussion_r112093313"},"pull_request":{"href":"https://api.github.com/repos/google/tie/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/google/tie/pulls/229","id":116424827,"html_url":"https://github.com/google/tie/pull/229","diff_url":"https://github.com/google/tie/pull/229.diff","patch_url":"https://github.com/google/tie/pull/229.patch","issue_url":"https://api.github.com/repos/google/tie/issues/229","number":229,"state":"open","locked":false,"title":"Fix #222: 100% karma coverage for domain/","user":{"login":"alblin","id":27439263,"avatar_url":"https://avatars3.githubusercontent.com/u/27439263?v=3","gravatar_id":"","url":"https://api.github.com/users/alblin","html_url":"https://github.com/alblin","followers_url":"https://api.github.com/users/alblin/followers","following_url":"https://api.github.com/users/alblin/following{/other_user}","gists_url":"https://api.github.com/users/alblin/gists{/gist_id}","starred_url":"https://api.github.com/users/alblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alblin/subscriptions","organizations_url":"https://api.github.com/users/alblin/orgs","repos_url":"https://api.github.com/users/alblin/repos","events_url":"https://api.github.com/users/alblin/events{/privacy}","received_events_url":"https://api.github.com/users/alblin/received_events","type":"User","site_admin":false},"body":"CodeEvalResultObjectFactory, CorrectnessTestObjectFactory, FeedbackObjectFactory, SnapshotObjectFactory\r\n\r\nsee issue #222 ","created_at":"2017-04-18T21:28:56Z","updated_at":"2017-04-19T00:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28250ebd3710dbdfc2c1ee8138b030f3dbfe9b63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/tie/pulls/229/commits","review_comments_url":"https://api.github.com/repos/google/tie/pulls/229/comments","review_comment_url":"https://api.github.com/repos/google/tie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/tie/issues/229/comments","statuses_url":"https://api.github.com/repos/google/tie/statuses/541f3d6cb9d91630cdfe0deb1e6b58e294cab22e","head":{"label":"google:domainKarmaCoverage","ref":"domainKarmaCoverage","sha":"541f3d6cb9d91630cdfe0deb1e6b58e294cab22e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-04-18T20:10:50Z","pushed_at":"2017-04-19T00:16:38Z","git_url":"git://github.com/google/tie.git","ssh_url":"git@github.com:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":1086,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":52,"forks":12,"open_issues":52,"watchers":75,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"7c44474fc6363c53b330649a09761e640a1e4af4","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-04-18T20:10:50Z","pushed_at":"2017-04-19T00:16:38Z","git_url":"git://github.com/google/tie.git","ssh_url":"git@github.com:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":1086,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":52,"forks":12,"open_issues":52,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/229"},"html":{"href":"https://github.com/google/tie/pull/229"},"issue":{"href":"https://api.github.com/repos/google/tie/issues/229"},"comments":{"href":"https://api.github.com/repos/google/tie/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/google/tie/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/google/tie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/tie/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/google/tie/statuses/541f3d6cb9d91630cdfe0deb1e6b58e294cab22e"}}}}
{"actor":{"display_login":"alblin"}}