{"action":"created","issue":{"url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/21","repository_url":"https://api.github.com/repos/fusionalliance/autorenter-react","labels_url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/21/comments","events_url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/21/events","html_url":"https://github.com/fusionalliance/autorenter-react/issues/21","id":246846535,"number":21,"title":"Don't access store directly","user":{"login":"jimmyhmiller","id":6071338,"avatar_url":"https://avatars1.githubusercontent.com/u/6071338?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmyhmiller","html_url":"https://github.com/jimmyhmiller","followers_url":"https://api.github.com/users/jimmyhmiller/followers","following_url":"https://api.github.com/users/jimmyhmiller/following{/other_user}","gists_url":"https://api.github.com/users/jimmyhmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyhmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyhmiller/subscriptions","organizations_url":"https://api.github.com/users/jimmyhmiller/orgs","repos_url":"https://api.github.com/users/jimmyhmiller/repos","events_url":"https://api.github.com/users/jimmyhmiller/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyhmiller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T18:42:16Z","updated_at":"2017-08-03T13:40:56Z","closed_at":null,"body":"Currently, we are access the store directly by passing it through router and yet we are still using `connect`. In the three locations where we are doing this, it isn't needed, connect is sufficient. It is also considered bad practice because it can lead to potential errors.\r\n\r\nThree places:\r\n\r\n[LoginContainer](https://github.com/fusionalliance/autorenter-react/blob/9a36050428bcfada80b8ab4cba437ee0c153ec5e/src/components/login/LoginContainer.js#L20)\r\n[VehicleContainer](https://github.com/fusionalliance/autorenter-react/blob/9a36050428bcfada80b8ab4cba437ee0c153ec5e/src/components/fleet/VehicleContainer.js#L17)\r\n[LocationContainer](https://github.com/fusionalliance/autorenter-react/blob/9a36050428bcfada80b8ab4cba437ee0c153ec5e/src/components/fleet/LocationContainer.js#L17)\r\n\r\nDan Abramov (creator of redux) recommending against it.\r\nhttps://github.com/reactjs/react-redux/issues/108#issuecomment-182553478"},"comment":{"url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/comments/319971916","html_url":"https://github.com/fusionalliance/autorenter-react/issues/21#issuecomment-319971916","issue_url":"https://api.github.com/repos/fusionalliance/autorenter-react/issues/21","id":319971916,"user":{"login":"aamato1990","id":8037353,"avatar_url":"https://avatars0.githubusercontent.com/u/8037353?v=4","gravatar_id":"","url":"https://api.github.com/users/aamato1990","html_url":"https://github.com/aamato1990","followers_url":"https://api.github.com/users/aamato1990/followers","following_url":"https://api.github.com/users/aamato1990/following{/other_user}","gists_url":"https://api.github.com/users/aamato1990/gists{/gist_id}","starred_url":"https://api.github.com/users/aamato1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamato1990/subscriptions","organizations_url":"https://api.github.com/users/aamato1990/orgs","repos_url":"https://api.github.com/users/aamato1990/repos","events_url":"https://api.github.com/users/aamato1990/events{/privacy}","received_events_url":"https://api.github.com/users/aamato1990/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T13:40:56Z","updated_at":"2017-08-03T13:40:56Z","body":"👍 "}}
{"actor":{"display_login":"aamato1990"}}