{"action":"created","issue":{"url":"https://api.github.com/repos/mgechev/angular-seed/issues/1776","repository_url":"https://api.github.com/repos/mgechev/angular-seed","labels_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1776/labels{/name}","comments_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1776/comments","events_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1776/events","html_url":"https://github.com/mgechev/angular-seed/pull/1776","id":202241062,"number":1776,"title":"feat(build): Another stab at having rollup tree-shaking in our build.","user":{"login":"nosachamos","id":1261686,"avatar_url":"https://avatars.githubusercontent.com/u/1261686?v=3","gravatar_id":"","url":"https://api.github.com/users/nosachamos","html_url":"https://github.com/nosachamos","followers_url":"https://api.github.com/users/nosachamos/followers","following_url":"https://api.github.com/users/nosachamos/following{/other_user}","gists_url":"https://api.github.com/users/nosachamos/gists{/gist_id}","starred_url":"https://api.github.com/users/nosachamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosachamos/subscriptions","organizations_url":"https://api.github.com/users/nosachamos/orgs","repos_url":"https://api.github.com/users/nosachamos/repos","events_url":"https://api.github.com/users/nosachamos/events{/privacy}","received_events_url":"https://api.github.com/users/nosachamos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-20T21:00:08Z","updated_at":"2017-01-20T21:43:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mgechev/angular-seed/pulls/1776","html_url":"https://github.com/mgechev/angular-seed/pull/1776","diff_url":"https://github.com/mgechev/angular-seed/pull/1776.diff","patch_url":"https://github.com/mgechev/angular-seed/pull/1776.patch"},"body":"To test this out, run:\r\n\r\n`npm run serve.prod.rollup.exp`\r\n\r\nWhich will perform a regular prod build, but also tree-shake the app.js bundle with rollup. \r\n\r\nIt will not tree-shake rxjs, but it shouldn't really matter given that only used operators should be imported, and the core content (Observables, Subject, etc) are used by most operators and apps. \r\n\r\nThis is largely based on the work done in the rollup branch, but I did a few small changes like abandoning the idea of using rxjs-es (given that it is no longer published) and adding the commonsjs rollup support.\r\n\r\nAs of right now, the sample app that comes with the seed can be built without any changes or workarounds.\r\n\r\nPreliminary results for the size of the generated app.js bundles look like this:\r\n\r\n**serve.prod**\r\n   app.js size: 1MB\r\n\r\n**serve.prod.exp**\r\n   app.js size: 623 Kb\r\n\r\n**serve.prod.rollup.exp**\r\n   app.js size: 426 Kb\r\n\r\n\r\nWhat do you guys think?"},"comment":{"url":"https://api.github.com/repos/mgechev/angular-seed/issues/comments/274187766","html_url":"https://github.com/mgechev/angular-seed/pull/1776#issuecomment-274187766","issue_url":"https://api.github.com/repos/mgechev/angular-seed/issues/1776","id":274187766,"user":{"login":"nosachamos","id":1261686,"avatar_url":"https://avatars.githubusercontent.com/u/1261686?v=3","gravatar_id":"","url":"https://api.github.com/users/nosachamos","html_url":"https://github.com/nosachamos","followers_url":"https://api.github.com/users/nosachamos/followers","following_url":"https://api.github.com/users/nosachamos/following{/other_user}","gists_url":"https://api.github.com/users/nosachamos/gists{/gist_id}","starred_url":"https://api.github.com/users/nosachamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosachamos/subscriptions","organizations_url":"https://api.github.com/users/nosachamos/orgs","repos_url":"https://api.github.com/users/nosachamos/repos","events_url":"https://api.github.com/users/nosachamos/events{/privacy}","received_events_url":"https://api.github.com/users/nosachamos/received_events","type":"User","site_admin":false},"created_at":"2017-01-20T21:43:44Z","updated_at":"2017-01-20T21:43:44Z","body":"@mgechev you got it! I'll update in a few mins."}}
{"actor":{"display_login":"nosachamos"}}