{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/godot/issues/12572","repository_url":"https://api.github.com/repos/godotengine/godot","labels_url":"https://api.github.com/repos/godotengine/godot/issues/12572/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/12572/comments","events_url":"https://api.github.com/repos/godotengine/godot/issues/12572/events","html_url":"https://github.com/godotengine/godot/pull/12572","id":270477466,"number":12572,"title":"Onion skinning [WIP]","user":{"login":"RandomShaper","id":11797174,"avatar_url":"https://avatars0.githubusercontent.com/u/11797174?v=4","gravatar_id":"","url":"https://api.github.com/users/RandomShaper","html_url":"https://github.com/RandomShaper","followers_url":"https://api.github.com/users/RandomShaper/followers","following_url":"https://api.github.com/users/RandomShaper/following{/other_user}","gists_url":"https://api.github.com/users/RandomShaper/gists{/gist_id}","starred_url":"https://api.github.com/users/RandomShaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RandomShaper/subscriptions","organizations_url":"https://api.github.com/users/RandomShaper/orgs","repos_url":"https://api.github.com/users/RandomShaper/repos","events_url":"https://api.github.com/users/RandomShaper/events{/privacy}","received_events_url":"https://api.github.com/users/RandomShaper/received_events","type":"User","site_admin":false},"labels":[{"id":73330068,"url":"https://api.github.com/repos/godotengine/godot/labels/feature%20proposal","name":"feature proposal","color":"1144ff","default":false},{"id":279098219,"url":"https://api.github.com/repos/godotengine/godot/labels/topic:editor","name":"topic:editor","color":"ffdd44","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/4","html_url":"https://github.com/godotengine/godot/milestone/4","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/4/labels","id":1449702,"number":4,"title":"3.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":349,"closed_issues":3662,"state":"open","created_at":"2015-12-08T11:42:08Z","updated_at":"2017-11-19T15:57:28Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2017-11-01T22:46:20Z","updated_at":"2017-11-19T16:12:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/12572","html_url":"https://github.com/godotengine/godot/pull/12572","diff_url":"https://github.com/godotengine/godot/pull/12572.diff","patch_url":"https://github.com/godotengine/godot/pull/12572.patch"},"body":"**This is work-in-progress.**\r\n\r\nThis allows you to see a ghosted view of the animated stuff a numbers of steps to the past or the future (based on the step value of the animation).\r\n\r\nSome commits add some infrastructure to some areas of the engine, needed for this to be implemented on top of them.\r\n\r\nIt works better if the animated hierarchy is edited in a scene by itself because the background color is used as a hint to differentiate frames.\r\n\r\nCloses #10425.\r\n\r\n## Images\r\n\r\n![onion-menu](https://user-images.githubusercontent.com/11797174/32748853-c180cba0-c8bd-11e7-80a6-331cd5c2fc76.png)\r\nNote icon is to be replaced.\r\n\r\n![editor-settings](https://user-images.githubusercontent.com/11797174/32748862-c44ae398-c8bd-11e7-80bc-6c9728d0cd94.png)\r\n\r\n![onion](https://user-images.githubusercontent.com/11797174/32975720-c4c671b6-cc0a-11e7-8695-03b5a2ef9e6e.gif)\r\nThis has improved since last time, but the grid and other fixed elements like the speaker are included in the onion layer. Not a big problem, but not too beautiful either.\r\nFor this image the setting is 1-step-deep towards past & present.\r\n\r\n## Current limitations\r\n\r\n- ~~It is always on (as long as the animation editor is visible). No UI to enable/disable or configure yet.~~\r\n- ~~It's _very_ slow because I haven't found yet a way of working with viewport captures on VRAM.~~\r\n- There isn't a way of seeing in realtime how the past state would be affected according to, e.g., the position of a node as you move it, until you really insert a keyframe or update the current one.\r\n- The ghost view corresponds to one frame (engine loop frame) earlier. No big issue.\r\n\r\nAnyway, please test and report or give suggestions.\r\n\r\n**Spatial transform and bone transform are handled separately so it'd be nice that testers tried on these kind of properties specifically.**\r\n\r\n## Changelog\r\n\r\n**UPDATED 11/06**\r\n- Viewport capture achieved and easily extensible to more past and/or future frames.\r\n\r\n**UPDATED 11/09**\r\n- Menu added to the animation editor. *I need a nice onion icon for it.* Currently it allows to enable/disable, but the direction and depth settings are ignored.\r\n- Works for 3D as well.\r\n\r\n**UPDATED 11/13**\r\n- Now every option in the onion skinning menu work.\r\n- Editor settings for past/future colors added.\r\n- Some images added to the post.\r\n- Description edited.\r\n\r\n**UPDATED 11/18**\r\n- Better shader.\r\n- Much less VRAM use.\r\n- Images updated."},"comment":{"url":"https://api.github.com/repos/godotengine/godot/issues/comments/345528331","html_url":"https://github.com/godotengine/godot/pull/12572#issuecomment-345528331","issue_url":"https://api.github.com/repos/godotengine/godot/issues/12572","id":345528331,"user":{"login":"blurymind","id":6495061,"avatar_url":"https://avatars0.githubusercontent.com/u/6495061?v=4","gravatar_id":"","url":"https://api.github.com/users/blurymind","html_url":"https://github.com/blurymind","followers_url":"https://api.github.com/users/blurymind/followers","following_url":"https://api.github.com/users/blurymind/following{/other_user}","gists_url":"https://api.github.com/users/blurymind/gists{/gist_id}","starred_url":"https://api.github.com/users/blurymind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blurymind/subscriptions","organizations_url":"https://api.github.com/users/blurymind/orgs","repos_url":"https://api.github.com/users/blurymind/repos","events_url":"https://api.github.com/users/blurymind/events{/privacy}","received_events_url":"https://api.github.com/users/blurymind/received_events","type":"User","site_admin":false},"created_at":"2017-11-19T16:12:23Z","updated_at":"2017-11-19T16:12:23Z","author_association":"NONE","body":"@RandomShaper Thank you! Also thank you for looking into autokeyframe mode.\r\nYour additions will make animating in godot so much faster and smoother! "}}
{"actor":{"display_login":"blurymind"}}