{"action":"created","issue":{"url":"https://api.github.com/repos/fire-eggs/YAGP/issues/41","repository_url":"https://api.github.com/repos/fire-eggs/YAGP","labels_url":"https://api.github.com/repos/fire-eggs/YAGP/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/fire-eggs/YAGP/issues/41/comments","events_url":"https://api.github.com/repos/fire-eggs/YAGP/issues/41/events","html_url":"https://github.com/fire-eggs/YAGP/issues/41","id":276780162,"number":41,"title":"\"Embedded\" NOTEs should be converted to NOTE records","user":{"login":"fire-eggs","id":9809727,"avatar_url":"https://avatars0.githubusercontent.com/u/9809727?v=4","gravatar_id":"","url":"https://api.github.com/users/fire-eggs","html_url":"https://github.com/fire-eggs","followers_url":"https://api.github.com/users/fire-eggs/followers","following_url":"https://api.github.com/users/fire-eggs/following{/other_user}","gists_url":"https://api.github.com/users/fire-eggs/gists{/gist_id}","starred_url":"https://api.github.com/users/fire-eggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fire-eggs/subscriptions","organizations_url":"https://api.github.com/users/fire-eggs/orgs","repos_url":"https://api.github.com/users/fire-eggs/repos","events_url":"https://api.github.com/users/fire-eggs/events{/privacy}","received_events_url":"https://api.github.com/users/fire-eggs/received_events","type":"User","site_admin":false},"labels":[{"id":174802275,"url":"https://api.github.com/repos/fire-eggs/YAGP/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":648149731,"url":"https://api.github.com/repos/fire-eggs/YAGP/labels/library","name":"library","color":"d4c5f9","default":false},{"id":174802278,"url":"https://api.github.com/repos/fire-eggs/YAGP/labels/question","name":"question","color":"cc317c","default":true},{"id":760913968,"url":"https://api.github.com/repos/fire-eggs/YAGP/labels/writer","name":"writer","color":"d1af0a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-25T21:45:14Z","updated_at":"2017-12-04T22:16:01Z","closed_at":null,"author_association":"OWNER","body":"currently impacts the writer\r\n\r\nQuestion: should \"one liner\" notes be excluded?"},"comment":{"url":"https://api.github.com/repos/fire-eggs/YAGP/issues/comments/349124745","html_url":"https://github.com/fire-eggs/YAGP/issues/41#issuecomment-349124745","issue_url":"https://api.github.com/repos/fire-eggs/YAGP/issues/41","id":349124745,"user":{"login":"fire-eggs","id":9809727,"avatar_url":"https://avatars0.githubusercontent.com/u/9809727?v=4","gravatar_id":"","url":"https://api.github.com/users/fire-eggs","html_url":"https://github.com/fire-eggs","followers_url":"https://api.github.com/users/fire-eggs/followers","following_url":"https://api.github.com/users/fire-eggs/following{/other_user}","gists_url":"https://api.github.com/users/fire-eggs/gists{/gist_id}","starred_url":"https://api.github.com/users/fire-eggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fire-eggs/subscriptions","organizations_url":"https://api.github.com/users/fire-eggs/orgs","repos_url":"https://api.github.com/users/fire-eggs/repos","events_url":"https://api.github.com/users/fire-eggs/events{/privacy}","received_events_url":"https://api.github.com/users/fire-eggs/received_events","type":"User","site_admin":false},"created_at":"2017-12-04T22:16:01Z","updated_at":"2017-12-04T22:16:01Z","author_association":"OWNER","body":"This and issue #42 are not necessarily simple to implement.\r\n\r\nThe multi-threaded nature of the parser precludes generating a NOTE record / tracking ids for correction. I.e. if an embedded note is encountered, the 'obvious' solution would be to create a NOTE record with a filler ident, use the filler ident in the referencing record, and after parsing is done, assign a \"real\" ident and replace the filler. This requires returning two records for a parse action, as well as updating a \"master list\" of references to filler idents to be corrected. Both these items are not easily supported in the current parallel parsing architecture.\r\n\r\nThe alternate is to parse embedded structures, then rework them post-parsing. This is difficult in its own way, as many sub-records could have notes. The following model entities would have to be checked, for embedded NOTE alone [a different list possible for embedded OBJE and Source-Citation]:\r\n\r\n- AssoRec\r\n- EventCommon\r\n- FamRecord\r\n- ChangeRec\r\n- HeadRecord\r\n- IndiRecord\r\n- LDSEvent\r\n- MediaLink\r\n- MediaRecord\r\n- RepoCit\r\n- Repository\r\n- SourceCit\r\n- SourceData\r\n- SourceRecord\r\n\r\nThe benefits from generating NOTE records for embedded NOTEs would be:\r\n1. More standard compliant\r\n2. Easier for GUI or other consumers to see NOTEs - rather than having to essentially perform the same search through model entities as above.\r\n"}}
{"actor":{"display_login":"fire-eggs"}}