{"action":"created","comment":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/121380350","pull_request_review_id":43422607,"id":121380350,"diff_hunk":"@@ -59,7 +59,7 @@ private void nextActivity() {\n             LOGGER.info(\"Sending my profile with name: \" + myProfile.getName() + \", public key: \"\n                     + myProfile.getPublicKey().toString());\n             final Contact myProfileAsContact = new Contact(myProfile.getName(), new SimpleKey(\"simplekey\", \"73890ien\"));\n-            this.serviceLocator.getBluetoothHandler().send(myProfileAsContact);\n+            this.serviceLocator.getBluetoothHandler().send(this.serviceLocator.getBluetoothHandler().objectToBytes(myProfileAsContact));","path":"app/src/main/java/com/nervousfish/nervousfish/activities/VisualVerificationActivity.java","position":null,"original_position":5,"commit_id":"2821d782d2c1dc36c0bc585a42e838d40b9918ba","original_commit_id":"2058483bfce4465c711e98be6fb407e4655b5248","user":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"body":"Hmm that's weird. I'm pretty sure I had changed it...\r\n","created_at":"2017-06-12T12:38:02Z","updated_at":"2017-06-12T12:38:02Z","html_url":"https://github.com/ericcornelissen/NervousFish/pull/231#discussion_r121380350","pull_request_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/121380350"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/231#discussion_r121380350"},"pull_request":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231","id":124708721,"html_url":"https://github.com/ericcornelissen/NervousFish/pull/231","diff_url":"https://github.com/ericcornelissen/NervousFish/pull/231.diff","patch_url":"https://github.com/ericcornelissen/NervousFish/pull/231.patch","issue_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/231","number":231,"state":"open","locked":false,"title":"Make it possible to exchange contacts via nfc, not yet fully manually tested #8","user":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"body":"<!-- Check if the title is descriptive! -->\r\n- Relevant Issues: #8\r\n- Related Pull Requests: -\r\n\r\n* * *\r\n\r\n## What\r\nThis pr adds a new activity which should be able to exchange contacts over nfc (Android Beam)\r\n\r\n## Why\r\nThis Pull Request is needed because NFC is MITM-proof and requires less hassle to setup.\r\n\r\n## How\r\nThis feature can be viewed/tested within the project by clicking the pairing menu in the main activity and selecting NFC. This should lead to the NFCActivity which should open up the activity with an instruction gif of what to do.\r\n\r\n## Alternative implementation\r\nOther implementations that I've have considered are making it so that our nfc handler fully replaces the android nfc adapter but that proved difficult.\r\n\r\n## Notes\r\n<!-- Is there anything reviewers need to know about? Do they need to take something into account while\r\nreviewing? Is there something they should pay extra attention to? -->\r\nYes, as it's stated in the title this functionality needs to be tested with actual phones, the activity (design wise) can still be improved and there are even some activity transitions missing but it will be add to this pr before merging.\r\n","created_at":"2017-06-08T17:55:22Z","updated_at":"2017-06-12T12:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b12b642900e706d20bffd5396f1ffb83024b478","assignee":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"assignees":[{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231/commits","review_comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231/comments","review_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/231/comments","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/2821d782d2c1dc36c0bc585a42e838d40b9918ba","head":{"label":"ericcornelissen:NFC-data-exchange#8","ref":"NFC-data-exchange#8","sha":"2821d782d2c1dc36c0bc585a42e838d40b9918ba","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-06-06T09:19:36Z","pushed_at":"2017-06-12T12:12:16Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":5439,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":41,"forks":4,"open_issues":41,"watchers":1,"default_branch":"develop"}},"base":{"label":"ericcornelissen:develop","ref":"develop","sha":"6bb60e0af5e5fd9fbae72b564c1243dd12a986a0","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-06-06T09:19:36Z","pushed_at":"2017-06-12T12:12:16Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":5439,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":41,"forks":4,"open_issues":41,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/231"},"issue":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/231"},"comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/2821d782d2c1dc36c0bc585a42e838d40b9918ba"}}}}
{"actor":{"display_login":"TheBonheurs"}}