{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/157407843","pull_request_review_id":84043195,"id":157407843,"diff_hunk":"@@ -1200,16 +1204,20 @@ def postprocess(test, params, env):\n             err += \"\\nPB cleanup: %s\" % str(details).replace('\\\\n', '\\n  ')\n             logging.error(details)\n \n-    if err:\n-        raise virt_vm.VMError(\"Failures occurred while postprocess:%s\" % err)\n     if params.get(\"verify_host_dmesg\", \"yes\") == \"yes\":\n         dmesg_log_file = params.get(\"host_dmesg_logfile\", \"host_dmesg.log\")\n         level = params.get(\"host_dmesg_level\", 3)\n         ignore_result = params.get(\"host_dmesg_ignore\", \"no\") == \"yes\"\n         dmesg_log_file = utils_misc.get_path(test.debugdir, dmesg_log_file)\n-        utils_misc.verify_dmesg(dmesg_log_file=dmesg_log_file,\n-                                ignore_result=ignore_result,\n-                                level_check=level)\n+        try:\n+            utils_misc.verify_dmesg(dmesg_log_file=dmesg_log_file,\n+                                    ignore_result=ignore_result,\n+                                    level_check=level)\n+        except exceptions.TestFail as details:\n+            err += \"\\nHost dmesg verification failed: %s\" % details\n+\n+    if err:\n+        raise virt_vm.VMError(\"Failures occurred while postprocess:%s\" % err)","path":"virttest/env_process.py","position":35,"original_position":35,"commit_id":"0d3f5361caefbbd9150bfcec9265cb3254c780db","original_commit_id":"0d3f5361caefbbd9150bfcec9265cb3254c780db","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"Well I kept the original exception but I see your point. How about `RuntimeError` instead?","created_at":"2017-12-18T06:27:19Z","updated_at":"2017-12-18T06:27:19Z","html_url":"https://github.com/avocado-framework/avocado-vt/pull/1260#discussion_r157407843","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/157407843"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1260#discussion_r157407843"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260"}},"in_reply_to_id":157394294},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260","id":158675594,"html_url":"https://github.com/avocado-framework/avocado-vt/pull/1260","diff_url":"https://github.com/avocado-framework/avocado-vt/pull/1260.diff","patch_url":"https://github.com/avocado-framework/avocado-vt/pull/1260.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1260","number":1260,"state":"open","locked":false,"title":"virttest.env_process: Fix dmesg verification error handling","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"The host/guest dmesg verification should not interrupt the\r\nenv_process.postprocess, otherwise the environment can be spoiled and\r\nmany processes can be left behind hanging avocado. Let's use the usual\r\npostprocess handling by appending the details about the failure.\r\n\r\n@sathnaga @clebergnu @Hao-Liu this issue stuck our CI last week. Can you please review this?","created_at":"2017-12-15T19:24:58Z","updated_at":"2017-12-18T06:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b400929804d6b6f240d3dc3bae7e945ae34dc5fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1260/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/0d3f5361caefbbd9150bfcec9265cb3254c780db","head":{"label":"ldoktor:postprocess","ref":"postprocess","sha":"0d3f5361caefbbd9150bfcec9265cb3254c780db","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"repo":{"id":37206852,"name":"avocado-vt","full_name":"ldoktor/avocado-vt","owner":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldoktor/avocado-vt","description":"Avocado Virt Test Compatibility Layer Plugin","fork":true,"url":"https://api.github.com/repos/ldoktor/avocado-vt","forks_url":"https://api.github.com/repos/ldoktor/avocado-vt/forks","keys_url":"https://api.github.com/repos/ldoktor/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldoktor/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldoktor/avocado-vt/teams","hooks_url":"https://api.github.com/repos/ldoktor/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/ldoktor/avocado-vt/events","assignees_url":"https://api.github.com/repos/ldoktor/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/ldoktor/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/ldoktor/avocado-vt/tags","blobs_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldoktor/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/ldoktor/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/ldoktor/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/ldoktor/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/ldoktor/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/ldoktor/avocado-vt/subscription","commits_url":"https://api.github.com/repos/ldoktor/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldoktor/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldoktor/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldoktor/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/ldoktor/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldoktor/avocado-vt/merges","archive_url":"https://api.github.com/repos/ldoktor/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldoktor/avocado-vt/downloads","issues_url":"https://api.github.com/repos/ldoktor/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/ldoktor/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/ldoktor/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/ldoktor/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldoktor/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/ldoktor/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/ldoktor/avocado-vt/deployments","created_at":"2015-06-10T15:51:41Z","updated_at":"2016-01-28T16:50:30Z","pushed_at":"2017-12-15T19:45:31Z","git_url":"git://github.com/ldoktor/avocado-vt.git","ssh_url":"git@github.com:ldoktor/avocado-vt.git","clone_url":"https://github.com/ldoktor/avocado-vt.git","svn_url":"https://github.com/ldoktor/avocado-vt","homepage":null,"size":26825,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"209dd4ed197ef9e874de31dfc99fed5bb23a383b","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36371959,"name":"avocado-vt","full_name":"avocado-framework/avocado-vt","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado-vt","description":"Avocado VT Plugin","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado-vt","forks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado-vt/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado-vt/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado-vt/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/deployments","created_at":"2015-05-27T14:22:13Z","updated_at":"2017-11-10T06:17:01Z","pushed_at":"2017-12-18T05:20:50Z","git_url":"git://github.com/avocado-framework/avocado-vt.git","ssh_url":"git@github.com:avocado-framework/avocado-vt.git","clone_url":"https://github.com/avocado-framework/avocado-vt.git","svn_url":"https://github.com/avocado-framework/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":26810,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":123,"open_issues":102,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1260"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1260"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1260/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1260/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/0d3f5361caefbbd9150bfcec9265cb3254c780db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ldoktor"}}