{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/110029760","pull_request_review_id":31161267,"id":110029760,"diff_hunk":"@@ -96,6 +96,12 @@ private FBO getFbo() {\n         return fboManager.get(fboName);\n     }\n \n+    public static void ResetDefaultInstance() {","path":"engine/src/main/java/org/terasology/rendering/dag/stateChanges/SetViewportToSizeOf.java","position":4,"original_position":4,"commit_id":"74e51c107ed7aa46dd0047aa0f7ecc15fe56bd6c","original_commit_id":"74e51c107ed7aa46dd0047aa0f7ecc15fe56bd6c","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars0.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"How about \"disposeDefaultInstance\".  Yes, please no capitalized first letter. ","created_at":"2017-04-05T21:14:25Z","updated_at":"2017-04-05T21:15:43Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2879#discussion_r110029760","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/110029760"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2879#discussion_r110029760"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879","id":113811617,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2879","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2879.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2879.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2879","number":2879,"state":"open","locked":false,"title":"Fixes all resizing issues","user":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"body":"Contains fixes for the remaining resizing issues.\r\n\r\nExisting Problem 1: When you start a game, exit to the main menu and start the game again, resizing will become corrupt and any resizing (maybe even no resizing) that you do will lead to problems.\r\nCause and Solution: The reason behind that is a static defaultInstance object of class SetViewportToSizeof, and this PR resets that object to null when disposing the RenderGraph.\r\n\r\nExisting Problem 2: When playing with scale set to anything other than 100%, the game would not render to entire screen, and would draw only to a small part if scale < 100%, or outside bounds if scale > 100%.\r\nCause and Solution: This was caused because setViewportToSizeOf used an FBO to obtain the size, but since scale was not 100%, size of FBO was not same as size of Display. This PR fixes that by forcing last Node to set viewport to size of Display (there is still scope for improvement).","created_at":"2017-04-02T09:35:52Z","updated_at":"2017-04-05T21:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e94d8f7e2e114cfd9a518d4e8f907468daa1d94","assignee":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"assignees":[{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2879/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/74e51c107ed7aa46dd0047aa0f7ecc15fe56bd6c","head":{"label":"vampcat:resizingFix","ref":"resizingFix","sha":"74e51c107ed7aa46dd0047aa0f7ecc15fe56bd6c","user":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"repo":{"id":84166907,"name":"Terasology","full_name":"vampcat/Terasology","owner":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vampcat/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/vampcat/Terasology","forks_url":"https://api.github.com/repos/vampcat/Terasology/forks","keys_url":"https://api.github.com/repos/vampcat/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vampcat/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vampcat/Terasology/teams","hooks_url":"https://api.github.com/repos/vampcat/Terasology/hooks","issue_events_url":"https://api.github.com/repos/vampcat/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/vampcat/Terasology/events","assignees_url":"https://api.github.com/repos/vampcat/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/vampcat/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/vampcat/Terasology/tags","blobs_url":"https://api.github.com/repos/vampcat/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vampcat/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vampcat/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/vampcat/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vampcat/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/vampcat/Terasology/languages","stargazers_url":"https://api.github.com/repos/vampcat/Terasology/stargazers","contributors_url":"https://api.github.com/repos/vampcat/Terasology/contributors","subscribers_url":"https://api.github.com/repos/vampcat/Terasology/subscribers","subscription_url":"https://api.github.com/repos/vampcat/Terasology/subscription","commits_url":"https://api.github.com/repos/vampcat/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/vampcat/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/vampcat/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/vampcat/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/vampcat/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/vampcat/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vampcat/Terasology/merges","archive_url":"https://api.github.com/repos/vampcat/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vampcat/Terasology/downloads","issues_url":"https://api.github.com/repos/vampcat/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/vampcat/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/vampcat/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/vampcat/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vampcat/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/vampcat/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/vampcat/Terasology/deployments","created_at":"2017-03-07T07:11:20Z","updated_at":"2017-03-07T07:11:27Z","pushed_at":"2017-04-02T15:10:17Z","git_url":"git://github.com/vampcat/Terasology.git","ssh_url":"git@github.com:vampcat/Terasology.git","clone_url":"https://github.com/vampcat/Terasology.git","svn_url":"https://github.com/vampcat/Terasology","homepage":"http://terasology.org","size":277650,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"5724bcc95f631a5b9538d6d06a2a9f07c8a3a910","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars2.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars2.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2017-04-05T18:08:08Z","pushed_at":"2017-04-05T08:24:47Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":278195,"stargazers_count":1954,"watchers_count":1954,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":875,"mirror_url":null,"open_issues_count":379,"forks":875,"open_issues":379,"watchers":1954,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2879"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2879"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2879/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2879/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/74e51c107ed7aa46dd0047aa0f7ecc15fe56bd6c"}}}}
{"actor":{"display_login":"emanuele3d"}}