{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/111674169","pull_request_review_id":32934770,"id":111674169,"diff_hunk":"@@ -19097,6 +19098,381 @@ unsigned short clif_parse_cmd_optional( int fd, struct map_session_data *sd ) {\n }\n \n /*==========================================\n+ * RoDEX\n+ *------------------------------------------*/\n+\n+void clif_parse_rodex_open_write_mail(int fd, struct map_session_data *sd)\n+{\n+\tconst struct PACKET_CZ_REQ_OPEN_WRITE_MAIL *rPacket = RFIFOP(fd, 0);\n+\tstruct PACKET_ZC_ACK_OPEN_WRITE_MAIL *sPacket = NULL;\n+\tWFIFOHEAD(fd, sizeof(*sPacket));","path":"src/map/clif.c","position":19,"original_position":19,"commit_id":"c18432e0e5df740819e6f8f394fd2a69a9d7f32b","original_commit_id":"c18432e0e5df740819e6f8f394fd2a69a9d7f32b","user":{"login":"4144","id":959758,"avatar_url":"https://avatars2.githubusercontent.com/u/959758?v=3","gravatar_id":"","url":"https://api.github.com/users/4144","html_url":"https://github.com/4144","followers_url":"https://api.github.com/users/4144/followers","following_url":"https://api.github.com/users/4144/following{/other_user}","gists_url":"https://api.github.com/users/4144/gists{/gist_id}","starred_url":"https://api.github.com/users/4144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4144/subscriptions","organizations_url":"https://api.github.com/users/4144/orgs","repos_url":"https://api.github.com/users/4144/repos","events_url":"https://api.github.com/users/4144/events{/privacy}","received_events_url":"https://api.github.com/users/4144/received_events","type":"User","site_admin":false},"body":"packets must be send from own functions and not from parse. extract into new function","created_at":"2017-04-15T22:08:36Z","updated_at":"2017-04-15T22:21:21Z","html_url":"https://github.com/HerculesWS/Hercules/pull/1686#discussion_r111674169","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/111674169"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1686#discussion_r111674169"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686","id":116039095,"html_url":"https://github.com/HerculesWS/Hercules/pull/1686","diff_url":"https://github.com/HerculesWS/Hercules/pull/1686.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1686.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1686","number":1686,"state":"open","locked":false,"title":"Implementation of RoDEX","user":{"login":"guilherme-gm","id":10552039,"avatar_url":"https://avatars1.githubusercontent.com/u/10552039?v=3","gravatar_id":"","url":"https://api.github.com/users/guilherme-gm","html_url":"https://github.com/guilherme-gm","followers_url":"https://api.github.com/users/guilherme-gm/followers","following_url":"https://api.github.com/users/guilherme-gm/following{/other_user}","gists_url":"https://api.github.com/users/guilherme-gm/gists{/gist_id}","starred_url":"https://api.github.com/users/guilherme-gm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilherme-gm/subscriptions","organizations_url":"https://api.github.com/users/guilherme-gm/orgs","repos_url":"https://api.github.com/users/guilherme-gm/repos","events_url":"https://api.github.com/users/guilherme-gm/events{/privacy}","received_events_url":"https://api.github.com/users/guilherme-gm/received_events","type":"User","site_admin":false},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\n[//]: # (Describe at length, the changes that this pull request makes.)\r\nImplementation of RoDEX system (new mail system). Works with clients dated 2015-05-13 and above.\r\nAdds `rodex_sendmail` and `rodex_sendmail2` script commands (see doc for information)\r\n\r\n**Affected Branches:**  Master\r\n\r\n[//]: # (Master? Slave?)\r\n\r\n**Issues addressed:**\r\n~~\r\n\r\n[//]: # (Issue Tracker Number if any.)\r\n\r\n### Known Issues and TODO List\r\n~~\r\n\r\n[//]: # (Insert checklist here)\r\n[//]: # (Syntax: - [ ] Checkbox)\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n\r\nA big thanks to:\r\n@hemagx - Base code\r\n@Asheraf  - some official info\r\n@dastgir - for giving me some directions when I was lost\r\nBrought by Ragnarok United (http://board.ragnarokunited.com)","created_at":"2017-04-15T21:08:05Z","updated_at":"2017-04-15T22:21:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"937a5d84d884b555b9e5441f6c13670efe6ecbab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1686/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/c18432e0e5df740819e6f8f394fd2a69a9d7f32b","head":{"label":"guilherme-gm:rodex_","ref":"rodex_","sha":"c18432e0e5df740819e6f8f394fd2a69a9d7f32b","user":{"login":"guilherme-gm","id":10552039,"avatar_url":"https://avatars1.githubusercontent.com/u/10552039?v=3","gravatar_id":"","url":"https://api.github.com/users/guilherme-gm","html_url":"https://github.com/guilherme-gm","followers_url":"https://api.github.com/users/guilherme-gm/followers","following_url":"https://api.github.com/users/guilherme-gm/following{/other_user}","gists_url":"https://api.github.com/users/guilherme-gm/gists{/gist_id}","starred_url":"https://api.github.com/users/guilherme-gm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilherme-gm/subscriptions","organizations_url":"https://api.github.com/users/guilherme-gm/orgs","repos_url":"https://api.github.com/users/guilherme-gm/repos","events_url":"https://api.github.com/users/guilherme-gm/events{/privacy}","received_events_url":"https://api.github.com/users/guilherme-gm/received_events","type":"User","site_admin":false},"repo":{"id":75749495,"name":"Hercules","full_name":"guilherme-gm/Hercules","owner":{"login":"guilherme-gm","id":10552039,"avatar_url":"https://avatars1.githubusercontent.com/u/10552039?v=3","gravatar_id":"","url":"https://api.github.com/users/guilherme-gm","html_url":"https://github.com/guilherme-gm","followers_url":"https://api.github.com/users/guilherme-gm/followers","following_url":"https://api.github.com/users/guilherme-gm/following{/other_user}","gists_url":"https://api.github.com/users/guilherme-gm/gists{/gist_id}","starred_url":"https://api.github.com/users/guilherme-gm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilherme-gm/subscriptions","organizations_url":"https://api.github.com/users/guilherme-gm/orgs","repos_url":"https://api.github.com/users/guilherme-gm/repos","events_url":"https://api.github.com/users/guilherme-gm/events{/privacy}","received_events_url":"https://api.github.com/users/guilherme-gm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guilherme-gm/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/guilherme-gm/Hercules","forks_url":"https://api.github.com/repos/guilherme-gm/Hercules/forks","keys_url":"https://api.github.com/repos/guilherme-gm/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guilherme-gm/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guilherme-gm/Hercules/teams","hooks_url":"https://api.github.com/repos/guilherme-gm/Hercules/hooks","issue_events_url":"https://api.github.com/repos/guilherme-gm/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/guilherme-gm/Hercules/events","assignees_url":"https://api.github.com/repos/guilherme-gm/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/guilherme-gm/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/guilherme-gm/Hercules/tags","blobs_url":"https://api.github.com/repos/guilherme-gm/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guilherme-gm/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guilherme-gm/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/guilherme-gm/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guilherme-gm/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/guilherme-gm/Hercules/languages","stargazers_url":"https://api.github.com/repos/guilherme-gm/Hercules/stargazers","contributors_url":"https://api.github.com/repos/guilherme-gm/Hercules/contributors","subscribers_url":"https://api.github.com/repos/guilherme-gm/Hercules/subscribers","subscription_url":"https://api.github.com/repos/guilherme-gm/Hercules/subscription","commits_url":"https://api.github.com/repos/guilherme-gm/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/guilherme-gm/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/guilherme-gm/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/guilherme-gm/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/guilherme-gm/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/guilherme-gm/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guilherme-gm/Hercules/merges","archive_url":"https://api.github.com/repos/guilherme-gm/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guilherme-gm/Hercules/downloads","issues_url":"https://api.github.com/repos/guilherme-gm/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/guilherme-gm/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/guilherme-gm/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/guilherme-gm/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guilherme-gm/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/guilherme-gm/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/guilherme-gm/Hercules/deployments","created_at":"2016-12-06T16:24:59Z","updated_at":"2016-12-06T16:25:09Z","pushed_at":"2017-04-15T21:01:35Z","git_url":"git://github.com/guilherme-gm/Hercules.git","ssh_url":"git@github.com:guilherme-gm/Hercules.git","clone_url":"https://github.com/guilherme-gm/Hercules.git","svn_url":"https://github.com/guilherme-gm/Hercules","homepage":"http://herc.ws","size":137879,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"5802b22439441be1914ae9024d6ce06d51c0210f","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars0.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars0.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2017-04-12T20:12:50Z","pushed_at":"2017-04-15T22:02:08Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":148630,"stargazers_count":335,"watchers_count":335,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":367,"forks":477,"open_issues":367,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1686"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1686"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1686/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1686/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/c18432e0e5df740819e6f8f394fd2a69a9d7f32b"}}}}
{"actor":{"display_login":"4144"}}