{"action":"created","comment":{"url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/comments/157970188","pull_request_review_id":84700709,"id":157970188,"diff_hunk":"@@ -16,4 +16,4 @@\n \n $style = apply_filters( 'tribe_events_embedded_map_style', \"height: $height; width: $width\", $index );\n ?>\n-<div id=\"tribe-events-gmap-<?php esc_attr_e( $index ) ?>\" style=\"<?php esc_attr_e( $style ) ?>\"></div><!-- #tribe-events-gmap-<?php esc_attr_e( $index ) ?> -->\n+<div id=\"tribe-events-gmap-<?php esc_attr( $index ) ?>\" style=\"<?php esc_attr_e( $style ) ?>\"></div><!-- #tribe-events-gmap-<?php esc_attr( $index ) ?> -->","path":"src/views/modules/map.php","position":5,"original_position":5,"commit_id":"17f61b8e2c15d69f62dd1f4b7b5e64c2856519b4","original_commit_id":"17f61b8e2c15d69f62dd1f4b7b5e64c2856519b4","user":{"login":"sc0ttkclark","id":709662,"avatar_url":"https://avatars2.githubusercontent.com/u/709662?v=4","gravatar_id":"","url":"https://api.github.com/users/sc0ttkclark","html_url":"https://github.com/sc0ttkclark","followers_url":"https://api.github.com/users/sc0ttkclark/followers","following_url":"https://api.github.com/users/sc0ttkclark/following{/other_user}","gists_url":"https://api.github.com/users/sc0ttkclark/gists{/gist_id}","starred_url":"https://api.github.com/users/sc0ttkclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sc0ttkclark/subscriptions","organizations_url":"https://api.github.com/users/sc0ttkclark/orgs","repos_url":"https://api.github.com/users/sc0ttkclark/repos","events_url":"https://api.github.com/users/sc0ttkclark/events{/privacy}","received_events_url":"https://api.github.com/users/sc0ttkclark/received_events","type":"User","site_admin":false},"body":"We shouldn't use _e() when it's not necessary. It can't be officially translated when passed a variable for the translation string.\r\n\r\nJust replace these with `<?php echo esc_attr( $index ); ?>` and we can call this golden.","created_at":"2017-12-20T09:15:22Z","updated_at":"2017-12-20T09:15:22Z","html_url":"https://github.com/moderntribe/the-events-calendar/pull/1705#discussion_r157970188","pull_request_url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/comments/157970188"},"html":{"href":"https://github.com/moderntribe/the-events-calendar/pull/1705#discussion_r157970188"},"pull_request":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705"}},"in_reply_to_id":153510759},"pull_request":{"url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705","id":155082269,"html_url":"https://github.com/moderntribe/the-events-calendar/pull/1705","diff_url":"https://github.com/moderntribe/the-events-calendar/pull/1705.diff","patch_url":"https://github.com/moderntribe/the-events-calendar/pull/1705.patch","issue_url":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/1705","number":1705,"state":"open","locked":false,"title":"Fixed events gmap id index was translated.","user":{"login":"LucaPipolo","id":2393718,"avatar_url":"https://avatars3.githubusercontent.com/u/2393718?v=4","gravatar_id":"","url":"https://api.github.com/users/LucaPipolo","html_url":"https://github.com/LucaPipolo","followers_url":"https://api.github.com/users/LucaPipolo/followers","following_url":"https://api.github.com/users/LucaPipolo/following{/other_user}","gists_url":"https://api.github.com/users/LucaPipolo/gists{/gist_id}","starred_url":"https://api.github.com/users/LucaPipolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucaPipolo/subscriptions","organizations_url":"https://api.github.com/users/LucaPipolo/orgs","repos_url":"https://api.github.com/users/LucaPipolo/repos","events_url":"https://api.github.com/users/LucaPipolo/events{/privacy}","received_events_url":"https://api.github.com/users/LucaPipolo/received_events","type":"User","site_admin":false},"body":"## Issue\r\nGoogle Maps are not loaded due to wrong map ID.\r\n\r\n## Details\r\n1. The JS [see [here](https://github.com/moderntribe/the-events-calendar/blob/master/src/resources/js/embedded-map.js#L90)] is looking for an ID that starts with `tribe-events-gmap-` + index.\r\n2. Events Gmap ID is assigned into the map view [see [here](https://github.com/moderntribe/the-events-calendar/blob/master/src/views/modules/map.php#L19)].\r\n3. The original value of index is an integer, e.g. `0`, but, since `esc_attr_e` is used, It expects a string and it does not automatically casting it. So the plugin is doing `esc_attr_e(0)` instead of `esc_attr_e('0')`. This leads to very unexpected results, e.g, in my case I have `tribe-events-gmap-0/Email` instead of `tribe-events-gmap-0`.\r\n3. Then I'm wondering why using `esc_attr_e` (so also applying a translation, see https://codex.wordpress.org/Function_Reference/esc_attr_e), instead of just `esc_attr`.\r\n\r\n## Proposed solutions\r\n- Use `esc_attr` instead of `esc_attr_e`.","created_at":"2017-11-28T14:15:11Z","updated_at":"2017-12-20T09:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5e93bc0982f067ae69df8d08e97783e8ed6149c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705/commits","review_comments_url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705/comments","review_comment_url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/1705/comments","statuses_url":"https://api.github.com/repos/moderntribe/the-events-calendar/statuses/17f61b8e2c15d69f62dd1f4b7b5e64c2856519b4","head":{"label":"netzstrategen:release/122","ref":"release/122","sha":"17f61b8e2c15d69f62dd1f4b7b5e64c2856519b4","user":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"repo":{"id":50680961,"name":"the-events-calendar","full_name":"netzstrategen/the-events-calendar","owner":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netzstrategen/the-events-calendar","description":"The Events Calendar WordPress plugin by Modern Tribe","fork":true,"url":"https://api.github.com/repos/netzstrategen/the-events-calendar","forks_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/forks","keys_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/teams","hooks_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/hooks","issue_events_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/events","assignees_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/tags","blobs_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/languages","stargazers_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/stargazers","contributors_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/contributors","subscribers_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/subscribers","subscription_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/subscription","commits_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/merges","archive_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/downloads","issues_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/labels{/name}","releases_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/releases{/id}","deployments_url":"https://api.github.com/repos/netzstrategen/the-events-calendar/deployments","created_at":"2016-01-29T18:06:41Z","updated_at":"2016-01-29T18:06:45Z","pushed_at":"2017-11-28T14:19:21Z","git_url":"git://github.com/netzstrategen/the-events-calendar.git","ssh_url":"git@github.com:netzstrategen/the-events-calendar.git","clone_url":"https://github.com/netzstrategen/the-events-calendar.git","svn_url":"https://github.com/netzstrategen/the-events-calendar","homepage":null,"size":33785,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release/122"}},"base":{"label":"moderntribe:master","ref":"master","sha":"46a00d61ee7847ae358963dc0d0276a5456748e6","user":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"repo":{"id":16366134,"name":"the-events-calendar","full_name":"moderntribe/the-events-calendar","owner":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moderntribe/the-events-calendar","description":"The Events Calendar WordPress plugin by Modern Tribe","fork":false,"url":"https://api.github.com/repos/moderntribe/the-events-calendar","forks_url":"https://api.github.com/repos/moderntribe/the-events-calendar/forks","keys_url":"https://api.github.com/repos/moderntribe/the-events-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moderntribe/the-events-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moderntribe/the-events-calendar/teams","hooks_url":"https://api.github.com/repos/moderntribe/the-events-calendar/hooks","issue_events_url":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/moderntribe/the-events-calendar/events","assignees_url":"https://api.github.com/repos/moderntribe/the-events-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/moderntribe/the-events-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/moderntribe/the-events-calendar/tags","blobs_url":"https://api.github.com/repos/moderntribe/the-events-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moderntribe/the-events-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moderntribe/the-events-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/moderntribe/the-events-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moderntribe/the-events-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/moderntribe/the-events-calendar/languages","stargazers_url":"https://api.github.com/repos/moderntribe/the-events-calendar/stargazers","contributors_url":"https://api.github.com/repos/moderntribe/the-events-calendar/contributors","subscribers_url":"https://api.github.com/repos/moderntribe/the-events-calendar/subscribers","subscription_url":"https://api.github.com/repos/moderntribe/the-events-calendar/subscription","commits_url":"https://api.github.com/repos/moderntribe/the-events-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/moderntribe/the-events-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/moderntribe/the-events-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/moderntribe/the-events-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/moderntribe/the-events-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moderntribe/the-events-calendar/merges","archive_url":"https://api.github.com/repos/moderntribe/the-events-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moderntribe/the-events-calendar/downloads","issues_url":"https://api.github.com/repos/moderntribe/the-events-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/moderntribe/the-events-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/moderntribe/the-events-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moderntribe/the-events-calendar/labels{/name}","releases_url":"https://api.github.com/repos/moderntribe/the-events-calendar/releases{/id}","deployments_url":"https://api.github.com/repos/moderntribe/the-events-calendar/deployments","created_at":"2014-01-30T02:17:01Z","updated_at":"2017-12-19T23:57:21Z","pushed_at":"2017-12-19T16:22:43Z","git_url":"git://github.com/moderntribe/the-events-calendar.git","ssh_url":"git@github.com:moderntribe/the-events-calendar.git","clone_url":"https://github.com/moderntribe/the-events-calendar.git","svn_url":"https://github.com/moderntribe/the-events-calendar","homepage":null,"size":73930,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":126,"open_issues":8,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705"},"html":{"href":"https://github.com/moderntribe/the-events-calendar/pull/1705"},"issue":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/1705"},"comments":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/issues/1705/comments"},"review_comments":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705/comments"},"review_comment":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/pulls/1705/commits"},"statuses":{"href":"https://api.github.com/repos/moderntribe/the-events-calendar/statuses/17f61b8e2c15d69f62dd1f4b7b5e64c2856519b4"}},"author_association":"NONE"}}
{"actor":{"display_login":"sc0ttkclark"}}