{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/pos/pulls/comments/135332942","pull_request_review_id":58739693,"id":135332942,"diff_hunk":"@@ -15,29 +15,62 @@\n  *    along with this program.  If not, see <http://www.gnu.org/licenses/>.\n  *\n  ******************************************************************************/\n-function pos_pricelist_models(instance, module) {\n+odoo.define('pos_pricelist.models', function (require) {\n+\t\"use strict\";\n \n-    var _t = instance.web._t;\n-    var round_pr = instance.web.round_precision;\n-    var round_di = instance.web.round_decimals;\n+\tvar models = require('point_of_sale.models');\n+\tvar screens = require('point_of_sale.screens');\n+\tvar PosDB = require('pos_pricelist.DB');\n+\tvar core = require('web.core');\n+\tvar utils = require('web.utils');\n \n-    /**\n+    var round_pr = utils.round_precision;\n+    var round_di = utils.round_decimals;\n+\n+\tPosDB = PosDB.extend({","path":"pos_pricelist/static/src/js/models.js","position":21,"original_position":21,"commit_id":"6792d25214baa701ac7f42e3bd0a8cbcafba5adc","original_commit_id":"3a35b8cc2e736e5d27b6c78ccdb8b6ebbb8bed9e","user":{"login":"llacroix","id":107525,"avatar_url":"https://avatars0.githubusercontent.com/u/107525?v=4","gravatar_id":"","url":"https://api.github.com/users/llacroix","html_url":"https://github.com/llacroix","followers_url":"https://api.github.com/users/llacroix/followers","following_url":"https://api.github.com/users/llacroix/following{/other_user}","gists_url":"https://api.github.com/users/llacroix/gists{/gist_id}","starred_url":"https://api.github.com/users/llacroix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llacroix/subscriptions","organizations_url":"https://api.github.com/users/llacroix/orgs","repos_url":"https://api.github.com/users/llacroix/repos","events_url":"https://api.github.com/users/llacroix/events{/privacy}","received_events_url":"https://api.github.com/users/llacroix/received_events","type":"User","site_admin":false},"body":"You should use include instead of extend. ","created_at":"2017-08-25T19:08:54Z","updated_at":"2017-08-25T19:08:54Z","html_url":"https://github.com/OCA/pos/pull/186#discussion_r135332942","pull_request_url":"https://api.github.com/repos/OCA/pos/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/OCA/pos/pulls/comments/135332942"},"html":{"href":"https://github.com/OCA/pos/pull/186#discussion_r135332942"},"pull_request":{"href":"https://api.github.com/repos/OCA/pos/pulls/186"}},"in_reply_to_id":126744860},"pull_request":{"url":"https://api.github.com/repos/OCA/pos/pulls/186","id":129952605,"html_url":"https://github.com/OCA/pos/pull/186","diff_url":"https://github.com/OCA/pos/pull/186.diff","patch_url":"https://github.com/OCA/pos/pull/186.patch","issue_url":"https://api.github.com/repos/OCA/pos/issues/186","number":186,"state":"open","locked":false,"title":"[IMP] Ported pos_pricelist to v9. Based on work from x620. Added calc…","user":{"login":"wpichler","id":13257734,"avatar_url":"https://avatars1.githubusercontent.com/u/13257734?v=4","gravatar_id":"","url":"https://api.github.com/users/wpichler","html_url":"https://github.com/wpichler","followers_url":"https://api.github.com/users/wpichler/followers","following_url":"https://api.github.com/users/wpichler/following{/other_user}","gists_url":"https://api.github.com/users/wpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/wpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpichler/subscriptions","organizations_url":"https://api.github.com/users/wpichler/orgs","repos_url":"https://api.github.com/users/wpichler/repos","events_url":"https://api.github.com/users/wpichler/events{/privacy}","received_events_url":"https://api.github.com/users/wpichler/received_events","type":"User","site_admin":false},"body":"…ulcation based on standard_price. Fixed bug in simulate_price. Removed old addProduct function - not needed anymore","created_at":"2017-07-11T16:33:27Z","updated_at":"2017-08-25T19:08:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcf625baa388c6469d1a8e4f6f58f5d9208a163d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/pos/pulls/186/commits","review_comments_url":"https://api.github.com/repos/OCA/pos/pulls/186/comments","review_comment_url":"https://api.github.com/repos/OCA/pos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/pos/issues/186/comments","statuses_url":"https://api.github.com/repos/OCA/pos/statuses/6792d25214baa701ac7f42e3bd0a8cbcafba5adc","head":{"label":"Callino:9.0-pos_pricelist_v9-WP","ref":"9.0-pos_pricelist_v9-WP","sha":"6792d25214baa701ac7f42e3bd0a8cbcafba5adc","user":{"login":"Callino","id":17481133,"avatar_url":"https://avatars2.githubusercontent.com/u/17481133?v=4","gravatar_id":"","url":"https://api.github.com/users/Callino","html_url":"https://github.com/Callino","followers_url":"https://api.github.com/users/Callino/followers","following_url":"https://api.github.com/users/Callino/following{/other_user}","gists_url":"https://api.github.com/users/Callino/gists{/gist_id}","starred_url":"https://api.github.com/users/Callino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Callino/subscriptions","organizations_url":"https://api.github.com/users/Callino/orgs","repos_url":"https://api.github.com/users/Callino/repos","events_url":"https://api.github.com/users/Callino/events{/privacy}","received_events_url":"https://api.github.com/users/Callino/received_events","type":"Organization","site_admin":false},"repo":{"id":76443869,"name":"pos","full_name":"Callino/pos","owner":{"login":"Callino","id":17481133,"avatar_url":"https://avatars2.githubusercontent.com/u/17481133?v=4","gravatar_id":"","url":"https://api.github.com/users/Callino","html_url":"https://github.com/Callino","followers_url":"https://api.github.com/users/Callino/followers","following_url":"https://api.github.com/users/Callino/following{/other_user}","gists_url":"https://api.github.com/users/Callino/gists{/gist_id}","starred_url":"https://api.github.com/users/Callino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Callino/subscriptions","organizations_url":"https://api.github.com/users/Callino/orgs","repos_url":"https://api.github.com/users/Callino/repos","events_url":"https://api.github.com/users/Callino/events{/privacy}","received_events_url":"https://api.github.com/users/Callino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Callino/pos","description":"Odoo Point of sale Addons","fork":true,"url":"https://api.github.com/repos/Callino/pos","forks_url":"https://api.github.com/repos/Callino/pos/forks","keys_url":"https://api.github.com/repos/Callino/pos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Callino/pos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Callino/pos/teams","hooks_url":"https://api.github.com/repos/Callino/pos/hooks","issue_events_url":"https://api.github.com/repos/Callino/pos/issues/events{/number}","events_url":"https://api.github.com/repos/Callino/pos/events","assignees_url":"https://api.github.com/repos/Callino/pos/assignees{/user}","branches_url":"https://api.github.com/repos/Callino/pos/branches{/branch}","tags_url":"https://api.github.com/repos/Callino/pos/tags","blobs_url":"https://api.github.com/repos/Callino/pos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Callino/pos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Callino/pos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Callino/pos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Callino/pos/statuses/{sha}","languages_url":"https://api.github.com/repos/Callino/pos/languages","stargazers_url":"https://api.github.com/repos/Callino/pos/stargazers","contributors_url":"https://api.github.com/repos/Callino/pos/contributors","subscribers_url":"https://api.github.com/repos/Callino/pos/subscribers","subscription_url":"https://api.github.com/repos/Callino/pos/subscription","commits_url":"https://api.github.com/repos/Callino/pos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Callino/pos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Callino/pos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Callino/pos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Callino/pos/contents/{+path}","compare_url":"https://api.github.com/repos/Callino/pos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Callino/pos/merges","archive_url":"https://api.github.com/repos/Callino/pos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Callino/pos/downloads","issues_url":"https://api.github.com/repos/Callino/pos/issues{/number}","pulls_url":"https://api.github.com/repos/Callino/pos/pulls{/number}","milestones_url":"https://api.github.com/repos/Callino/pos/milestones{/number}","notifications_url":"https://api.github.com/repos/Callino/pos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Callino/pos/labels{/name}","releases_url":"https://api.github.com/repos/Callino/pos/releases{/id}","deployments_url":"https://api.github.com/repos/Callino/pos/deployments","created_at":"2016-12-14T09:17:59Z","updated_at":"2016-12-14T09:18:01Z","pushed_at":"2017-07-18T15:23:49Z","git_url":"git://github.com/Callino/pos.git","ssh_url":"git@github.com:Callino/pos.git","clone_url":"https://github.com/Callino/pos.git","svn_url":"https://github.com/Callino/pos","homepage":"http://odoo-community.org/project/59","size":1018,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"d39fe68a7529c27e1f15c5ce0d571e831544b74d","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":24946822,"name":"pos","full_name":"OCA/pos","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/pos","description":"Odoo Point of sale Addons","fork":false,"url":"https://api.github.com/repos/OCA/pos","forks_url":"https://api.github.com/repos/OCA/pos/forks","keys_url":"https://api.github.com/repos/OCA/pos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/pos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/pos/teams","hooks_url":"https://api.github.com/repos/OCA/pos/hooks","issue_events_url":"https://api.github.com/repos/OCA/pos/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/pos/events","assignees_url":"https://api.github.com/repos/OCA/pos/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/pos/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/pos/tags","blobs_url":"https://api.github.com/repos/OCA/pos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/pos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/pos/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/pos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/pos/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/pos/languages","stargazers_url":"https://api.github.com/repos/OCA/pos/stargazers","contributors_url":"https://api.github.com/repos/OCA/pos/contributors","subscribers_url":"https://api.github.com/repos/OCA/pos/subscribers","subscription_url":"https://api.github.com/repos/OCA/pos/subscription","commits_url":"https://api.github.com/repos/OCA/pos/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/pos/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/pos/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/pos/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/pos/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/pos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/pos/merges","archive_url":"https://api.github.com/repos/OCA/pos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/pos/downloads","issues_url":"https://api.github.com/repos/OCA/pos/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/pos/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/pos/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/pos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/pos/labels{/name}","releases_url":"https://api.github.com/repos/OCA/pos/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/pos/deployments","created_at":"2014-10-08T15:22:35Z","updated_at":"2017-06-13T21:19:29Z","pushed_at":"2017-08-25T09:01:28Z","git_url":"git://github.com/OCA/pos.git","ssh_url":"git@github.com:OCA/pos.git","clone_url":"https://github.com/OCA/pos.git","svn_url":"https://github.com/OCA/pos","homepage":"http://odoo-community.org/project/59","size":1576,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":54,"forks":157,"open_issues":54,"watchers":58,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/pos/pulls/186"},"html":{"href":"https://github.com/OCA/pos/pull/186"},"issue":{"href":"https://api.github.com/repos/OCA/pos/issues/186"},"comments":{"href":"https://api.github.com/repos/OCA/pos/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/pos/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/pos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/pos/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/pos/statuses/6792d25214baa701ac7f42e3bd0a8cbcafba5adc"}}}}
{"actor":{"display_login":"llacroix"}}