{"action":"created","comment":{"url":"https://api.github.com/repos/vertexproject/synapse/pulls/comments/125042177","pull_request_review_id":47394218,"id":125042177,"diff_hunk":"@@ -39,7 +39,7 @@ def test_certdir_user(self):\n     def test_certdir_host(self):\n         with self.getCertDir() as cdir:\n             cdir.genCaCert('syntest')\n-            cdir.genHostCert('visi.vertex.link', signas='syntest')\n+            cdir.genHostCert('visi.vertex.link', signas='syntest', sans='DNS:visi.vertex.link,DNS:vertex.link')","path":"synapse/tests/test_lib_certdir.py","position":null,"original_position":5,"commit_id":"22dbf0105204db32f4d5537915557da7223c3e48","original_commit_id":"595c9ad2ef2cbcb3876067c004f0b7e08e4ae97a","user":{"login":"vertexmc","id":25180408,"avatar_url":"https://avatars2.githubusercontent.com/u/25180408?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexmc","html_url":"https://github.com/vertexmc","followers_url":"https://api.github.com/users/vertexmc/followers","following_url":"https://api.github.com/users/vertexmc/following{/other_user}","gists_url":"https://api.github.com/users/vertexmc/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexmc/subscriptions","organizations_url":"https://api.github.com/users/vertexmc/orgs","repos_url":"https://api.github.com/users/vertexmc/repos","events_url":"https://api.github.com/users/vertexmc/events{/privacy}","received_events_url":"https://api.github.com/users/vertexmc/received_events","type":"User","site_admin":false},"body":"I also added `DNS:vertex.link` to `sans` and the test asserts that it is only added to the cert once.","created_at":"2017-06-30T13:44:32Z","updated_at":"2017-06-30T13:44:32Z","html_url":"https://github.com/vertexproject/synapse/pull/285#discussion_r125042177","pull_request_url":"https://api.github.com/repos/vertexproject/synapse/pulls/285","_links":{"self":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/comments/125042177"},"html":{"href":"https://github.com/vertexproject/synapse/pull/285#discussion_r125042177"},"pull_request":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/vertexproject/synapse/pulls/285","id":128232991,"html_url":"https://github.com/vertexproject/synapse/pull/285","diff_url":"https://github.com/vertexproject/synapse/pull/285.diff","patch_url":"https://github.com/vertexproject/synapse/pull/285.patch","issue_url":"https://api.github.com/repos/vertexproject/synapse/issues/285","number":285,"state":"open","locked":false,"title":"EasyCert Chrome 58+ compatibility changes","user":{"login":"vertexmc","id":25180408,"avatar_url":"https://avatars2.githubusercontent.com/u/25180408?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexmc","html_url":"https://github.com/vertexmc","followers_url":"https://api.github.com/users/vertexmc/followers","following_url":"https://api.github.com/users/vertexmc/following{/other_user}","gists_url":"https://api.github.com/users/vertexmc/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexmc/subscriptions","organizations_url":"https://api.github.com/users/vertexmc/orgs","repos_url":"https://api.github.com/users/vertexmc/repos","events_url":"https://api.github.com/users/vertexmc/events{/privacy}","received_events_url":"https://api.github.com/users/vertexmc/received_events","type":"User","site_admin":false},"body":"- subjectAltName added to server certs\r\n- serial number changed from timestamp to guid","created_at":"2017-06-29T19:50:39Z","updated_at":"2017-06-30T13:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fe54b4a9d8ffcfa3e080f81fb76fbaaca9f7edc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/vertexproject/synapse/milestones/13","html_url":"https://github.com/vertexproject/synapse/milestone/13","labels_url":"https://api.github.com/repos/vertexproject/synapse/milestones/13/labels","id":2605532,"number":13,"title":"v0.0.20","description":"","creator":{"login":"vertexmc","id":25180408,"avatar_url":"https://avatars2.githubusercontent.com/u/25180408?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexmc","html_url":"https://github.com/vertexmc","followers_url":"https://api.github.com/users/vertexmc/followers","following_url":"https://api.github.com/users/vertexmc/following{/other_user}","gists_url":"https://api.github.com/users/vertexmc/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexmc/subscriptions","organizations_url":"https://api.github.com/users/vertexmc/orgs","repos_url":"https://api.github.com/users/vertexmc/repos","events_url":"https://api.github.com/users/vertexmc/events{/privacy}","received_events_url":"https://api.github.com/users/vertexmc/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":11,"state":"open","created_at":"2017-06-26T19:49:55Z","updated_at":"2017-06-29T20:52:02Z","due_on":"2017-07-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vertexproject/synapse/pulls/285/commits","review_comments_url":"https://api.github.com/repos/vertexproject/synapse/pulls/285/comments","review_comment_url":"https://api.github.com/repos/vertexproject/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vertexproject/synapse/issues/285/comments","statuses_url":"https://api.github.com/repos/vertexproject/synapse/statuses/22dbf0105204db32f4d5537915557da7223c3e48","head":{"label":"vertexmc:easycert_chrome","ref":"easycert_chrome","sha":"22dbf0105204db32f4d5537915557da7223c3e48","user":{"login":"vertexmc","id":25180408,"avatar_url":"https://avatars2.githubusercontent.com/u/25180408?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexmc","html_url":"https://github.com/vertexmc","followers_url":"https://api.github.com/users/vertexmc/followers","following_url":"https://api.github.com/users/vertexmc/following{/other_user}","gists_url":"https://api.github.com/users/vertexmc/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexmc/subscriptions","organizations_url":"https://api.github.com/users/vertexmc/orgs","repos_url":"https://api.github.com/users/vertexmc/repos","events_url":"https://api.github.com/users/vertexmc/events{/privacy}","received_events_url":"https://api.github.com/users/vertexmc/received_events","type":"User","site_admin":false},"repo":{"id":79249563,"name":"synapse","full_name":"vertexmc/synapse","owner":{"login":"vertexmc","id":25180408,"avatar_url":"https://avatars2.githubusercontent.com/u/25180408?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexmc","html_url":"https://github.com/vertexmc","followers_url":"https://api.github.com/users/vertexmc/followers","following_url":"https://api.github.com/users/vertexmc/following{/other_user}","gists_url":"https://api.github.com/users/vertexmc/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexmc/subscriptions","organizations_url":"https://api.github.com/users/vertexmc/orgs","repos_url":"https://api.github.com/users/vertexmc/repos","events_url":"https://api.github.com/users/vertexmc/events{/privacy}","received_events_url":"https://api.github.com/users/vertexmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vertexmc/synapse","description":"Distributed Computing Framework","fork":true,"url":"https://api.github.com/repos/vertexmc/synapse","forks_url":"https://api.github.com/repos/vertexmc/synapse/forks","keys_url":"https://api.github.com/repos/vertexmc/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vertexmc/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vertexmc/synapse/teams","hooks_url":"https://api.github.com/repos/vertexmc/synapse/hooks","issue_events_url":"https://api.github.com/repos/vertexmc/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/vertexmc/synapse/events","assignees_url":"https://api.github.com/repos/vertexmc/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/vertexmc/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/vertexmc/synapse/tags","blobs_url":"https://api.github.com/repos/vertexmc/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vertexmc/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vertexmc/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/vertexmc/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vertexmc/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/vertexmc/synapse/languages","stargazers_url":"https://api.github.com/repos/vertexmc/synapse/stargazers","contributors_url":"https://api.github.com/repos/vertexmc/synapse/contributors","subscribers_url":"https://api.github.com/repos/vertexmc/synapse/subscribers","subscription_url":"https://api.github.com/repos/vertexmc/synapse/subscription","commits_url":"https://api.github.com/repos/vertexmc/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/vertexmc/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/vertexmc/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/vertexmc/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/vertexmc/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/vertexmc/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vertexmc/synapse/merges","archive_url":"https://api.github.com/repos/vertexmc/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vertexmc/synapse/downloads","issues_url":"https://api.github.com/repos/vertexmc/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/vertexmc/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/vertexmc/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/vertexmc/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vertexmc/synapse/labels{/name}","releases_url":"https://api.github.com/repos/vertexmc/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/vertexmc/synapse/deployments","created_at":"2017-01-17T16:50:56Z","updated_at":"2017-01-17T16:51:00Z","pushed_at":"2017-06-30T13:43:43Z","git_url":"git://github.com/vertexmc/synapse.git","ssh_url":"git@github.com:vertexmc/synapse.git","clone_url":"https://github.com/vertexmc/synapse.git","svn_url":"https://github.com/vertexmc/synapse","homepage":null,"size":3284,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vertexproject:master","ref":"master","sha":"db46e09510c65563332c065825ae8b60fb6bb8b6","user":{"login":"vertexproject","id":21201579,"avatar_url":"https://avatars1.githubusercontent.com/u/21201579?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37228107,"name":"synapse","full_name":"vertexproject/synapse","owner":{"login":"vertexproject","id":21201579,"avatar_url":"https://avatars1.githubusercontent.com/u/21201579?v=3","gravatar_id":"","url":"https://api.github.com/users/vertexproject","html_url":"https://github.com/vertexproject","followers_url":"https://api.github.com/users/vertexproject/followers","following_url":"https://api.github.com/users/vertexproject/following{/other_user}","gists_url":"https://api.github.com/users/vertexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vertexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertexproject/subscriptions","organizations_url":"https://api.github.com/users/vertexproject/orgs","repos_url":"https://api.github.com/users/vertexproject/repos","events_url":"https://api.github.com/users/vertexproject/events{/privacy}","received_events_url":"https://api.github.com/users/vertexproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vertexproject/synapse","description":"Distributed Key-Value Hypergraph Analysis Framework","fork":false,"url":"https://api.github.com/repos/vertexproject/synapse","forks_url":"https://api.github.com/repos/vertexproject/synapse/forks","keys_url":"https://api.github.com/repos/vertexproject/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vertexproject/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vertexproject/synapse/teams","hooks_url":"https://api.github.com/repos/vertexproject/synapse/hooks","issue_events_url":"https://api.github.com/repos/vertexproject/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/vertexproject/synapse/events","assignees_url":"https://api.github.com/repos/vertexproject/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/vertexproject/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/vertexproject/synapse/tags","blobs_url":"https://api.github.com/repos/vertexproject/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vertexproject/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vertexproject/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/vertexproject/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vertexproject/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/vertexproject/synapse/languages","stargazers_url":"https://api.github.com/repos/vertexproject/synapse/stargazers","contributors_url":"https://api.github.com/repos/vertexproject/synapse/contributors","subscribers_url":"https://api.github.com/repos/vertexproject/synapse/subscribers","subscription_url":"https://api.github.com/repos/vertexproject/synapse/subscription","commits_url":"https://api.github.com/repos/vertexproject/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/vertexproject/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/vertexproject/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/vertexproject/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/vertexproject/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/vertexproject/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vertexproject/synapse/merges","archive_url":"https://api.github.com/repos/vertexproject/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vertexproject/synapse/downloads","issues_url":"https://api.github.com/repos/vertexproject/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/vertexproject/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/vertexproject/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/vertexproject/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vertexproject/synapse/labels{/name}","releases_url":"https://api.github.com/repos/vertexproject/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/vertexproject/synapse/deployments","created_at":"2015-06-10T23:29:41Z","updated_at":"2017-05-15T23:55:07Z","pushed_at":"2017-06-30T13:43:44Z","git_url":"git://github.com/vertexproject/synapse.git","ssh_url":"git@github.com:vertexproject/synapse.git","clone_url":"https://github.com/vertexproject/synapse.git","svn_url":"https://github.com/vertexproject/synapse","homepage":"","size":3287,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":25,"forks":20,"open_issues":25,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/285"},"html":{"href":"https://github.com/vertexproject/synapse/pull/285"},"issue":{"href":"https://api.github.com/repos/vertexproject/synapse/issues/285"},"comments":{"href":"https://api.github.com/repos/vertexproject/synapse/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vertexproject/synapse/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/vertexproject/synapse/statuses/22dbf0105204db32f4d5537915557da7223c3e48"}}}}
{"actor":{"display_login":"vertexmc"}}