{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/103659545","pull_request_review_id":24451800,"id":103659545,"diff_hunk":"@@ -35,77 +33,19 @@ function nodeName_(element) {\n  * @name $touchProvider\n  *\n  * @description\n- * The `$touchProvider` allows enabling / disabling {@link ngTouch.ngClick ngTouch's ngClick directive}.\n+ * The `$touchProvider` allows configuration of the ngTouch module. It currently contains\n+ * no methods.\n  */\n-$TouchProvider.$inject = ['$provide', '$compileProvider'];\n-function $TouchProvider($provide, $compileProvider) {\n-\n-  /**\n-   * @ngdoc method\n-   * @name  $touchProvider#ngClickOverrideEnabled\n-   *\n-   * @param {boolean=} enabled update the ngClickOverrideEnabled state if provided, otherwise just return the\n-   * current ngClickOverrideEnabled state\n-   * @returns {*} current value if used as getter or itself (chaining) if used as setter\n-   *\n-   * @kind function\n-   *\n-   * @description\n-   * Call this method to enable/disable {@link ngTouch.ngClick ngTouch's ngClick directive}. If enabled,\n-   * the default ngClick directive will be replaced by a version that eliminates the 300ms delay for\n-   * click events on browser for touch-devices.\n-   *\n-   * The default is `false`.\n-   *\n-   */\n-  var ngClickOverrideEnabled = false;\n-  var ngClickDirectiveAdded = false;\n-  // eslint-disable-next-line no-invalid-this\n-  this.ngClickOverrideEnabled = function(enabled) {\n-    if (angular.isDefined(enabled)) {\n-\n-      if (enabled && !ngClickDirectiveAdded) {\n-        ngClickDirectiveAdded = true;\n-\n-        // Use this to identify the correct directive in the delegate\n-        ngTouchClickDirectiveFactory.$$moduleName = 'ngTouch';\n-        $compileProvider.directive('ngClick', ngTouchClickDirectiveFactory);\n-\n-        $provide.decorator('ngClickDirective', ['$delegate', function($delegate) {\n-          if (ngClickOverrideEnabled) {\n-            // drop the default ngClick directive\n-            $delegate.shift();\n-          } else {\n-            // drop the ngTouch ngClick directive if the override has been re-disabled (because\n-            // we cannot de-register added directives)\n-            var i = $delegate.length - 1;\n-            while (i >= 0) {\n-              if ($delegate[i].$$moduleName === 'ngTouch') {\n-                $delegate.splice(i, 1);\n-                break;\n-              }\n-              i--;\n-            }\n-          }\n-\n-          return $delegate;\n-        }]);\n-      }\n-\n-      ngClickOverrideEnabled = enabled;\n-      return this;\n-    }\n-\n-    return ngClickOverrideEnabled;\n-  };\n+$TouchProvider.$inject = [];\n+function $TouchProvider() {\n \n   /**\n   * @ngdoc service\n   * @name $touch\n   * @kind object\n   *\n   * @description\n-  * Provides the {@link ngTouch.$touch#ngClickOverrideEnabled `ngClickOverrideEnabled`} method.\n+  * Provides the legacy {@link ngTouch.$touch#ngClickOverrideEnabled `ngClickOverrideEnabled`} method.","path":"src/ngTouch/touch.js","position":105,"original_position":105,"commit_id":"f6414841e9e4b9d502ca172914fb292898f14cb3","original_commit_id":"f6414841e9e4b9d502ca172914fb292898f14cb3","user":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars2.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"body":"So, it looks like material never implemented a check with ngClickOverrideEnabled, it simply is not compatible with ngTouch: https://github.com/angular/material/blob/24370e7627389a873a95777f8bebc8bb43c842ce/src/core/core.js#L23\r\n\r\nI think that means we can remove $touch.ngClickOverrideEnabled\r\nI doubt that anyone else uses it (famous last words)","created_at":"2017-03-01T11:04:50Z","updated_at":"2017-03-01T11:04:50Z","html_url":"https://github.com/angular/angular.js/pull/15761#discussion_r103659545","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/15761","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/103659545"},"html":{"href":"https://github.com/angular/angular.js/pull/15761#discussion_r103659545"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15761"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/15761","id":108379464,"html_url":"https://github.com/angular/angular.js/pull/15761","diff_url":"https://github.com/angular/angular.js/pull/15761.diff","patch_url":"https://github.com/angular/angular.js/pull/15761.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/15761","number":15761,"state":"open","locked":false,"title":"fix(ngTouch): remove ngClick override and $touchProvider.ngClickOverr…","user":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars2.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"body":"…ideEnabled()\r\n\r\nCloses #15755\r\n\r\nBREAKING CHANGE:\r\n\r\nThe `ngClick` directive from the ngTouch module has been removed, and with the also the\r\ncorresponding $touchProvider.ngClickOverrideEnabled() method.\r\n\r\nIf you have included ngTouch in your application with a version of 1.5.0 or higher, and have not\r\nchanged the value of $touchProvider.ngClickOverrideEnabled()`, then there are no migration steps.\r\n\r\nThe `ngClick` override directive had been deprecated and by default disabled since v1.5.0,\r\nbecause of buggy behavior in edge cases, and a general trend to avoid special touch based\r\noverrides of click events. If you still need a touch override, consider using\r\n[Fastclick](https://github.com/ftlabs/fastclick).\r\n\r\nNote that the `$touch` service still offers the `ngClickOverrideEnabled()` function for\r\nlibraries that want to detect if an app uses the click override. Starting with 1.7.0, it\r\nwill always return `false`.\r\n\r\n\r\nOther info:\r\n\r\nThis one is a bit tricky, as we have deprecated the ngClick directive, but at the same time introduced two new APIs: $touchProvider.ngClickOverrideEnabled and $touch.ngClickOverrideEnabled().\r\nI have removed the former, because it's directly tied to the directive. I think that's fine, as someone who uses the ngClick override must migrate to a different solution anyway, and will see an error when he updates and the provider fn is missing. I've kept the actual provider for the unlikely case that we introduce new config for the ngTouch module.\r\nI've also kept the $touch.ngClickOverrideEnabled() method, as this one is used by material to check if they should include their own touch stuff. I think if we removed this then they wouldn't be able to determine if the ngClick override is present (because ngTouch module but no $touch service could also mean a pre 1.5.0 version of ngTouch)\r\n","created_at":"2017-02-28T17:27:19Z","updated_at":"2017-03-01T11:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06596d1edcc649935f1b500e1bec657871c33250","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/128","html_url":"https://github.com/angular/angular.js/milestone/128","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/128/labels","id":2049673,"number":128,"title":"1.7.0","description":"Stuff that cannot go into 1.6.x or earlier but that we definitely intend to implement or merge.","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars3.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2016-10-05T13:44:57Z","updated_at":"2017-02-28T17:40:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/15761/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/15761/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/15761/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/f6414841e9e4b9d502ca172914fb292898f14cb3","head":{"label":"Narretz:fix-remove-ngtouch-nglick","ref":"fix-remove-ngtouch-nglick","sha":"f6414841e9e4b9d502ca172914fb292898f14cb3","user":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars2.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"repo":{"id":14773045,"name":"angular.js","full_name":"Narretz/angular.js","owner":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars2.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Narretz/angular.js","description":null,"fork":true,"url":"https://api.github.com/repos/Narretz/angular.js","forks_url":"https://api.github.com/repos/Narretz/angular.js/forks","keys_url":"https://api.github.com/repos/Narretz/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Narretz/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Narretz/angular.js/teams","hooks_url":"https://api.github.com/repos/Narretz/angular.js/hooks","issue_events_url":"https://api.github.com/repos/Narretz/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/Narretz/angular.js/events","assignees_url":"https://api.github.com/repos/Narretz/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/Narretz/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/Narretz/angular.js/tags","blobs_url":"https://api.github.com/repos/Narretz/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Narretz/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Narretz/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Narretz/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Narretz/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Narretz/angular.js/languages","stargazers_url":"https://api.github.com/repos/Narretz/angular.js/stargazers","contributors_url":"https://api.github.com/repos/Narretz/angular.js/contributors","subscribers_url":"https://api.github.com/repos/Narretz/angular.js/subscribers","subscription_url":"https://api.github.com/repos/Narretz/angular.js/subscription","commits_url":"https://api.github.com/repos/Narretz/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Narretz/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Narretz/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Narretz/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Narretz/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/Narretz/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Narretz/angular.js/merges","archive_url":"https://api.github.com/repos/Narretz/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Narretz/angular.js/downloads","issues_url":"https://api.github.com/repos/Narretz/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/Narretz/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Narretz/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Narretz/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Narretz/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/Narretz/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/Narretz/angular.js/deployments","created_at":"2013-11-28T09:39:41Z","updated_at":"2016-01-19T19:00:19Z","pushed_at":"2017-02-28T17:38:37Z","git_url":"git://github.com/Narretz/angular.js.git","ssh_url":"git@github.com:Narretz/angular.js.git","clone_url":"https://github.com/Narretz/angular.js.git","svn_url":"https://github.com/Narretz/angular.js","homepage":"http://angularjs.org","size":84977,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"19bc52127f8393ffccac563b21267adb75c19275","user":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"AngularJS - HTML enhanced for web apps!","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2017-03-01T10:19:01Z","pushed_at":"2017-03-01T09:54:03Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"https://angularjs.org","size":86605,"stargazers_count":54911,"watchers_count":54911,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27355,"mirror_url":null,"open_issues_count":789,"forks":27355,"open_issues":789,"watchers":54911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15761"},"html":{"href":"https://github.com/angular/angular.js/pull/15761"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/15761"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/15761/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15761/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15761/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/f6414841e9e4b9d502ca172914fb292898f14cb3"}}}}
{"actor":{"display_login":"Narretz"}}