{"action":"created","issue":{"url":"https://api.github.com/repos/jashkenas/backbone/issues/4175","repository_url":"https://api.github.com/repos/jashkenas/backbone","labels_url":"https://api.github.com/repos/jashkenas/backbone/issues/4175/labels{/name}","comments_url":"https://api.github.com/repos/jashkenas/backbone/issues/4175/comments","events_url":"https://api.github.com/repos/jashkenas/backbone/issues/4175/events","html_url":"https://github.com/jashkenas/backbone/pull/4175","id":281956584,"number":4175,"title":"Fix navigate with replace: true and diacriticals/unicode characters in the hash","user":{"login":"gwynjudd","id":314188,"avatar_url":"https://avatars1.githubusercontent.com/u/314188?v=4","gravatar_id":"","url":"https://api.github.com/users/gwynjudd","html_url":"https://github.com/gwynjudd","followers_url":"https://api.github.com/users/gwynjudd/followers","following_url":"https://api.github.com/users/gwynjudd/following{/other_user}","gists_url":"https://api.github.com/users/gwynjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/gwynjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwynjudd/subscriptions","organizations_url":"https://api.github.com/users/gwynjudd/orgs","repos_url":"https://api.github.com/users/gwynjudd/repos","events_url":"https://api.github.com/users/gwynjudd/events{/privacy}","received_events_url":"https://api.github.com/users/gwynjudd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-14T01:54:41Z","updated_at":"2017-12-14T03:57:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/4175","html_url":"https://github.com/jashkenas/backbone/pull/4175","diff_url":"https://github.com/jashkenas/backbone/pull/4175.diff","patch_url":"https://github.com/jashkenas/backbone/pull/4175.patch"},"body":"It seems there is a change in chrome 63 (also similarly\r\nintroduced a while ago in some earlier version of iOS Safari) where the\r\nhash portion of the location.href is encoded, where it used to be\r\ndecoded\r\n\r\nFixes https://github.com/jashkenas/backbone/issues/4085"},"comment":{"url":"https://api.github.com/repos/jashkenas/backbone/issues/comments/351601896","html_url":"https://github.com/jashkenas/backbone/pull/4175#issuecomment-351601896","issue_url":"https://api.github.com/repos/jashkenas/backbone/issues/4175","id":351601896,"user":{"login":"gwynjudd","id":314188,"avatar_url":"https://avatars1.githubusercontent.com/u/314188?v=4","gravatar_id":"","url":"https://api.github.com/users/gwynjudd","html_url":"https://github.com/gwynjudd","followers_url":"https://api.github.com/users/gwynjudd/followers","following_url":"https://api.github.com/users/gwynjudd/following{/other_user}","gists_url":"https://api.github.com/users/gwynjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/gwynjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwynjudd/subscriptions","organizations_url":"https://api.github.com/users/gwynjudd/orgs","repos_url":"https://api.github.com/users/gwynjudd/repos","events_url":"https://api.github.com/users/gwynjudd/events{/privacy}","received_events_url":"https://api.github.com/users/gwynjudd/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T03:57:19Z","updated_at":"2017-12-14T03:57:19Z","author_association":"NONE","body":"Anyone reading this, I couldn't actually get the added unit tests to \"successfully fail\". The reason being, it seems that running in karma-chrome-launcher, the 'hashchange' event never actually fires so the checkUrl method isn't called. Despite this, I added the tests in the hope that somebody could figure that out. I can verify that the change does actually work by manually testing it in various contexts."}}
{"actor":{"display_login":"gwynjudd"}}