{"action":"created","issue":{"url":"https://api.github.com/repos/TV-Rename/tvrename/issues/187","repository_url":"https://api.github.com/repos/TV-Rename/tvrename","labels_url":"https://api.github.com/repos/TV-Rename/tvrename/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/TV-Rename/tvrename/issues/187/comments","events_url":"https://api.github.com/repos/TV-Rename/tvrename/issues/187/events","html_url":"https://github.com/TV-Rename/tvrename/issues/187","id":283994680,"number":187,"title":"Automated builds/releases","user":{"login":"JoeBiellik","id":43646,"avatar_url":"https://avatars1.githubusercontent.com/u/43646?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeBiellik","html_url":"https://github.com/JoeBiellik","followers_url":"https://api.github.com/users/JoeBiellik/followers","following_url":"https://api.github.com/users/JoeBiellik/following{/other_user}","gists_url":"https://api.github.com/users/JoeBiellik/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeBiellik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeBiellik/subscriptions","organizations_url":"https://api.github.com/users/JoeBiellik/orgs","repos_url":"https://api.github.com/users/JoeBiellik/repos","events_url":"https://api.github.com/users/JoeBiellik/events{/privacy}","received_events_url":"https://api.github.com/users/JoeBiellik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-12-21T20:25:55Z","updated_at":"2017-12-22T05:25:19Z","closed_at":null,"author_association":"COLLABORATOR","body":"@MarkSummerville mentioned in #185 the need for an easier build/deploy process. From what I can see, currently, NSIS is manually used to build an installer package from a compiled release build.\r\n\r\nVersion numbers across the project seem sporadic, [Version.cs](https://github.com/TV-Rename/tvrename/blob/master/TVRename%23/App/Version.cs) seems outdated, [AssemblyInfo.cs](https://github.com/TV-Rename/tvrename/blob/master/TVRename%23/Properties/AssemblyInfo.cs)'s ``AssemblyVersion`` is wrong and ``AssemblyFileVersion`` is used to determine the config directory (see #186).\r\nFinally, the NSIS scripts are a little outdated and incorrectly report that .NET Framework 2.0 is required when the project is built against 4.0 and include dead download links.\r\n\r\nI've had great success using a free [AppVeyor](https://www.appveyor.com/) account to automatically pull, build and push to a GitHub release, so that's what I would strongly suggest.\r\n\r\nI'll happily make a pull request fixing the above-mentioned issues and configuring AppVeyor, however, a project owner will need to create the AppVeyor account to grant GitHub access.\r\n\r\nIt would work by an owner manually creating a GitHub release or tag, AppVeyor would pull and build the code, run NSIS and then upload the resulting installer to the GitHub release. To build locally you would need to install NSIS and the 2 plugins as needed currently, then run the package command, providing the version numbers from git."},"comment":{"url":"https://api.github.com/repos/TV-Rename/tvrename/issues/comments/353524723","html_url":"https://github.com/TV-Rename/tvrename/issues/187#issuecomment-353524723","issue_url":"https://api.github.com/repos/TV-Rename/tvrename/issues/187","id":353524723,"user":{"login":"JoeBiellik","id":43646,"avatar_url":"https://avatars1.githubusercontent.com/u/43646?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeBiellik","html_url":"https://github.com/JoeBiellik","followers_url":"https://api.github.com/users/JoeBiellik/followers","following_url":"https://api.github.com/users/JoeBiellik/following{/other_user}","gists_url":"https://api.github.com/users/JoeBiellik/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeBiellik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeBiellik/subscriptions","organizations_url":"https://api.github.com/users/JoeBiellik/orgs","repos_url":"https://api.github.com/users/JoeBiellik/repos","events_url":"https://api.github.com/users/JoeBiellik/events{/privacy}","received_events_url":"https://api.github.com/users/JoeBiellik/received_events","type":"User","site_admin":false},"created_at":"2017-12-22T05:25:19Z","updated_at":"2017-12-22T05:25:19Z","author_association":"COLLABORATOR","body":"Very nice! The only issue is the installer name and software will report version 2.3.6 as that's the tag you used, it also makes it quite hard to jump to the correct versions code in git.\r\n\r\nFor ``2.3 RC 2``, semantic versioning states ``2.3.0-rc2`` is the correct tag name, however, that is not a valid Windows version number (4 sections, digits only) which confuses the issue. If you used that tag then AppVeyor will error when it tries to build the project.\r\n\r\nI'll have a look at updating the AppVeyor script, it should be possible to trim everything after a dash for the actual file version number, but keep the ``-rc2`` for the filename and display inside the app. Perhaps for now it would be better if you removed the tag or recreated it as ``2.3.0``. Not sure how you would tag RC3 or the final 2.3 release though?"}}
{"actor":{"display_login":"JoeBiellik"}}