{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/132534260","pull_request_review_id":55626476,"id":132534260,"diff_hunk":"@@ -4590,11 +4590,11 @@ chain(p, q, ...) --> p0, p1, ... plast, q0, q1, ... \\n\\\n chain.from_iterable([p, q, ...]) --> p0, p1, ... plast, q0, q1, ... \\n\\\n compress(data, selectors) --> (d[0] if s[0]), (d[1] if s[1]), ...\\n\\\n dropwhile(pred, seq) --> seq[n], seq[n+1], starting when pred fails\\n\\\n-groupby(iterable[, keyfunc]) --> sub-iterators grouped by value of keyfunc(v)\\n\\\n+groupby(iterable, key=None) --> sub-iterators grouped by value of keyfunc(v)\\n\\","path":"Modules/itertoolsmodule.c","position":null,"original_position":36,"commit_id":"7c857f8fa32384aff21b73c77f69f08db39d30c6","original_commit_id":"e8d4b64b113f71b67b7a1cf97e63e269abf1c304","user":{"login":"NicholasKobald","id":17344901,"avatar_url":"https://avatars2.githubusercontent.com/u/17344901?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasKobald","html_url":"https://github.com/NicholasKobald","followers_url":"https://api.github.com/users/NicholasKobald/followers","following_url":"https://api.github.com/users/NicholasKobald/following{/other_user}","gists_url":"https://api.github.com/users/NicholasKobald/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasKobald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasKobald/subscriptions","organizations_url":"https://api.github.com/users/NicholasKobald/orgs","repos_url":"https://api.github.com/users/NicholasKobald/repos","events_url":"https://api.github.com/users/NicholasKobald/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasKobald/received_events","type":"User","site_admin":false},"body":"Changed in b6336f5. \r\n\r\nI'm a bit worried it looks confusing to someone that hasn't used group by before. Someone might assume that it defaults to None, and will assume that not providing a function will cause a crash when a None value is called. ","created_at":"2017-08-10T18:36:55Z","updated_at":"2017-08-10T18:36:55Z","html_url":"https://github.com/python/cpython/pull/3047#discussion_r132534260","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/3047","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/132534260"},"html":{"href":"https://github.com/python/cpython/pull/3047#discussion_r132534260"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/3047"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/3047","id":134961603,"html_url":"https://github.com/python/cpython/pull/3047","diff_url":"https://github.com/python/cpython/pull/3047.diff","patch_url":"https://github.com/python/cpython/pull/3047.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/3047","number":3047,"state":"open","locked":false,"title":"bpo-31153: Update docstrings of itertools functions","user":{"login":"NicholasKobald","id":17344901,"avatar_url":"https://avatars2.githubusercontent.com/u/17344901?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasKobald","html_url":"https://github.com/NicholasKobald","followers_url":"https://api.github.com/users/NicholasKobald/followers","following_url":"https://api.github.com/users/NicholasKobald/following{/other_user}","gists_url":"https://api.github.com/users/NicholasKobald/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasKobald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasKobald/subscriptions","organizations_url":"https://api.github.com/users/NicholasKobald/orgs","repos_url":"https://api.github.com/users/NicholasKobald/repos","events_url":"https://api.github.com/users/NicholasKobald/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasKobald/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: bpo-31153 -->\nhttps://bugs.python.org/issue31153\n<!-- /issue-number -->\n","created_at":"2017-08-09T18:39:07Z","updated_at":"2017-08-10T18:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3a5dcc124236d8f53ec00af06ccdfd1642d2bdc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/3047/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/3047/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/3047/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/7c857f8fa32384aff21b73c77f69f08db39d30c6","head":{"label":"NicholasKobald:bpo-31153-update-itertools-docstring","ref":"bpo-31153-update-itertools-docstring","sha":"7c857f8fa32384aff21b73c77f69f08db39d30c6","user":{"login":"NicholasKobald","id":17344901,"avatar_url":"https://avatars2.githubusercontent.com/u/17344901?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasKobald","html_url":"https://github.com/NicholasKobald","followers_url":"https://api.github.com/users/NicholasKobald/followers","following_url":"https://api.github.com/users/NicholasKobald/following{/other_user}","gists_url":"https://api.github.com/users/NicholasKobald/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasKobald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasKobald/subscriptions","organizations_url":"https://api.github.com/users/NicholasKobald/orgs","repos_url":"https://api.github.com/users/NicholasKobald/repos","events_url":"https://api.github.com/users/NicholasKobald/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasKobald/received_events","type":"User","site_admin":false},"repo":{"id":97861519,"name":"cpython","full_name":"NicholasKobald/cpython","owner":{"login":"NicholasKobald","id":17344901,"avatar_url":"https://avatars2.githubusercontent.com/u/17344901?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasKobald","html_url":"https://github.com/NicholasKobald","followers_url":"https://api.github.com/users/NicholasKobald/followers","following_url":"https://api.github.com/users/NicholasKobald/following{/other_user}","gists_url":"https://api.github.com/users/NicholasKobald/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasKobald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasKobald/subscriptions","organizations_url":"https://api.github.com/users/NicholasKobald/orgs","repos_url":"https://api.github.com/users/NicholasKobald/repos","events_url":"https://api.github.com/users/NicholasKobald/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasKobald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NicholasKobald/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/NicholasKobald/cpython","forks_url":"https://api.github.com/repos/NicholasKobald/cpython/forks","keys_url":"https://api.github.com/repos/NicholasKobald/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NicholasKobald/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NicholasKobald/cpython/teams","hooks_url":"https://api.github.com/repos/NicholasKobald/cpython/hooks","issue_events_url":"https://api.github.com/repos/NicholasKobald/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/NicholasKobald/cpython/events","assignees_url":"https://api.github.com/repos/NicholasKobald/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/NicholasKobald/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/NicholasKobald/cpython/tags","blobs_url":"https://api.github.com/repos/NicholasKobald/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NicholasKobald/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NicholasKobald/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/NicholasKobald/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NicholasKobald/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/NicholasKobald/cpython/languages","stargazers_url":"https://api.github.com/repos/NicholasKobald/cpython/stargazers","contributors_url":"https://api.github.com/repos/NicholasKobald/cpython/contributors","subscribers_url":"https://api.github.com/repos/NicholasKobald/cpython/subscribers","subscription_url":"https://api.github.com/repos/NicholasKobald/cpython/subscription","commits_url":"https://api.github.com/repos/NicholasKobald/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/NicholasKobald/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/NicholasKobald/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/NicholasKobald/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/NicholasKobald/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/NicholasKobald/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NicholasKobald/cpython/merges","archive_url":"https://api.github.com/repos/NicholasKobald/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NicholasKobald/cpython/downloads","issues_url":"https://api.github.com/repos/NicholasKobald/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/NicholasKobald/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/NicholasKobald/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/NicholasKobald/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NicholasKobald/cpython/labels{/name}","releases_url":"https://api.github.com/repos/NicholasKobald/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/NicholasKobald/cpython/deployments","created_at":"2017-07-20T17:28:33Z","updated_at":"2017-07-20T17:28:57Z","pushed_at":"2017-08-10T18:34:13Z","git_url":"git://github.com/NicholasKobald/cpython.git","ssh_url":"git@github.com:NicholasKobald/cpython.git","clone_url":"https://github.com/NicholasKobald/cpython.git","svn_url":"https://github.com/NicholasKobald/cpython","homepage":"https://www.python.org/","size":210277,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"da5e9301877346942fa4279612750d6a09e05153","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2017-08-10T18:29:32Z","pushed_at":"2017-08-10T18:34:18Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":211257,"stargazers_count":12213,"watchers_count":12213,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2150,"mirror_url":null,"open_issues_count":417,"forks":2150,"open_issues":417,"watchers":12213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/3047"},"html":{"href":"https://github.com/python/cpython/pull/3047"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/3047"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/3047/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/3047/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/3047/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/7c857f8fa32384aff21b73c77f69f08db39d30c6"}}}}
{"actor":{"display_login":"NicholasKobald"}}