{"action":"created","issue":{"url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/383","repository_url":"https://api.github.com/repos/Dart-Code/Dart-Code","labels_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/383/labels{/name}","comments_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/383/comments","events_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/383/events","html_url":"https://github.com/Dart-Code/Dart-Code/issues/383","id":244901491,"number":383,"title":"Feedback on \"closing labels\" preview feature","user":{"login":"DanTup","id":1078012,"avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":633293762,"url":"https://api.github.com/repos/Dart-Code/Dart-Code/labels/in%20editor","name":"in editor","color":"5319e7","default":false},{"id":416693373,"url":"https://api.github.com/repos/Dart-Code/Dart-Code/labels/question%20/%20discussion%20/%20feedback","name":"question / discussion / feedback","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2017-07-23T10:19:19Z","updated_at":"2017-09-21T16:53:37Z","closed_at":null,"author_association":"OWNER","body":"v2.3.1 includes a preview feature enabled with the `dart.previewFlutterCloseTagDecorations: true` setting. This adds \"closing tag\" decorations to the closing parens of constructor calls within `build` methods.\r\n\r\nThis feature is behind a flag because it's incomplete, has sub-optimal performance and may not work reliably. It is being shipped solely for feedback on the idea and may require analyzer work in order to support in a reliable way.\r\n\r\nPlease post your feedback below!\r\n\r\n![Flutter closing tag decorations](https://user-images.githubusercontent.com/1078012/28498671-6ec16dba-6f9a-11e7-82fe-8fec8d0a3b2f.png)\r\n\r\n### Known issues:\r\n\r\nThese are things that (probably) can't be addressed without support from the analyzer.\r\n\r\n- [x] [Perf] Doesn't scale well due to reliance on Outlines, Highlights and repeated `getHover` calls\r\n- [x] Currently identifies `build` methods based on return type string (`Widget`)\r\n- [x] Only shows constructors, doesn't show end of lists (children, actions)\r\n\r\n### Suggestions:\r\n\r\nThese are things that can be improved in the preview.\r\n\r\n- [x] Support `const` as well as `new`\r\n- [x] Prefix with `//` instead of `/` so looks a bit like a comment marking the end\r\n- [x] Improve styling\r\n- [x] Fix flicker when typing quickly (or holding keys) caused by not being able relate analyzer notifications with document versions - just keep resetting a timeout and only update after there's been no update for x milliseconds (where x > expected latency for the update)\r\n- [x] Show decorations in any Widget-returning method\r\n- [x] Don't show annotations against characters other than `)` to mitigate out-of-sync notifications\r\n- [x] Allow color to be customised rather than reusing an existing style"},"comment":{"url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/comments/331217114","html_url":"https://github.com/Dart-Code/Dart-Code/issues/383#issuecomment-331217114","issue_url":"https://api.github.com/repos/Dart-Code/Dart-Code/issues/383","id":331217114,"user":{"login":"DanTup","id":1078012,"avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T16:53:37Z","updated_at":"2017-09-21T16:53:37Z","author_association":"OWNER","body":"@devoncarew Thanks for the info. Give me a shout when you have some solid changes you want to make (or if easier for for you make them, feel free). I haven't removed the flag from this yet as I thought 1.25 was near and wanted to do a final test with the release SDK before doing so.\r\n\r\n@xster Glad you like it! We can customse things, but smaller fonts might look a bit weird. The colour is customisable already, though I don't know if that's enough. It's possible to add borders/underlines/etc., but I think they'll make it less subtle, and probably more subtle is what you're after? If you have ideas, I can try them out and make screenshots (or if you're comfortable running Dart Code from source you can try it yourself - relevant code is [this](https://github.com/Dart-Code/Dart-Code/blob/0adf72b200687f827d84d195cc5c0bb94a2064a0/src/decorations/closing_labels_decorations.ts#L15) and Code docs on what's possible are [here](https://code.visualstudio.com/docs/extensionAPI/vscode-api#DecorationRenderOptions).\r\n\r\n@yjbanov Not currently; but I've been meaning to remove it for a while. I saw someone tweet about uninstalling an extension that was doing something like this and I realised how annoying it is. I should've made it only show once :(\r\n\r\nIf 1.25 SDK ships soon, I'll remove the flag so it'll go anyway. If not, I'll push an update out to remove it soon. Sorry for the annoyance - I haven't used it much myself (been away for 3 weeks) so it hasn't been on my mind ;("}}
{"actor":{"display_login":"DanTup"}}