{"action":"created","comment":{"url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/comments/139486556","pull_request_review_id":63425996,"id":139486556,"diff_hunk":"@@ -2338,9 +2360,10 @@ module.exports = (function(window, document) { \"use strict\";\n \t\t\tvar mode = 'y';\n \t\t\tvar fullSize = fullHeight;\n \t\t\tvar ySizes = this.ySizes.map(initializeFromConstraints);\n-\t\t\t\n-\t\t\tvar getMinHeightOf = function(item) { return item.element.offsetHeight+item.vMargins; };\n-\t\t\tvar getMaxHeightOf = function(item) { return item.element.offsetHeight+item.vMargins; };\n+\t\t\tvar rowGap = this.rowGap;\n+\n+\t\t\tvar getMinHeightOf = function(item) { return item.element.offsetHeight + item.vMargins + Math.max(0, item.yEnd - item.yStart - 1) * rowGap; };","path":"src/css-grid/lib/grid-layout.js","position":null,"original_position":76,"commit_id":"fc2dd985c671ed211e751dc20492917467e9caff","original_commit_id":"37e23e635551f0771a7f7237ea2c416875e6eb26","user":{"login":"FremyCompany","id":364405,"avatar_url":"https://avatars3.githubusercontent.com/u/364405?v=4","gravatar_id":"","url":"https://api.github.com/users/FremyCompany","html_url":"https://github.com/FremyCompany","followers_url":"https://api.github.com/users/FremyCompany/followers","following_url":"https://api.github.com/users/FremyCompany/following{/other_user}","gists_url":"https://api.github.com/users/FremyCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/FremyCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FremyCompany/subscriptions","organizations_url":"https://api.github.com/users/FremyCompany/orgs","repos_url":"https://api.github.com/users/FremyCompany/repos","events_url":"https://api.github.com/users/FremyCompany/events{/privacy}","received_events_url":"https://api.github.com/users/FremyCompany/received_events","type":"User","site_admin":false},"body":"^ Fixed in the current changeset I think","created_at":"2017-09-18T17:23:54Z","updated_at":"2017-09-18T17:23:54Z","html_url":"https://github.com/FremyCompany/css-grid-polyfill/pull/51#discussion_r139486556","pull_request_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/comments/139486556"},"html":{"href":"https://github.com/FremyCompany/css-grid-polyfill/pull/51#discussion_r139486556"},"pull_request":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51"}},"in_reply_to_id":137345016},"pull_request":{"url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51","id":139609147,"html_url":"https://github.com/FremyCompany/css-grid-polyfill/pull/51","diff_url":"https://github.com/FremyCompany/css-grid-polyfill/pull/51.diff","patch_url":"https://github.com/FremyCompany/css-grid-polyfill/pull/51.patch","issue_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/51","number":51,"state":"open","locked":false,"title":"Add support for grid-gap, grid-row-gap and grid-column-gap","user":{"login":"RamIdeas","id":5822355,"avatar_url":"https://avatars0.githubusercontent.com/u/5822355?v=4","gravatar_id":"","url":"https://api.github.com/users/RamIdeas","html_url":"https://github.com/RamIdeas","followers_url":"https://api.github.com/users/RamIdeas/followers","following_url":"https://api.github.com/users/RamIdeas/following{/other_user}","gists_url":"https://api.github.com/users/RamIdeas/gists{/gist_id}","starred_url":"https://api.github.com/users/RamIdeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamIdeas/subscriptions","organizations_url":"https://api.github.com/users/RamIdeas/orgs","repos_url":"https://api.github.com/users/RamIdeas/repos","events_url":"https://api.github.com/users/RamIdeas/events{/privacy}","received_events_url":"https://api.github.com/users/RamIdeas/received_events","type":"User","site_admin":false},"body":"This PR adds support for the gap properties mentioned 🎉 \r\n \r\nThis only took under an hour to implement and a bit longer to (manually) test a little thanks to [your comment](https://github.com/FremyCompany/css-grid-polyfill/issues/26#issuecomment-118553399)\r\n\r\nIf you could offer similar help for any other issues mentioned in #50 I would be glad to have another go!","created_at":"2017-09-06T16:32:30Z","updated_at":"2017-09-18T17:23:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eef05283f3b78cf91c32395864f056a7a6a43fe4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51/commits","review_comments_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51/comments","review_comment_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/51/comments","statuses_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/statuses/fc2dd985c671ed211e751dc20492917467e9caff","head":{"label":"RamIdeas:new-spec-gap","ref":"new-spec-gap","sha":"fc2dd985c671ed211e751dc20492917467e9caff","user":{"login":"RamIdeas","id":5822355,"avatar_url":"https://avatars0.githubusercontent.com/u/5822355?v=4","gravatar_id":"","url":"https://api.github.com/users/RamIdeas","html_url":"https://github.com/RamIdeas","followers_url":"https://api.github.com/users/RamIdeas/followers","following_url":"https://api.github.com/users/RamIdeas/following{/other_user}","gists_url":"https://api.github.com/users/RamIdeas/gists{/gist_id}","starred_url":"https://api.github.com/users/RamIdeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamIdeas/subscriptions","organizations_url":"https://api.github.com/users/RamIdeas/orgs","repos_url":"https://api.github.com/users/RamIdeas/repos","events_url":"https://api.github.com/users/RamIdeas/events{/privacy}","received_events_url":"https://api.github.com/users/RamIdeas/received_events","type":"User","site_admin":false},"repo":{"id":102607429,"name":"css-grid-polyfill","full_name":"RamIdeas/css-grid-polyfill","owner":{"login":"RamIdeas","id":5822355,"avatar_url":"https://avatars0.githubusercontent.com/u/5822355?v=4","gravatar_id":"","url":"https://api.github.com/users/RamIdeas","html_url":"https://github.com/RamIdeas","followers_url":"https://api.github.com/users/RamIdeas/followers","following_url":"https://api.github.com/users/RamIdeas/following{/other_user}","gists_url":"https://api.github.com/users/RamIdeas/gists{/gist_id}","starred_url":"https://api.github.com/users/RamIdeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamIdeas/subscriptions","organizations_url":"https://api.github.com/users/RamIdeas/orgs","repos_url":"https://api.github.com/users/RamIdeas/repos","events_url":"https://api.github.com/users/RamIdeas/events{/privacy}","received_events_url":"https://api.github.com/users/RamIdeas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RamIdeas/css-grid-polyfill","description":"A working implementation of css grids for current browsers.","fork":true,"url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill","forks_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/forks","keys_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/teams","hooks_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/hooks","issue_events_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/events","assignees_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/tags","blobs_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/languages","stargazers_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/stargazers","contributors_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/contributors","subscribers_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/subscribers","subscription_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/subscription","commits_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/merges","archive_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/downloads","issues_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/labels{/name}","releases_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/releases{/id}","deployments_url":"https://api.github.com/repos/RamIdeas/css-grid-polyfill/deployments","created_at":"2017-09-06T12:46:30Z","updated_at":"2017-09-06T12:46:32Z","pushed_at":"2017-09-18T10:27:38Z","git_url":"git://github.com/RamIdeas/css-grid-polyfill.git","ssh_url":"git@github.com:RamIdeas/css-grid-polyfill.git","clone_url":"https://github.com/RamIdeas/css-grid-polyfill.git","svn_url":"https://github.com/RamIdeas/css-grid-polyfill","homepage":"","size":1209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FremyCompany:master","ref":"master","sha":"e7422a6a5a4f92173ffb86c097bef308ef8fc344","user":{"login":"FremyCompany","id":364405,"avatar_url":"https://avatars3.githubusercontent.com/u/364405?v=4","gravatar_id":"","url":"https://api.github.com/users/FremyCompany","html_url":"https://github.com/FremyCompany","followers_url":"https://api.github.com/users/FremyCompany/followers","following_url":"https://api.github.com/users/FremyCompany/following{/other_user}","gists_url":"https://api.github.com/users/FremyCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/FremyCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FremyCompany/subscriptions","organizations_url":"https://api.github.com/users/FremyCompany/orgs","repos_url":"https://api.github.com/users/FremyCompany/repos","events_url":"https://api.github.com/users/FremyCompany/events{/privacy}","received_events_url":"https://api.github.com/users/FremyCompany/received_events","type":"User","site_admin":false},"repo":{"id":22578662,"name":"css-grid-polyfill","full_name":"FremyCompany/css-grid-polyfill","owner":{"login":"FremyCompany","id":364405,"avatar_url":"https://avatars3.githubusercontent.com/u/364405?v=4","gravatar_id":"","url":"https://api.github.com/users/FremyCompany","html_url":"https://github.com/FremyCompany","followers_url":"https://api.github.com/users/FremyCompany/followers","following_url":"https://api.github.com/users/FremyCompany/following{/other_user}","gists_url":"https://api.github.com/users/FremyCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/FremyCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FremyCompany/subscriptions","organizations_url":"https://api.github.com/users/FremyCompany/orgs","repos_url":"https://api.github.com/users/FremyCompany/repos","events_url":"https://api.github.com/users/FremyCompany/events{/privacy}","received_events_url":"https://api.github.com/users/FremyCompany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FremyCompany/css-grid-polyfill","description":"A working implementation of css grids for current browsers.","fork":false,"url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill","forks_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/forks","keys_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/teams","hooks_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/hooks","issue_events_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/events","assignees_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/tags","blobs_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/languages","stargazers_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/stargazers","contributors_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/contributors","subscribers_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/subscribers","subscription_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/subscription","commits_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/merges","archive_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/downloads","issues_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/labels{/name}","releases_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/releases{/id}","deployments_url":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/deployments","created_at":"2014-08-03T16:26:25Z","updated_at":"2017-09-18T10:43:55Z","pushed_at":"2017-09-18T10:33:30Z","git_url":"git://github.com/FremyCompany/css-grid-polyfill.git","ssh_url":"git@github.com:FremyCompany/css-grid-polyfill.git","clone_url":"https://github.com/FremyCompany/css-grid-polyfill.git","svn_url":"https://github.com/FremyCompany/css-grid-polyfill","homepage":"","size":1116,"stargazers_count":717,"watchers_count":717,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":23,"forks":39,"open_issues":23,"watchers":717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51"},"html":{"href":"https://github.com/FremyCompany/css-grid-polyfill/pull/51"},"issue":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/51"},"comments":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/FremyCompany/css-grid-polyfill/statuses/fc2dd985c671ed211e751dc20492917467e9caff"}},"author_association":"NONE"}}
{"actor":{"display_login":"FremyCompany"}}