{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/99474643","pull_request_review_id":20155979,"id":99474643,"diff_hunk":"@@ -0,0 +1,137 @@\n+<?php\n+/**\n+*\n+* This file is part of the phpBB Forum Software package.\n+*\n+* @copyright (c) phpBB Limited <https://www.phpbb.com>\n+* @license GNU General Public License, version 2 (GPL-2.0)\n+*\n+* For full copyright and license information, please see\n+* the docs/CREDITS.txt file.\n+*\n+*/\n+\n+class manager_test extends phpbb_database_test_case\n+{\n+\t/** @var \\phpbb\\db\\driver\\driver_interface */\n+\tprotected $db;\n+\n+\t/** @var \\phpbb\\config\\db_text */\n+\tprotected $config_text;\n+\n+\t/** @var \\phpbb\\profilefields\\manager */\n+\tprotected $manager;\n+\n+\t/** @var \\phpbb\\log\\log_interface */\n+\tprotected $log;\n+\n+\t/** @var \\phpbb\\db\\tools */\n+\tprotected $db_tools;\n+\n+\tpublic function getDataSet()\n+\t{\n+\t\treturn $this->createXMLDataSet(dirname(__FILE__).'/fixtures/manager.xml');\n+\t}\n+\n+\tpublic function setUp()\n+\t{\n+\t\tparent::setUp();\n+\n+\t\tglobal $phpbb_log;\n+\n+\t\t$this->log = $this->prophesize('\\phpbb\\log\\log_interface');\n+\t\t$phpbb_log = $this->log->reveal();\n+\n+\t\t$this->db = $this->new_dbal();\n+\t\t$this->config_text = $this->prophesize('\\phpbb\\config\\db_text');\n+\t\t$this->db_tools = $this->prophesize('\\phpbb\\db\\tools');\n+\n+\t\t$this->manager = new \\phpbb\\profilefields\\manager(\n+\t\t\t$this->prophesize('phpbb\\auth\\auth')->reveal(),\n+\t\t\t$this->db,\n+\t\t\t$this->db_tools->reveal(),\n+\t\t\t$this->prophesize('\\phpbb\\event\\dispatcher_interface')->reveal(),\n+\t\t\t$this->prophesize('\\phpbb\\request\\request')->reveal(),\n+\t\t\t$this->prophesize('\\phpbb\\template\\template')->reveal(),\n+\t\t\t$this->prophesize('\\phpbb\\di\\service_collection')->reveal(),\n+\t\t\t$this->prophesize('\\phpbb\\user')->reveal(),\n+\t\t\t$this->config_text->reveal(),\n+\t\t\tPROFILE_FIELDS_TABLE,\n+\t\t\tPROFILE_FIELDS_LANG_TABLE,\n+\t\t\tPROFILE_FIELDS_DATA_TABLE\n+\t\t);\n+\t}\n+\n+\tpublic function test_disable_profilefields()\n+\t{\n+\t\t$this->log->add('admin', 'LOG_PROFILE_FIELD_DEACTIVATE', 'pf_1')->shouldBeCalled();\n+\t\t$this->log->add('admin', 'LOG_PROFILE_FIELD_DEACTIVATE', 'pf_2')->shouldBeCalled();\n+","path":"tests/profilefields/manager_test.php","position":69,"original_position":69,"commit_id":"d71c48e4709d4d64eba8b7c876a7ad35152b78c7","original_commit_id":"d71c48e4709d4d64eba8b7c876a7ad35152b78c7","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"body":"This does not match the log interface: is it correct?","created_at":"2017-02-04T20:36:07Z","updated_at":"2017-02-04T20:40:24Z","html_url":"https://github.com/phpbb/phpbb/pull/4603#discussion_r99474643","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4603","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/99474643"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4603#discussion_r99474643"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4603"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4603","id":99784298,"html_url":"https://github.com/phpbb/phpbb/pull/4603","diff_url":"https://github.com/phpbb/phpbb/pull/4603.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4603.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4603","number":4603,"state":"open","locked":false,"title":"[ticket/13867] Enable/disable mechanism for new profile field types","user":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"body":"replaces #3656\r\n\r\nChecklist:\r\n\r\n- [x] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [x] Tests pass\r\n- [x] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [x] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-13867\r\n","created_at":"2016-12-30T21:24:43Z","updated_at":"2017-02-04T20:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8d673f867e9ad941e4bc9ea54c152cd4986539b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/23","html_url":"https://github.com/phpbb/phpbb/milestone/23","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/23/labels","id":2223136,"number":23,"title":"3.2.1","description":"","creator":{"login":"marc1706","id":394418,"avatar_url":"https://avatars.githubusercontent.com/u/394418?v=3","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":25,"state":"open","created_at":"2017-01-02T11:13:59Z","updated_at":"2017-01-29T13:44:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4603/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4603/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4603/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/d71c48e4709d4d64eba8b7c876a7ad35152b78c7","head":{"label":"Nicofuma:ticket/13867","ref":"ticket/13867","sha":"d71c48e4709d4d64eba8b7c876a7ad35152b78c7","user":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"repo":{"id":18715287,"name":"phpbb","full_name":"Nicofuma/phpbb","owner":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nicofuma/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/Nicofuma/phpbb","forks_url":"https://api.github.com/repos/Nicofuma/phpbb/forks","keys_url":"https://api.github.com/repos/Nicofuma/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nicofuma/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nicofuma/phpbb/teams","hooks_url":"https://api.github.com/repos/Nicofuma/phpbb/hooks","issue_events_url":"https://api.github.com/repos/Nicofuma/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/Nicofuma/phpbb/events","assignees_url":"https://api.github.com/repos/Nicofuma/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/Nicofuma/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/Nicofuma/phpbb/tags","blobs_url":"https://api.github.com/repos/Nicofuma/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nicofuma/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nicofuma/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nicofuma/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nicofuma/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/Nicofuma/phpbb/languages","stargazers_url":"https://api.github.com/repos/Nicofuma/phpbb/stargazers","contributors_url":"https://api.github.com/repos/Nicofuma/phpbb/contributors","subscribers_url":"https://api.github.com/repos/Nicofuma/phpbb/subscribers","subscription_url":"https://api.github.com/repos/Nicofuma/phpbb/subscription","commits_url":"https://api.github.com/repos/Nicofuma/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nicofuma/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nicofuma/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nicofuma/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nicofuma/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/Nicofuma/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nicofuma/phpbb/merges","archive_url":"https://api.github.com/repos/Nicofuma/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nicofuma/phpbb/downloads","issues_url":"https://api.github.com/repos/Nicofuma/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/Nicofuma/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/Nicofuma/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/Nicofuma/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nicofuma/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/Nicofuma/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/Nicofuma/phpbb/deployments","created_at":"2014-04-12T21:36:20Z","updated_at":"2015-02-03T09:26:19Z","pushed_at":"2017-01-22T23:13:59Z","git_url":"git://github.com/Nicofuma/phpbb.git","ssh_url":"git@github.com:Nicofuma/phpbb.git","clone_url":"https://github.com/Nicofuma/phpbb.git","svn_url":"https://github.com/Nicofuma/phpbb","homepage":"http://www.phpbb.com","size":59119,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:3.2.x","ref":"3.2.x","sha":"3c30cbd39ecf287d95f49ae3098d0b05a7fcfb13","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/phpbb/phpbb/deployments","created_at":"2010-03-01T22:33:17Z","updated_at":"2017-02-02T22:51:18Z","pushed_at":"2017-02-04T05:29:47Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":57964,"stargazers_count":966,"watchers_count":966,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":571,"mirror_url":null,"open_issues_count":64,"forks":571,"open_issues":64,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4603"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4603"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4603"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4603/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4603/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4603/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/d71c48e4709d4d64eba8b7c876a7ad35152b78c7"}}}}
{"actor":{"display_login":"javiexin"}}