{"action":"created","issue":{"url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/41","repository_url":"https://api.github.com/repos/arcticicestudio/nord-vim","labels_url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/41/comments","events_url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/41/events","html_url":"https://github.com/arcticicestudio/nord-vim/pull/41","id":243300919,"number":41,"title":"Underline substitute search result highlight text","user":{"login":"arcticicestudio","id":7836623,"avatar_url":"https://avatars3.githubusercontent.com/u/7836623?v=4","gravatar_id":"","url":"https://api.github.com/users/arcticicestudio","html_url":"https://github.com/arcticicestudio","followers_url":"https://api.github.com/users/arcticicestudio/followers","following_url":"https://api.github.com/users/arcticicestudio/following{/other_user}","gists_url":"https://api.github.com/users/arcticicestudio/gists{/gist_id}","starred_url":"https://api.github.com/users/arcticicestudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcticicestudio/subscriptions","organizations_url":"https://api.github.com/users/arcticicestudio/orgs","repos_url":"https://api.github.com/users/arcticicestudio/repos","events_url":"https://api.github.com/users/arcticicestudio/events{/privacy}","received_events_url":"https://api.github.com/users/arcticicestudio/received_events","type":"User","site_admin":false},"labels":[{"id":487636614,"url":"https://api.github.com/repos/arcticicestudio/nord-vim/labels/improvement","name":"improvement","color":"88C0D0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/arcticicestudio/nord-vim/milestones/8","html_url":"https://github.com/arcticicestudio/nord-vim/milestone/8","labels_url":"https://api.github.com/repos/arcticicestudio/nord-vim/milestones/8/labels","id":2642470,"number":8,"title":"0.6.0","description":"[Project Board](https://github.com/arcticicestudio/nord-vim/projects/9)","creator":{"login":"arcticicestudio","id":7836623,"avatar_url":"https://avatars3.githubusercontent.com/u/7836623?v=4","gravatar_id":"","url":"https://api.github.com/users/arcticicestudio","html_url":"https://github.com/arcticicestudio","followers_url":"https://api.github.com/users/arcticicestudio/followers","following_url":"https://api.github.com/users/arcticicestudio/following{/other_user}","gists_url":"https://api.github.com/users/arcticicestudio/gists{/gist_id}","starred_url":"https://api.github.com/users/arcticicestudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcticicestudio/subscriptions","organizations_url":"https://api.github.com/users/arcticicestudio/orgs","repos_url":"https://api.github.com/users/arcticicestudio/repos","events_url":"https://api.github.com/users/arcticicestudio/events{/privacy}","received_events_url":"https://api.github.com/users/arcticicestudio/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":10,"state":"closed","created_at":"2017-07-15T07:15:33Z","updated_at":"2017-08-03T07:28:22Z","due_on":null,"closed_at":"2017-08-03T07:28:22Z"},"comments":1,"created_at":"2017-07-17T05:41:03Z","updated_at":"2017-08-03T12:30:04Z","closed_at":"2017-08-03T03:30:51Z","pull_request":{"url":"https://api.github.com/repos/arcticicestudio/nord-vim/pulls/41","html_url":"https://github.com/arcticicestudio/nord-vim/pull/41","diff_url":"https://github.com/arcticicestudio/nord-vim/pull/41.diff","patch_url":"https://github.com/arcticicestudio/nord-vim/pull/41.patch"},"body":"> Closes #35 \r\nMust be merged **after** #39 \r\n\r\nThis PR improves the substitute search command by underlining the active search result highlight text in order to make it more recognizable.\r\n\r\n![gh-35-scrcast-underline-highlight](https://user-images.githubusercontent.com/7836623/28245896-ebd3abae-6a10-11e7-9e83-85b69cb62455.gif)"},"comment":{"url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/comments/319955105","html_url":"https://github.com/arcticicestudio/nord-vim/pull/41#issuecomment-319955105","issue_url":"https://api.github.com/repos/arcticicestudio/nord-vim/issues/41","id":319955105,"user":{"login":"KevinSjoberg","id":503025,"avatar_url":"https://avatars3.githubusercontent.com/u/503025?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinSjoberg","html_url":"https://github.com/KevinSjoberg","followers_url":"https://api.github.com/users/KevinSjoberg/followers","following_url":"https://api.github.com/users/KevinSjoberg/following{/other_user}","gists_url":"https://api.github.com/users/KevinSjoberg/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinSjoberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinSjoberg/subscriptions","organizations_url":"https://api.github.com/users/KevinSjoberg/orgs","repos_url":"https://api.github.com/users/KevinSjoberg/repos","events_url":"https://api.github.com/users/KevinSjoberg/events{/privacy}","received_events_url":"https://api.github.com/users/KevinSjoberg/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T12:30:04Z","updated_at":"2017-08-03T12:30:04Z","body":"I'm just tried out latest changes from `develop` and I still experience this issue. See the screenshot below.\r\n\r\n![2017-08-03 14 25 03](https://user-images.githubusercontent.com/503025/28921799-b04a58e4-7857-11e7-815d-680034dc5b07.gif)\r\n\r\nAs you can see, there is not distinction between the word I'm currently on and the other matches.\r\n\r\n**OS**\r\n```\r\nMac OS Sierra\r\nVersion 10.12.6 (16G29)\r\n```\r\n\r\n**Vim**\r\n```\r\nVIM - Vi IMproved 8.0 (2016 Sep 12, compiled Aug  1 2017 18:00:30)\r\nMacOS X (unix) version\r\nIncluded patches: 1-823\r\nCompiled by Homebrew\r\nHuge version without GUI.  Features included (+) or not (-):\r\n+acl             +file_in_path    +mouse_sgr       +tag_old_static\r\n+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white\r\n+autocmd         +float           +mouse_urxvt     -tcl\r\n-balloon_eval    +folding         +mouse_xterm     +termguicolors\r\n-browse          -footer          +multi_byte      +terminal\r\n++builtin_terms  +fork()          +multi_lang      +terminfo\r\n+byte_offset     -gettext         -mzscheme        +termresponse\r\n+channel         -hangul_input    +netbeans_intg   +textobjects\r\n+cindent         +iconv           +num64           +timers\r\n-clientserver    +insert_expand   +packages        +title\r\n+clipboard       +job             +path_extra      -toolbar\r\n+cmdline_compl   +jumplist        +perl            +user_commands\r\n+cmdline_hist    +keymap          +persistent_undo +vertsplit\r\n+cmdline_info    +lambda          +postscript      +virtualedit\r\n+comments        +langmap         +printer         +visual\r\n+conceal         +libcall         +profile         +visualextra\r\n+cryptv          +linebreak       +python          +viminfo\r\n+cscope          +lispindent      -python3         +vreplace\r\n+cursorbind      +listcmds        +quickfix        +wildignore\r\n+cursorshape     +localmap        +reltime         +wildmenu\r\n+dialog_con      +lua             +rightleft       +windows\r\n+diff            +menu            +ruby            +writebackup\r\n+digraphs        +mksession       +scrollbind      -X11\r\n-dnd             +modify_fname    +signs           -xfontset\r\n-ebcdic          +mouse           +smartindent     -xim\r\n+emacs_tags      -mouseshape      +startuptime     -xpm\r\n+eval            +mouse_dec       +statusline      -xsmp\r\n+ex_extra        -mouse_gpm       -sun_workshop    -xterm_clipboard\r\n+extra_search    -mouse_jsbterm   +syntax          -xterm_save\r\n+farsi           +mouse_netterm   +tag_binary      \r\n   system vimrc file: \"$VIM/vimrc\"\r\n     user vimrc file: \"$HOME/.vimrc\"\r\n 2nd user vimrc file: \"~/.vim/vimrc\"\r\n      user exrc file: \"$HOME/.exrc\"\r\n       defaults file: \"$VIMRUNTIME/defaults.vim\"\r\n  fall-back for $VIM: \"/usr/local/share/vim\"\r\nCompilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1       \r\nLinking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework Cocoa  -pagezero_size 10000 -image_base 100000000 -L/usr/local/lib -lluajit-5.1 -mmacosx-version-min=10.12 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.26.0/lib/perl5/5.26.0/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc -F/usr/local/opt/python/Frameworks -framework Python   -lruby.2.4.1 -lobjc \r\n```"}}
{"actor":{"display_login":"KevinSjoberg"}}