{"push_id":1642919408,"size":187,"distinct_size":14,"ref":"refs/heads/seclabels2","head":"263a6b5333c23c4c43d04bbdeb5b7c364a8a15d0","before":"53dbc66300db1b847c828340a3922cf43cc5ce98","commits":[{"sha":"26026810eaeef9b95cac915e6f4d3ed5e54b5321","author":{"name":"Andrea Bolognani","email":"0c58d8c54619c257465b8c09c1c6917894f8def9@redhat.com"},"message":"qemu: Fix typo in __QEMU_CAPSPRIV_H_ALLOW__","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/26026810eaeef9b95cac915e6f4d3ed5e54b5321"},{"sha":"b7118623ad5a8e6ea75d693881c08873eefa3e28","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"qemu: forbid migration with an IOMMU device\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1433994","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/b7118623ad5a8e6ea75d693881c08873eefa3e28"},{"sha":"176229dd05a6c96dec2b7b1c2fb0143d7331b10e","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: permit querying a VF MAC address or VLAN tag by itself\n\nvirNetDevParseVfConfig() assumed that both the MAC address and VLAN\ntag pointers were valid, so even if you only wanted one or the other,\nyou would need a variable to hold the returned value for both. This\npatch checks each for a NULL pointer before filling it in.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/176229dd05a6c96dec2b7b1c2fb0143d7331b10e"},{"sha":"0a583c26f766d973c08d05ddf0b8fb297eb10f4f","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: remove unused args from virNetDevSetVfConfig()\n\nThis function is only called in two places, and the ifindex,\nnltarget_kernel, and getPidFunc args are never used (and never will\nbe).\n\nifindex - we always know the name of the device, and never know the\nifindex - if we really did need the ifindex we would have to get it\nfrom the name using virNetDevGetIndex(). In practice, we just send -1\nto virNetDevSetVfConfig(), which doesn't bother to learn the real\nifindex (you only need a name *or* an ifindex for the netlink command\nto succeed, not both).\n\nnltarget_kernel - messages to set the config of an SRIOV VF will\nalways go to netlink in the kernel, not to another user process, so\nthis arg is always true (there are other uses of netlink messages\nwhere the message might need to go to another user process, but never\nin the case of RTM_SETLINK for SRIOV).\n\ngetPidFunc - this arg is only used if nltarget_kernel is false, and it\nnever is.\n\nNone of this has any functional effect, it just makes it easier to\nfollow what's happening when virNetDevSetVfConfig() is called.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/0a583c26f766d973c08d05ddf0b8fb297eb10f4f"},{"sha":"19c5db749cdc3ddf53c2b23d5803a0f17cc5077a","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: use cleanup label consistently in virHostdevNetConfigReplace()\n\nThis will make an upcoming functional change more straightforward.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/19c5db749cdc3ddf53c2b23d5803a0f17cc5077a"},{"sha":"606a01339563b5371f21a9b2c10ef818c0557fb1","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: eliminate useless local variable\n\nvf in virNetDevMacVLanDeleteWithVPortProfile() is initialized to -1\nand never set. It's not set for a good reason - because it doesn't\nmake sense during macvtap device setup to refer to a VF device as\n\"PF:VF#\". This patch replaces the two uses of \"vf\" with \"-1\", and\nremoves the local variable, so that it's more clear we are always\ncalling the utility functions with vf set to -1.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/606a01339563b5371f21a9b2c10ef818c0557fb1"},{"sha":"30b07a425d7b5b3ac7ca68d3574692ac6415ccbe","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: make virMacAddrParse more versatile\n\nPreviously the MAC address text was required to be terminated with a\nNULL. After this, it can be terminated with a space or any control\ncharacter.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/30b07a425d7b5b3ac7ca68d3574692ac6415ccbe"},{"sha":"d6ee56d723761d408eeef32a96e3c118e0e742c2","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: change virPCIGetNetName() to not return error if device has no net name\n\n...and cleanup the callers to report it when it *is* an error.\n\nIn many cases It's useful for virPCIGetNetName() to not log an error\nand simply return a NULL pointer when the given device isn't bound to\na net driver (e.g. we're looking at a VF that is permanently bound to\nvfio-pci). The existing code would silently return an error in this\ncase, which could eventually lead to the dreaded \"An error occurred\nbut the cause is unknown\" log message.\n\nThis patch changes virPCIGetNetName() to still return success if the\ndevice simply isn't bound to a net driver, and adjusts all the callers\nthat require a non-null netname to check for that condition and log an\nerror when it happens.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/d6ee56d723761d408eeef32a96e3c118e0e742c2"},{"sha":"9a238c16b382f3366bf474a648ff0e4b777b0af8","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: make virPCIGetDeviceAddressFromSysfsLink() public\n\nThis function will be useful in virnetdev.c, so promote it from static.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/9a238c16b382f3366bf474a648ff0e4b777b0af8"},{"sha":"251d179bf2c10c7d7fb594c68f1aac56a9b0d932","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: new function virPCIDeviceRebind()\n\nThis function unbinds a device from its driver, then immediately\nrebinds it to its driver again. The code for this new function is just\nthe 2nd half of virPCIDeviceBindWithDriverOverride(), so that\nfunction's 2nd half is replaced with a call to virPCIDeviceRebind().","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/251d179bf2c10c7d7fb594c68f1aac56a9b0d932"},{"sha":"f4ef3a71f8abc83771952604d309b39ca3ea64cf","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: new internal function to permit silent failure of virNetDevSetMAC()\n\nWe will want to allow silent failure of virNetDevSetMAC() in the case\nthat the SIOSIFHWADDR ioctl fails with errno == EADDRNOTAVAIL. (Yes,\nthat is very specific, but we really *do* want a logged failure in all\nother circumstances, and don't want to duplicate code in the caller\nfor the other possibilities).\n\nThis patch renames the 3 different virNetDevSetMAC() functions to\nvirNetDevSetMACInternal(), adding a 3rd arg called \"quiet\" and making\nthem static (because this extra control will only be needed within\nvirnetdev.c). A new global virNetDevSetMAC() is defined that calls\nwhichever of the three *Internal() functions gets compiled with quiet\n= false. Callers in virnetdev.c that want to notice a failure with\nerrno == EADDRNOTAVAIL and retry with a different strategy rather than\nimmediately failing, can call virNetDevSetMACInternal(..., true).","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/f4ef3a71f8abc83771952604d309b39ca3ea64cf"},{"sha":"554253ad04463e0442030f4630f0a4a02613a595","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: new function virNetDevPFGetVF()\n\nGiven an SRIOV PF netdev name (e.g. \"enp2s0f0\") and VF#, this new\nfunction returns the netdev name of the referenced VF device\n(e.g. \"enp2s11f6\"), or NULL if the device isn't bound to a net driver.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/554253ad04463e0442030f4630f0a4a02613a595"},{"sha":"da17090b8ce4f9a2df9529227cbe502cfab21c8f","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"Revert \"qemu: forbid migration with an IOMMU device\"\n\nThis reverts commit b7118623ad5a8e6ea75d693881c08873eefa3e28.\n\nMigration was implemented by QEMU commit:\ncommit 8cdcf3c1e58d04b6811956d7608efeb66c42d719\nAuthor: Peter Xu <peterx@redhat.com>\nDate:   Fri Jan 6 12:06:13 2017 +0800\n\n    intel_iommu: allow migration\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1433994","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/da17090b8ce4f9a2df9529227cbe502cfab21c8f"},{"sha":"a1f46c71a4307f1b8be93793e469e6467455d56d","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"network: only check for IPv6 RA routes when the network has an IPv6 address\n\ncommit 00d28a78 added a check to see if there were any IPv6 routes\nadded by RA (Router Advertisement) via an interface that had accept_ra\nset to something other than \"2\". The check was being done\nunconditionally, but it's only relevant if IPv6 forwarding is going to\nbe turned on, and that will only happen if the network has an IPv6\naddress.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a1f46c71a4307f1b8be93793e469e6467455d56d"},{"sha":"9e2465834f4bff4068e270f15e9ed5d7301de045","author":{"name":"Peter Krempa","email":"ad550f3a498f24c1804da389934cf0cf16278373@redhat.com"},"message":"qemu: snapshot: Forbid internal snapshots with pflash firmware\n\nIf the variable store (<nvram>) file is raw qemu can't do a snapshot of\nit and thus the snapshot fails. QEMU rejects such snapshot by a message\nwhich would not be properly interpreted as an error by libvirt.\n\nAdditionally allowing to use a qcow2 variable store backing file would\nsolve this issue but then it would become eligible to become target of\nthe memory dump.\n\nOffline internal snapshot would be incomplete too with either storage\nformat since libvirt does not handle the pflash file in this case.\n\nForbid such snapshot so that we can avoid problems.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/9e2465834f4bff4068e270f15e9ed5d7301de045"},{"sha":"a7496ad29ab08cd32325746fd1c2694697774f00","author":{"name":"Roman Bogorodskiy","email":"be56f82784a423d301db8f60637af99aa5b10d53@gmail.com"},"message":"util: fix build on non-Linux\n\nFix typo in virNetDevPFGetVF() stub:\n\n  ATTRUBUTE_UNUSED -> ATTRIBUTE_UNUSED.\n\nWhile here, use common indent style for arguments in\nvirNetDevGetVirtualFunctionIndex() stub.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a7496ad29ab08cd32325746fd1c2694697774f00"},{"sha":"54477976f2460724c20c1ef336ba7e6ba000aeb0","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Create #define for TLS configuration setup.\n\nCreate GET_CONFIG_TLS_CERT to set up the TLS for 'chardev' TLS setting.\nSoon to be reused.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/54477976f2460724c20c1ef336ba7e6ba000aeb0"},{"sha":"e3ff84edf52ee424456b85f9083e88c6a17bcd05","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Replace macro usage of (false); with just (0)\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/e3ff84edf52ee424456b85f9083e88c6a17bcd05"},{"sha":"1415121a5ef78a8dcc3fc5f09ea1c1203a69ab01","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"conf: Introduce migrate_tls_x509_cert_dir\n\nAdd a new TLS X.509 certificate type - \"migrate\". This will handle the\ncreation of a TLS certificate capability (and possibly repository) to\nbe used for migrations. Similar to chardev's, credentials will be handled\nvia a libvirt secrets; however, unlike chardev's enablement and usage\nwill be via a CLI flag instead of a conf flag and a domain XML attribute.\n\nThe migrations using the *x509_verify flag require the client-cert.pem\nand client-key.pem files to be present in the TLS directory - so let's\nalso be sure to note that in the qemu.conf file.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/1415121a5ef78a8dcc3fc5f09ea1c1203a69ab01"},{"sha":"3f3582d6d47eaf6d2865148d57a0bd558d492a0e","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Update the TLS client verify descriptions for vnc and chardev\n\nUpdate the descriptions to match the migrate option.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3f3582d6d47eaf6d2865148d57a0bd558d492a0e"}]}
{"actor":{"display_login":"zippy2"}}