{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/100790980","pull_request_review_id":21503927,"id":100790980,"diff_hunk":"@@ -119,15 +120,73 @@ func (jm *CronJobController) SyncAll() {\n \tglog.V(4).Infof(\"Found %d groups\", len(jobsBySj))\n \n \tfor _, sj := range sjs {\n-\t\tSyncOne(sj, jobsBySj[sj.UID], time.Now(), jm.jobControl, jm.sjControl, jm.podControl, jm.recorder)\n+\t\tsj := syncOne(sj, jobsBySj[sj.UID], time.Now(), jm.jobControl, jm.sjControl, jm.podControl, jm.recorder)\n+\t\tcleanupFinishedJobs(sj, jobsBySj[sj.UID], jm.jobControl, jm.sjControl, jm.podControl, jm.recorder)\n \t}\n }\n \n-// SyncOne reconciles a CronJob with a list of any Jobs that it created.\n+// cleanupFinishedJobs cleanups finished jobs created by a CronJob\n+func cleanupFinishedJobs(sj batch.CronJob, js []batch.Job, jc jobControlInterface, sjc sjControlInterface, pc podControlInterface, recorder record.EventRecorder) {\n+\t// If neither limits are active, there is no need to do anything.\n+\tif sj.Spec.FailedJobsHistoryLimit == nil && sj.Spec.SuccessfulJobsHistoryLimit == nil {\n+\t\treturn\n+\t}\n+\n+\tfailedJobs := []batch.Job{}\n+\tsuccesfulJobs := []batch.Job{}\n+\n+\tfor _, job := range js {\n+\t\tisFinished, finishedStatus := GetFinishedStatus(&job)\n+\t\tif isFinished && finishedStatus == batch.JobComplete {\n+\t\t\tsuccesfulJobs = append(succesfulJobs, job)\n+\t\t} else if isFinished && finishedStatus == batch.JobFailed {\n+\t\t\tfailedJobs = append(failedJobs, job)\n+\t\t}\n+\t}\n+\n+\tremoveOldestJobs(&sj,\n+\t\tsuccesfulJobs,\n+\t\tjc,\n+\t\tpc,\n+\t\t*sj.Spec.SuccessfulJobsHistoryLimit,\n+\t\trecorder)\n+\n+\tremoveOldestJobs(&sj,\n+\t\tfailedJobs,\n+\t\tjc,\n+\t\tpc,\n+\t\t*sj.Spec.FailedJobsHistoryLimit,\n+\t\trecorder)\n+\n+\t// Update the CronJob, in case jobs were removed from the list.\n+\tif _, err := sjc.UpdateStatus(&sj); err != nil {\n+\t\tnameForLog := fmt.Sprintf(\"%s/%s\", sj.Namespace, sj.Name)\n+\t\tglog.Infof(\"Unable to update status for %s (rv = %s): %v\", nameForLog, sj.ResourceVersion, err)\n+\t}\n+}\n+\n+// removeOldestJobs removes the oldest jobs from a list of jobs\n+func removeOldestJobs(sj *batch.CronJob, js []batch.Job, jc jobControlInterface, pc podControlInterface, maxJobs int32, recorder record.EventRecorder) {\n+\tnumToDelete := len(js) - int(maxJobs)\n+\tif numToDelete <= 0 {\n+\t\treturn\n+\t}\n+\n+\tnameForLog := fmt.Sprintf(\"%s/%s\", sj.Namespace, sj.Name)\n+\tglog.V(4).Infof(\"Cleaning up %d/%d jobs from %s\", numToDelete, len(js), nameForLog, numToDelete)","path":"pkg/controller/cronjob/cronjob_controller.go","position":84,"original_position":84,"commit_id":"86c1845cec1e7d4d222f1583a66fecb8f2fb2212","original_commit_id":"4fff16bce9dcc6a4a31344a90f4296015afe834f","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"Second `numToDelete`, at the end, is not necessary.","created_at":"2017-02-13T13:20:12Z","updated_at":"2017-02-13T13:31:42Z","html_url":"https://github.com/kubernetes/kubernetes/pull/40932#discussion_r100790980","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/100790980"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/40932#discussion_r100790980"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932","id":104577005,"html_url":"https://github.com/kubernetes/kubernetes/pull/40932","diff_url":"https://github.com/kubernetes/kubernetes/pull/40932.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/40932.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40932","number":40932,"state":"open","locked":false,"title":"Modify CronJob API to add job history limits, cleanup jobs in controller","user":{"login":"peay","id":7261177,"avatar_url":"https://avatars.githubusercontent.com/u/7261177?v=3","gravatar_id":"","url":"https://api.github.com/users/peay","html_url":"https://github.com/peay","followers_url":"https://api.github.com/users/peay/followers","following_url":"https://api.github.com/users/peay/following{/other_user}","gists_url":"https://api.github.com/users/peay/gists{/gist_id}","starred_url":"https://api.github.com/users/peay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peay/subscriptions","organizations_url":"https://api.github.com/users/peay/orgs","repos_url":"https://api.github.com/users/peay/repos","events_url":"https://api.github.com/users/peay/events{/privacy}","received_events_url":"https://api.github.com/users/peay/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nAs discussed in #34710: this adds two limits to `CronJobSpec`, to limit the number of finished jobs created by a CronJob to keep.\r\n\r\n**Which issue this PR fixes**: fixes #34710\r\n\r\n**Special notes for your reviewer**:\r\n\r\ncc @soltysh, please have a look and let me know what you think -- I'll then add end to end testing and update the doc in a separate commit. What is the timeline to get this into 1.6?\r\n\r\nThe plan:\r\n\r\n- [x] API changes\r\n  - [x] Changing versioned APIs\r\n    - [x] `types.go`\r\n    - [x] `defaults.go` (nothing to do)\r\n    - [x] `conversion.go` (nothing to do?)\r\n    - [x] `conversion_test.go` (nothing to do?)\r\n  - [x] Changing the internal structure\r\n    - [x] `types.go`\r\n    - [x] `validation.go`\r\n    - [x] `validation_test.go`\r\n  - [x] Edit version conversions\r\n    - [x] Edit (nothing to do?)\r\n    - [x] Run `hack/update-codegen.sh`\r\n  - [x] Generate protobuf objects\r\n    - [x] Run `hack/update-generated-protobuf.sh`\r\n  - [x] Generate json (un)marshaling code\r\n    - [x] Run `hack/update-codecgen.sh`\r\n  - [x] Update fuzzer\r\n- [x] Actual logic\r\n- [x] Unit tests\r\n- [x] End to end tests\r\n- [x] Documentation changes and API specs update in separate commit\r\n\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\nAdd configurable limits to CronJob resource to specify how many successful and failed jobs are preserved.\r\n```\r\n","created_at":"2017-02-03T17:27:19Z","updated_at":"2017-02-13T13:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f1c8519e5fb215ed86dc6dc22997c68cf2ff5d9","assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/33","html_url":"https://github.com/kubernetes/kubernetes/milestone/33","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/33/labels","id":2265498,"number":33,"title":"1.6","description":null,"creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":37,"state":"open","created_at":"2017-01-19T21:27:19Z","updated_at":"2017-02-13T13:04:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/40932/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/86c1845cec1e7d4d222f1583a66fecb8f2fb2212","head":{"label":"peay:cronjob-max-finished-jobs","ref":"cronjob-max-finished-jobs","sha":"86c1845cec1e7d4d222f1583a66fecb8f2fb2212","user":{"login":"peay","id":7261177,"avatar_url":"https://avatars.githubusercontent.com/u/7261177?v=3","gravatar_id":"","url":"https://api.github.com/users/peay","html_url":"https://github.com/peay","followers_url":"https://api.github.com/users/peay/followers","following_url":"https://api.github.com/users/peay/following{/other_user}","gists_url":"https://api.github.com/users/peay/gists{/gist_id}","starred_url":"https://api.github.com/users/peay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peay/subscriptions","organizations_url":"https://api.github.com/users/peay/orgs","repos_url":"https://api.github.com/users/peay/repos","events_url":"https://api.github.com/users/peay/events{/privacy}","received_events_url":"https://api.github.com/users/peay/received_events","type":"User","site_admin":false},"repo":{"id":72749429,"name":"kubernetes","full_name":"peay/kubernetes","owner":{"login":"peay","id":7261177,"avatar_url":"https://avatars.githubusercontent.com/u/7261177?v=3","gravatar_id":"","url":"https://api.github.com/users/peay","html_url":"https://github.com/peay","followers_url":"https://api.github.com/users/peay/followers","following_url":"https://api.github.com/users/peay/following{/other_user}","gists_url":"https://api.github.com/users/peay/gists{/gist_id}","starred_url":"https://api.github.com/users/peay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peay/subscriptions","organizations_url":"https://api.github.com/users/peay/orgs","repos_url":"https://api.github.com/users/peay/repos","events_url":"https://api.github.com/users/peay/events{/privacy}","received_events_url":"https://api.github.com/users/peay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peay/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/peay/kubernetes","forks_url":"https://api.github.com/repos/peay/kubernetes/forks","keys_url":"https://api.github.com/repos/peay/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peay/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peay/kubernetes/teams","hooks_url":"https://api.github.com/repos/peay/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/peay/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/peay/kubernetes/events","assignees_url":"https://api.github.com/repos/peay/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/peay/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/peay/kubernetes/tags","blobs_url":"https://api.github.com/repos/peay/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peay/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peay/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/peay/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peay/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/peay/kubernetes/languages","stargazers_url":"https://api.github.com/repos/peay/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/peay/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/peay/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/peay/kubernetes/subscription","commits_url":"https://api.github.com/repos/peay/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/peay/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/peay/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/peay/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/peay/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/peay/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peay/kubernetes/merges","archive_url":"https://api.github.com/repos/peay/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peay/kubernetes/downloads","issues_url":"https://api.github.com/repos/peay/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/peay/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/peay/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/peay/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peay/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/peay/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/peay/kubernetes/deployments","created_at":"2016-11-03T13:44:03Z","updated_at":"2016-11-03T13:44:39Z","pushed_at":"2017-02-12T16:13:00Z","git_url":"git://github.com/peay/kubernetes.git","ssh_url":"git@github.com:peay/kubernetes.git","clone_url":"https://github.com/peay/kubernetes.git","svn_url":"https://github.com/peay/kubernetes","homepage":"http://kubernetes.io","size":398823,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7738f41b958bd8a8018333b9c3eb86c563e1ee1a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-02-13T12:51:07Z","pushed_at":"2017-02-13T13:25:53Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":548040,"stargazers_count":20549,"watchers_count":20549,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7017,"mirror_url":null,"open_issues_count":5560,"forks":7017,"open_issues":5560,"watchers":20549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/40932"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/40932"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/40932/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/40932/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/86c1845cec1e7d4d222f1583a66fecb8f2fb2212"}}}}
{"actor":{"display_login":"soltysh"}}