{"action":"created","comment":{"url":"https://api.github.com/repos/istio/pilot/pulls/comments/133249574","pull_request_review_id":56407918,"id":133249574,"diff_hunk":"@@ -11,7 +11,7 @@\n       \"cluster\": \"out.81c187d71467b1608736c57bb0734f9ef9b68f7d\",\n       \"opaque_config\": {\n        \"mixer_control\": \"on\",\n-       \"mixer_forward\": \"off\"\n+       \"mixer_forward\": \"on\"","path":"proxy/envoy/testdata/rds-ingress-ssl.json.golden","position":5,"original_position":5,"commit_id":"3f4dba6123b6cee6cd93c8563ba269b2d1022505","original_commit_id":"589caf3bdcd879d5cc5996068dedb41fccb0b924","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"should we have cases where control and forward both are on?  I think we should not.","created_at":"2017-08-15T17:25:18Z","updated_at":"2017-08-15T17:25:26Z","html_url":"https://github.com/istio/pilot/pull/1033#discussion_r133249574","pull_request_url":"https://api.github.com/repos/istio/pilot/pulls/1033","_links":{"self":{"href":"https://api.github.com/repos/istio/pilot/pulls/comments/133249574"},"html":{"href":"https://github.com/istio/pilot/pull/1033#discussion_r133249574"},"pull_request":{"href":"https://api.github.com/repos/istio/pilot/pulls/1033"}}},"pull_request":{"url":"https://api.github.com/repos/istio/pilot/pulls/1033","id":135847809,"html_url":"https://github.com/istio/pilot/pull/1033","diff_url":"https://github.com/istio/pilot/pull/1033.diff","patch_url":"https://github.com/istio/pilot/pull/1033.patch","issue_url":"https://api.github.com/repos/istio/pilot/issues/1033","number":1033,"state":"open","locked":false,"title":"Enable TCP mixer check","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"+ small change to forward attributes in ingress","created_at":"2017-08-15T17:17:57Z","updated_at":"2017-08-15T17:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a37e97c158e0776c8079d0f54208f468887a0e14","assignee":null,"assignees":[],"requested_reviewers":[{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/pilot/pulls/1033/commits","review_comments_url":"https://api.github.com/repos/istio/pilot/pulls/1033/comments","review_comment_url":"https://api.github.com/repos/istio/pilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/pilot/issues/1033/comments","statuses_url":"https://api.github.com/repos/istio/pilot/statuses/3f4dba6123b6cee6cd93c8563ba269b2d1022505","head":{"label":"kyessenov:tcp_ingress","ref":"tcp_ingress","sha":"3f4dba6123b6cee6cd93c8563ba269b2d1022505","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":75991473,"name":"pilot","full_name":"kyessenov/pilot","owner":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/pilot","description":"The Istio manager implementation","fork":true,"url":"https://api.github.com/repos/kyessenov/pilot","forks_url":"https://api.github.com/repos/kyessenov/pilot/forks","keys_url":"https://api.github.com/repos/kyessenov/pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/pilot/teams","hooks_url":"https://api.github.com/repos/kyessenov/pilot/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/pilot/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/pilot/events","assignees_url":"https://api.github.com/repos/kyessenov/pilot/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/pilot/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/pilot/tags","blobs_url":"https://api.github.com/repos/kyessenov/pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/pilot/languages","stargazers_url":"https://api.github.com/repos/kyessenov/pilot/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/pilot/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/pilot/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/pilot/subscription","commits_url":"https://api.github.com/repos/kyessenov/pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/pilot/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/pilot/merges","archive_url":"https://api.github.com/repos/kyessenov/pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/pilot/downloads","issues_url":"https://api.github.com/repos/kyessenov/pilot/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/pilot/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/pilot/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/pilot/deployments","created_at":"2016-12-09T01:53:54Z","updated_at":"2017-06-01T21:20:25Z","pushed_at":"2017-08-15T17:23:18Z","git_url":"git://github.com/kyessenov/pilot.git","ssh_url":"git@github.com:kyessenov/pilot.git","clone_url":"https://github.com/kyessenov/pilot.git","svn_url":"https://github.com/kyessenov/pilot","homepage":"","size":2058,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"44ee50d9a9c8813e4a82bc8be0f536cdbda86688","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"pilot","full_name":"istio/pilot","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/pilot","description":"Istio Pilot implementation","fork":false,"url":"https://api.github.com/repos/istio/pilot","forks_url":"https://api.github.com/repos/istio/pilot/forks","keys_url":"https://api.github.com/repos/istio/pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/pilot/teams","hooks_url":"https://api.github.com/repos/istio/pilot/hooks","issue_events_url":"https://api.github.com/repos/istio/pilot/issues/events{/number}","events_url":"https://api.github.com/repos/istio/pilot/events","assignees_url":"https://api.github.com/repos/istio/pilot/assignees{/user}","branches_url":"https://api.github.com/repos/istio/pilot/branches{/branch}","tags_url":"https://api.github.com/repos/istio/pilot/tags","blobs_url":"https://api.github.com/repos/istio/pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/pilot/languages","stargazers_url":"https://api.github.com/repos/istio/pilot/stargazers","contributors_url":"https://api.github.com/repos/istio/pilot/contributors","subscribers_url":"https://api.github.com/repos/istio/pilot/subscribers","subscription_url":"https://api.github.com/repos/istio/pilot/subscription","commits_url":"https://api.github.com/repos/istio/pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/pilot/contents/{+path}","compare_url":"https://api.github.com/repos/istio/pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/pilot/merges","archive_url":"https://api.github.com/repos/istio/pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/pilot/downloads","issues_url":"https://api.github.com/repos/istio/pilot/issues{/number}","pulls_url":"https://api.github.com/repos/istio/pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/pilot/labels{/name}","releases_url":"https://api.github.com/repos/istio/pilot/releases{/id}","deployments_url":"https://api.github.com/repos/istio/pilot/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-08-07T23:52:19Z","pushed_at":"2017-08-15T17:23:19Z","git_url":"git://github.com/istio/pilot.git","ssh_url":"git@github.com:istio/pilot.git","clone_url":"https://github.com/istio/pilot.git","svn_url":"https://github.com/istio/pilot","homepage":"","size":73440,"stargazers_count":98,"watchers_count":98,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":93,"forks":64,"open_issues":93,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/pilot/pulls/1033"},"html":{"href":"https://github.com/istio/pilot/pull/1033"},"issue":{"href":"https://api.github.com/repos/istio/pilot/issues/1033"},"comments":{"href":"https://api.github.com/repos/istio/pilot/issues/1033/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/pilot/pulls/1033/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/pilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/pilot/pulls/1033/commits"},"statuses":{"href":"https://api.github.com/repos/istio/pilot/statuses/3f4dba6123b6cee6cd93c8563ba269b2d1022505"}}}}
{"actor":{"display_login":"qiwzhang"}}