{"action":"created","comment":{"url":"https://api.github.com/repos/docker-java/docker-java/pulls/comments/140373757","pull_request_review_id":64439237,"id":140373757,"diff_hunk":"@@ -97,7 +143,15 @@ public PropagationMode getPropagationMode() {\n      */\n     public static Bind parse(String serialized) {\n         try {\n-            String[] parts = serialized.split(\":\");\n+\n+            String[] parts = null;\n+\n+            if (SystemUtils.IS_OS_WINDOWS) {","path":"src/main/java/com/github/dockerjava/api/model/Bind.java","position":67,"original_position":67,"commit_id":"b92e5569e282eab8d50afdeb8bf4994d7ad1a16c","original_commit_id":"b92e5569e282eab8d50afdeb8bf4994d7ad1a16c","user":{"login":"intesar","id":990419,"avatar_url":"https://avatars1.githubusercontent.com/u/990419?v=4","gravatar_id":"","url":"https://api.github.com/users/intesar","html_url":"https://github.com/intesar","followers_url":"https://api.github.com/users/intesar/followers","following_url":"https://api.github.com/users/intesar/following{/other_user}","gists_url":"https://api.github.com/users/intesar/gists{/gist_id}","starred_url":"https://api.github.com/users/intesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intesar/subscriptions","organizations_url":"https://api.github.com/users/intesar/orgs","repos_url":"https://api.github.com/users/intesar/repos","events_url":"https://api.github.com/users/intesar/events{/privacy}","received_events_url":"https://api.github.com/users/intesar/received_events","type":"User","site_admin":false},"body":"You're right the code won't work if it accesses Docker API remotely.","created_at":"2017-09-21T22:20:13Z","updated_at":"2017-09-21T22:20:14Z","html_url":"https://github.com/docker-java/docker-java/pull/920#discussion_r140373757","pull_request_url":"https://api.github.com/repos/docker-java/docker-java/pulls/920","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/comments/140373757"},"html":{"href":"https://github.com/docker-java/docker-java/pull/920#discussion_r140373757"},"pull_request":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/920"}},"in_reply_to_id":140372452},"pull_request":{"url":"https://api.github.com/repos/docker-java/docker-java/pulls/920","id":142450932,"html_url":"https://github.com/docker-java/docker-java/pull/920","diff_url":"https://github.com/docker-java/docker-java/pull/920.diff","patch_url":"https://github.com/docker-java/docker-java/pull/920.patch","issue_url":"https://api.github.com/repos/docker-java/docker-java/issues/920","number":920,"state":"open","locked":false,"title":"Windows volume parsing fix.","user":{"login":"intesar","id":990419,"avatar_url":"https://avatars1.githubusercontent.com/u/990419?v=4","gravatar_id":"","url":"https://api.github.com/users/intesar","html_url":"https://github.com/intesar","followers_url":"https://api.github.com/users/intesar/followers","following_url":"https://api.github.com/users/intesar/following{/other_user}","gists_url":"https://api.github.com/users/intesar/gists{/gist_id}","starred_url":"https://api.github.com/users/intesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intesar/subscriptions","organizations_url":"https://api.github.com/users/intesar/orgs","repos_url":"https://api.github.com/users/intesar/repos","events_url":"https://api.github.com/users/intesar/events{/privacy}","received_events_url":"https://api.github.com/users/intesar/received_events","type":"User","site_admin":false},"body":"When deploying containers to windows with volumes - the docker-java API throws error when parsing windows paths like c:\\dir:c:\\dir.\r\n\r\nThis fixes windows paths like.\r\n\r\nC:\\dir:C:\\dir\r\nC:\\dir:C:\\dir:RO\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/docker-java/docker-java/920)\n<!-- Reviewable:end -->\n","created_at":"2017-09-21T21:32:22Z","updated_at":"2017-09-21T22:20:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e51d0e5f6a3096688d93a900cab803847e466b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker-java/docker-java/pulls/920/commits","review_comments_url":"https://api.github.com/repos/docker-java/docker-java/pulls/920/comments","review_comment_url":"https://api.github.com/repos/docker-java/docker-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker-java/docker-java/issues/920/comments","statuses_url":"https://api.github.com/repos/docker-java/docker-java/statuses/b92e5569e282eab8d50afdeb8bf4994d7ad1a16c","head":{"label":"intesar:3.0.x","ref":"3.0.x","sha":"b92e5569e282eab8d50afdeb8bf4994d7ad1a16c","user":{"login":"intesar","id":990419,"avatar_url":"https://avatars1.githubusercontent.com/u/990419?v=4","gravatar_id":"","url":"https://api.github.com/users/intesar","html_url":"https://github.com/intesar","followers_url":"https://api.github.com/users/intesar/followers","following_url":"https://api.github.com/users/intesar/following{/other_user}","gists_url":"https://api.github.com/users/intesar/gists{/gist_id}","starred_url":"https://api.github.com/users/intesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intesar/subscriptions","organizations_url":"https://api.github.com/users/intesar/orgs","repos_url":"https://api.github.com/users/intesar/repos","events_url":"https://api.github.com/users/intesar/events{/privacy}","received_events_url":"https://api.github.com/users/intesar/received_events","type":"User","site_admin":false},"repo":{"id":104307171,"name":"docker-java","full_name":"intesar/docker-java","owner":{"login":"intesar","id":990419,"avatar_url":"https://avatars1.githubusercontent.com/u/990419?v=4","gravatar_id":"","url":"https://api.github.com/users/intesar","html_url":"https://github.com/intesar","followers_url":"https://api.github.com/users/intesar/followers","following_url":"https://api.github.com/users/intesar/following{/other_user}","gists_url":"https://api.github.com/users/intesar/gists{/gist_id}","starred_url":"https://api.github.com/users/intesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intesar/subscriptions","organizations_url":"https://api.github.com/users/intesar/orgs","repos_url":"https://api.github.com/users/intesar/repos","events_url":"https://api.github.com/users/intesar/events{/privacy}","received_events_url":"https://api.github.com/users/intesar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/intesar/docker-java","description":"Java Docker API Client","fork":true,"url":"https://api.github.com/repos/intesar/docker-java","forks_url":"https://api.github.com/repos/intesar/docker-java/forks","keys_url":"https://api.github.com/repos/intesar/docker-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intesar/docker-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intesar/docker-java/teams","hooks_url":"https://api.github.com/repos/intesar/docker-java/hooks","issue_events_url":"https://api.github.com/repos/intesar/docker-java/issues/events{/number}","events_url":"https://api.github.com/repos/intesar/docker-java/events","assignees_url":"https://api.github.com/repos/intesar/docker-java/assignees{/user}","branches_url":"https://api.github.com/repos/intesar/docker-java/branches{/branch}","tags_url":"https://api.github.com/repos/intesar/docker-java/tags","blobs_url":"https://api.github.com/repos/intesar/docker-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intesar/docker-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intesar/docker-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/intesar/docker-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intesar/docker-java/statuses/{sha}","languages_url":"https://api.github.com/repos/intesar/docker-java/languages","stargazers_url":"https://api.github.com/repos/intesar/docker-java/stargazers","contributors_url":"https://api.github.com/repos/intesar/docker-java/contributors","subscribers_url":"https://api.github.com/repos/intesar/docker-java/subscribers","subscription_url":"https://api.github.com/repos/intesar/docker-java/subscription","commits_url":"https://api.github.com/repos/intesar/docker-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/intesar/docker-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/intesar/docker-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/intesar/docker-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/intesar/docker-java/contents/{+path}","compare_url":"https://api.github.com/repos/intesar/docker-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intesar/docker-java/merges","archive_url":"https://api.github.com/repos/intesar/docker-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intesar/docker-java/downloads","issues_url":"https://api.github.com/repos/intesar/docker-java/issues{/number}","pulls_url":"https://api.github.com/repos/intesar/docker-java/pulls{/number}","milestones_url":"https://api.github.com/repos/intesar/docker-java/milestones{/number}","notifications_url":"https://api.github.com/repos/intesar/docker-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intesar/docker-java/labels{/name}","releases_url":"https://api.github.com/repos/intesar/docker-java/releases{/id}","deployments_url":"https://api.github.com/repos/intesar/docker-java/deployments","created_at":"2017-09-21T05:52:13Z","updated_at":"2017-09-21T05:52:16Z","pushed_at":"2017-09-21T21:30:21Z","git_url":"git://github.com/intesar/docker-java.git","ssh_url":"git@github.com:intesar/docker-java.git","clone_url":"https://github.com/intesar/docker-java.git","svn_url":"https://github.com/intesar/docker-java","homepage":"","size":3950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker-java:3.0.x","ref":"3.0.x","sha":"943cc6f2502a6b650818d71b34dda64de85e5bd7","user":{"login":"docker-java","id":7772003,"avatar_url":"https://avatars1.githubusercontent.com/u/7772003?v=4","gravatar_id":"","url":"https://api.github.com/users/docker-java","html_url":"https://github.com/docker-java","followers_url":"https://api.github.com/users/docker-java/followers","following_url":"https://api.github.com/users/docker-java/following{/other_user}","gists_url":"https://api.github.com/users/docker-java/gists{/gist_id}","starred_url":"https://api.github.com/users/docker-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker-java/subscriptions","organizations_url":"https://api.github.com/users/docker-java/orgs","repos_url":"https://api.github.com/users/docker-java/repos","events_url":"https://api.github.com/users/docker-java/events{/privacy}","received_events_url":"https://api.github.com/users/docker-java/received_events","type":"Organization","site_admin":false},"repo":{"id":20415251,"name":"docker-java","full_name":"docker-java/docker-java","owner":{"login":"docker-java","id":7772003,"avatar_url":"https://avatars1.githubusercontent.com/u/7772003?v=4","gravatar_id":"","url":"https://api.github.com/users/docker-java","html_url":"https://github.com/docker-java","followers_url":"https://api.github.com/users/docker-java/followers","following_url":"https://api.github.com/users/docker-java/following{/other_user}","gists_url":"https://api.github.com/users/docker-java/gists{/gist_id}","starred_url":"https://api.github.com/users/docker-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker-java/subscriptions","organizations_url":"https://api.github.com/users/docker-java/orgs","repos_url":"https://api.github.com/users/docker-java/repos","events_url":"https://api.github.com/users/docker-java/events{/privacy}","received_events_url":"https://api.github.com/users/docker-java/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker-java/docker-java","description":"Java Docker API Client","fork":false,"url":"https://api.github.com/repos/docker-java/docker-java","forks_url":"https://api.github.com/repos/docker-java/docker-java/forks","keys_url":"https://api.github.com/repos/docker-java/docker-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker-java/docker-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker-java/docker-java/teams","hooks_url":"https://api.github.com/repos/docker-java/docker-java/hooks","issue_events_url":"https://api.github.com/repos/docker-java/docker-java/issues/events{/number}","events_url":"https://api.github.com/repos/docker-java/docker-java/events","assignees_url":"https://api.github.com/repos/docker-java/docker-java/assignees{/user}","branches_url":"https://api.github.com/repos/docker-java/docker-java/branches{/branch}","tags_url":"https://api.github.com/repos/docker-java/docker-java/tags","blobs_url":"https://api.github.com/repos/docker-java/docker-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker-java/docker-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker-java/docker-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker-java/docker-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker-java/docker-java/statuses/{sha}","languages_url":"https://api.github.com/repos/docker-java/docker-java/languages","stargazers_url":"https://api.github.com/repos/docker-java/docker-java/stargazers","contributors_url":"https://api.github.com/repos/docker-java/docker-java/contributors","subscribers_url":"https://api.github.com/repos/docker-java/docker-java/subscribers","subscription_url":"https://api.github.com/repos/docker-java/docker-java/subscription","commits_url":"https://api.github.com/repos/docker-java/docker-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker-java/docker-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker-java/docker-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker-java/docker-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker-java/docker-java/contents/{+path}","compare_url":"https://api.github.com/repos/docker-java/docker-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker-java/docker-java/merges","archive_url":"https://api.github.com/repos/docker-java/docker-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker-java/docker-java/downloads","issues_url":"https://api.github.com/repos/docker-java/docker-java/issues{/number}","pulls_url":"https://api.github.com/repos/docker-java/docker-java/pulls{/number}","milestones_url":"https://api.github.com/repos/docker-java/docker-java/milestones{/number}","notifications_url":"https://api.github.com/repos/docker-java/docker-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker-java/docker-java/labels{/name}","releases_url":"https://api.github.com/repos/docker-java/docker-java/releases{/id}","deployments_url":"https://api.github.com/repos/docker-java/docker-java/deployments","created_at":"2014-06-02T18:47:31Z","updated_at":"2017-09-19T01:55:14Z","pushed_at":"2017-09-21T21:32:27Z","git_url":"git://github.com/docker-java/docker-java.git","ssh_url":"git@github.com:docker-java/docker-java.git","clone_url":"https://github.com/docker-java/docker-java.git","svn_url":"https://github.com/docker-java/docker-java","homepage":"","size":5388,"stargazers_count":832,"watchers_count":832,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":130,"forks":492,"open_issues":130,"watchers":832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/920"},"html":{"href":"https://github.com/docker-java/docker-java/pull/920"},"issue":{"href":"https://api.github.com/repos/docker-java/docker-java/issues/920"},"comments":{"href":"https://api.github.com/repos/docker-java/docker-java/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker-java/docker-java/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/docker-java/docker-java/statuses/b92e5569e282eab8d50afdeb8bf4994d7ad1a16c"}},"author_association":"NONE"}}
{"actor":{"display_login":"intesar"}}