{"action":"created","issue":{"url":"https://api.github.com/repos/nix-rust/nix/issues/681","repository_url":"https://api.github.com/repos/nix-rust/nix","labels_url":"https://api.github.com/repos/nix-rust/nix/issues/681/labels{/name}","comments_url":"https://api.github.com/repos/nix-rust/nix/issues/681/comments","events_url":"https://api.github.com/repos/nix-rust/nix/issues/681/events","html_url":"https://github.com/nix-rust/nix/pull/681","id":243295995,"number":681,"title":"Remove feature flags","user":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars5.githubusercontent.com/u/206363?v=4","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-17T04:45:42Z","updated_at":"2017-07-17T04:58:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nix-rust/nix/pulls/681","html_url":"https://github.com/nix-rust/nix/pull/681","diff_url":"https://github.com/nix-rust/nix/pull/681.diff","patch_url":"https://github.com/nix-rust/nix/pull/681.patch"},"body":"These are vestiges of the initial push to get this working on Rust 1.0. These feature flags are undocumented and so hard to discover (only learned about them today!), prevent functions being included that should be and this also affects documentation on docs.rs, and none of the features are tested in CI and the `execvpe` has been broken for forever.\r\n\r\nThe solution is to conditionally compile everything supported for a given platform and do away completely with the feature flags. The `execvpe` function is completely removed as it's not available for *nix platforms in libc and is already broken, so no loss removing it. We'll add it back once it's back in libc (rust-lang/libc#670).\r\n\r\nCloses #98.\r\nCloses #206.\r\nCloses #306.\r\nCloses #308."},"comment":{"url":"https://api.github.com/repos/nix-rust/nix/issues/comments/315668332","html_url":"https://github.com/nix-rust/nix/pull/681#issuecomment-315668332","issue_url":"https://api.github.com/repos/nix-rust/nix/issues/681","id":315668332,"user":{"login":"asomers","id":129721,"avatar_url":"https://avatars5.githubusercontent.com/u/129721?v=4","gravatar_id":"","url":"https://api.github.com/users/asomers","html_url":"https://github.com/asomers","followers_url":"https://api.github.com/users/asomers/followers","following_url":"https://api.github.com/users/asomers/following{/other_user}","gists_url":"https://api.github.com/users/asomers/gists{/gist_id}","starred_url":"https://api.github.com/users/asomers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asomers/subscriptions","organizations_url":"https://api.github.com/users/asomers/orgs","repos_url":"https://api.github.com/users/asomers/repos","events_url":"https://api.github.com/users/asomers/events{/privacy}","received_events_url":"https://api.github.com/users/asomers/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T04:58:04Z","updated_at":"2017-07-17T04:58:04Z","body":"Coincidentally, I first learned of those feature flags today, too.  I agree with getting rid of them.  Could you also change test_signalfd.rs into a normal test file?  And there are also some feature gates in test_unistd.rs and sys/test_uio.rs to remove."}}
{"actor":{"display_login":"asomers"}}