{"action":"created","issue":{"url":"https://api.github.com/repos/zetok/tox/issues/83","repository_url":"https://api.github.com/repos/zetok/tox","labels_url":"https://api.github.com/repos/zetok/tox/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/zetok/tox/issues/83/comments","events_url":"https://api.github.com/repos/zetok/tox/issues/83/events","html_url":"https://github.com/zetok/tox/pull/83","id":259312803,"number":83,"title":"feat(dht_node): add fn for sending packets and method for handling them","user":{"login":"zetok","id":3148759,"avatar_url":"https://avatars1.githubusercontent.com/u/3148759?v=4","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-20T21:50:04Z","updated_at":"2017-09-21T18:08:14Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/zetok/tox/pulls/83","html_url":"https://github.com/zetok/tox/pull/83","diff_url":"https://github.com/zetok/tox/pull/83.diff","patch_url":"https://github.com/zetok/tox/pull/83.patch"},"body":"Depends on #81.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zetok/tox/83)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/zetok/tox/issues/comments/331236894","html_url":"https://github.com/zetok/tox/pull/83#issuecomment-331236894","issue_url":"https://api.github.com/repos/zetok/tox/issues/83","id":331236894,"user":{"login":"zetok","id":3148759,"avatar_url":"https://avatars1.githubusercontent.com/u/3148759?v=4","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T18:08:14Z","updated_at":"2017-09-21T18:08:14Z","author_association":"OWNER","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/toxcore/dht_node.rs, line 365 at r1](https://reviewable.io:443/reviews/zetok/tox/83#-Ku_2jzv9YOyPwBnKVlv:-Ku_b5UjQnpptcAoWLhP:bb038bp) ([raw file](https://github.com/zetok/tox/blob/ef8942cdf99d3bb3ce568f1ce26a93db7a492b98/src/toxcore/dht_node.rs#L365)):*\n<details><summary><i>Previously, kpp (Roman) wrote…</i></summary><blockquote>\n\ndon't use drop\n</blockquote></details>\n\nDropping thread handle detaches the thread, which seems to be desirable here, since thread itself doesn't return anything..?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/zetok/tox/83)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"zetok"}}