{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/107619897","pull_request_review_id":28601638,"id":107619897,"diff_hunk":"@@ -904,25 +893,20 @@ class spell_warr_shield_wall : public SpellScriptLoader\n             if (!GetCaster())\n                 return;\n \n-            if (Player* _player = GetCaster()->ToPlayer())\n+            if (Player* player = GetCaster()->ToPlayer())","path":"src/server/scripts/Spells/spell_warrior.cpp","position":null,"original_position":37,"commit_id":"f4a52dc47bce425fbad0b422e383dd70a5a1faf6","original_commit_id":"f4a52dc47bce425fbad0b422e383dd70a5a1faf6","user":{"login":"Temppus","id":827991,"avatar_url":"https://avatars0.githubusercontent.com/u/827991?v=3","gravatar_id":"","url":"https://api.github.com/users/Temppus","html_url":"https://github.com/Temppus","followers_url":"https://api.github.com/users/Temppus/followers","following_url":"https://api.github.com/users/Temppus/following{/other_user}","gists_url":"https://api.github.com/users/Temppus/gists{/gist_id}","starred_url":"https://api.github.com/users/Temppus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temppus/subscriptions","organizations_url":"https://api.github.com/users/Temppus/orgs","repos_url":"https://api.github.com/users/Temppus/repos","events_url":"https://api.github.com/users/Temppus/events{/privacy}","received_events_url":"https://api.github.com/users/Temppus/received_events","type":"User","site_admin":false},"body":"Why cast to player ?","created_at":"2017-03-23T09:23:49Z","updated_at":"2017-03-23T09:23:55Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/19351#discussion_r107619897","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/107619897"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/19351#discussion_r107619897"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351","id":112117860,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/19351","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/19351.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/19351.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19351","number":19351,"state":"open","locked":false,"title":"Core/Spell Implement Warrior Wall Shield.","user":{"login":"HannibalRoG","id":19369492,"avatar_url":"https://avatars0.githubusercontent.com/u/19369492?v=3","gravatar_id":"","url":"https://api.github.com/users/HannibalRoG","html_url":"https://github.com/HannibalRoG","followers_url":"https://api.github.com/users/HannibalRoG/followers","following_url":"https://api.github.com/users/HannibalRoG/following{/other_user}","gists_url":"https://api.github.com/users/HannibalRoG/gists{/gist_id}","starred_url":"https://api.github.com/users/HannibalRoG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannibalRoG/subscriptions","organizations_url":"https://api.github.com/users/HannibalRoG/orgs","repos_url":"https://api.github.com/users/HannibalRoG/repos","events_url":"https://api.github.com/users/HannibalRoG/events{/privacy}","received_events_url":"https://api.github.com/users/HannibalRoG/received_events","type":"User","site_admin":false},"body":"[//]: # (***************************)\r\n[//]: # (** FILL IN THIS TEMPLATE **)\r\n[//]: # (***************************)\r\n\r\n**Changes proposed:**\r\n\r\n-  Implement spell for warrior class Wall shield.\r\n\r\n**Target branch(es):** 3.3.5/master\r\n\r\n- [x] master\r\n\r\n**Issues addressed:** Closes #  (insert issue tracker number)\r\nDon´t find any\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\nCompiled and tested in game\r\n\r\n**Known issues and TODO list:** (add/remove lines as needed)\r\n\r\n- [ ]  I dont think the visual are correct, i cant find any video from retail.\r\n- [ ]  I dont know if visual for Horde and Alliance exist in Legion.\r\n\r\n","created_at":"2017-03-22T21:45:05Z","updated_at":"2017-03-23T09:23:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7099362e702079ed5b251b7710e7acc5a59774e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19351/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/f4a52dc47bce425fbad0b422e383dd70a5a1faf6","head":{"label":"HannibalRoG:Warrior_Wall_Shield","ref":"Warrior_Wall_Shield","sha":"f4a52dc47bce425fbad0b422e383dd70a5a1faf6","user":{"login":"HannibalRoG","id":19369492,"avatar_url":"https://avatars0.githubusercontent.com/u/19369492?v=3","gravatar_id":"","url":"https://api.github.com/users/HannibalRoG","html_url":"https://github.com/HannibalRoG","followers_url":"https://api.github.com/users/HannibalRoG/followers","following_url":"https://api.github.com/users/HannibalRoG/following{/other_user}","gists_url":"https://api.github.com/users/HannibalRoG/gists{/gist_id}","starred_url":"https://api.github.com/users/HannibalRoG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannibalRoG/subscriptions","organizations_url":"https://api.github.com/users/HannibalRoG/orgs","repos_url":"https://api.github.com/users/HannibalRoG/repos","events_url":"https://api.github.com/users/HannibalRoG/events{/privacy}","received_events_url":"https://api.github.com/users/HannibalRoG/received_events","type":"User","site_admin":false},"repo":{"id":63838873,"name":"TrinityCore","full_name":"HannibalRoG/TrinityCore","owner":{"login":"HannibalRoG","id":19369492,"avatar_url":"https://avatars0.githubusercontent.com/u/19369492?v=3","gravatar_id":"","url":"https://api.github.com/users/HannibalRoG","html_url":"https://github.com/HannibalRoG","followers_url":"https://api.github.com/users/HannibalRoG/followers","following_url":"https://api.github.com/users/HannibalRoG/following{/other_user}","gists_url":"https://api.github.com/users/HannibalRoG/gists{/gist_id}","starred_url":"https://api.github.com/users/HannibalRoG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannibalRoG/subscriptions","organizations_url":"https://api.github.com/users/HannibalRoG/orgs","repos_url":"https://api.github.com/users/HannibalRoG/repos","events_url":"https://api.github.com/users/HannibalRoG/events{/privacy}","received_events_url":"https://api.github.com/users/HannibalRoG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HannibalRoG/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/HannibalRoG/TrinityCore","forks_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/forks","keys_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/teams","hooks_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/events","assignees_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/tags","blobs_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/subscription","commits_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/merges","archive_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/downloads","issues_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/HannibalRoG/TrinityCore/deployments","created_at":"2016-07-21T05:10:27Z","updated_at":"2017-03-12T10:27:42Z","pushed_at":"2017-03-23T03:03:41Z","git_url":"git://github.com/HannibalRoG/TrinityCore.git","ssh_url":"git@github.com:HannibalRoG/TrinityCore.git","clone_url":"https://github.com/HannibalRoG/TrinityCore.git","svn_url":"https://github.com/HannibalRoG/TrinityCore","homepage":"http://www.trinitycore.org","size":404680,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"TrinityCore:master","ref":"master","sha":"408d8768135dd8fb72150cc5ede9967cf57a728b","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars0.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars0.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2017-03-23T07:25:39Z","pushed_at":"2017-03-23T03:13:08Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":423441,"stargazers_count":3712,"watchers_count":3712,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3719,"mirror_url":null,"open_issues_count":1317,"forks":3719,"open_issues":1317,"watchers":3712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/19351"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19351"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19351/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19351/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/f4a52dc47bce425fbad0b422e383dd70a5a1faf6"}}}}
{"actor":{"display_login":"Temppus"}}