{"action":"created","issue":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/451","repository_url":"https://api.github.com/repos/mailcow/mailcow-dockerized","labels_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/451/labels{/name}","comments_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/451/comments","events_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/451/events","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/451","id":241824973,"number":451,"title":"DNS diagnostics page","user":{"login":"mkuron","id":1748330,"avatar_url":"https://avatars0.githubusercontent.com/u/1748330?v=4","gravatar_id":"","url":"https://api.github.com/users/mkuron","html_url":"https://github.com/mkuron","followers_url":"https://api.github.com/users/mkuron/followers","following_url":"https://api.github.com/users/mkuron/following{/other_user}","gists_url":"https://api.github.com/users/mkuron/gists{/gist_id}","starred_url":"https://api.github.com/users/mkuron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkuron/subscriptions","organizations_url":"https://api.github.com/users/mkuron/orgs","repos_url":"https://api.github.com/users/mkuron/repos","events_url":"https://api.github.com/users/mkuron/events{/privacy}","received_events_url":"https://api.github.com/users/mkuron/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"andryyy","id":2972950,"avatar_url":"https://avatars0.githubusercontent.com/u/2972950?v=4","gravatar_id":"","url":"https://api.github.com/users/andryyy","html_url":"https://github.com/andryyy","followers_url":"https://api.github.com/users/andryyy/followers","following_url":"https://api.github.com/users/andryyy/following{/other_user}","gists_url":"https://api.github.com/users/andryyy/gists{/gist_id}","starred_url":"https://api.github.com/users/andryyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andryyy/subscriptions","organizations_url":"https://api.github.com/users/andryyy/orgs","repos_url":"https://api.github.com/users/andryyy/repos","events_url":"https://api.github.com/users/andryyy/events{/privacy}","received_events_url":"https://api.github.com/users/andryyy/received_events","type":"User","site_admin":false},"assignees":[{"login":"andryyy","id":2972950,"avatar_url":"https://avatars0.githubusercontent.com/u/2972950?v=4","gravatar_id":"","url":"https://api.github.com/users/andryyy","html_url":"https://github.com/andryyy","followers_url":"https://api.github.com/users/andryyy/followers","following_url":"https://api.github.com/users/andryyy/following{/other_user}","gists_url":"https://api.github.com/users/andryyy/gists{/gist_id}","starred_url":"https://api.github.com/users/andryyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andryyy/subscriptions","organizations_url":"https://api.github.com/users/andryyy/orgs","repos_url":"https://api.github.com/users/andryyy/repos","events_url":"https://api.github.com/users/andryyy/events{/privacy}","received_events_url":"https://api.github.com/users/andryyy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-07-10T19:43:59Z","updated_at":"2017-11-07T09:50:34Z","closed_at":"2017-11-07T08:41:33Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/pulls/451","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/451","diff_url":"https://github.com/mailcow/mailcow-dockerized/pull/451.diff","patch_url":"https://github.com/mailcow/mailcow-dockerized/pull/451.patch"},"body":"@andryyy merged #427 and #444 this morning and later reverted them with a few comments. This PR just contains the DNS diagnostics page updated according to his comments, which I have included and addressed below. It needs to be merged after #449 as it depends on that PR.\r\n\r\n----------\r\n\r\n> Remove the SPF stuff and DMARC, please. Or just write \"SPF\" or something, don't tell the users this single record is fine (I know you already check for a covered SPF, but still this is misleading). The DMARC record can actually be removed completly. Or mark it as optional. This should not be added without knowing anything about it, nobody needs it when they don't know what it is and does. :-)\r\n\r\nDone that. I now link to the assistant from the documentation instead of showing a recommended value. Instead of a checkmark or cross, it now just shows the current value and that it's optional.\r\n\r\n> Besides the diagnostics.php in the root directory (?) it does not show anything.\r\n\r\nOoops, sorry. Fixed that now."},"comment":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/comments/342430503","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/451#issuecomment-342430503","issue_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/451","id":342430503,"user":{"login":"develth","id":3374563,"avatar_url":"https://avatars0.githubusercontent.com/u/3374563?v=4","gravatar_id":"","url":"https://api.github.com/users/develth","html_url":"https://github.com/develth","followers_url":"https://api.github.com/users/develth/followers","following_url":"https://api.github.com/users/develth/following{/other_user}","gists_url":"https://api.github.com/users/develth/gists{/gist_id}","starred_url":"https://api.github.com/users/develth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develth/subscriptions","organizations_url":"https://api.github.com/users/develth/orgs","repos_url":"https://api.github.com/users/develth/repos","events_url":"https://api.github.com/users/develth/events{/privacy}","received_events_url":"https://api.github.com/users/develth/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T09:50:34Z","updated_at":"2017-11-07T09:50:34Z","author_association":"NONE","body":"@mkuron I wouldn´t put general stuff in domain specific sections ( maybe you just would show the domain DNS fields to Domain Admins - and they should not see the Global DNS overview).\r\n\r\nWhat about:\r\n\r\nAdmin: \r\n* **Configuration Administration-> Bottom**: A Icon Indicator if DNS State is ok (green ok, red missing). This flag could be set by Cron / AJAX. Beside is a Button / Link that show the Detail of the cow DNS.\r\n* **Configuration Mailboxes -> Domains**:  New Multi Action DNS Diagnostic. Show DNS for selected Pages. Add a table row with indicator if DNS is ok or not. this flag could be set by Cron / AJAX.\r\n* **Configuration Mailboxes -> Domains Edit Bottom**: DNS Indicator with Collapsable or Modal Detail. Indicator Cron / AJAX - Collapsed / Modal loaded by AJAX request.\r\n\r\nI think that would be the best UX. DNS Settings are important to ensure mail delivery, so lets move them into users focus. "}}
{"actor":{"display_login":"develth"}}