{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/482","repository_url":"https://api.github.com/repos/openSUSE/osc-plugin-factory","labels_url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/482/comments","events_url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/482/events","html_url":"https://github.com/openSUSE/osc-plugin-factory/issues/482","id":146629386,"number":482,"title":"factory-repo-checker: add comment if check is delayed","user":{"login":"lnussel","id":722232,"avatar_url":"https://avatars1.githubusercontent.com/u/722232?v=3","gravatar_id":"","url":"https://api.github.com/users/lnussel","html_url":"https://github.com/lnussel","followers_url":"https://api.github.com/users/lnussel/followers","following_url":"https://api.github.com/users/lnussel/following{/other_user}","gists_url":"https://api.github.com/users/lnussel/gists{/gist_id}","starred_url":"https://api.github.com/users/lnussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnussel/subscriptions","organizations_url":"https://api.github.com/users/lnussel/orgs","repos_url":"https://api.github.com/users/lnussel/repos","events_url":"https://api.github.com/users/lnussel/events{/privacy}","received_events_url":"https://api.github.com/users/lnussel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-04-07T13:41:53Z","updated_at":"2017-05-06T04:46:53Z","closed_at":null,"body":"the factory-repo-checker currently only changes the review if it couldn't approve the request. There are no notifications for that kind of events. factory-repo-checker should therefore add an obs comment if it couldn't approve a request for let's say 24 hours.\n"},"comment":{"url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/comments/299615589","html_url":"https://github.com/openSUSE/osc-plugin-factory/issues/482#issuecomment-299615589","issue_url":"https://api.github.com/repos/openSUSE/osc-plugin-factory/issues/482","id":299615589,"user":{"login":"jberry-suse","id":22943929,"avatar_url":"https://avatars1.githubusercontent.com/u/22943929?v=3","gravatar_id":"","url":"https://api.github.com/users/jberry-suse","html_url":"https://github.com/jberry-suse","followers_url":"https://api.github.com/users/jberry-suse/followers","following_url":"https://api.github.com/users/jberry-suse/following{/other_user}","gists_url":"https://api.github.com/users/jberry-suse/gists{/gist_id}","starred_url":"https://api.github.com/users/jberry-suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberry-suse/subscriptions","organizations_url":"https://api.github.com/users/jberry-suse/orgs","repos_url":"https://api.github.com/users/jberry-suse/repos","events_url":"https://api.github.com/users/jberry-suse/events{/privacy}","received_events_url":"https://api.github.com/users/jberry-suse/received_events","type":"User","site_admin":false},"created_at":"2017-05-06T04:46:53Z","updated_at":"2017-05-06T04:46:53Z","body":"In the same fashion that the devel reminders check comment age before making another the delay or repeat delay should be feasible. While I'm in the code for #837 would be a convenient time to implement this, but we need some sort of decision.\r\n\r\nOnly comment in case of fail seems to be the idea since otherwise there is nothing to be done by the submitter.\r\n\r\nIn case of fail, there are likely two likely points for constraints.\r\n\r\n1. Age of request\r\n2. Delta since staged\r\n\r\nAt least for Leap waiting for `2` will likely need to be a requirement in the case of things like SLE requests although those will be by `leaper` and comments may not be relevant. Either way it seems best to wait for a request to be staged if it is not outright declined.\r\n\r\nLikely once delta since last staged is `> 12` hours? or some number? Someone more familiar with failures in Factory would likely answer better.\r\n\r\nOn the other hand @nilxam comment about groups seems to make sense in that if the review is based on staging groups it may be related to any request in the group. Then one might say it would be better to post the comment on the project similar to the comment bot regarding build failures.\r\n\r\nIf so the likely path is waiting for build completion in staging project before posting comment. Same as `leaper` check if comment is similar first and if not either always update or have repeat delay.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"jberry-suse"}}