{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/123616747","pull_request_review_id":45839872,"id":123616747,"diff_hunk":"@@ -577,28 +577,37 @@ jenkinsPipelineStrategy:\n \n [NOTE]\n ====\n-Specifics on the mapping between `BuildConfig` environment variables and Jenkins job parameters:\n-\n-* When a Jenkins job is created or updated based on changes to a Pipeline strategy `BuildConfig`, any environment\n-variables in the `BuildConfig` are mapped to Jenkins job parameters definitions, where the default values for the Jenkins job parameters\n-definitions are the current values of the associated environment variables.\n-* You can still add additional parameters (whose names differ from the names of the environment variables in the `BuildConfig`)\n-to the Jenkins job from the Jenkins console after the job's initial creation and they will be honored when builds are started for those Jenkins jobs.\n-* How you start builds for the Jenkins job then dictates how the parameters are set.\n-* If you start via `oc start-build`, the values of the environment variables in the `BuildConfig` are what the parameters are set\n-to for the corresponding job instance.  Any changes you make to the parameters default values from the Jenkins console are ignored.\n-The `BuildConfig` values take precedence.\n-* If you start via `oc start-build -e`, the values for the environment variables specified in the `-e` option take precedence.  And if you\n-specify an environment variable not listed in the `BuildConfig`, they will be added as a Jenkins job parameter definitions. And, again, any\n-changes you make from the Jenkins console to the parameters corresponding to the environment variables are ignored.  The `BuildConfig`\n-and what you specify via `oc start-build -e` takes precedence.\n-* If you start the Jenkins job via the Jenkins console, then you can control the setting of the parameters via the Jenkins console as part\n-of starting a build for the job.\n-\n-Please visit the xref:../../dev_guide/builds/build_environment.adoc#dev-guide-build-build-environment[build environment]\n-section for more advanced usage.\n-\n You can also manage environment variables defined in the `BuildConfig` with the\n xref:../../dev_guide/environment_variables.adoc#dev-guide-environment-variables[`oc set env`] command.\n ====\n \n+[[mapping-buildconfig-jenkins]]\n+==== Mapping Between BuildConfig Environment Variables and Jenkins Job Parameters\n+\n+When a Jenkins job is created or updated based on changes to a Pipeline\n+strategy `BuildConfig`, any environment variables in the `BuildConfig` are\n+mapped to Jenkins job parameters definitions, where the default values for the\n+Jenkins job parameters definitions are the current values of the associated\n+environment variables.\n+\n+You can still add additional parameters (whose names differ from the names of\n+the environment variables in the `BuildConfig`) to the Jenkins job from the\n+Jenkins console after the job's initial creation and they will be honored when\n+builds are started for those Jenkins jobs.\n+\n+How you start builds for the Jenkins job dictates how the parameters are set. If\n+you start with `oc start-build`, the values of the environment variables in the\n+`BuildConfig` are the parameters set for the corresponding job instance. Any\n+changes you make to the parameters default values from the Jenkins console are","path":"dev_guide/builds/build_strategies.adoc","position":90,"original_position":90,"commit_id":"0915d69341bfb20d56fdbc2a598deb96b2242d63","original_commit_id":"0915d69341bfb20d56fdbc2a598deb96b2242d63","user":{"login":"ahardin-rh","id":16197393,"avatar_url":"https://avatars2.githubusercontent.com/u/16197393?v=3","gravatar_id":"","url":"https://api.github.com/users/ahardin-rh","html_url":"https://github.com/ahardin-rh","followers_url":"https://api.github.com/users/ahardin-rh/followers","following_url":"https://api.github.com/users/ahardin-rh/following{/other_user}","gists_url":"https://api.github.com/users/ahardin-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/ahardin-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahardin-rh/subscriptions","organizations_url":"https://api.github.com/users/ahardin-rh/orgs","repos_url":"https://api.github.com/users/ahardin-rh/repos","events_url":"https://api.github.com/users/ahardin-rh/events{/privacy}","received_events_url":"https://api.github.com/users/ahardin-rh/received_events","type":"User","site_admin":false},"body":"parameters'","created_at":"2017-06-22T20:41:54Z","updated_at":"2017-06-22T20:41:54Z","html_url":"https://github.com/openshift/openshift-docs/pull/4638#discussion_r123616747","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/123616747"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/4638#discussion_r123616747"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638","id":127007845,"html_url":"https://github.com/openshift/openshift-docs/pull/4638","diff_url":"https://github.com/openshift/openshift-docs/pull/4638.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/4638.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/4638","number":4638,"state":"open","locked":false,"title":"[WIP] PR4557-Follow-up","user":{"login":"bmcelvee","id":24275422,"avatar_url":"https://avatars2.githubusercontent.com/u/24275422?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcelvee","html_url":"https://github.com/bmcelvee","followers_url":"https://api.github.com/users/bmcelvee/followers","following_url":"https://api.github.com/users/bmcelvee/following{/other_user}","gists_url":"https://api.github.com/users/bmcelvee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcelvee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcelvee/subscriptions","organizations_url":"https://api.github.com/users/bmcelvee/orgs","repos_url":"https://api.github.com/users/bmcelvee/repos","events_url":"https://api.github.com/users/bmcelvee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcelvee/received_events","type":"User","site_admin":false},"body":"https://github.com/openshift/openshift-docs/pull/4557","created_at":"2017-06-22T14:34:40Z","updated_at":"2017-06-22T20:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f4451947a98fa6eebba452721262e9ebc914a3b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6","html_url":"https://github.com/openshift/openshift-docs/milestone/6","labels_url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6/labels","id":1435997,"number":6,"title":"Future Release","description":"Tracker for content relevant to latest Origin code, but still targeting a future release of Enterprise, Dedicated, and/or Online.","creator":{"login":"adellape","id":3442316,"avatar_url":"https://avatars2.githubusercontent.com/u/3442316?v=3","gravatar_id":"","url":"https://api.github.com/users/adellape","html_url":"https://github.com/adellape","followers_url":"https://api.github.com/users/adellape/followers","following_url":"https://api.github.com/users/adellape/following{/other_user}","gists_url":"https://api.github.com/users/adellape/gists{/gist_id}","starred_url":"https://api.github.com/users/adellape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adellape/subscriptions","organizations_url":"https://api.github.com/users/adellape/orgs","repos_url":"https://api.github.com/users/adellape/repos","events_url":"https://api.github.com/users/adellape/events{/privacy}","received_events_url":"https://api.github.com/users/adellape/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":85,"state":"open","created_at":"2015-11-30T20:14:06Z","updated_at":"2017-06-22T20:16:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/4638/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/0915d69341bfb20d56fdbc2a598deb96b2242d63","head":{"label":"bmcelvee:PR4557-Follow-up","ref":"PR4557-Follow-up","sha":"0915d69341bfb20d56fdbc2a598deb96b2242d63","user":{"login":"bmcelvee","id":24275422,"avatar_url":"https://avatars2.githubusercontent.com/u/24275422?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcelvee","html_url":"https://github.com/bmcelvee","followers_url":"https://api.github.com/users/bmcelvee/followers","following_url":"https://api.github.com/users/bmcelvee/following{/other_user}","gists_url":"https://api.github.com/users/bmcelvee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcelvee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcelvee/subscriptions","organizations_url":"https://api.github.com/users/bmcelvee/orgs","repos_url":"https://api.github.com/users/bmcelvee/repos","events_url":"https://api.github.com/users/bmcelvee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcelvee/received_events","type":"User","site_admin":false},"repo":{"id":75429914,"name":"openshift-docs","full_name":"bmcelvee/openshift-docs","owner":{"login":"bmcelvee","id":24275422,"avatar_url":"https://avatars2.githubusercontent.com/u/24275422?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcelvee","html_url":"https://github.com/bmcelvee","followers_url":"https://api.github.com/users/bmcelvee/followers","following_url":"https://api.github.com/users/bmcelvee/following{/other_user}","gists_url":"https://api.github.com/users/bmcelvee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcelvee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcelvee/subscriptions","organizations_url":"https://api.github.com/users/bmcelvee/orgs","repos_url":"https://api.github.com/users/bmcelvee/repos","events_url":"https://api.github.com/users/bmcelvee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcelvee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmcelvee/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/bmcelvee/openshift-docs","forks_url":"https://api.github.com/repos/bmcelvee/openshift-docs/forks","keys_url":"https://api.github.com/repos/bmcelvee/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmcelvee/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmcelvee/openshift-docs/teams","hooks_url":"https://api.github.com/repos/bmcelvee/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/bmcelvee/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/bmcelvee/openshift-docs/events","assignees_url":"https://api.github.com/repos/bmcelvee/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/bmcelvee/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/bmcelvee/openshift-docs/tags","blobs_url":"https://api.github.com/repos/bmcelvee/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmcelvee/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmcelvee/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmcelvee/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmcelvee/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/bmcelvee/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/bmcelvee/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/bmcelvee/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/bmcelvee/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/bmcelvee/openshift-docs/subscription","commits_url":"https://api.github.com/repos/bmcelvee/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmcelvee/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmcelvee/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmcelvee/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmcelvee/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/bmcelvee/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmcelvee/openshift-docs/merges","archive_url":"https://api.github.com/repos/bmcelvee/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmcelvee/openshift-docs/downloads","issues_url":"https://api.github.com/repos/bmcelvee/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/bmcelvee/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/bmcelvee/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/bmcelvee/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmcelvee/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/bmcelvee/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/bmcelvee/openshift-docs/deployments","created_at":"2016-12-02T20:50:34Z","updated_at":"2016-12-02T20:50:37Z","pushed_at":"2017-06-22T20:38:55Z","git_url":"git://github.com/bmcelvee/openshift-docs.git","ssh_url":"git@github.com:bmcelvee/openshift-docs.git","clone_url":"https://github.com/bmcelvee/openshift-docs.git","svn_url":"https://github.com/bmcelvee/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":39306,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"be98ce352e6c03860101c14dae95e34c665cce01","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2017-06-21T16:15:22Z","pushed_at":"2017-06-22T20:38:56Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":39484,"stargazers_count":97,"watchers_count":97,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":220,"forks":367,"open_issues":220,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/4638"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/4638"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/4638/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/4638/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/0915d69341bfb20d56fdbc2a598deb96b2242d63"}}}}
{"actor":{"display_login":"ahardin-rh"}}