{"action":"created","issue":{"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1451","repository_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS","labels_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1451/labels{/name}","comments_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1451/comments","events_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1451/events","html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1451","id":205092336,"number":1451,"title":"[NodeSearchBundle] Make NodeSearcher properties protected for extending","user":{"login":"b-franco","id":8274224,"avatar_url":"https://avatars.githubusercontent.com/u/8274224?v=3","gravatar_id":"","url":"https://api.github.com/users/b-franco","html_url":"https://github.com/b-franco","followers_url":"https://api.github.com/users/b-franco/followers","following_url":"https://api.github.com/users/b-franco/following{/other_user}","gists_url":"https://api.github.com/users/b-franco/gists{/gist_id}","starred_url":"https://api.github.com/users/b-franco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-franco/subscriptions","organizations_url":"https://api.github.com/users/b-franco/orgs","repos_url":"https://api.github.com/users/b-franco/repos","events_url":"https://api.github.com/users/b-franco/events{/privacy}","received_events_url":"https://api.github.com/users/b-franco/received_events","type":"User","site_admin":false},"labels":[{"id":130845547,"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/labels/Priority:%20Low","name":"Priority: Low","color":"207de5","default":false},{"id":168507049,"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/labels/Profile:%20Backend","name":"Profile: Backend","color":"c7def8","default":false},{"id":130845788,"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/labels/Target%20audience:%20Developers","name":"Target audience: Developers","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-03T07:50:41Z","updated_at":"2017-02-16T16:21:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1451","html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1451","diff_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1451.diff","patch_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1451.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed tickets | /\r\n\r\nMake the properties of NodeSearcher protected so it's easier/cleaner to extend it.\r\n"},"comment":{"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/comments/280378995","html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1451#issuecomment-280378995","issue_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1451","id":280378995,"user":{"login":"Devolicious","id":360302,"avatar_url":"https://avatars.githubusercontent.com/u/360302?v=3","gravatar_id":"","url":"https://api.github.com/users/Devolicious","html_url":"https://github.com/Devolicious","followers_url":"https://api.github.com/users/Devolicious/followers","following_url":"https://api.github.com/users/Devolicious/following{/other_user}","gists_url":"https://api.github.com/users/Devolicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Devolicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devolicious/subscriptions","organizations_url":"https://api.github.com/users/Devolicious/orgs","repos_url":"https://api.github.com/users/Devolicious/repos","events_url":"https://api.github.com/users/Devolicious/events{/privacy}","received_events_url":"https://api.github.com/users/Devolicious/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T16:21:16Z","updated_at":"2017-02-16T16:21:16Z","body":"Hi @b-franco,\r\n\r\nI like your changes but they implicate a BC break since you can't define properties with a more strict access level than it's parent. So I would like to ask you to rebase and submit this PR to the 5.0 branch and add some documentation to the upgrade guide.\r\n\r\nThanks and keep up the good work!"}}
{"actor":{"display_login":"Devolicious"}}