{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/103532995","pull_request_review_id":24318585,"id":103532995,"diff_hunk":"@@ -114,10 +116,36 @@ const (\n )\n \n // NewFailureReason initializes a new failure reason that contains both the\n-// reason and a message to be displayed\n+// reason and a message to be displayed.\n func NewFailureReason(reason api.StepFailureReason, message api.StepFailureMessage) api.FailureReason {\n \treturn api.FailureReason{\n \t\tReason:  reason,\n \t\tMessage: message,\n \t}\n }\n+\n+// AddStepInfo appends timing information about specific build stepts to the\n+// result object. In case the step was already added, it will update the stop\n+// time, this allows timing for substeps to be aggregated under a generic step.","path":"pkg/util/status/build_status.go","position":24,"original_position":24,"commit_id":"f782e61c6f83e085e9e40c1266d640166aa75f7f","original_commit_id":"f782e61c6f83e085e9e40c1266d640166aa75f7f","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars1.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"i'm not sure how i feel about this.  If i run 6 steps and label them all \"GatherInput\" but they are intermingled with other actions, you're going to report that GatherInput took way longer than it really did.\r\n\r\nI think we should just aim to structure the code+definition of \"steps\" better such that we can explicitly start/stop the timing for a given step exactly once.  If there are cases where you think we are going a little bit of input gathering, then go off and do something else, then come back and do some more input gathering, we should discuss them and decide if maybe we just need more fine grained \"step\" definitions rather than lumping all those things as \"input gathering\".  And again i think a lot of this goes away anyway once you stop worrying about timings for flows that are either\r\n\r\n1) specific to extended builds\r\n2) specific to standalone s2i usage because openshift handles that step externally\r\n\r\n\r\n","created_at":"2017-02-28T19:27:33Z","updated_at":"2017-02-28T19:28:10Z","html_url":"https://github.com/openshift/source-to-image/pull/694#discussion_r103532995","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/103532995"},"html":{"href":"https://github.com/openshift/source-to-image/pull/694#discussion_r103532995"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/694","id":108383219,"html_url":"https://github.com/openshift/source-to-image/pull/694","diff_url":"https://github.com/openshift/source-to-image/pull/694.diff","patch_url":"https://github.com/openshift/source-to-image/pull/694.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/694","number":694,"state":"open","locked":false,"title":"add build timing information","user":{"login":"coreydaley","id":5060301,"avatar_url":"https://avatars1.githubusercontent.com/u/5060301?v=3","gravatar_id":"","url":"https://api.github.com/users/coreydaley","html_url":"https://github.com/coreydaley","followers_url":"https://api.github.com/users/coreydaley/followers","following_url":"https://api.github.com/users/coreydaley/following{/other_user}","gists_url":"https://api.github.com/users/coreydaley/gists{/gist_id}","starred_url":"https://api.github.com/users/coreydaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreydaley/subscriptions","organizations_url":"https://api.github.com/users/coreydaley/orgs","repos_url":"https://api.github.com/users/coreydaley/repos","events_url":"https://api.github.com/users/coreydaley/events{/privacy}","received_events_url":"https://api.github.com/users/coreydaley/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-28T17:47:27Z","updated_at":"2017-02-28T19:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e2be865c584887a533b3486e64181a0469401fb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/694/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/694/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/694/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/f782e61c6f83e085e9e40c1266d640166aa75f7f","head":{"label":"coreydaley:add_timing_info","ref":"add_timing_info","sha":"f782e61c6f83e085e9e40c1266d640166aa75f7f","user":{"login":"coreydaley","id":5060301,"avatar_url":"https://avatars1.githubusercontent.com/u/5060301?v=3","gravatar_id":"","url":"https://api.github.com/users/coreydaley","html_url":"https://github.com/coreydaley","followers_url":"https://api.github.com/users/coreydaley/followers","following_url":"https://api.github.com/users/coreydaley/following{/other_user}","gists_url":"https://api.github.com/users/coreydaley/gists{/gist_id}","starred_url":"https://api.github.com/users/coreydaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreydaley/subscriptions","organizations_url":"https://api.github.com/users/coreydaley/orgs","repos_url":"https://api.github.com/users/coreydaley/repos","events_url":"https://api.github.com/users/coreydaley/events{/privacy}","received_events_url":"https://api.github.com/users/coreydaley/received_events","type":"User","site_admin":false},"repo":{"id":67154435,"name":"source-to-image","full_name":"coreydaley/source-to-image","owner":{"login":"coreydaley","id":5060301,"avatar_url":"https://avatars1.githubusercontent.com/u/5060301?v=3","gravatar_id":"","url":"https://api.github.com/users/coreydaley","html_url":"https://github.com/coreydaley","followers_url":"https://api.github.com/users/coreydaley/followers","following_url":"https://api.github.com/users/coreydaley/following{/other_user}","gists_url":"https://api.github.com/users/coreydaley/gists{/gist_id}","starred_url":"https://api.github.com/users/coreydaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreydaley/subscriptions","organizations_url":"https://api.github.com/users/coreydaley/orgs","repos_url":"https://api.github.com/users/coreydaley/repos","events_url":"https://api.github.com/users/coreydaley/events{/privacy}","received_events_url":"https://api.github.com/users/coreydaley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coreydaley/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/coreydaley/source-to-image","forks_url":"https://api.github.com/repos/coreydaley/source-to-image/forks","keys_url":"https://api.github.com/repos/coreydaley/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreydaley/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreydaley/source-to-image/teams","hooks_url":"https://api.github.com/repos/coreydaley/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/coreydaley/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/coreydaley/source-to-image/events","assignees_url":"https://api.github.com/repos/coreydaley/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/coreydaley/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/coreydaley/source-to-image/tags","blobs_url":"https://api.github.com/repos/coreydaley/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreydaley/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreydaley/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreydaley/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreydaley/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/coreydaley/source-to-image/languages","stargazers_url":"https://api.github.com/repos/coreydaley/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/coreydaley/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/coreydaley/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/coreydaley/source-to-image/subscription","commits_url":"https://api.github.com/repos/coreydaley/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreydaley/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreydaley/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreydaley/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreydaley/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/coreydaley/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreydaley/source-to-image/merges","archive_url":"https://api.github.com/repos/coreydaley/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreydaley/source-to-image/downloads","issues_url":"https://api.github.com/repos/coreydaley/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/coreydaley/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/coreydaley/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/coreydaley/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreydaley/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/coreydaley/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/coreydaley/source-to-image/deployments","created_at":"2016-09-01T18:02:21Z","updated_at":"2016-09-01T18:02:23Z","pushed_at":"2017-02-28T17:45:34Z","git_url":"git://github.com/coreydaley/source-to-image.git","ssh_url":"git@github.com:coreydaley/source-to-image.git","clone_url":"https://github.com/coreydaley/source-to-image.git","svn_url":"https://github.com/coreydaley/source-to-image","homepage":"","size":15758,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d76ef1e571b9501a120d5716eeee5bc824d747e2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2017-02-28T10:53:56Z","pushed_at":"2017-02-28T18:15:10Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":15751,"stargazers_count":395,"watchers_count":395,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":18,"forks":182,"open_issues":18,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/694"},"html":{"href":"https://github.com/openshift/source-to-image/pull/694"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/694"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/f782e61c6f83e085e9e40c1266d640166aa75f7f"}}}}
{"actor":{"display_login":"bparees"}}