{"action":"created","comment":{"url":"https://api.github.com/repos/kelda/kelda/pulls/comments/150704622","pull_request_review_id":76294346,"id":150704622,"diff_hunk":"@@ -46,29 +47,46 @@ func syncImages(conn db.Conn, dk docker.Client) {\n \tvar toBuild []db.Image\n \tconn.Txn(db.ImageTable).Run(func(view db.Database) error {\n \t\ttoBuild = view.SelectFromImage(func(img db.Image) bool {\n-\t\t\treturn img.Status != db.Built\n+\t\t\treturn !img.BuildQueued","path":"minion/registry/registry.go","position":13,"original_position":13,"commit_id":"24da744d2c880c1d457a2344753534e4bbc90dca","original_commit_id":"24da744d2c880c1d457a2344753534e4bbc90dca","user":{"login":"ejj","id":620438,"avatar_url":"https://avatars2.githubusercontent.com/u/620438?v=4","gravatar_id":"","url":"https://api.github.com/users/ejj","html_url":"https://github.com/ejj","followers_url":"https://api.github.com/users/ejj/followers","following_url":"https://api.github.com/users/ejj/following{/other_user}","gists_url":"https://api.github.com/users/ejj/gists{/gist_id}","starred_url":"https://api.github.com/users/ejj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejj/subscriptions","organizations_url":"https://api.github.com/users/ejj/orgs","repos_url":"https://api.github.com/users/ejj/repos","events_url":"https://api.github.com/users/ejj/events{/privacy}","received_events_url":"https://api.github.com/users/ejj/received_events","type":"User","site_admin":false},"body":"I don't quite see the point of this BuildQueued thing. Nothing uses it outside of this function ...  Also, the way you've written it here, it won't work.  You can only write to an image in a database transaction.","created_at":"2017-11-14T00:14:14Z","updated_at":"2017-11-14T00:14:14Z","html_url":"https://github.com/kelda/kelda/pull/1263#discussion_r150704622","pull_request_url":"https://api.github.com/repos/kelda/kelda/pulls/1263","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kelda/kelda/pulls/comments/150704622"},"html":{"href":"https://github.com/kelda/kelda/pull/1263#discussion_r150704622"},"pull_request":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1263"}}},"pull_request":{"url":"https://api.github.com/repos/kelda/kelda/pulls/1263","id":152041268,"html_url":"https://github.com/kelda/kelda/pull/1263","diff_url":"https://github.com/kelda/kelda/pull/1263.diff","patch_url":"https://github.com/kelda/kelda/pull/1263.patch","issue_url":"https://api.github.com/repos/kelda/kelda/issues/1263","number":1263,"state":"open","locked":false,"title":"minion: Build custom Docker images in parallel","user":{"login":"aegamesi","id":552502,"avatar_url":"https://avatars2.githubusercontent.com/u/552502?v=4","gravatar_id":"","url":"https://api.github.com/users/aegamesi","html_url":"https://github.com/aegamesi","followers_url":"https://api.github.com/users/aegamesi/followers","following_url":"https://api.github.com/users/aegamesi/following{/other_user}","gists_url":"https://api.github.com/users/aegamesi/gists{/gist_id}","starred_url":"https://api.github.com/users/aegamesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aegamesi/subscriptions","organizations_url":"https://api.github.com/users/aegamesi/orgs","repos_url":"https://api.github.com/users/aegamesi/repos","events_url":"https://api.github.com/users/aegamesi/events{/privacy}","received_events_url":"https://api.github.com/users/aegamesi/received_events","type":"User","site_admin":false},"body":"Previously, custom Docker images would be built sequentially by the\r\nmaster, potentially not making full use of the machine. This change\r\nallows up to 8 images to be built simultaneously.","created_at":"2017-11-11T04:27:12Z","updated_at":"2017-11-14T00:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a6d2971dc145740b5ecebe6110b9cd0ec81a7a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kayousterhout","id":1108612,"avatar_url":"https://avatars3.githubusercontent.com/u/1108612?v=4","gravatar_id":"","url":"https://api.github.com/users/kayousterhout","html_url":"https://github.com/kayousterhout","followers_url":"https://api.github.com/users/kayousterhout/followers","following_url":"https://api.github.com/users/kayousterhout/following{/other_user}","gists_url":"https://api.github.com/users/kayousterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/kayousterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayousterhout/subscriptions","organizations_url":"https://api.github.com/users/kayousterhout/orgs","repos_url":"https://api.github.com/users/kayousterhout/repos","events_url":"https://api.github.com/users/kayousterhout/events{/privacy}","received_events_url":"https://api.github.com/users/kayousterhout/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kelda/kelda/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/kelda/kelda/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/kelda/kelda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kelda/kelda/issues/1263/comments","statuses_url":"https://api.github.com/repos/kelda/kelda/statuses/24da744d2c880c1d457a2344753534e4bbc90dca","head":{"label":"aegamesi:parallel-docker","ref":"parallel-docker","sha":"24da744d2c880c1d457a2344753534e4bbc90dca","user":{"login":"aegamesi","id":552502,"avatar_url":"https://avatars2.githubusercontent.com/u/552502?v=4","gravatar_id":"","url":"https://api.github.com/users/aegamesi","html_url":"https://github.com/aegamesi","followers_url":"https://api.github.com/users/aegamesi/followers","following_url":"https://api.github.com/users/aegamesi/following{/other_user}","gists_url":"https://api.github.com/users/aegamesi/gists{/gist_id}","starred_url":"https://api.github.com/users/aegamesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aegamesi/subscriptions","organizations_url":"https://api.github.com/users/aegamesi/orgs","repos_url":"https://api.github.com/users/aegamesi/repos","events_url":"https://api.github.com/users/aegamesi/events{/privacy}","received_events_url":"https://api.github.com/users/aegamesi/received_events","type":"User","site_admin":false},"repo":{"id":103072146,"name":"kelda","full_name":"aegamesi/kelda","owner":{"login":"aegamesi","id":552502,"avatar_url":"https://avatars2.githubusercontent.com/u/552502?v=4","gravatar_id":"","url":"https://api.github.com/users/aegamesi","html_url":"https://github.com/aegamesi","followers_url":"https://api.github.com/users/aegamesi/followers","following_url":"https://api.github.com/users/aegamesi/following{/other_user}","gists_url":"https://api.github.com/users/aegamesi/gists{/gist_id}","starred_url":"https://api.github.com/users/aegamesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aegamesi/subscriptions","organizations_url":"https://api.github.com/users/aegamesi/orgs","repos_url":"https://api.github.com/users/aegamesi/repos","events_url":"https://api.github.com/users/aegamesi/events{/privacy}","received_events_url":"https://api.github.com/users/aegamesi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aegamesi/kelda","description":"An approachable way to deploy to the cloud using Node.js","fork":true,"url":"https://api.github.com/repos/aegamesi/kelda","forks_url":"https://api.github.com/repos/aegamesi/kelda/forks","keys_url":"https://api.github.com/repos/aegamesi/kelda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aegamesi/kelda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aegamesi/kelda/teams","hooks_url":"https://api.github.com/repos/aegamesi/kelda/hooks","issue_events_url":"https://api.github.com/repos/aegamesi/kelda/issues/events{/number}","events_url":"https://api.github.com/repos/aegamesi/kelda/events","assignees_url":"https://api.github.com/repos/aegamesi/kelda/assignees{/user}","branches_url":"https://api.github.com/repos/aegamesi/kelda/branches{/branch}","tags_url":"https://api.github.com/repos/aegamesi/kelda/tags","blobs_url":"https://api.github.com/repos/aegamesi/kelda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aegamesi/kelda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aegamesi/kelda/git/refs{/sha}","trees_url":"https://api.github.com/repos/aegamesi/kelda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aegamesi/kelda/statuses/{sha}","languages_url":"https://api.github.com/repos/aegamesi/kelda/languages","stargazers_url":"https://api.github.com/repos/aegamesi/kelda/stargazers","contributors_url":"https://api.github.com/repos/aegamesi/kelda/contributors","subscribers_url":"https://api.github.com/repos/aegamesi/kelda/subscribers","subscription_url":"https://api.github.com/repos/aegamesi/kelda/subscription","commits_url":"https://api.github.com/repos/aegamesi/kelda/commits{/sha}","git_commits_url":"https://api.github.com/repos/aegamesi/kelda/git/commits{/sha}","comments_url":"https://api.github.com/repos/aegamesi/kelda/comments{/number}","issue_comment_url":"https://api.github.com/repos/aegamesi/kelda/issues/comments{/number}","contents_url":"https://api.github.com/repos/aegamesi/kelda/contents/{+path}","compare_url":"https://api.github.com/repos/aegamesi/kelda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aegamesi/kelda/merges","archive_url":"https://api.github.com/repos/aegamesi/kelda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aegamesi/kelda/downloads","issues_url":"https://api.github.com/repos/aegamesi/kelda/issues{/number}","pulls_url":"https://api.github.com/repos/aegamesi/kelda/pulls{/number}","milestones_url":"https://api.github.com/repos/aegamesi/kelda/milestones{/number}","notifications_url":"https://api.github.com/repos/aegamesi/kelda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aegamesi/kelda/labels{/name}","releases_url":"https://api.github.com/repos/aegamesi/kelda/releases{/id}","deployments_url":"https://api.github.com/repos/aegamesi/kelda/deployments","created_at":"2017-09-11T00:32:18Z","updated_at":"2017-10-21T02:31:44Z","pushed_at":"2017-11-13T22:53:41Z","git_url":"git://github.com/aegamesi/kelda.git","ssh_url":"git@github.com:aegamesi/kelda.git","clone_url":"https://github.com/aegamesi/kelda.git","svn_url":"https://github.com/aegamesi/kelda","homepage":"http://quilt.io","size":22357,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kelda:master","ref":"master","sha":"8504f17a1b6987bfe5bd07f17c12e71f9bb4a6a2","user":{"login":"kelda","id":25753912,"avatar_url":"https://avatars2.githubusercontent.com/u/25753912?v=4","gravatar_id":"","url":"https://api.github.com/users/kelda","html_url":"https://github.com/kelda","followers_url":"https://api.github.com/users/kelda/followers","following_url":"https://api.github.com/users/kelda/following{/other_user}","gists_url":"https://api.github.com/users/kelda/gists{/gist_id}","starred_url":"https://api.github.com/users/kelda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelda/subscriptions","organizations_url":"https://api.github.com/users/kelda/orgs","repos_url":"https://api.github.com/users/kelda/repos","events_url":"https://api.github.com/users/kelda/events{/privacy}","received_events_url":"https://api.github.com/users/kelda/received_events","type":"Organization","site_admin":false},"repo":{"id":43390663,"name":"kelda","full_name":"kelda/kelda","owner":{"login":"kelda","id":25753912,"avatar_url":"https://avatars2.githubusercontent.com/u/25753912?v=4","gravatar_id":"","url":"https://api.github.com/users/kelda","html_url":"https://github.com/kelda","followers_url":"https://api.github.com/users/kelda/followers","following_url":"https://api.github.com/users/kelda/following{/other_user}","gists_url":"https://api.github.com/users/kelda/gists{/gist_id}","starred_url":"https://api.github.com/users/kelda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelda/subscriptions","organizations_url":"https://api.github.com/users/kelda/orgs","repos_url":"https://api.github.com/users/kelda/repos","events_url":"https://api.github.com/users/kelda/events{/privacy}","received_events_url":"https://api.github.com/users/kelda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kelda/kelda","description":"Kelda, formerly Quilt, is an approachable way to deploy to the cloud using Node.js","fork":false,"url":"https://api.github.com/repos/kelda/kelda","forks_url":"https://api.github.com/repos/kelda/kelda/forks","keys_url":"https://api.github.com/repos/kelda/kelda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelda/kelda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelda/kelda/teams","hooks_url":"https://api.github.com/repos/kelda/kelda/hooks","issue_events_url":"https://api.github.com/repos/kelda/kelda/issues/events{/number}","events_url":"https://api.github.com/repos/kelda/kelda/events","assignees_url":"https://api.github.com/repos/kelda/kelda/assignees{/user}","branches_url":"https://api.github.com/repos/kelda/kelda/branches{/branch}","tags_url":"https://api.github.com/repos/kelda/kelda/tags","blobs_url":"https://api.github.com/repos/kelda/kelda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelda/kelda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelda/kelda/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelda/kelda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelda/kelda/statuses/{sha}","languages_url":"https://api.github.com/repos/kelda/kelda/languages","stargazers_url":"https://api.github.com/repos/kelda/kelda/stargazers","contributors_url":"https://api.github.com/repos/kelda/kelda/contributors","subscribers_url":"https://api.github.com/repos/kelda/kelda/subscribers","subscription_url":"https://api.github.com/repos/kelda/kelda/subscription","commits_url":"https://api.github.com/repos/kelda/kelda/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelda/kelda/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelda/kelda/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelda/kelda/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelda/kelda/contents/{+path}","compare_url":"https://api.github.com/repos/kelda/kelda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelda/kelda/merges","archive_url":"https://api.github.com/repos/kelda/kelda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelda/kelda/downloads","issues_url":"https://api.github.com/repos/kelda/kelda/issues{/number}","pulls_url":"https://api.github.com/repos/kelda/kelda/pulls{/number}","milestones_url":"https://api.github.com/repos/kelda/kelda/milestones{/number}","notifications_url":"https://api.github.com/repos/kelda/kelda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelda/kelda/labels{/name}","releases_url":"https://api.github.com/repos/kelda/kelda/releases{/id}","deployments_url":"https://api.github.com/repos/kelda/kelda/deployments","created_at":"2015-09-29T19:52:32Z","updated_at":"2017-11-10T02:20:15Z","pushed_at":"2017-11-13T22:53:42Z","git_url":"git://github.com/kelda/kelda.git","ssh_url":"git@github.com:kelda/kelda.git","clone_url":"https://github.com/kelda/kelda.git","svn_url":"https://github.com/kelda/kelda","homepage":"http://kelda.io","size":22539,"stargazers_count":427,"watchers_count":427,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":36,"open_issues":7,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1263"},"html":{"href":"https://github.com/kelda/kelda/pull/1263"},"issue":{"href":"https://api.github.com/repos/kelda/kelda/issues/1263"},"comments":{"href":"https://api.github.com/repos/kelda/kelda/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/kelda/kelda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/kelda/kelda/statuses/24da744d2c880c1d457a2344753534e4bbc90dca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ejj"}}