{"action":"created","issue":{"url":"https://api.github.com/repos/google/protobuf/issues/1703","repository_url":"https://api.github.com/repos/google/protobuf","labels_url":"https://api.github.com/repos/google/protobuf/issues/1703/labels{/name}","comments_url":"https://api.github.com/repos/google/protobuf/issues/1703/comments","events_url":"https://api.github.com/repos/google/protobuf/issues/1703/events","html_url":"https://github.com/google/protobuf/issues/1703","id":161727336,"number":1703,"title":"javascript code generator generates unused require of import weak","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars3.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[{"id":124699531,"url":"https://api.github.com/repos/google/protobuf/labels/bug","name":"bug","color":"fc2929","default":true},{"id":314289982,"url":"https://api.github.com/repos/google/protobuf/labels/protoc","name":"protoc","color":"c7def8","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-06-22T16:24:38Z","updated_at":"2017-03-09T00:51:08Z","closed_at":"2017-03-09T00:51:08Z","body":"In our protos, we `import weak \"gogoproto/gogo.proto\";` and use it for Golang-specific options. Using this proto with `--js_out`, an unused `var gogoproto_gogo_pb = require('../../../gogoproto/gogo_pb.js');` is generated. I believe `import weak` should not result in a generated `require`.\n\ncc @haberman \n"},"comment":{"url":"https://api.github.com/repos/google/protobuf/issues/comments/285219238","html_url":"https://github.com/google/protobuf/issues/1703#issuecomment-285219238","issue_url":"https://api.github.com/repos/google/protobuf/issues/1703","id":285219238,"user":{"login":"gerben-s","id":7914762,"avatar_url":"https://avatars3.githubusercontent.com/u/7914762?v=3","gravatar_id":"","url":"https://api.github.com/users/gerben-s","html_url":"https://github.com/gerben-s","followers_url":"https://api.github.com/users/gerben-s/followers","following_url":"https://api.github.com/users/gerben-s/following{/other_user}","gists_url":"https://api.github.com/users/gerben-s/gists{/gist_id}","starred_url":"https://api.github.com/users/gerben-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerben-s/subscriptions","organizations_url":"https://api.github.com/users/gerben-s/orgs","repos_url":"https://api.github.com/users/gerben-s/repos","events_url":"https://api.github.com/users/gerben-s/events{/privacy}","received_events_url":"https://api.github.com/users/gerben-s/received_events","type":"User","site_admin":false},"created_at":"2017-03-09T00:51:08Z","updated_at":"2017-03-09T00:51:08Z","body":"import weak is not an open source option. Closing this bug"}}
{"actor":{"display_login":"gerben-s"}}