{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/112037707","pull_request_review_id":33322339,"id":112037707,"diff_hunk":"@@ -0,0 +1,190 @@\n+import org.elasticsearch.gradle.LoggedExec\n+import org.elasticsearch.gradle.VersionProperties\n+import org.apache.tools.ant.taskdefs.condition.Os\n+\n+import java.nio.charset.StandardCharsets\n+import java.nio.file.Files\n+import java.util.stream.Stream\n+\n+/*\n+ * Licensed to Elasticsearch under one or more contributor\n+ * license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright\n+ * ownership. Elasticsearch licenses this file to you under\n+ * the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+apply plugin: 'war'\n+apply plugin: 'elasticsearch.build'\n+apply plugin: 'elasticsearch.rest-test'\n+\n+final String wildflyVersion = '10.0.0.Final'\n+final String wildflyDir = \"${buildDir}/wildfly\"\n+final String wildflyInstall = \"${buildDir}/wildfly/wildfly-${wildflyVersion}\"\n+// TODO: use ephemeral ports\n+final int portOffset = 30000\n+final int managementPort = 9990 + portOffset\n+final String stopWildflyCommand = \"${wildflyInstall}/bin/jboss-cli.sh --controller=localhost:${managementPort} --connect command=:shutdown\"\n+\n+repositories {\n+    mavenCentral()\n+    // the Wildfly distribution is not available via a repository, so we fake an Ivy repository on top of the download site\n+    ivy {\n+        url \"http://download.jboss.org\"\n+        layout 'pattern', {\n+            artifact 'wildfly/[revision]/[module]-[revision].[ext]'\n+        }\n+    }\n+}\n+\n+configurations {\n+    wildfly\n+}\n+\n+dependencies {\n+    providedCompile 'javax.enterprise:cdi-api:1.2'\n+    providedCompile 'org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:1.0.0.Final'\n+    providedCompile 'org.jboss.spec.javax.ws.rs:jboss-jaxrs-api_2.0_spec:1.0.0.Final'\n+    compile ('org.jboss.resteasy:resteasy-jackson2-provider:3.0.19.Final') {\n+        exclude module: 'jackson-annotations'\n+        exclude module: 'jackson-core'\n+        exclude module: 'jackson-databind'\n+        exclude module: 'jackson-jaxrs-json-provider'\n+    }\n+    compile \"com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}\"\n+    compile \"com.fasterxml.jackson.core:jackson-core:${versions.jackson}\"\n+    compile \"com.fasterxml.jackson.core:jackson-databind:${versions.jackson}\"\n+    compile \"com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:${versions.jackson}\"\n+    compile \"com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:${versions.jackson}\"\n+    compile \"com.fasterxml.jackson.module:jackson-module-jaxb-annotations:${versions.jackson}\"\n+    compile \"org.apache.logging.log4j:log4j-api:${versions.log4j}\"\n+    compile \"org.apache.logging.log4j:log4j-core:${versions.log4j}\"\n+    compile project(path: ':client:transport', configuration: 'runtime')\n+    wildfly \"org.jboss:wildfly:${wildflyVersion}@zip\"\n+    testCompile \"org.elasticsearch.test:framework:${VersionProperties.elasticsearch}\"\n+}\n+\n+task unzipWildfly(type: Sync) {\n+    into wildflyDir\n+    from { zipTree(configurations.wildfly.singleFile) }\n+}\n+\n+task deploy(type: Copy) {\n+    dependsOn unzipWildfly, war\n+    from war\n+    into \"${wildflyInstall}/standalone/deployments\"\n+}\n+\n+task writeElasticsearchProperties {\n+    onlyIf { !Os.isFamily(Os.FAMILY_WINDOWS) }\n+    dependsOn 'integTestCluster#wait', deploy\n+    doLast {\n+        final File elasticsearchProperties =\n+                file(\"${wildflyInstall}/standalone/configuration/elasticsearch.properties\")\n+        elasticsearchProperties.write([\"transport.uri=${-> integTest.getNodes().get(0).transportUri()}\", \"cluster.name=${-> integTest.getNodes().get(0).clusterName}\"].join(\"\\n\"))\n+    }\n+}\n+\n+// the default configuration ships with IPv6 disabled but our cluster could be bound to IPv6 if the host supports it\n+task enableIPv6 {\n+    dependsOn unzipWildfly\n+    doLast {\n+        final File standaloneConf = file(\"${wildflyInstall}/bin/standalone.conf\")\n+        final List<String> lines =\n+                Files.readAllLines(standaloneConf.toPath())\n+                        .collect { line -> line.replace(\"-Djava.net.preferIPv4Stack=true\", \"-Djava.net.preferIPv4Stack=false\") }\n+        standaloneConf.write(lines.join(\"\\n\"))\n+    }\n+}\n+\n+task startWildfly {\n+    dependsOn enableIPv6, writeElasticsearchProperties\n+    doFirst {\n+        final File script = new File(project.buildDir, \"wildfly/wildfly.killer.sh\")","path":"qa/wildfly/build.gradle","position":114,"original_position":114,"commit_id":"f8a3f7219daa99ea7c6063866c47499217d3e595","original_commit_id":"f8a3f7219daa99ea7c6063866c47499217d3e595","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"body":"It doesn't *need* one because we [skip this test on Windows](https://github.com/elastic/elasticsearch/pull/24147/files#diff-b0d9c5d2992ba8499be25560312ae916R152). I do not see a good reason to jump through a lot of hoops to try to make it work on Windows. Please feel free to disagree and let me know if you think otherwise.","created_at":"2017-04-18T19:04:25Z","updated_at":"2017-04-18T19:04:25Z","html_url":"https://github.com/elastic/elasticsearch/pull/24147#discussion_r112037707","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/112037707"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/24147#discussion_r112037707"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147","id":116241026,"html_url":"https://github.com/elastic/elasticsearch/pull/24147","diff_url":"https://github.com/elastic/elasticsearch/pull/24147.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/24147.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/24147","number":24147,"state":"open","locked":false,"title":"Add Wildfly integration test","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"body":"An important use case for our users is deploying our clients inside of applications containers like Wildfly. Sometimes, we make changes that unintentionally break this use case. We need to know before we ship a release that we have broken such use cases. As Wildfly is one of the bigger application containers, this commit starts by adding an integration test that deploys an application using the transport client to Wildfly and ensures that all is well. Future work can add similar integration tests for the low-level and high-level REST clients.\r\n\r\nCloses #24050\r\n","created_at":"2017-04-18T02:47:13Z","updated_at":"2017-04-18T19:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06f91d0adfb729318d1435d816ed04f084a94407","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/24147/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/f8a3f7219daa99ea7c6063866c47499217d3e595","head":{"label":"jasontedor:wildfly","ref":"wildfly","sha":"f8a3f7219daa99ea7c6063866c47499217d3e595","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"repo":{"id":71962406,"name":"elasticsearch","full_name":"jasontedor/elasticsearch","owner":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasontedor/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jasontedor/elasticsearch","forks_url":"https://api.github.com/repos/jasontedor/elasticsearch/forks","keys_url":"https://api.github.com/repos/jasontedor/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasontedor/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasontedor/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jasontedor/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jasontedor/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jasontedor/elasticsearch/events","assignees_url":"https://api.github.com/repos/jasontedor/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jasontedor/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jasontedor/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jasontedor/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasontedor/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasontedor/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasontedor/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasontedor/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jasontedor/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jasontedor/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jasontedor/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jasontedor/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jasontedor/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jasontedor/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasontedor/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasontedor/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasontedor/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasontedor/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jasontedor/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasontedor/elasticsearch/merges","archive_url":"https://api.github.com/repos/jasontedor/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasontedor/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jasontedor/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jasontedor/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jasontedor/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jasontedor/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasontedor/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jasontedor/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jasontedor/elasticsearch/deployments","created_at":"2016-10-26T03:23:35Z","updated_at":"2016-10-26T03:24:01Z","pushed_at":"2017-04-18T11:21:16Z","git_url":"git://github.com/jasontedor/elasticsearch.git","ssh_url":"git@github.com:jasontedor/elasticsearch.git","clone_url":"https://github.com/jasontedor/elasticsearch.git","svn_url":"https://github.com/jasontedor/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":308429,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a973197503036278bdf44ebd54d7d442521d7f4d","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-04-18T18:41:41Z","pushed_at":"2017-04-18T19:04:13Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":334825,"stargazers_count":22098,"watchers_count":22098,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7355,"mirror_url":null,"open_issues_count":1343,"forks":7355,"open_issues":1343,"watchers":22098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/24147"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/24147"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/24147/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24147/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/f8a3f7219daa99ea7c6063866c47499217d3e595"}}}}
{"actor":{"display_login":"jasontedor"}}