{"action":"created","comment":{"url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/comments/106672107","pull_request_review_id":27608588,"id":106672107,"diff_hunk":"@@ -100,24 +101,57 @@ function install_node() {\n   mkdir --parents -- \"$BIN_DIR\"\n \n   # Download and extract the tar if it doesn't exist on disk.\n-  if [[ ! -d \"$INSTALL_DIR/node-v$NODE_VERSION-linux-x64\" ]]; then\n+  if [[ ! -d \"$INSTALL_DIR/$PACKAGE\" ]]; then\n     # Fail if version doesn't exist.\n-    NODE_DIST_LOOKUP=$(wget -qO - https://nodejs.org/dist/index.json | grep --null-data --only-matching --perl-regex --text \"\\\"version\\\"\\s*:\\s*\\\"v$NODE_VERSION\\\"\")\n-    [[ -z \"$NODE_DIST_LOOKUP\" ]] && >&2 echo \"Error: Couldn't find Node.js version v$NODE_VERSION. Aborting.\" && exit 1\n+    local NODE_DIST_LOOKUP","path":"nvi","position":17,"original_position":17,"commit_id":"e49d8e6a23a8d10d5c10b2e5d8195fefb3ce3e59","original_commit_id":"e49d8e6a23a8d10d5c10b2e5d8195fefb3ce3e59","user":{"login":"emiln","id":1078925,"avatar_url":"https://avatars0.githubusercontent.com/u/1078925?v=3","gravatar_id":"","url":"https://api.github.com/users/emiln","html_url":"https://github.com/emiln","followers_url":"https://api.github.com/users/emiln/followers","following_url":"https://api.github.com/users/emiln/following{/other_user}","gists_url":"https://api.github.com/users/emiln/gists{/gist_id}","starred_url":"https://api.github.com/users/emiln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emiln/subscriptions","organizations_url":"https://api.github.com/users/emiln/orgs","repos_url":"https://api.github.com/users/emiln/repos","events_url":"https://api.github.com/users/emiln/events{/privacy}","received_events_url":"https://api.github.com/users/emiln/received_events","type":"User","site_admin":false},"body":"What's the advantage in separating declaration and assignment of `NODE_DIST_LOOKUP`?","created_at":"2017-03-17T15:11:28Z","updated_at":"2017-03-17T15:11:28Z","html_url":"https://github.com/DanskSupermarked/nvi/pull/9#discussion_r106672107","pull_request_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/comments/106672107"},"html":{"href":"https://github.com/DanskSupermarked/nvi/pull/9#discussion_r106672107"},"pull_request":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9","id":111299167,"html_url":"https://github.com/DanskSupermarked/nvi/pull/9","diff_url":"https://github.com/DanskSupermarked/nvi/pull/9.diff","patch_url":"https://github.com/DanskSupermarked/nvi/pull/9.patch","issue_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/9","number":9,"state":"open","locked":false,"title":"Break down dense lines","user":{"login":"commonquail","id":603326,"avatar_url":"https://avatars2.githubusercontent.com/u/603326?v=3","gravatar_id":"","url":"https://api.github.com/users/commonquail","html_url":"https://github.com/commonquail","followers_url":"https://api.github.com/users/commonquail/followers","following_url":"https://api.github.com/users/commonquail/following{/other_user}","gists_url":"https://api.github.com/users/commonquail/gists{/gist_id}","starred_url":"https://api.github.com/users/commonquail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonquail/subscriptions","organizations_url":"https://api.github.com/users/commonquail/orgs","repos_url":"https://api.github.com/users/commonquail/repos","events_url":"https://api.github.com/users/commonquail/events{/privacy}","received_events_url":"https://api.github.com/users/commonquail/received_events","type":"User","site_admin":false},"body":"tl;dr: increase line count by 30%.\r\n\r\nOther than 80-column elitism, this change will reduce churn and help to draw attention to command options. Also, one of the error messages had an error.","created_at":"2017-03-17T15:01:03Z","updated_at":"2017-03-17T15:11:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b46ab8a4c9163eceb64b53457a1b4fc2b37f1603","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9/commits","review_comments_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9/comments","review_comment_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/9/comments","statuses_url":"https://api.github.com/repos/DanskSupermarked/nvi/statuses/e49d8e6a23a8d10d5c10b2e5d8195fefb3ce3e59","head":{"label":"DanskSupermarked:break-down-dense-lines","ref":"break-down-dense-lines","sha":"e49d8e6a23a8d10d5c10b2e5d8195fefb3ce3e59","user":{"login":"DanskSupermarked","id":5038764,"avatar_url":"https://avatars1.githubusercontent.com/u/5038764?v=3","gravatar_id":"","url":"https://api.github.com/users/DanskSupermarked","html_url":"https://github.com/DanskSupermarked","followers_url":"https://api.github.com/users/DanskSupermarked/followers","following_url":"https://api.github.com/users/DanskSupermarked/following{/other_user}","gists_url":"https://api.github.com/users/DanskSupermarked/gists{/gist_id}","starred_url":"https://api.github.com/users/DanskSupermarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanskSupermarked/subscriptions","organizations_url":"https://api.github.com/users/DanskSupermarked/orgs","repos_url":"https://api.github.com/users/DanskSupermarked/repos","events_url":"https://api.github.com/users/DanskSupermarked/events{/privacy}","received_events_url":"https://api.github.com/users/DanskSupermarked/received_events","type":"Organization","site_admin":false},"repo":{"id":84797422,"name":"nvi","full_name":"DanskSupermarked/nvi","owner":{"login":"DanskSupermarked","id":5038764,"avatar_url":"https://avatars1.githubusercontent.com/u/5038764?v=3","gravatar_id":"","url":"https://api.github.com/users/DanskSupermarked","html_url":"https://github.com/DanskSupermarked","followers_url":"https://api.github.com/users/DanskSupermarked/followers","following_url":"https://api.github.com/users/DanskSupermarked/following{/other_user}","gists_url":"https://api.github.com/users/DanskSupermarked/gists{/gist_id}","starred_url":"https://api.github.com/users/DanskSupermarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanskSupermarked/subscriptions","organizations_url":"https://api.github.com/users/DanskSupermarked/orgs","repos_url":"https://api.github.com/users/DanskSupermarked/repos","events_url":"https://api.github.com/users/DanskSupermarked/events{/privacy}","received_events_url":"https://api.github.com/users/DanskSupermarked/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DanskSupermarked/nvi","description":"Node.js Version Installer","fork":false,"url":"https://api.github.com/repos/DanskSupermarked/nvi","forks_url":"https://api.github.com/repos/DanskSupermarked/nvi/forks","keys_url":"https://api.github.com/repos/DanskSupermarked/nvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanskSupermarked/nvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanskSupermarked/nvi/teams","hooks_url":"https://api.github.com/repos/DanskSupermarked/nvi/hooks","issue_events_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/events{/number}","events_url":"https://api.github.com/repos/DanskSupermarked/nvi/events","assignees_url":"https://api.github.com/repos/DanskSupermarked/nvi/assignees{/user}","branches_url":"https://api.github.com/repos/DanskSupermarked/nvi/branches{/branch}","tags_url":"https://api.github.com/repos/DanskSupermarked/nvi/tags","blobs_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanskSupermarked/nvi/statuses/{sha}","languages_url":"https://api.github.com/repos/DanskSupermarked/nvi/languages","stargazers_url":"https://api.github.com/repos/DanskSupermarked/nvi/stargazers","contributors_url":"https://api.github.com/repos/DanskSupermarked/nvi/contributors","subscribers_url":"https://api.github.com/repos/DanskSupermarked/nvi/subscribers","subscription_url":"https://api.github.com/repos/DanskSupermarked/nvi/subscription","commits_url":"https://api.github.com/repos/DanskSupermarked/nvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanskSupermarked/nvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanskSupermarked/nvi/contents/{+path}","compare_url":"https://api.github.com/repos/DanskSupermarked/nvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanskSupermarked/nvi/merges","archive_url":"https://api.github.com/repos/DanskSupermarked/nvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanskSupermarked/nvi/downloads","issues_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues{/number}","pulls_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls{/number}","milestones_url":"https://api.github.com/repos/DanskSupermarked/nvi/milestones{/number}","notifications_url":"https://api.github.com/repos/DanskSupermarked/nvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanskSupermarked/nvi/labels{/name}","releases_url":"https://api.github.com/repos/DanskSupermarked/nvi/releases{/id}","deployments_url":"https://api.github.com/repos/DanskSupermarked/nvi/deployments","created_at":"2017-03-13T07:39:00Z","updated_at":"2017-03-15T12:12:59Z","pushed_at":"2017-03-17T15:07:34Z","git_url":"git://github.com/DanskSupermarked/nvi.git","ssh_url":"git@github.com:DanskSupermarked/nvi.git","clone_url":"https://github.com/DanskSupermarked/nvi.git","svn_url":"https://github.com/DanskSupermarked/nvi","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"DanskSupermarked:master","ref":"master","sha":"52549f2d926ff70681b6eeb111618ca7816f09fe","user":{"login":"DanskSupermarked","id":5038764,"avatar_url":"https://avatars1.githubusercontent.com/u/5038764?v=3","gravatar_id":"","url":"https://api.github.com/users/DanskSupermarked","html_url":"https://github.com/DanskSupermarked","followers_url":"https://api.github.com/users/DanskSupermarked/followers","following_url":"https://api.github.com/users/DanskSupermarked/following{/other_user}","gists_url":"https://api.github.com/users/DanskSupermarked/gists{/gist_id}","starred_url":"https://api.github.com/users/DanskSupermarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanskSupermarked/subscriptions","organizations_url":"https://api.github.com/users/DanskSupermarked/orgs","repos_url":"https://api.github.com/users/DanskSupermarked/repos","events_url":"https://api.github.com/users/DanskSupermarked/events{/privacy}","received_events_url":"https://api.github.com/users/DanskSupermarked/received_events","type":"Organization","site_admin":false},"repo":{"id":84797422,"name":"nvi","full_name":"DanskSupermarked/nvi","owner":{"login":"DanskSupermarked","id":5038764,"avatar_url":"https://avatars1.githubusercontent.com/u/5038764?v=3","gravatar_id":"","url":"https://api.github.com/users/DanskSupermarked","html_url":"https://github.com/DanskSupermarked","followers_url":"https://api.github.com/users/DanskSupermarked/followers","following_url":"https://api.github.com/users/DanskSupermarked/following{/other_user}","gists_url":"https://api.github.com/users/DanskSupermarked/gists{/gist_id}","starred_url":"https://api.github.com/users/DanskSupermarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanskSupermarked/subscriptions","organizations_url":"https://api.github.com/users/DanskSupermarked/orgs","repos_url":"https://api.github.com/users/DanskSupermarked/repos","events_url":"https://api.github.com/users/DanskSupermarked/events{/privacy}","received_events_url":"https://api.github.com/users/DanskSupermarked/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DanskSupermarked/nvi","description":"Node.js Version Installer","fork":false,"url":"https://api.github.com/repos/DanskSupermarked/nvi","forks_url":"https://api.github.com/repos/DanskSupermarked/nvi/forks","keys_url":"https://api.github.com/repos/DanskSupermarked/nvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanskSupermarked/nvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanskSupermarked/nvi/teams","hooks_url":"https://api.github.com/repos/DanskSupermarked/nvi/hooks","issue_events_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/events{/number}","events_url":"https://api.github.com/repos/DanskSupermarked/nvi/events","assignees_url":"https://api.github.com/repos/DanskSupermarked/nvi/assignees{/user}","branches_url":"https://api.github.com/repos/DanskSupermarked/nvi/branches{/branch}","tags_url":"https://api.github.com/repos/DanskSupermarked/nvi/tags","blobs_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanskSupermarked/nvi/statuses/{sha}","languages_url":"https://api.github.com/repos/DanskSupermarked/nvi/languages","stargazers_url":"https://api.github.com/repos/DanskSupermarked/nvi/stargazers","contributors_url":"https://api.github.com/repos/DanskSupermarked/nvi/contributors","subscribers_url":"https://api.github.com/repos/DanskSupermarked/nvi/subscribers","subscription_url":"https://api.github.com/repos/DanskSupermarked/nvi/subscription","commits_url":"https://api.github.com/repos/DanskSupermarked/nvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanskSupermarked/nvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanskSupermarked/nvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanskSupermarked/nvi/contents/{+path}","compare_url":"https://api.github.com/repos/DanskSupermarked/nvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanskSupermarked/nvi/merges","archive_url":"https://api.github.com/repos/DanskSupermarked/nvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanskSupermarked/nvi/downloads","issues_url":"https://api.github.com/repos/DanskSupermarked/nvi/issues{/number}","pulls_url":"https://api.github.com/repos/DanskSupermarked/nvi/pulls{/number}","milestones_url":"https://api.github.com/repos/DanskSupermarked/nvi/milestones{/number}","notifications_url":"https://api.github.com/repos/DanskSupermarked/nvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanskSupermarked/nvi/labels{/name}","releases_url":"https://api.github.com/repos/DanskSupermarked/nvi/releases{/id}","deployments_url":"https://api.github.com/repos/DanskSupermarked/nvi/deployments","created_at":"2017-03-13T07:39:00Z","updated_at":"2017-03-15T12:12:59Z","pushed_at":"2017-03-17T15:07:34Z","git_url":"git://github.com/DanskSupermarked/nvi.git","ssh_url":"git@github.com:DanskSupermarked/nvi.git","clone_url":"https://github.com/DanskSupermarked/nvi.git","svn_url":"https://github.com/DanskSupermarked/nvi","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9"},"html":{"href":"https://github.com/DanskSupermarked/nvi/pull/9"},"issue":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/issues/9"},"comments":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/DanskSupermarked/nvi/statuses/e49d8e6a23a8d10d5c10b2e5d8195fefb3ce3e59"}}}}
{"actor":{"display_login":"emiln"}}