{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/109571063","pull_request_review_id":30681096,"id":109571063,"diff_hunk":"@@ -780,33 +866,60 @@ class SliverAppBar extends StatelessWidget {\n   /// remain visible rather than being scrolled out of view.\n   final bool pinned;\n \n+  /// If [snap] and [floating] are true then the floating app bar will \"snap\"\n+  /// into view.\n+  ///\n+  /// If [snap] is true then a scroll that exposes the floating app bar will\n+  /// trigger an animation that slides the entire app bar into view. Similarly if\n+  /// a scroll dismisses the app bar, the animation will slide the app bar\n+  /// completely out of view.\n+  ///\n+  /// Snapping only applies when the app bar is floating, not when the appbar\n+  /// appears at the top of its scroll view.\n+  final bool snap;\n+\n+  @override\n+  _SliverAppBarState createState() => new _SliverAppBarState();\n+}\n+\n+class _SliverAppBarState extends State<SliverAppBar> with TickerProviderStateMixin {\n   @override\n   Widget build(BuildContext context) {\n-    final double topPadding = primary ? MediaQuery.of(context).padding.top : 0.0;\n-    final double collapsedHeight = (pinned && floating && bottom != null)\n-      ? bottom.bottomHeight + topPadding : null;\n+    final double topPadding = config.primary ? MediaQuery.of(context).padding.top : 0.0;\n+    final double collapsedHeight = (config.pinned && config.floating && config.bottom != null)\n+      ? config.bottom.bottomHeight + topPadding : null;\n+\n+    FloatingHeaderSnapConfiguration snapConfiguration;","path":"packages/flutter/lib/src/material/app_bar.dart","position":194,"original_position":194,"commit_id":"4cb1866e9a371d2d2737a65f1c9960af5e7832b9","original_commit_id":"4cb1866e9a371d2d2737a65f1c9960af5e7832b9","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars1.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"since you're stateful anyway, you might as well cache this object, creating it in initState/didUpdateConfig. That way if you get built redundantly, you don't have to rebuild it.","created_at":"2017-04-04T03:32:24Z","updated_at":"2017-04-04T03:32:24Z","html_url":"https://github.com/flutter/flutter/pull/9156#discussion_r109571063","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/9156","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/109571063"},"html":{"href":"https://github.com/flutter/flutter/pull/9156#discussion_r109571063"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9156"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/9156","id":113999510,"html_url":"https://github.com/flutter/flutter/pull/9156","diff_url":"https://github.com/flutter/flutter/pull/9156.diff","patch_url":"https://github.com/flutter/flutter/pull/9156.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/9156","number":9156,"state":"open","locked":false,"title":"Support for snapping floating app bars","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"body":"Support for floating appbars that snap open and shut after a short scroll up or down.\r\n\r\nA useful additional feature would be support for specifying that only part of the AppBar, often the integral tab bar,  was to appear when a floating (not pinned) appbar snapped open. Similarly, app bars might want to change how they're configured when they're floating.\r\n\r\n\r\n","created_at":"2017-04-03T19:02:18Z","updated_at":"2017-04-04T03:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2f253e6126bb145feb9ba6862eb22b43f70330f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/9156/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/9156/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/9156/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/4cb1866e9a371d2d2737a65f1c9960af5e7832b9","head":{"label":"HansMuller:snapping_appbars","ref":"snapping_appbars","sha":"4cb1866e9a371d2d2737a65f1c9960af5e7832b9","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"repo":{"id":45849791,"name":"flutter","full_name":"HansMuller/flutter","owner":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HansMuller/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/HansMuller/flutter","forks_url":"https://api.github.com/repos/HansMuller/flutter/forks","keys_url":"https://api.github.com/repos/HansMuller/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HansMuller/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HansMuller/flutter/teams","hooks_url":"https://api.github.com/repos/HansMuller/flutter/hooks","issue_events_url":"https://api.github.com/repos/HansMuller/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/HansMuller/flutter/events","assignees_url":"https://api.github.com/repos/HansMuller/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/HansMuller/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/HansMuller/flutter/tags","blobs_url":"https://api.github.com/repos/HansMuller/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HansMuller/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HansMuller/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HansMuller/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HansMuller/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/HansMuller/flutter/languages","stargazers_url":"https://api.github.com/repos/HansMuller/flutter/stargazers","contributors_url":"https://api.github.com/repos/HansMuller/flutter/contributors","subscribers_url":"https://api.github.com/repos/HansMuller/flutter/subscribers","subscription_url":"https://api.github.com/repos/HansMuller/flutter/subscription","commits_url":"https://api.github.com/repos/HansMuller/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HansMuller/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HansMuller/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HansMuller/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HansMuller/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/HansMuller/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HansMuller/flutter/merges","archive_url":"https://api.github.com/repos/HansMuller/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HansMuller/flutter/downloads","issues_url":"https://api.github.com/repos/HansMuller/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/HansMuller/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/HansMuller/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/HansMuller/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HansMuller/flutter/labels{/name}","releases_url":"https://api.github.com/repos/HansMuller/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/HansMuller/flutter/deployments","created_at":"2015-11-09T16:11:46Z","updated_at":"2015-11-09T16:11:50Z","pushed_at":"2017-04-03T22:13:42Z","git_url":"git://github.com/HansMuller/flutter.git","ssh_url":"git@github.com:HansMuller/flutter.git","clone_url":"https://github.com/HansMuller/flutter.git","svn_url":"https://github.com/HansMuller/flutter","homepage":"http://flutter.io","size":24533,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"58ddde88f47dd0d05e36c8ab3e77b9dcfea954ec","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-04-03T21:42:14Z","pushed_at":"2017-04-04T02:47:41Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":24244,"stargazers_count":4196,"watchers_count":4196,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":457,"mirror_url":null,"open_issues_count":1377,"forks":457,"open_issues":1377,"watchers":4196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9156"},"html":{"href":"https://github.com/flutter/flutter/pull/9156"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/9156"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/9156/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9156/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9156/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/4cb1866e9a371d2d2737a65f1c9960af5e7832b9"}}}}
{"actor":{"display_login":"Hixie"}}