{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/147332360","pull_request_review_id":72413770,"id":147332360,"diff_hunk":"@@ -0,0 +1,161 @@\n+{ config, pkgs, lib, ... }:\n+\n+with lib;\n+\n+let\n+  cfg = config.services.rtorrent;\n+in\n+{\n+  options.services.rtorrent = {\n+    enable = mkOption {\n+      type = types.bool;\n+      default = false;\n+      description = ''\n+        Whether to enable a system service for rtorrent (via tmux).\n+        Use `sudo -u rtorrent tmux attach` to manage rtorrent,\n+        and `Ctrl-B d` to detach.\n+\n+        If true, services.rtorrent.install is considered true, whatever its value.\n+      '';\n+    };\n+    install = mkOption {\n+      type = types.bool;\n+      default = false;\n+      description = ''\n+        Whether to install a user service for rtorrent (via tmux).\n+        The service must be manually started for each user with","path":"nixos/modules/services/torrent/rtorrent.nix","position":26,"original_position":26,"commit_id":"11e4b5b378e190af7859f7c0d6c6a757205ec5f1","original_commit_id":"11e4b5b378e190af7859f7c0d6c6a757205ec5f1","user":{"login":"adisbladis","id":63286,"avatar_url":"https://avatars3.githubusercontent.com/u/63286?v=4","gravatar_id":"","url":"https://api.github.com/users/adisbladis","html_url":"https://github.com/adisbladis","followers_url":"https://api.github.com/users/adisbladis/followers","following_url":"https://api.github.com/users/adisbladis/following{/other_user}","gists_url":"https://api.github.com/users/adisbladis/gists{/gist_id}","starred_url":"https://api.github.com/users/adisbladis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adisbladis/subscriptions","organizations_url":"https://api.github.com/users/adisbladis/orgs","repos_url":"https://api.github.com/users/adisbladis/repos","events_url":"https://api.github.com/users/adisbladis/events{/privacy}","received_events_url":"https://api.github.com/users/adisbladis/received_events","type":"User","site_admin":false},"body":"Duplicate text.","created_at":"2017-10-27T06:39:49Z","updated_at":"2017-10-27T06:45:53Z","html_url":"https://github.com/NixOS/nixpkgs/pull/30850#discussion_r147332360","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/147332360"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30850#discussion_r147332360"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850","id":149098342,"html_url":"https://github.com/NixOS/nixpkgs/pull/30850","diff_url":"https://github.com/NixOS/nixpkgs/pull/30850.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/30850.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30850","number":30850,"state":"open","locked":false,"title":"nixos/rtorrent: add rtorrent tmux service (user and system)","user":{"login":"csingley","id":398996,"avatar_url":"https://avatars1.githubusercontent.com/u/398996?v=4","gravatar_id":"","url":"https://api.github.com/users/csingley","html_url":"https://github.com/csingley","followers_url":"https://api.github.com/users/csingley/followers","following_url":"https://api.github.com/users/csingley/following{/other_user}","gists_url":"https://api.github.com/users/csingley/gists{/gist_id}","starred_url":"https://api.github.com/users/csingley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csingley/subscriptions","organizations_url":"https://api.github.com/users/csingley/orgs","repos_url":"https://api.github.com/users/csingley/repos","events_url":"https://api.github.com/users/csingley/events{/privacy}","received_events_url":"https://api.github.com/users/csingley/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nrtorrent systemd service units, started within a tmux session.  Both a system service and a user service are provided, somewhat following the install/enable config syntax of the emacsd expression.  Particularly handy to bring up rtorrent at boot time.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-10-27T04:23:24Z","updated_at":"2017-10-27T06:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd255cbe50d13a9ebff453dac8b6cbff53e860d1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30850/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/11e4b5b378e190af7859f7c0d6c6a757205ec5f1","head":{"label":"csingley:rtorrent","ref":"rtorrent","sha":"11e4b5b378e190af7859f7c0d6c6a757205ec5f1","user":{"login":"csingley","id":398996,"avatar_url":"https://avatars1.githubusercontent.com/u/398996?v=4","gravatar_id":"","url":"https://api.github.com/users/csingley","html_url":"https://github.com/csingley","followers_url":"https://api.github.com/users/csingley/followers","following_url":"https://api.github.com/users/csingley/following{/other_user}","gists_url":"https://api.github.com/users/csingley/gists{/gist_id}","starred_url":"https://api.github.com/users/csingley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csingley/subscriptions","organizations_url":"https://api.github.com/users/csingley/orgs","repos_url":"https://api.github.com/users/csingley/repos","events_url":"https://api.github.com/users/csingley/events{/privacy}","received_events_url":"https://api.github.com/users/csingley/received_events","type":"User","site_admin":false},"repo":{"id":104918772,"name":"nixpkgs","full_name":"csingley/nixpkgs","owner":{"login":"csingley","id":398996,"avatar_url":"https://avatars1.githubusercontent.com/u/398996?v=4","gravatar_id":"","url":"https://api.github.com/users/csingley","html_url":"https://github.com/csingley","followers_url":"https://api.github.com/users/csingley/followers","following_url":"https://api.github.com/users/csingley/following{/other_user}","gists_url":"https://api.github.com/users/csingley/gists{/gist_id}","starred_url":"https://api.github.com/users/csingley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csingley/subscriptions","organizations_url":"https://api.github.com/users/csingley/orgs","repos_url":"https://api.github.com/users/csingley/repos","events_url":"https://api.github.com/users/csingley/events{/privacy}","received_events_url":"https://api.github.com/users/csingley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csingley/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/csingley/nixpkgs","forks_url":"https://api.github.com/repos/csingley/nixpkgs/forks","keys_url":"https://api.github.com/repos/csingley/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csingley/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csingley/nixpkgs/teams","hooks_url":"https://api.github.com/repos/csingley/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/csingley/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/csingley/nixpkgs/events","assignees_url":"https://api.github.com/repos/csingley/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/csingley/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/csingley/nixpkgs/tags","blobs_url":"https://api.github.com/repos/csingley/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csingley/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csingley/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/csingley/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csingley/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/csingley/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/csingley/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/csingley/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/csingley/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/csingley/nixpkgs/subscription","commits_url":"https://api.github.com/repos/csingley/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/csingley/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/csingley/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/csingley/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/csingley/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/csingley/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csingley/nixpkgs/merges","archive_url":"https://api.github.com/repos/csingley/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csingley/nixpkgs/downloads","issues_url":"https://api.github.com/repos/csingley/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/csingley/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/csingley/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/csingley/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csingley/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/csingley/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/csingley/nixpkgs/deployments","created_at":"2017-09-26T17:46:24Z","updated_at":"2017-09-26T17:46:52Z","pushed_at":"2017-10-27T04:05:06Z","git_url":"git://github.com/csingley/nixpkgs.git","ssh_url":"git@github.com:csingley/nixpkgs.git","clone_url":"https://github.com/csingley/nixpkgs.git","svn_url":"https://github.com/csingley/nixpkgs","homepage":null,"size":621849,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"0f5eaaf1e954bca014acfa6982c5376e4d018d2a","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-10-26T17:05:12Z","pushed_at":"2017-10-27T06:42:13Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":626383,"stargazers_count":1964,"watchers_count":1964,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2304,"mirror_url":null,"archived":false,"open_issues_count":2492,"forks":2304,"open_issues":2492,"watchers":1964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30850"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30850"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30850/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30850/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/11e4b5b378e190af7859f7c0d6c6a757205ec5f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"adisbladis"}}