{"action":"opened","number":93,"pull_request":{"url":"https://api.github.com/repos/uber/jaeger-ui/pulls/93","id":146581617,"html_url":"https://github.com/uber/jaeger-ui/pull/93","diff_url":"https://github.com/uber/jaeger-ui/pull/93.diff","patch_url":"https://github.com/uber/jaeger-ui/pull/93.patch","issue_url":"https://api.github.com/repos/uber/jaeger-ui/issues/93","number":93,"state":"open","locked":false,"title":"[WIP] Keyboard shortcuts and minimap UX","user":{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"body":"**(gif TKTK)**\r\n\r\n**Issues addressed:**\r\n\r\n- [In-trace search should allow navigation between results](https://github.com/uber/jaeger-ui/issues/91) (partially addresses)\r\n- Fix #89 - [trace view - Drag and release on timeline header row zooms into respective range](https://github.com/uber/jaeger-ui/issues/89)\r\n- Fix #23 - [trace view - Navigate and zoom via minimap](https://github.com/uber/jaeger-ui/issues/23)\r\n- Fix #22 - [trace view - Pan and zoom via keyboard shortcuts](https://github.com/uber/jaeger-ui/issues/22)\r\n\r\n**Changes:**\r\n\r\n- Revamped mouse UX on trace minimap\r\n- Adjusted rendering of the trace minimap to make spans more visible in large traces\r\n- Added visuals and mouse UX for zooming to trace timeline header row\r\n- Added keyboard shortcuts:\r\n  - Scroll up, down (`w`, `s`)\r\n  - Scroll to next, previous visible span (`f`, `b`)\r\n  - Pan left, right (`a` or `left`, `d` or `right`)\r\n  - Large pan left, right (`shift+left`, `shift+right`)\r\n  - Zoom in, out (`up`, `down`)\r\n  - Large zoom in, out (`shift+up`, `shift+down`)\r\n\r\n**TODO:**\r\n\r\n- Finish adding tests\r\n- Finish comments\r\n- Update readme with shortcuts","created_at":"2017-10-14T01:53:18Z","updated_at":"2017-10-14T01:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"saminzadeh","id":6935733,"avatar_url":"https://avatars3.githubusercontent.com/u/6935733?v=4","gravatar_id":"","url":"https://api.github.com/users/saminzadeh","html_url":"https://github.com/saminzadeh","followers_url":"https://api.github.com/users/saminzadeh/followers","following_url":"https://api.github.com/users/saminzadeh/following{/other_user}","gists_url":"https://api.github.com/users/saminzadeh/gists{/gist_id}","starred_url":"https://api.github.com/users/saminzadeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saminzadeh/subscriptions","organizations_url":"https://api.github.com/users/saminzadeh/orgs","repos_url":"https://api.github.com/users/saminzadeh/repos","events_url":"https://api.github.com/users/saminzadeh/events{/privacy}","received_events_url":"https://api.github.com/users/saminzadeh/received_events","type":"User","site_admin":false},"assignees":[{"login":"saminzadeh","id":6935733,"avatar_url":"https://avatars3.githubusercontent.com/u/6935733?v=4","gravatar_id":"","url":"https://api.github.com/users/saminzadeh","html_url":"https://github.com/saminzadeh","followers_url":"https://api.github.com/users/saminzadeh/followers","following_url":"https://api.github.com/users/saminzadeh/following{/other_user}","gists_url":"https://api.github.com/users/saminzadeh/gists{/gist_id}","starred_url":"https://api.github.com/users/saminzadeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saminzadeh/subscriptions","organizations_url":"https://api.github.com/users/saminzadeh/orgs","repos_url":"https://api.github.com/users/saminzadeh/repos","events_url":"https://api.github.com/users/saminzadeh/events{/privacy}","received_events_url":"https://api.github.com/users/saminzadeh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jcorbin","id":49715,"avatar_url":"https://avatars2.githubusercontent.com/u/49715?v=4","gravatar_id":"","url":"https://api.github.com/users/jcorbin","html_url":"https://github.com/jcorbin","followers_url":"https://api.github.com/users/jcorbin/followers","following_url":"https://api.github.com/users/jcorbin/following{/other_user}","gists_url":"https://api.github.com/users/jcorbin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcorbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcorbin/subscriptions","organizations_url":"https://api.github.com/users/jcorbin/orgs","repos_url":"https://api.github.com/users/jcorbin/repos","events_url":"https://api.github.com/users/jcorbin/events{/privacy}","received_events_url":"https://api.github.com/users/jcorbin/received_events","type":"User","site_admin":false},{"login":"whistlinwilly","id":2085081,"avatar_url":"https://avatars3.githubusercontent.com/u/2085081?v=4","gravatar_id":"","url":"https://api.github.com/users/whistlinwilly","html_url":"https://github.com/whistlinwilly","followers_url":"https://api.github.com/users/whistlinwilly/followers","following_url":"https://api.github.com/users/whistlinwilly/following{/other_user}","gists_url":"https://api.github.com/users/whistlinwilly/gists{/gist_id}","starred_url":"https://api.github.com/users/whistlinwilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whistlinwilly/subscriptions","organizations_url":"https://api.github.com/users/whistlinwilly/orgs","repos_url":"https://api.github.com/users/whistlinwilly/repos","events_url":"https://api.github.com/users/whistlinwilly/events{/privacy}","received_events_url":"https://api.github.com/users/whistlinwilly/received_events","type":"User","site_admin":false},{"login":"saminzadeh","id":6935733,"avatar_url":"https://avatars3.githubusercontent.com/u/6935733?v=4","gravatar_id":"","url":"https://api.github.com/users/saminzadeh","html_url":"https://github.com/saminzadeh","followers_url":"https://api.github.com/users/saminzadeh/followers","following_url":"https://api.github.com/users/saminzadeh/following{/other_user}","gists_url":"https://api.github.com/users/saminzadeh/gists{/gist_id}","starred_url":"https://api.github.com/users/saminzadeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saminzadeh/subscriptions","organizations_url":"https://api.github.com/users/saminzadeh/orgs","repos_url":"https://api.github.com/users/saminzadeh/repos","events_url":"https://api.github.com/users/saminzadeh/events{/privacy}","received_events_url":"https://api.github.com/users/saminzadeh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uber/jaeger-ui/pulls/93/commits","review_comments_url":"https://api.github.com/repos/uber/jaeger-ui/pulls/93/comments","review_comment_url":"https://api.github.com/repos/uber/jaeger-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/jaeger-ui/issues/93/comments","statuses_url":"https://api.github.com/repos/uber/jaeger-ui/statuses/6aad7ed7ba346d3c79ce9098cd8d81fac0b53ec3","head":{"label":"uber:issue-23-trace-minimap-navigate-zoom","ref":"issue-23-trace-minimap-navigate-zoom","sha":"6aad7ed7ba346d3c79ce9098cd8d81fac0b53ec3","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"name":"jaeger-ui","full_name":"uber/jaeger-ui","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/uber/jaeger-ui","forks_url":"https://api.github.com/repos/uber/jaeger-ui/forks","keys_url":"https://api.github.com/repos/uber/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-ui/events","assignees_url":"https://api.github.com/repos/uber/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-ui/merges","archive_url":"https://api.github.com/repos/uber/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2017-10-13T02:06:24Z","pushed_at":"2017-10-11T19:23:20Z","git_url":"git://github.com/uber/jaeger-ui.git","ssh_url":"git@github.com:uber/jaeger-ui.git","clone_url":"https://github.com/uber/jaeger-ui.git","svn_url":"https://github.com/uber/jaeger-ui","homepage":"https://uber.github.io/jaeger/","size":758,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":26,"forks":10,"open_issues":26,"watchers":53,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"61cd543924ce2f56b3257bec86905e626a1ba44a","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"name":"jaeger-ui","full_name":"uber/jaeger-ui","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/uber/jaeger-ui","forks_url":"https://api.github.com/repos/uber/jaeger-ui/forks","keys_url":"https://api.github.com/repos/uber/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-ui/events","assignees_url":"https://api.github.com/repos/uber/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-ui/merges","archive_url":"https://api.github.com/repos/uber/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2017-10-13T02:06:24Z","pushed_at":"2017-10-11T19:23:20Z","git_url":"git://github.com/uber/jaeger-ui.git","ssh_url":"git@github.com:uber/jaeger-ui.git","clone_url":"https://github.com/uber/jaeger-ui.git","svn_url":"https://github.com/uber/jaeger-ui","homepage":"https://uber.github.io/jaeger/","size":758,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":26,"forks":10,"open_issues":26,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-ui/pulls/93"},"html":{"href":"https://github.com/uber/jaeger-ui/pull/93"},"issue":{"href":"https://api.github.com/repos/uber/jaeger-ui/issues/93"},"comments":{"href":"https://api.github.com/repos/uber/jaeger-ui/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/jaeger-ui/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/jaeger-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/jaeger-ui/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/uber/jaeger-ui/statuses/6aad7ed7ba346d3c79ce9098cd8d81fac0b53ec3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":16,"additions":2853,"deletions":1058,"changed_files":43}}
{"actor":{"display_login":"tiffon"}}