{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/96660272","pull_request_review_id":17247938,"id":96660272,"diff_hunk":"@@ -26,10 +26,16 @@ message TrillianApiStatus {\n }\n \n message LogLeaf {\n+    // merkle_leaf_hash is over leaf data and optional extra_data.\n     bytes merkle_leaf_hash = 1;\n+    // leaf_value contains arbitray data.\n     bytes leaf_value = 2;\n+    // extra_data is optional.","path":"trillian_api.proto","position":8,"original_position":8,"commit_id":"69d3d5030b3611c9bba11ee37c760346561ef97d","original_commit_id":"69d3d5030b3611c9bba11ee37c760346561ef97d","user":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars.githubusercontent.com/u/12500300?v=3","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"body":"What distinguishes leaf_value and extra_data? Could you add some examples? Are both end-user/personality supplied, or is extra_data recorded for internal Trillian purposes?","created_at":"2017-01-18T15:30:37Z","updated_at":"2017-01-18T15:31:50Z","html_url":"https://github.com/google/trillian/pull/299#discussion_r96660272","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/299","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/96660272"},"html":{"href":"https://github.com/google/trillian/pull/299#discussion_r96660272"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/299","id":102077982,"html_url":"https://github.com/google/trillian/pull/299","diff_url":"https://github.com/google/trillian/pull/299.diff","patch_url":"https://github.com/google/trillian/pull/299.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/299","number":299,"state":"open","locked":false,"title":"Document LogLeaf","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-18T14:40:17Z","updated_at":"2017-01-18T15:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fa7b68c64c022a19de3f0b2771515a1075de949","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/299/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/299/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/299/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/69d3d5030b3611c9bba11ee37c760346561ef97d","head":{"label":"gdbelvin:doc","ref":"doc","sha":"69d3d5030b3611c9bba11ee37c760346561ef97d","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79220930,"name":"trillian","full_name":"gdbelvin/trillian","owner":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/gdbelvin/trillian","forks_url":"https://api.github.com/repos/gdbelvin/trillian/forks","keys_url":"https://api.github.com/repos/gdbelvin/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/trillian/teams","hooks_url":"https://api.github.com/repos/gdbelvin/trillian/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/trillian/events","assignees_url":"https://api.github.com/repos/gdbelvin/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/trillian/tags","blobs_url":"https://api.github.com/repos/gdbelvin/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/trillian/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/trillian/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/trillian/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/trillian/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/trillian/subscription","commits_url":"https://api.github.com/repos/gdbelvin/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/trillian/merges","archive_url":"https://api.github.com/repos/gdbelvin/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/trillian/downloads","issues_url":"https://api.github.com/repos/gdbelvin/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/trillian/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/trillian/deployments","created_at":"2017-01-17T11:27:31Z","updated_at":"2017-01-17T11:27:34Z","pushed_at":"2017-01-18T14:40:05Z","git_url":"git://github.com/gdbelvin/trillian.git","ssh_url":"git@github.com:gdbelvin/trillian.git","clone_url":"https://github.com/gdbelvin/trillian.git","svn_url":"https://github.com/gdbelvin/trillian","homepage":null,"size":1842,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"137a1c686e4d11f9e7f6dce7f6209d8d33bc38e7","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":null,"fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-01-18T08:02:50Z","pushed_at":"2017-01-18T15:23:29Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":null,"size":1835,"stargazers_count":154,"watchers_count":154,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":18,"forks":25,"open_issues":18,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/299"},"html":{"href":"https://github.com/google/trillian/pull/299"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/299"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/69d3d5030b3611c9bba11ee37c760346561ef97d"}}}}
{"actor":{"display_login":"codingllama"}}