{"action":"created","comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/145186495","pull_request_review_id":69949139,"id":145186495,"diff_hunk":"@@ -98,46 +98,56 @@ class RandomGen3Teams extends RandomGen4Teams {\n \t\t\t\tcase 'focuspunch':\n \t\t\t\t\tif (!hasMove['substitute'] || counter.damagingMoves.length < 2) rejected = true;\n \t\t\t\t\tbreak;\n+\t\t\t\tcase 'meanlook': case 'spiderweb':\n+\t\t\t\t\tif (!hasMove['batonpass'] && !hasMove['perishsong']) rejected = true;\n+\t\t\t\t\tbreak;\n \t\t\t\tcase 'perishsong':\n \t\t\t\t\tif (!hasMove['meanlook']) rejected = true;\n \t\t\t\t\tbreak;\n-\t\t\t\tcase 'rest': {\n+\t\t\t\tcase 'rest':\n \t\t\t\t\tif (movePool.includes('sleeptalk')) rejected = true;\n \t\t\t\t\tbreak;\n-\t\t\t\t}\n \t\t\t\tcase 'sleeptalk':\n \t\t\t\t\tif (!hasMove['rest']) rejected = true;\n \t\t\t\t\tif (movePool.length > 1) {\n \t\t\t\t\t\tlet rest = movePool.indexOf('rest');\n \t\t\t\t\t\tif (rest >= 0) this.fastPop(movePool, rest);\n \t\t\t\t\t}\n \t\t\t\t\tbreak;\n+\t\t\t\tcase 'sunnyday':\n+\t\t\t\t\tif (!hasMove['solarbeam']) rejected = true;\n+\t\t\t\t\tbreak;\n \n \t\t\t\t// Set up once and only if we have the moves for it\n \t\t\t\tcase 'bellydrum': case 'bulkup': case 'curse': case 'dragondance': case 'swordsdance':\n \t\t\t\t\tif (counter.setupType !== 'Physical' || counter['physicalsetup'] > 1) rejected = true;\n \t\t\t\t\tif (counter.Physical + counter['physicalpool'] < 2 && !hasMove['batonpass'] && (!hasMove['rest'] || !hasMove['sleeptalk'])) rejected = true;\n \t\t\t\t\tisSetup = true;\n \t\t\t\t\tbreak;\n-\t\t\t\tcase 'calmmind': case 'growth': case 'nastyplot': case 'tailglow':\n+\t\t\t\tcase 'calmmind': case 'growth': case 'tailglow':\n \t\t\t\t\tif (counter.setupType !== 'Special' || counter['specialsetup'] > 1) rejected = true;\n \t\t\t\t\tif (counter.Special + counter['specialpool'] < 2 && !hasMove['batonpass'] && (!hasMove['rest'] || !hasMove['sleeptalk'])) rejected = true;\n \t\t\t\t\tisSetup = true;\n \t\t\t\t\tbreak;\n-\t\t\t\tcase 'agility': case 'rockpolish':\n+\t\t\t\tcase 'agility':\n \t\t\t\t\tif (counter.damagingMoves.length < 2 && !hasMove['batonpass']) rejected = true;\n \t\t\t\t\tif (hasMove['rest'] && hasMove['sleeptalk']) rejected = true;\n \t\t\t\t\tif (!counter.setupType) isSetup = true;\n \t\t\t\t\tbreak;\n-\t\t\t\tcase 'flail':\n+\t\t\t\tcase 'endeavor': case 'flail': case 'reversal':\n \t\t\t\t\tif (!hasMove['substitute'] && !hasMove['endure']) rejected = true;\n \t\t\t\t\tbreak;\n \n \t\t\t\t// Bad after setup\n-\t\t\t\tcase 'explosion':\n+\t\t\t\tcase 'destinybond': case 'explosion': case 'memento': case 'selfdestruct':\n \t\t\t\t\tif (counter.setupType || !!counter['recovery'] || hasMove['rest']) rejected = true;\n+\t\t\t\t\tif (moveid === 'destinybond' && (hasMove['explosion'] || hasMove['selfdestruct'])) rejected = true;\n+\t\t\t\t\tif (moveid === 'memento' && hasMove['destinybond']) rejected = true;\n \t\t\t\t\tbreak;\n-\t\t\t\tcase 'foresight': case 'protect': case 'roar':\n+\t\t\t\tcase 'protect':\n+\t\t\t\t\tif (!hasAbility['Speed Boost'] && !hasMove['perishsong'] && !hasMove['toxic'] && !hasMove['wish']) rejected = true;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase 'roar': case 'whirlwind':\n \t\t\t\t\tif (counter.setupType && !hasAbility['Speed Boost']) rejected = true;","path":"mods/gen3/random-teams.js","position":61,"original_position":61,"commit_id":"3b39a17d0a019d68c2888d168e55f949c8105193","original_commit_id":"3b39a17d0a019d68c2888d168e55f949c8105193","user":{"login":"Honko","id":1281356,"avatar_url":"https://avatars2.githubusercontent.com/u/1281356?v=4","gravatar_id":"","url":"https://api.github.com/users/Honko","html_url":"https://github.com/Honko","followers_url":"https://api.github.com/users/Honko/followers","following_url":"https://api.github.com/users/Honko/following{/other_user}","gists_url":"https://api.github.com/users/Honko/gists{/gist_id}","starred_url":"https://api.github.com/users/Honko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Honko/subscriptions","organizations_url":"https://api.github.com/users/Honko/orgs","repos_url":"https://api.github.com/users/Honko/repos","events_url":"https://api.github.com/users/Honko/events{/privacy}","received_events_url":"https://api.github.com/users/Honko/received_events","type":"User","site_admin":false},"body":"Good catch, I missed taking that out when I split Protect into its own check.","created_at":"2017-10-17T16:40:15Z","updated_at":"2017-10-17T16:40:15Z","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/4055#discussion_r145186495","pull_request_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/145186495"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/4055#discussion_r145186495"},"pull_request":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055"}},"in_reply_to_id":145101838},"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055","id":146618076,"html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/4055","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/4055.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/4055.patch","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/4055","number":4055,"state":"open","locked":false,"title":"Gen 3 Randbat improvements","user":{"login":"Honko","id":1281356,"avatar_url":"https://avatars2.githubusercontent.com/u/1281356?v=4","gravatar_id":"","url":"https://api.github.com/users/Honko","html_url":"https://github.com/Honko","followers_url":"https://api.github.com/users/Honko/followers","following_url":"https://api.github.com/users/Honko/following{/other_user}","gists_url":"https://api.github.com/users/Honko/gists{/gist_id}","starred_url":"https://api.github.com/users/Honko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Honko/subscriptions","organizations_url":"https://api.github.com/users/Honko/orgs","repos_url":"https://api.github.com/users/Honko/repos","events_url":"https://api.github.com/users/Honko/events{/privacy}","received_events_url":"https://api.github.com/users/Honko/received_events","type":"User","site_admin":false},"body":"* Reject Mean Look, Spider Web, and Protect without moves to support them\r\n* Reject Sunny Day without Solar Beam and vice versa\r\n* Reject Reversal/Endeavor without Sub/Endure\r\n* Reject multiple self-KO moves on the same set\r\n* Reject Whirlwind with setup\r\n* Reject Endure with Substitute\r\n* Reject redundant Grass- and Fighting-type moves\r\n* Remove checks for moves that don't exist or are irrelevant in ADV\r\n* Fix bug that sometimes caused Castform to have its weather move twice","created_at":"2017-10-14T19:40:21Z","updated_at":"2017-10-17T16:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fee0115445487b131483d8a6840abcc12eeee71","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055/commits","review_comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055/comments","review_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/4055/comments","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/3b39a17d0a019d68c2888d168e55f949c8105193","head":{"label":"Honko:patch-10","ref":"patch-10","sha":"3b39a17d0a019d68c2888d168e55f949c8105193","user":{"login":"Honko","id":1281356,"avatar_url":"https://avatars2.githubusercontent.com/u/1281356?v=4","gravatar_id":"","url":"https://api.github.com/users/Honko","html_url":"https://github.com/Honko","followers_url":"https://api.github.com/users/Honko/followers","following_url":"https://api.github.com/users/Honko/following{/other_user}","gists_url":"https://api.github.com/users/Honko/gists{/gist_id}","starred_url":"https://api.github.com/users/Honko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Honko/subscriptions","organizations_url":"https://api.github.com/users/Honko/orgs","repos_url":"https://api.github.com/users/Honko/repos","events_url":"https://api.github.com/users/Honko/events{/privacy}","received_events_url":"https://api.github.com/users/Honko/received_events","type":"User","site_admin":false},"repo":{"id":97082883,"name":"Pokemon-Showdown","full_name":"Honko/Pokemon-Showdown","owner":{"login":"Honko","id":1281356,"avatar_url":"https://avatars2.githubusercontent.com/u/1281356?v=4","gravatar_id":"","url":"https://api.github.com/users/Honko","html_url":"https://github.com/Honko","followers_url":"https://api.github.com/users/Honko/followers","following_url":"https://api.github.com/users/Honko/following{/other_user}","gists_url":"https://api.github.com/users/Honko/gists{/gist_id}","starred_url":"https://api.github.com/users/Honko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Honko/subscriptions","organizations_url":"https://api.github.com/users/Honko/orgs","repos_url":"https://api.github.com/users/Honko/repos","events_url":"https://api.github.com/users/Honko/events{/privacy}","received_events_url":"https://api.github.com/users/Honko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Honko/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/Honko/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Honko/Pokemon-Showdown/deployments","created_at":"2017-07-13T05:20:11Z","updated_at":"2017-07-13T05:20:15Z","pushed_at":"2017-10-14T19:02:24Z","git_url":"git://github.com/Honko/Pokemon-Showdown.git","ssh_url":"git@github.com:Honko/Pokemon-Showdown.git","clone_url":"https://github.com/Honko/Pokemon-Showdown.git","svn_url":"https://github.com/Honko/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":53894,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zarel:master","ref":"master","sha":"c0d65d488b6dbc447dff4bd92569820a6986bf48","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars3.githubusercontent.com/u/551184?v=4","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"repo":{"id":3038446,"name":"Pokemon-Showdown","full_name":"Zarel/Pokemon-Showdown","owner":{"login":"Zarel","id":551184,"avatar_url":"https://avatars3.githubusercontent.com/u/551184?v=4","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarel/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":false,"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/deployments","created_at":"2011-12-23T04:52:33Z","updated_at":"2017-10-15T09:23:26Z","pushed_at":"2017-10-17T13:29:43Z","git_url":"git://github.com/Zarel/Pokemon-Showdown.git","ssh_url":"git@github.com:Zarel/Pokemon-Showdown.git","clone_url":"https://github.com/Zarel/Pokemon-Showdown.git","svn_url":"https://github.com/Zarel/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":53806,"stargazers_count":1252,"watchers_count":1252,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1215,"mirror_url":null,"open_issues_count":59,"forks":1215,"open_issues":59,"watchers":1252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/4055"},"issue":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/4055"},"comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/4055/comments"},"review_comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055/comments"},"review_comment":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/4055/commits"},"statuses":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/3b39a17d0a019d68c2888d168e55f949c8105193"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Honko"}}