{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Security/issues/1265","repository_url":"https://api.github.com/repos/aspnet/Security","labels_url":"https://api.github.com/repos/aspnet/Security/issues/1265/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Security/issues/1265/comments","events_url":"https://api.github.com/repos/aspnet/Security/issues/1265/events","html_url":"https://github.com/aspnet/Security/issues/1265","id":236183014,"number":1265,"title":"Authentication failures are not properly logged","user":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars1.githubusercontent.com/u/6998306?v=4","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"labels":[{"id":93052241,"url":"https://api.github.com/repos/aspnet/Security/labels/3%20-%20Done","name":"3 - Done","color":"CCCCCC","default":false},{"id":85920071,"url":"https://api.github.com/repos/aspnet/Security/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"muratg","id":1808428,"avatar_url":"https://avatars3.githubusercontent.com/u/1808428?v=4","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false},"assignees":[{"login":"muratg","id":1808428,"avatar_url":"https://avatars3.githubusercontent.com/u/1808428?v=4","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/Security/milestones/24","html_url":"https://github.com/aspnet/Security/milestone/24","labels_url":"https://api.github.com/repos/aspnet/Security/milestones/24/labels","id":2530126,"number":24,"title":"2.0.0","description":"","creator":{"login":"Eilon","id":202643,"avatar_url":"https://avatars3.githubusercontent.com/u/202643?v=4","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":22,"state":"open","created_at":"2017-05-18T21:42:09Z","updated_at":"2017-07-19T17:25:41Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-06-15T13:00:18Z","updated_at":"2017-07-20T21:52:33Z","closed_at":"2017-07-04T01:04:45Z","body":"https://github.com/aspnet-contrib/AspNet.Security.OAuth.Extensions/issues/73#issuecomment-308709255\r\n\r\nThe fix is simple: `AuthenticationHandler.AuthenticateAsync()` should be updated to log the authentication failure when it's not null: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication/AuthenticationHandler.cs#L133\r\n\r\nNote: the issue exists in both 1.0/1.1 and 2.0 but it's more terrible in 2.0 because it also manifests when enabling automatic authentication (1.0/1.1 correctly log the failure in this case: https://github.com/aspnet/Security/blob/1.0.0/src/Microsoft.AspNetCore.Authentication/AuthenticationHandler.cs#L107)\r\n\r\n/cc @HaoK "},"comment":{"url":"https://api.github.com/repos/aspnet/Security/issues/comments/316840535","html_url":"https://github.com/aspnet/Security/issues/1265#issuecomment-316840535","issue_url":"https://api.github.com/repos/aspnet/Security/issues/1265","id":316840535,"user":{"login":"NinoFloris","id":4218809,"avatar_url":"https://avatars0.githubusercontent.com/u/4218809?v=4","gravatar_id":"","url":"https://api.github.com/users/NinoFloris","html_url":"https://github.com/NinoFloris","followers_url":"https://api.github.com/users/NinoFloris/followers","following_url":"https://api.github.com/users/NinoFloris/following{/other_user}","gists_url":"https://api.github.com/users/NinoFloris/gists{/gist_id}","starred_url":"https://api.github.com/users/NinoFloris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NinoFloris/subscriptions","organizations_url":"https://api.github.com/users/NinoFloris/orgs","repos_url":"https://api.github.com/users/NinoFloris/repos","events_url":"https://api.github.com/users/NinoFloris/events{/privacy}","received_events_url":"https://api.github.com/users/NinoFloris/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T21:52:33Z","updated_at":"2017-07-20T21:52:33Z","body":"Ah thanks @PinpointTownes I was just scratching my head for an hour why I wouldn't get a valid ClaimsIdentity, all along our auth handler was returning failures... Great to see this fixed!"}}
{"actor":{"display_login":"NinoFloris"}}