{"push_id":1714921004,"size":1,"distinct_size":1,"ref":"refs/heads/self_links_want_to_be_objects_too","head":"a3c4eb8c7c785a70e3b00e7d8779ed09068bf7f7","before":"1025f3c8ded8b8b1ab2894f781a45ef45388bcf4","commits":[{"sha":"a3c4eb8c7c785a70e3b00e7d8779ed09068bf7f7","author":{"name":"Tadas Tamosauskas","email":"ba322e4eb52029db729be9c8c2cb3a7ebdc3241a@thetrainline.com"},"message":"Allow 'links.self' as objects in the schema\n\nThe spec says that a link can be either a string or an\nobject: http://jsonapi.org/format/#document-links\n\nHowever the schema enforces that `self` links must be\nstrings: https://github.com/json-api/json-api/blob/509ee949c621cee5683c959d4268386e1a592b83/schema#L158-L162\n\nIt is also a bit odd that the properties and descriptions in\n`definitions/links` seems to be relationship-specific: https://github.com/json-api/json-api/blob/509ee949c621cee5683c959d4268386e1a592b83/schema#L154-L168 ,\nbut this definition is referenced from resource: https://github.com/json-api/json-api/blob/509ee949c621cee5683c959d4268386e1a592b83/schema#L144-L146\nand top level: https://github.com/json-api/json-api/blob/509ee949c621cee5683c959d4268386e1a592b83/schema#L38-L43\nlink objects.\n\n@steveklabnik has confirmed in GH issue #1159 that the spec is the\nsource of truth and the schema might lag behind.\n\nThis change allows the self link to be an object as well as a string. It\nalso makes sure that each property in the `links` object is a\n`definitions/link` (as per spec).\nIt also separates a relationshipLinks definition that seems to carry\nsome relationship-specific descriptions.\n\nFixes #1159","distinct":true,"url":"https://api.github.com/repos/tadast/json-api/commits/a3c4eb8c7c785a70e3b00e7d8779ed09068bf7f7"}]}
{"actor":{"display_login":"tadast"}}