{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/1141","repository_url":"https://api.github.com/repos/apollographql/apollo-client","labels_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1141/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1141/comments","events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1141/events","html_url":"https://github.com/apollographql/apollo-client/issues/1141","id":199232093,"number":1141,"title":"Discussion/feature request: custom error handling","user":{"login":"dallonf","id":346300,"avatar_url":"https://avatars.githubusercontent.com/u/346300?v=3","gravatar_id":"","url":"https://api.github.com/users/dallonf","html_url":"https://github.com/dallonf","followers_url":"https://api.github.com/users/dallonf/followers","following_url":"https://api.github.com/users/dallonf/following{/other_user}","gists_url":"https://api.github.com/users/dallonf/gists{/gist_id}","starred_url":"https://api.github.com/users/dallonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dallonf/subscriptions","organizations_url":"https://api.github.com/users/dallonf/orgs","repos_url":"https://api.github.com/users/dallonf/repos","events_url":"https://api.github.com/users/dallonf/events{/privacy}","received_events_url":"https://api.github.com/users/dallonf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-01-06T16:24:56Z","updated_at":"2017-02-27T10:18:45Z","closed_at":null,"body":"For my current project, we use `apollo-react` and [Sentry](https://sentry.io/) (for error reporting and tracking).\r\n\r\nNow, errors in render functions are [historically something that React doesn't handle very elegantly](https://github.com/facebook/react/issues/2461), but usually they at least bubble up as an uncaught exception or unhandled promise rejection, and Sentry can detect this and report them.\r\n\r\nHowever, when a render error happens in response to an update from Apollo, the error gets logged by `console.error`, here: https://github.com/apollostack/apollo-client/blob/v0.5.25/src/core/QueryManager.ts#L375\r\n\r\nIn order to report these errors to Sentry, I actually have to monkeypatch `console.error`, which I'm not really pleased with as a solution.\r\n\r\nI don't know what a better solution would be - probably raising them as an uncaught exception. Or if this is happening in promise-land, I'd also be fine with a promise rejection, as we're using core-js promises and those do a pretty good job of reporting unhandled rejections, but I suspect that's not the case for everyone.  Maybe the Apollo client should be configurable as to where these errors go?"},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments/282680981","html_url":"https://github.com/apollographql/apollo-client/issues/1141#issuecomment-282680981","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1141","id":282680981,"user":{"login":"fischerman","id":6820657,"avatar_url":"https://avatars.githubusercontent.com/u/6820657?v=3","gravatar_id":"","url":"https://api.github.com/users/fischerman","html_url":"https://github.com/fischerman","followers_url":"https://api.github.com/users/fischerman/followers","following_url":"https://api.github.com/users/fischerman/following{/other_user}","gists_url":"https://api.github.com/users/fischerman/gists{/gist_id}","starred_url":"https://api.github.com/users/fischerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fischerman/subscriptions","organizations_url":"https://api.github.com/users/fischerman/orgs","repos_url":"https://api.github.com/users/fischerman/repos","events_url":"https://api.github.com/users/fischerman/events{/privacy}","received_events_url":"https://api.github.com/users/fischerman/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T10:18:45Z","updated_at":"2017-02-27T10:18:45Z","body":"Any progress on this?"}}
{"actor":{"display_login":"fischerman"}}