{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/128467440","pull_request_review_id":51148352,"id":128467440,"diff_hunk":"@@ -224,6 +224,15 @@\n         &:focus {\n             outline: none;\n         }\n+\n+        div[class^=\"hidden\"] {","path":"lms/static/sass/views/_login-register.scss","position":5,"original_position":5,"commit_id":"dbe2f383235bf7b2391acfd426d585e8f05b969a","original_commit_id":"dbe2f383235bf7b2391acfd426d585e8f05b969a","user":{"login":"douglashall","id":224634,"avatar_url":"https://avatars2.githubusercontent.com/u/224634?v=4","gravatar_id":"","url":"https://api.github.com/users/douglashall","html_url":"https://github.com/douglashall","followers_url":"https://api.github.com/users/douglashall/followers","following_url":"https://api.github.com/users/douglashall/following{/other_user}","gists_url":"https://api.github.com/users/douglashall/gists{/gist_id}","starred_url":"https://api.github.com/users/douglashall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglashall/subscriptions","organizations_url":"https://api.github.com/users/douglashall/orgs","repos_url":"https://api.github.com/users/douglashall/repos","events_url":"https://api.github.com/users/douglashall/events{/privacy}","received_events_url":"https://api.github.com/users/douglashall/received_events","type":"User","site_admin":false},"body":"I think the `class` attribute values on those divs look like `form-field hidden-username`. You could use `div[class*=\"hidden-\"]` instead.","created_at":"2017-07-20T09:32:29Z","updated_at":"2017-07-20T09:32:29Z","html_url":"https://github.com/edx/edx-platform/pull/15608#discussion_r128467440","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/15608","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/128467440"},"html":{"href":"https://github.com/edx/edx-platform/pull/15608#discussion_r128467440"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15608"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/15608","id":131364912,"html_url":"https://github.com/edx/edx-platform/pull/15608","diff_url":"https://github.com/edx/edx-platform/pull/15608.diff","patch_url":"https://github.com/edx/edx-platform/pull/15608.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/15608","number":15608,"state":"open","locked":false,"title":"WIP ENT-550 Display only TOS for enterprise's configured to skip registration","user":{"login":"brittneyexline","id":524809,"avatar_url":"https://avatars1.githubusercontent.com/u/524809?v=4","gravatar_id":"","url":"https://api.github.com/users/brittneyexline","html_url":"https://github.com/brittneyexline","followers_url":"https://api.github.com/users/brittneyexline/followers","following_url":"https://api.github.com/users/brittneyexline/following{/other_user}","gists_url":"https://api.github.com/users/brittneyexline/gists{/gist_id}","starred_url":"https://api.github.com/users/brittneyexline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittneyexline/subscriptions","organizations_url":"https://api.github.com/users/brittneyexline/orgs","repos_url":"https://api.github.com/users/brittneyexline/repos","events_url":"https://api.github.com/users/brittneyexline/events{/privacy}","received_events_url":"https://api.github.com/users/brittneyexline/received_events","type":"User","site_admin":false},"body":"We have recently discovered that for any SSO Provider configured to skip\r\nthe registration form, we were auto checking the terms of service box,\r\nwhich is a legal faux pas. Since a customer is planning to launch imminently and\r\nis depending on this feature, we need to remedy this situation for enterprises\r\nwhose SSO Provider is configured to skip registration.\r\n\r\nThis PR hides all of the registration fields except TOS for this scenario\r\nand disables the autoSubmit functionality that typically happens when skipping\r\nregistration.\r\n\r\n**Testing Instructions**\r\n\r\nSandbox Link: https://business.sandbox.edx.org/enterprise/2b5a2956-7746-4fc9-9587-bc887ba45973/course/course-v1:edX+DemoX+Demo_Course/enroll/\r\n\r\nNote that normal registration flow should not be impacted - the scope of this change is limited to TPA Providers linked to an enterprise and with skip_registration_form turned on.\r\n\r\n1. Go to the sandbox link, authenticate with the SSO Provider (TestShib).\r\n2. Arrive at the registration page. Note that there is a welcome message for the user, and that the password field and all fields that got passed via the SAML handshake with the IdP do not appear in the form. Terms of Service and fields that did not get data passed should display for the user.\r\n3. Fill out the form fields that are available, and click submit. If a field is missing or invalid that you have access to change, it should behave as normal. None of the hidden fields should error :crossed_fingers: \r\n4. The rest of the flow should behave as expected.\r\n\r\n**Caveats**\r\nIn Production, if the IdP is properly configured, only the TOS box should appear. However, @itsjeyd and @haikuginger were able to fake this data from TestShib somehow for testing purposes when we enabled population of the country field.\r\n\r\nWe are not addressing the possibility of the hidden fields erroring yet. If that becomes obviously prohibitive during testing, we may need to address that sooner rather than later.","created_at":"2017-07-19T16:27:42Z","updated_at":"2017-07-20T09:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d29bc6507b07f398623dee8369cb00e83a3c42dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattdrayer","id":4520595,"avatar_url":"https://avatars0.githubusercontent.com/u/4520595?v=4","gravatar_id":"","url":"https://api.github.com/users/mattdrayer","html_url":"https://github.com/mattdrayer","followers_url":"https://api.github.com/users/mattdrayer/followers","following_url":"https://api.github.com/users/mattdrayer/following{/other_user}","gists_url":"https://api.github.com/users/mattdrayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdrayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdrayer/subscriptions","organizations_url":"https://api.github.com/users/mattdrayer/orgs","repos_url":"https://api.github.com/users/mattdrayer/repos","events_url":"https://api.github.com/users/mattdrayer/events{/privacy}","received_events_url":"https://api.github.com/users/mattdrayer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/15608/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/15608/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/15608/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/dbe2f383235bf7b2391acfd426d585e8f05b969a","head":{"label":"edx:bexline/fix_auto_registration","ref":"bexline/fix_auto_registration","sha":"dbe2f383235bf7b2391acfd426d585e8f05b969a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-07-20T07:32:17Z","pushed_at":"2017-07-20T08:19:44Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":826628,"stargazers_count":3229,"watchers_count":3229,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1868,"mirror_url":null,"open_issues_count":177,"forks":1868,"open_issues":177,"watchers":3229,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"e9e72aec8959f5922e72d0efbfe7129c65e0c8fb","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-07-20T07:32:17Z","pushed_at":"2017-07-20T08:19:44Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":826628,"stargazers_count":3229,"watchers_count":3229,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1868,"mirror_url":null,"open_issues_count":177,"forks":1868,"open_issues":177,"watchers":3229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15608"},"html":{"href":"https://github.com/edx/edx-platform/pull/15608"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15608"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15608/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15608/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15608/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/dbe2f383235bf7b2391acfd426d585e8f05b969a"}}}}
{"actor":{"display_login":"douglashall"}}