{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/115059154","pull_request_review_id":36576768,"id":115059154,"diff_hunk":"@@ -84,15 +84,15 @@ def self.perform_for_groups_in_app(app: nil, groups: nil, &block)\n       if groups.nil?\n         default_external_group = app.default_external_group\n         if default_external_group.nil?\n-          UI.user_error!(\"The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option.\")\n+          raise \"The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option.\"","path":"spaceship/lib/spaceship/test_flight/group.rb","position":5,"original_position":5,"commit_id":"bf441d168997760e73ec86d52df7b5ee6d3aabf3","original_commit_id":"bf441d168997760e73ec86d52df7b5ee6d3aabf3","user":{"login":"mpirri","id":1190389,"avatar_url":"https://avatars0.githubusercontent.com/u/1190389?v=3","gravatar_id":"","url":"https://api.github.com/users/mpirri","html_url":"https://github.com/mpirri","followers_url":"https://api.github.com/users/mpirri/followers","following_url":"https://api.github.com/users/mpirri/following{/other_user}","gists_url":"https://api.github.com/users/mpirri/gists{/gist_id}","starred_url":"https://api.github.com/users/mpirri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpirri/subscriptions","organizations_url":"https://api.github.com/users/mpirri/orgs","repos_url":"https://api.github.com/users/mpirri/repos","events_url":"https://api.github.com/users/mpirri/events{/privacy}","received_events_url":"https://api.github.com/users/mpirri/received_events","type":"User","site_admin":false},"body":"My feeling is that we need to be sure that we surface this failure as a user-error of some sort up the chain. Failing to include a group name or mistyping a group name (as in line 95 below) is not really a crash, yet if we do not rescue this error and re-raise as a user error, it will be logged as a crash by _fastlane_'s `runner.rb`.","created_at":"2017-05-05T18:21:20Z","updated_at":"2017-05-05T18:21:20Z","html_url":"https://github.com/fastlane/fastlane/pull/9089#discussion_r115059154","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/9089","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/115059154"},"html":{"href":"https://github.com/fastlane/fastlane/pull/9089#discussion_r115059154"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9089"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/9089","id":119212120,"html_url":"https://github.com/fastlane/fastlane/pull/9089","diff_url":"https://github.com/fastlane/fastlane/pull/9089.diff","patch_url":"https://github.com/fastlane/fastlane/pull/9089.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/9089","number":9089,"state":"open","locked":false,"title":"Fix accessing fastlane_core from within spaceship","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars1.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"body":"Also adds tests so that never happens again\r\n\r\nwith the recent TestFlight changes, multiple `UI.something` calls went into _spaceship_ causing crashes if that part of the code is reached. Currently _spaceship_ doesn't have access to _fastlane_core_. I'm updating our build scripts to automatically detect those errors in the future :+1:","created_at":"2017-05-05T16:28:40Z","updated_at":"2017-05-05T18:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5d5314a853d6102a6b8f5e298c6eb5c9fccce23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/9089/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/9089/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/9089/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/bf441d168997760e73ec86d52df7b5ee6d3aabf3","head":{"label":"fastlane:fix-spaceship","ref":"fix-spaceship","sha":"bf441d168997760e73ec86d52df7b5ee6d3aabf3","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2017-05-05T16:22:02Z","pushed_at":"2017-05-05T17:57:43Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":55948,"stargazers_count":15640,"watchers_count":15640,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2375,"mirror_url":null,"open_issues_count":327,"forks":2375,"open_issues":327,"watchers":15640,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"29886bfa6861e5f0507d4369404abf055c2687e4","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2017-05-05T16:22:02Z","pushed_at":"2017-05-05T17:57:43Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":55948,"stargazers_count":15640,"watchers_count":15640,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2375,"mirror_url":null,"open_issues_count":327,"forks":2375,"open_issues":327,"watchers":15640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9089"},"html":{"href":"https://github.com/fastlane/fastlane/pull/9089"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/9089"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/9089/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9089/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9089/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/bf441d168997760e73ec86d52df7b5ee6d3aabf3"}}}}
{"actor":{"display_login":"mpirri"}}