{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/288","repository_url":"https://api.github.com/repos/mobify/progressive-web-scaffold","labels_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/288/comments","events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/288/events","html_url":"https://github.com/mobify/progressive-web-scaffold/pull/288","id":205311178,"number":288,"title":"Disallow global jquery and jest","user":{"login":"mikenikles","id":788827,"avatar_url":"https://avatars.githubusercontent.com/u/788827?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenikles","html_url":"https://github.com/mikenikles","followers_url":"https://api.github.com/users/mikenikles/followers","following_url":"https://api.github.com/users/mikenikles/following{/other_user}","gists_url":"https://api.github.com/users/mikenikles/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenikles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenikles/subscriptions","organizations_url":"https://api.github.com/users/mikenikles/orgs","repos_url":"https://api.github.com/users/mikenikles/repos","events_url":"https://api.github.com/users/mikenikles/events{/privacy}","received_events_url":"https://api.github.com/users/mikenikles/received_events","type":"User","site_admin":false},"labels":[{"id":402885657,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels/ready%20for%20review","name":"ready for review","color":"0e8a16","default":false},{"id":520512961,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels/web","name":"web","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-04T01:22:06Z","updated_at":"2017-02-09T18:40:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/288","html_url":"https://github.com/mobify/progressive-web-scaffold/pull/288","diff_url":"https://github.com/mobify/progressive-web-scaffold/pull/288.diff","patch_url":"https://github.com/mobify/progressive-web-scaffold/pull/288.patch"},"body":"Removes the ESLint `jquery` and `jest` environments globally and instead relies on explicit configuration in files where global variables of these environments are necessary.\r\n\r\nThe main benefit of this PR is to enforce the use of our internal `$` variable returned by the SDK's `jqueryResponse` function, rather than the global `$` bound to `window` in browsers.\r\n\r\n## Changes\r\n- Removed the ESLint env settings.\r\n- Updated all test files accordingly.\r\n\r\n## How to test-drive this PR\r\n- Run `npm run test:js`.\r\n  - Verify that it succeeds.\r\n- Open any file and try to use `$`.\r\n  - Verify that ESLint reports an error.\r\n- Run `npm run dev`\r\n- Preview [Merlin's Potions](https://preview.mobify.com/?url=https%3A%2F%2Fwww.merlinspotions.com%2F&site_folder=https%3A%2F%2Flocalhost%3A8443%2Floader.js&disabled=0&domain=&scope=1)"},"comment":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/comments/278733146","html_url":"https://github.com/mobify/progressive-web-scaffold/pull/288#issuecomment-278733146","issue_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/288","id":278733146,"user":{"login":"mikenikles","id":788827,"avatar_url":"https://avatars.githubusercontent.com/u/788827?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenikles","html_url":"https://github.com/mikenikles","followers_url":"https://api.github.com/users/mikenikles/followers","following_url":"https://api.github.com/users/mikenikles/following{/other_user}","gists_url":"https://api.github.com/users/mikenikles/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenikles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenikles/subscriptions","organizations_url":"https://api.github.com/users/mikenikles/orgs","repos_url":"https://api.github.com/users/mikenikles/repos","events_url":"https://api.github.com/users/mikenikles/events{/privacy}","received_events_url":"https://api.github.com/users/mikenikles/received_events","type":"User","site_admin":false},"created_at":"2017-02-09T18:40:16Z","updated_at":"2017-02-09T18:40:16Z","body":"@jnurse Let's never talk about the code I originally pushed... :). I addressed your comments in 37bbc9b"}}
{"actor":{"display_login":"mikenikles"}}