{"action":"closed","number":1327,"pull_request":{"url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327","id":152524911,"html_url":"https://github.com/OpenRefine/OpenRefine/pull/1327","diff_url":"https://github.com/OpenRefine/OpenRefine/pull/1327.diff","patch_url":"https://github.com/OpenRefine/OpenRefine/pull/1327.patch","issue_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1327","number":1327,"state":"closed","locked":false,"title":"Invert text search facet/text filter","user":{"login":"ostephens","id":576174,"avatar_url":"https://avatars1.githubusercontent.com/u/576174?v=4","gravatar_id":"","url":"https://api.github.com/users/ostephens","html_url":"https://github.com/ostephens","followers_url":"https://api.github.com/users/ostephens/followers","following_url":"https://api.github.com/users/ostephens/following{/other_user}","gists_url":"https://api.github.com/users/ostephens/gists{/gist_id}","starred_url":"https://api.github.com/users/ostephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostephens/subscriptions","organizations_url":"https://api.github.com/users/ostephens/orgs","repos_url":"https://api.github.com/users/ostephens/repos","events_url":"https://api.github.com/users/ostephens/events{/privacy}","received_events_url":"https://api.github.com/users/ostephens/received_events","type":"User","site_admin":false},"body":"Implementing an 'Invert' option for the text search facet (a.k.a filter) as per #952 \r\n\r\n* New 'Invert' and 'Reset' options at the top left of the Text filter facet panel\r\n* Click the 'Invert' link to invert the filter - i.e. find all rows which don't match the filter text or regular expression\r\n* When 'Invert' is applied, panel gets an orange header to indicate the filter is inverted. The same device also implemented on text facets. In both cases the 'Invert' link appears struck-through (this latter device is the current behaviour for the Text Facet)\r\n* 'Reset' clears all the options (invert, text in the filter box, case-sensitive, regular expression) of the filter\r\n\r\nComments on the UI welcome (@ettorerizza, @thadguidry, @wetneb)\r\n\r\nI want to implement some tests for this functionality, but I can't work out how to best do this - @jackyq2015 @wetneb @thadguidry - any hints on the right approach to writing a test for these? I'm not quite sure how to apply the filter with options to a test set of data to see what the results are (I know what I expect the results to be - I'm just not sure on the mechanics to get the results). Pointers v welcome.","created_at":"2017-11-14T14:51:22Z","updated_at":"2017-11-16T08:05:32Z","closed_at":"2017-11-16T08:05:32Z","merged_at":"2017-11-16T08:05:32Z","merge_commit_sha":"78b7f01be5516c8e4e16d24ff33361b9b36c4bfb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327/commits","review_comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327/comments","review_comment_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1327/comments","statuses_url":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/742b42ade1c3f0df61506dc6cc6240d6df71c7d7","head":{"label":"ostephens:invert-filter","ref":"invert-filter","sha":"742b42ade1c3f0df61506dc6cc6240d6df71c7d7","user":{"login":"ostephens","id":576174,"avatar_url":"https://avatars1.githubusercontent.com/u/576174?v=4","gravatar_id":"","url":"https://api.github.com/users/ostephens","html_url":"https://github.com/ostephens","followers_url":"https://api.github.com/users/ostephens/followers","following_url":"https://api.github.com/users/ostephens/following{/other_user}","gists_url":"https://api.github.com/users/ostephens/gists{/gist_id}","starred_url":"https://api.github.com/users/ostephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostephens/subscriptions","organizations_url":"https://api.github.com/users/ostephens/orgs","repos_url":"https://api.github.com/users/ostephens/repos","events_url":"https://api.github.com/users/ostephens/events{/privacy}","received_events_url":"https://api.github.com/users/ostephens/received_events","type":"User","site_admin":false},"repo":{"id":30748694,"name":"OpenRefine","full_name":"ostephens/OpenRefine","owner":{"login":"ostephens","id":576174,"avatar_url":"https://avatars1.githubusercontent.com/u/576174?v=4","gravatar_id":"","url":"https://api.github.com/users/ostephens","html_url":"https://github.com/ostephens","followers_url":"https://api.github.com/users/ostephens/followers","following_url":"https://api.github.com/users/ostephens/following{/other_user}","gists_url":"https://api.github.com/users/ostephens/gists{/gist_id}","starred_url":"https://api.github.com/users/ostephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostephens/subscriptions","organizations_url":"https://api.github.com/users/ostephens/orgs","repos_url":"https://api.github.com/users/ostephens/repos","events_url":"https://api.github.com/users/ostephens/events{/privacy}","received_events_url":"https://api.github.com/users/ostephens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ostephens/OpenRefine","description":"OpenRefine is a free, open source power tool for working with messy data and improving it","fork":true,"url":"https://api.github.com/repos/ostephens/OpenRefine","forks_url":"https://api.github.com/repos/ostephens/OpenRefine/forks","keys_url":"https://api.github.com/repos/ostephens/OpenRefine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ostephens/OpenRefine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ostephens/OpenRefine/teams","hooks_url":"https://api.github.com/repos/ostephens/OpenRefine/hooks","issue_events_url":"https://api.github.com/repos/ostephens/OpenRefine/issues/events{/number}","events_url":"https://api.github.com/repos/ostephens/OpenRefine/events","assignees_url":"https://api.github.com/repos/ostephens/OpenRefine/assignees{/user}","branches_url":"https://api.github.com/repos/ostephens/OpenRefine/branches{/branch}","tags_url":"https://api.github.com/repos/ostephens/OpenRefine/tags","blobs_url":"https://api.github.com/repos/ostephens/OpenRefine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ostephens/OpenRefine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ostephens/OpenRefine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ostephens/OpenRefine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ostephens/OpenRefine/statuses/{sha}","languages_url":"https://api.github.com/repos/ostephens/OpenRefine/languages","stargazers_url":"https://api.github.com/repos/ostephens/OpenRefine/stargazers","contributors_url":"https://api.github.com/repos/ostephens/OpenRefine/contributors","subscribers_url":"https://api.github.com/repos/ostephens/OpenRefine/subscribers","subscription_url":"https://api.github.com/repos/ostephens/OpenRefine/subscription","commits_url":"https://api.github.com/repos/ostephens/OpenRefine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ostephens/OpenRefine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ostephens/OpenRefine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ostephens/OpenRefine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ostephens/OpenRefine/contents/{+path}","compare_url":"https://api.github.com/repos/ostephens/OpenRefine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ostephens/OpenRefine/merges","archive_url":"https://api.github.com/repos/ostephens/OpenRefine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ostephens/OpenRefine/downloads","issues_url":"https://api.github.com/repos/ostephens/OpenRefine/issues{/number}","pulls_url":"https://api.github.com/repos/ostephens/OpenRefine/pulls{/number}","milestones_url":"https://api.github.com/repos/ostephens/OpenRefine/milestones{/number}","notifications_url":"https://api.github.com/repos/ostephens/OpenRefine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ostephens/OpenRefine/labels{/name}","releases_url":"https://api.github.com/repos/ostephens/OpenRefine/releases{/id}","deployments_url":"https://api.github.com/repos/ostephens/OpenRefine/deployments","created_at":"2015-02-13T09:07:22Z","updated_at":"2017-06-08T13:50:24Z","pushed_at":"2017-11-15T19:02:08Z","git_url":"git://github.com/ostephens/OpenRefine.git","ssh_url":"git@github.com:ostephens/OpenRefine.git","clone_url":"https://github.com/ostephens/OpenRefine.git","svn_url":"https://github.com/ostephens/OpenRefine","homepage":"","size":336171,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenRefine:master","ref":"master","sha":"850b861acb7fc1d214303f766d6400b69b07ddee","user":{"login":"OpenRefine","id":2538880,"avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"repo":{"id":6220644,"name":"OpenRefine","full_name":"OpenRefine/OpenRefine","owner":{"login":"OpenRefine","id":2538880,"avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRefine/OpenRefine","description":"OpenRefine is a free, open source power tool for working with messy data and improving it","fork":false,"url":"https://api.github.com/repos/OpenRefine/OpenRefine","forks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/forks","keys_url":"https://api.github.com/repos/OpenRefine/OpenRefine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRefine/OpenRefine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRefine/OpenRefine/teams","hooks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/hooks","issue_events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/events","assignees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRefine/OpenRefine/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/tags","blobs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRefine/OpenRefine/languages","stargazers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/stargazers","contributors_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contributors","subscribers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscribers","subscription_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscription","commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRefine/OpenRefine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRefine/OpenRefine/merges","archive_url":"https://api.github.com/repos/OpenRefine/OpenRefine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRefine/OpenRefine/downloads","issues_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRefine/OpenRefine/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRefine/OpenRefine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRefine/OpenRefine/labels{/name}","releases_url":"https://api.github.com/repos/OpenRefine/OpenRefine/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/deployments","created_at":"2012-10-15T02:22:48Z","updated_at":"2017-11-15T22:22:12Z","pushed_at":"2017-11-16T08:05:32Z","git_url":"git://github.com/OpenRefine/OpenRefine.git","ssh_url":"git@github.com:OpenRefine/OpenRefine.git","clone_url":"https://github.com/OpenRefine/OpenRefine.git","svn_url":"https://github.com/OpenRefine/OpenRefine","homepage":"http://openrefine.org/","size":332013,"stargazers_count":4840,"watchers_count":4840,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":864,"mirror_url":null,"archived":false,"open_issues_count":347,"forks":864,"open_issues":347,"watchers":4840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327"},"html":{"href":"https://github.com/OpenRefine/OpenRefine/pull/1327"},"issue":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1327"},"comments":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1327/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1327/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/742b42ade1c3f0df61506dc6cc6240d6df71c7d7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wetneb","id":309908,"avatar_url":"https://avatars1.githubusercontent.com/u/309908?v=4","gravatar_id":"","url":"https://api.github.com/users/wetneb","html_url":"https://github.com/wetneb","followers_url":"https://api.github.com/users/wetneb/followers","following_url":"https://api.github.com/users/wetneb/following{/other_user}","gists_url":"https://api.github.com/users/wetneb/gists{/gist_id}","starred_url":"https://api.github.com/users/wetneb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wetneb/subscriptions","organizations_url":"https://api.github.com/users/wetneb/orgs","repos_url":"https://api.github.com/users/wetneb/repos","events_url":"https://api.github.com/users/wetneb/events{/privacy}","received_events_url":"https://api.github.com/users/wetneb/received_events","type":"User","site_admin":false},"comments":8,"review_comments":2,"maintainer_can_modify":false,"commits":8,"additions":349,"deletions":36,"changed_files":6}}
{"actor":{"display_login":"wetneb"}}