{"action":"opened","number":41,"pull_request":{"url":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41","id":100985919,"html_url":"https://github.com/Kupoman/blendergltf/pull/41","diff_url":"https://github.com/Kupoman/blendergltf/pull/41.diff","patch_url":"https://github.com/Kupoman/blendergltf/pull/41.patch","issue_url":"https://api.github.com/repos/Kupoman/blendergltf/issues/41","number":41,"state":"open","locked":false,"title":"Support output of smoothed normals","user":{"login":"stevenvergenz","id":1882376,"avatar_url":"https://avatars.githubusercontent.com/u/1882376?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenvergenz","html_url":"https://github.com/stevenvergenz","followers_url":"https://api.github.com/users/stevenvergenz/followers","following_url":"https://api.github.com/users/stevenvergenz/following{/other_user}","gists_url":"https://api.github.com/users/stevenvergenz/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenvergenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenvergenz/subscriptions","organizations_url":"https://api.github.com/users/stevenvergenz/orgs","repos_url":"https://api.github.com/users/stevenvergenz/repos","events_url":"https://api.github.com/users/stevenvergenz/events{/privacy}","received_events_url":"https://api.github.com/users/stevenvergenz/received_events","type":"User","site_admin":false},"body":"I've made two main changes. First, a given output vertex uses the mesh vertex normal if both `mesh.use_auto_smooth` is enabled, and the edge it's a part of is not marked as a \"sharp\" edge. Otherwise, the vertex will use the loop normal (the current output). Second, I have changed the way vertices are indexed. Previously, vertices stored a loop index array, but there was no way to update that array if a duplicate ever came up. Now, the SmartVertexList can look up the matching vertex.\r\n\r\nThis PR works, but it's *super* slow. Takes several minutes to output an isosphere with 10k vertices. Still trying to improve that run time, but I wanted to get more eyes on this first. Thoughts?","created_at":"2017-01-11T01:13:11Z","updated_at":"2017-01-11T01:13:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41/commits","review_comments_url":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41/comments","review_comment_url":"https://api.github.com/repos/Kupoman/blendergltf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kupoman/blendergltf/issues/41/comments","statuses_url":"https://api.github.com/repos/Kupoman/blendergltf/statuses/92a936ffe295446d9161fcfd7e2f703e343c166b","head":{"label":"AltspaceVR:feature/smooth-normals","ref":"feature/smooth-normals","sha":"92a936ffe295446d9161fcfd7e2f703e343c166b","user":{"login":"AltspaceVR","id":7229981,"avatar_url":"https://avatars.githubusercontent.com/u/7229981?v=3","gravatar_id":"","url":"https://api.github.com/users/AltspaceVR","html_url":"https://github.com/AltspaceVR","followers_url":"https://api.github.com/users/AltspaceVR/followers","following_url":"https://api.github.com/users/AltspaceVR/following{/other_user}","gists_url":"https://api.github.com/users/AltspaceVR/gists{/gist_id}","starred_url":"https://api.github.com/users/AltspaceVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AltspaceVR/subscriptions","organizations_url":"https://api.github.com/users/AltspaceVR/orgs","repos_url":"https://api.github.com/users/AltspaceVR/repos","events_url":"https://api.github.com/users/AltspaceVR/events{/privacy}","received_events_url":"https://api.github.com/users/AltspaceVR/received_events","type":"Organization","site_admin":false},"repo":{"id":78562020,"name":"blendergltf","full_name":"AltspaceVR/blendergltf","owner":{"login":"AltspaceVR","id":7229981,"avatar_url":"https://avatars.githubusercontent.com/u/7229981?v=3","gravatar_id":"","url":"https://api.github.com/users/AltspaceVR","html_url":"https://github.com/AltspaceVR","followers_url":"https://api.github.com/users/AltspaceVR/followers","following_url":"https://api.github.com/users/AltspaceVR/following{/other_user}","gists_url":"https://api.github.com/users/AltspaceVR/gists{/gist_id}","starred_url":"https://api.github.com/users/AltspaceVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AltspaceVR/subscriptions","organizations_url":"https://api.github.com/users/AltspaceVR/orgs","repos_url":"https://api.github.com/users/AltspaceVR/repos","events_url":"https://api.github.com/users/AltspaceVR/events{/privacy}","received_events_url":"https://api.github.com/users/AltspaceVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AltspaceVR/blendergltf","description":"A glTF exporter for Blender","fork":true,"url":"https://api.github.com/repos/AltspaceVR/blendergltf","forks_url":"https://api.github.com/repos/AltspaceVR/blendergltf/forks","keys_url":"https://api.github.com/repos/AltspaceVR/blendergltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AltspaceVR/blendergltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AltspaceVR/blendergltf/teams","hooks_url":"https://api.github.com/repos/AltspaceVR/blendergltf/hooks","issue_events_url":"https://api.github.com/repos/AltspaceVR/blendergltf/issues/events{/number}","events_url":"https://api.github.com/repos/AltspaceVR/blendergltf/events","assignees_url":"https://api.github.com/repos/AltspaceVR/blendergltf/assignees{/user}","branches_url":"https://api.github.com/repos/AltspaceVR/blendergltf/branches{/branch}","tags_url":"https://api.github.com/repos/AltspaceVR/blendergltf/tags","blobs_url":"https://api.github.com/repos/AltspaceVR/blendergltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AltspaceVR/blendergltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AltspaceVR/blendergltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/AltspaceVR/blendergltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AltspaceVR/blendergltf/statuses/{sha}","languages_url":"https://api.github.com/repos/AltspaceVR/blendergltf/languages","stargazers_url":"https://api.github.com/repos/AltspaceVR/blendergltf/stargazers","contributors_url":"https://api.github.com/repos/AltspaceVR/blendergltf/contributors","subscribers_url":"https://api.github.com/repos/AltspaceVR/blendergltf/subscribers","subscription_url":"https://api.github.com/repos/AltspaceVR/blendergltf/subscription","commits_url":"https://api.github.com/repos/AltspaceVR/blendergltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/AltspaceVR/blendergltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/AltspaceVR/blendergltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/AltspaceVR/blendergltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/AltspaceVR/blendergltf/contents/{+path}","compare_url":"https://api.github.com/repos/AltspaceVR/blendergltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AltspaceVR/blendergltf/merges","archive_url":"https://api.github.com/repos/AltspaceVR/blendergltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AltspaceVR/blendergltf/downloads","issues_url":"https://api.github.com/repos/AltspaceVR/blendergltf/issues{/number}","pulls_url":"https://api.github.com/repos/AltspaceVR/blendergltf/pulls{/number}","milestones_url":"https://api.github.com/repos/AltspaceVR/blendergltf/milestones{/number}","notifications_url":"https://api.github.com/repos/AltspaceVR/blendergltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AltspaceVR/blendergltf/labels{/name}","releases_url":"https://api.github.com/repos/AltspaceVR/blendergltf/releases{/id}","deployments_url":"https://api.github.com/repos/AltspaceVR/blendergltf/deployments","created_at":"2017-01-10T18:34:36Z","updated_at":"2017-01-10T18:34:38Z","pushed_at":"2017-01-11T00:46:32Z","git_url":"git://github.com/AltspaceVR/blendergltf.git","ssh_url":"git@github.com:AltspaceVR/blendergltf.git","clone_url":"https://github.com/AltspaceVR/blendergltf.git","svn_url":"https://github.com/AltspaceVR/blendergltf","homepage":"","size":119,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kupoman:master","ref":"master","sha":"766268cc6ea42ed19dfa7d703fe1df83544f5652","user":{"login":"Kupoman","id":4071975,"avatar_url":"https://avatars.githubusercontent.com/u/4071975?v=3","gravatar_id":"","url":"https://api.github.com/users/Kupoman","html_url":"https://github.com/Kupoman","followers_url":"https://api.github.com/users/Kupoman/followers","following_url":"https://api.github.com/users/Kupoman/following{/other_user}","gists_url":"https://api.github.com/users/Kupoman/gists{/gist_id}","starred_url":"https://api.github.com/users/Kupoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kupoman/subscriptions","organizations_url":"https://api.github.com/users/Kupoman/orgs","repos_url":"https://api.github.com/users/Kupoman/repos","events_url":"https://api.github.com/users/Kupoman/events{/privacy}","received_events_url":"https://api.github.com/users/Kupoman/received_events","type":"User","site_admin":false},"repo":{"id":51494812,"name":"blendergltf","full_name":"Kupoman/blendergltf","owner":{"login":"Kupoman","id":4071975,"avatar_url":"https://avatars.githubusercontent.com/u/4071975?v=3","gravatar_id":"","url":"https://api.github.com/users/Kupoman","html_url":"https://github.com/Kupoman","followers_url":"https://api.github.com/users/Kupoman/followers","following_url":"https://api.github.com/users/Kupoman/following{/other_user}","gists_url":"https://api.github.com/users/Kupoman/gists{/gist_id}","starred_url":"https://api.github.com/users/Kupoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kupoman/subscriptions","organizations_url":"https://api.github.com/users/Kupoman/orgs","repos_url":"https://api.github.com/users/Kupoman/repos","events_url":"https://api.github.com/users/Kupoman/events{/privacy}","received_events_url":"https://api.github.com/users/Kupoman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kupoman/blendergltf","description":"A glTF exporter for Blender","fork":false,"url":"https://api.github.com/repos/Kupoman/blendergltf","forks_url":"https://api.github.com/repos/Kupoman/blendergltf/forks","keys_url":"https://api.github.com/repos/Kupoman/blendergltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kupoman/blendergltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kupoman/blendergltf/teams","hooks_url":"https://api.github.com/repos/Kupoman/blendergltf/hooks","issue_events_url":"https://api.github.com/repos/Kupoman/blendergltf/issues/events{/number}","events_url":"https://api.github.com/repos/Kupoman/blendergltf/events","assignees_url":"https://api.github.com/repos/Kupoman/blendergltf/assignees{/user}","branches_url":"https://api.github.com/repos/Kupoman/blendergltf/branches{/branch}","tags_url":"https://api.github.com/repos/Kupoman/blendergltf/tags","blobs_url":"https://api.github.com/repos/Kupoman/blendergltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kupoman/blendergltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kupoman/blendergltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kupoman/blendergltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kupoman/blendergltf/statuses/{sha}","languages_url":"https://api.github.com/repos/Kupoman/blendergltf/languages","stargazers_url":"https://api.github.com/repos/Kupoman/blendergltf/stargazers","contributors_url":"https://api.github.com/repos/Kupoman/blendergltf/contributors","subscribers_url":"https://api.github.com/repos/Kupoman/blendergltf/subscribers","subscription_url":"https://api.github.com/repos/Kupoman/blendergltf/subscription","commits_url":"https://api.github.com/repos/Kupoman/blendergltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kupoman/blendergltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kupoman/blendergltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kupoman/blendergltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kupoman/blendergltf/contents/{+path}","compare_url":"https://api.github.com/repos/Kupoman/blendergltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kupoman/blendergltf/merges","archive_url":"https://api.github.com/repos/Kupoman/blendergltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kupoman/blendergltf/downloads","issues_url":"https://api.github.com/repos/Kupoman/blendergltf/issues{/number}","pulls_url":"https://api.github.com/repos/Kupoman/blendergltf/pulls{/number}","milestones_url":"https://api.github.com/repos/Kupoman/blendergltf/milestones{/number}","notifications_url":"https://api.github.com/repos/Kupoman/blendergltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kupoman/blendergltf/labels{/name}","releases_url":"https://api.github.com/repos/Kupoman/blendergltf/releases{/id}","deployments_url":"https://api.github.com/repos/Kupoman/blendergltf/deployments","created_at":"2016-02-11T04:53:55Z","updated_at":"2017-01-09T15:31:34Z","pushed_at":"2017-01-09T21:23:01Z","git_url":"git://github.com/Kupoman/blendergltf.git","ssh_url":"git@github.com:Kupoman/blendergltf.git","clone_url":"https://github.com/Kupoman/blendergltf.git","svn_url":"https://github.com/Kupoman/blendergltf","homepage":"","size":106,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41"},"html":{"href":"https://github.com/Kupoman/blendergltf/pull/41"},"issue":{"href":"https://api.github.com/repos/Kupoman/blendergltf/issues/41"},"comments":{"href":"https://api.github.com/repos/Kupoman/blendergltf/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/Kupoman/blendergltf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kupoman/blendergltf/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/Kupoman/blendergltf/statuses/92a936ffe295446d9161fcfd7e2f703e343c166b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":47,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"stevenvergenz"}}