{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/comments/114047082","pull_request_review_id":35490333,"id":114047082,"diff_hunk":"@@ -341,7 +341,7 @@ function mixinDiscovery(MsSQL) {\n \n   MsSQL.prototype.buildPropertyType = function(columnDefinition, dataLength) {\n     var mysqlType = columnDefinition.dataType;\n-    var dataLength = columnDefinition.dataLength;\n+    dataLength = dataLength || columnDefinition.dataLength;","path":"lib/discovery.js","position":null,"original_position":5,"commit_id":"7bf0a59bda472893975a8f5f028945a5b4ef0a9e","original_commit_id":"42a6fb1d80e3233d511ff3c87b7ceb0477988d71","user":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars3.githubusercontent.com/u/540892?v=3","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"body":"@jannyHou Good catch. Fixed.","created_at":"2017-04-29T06:09:14Z","updated_at":"2017-04-29T06:09:14Z","html_url":"https://github.com/strongloop/loopback-connector-mssql/pull/144#discussion_r114047082","pull_request_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/comments/114047082"},"html":{"href":"https://github.com/strongloop/loopback-connector-mssql/pull/144#discussion_r114047082"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144","id":118080067,"html_url":"https://github.com/strongloop/loopback-connector-mssql/pull/144","diff_url":"https://github.com/strongloop/loopback-connector-mssql/pull/144.diff","patch_url":"https://github.com/strongloop/loopback-connector-mssql/pull/144.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/144","number":144,"state":"open","locked":false,"title":"Feature/upgrade deps","user":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars3.githubusercontent.com/u/540892?v=3","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThe PR upgrade `mssql` to `4.x`, which has breaking changes than `3.x`. \r\nIt also includes other dev time dependency upgrades.\r\n\r\n#### Related issues\r\n\r\n<!--\r\nPlease use the following link syntaxes:\r\n\r\n- #49 (to reference issues in the current repository)\r\n- strongloop/loopback#49 (to reference issues in another repository)\r\n-->\r\n\r\n- None\r\n\r\n### Checklist\r\n\r\n<!--\r\nPlease mark your choice with an \"x\" (i.e. [x], see\r\nhttps://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments)\r\n-->\r\n\r\n- [ ] New tests added or existing tests modified to cover all changes\r\n- [x] Code conforms with the [style\r\n  guide](http://loopback.io/doc/en/contrib/style-guide.html)\r\n","created_at":"2017-04-28T04:54:54Z","updated_at":"2017-04-29T06:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c310089f266e2d85f9eb3bce551cf971e12a6ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/144/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/statuses/7bf0a59bda472893975a8f5f028945a5b4ef0a9e","head":{"label":"strongloop:feature/upgrade-deps","ref":"feature/upgrade-deps","sha":"7bf0a59bda472893975a8f5f028945a5b4ef0a9e","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":16129899,"name":"loopback-connector-mssql","full_name":"strongloop/loopback-connector-mssql","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-connector-mssql","description":"LoopBack connector for Microsoft SQL Server","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-connector-mssql","forks_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/deployments","created_at":"2014-01-22T05:34:06Z","updated_at":"2017-04-01T18:16:40Z","pushed_at":"2017-04-29T06:08:28Z","git_url":"git://github.com/strongloop/loopback-connector-mssql.git","ssh_url":"git@github.com:strongloop/loopback-connector-mssql.git","clone_url":"https://github.com/strongloop/loopback-connector-mssql.git","svn_url":"https://github.com/strongloop/loopback-connector-mssql","homepage":"http://loopback.io/doc/en/lb3/SQL-Server-connector.html","size":270,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":45,"forks":39,"open_issues":45,"watchers":35,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"2035c86915888c15812b67fe74a0946ad83e2a68","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":16129899,"name":"loopback-connector-mssql","full_name":"strongloop/loopback-connector-mssql","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-connector-mssql","description":"LoopBack connector for Microsoft SQL Server","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-connector-mssql","forks_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-connector-mssql/deployments","created_at":"2014-01-22T05:34:06Z","updated_at":"2017-04-01T18:16:40Z","pushed_at":"2017-04-29T06:08:28Z","git_url":"git://github.com/strongloop/loopback-connector-mssql.git","ssh_url":"git@github.com:strongloop/loopback-connector-mssql.git","clone_url":"https://github.com/strongloop/loopback-connector-mssql.git","svn_url":"https://github.com/strongloop/loopback-connector-mssql","homepage":"http://loopback.io/doc/en/lb3/SQL-Server-connector.html","size":270,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":45,"forks":39,"open_issues":45,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144"},"html":{"href":"https://github.com/strongloop/loopback-connector-mssql/pull/144"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/144"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mssql/statuses/7bf0a59bda472893975a8f5f028945a5b4ef0a9e"}}}}
{"actor":{"display_login":"raymondfeng"}}