{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/176","repository_url":"https://api.github.com/repos/Microsoft/sqltoolsservice","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/176/comments","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/176/events","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/176","id":194738117,"number":176,"title":"Reuse query connection","user":{"login":"coquagli","id":24420239,"avatar_url":"https://avatars.githubusercontent.com/u/24420239?v=3","gravatar_id":"","url":"https://api.github.com/users/coquagli","html_url":"https://github.com/coquagli","followers_url":"https://api.github.com/users/coquagli/followers","following_url":"https://api.github.com/users/coquagli/following{/other_user}","gists_url":"https://api.github.com/users/coquagli/gists{/gist_id}","starred_url":"https://api.github.com/users/coquagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coquagli/subscriptions","organizations_url":"https://api.github.com/users/coquagli/orgs","repos_url":"https://api.github.com/users/coquagli/repos","events_url":"https://api.github.com/users/coquagli/events{/privacy}","received_events_url":"https://api.github.com/users/coquagli/received_events","type":"User","site_admin":false},"labels":[{"id":481657897,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-12-10T02:15:33Z","updated_at":"2017-01-12T00:25:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/176","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/176","diff_url":"https://github.com/Microsoft/sqltoolsservice/pull/176.diff","patch_url":"https://github.com/Microsoft/sqltoolsservice/pull/176.patch"},"body":"Fixes [483](https://github.com/Microsoft/vscode-mssql/issues/483) in vscode-mssql.\r\n\r\n- Replace the `DbConnection `with `Dictionary<ConnectionType, DbConnection>` in `ConnectionInfo` so that any number of simultaneous connections can be supported\r\n- Change `ConnectionService` to support conneciton, disconneciton, and cancellation of any number of simultanious connecitons. \r\n- Add `ConnectionType.cs`, and add a `ConnectionType` variable to numerous parameter classes\r\n- Change query execution so the first query for a URI will open a new `DbConnection` dedicated to query execution. All subsequent queries on that URI use the same `DbConnection`\r\n- Change existing tests to reflect connection logic changes\r\n- Add new tests for transactions, temp tables, and multiple `DbConnection` logic\r\n\r\nI continued to use a `DbConnection` for the connection. I noticed that some other classes are using `SqlConnection` instead of `DbConnection`. Notably `ConnectedBindingQueue` (which is reused in `PeekDefinition`), `DbConnectionWrapper`, and `ReliableSqlConnection`."},"comment":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments/272039241","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/176#issuecomment-272039241","issue_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/176","id":272039241,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T00:25:55Z","updated_at":"2017-01-12T00:25:55Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9631515/badge)](https://coveralls.io/builds/9631515)\n\nCoverage increased (+0.8%) to 86.734% when pulling **82a9659ed26a24aac7a76a1a3bb8bcf135fb50de on bug/reUseConnection** into **0e29b181c97b770b59c35aede60692202b6c8e64 on dev**.\n"}}
{"actor":{"display_login":"coveralls"}}