{"action":"created","comment":{"url":"https://api.github.com/repos/go-spatial/geom/pulls/comments/139506038","pull_request_review_id":63448044,"id":139506038,"diff_hunk":"@@ -1,14 +1,18 @@\n // Package geom describes geometry interfaces.\n package geom\n \n-type Geometry interface{}\n+// Geometry is an object with a spatial reference.\n+type Geometry interface {\n+\tPoints() [][2]float64","path":"geom.go","position":7,"original_position":7,"commit_id":"8ce029608164c233a1126cd18bfdb20f81775e12","original_commit_id":"8ce029608164c233a1126cd18bfdb20f81775e12","user":{"login":"gdey","id":14805,"avatar_url":"https://avatars0.githubusercontent.com/u/14805?v=4","gravatar_id":"","url":"https://api.github.com/users/gdey","html_url":"https://github.com/gdey","followers_url":"https://api.github.com/users/gdey/followers","following_url":"https://api.github.com/users/gdey/following{/other_user}","gists_url":"https://api.github.com/users/gdey/gists{/gist_id}","starred_url":"https://api.github.com/users/gdey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdey/subscriptions","organizations_url":"https://api.github.com/users/gdey/orgs","repos_url":"https://api.github.com/users/gdey/repos","events_url":"https://api.github.com/users/gdey/events{/privacy}","received_events_url":"https://api.github.com/users/gdey/received_events","type":"User","site_admin":false},"body":"Alex and I had this conversion. I don't think we should have Point in the Geometery Interface, and if we do want to have it there, it should be named something else. The way you have it currently, make it hard to describe the intent of the function when working with LineStrings, Points or Polygons or Geometries; since they all have the same Func signature. Where these are semantically different things and should be treated differently. Making it difficult for a ClipLineString function to assume certain things.","created_at":"2017-09-18T18:41:03Z","updated_at":"2017-09-18T18:41:03Z","html_url":"https://github.com/go-spatial/geom/pull/1#discussion_r139506038","pull_request_url":"https://api.github.com/repos/go-spatial/geom/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/comments/139506038"},"html":{"href":"https://github.com/go-spatial/geom/pull/1#discussion_r139506038"},"pull_request":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/1"}},"in_reply_to_id":139292887},"pull_request":{"url":"https://api.github.com/repos/go-spatial/geom/pulls/1","id":141389004,"html_url":"https://github.com/go-spatial/geom/pull/1","diff_url":"https://github.com/go-spatial/geom/pull/1.diff","patch_url":"https://github.com/go-spatial/geom/pull/1.patch","issue_url":"https://api.github.com/repos/go-spatial/geom/issues/1","number":1,"state":"open","locked":false,"title":"Testing","user":{"login":"jyutzler","id":3401345,"avatar_url":"https://avatars1.githubusercontent.com/u/3401345?v=4","gravatar_id":"","url":"https://api.github.com/users/jyutzler","html_url":"https://github.com/jyutzler","followers_url":"https://api.github.com/users/jyutzler/followers","following_url":"https://api.github.com/users/jyutzler/following{/other_user}","gists_url":"https://api.github.com/users/jyutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/jyutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyutzler/subscriptions","organizations_url":"https://api.github.com/users/jyutzler/orgs","repos_url":"https://api.github.com/users/jyutzler/repos","events_url":"https://api.github.com/users/jyutzler/events{/privacy}","received_events_url":"https://api.github.com/users/jyutzler/received_events","type":"User","site_admin":false},"body":"This PR now contains a complete implementation (structs and associated tests) for all of the interfaces in geom.go. Minor changes were made to the interfaces to improve clarity and consistency.","created_at":"2017-09-15T19:53:57Z","updated_at":"2017-09-18T18:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda4464f2b4aa431f5b746ef07ee8573a9173335","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-spatial/geom/pulls/1/commits","review_comments_url":"https://api.github.com/repos/go-spatial/geom/pulls/1/comments","review_comment_url":"https://api.github.com/repos/go-spatial/geom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-spatial/geom/issues/1/comments","statuses_url":"https://api.github.com/repos/go-spatial/geom/statuses/8ce029608164c233a1126cd18bfdb20f81775e12","head":{"label":"go-spatial:testing","ref":"testing","sha":"8ce029608164c233a1126cd18bfdb20f81775e12","user":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"repo":{"id":102145722,"name":"geom","full_name":"go-spatial/geom","owner":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-spatial/geom","description":"Geometry interfaces to help drive interoperability within the Go geospatial community","fork":false,"url":"https://api.github.com/repos/go-spatial/geom","forks_url":"https://api.github.com/repos/go-spatial/geom/forks","keys_url":"https://api.github.com/repos/go-spatial/geom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-spatial/geom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-spatial/geom/teams","hooks_url":"https://api.github.com/repos/go-spatial/geom/hooks","issue_events_url":"https://api.github.com/repos/go-spatial/geom/issues/events{/number}","events_url":"https://api.github.com/repos/go-spatial/geom/events","assignees_url":"https://api.github.com/repos/go-spatial/geom/assignees{/user}","branches_url":"https://api.github.com/repos/go-spatial/geom/branches{/branch}","tags_url":"https://api.github.com/repos/go-spatial/geom/tags","blobs_url":"https://api.github.com/repos/go-spatial/geom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-spatial/geom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-spatial/geom/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-spatial/geom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-spatial/geom/statuses/{sha}","languages_url":"https://api.github.com/repos/go-spatial/geom/languages","stargazers_url":"https://api.github.com/repos/go-spatial/geom/stargazers","contributors_url":"https://api.github.com/repos/go-spatial/geom/contributors","subscribers_url":"https://api.github.com/repos/go-spatial/geom/subscribers","subscription_url":"https://api.github.com/repos/go-spatial/geom/subscription","commits_url":"https://api.github.com/repos/go-spatial/geom/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-spatial/geom/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-spatial/geom/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-spatial/geom/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-spatial/geom/contents/{+path}","compare_url":"https://api.github.com/repos/go-spatial/geom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-spatial/geom/merges","archive_url":"https://api.github.com/repos/go-spatial/geom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-spatial/geom/downloads","issues_url":"https://api.github.com/repos/go-spatial/geom/issues{/number}","pulls_url":"https://api.github.com/repos/go-spatial/geom/pulls{/number}","milestones_url":"https://api.github.com/repos/go-spatial/geom/milestones{/number}","notifications_url":"https://api.github.com/repos/go-spatial/geom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-spatial/geom/labels{/name}","releases_url":"https://api.github.com/repos/go-spatial/geom/releases{/id}","deployments_url":"https://api.github.com/repos/go-spatial/geom/deployments","created_at":"2017-09-01T19:19:38Z","updated_at":"2017-09-10T19:14:59Z","pushed_at":"2017-09-16T04:05:19Z","git_url":"git://github.com/go-spatial/geom.git","ssh_url":"git@github.com:go-spatial/geom.git","clone_url":"https://github.com/go-spatial/geom.git","svn_url":"https://github.com/go-spatial/geom","homepage":null,"size":16,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"go-spatial:master","ref":"master","sha":"288848ad6eb635f442f61fba0020135064850c9d","user":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"repo":{"id":102145722,"name":"geom","full_name":"go-spatial/geom","owner":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-spatial/geom","description":"Geometry interfaces to help drive interoperability within the Go geospatial community","fork":false,"url":"https://api.github.com/repos/go-spatial/geom","forks_url":"https://api.github.com/repos/go-spatial/geom/forks","keys_url":"https://api.github.com/repos/go-spatial/geom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-spatial/geom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-spatial/geom/teams","hooks_url":"https://api.github.com/repos/go-spatial/geom/hooks","issue_events_url":"https://api.github.com/repos/go-spatial/geom/issues/events{/number}","events_url":"https://api.github.com/repos/go-spatial/geom/events","assignees_url":"https://api.github.com/repos/go-spatial/geom/assignees{/user}","branches_url":"https://api.github.com/repos/go-spatial/geom/branches{/branch}","tags_url":"https://api.github.com/repos/go-spatial/geom/tags","blobs_url":"https://api.github.com/repos/go-spatial/geom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-spatial/geom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-spatial/geom/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-spatial/geom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-spatial/geom/statuses/{sha}","languages_url":"https://api.github.com/repos/go-spatial/geom/languages","stargazers_url":"https://api.github.com/repos/go-spatial/geom/stargazers","contributors_url":"https://api.github.com/repos/go-spatial/geom/contributors","subscribers_url":"https://api.github.com/repos/go-spatial/geom/subscribers","subscription_url":"https://api.github.com/repos/go-spatial/geom/subscription","commits_url":"https://api.github.com/repos/go-spatial/geom/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-spatial/geom/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-spatial/geom/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-spatial/geom/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-spatial/geom/contents/{+path}","compare_url":"https://api.github.com/repos/go-spatial/geom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-spatial/geom/merges","archive_url":"https://api.github.com/repos/go-spatial/geom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-spatial/geom/downloads","issues_url":"https://api.github.com/repos/go-spatial/geom/issues{/number}","pulls_url":"https://api.github.com/repos/go-spatial/geom/pulls{/number}","milestones_url":"https://api.github.com/repos/go-spatial/geom/milestones{/number}","notifications_url":"https://api.github.com/repos/go-spatial/geom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-spatial/geom/labels{/name}","releases_url":"https://api.github.com/repos/go-spatial/geom/releases{/id}","deployments_url":"https://api.github.com/repos/go-spatial/geom/deployments","created_at":"2017-09-01T19:19:38Z","updated_at":"2017-09-10T19:14:59Z","pushed_at":"2017-09-16T04:05:19Z","git_url":"git://github.com/go-spatial/geom.git","ssh_url":"git@github.com:go-spatial/geom.git","clone_url":"https://github.com/go-spatial/geom.git","svn_url":"https://github.com/go-spatial/geom","homepage":null,"size":16,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/1"},"html":{"href":"https://github.com/go-spatial/geom/pull/1"},"issue":{"href":"https://api.github.com/repos/go-spatial/geom/issues/1"},"comments":{"href":"https://api.github.com/repos/go-spatial/geom/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-spatial/geom/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/go-spatial/geom/statuses/8ce029608164c233a1126cd18bfdb20f81775e12"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gdey"}}