{"action":"created","issue":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1891","repository_url":"https://api.github.com/repos/Minecolonies/minecolonies","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1891/labels{/name}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1891/comments","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1891/events","html_url":"https://github.com/Minecolonies/minecolonies/pull/1891","id":284006170,"number":1891,"title":"Port/1.11 features","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-21T21:13:52Z","updated_at":"2017-12-21T21:19:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1891","html_url":"https://github.com/Minecolonies/minecolonies/pull/1891","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1891.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1891.patch"},"body":"Port some stuff to 1.11\r\n\r\nReview please\r\n"},"comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments/353460367","html_url":"https://github.com/Minecolonies/minecolonies/pull/1891#issuecomment-353460367","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1891","id":353460367,"user":{"login":"BuildTeamLinter","id":30551110,"avatar_url":"https://avatars0.githubusercontent.com/u/30551110?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildTeamLinter","html_url":"https://github.com/BuildTeamLinter","followers_url":"https://api.github.com/users/BuildTeamLinter/followers","following_url":"https://api.github.com/users/BuildTeamLinter/following{/other_user}","gists_url":"https://api.github.com/users/BuildTeamLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildTeamLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildTeamLinter/subscriptions","organizations_url":"https://api.github.com/users/BuildTeamLinter/orgs","repos_url":"https://api.github.com/users/BuildTeamLinter/repos","events_url":"https://api.github.com/users/BuildTeamLinter/events{/privacy}","received_events_url":"https://api.github.com/users/BuildTeamLinter/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T21:19:40Z","updated_at":"2017-12-21T21:19:40Z","author_association":"NONE","body":"SonarQube analysis reported 110 issues\n* ![CRITICAL][CRITICAL] 6 critical\n* ![MAJOR][MAJOR] 44 major\n* ![MINOR][MINOR] 56 minor\n* ![INFO][INFO] 4 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1374](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1374): Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1452)\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1440](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1440): Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1452)\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1471](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1471): Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1452)\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1483](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1483): Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1452)\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1589](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1589): Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1452)\n1. ![CRITICAL][CRITICAL] [AbstractBuilding.java#L1701](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/buildings/AbstractBuilding.java#L1701): Missing curly brace. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS00121)\n1. ![MAJOR][MAJOR] [Colony.java#](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/Colony.java#): This file has 1,409 lines, which is greater than 1,000 authorized. Split it into smaller files. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS00104)\n1. ![MAJOR][MAJOR] [Colony.java#L62](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/Colony.java#L62): Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 51 to the maximum authorized 30 or less. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1200)\n1. ![MAJOR][MAJOR] [Colony.java#L62](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/Colony.java#L62): class \"Colony\" has 102 methods, which is greater than the 35 authorized. Split it into smaller classes. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1448)\n1. ![MAJOR][MAJOR] [Colony.java#L651](https://github.com/Minecolonies/minecolonies/blob/cbcaaddf07e4539aa9e7d8a172123d745053c87f/src/main/java/com/minecolonies/coremod/colony/Colony.java#L651): Reduce the number of returns of this method 11, down to the maximum allowed 6. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1142)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"BuildTeamLinter"}}