{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/119306542","pull_request_review_id":41171696,"id":119306542,"diff_hunk":"@@ -154,42 +128,50 @@ func runStart(cmd *cobra.Command, args []string) {\n \t}\n \n \t//Create the host directories if not present\n-\thostDirs := []string{viper.GetString(startFlags.HostConfigDir.Name),\n-\t\tviper.GetString(startFlags.HostDataDir.Name), viper.GetString(startFlags.HostVolumeDir.Name),\n-\t\tviper.GetString(startFlags.HostPvDir.Name)}\n-\terr = clusterup.EnsureHostDirectoriesExist(libMachineClient, hostDirs)\n-\tif err != nil {\n-\t\tfmt.Println(\"Error creating required host directories: \", err)\n-\t\tatexit.Exit(1)\n+\thostDirs := []string{\n+\t\tviper.GetString(startFlags.HostConfigDir.Name),\n+\t\tviper.GetString(startFlags.HostDataDir.Name),\n+\t\tviper.GetString(startFlags.HostVolumeDir.Name),\n+\t\tviper.GetString(startFlags.HostPvDir.Name),\n \t}\n-\n-\tip, err := host.Driver.GetIP()\n+\terr = clusterup.EnsureHostDirectoriesExist(hostVm, hostDirs)\n \tif err != nil {\n-\t\tfmt.Println(\"Error determining host ip: \", err)\n-\t\tatexit.Exit(1)\n+\t\tatexit.ExitWithMessage(1, fmt.Sprintf(\"Error creating required host directories: %v\", err))\n \t}\n \n-\tif proxyConfig.IsEnabled() {\n-\t\t// once we know the IP, we need to make sure it is not proxied in a proxy environment\n-\t\tproxyConfig.AddNoProxy(ip)\n-\t\tproxyConfig.ApplyToEnvironment()\n+\tautoMountHostFolders(hostVm.Driver)\n+\n+\topenShiftVersion := clusterup.DetermineOpenShiftVersion(viper.GetString(startFlags.OpenshiftVersion.Name))\n+\tclusterUpConfig := &clusterup.ClusterUpConfig{\n+\t\tOpenShiftVersion: openShiftVersion,\n+\t\tMachineName:      constants.MachineName,\n+\t\tIp:               ip,\n+\t\tPort:             constants.APIServerPort,\n+\t\tRoutingSuffix:    viper.GetString(startFlags.RoutingSuffix.Name),\n+\t\tHostPvDir:        viper.GetString(startFlags.HostPvDir.Name),\n+\t\tUser:             defaultUser,\n+\t\tProject:          defaultProject,\n+\t\tKubeConfigPath:   constants.KubeConfigPath,\n+\t\tOcPath:           cacheOc(openShiftVersion),","path":"cmd/minishift/cmd/start.go","position":181,"original_position":181,"commit_id":"3f5ac386a7f371896a8bb15427d3fe5cee029ce2","original_commit_id":"3f5ac386a7f371896a8bb15427d3fe5cee029ce2","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars3.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"I see yeha, maybe the `cacheOc` should not happen here. It is a function that does too much","created_at":"2017-05-31T09:03:25Z","updated_at":"2017-05-31T09:03:25Z","html_url":"https://github.com/minishift/minishift/pull/962#discussion_r119306542","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/962","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/119306542"},"html":{"href":"https://github.com/minishift/minishift/pull/962#discussion_r119306542"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/962"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/962","id":122881387,"html_url":"https://github.com/minishift/minishift/pull/962","diff_url":"https://github.com/minishift/minishift/pull/962.diff","patch_url":"https://github.com/minishift/minishift/pull/962.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/962","number":962,"state":"open","locked":false,"title":"Issue #409 Refactoring start.go","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"- Introducing ClusterUpConfig struct to separate Viper flags processing from 'cluster up' call\r\n- Moving ClusterUp and PostClusterUp into own package under pks, since they are now independent of the command\r\n- Updated tests","created_at":"2017-05-29T11:59:58Z","updated_at":"2017-05-31T09:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f410094d23e12c17078ca8111ad5af36012c7337","assignee":{"login":"gbraad","id":1894,"avatar_url":"https://avatars3.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"assignees":[{"login":"gbraad","id":1894,"avatar_url":"https://avatars3.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/962/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/962/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/962/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/3f5ac386a7f371896a8bb15427d3fe5cee029ce2","head":{"label":"hferentschik:issue-409","ref":"issue-409","sha":"3f5ac386a7f371896a8bb15427d3fe5cee029ce2","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"repo":{"id":62797899,"name":"minishift","full_name":"hferentschik/minishift","owner":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hferentschik/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/hferentschik/minishift","forks_url":"https://api.github.com/repos/hferentschik/minishift/forks","keys_url":"https://api.github.com/repos/hferentschik/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hferentschik/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hferentschik/minishift/teams","hooks_url":"https://api.github.com/repos/hferentschik/minishift/hooks","issue_events_url":"https://api.github.com/repos/hferentschik/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/hferentschik/minishift/events","assignees_url":"https://api.github.com/repos/hferentschik/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/hferentschik/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/hferentschik/minishift/tags","blobs_url":"https://api.github.com/repos/hferentschik/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hferentschik/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hferentschik/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/hferentschik/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hferentschik/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/hferentschik/minishift/languages","stargazers_url":"https://api.github.com/repos/hferentschik/minishift/stargazers","contributors_url":"https://api.github.com/repos/hferentschik/minishift/contributors","subscribers_url":"https://api.github.com/repos/hferentschik/minishift/subscribers","subscription_url":"https://api.github.com/repos/hferentschik/minishift/subscription","commits_url":"https://api.github.com/repos/hferentschik/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/hferentschik/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/hferentschik/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/hferentschik/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/hferentschik/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/hferentschik/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hferentschik/minishift/merges","archive_url":"https://api.github.com/repos/hferentschik/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hferentschik/minishift/downloads","issues_url":"https://api.github.com/repos/hferentschik/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/hferentschik/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/hferentschik/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/hferentschik/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hferentschik/minishift/labels{/name}","releases_url":"https://api.github.com/repos/hferentschik/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/hferentschik/minishift/deployments","created_at":"2016-07-07T10:20:01Z","updated_at":"2016-07-07T10:20:03Z","pushed_at":"2017-05-31T08:49:12Z","git_url":"git://github.com/hferentschik/minishift.git","ssh_url":"git@github.com:hferentschik/minishift.git","clone_url":"https://github.com/hferentschik/minishift.git","svn_url":"https://github.com/hferentschik/minishift","homepage":null,"size":161883,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"2681e24226dc3d1b2b54f389863ce84c40ce4392","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-05-30T06:59:25Z","pushed_at":"2017-05-31T08:49:14Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":156701,"stargazers_count":429,"watchers_count":429,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":171,"forks":97,"open_issues":171,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/962"},"html":{"href":"https://github.com/minishift/minishift/pull/962"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/962"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/962/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/962/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/962/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/3f5ac386a7f371896a8bb15427d3fe5cee029ce2"}}}}
{"actor":{"display_login":"gbraad"}}