{"action":"closed","number":246,"pull_request":{"url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246","id":147952516,"html_url":"https://github.com/schrodinger/fixed-data-table-2/pull/246","diff_url":"https://github.com/schrodinger/fixed-data-table-2/pull/246.diff","patch_url":"https://github.com/schrodinger/fixed-data-table-2/pull/246.patch","issue_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/246","number":246,"state":"closed","locked":false,"title":"Implementation of reorder and resize for touch devices.","user":{"login":"SirGandal","id":5107404,"avatar_url":"https://avatars1.githubusercontent.com/u/5107404?v=4","gravatar_id":"","url":"https://api.github.com/users/SirGandal","html_url":"https://github.com/SirGandal","followers_url":"https://api.github.com/users/SirGandal/followers","following_url":"https://api.github.com/users/SirGandal/following{/other_user}","gists_url":"https://api.github.com/users/SirGandal/gists{/gist_id}","starred_url":"https://api.github.com/users/SirGandal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirGandal/subscriptions","organizations_url":"https://api.github.com/users/SirGandal/orgs","repos_url":"https://api.github.com/users/SirGandal/repos","events_url":"https://api.github.com/users/SirGandal/events{/privacy}","received_events_url":"https://api.github.com/users/SirGandal/received_events","type":"User","site_admin":false},"body":"Enable reordering and resizing on touch devices. Based on the comments of @wcjordan on #236 this functionality should be turned on only if touchScrollEnabled is set to true.\r\n\r\n## Description\r\n- Addition of helper file _FixedDataTableEventHelper_ to extract x and y coordinates from either mouse or touch events.\r\n- Extended _DOMMouseMoveTracker_ to account for touch events other than mouse events. Touch events trigger the same methods as their mouse equivalent,\r\n- Added _touchEnabled_ property to _FixedDataTableCell_, _FixedDataTableCellGroup_, _FixedDataTableColumnResizeHandle_, _FixedDataTableColumnReorderHandle_ and _FixedDataTableRow_. None of these files are part of the public API so we should be fine. This is needed to propagate the _touchScrollEnabled_ property down to the _DOMMouseMoveTracker_ where we bind listeners to touch events.\r\n- Added _touch-action: none;_ CSS rule to resize and reorder handles. This is needed since event.preventDefault() is used in a couple of places. Despite that works fine on mouse events, preventDefault logs a warning in console unless that rule is applied: \"Unable to preventDefault inside passive event listener due to target being treated as passive.\"\r\n\r\n## Motivation and Context\r\nSince we are able to scroll on touch devices I believe that all the other functionalities (in this case reorder and resize) should work on touch devices as well.\r\nExisting issue: #164 \r\n\r\n## How Has This Been Tested?\r\nTested with device simulator in Chrome on Linux and Windows, on iPad running iOS 10.1.1 and Nexus 7 2013 running on Android 5.1.1.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n","created_at":"2017-10-21T16:57:18Z","updated_at":"2017-10-23T04:08:00Z","closed_at":"2017-10-23T04:08:00Z","merged_at":"2017-10-23T04:08:00Z","merge_commit_sha":"fa81d66013e1c3e6d45bd80dfea7d21466765a47","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246/commits","review_comments_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246/comments","review_comment_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/246/comments","statuses_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/statuses/74676600f89a01584fed9e6ea83e1fe13d5dbd99","head":{"label":"SirGandal:resize-reorder-handle-touch","ref":"resize-reorder-handle-touch","sha":"74676600f89a01584fed9e6ea83e1fe13d5dbd99","user":{"login":"SirGandal","id":5107404,"avatar_url":"https://avatars1.githubusercontent.com/u/5107404?v=4","gravatar_id":"","url":"https://api.github.com/users/SirGandal","html_url":"https://github.com/SirGandal","followers_url":"https://api.github.com/users/SirGandal/followers","following_url":"https://api.github.com/users/SirGandal/following{/other_user}","gists_url":"https://api.github.com/users/SirGandal/gists{/gist_id}","starred_url":"https://api.github.com/users/SirGandal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirGandal/subscriptions","organizations_url":"https://api.github.com/users/SirGandal/orgs","repos_url":"https://api.github.com/users/SirGandal/repos","events_url":"https://api.github.com/users/SirGandal/events{/privacy}","received_events_url":"https://api.github.com/users/SirGandal/received_events","type":"User","site_admin":false},"repo":{"id":104525990,"name":"fixed-data-table-2_RTR","full_name":"SirGandal/fixed-data-table-2_RTR","owner":{"login":"SirGandal","id":5107404,"avatar_url":"https://avatars1.githubusercontent.com/u/5107404?v=4","gravatar_id":"","url":"https://api.github.com/users/SirGandal","html_url":"https://github.com/SirGandal","followers_url":"https://api.github.com/users/SirGandal/followers","following_url":"https://api.github.com/users/SirGandal/following{/other_user}","gists_url":"https://api.github.com/users/SirGandal/gists{/gist_id}","starred_url":"https://api.github.com/users/SirGandal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirGandal/subscriptions","organizations_url":"https://api.github.com/users/SirGandal/orgs","repos_url":"https://api.github.com/users/SirGandal/repos","events_url":"https://api.github.com/users/SirGandal/events{/privacy}","received_events_url":"https://api.github.com/users/SirGandal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SirGandal/fixed-data-table-2_RTR","description":"A React table component designed to allow presenting millions of rows of data.","fork":true,"url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR","forks_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/forks","keys_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/teams","hooks_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/hooks","issue_events_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/issues/events{/number}","events_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/events","assignees_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/assignees{/user}","branches_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/branches{/branch}","tags_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/tags","blobs_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/git/refs{/sha}","trees_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/statuses/{sha}","languages_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/languages","stargazers_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/stargazers","contributors_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/contributors","subscribers_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/subscribers","subscription_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/subscription","commits_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/commits{/sha}","git_commits_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/git/commits{/sha}","comments_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/comments{/number}","issue_comment_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/issues/comments{/number}","contents_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/contents/{+path}","compare_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/merges","archive_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/downloads","issues_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/issues{/number}","pulls_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/pulls{/number}","milestones_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/milestones{/number}","notifications_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/labels{/name}","releases_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/releases{/id}","deployments_url":"https://api.github.com/repos/SirGandal/fixed-data-table-2_RTR/deployments","created_at":"2017-09-22T23:12:17Z","updated_at":"2017-10-01T16:04:13Z","pushed_at":"2017-10-23T03:47:11Z","git_url":"git://github.com/SirGandal/fixed-data-table-2_RTR.git","ssh_url":"git@github.com:SirGandal/fixed-data-table-2_RTR.git","clone_url":"https://github.com/SirGandal/fixed-data-table-2_RTR.git","svn_url":"https://github.com/SirGandal/fixed-data-table-2_RTR","homepage":"http://schrodinger.github.io/fixed-data-table-2/","size":8749,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"schrodinger:master","ref":"master","sha":"5b53d08e531a1b733771063714252c53364f7d5d","user":{"login":"schrodinger","id":724753,"avatar_url":"https://avatars3.githubusercontent.com/u/724753?v=4","gravatar_id":"","url":"https://api.github.com/users/schrodinger","html_url":"https://github.com/schrodinger","followers_url":"https://api.github.com/users/schrodinger/followers","following_url":"https://api.github.com/users/schrodinger/following{/other_user}","gists_url":"https://api.github.com/users/schrodinger/gists{/gist_id}","starred_url":"https://api.github.com/users/schrodinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schrodinger/subscriptions","organizations_url":"https://api.github.com/users/schrodinger/orgs","repos_url":"https://api.github.com/users/schrodinger/repos","events_url":"https://api.github.com/users/schrodinger/events{/privacy}","received_events_url":"https://api.github.com/users/schrodinger/received_events","type":"Organization","site_admin":false},"repo":{"id":52289723,"name":"fixed-data-table-2","full_name":"schrodinger/fixed-data-table-2","owner":{"login":"schrodinger","id":724753,"avatar_url":"https://avatars3.githubusercontent.com/u/724753?v=4","gravatar_id":"","url":"https://api.github.com/users/schrodinger","html_url":"https://github.com/schrodinger","followers_url":"https://api.github.com/users/schrodinger/followers","following_url":"https://api.github.com/users/schrodinger/following{/other_user}","gists_url":"https://api.github.com/users/schrodinger/gists{/gist_id}","starred_url":"https://api.github.com/users/schrodinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schrodinger/subscriptions","organizations_url":"https://api.github.com/users/schrodinger/orgs","repos_url":"https://api.github.com/users/schrodinger/repos","events_url":"https://api.github.com/users/schrodinger/events{/privacy}","received_events_url":"https://api.github.com/users/schrodinger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/schrodinger/fixed-data-table-2","description":"A React table component designed to allow presenting millions of rows of data.","fork":false,"url":"https://api.github.com/repos/schrodinger/fixed-data-table-2","forks_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/forks","keys_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/teams","hooks_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/hooks","issue_events_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/events{/number}","events_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/events","assignees_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/assignees{/user}","branches_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/branches{/branch}","tags_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/tags","blobs_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/statuses/{sha}","languages_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/languages","stargazers_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/stargazers","contributors_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/contributors","subscribers_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/subscribers","subscription_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/subscription","commits_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/contents/{+path}","compare_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/merges","archive_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/downloads","issues_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues{/number}","pulls_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls{/number}","milestones_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/milestones{/number}","notifications_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/labels{/name}","releases_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/releases{/id}","deployments_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/deployments","created_at":"2016-02-22T17:02:05Z","updated_at":"2017-10-22T15:43:11Z","pushed_at":"2017-10-23T04:08:00Z","git_url":"git://github.com/schrodinger/fixed-data-table-2.git","ssh_url":"git@github.com:schrodinger/fixed-data-table-2.git","clone_url":"https://github.com/schrodinger/fixed-data-table-2.git","svn_url":"https://github.com/schrodinger/fixed-data-table-2","homepage":"http://schrodinger.github.io/fixed-data-table-2/","size":8685,"stargazers_count":445,"watchers_count":445,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":49,"forks":106,"open_issues":49,"watchers":445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246"},"html":{"href":"https://github.com/schrodinger/fixed-data-table-2/pull/246"},"issue":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/246"},"comments":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/schrodinger/fixed-data-table-2/statuses/74676600f89a01584fed9e6ea83e1fe13d5dbd99"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wcjordan","id":1034455,"avatar_url":"https://avatars0.githubusercontent.com/u/1034455?v=4","gravatar_id":"","url":"https://api.github.com/users/wcjordan","html_url":"https://github.com/wcjordan","followers_url":"https://api.github.com/users/wcjordan/followers","following_url":"https://api.github.com/users/wcjordan/following{/other_user}","gists_url":"https://api.github.com/users/wcjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/wcjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcjordan/subscriptions","organizations_url":"https://api.github.com/users/wcjordan/orgs","repos_url":"https://api.github.com/users/wcjordan/repos","events_url":"https://api.github.com/users/wcjordan/events{/privacy}","received_events_url":"https://api.github.com/users/wcjordan/received_events","type":"User","site_admin":false},"comments":1,"review_comments":22,"maintainer_can_modify":false,"commits":4,"additions":148,"deletions":13,"changed_files":8}}
{"actor":{"display_login":"wcjordan"}}