{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1250","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1250/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1250/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1250/events","html_url":"https://github.com/shopware/shopware/pull/1250","id":252553713,"number":1250,"title":"Show Growl message when creating order document","user":{"login":"samuelvogel","id":710188,"avatar_url":"https://avatars1.githubusercontent.com/u/710188?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelvogel","html_url":"https://github.com/samuelvogel","followers_url":"https://api.github.com/users/samuelvogel/followers","following_url":"https://api.github.com/users/samuelvogel/following{/other_user}","gists_url":"https://api.github.com/users/samuelvogel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelvogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelvogel/subscriptions","organizations_url":"https://api.github.com/users/samuelvogel/orgs","repos_url":"https://api.github.com/users/samuelvogel/repos","events_url":"https://api.github.com/users/samuelvogel/events{/privacy}","received_events_url":"https://api.github.com/users/samuelvogel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-24T10:12:32Z","updated_at":"2017-08-28T09:55:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1250","html_url":"https://github.com/shopware/shopware/pull/1250","diff_url":"https://github.com/shopware/shopware/pull/1250.diff","patch_url":"https://github.com/shopware/shopware/pull/1250.patch"},"body":"<!--\r\nThank you for contributing to Shopware! Please fill out this description template to help us to process your pull request.\r\n\r\nPlease make sure to fulfil our contribution guideline (https://developers.shopware.com/contributing/contribution-guideline/).\r\n-->\r\n\r\n### 1. Why is this change necessary?\r\nWhen creating a document for an order in the backend there is neither a success nor a failure message. The document just appears in the list, but especially when recreating/overwriting a document it is not distinguishable when the action is actually finished. This is even more annoying, when an error occurs while creating the document. The problem is not visible for users at all and painful debugging ensues...\r\n\r\n### 2. What does this change do, exactly?\r\nShow success and error growl messages when creating an order document. The respective snippets for this where already present in the code BTW but never used.\r\n![document-message](https://user-images.githubusercontent.com/710188/29661736-3fd85902-88c5-11e7-8d56-46b90cb99b9f.png)\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\nCreate a document in the backend and a success message should be shown. For some mPDF errors (missing rights on `files/documents` or no disk space for example) there will still be no correct error message unfortunately. The currently shipped mPDF version responds with an error string instead of throwing an exception (leading to a `200 OK` HTTP code, which will not be interpreted as a failure). This was fixed with mPDF `v6.1.0` (see https://github.com/mpdf/mpdf/commit/2d02c208b8d7b15c4208517375b9a10b0ea7cefa), once mPDF gets updated these exceptions will be shown as well.\r\n\r\n### 4. Please link to the relevant issues (if any).\r\nn/a\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nNone\r\n\r\n### 6. Checklist\r\n\r\n- [X] I have written tests and verified that they fail without my change\r\n- [X] I have squashed any insignificant commits\r\n- [X] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [X] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/325312077","html_url":"https://github.com/shopware/shopware/pull/1250#issuecomment-325312077","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1250","id":325312077,"user":{"login":"shopwareBot","id":4725494,"avatar_url":"https://avatars1.githubusercontent.com/u/4725494?v=4","gravatar_id":"","url":"https://api.github.com/users/shopwareBot","html_url":"https://github.com/shopwareBot","followers_url":"https://api.github.com/users/shopwareBot/followers","following_url":"https://api.github.com/users/shopwareBot/following{/other_user}","gists_url":"https://api.github.com/users/shopwareBot/gists{/gist_id}","starred_url":"https://api.github.com/users/shopwareBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopwareBot/subscriptions","organizations_url":"https://api.github.com/users/shopwareBot/orgs","repos_url":"https://api.github.com/users/shopwareBot/repos","events_url":"https://api.github.com/users/shopwareBot/events{/privacy}","received_events_url":"https://api.github.com/users/shopwareBot/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T09:55:06Z","updated_at":"2017-08-28T09:55:06Z","body":"Hello,\n\nthank you for creating this pull request.\nI have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19761.\n\nPlease use this issue to track the state of your pull request."}}
{"actor":{"display_login":"shopwareBot"}}