{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/142778017","pull_request_review_id":67182262,"id":142778017,"diff_hunk":"@@ -0,0 +1,69 @@\n+#!/usr/bin/ansible-playbook\n+---\n+- hosts: localhost\n+  gather_facts: yes\n+  vars:\n+    origin_dns:\n+      file: /etc/dnsmasq.d/origin-dns.conf\n+      lines:\n+      - regex: ^listen-address\n+        state: present\n+        line: \"listen-address={{ ansible_default_ipv4.address }}\"\n+    node_dns:\n+      file: /etc/dnsmasq.d/node-dnsmasq.conf\n+      lines:\n+      - regex: \"^server=/in-addr.arpa/127.0.0.1$\"\n+        line: server=/in-addr.arpa/127.0.0.1\n+      - regex: \"^server=/cluster.local/127.0.0.1$\"\n+        line: server=/cluster.local/127.0.0.1\n+\n+  tasks:\n+  - include_vars: openshift_settings.yaml","path":"roles/openshift_node/files/bootstrap.yml","position":21,"original_position":21,"commit_id":"7fe166883781703ee8baf199b3eb34b77757d5b5","original_commit_id":"7fe166883781703ee8baf199b3eb34b77757d5b5","user":{"login":"michaelgugino","id":6255238,"avatar_url":"https://avatars0.githubusercontent.com/u/6255238?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelgugino","html_url":"https://github.com/michaelgugino","followers_url":"https://api.github.com/users/michaelgugino/followers","following_url":"https://api.github.com/users/michaelgugino/following{/other_user}","gists_url":"https://api.github.com/users/michaelgugino/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgugino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgugino/subscriptions","organizations_url":"https://api.github.com/users/michaelgugino/orgs","repos_url":"https://api.github.com/users/michaelgugino/repos","events_url":"https://api.github.com/users/michaelgugino/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgugino/received_events","type":"User","site_admin":false},"body":"Where are we getting these settings?","created_at":"2017-10-04T20:05:41Z","updated_at":"2017-10-04T20:08:56Z","html_url":"https://github.com/openshift/openshift-ansible/pull/5361#discussion_r142778017","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/142778017"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/5361#discussion_r142778017"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361","id":140401047,"html_url":"https://github.com/openshift/openshift-ansible/pull/5361","diff_url":"https://github.com/openshift/openshift-ansible/pull/5361.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/5361.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5361","number":5361,"state":"open","locked":false,"title":"Provisioning updates.","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"These are provisioning updates and features that allow node bootstrapping.\r\n\r\nList of updates:\r\n- Removed the need to specify `openshift_node_bootstrap` in ami creation.\r\n- Skip failures in evaluate groups if no etcd hosts are defined\r\n- More default variables for the openshift_aws role\r\n  - Termination policy for scale groups\r\n  - replace instances or replace all\r\n  - label support\r\n  - ability to run bootstrap.yml on startup\r\n  - moved the logic of the user_data into a template\r\n  - remove any openshift.fact files because ami creation and where the node ends up are different\r\n  - install bootstrap.yml into AMI\r\n  - variable to turn on/off - run the bootstrap.yml on start\r\n  - install openshift-ansible-roles into AMI for later boot use (use yedit to modify files)\r\n  - override the user_data if desired\r\n- Added the feature to create a configmap per node group\r\n- Added default variables for openshift_master to support node group configmaps\r\n  - config dir\r\n  - cloud provider\r\n  - node-config settings\r\n    - kubeletargs\r\n    - node labels\r\n\r\nInstead of using a template for the node-config.yaml, we call `oc adm create-node-config`.  We have a list of edits that occur to clean up the generation before it is specialized for each node group.  Once each node group has specialized their own copy they are placed in the kube-system namespace with the name node-config-<group type> configmap.\r\n\r\nThis is going to require code changes from @smarterclayton to take the configmap and lay it down as the node-config.yaml.","created_at":"2017-09-11T18:14:14Z","updated_at":"2017-10-04T20:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0af4f45b20e64c4abd2f85d56e4c967478234754","assignee":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"assignees":[{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sdodson","id":48161,"avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5361/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7fe166883781703ee8baf199b3eb34b77757d5b5","head":{"label":"kwoodson:fix_bootstrap_files","ref":"fix_bootstrap_files","sha":"7fe166883781703ee8baf199b3eb34b77757d5b5","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"repo":{"id":27775666,"name":"openshift-ansible","full_name":"kwoodson/openshift-ansible","owner":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwoodson/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/kwoodson/openshift-ansible","forks_url":"https://api.github.com/repos/kwoodson/openshift-ansible/forks","keys_url":"https://api.github.com/repos/kwoodson/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwoodson/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwoodson/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/kwoodson/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/kwoodson/openshift-ansible/events","assignees_url":"https://api.github.com/repos/kwoodson/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/kwoodson/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/kwoodson/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwoodson/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/kwoodson/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/kwoodson/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/kwoodson/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/kwoodson/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/kwoodson/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/kwoodson/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwoodson/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwoodson/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/kwoodson/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwoodson/openshift-ansible/merges","archive_url":"https://api.github.com/repos/kwoodson/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwoodson/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/kwoodson/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/kwoodson/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/kwoodson/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwoodson/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/kwoodson/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/kwoodson/openshift-ansible/deployments","created_at":"2014-12-09T16:28:41Z","updated_at":"2016-12-04T16:26:45Z","pushed_at":"2017-10-04T13:46:13Z","git_url":"git://github.com/kwoodson/openshift-ansible.git","ssh_url":"git@github.com:kwoodson/openshift-ansible.git","clone_url":"https://github.com/kwoodson/openshift-ansible.git","svn_url":"https://github.com/kwoodson/openshift-ansible","homepage":"","size":18180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a25709a6f16913b59ef2edc3e07d8bc8a598f41e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-10-04T14:31:06Z","pushed_at":"2017-10-04T20:01:17Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":18191,"stargazers_count":567,"watchers_count":567,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":896,"mirror_url":null,"open_issues_count":576,"forks":896,"open_issues":576,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/5361"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/5361"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/5361/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5361/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7fe166883781703ee8baf199b3eb34b77757d5b5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"michaelgugino"}}