{"action":"created","issue":{"url":"https://api.github.com/repos/cronvel/terminal-kit/issues/47","repository_url":"https://api.github.com/repos/cronvel/terminal-kit","labels_url":"https://api.github.com/repos/cronvel/terminal-kit/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/cronvel/terminal-kit/issues/47/comments","events_url":"https://api.github.com/repos/cronvel/terminal-kit/issues/47/events","html_url":"https://github.com/cronvel/terminal-kit/pull/47","id":256053692,"number":47,"title":"Spaceship demo hangs forever on Git-Bash","user":{"login":"zolem","id":7129911,"avatar_url":"https://avatars1.githubusercontent.com/u/7129911?v=4","gravatar_id":"","url":"https://api.github.com/users/zolem","html_url":"https://github.com/zolem","followers_url":"https://api.github.com/users/zolem/followers","following_url":"https://api.github.com/users/zolem/following{/other_user}","gists_url":"https://api.github.com/users/zolem/gists{/gist_id}","starred_url":"https://api.github.com/users/zolem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolem/subscriptions","organizations_url":"https://api.github.com/users/zolem/orgs","repos_url":"https://api.github.com/users/zolem/repos","events_url":"https://api.github.com/users/zolem/events{/privacy}","received_events_url":"https://api.github.com/users/zolem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-07T20:02:04Z","updated_at":"2017-09-07T20:13:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cronvel/terminal-kit/pulls/47","html_url":"https://github.com/cronvel/terminal-kit/pull/47","diff_url":"https://github.com/cronvel/terminal-kit/pull/47.diff","patch_url":"https://github.com/cronvel/terminal-kit/pull/47.patch"},"body":"It looks like the while loop never finishes because process id becomes NaN at some point and never equals 1. Adding a condition that if pid is falsey then it will send the Terminal not found error."},"comment":{"url":"https://api.github.com/repos/cronvel/terminal-kit/issues/comments/327914986","html_url":"https://github.com/cronvel/terminal-kit/pull/47#issuecomment-327914986","issue_url":"https://api.github.com/repos/cronvel/terminal-kit/issues/47","id":327914986,"user":{"login":"zolem","id":7129911,"avatar_url":"https://avatars1.githubusercontent.com/u/7129911?v=4","gravatar_id":"","url":"https://api.github.com/users/zolem","html_url":"https://github.com/zolem","followers_url":"https://api.github.com/users/zolem/followers","following_url":"https://api.github.com/users/zolem/following{/other_user}","gists_url":"https://api.github.com/users/zolem/gists{/gist_id}","starred_url":"https://api.github.com/users/zolem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolem/subscriptions","organizations_url":"https://api.github.com/users/zolem/orgs","repos_url":"https://api.github.com/users/zolem/repos","events_url":"https://api.github.com/users/zolem/events{/privacy}","received_events_url":"https://api.github.com/users/zolem/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T20:13:48Z","updated_at":"2017-09-07T20:13:48Z","author_association":"NONE","body":"To give more context the 2 async child_process calls that call ps only ever return the help on git-bash because it must be used differently than on linux. Powershell and CMD obviously are significantly different as well. I am not sure if git-bash just doesn't include the linux version of ps and it defaults to the CMD ps command.\r\n\r\nI don't know if it would be helpful to update that code with a conditional to check if you are on windows and check if you are using a cygwin like terminal or powershell/cmd.\r\n\r\nI can't imagine you would need to do anything differently for CMD and powershell since supposedly in Windows 10 now they understand the ansi escape characters. But I wonder if we should attempt to use the full 24bit color xterm mode when in git-bash. I might test it a little doing that. Is there an option to force it to use a certain mode?"}}
{"actor":{"display_login":"zolem"}}