{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/2983","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/2983/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/2983/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/2983/events","html_url":"https://github.com/kubernetes/kops/issues/2983","id":243529211,"number":2983,"title":"Extend cli with cloud provider specific arguments","user":{"login":"matyix","id":6003104,"avatar_url":"https://avatars3.githubusercontent.com/u/6003104?v=4","gravatar_id":"","url":"https://api.github.com/users/matyix","html_url":"https://github.com/matyix","followers_url":"https://api.github.com/users/matyix/followers","following_url":"https://api.github.com/users/matyix/following{/other_user}","gists_url":"https://api.github.com/users/matyix/gists{/gist_id}","starred_url":"https://api.github.com/users/matyix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyix/subscriptions","organizations_url":"https://api.github.com/users/matyix/orgs","repos_url":"https://api.github.com/users/matyix/repos","events_url":"https://api.github.com/users/matyix/events{/privacy}","received_events_url":"https://api.github.com/users/matyix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-17T21:12:31Z","updated_at":"2017-08-29T21:23:52Z","closed_at":"2017-07-17T22:28:51Z","author_association":"NONE","body":"I'd like to extend the cli with cloud provider specific configs - whereas the easiest would be to just add it here - [Create Cluster](https://github.com/kubernetes/kops/blob/master/cmd/kops/create_cluster.go#L51) - this would  break the cross cloud provider functionality, as these items are provider specific, whereas this is generic. One example is AWS spot prices/bid/max arguments are different compared to Google's preemptible instances, and have no idea about VSpehere for instance. \r\n\r\nThere are some initiatives like [Cloud abstraction #2486](https://github.com/kubernetes/kops/pull/2486) and [WIP - Cloud Implementation #2487](https://github.com/kubernetes/kops/pull/2487) the question is which way is to move forward and submit the PR? Currently the PR it's agains the [Create Cluster](https://github.com/kubernetes/kops/blob/master/cmd/kops/create_cluster.go#L51) but I don't believe its a good solution at all. What is the short term recommendation (beside maintaining a fork) and what is the long term approach where the PR should be landed.\r\n\r\nThanks in advance."},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/325808603","html_url":"https://github.com/kubernetes/kops/issues/2983#issuecomment-325808603","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/2983","id":325808603,"user":{"login":"kris-nova","id":13757818,"avatar_url":"https://avatars2.githubusercontent.com/u/13757818?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-nova","html_url":"https://github.com/kris-nova","followers_url":"https://api.github.com/users/kris-nova/followers","following_url":"https://api.github.com/users/kris-nova/following{/other_user}","gists_url":"https://api.github.com/users/kris-nova/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-nova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-nova/subscriptions","organizations_url":"https://api.github.com/users/kris-nova/orgs","repos_url":"https://api.github.com/users/kris-nova/repos","events_url":"https://api.github.com/users/kris-nova/events{/privacy}","received_events_url":"https://api.github.com/users/kris-nova/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T21:23:52Z","updated_at":"2017-08-29T21:23:52Z","author_association":"MEMBER","body":":smiley: "}}
{"actor":{"display_login":"kris-nova"}}