{"action":"created","issue":{"url":"https://api.github.com/repos/Level/levelup/issues/481","repository_url":"https://api.github.com/repos/Level/levelup","labels_url":"https://api.github.com/repos/Level/levelup/issues/481/labels{/name}","comments_url":"https://api.github.com/repos/Level/levelup/issues/481/comments","events_url":"https://api.github.com/repos/Level/levelup/issues/481/events","html_url":"https://github.com/Level/levelup/pull/481","id":256713458,"number":481,"title":"Improve Typings","user":{"login":"MeirionHughes","id":3584509,"avatar_url":"https://avatars2.githubusercontent.com/u/3584509?v=4","gravatar_id":"","url":"https://api.github.com/users/MeirionHughes","html_url":"https://github.com/MeirionHughes","followers_url":"https://api.github.com/users/MeirionHughes/followers","following_url":"https://api.github.com/users/MeirionHughes/following{/other_user}","gists_url":"https://api.github.com/users/MeirionHughes/gists{/gist_id}","starred_url":"https://api.github.com/users/MeirionHughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeirionHughes/subscriptions","organizations_url":"https://api.github.com/users/MeirionHughes/orgs","repos_url":"https://api.github.com/users/MeirionHughes/repos","events_url":"https://api.github.com/users/MeirionHughes/events{/privacy}","received_events_url":"https://api.github.com/users/MeirionHughes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ralphtheninja","id":308049,"avatar_url":"https://avatars2.githubusercontent.com/u/308049?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphtheninja","html_url":"https://github.com/ralphtheninja","followers_url":"https://api.github.com/users/ralphtheninja/followers","following_url":"https://api.github.com/users/ralphtheninja/following{/other_user}","gists_url":"https://api.github.com/users/ralphtheninja/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphtheninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphtheninja/subscriptions","organizations_url":"https://api.github.com/users/ralphtheninja/orgs","repos_url":"https://api.github.com/users/ralphtheninja/repos","events_url":"https://api.github.com/users/ralphtheninja/events{/privacy}","received_events_url":"https://api.github.com/users/ralphtheninja/received_events","type":"User","site_admin":false},"assignees":[{"login":"ralphtheninja","id":308049,"avatar_url":"https://avatars2.githubusercontent.com/u/308049?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphtheninja","html_url":"https://github.com/ralphtheninja","followers_url":"https://api.github.com/users/ralphtheninja/followers","following_url":"https://api.github.com/users/ralphtheninja/following{/other_user}","gists_url":"https://api.github.com/users/ralphtheninja/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphtheninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphtheninja/subscriptions","organizations_url":"https://api.github.com/users/ralphtheninja/orgs","repos_url":"https://api.github.com/users/ralphtheninja/repos","events_url":"https://api.github.com/users/ralphtheninja/events{/privacy}","received_events_url":"https://api.github.com/users/ralphtheninja/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2017-09-11T14:01:28Z","updated_at":"2017-09-13T17:41:44Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/Level/levelup/pulls/481","html_url":"https://github.com/Level/levelup/pull/481","diff_url":"https://github.com/Level/levelup/pull/481.diff","patch_url":"https://github.com/Level/levelup/pull/481.patch"},"body":"refactor: use AbstractLevelDOWN typings.\r\nfeat: support declaration merging.\r\n\r\n>requires: https://github.com/Level/abstract-leveldown/pull/124 "},"comment":{"url":"https://api.github.com/repos/Level/levelup/issues/comments/329243244","html_url":"https://github.com/Level/levelup/pull/481#issuecomment-329243244","issue_url":"https://api.github.com/repos/Level/levelup/issues/481","id":329243244,"user":{"login":"MeirionHughes","id":3584509,"avatar_url":"https://avatars2.githubusercontent.com/u/3584509?v=4","gravatar_id":"","url":"https://api.github.com/users/MeirionHughes","html_url":"https://github.com/MeirionHughes","followers_url":"https://api.github.com/users/MeirionHughes/followers","following_url":"https://api.github.com/users/MeirionHughes/following{/other_user}","gists_url":"https://api.github.com/users/MeirionHughes/gists{/gist_id}","starred_url":"https://api.github.com/users/MeirionHughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeirionHughes/subscriptions","organizations_url":"https://api.github.com/users/MeirionHughes/orgs","repos_url":"https://api.github.com/users/MeirionHughes/repos","events_url":"https://api.github.com/users/MeirionHughes/events{/privacy}","received_events_url":"https://api.github.com/users/MeirionHughes/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T17:41:44Z","updated_at":"2017-09-13T17:41:44Z","author_association":"OWNER","body":"```ts\r\n levelup(encoding(leveldown('./db'), {valueEncoding:'utf8'}))\r\n```\r\n\r\nThat's typed correctly and working fine. \r\n\r\nHowever, levelup does pass its own options to the base db in `open`. So the options type you pass to levelup(..., options),  is currently typed (for levelup->encoding->leveldown) like: \r\n\r\n```ts\r\ntype Options = leveldown.LevelDownOptions & encoding.CodecOptions\r\n```\r\n\r\nand that options object does get used and passed to the base dbs via `open`. As far as I can tell, levelup's options don't seem to be used anywhere else within levelup? "}}
{"actor":{"display_login":"MeirionHughes"}}