{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/157908201","pull_request_review_id":84630090,"id":157908201,"diff_hunk":"@@ -3268,24 +3268,34 @@ NativeCodeGenerator::QueueFreeNativeCodeGenAllocation(void* codeAddress, void *\n     // OOP JIT will always queue a job\n \n     // The foreground allocators may have been used\n-    if(this->foregroundAllocators && this->foregroundAllocators->emitBufferManager.FreeAllocation(codeAddress))\n+    if(this->foregroundAllocators)\n     {\n-        return;\n+#if PDATA_ENABLED && defined(_WIN32)\n+        if (functionTable)\n+        {\n+            NtdllLibrary::Instance->DeleteGrowableFunctionTable(functionTable);","path":"lib/Backend/NativeCodeGenerator.cpp","position":37,"original_position":37,"commit_id":"a3e1c800a29be5fc1e472fa1dbc8fc6bca2d971a","original_commit_id":"a3e1c800a29be5fc1e472fa1dbc8fc6bca2d971a","user":{"login":"MikeHolman","id":4925255,"avatar_url":"https://avatars3.githubusercontent.com/u/4925255?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeHolman","html_url":"https://github.com/MikeHolman","followers_url":"https://api.github.com/users/MikeHolman/followers","following_url":"https://api.github.com/users/MikeHolman/following{/other_user}","gists_url":"https://api.github.com/users/MikeHolman/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeHolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeHolman/subscriptions","organizations_url":"https://api.github.com/users/MikeHolman/orgs","repos_url":"https://api.github.com/users/MikeHolman/repos","events_url":"https://api.github.com/users/MikeHolman/events{/privacy}","received_events_url":"https://api.github.com/users/MikeHolman/received_events","type":"User","site_admin":false},"body":"i think we can only do this on win8+?","created_at":"2017-12-20T00:04:20Z","updated_at":"2017-12-20T00:04:20Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/4448#discussion_r157908201","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/157908201"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4448#discussion_r157908201"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448","id":159297830,"html_url":"https://github.com/Microsoft/ChakraCore/pull/4448","diff_url":"https://github.com/Microsoft/ChakraCore/pull/4448.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/4448.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4448","number":4448,"state":"open","locked":false,"title":"Delete function table in background thread","user":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars3.githubusercontent.com/u/15365664?v=4","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"body":"RtlDeleteGrowableFunctionTable is slow. when cleaning up large amount of function\nentry points in UI thread it can causes a busy hang. Moving this call to background\ntogether with freeing jit code allocation.\n","created_at":"2017-12-19T23:32:52Z","updated_at":"2017-12-20T00:04:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed23c501a10315d34589908199640bf78bd91b7b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LouisLaf","id":12550583,"avatar_url":"https://avatars3.githubusercontent.com/u/12550583?v=4","gravatar_id":"","url":"https://api.github.com/users/LouisLaf","html_url":"https://github.com/LouisLaf","followers_url":"https://api.github.com/users/LouisLaf/followers","following_url":"https://api.github.com/users/LouisLaf/following{/other_user}","gists_url":"https://api.github.com/users/LouisLaf/gists{/gist_id}","starred_url":"https://api.github.com/users/LouisLaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LouisLaf/subscriptions","organizations_url":"https://api.github.com/users/LouisLaf/orgs","repos_url":"https://api.github.com/users/LouisLaf/repos","events_url":"https://api.github.com/users/LouisLaf/events{/privacy}","received_events_url":"https://api.github.com/users/LouisLaf/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4448/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/a3e1c800a29be5fc1e472fa1dbc8fc6bca2d971a","head":{"label":"leirocks:delft","ref":"delft","sha":"a3e1c800a29be5fc1e472fa1dbc8fc6bca2d971a","user":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars3.githubusercontent.com/u/15365664?v=4","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"repo":{"id":49605998,"name":"ChakraCore","full_name":"leirocks/ChakraCore","owner":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars3.githubusercontent.com/u/15365664?v=4","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leirocks/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/leirocks/ChakraCore","forks_url":"https://api.github.com/repos/leirocks/ChakraCore/forks","keys_url":"https://api.github.com/repos/leirocks/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leirocks/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leirocks/ChakraCore/teams","hooks_url":"https://api.github.com/repos/leirocks/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/leirocks/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/leirocks/ChakraCore/events","assignees_url":"https://api.github.com/repos/leirocks/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/leirocks/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/leirocks/ChakraCore/tags","blobs_url":"https://api.github.com/repos/leirocks/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leirocks/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leirocks/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/leirocks/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leirocks/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/leirocks/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/leirocks/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/leirocks/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/leirocks/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/leirocks/ChakraCore/subscription","commits_url":"https://api.github.com/repos/leirocks/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/leirocks/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/leirocks/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/leirocks/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/leirocks/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/leirocks/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leirocks/ChakraCore/merges","archive_url":"https://api.github.com/repos/leirocks/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leirocks/ChakraCore/downloads","issues_url":"https://api.github.com/repos/leirocks/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/leirocks/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/leirocks/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/leirocks/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leirocks/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/leirocks/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/leirocks/ChakraCore/deployments","created_at":"2016-01-13T22:22:27Z","updated_at":"2016-01-13T22:52:58Z","pushed_at":"2017-12-19T23:46:43Z","git_url":"git://github.com/leirocks/ChakraCore.git","ssh_url":"git@github.com:leirocks/ChakraCore.git","clone_url":"https://github.com/leirocks/ChakraCore.git","svn_url":"https://github.com/leirocks/ChakraCore","homepage":null,"size":76983,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:release/1.8","ref":"release/1.8","sha":"baaf993253c07fa756e3ce5d69eebec1a425e482","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2017-12-19T17:59:17Z","pushed_at":"2017-12-20T00:01:32Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":99516,"stargazers_count":6619,"watchers_count":6619,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":837,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":837,"open_issues":387,"watchers":6619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4448"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4448"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4448/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4448/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/a3e1c800a29be5fc1e472fa1dbc8fc6bca2d971a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MikeHolman"}}