{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/111018059","pull_request_review_id":32232804,"id":111018059,"diff_hunk":"@@ -12,21 +12,30 @@ public class NumberFormatInfoPercentNegativePattern\n     {\n         public static IEnumerable<object[]> PercentNegativePattern_TestData()\n         {\n-            yield return new object[] { NumberFormatInfo.InvariantInfo, 0, 0 };\n-            yield return new object[] { new CultureInfo(\"en-US\").NumberFormat, 0, 1 };\n-            yield return new object[] { new CultureInfo(\"en-MY\").NumberFormat, 1, 1 };\n-            yield return new object[] { new CultureInfo(\"tr\").NumberFormat, 2, 2 };\n+            yield return new object[] { new CultureInfo(\"en-US\").NumberFormat, 1 };\n+            yield return new object[] { new CultureInfo(\"en-MY\").NumberFormat, 1 };\n+            yield return new object[] { new CultureInfo(\"tr\").NumberFormat, 2 };\n         }\n \n+        /// <summary>\n+        /// Not testing for Windows as the culture data can change\n+        /// https://blogs.msdn.microsoft.com/shawnste/2005/04/05/culture-data-shouldnt-be-considered-stable-except-for-invariant/\n+        /// </summary>\n         [Theory]\n+        [PlatformSpecific(TestPlatforms.AnyUnix)]\n         [MemberData(nameof(PercentNegativePattern_TestData))]\n-        public void PercentNegativePattern_Get(NumberFormatInfo format, int expectedWindows, int expectedIcu)\n+        public void PercentNegativePattern_Get(NumberFormatInfo format, int expected)\n         {\n-            int expected = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? expectedWindows : expectedIcu;\n             Assert.Equal(expected, format.PercentNegativePattern);\n         }\n \n         [Theory]","path":"src/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoPercentNegativePattern.cs","position":27,"original_position":27,"commit_id":"3409e8aa5b20a71bfae8ed8526fb7d015dd9c6e0","original_commit_id":"3409e8aa5b20a71bfae8ed8526fb7d015dd9c6e0","user":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars1.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"body":"should make this one as Fact?","created_at":"2017-04-11T21:29:10Z","updated_at":"2017-04-11T21:29:10Z","html_url":"https://github.com/dotnet/corefx/pull/18228#discussion_r111018059","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/18228","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/111018059"},"html":{"href":"https://github.com/dotnet/corefx/pull/18228#discussion_r111018059"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18228"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/18228","id":115418526,"html_url":"https://github.com/dotnet/corefx/pull/18228","diff_url":"https://github.com/dotnet/corefx/pull/18228.diff","patch_url":"https://github.com/dotnet/corefx/pull/18228.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/18228","number":18228,"state":"open","locked":false,"title":"Removed static test values for cultures which could change, e.g. Win1…","user":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"body":"…0 Insider builds\r\n\r\nfixes https://github.com/dotnet/corefx/issues/18208","created_at":"2017-04-11T21:25:36Z","updated_at":"2017-04-11T21:29:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8910b9de79d273309e3d24025a785678df9c4c40","assignee":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestone/4","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"2.0.0","description":".NET Core 2.0 next major release\r\nhttps://github.com/dotnet/core/blob/master/roadmap.md\r\n\r\nNote: Previously known as 1.2.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars2.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":264,"closed_issues":6504,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2017-04-11T21:25:36Z","due_on":"2017-05-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/18228/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/18228/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/18228/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3409e8aa5b20a71bfae8ed8526fb7d015dd9c6e0","head":{"label":"ViktorHofer:issue-18208","ref":"issue-18208","sha":"3409e8aa5b20a71bfae8ed8526fb7d015dd9c6e0","user":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"repo":{"id":85503956,"name":"corefx","full_name":"ViktorHofer/corefx","owner":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ViktorHofer/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ViktorHofer/corefx","forks_url":"https://api.github.com/repos/ViktorHofer/corefx/forks","keys_url":"https://api.github.com/repos/ViktorHofer/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ViktorHofer/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ViktorHofer/corefx/teams","hooks_url":"https://api.github.com/repos/ViktorHofer/corefx/hooks","issue_events_url":"https://api.github.com/repos/ViktorHofer/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ViktorHofer/corefx/events","assignees_url":"https://api.github.com/repos/ViktorHofer/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ViktorHofer/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ViktorHofer/corefx/tags","blobs_url":"https://api.github.com/repos/ViktorHofer/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ViktorHofer/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ViktorHofer/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ViktorHofer/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ViktorHofer/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ViktorHofer/corefx/languages","stargazers_url":"https://api.github.com/repos/ViktorHofer/corefx/stargazers","contributors_url":"https://api.github.com/repos/ViktorHofer/corefx/contributors","subscribers_url":"https://api.github.com/repos/ViktorHofer/corefx/subscribers","subscription_url":"https://api.github.com/repos/ViktorHofer/corefx/subscription","commits_url":"https://api.github.com/repos/ViktorHofer/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ViktorHofer/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ViktorHofer/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ViktorHofer/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ViktorHofer/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ViktorHofer/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ViktorHofer/corefx/merges","archive_url":"https://api.github.com/repos/ViktorHofer/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ViktorHofer/corefx/downloads","issues_url":"https://api.github.com/repos/ViktorHofer/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ViktorHofer/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ViktorHofer/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ViktorHofer/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ViktorHofer/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ViktorHofer/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ViktorHofer/corefx/deployments","created_at":"2017-03-19T19:49:18Z","updated_at":"2017-03-19T19:49:56Z","pushed_at":"2017-04-11T21:24:02Z","git_url":"git://github.com/ViktorHofer/corefx.git","ssh_url":"git@github.com:ViktorHofer/corefx.git","clone_url":"https://github.com/ViktorHofer/corefx.git","svn_url":"https://github.com/ViktorHofer/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":139446,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f630d05fda271687875e06a163af7543fb68d27b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-04-11T21:08:40Z","pushed_at":"2017-04-11T21:25:37Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":139779,"stargazers_count":11562,"watchers_count":11562,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3040,"mirror_url":null,"open_issues_count":1427,"forks":3040,"open_issues":1427,"watchers":11562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18228"},"html":{"href":"https://github.com/dotnet/corefx/pull/18228"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18228"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18228/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18228/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18228/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3409e8aa5b20a71bfae8ed8526fb7d015dd9c6e0"}}}}
{"actor":{"display_login":"tarekgh"}}