{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-core/pulls/comments/112565042","pull_request_review_id":33891264,"id":112565042,"diff_hunk":"@@ -867,6 +870,8 @@ ref_type SlabAlloc::attach_file(const std::string& file_path, Config& cfg)\n                 m_baseline = size;\n                 m_initial_chunk_size = size;\n                 m_file_mappings->m_first_additional_mapping = get_section_index(m_initial_chunk_size);\n+\n+                realm::util::encryption_read_barrier(m_file_mappings->m_initial_mapping, 0, sizeof(Header));","path":"src/realm/alloc_slab.cpp","position":77,"original_position":77,"commit_id":"b002957495683bee091742cce39623060eb80ed1","original_commit_id":"b002957495683bee091742cce39623060eb80ed1","user":{"login":"ironage","id":2826060,"avatar_url":"https://avatars1.githubusercontent.com/u/2826060?v=3","gravatar_id":"","url":"https://api.github.com/users/ironage","html_url":"https://github.com/ironage","followers_url":"https://api.github.com/users/ironage/followers","following_url":"https://api.github.com/users/ironage/following{/other_user}","gists_url":"https://api.github.com/users/ironage/gists{/gist_id}","starred_url":"https://api.github.com/users/ironage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironage/subscriptions","organizations_url":"https://api.github.com/users/ironage/orgs","repos_url":"https://api.github.com/users/ironage/repos","events_url":"https://api.github.com/users/ironage/events{/privacy}","received_events_url":"https://api.github.com/users/ironage/received_events","type":"User","site_admin":false},"body":"Don't you want to use `encryption_write_barrier()` instead?","created_at":"2017-04-20T21:28:00Z","updated_at":"2017-04-20T21:28:00Z","html_url":"https://github.com/realm/realm-core/pull/2575#discussion_r112565042","pull_request_url":"https://api.github.com/repos/realm/realm-core/pulls/2575","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-core/pulls/comments/112565042"},"html":{"href":"https://github.com/realm/realm-core/pull/2575#discussion_r112565042"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2575"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-core/pulls/2575","id":116300442,"html_url":"https://github.com/realm/realm-core/pull/2575","diff_url":"https://github.com/realm/realm-core/pull/2575.diff","patch_url":"https://github.com/realm/realm-core/pull/2575.patch","issue_url":"https://api.github.com/repos/realm/realm-core/issues/2575","number":2575,"state":"open","locked":false,"title":"Remove file format version handling from allocator","user":{"login":"jedelbo","id":572755,"avatar_url":"https://avatars1.githubusercontent.com/u/572755?v=3","gravatar_id":"","url":"https://api.github.com/users/jedelbo","html_url":"https://github.com/jedelbo","followers_url":"https://api.github.com/users/jedelbo/followers","following_url":"https://api.github.com/users/jedelbo/following{/other_user}","gists_url":"https://api.github.com/users/jedelbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jedelbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedelbo/subscriptions","organizations_url":"https://api.github.com/users/jedelbo/orgs","repos_url":"https://api.github.com/users/jedelbo/repos","events_url":"https://api.github.com/users/jedelbo/events{/privacy}","received_events_url":"https://api.github.com/users/jedelbo/received_events","type":"User","site_admin":false},"body":"Confine the handling of file format version to the Group/SharedGroup\r\ncomplex. There is no logic in having the allocator involved in this.","created_at":"2017-04-18T10:50:14Z","updated_at":"2017-04-20T21:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"493153470e22b7aa60e14e5d862655ad157d2ce9","assignee":{"login":"jedelbo","id":572755,"avatar_url":"https://avatars1.githubusercontent.com/u/572755?v=3","gravatar_id":"","url":"https://api.github.com/users/jedelbo","html_url":"https://github.com/jedelbo","followers_url":"https://api.github.com/users/jedelbo/followers","following_url":"https://api.github.com/users/jedelbo/following{/other_user}","gists_url":"https://api.github.com/users/jedelbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jedelbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedelbo/subscriptions","organizations_url":"https://api.github.com/users/jedelbo/orgs","repos_url":"https://api.github.com/users/jedelbo/repos","events_url":"https://api.github.com/users/jedelbo/events{/privacy}","received_events_url":"https://api.github.com/users/jedelbo/received_events","type":"User","site_admin":false},"assignees":[{"login":"jedelbo","id":572755,"avatar_url":"https://avatars1.githubusercontent.com/u/572755?v=3","gravatar_id":"","url":"https://api.github.com/users/jedelbo","html_url":"https://github.com/jedelbo","followers_url":"https://api.github.com/users/jedelbo/followers","following_url":"https://api.github.com/users/jedelbo/following{/other_user}","gists_url":"https://api.github.com/users/jedelbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jedelbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedelbo/subscriptions","organizations_url":"https://api.github.com/users/jedelbo/orgs","repos_url":"https://api.github.com/users/jedelbo/repos","events_url":"https://api.github.com/users/jedelbo/events{/privacy}","received_events_url":"https://api.github.com/users/jedelbo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-core/pulls/2575/commits","review_comments_url":"https://api.github.com/repos/realm/realm-core/pulls/2575/comments","review_comment_url":"https://api.github.com/repos/realm/realm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-core/issues/2575/comments","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/b002957495683bee091742cce39623060eb80ed1","head":{"label":"realm:jed/file-format-version","ref":"jed/file-format-version","sha":"b002957495683bee091742cce39623060eb80ed1","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":1917262,"name":"realm-core","full_name":"realm/realm-core","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-core","description":"Core database component for the Realm Mobile Database SDKs","fork":false,"url":"https://api.github.com/repos/realm/realm-core","forks_url":"https://api.github.com/repos/realm/realm-core/forks","keys_url":"https://api.github.com/repos/realm/realm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-core/teams","hooks_url":"https://api.github.com/repos/realm/realm-core/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-core/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-core/events","assignees_url":"https://api.github.com/repos/realm/realm-core/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-core/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-core/tags","blobs_url":"https://api.github.com/repos/realm/realm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-core/languages","stargazers_url":"https://api.github.com/repos/realm/realm-core/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-core/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-core/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-core/subscription","commits_url":"https://api.github.com/repos/realm/realm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-core/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-core/merges","archive_url":"https://api.github.com/repos/realm/realm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-core/downloads","issues_url":"https://api.github.com/repos/realm/realm-core/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-core/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-core/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-core/deployments","created_at":"2011-06-18T21:18:46Z","updated_at":"2017-04-17T13:42:24Z","pushed_at":"2017-04-20T18:18:29Z","git_url":"git://github.com/realm/realm-core.git","ssh_url":"git@github.com:realm/realm-core.git","clone_url":"https://github.com/realm/realm-core.git","svn_url":"https://github.com/realm/realm-core","homepage":"https://realm.io","size":50766,"stargazers_count":531,"watchers_count":531,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":199,"forks":30,"open_issues":199,"watchers":531,"default_branch":"master"}},"base":{"label":"realm:develop","ref":"develop","sha":"409ed3385ded32a39384293fcc01d95334f0d8c3","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":1917262,"name":"realm-core","full_name":"realm/realm-core","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-core","description":"Core database component for the Realm Mobile Database SDKs","fork":false,"url":"https://api.github.com/repos/realm/realm-core","forks_url":"https://api.github.com/repos/realm/realm-core/forks","keys_url":"https://api.github.com/repos/realm/realm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-core/teams","hooks_url":"https://api.github.com/repos/realm/realm-core/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-core/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-core/events","assignees_url":"https://api.github.com/repos/realm/realm-core/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-core/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-core/tags","blobs_url":"https://api.github.com/repos/realm/realm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-core/languages","stargazers_url":"https://api.github.com/repos/realm/realm-core/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-core/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-core/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-core/subscription","commits_url":"https://api.github.com/repos/realm/realm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-core/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-core/merges","archive_url":"https://api.github.com/repos/realm/realm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-core/downloads","issues_url":"https://api.github.com/repos/realm/realm-core/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-core/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-core/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-core/deployments","created_at":"2011-06-18T21:18:46Z","updated_at":"2017-04-17T13:42:24Z","pushed_at":"2017-04-20T18:18:29Z","git_url":"git://github.com/realm/realm-core.git","ssh_url":"git@github.com:realm/realm-core.git","clone_url":"https://github.com/realm/realm-core.git","svn_url":"https://github.com/realm/realm-core","homepage":"https://realm.io","size":50766,"stargazers_count":531,"watchers_count":531,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":199,"forks":30,"open_issues":199,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2575"},"html":{"href":"https://github.com/realm/realm-core/pull/2575"},"issue":{"href":"https://api.github.com/repos/realm/realm-core/issues/2575"},"comments":{"href":"https://api.github.com/repos/realm/realm-core/issues/2575/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2575/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2575/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-core/statuses/b002957495683bee091742cce39623060eb80ed1"}}}}
{"actor":{"display_login":"ironage"}}