{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/94341078","pull_request_review_id":14867752,"id":94341078,"diff_hunk":"@@ -117,6 +117,11 @@ func makeStatefulSetSpec(a *spec.Alertmanager) v1beta1.StatefulSetSpec {\n \t\tfmt.Sprintf(\"-mesh.listen-address=:%d\", 6783),\n \t\tfmt.Sprintf(\"-storage.path=%s\", \"/etc/alertmanager/data\"),\n \t}\n+\n+\tif a.Spec.ExternalUrl != \"\" {","path":"pkg/alertmanager/statefulset.go","position":5,"original_position":5,"commit_id":"21e342bcea8ca12b5d7431a1c194365bdb412818","original_commit_id":"21e342bcea8ca12b5d7431a1c194365bdb412818","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"`ExternalURL`.","created_at":"2017-01-02T19:24:31Z","updated_at":"2017-01-02T19:26:55Z","html_url":"https://github.com/coreos/prometheus-operator/pull/80#discussion_r94341078","pull_request_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/94341078"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/80#discussion_r94341078"},"pull_request":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80","id":99871708,"html_url":"https://github.com/coreos/prometheus-operator/pull/80","diff_url":"https://github.com/coreos/prometheus-operator/pull/80.diff","patch_url":"https://github.com/coreos/prometheus-operator/pull/80.patch","issue_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/80","number":80,"state":"open","locked":false,"title":"External url","user":{"login":"brancz","id":4546722,"avatar_url":"https://avatars.githubusercontent.com/u/4546722?v=3","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"body":"@alexsomesan @fabxc \r\n\r\nTested with minikube. And the following manifests (replacing the manifests from `kube-prometheus`).\r\n\r\nPrometheus:\r\n\r\n```\r\napiVersion: monitoring.coreos.com/v1alpha1\r\nkind: Prometheus\r\nmetadata:\r\n  name: prometheus-k8s\r\n  labels:\r\n    prometheus: k8s\r\nspec:\r\n  version: v1.4.1\r\n  externalUrl: http://192.168.99.100:30900/prometheus\r\n  resources:\r\n    requests:\r\n      memory: 400Mi\r\n```\r\n\r\nAlertmanager:\r\n\r\n```\r\napiVersion: \"monitoring.coreos.com/v1alpha1\"\r\nkind: \"Alertmanager\"\r\nmetadata:\r\n  name: \"alertmanager-main\"\r\n  labels:\r\n    alertmanager: \"main\"\r\nspec:\r\n  replicas: 3\r\n  version: v0.5.1\r\n  externalUrl: http://192.168.99.100:30903/alertmanager\r\n```\r\n\r\nFixes #26 ","created_at":"2017-01-02T15:12:41Z","updated_at":"2017-01-02T19:26:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"372e285afad06e8a5110eba40943b5ade1bff3ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80/commits","review_comments_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80/comments","review_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/80/comments","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/21e342bcea8ca12b5d7431a1c194365bdb412818","head":{"label":"brancz:external-url","ref":"external-url","sha":"21e342bcea8ca12b5d7431a1c194365bdb412818","user":{"login":"brancz","id":4546722,"avatar_url":"https://avatars.githubusercontent.com/u/4546722?v=3","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"repo":{"id":72764023,"name":"prometheus-operator","full_name":"brancz/prometheus-operator","owner":{"login":"brancz","id":4546722,"avatar_url":"https://avatars.githubusercontent.com/u/4546722?v=3","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brancz/prometheus-operator","description":null,"fork":true,"url":"https://api.github.com/repos/brancz/prometheus-operator","forks_url":"https://api.github.com/repos/brancz/prometheus-operator/forks","keys_url":"https://api.github.com/repos/brancz/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brancz/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brancz/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/brancz/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/brancz/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/brancz/prometheus-operator/events","assignees_url":"https://api.github.com/repos/brancz/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/brancz/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/brancz/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/brancz/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brancz/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brancz/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/brancz/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brancz/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/brancz/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/brancz/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/brancz/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/brancz/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/brancz/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/brancz/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/brancz/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/brancz/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/brancz/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/brancz/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/brancz/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brancz/prometheus-operator/merges","archive_url":"https://api.github.com/repos/brancz/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brancz/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/brancz/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/brancz/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/brancz/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/brancz/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brancz/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/brancz/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/brancz/prometheus-operator/deployments","created_at":"2016-11-03T16:19:53Z","updated_at":"2016-11-03T16:19:54Z","pushed_at":"2017-01-02T15:38:07Z","git_url":"git://github.com/brancz/prometheus-operator.git","ssh_url":"git@github.com:brancz/prometheus-operator.git","clone_url":"https://github.com/brancz/prometheus-operator.git","svn_url":"https://github.com/brancz/prometheus-operator","homepage":null,"size":4206,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"0954dab775a98760efd60772ab8d89733af5cc94","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":68964263,"name":"prometheus-operator","full_name":"coreos/prometheus-operator","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/prometheus-operator","forks_url":"https://api.github.com/repos/coreos/prometheus-operator/forks","keys_url":"https://api.github.com/repos/coreos/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/coreos/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/prometheus-operator/events","assignees_url":"https://api.github.com/repos/coreos/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/coreos/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/prometheus-operator/merges","archive_url":"https://api.github.com/repos/coreos/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/coreos/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/prometheus-operator/deployments","created_at":"2016-09-22T21:38:06Z","updated_at":"2017-01-01T09:49:23Z","pushed_at":"2017-01-02T15:58:22Z","git_url":"git://github.com/coreos/prometheus-operator.git","ssh_url":"git@github.com:coreos/prometheus-operator.git","clone_url":"https://github.com/coreos/prometheus-operator.git","svn_url":"https://github.com/coreos/prometheus-operator","homepage":"https://coreos.com/blog/the-prometheus-operator.html","size":4205,"stargazers_count":108,"watchers_count":108,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/80"},"issue":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/80"},"comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/prometheus-operator/statuses/21e342bcea8ca12b5d7431a1c194365bdb412818"}}}}
{"actor":{"display_login":"fabxc"}}