{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/5538","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/5538/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/5538/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/5538/events","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/5538","id":228373775,"number":5538,"title":"Strip down builds for Heroku","user":{"login":"robertfairhead","id":6646098,"avatar_url":"https://avatars2.githubusercontent.com/u/6646098?v=3","gravatar_id":"","url":"https://api.github.com/users/robertfairhead","html_url":"https://github.com/robertfairhead","followers_url":"https://api.github.com/users/robertfairhead/followers","following_url":"https://api.github.com/users/robertfairhead/following{/other_user}","gists_url":"https://api.github.com/users/robertfairhead/gists{/gist_id}","starred_url":"https://api.github.com/users/robertfairhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertfairhead/subscriptions","organizations_url":"https://api.github.com/users/robertfairhead/orgs","repos_url":"https://api.github.com/users/robertfairhead/repos","events_url":"https://api.github.com/users/robertfairhead/events{/privacy}","received_events_url":"https://api.github.com/users/robertfairhead/received_events","type":"User","site_admin":false},"labels":[{"id":314912936,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels/in%20progress","name":"in progress","color":"5319e7","default":false},{"id":589054837,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels/nebula","name":"nebula","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"robertfairhead","id":6646098,"avatar_url":"https://avatars2.githubusercontent.com/u/6646098?v=3","gravatar_id":"","url":"https://api.github.com/users/robertfairhead","html_url":"https://github.com/robertfairhead","followers_url":"https://api.github.com/users/robertfairhead/followers","following_url":"https://api.github.com/users/robertfairhead/following{/other_user}","gists_url":"https://api.github.com/users/robertfairhead/gists{/gist_id}","starred_url":"https://api.github.com/users/robertfairhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertfairhead/subscriptions","organizations_url":"https://api.github.com/users/robertfairhead/orgs","repos_url":"https://api.github.com/users/robertfairhead/repos","events_url":"https://api.github.com/users/robertfairhead/events{/privacy}","received_events_url":"https://api.github.com/users/robertfairhead/received_events","type":"User","site_admin":false},"assignees":[{"login":"robertfairhead","id":6646098,"avatar_url":"https://avatars2.githubusercontent.com/u/6646098?v=3","gravatar_id":"","url":"https://api.github.com/users/robertfairhead","html_url":"https://github.com/robertfairhead","followers_url":"https://api.github.com/users/robertfairhead/followers","following_url":"https://api.github.com/users/robertfairhead/following{/other_user}","gists_url":"https://api.github.com/users/robertfairhead/gists{/gist_id}","starred_url":"https://api.github.com/users/robertfairhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertfairhead/subscriptions","organizations_url":"https://api.github.com/users/robertfairhead/orgs","repos_url":"https://api.github.com/users/robertfairhead/repos","events_url":"https://api.github.com/users/robertfairhead/events{/privacy}","received_events_url":"https://api.github.com/users/robertfairhead/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-05-12T18:36:12Z","updated_at":"2017-05-12T19:45:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/5538","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/5538","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/5538.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/5538.patch"},"body":"Closes https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2762\r\n\r\nCreates a build-unsafe script which strips down the metalsmith build steps and a webpack.heroku.js config that skips building all the React modules.\r\n\r\nOn my machine the striped down build runs in 44 seconds. The full build runs in about 4 minutes showing a roughly 5x speed improvement.\r\n\r\nI always tweaked the procfile to run `npm rebuild node-sass` after every push to try to resolve the missing file descriptor errors we've been having since running once on post-install didn't seem to lick it.\r\n\r\nMerging this will await discussion at the next Engineering meeting to make sure skipping the React builds (to focus on content and styling) won't wreak any workflows. /cc @ayaleloehr @rroueche "},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments/301169113","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/5538#issuecomment-301169113","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/5538","id":301169113,"user":{"login":"robertfairhead","id":6646098,"avatar_url":"https://avatars2.githubusercontent.com/u/6646098?v=3","gravatar_id":"","url":"https://api.github.com/users/robertfairhead","html_url":"https://github.com/robertfairhead","followers_url":"https://api.github.com/users/robertfairhead/followers","following_url":"https://api.github.com/users/robertfairhead/following{/other_user}","gists_url":"https://api.github.com/users/robertfairhead/gists{/gist_id}","starred_url":"https://api.github.com/users/robertfairhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertfairhead/subscriptions","organizations_url":"https://api.github.com/users/robertfairhead/orgs","repos_url":"https://api.github.com/users/robertfairhead/repos","events_url":"https://api.github.com/users/robertfairhead/events{/privacy}","received_events_url":"https://api.github.com/users/robertfairhead/received_events","type":"User","site_admin":false},"created_at":"2017-05-12T19:45:45Z","updated_at":"2017-05-12T19:45:45Z","body":"I can add the React builds back in. I figured this would make what I meant by \"fast path\" more clear. Basically only build the static content. The heroku builds don't connect to any backends. So it's basically the same as running off localhost for development purposes. The API is mocked out.\r\n\r\nThat's why i'd suggest discussing at engineering meeting before doing anything globally to the Heroku builds.\r\n\r\nWe can determine WIP content PRs and only send those down the fast path to give the content team the quicker turnaround they want.\r\n\r\nWith respect to duplication, we can either factor the shared sections into a common JS file or I could just add in selective buildtype wrappers in the original file to skip the unneeded parts. I figured both are refinements we could ship after an initial solution (whatever that ends up being). I wanted to avoid messing with the standard build configs at this point while this is in flux to avoid borking any Jenkins builds."}}
{"actor":{"display_login":"robertfairhead"}}