{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/123823881","pull_request_review_id":46067702,"id":123823881,"diff_hunk":"@@ -80,9 +80,9 @@ public void Adding_method_fluent_only_convention_defaults()\n             var modelBuilder = GetModelBuilder();\n \n             var dbFuncBuilder = modelBuilder.HasDbFunction(MethodAmi);\n-            var dbFunc = dbFuncBuilder.Metadata;\n+            var dbFunc = dbFuncBuilder.Metadata as DbFunction;","path":"test/EFCore.Relational.Tests/Metadata/DbFunctionMetadataTests.cs","position":25,"original_position":25,"commit_id":"a0c24f91e1271e45e062a085821ad6b9ddb15f2e","original_commit_id":"a0c24f91e1271e45e062a085821ad6b9ddb15f2e","user":{"login":"smitpatel","id":1528107,"avatar_url":"https://avatars3.githubusercontent.com/u/1528107?v=3","gravatar_id":"","url":"https://api.github.com/users/smitpatel","html_url":"https://github.com/smitpatel","followers_url":"https://api.github.com/users/smitpatel/followers","following_url":"https://api.github.com/users/smitpatel/following{/other_user}","gists_url":"https://api.github.com/users/smitpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/smitpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smitpatel/subscriptions","organizations_url":"https://api.github.com/users/smitpatel/orgs","repos_url":"https://api.github.com/users/smitpatel/repos","events_url":"https://api.github.com/users/smitpatel/events{/privacy}","received_events_url":"https://api.github.com/users/smitpatel/received_events","type":"User","site_admin":false},"body":"Indeed. So we should simplify it further.\r\nAlso if user is providing manual translation then name & schema should be absent. We are not strictly enforcing this but they won't be used anyway. ","created_at":"2017-06-23T19:05:49Z","updated_at":"2017-06-23T19:05:49Z","html_url":"https://github.com/aspnet/EntityFramework/pull/8953#discussion_r123823881","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/123823881"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/8953#discussion_r123823881"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953","id":127132239,"html_url":"https://github.com/aspnet/EntityFramework/pull/8953","diff_url":"https://github.com/aspnet/EntityFramework/pull/8953.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/8953.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/8953","number":8953,"state":"open","locked":false,"title":"WIP #8942 - Refactor DbFunctions public api","user":{"login":"pmiddleton","id":11600726,"avatar_url":"https://avatars2.githubusercontent.com/u/11600726?v=3","gravatar_id":"","url":"https://api.github.com/users/pmiddleton","html_url":"https://github.com/pmiddleton","followers_url":"https://api.github.com/users/pmiddleton/followers","following_url":"https://api.github.com/users/pmiddleton/following{/other_user}","gists_url":"https://api.github.com/users/pmiddleton/gists{/gist_id}","starred_url":"https://api.github.com/users/pmiddleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmiddleton/subscriptions","organizations_url":"https://api.github.com/users/pmiddleton/orgs","repos_url":"https://api.github.com/users/pmiddleton/repos","events_url":"https://api.github.com/users/pmiddleton/events{/privacy}","received_events_url":"https://api.github.com/users/pmiddleton/received_events","type":"User","site_admin":false},"body":"Update DBFunctions public api based on #8942","created_at":"2017-06-23T04:24:27Z","updated_at":"2017-06-23T19:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1aa7c8e3eac7188cb94d1e08a364c47ce5bb3f6","assignee":{"login":"anpete","id":1210944,"avatar_url":"https://avatars3.githubusercontent.com/u/1210944?v=3","gravatar_id":"","url":"https://api.github.com/users/anpete","html_url":"https://github.com/anpete","followers_url":"https://api.github.com/users/anpete/followers","following_url":"https://api.github.com/users/anpete/following{/other_user}","gists_url":"https://api.github.com/users/anpete/gists{/gist_id}","starred_url":"https://api.github.com/users/anpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpete/subscriptions","organizations_url":"https://api.github.com/users/anpete/orgs","repos_url":"https://api.github.com/users/anpete/repos","events_url":"https://api.github.com/users/anpete/events{/privacy}","received_events_url":"https://api.github.com/users/anpete/received_events","type":"User","site_admin":false},"assignees":[{"login":"anpete","id":1210944,"avatar_url":"https://avatars3.githubusercontent.com/u/1210944?v=3","gravatar_id":"","url":"https://api.github.com/users/anpete","html_url":"https://github.com/anpete","followers_url":"https://api.github.com/users/anpete/followers","following_url":"https://api.github.com/users/anpete/following{/other_user}","gists_url":"https://api.github.com/users/anpete/gists{/gist_id}","starred_url":"https://api.github.com/users/anpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpete/subscriptions","organizations_url":"https://api.github.com/users/anpete/orgs","repos_url":"https://api.github.com/users/anpete/repos","events_url":"https://api.github.com/users/anpete/events{/privacy}","received_events_url":"https://api.github.com/users/anpete/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/8953/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/a0c24f91e1271e45e062a085821ad6b9ddb15f2e","head":{"label":"pmiddleton:functionApiUpdates","ref":"functionApiUpdates","sha":"a0c24f91e1271e45e062a085821ad6b9ddb15f2e","user":{"login":"pmiddleton","id":11600726,"avatar_url":"https://avatars2.githubusercontent.com/u/11600726?v=3","gravatar_id":"","url":"https://api.github.com/users/pmiddleton","html_url":"https://github.com/pmiddleton","followers_url":"https://api.github.com/users/pmiddleton/followers","following_url":"https://api.github.com/users/pmiddleton/following{/other_user}","gists_url":"https://api.github.com/users/pmiddleton/gists{/gist_id}","starred_url":"https://api.github.com/users/pmiddleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmiddleton/subscriptions","organizations_url":"https://api.github.com/users/pmiddleton/orgs","repos_url":"https://api.github.com/users/pmiddleton/repos","events_url":"https://api.github.com/users/pmiddleton/events{/privacy}","received_events_url":"https://api.github.com/users/pmiddleton/received_events","type":"User","site_admin":false},"repo":{"id":78161346,"name":"EntityFramework","full_name":"pmiddleton/EntityFramework","owner":{"login":"pmiddleton","id":11600726,"avatar_url":"https://avatars2.githubusercontent.com/u/11600726?v=3","gravatar_id":"","url":"https://api.github.com/users/pmiddleton","html_url":"https://github.com/pmiddleton","followers_url":"https://api.github.com/users/pmiddleton/followers","following_url":"https://api.github.com/users/pmiddleton/following{/other_user}","gists_url":"https://api.github.com/users/pmiddleton/gists{/gist_id}","starred_url":"https://api.github.com/users/pmiddleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmiddleton/subscriptions","organizations_url":"https://api.github.com/users/pmiddleton/orgs","repos_url":"https://api.github.com/users/pmiddleton/repos","events_url":"https://api.github.com/users/pmiddleton/events{/privacy}","received_events_url":"https://api.github.com/users/pmiddleton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmiddleton/EntityFramework","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":true,"url":"https://api.github.com/repos/pmiddleton/EntityFramework","forks_url":"https://api.github.com/repos/pmiddleton/EntityFramework/forks","keys_url":"https://api.github.com/repos/pmiddleton/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmiddleton/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmiddleton/EntityFramework/teams","hooks_url":"https://api.github.com/repos/pmiddleton/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/pmiddleton/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/pmiddleton/EntityFramework/events","assignees_url":"https://api.github.com/repos/pmiddleton/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/pmiddleton/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/pmiddleton/EntityFramework/tags","blobs_url":"https://api.github.com/repos/pmiddleton/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmiddleton/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmiddleton/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmiddleton/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmiddleton/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/pmiddleton/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/pmiddleton/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/pmiddleton/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/pmiddleton/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/pmiddleton/EntityFramework/subscription","commits_url":"https://api.github.com/repos/pmiddleton/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmiddleton/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmiddleton/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmiddleton/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmiddleton/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/pmiddleton/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmiddleton/EntityFramework/merges","archive_url":"https://api.github.com/repos/pmiddleton/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmiddleton/EntityFramework/downloads","issues_url":"https://api.github.com/repos/pmiddleton/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/pmiddleton/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/pmiddleton/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/pmiddleton/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmiddleton/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/pmiddleton/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/pmiddleton/EntityFramework/deployments","created_at":"2017-01-06T01:06:05Z","updated_at":"2017-01-06T01:06:13Z","pushed_at":"2017-06-23T04:32:44Z","git_url":"git://github.com/pmiddleton/EntityFramework.git","ssh_url":"git@github.com:pmiddleton/EntityFramework.git","clone_url":"https://github.com/pmiddleton/EntityFramework.git","svn_url":"https://github.com/pmiddleton/EntityFramework","homepage":"https://docs.efproject.net","size":50966,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"udfSlim2"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"7179154274e52118cb8fc235cbb00f8fdbfed2d5","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/EntityFramework/deployments","created_at":"2014-01-23T00:52:01Z","updated_at":"2017-06-23T14:09:38Z","pushed_at":"2017-06-23T08:06:48Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":"https://docs.microsoft.com/ef/","size":50688,"stargazers_count":4683,"watchers_count":4683,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1379,"mirror_url":null,"open_issues_count":577,"forks":1379,"open_issues":577,"watchers":4683,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/8953"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/8953"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/8953/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8953/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFramework/statuses/a0c24f91e1271e45e062a085821ad6b9ddb15f2e"}}}}
{"actor":{"display_login":"smitpatel"}}