{"action":"closed","issue":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2663","repository_url":"https://api.github.com/repos/DynamoRIO/dynamorio","labels_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2663/labels{/name}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2663/comments","events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2663/events","html_url":"https://github.com/DynamoRIO/dynamorio/issues/2663","id":265916619,"number":2663,"title":"Segfault in ~raw2trace_t when modfule file is not parsed correctly","user":{"login":"Carrotman42","id":570095,"avatar_url":"https://avatars2.githubusercontent.com/u/570095?v=4","gravatar_id":"","url":"https://api.github.com/users/Carrotman42","html_url":"https://github.com/Carrotman42","followers_url":"https://api.github.com/users/Carrotman42/followers","following_url":"https://api.github.com/users/Carrotman42/following{/other_user}","gists_url":"https://api.github.com/users/Carrotman42/gists{/gist_id}","starred_url":"https://api.github.com/users/Carrotman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carrotman42/subscriptions","organizations_url":"https://api.github.com/users/Carrotman42/orgs","repos_url":"https://api.github.com/users/Carrotman42/repos","events_url":"https://api.github.com/users/Carrotman42/events{/privacy}","received_events_url":"https://api.github.com/users/Carrotman42/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Carrotman42","id":570095,"avatar_url":"https://avatars2.githubusercontent.com/u/570095?v=4","gravatar_id":"","url":"https://api.github.com/users/Carrotman42","html_url":"https://github.com/Carrotman42","followers_url":"https://api.github.com/users/Carrotman42/followers","following_url":"https://api.github.com/users/Carrotman42/following{/other_user}","gists_url":"https://api.github.com/users/Carrotman42/gists{/gist_id}","starred_url":"https://api.github.com/users/Carrotman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carrotman42/subscriptions","organizations_url":"https://api.github.com/users/Carrotman42/orgs","repos_url":"https://api.github.com/users/Carrotman42/repos","events_url":"https://api.github.com/users/Carrotman42/events{/privacy}","received_events_url":"https://api.github.com/users/Carrotman42/received_events","type":"User","site_admin":false},"assignees":[{"login":"Carrotman42","id":570095,"avatar_url":"https://avatars2.githubusercontent.com/u/570095?v=4","gravatar_id":"","url":"https://api.github.com/users/Carrotman42","html_url":"https://github.com/Carrotman42","followers_url":"https://api.github.com/users/Carrotman42/followers","following_url":"https://api.github.com/users/Carrotman42/following{/other_user}","gists_url":"https://api.github.com/users/Carrotman42/gists{/gist_id}","starred_url":"https://api.github.com/users/Carrotman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carrotman42/subscriptions","organizations_url":"https://api.github.com/users/Carrotman42/orgs","repos_url":"https://api.github.com/users/Carrotman42/repos","events_url":"https://api.github.com/users/Carrotman42/events{/privacy}","received_events_url":"https://api.github.com/users/Carrotman42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-10-16T21:06:20Z","updated_at":"2017-10-18T23:17:47Z","closed_at":"2017-10-18T23:17:47Z","author_association":"CONTRIBUTOR","body":"`raw2trace_t.modhandle` is only initialized in `raw2trace_t::read_and_map_modules` when `drmodtrack_offline_read` returns successfully, otherwise it is left untouched. In the scenario where `drmodtrack_offline_read` returns an error, the destructor of `raw2trace_t` calls `raw2trace_t::unmap_modules` which calls `drmodtrack_offline_exit`, passing the uninitialized `modhandle` pointer to it. This causes a segfault when `drmodtrack_offline_exit` tries to dereference the pointer.\r\n\r\nI have a simple fix for this, just submitting an issue for tracking purposes."}}
{"actor":{"display_login":"derekbruening"}}