{"push_id":2096034051,"size":12,"distinct_size":12,"ref":"refs/heads/master","head":"91ef133b82b12e5ccc322d584bc9ffb12aef531f","before":"5f0f5987d3ce44b7cfa34789da48fa3c5d8ddfbc","commits":[{"sha":"c5640067280df306412ba24ea21e85d15406b1cf","author":{"name":"Alan Orth","email":"6bae802e3af8ec377f65e9658ab699f698726a4a@gmail.com"},"message":"README.md: Fix link to \"good first issue\" label\n\nLooking at the labels of closed issues, it appears that the project is\nactually using \"good first issue\" as the label for issues that would\nbe good for new contributors. The README suggests that good issues for\nwould-be new contributors are labeled \"good first bug\".","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/c5640067280df306412ba24ea21e85d15406b1cf"},{"sha":"48054aed425117741d3c68a602ebc0bddcab132a","author":{"name":"Sebastian Kaspari","email":"0b02a9d9f789d190c064880c376e6853a0ed8890@gmail.com"},"message":"Import translations from L10N repository. (#1572)","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/48054aed425117741d3c68a602ebc0bddcab132a"},{"sha":"0ada32f4cdb8a80255bbb5f31ef0a5f7d643b562","author":{"name":"Emily Kager","email":"936c68105edac4896fca36bc3d181945001efa52@mills.edu"},"message":"CSS workaround to clear visited link color (#1392)","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/0ada32f4cdb8a80255bbb5f31ef0a5f7d643b562"},{"sha":"6ba3d1b9d58f1abd55f98f0d073acc76f89a374f","author":{"name":"Sebastian Kaspari","email":"0b02a9d9f789d190c064880c376e6853a0ed8890@gmail.com"},"message":"Update licenses file. (#1271)\n\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1400284","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/6ba3d1b9d58f1abd55f98f0d073acc76f89a374f"},{"sha":"88aedf3b1e4eb04a1d3e72e735132a8143d27a77","author":{"name":"Michael Comella","email":"caa8d3861eff69c4405d7fa53fa9aba6b14d3516@gmail.com"},"message":"Convert FileUtils to Kotlin.\n\nI tested this by verifying WebViewDataTest still passes successfully.","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/88aedf3b1e4eb04a1d3e72e735132a8143d27a77"},{"sha":"16129cc35cc82fcecb9f3a2cf8afbe2f79eb9cc8","author":{"name":"Michael Comella","email":"caa8d3861eff69c4405d7fa53fa9aba6b14d3516@gmail.com"},"message":"Issue #1306: Do not erase WebView's Local Storage directory; fix test.\n\nThis fixes the user experienced issue where Google Search History is not erased.\nHowever, the google search result page restores a google.com file in the \"Local\nStorage\" directory so not all data on disk is actually deleted. I'll tackle this\nin a later commit.\n\nI verified that the correct files were deleted via WebViewDataTest.","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/16129cc35cc82fcecb9f3a2cf8afbe2f79eb9cc8"},{"sha":"8af3720bb3383d1c3906aca0982f7ea5ebe8ca3d","author":{"name":"Michael Comella","email":"caa8d3861eff69c4405d7fa53fa9aba6b14d3516@gmail.com"},"message":"Closes #1306: Delete local storage when starting a new browser session.\n\nThis code is hacky: see below.\n\nWe run clean-up on the main thread in order to guarantee we don't accidentally\ndelete current session data if we run asynchronously. I haven't seen any\nproblems with this locally but I'm running in an emulator. Alternative solutions\nwould be:\n1. Find another place to delete (UrlInputFragment.onFilter worked before)\n2. Run this on a background thread and run the fragment methods after (may need\nto then run those on the UIThread). This would at least free the main thread\nfor UI events.\n\nIt creates more inconsistent confusion in our erase strategy. We should revise\nthis in #1472.","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/8af3720bb3383d1c3906aca0982f7ea5ebe8ca3d"},{"sha":"906edfbc1658dba683e58df55650645136858284","author":{"name":"Michael Comella","email":"caa8d3861eff69c4405d7fa53fa9aba6b14d3516@gmail.com"},"message":"Closes #1306 - review: Suppress findbugs warning BC_BAD_CAST_TO_ABSTRACT_COLLECTION.\n\nCopied from https://github.com/mozilla-mobile/focus-android/pull/1555#issuecomment-339365588:\n\n> https://public-artifacts.taskcluster.net/S_gwYP5cR2C0eVCnS06xZQ/0/public/findbugs/findbugs.html\n\nThe error is `BC_BAD_CAST_TO_ABSTRACT_COLLECTION`\n\n>  Questionable cast from Collection to abstract class java.util.List  in org.mozilla.focus.utils.FileUtils$Companion.deleteContent(File, Set)\n\nLooking at the decompiled bytecode from Kotlin:\n\n```java\n            Collection element$iv = (Collection)(new ArrayList());\n\n            for(int it = 0; it < $receiver$iv$iv.length; ++it) {\n               Object $i$a$1$all = $receiver$iv$iv[it];\n               File $i$f$all = (File)$i$a$1$all;\n               if(!doNotEraseWhitelist.contains($i$f$all.getName())) {\n                  element$iv.add($i$a$1$all);\n               }\n            }\n\n            List filesToDelete = (List)element$iv;\n```\n\nThe corresponding kotlin code is:\n```kotlin\nval filesToDelete = directory.listFiles()?.filter { !doNotEraseWhitelist.contains(it.name) } ?: return false\nreturn filesToDelete.all { it.deleteRecursively() }\n```\n\nSo we're casting to `Collection` to filter but casting back to `List` to store\nthe temporary variable.\n\nIt looks like others have seen this problem: here's [an issue filed for\nfindbugs](https://youtrack.jetbrains.com/issue/KT-18311) and [the issue it was\nduped to](https://youtrack.jetbrains.com/issue/KT-16446). Neither appears to be\nverified by the core maintainers or prioritized (the original issue is filed in\nFeb 2017).\n\nI think the best course of action here is to suppress the error.","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/906edfbc1658dba683e58df55650645136858284"},{"sha":"6bd81c0e141a94302fa4147e79d2f3fb605891a5","author":{"name":"layely","email":"26b514891a6d15efd60b68fe997f096f3fad7498@gmail.com"},"message":"UI polishing: Add to home screen dialog (#1260)","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/6bd81c0e141a94302fa4147e79d2f3fb605891a5"},{"sha":"d527e406118e56e72a4dcc5ce16765141e783b30","author":{"name":"layely","email":"26b514891a6d15efd60b68fe997f096f3fad7498@gmail.com"},"message":"UI polishing: add some shared ressources for dialogs (#1260)\n - dialogHorizontalPadding in Dimens\n - dialogAccent and snackbarActionText in Colors","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/d527e406118e56e72a4dcc5ce16765141e783b30"},{"sha":"49fb2f87b4d6cc30d381965ab56210e42c599080","author":{"name":"Emin Mastizada","email":"9be31a8dec9fc75f894cfdb4cbc48fb46a341f03@mastizada.com"},"message":"Added interlingua (ia) to the list of missing locales","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/49fb2f87b4d6cc30d381965ab56210e42c599080"},{"sha":"91ef133b82b12e5ccc322d584bc9ffb12aef531f","author":{"name":"Sebastian Kaspari","email":"0b02a9d9f789d190c064880c376e6853a0ed8890@gmail.com"},"message":"Import translations from L10N repository. (#1602, #1601)","distinct":true,"url":"https://api.github.com/repos/ekager/focus-android/commits/91ef133b82b12e5ccc322d584bc9ffb12aef531f"}]}
{"actor":{"display_login":"ekager"}}